| *** bobh has joined #openstack-oslo | 00:11 | |
| *** bobh has quit IRC | 00:17 | |
| *** rcernin has quit IRC | 00:30 | |
| *** rcernin has joined #openstack-oslo | 01:45 | |
| *** dave-mccowan has quit IRC | 01:58 | |
| *** bobh has joined #openstack-oslo | 02:37 | |
| *** bobh has quit IRC | 03:14 | |
| *** Luzi has joined #openstack-oslo | 04:48 | |
| *** jaosorior has joined #openstack-oslo | 05:03 | |
| *** e0ne has joined #openstack-oslo | 06:09 | |
| *** jbadiapa has joined #openstack-oslo | 06:13 | |
| *** e0ne has quit IRC | 06:18 | |
| *** snapiri has quit IRC | 06:35 | |
| *** snapiri has joined #openstack-oslo | 06:36 | |
| *** snapiri has quit IRC | 06:36 | |
| *** snapiri has joined #openstack-oslo | 06:49 | |
| *** shachar has joined #openstack-oslo | 06:58 | |
| *** snapiri has quit IRC | 07:00 | |
| *** rcernin has quit IRC | 07:02 | |
| *** trident has quit IRC | 07:10 | |
| *** tesseract has joined #openstack-oslo | 07:13 | |
| *** trident has joined #openstack-oslo | 07:21 | |
| *** hberaud|gone is now known as hberaud | 07:38 | |
| *** pcaruana has joined #openstack-oslo | 07:49 | |
| *** ralonsoh has joined #openstack-oslo | 08:18 | |
| *** e0ne has joined #openstack-oslo | 08:19 | |
| openstackgerrit | Michal Arbet proposed openstack/osprofiler master: Fix osprofiler usage in horizon https://review.opendev.org/630298 | 09:31 |
|---|---|---|
| *** shachar has quit IRC | 09:53 | |
| *** snapiri has joined #openstack-oslo | 09:53 | |
| *** hberaud is now known as hberaud|school-r | 09:54 | |
| *** lpetrut has joined #openstack-oslo | 09:55 | |
| *** hberaud|school-r is now known as hberaud|afk | 10:03 | |
| *** hberaud|afk is now known as hberaud | 10:03 | |
| *** rcernin has joined #openstack-oslo | 10:08 | |
| *** hberaud is now known as hberaud|lunch | 10:48 | |
| *** dave-mccowan has joined #openstack-oslo | 10:52 | |
| *** shachar has joined #openstack-oslo | 11:02 | |
| *** snapiri has quit IRC | 11:03 | |
| *** kgiusti has quit IRC | 11:26 | |
| *** shachar has quit IRC | 11:48 | |
| *** ansmith has quit IRC | 11:51 | |
| *** moguimar has quit IRC | 11:52 | |
| *** goldyfruit has quit IRC | 11:56 | |
| *** boden has joined #openstack-oslo | 11:56 | |
| *** moguimar has joined #openstack-oslo | 12:00 | |
| *** snapiri has joined #openstack-oslo | 12:02 | |
| *** raildo has joined #openstack-oslo | 12:02 | |
| *** hberaud|lunch is now known as hberaud | 12:04 | |
| *** rcernin has quit IRC | 12:22 | |
| *** kgiusti has joined #openstack-oslo | 12:38 | |
| *** ansmith has joined #openstack-oslo | 12:45 | |
| *** e0ne has quit IRC | 13:19 | |
| *** camelCaser has quit IRC | 13:28 | |
| *** Luzi has quit IRC | 13:34 | |
| *** e0ne has joined #openstack-oslo | 13:50 | |
| *** mriedem has joined #openstack-oslo | 13:53 | |
| mriedem | beekneemech: lbragstad: got a question about oslo.policy, | 13:54 |
| *** beekneemech is now known as bnemec | 13:54 | |
| mriedem | when placement was in nova, we had to define a separate policy file for placement since nova used oslo_policy.policy_file, | 13:54 |
| mriedem | now we want to deprecate the placement.policy_file option and use oslo_policy.policy_file, | 13:54 |
| mriedem | but for train need to have compat for the deprecation, | 13:54 |
| mriedem | so i'm poking through oslo.policy trying to figure out the best way to determine if the placement policy file is used or the oslo_policy policy file | 13:55 |
| mriedem | like, would i try to create an Enforcer to load up the rules from the [oslo_policy]/policy_file config and handle any errors and fallback to loading up from [placement]/policy_file? | 13:56 |
| lbragstad | mriedem that's a portion of oslo.policy i'm not entirely familiar with | 13:57 |
| mriedem | i'd think i'd handle some kind of error here https://opendev.org/openstack/placement/src/branch/master/placement/policy.py#L47 | 13:57 |
| mriedem | the docstrings aren't clear about what kind of exceptions can be raised up though | 13:58 |
| mriedem | like OSError if trying to load a policy file and the policy file doesn't exist? | 13:58 |
| lbragstad | but i want to say oslo.policy has the ability to load policies from multiple files (e.g., /etc/nova/policy.d/ | 13:58 |
| lbragstad | ) | 13:58 |
| mriedem | yeah https://docs.openstack.org/oslo.policy/latest/configuration/index.html#oslo_policy.policy_dirs | 13:58 |
| lbragstad | so - you'd want nova to load a placement policy file and use those policies if they are there (because placement also has default policies in code, right) | 13:59 |
| mriedem | not nova, placement | 13:59 |
| bnemec | We don't raise on a missing policy file: https://github.com/openstack/oslo.policy/blob/master/oslo_policy/policy.py#L560 | 14:00 |
| mriedem | bnemec: yeah i saw that | 14:00 |
| lbragstad | it's this for compatibility with nova running with placement in nova still? like the migration to using placement as an external service? | 14:00 |
| mriedem | lbragstad: yeah placement has policy defaults in code | 14:00 |
| lbragstad | isn't* | 14:00 |
| mriedem | lbragstad: no nova is not involved at all | 14:00 |
| lbragstad | oh | 14:00 |
| mriedem | this is cleaning up old stuff from when placement was in nova | 14:01 |
| mriedem | bnemec: so my other thought was just checking if [placement]/policy_file exists and if so, use it | 14:01 |
| lbragstad | got it - so you just want to update the configuration to look for the policy file in a standard place, but check the old location (for migration purposes) | 14:01 |
| mriedem | yes | 14:01 |
| bnemec | Yeah, you might have to explicitly check, and log a warning if the old file is found. | 14:02 |
| lbragstad | yeah - i don't think we've ever had a case like this, because i don't think we've ever had someone forcing namespacing in the way nova had to for placement | 14:02 |
| bnemec | I don't think we really expose the location that a policy rule was loaded from. | 14:02 |
| mriedem | i think i can use ConfigOpts.find_file for that existence check yeah? | 14:03 |
| mriedem | since policy_file can be absolute or relative to the config file | 14:03 |
| lbragstad | right | 14:03 |
| lbragstad | the defaults to being relative iirc | 14:03 |
| lbragstad | it defaults* | 14:03 |
| bnemec | Yeah, that's what oslo.policy is using: https://github.com/openstack/oslo.policy/blob/master/oslo_policy/policy.py#L818 | 14:04 |
| mriedem | yup, that's how i found it :) | 14:04 |
| mriedem | ok i'll try that, thanks | 14:04 |
| mriedem | i'm not sure i can even warn if [placement]/policy_file is used... | 14:05 |
| mriedem | it defaults to policy.yaml, | 14:05 |
| mriedem | and if you configured [oslo_policy]/policy_file to policy.yaml, | 14:05 |
| mriedem | and they are in the same location, | 14:05 |
| mriedem | they'd look the same | 14:05 |
| mriedem | so maybe i need to look for [oslo_policy]/policy_file first? that defaults to policy.json so if that doesn't exist it would be more obvious that you haven't migrated yet | 14:06 |
| lbragstad | yeah - or you're just using the defaults in code | 14:06 |
| mriedem | ugh, true | 14:07 |
| lbragstad | so 1.) check if [oslo_policy]/policy_file exists, if so use it 2.) check if [placement]/policy_file exists, if so use it 3.) load everything from defaults in code (which should happen regardless to fill in the gaps in an existing policy file) | 14:08 |
| lbragstad | and eventually - i think you could just remove the second case | 14:08 |
| lbragstad | (cases 1 and 3 are essentially oslo.policy's default behavior) | 14:09 |
| *** hberaud is now known as hberaud|school-r | 14:23 | |
| mriedem | yup i think i've got something here, will post the wip and see if it makes sense | 14:26 |
| mriedem | trying to be extra cautious | 14:26 |
| *** lpetrut has quit IRC | 14:30 | |
| lbragstad | sounds good | 14:32 |
| *** hberaud|school-r is now known as hberaud | 14:39 | |
| bnemec | #startmeeting oslo | 15:00 |
| bnemec | Courtesy ping for bnemec, jungleboyj, moguimar, hberaud, kgiusti, redrobot, stephenfin, johnsom | 15:00 |
| bnemec | #link https://wiki.openstack.org/wiki/Meetings/Oslo#Agenda_for_Next_Meeting | 15:00 |
| openstack | Meeting started Mon Sep 9 15:00:26 2019 UTC and is due to finish in 60 minutes. The chair is bnemec. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| *** openstack changes topic to " (Meeting topic: oslo)" | 15:00 | |
| openstack | The meeting name has been set to 'oslo' | 15:00 |
| hberaud | o/ | 15:00 |
| moguimar | o/ | 15:00 |
| jungleboyj | o/ | 15:00 |
| johnsom | o/ | 15:00 |
| *** jroll has joined #openstack-oslo | 15:00 | |
| ansmith | o/ | 15:01 |
| bnemec | #topic Red flags for/from liaisons | 15:02 |
| *** openstack changes topic to "Red flags for/from liaisons (Meeting topic: oslo)" | 15:02 | |
| kgiusti | o/ | 15:02 |
| johnsom | Nothing to raise from Octavia team | 15:02 |
| moguimar | Nothing from Oslo | 15:03 |
| moguimar | oops | 15:03 |
| moguimar | barbican | 15:03 |
| bnemec | moguimar: :-) | 15:03 |
| moguimar | :facepalm: | 15:03 |
| bnemec | The one major thing to note from the Oslo side is that we have merged the sighup fix so that services won't be completely restarted when using mutable config. | 15:04 |
| bnemec | If you see any weird behavior as a result please let us know ASAP. | 15:04 |
| jungleboyj | nothing from Cinder | 15:04 |
| bnemec | Okay, sounds like we're good. | 15:05 |
| bnemec | #topic Releases | 15:05 |
| *** openstack changes topic to "Releases (Meeting topic: oslo)" | 15:05 | |
| jungleboyj | \o/ | 15:06 |
| bnemec | We're in feature freeze, so releases from here on out should be bugfix only, unless an FFE is granted. | 15:06 |
| bnemec | Also note that I released all the things last week. We need to do that so when branches are cut they include all of the doc and test changes we normally don't release. | 15:07 |
| *** goldyfruit has joined #openstack-oslo | 15:08 | |
| bnemec | Otherwise I would expect release activity to slow down a bit here as we come to the end of the cycle. | 15:08 |
| bnemec | I think that's all I've got. | 15:09 |
| bnemec | #topic Action items from last meeting | 15:09 |
| *** openstack changes topic to "Action items from last meeting (Meeting topic: oslo)" | 15:09 | |
| bnemec | "bnemec add gsantomaggio to oslo.messaging core list" | 15:09 |
| bnemec | Done. \o/ | 15:09 |
| gsantomaggio | @bnemec thank you | 15:09 |
| bnemec | My pleasure. :-) | 15:10 |
| bnemec | "bnemec to ask keystone team about https://review.opendev.org/#/c/662830" | 15:10 |
| bnemec | Pretty sure I did that, but still haven't heard anything back. | 15:10 |
| bnemec | At this point I'm inclined to just go ahead and merge it. | 15:11 |
| moguimar | lbragstad: ^ | 15:11 |
| bnemec | Since it's a bug fix we could do that now. I'm not sure how high priority this is though. | 15:11 |
| moguimar | bnemec: lbragstad and I are working in the same DFG now | 15:12 |
| *** jaosorior has quit IRC | 15:12 | |
| bnemec | Handy. :-) | 15:12 |
| moguimar | yep | 15:12 |
| lbragstad | i can take a look at that today if needed | 15:13 |
| bnemec | The other thing is that since this is a bugfix we could wait until next cycle and backport it. | 15:13 |
| bnemec | lbragstad: I'm mostly just looking for a sanity check that this isn't horribly violating any keystone expectations of how tokens get used. | 15:14 |
| lbragstad | bnemec cool - that sounds good | 15:15 |
| bnemec | Okay, we'll wait for lbragstad's input on that one then. | 15:16 |
| bnemec | #topic Feature freeze | 15:16 |
| *** openstack changes topic to "Feature freeze (Meeting topic: oslo)" | 15:16 | |
| bnemec | I mentioned it earlier, but we're in feature freeze now, both for Oslo and non-client libs. | 15:17 |
| bnemec | That means nobody should merge any patches that would require a feature release from now until we branch stable/train. | 15:17 |
| bnemec | Unless an FFE has been granted, and at this point I think we'd need approval from both me and the release team since we're out of the Oslo-specific freeze period. | 15:18 |
| bnemec | On a related note... | 15:18 |
| bnemec | #topic Deprecation of oslo.i18n Message.translate function | 15:18 |
| *** openstack changes topic to "Deprecation of oslo.i18n Message.translate function (Meeting topic: oslo)" | 15:18 | |
| bnemec | A bug was pointed out on the mailing list a couple of weeks ago that there was an issue with the Message.translate function. | 15:19 |
| bnemec | It turns out we shadowed a unicode built-in function in our Message subclass. | 15:19 |
| bnemec | That causes problems when we pass a Message object as a unicode to external libraries that try to use it as a non-i18n call. | 15:20 |
| bnemec | I have a two-part fix up for this, starting at https://review.opendev.org/#/c/679092/ | 15:20 |
| bnemec | The first one we can merge because it's exclusively a bug fix. | 15:21 |
| bnemec | The followup is more of a question because it deprecates the existing function. | 15:21 |
| bnemec | #link https://review.opendev.org/#/c/679321/1 | 15:21 |
| bnemec | However, I would like to ask for an FFE to get that in this cycle so we can do the removal ASAP. | 15:21 |
| bnemec | If we wait til next cycle we'll have to wait an extra cycle before removing it, per our deprecation policy. | 15:22 |
| bnemec | It's a pretty low risk thing since we don't document calling that function directly. Translation is supposed to happen via the i18n.translate module-level function. | 15:22 |
| bnemec | I don't see any deprecation warnings logged in the tempest jobs on the patch, so I don't think any of the projects we're testing with call it directly. | 15:23 |
| bnemec | So I wanted to bring this up for two reasons: 1) To get another core to look at that so we can have it ready to merge if we get an FFE | 15:24 |
| bnemec | 2) To see if anyone has any objections to me asking for an FFE on it | 15:24 |
| bnemec | If I hear no objections during the meeting I'll probably go ahead and take it to the list. | 15:26 |
| bnemec | Okay, moving on then. | 15:27 |
| bnemec | #topic PTG/Forum | 15:27 |
| *** openstack changes topic to "PTG/Forum (Meeting topic: oslo)" | 15:27 | |
| bnemec | #link https://etherpad.openstack.org/p/oslo-shanghai-topics | 15:27 |
| bnemec | Forum session proposals are now open. | 15:27 |
| gsantomaggio | can't go :( | 15:28 |
| bnemec | I don't have any topics planned, but if anyone has anything that they think would benefit from a broad discussion at the Forum please feel free to submit and add to the etherpad. | 15:28 |
| moguimar | bnemec: feel free to ping me for the castellan demo | 15:28 |
| bnemec | There's a lot of that going around. :-/ | 15:28 |
| bnemec | moguimar: Cool, I was planning on that. :-) | 15:28 |
| bnemec | I don't have a lot else to say on that, other than to always keep in mind that if you run across anything you think would benefit from discussion at the PTG, please add it to the etherpad too. | 15:30 |
| bnemec | #topic Cycle highlights | 15:30 |
| *** openstack changes topic to "Cycle highlights (Meeting topic: oslo)" | 15:30 | |
| bnemec | Now that we're coming to the end of the cycle, it's time for cycle highlights. | 15:30 |
| bnemec | I believe there was an email to the ML about this, but basically it's some marketing bullet points for each project. | 15:31 |
| bnemec | We don't always have them for Oslo because a lot of our work is not user-facing, so it's not terribly marketable. | 15:31 |
| bnemec | However, if you worked on anything this cycle that you think should show up in the OpenStack marketing materials please let me know ASAP. | 15:32 |
| bnemec | Oslo-related of course. ;-) | 15:32 |
| moguimar | was castellan driver this or last cycle? | 15:33 |
| bnemec | Last cycle, I believe. | 15:34 |
| bnemec | I'm pretty sure I included it in the cycle highlights last time. | 15:35 |
| bnemec | For reference, here's the cycle highlights from last time: | 15:36 |
| bnemec | #link https://review.opendev.org/#/c/645019 | 15:36 |
| bnemec | Basically all config-related. | 15:36 |
| bnemec | #topic Weekly Wayward Review | 15:38 |
| *** openstack changes topic to "Weekly Wayward Review (Meeting topic: oslo)" | 15:38 | |
| bnemec | This one catches my eye: | 15:39 |
| bnemec | #link https://review.opendev.org/#/c/672781/ | 15:39 |
| bnemec | It's a kind of important fix since it results in broken rules in the generated policy. | 15:40 |
| bnemec | lbragstad: I'm thinking I might go ahead and +2 since we've both reviewed each other's changes, and I only touched the tests. | 15:40 |
| bnemec | And maybe that will get cmurphy's attention. I hesitate to ping her since I don't know if she's caught up from PTO yet. | 15:41 |
| moguimar | bnemec: I can review it tomorrow morning | 15:42 |
| bnemec | moguimar: Sounds good, thanks. | 15:42 |
| bnemec | #action moguimar to review https://review.opendev.org/#/c/672781/ | 15:42 |
| bnemec | Alright, we'll call that good. At some point here I'll probably stop doing the wayward review section until ussuri opens up since we don't want to be forcing patches in late in the cycle. | 15:43 |
| bnemec | #topic Open discussion | 15:43 |
| *** openstack changes topic to "Open discussion (Meeting topic: oslo)" | 15:43 | |
| bnemec | Anything else this week? | 15:43 |
| moguimar | not on my end | 15:44 |
| lbragstad | thanks moguimar | 15:44 |
| bnemec | Okay, let's give everyone 13 minutes back. Thanks for joining! | 15:47 |
| bnemec | #endmeeting | 15:47 |
| *** openstack changes topic to "OpenStack Common Libraries | https://wiki.openstack.org/wiki/Oslo" | 15:47 | |
| openstack | Meeting ended Mon Sep 9 15:47:16 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:47 |
| moguimar | yay | 15:47 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/oslo/2019/oslo.2019-09-09-15.00.html | 15:47 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/oslo/2019/oslo.2019-09-09-15.00.txt | 15:47 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/oslo/2019/oslo.2019-09-09-15.00.log.html | 15:47 |
| mriedem | bnemec: lbragstad: this is whati came up with https://review.opendev.org/#/c/681047/1/placement/policy.py | 15:59 |
| *** tesseract has quit IRC | 16:07 | |
| *** e0ne has quit IRC | 16:10 | |
| lbragstad | mriedem nice - does that work locally | 16:13 |
| mriedem | haven't tried yet | 16:14 |
| mriedem | probably won't be able to today either | 16:14 |
| *** trident has quit IRC | 16:58 | |
| *** hberaud is now known as hberaud|gone | 16:59 | |
| *** trident has joined #openstack-oslo | 17:06 | |
| *** camelCaser has joined #openstack-oslo | 17:19 | |
| *** camelCaser has quit IRC | 17:28 | |
| *** camelCaser has joined #openstack-oslo | 17:28 | |
| *** mriedem has left #openstack-oslo | 17:38 | |
| *** ralonsoh has quit IRC | 17:49 | |
| *** goldyfruit_ has joined #openstack-oslo | 17:51 | |
| *** goldyfruit has quit IRC | 17:53 | |
| *** e0ne has joined #openstack-oslo | 18:12 | |
| *** e0ne has quit IRC | 18:34 | |
| *** jbadiapa has quit IRC | 19:00 | |
| *** e0ne has joined #openstack-oslo | 19:03 | |
| *** e0ne has quit IRC | 19:09 | |
| *** e0ne has joined #openstack-oslo | 19:10 | |
| *** jbadiapa has joined #openstack-oslo | 19:13 | |
| *** goldyfruit_ has quit IRC | 19:15 | |
| *** bnemec has quit IRC | 19:27 | |
| *** bnemec has joined #openstack-oslo | 19:32 | |
| *** goldyfruit has joined #openstack-oslo | 19:33 | |
| *** trident has quit IRC | 20:15 | |
| *** trident has joined #openstack-oslo | 20:27 | |
| *** kgiusti has left #openstack-oslo | 20:29 | |
| *** trident has quit IRC | 20:32 | |
| *** trident has joined #openstack-oslo | 20:33 | |
| *** ansmith has quit IRC | 20:49 | |
| *** boden has quit IRC | 20:53 | |
| *** raildo has quit IRC | 20:58 | |
| *** ansmith has joined #openstack-oslo | 21:24 | |
| *** e0ne has quit IRC | 21:40 | |
| *** snapiri has quit IRC | 21:41 | |
| *** lbragstad_ has joined #openstack-oslo | 21:44 | |
| *** lbragstad has quit IRC | 21:44 | |
| *** goldyfruit has quit IRC | 22:01 | |
| *** goldyfruit has joined #openstack-oslo | 22:08 | |
| *** lbragstad_ is now known as lbragstad | 22:11 | |
| *** goldyfruit_ has joined #openstack-oslo | 22:21 | |
| *** goldyfruit has quit IRC | 22:24 | |
| *** bobh has joined #openstack-oslo | 22:37 | |
| *** bobh has quit IRC | 22:45 | |
| *** goldyfruit_ has quit IRC | 22:51 | |
| *** rcernin has joined #openstack-oslo | 22:59 | |
| *** threestrands has joined #openstack-oslo | 23:14 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!