*** larainema has joined #openstack-oslo | 01:01 | |
*** openstackgerrit has quit IRC | 02:37 | |
*** rcernin has quit IRC | 03:13 | |
*** rcernin has joined #openstack-oslo | 04:05 | |
*** adriant has quit IRC | 04:05 | |
*** adriant has joined #openstack-oslo | 04:05 | |
*** dave-mccowan has quit IRC | 04:41 | |
*** Luzi has joined #openstack-oslo | 05:05 | |
*** adriant has quit IRC | 05:10 | |
*** adriant has joined #openstack-oslo | 05:11 | |
*** rcernin_ has joined #openstack-oslo | 05:52 | |
*** rcernin has quit IRC | 05:55 | |
*** jaosorior has quit IRC | 05:56 | |
*** lpetrut has joined #openstack-oslo | 06:20 | |
*** tosky has joined #openstack-oslo | 07:23 | |
*** jbadiapa has joined #openstack-oslo | 07:28 | |
*** rcernin_ has quit IRC | 07:40 | |
*** trident has quit IRC | 07:40 | |
*** jaosorior has joined #openstack-oslo | 07:42 | |
*** trident has joined #openstack-oslo | 07:49 | |
*** rcernin_ has joined #openstack-oslo | 07:57 | |
*** jaosorior has quit IRC | 08:01 | |
*** ralonsoh has joined #openstack-oslo | 08:04 | |
*** lpetrut has quit IRC | 08:08 | |
*** e0ne has joined #openstack-oslo | 08:11 | |
*** e0ne has quit IRC | 08:20 | |
*** e0ne has joined #openstack-oslo | 08:34 | |
*** jaosorior has joined #openstack-oslo | 08:37 | |
*** jaosorior has quit IRC | 08:49 | |
*** e0ne has quit IRC | 08:59 | |
*** e0ne has joined #openstack-oslo | 09:27 | |
*** e0ne has quit IRC | 09:27 | |
*** e0ne has joined #openstack-oslo | 10:21 | |
*** e0ne has quit IRC | 10:27 | |
*** e0ne has joined #openstack-oslo | 11:00 | |
*** jaosorior has joined #openstack-oslo | 11:02 | |
*** tesseract has joined #openstack-oslo | 11:15 | |
*** dave-mccowan has joined #openstack-oslo | 11:18 | |
*** e0ne has quit IRC | 11:20 | |
*** e0ne has joined #openstack-oslo | 11:23 | |
*** lpetrut has joined #openstack-oslo | 11:24 | |
*** lpetrut has quit IRC | 11:30 | |
*** e0ne has quit IRC | 11:32 | |
*** ansmith has quit IRC | 11:36 | |
*** e0ne has joined #openstack-oslo | 11:40 | |
*** boden has joined #openstack-oslo | 11:46 | |
*** boden has quit IRC | 12:08 | |
*** boden has joined #openstack-oslo | 12:10 | |
*** e0ne has quit IRC | 12:11 | |
*** larainema has quit IRC | 12:32 | |
*** ansmith has joined #openstack-oslo | 12:37 | |
*** jaosorior has quit IRC | 12:41 | |
*** Luzi has quit IRC | 12:44 | |
lbragstad | bnemec o/ | 12:46 |
---|---|---|
lbragstad | i noticed that we have some help text in keystone-manage that isn't rendering properly | 12:49 |
lbragstad | https://opendev.org/openstack/keystone/src/branch/master/keystone/cmd/cli.py#L1222-L1225 has new lines | 12:49 |
lbragstad | but they appear to be removed at runtime https://pasted.tech/pastes/5cdb1faa34f6b854f19b8f2e2fe976c73acb2363.raw | 12:49 |
lbragstad | i'm wondering if there is a way to tell oslo.config (i assume that's what is dealing with this?) to format the output to pick up those new lines? | 12:50 |
*** lpetrut has joined #openstack-oslo | 12:52 | |
bnemec | lbragstad: It looks like they are there but the newlines got dropped: "Example: EMAIL: me@example.com LOGIN: me GROUPS: group1;group2;group3" | 12:56 |
lbragstad | yeah | 12:56 |
bnemec | Off the top of my head I'm not sure what is responsible for processing that. | 12:57 |
lbragstad | my knee-jerk reaction was to say argparse | 12:57 |
lbragstad | but that's not it - at least not directly | 12:57 |
lbragstad | https://opendev.org/openstack/oslo.config/src/branch/master/oslo_config/cfg.py#L1254-L1308 ? | 12:58 |
bnemec | lbragstad: Could be cliff. Do you use that in keystone-manage? | 12:59 |
lbragstad | not that i'm aware of | 13:00 |
lbragstad | we seem to use SubCommandOpt? https://opendev.org/openstack/keystone/src/branch/master/keystone/cmd/cli.py#L1312-L1315 | 13:00 |
*** jaosorior has joined #openstack-oslo | 13:04 | |
lbragstad | looks like we are using https://opendev.org/openstack/oslo.config/src/branch/master/oslo_config/cfg.py#L1862 | 13:06 |
lbragstad | (somehow) | 13:06 |
bnemec | It looks like all of the cli stuff there inherits from argparse. | 13:09 |
bnemec | And apparently you need a different formatter to get newlines: https://stackoverflow.com/questions/3853722/python-argparse-how-to-insert-newline-in-the-help-text | 13:09 |
*** kgiusti has joined #openstack-oslo | 13:11 | |
bnemec | Unfortunately it doesn't appear we expose that option: https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L1986 | 13:12 |
lbragstad | this works - https://pasted.tech/pastes/9b368d0da3ae43b5f5ff7695bf146b262d4982e6.raw | 13:13 |
bnemec | Oh, nice. That's not too bad. | 13:17 |
bnemec | It will require you to manually wrap all of the help text for that parser, but I guess that's the way it goes. | 13:18 |
lbragstad | yeah - i don't think so | 13:18 |
*** boden has quit IRC | 13:18 | |
*** boden has joined #openstack-oslo | 13:19 | |
*** ansmith has quit IRC | 13:24 | |
efried | stephenfin: ...here | 13:25 |
efried | I haven't caught up with email yet, so forgive me if I missed it | 13:25 |
efried | remember the other day how you were saying you were good in oslo, except .service and .privsep? | 13:26 |
stephenfin | yarp | 13:26 |
stephenfin | (fwiw, I doubt I'm alone /o\) | 13:26 |
efried | well... could I nevertheless pretty please ask you to look at https://review.opendev.org/#/c/641907/ and https://review.opendev.org/678323 ? | 13:27 |
efried | With both of these, the SIGHUP bug is resolved. | 13:27 |
efried | The former has an effective +2 from zbitter (only commit message update since his +2) and the latter has +2 from bnemec, so you could send 'em both. | 13:28 |
stephenfin | I'll try | 13:29 |
efried | thanks stephenfin. As bnemec said, think of this as being aligned with your interests in nova as well :P | 13:29 |
*** e0ne has joined #openstack-oslo | 13:40 | |
*** rcernin_ has quit IRC | 13:41 | |
*** e0ne has quit IRC | 13:43 | |
*** efried is now known as efried_afk | 13:47 | |
*** jaosorior has quit IRC | 13:51 | |
*** lpetrut has quit IRC | 13:51 | |
*** zbitter has quit IRC | 13:53 | |
*** zbitter has joined #openstack-oslo | 13:54 | |
*** dave-mccowan has quit IRC | 13:54 | |
*** dave-mccowan has joined #openstack-oslo | 13:54 | |
*** rcernin_ has joined #openstack-oslo | 13:55 | |
*** fnordahl has quit IRC | 13:56 | |
*** d34dh0r53 has quit IRC | 13:57 | |
*** fnordahl has joined #openstack-oslo | 13:57 | |
*** d34dh0r53 has joined #openstack-oslo | 14:01 | |
*** e0ne has joined #openstack-oslo | 14:22 | |
*** openstackgerrit has joined #openstack-oslo | 14:46 | |
openstackgerrit | Ben Nemec proposed openstack/oslo.policy master: Follow the new PTI for document build https://review.opendev.org/549088 | 14:46 |
*** jbadiapa has quit IRC | 14:47 | |
*** jbadiapa has joined #openstack-oslo | 15:00 | |
*** ansmith has joined #openstack-oslo | 15:04 | |
*** efried_afk is now known as efried | 15:13 | |
*** e0ne has quit IRC | 15:14 | |
*** jbadiapa has quit IRC | 15:30 | |
openstackgerrit | Merged openstack/oslo.privsep master: Self-resetting PrivContext https://review.opendev.org/678323 | 16:07 |
*** tesseract has quit IRC | 16:50 | |
*** e0ne has joined #openstack-oslo | 17:02 | |
*** e0ne has quit IRC | 17:04 | |
*** e0ne has joined #openstack-oslo | 17:04 | |
*** e0ne has quit IRC | 17:04 | |
*** jbadiapa has joined #openstack-oslo | 17:07 | |
*** e0ne has joined #openstack-oslo | 17:35 | |
*** e0ne has quit IRC | 17:35 | |
*** ralonsoh has quit IRC | 17:43 | |
openstackgerrit | Ben Nemec proposed openstack/oslo.context stable/stein: Cap Bandit below 1.6.0 and update Sphinx requirement https://review.opendev.org/679309 | 17:50 |
openstackgerrit | Ben Nemec proposed openstack/oslo.context stable/rocky: Cap Bandit below 1.6.0 and update Sphinx requirement https://review.opendev.org/679310 | 17:54 |
openstackgerrit | Vladyslav Drok proposed openstack/oslo.log master: Serialize complex objects in FluentFormatter https://review.opendev.org/679312 | 17:56 |
*** dougwig has joined #openstack-oslo | 18:12 | |
*** e0ne has joined #openstack-oslo | 18:29 | |
*** e0ne has quit IRC | 18:32 | |
*** e0ne has joined #openstack-oslo | 18:55 | |
*** e0ne has quit IRC | 19:01 | |
*** e0ne has joined #openstack-oslo | 19:03 | |
*** e0ne has quit IRC | 19:04 | |
*** e0ne has joined #openstack-oslo | 19:05 | |
*** e0ne has quit IRC | 19:05 | |
openstackgerrit | Ben Nemec proposed openstack/oslo.i18n master: Deprecate Message.translate in favor of Message.translation https://review.opendev.org/679321 | 19:16 |
efried | bnemec: did you see stephenfin's request on the oslo.service patch? | 19:18 |
efried | I guess there's no reason I can't fix that... | 19:19 |
bnemec | efried: I glanced at it earlier, but if you want to take it I'm fine with that. | 19:24 |
efried | yeah, I got it. | 19:24 |
bnemec | Thanks | 19:27 |
*** kgiusti has left #openstack-oslo | 20:29 | |
openstackgerrit | Eric Fried proposed openstack/oslo.service master: restart: don't stop process on sighup when mutating https://review.opendev.org/641907 | 20:29 |
openstackgerrit | Eric Fried proposed openstack/oslo.service master: Polish usage.rst https://review.opendev.org/679334 | 20:29 |
efried | bnemec: fyi ^ | 20:31 |
efried | and stephenfin (when you awake) ^ | 20:37 |
*** ansmith has quit IRC | 20:42 | |
*** lpetrut has joined #openstack-oslo | 20:45 | |
*** lpetrut has quit IRC | 20:51 | |
*** ansmith has joined #openstack-oslo | 21:18 | |
*** rcernin_ has quit IRC | 21:25 | |
efried | bnemec: in case you care, https://bugs.launchpad.net/oslo.service/+bug/1794708 got assigned to me and I can't seem to assign it back. | 21:33 |
openstack | Launchpad bug 1794708 in oslo.service "Service children uselessly restart on signals" [Undecided,In progress] - Assigned to Eric Fried (efried) | 21:33 |
*** boden has quit IRC | 22:15 | |
*** tosky has quit IRC | 22:29 | |
*** rcernin has joined #openstack-oslo | 22:43 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!