| *** iurygregory has quit IRC | 00:17 | |
| *** goldyfruit has quit IRC | 00:50 | |
| *** goldyfruit has joined #openstack-oslo | 00:53 | |
| openstackgerrit | pengyuesheng proposed openstack/oslo.log master: Bump the openstackdocstheme extension to 1.20 https://review.opendev.org/669232 | 01:47 |
|---|---|---|
| openstackgerrit | pengyuesheng proposed openstack/oslo.messaging master: Bump the openstackdocstheme extension to 1.20 https://review.opendev.org/669238 | 01:49 |
| *** goldyfruit has quit IRC | 02:07 | |
| *** goldyfruit has joined #openstack-oslo | 02:08 | |
| *** threestrands has joined #openstack-oslo | 02:43 | |
| *** goldyfruit has quit IRC | 03:30 | |
| *** redrobot has quit IRC | 03:32 | |
| *** Guest99405 has joined #openstack-oslo | 03:39 | |
| *** Luzi has joined #openstack-oslo | 05:09 | |
| *** pcaruana has joined #openstack-oslo | 05:44 | |
| *** logan- has quit IRC | 06:00 | |
| *** logan_ has joined #openstack-oslo | 06:01 | |
| *** logan_ is now known as logan- | 06:01 | |
| *** rcernin has quit IRC | 06:44 | |
| *** jbadiapa has joined #openstack-oslo | 07:04 | |
| *** threestrands has quit IRC | 07:24 | |
| *** hberaud|gone is now known as hberaud | 07:46 | |
| *** ralonsoh has joined #openstack-oslo | 07:56 | |
| *** tosky has joined #openstack-oslo | 08:31 | |
| *** iurygregory has joined #openstack-oslo | 08:46 | |
| openstackgerrit | Elod Illes proposed openstack/taskflow stable/rocky: import zuul job settings from project-config https://review.opendev.org/591170 | 08:56 |
| stephenfin | hberaud: Trivial doc cleanup patch here. Care to take a look? https://review.opendev.org/#/c/669180/ | 09:30 |
| hberaud | stephenfin: sure | 09:31 |
| openstackgerrit | Merged openstack/oslo.messaging master: Blacklist sphinx 2.1.0 (autodoc bug) https://review.opendev.org/669237 | 09:35 |
| *** hberaud is now known as hberaud|lunch | 09:56 | |
| openstackgerrit | Stephen Finucane proposed openstack/oslo.vmware master: Add local bindep.txt https://review.opendev.org/671450 | 10:22 |
| openstackgerrit | Merged openstack/oslo.log stable/stein: Replace git.openstack.org URLs with opendev.org URLs https://review.opendev.org/658296 | 10:31 |
| *** takamatsu has joined #openstack-oslo | 10:37 | |
| *** hberaud|lunch is now known as hberaud | 10:50 | |
| openstackgerrit | Merged openstack/pbr master: Fix parsing on egg names with dashes from git URLs https://review.opendev.org/648727 | 11:16 |
| *** goldyfruit has joined #openstack-oslo | 11:20 | |
| *** tesseract has joined #openstack-oslo | 11:38 | |
| *** ansmith has quit IRC | 12:10 | |
| *** boden has joined #openstack-oslo | 12:23 | |
| *** raildo has joined #openstack-oslo | 12:34 | |
| *** ansmith has joined #openstack-oslo | 12:42 | |
| *** Guest99405 is now known as redrobot | 13:13 | |
| *** hoonetorg has quit IRC | 13:28 | |
| *** kgiusti has joined #openstack-oslo | 13:35 | |
| *** beekneemech has joined #openstack-oslo | 13:36 | |
| *** bnemec has quit IRC | 13:37 | |
| *** raildo has quit IRC | 13:50 | |
| *** Luzi has quit IRC | 13:52 | |
| gsantomaggio | hello, | 14:11 |
| gsantomaggio | I am looking how to implement mandatory flag server side, but it is a totally different from the RPCClient. | 14:11 |
| gsantomaggio | For what I have understood I have to change `AMQPIncomingMessage` | 14:11 |
| gsantomaggio | https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/_drivers/amqpdriver.py#L125 | 14:11 |
| gsantomaggio | that is the class that actually send back the message | 14:11 |
| gsantomaggio | I am in the right path? | 14:11 |
| gsantomaggio | @kgiusti @hberaud | 14:11 |
| gsantomaggio | thanks | 14:11 |
| gsantomaggio | >I am in the right path? | 14:11 |
| gsantomaggio | Am I in the right path? | 14:11 |
| *** iurygregory has quit IRC | 14:23 | |
| *** lbragstad has joined #openstack-oslo | 14:36 | |
| *** iurygregory has joined #openstack-oslo | 14:40 | |
| hberaud | gsantomaggio: yo | 14:47 |
| kgiusti | gsantomaggio: sorry! | 14:48 |
| hberaud | gsantomaggio: sorry I've no significant experience with this module but I'll take a look to help you | 14:48 |
| kgiusti | gsantomaggio: the reply method does get called by the server, yes | 14:49 |
| gsantomaggio | @hberaud thank you, don't worry I am working on it, maybe you can help for the review | 14:49 |
| gsantomaggio | @kgiusti thanks | 14:49 |
| hberaud | gsantomaggio: sure | 14:50 |
| hberaud | kgiusti: thx too | 14:50 |
| kgiusti | gsantomaggio: https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/rpc/server.py#L178 | 14:50 |
| gsantomaggio | yes, seen it | 14:51 |
| gsantomaggio | I need to add a parameter there | 14:51 |
| kgiusti | gsantomaggio: the transport options parameter? | 14:52 |
| gsantomaggio | yes that one | 14:52 |
| gsantomaggio | I am looking a "place" where to put | 14:52 |
| gsantomaggio | the transport options parameter | 14:52 |
| gsantomaggio | I ended up on https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/rpc/server.py#L178 | 14:53 |
| gsantomaggio | looking the stack, that the first function called | 14:54 |
| gsantomaggio | I already passed it on `RPCServer` | 14:54 |
| gsantomaggio | so it should be something like `message.reply(res, self.transport_options)` | 14:55 |
| kgiusti | gsantomaggio: makes sense to add a new parameter to reply(). IIRC that method is internal to o.m. and only used by the RPCServer | 14:55 |
| gsantomaggio | @kgiusti ok cool! I continue on this way :)! | 14:55 |
| kgiusti | gsantomaggio: that should be safe. The reply() definition takes keyword args so you can add new ones easily. | 14:56 |
| kgiusti | gsantomaggio: +1 | 14:56 |
| gsantomaggio | @kgiusti ... last famous words :D :D | 14:57 |
| *** hberaud has quit IRC | 14:57 | |
| *** hberaud has joined #openstack-oslo | 14:59 | |
| kgiusti | gsantomaggio: ha! looky here: https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/_drivers/base.py#L141 | 14:59 |
| gsantomaggio | hahahah | 15:00 |
| kgiusti | gsantomaggio: you may want to consider just turning on mandatory by default in the rabbit driver | 15:01 |
| kgiusti | gsantomaggio: since "reply" is _supposed_ to fail fast | 15:02 |
| gsantomaggio | @kgiusti yes, I was thinking the same. | 15:02 |
| kgiusti | gsantomaggio: I'd be fine with simply doing that | 15:02 |
| kgiusti | gsantomaggio: the _send_reply method in amqpdriver.py would simply (ha! "simply") be changed to do a mandatory send. | 15:03 |
| gsantomaggio | @kgiusti I'd add transport_parameter here: https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/_drivers/amqpdriver.py#L102 | 15:07 |
| gsantomaggio | 15:07 | |
| gsantomaggio | then back | 15:07 |
| gsantomaggio | to the other functions | 15:07 |
| gsantomaggio | a bit monkey programming but that's it :D | 15:07 |
| kgiusti | gsantomaggio: does it need to be a parameter or can _send_reply be rewritten to always use mandatory? | 15:09 |
| kgiusti | gsantomaggio: in other words it's not optional - replies are always sent mandatory=true? | 15:10 |
| gsantomaggio | @kgiusti a ok, so you want to male `_send_reply` *always* mandatory | 15:10 |
| kgiusti | gsantomaggio: if it's simpler to do. I can't think of any reason not to. | 15:11 |
| gsantomaggio | *make | 15:11 |
| gsantomaggio | @kgiusti yes, it makes sense | 15:11 |
| gsantomaggio | @kgiusti I usually use the `mandatory` flag in this kind of the situations | 15:12 |
| kgiusti | gsantomaggio: try it out - if it is simpler/cleaner I'd say go for it. You wouldn't need to change RPCServer API at all (I think) | 15:12 |
| kgiusti | gsantomaggio: yeah I think that's the right thing to do | 15:12 |
| kgiusti | gsantomaggio: 'mandatory' should be default for replies. | 15:13 |
| gsantomaggio | @kgiusti what we can do is: | 15:14 |
| gsantomaggio | 1 - make it as default | 15:14 |
| gsantomaggio | 2- add a global paramenter to disable it (maybe ??? no ) | 15:14 |
| gsantomaggio | btw let's do that | 15:14 |
| kgiusti | gsantomaggio: heh - cover our butts? :D good idea! | 15:15 |
| *** hoonetorg has joined #openstack-oslo | 15:26 | |
| *** beekneemech has quit IRC | 15:57 | |
| *** bnemec has joined #openstack-oslo | 15:58 | |
| *** iurygregory has quit IRC | 16:01 | |
| *** ansmith_ has joined #openstack-oslo | 16:33 | |
| *** ansmith has quit IRC | 16:35 | |
| openstackgerrit | Merged openstack/oslo.log stable/stein: Modify the constraints url in tox. https://review.opendev.org/666516 | 16:35 |
| *** gibi has quit IRC | 16:45 | |
| *** ansmith_ has quit IRC | 16:46 | |
| *** ansmith_ has joined #openstack-oslo | 16:46 | |
| *** tosky has quit IRC | 17:17 | |
| *** raildo has joined #openstack-oslo | 17:30 | |
| *** hogepodge has quit IRC | 17:45 | |
| *** hogepodge has joined #openstack-oslo | 17:47 | |
| *** ralonsoh has quit IRC | 17:51 | |
| *** gibi has joined #openstack-oslo | 17:53 | |
| *** hberaud is now known as hberaud|gone | 18:03 | |
| *** irclogbot_3 has quit IRC | 18:07 | |
| *** altlogbot_3 has quit IRC | 18:07 | |
| *** irclogbot_1 has joined #openstack-oslo | 18:08 | |
| *** altlogbot_0 has joined #openstack-oslo | 18:09 | |
| *** lbragstad has quit IRC | 19:02 | |
| *** gibi has quit IRC | 19:15 | |
| *** gibi has joined #openstack-oslo | 19:28 | |
| *** e0ne has joined #openstack-oslo | 19:38 | |
| *** pcaruana has quit IRC | 20:01 | |
| *** tesseract has quit IRC | 20:05 | |
| *** kgiusti has quit IRC | 20:36 | |
| *** ansmith_ has quit IRC | 20:43 | |
| *** raildo has quit IRC | 21:04 | |
| *** raildo has joined #openstack-oslo | 21:04 | |
| *** e0ne has quit IRC | 21:17 | |
| *** raildo has quit IRC | 21:21 | |
| *** beekneemech has joined #openstack-oslo | 21:38 | |
| *** beekneemech has quit IRC | 21:38 | |
| *** boden has quit IRC | 21:52 | |
| *** bnemec has quit IRC | 22:03 | |
| *** bnemec has joined #openstack-oslo | 22:13 | |
| *** bnemec has quit IRC | 22:42 | |
| *** bnemec has joined #openstack-oslo | 22:43 | |
| *** ansmith_ has joined #openstack-oslo | 22:53 | |
| *** rcernin has joined #openstack-oslo | 23:15 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!