| *** threestrands has joined #openstack-oslo | 00:04 | |
| *** rcernin has quit IRC | 00:06 | |
| *** kgiusti has left #openstack-oslo | 00:15 | |
| *** rcernin has joined #openstack-oslo | 00:18 | |
| *** ajo has quit IRC | 00:51 | |
| *** ajo has joined #openstack-oslo | 00:51 | |
| *** niceplace has quit IRC | 00:52 | |
| *** niceplace has joined #openstack-oslo | 00:54 | |
| *** rcernin has quit IRC | 01:12 | |
| *** rcernin has joined #openstack-oslo | 01:17 | |
| *** Dinesh_Bhor has quit IRC | 01:27 | |
| *** Dinesh_Bhor has joined #openstack-oslo | 01:31 | |
| *** threestrands has quit IRC | 01:41 | |
| *** jhesketh has quit IRC | 02:12 | |
| *** jhesketh has joined #openstack-oslo | 02:13 | |
| *** Luzi has joined #openstack-oslo | 05:45 | |
| *** jbadiapa has joined #openstack-oslo | 05:48 | |
| *** coreycb_ has joined #openstack-oslo | 06:08 | |
| *** Anticime1 has joined #openstack-oslo | 06:10 | |
| *** coreycb has quit IRC | 06:15 | |
| *** smcginnis has quit IRC | 06:15 | |
| *** Anticimex has quit IRC | 06:15 | |
| *** fnordahl has quit IRC | 06:15 | |
| *** coreycb_ is now known as coreycb | 06:15 | |
| *** irclogbot_0 has quit IRC | 06:18 | |
| *** irclogbot_1 has joined #openstack-oslo | 06:19 | |
| *** pcaruana has joined #openstack-oslo | 06:25 | |
| *** lpetrut has joined #openstack-oslo | 06:49 | |
| *** rcernin has quit IRC | 06:57 | |
| *** e0ne has quit IRC | 06:59 | |
| *** iurygregory has joined #openstack-oslo | 07:00 | |
| *** jaosorior has joined #openstack-oslo | 07:11 | |
| *** tesseract has joined #openstack-oslo | 07:11 | |
| *** tosky has joined #openstack-oslo | 07:14 | |
| *** trident has quit IRC | 07:40 | |
| *** trident has joined #openstack-oslo | 07:41 | |
| *** fnordahl has joined #openstack-oslo | 07:44 | |
| *** hberaud|gone is now known as hberaud | 07:45 | |
| *** ralonsoh has joined #openstack-oslo | 07:54 | |
| *** jaosorior has quit IRC | 08:13 | |
| openstackgerrit | Natal Ngétal proposed openstack/oslo.log stable/stein: Modify the constraints url in tox. https://review.opendev.org/666516 | 08:16 |
|---|---|---|
| *** jaosorior has joined #openstack-oslo | 08:17 | |
| openstackgerrit | Gabriele Santomaggio proposed openstack/oslo.messaging master: Implement the transport options https://review.opendev.org/666241 | 08:22 |
| *** e0ne has joined #openstack-oslo | 08:27 | |
| openstackgerrit | Gabriele Santomaggio proposed openstack/oslo.messaging master: Implement the transport options https://review.opendev.org/666241 | 08:30 |
| openstackgerrit | Hervé Beraud proposed openstack/oslo.messaging master: Introduce RabbitMQ driver documentation https://review.opendev.org/666863 | 09:30 |
| openstackgerrit | Hervé Beraud proposed openstack/oslo-specs master: Always run the rabbitmq heartbeat inside a standard pthread. https://review.opendev.org/661314 | 09:37 |
| openstackgerrit | Stephen Finucane proposed openstack/oslo.config master: Remove '.testr.conf' https://review.opendev.org/667052 | 09:51 |
| openstackgerrit | Stephen Finucane proposed openstack/pbr master: option to print only the version of a package https://review.opendev.org/577614 | 09:58 |
| *** hberaud is now known as hberaud|lunch | 10:12 | |
| openstackgerrit | Stephen Finucane proposed openstack/oslo.policy master: Updated from global requirements https://review.opendev.org/555580 | 10:24 |
| *** hberaud|lunch is now known as hberaud | 11:04 | |
| *** jaosorior_ has joined #openstack-oslo | 11:22 | |
| *** jaosorior has quit IRC | 11:23 | |
| *** ansmith has quit IRC | 11:59 | |
| *** boden has joined #openstack-oslo | 12:21 | |
| *** jroll has quit IRC | 12:28 | |
| *** jroll has joined #openstack-oslo | 12:29 | |
| *** ansmith has joined #openstack-oslo | 12:45 | |
| *** beekneemech is now known as bnemec | 12:51 | |
| *** boden has quit IRC | 12:53 | |
| *** boden has joined #openstack-oslo | 12:55 | |
| *** raildo has joined #openstack-oslo | 12:59 | |
| *** lbragstad has joined #openstack-oslo | 13:02 | |
| *** boden has quit IRC | 13:02 | |
| *** boden has joined #openstack-oslo | 13:09 | |
| openstackgerrit | Hervé Beraud proposed openstack/oslo.messaging stable/rocky: Issue blocking ACK for RPC requests from the consumer thread https://review.opendev.org/667080 | 13:13 |
| *** goldyfruit has joined #openstack-oslo | 13:14 | |
| openstackgerrit | Hervé Beraud proposed openstack/oslo.messaging stable/queens: Issue blocking ACK for RPC requests from the consumer thread https://review.opendev.org/667083 | 13:14 |
| *** trident has quit IRC | 13:29 | |
| *** kgiusti has joined #openstack-oslo | 13:33 | |
| *** trident has joined #openstack-oslo | 13:35 | |
| *** goldyfruit has quit IRC | 13:42 | |
| *** jaosorior_ has quit IRC | 13:48 | |
| *** jaosorior has joined #openstack-oslo | 13:49 | |
| *** jaosorior has quit IRC | 13:49 | |
| *** Luzi has quit IRC | 13:57 | |
| *** lpetrut has quit IRC | 14:06 | |
| *** dave-mccowan has joined #openstack-oslo | 14:07 | |
| *** goldyfruit has joined #openstack-oslo | 14:09 | |
| *** dave-mccowan has quit IRC | 14:11 | |
| *** smcginnis has joined #openstack-oslo | 14:13 | |
| openstackgerrit | jacky06 proposed openstack/mox3 master: Sync Sphinx requirement https://review.opendev.org/666051 | 14:20 |
| *** hberaud is now known as hberaud|school-r | 14:27 | |
| *** jaosorior has joined #openstack-oslo | 14:33 | |
| *** goldyfruit has quit IRC | 14:41 | |
| *** hberaud|school-r is now known as hberaud | 14:49 | |
| openstackgerrit | Gabriele Santomaggio proposed openstack/oslo.messaging master: Implement the transport options https://review.opendev.org/666241 | 14:51 |
| openstackgerrit | Merged openstack/oslo.config master: Remove '.testr.conf' https://review.opendev.org/667052 | 14:56 |
| moguimar | bnemec: meeting? | 15:01 |
| openstackgerrit | Merged openstack/oslo-cookiecutter master: Use sphinxcontrib-apidoc for building api docs https://review.opendev.org/662325 | 15:01 |
| openstackgerrit | Merged openstack/oslo-cookiecutter master: Fix stestr configuration https://review.opendev.org/662507 | 15:01 |
| openstackgerrit | Merged openstack/oslo-cookiecutter master: Add test script to verify tox targets run https://review.opendev.org/662326 | 15:01 |
| openstackgerrit | Merged openstack/oslo-cookiecutter master: Fix doc build in test script https://review.opendev.org/662508 | 15:01 |
| bnemec | #startmeeting oslo | 15:01 |
| bnemec | Courtesy ping for bnemec, jungleboyj, moguimar, hberaud, kgiusti, redrobot, stephenfin, johnsom | 15:01 |
| bnemec | #link https://wiki.openstack.org/wiki/Meetings/Oslo#Agenda_for_Next_Meeting | 15:01 |
| openstack | Meeting started Mon Jun 24 15:01:49 2019 UTC and is due to finish in 60 minutes. The chair is bnemec. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:01 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:01 |
| *** openstack changes topic to " (Meeting topic: oslo)" | 15:01 | |
| openstack | The meeting name has been set to 'oslo' | 15:01 |
| hberaud | yo | 15:03 |
| gsantomaggio | yo | 15:03 |
| ansmith | o/ | 15:03 |
| moguimar | o/ | 15:03 |
| kgiusti | o/ | 15:04 |
| *** jaosorior has quit IRC | 15:05 | |
| bnemec | #topic Red flags for/from liaisons | 15:05 |
| *** openstack changes topic to "Red flags for/from liaisons (Meeting topic: oslo)" | 15:05 | |
| moguimar | None from Barbican | 15:06 |
| jungleboyj | o/ | 15:06 |
| jungleboyj | Nothing from Cinder. | 15:06 |
| bnemec | Last week was pretty quiet from the Oslo side too. | 15:06 |
| bnemec | Nothing I can think of to highlight. | 15:06 |
| bnemec | #topic Releases | 15:07 |
| *** openstack changes topic to "Releases (Meeting topic: oslo)" | 15:07 | |
| bnemec | Just a couple last week. | 15:07 |
| bnemec | Of note is that I held off on releasing oslo.messaging since the transport options feature is only partially merged. | 15:07 |
| bnemec | kgiusti: gsantomaggio: If you have something that needs to be released anyway we can certainly do that though. | 15:08 |
| gsantomaggio | I'm proceeding by steps | 15:08 |
| bnemec | Other than that, I will take a look at the necessary releases again this week. | 15:09 |
| kgiusti | I've got nuthin' - hberaud - anything? | 15:09 |
| hberaud | nope | 15:09 |
| gsantomaggio | I am waiting for approving this: https://review.opendev.org/#/c/666241/ | 15:09 |
| gsantomaggio | then I can add the handle the mandatory flag client side and then server side | 15:10 |
| kgiusti | gsantomaggio: I'll take a look | 15:10 |
| hberaud | +1 | 15:10 |
| bnemec | Yep, that's what I'm waiting the release on. | 15:10 |
| bnemec | Or maybe the actual mandatory implementation. | 15:11 |
| bnemec | I guess the main point is that I intentionally didn't release oslo.messaging last week, but if you need a release just let me know. | 15:11 |
| gsantomaggio | as you prefer | 15:11 |
| stephenfin | Not entirely relevant for this section, but I went and abandoned a load of seemingly stale patches/specs this morning. Hopefully I didn't catch anything I shouldn't have in the process | 15:12 |
| bnemec | The ones I saw looked fine. | 15:12 |
| bnemec | I know pluggably policy is pretty much off the table at this point. | 15:13 |
| moguimar | yep | 15:13 |
| bnemec | It's always okay to restore an abandoned patch if you still have interest in it. | 15:13 |
| moguimar | I even tried to help ozz on that one | 15:13 |
| bnemec | And if you're not the owner, feel free to ping an Oslo core to do it. | 15:13 |
| bnemec | moguimar: Yeah, based on the discussions I've had with people it sounds like that was kind of a side project that didn't end up going anywhere. | 15:14 |
| bnemec | Doug does have a patch up to allow integration with external policy engines. | 15:14 |
| bnemec | It's not pluggable though. | 15:14 |
| bnemec | #link https://review.opendev.org/#/c/658675/ | 15:15 |
| bnemec | for anyone who is interested. | 15:15 |
| bnemec | #topic Action items from last meeting | 15:16 |
| *** openstack changes topic to "Action items from last meeting (Meeting topic: oslo)" | 15:16 | |
| bnemec | "bnemec reply to unicode project description thread" | 15:16 |
| bnemec | Done | 15:16 |
| bnemec | "bnemec update liaison documentation with new ping list details" | 15:16 |
| bnemec | Turns out we didn't document the ping list in the liaison docs, so this was a noop | 15:17 |
| bnemec | "bnemec retire courtesy ping script in oslo.tools" | 15:17 |
| bnemec | Proposed. | 15:17 |
| gsantomaggio | > but if you need a release just let me know. | 15:17 |
| gsantomaggio | No I don't need a release thank you, I work always on `master` branch | 15:17 |
| bnemec | #link https://review.opendev.org/666057 | 15:17 |
| bnemec | gsantomaggio: Sounds good. | 15:17 |
| bnemec | "bnemec to point kafka functional test patch at apache mirror" | 15:17 |
| *** jaosorior has joined #openstack-oslo | 15:18 | |
| bnemec | Turns out the mirrors don't include the archive content, so we couldn't do this. | 15:18 |
| bnemec | I believe we did merge the patch to switch it to archive.a.o so we could unblock those functional tests though. | 15:18 |
| bnemec | "Cores to review https://review.opendev.org/648727" | 15:18 |
| openstackgerrit | Merged openstack/oslo.tools master: Remove ping_me script https://review.opendev.org/666057 | 15:18 |
| bnemec | I took a look, but it didn't quite fix the bug entirely. | 15:19 |
| bnemec | I should probably go -1 that since at the very least it shouldn't be marked Closes-Bug. Partial-Bug might be okay. | 15:19 |
| hberaud | bnemec: I saw comments | 15:19 |
| hberaud | s/I saw/I just saw/ | 15:20 |
| bnemec | hberaud: It's possible we could merge that as an improvement and iterate on the full fix. | 15:20 |
| bnemec | I'm not sure whether it regresses any cases that were working before. | 15:20 |
| hberaud | bnemec: ack | 15:20 |
| bnemec | If not, it's an improvement even if not a 100% solution. | 15:21 |
| hberaud | I'll move from Closes to Parial | 15:21 |
| hberaud | partial | 15:21 |
| bnemec | Sounds good, thanks. | 15:21 |
| bnemec | "bnemec to follow up on oslo.service reload bug" | 15:22 |
| bnemec | Not done. Still on my todo list though. | 15:22 |
| moguimar | I tried to test it | 15:22 |
| bnemec | Last week ended up being a bit busy, so hopefully I'll have more time this week to do this. | 15:22 |
| moguimar | but even master is failing tox on my machine | 15:22 |
| bnemec | moguimar: The oslo.service patch? | 15:22 |
| moguimar | the pbr | 15:22 |
| bnemec | Ah | 15:23 |
| bnemec | moguimar: What is the error? | 15:23 |
| bnemec | The pbr unit tests _should_ be pretty stable since we fixed the wsgi issue. | 15:23 |
| bnemec | (that was the end of action items from last week, BTW) | 15:24 |
| moguimar | lots of testtools.matchers._impl.MismatchError: '1.2.3.dev1' does not start with '1.2.3.0a2.dev1'. | 15:24 |
| moguimar | and some pgp failed to sign the data | 15:24 |
| moguimar | I have to dig more into it | 15:24 |
| moguimar | testing that review I had 13 fails | 15:25 |
| moguimar | I'm hitting 11 on master | 15:25 |
| moguimar | It is probably something in my machine | 15:25 |
| bnemec | Have you tried wiping .tox? That's always my first step when I get unexpected test failures. :-) | 15:25 |
| moguimar | I usually do a "git clean -fdX" | 15:26 |
| moguimar | trying it right now | 15:26 |
| bnemec | Okay, we can follow up after the meeting too. | 15:27 |
| bnemec | I don't have any topics for this week, so we'll go straight to | 15:28 |
| bnemec | #topic Weekly Wayward Review | 15:28 |
| *** openstack changes topic to "Weekly Wayward Review (Meeting topic: oslo)" | 15:28 | |
| bnemec | #link https://review.opendev.org/#/c/577614 | 15:28 |
| bnemec | Looks like this just got rebased. | 15:28 |
| bnemec | It's a pretty simple change, so hopefully we can just merge it. | 15:28 |
| bnemec | And approved. | 15:31 |
| hberaud | I'll +2 | 15:31 |
| bnemec | One more off the review pile of shame. :-) | 15:31 |
| bnemec | #topic Open discussion | 15:31 |
| *** openstack changes topic to "Open discussion (Meeting topic: oslo)" | 15:31 | |
| hberaud | lol ok | 15:32 |
| bnemec | Anything else this week? | 15:32 |
| bnemec | hberaud: Thanks for looking. :-) | 15:32 |
| hberaud | if someone can take a look to => https://review.opendev.org/#/c/663074/ and https://review.opendev.org/#/c/661314/ (the eventlet heartbeat stuff) | 15:33 |
| *** tesseract has quit IRC | 15:33 | |
| bnemec | hberaud: What's the status on that? Last I heard kgiusti had concerns and you said something about tpool not working the way we needed. | 15:34 |
| * kgiusti - re-looks... | 15:34 | |
| hberaud | bnemec: I've submit 2 solution, 1 with tpool, 1 without tpool (the current patch set) and the instructions to test it | 15:35 |
| hberaud | (the both) | 15:35 |
| bnemec | hberaud: Okay, thanks. Do you have a recommendation on which we should go with? | 15:36 |
| hberaud | bnemec: yeah I propose to use the current patch set | 15:36 |
| kgiusti | bnemec: hberaud: I didn't have a technical objection - just concerned about the scope of work in general. | 15:36 |
| kgiusti | but I'm definitely interesting in this problem. | 15:36 |
| bnemec | hberaud: Sounds good. I'll try to take a look this week. | 15:37 |
| hberaud | bnemec: but if you want to observe the result with tpool you can us the patch set 3 to test it | 15:37 |
| hberaud | (cf. the commit message) | 15:37 |
| bnemec | kgiusti: Yeah, we just never really resolved that discussion that I can recall. | 15:37 |
| *** jaosorior has quit IRC | 15:37 | |
| hberaud | also I suppose it's better to keep the spec too | 15:38 |
| hberaud | to keep a track of all puzzle pieces | 15:38 |
| hberaud | bnemec: kgiusti; thoughts? | 15:38 |
| bnemec | Given that this is technically a bug fix I don't think we _need_ a spec, but if it helps to coordinate the work then I'm fine with keeping it. | 15:38 |
| bnemec | Just don't do it solely for the sake of more bureaucracy. :-) | 15:39 |
| hberaud | the main of the spec part is to justify some technical choice in the doc after that => https://review.opendev.org/#/c/666863/ | 15:39 |
| hberaud | s/the main/the main goal/ | 15:39 |
| kgiusti | hberaud: I'll spend more time reviewing what you've currently done | 15:40 |
| kgiusti | hberaud: I'll try to get that done today. | 15:41 |
| hberaud | bnemec: yeah sure "not a bureaucracy" choice :) | 15:41 |
| hberaud | kgiusti: thanks | 15:41 |
| bnemec | #action kgiusti and bnemec to review rabbit heartbeat changes | 15:41 |
| bnemec | There, now it's official. | 15:42 |
| hberaud | :) | 15:42 |
| bnemec | Anything else? | 15:42 |
| hberaud | not on my side | 15:42 |
| moguimar | neither on mine | 15:43 |
| gsantomaggio | nothing here ! | 15:43 |
| bnemec | Sounds like we're done. Thanks for joining, everyone! | 15:44 |
| bnemec | #endmeeting | 15:44 |
| *** openstack changes topic to "OpenStack Common Libraries | https://wiki.openstack.org/wiki/Oslo" | 15:44 | |
| openstack | Meeting ended Mon Jun 24 15:44:49 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:44 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/oslo/2019/oslo.2019-06-24-15.01.html | 15:44 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/oslo/2019/oslo.2019-06-24-15.01.txt | 15:44 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/oslo/2019/oslo.2019-06-24-15.01.log.html | 15:44 |
| * bnemec is impressed we came up with 45 minutes of discussion in a week with no formal topics | 15:45 | |
| openstackgerrit | Lance Bragstad proposed openstack/oslo.limit master: Add ksa connection logic https://review.opendev.org/666085 | 15:45 |
| moguimar | bnemec: I'm going home now, will dig more into pbr tomorrow morning | 15:45 |
| * moguimar can't think straight while hungry | 15:46 | |
| bnemec | :-) | 15:59 |
| openstackgerrit | Lance Bragstad proposed openstack/oslo.limit master: Add ksa connection logic https://review.opendev.org/666085 | 16:01 |
| openstackgerrit | Merged openstack/oslo.messaging master: Add the "transport_options" parameter to the amqp1 and kafka drivers. https://review.opendev.org/666726 | 16:08 |
| *** e0ne has quit IRC | 16:12 | |
| *** hberaud is now known as hberaud|afk | 16:15 | |
| *** iurygregory has quit IRC | 16:17 | |
| *** trident has quit IRC | 16:30 | |
| *** trident has joined #openstack-oslo | 16:32 | |
| *** hberaud|afk is now known as hberaud | 17:03 | |
| *** e0ne has joined #openstack-oslo | 17:07 | |
| *** e0ne has quit IRC | 17:08 | |
| *** ralonsoh has quit IRC | 17:23 | |
| openstackgerrit | Merged openstack/pbr master: option to print only the version of a package https://review.opendev.org/577614 | 17:24 |
| *** e0ne has joined #openstack-oslo | 17:27 | |
| openstackgerrit | Hervé Beraud proposed openstack/oslo.messaging master: Introduce RabbitMQ driver documentation https://review.opendev.org/666863 | 17:28 |
| *** goldyfruit has joined #openstack-oslo | 17:30 | |
| *** hberaud is now known as hberaud|gone | 17:33 | |
| lbragstad | bnemec i'm tinkering with oslo_limit and building out the connections using openstacksdk - but we need configuration options to build that connection | 17:50 |
| lbragstad | i'm wondering if there is an easy way to script a config object for testing this all out? | 17:50 |
| lbragstad | i feel like there is, but it's not jumping out at me in the code or docs | 17:50 |
| *** goldyfruit has quit IRC | 17:54 | |
| bnemec | lbragstad: In unit tests or for functional testing? | 17:58 |
| *** e0ne has quit IRC | 18:02 | |
| *** e0ne has joined #openstack-oslo | 18:06 | |
| lbragstad | i think this would classify as functional, but not in-repo | 18:11 |
| lbragstad | i'm literally just writing a script that has an oslo_limit.limit.Enforcer and makes up some bogus resources | 18:11 |
| lbragstad | cc bnemec ^ | 18:14 |
| bnemec | lbragstad: If you're just looking to script some config values, you probably want set_override: https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L2422 | 18:15 |
| lbragstad | bnemec so something along these lines? https://pasted.tech/pastes/296394a9b325a2c8b622e2cbd34cb866492865d1.raw | 18:19 |
| bnemec | lbragstad: Yeah, I think that should work. | 18:21 |
| bnemec | It's possible you would also need to register the opts first. | 18:21 |
| lbragstad | i must be missing a registration step | 18:21 |
| bnemec | I'm not sure whether set_override requires the options to be defined first. | 18:21 |
| lbragstad | https://pasted.tech/pastes/800c63056650e60704607be59e1287960ef42e1f.raw | 18:22 |
| bnemec | Maybe you need to call opts.register_opts first? | 18:22 |
| bnemec | https://opendev.org/openstack/oslo.limit/src/branch/master/oslo_limit/opts.py#L51 | 18:23 |
| lbragstad | https://review.opendev.org/#/c/666085/5/oslo_limit/limit.py@28 | 18:23 |
| lbragstad | ok - cool | 18:23 |
| lbragstad | yeah, i'm working off of https://review.opendev.org/#/c/666085/5 | 18:23 |
| bnemec | Yeah, without digging too deep into the set_override code, I would guess it requires the opts to be registered before they can be overridden. | 18:25 |
| lbragstad | interesting... i think registration is broken anyway? | 18:25 |
| bnemec | How so? | 18:26 |
| bnemec | Oh, because auth_type needs to be set before https://review.opendev.org/#/c/666085/5/oslo_limit/opts.py will work? | 18:26 |
| lbragstad | actually - i tried overriding endpoint_id first instead | 18:27 |
| lbragstad | since that's actually a registered option by oslo_limit | 18:28 |
| lbragstad | https://pasted.tech/pastes/e779534c72a5fb34018e28b71e391e92e89c82f6.raw gives me https://pasted.tech/pastes/b099f97bd43c807ba9a8a1dd9ba2288d91710cd7.raw | 18:29 |
| bnemec | lbragstad: I don't see anything there that would be registering the opts. | 18:31 |
| bnemec | I think you need: | 18:31 |
| bnemec | from oslo_limit import opts | 18:31 |
| bnemec | opts.register_opts(cfg.CONF) | 18:31 |
| lbragstad | in oslo_limit/limit.py? | 18:32 |
| bnemec | In your test script. | 18:32 |
| bnemec | Something like: https://pasted.tech/pastes/bf919fdc525f72fa7809012ca055ac6f435e56a7 | 18:34 |
| lbragstad | interesting.. just did that and it didn't work | 18:35 |
| lbragstad | https://pasted.tech/pastes/0c96b0a543aa04874ada8f13d952b94867de846a.raw | 18:35 |
| bnemec | Still a NoSuchOptError? | 18:36 |
| lbragstad | https://pasted.tech/pastes/fa30e4e761ecdde1f2ebe6c05b93f646e3f40e01.raw | 18:36 |
| lbragstad | yup | 18:36 |
| bnemec | Weird. That only has the internal oslo.config stuff present. | 18:38 |
| lbragstad | right | 18:38 |
| lbragstad | it doesn't look registered? | 18:39 |
| lbragstad | kind of an aside, but.. | 18:40 |
| lbragstad | it looks like we're using two different config objects | 18:41 |
| lbragstad | https://opendev.org/openstack/oslo.limit/src/branch/master/oslo_limit/opts.py#L52-L53 | 18:41 |
| *** tosky has quit IRC | 18:41 | |
| lbragstad | oh - maybe note | 18:41 |
| lbragstad | not* | 18:41 |
| bnemec | Yeah, should both be cfg.CONF. Just the shorthand name. | 18:42 |
| lbragstad | register_opts takes one argument that we only use on line 55 | 18:43 |
| bnemec | lbragstad: OH. s/endpoint_url/endpoint_id/ | 18:48 |
| bnemec | endpoint_url legitimately doesn't exist. :-) | 18:48 |
| lbragstad | ugh... | 18:48 |
| * lbragstad facepalm | 18:49 | |
| lbragstad | sorry | 18:49 |
| bnemec | Heh, Monday. | 18:49 |
| lbragstad | clearly | 18:50 |
| lbragstad | looks like it still trips over the auth_type option | 18:50 |
| lbragstad | but that might be from not registering the ksa options? | 18:50 |
| lbragstad | er, where ever those are registered | 18:50 |
| lbragstad | well - ksa can't have oslo dependencies | 18:52 |
| lbragstad | but we do have https://opendev.org/openstack/keystoneauth/src/branch/master/keystoneauth1/loading/__init__.py#L66 | 18:54 |
| bnemec | Yeah, you've got a chicken-and-egg problem with overriding auth_type if it's all handled in register_opts. | 18:58 |
| bnemec | You can't do overrides before calling register_opts, but you can't register ksa opts without auth_type overridden. | 18:58 |
| bnemec | I guess maybe you could call register_opts a second time? | 18:58 |
| bnemec | register_opts | 18:59 |
| bnemec | set_override on auth_type | 18:59 |
| bnemec | register_opts again | 18:59 |
| bnemec | That's super hacky, but for a test script it might work. | 18:59 |
| lbragstad | right | 18:59 |
| *** e0ne has quit IRC | 19:00 | |
| bnemec | Honestly, it might be just as easy to hard-code a file path in the test script and just write the options you need to set in there. | 19:01 |
| *** e0ne has joined #openstack-oslo | 19:03 | |
| lbragstad | do CONF objects take a file path? | 19:04 |
| bnemec | This is a lot of running around to avoid calling cfg.CONF(['--config-file', 'test.conf']) | 19:04 |
| bnemec | Yeah, like that^ | 19:04 |
| bnemec | That call can be done before opts are registered too. The opts just won't be exposed on the conf object until they're registered, but the values will be stored. | 19:05 |
| lbragstad | sweet | 19:09 |
| lbragstad | that might work better | 19:09 |
| lbragstad | https://pasted.tech/pastes/ff09b34499b9985408e89766be75f15583985953.raw gives me https://pasted.tech/pastes/20de7504d127a85bdbaa42fed552d55f4d15d528.raw | 19:10 |
| lbragstad | so it's actually loading stuff | 19:10 |
| lbragstad | looks like i'm just missing some other options | 19:10 |
| bnemec | Yep, looks like progress. | 19:12 |
| *** e0ne has quit IRC | 19:16 | |
| *** e0ne has joined #openstack-oslo | 19:19 | |
| *** e0ne has quit IRC | 19:36 | |
| *** e0ne has joined #openstack-oslo | 19:49 | |
| *** bnemec has quit IRC | 20:00 | |
| *** bnemec has joined #openstack-oslo | 20:08 | |
| *** e0ne has quit IRC | 20:34 | |
| *** kgiusti has quit IRC | 20:35 | |
| *** pcaruana has quit IRC | 20:44 | |
| *** e0ne has joined #openstack-oslo | 20:46 | |
| *** e0ne has quit IRC | 20:47 | |
| *** ansmith has quit IRC | 20:53 | |
| *** ianychoi_ has joined #openstack-oslo | 21:19 | |
| *** ianychoi has quit IRC | 21:22 | |
| *** ianychoi_ has quit IRC | 21:30 | |
| *** ianychoi_ has joined #openstack-oslo | 21:31 | |
| *** raildo has quit IRC | 21:40 | |
| *** boden has quit IRC | 21:47 | |
| openstackgerrit | Merged openstack/oslo.log master: Schedule a periodical check of requirements to catch py2.7 issues quickly https://review.opendev.org/659289 | 22:24 |
| openstackgerrit | Lance Bragstad proposed openstack/oslo.limit master: Flush out basic enforcer and model relationship https://review.opendev.org/666444 | 22:36 |
| openstackgerrit | Lance Bragstad proposed openstack/oslo.limit master: WIP put together example and smooth out issues https://review.opendev.org/667242 | 22:36 |
| *** lbragstad has quit IRC | 22:41 | |
| *** rcernin has joined #openstack-oslo | 22:51 | |
| *** ansmith has joined #openstack-oslo | 23:43 | |
| *** rcernin has quit IRC | 23:59 | |
| *** rcernin has joined #openstack-oslo | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!