*** rcernin has quit IRC | 00:07 | |
*** samueldmq has quit IRC | 00:12 | |
*** rcernin has joined #openstack-oslo | 01:05 | |
openstackgerrit | wayen proposed openstack/tooz master: Avoid redis lock's expire_time exceeding timeout. https://review.opendev.org/649629 | 01:52 |
---|---|---|
openstackgerrit | wayen proposed openstack/tooz master: Referencing testenv deps now works https://review.opendev.org/651057 | 02:03 |
openstackgerrit | wayen proposed openstack/tooz master: Avoid redis lock's expire_time exceeding timeout. https://review.opendev.org/649629 | 02:11 |
*** altlogbot_2 has quit IRC | 02:12 | |
*** altlogbot_3 has joined #openstack-oslo | 02:13 | |
*** gmann has joined #openstack-oslo | 02:42 | |
*** dave-mccowan has quit IRC | 03:14 | |
*** pcaruana has joined #openstack-oslo | 05:08 | |
*** pcaruana has quit IRC | 05:16 | |
*** pcaruana has joined #openstack-oslo | 05:17 | |
*** imacdonn has quit IRC | 05:42 | |
*** imacdonn has joined #openstack-oslo | 05:42 | |
*** lpetrut has joined #openstack-oslo | 05:45 | |
*** lpetrut has quit IRC | 05:46 | |
*** lpetrut has joined #openstack-oslo | 05:46 | |
*** Luzi has joined #openstack-oslo | 06:01 | |
*** starborn has joined #openstack-oslo | 06:59 | |
*** hberaud|gone is now known as hberaud | 07:03 | |
openstackgerrit | Natal Ngétal proposed openstack/oslo.log stable/stein: Replace git.openstack.org URLs with opendev.org URLs https://review.opendev.org/658296 | 07:25 |
*** gmann has quit IRC | 07:28 | |
*** mnaser has quit IRC | 07:35 | |
*** rcernin has quit IRC | 07:36 | |
*** jungleboyj has quit IRC | 07:40 | |
*** jungleboyj has joined #openstack-oslo | 07:43 | |
*** mnaser has joined #openstack-oslo | 07:43 | |
*** ralonsoh has joined #openstack-oslo | 07:50 | |
*** e0ne has joined #openstack-oslo | 07:51 | |
*** mnaser has quit IRC | 08:02 | |
*** iurygregory has joined #openstack-oslo | 08:03 | |
*** jungleboyj has quit IRC | 08:04 | |
*** mnaser has joined #openstack-oslo | 08:05 | |
*** geekinutah has quit IRC | 08:06 | |
*** gsantomaggio has quit IRC | 08:06 | |
*** jungleboyj has joined #openstack-oslo | 08:07 | |
*** rm_work has quit IRC | 08:09 | |
*** gsantomaggio has joined #openstack-oslo | 08:10 | |
*** rm_work has joined #openstack-oslo | 08:10 | |
*** geekinutah has joined #openstack-oslo | 08:10 | |
*** tosky has joined #openstack-oslo | 08:10 | |
openstackgerrit | Merged openstack/pbr master: Remove neutron-lbaas https://review.opendev.org/658643 | 08:21 |
*** trident has quit IRC | 08:33 | |
*** trident has joined #openstack-oslo | 08:34 | |
*** tesseract has joined #openstack-oslo | 08:48 | |
openstackgerrit | Hervé Beraud proposed openstack/pbr master: Read description file as utf-8 https://review.opendev.org/564874 | 08:50 |
openstackgerrit | Hervé Beraud proposed openstack/pbr master: Read description file as utf-8 https://review.opendev.org/564874 | 08:52 |
openstackgerrit | Hervé Beraud proposed openstack/pbr master: Read description file as utf-8 https://review.opendev.org/564874 | 09:00 |
*** lpetrut has quit IRC | 09:46 | |
*** hberaud is now known as hberaud|school-r | 09:55 | |
*** tesseract has quit IRC | 09:56 | |
*** tesseract has joined #openstack-oslo | 09:59 | |
*** tesseract has quit IRC | 10:00 | |
*** tesseract has joined #openstack-oslo | 10:01 | |
*** hberaud|school-r is now known as hberaud|lunch | 10:05 | |
*** gmann has joined #openstack-oslo | 11:02 | |
*** raildo has joined #openstack-oslo | 11:03 | |
*** tesseract has quit IRC | 11:10 | |
*** hberaud|lunch is now known as hberaud | 11:20 | |
*** njohnston has joined #openstack-oslo | 11:32 | |
*** jaosorior has joined #openstack-oslo | 12:06 | |
*** dims has left #openstack-oslo | 12:19 | |
*** e0ne has quit IRC | 12:52 | |
*** e0ne has joined #openstack-oslo | 13:01 | |
*** ansmith has joined #openstack-oslo | 13:04 | |
openstackgerrit | Sorin Sbarnea proposed openstack/pbr master: Allow git-tags to be SemVer compliant https://review.opendev.org/618569 | 13:22 |
*** bnemec is now known as beekneemech | 14:14 | |
*** stephenfin is now known as finucannot | 14:14 | |
*** starborn has quit IRC | 14:15 | |
*** jaosorior has quit IRC | 14:23 | |
*** Anticime1 is now known as Anticimex | 14:26 | |
*** hberaud is now known as hberaud|school-r | 14:27 | |
*** hberaud|school-r is now known as hberaud | 14:32 | |
openstackgerrit | Hervé Beraud proposed openstack/oslo-specs master: [WIP] allow customers to use python standard threads on rabbitmq driver https://review.opendev.org/661314 | 14:50 |
*** e0ne has quit IRC | 15:08 | |
*** e0ne has joined #openstack-oslo | 15:11 | |
*** e0ne has quit IRC | 15:14 | |
*** e0ne has joined #openstack-oslo | 15:15 | |
openstackgerrit | Sean McGinnis proposed openstack/oslo.upgradecheck master: Enable JSON results output https://review.opendev.org/661334 | 15:30 |
finucannot | smcginnis: Any reason not to switch to actually switch to cliff? ^ | 15:32 |
smcginnis | finucannot: It seemed overkill, so I thought I would propose this as a simpler solution. | 15:41 |
smcginnis | finucannot: Of course, open to just dropping this one if there is more desire to switch to cliff. | 15:43 |
openstackgerrit | Merged openstack/oslo.messaging stable/stein: Cap Bandit below 1.6.0 and update Sphinx requirement https://review.opendev.org/660389 | 15:47 |
*** Luzi has quit IRC | 15:50 | |
finucannot | smcginnis: Lemme think about it. I'd personally like to see cliff used across the board but if it's a lot of effort/breaking changes, I could avoid that | 15:53 |
*** e0ne has quit IRC | 16:04 | |
openstackgerrit | Merged openstack/taskflow stable/stein: Update Sphinx requirement https://review.opendev.org/660605 | 16:10 |
*** bobh has joined #openstack-oslo | 16:23 | |
*** bobh has quit IRC | 16:23 | |
*** iurygregory has quit IRC | 16:32 | |
*** bobh has joined #openstack-oslo | 16:33 | |
openstackgerrit | Ben Nemec proposed openstack/oslo.versionedobjects master: Cap Bandit below 1.6.0 https://review.opendev.org/661360 | 16:56 |
*** hberaud is now known as hberaud|gone | 17:03 | |
*** ralonsoh has quit IRC | 17:06 | |
openstackgerrit | Ben Nemec proposed openstack/oslo.versionedobjects master: Cap Bandit below 1.6.0, update sphinx requirement, uncap jsonschema https://review.opendev.org/661360 | 17:19 |
*** bobh has quit IRC | 17:38 | |
*** pcaruana has quit IRC | 17:53 | |
*** e0ne has joined #openstack-oslo | 17:54 | |
*** finucannot is now known as stephenfin | 18:05 | |
*** e0ne has quit IRC | 18:26 | |
*** e0ne has joined #openstack-oslo | 18:31 | |
*** pcaruana has joined #openstack-oslo | 18:48 | |
*** pcaruana has quit IRC | 18:48 | |
*** lbragstad has joined #openstack-oslo | 18:59 | |
*** tosky has quit IRC | 19:16 | |
gsantomaggio | @beekneemech hi, | 19:22 |
gsantomaggio | I was looking https://review.opendev.org/#/c/661314/ | 19:22 |
gsantomaggio | but the heartbeat is already a native thread https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/_drivers/impl_rabbit.py#L900 | 19:22 |
gsantomaggio | So, I am not understanding exactly the issue | 19:23 |
beekneemech | gsantomaggio: I think we're in agreement. That's basically what my comment on the review is pointing out. | 19:24 |
beekneemech | Although I didn't actually look at the code to verify. ;-) | 19:24 |
beekneemech | I am usrprised that we're using the eventlet Event there. That probably adds a hard Eventlet dependency. | 19:25 |
beekneemech | Oh, no it doesn't: https://github.com/openstack/oslo.utils/blob/master/oslo_utils/eventletutils.py#L182 | 19:26 |
beekneemech | It just does the right thing depending on whether eventlet is in use. Good. | 19:26 |
gsantomaggio | Ok | 19:32 |
gsantomaggio | I will add a comment about that, maybe I am missing something. | 19:36 |
gsantomaggio | @beekneemech I was wondering if we have to give a name to threads we have inside olso, something like: | 19:36 |
gsantomaggio | ``` | 19:36 |
gsantomaggio | self._heartbeat_thread = threading.Thread( | 19:36 |
gsantomaggio | target=self._heartbeat_thread_job, name="Rabbit-heartbeat") | 19:36 |
gsantomaggio | ``` | 19:36 |
gsantomaggio | the debug will be easier, like: | 19:38 |
gsantomaggio | ``` | 19:38 |
gsantomaggio | <_MainThread(MainThread, started 140613908682560)>, <_DummyThread(Dummy-2, started daemon 140613816592128)>, <Thread(Thread-3, started daemon 140613722932992)>, <_DummyThread(Dummy-5, started daemon 140613714540288)>, <Thread(Thread-4, started daemon 140613706147584)>, <Thread(RabbitMQ_heartbeat, started daemon 140613697754880)>, <Thread(RabbitMQ_heartbeat, started daemon 140613689362176)>] | 19:38 |
gsantomaggio | ``` | 19:38 |
beekneemech | gsantomaggio: Sounds like a good idea to me. | 19:38 |
gsantomaggio | is it a problem in python to give the same threadname? | 19:39 |
openstackgerrit | Gabriele Santomaggio proposed openstack/oslo.messaging master: Add thread name to the RabbitMQ heartbeat thread https://review.opendev.org/661388 | 20:03 |
*** ansmith has quit IRC | 20:04 | |
beekneemech | Not sure about thread names. I don't know that I've ever named any of my Python threads. | 20:06 |
gsantomaggio | ``` | 20:14 |
gsantomaggio | name | 20:14 |
gsantomaggio | A string used for identification purposes only. It has no semantics. Multiple threads may be given the same name. The initial name is set by the constructor. | 20:14 |
gsantomaggio | ``` | 20:14 |
gsantomaggio | https://docs.python.org/2/library/threading.html | 20:14 |
gsantomaggio | @beekneemech | 20:14 |
beekneemech | gsantomaggio: Cool | 20:15 |
*** aspiers has quit IRC | 20:38 | |
*** ansmith has joined #openstack-oslo | 20:53 | |
*** aspiers has joined #openstack-oslo | 20:57 | |
*** raildo has quit IRC | 21:35 | |
*** e0ne has quit IRC | 21:40 | |
openstackgerrit | Merged openstack/oslo.versionedobjects master: Cap Bandit below 1.6.0, update sphinx requirement, uncap jsonschema https://review.opendev.org/661360 | 21:40 |
*** lbragstad has quit IRC | 21:52 | |
*** rcernin has joined #openstack-oslo | 23:05 | |
*** rcernin has quit IRC | 23:11 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!