| *** bobh has joined #openstack-oslo | 00:05 | |
| *** bobh has quit IRC | 00:10 | |
| *** imacdonn has quit IRC | 00:58 | |
| *** gmann has quit IRC | 01:43 | |
| *** bobh has joined #openstack-oslo | 02:02 | |
| *** bobh has quit IRC | 02:07 | |
| *** altlogbot_0 has quit IRC | 02:41 | |
| *** altlogbot_3 has joined #openstack-oslo | 02:43 | |
| *** altlogbot_3 has quit IRC | 03:31 | |
| *** altlogbot_2 has joined #openstack-oslo | 03:32 | |
| *** larainema has quit IRC | 03:42 | |
| *** lpetrut has joined #openstack-oslo | 05:54 | |
| openstackgerrit | tonybrad proposed openstack/sphinx-feature-classification master: Change the deps source https://review.opendev.org/657325 | 07:01 |
|---|---|---|
| *** tesseract-RH has joined #openstack-oslo | 07:05 | |
| *** altlogbot_2 has quit IRC | 07:13 | |
| *** altlogbot_0 has joined #openstack-oslo | 07:18 | |
| *** yan0s has joined #openstack-oslo | 07:26 | |
| *** tosky has joined #openstack-oslo | 07:28 | |
| *** iurygregory has joined #openstack-oslo | 07:43 | |
| *** dmellado has quit IRC | 07:44 | |
| *** dmellado has joined #openstack-oslo | 07:44 | |
| *** pcaruana has joined #openstack-oslo | 08:24 | |
| *** altlogbot_0 has quit IRC | 09:11 | |
| *** altlogbot_3 has joined #openstack-oslo | 09:16 | |
| *** gibi_cape is now known as gibi | 09:24 | |
| *** gmann has joined #openstack-oslo | 09:41 | |
| openstackgerrit | Merged openstack/osprofiler master: change function list_traces of mongodb module https://review.opendev.org/656929 | 09:53 |
| *** gmann is now known as gmann_pto | 09:57 | |
| *** raildo has joined #openstack-oslo | 10:27 | |
| *** takamatsu has joined #openstack-oslo | 10:36 | |
| *** larainema has joined #openstack-oslo | 10:46 | |
| *** altlogbot_3 has quit IRC | 11:19 | |
| *** ansmith has quit IRC | 11:21 | |
| *** jaosorior has joined #openstack-oslo | 11:21 | |
| *** altlogbot_2 has joined #openstack-oslo | 11:21 | |
| openstackgerrit | Merged openstack/osprofiler master: Fix elasticsearch version in python requirements https://review.opendev.org/656192 | 11:52 |
| *** bobh has joined #openstack-oslo | 12:06 | |
| *** bobh has quit IRC | 12:09 | |
| *** altlogbot_2 has quit IRC | 12:14 | |
| *** altlogbot_0 has joined #openstack-oslo | 12:20 | |
| *** pcaruana has quit IRC | 12:29 | |
| *** ansmith has joined #openstack-oslo | 12:42 | |
| *** kgiusti has joined #openstack-oslo | 12:53 | |
| *** altlogbot_0 has quit IRC | 13:15 | |
| *** pcaruana has joined #openstack-oslo | 13:16 | |
| *** altlogbot_1 has joined #openstack-oslo | 13:17 | |
| *** mmethot has joined #openstack-oslo | 13:19 | |
| *** altlogbot_1 has quit IRC | 13:21 | |
| *** altlogbot_1 has joined #openstack-oslo | 13:25 | |
| *** altlogbot_1 has quit IRC | 13:25 | |
| *** altlogbot_0 has joined #openstack-oslo | 13:26 | |
| *** lbragstad has joined #openstack-oslo | 13:32 | |
| *** raildo has quit IRC | 13:41 | |
| *** zaneb has joined #openstack-oslo | 13:44 | |
| *** ianychoi has quit IRC | 13:48 | |
| *** bnemec has joined #openstack-oslo | 13:50 | |
| *** ianychoi has joined #openstack-oslo | 13:52 | |
| *** zaneb has quit IRC | 13:55 | |
| *** zbitter has joined #openstack-oslo | 13:55 | |
| *** zbitter is now known as zaneb | 13:55 | |
| *** raildo has joined #openstack-oslo | 14:00 | |
| *** ianychoi has quit IRC | 14:04 | |
| *** ianychoi has joined #openstack-oslo | 14:18 | |
| *** samueldmq has joined #openstack-oslo | 14:27 | |
| *** lpetrut has quit IRC | 14:36 | |
| gsantomaggio | hi, | 15:10 |
| gsantomaggio | about the mandatory flag, do you prefer: | 15:10 |
| gsantomaggio | 1- to add another parameter to the `publish` function: | 15:10 |
| gsantomaggio | https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/_drivers/impl_rabbit.py#L1120 | 15:10 |
| gsantomaggio | 2 - to add a config parameter, something like https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/_drivers/impl_rabbit.py#L106 `rabbit_mandatory flag` | 15:10 |
| gsantomaggio | 1 is more complex than the 2 ( nothing impossible) | 15:10 |
| gsantomaggio | cc @kgiusti | 15:10 |
| *** imacdonn has joined #openstack-oslo | 15:11 | |
| kgiusti | gsantomaggio: I would guess that a parameter would be better than a config flag - a parameter would give the use a choice on a case by case basis rather than forcing an all or nothing approach. | 15:20 |
| gsantomaggio | @kgiusti I agree, I will add a `struct`, so in the future will be easy to add other parameters instead of changing the function interface, something like: | 15:28 |
| gsantomaggio | ``` | 15:28 |
| gsantomaggio | publish_options = { | 15:28 |
| gsantomaggio | 'mandatory': True, | 15:28 |
| gsantomaggio | 'another_possible_parameter': True | 15:28 |
| gsantomaggio | } | 15:28 |
| gsantomaggio | def _publish(self, exchange, msg, routing_key=None, timeout=None, publish_options=publish_options): | 15:28 |
| gsantomaggio | ``` | 15:28 |
| gsantomaggio | what do you thing ? | 15:28 |
| gsantomaggio | @kgiusti I agree, I will add a `struct`, so in the future will be easy to add other parameters instead of changing the function interface, something like: | 15:28 |
| gsantomaggio | ``` | 15:28 |
| gsantomaggio | publish_options = { | 15:28 |
| gsantomaggio | 'mandatory': True, | 15:28 |
| gsantomaggio | 'another_possible_parameter': True | 15:28 |
| gsantomaggio | } | 15:28 |
| kgiusti | gsantomaggio: +1 | 15:29 |
| *** yan0s has quit IRC | 15:59 | |
| *** gmann_pto has quit IRC | 16:56 | |
| *** jaosorior has quit IRC | 17:14 | |
| *** tesseract-RH has quit IRC | 17:24 | |
| openstackgerrit | Merged openstack/taskflow master: Uncap jsonschema https://review.opendev.org/649803 | 17:31 |
| *** adrianc has quit IRC | 17:40 | |
| *** adrianc has joined #openstack-oslo | 17:43 | |
| *** adrianc has quit IRC | 17:48 | |
| *** adrianc has joined #openstack-oslo | 19:26 | |
| *** larainema_ has joined #openstack-oslo | 19:35 | |
| *** adrianc_ has joined #openstack-oslo | 19:35 | |
| *** kgiusti has quit IRC | 19:39 | |
| *** adrianc has quit IRC | 19:39 | |
| *** larainema has quit IRC | 19:39 | |
| *** larainema_ is now known as larainema | 19:39 | |
| *** kgiusti has joined #openstack-oslo | 19:39 | |
| openstackgerrit | Adam Spiers proposed openstack/cookiecutter master: Fix outdated references to git.openstack.org/cgit/ https://review.opendev.org/657444 | 19:46 |
| *** takamatsu has quit IRC | 19:51 | |
| openstackgerrit | Merged openstack/taskflow stable/stein: Raise lower constraint of psycopg2 https://review.opendev.org/651272 | 20:07 |
| *** raildo has quit IRC | 20:11 | |
| *** raildo has joined #openstack-oslo | 20:11 | |
| *** kgiusti has quit IRC | 20:17 | |
| *** ansmith has quit IRC | 20:34 | |
| *** pcaruana has quit IRC | 20:51 | |
| openstackgerrit | Ben Nemec proposed openstack/tooz master: Uncap grpcio https://review.opendev.org/657454 | 21:06 |
| *** ansmith has joined #openstack-oslo | 22:04 | |
| *** raildo has quit IRC | 22:26 | |
| *** rcernin has joined #openstack-oslo | 22:48 | |
| *** tosky has quit IRC | 23:32 | |
| *** mmethot has quit IRC | 23:45 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!