*** tosky has quit IRC | 00:02 | |
*** edmondsw has quit IRC | 00:17 | |
*** agopi has joined #openstack-oslo | 00:25 | |
*** nsmeds has quit IRC | 00:27 | |
*** lbragstad has quit IRC | 00:59 | |
*** nsmeds has joined #openstack-oslo | 01:15 | |
*** takamatsu_ has quit IRC | 01:39 | |
*** edmondsw has joined #openstack-oslo | 01:43 | |
*** takamatsu_ has joined #openstack-oslo | 01:45 | |
*** lbragstad has joined #openstack-oslo | 01:58 | |
*** rcernin has quit IRC | 02:32 | |
*** takamatsu_ has quit IRC | 02:53 | |
*** dkehn has quit IRC | 04:56 | |
*** dave-mccowan has quit IRC | 05:05 | |
*** njohnston has quit IRC | 06:27 | |
*** Luzi has joined #openstack-oslo | 06:47 | |
*** e0ne has joined #openstack-oslo | 07:09 | |
*** aojea has joined #openstack-oslo | 07:16 | |
*** e0ne has quit IRC | 07:16 | |
*** takamatsu_ has joined #openstack-oslo | 07:21 | |
*** e0ne has joined #openstack-oslo | 07:57 | |
*** lbragstad has quit IRC | 08:01 | |
*** pcaruana has joined #openstack-oslo | 08:13 | |
*** pcaruana has quit IRC | 08:28 | |
*** hberaud|gone is now known as hberaud | 08:31 | |
*** takamatsu_ has quit IRC | 08:31 | |
*** tosky has joined #openstack-oslo | 08:41 | |
*** pcaruana has joined #openstack-oslo | 08:42 | |
*** pcaruana has quit IRC | 08:51 | |
*** e0ne has quit IRC | 08:57 | |
*** pcaruana has joined #openstack-oslo | 08:58 | |
*** pcaruana|afk| has joined #openstack-oslo | 09:01 | |
*** pcaruana has quit IRC | 09:03 | |
*** takamatsu has joined #openstack-oslo | 09:15 | |
*** shachar has quit IRC | 09:28 | |
*** Luzi has quit IRC | 09:36 | |
*** takamatsu has quit IRC | 09:44 | |
*** Luzi has joined #openstack-oslo | 09:51 | |
*** snapiri has joined #openstack-oslo | 10:07 | |
*** moguimar has joined #openstack-oslo | 11:16 | |
*** e0ne has joined #openstack-oslo | 11:16 | |
*** takamatsu has joined #openstack-oslo | 11:24 | |
*** hberaud is now known as hberaud|lunch | 11:31 | |
*** a-pugachev has joined #openstack-oslo | 11:46 | |
*** a-pugachev has quit IRC | 11:46 | |
*** a-pugachev has joined #openstack-oslo | 11:47 | |
*** a-pugachev has quit IRC | 12:00 | |
*** Luzi has quit IRC | 12:00 | |
*** Luzi has joined #openstack-oslo | 12:02 | |
*** a-pugachev has joined #openstack-oslo | 12:06 | |
*** raildo has joined #openstack-oslo | 12:22 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/oslo.privsep master: Convert dict keys received in _ClientChannel from byte to str https://review.openstack.org/638216 | 12:30 |
---|---|---|
*** hberaud|lunch is now known as hberaud | 12:37 | |
*** ansmith has quit IRC | 12:43 | |
*** agopi has quit IRC | 12:59 | |
*** njohnston has joined #openstack-oslo | 13:01 | |
*** dave-mccowan has joined #openstack-oslo | 13:04 | |
*** pcaruana|afk| has quit IRC | 13:09 | |
*** kgiusti has joined #openstack-oslo | 13:20 | |
*** a-pugachev has quit IRC | 13:29 | |
*** a-pugachev has joined #openstack-oslo | 13:30 | |
openstackgerrit | Hervé Beraud proposed openstack-dev/pbr master: Fix error when keywords are defined as a list in cfg https://review.openstack.org/639661 | 13:31 |
*** agopi has joined #openstack-oslo | 13:35 | |
*** ansmith has joined #openstack-oslo | 13:36 | |
*** a-pugachev has quit IRC | 13:39 | |
*** agopi has quit IRC | 13:40 | |
*** a-pugachev has joined #openstack-oslo | 13:41 | |
*** a-pugachev has quit IRC | 13:43 | |
*** a-pugachev has joined #openstack-oslo | 13:44 | |
openstackgerrit | Hervé Beraud proposed openstack-dev/pbr master: Fix error when keywords are defined as a list in cfg https://review.openstack.org/639661 | 13:48 |
*** e0ne has quit IRC | 13:50 | |
*** e0ne has joined #openstack-oslo | 14:04 | |
*** hberaud has quit IRC | 14:06 | |
*** hberaud has joined #openstack-oslo | 14:06 | |
*** agopi has joined #openstack-oslo | 14:08 | |
*** Luzi has quit IRC | 14:17 | |
*** lbragstad has joined #openstack-oslo | 14:20 | |
*** moguimar has quit IRC | 14:31 | |
*** moguimar has joined #openstack-oslo | 14:48 | |
*** pcaruana has joined #openstack-oslo | 14:57 | |
openstackgerrit | Hervé Beraud proposed openstack-dev/pbr master: Fix error when keywords are defined as a list in cfg https://review.openstack.org/639661 | 15:21 |
openstackgerrit | Hervé Beraud proposed openstack-dev/pbr master: Fix error when keywords are defined as a list in cfg https://review.openstack.org/639661 | 15:39 |
*** dmellado has quit IRC | 15:42 | |
*** dmellado has joined #openstack-oslo | 15:43 | |
kmalloc | hberaud: saw your email. i think i was mistaken about the dogpile test in oslo. | 15:48 |
kmalloc | hberaud: it was sane to just delete it. | 15:49 |
hberaud | ack | 15:49 |
hberaud | kmalloc: we have discuss about this yesterday with zzzeek and bnemec | 15:50 |
hberaud | kmalloc: we want to fix and keep test in oslo.cache side in a first time | 15:50 |
hberaud | kmalloc: and migrate test into dogpile.cache instead these tests are out of the oslo scope | 15:51 |
hberaud | kmalloc: https://github.com/sqlalchemy/dogpile.cache/pull/145 | 15:51 |
bnemec | I think we would be covered to just remove it at this point too. dogpile covers the kwarg case in https://github.com/sqlalchemy/dogpile.cache/blob/master/tests/cache/test_decorator.py#L219 | 15:51 |
hberaud | bnemec: it's not really the same test | 15:52 |
hberaud | bnemec: this test directly use dogpile.cache utils | 15:53 |
kmalloc | ++ | 15:53 |
hberaud | bnemec: and they don't cover the decorator problem | 15:53 |
bnemec | hberaud: It's verifying that the decorator raises when it gets kwargs. | 15:53 |
bnemec | The change here was that it doesn't get kwargs in some cases where it used to. | 15:53 |
kmalloc | hberaud: i just wanted to be sure you knew I read the email, but here not just the @rh side ;) | 15:53 |
hberaud | sure but not really in the same inception way | 15:53 |
hberaud | kmalloc: thx :) | 15:55 |
*** a-pugachev has quit IRC | 15:58 | |
*** a-pugachev has joined #openstack-oslo | 16:07 | |
*** takamatsu has quit IRC | 16:09 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/oslo.privsep master: Convert dict keys received in _ClientChannel from byte to str https://review.openstack.org/638216 | 16:17 |
*** aojea has quit IRC | 16:20 | |
openstackgerrit | Ben Nemec proposed openstack/oslo.cache master: Fix memcache pool client in monkey-patched environments https://review.openstack.org/639457 | 16:23 |
openstackgerrit | Ben Nemec proposed openstack/oslo.cache master: Fix memcache issue due to the __new__ attribute reassign. https://review.openstack.org/634457 | 16:23 |
openstackgerrit | Ben Nemec proposed openstack/oslo.cache master: Remove dogpile kwarg test https://review.openstack.org/638732 | 16:23 |
* bnemec crosses his fingers that he didn't screw up that rebase | 16:24 | |
bnemec | Hey, looks good. | 16:24 |
bnemec | hberaud: I rebased everything in the order that I think they should merge^ | 16:25 |
hberaud | bnemec: great! thanks | 16:25 |
bnemec | All of the votes carried over so I don't think I hosed anything up. :-) | 16:25 |
hberaud | ack | 16:25 |
bnemec | I did drop your WIP followup. It wasn't current with the latest patch set of the dependencies anyway. | 16:26 |
bnemec | It's still there of course, it's just not in the series. | 16:26 |
hberaud | bnemec: ack | 16:27 |
*** dmellado has quit IRC | 16:32 | |
*** dmellado has joined #openstack-oslo | 16:34 | |
kmalloc | bnemec: i think i prefer pymemcache fix to eventlet-specific hacky-code | 16:39 |
kmalloc | but i'll support either | 16:39 |
bnemec | kmalloc: The hack is only for backportability. | 16:44 |
bnemec | I want it to die in a fire ASAP. | 16:45 |
bnemec | I rebased everything in order on https://review.openstack.org/#/q/topic:all-the-fixes+(status:open+OR+status:merged) | 16:46 |
*** pcaruana has quit IRC | 16:57 | |
*** e0ne has quit IRC | 17:00 | |
*** a-pugachev has quit IRC | 17:01 | |
*** a-pugachev has joined #openstack-oslo | 17:04 | |
kmalloc | Will +2 the stack shortly | 17:13 |
kmalloc | At the doctor's office right now | 17:13 |
kmalloc | Back in 30-40m | 17:13 |
bnemec | ack, thanks | 17:28 |
openstackgerrit | Hervé Beraud proposed openstack/oslo.cache master: Switch from python-memcached to pymemcache. https://review.openstack.org/634457 | 17:32 |
*** dims has quit IRC | 17:35 | |
*** takamatsu has joined #openstack-oslo | 17:41 | |
hberaud | bnemec: changes on mine done | 17:41 |
*** dims has joined #openstack-oslo | 17:48 | |
moguimar | bnemec: should I update other oslo projects accortding to https://review.openstack.org/#/c/639655/ ? | 17:51 |
bnemec | moguimar: No. Did you see the latest responses to your thread? | 17:52 |
bnemec | There are still quite a few projects with py35 jobs running because of the bionic migration not being complete yet. | 17:52 |
bnemec | So I'd prefer to hold off on the Oslo libs so we don't accidentally break someone. | 17:53 |
bnemec | I don't think we need to add py35 back to any projects that removed it, but let's not make any more of those changes for now. | 17:53 |
*** a-pugachev has quit IRC | 17:54 | |
*** takamatsu has quit IRC | 18:01 | |
moguimar | ok | 18:02 |
*** moguimar has quit IRC | 18:03 | |
*** hberaud is now known as hberaud|gone | 18:29 | |
openstackgerrit | Merged openstack/oslo.cache master: fix dogpile.cache issue due to the new usage of decorate in the lib https://review.openstack.org/638788 | 18:29 |
*** takamatsu has joined #openstack-oslo | 18:52 | |
bnemec | \o/ | 18:57 |
*** e0ne has joined #openstack-oslo | 18:58 | |
*** lbragstad has quit IRC | 19:39 | |
*** lbragstad has joined #openstack-oslo | 19:41 | |
openstackgerrit | Eric Harney proposed openstack/oslo.privsep master: Add sample_default for thread_pool_size Opt https://review.openstack.org/639804 | 19:51 |
njohnston | bnemec: Quick question as I try to dig into https://bugs.launchpad.net/neutron/+bug/1817953 | 19:57 |
openstack | Launchpad bug 1817953 in neutron "oslopolicy-policy-generator does not work for neutron" [Medium,New] - Assigned to Nate Johnston (nate-johnston) | 19:58 |
*** e0ne has quit IRC | 19:59 | |
njohnston | When called as `oslopolicy-policy-generator --namespace neutron`, when we get to line 87 of oslo_policy/generator.py it looks like mgr[namespace] returns a KeyError. Does this mean it is using a different setup.cfg than I am aware of? | 20:00 |
*** e0ne has joined #openstack-oslo | 20:09 | |
bnemec | njohnston: I don't see anything obviously wrong. Maybe lbragstad will have an idea? | 20:12 |
lbragstad | bnemec njohnston i can dig in here in just a minute - wrapping something up | 20:15 |
bnemec | njohnston: Actually, that's working for me in my local copy of neutron. Is this related to some other change? | 20:15 |
njohnston | bnemec: I tried it out on a plain-jane devstack I just pulled down | 20:17 |
*** e0ne has quit IRC | 20:17 | |
bnemec | njohnston: Does the tox target work for you? | 20:18 |
lbragstad | locally - i get this https://pasted.tech/pastes/d161c315bc0ed89481adb9f70de2aac9bdbf7265.raw | 20:22 |
lbragstad | i'm running from 376fa8aef49fa45c7038be4648aecd6899fb8d4e | 20:22 |
openstackgerrit | Hervé Beraud proposed openstack/oslo.cache master: Switch from python-memcached to pymemcache. https://review.openstack.org/634457 | 20:26 |
*** e0ne has joined #openstack-oslo | 20:30 | |
njohnston | I am running from the same git hash | 20:30 |
bnemec | njohnston: Very strange. Are you running it out of the tox venv or directly on the devstack system? | 20:32 |
bnemec | Maybe devstack is not installing something that is needed for policy generation? | 20:32 |
*** e0ne has quit IRC | 20:33 | |
*** e0ne has joined #openstack-oslo | 20:35 | |
njohnston | bnemec: devstack directly. If I do a `tox -e genconfig` it works fine. | 20:35 |
njohnston | bnemec: could this occur if devstack is installing under python3 but oslopolicy-sample-generator is installing under python 2.7? | 20:35 |
bnemec | njohnston: I would think so. If it runs in a python environment where neutron was not installed then I could see it behaving like this. | 20:36 |
*** tosky has quit IRC | 20:36 | |
lbragstad | oh sure | 20:37 |
njohnston | bnemec: ok, let me try forcing oslopolicy-config-generator to py3 and see if it works | 20:37 |
*** dave-mccowan has quit IRC | 20:38 | |
bnemec | Yep, if I install oslo.policy in a venv without neutron then I also get the KeyError. | 20:39 |
lbragstad | fwiw - that error is familiar and i've seen it under similar circumstances | 20:42 |
lbragstad | i wonder if it's worth adding some logging to make it a little more apparent to the user what's actually happening | 20:42 |
bnemec | Yeah, I'm working on a patch to provide a more useful error. | 20:47 |
lbragstad | cool - i can review | 20:47 |
bnemec | Writing unit tests takes so much longer than writing the actual code on simple fixes. :-) | 20:49 |
openstackgerrit | Ben Nemec proposed openstack/oslo.policy master: Provide more specific error when namespace is missing https://review.openstack.org/639822 | 20:55 |
*** mmethot has quit IRC | 21:06 | |
*** jaosorior has quit IRC | 21:08 | |
*** redrobot has quit IRC | 21:25 | |
*** ansmith has quit IRC | 21:33 | |
*** Guest66940 has joined #openstack-oslo | 21:37 | |
*** Guest66940 is now known as redrobot | 21:38 | |
*** mmethot has joined #openstack-oslo | 21:42 | |
*** e0ne has quit IRC | 21:54 | |
*** agopi has quit IRC | 22:16 | |
*** agopi has joined #openstack-oslo | 22:20 | |
*** ansmith has joined #openstack-oslo | 22:30 | |
*** agopi has quit IRC | 22:31 | |
*** kgiusti has left #openstack-oslo | 22:34 | |
*** raildo has quit IRC | 22:37 | |
*** mmethot has quit IRC | 22:57 | |
*** rcernin has joined #openstack-oslo | 23:06 | |
*** dave-mccowan has joined #openstack-oslo | 23:18 | |
*** harlowja has joined #openstack-oslo | 23:35 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!