Friday, 2019-02-22

*** dave-mccowan has joined #openstack-oslo00:04
*** agopi has joined #openstack-oslo00:15
*** lbragstad has quit IRC00:35
*** lbragstad has joined #openstack-oslo00:39
*** dave-mccowan has quit IRC00:53
*** Liang__ has joined #openstack-oslo00:58
openstackgerritMerged openstack/oslo.messaging master: Change python3.5 job to python3.7 job on Stein+  https://review.openstack.org/61011801:23
*** takamatsu_ has joined #openstack-oslo01:26
*** takamatsu has quit IRC01:26
*** Liang__ has quit IRC02:24
*** lbragstad_ has joined #openstack-oslo02:54
*** lbragstad has quit IRC02:55
*** lpetrut has joined #openstack-oslo04:49
eanderssonAnyone that could take a look at these oslo.config hacks? https://review.openstack.org/#/c/638000/12/networking_cisco/config/base.py05:13
eanderssonNo clue what I am doing here. I mean it works, but probably not the way I should get it working.05:13
*** dougwig has joined #openstack-oslo05:16
*** lpetrut has quit IRC05:25
*** gmann has quit IRC05:28
*** lpetrut has joined #openstack-oslo05:54
*** Luzi has joined #openstack-oslo06:41
*** e0ne has joined #openstack-oslo07:29
*** e0ne has quit IRC07:43
*** e0ne has joined #openstack-oslo07:44
*** aojea has joined #openstack-oslo07:44
*** e0ne has quit IRC07:44
*** e0ne has joined #openstack-oslo07:50
*** hberaud|gone is now known as hberaud08:00
*** lbragstad_ has quit IRC08:07
*** e0ne has quit IRC08:10
*** cdent has joined #openstack-oslo08:30
*** cdent has quit IRC09:31
*** jaosorior has quit IRC09:33
*** jaosorior has joined #openstack-oslo09:35
*** yan0s has joined #openstack-oslo09:41
*** stephenfin is now known as finucannot09:48
*** takamatsu_ has quit IRC10:04
*** gibi is now known as giblet10:04
*** takamatsu has joined #openstack-oslo10:05
*** e0ne has joined #openstack-oslo10:19
*** takamatsu_ has joined #openstack-oslo10:23
*** takamatsu has quit IRC10:24
*** rcernin has quit IRC10:31
*** takamatsu_ has quit IRC10:48
*** takamatsu has joined #openstack-oslo10:49
*** takamatsu has quit IRC10:54
*** shardy has joined #openstack-oslo10:54
*** takamatsu has joined #openstack-oslo10:58
*** shardy has quit IRC11:06
*** a-pugachev has joined #openstack-oslo11:11
*** tosky has joined #openstack-oslo11:12
*** gmann has joined #openstack-oslo11:49
*** sum12 has quit IRC12:03
*** raildo has joined #openstack-oslo12:11
*** sum12 has joined #openstack-oslo12:17
*** kgiusti has joined #openstack-oslo13:08
*** dave-mccowan has joined #openstack-oslo13:19
*** sambetts_ has quit IRC13:21
*** sambetts_ has joined #openstack-oslo13:24
*** moguimar has joined #openstack-oslo13:42
*** dave-mccowan has quit IRC13:43
*** dave-mccowan has joined #openstack-oslo13:43
*** agopi has quit IRC13:44
*** agopi has joined #openstack-oslo13:54
*** agopi_ has joined #openstack-oslo13:58
*** agopi has quit IRC14:00
openstackgerritKen Giusti proposed openstack/oslo.messaging stable/rocky: Mark telemetry tests nv and remove from gate  https://review.openstack.org/63866314:00
*** dave-mccowan has quit IRC14:05
*** lbragstad_ has joined #openstack-oslo14:05
*** lbragstad_ is now known as lbragstad14:07
*** dave-mccowan has joined #openstack-oslo14:38
*** bnemec is now known as beekneemech14:39
beekneemechkgiusti: So I suppose we'll need to backport that to all the stable branches?15:15
beekneemechOr did we only add those tests recently?15:15
*** Luzi has quit IRC15:16
kgiustibeekneemech: those tests have been around a long time.  But they may still be valid for other branches - I'll check.15:19
openstackgerritKen Giusti proposed openstack/oslo.messaging stable/queens: DO NOT MERGE - testing telemetry gate  https://review.openstack.org/63868815:26
*** lbragstad is now known as elbragstad15:47
*** njohnston has quit IRC15:58
*** njohnston has joined #openstack-oslo15:59
*** njohnston has quit IRC16:00
*** njohnston has joined #openstack-oslo16:04
*** e0ne has quit IRC16:11
beekneemechkgiusti: Okay, sounds good. I guess I'm a little surprised it broke on rocky since the breakage on master was recent.16:13
beekneemechYou wouldn't think the same issue would affect rocky.16:14
beekneemechIn any case, you can probably go ahead and propose the reno backports to queens and pike. That'll be as good a gate check as any.16:14
kgiustibeekneemech: one would, but that test depends on several external projects - who knows what 'fixes' were backported....16:15
kgiustibeekneemech: kk I'll backport the releasenotes to Q and P16:15
beekneemechkgiusti: Thanks16:16
*** aojea has quit IRC16:18
*** yan0s has quit IRC16:19
*** e0ne has joined #openstack-oslo16:20
*** agopi_ is now known as agopi16:29
*** a-pugachev has quit IRC16:29
*** a-pugachev has joined #openstack-oslo16:30
*** e0ne has quit IRC16:31
*** imacdonn has quit IRC16:38
*** imacdonn has joined #openstack-oslo16:38
*** hberaud is now known as hberaud|school-r16:41
*** hberaud|school-r is now known as hberaud16:46
*** agopi is now known as agopi|lunch|trav16:54
*** agopi|lunch|trav has quit IRC16:55
*** imacdonn has quit IRC17:08
*** tosky has quit IRC17:28
*** a-pugachev has quit IRC17:34
openstackgerritBen Nemec proposed openstack/oslo.cache master: Remove dogpile kwarg test  https://review.openstack.org/63873217:46
beekneemechhberaud: ^17:46
openstackgerritKen Giusti proposed openstack/oslo.messaging stable/queens: Add release note for amqp library TLS/SSL error  https://review.openstack.org/63873317:46
beekneemechI realize you're probably on your weekend by now, but for Monday. :-)17:47
hberaudbeekneemech: ack17:47
*** takamatsu_ has joined #openstack-oslo17:48
hberaudbeekneemech: bnemec: else I think I find a fix and monday/tuesday I guess have someting that works17:48
*** takamatsu has quit IRC17:48
beekneemechhberaud: Okay, but the fix should be in dogpile.cache, right?17:48
hberaudbeekneemech: functools fix on oslo.cache core side to avoid the decorator issue17:49
hberaudbeekneemech: I need to go now I'll be away during few hours but I guess back in 2-3 hours17:50
hberaudbeekneemech: stay in touch17:50
beekneemechhberaud: Hmm, okay. I feel like this is a bug in dogpile.cache and we should push for a fix there in any case, but I'll be interested to see what you come up with.17:50
beekneemechhberaud: Thanks for investigating.17:50
hberaudbeekneemech: my pleasure17:51
hberaudbeekneemech: and not really an issue on dogpile.cache17:51
hberaudthey have introduced "decorator" and we have side effects17:51
hberaudbeekneemech: well need to go, see you17:52
beekneemechOkay, maybe I'm wrong about what's going on here. We can talk more later.17:52
*** hberaud is now known as hberaud|afk17:52
openstackgerritKen Giusti proposed openstack/oslo.messaging stable/pike: Add release note for amqp library TLS/SSL error  https://review.openstack.org/63873517:55
*** takamatsu_ has quit IRC18:03
moguimarbeekneemech: is that you Ben?18:05
beekneemechmoguimar: Yes.18:05
beekneemechCasual nick Friday. :-)18:05
moguimarxD18:05
moguimarnice18:05
moguimarwe declined one patch on castellan and fixed another bug.18:06
*** takamatsu_ has joined #openstack-oslo18:06
moguimargoing offline now18:08
moguimarsee yall next monday18:08
moguimaro/18:08
*** moguimar has quit IRC18:08
*** dave-mccowan has quit IRC18:15
eanderssonAnyone that can help me with some oslo.config stuff?18:40
eanderssonhttps://review.openstack.org/#/c/638000/13/networking_cisco/config/base.py18:40
eanderssonTrying to make cisco code work with Stein, and.. well this feels super hacky18:41
*** agopi has joined #openstack-oslo18:45
*** lpetrut has quit IRC18:51
*** lpetrut has joined #openstack-oslo19:07
*** e0ne has joined #openstack-oslo19:18
beekneemecheandersson: Why do you have to conditionalize the creation of the LocationInfo? I'm not sure why you would ever want to return None there.19:31
eanderssonbeekneemech, so I didn't design this, but it needs to work with e.g. mitaka19:33
beekneemecheandersson: I think that's what the if getattr(cfg.CONF, 'get_location', None) is doing.19:34
beekneemechOlder versions of oslo.config didn't expect to get back a tuple.19:34
beekneemechI suspect None was just a temporary thing to make the API match.19:34
beekneemechAnd I guess if you don't care about being able to determine the location for the opts it's probably fine.19:34
beekneemechBut I assume you do since you're making this change. :-)19:34
eanderssonSo the code in Stein isn't working with loc being None19:36
eanderssonbut works fine in e.g. Rocky19:36
beekneemechHmm. Let me see when we added that.19:36
eanderssonI am really just trying to get someone elses stuff work under Stein with the bare minimum amount of work19:37
eanderssonbut without doing anything stupid haha19:37
beekneemechUnderstood. I think I may have a commit in that repo for similar reasons. :-)19:38
beekneemechLocations have been around for over a year, so they should have been in Rocky too.19:39
*** dave-mccowan has joined #openstack-oslo19:43
beekneemecheandersson: I think if you just change the returns to look like this: http://paste.openstack.org/show/745766/ it should work.19:44
beekneemechThat's using all stuff that exists in any version of oslo.config with get_location.19:44
beekneemechAnd it should satisfy the oslo.config expectations for what these functions return.19:44
beekneemechI'm not exactly sure why it would have broken just in Stein, but I think this is more correct anyway.19:45
eanderssonYea troubleshooting this was really difficult19:48
eanderssonas what ever went wrong was not bubbling up19:48
beekneemechYeah, when we implemented this I don't think we considered external config types.19:49
beekneemechWe changed a bunch of internal apis and thought it was safe because they were all private.19:49
openstackgerritMorgan Fainberg proposed openstack/oslo.limit master: Add python3.7 job on Stein+  https://review.openstack.org/61064119:53
openstackgerritMerged openstack/oslo.messaging stable/rocky: Mark telemetry tests nv and remove from gate  https://review.openstack.org/63866320:07
*** lpetrut has quit IRC20:08
*** e0ne has quit IRC20:08
eanderssonThanks beekneemech20:13
eanderssonYea - makes sense20:13
beekneemechnp20:15
*** tosky has joined #openstack-oslo21:11
*** raildo has quit IRC21:15
*** hberaud|afk is now known as hberaud21:20
*** dave-mccowan has quit IRC21:55
dougwigcan I get a second ovo core to peek at https://review.openstack.org/637389 ?23:14
openstackgerritHervé Beraud proposed openstack/oslo.cache master: Fix memcache issue due to the __new__ attribute reassign.  https://review.openstack.org/63445723:27
openstackgerritHervé Beraud proposed openstack/oslo.cache master: [WIP] fix dogpile.cache issue due to the new usage of decorate in the lib  https://review.openstack.org/63878823:27
openstackgerritHervé Beraud proposed openstack/oslo.cache master: [WIP] fix dogpile.cache issue due to the new usage of decorate in the lib  https://review.openstack.org/63878823:29
openstackgerritHervé Beraud proposed openstack/oslo.cache master: [WIP] fix dogpile.cache issue due to the new usage of decorate in the lib  https://review.openstack.org/63878823:32
openstackgerritHervé Beraud proposed openstack/oslo.cache master: [WIP] fix dogpile.cache issue due to the new usage of decorate in the lib  https://review.openstack.org/63878823:41

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!