*** dave-mccowan has joined #openstack-oslo | 00:04 | |
*** agopi has joined #openstack-oslo | 00:15 | |
*** lbragstad has quit IRC | 00:35 | |
*** lbragstad has joined #openstack-oslo | 00:39 | |
*** dave-mccowan has quit IRC | 00:53 | |
*** Liang__ has joined #openstack-oslo | 00:58 | |
openstackgerrit | Merged openstack/oslo.messaging master: Change python3.5 job to python3.7 job on Stein+ https://review.openstack.org/610118 | 01:23 |
---|---|---|
*** takamatsu_ has joined #openstack-oslo | 01:26 | |
*** takamatsu has quit IRC | 01:26 | |
*** Liang__ has quit IRC | 02:24 | |
*** lbragstad_ has joined #openstack-oslo | 02:54 | |
*** lbragstad has quit IRC | 02:55 | |
*** lpetrut has joined #openstack-oslo | 04:49 | |
eandersson | Anyone that could take a look at these oslo.config hacks? https://review.openstack.org/#/c/638000/12/networking_cisco/config/base.py | 05:13 |
eandersson | No clue what I am doing here. I mean it works, but probably not the way I should get it working. | 05:13 |
*** dougwig has joined #openstack-oslo | 05:16 | |
*** lpetrut has quit IRC | 05:25 | |
*** gmann has quit IRC | 05:28 | |
*** lpetrut has joined #openstack-oslo | 05:54 | |
*** Luzi has joined #openstack-oslo | 06:41 | |
*** e0ne has joined #openstack-oslo | 07:29 | |
*** e0ne has quit IRC | 07:43 | |
*** e0ne has joined #openstack-oslo | 07:44 | |
*** aojea has joined #openstack-oslo | 07:44 | |
*** e0ne has quit IRC | 07:44 | |
*** e0ne has joined #openstack-oslo | 07:50 | |
*** hberaud|gone is now known as hberaud | 08:00 | |
*** lbragstad_ has quit IRC | 08:07 | |
*** e0ne has quit IRC | 08:10 | |
*** cdent has joined #openstack-oslo | 08:30 | |
*** cdent has quit IRC | 09:31 | |
*** jaosorior has quit IRC | 09:33 | |
*** jaosorior has joined #openstack-oslo | 09:35 | |
*** yan0s has joined #openstack-oslo | 09:41 | |
*** stephenfin is now known as finucannot | 09:48 | |
*** takamatsu_ has quit IRC | 10:04 | |
*** gibi is now known as giblet | 10:04 | |
*** takamatsu has joined #openstack-oslo | 10:05 | |
*** e0ne has joined #openstack-oslo | 10:19 | |
*** takamatsu_ has joined #openstack-oslo | 10:23 | |
*** takamatsu has quit IRC | 10:24 | |
*** rcernin has quit IRC | 10:31 | |
*** takamatsu_ has quit IRC | 10:48 | |
*** takamatsu has joined #openstack-oslo | 10:49 | |
*** takamatsu has quit IRC | 10:54 | |
*** shardy has joined #openstack-oslo | 10:54 | |
*** takamatsu has joined #openstack-oslo | 10:58 | |
*** shardy has quit IRC | 11:06 | |
*** a-pugachev has joined #openstack-oslo | 11:11 | |
*** tosky has joined #openstack-oslo | 11:12 | |
*** gmann has joined #openstack-oslo | 11:49 | |
*** sum12 has quit IRC | 12:03 | |
*** raildo has joined #openstack-oslo | 12:11 | |
*** sum12 has joined #openstack-oslo | 12:17 | |
*** kgiusti has joined #openstack-oslo | 13:08 | |
*** dave-mccowan has joined #openstack-oslo | 13:19 | |
*** sambetts_ has quit IRC | 13:21 | |
*** sambetts_ has joined #openstack-oslo | 13:24 | |
*** moguimar has joined #openstack-oslo | 13:42 | |
*** dave-mccowan has quit IRC | 13:43 | |
*** dave-mccowan has joined #openstack-oslo | 13:43 | |
*** agopi has quit IRC | 13:44 | |
*** agopi has joined #openstack-oslo | 13:54 | |
*** agopi_ has joined #openstack-oslo | 13:58 | |
*** agopi has quit IRC | 14:00 | |
openstackgerrit | Ken Giusti proposed openstack/oslo.messaging stable/rocky: Mark telemetry tests nv and remove from gate https://review.openstack.org/638663 | 14:00 |
*** dave-mccowan has quit IRC | 14:05 | |
*** lbragstad_ has joined #openstack-oslo | 14:05 | |
*** lbragstad_ is now known as lbragstad | 14:07 | |
*** dave-mccowan has joined #openstack-oslo | 14:38 | |
*** bnemec is now known as beekneemech | 14:39 | |
beekneemech | kgiusti: So I suppose we'll need to backport that to all the stable branches? | 15:15 |
beekneemech | Or did we only add those tests recently? | 15:15 |
*** Luzi has quit IRC | 15:16 | |
kgiusti | beekneemech: those tests have been around a long time. But they may still be valid for other branches - I'll check. | 15:19 |
openstackgerrit | Ken Giusti proposed openstack/oslo.messaging stable/queens: DO NOT MERGE - testing telemetry gate https://review.openstack.org/638688 | 15:26 |
*** lbragstad is now known as elbragstad | 15:47 | |
*** njohnston has quit IRC | 15:58 | |
*** njohnston has joined #openstack-oslo | 15:59 | |
*** njohnston has quit IRC | 16:00 | |
*** njohnston has joined #openstack-oslo | 16:04 | |
*** e0ne has quit IRC | 16:11 | |
beekneemech | kgiusti: Okay, sounds good. I guess I'm a little surprised it broke on rocky since the breakage on master was recent. | 16:13 |
beekneemech | You wouldn't think the same issue would affect rocky. | 16:14 |
beekneemech | In any case, you can probably go ahead and propose the reno backports to queens and pike. That'll be as good a gate check as any. | 16:14 |
kgiusti | beekneemech: one would, but that test depends on several external projects - who knows what 'fixes' were backported.... | 16:15 |
kgiusti | beekneemech: kk I'll backport the releasenotes to Q and P | 16:15 |
beekneemech | kgiusti: Thanks | 16:16 |
*** aojea has quit IRC | 16:18 | |
*** yan0s has quit IRC | 16:19 | |
*** e0ne has joined #openstack-oslo | 16:20 | |
*** agopi_ is now known as agopi | 16:29 | |
*** a-pugachev has quit IRC | 16:29 | |
*** a-pugachev has joined #openstack-oslo | 16:30 | |
*** e0ne has quit IRC | 16:31 | |
*** imacdonn has quit IRC | 16:38 | |
*** imacdonn has joined #openstack-oslo | 16:38 | |
*** hberaud is now known as hberaud|school-r | 16:41 | |
*** hberaud|school-r is now known as hberaud | 16:46 | |
*** agopi is now known as agopi|lunch|trav | 16:54 | |
*** agopi|lunch|trav has quit IRC | 16:55 | |
*** imacdonn has quit IRC | 17:08 | |
*** tosky has quit IRC | 17:28 | |
*** a-pugachev has quit IRC | 17:34 | |
openstackgerrit | Ben Nemec proposed openstack/oslo.cache master: Remove dogpile kwarg test https://review.openstack.org/638732 | 17:46 |
beekneemech | hberaud: ^ | 17:46 |
openstackgerrit | Ken Giusti proposed openstack/oslo.messaging stable/queens: Add release note for amqp library TLS/SSL error https://review.openstack.org/638733 | 17:46 |
beekneemech | I realize you're probably on your weekend by now, but for Monday. :-) | 17:47 |
hberaud | beekneemech: ack | 17:47 |
*** takamatsu_ has joined #openstack-oslo | 17:48 | |
hberaud | beekneemech: bnemec: else I think I find a fix and monday/tuesday I guess have someting that works | 17:48 |
*** takamatsu has quit IRC | 17:48 | |
beekneemech | hberaud: Okay, but the fix should be in dogpile.cache, right? | 17:48 |
hberaud | beekneemech: functools fix on oslo.cache core side to avoid the decorator issue | 17:49 |
hberaud | beekneemech: I need to go now I'll be away during few hours but I guess back in 2-3 hours | 17:50 |
hberaud | beekneemech: stay in touch | 17:50 |
beekneemech | hberaud: Hmm, okay. I feel like this is a bug in dogpile.cache and we should push for a fix there in any case, but I'll be interested to see what you come up with. | 17:50 |
beekneemech | hberaud: Thanks for investigating. | 17:50 |
hberaud | beekneemech: my pleasure | 17:51 |
hberaud | beekneemech: and not really an issue on dogpile.cache | 17:51 |
hberaud | they have introduced "decorator" and we have side effects | 17:51 |
hberaud | beekneemech: well need to go, see you | 17:52 |
beekneemech | Okay, maybe I'm wrong about what's going on here. We can talk more later. | 17:52 |
*** hberaud is now known as hberaud|afk | 17:52 | |
openstackgerrit | Ken Giusti proposed openstack/oslo.messaging stable/pike: Add release note for amqp library TLS/SSL error https://review.openstack.org/638735 | 17:55 |
*** takamatsu_ has quit IRC | 18:03 | |
moguimar | beekneemech: is that you Ben? | 18:05 |
beekneemech | moguimar: Yes. | 18:05 |
beekneemech | Casual nick Friday. :-) | 18:05 |
moguimar | xD | 18:05 |
moguimar | nice | 18:05 |
moguimar | we declined one patch on castellan and fixed another bug. | 18:06 |
*** takamatsu_ has joined #openstack-oslo | 18:06 | |
moguimar | going offline now | 18:08 |
moguimar | see yall next monday | 18:08 |
moguimar | o/ | 18:08 |
*** moguimar has quit IRC | 18:08 | |
*** dave-mccowan has quit IRC | 18:15 | |
eandersson | Anyone that can help me with some oslo.config stuff? | 18:40 |
eandersson | https://review.openstack.org/#/c/638000/13/networking_cisco/config/base.py | 18:40 |
eandersson | Trying to make cisco code work with Stein, and.. well this feels super hacky | 18:41 |
*** agopi has joined #openstack-oslo | 18:45 | |
*** lpetrut has quit IRC | 18:51 | |
*** lpetrut has joined #openstack-oslo | 19:07 | |
*** e0ne has joined #openstack-oslo | 19:18 | |
beekneemech | eandersson: Why do you have to conditionalize the creation of the LocationInfo? I'm not sure why you would ever want to return None there. | 19:31 |
eandersson | beekneemech, so I didn't design this, but it needs to work with e.g. mitaka | 19:33 |
beekneemech | eandersson: I think that's what the if getattr(cfg.CONF, 'get_location', None) is doing. | 19:34 |
beekneemech | Older versions of oslo.config didn't expect to get back a tuple. | 19:34 |
beekneemech | I suspect None was just a temporary thing to make the API match. | 19:34 |
beekneemech | And I guess if you don't care about being able to determine the location for the opts it's probably fine. | 19:34 |
beekneemech | But I assume you do since you're making this change. :-) | 19:34 |
eandersson | So the code in Stein isn't working with loc being None | 19:36 |
eandersson | but works fine in e.g. Rocky | 19:36 |
beekneemech | Hmm. Let me see when we added that. | 19:36 |
eandersson | I am really just trying to get someone elses stuff work under Stein with the bare minimum amount of work | 19:37 |
eandersson | but without doing anything stupid haha | 19:37 |
beekneemech | Understood. I think I may have a commit in that repo for similar reasons. :-) | 19:38 |
beekneemech | Locations have been around for over a year, so they should have been in Rocky too. | 19:39 |
*** dave-mccowan has joined #openstack-oslo | 19:43 | |
beekneemech | eandersson: I think if you just change the returns to look like this: http://paste.openstack.org/show/745766/ it should work. | 19:44 |
beekneemech | That's using all stuff that exists in any version of oslo.config with get_location. | 19:44 |
beekneemech | And it should satisfy the oslo.config expectations for what these functions return. | 19:44 |
beekneemech | I'm not exactly sure why it would have broken just in Stein, but I think this is more correct anyway. | 19:45 |
eandersson | Yea troubleshooting this was really difficult | 19:48 |
eandersson | as what ever went wrong was not bubbling up | 19:48 |
beekneemech | Yeah, when we implemented this I don't think we considered external config types. | 19:49 |
beekneemech | We changed a bunch of internal apis and thought it was safe because they were all private. | 19:49 |
openstackgerrit | Morgan Fainberg proposed openstack/oslo.limit master: Add python3.7 job on Stein+ https://review.openstack.org/610641 | 19:53 |
openstackgerrit | Merged openstack/oslo.messaging stable/rocky: Mark telemetry tests nv and remove from gate https://review.openstack.org/638663 | 20:07 |
*** lpetrut has quit IRC | 20:08 | |
*** e0ne has quit IRC | 20:08 | |
eandersson | Thanks beekneemech | 20:13 |
eandersson | Yea - makes sense | 20:13 |
beekneemech | np | 20:15 |
*** tosky has joined #openstack-oslo | 21:11 | |
*** raildo has quit IRC | 21:15 | |
*** hberaud|afk is now known as hberaud | 21:20 | |
*** dave-mccowan has quit IRC | 21:55 | |
dougwig | can I get a second ovo core to peek at https://review.openstack.org/637389 ? | 23:14 |
openstackgerrit | Hervé Beraud proposed openstack/oslo.cache master: Fix memcache issue due to the __new__ attribute reassign. https://review.openstack.org/634457 | 23:27 |
openstackgerrit | Hervé Beraud proposed openstack/oslo.cache master: [WIP] fix dogpile.cache issue due to the new usage of decorate in the lib https://review.openstack.org/638788 | 23:27 |
openstackgerrit | Hervé Beraud proposed openstack/oslo.cache master: [WIP] fix dogpile.cache issue due to the new usage of decorate in the lib https://review.openstack.org/638788 | 23:29 |
openstackgerrit | Hervé Beraud proposed openstack/oslo.cache master: [WIP] fix dogpile.cache issue due to the new usage of decorate in the lib https://review.openstack.org/638788 | 23:32 |
openstackgerrit | Hervé Beraud proposed openstack/oslo.cache master: [WIP] fix dogpile.cache issue due to the new usage of decorate in the lib https://review.openstack.org/638788 | 23:41 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!