Tuesday, 2018-07-17

« Monday, 2018-07-16 Index Wednesday, 2018-07-18 »
*** rcernin_ has joined #openstack-oslo00:04
*** rcernin has quit IRC00:04
*** mengalong has joined #openstack-oslo00:07
*** mengalong_ has joined #openstack-oslo00:07
*** bobh has quit IRC00:38
*** bobh has joined #openstack-oslo00:38
*** bobh has quit IRC00:43
*** dave-mccowan has joined #openstack-oslo02:06
*** dave-mcc_ has joined #openstack-oslo02:25
*** dave-mccowan has quit IRC02:25
*** lbragstad has quit IRC03:05
*** dave-mcc_ has quit IRC03:30
*** lpetrut has joined #openstack-oslo03:49
*** lpetrut has quit IRC04:39
*** e0ne has joined #openstack-oslo05:18
*** e0ne has quit IRC05:20
*** rcernin_ has quit IRC05:25
*** rcernin has joined #openstack-oslo05:26
*** links has joined #openstack-oslo05:33
*** mengalong_ has quit IRC05:55
*** mengalong has quit IRC05:55
*** tesseract has joined #openstack-oslo06:48
*** lpetrut has joined #openstack-oslo06:50
*** yamamoto has joined #openstack-oslo07:02
*** peereb has joined #openstack-oslo07:04
*** shardy has joined #openstack-oslo07:06
*** rcernin has quit IRC07:11
*** AlexeyAbashkin has joined #openstack-oslo07:22
*** zhiguo has joined #openstack-oslo07:34
zhiguohello, there is a problem https://bugs.launchpad.net/oslo.messaging/+bug/178187607:37
openstackLaunchpad bug 1781876 in oslo.messaging "An strange error in oslo.messaging" [Undecided,New]07:37
*** tosky has joined #openstack-oslo07:38
*** zhiguo has quit IRC07:55
*** zhiguo has joined #openstack-oslo07:59
zhiguoHello, there is a proplem , https://bugs.launchpad.net/oslo.messaging/+bug/1781876  welcome to discuss.08:04
openstackLaunchpad bug 1781876 in oslo.messaging "An strange error in oslo.messaging" [Undecided,New]08:04
*** moguimar has joined #openstack-oslo08:04
*** mago_ has joined #openstack-oslo08:05
*** e0ne has joined #openstack-oslo08:05
*** zhiguo has quit IRC08:10
*** zhiguo has joined #openstack-oslo08:11
*** shardy has quit IRC08:24
openstackgerritRadoslav Gerganov proposed openstack/oslo.vmware master: Add function for getting recommended datastore  https://review.openstack.org/58131208:28
*** moguimar has quit IRC08:33
*** pbourke has quit IRC08:35
*** shardy has joined #openstack-oslo08:37
openstackgerritDirk Mueller proposed openstack/oslo.messaging master: Remove setting of DEVSTACK_GATE_EXERCISES  https://review.openstack.org/58315708:47
*** moguimar has joined #openstack-oslo08:47
*** hoonetorg has quit IRC08:47
*** pbourke has joined #openstack-oslo08:52
*** hoonetorg has joined #openstack-oslo09:04
*** moguimar has quit IRC09:37
*** yamamoto has quit IRC09:37
*** moguimar has joined #openstack-oslo09:37
openstackgerritStephen Finucane proposed openstack-dev/pbr master: trivial: Remove 'tools/releasenotes_tox.sh'  https://review.openstack.org/58041409:39
openstackgerritStephen Finucane proposed openstack-dev/pbr master: trivial: Fix file permissions  https://review.openstack.org/58041509:39
openstackgerritStephen Finucane proposed openstack-dev/pbr master: Switch to stestr  https://review.openstack.org/58041309:39
openstackgerritStephen Finucane proposed openstack-dev/pbr master: builddoc: Remove support for Sphinx < 1.6  https://review.openstack.org/58041609:39
openstackgerritStephen Finucane proposed openstack-dev/pbr master: packaging: Remove support for pyN requirement files  https://review.openstack.org/58041709:39
openstackgerritStephen Finucane proposed openstack-dev/pbr master: doc: Fix formatting of packagers guide  https://review.openstack.org/58041809:39
openstackgerritStephen Finucane proposed openstack-dev/pbr master: doc: Add documentation for missing '[pbr]' options  https://review.openstack.org/58041909:39
openstackgerritStephen Finucane proposed openstack-dev/pbr master: Add Sphinx extension  https://review.openstack.org/58042009:39
openstackgerritStephen Finucane proposed openstack-dev/pbr master: Deprecate 'build_sphinx' integration  https://review.openstack.org/58042109:39
openstackgerritStephen Finucane proposed openstack-dev/pbr master: Deprecate 'test' integration  https://review.openstack.org/58042209:39
openstackgerritStephen Finucane proposed openstack-dev/pbr master: trivial: Increase integration test timeout  https://review.openstack.org/58317809:39
*** zhiguo has quit IRC09:43
openstackgerritStephen Finucane proposed openstack/oslo.log master: Migrate to stestr  https://review.openstack.org/57120509:48
openstackgerritStephen Finucane proposed openstack/oslo.log master: Follow the new PTI for document build  https://review.openstack.org/54933809:48
openstackgerritStephen Finucane proposed openstack/oslo.log master: Fix lower-constraints job  https://review.openstack.org/58318209:48
*** moguimar has quit IRC09:52
*** shardy_ has joined #openstack-oslo09:59
*** shardy has quit IRC10:02
*** moguimar has joined #openstack-oslo10:51
*** mago_ has quit IRC10:57
*** sambetts|afk is now known as sambetts10:59
*** mago_ has joined #openstack-oslo11:03
*** mago_ has quit IRC11:03
*** mattgo has joined #openstack-oslo11:04
*** d0ugal has quit IRC11:15
*** dave-mccowan has joined #openstack-oslo11:18
*** d0ugal has joined #openstack-oslo11:18
*** d0ugal has quit IRC11:18
*** d0ugal has joined #openstack-oslo11:18
*** rpioso|afk is now known as rpioso11:56
*** edmondsw has joined #openstack-oslo12:06
*** moguimar has quit IRC12:06
*** moguimar has joined #openstack-oslo12:07
*** namnh has joined #openstack-oslo12:10
*** lbragstad has joined #openstack-oslo12:31
*** raildo has joined #openstack-oslo12:40
*** lbragstad has quit IRC12:41
*** raildo has quit IRC12:45
*** raildo has joined #openstack-oslo12:46
*** raildo has quit IRC12:50
*** raildo has joined #openstack-oslo12:52
*** eck`gone is now known as eck`12:53
*** peereb has quit IRC12:56
*** tosky has quit IRC12:56
*** tosky has joined #openstack-oslo12:56
*** raildo has quit IRC13:00
*** raildo has joined #openstack-oslo13:00
*** moguimar has quit IRC13:02
*** raildo has quit IRC13:03
*** raildo has joined #openstack-oslo13:03
*** moguimar has joined #openstack-oslo13:06
raildodhellmann, that's a pretty odd behavior, even that debug patch seems to pass in the py35 tests13:08
raildodhellmann, the reason that I'm having is mind, is that that code is expecting a tuple in a exactly order... by any chance is it possible that tuple's order be randomly generated, so sometimes we are good and sometimes we aren't?13:10
dhellmannraildo : there's a race condition of some sort in the tests. Usually that comes up when they try to access the same files or something like that. I was hoping that we could get a better error message to understand why without me having to dig deeply into moguimar's test code13:11
*** e0ne has quit IRC13:11
dhellmannis it expecting something in a specific order?13:11
dhellmannfrom what I saw, it was looping over all of the options and expecting their values to match an expected set and sometimes the options aren't set at all13:12
raildodhellmann, based in the moguimar's comment over here: https://github.com/openstack/oslo.config/commit/084ac31f4c0ac9d2a7960658b9a8dbde6765492b#diff-b067a69e3afb17258ed33798bb2f3c93R27813:13
raildoit's expecting to be in that 'abc', 'def', 'ghi' order13:13
dhellmannthe values are being loaded in the loop starting on line 264, and that loop seems to be iterating over a list13:14
dhellmannwell, wait, the load is actually line 27213:14
dhellmannand *that* call should be looking at the config_source value, also set to a list on line 27113:14
dhellmannif we could get it to fail, the log changes would show the order things are loaded :-/13:15
*** moguimar has quit IRC13:15
raildodhellmann, ++ let's send some recheck and see if we can caught that log details, also I'm deploying that in a devstack with your patch to see if I'm able to catch that locally13:16
dhellmannsounds good13:16
*** moguimar has joined #openstack-oslo13:19
*** moguimar has quit IRC13:24
*** moguimar has joined #openstack-oslo13:28
efrieddhellmann, raildo: What's the bug number, please?13:30
raildoefried, well, we didn't created a bug for that yet, we're facing the issue over this patch: https://review.openstack.org/#/c/578144/ and we are adding some more debug logs over here: https://review.openstack.org/#/c/583038/13:32
efriedraildo: Okay. I'm getting the same issue in https://review.openstack.org/#/c/583063/ and wanted to tag my recheck comment; I'll just keep it anonymous for now :)13:33
raildoefried, I had that issue in some previous patches, a few rechecks were enough to "fix" it, but we're trying to figure out what's really going on13:34
efriedraildo: Yup, agree.13:35
*** raildo has quit IRC13:35
*** raildo has joined #openstack-oslo13:36
*** raildo has quit IRC13:37
*** moguimar has quit IRC13:37
efrieddhellmann: I put a Depends-On from a nova patch to an oslo.config patch and it doesn't seem to be working.  Is there a known issue ther?13:38
efriede13:38
*** raildo has joined #openstack-oslo13:39
*** raildo has quit IRC13:41
*** moguimar has joined #openstack-oslo13:44
*** moguimar has quit IRC13:47
*** chhagarw has joined #openstack-oslo13:47
*** moguimar has joined #openstack-oslo13:47
*** bobh has joined #openstack-oslo13:53
*** bobh has quit IRC13:58
openstackgerritMerged openstack/oslo.vmware master: Add function for getting recommended datastore  https://review.openstack.org/58131214:05
*** raildo has joined #openstack-oslo14:07
*** spilla has joined #openstack-oslo14:20
*** bobh has joined #openstack-oslo14:28
*** d0ugal has quit IRC14:37
*** d0ugal has joined #openstack-oslo14:44
*** lbragstad has joined #openstack-oslo14:57
*** namnh has quit IRC14:57
*** d0ugal has quit IRC15:03
efrieddhellmann, raildo: Got a local repro, hth: http://paste.openstack.org/show/726118/15:12
dhellmannefried : we're discussing this in #openstack-meeting-3 right now15:12
*** d0ugal has joined #openstack-oslo15:14
*** lpetrut has quit IRC15:23
*** d0ugal has quit IRC15:26
*** moguimar has quit IRC15:31
raildoo/15:32
efriedHi raildo. I wasn't clear - did we get anywhere debugging this?15:32
efrieddhellmann: I seem to be able to repro fairly regularly in my local env. If you want to shove more debug code into https://review.openstack.org/#/c/583038/ I can try it out.15:33
raildoefried, well, I don't think so, at this moment we just know that the loading conf option is not working properly on that test15:34
dhellmannit looks like the options in the groups are being initialized twice, and the second time sometimes the driver option is initialized differently15:34
dhellmannI suspect that the difference is in the choices value ordering15:34
dhellmannI'm trying to figure out where the two calls are now15:35
*** mattgo has quit IRC15:41
raildodhellmann, efried looks like it's some miss cleaning pass in other tests, since you only get the issue running the entire set of tests, if you only execute the test, it will pass15:45
efriedA missed addCleanup in the fixture, maybe?15:54
bnemecIt may be because we aren't using the fixture's register_opt: https://github.com/openstack/oslo.config/blob/master/oslo_config/fixture.py#L9915:56
bnemecSo it doesn't know it needs to clean up the opt.15:56
dhellmannwe create a new ConfigOpt instance for each test, though15:56
bnemecYeah, that part doesn't make sense.15:56
*** d0ugal has joined #openstack-oslo15:57
*** tesseract has quit IRC15:57
dhellmannok, for some reason the driver *is* registering the 'driver' option a second time15:59
raildowe're using register_opts over here: https://github.com/openstack/oslo.config/blob/master/oslo_config/tests/test_sources.py#L193-L19716:00
efriedhttps://www.youtube.com/watch?v=wSGkBWYDmrM16:00
raildohaha16:01
raildodhellmann, I think that I get it.... in the self.conf._load_alternative_sources() line 273, internally it will call the _open_source_from_opt_group on cfg, and there is a self.register_opt over there, than the test will try to register again doing self._register_opts(_extra_configs[uri]["data"])16:15
raildodhellmann, that's may be the reason why it's trying to register twice16:15
dhellmannthat's the calling sequence, but where is the second different driver opt coming from? because registering the same thing twice is ok.16:16
dhellmannit's only an error to register the option differently more than one time16:16
*** d0ugal has quit IRC16:18
*** harlowja has joined #openstack-oslo16:18
raildodhellmann, iiuc the first call will register the three group options, and the second call will just use the ini_3 group, I'll debug a bit more to confirm this theory16:22
dhellmannI think I've found it16:22
dhellmannit has to do with the option discovery code16:22
dhellmannstand by for a patch16:22
openstackgerritDoug Hellmann proposed openstack/oslo.config master: add more debug output to flakey test  https://review.openstack.org/58303816:24
openstackgerritDoug Hellmann proposed openstack/oslo.config master: ensure we do not modify private data from drivers  https://review.openstack.org/58330316:24
*** links has quit IRC16:24
dhellmannraildo , efried , bnemec : https://review.openstack.org/583303 should fix it16:25
efriedschweet16:25
bnemecAh16:26
efrieddhellmann: Now that that's off your chest... any idea why Depends-On from https://review.openstack.org/#/c/583025/ to https://review.openstack.org/#/c/583064/ isn't working?16:26
openstackgerritJoshua Harlow proposed openstack/oslo.utils master: Handle non-string keys appropriately  https://review.openstack.org/58330416:27
dhellmannefried : which job didn't do what you expected?16:27
efrieddhellmann: Docs build... oh.16:27
efrieddeps not set up properly for that?16:28
dhellmannyeah, only the devstack jobs do something useful with depends-on16:28
dhellmannthe docs job doesn't install anything from source16:28
efriedOkay.16:28
*** lpetrut has joined #openstack-oslo16:28
efriedWell, whadayathink about that patch, then? :)16:28
dhellmannI saw it, but haven't had a chance to review it16:28
dhellmannin general it seems like a good thing to fix16:29
dhellmannI'm not sure about the idea of writing our own parser for it16:29
openstackgerritJoshua Harlow proposed openstack/oslo.utils master: Handle non-string keys appropriately  https://review.openstack.org/58330416:29
dhellmannI wonder about using docutils to convert the help text to plain text16:30
dhellmannthat may be overkill16:30
*** d0ugal has joined #openstack-oslo16:30
efriedThat sounds like a broader effort. This is effectively 6 lines (plus doc text).16:31
*** e0ne has joined #openstack-oslo16:31
*** spilla has quit IRC16:31
raildodhellmann, http://paste.openstack.org/show/726135/ i got this output applying your patch here16:31
raildo(now it's in a different test test_list_opts)16:32
dhellmannhmm16:32
openstackgerritDoug Hellmann proposed openstack/oslo.config master: ensure we do not modify private data from drivers  https://review.openstack.org/58330316:35
dhellmannraildo : try the new version ^ (I left out a change I had stashed locally when cleaning up the debug stuff I spewed throughout the module)16:36
raildodhellmann, it works, thanks for take some time to take care of this :)16:40
*** spilla has joined #openstack-oslo16:41
efriedthat looks like just a var rename16:41
efriedtrying anyway...16:41
efriedoh, I see16:42
efriedyup, wfm.16:42
openstackgerritEric Fried proposed openstack/oslo.config master: generator: Pass conf to _OptFormatter  https://review.openstack.org/58306316:43
openstackgerritEric Fried proposed openstack/oslo.config master: generator: Convert sphinx-isms in opt help text  https://review.openstack.org/58306416:44
efriedrebased those on top of the fix ^16:44
*** tobasco is now known as tobasco_away16:54
*** AlexeyAbashkin has quit IRC16:59
*** chhagarw has quit IRC17:09
*** lbragstad has quit IRC17:11
*** bobh has quit IRC17:13
*** e0ne has quit IRC17:15
*** e0ne has joined #openstack-oslo17:21
*** chhagarw has joined #openstack-oslo17:29
openstackgerritEric Fried proposed openstack/oslo.config master: generator: Convert sphinx-isms in opt help text  https://review.openstack.org/58306417:38
efriedstephenfin: Addressed doc & help string formatting ^17:38
*** sambetts is now known as sambetts|afk17:41
*** chhagarw has quit IRC17:45
*** spilla_ has joined #openstack-oslo17:46
*** spilla has quit IRC17:46
*** spilla_ has quit IRC17:51
*** harlowja has quit IRC17:54
*** shardy_ has quit IRC17:54
*** spilla has joined #openstack-oslo17:58
*** bobh has joined #openstack-oslo18:10
*** ianychoi has quit IRC18:14
*** e0ne has quit IRC18:15
bnemecI added a Help Wanted section to the wiki listing some of the major projects where we don't have a lot of expertise today: https://wiki.openstack.org/wiki/Oslo#Help_Wanted18:32
*** harlowja has joined #openstack-oslo18:32
bnemecI think that came up in the onboarding session in Vancouver so I thought it would be good to document it.18:33
efriedbnemec: What do y'all need in taskflow?18:33
bnemecI'm open to additions if anyone is aware of other major gaps in our coverage.18:33
dhellmannbnemec : ++18:33
dhellmannefried : reviews from someone with some experience with that code would be good18:34
efriedI'm really familiar with *using* that code...18:34
bnemecIt's looking better now, but I think that's mostly because harlowja abandoned a lot of his feature patches. :-/18:35
harlowjalol18:35
harlowjahahaha18:35
bnemecIt would have been nice to have more reviewers so we could actually get those in.18:35
harlowjai still need to do the networkx adjustment :-P18:35
harlowjai think that one is still needed...18:35
bnemecharlowja: It's actually done.18:35
harlowjaoh18:35
harlowjaeven better!18:35
harlowjalol18:35
bnemechttps://review.openstack.org/#/c/577833/18:35
harlowjakk, it prob wasn't to bad, cool18:35
harlowjasince taskflow wraps the graph stuff anyway (at one point there was a possiblity of just doing our own mini-graph stuff)18:36
harlowja(since networkx is aloooot of other stuff, useful, but alot)18:36
bnemecYeah, and we're lacking people to work on that sort of thing.18:37
*** lbragstad has joined #openstack-oslo18:47
*** e0ne has joined #openstack-oslo18:49
*** bobh has quit IRC18:54
openstackgerritEric Fried proposed openstack/taskflow master: Update various links in docs  https://review.openstack.org/56718118:56
*** efried has quit IRC19:14
*** efried has joined #openstack-oslo19:14
openstackgerritOndřej Nový proposed openstack/taskflow master: Make the build reproducible  https://review.openstack.org/51839719:19
*** tosky has quit IRC19:20
*** mattgo has joined #openstack-oslo19:21
*** e0ne has quit IRC19:41
harlowjabnemec ya.... :-/19:43
*** AlexeyAbashkin has joined #openstack-oslo20:22
*** lbragstad has quit IRC20:28
*** raildo has quit IRC20:31
*** lpetrut has quit IRC20:36
*** raildo has joined #openstack-oslo20:38
*** raildo has quit IRC20:50
*** AlexeyAbashkin has quit IRC20:54
*** d0ugal has quit IRC20:58
*** d0ugal has joined #openstack-oslo21:00
*** d0ugal has quit IRC21:00
*** d0ugal has joined #openstack-oslo21:00
*** spilla has quit IRC21:03
*** mattgo has quit IRC21:08
*** edmondsw has quit IRC21:36
*** bobh has joined #openstack-oslo21:44
*** edmondsw_ has joined #openstack-oslo21:45
*** edmondsw_ has quit IRC21:49
*** spilla has joined #openstack-oslo21:51
*** bobh has quit IRC22:05
*** mattgo has joined #openstack-oslo22:13
*** dave-mccowan has quit IRC22:16
*** spilla has quit IRC22:18
*** mattgo has quit IRC22:23
*** sambetts|afk has quit IRC22:26
*** mriedem has joined #openstack-oslo22:27
mriedemi've noticed that the rst generated oslo.config group help text gets dumped multiple times, which is really weird22:27
mriedemhttps://docs.openstack.org/nova/latest/configuration/config.html#spice22:27
mriedemhttps://docs.openstack.org/nova/latest/configuration/config.html#upgrade-levels22:27
mriedemif you search for the first sentence on either of those you'll see it shows up multiple times22:27
mriedemit's not a problem in the generated sample file22:28
*** sambetts_ has joined #openstack-oslo22:28
mriedemhttps://bugs.launchpad.net/oslo.config/+bug/178225322:30
openstackLaunchpad bug 1782253 in oslo.config "Group help text is output multiple times during sphinx docs generation" [Undecided,New]22:30
*** rcernin has joined #openstack-oslo22:32
efriedmriedem: We had something similar fixed via https://review.openstack.org/#/c/577023/ (bug 1774754). This doesn't appear to be the same, though.22:44
openstackbug 1774754 in OpenStack Compute (nova) "[api_database] config options are duplicated in config reference" [Medium,Fix released] https://launchpad.net/bugs/1774754 - Assigned to Chason Chan (chen-xing)22:45
*** lbragstad has joined #openstack-oslo22:50
openstackgerritMerged openstack/oslo.config master: ensure we do not modify private data from drivers  https://review.openstack.org/58330322:53
*** tosky has joined #openstack-oslo23:09
*** rpioso is now known as rpioso|afk23:13
dhellmannstephenfin : I wonder if mriedem's issue rings any bells for you? ^^23:14
openstackgerritRaildo Mascena proposed openstack/oslo.config master: New cache layer for external sources  https://review.openstack.org/57814423:54
« Monday, 2018-07-16 Index Wednesday, 2018-07-18 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!