*** namnh has joined #openstack-oslo | 02:26 | |
*** lpetrut has joined #openstack-oslo | 03:44 | |
*** lpetrut has quit IRC | 04:25 | |
*** nicolasbock has joined #openstack-oslo | 05:53 | |
*** AlexeyAbashkin has joined #openstack-oslo | 05:54 | |
*** lpetrut has joined #openstack-oslo | 06:11 | |
*** lpetrut_ has joined #openstack-oslo | 06:13 | |
*** AlexeyAbashkin has quit IRC | 06:13 | |
*** lpetrut has quit IRC | 06:16 | |
*** samueldmq has quit IRC | 06:28 | |
*** samueldmq has joined #openstack-oslo | 06:28 | |
*** pcaruana has joined #openstack-oslo | 06:30 | |
*** e0ne has joined #openstack-oslo | 06:54 | |
*** e0ne has quit IRC | 07:03 | |
*** rcernin has quit IRC | 07:08 | |
*** AlexeyAbashkin has joined #openstack-oslo | 07:10 | |
*** tesseract has joined #openstack-oslo | 07:11 | |
*** tosky has joined #openstack-oslo | 07:18 | |
*** gibi is now known as giblet | 07:38 | |
*** d0ugal_ has quit IRC | 08:03 | |
*** d0ugal has joined #openstack-oslo | 08:04 | |
*** peereb has joined #openstack-oslo | 08:05 | |
*** rcernin has joined #openstack-oslo | 08:05 | |
*** shardy has joined #openstack-oslo | 08:08 | |
*** namnh has quit IRC | 08:09 | |
*** AlexeyAbashkin has quit IRC | 08:29 | |
*** rcernin has quit IRC | 08:41 | |
*** e0ne has joined #openstack-oslo | 09:02 | |
*** lpetrut__ has joined #openstack-oslo | 09:03 | |
*** lpetrut_ has quit IRC | 09:07 | |
*** shardy has quit IRC | 09:16 | |
*** shardy has joined #openstack-oslo | 09:17 | |
*** sileht has quit IRC | 09:35 | |
*** AlexeyAbashkin has joined #openstack-oslo | 09:36 | |
*** d0ugal has quit IRC | 09:55 | |
*** d0ugal has joined #openstack-oslo | 09:56 | |
*** salv-orlando has joined #openstack-oslo | 10:04 | |
*** salv-orlando has quit IRC | 10:09 | |
*** bigdogstl has joined #openstack-oslo | 10:17 | |
*** sileht has joined #openstack-oslo | 10:17 | |
*** bigdogstl has quit IRC | 10:17 | |
*** yamamoto has quit IRC | 10:29 | |
*** salv-orlando has joined #openstack-oslo | 11:05 | |
*** lpetrut__ has quit IRC | 11:08 | |
*** salv-orlando has quit IRC | 11:09 | |
*** lpetrut has joined #openstack-oslo | 11:14 | |
*** yamamoto has joined #openstack-oslo | 11:14 | |
*** yamamoto has quit IRC | 11:16 | |
*** yamamoto has joined #openstack-oslo | 11:27 | |
*** yamamoto has quit IRC | 11:28 | |
*** yamamoto has joined #openstack-oslo | 11:35 | |
*** yamamoto has quit IRC | 11:42 | |
*** raildo has joined #openstack-oslo | 11:45 | |
*** AlexeyAbashkin has quit IRC | 11:57 | |
*** yamamoto has joined #openstack-oslo | 12:08 | |
*** AlexeyAbashkin has joined #openstack-oslo | 12:11 | |
*** yamamoto has quit IRC | 12:21 | |
*** moguimar has quit IRC | 12:21 | |
*** moguimar has joined #openstack-oslo | 12:23 | |
*** kgiusti has joined #openstack-oslo | 12:30 | |
*** mmethot has quit IRC | 12:47 | |
*** yamamoto has joined #openstack-oslo | 12:55 | |
*** lpetrut has quit IRC | 12:58 | |
*** lpetrut has joined #openstack-oslo | 13:17 | |
*** mmethot has joined #openstack-oslo | 13:17 | |
*** HenryG has quit IRC | 13:18 | |
*** HenryG has joined #openstack-oslo | 13:21 | |
*** njohnston has quit IRC | 13:40 | |
openstackgerrit | Stephen Finucane proposed openstack/osprofiler master: opts: Fix invalid rST formatting https://review.openstack.org/577423 | 13:43 |
---|---|---|
*** njohnston has joined #openstack-oslo | 13:49 | |
stephenfin | dhellmann: Have you any sway over https://github.com/dreamhost/sphinxcontrib-pecanwsme/ anymore? | 13:52 |
*** lbragstad is now known as elbragstad | 13:52 | |
*** moguimar has quit IRC | 14:03 | |
*** spilla has joined #openstack-oslo | 14:03 | |
*** moguimar has joined #openstack-oslo | 14:04 | |
*** peereb has quit IRC | 14:10 | |
openstackgerrit | Raildo Mascena proposed openstack/oslo.config master: User guide documentation for backend drivers for oslo.config https://review.openstack.org/576947 | 14:10 |
dhellmann | stephenfin : I have owner rights on pypi but not on that repo. Let me see if I can get someone to give me access so we can move it over to the sphinx-contrib org | 14:13 |
openstackgerrit | Raildo Mascena proposed openstack/oslo.config master: User guide documentation for backend drivers for oslo.config https://review.openstack.org/576947 | 14:13 |
stephenfin | dhellmann: Yup, would appreciate that. It looks like a blocker for moving multiple project's docs to Python 3 | 14:14 |
*** pblaho has quit IRC | 14:16 | |
dhellmann | stephenfin : have you tried any of those pull requests that claim to fix python 3 compatibility? | 14:32 |
stephenfin | dhellmann: I have not but I can | 14:32 |
dhellmann | if you have time, it's not a high priority | 14:32 |
dhellmann | https://github.com/dreamhost/sphinxcontrib-pecanwsme/pull/18 looks promising | 14:33 |
dhellmann | as does https://github.com/dreamhost/sphinxcontrib-pecanwsme/pull/14 | 14:33 |
openstackgerrit | Thierry Carrez proposed openstack/sphinx-feature-classification master: Update for Python 3 compatibility https://review.openstack.org/577435 | 14:36 |
stephenfin | dhellmann: https://github.com/dreamhost/sphinxcontrib-pecanwsme/pull/18 works a-ok for me | 14:36 |
dhellmann | it looks like it ought to support python 2 as well, which would make rolling it out easier | 14:37 |
*** takedakn has joined #openstack-oslo | 14:37 | |
stephenfin | Aye, there's nothing that's not Python 2 incompatible in those | 14:38 |
* stephenfin tests to be sure | 14:38 | |
dhellmann | I've asked my contact at DH to help me move the repo over, so I'll let you know when I have a response | 14:38 |
stephenfin | Sounds good to me | 14:38 |
*** lpetrut has quit IRC | 14:42 | |
*** lpetrut has joined #openstack-oslo | 14:51 | |
*** moguimar has quit IRC | 14:53 | |
*** takedakn has quit IRC | 14:55 | |
*** lpetrut has quit IRC | 14:59 | |
*** spilla has quit IRC | 15:06 | |
*** spilla has joined #openstack-oslo | 15:12 | |
*** moguimar has joined #openstack-oslo | 15:14 | |
openstackgerrit | Merged openstack/sphinx-feature-classification master: Update for Python 3 compatibility https://review.openstack.org/577435 | 15:33 |
*** rpittau has quit IRC | 15:35 | |
*** pbourke has quit IRC | 15:41 | |
*** pbourke has joined #openstack-oslo | 15:42 | |
*** kgiusti has left #openstack-oslo | 15:44 | |
bnemec | I'm trying to add constraints to osprofiler, but it's failing with the dreaded "Could not satisfy constraints for 'osprofiler': installation from path or url cannot be constrained to a version" | 15:48 |
bnemec | Does anyone remember off hand how to fix that? | 15:48 |
bnemec | I know at one point we were filtering the current project out of the list, but I thought we weren't supposed to do that anymore. | 15:48 |
dhellmann | how do we do it in the other libs? | 15:48 |
bnemec | I dunno. I'm looking at the oslo.config tox.ini and I don't see anything obvious. | 15:51 |
bnemec | Huh. The problem appears to be the .[oslo_config] dep in tox.ini. | 15:54 |
bnemec | If I remove that then the problem goes away. | 15:54 |
bnemec | That's weird. I wonder why they split it out that way since there are other deps that pull in oslo.config anyway. | 15:56 |
bnemec | It's not like it's an optional dependency. | 15:56 |
*** r-mibu has quit IRC | 15:57 | |
openstackgerrit | Ben Nemec proposed openstack/osprofiler master: Start using upper-constraints in tox venvs https://review.openstack.org/577462 | 16:00 |
bnemec | Let's see how ci likes that. | 16:01 |
*** tesseract has quit IRC | 16:02 | |
*** pcaruana has quit IRC | 16:04 | |
*** nicolasbock has quit IRC | 16:06 | |
*** kgiusti has joined #openstack-oslo | 16:10 | |
*** spilla has quit IRC | 16:12 | |
*** spilla has joined #openstack-oslo | 16:13 | |
*** bobh has joined #openstack-oslo | 16:22 | |
*** bobh has quit IRC | 16:28 | |
*** e0ne has quit IRC | 16:32 | |
*** kgiusti has quit IRC | 16:36 | |
openstackgerrit | Ben Nemec proposed openstack/osprofiler master: Start using upper-constraints in tox venvs https://review.openstack.org/577462 | 16:41 |
*** e0ne has joined #openstack-oslo | 16:41 | |
*** e0ne has quit IRC | 16:42 | |
*** kgiusti has joined #openstack-oslo | 16:49 | |
*** salv-orlando has joined #openstack-oslo | 17:10 | |
*** salv-orlando has quit IRC | 17:14 | |
*** yamamoto has quit IRC | 17:42 | |
*** lpetrut has joined #openstack-oslo | 17:55 | |
*** lpetrut has quit IRC | 18:00 | |
*** salv-orlando has joined #openstack-oslo | 18:10 | |
*** salv-orlando has quit IRC | 18:15 | |
raildo | dhellmann, around? need some help with that cache stuff for the oslo.config driver | 18:22 |
dhellmann | raildo : sure, what's up? | 18:25 |
raildo | dhellmann, so I'm trying to implement to store the external values during the get method here https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L2940-L2952 | 18:27 |
raildo | dhellmann, the issue is that looks like we don't know the source for this values at this point | 18:27 |
dhellmann | hmm | 18:28 |
raildo | dhellmann, so, I'm trying to figure out how to discover if the value come from the external source, so we can store in the new cache, or if it come from the ini value, so we can put in that cache | 18:28 |
dhellmann | what is the value of loc when it comes back from the driver? | 18:28 |
raildo | dhellmann, hum, don't know, I didn't see any location been set over the driver creation | 18:30 |
*** e0ne has joined #openstack-oslo | 18:31 | |
dhellmann | oh, the driver is returning None as the location | 18:33 |
dhellmann | we're going to have to fix that to at least return a valid LocationInfo instance | 18:35 |
raildo | dhellmann, hum... got it, so we should create the LocationInfo and return it in the get method over the driver? https://review.openstack.org/#/c/562746/29/oslo_config/sources/ini.py (line 112) | 18:36 |
raildo | is that right? | 18:36 |
dhellmann | yeah | 18:37 |
dhellmann | oh, hang on | 18:37 |
dhellmann | this code is so messy | 18:37 |
dhellmann | if the option is in the namespace object used by the driver that call on line 108 will return a tuple that includes a valid LocationInfo | 18:38 |
dhellmann | line 112 is the case where the driver doesn't have the value, and None is ok there because the location is going to be ignored | 18:38 |
dhellmann | so you'll always have a valid LocationInfo on line 2950, but you won't be able to tell from it whether the value came out of a driver or not | 18:38 |
dhellmann | raildo : maybe using a separate cache is the wrong way to approach this | 18:39 |
raildo | dhellmann, yeah, that my felling at this point | 18:40 |
dhellmann | unfortunately I have another meeting now, but I suggest spending some time thinking about how to deal with the mutability issue differently | 18:40 |
raildo | I was thinking how bad would be to not cache values for external sources, at this point | 18:40 |
dhellmann | in order to not cache them you have to know they came from external sources, too | 18:40 |
dhellmann | so the real problem is that all values would be cached always | 18:40 |
dhellmann | and then the cache is discarded when the option is mutated | 18:40 |
raildo | dhellmann, sure, no problem, we can talk about that later, or in the worst case, in the tuesday meeting | 18:40 |
dhellmann | oh, maybe the second cache can be managed where we access the sources instead of in _do_get | 18:41 |
dhellmann | sorry, *inside* _do_get instead of where we *call* _do_get | 18:41 |
dhellmann | raildo : does that make sense? | 18:42 |
raildo | dhellmann, so, it would be one cache per driver? like we will be caching inside the driver? | 18:42 |
*** yamamoto has joined #openstack-oslo | 18:42 | |
dhellmann | you don't need a separate cache, no. but at the point where you're calling the sources you know that the value is coming from a source | 18:42 |
dhellmann | so you still only need 1 extra cache | 18:43 |
dhellmann | not one per driver | 18:43 |
dhellmann | down around line 3078 you'd check the cache before entering the loop | 18:43 |
dhellmann | and then on line 3081 before returning the value you'd add it to the cache | 18:43 |
dhellmann | I have to run :-( | 18:44 |
*** AlexeyAbashkin has quit IRC | 18:44 | |
raildo | dhellmann, no worries, we talk about that later | 18:44 |
*** yamamoto has quit IRC | 18:48 | |
*** salv-orlando has joined #openstack-oslo | 19:11 | |
*** salv-orlando has quit IRC | 19:16 | |
openstackgerrit | Hervé Beraud proposed openstack/oslo.db master: Rename enginefacade async method into asynchronous https://review.openstack.org/577525 | 19:32 |
openstackgerrit | Hervé Beraud proposed openstack/oslo.db master: Rename enginefacade async method into asynchronous https://review.openstack.org/577323 | 19:40 |
*** mago_ has quit IRC | 19:41 | |
*** yamamoto has joined #openstack-oslo | 19:44 | |
*** yamamoto has quit IRC | 19:48 | |
*** mmethot has quit IRC | 19:55 | |
*** salv-orlando has joined #openstack-oslo | 20:12 | |
*** salv-orlando has quit IRC | 20:16 | |
*** mmethot has joined #openstack-oslo | 20:27 | |
*** spilla has quit IRC | 20:41 | |
*** yamamoto has joined #openstack-oslo | 20:45 | |
*** yamamoto has quit IRC | 20:49 | |
*** raildo has quit IRC | 20:52 | |
*** e0ne has quit IRC | 20:54 | |
*** kgiusti has left #openstack-oslo | 20:57 | |
*** AlexeyAbashkin has joined #openstack-oslo | 21:02 | |
*** AlexeyAbashkin has quit IRC | 21:11 | |
*** salv-orlando has joined #openstack-oslo | 21:13 | |
*** salv-orlando has quit IRC | 21:17 | |
*** yamamoto has joined #openstack-oslo | 21:46 | |
*** yamamoto has quit IRC | 21:51 | |
*** eck` is now known as eck`gone | 21:59 | |
*** eck`gone is now known as eck` | 22:00 | |
*** eck` is now known as eck`gone | 22:01 | |
*** eck`gone is now known as eck` | 22:01 | |
*** edmondsw has joined #openstack-oslo | 22:09 | |
*** edmondsw has quit IRC | 22:13 | |
*** salv-orlando has joined #openstack-oslo | 22:13 | |
*** salv-orlando has quit IRC | 22:18 | |
*** yamamoto has joined #openstack-oslo | 22:47 | |
*** yamamoto has quit IRC | 22:53 | |
*** salv-orlando has joined #openstack-oslo | 23:14 | |
*** salv-orlando has quit IRC | 23:19 | |
*** tosky has quit IRC | 23:41 | |
*** yamamoto has joined #openstack-oslo | 23:49 | |
*** yamamoto has quit IRC | 23:54 | |
*** Guest30449 has quit IRC | 23:55 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!