| *** edmondsw has joined #openstack-oslo | 00:16 | |
| *** edmondsw has quit IRC | 00:23 | |
| *** edmondsw has joined #openstack-oslo | 00:24 | |
| *** edmondsw has quit IRC | 00:28 | |
| *** edmondsw has joined #openstack-oslo | 00:29 | |
| *** edmondsw has quit IRC | 00:32 | |
| *** edmondsw has joined #openstack-oslo | 00:32 | |
| *** edmondsw has quit IRC | 00:37 | |
| *** dave-mccowan has joined #openstack-oslo | 01:37 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 01:39 | |
| *** AlexeyAbashkin has quit IRC | 01:43 | |
| *** dstanek_ is now known as dstanek | 01:56 | |
| *** salv-orl_ has joined #openstack-oslo | 01:59 | |
| *** salv-orlando has quit IRC | 02:02 | |
| *** salv-orl_ has quit IRC | 02:11 | |
| *** gcb has joined #openstack-oslo | 02:13 | |
| *** salv-orlando has joined #openstack-oslo | 02:13 | |
| *** salv-orlando has quit IRC | 02:20 | |
| openstackgerrit | Tovin Seven proposed openstack/osprofiler master: Add lower-constraints job https://review.openstack.org/561134 | 02:21 |
|---|---|---|
| *** salv-orlando has joined #openstack-oslo | 02:22 | |
| *** harlowja_ has quit IRC | 02:53 | |
| *** toabctl has quit IRC | 03:00 | |
| *** harlowja has joined #openstack-oslo | 03:22 | |
| *** nicolasbock has quit IRC | 03:34 | |
| *** pbourke has quit IRC | 04:07 | |
| *** pbourke has joined #openstack-oslo | 04:08 | |
| *** bobh has joined #openstack-oslo | 04:17 | |
| *** hoonetorg has quit IRC | 04:27 | |
| *** bobh has quit IRC | 04:36 | |
| *** hoonetorg has joined #openstack-oslo | 04:41 | |
| *** harlowja has quit IRC | 04:52 | |
| *** links has joined #openstack-oslo | 05:18 | |
| *** e0ne has joined #openstack-oslo | 05:27 | |
| *** larainema has quit IRC | 05:34 | |
| *** toabctl has joined #openstack-oslo | 06:04 | |
| *** pcaruana has joined #openstack-oslo | 06:21 | |
| *** dims has quit IRC | 06:54 | |
| *** dims has joined #openstack-oslo | 06:56 | |
| *** dims has quit IRC | 07:01 | |
| *** dims has joined #openstack-oslo | 07:02 | |
| *** namnh has joined #openstack-oslo | 07:05 | |
| *** tenobreg has joined #openstack-oslo | 07:05 | |
| *** tellesnobrega has quit IRC | 07:09 | |
| *** tesseract has joined #openstack-oslo | 07:10 | |
| *** shardy has joined #openstack-oslo | 07:10 | |
| openstackgerrit | wangxiyuan proposed openstack/oslo.limit master: [WIP] Init repo https://review.openstack.org/556744 | 07:21 |
| *** salv-orlando has quit IRC | 07:23 | |
| *** salv-orlando has joined #openstack-oslo | 07:24 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 07:26 | |
| *** salv-orlando has quit IRC | 07:28 | |
| *** dmellado has joined #openstack-oslo | 07:32 | |
| *** rcernin has quit IRC | 07:33 | |
| *** salv-orlando has joined #openstack-oslo | 07:37 | |
| *** pcaruana has quit IRC | 07:45 | |
| *** pcaruana has joined #openstack-oslo | 07:46 | |
| *** salv-orlando has quit IRC | 08:00 | |
| *** salv-orlando has joined #openstack-oslo | 08:01 | |
| *** salv-orlando has quit IRC | 08:05 | |
| *** lucas-afk is now known as lucasagomes | 08:11 | |
| *** larainema has joined #openstack-oslo | 08:19 | |
| openstackgerrit | Nam Nguyen Hoai proposed openstack/oslo.config master: Handle config mapping changes https://review.openstack.org/526314 | 08:39 |
| openstackgerrit | Nam Nguyen Hoai proposed openstack/oslo.config master: Handle config mapping changes https://review.openstack.org/526314 | 08:41 |
| openstackgerrit | Tovin Seven proposed openstack/osprofiler master: [WiP] OSprofiler with OpenTracing compatible https://review.openstack.org/480018 | 08:52 |
| *** salv-orlando has joined #openstack-oslo | 08:58 | |
| namnh | bnemec, dhellmann: I've just update a new patch on [1]. Please take a look at it for me. Thanks [1] https://review.openstack.org/#/c/526314 | 08:58 |
| openstackgerrit | Nam Nguyen Hoai proposed openstack/oslo.config master: Handle config mapping changes https://review.openstack.org/526314 | 09:09 |
| *** salv-orl_ has joined #openstack-oslo | 09:43 | |
| *** salv-orlando has quit IRC | 09:47 | |
| *** msimonin has joined #openstack-oslo | 09:53 | |
| *** msimonin has quit IRC | 09:54 | |
| *** msimonin has joined #openstack-oslo | 09:57 | |
| *** namnh has quit IRC | 10:05 | |
| *** sambetts|afk is now known as sambetts | 10:09 | |
| *** nicolasbock has joined #openstack-oslo | 10:57 | |
| *** ansmith has quit IRC | 11:13 | |
| *** msimonin1 has joined #openstack-oslo | 11:13 | |
| *** msimonin has quit IRC | 11:16 | |
| *** lucasagomes is now known as lucas-hungry | 11:35 | |
| *** mugsie has quit IRC | 11:42 | |
| *** mugsie has joined #openstack-oslo | 11:42 | |
| *** mugsie has quit IRC | 11:42 | |
| *** mugsie has joined #openstack-oslo | 11:42 | |
| *** Guest4072 has quit IRC | 12:07 | |
| *** yassine has joined #openstack-oslo | 12:07 | |
| *** yassine is now known as Guest58458 | 12:08 | |
| *** yamamoto_ has quit IRC | 12:21 | |
| *** raildo has joined #openstack-oslo | 12:22 | |
| *** yamamoto has joined #openstack-oslo | 12:27 | |
| *** lucas-hungry is now known as lucasagomes | 12:33 | |
| *** AlexeyAbashkin has quit IRC | 12:34 | |
| *** rmascena has joined #openstack-oslo | 12:36 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 12:36 | |
| *** edmondsw has joined #openstack-oslo | 12:38 | |
| *** raildo has quit IRC | 12:38 | |
| *** e0ne has quit IRC | 12:40 | |
| *** ansmith has joined #openstack-oslo | 12:47 | |
| *** e0ne has joined #openstack-oslo | 12:59 | |
| *** kgiusti has joined #openstack-oslo | 13:01 | |
| msimonin1 | kgiusti ansmith we're coming | 13:05 |
| *** msimonin1 has quit IRC | 13:05 | |
| kgiusti | msimonin1: np | 13:05 |
| *** spilla has joined #openstack-oslo | 13:09 | |
| *** e0ne_ has joined #openstack-oslo | 13:17 | |
| *** tenobreg has left #openstack-oslo | 13:20 | |
| *** e0ne has quit IRC | 13:20 | |
| *** AlexeyAbashkin has quit IRC | 13:23 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 13:25 | |
| *** salv-orl_ has quit IRC | 13:27 | |
| *** AlexeyAbashkin has quit IRC | 13:52 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 13:57 | |
| *** janzian has joined #openstack-oslo | 14:03 | |
| *** nicolasbock has quit IRC | 14:10 | |
| *** bobh has joined #openstack-oslo | 14:14 | |
| *** AlexeyAbashkin has quit IRC | 14:23 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 14:25 | |
| *** moguimar has joined #openstack-oslo | 14:30 | |
| moguimar | guys, I have noticed that it is possible to register options after calling the conf like conf(sys.argv[1:]) | 14:31 |
| moguimar | and then retrieve the option value right after without another call to the conf | 14:32 |
| moguimar | but if the option has `required=True`, it doesn't raises RequiredOptError | 14:33 |
| *** AlexeyAbashkin has quit IRC | 14:40 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 14:42 | |
| stephenfin | moguimar: https://bugs.launchpad.net/oslo.config/+bug/1735790 | 14:44 |
| openstack | Launchpad bug 1735790 in oslo.config "Required opts don't raise exceptions" [Undecided,New] | 14:44 |
| stephenfin | Looks like the same issue. Not sure what the resolution will be | 14:44 |
| *** salv-orlando has joined #openstack-oslo | 14:51 | |
| *** AlexeyAbashkin has quit IRC | 14:54 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 14:56 | |
| *** AlexeyAbashkin has quit IRC | 15:04 | |
| *** yikun_ has quit IRC | 15:07 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 15:08 | |
| *** yikun_ has joined #openstack-oslo | 15:08 | |
| moguimar | thanks stephenfin | 15:12 |
| moguimar | that is the same behavior I'm seeing here | 15:12 |
| *** yamamoto has quit IRC | 15:13 | |
| *** yamamoto has joined #openstack-oslo | 15:14 | |
| moguimar | the other issue I'm having is when I try to register the same opt twice, the first atempt returns True and the following ones returns False | 15:16 |
| moguimar | but when the option is an URIOpt I get an Exception instead | 15:16 |
| moguimar | and it doesn't even makes sense | 15:17 |
| moguimar | AttributeError: 'URI' object has no attribute 'value' | 15:17 |
| *** yamamoto has quit IRC | 15:19 | |
| dhellmann | moguimar : the return value for register_opt() is based on whether the option has been seen before (True means it is new, False means it is not new) | 15:31 |
| dhellmann | I would have to see a traceback for the other issue; that sounds like it might be a bug. | 15:31 |
| *** yamamoto has joined #openstack-oslo | 15:34 | |
| moguimar | dhellmann: https://pastebin.com/bD6MK6MC | 15:41 |
| dhellmann | moguimar : one thing that may not be clear is that we expect each Opt instance to be kept and reused -- some state is stored in that object | 15:42 |
| dhellmann | at least for situations where you expect to re-register the same option | 15:42 |
| dhellmann | that's what's triggering this error, although it's a bug in the URIOpt I think | 15:43 |
| dhellmann | the registration code is trying to figure out if two options are the same, and the comparison expects to look at the value of the option, but this option instance doesn't have a value yet | 15:44 |
| dhellmann | either because it doesn't have a default and it's not set in the config file, or because URIOpt doesn't initialize self.value properly | 15:44 |
| moguimar | it also breaks after loading the confs | 15:46 |
| moguimar | with the same traceback | 15:46 |
| dhellmann | yeah, so it sounds like an issue with the URIOpt | 15:46 |
| dhellmann | let me look at that code... | 15:46 |
| dhellmann | oh, interesting, that's a particular thing in the URIType | 15:48 |
| dhellmann | not just the general Opt | 15:48 |
| *** janzian has quit IRC | 15:49 | |
| moguimar | class URI(ConfigType) | 15:49 |
| moguimar | it doesn't sets self.value before __call)__() | 15:50 |
| moguimar | it doesn't sets self.value before __call__()* | 15:50 |
| dhellmann | aha | 15:50 |
| moguimar | it should at least initialize it in the __init__ | 15:50 |
| dhellmann | Opt._vars_for_cmp is including the type and the type hasn't been initialized yet for that option | 15:51 |
| dhellmann | I'm not sure the type needs to use the value in its comparison | 15:51 |
| dhellmann | the other types do not | 15:52 |
| moguimar | In [5]: conf.register_opt(cfg.URIOpt('uri', schemes=["http", "https"]), | 15:52 |
| moguimar | ...: cfg.OptGroup(group_name)) | 15:52 |
| dhellmann | and the "type" is "URI" not a specific URL | 15:52 |
| moguimar | Out[5]: True | 15:52 |
| moguimar | In [6]: conf.register_opt(cfg.URIOpt('uri', schemes=["http", "https"]), | 15:52 |
| moguimar | ...: cfg.OptGroup(group_name)) | 15:52 |
| moguimar | Out[6]: False | 15:52 |
| moguimar | y | 15:52 |
| moguimar | it stops breaking after setting self.value = None | 15:52 |
| moguimar | in the init | 15:52 |
| dhellmann | I think we want to remove self.value completely from the URIType | 15:52 |
| dhellmann | sorry, URI class | 15:53 |
| dhellmann | the way it is implemented now makes no sense | 15:53 |
| dhellmann | it's like saying the types of 5 and 10 are different because 5 and 10 are different | 15:53 |
| dhellmann | or that the types of 2 lists with different contents are different, even though they are both lists | 15:53 |
| moguimar | another weird thing in the same file | 15:54 |
| moguimar | HostAddress extends object | 15:54 |
| moguimar | while everyone else extends ConfigType | 15:54 |
| *** AlexeyAbashkin has quit IRC | 15:55 | |
| dhellmann | hmm, that's odd | 15:55 |
| dhellmann | you could propose a separate patch to fix that | 15:56 |
| dhellmann | I'm looking at the uri thing to make sure changing it won't change any other expected behaviors | 15:56 |
| dhellmann | it doesn't seem so | 15:56 |
| *** AlexeyAbashkin has joined #openstack-oslo | 15:56 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.config master: ignore URI value when comparing types for equality https://review.openstack.org/562724 | 15:57 |
| moguimar | but following the other classes | 15:58 |
| dhellmann | moguimar : can you try this change out and let me know if it fixes your issue ^^ | 15:58 |
| moguimar | URI should compare max_length and schemes in the __eq__, not value | 15:58 |
| dhellmann | the tests pass for me | 15:58 |
| moguimar | sure dhellmann | 15:58 |
| dhellmann | oh, yeah, that's a good point | 15:58 |
| moguimar | dhellmann: let me know when you update the patch with max_length and schemes | 16:00 |
| dhellmann | yeah, working on that | 16:01 |
| dhellmann | those are optional so it's not trivial | 16:01 |
| *** links has quit IRC | 16:01 | |
| dhellmann | although I guess it could be | 16:01 |
| *** nicolasbock has joined #openstack-oslo | 16:02 | |
| moguimar | other optional stuff are also checked in the other types | 16:02 |
| *** pcaruana has quit IRC | 16:03 | |
| *** janzian has joined #openstack-oslo | 16:04 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.config master: fix URI type equality comparison https://review.openstack.org/562724 | 16:06 |
| dhellmann | moguimar : ^^ | 16:06 |
| dhellmann | moguimar : it's time for lunch, so I'll be back in a little bit | 16:09 |
| moguimar | it is 18:00 here | 16:10 |
| moguimar | Brno-cz | 16:11 |
| *** AlexeyAbashkin has quit IRC | 16:11 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 16:14 | |
| moguimar | 15 | 16:35 |
| openstackgerrit | Moisés Guimarães de Medeiros proposed openstack/oslo.config master: ConfigurationSource base class https://review.openstack.org/559389 | 16:37 |
| *** lucasagomes is now known as lucas-afk | 16:40 | |
| *** bobh has quit IRC | 16:54 | |
| openstackgerrit | Moisés Guimarães de Medeiros proposed openstack/oslo.config master: ConfigurationSource base class https://review.openstack.org/559389 | 16:56 |
| openstackgerrit | Moisés Guimarães de Medeiros proposed openstack/oslo.config master: Create INI file ConfigurationSourceDriver. https://review.openstack.org/562746 | 16:56 |
| *** AlexeyAbashkin has quit IRC | 16:57 | |
| *** Guest58458 has quit IRC | 16:59 | |
| *** Guest58458 has joined #openstack-oslo | 17:03 | |
| *** pblaho has quit IRC | 17:06 | |
| *** e0ne has joined #openstack-oslo | 17:12 | |
| *** bobh has joined #openstack-oslo | 17:13 | |
| *** e0ne_ has quit IRC | 17:15 | |
| *** yamamoto has quit IRC | 17:20 | |
| *** shardy has quit IRC | 17:35 | |
| *** sambetts is now known as sambetts|afk | 17:52 | |
| *** e0ne has quit IRC | 17:54 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.config master: fix URI type equality comparison https://review.openstack.org/562724 | 18:10 |
| *** Guest58458 has quit IRC | 18:11 | |
| *** yamamoto has joined #openstack-oslo | 18:20 | |
| *** yikun__ has joined #openstack-oslo | 18:25 | |
| *** Guest58458 has joined #openstack-oslo | 18:27 | |
| *** yikun_ has quit IRC | 18:28 | |
| *** yamamoto has quit IRC | 18:30 | |
| *** e0ne has joined #openstack-oslo | 18:47 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 18:49 | |
| *** tesseract has quit IRC | 18:55 | |
| *** AlexeyAbashkin has quit IRC | 18:59 | |
| openstackgerrit | Samuel Pilla proposed openstack/oslo.config master: ConfigurationSource base class https://review.openstack.org/559389 | 19:48 |
| *** harlowja has joined #openstack-oslo | 20:03 | |
| *** e0ne has quit IRC | 20:07 | |
| *** e0ne has joined #openstack-oslo | 20:19 | |
| *** kgiusti has left #openstack-oslo | 20:31 | |
| *** ansmith has quit IRC | 20:42 | |
| *** e0ne has quit IRC | 21:10 | |
| *** spilla has quit IRC | 21:19 | |
| *** rmascena has quit IRC | 21:20 | |
| *** ansmith has joined #openstack-oslo | 21:30 | |
| *** janzian has quit IRC | 21:39 | |
| *** yamamoto has joined #openstack-oslo | 21:49 | |
| *** bobh has quit IRC | 22:02 | |
| *** rcernin has joined #openstack-oslo | 22:30 | |
| *** edmondsw has quit IRC | 22:49 | |
| *** edmondsw has joined #openstack-oslo | 22:49 | |
| *** edmondsw has quit IRC | 22:53 | |
| *** Guest58458 has quit IRC | 23:05 | |
| *** salv-orlando has quit IRC | 23:13 | |
| *** salv-orlando has joined #openstack-oslo | 23:13 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!