| *** harlowja has quit IRC | 00:08 | |
| *** bobh has quit IRC | 00:16 | |
| *** yamamoto has joined #openstack-oslo | 00:47 | |
| *** yamamoto has quit IRC | 00:52 | |
| *** salv-orlando has joined #openstack-oslo | 00:59 | |
| *** salv-orlando has quit IRC | 01:03 | |
| *** namnh has joined #openstack-oslo | 01:25 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/oslo.db master: Improve exponential backoff for wrap_db_retry https://review.openstack.org/527362 | 01:48 |
|---|---|---|
| *** salv-orlando has joined #openstack-oslo | 02:00 | |
| *** salv-orlando has quit IRC | 02:04 | |
| *** kmalloc has quit IRC | 02:06 | |
| *** edmondsw has joined #openstack-oslo | 02:19 | |
| *** edmondsw has quit IRC | 02:24 | |
| *** songjian has joined #openstack-oslo | 02:30 | |
| *** d0ugal has quit IRC | 02:40 | |
| *** d0ugal has joined #openstack-oslo | 02:48 | |
| eandersson | Any reason why min_pool_size is a thing in oslo.db? I don't think it's ever been used? | 02:50 |
| openstackgerrit | Brian Rosmaita proposed openstack/oslo.config master: Make List option format bounds-sensitive https://review.openstack.org/560716 | 02:51 |
| *** salv-orlando has joined #openstack-oslo | 03:00 | |
| *** salv-orlando has quit IRC | 03:05 | |
| *** dave-mccowan has quit IRC | 03:18 | |
| *** d0ugal has quit IRC | 03:39 | |
| *** d0ugal has joined #openstack-oslo | 03:49 | |
| *** nicolasbock has quit IRC | 03:49 | |
| *** salv-orlando has joined #openstack-oslo | 04:01 | |
| *** salv-orlando has quit IRC | 04:05 | |
| *** edmondsw has joined #openstack-oslo | 04:07 | |
| *** edmondsw has quit IRC | 04:12 | |
| *** janzian has quit IRC | 04:29 | |
| *** lpetrut has joined #openstack-oslo | 05:02 | |
| *** salv-orlando has joined #openstack-oslo | 05:02 | |
| *** salv-orlando has quit IRC | 05:05 | |
| *** salv-orlando has joined #openstack-oslo | 05:05 | |
| *** chhagarw has joined #openstack-oslo | 05:07 | |
| *** chhavi__ has joined #openstack-oslo | 05:07 | |
| *** links has joined #openstack-oslo | 05:09 | |
| *** ianychoi_ has joined #openstack-oslo | 05:19 | |
| *** jbadiapa has quit IRC | 05:19 | |
| *** ianychoi has quit IRC | 05:23 | |
| *** jaosorior has quit IRC | 05:26 | |
| *** d0ugal has quit IRC | 05:41 | |
| *** fnordahl has quit IRC | 05:41 | |
| *** fnordahl has joined #openstack-oslo | 05:43 | |
| *** lpetrut has quit IRC | 05:46 | |
| *** openstackgerrit has quit IRC | 05:48 | |
| *** d0ugal has joined #openstack-oslo | 05:48 | |
| *** jaosorior has joined #openstack-oslo | 05:55 | |
| *** lpetrut has joined #openstack-oslo | 05:55 | |
| *** edmondsw has joined #openstack-oslo | 05:56 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 05:58 | |
| *** edmondsw has quit IRC | 06:00 | |
| *** threestrands has joined #openstack-oslo | 06:05 | |
| *** e0ne has joined #openstack-oslo | 06:11 | |
| *** songjian has quit IRC | 06:11 | |
| *** AlexeyAbashkin has quit IRC | 06:24 | |
| *** lpetrut has quit IRC | 06:33 | |
| *** salv-orlando has quit IRC | 06:35 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 06:35 | |
| *** salv-orlando has joined #openstack-oslo | 06:35 | |
| *** salv-orlando has quit IRC | 06:39 | |
| *** salv-orlando has joined #openstack-oslo | 06:42 | |
| *** AlexeyAbashkin has quit IRC | 06:44 | |
| *** msimonin has quit IRC | 06:47 | |
| *** msimonin has joined #openstack-oslo | 06:48 | |
| *** msimonin has quit IRC | 06:52 | |
| *** e0ne has quit IRC | 06:58 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 07:01 | |
| *** bhagyashris has quit IRC | 07:04 | |
| *** bhagyashris has joined #openstack-oslo | 07:04 | |
| *** yamamoto has joined #openstack-oslo | 07:05 | |
| *** e0ne has joined #openstack-oslo | 07:05 | |
| *** jbadiapa has joined #openstack-oslo | 07:28 | |
| *** tesseract has joined #openstack-oslo | 07:39 | |
| *** msimonin has joined #openstack-oslo | 07:40 | |
| *** edmondsw has joined #openstack-oslo | 07:44 | |
| *** msimonin has quit IRC | 07:44 | |
| *** edmondsw has quit IRC | 07:48 | |
| *** e0ne_ has joined #openstack-oslo | 07:52 | |
| *** e0ne__ has joined #openstack-oslo | 07:53 | |
| *** e0ne has quit IRC | 07:53 | |
| *** lucas-afk is now known as lucasagomes | 07:55 | |
| *** e0ne_ has quit IRC | 07:57 | |
| *** gcb has quit IRC | 07:57 | |
| *** msimonin has joined #openstack-oslo | 08:12 | |
| *** pcaruana has joined #openstack-oslo | 08:12 | |
| *** d0ugal has quit IRC | 08:14 | |
| *** yamamoto has quit IRC | 08:17 | |
| *** d0ugal has joined #openstack-oslo | 08:18 | |
| *** AlexeyAbashkin has quit IRC | 08:29 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 08:30 | |
| *** salv-orlando has quit IRC | 08:30 | |
| *** salv-orlando has joined #openstack-oslo | 08:31 | |
| *** yamamoto has joined #openstack-oslo | 08:32 | |
| *** lpetrut has joined #openstack-oslo | 08:33 | |
| *** salv-orlando has quit IRC | 08:35 | |
| *** yamamoto has quit IRC | 08:36 | |
| *** sambetts|afk is now known as sambetts | 08:45 | |
| *** msimonin has quit IRC | 08:57 | |
| *** msimonin has joined #openstack-oslo | 09:05 | |
| *** rha has joined #openstack-oslo | 09:21 | |
| *** salv-orlando has joined #openstack-oslo | 09:31 | |
| *** salv-orlando has quit IRC | 09:37 | |
| *** salv-orlando has joined #openstack-oslo | 09:39 | |
| *** yamamoto has joined #openstack-oslo | 09:46 | |
| *** yamamoto has quit IRC | 09:48 | |
| *** yamamoto has joined #openstack-oslo | 09:49 | |
| *** yamamoto has quit IRC | 09:52 | |
| *** yamamoto has joined #openstack-oslo | 09:54 | |
| *** yamamoto has quit IRC | 10:00 | |
| *** kmalloc has joined #openstack-oslo | 10:01 | |
| *** yamamoto has joined #openstack-oslo | 10:01 | |
| *** namnh has quit IRC | 10:06 | |
| *** AlexeyAbashkin has quit IRC | 10:10 | |
| *** pbourke has quit IRC | 10:14 | |
| *** pbourke has joined #openstack-oslo | 10:15 | |
| *** lpetrut has quit IRC | 10:21 | |
| *** threestrands has quit IRC | 10:24 | |
| *** e0ne__ has quit IRC | 10:46 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 10:53 | |
| *** yamamoto has quit IRC | 10:56 | |
| *** yamamoto has joined #openstack-oslo | 11:02 | |
| *** yamamoto has quit IRC | 11:03 | |
| *** ansmith has quit IRC | 11:04 | |
| *** yamamoto has joined #openstack-oslo | 11:08 | |
| *** yamamoto has quit IRC | 11:11 | |
| *** yamamoto has joined #openstack-oslo | 11:11 | |
| *** edmondsw has joined #openstack-oslo | 11:20 | |
| *** openstackgerrit has joined #openstack-oslo | 11:21 | |
| openstackgerrit | Stephen Finucane proposed openstack/oslo.config master: sphinxext: Use 'sphinx.util.logging' https://review.openstack.org/560865 | 11:21 |
| openstackgerrit | Stephen Finucane proposed openstack/oslo.config master: sphinxext: Address nits from Ic6c2dcbe7823dd3fdc71db8dc5afab2d604559e3 https://review.openstack.org/560866 | 11:22 |
| *** edmondsw has quit IRC | 11:24 | |
| *** lpetrut has joined #openstack-oslo | 11:25 | |
| *** nicolasbock has joined #openstack-oslo | 11:30 | |
| *** lucasagomes is now known as lucas-hungry | 11:31 | |
| *** yamamoto has quit IRC | 11:33 | |
| *** rcernin has quit IRC | 11:35 | |
| *** AlexeyAbashkin has quit IRC | 12:28 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 12:29 | |
| *** yamamoto has joined #openstack-oslo | 12:30 | |
| *** raildo has joined #openstack-oslo | 12:33 | |
| *** dave-mccowan has joined #openstack-oslo | 12:33 | |
| *** yamamoto has quit IRC | 12:35 | |
| *** ansmith has joined #openstack-oslo | 12:39 | |
| *** yamamoto has joined #openstack-oslo | 12:47 | |
| *** kgiusti has joined #openstack-oslo | 12:49 | |
| *** yamamoto has quit IRC | 12:49 | |
| *** spilla has joined #openstack-oslo | 12:54 | |
| *** jbadiapa has quit IRC | 13:00 | |
| *** edmondsw has joined #openstack-oslo | 13:01 | |
| *** yamamoto has joined #openstack-oslo | 13:01 | |
| *** yamamoto has quit IRC | 13:01 | |
| *** bobh has joined #openstack-oslo | 13:02 | |
| *** msimonin has quit IRC | 13:02 | |
| *** msimonin has joined #openstack-oslo | 13:04 | |
| *** yamamoto has joined #openstack-oslo | 13:05 | |
| *** lucas-hungry is now known as lucasagomes | 13:05 | |
| *** yamamoto has quit IRC | 13:09 | |
| *** jbadiapa has joined #openstack-oslo | 13:15 | |
| *** edmondsw has quit IRC | 13:20 | |
| *** yamamoto has joined #openstack-oslo | 13:21 | |
| *** edmondsw has joined #openstack-oslo | 13:21 | |
| *** edmondsw has quit IRC | 13:21 | |
| *** yamamoto has quit IRC | 13:24 | |
| *** links has quit IRC | 13:27 | |
| *** jaosorior has quit IRC | 13:29 | |
| *** yamamoto has joined #openstack-oslo | 13:43 | |
| *** yamamoto has quit IRC | 13:44 | |
| *** yamamoto has joined #openstack-oslo | 13:48 | |
| *** yamamoto has quit IRC | 13:49 | |
| *** yamamoto has joined #openstack-oslo | 13:49 | |
| *** chhavi__ has quit IRC | 13:55 | |
| *** chhagarw has quit IRC | 13:55 | |
| *** chhagarw has joined #openstack-oslo | 13:55 | |
| *** janzian has joined #openstack-oslo | 13:57 | |
| bhagyashris | gcb: Hi | 14:00 |
| bhagyashris | dims: Hi, | 14:03 |
| dims | bhagyashris : hello | 14:03 |
| *** jaosorior has joined #openstack-oslo | 14:04 | |
| bhagyashris | dims: I just want to know about the spec https://docs.openstack.org/oslo.config/latest/reference/mutable.html which basically give the provision to make the conf parameter as mutable, so on which basis or what are the criteria to make the conf parameter as mutable in any project | 14:04 |
| bhagyashris | dims: there is one patch submitted in nova https://review.openstack.org/#/c/319203/3 so is that mean only two parameters will be mutable and others will be non-mutable | 14:05 |
| *** lpetrut has quit IRC | 14:08 | |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/oslo.privsep master: Skip unit tests in bandit scan https://review.openstack.org/560917 | 14:08 |
| *** mugsie has quit IRC | 14:08 | |
| *** lpetrut has joined #openstack-oslo | 14:08 | |
| dims | bhagyashris : right about the nova patch. | 14:09 |
| bhagyashris | dims: Is there any guideline: Which parameter should make mutable = True in source code like nova patch: https://review.openstack.org/#/c/319203/3 | 14:09 |
| dims | bhagyashris : mostly it is feedback from operators etc who say, "oh i wish i could tweak that option and not have to restart things because i have something in progress" | 14:10 |
| dims | in the nova case it's live migration | 14:10 |
| dims | if you see it says "These will immediately apply to all running live migrations." | 14:10 |
| dims | then the other consideration is on the page you listed first, where we ask .... you need all these things to line up right for you to be able to mark something mutable | 14:11 |
| bhagyashris | dims: IMO we can do that by SIGUP signal that is also reloading the conf file without restarting the service | 14:11 |
| *** e0ne has joined #openstack-oslo | 14:12 | |
| openstackgerrit | John Eckersberg proposed openstack/oslo.messaging master: Do not use threading.Event https://review.openstack.org/558882 | 14:13 |
| dims | bhagyashris : yes, mutable uses the SIGHUP signal ... it's also partly documentation in the sense that you are indicating to end users that "these options which we have marked mutable will always work properly" | 14:14 |
| dims | so it's a contract | 14:14 |
| bhagyashris | dims: If that is the case then all the conf option should mark as mutable = True | 14:16 |
| dims | will you be able to guarantee that? (see example 4 - https://docs.openstack.org/oslo.config/latest/reference/mutable.html#id4 ) | 14:17 |
| bhagyashris | dims: Means if we mark it as True then operator will need not to pass the SIGHUP signal explicitly | 14:18 |
| dims | a simple mistake in coding or review it is easy to lose that capability | 14:18 |
| dims | if you make the mistake in example 4, then a SIGHUP will not help | 14:18 |
| bnemec | And changing some options is inherently dangerous (db connection, messaging connection, etc.) | 14:19 |
| dims | so it's better to mark as few as possible and then make sure you test that | 14:19 |
| dims | ++ bnemec | 14:20 |
| bnemec | Just by making the change you can have data get lost. | 14:20 |
| bhagyashris | dims: ok means if the conf option used in any loop and if it's modified by the operator then the reloading of that option using the SIGHUP signal will not help so better to make it as mutable = True right? | 14:30 |
| *** jbadiapa has quit IRC | 14:33 | |
| dims | bhagyashris : let me twist it around ... if you really want your operators to be able to change an option, you review every location where it is loaded/used, make sure you are not caching it etc (like it says in the doc), then finally mark it mutable and test with SIGHUP | 14:36 |
| *** msimonin has quit IRC | 14:36 | |
| bhagyashris | dims: basically I am not aware about The option is cached on the stack can you please give little bit idea | 14:37 |
| *** msimonin has joined #openstack-oslo | 14:38 | |
| dims | the example for that basically says if you store the CONF value outside the loop, then a SIGHUP will not help because you don't really re-read the value to have it take effect | 14:38 |
| dims | bhagyashris : i think the doc is very well written, so would recommend reading it again fully | 14:39 |
| bhagyashris | dims: ok now got some idea thank you :) | 14:39 |
| dims | cool. ttyl | 14:40 |
| bhagyashris | dims: thanks :) | 14:40 |
| openstackgerrit | Doug Hellmann proposed openstack/futurist master: fix lower constraints and uncap eventlet https://review.openstack.org/560583 | 14:45 |
| *** AlexeyAbashkin has quit IRC | 14:45 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.concurrency master: fix lower constraints and uncap eventlet https://review.openstack.org/560586 | 14:46 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.messaging master: fix lower constraints and uncap eventlet https://review.openstack.org/560587 | 14:46 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.privsep master: fix lower constraints and uncap eventlet https://review.openstack.org/560588 | 14:47 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.reports master: fix lower constraints and uncap eventlet https://review.openstack.org/560590 | 14:47 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.rootwrap master: fix lower constraints and uncap eventlet https://review.openstack.org/560591 | 14:48 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.vmware master: fix lower constraints and uncap eventlet https://review.openstack.org/560592 | 14:48 |
| openstackgerrit | Doug Hellmann proposed openstack/taskflow master: fix lower constraints and uncap eventlet https://review.openstack.org/560593 | 14:49 |
| *** mugsie has joined #openstack-oslo | 14:54 | |
| dhellmann | bnemec : I reworked those patches to merge the sets of changes into 1 per repo | 14:55 |
| bnemec | dhellmann: Yep, thanks | 14:56 |
| *** dmitryme has quit IRC | 15:00 | |
| *** DinaBelova has quit IRC | 15:00 | |
| *** mugsie has quit IRC | 15:04 | |
| *** mugsie has joined #openstack-oslo | 15:06 | |
| *** mugsie has quit IRC | 15:06 | |
| *** mugsie has joined #openstack-oslo | 15:06 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 15:07 | |
| *** mugsie has quit IRC | 15:08 | |
| *** mugsie has joined #openstack-oslo | 15:08 | |
| *** mugsie has quit IRC | 15:08 | |
| *** mugsie has joined #openstack-oslo | 15:08 | |
| *** AlexeyAbashkin has quit IRC | 15:12 | |
| *** msimonin has quit IRC | 15:12 | |
| *** DinaBelova has joined #openstack-oslo | 15:15 | |
| *** jaosorior has quit IRC | 15:15 | |
| *** dmitryme has joined #openstack-oslo | 15:16 | |
| openstackgerrit | Merged openstack/oslo.config master: sphinxext: Start parsing 'Opt.help' as rST https://review.openstack.org/553860 | 15:18 |
| *** e0ne has quit IRC | 15:30 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 15:32 | |
| *** edmondsw has joined #openstack-oslo | 15:50 | |
| *** edmondsw has quit IRC | 15:53 | |
| *** edmondsw has joined #openstack-oslo | 15:58 | |
| *** spilla has quit IRC | 16:01 | |
| *** lucasagomes is now known as lucas-afk | 16:11 | |
| openstackgerrit | Ben Nemec proposed openstack/oslo.cache master: Switch pep8 job to python 3 https://review.openstack.org/560957 | 16:11 |
| *** janzian has quit IRC | 16:20 | |
| *** shardy has quit IRC | 16:21 | |
| *** e0ne has joined #openstack-oslo | 16:25 | |
| openstackgerrit | Ben Nemec proposed openstack/oslo.concurrency master: Switch pep8 job to python 3 https://review.openstack.org/560963 | 16:28 |
| *** janzian has joined #openstack-oslo | 16:28 | |
| *** msimonin has joined #openstack-oslo | 16:32 | |
| *** spilla has joined #openstack-oslo | 16:33 | |
| openstackgerrit | Ben Nemec proposed openstack/oslo.config master: Switch pep8 job to python 3 https://review.openstack.org/560967 | 16:42 |
| *** yamamoto has quit IRC | 16:47 | |
| *** jbadiapa has joined #openstack-oslo | 16:52 | |
| openstackgerrit | Ben Nemec proposed openstack/oslo.context master: Switch pep8 job to python 3 https://review.openstack.org/560972 | 16:55 |
| *** dtruong_ has joined #openstack-oslo | 16:56 | |
| *** dtruong_ has quit IRC | 16:56 | |
| *** dtruong has joined #openstack-oslo | 16:57 | |
| *** yamamoto has joined #openstack-oslo | 16:58 | |
| *** yamamoto has quit IRC | 17:03 | |
| dtruong | bnemec: I'm looking at the oslo_service threadgroup implementation. Is there a reason why add_timer function does not take stop_on_exception parameter to be passed on to FixedIntervalLoopingCall? https://github.com/openstack/oslo.service/blob/master/oslo_service/threadgroup.py#L86 | 17:08 |
| bnemec | dtruong: I'm not familiar enough with that code to say one way or another. | 17:11 |
| *** mugsie has quit IRC | 17:14 | |
| *** mugsie has joined #openstack-oslo | 17:15 | |
| *** mugsie has quit IRC | 17:15 | |
| *** mugsie has joined #openstack-oslo | 17:15 | |
| dtruong | bnemec: Thanks for the reply. Looks like the add_timer function was created and last modified 6 years ago. Then 3 years ago the stop_on_exception parameter was added to FixedIntervalLoopingCall. | 17:17 |
| dtruong | So seems like when the change was made to FixedIntervalLoopingCall, the corresponding change to threadgroup add_timer was not made. | 17:19 |
| dtruong | I'll propose a patchset because I need the threadgroup timer to continue on exceptions. | 17:19 |
| *** pblaho has quit IRC | 17:26 | |
| bnemec | dtruong: Sounds good, thanks | 17:33 |
| *** lpetrut has quit IRC | 17:44 | |
| *** sambetts is now known as sambetts|afk | 17:48 | |
| *** tesseract has quit IRC | 17:55 | |
| *** yamamoto has joined #openstack-oslo | 18:04 | |
| *** pcaruana has quit IRC | 18:09 | |
| *** openstackgerrit has quit IRC | 18:19 | |
| kgiusti | bnemec: hey - how would you feel if I left the zmq dependencies in requirements.txt for rocky instead of moving them in https://review.openstack.org/#/c/525319/7 ? | 18:29 |
| kgiusti | bnemec: seems like forcing folks (if there are any) to update their reqs for zmq, then pulling zmq in S... well.. extraineous? | 18:29 |
| bnemec | kgiusti: I'd be fine with that. It solves the quandary of whether we have to do a major release to remove deps for a broken driver. :-) | 18:30 |
| bnemec | And that too. | 18:30 |
| *** openstackgerrit has joined #openstack-oslo | 18:31 | |
| openstackgerrit | Duc Truong proposed openstack/oslo.service master: Add stop_on_exception to TG timers https://review.openstack.org/561005 | 18:31 |
| *** links has joined #openstack-oslo | 18:31 | |
| kgiusti | bnemec: agreed | 18:31 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.privsep master: fix lower constraints and uncap eventlet https://review.openstack.org/560588 | 18:34 |
| *** lpetrut has joined #openstack-oslo | 18:37 | |
| *** salv-orlando has quit IRC | 19:04 | |
| *** salv-orlando has joined #openstack-oslo | 19:04 | |
| *** AlexeyAbashkin has quit IRC | 19:06 | |
| *** salv-orlando has quit IRC | 19:09 | |
| *** msimonin1 has joined #openstack-oslo | 19:10 | |
| *** msimonin has quit IRC | 19:11 | |
| openstackgerrit | Ken Giusti proposed openstack/oslo.messaging master: Move requirements for the optional drivers (pika, zmq, etc) https://review.openstack.org/525319 | 19:41 |
| openstackgerrit | Raildo Mascena proposed openstack/oslo.config master: Base class for a configuration driver https://review.openstack.org/560027 | 19:45 |
| bnemec | kgiusti: Did you mean to put the zmq deps back in that patch set? | 19:46 |
| *** links has quit IRC | 19:46 | |
| bnemec | (they're not, from what I see) | 19:46 |
| kgiusti | bnemec: ah, crap. | 19:47 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.config master: set default python to python3 https://review.openstack.org/561025 | 19:57 |
| kgiusti | bnemec: turns out you can give tox extras, which means we could remove driver deps from test-requirements.txt, but it requires tox >= 2.4 | 20:00 |
| *** ansmith has quit IRC | 20:00 | |
| openstackgerrit | Ken Giusti proposed openstack/oslo.messaging master: Move requirements for the optional drivers (amqp1, kafka) https://review.openstack.org/525319 | 20:02 |
| *** snapiri has quit IRC | 20:04 | |
| *** oanson has quit IRC | 20:05 | |
| *** salv-orlando has joined #openstack-oslo | 20:05 | |
| *** salv-orlando has quit IRC | 20:09 | |
| *** salv-orlando has joined #openstack-oslo | 20:09 | |
| *** e0ne has quit IRC | 20:10 | |
| *** snapiri has joined #openstack-oslo | 20:11 | |
| *** oanson has joined #openstack-oslo | 20:12 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.cache master: Avoid use of autodoc_tree_index_modules https://review.openstack.org/555080 | 20:13 |
| bnemec | kgiusti: Interesting. 2.4 is about a year and a half old, so it might be reasonable to start requiring it. | 20:14 |
| bnemec | On the other hand, I'm apparently still on 2.3.1 on my dev vm. :-) | 20:14 |
| kgiusti | bnemec: yeah, codesearch doesn't catch anything > than that | 20:16 |
| kgiusti | bnemec: oop nope monasca's using 2.5... | 20:17 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.concurrency master: set default python to python3 https://review.openstack.org/561036 | 20:20 |
| *** yamamoto has quit IRC | 20:21 | |
| *** yamamoto has joined #openstack-oslo | 20:22 | |
| *** chhagarw has quit IRC | 20:22 | |
| *** kgiusti has left #openstack-oslo | 20:23 | |
| bnemec | kgiusti: There are a bunch of projects requiring 2.3.2, which is actually newer chronologically. | 20:23 |
| dhellmann | bnemec : https://review.openstack.org/561038 | 20:23 |
| bnemec | dhellmann: So I should start switching all the jobs instead of just pep8? | 20:25 |
| dhellmann | bnemec : we might as well do them all at once. Only pep8 and releasenotes actually change in CI when we change tox.ini though | 20:25 |
| dhellmann | I need to set up an etherpad for tracking this stuff | 20:26 |
| bnemec | dhellmann: I had started https://etherpad.openstack.org/p/oslo-pep8-python3 | 20:26 |
| dhellmann | cool | 20:26 |
| dhellmann | https://etherpad.openstack.org/p/converting-secondary-jobs-to-py3 can link to that with some notes | 20:26 |
| bnemec | Although that's overly specific now. | 20:26 |
| bnemec | Maybe we could push followup changes with noop code diffs to validate the ci jobs? | 20:27 |
| bnemec | Or just trust that the submitter ran the unit tests, I supposed. The devstack jobs won't be impacted, right? | 20:28 |
| bnemec | *suppose | 20:28 |
| dhellmann | the devstack jobs won't be changed | 20:29 |
| dhellmann | I don't think we can test speculative job changes that way because of the settings on the project-config repository | 20:30 |
| dhellmann | that's part of why I have that set to depends-on the tox changes, so we can verify those and the project team has some control over when the job change lands | 20:30 |
| bnemec | Ah, right. They don't actually use tox for docs jobs. | 20:32 |
| dhellmann | right | 20:32 |
| *** salv-orlando has quit IRC | 20:47 | |
| *** salv-orlando has joined #openstack-oslo | 20:48 | |
| *** janzian has quit IRC | 20:48 | |
| *** spilla has quit IRC | 20:52 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.config master: DNM: test the new python3 version of the release notes job https://review.openstack.org/561046 | 20:52 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.config master: DNM: test the new python3 version of the release notes job https://review.openstack.org/561046 | 20:54 |
| *** raildo has quit IRC | 20:55 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.config master: DNM: test the new python3 version of the release notes job https://review.openstack.org/561046 | 21:03 |
| openstackgerrit | Merged openstack/oslo.privsep master: Skip unit tests in bandit scan https://review.openstack.org/560917 | 21:27 |
| *** openstackstatus has quit IRC | 21:27 | |
| *** openstack has joined #openstack-oslo | 21:28 | |
| *** ChanServ sets mode: +o openstack | 21:28 | |
| *** openstackstatus has joined #openstack-oslo | 21:29 | |
| *** ChanServ sets mode: +v openstackstatus | 21:29 | |
| dtruong | bnemec it doesn't seem possible to add the stop_on_exception parameter without breaking any existing code that uses add_timer. The details are in the review comments: https://review.openstack.org/#/c/561005 | 21:31 |
| dtruong | unless you can think of a better way of adding stop_on_exception parameter, I will abandon my patchset. maybe we can just update the documentation so that the users are aware of the threadgroup timer behavior when an exception occurs. | 21:33 |
| *** lpetrut has quit IRC | 21:35 | |
| *** sambetts|afk has quit IRC | 21:36 | |
| *** sambetts_ has joined #openstack-oslo | 21:38 | |
| dhellmann | dtruong : you could add new methods that have different signatures (and do not include the *args positional argument so we can avoid this in the future) | 21:50 |
| *** ansmith has joined #openstack-oslo | 21:53 | |
| *** bobh has quit IRC | 22:00 | |
| openstackgerrit | Merged openstack/oslo.messaging master: fix lower constraints and uncap eventlet https://review.openstack.org/560587 | 22:00 |
| openstackgerrit | Merged openstack/oslo.versionedobjects master: Add bindep.txt file to prevent fallback to generic list https://review.openstack.org/554589 | 22:09 |
| *** lbragstad has quit IRC | 22:16 | |
| *** salv-orlando has quit IRC | 22:18 | |
| *** salv-orlando has joined #openstack-oslo | 22:19 | |
| *** salv-orlando has quit IRC | 22:23 | |
| *** harlowja has joined #openstack-oslo | 22:24 | |
| *** rcernin has joined #openstack-oslo | 22:30 | |
| dtruong | dhellman: so you mean i should have a new add_timer function with the stop_on_exception parameter added and keep **kwargs. Then the callback function will only accept variable keyword arguments? | 22:35 |
| dtruong | oops, that ^ was meant for dhellmann | 22:37 |
| dhellmann | dtruong : yes, something like that. You'll need to give the new method a new name, and then it will just be a slightly different API to add timers | 22:40 |
| dtruong | ok, thanks for the clarification | 22:45 |
| dtruong | i'll give that a try | 22:45 |
| *** yikun has quit IRC | 22:51 | |
| *** yikun has joined #openstack-oslo | 22:52 | |
| openstackgerrit | Duc Truong proposed openstack/oslo.service master: New TG timer functions with stop_on_exception https://review.openstack.org/561005 | 23:37 |
| -openstackstatus- NOTICE: The Etherpad service at https://etherpad.openstack.org/ is being restarted to pick up the latest release version; browsers should see only a brief ~1min blip before reconnecting automatically to active pads | 23:40 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!