| *** salv-orlando has joined #openstack-oslo | 00:32 | |
| *** salv-orlando has quit IRC | 00:36 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/pycadf master: Updated from global requirements https://review.openstack.org/470137 | 00:40 |
|---|---|---|
| *** kmalloc has quit IRC | 00:53 | |
| *** ihrachys has quit IRC | 01:10 | |
| *** ihrachys has joined #openstack-oslo | 01:10 | |
| *** dave-mccowan has quit IRC | 01:24 | |
| *** salv-orlando has joined #openstack-oslo | 01:32 | |
| *** salv-orlando has quit IRC | 01:38 | |
| *** sdague has quit IRC | 02:17 | |
| *** salv-orlando has joined #openstack-oslo | 02:33 | |
| *** salv-orlando has quit IRC | 02:38 | |
| *** openstack has joined #openstack-oslo | 02:43 | |
| *** ChanServ sets mode: +o openstack | 02:43 | |
| *** links has joined #openstack-oslo | 02:52 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 03:01 | |
| *** AlexeyAbashkin has quit IRC | 03:05 | |
| *** ihrachys has quit IRC | 03:49 | |
| *** aselius has quit IRC | 04:21 | |
| *** nicolasbock has quit IRC | 04:23 | |
| *** lpetrut has joined #openstack-oslo | 04:33 | |
| *** salv-orlando has joined #openstack-oslo | 04:35 | |
| *** salv-orlando has quit IRC | 04:40 | |
| *** yamamoto has joined #openstack-oslo | 04:47 | |
| openstackgerrit | Stephen Finucane proposed openstack-dev/pbr master: Deprecate testr and nose integration https://review.openstack.org/518224 | 04:59 |
| *** lpetrut has quit IRC | 05:23 | |
| *** lpetrut has joined #openstack-oslo | 05:28 | |
| *** salv-orlando has joined #openstack-oslo | 05:36 | |
| *** salv-orlando has quit IRC | 05:40 | |
| *** lpetrut has quit IRC | 05:44 | |
| *** namnh has joined #openstack-oslo | 06:18 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.context master: Don't output auth_token for logging https://review.openstack.org/518244 | 06:31 |
| jaosorior | Tengu: ^^ | 06:31 |
| Tengu | +2 (can't do… so +1 only ;)) | 06:32 |
| jaosorior | haha thanks | 06:32 |
| jaosorior | gonna try to add some tests | 06:32 |
| jaosorior | oh, there were tests already | 06:33 |
| jaosorior | great | 06:33 |
| *** salv-orlando has joined #openstack-oslo | 06:35 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.context master: Don't output auth_token for logging https://review.openstack.org/518244 | 06:36 |
| jaosorior | Tengu: updated ^^ | 06:37 |
| Tengu | :D | 06:37 |
| Tengu | ah, and a release note as well now. cool | 06:37 |
| jaosorior | I need to add one for oslo.log too | 06:38 |
| Tengu | yup. | 06:43 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.log master: Add release note for use_json option https://review.openstack.org/518247 | 06:45 |
| jaosorior | Tengu: ^^ | 06:45 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.log master: Use retrieved context instead of entry in the record's 'extra' https://review.openstack.org/517894 | 06:47 |
| openstackgerrit | xhzhf proposed openstack/oslo.service master: change periodic_task to catch all exceptions including BaseException https://review.openstack.org/518249 | 06:50 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.log master: Add release note for use_json option https://review.openstack.org/518247 | 06:50 |
| jaosorior | dhellmann: thanks for the quick review! | 06:51 |
| Tengu | jaosorior: \o/ | 06:53 |
| Tengu | jaosorior: although I doubt those can be merged in stable/pike? | 06:54 |
| jaosorior | Tengu: I don't think so :/ specially not the auth_token one, since, as dhellmann said, it's sort of an API-breaking change. | 06:55 |
| Tengu | yup. | 06:55 |
| Tengu | a pity we can't just change the content to the actual id, instead of the auth-token header content :( | 06:55 |
| Tengu | jaosorior: hmmm... and what about hasing the auth_token? that way, still OK, but as it's hashed, can't go back. a sha256 for example, in order to avoid easy collisions. | 06:59 |
| Tengu | jaosorior: that way we'll be able to still try to detect session take-over, while avoiding to provide the material to do the take over. | 06:59 |
| Tengu | should have thought about that before you submit the review, sorry. | 07:00 |
| jaosorior | Tengu: that's an option. But what about the performance penalty? | 07:01 |
| Tengu | hashing isn't that heavy compared to the other actions done. | 07:01 |
| Tengu | maybe sha2 is a bit overkill though | 07:02 |
| Tengu | we might even keep md5 - logs aren't supposed to be seen by non-authorized people, right? | 07:02 |
| Tengu | md5 is really fast. | 07:02 |
| jaosorior | uhm, that might be a good idea actually | 07:02 |
| Tengu | although it's a poor hash algo, but might be enough in order to avoid plain stupid leak. | 07:02 |
| Tengu | or sha1 | 07:03 |
| * Tengu doesn't like md5 | 07:03 | |
| jaosorior | lol who does | 07:03 |
| Tengu | but as md5 is still used in order to checksum the images in glance… ;) | 07:03 |
| jaosorior | :( | 07:03 |
| Tengu | balance between speed and actual security. | 07:03 |
| jaosorior | well, with the information we currently have from the context, one could just disable the user whose token has been compromised. | 07:04 |
| Tengu | 1- logs aren't supposed to be accessed by unauthorized ppl 2- hashing will allow to copy-paste logs to some public pastebin 3- md5 is poor, BUT we might want to add some garbage in the original string in order to salt it. | 07:04 |
| Tengu | meaning: md5 might be enough if we just add some salt. that's pretty fast and efficient. | 07:05 |
| Tengu | what do you think? | 07:05 |
| Tengu | although it will be fixed, static salt. | 07:06 |
| Tengu | else we won't be able to follow the auth_token in the logs, of course. | 07:06 |
| jaosorior | Tengu: I'm just thinking, how we would actually use it | 07:06 |
| jaosorior | lets say you suspect that a token has been compromised | 07:07 |
| jaosorior | you look at the logs | 07:07 |
| jaosorior | find the hash | 07:07 |
| Tengu | jaosorior: instead of filtering by user, we might actually want to filter by auth-token, so that we can ensure it's used by the same user all the time | 07:07 |
| jaosorior | that's a good point | 07:07 |
| Tengu | well, best way to ensure nothing is compromised. | 07:08 |
| Tengu | meaning a hashed token is enough. and, as said, md5 might be OK in that use-case, because log access should be reserved to specific power users. | 07:08 |
| Tengu | in addition, that will allow people to debug possible right/policies issues following a token ID instead of a user. | 07:09 |
| jaosorior | I'm sold | 07:09 |
| jaosorior | what do you think is the best way | 07:10 |
| jaosorior | to add always? or to make it configurable? | 07:10 |
| Tengu | best way: configurable | 07:10 |
| Tengu | either set it to md5, or plain (big fat warning) or drop it | 07:10 |
| Tengu | a warning for md5 might as well be issued in the doc, as it's not a good hash algo. | 07:11 |
| Tengu | but, as said: threadof between sec and speed. logs must flow without huge impact on the systems. | 07:11 |
| Tengu | jaosorior: we might want to allow ppl to add static salt for the hash? that way, we MIGHT get a sligtly better security while still using a poor hash algo. | 07:12 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.log master: Add release note for use_json option https://review.openstack.org/518247 | 07:12 |
| jaosorior | Tengu: ok, now the next step is to figure out where to import these algos from | 07:13 |
| jaosorior | Tengu: it has to be a library that's already in the openstack requirements | 07:13 |
| Tengu | from digest import md5 | 07:13 |
| Tengu | it's a standard python lib | 07:13 |
| jaosorior | is it already? | 07:13 |
| jaosorior | oh | 07:14 |
| jaosorior | lol | 07:14 |
| Tengu | and it must be, because glance uses md5 :) | 07:14 |
| jaosorior | thought there was an oslo library for those algos | 07:14 |
| Tengu | ah. hmm. | 07:14 |
| Tengu | don't think so. | 07:14 |
| Tengu | shouldn't be the case for code sake. | 07:14 |
| Tengu | we might want to check in glance. | 07:15 |
| jaosorior | lets do that | 07:15 |
| Tengu | hmmm. | 07:16 |
| Tengu | they use another thing than plain digest. | 07:16 |
| Tengu | https://github.com/openstack/glance/blob/0fb096ffcd7e51e11fccc7c28eddc18fa59185f4/glance/common/utils.py#L36 | 07:16 |
| Tengu | ok, openssl module. | 07:16 |
| Tengu | that's kind of OK in that case because they do other things with crypto module. | 07:16 |
| jaosorior | Tengu: and keystone uses passlib for their hashes | 07:17 |
| Tengu | ah. | 07:17 |
| Tengu | hmm. | 07:17 |
| Tengu | wait | 07:17 |
| Tengu | ok. https://passlib.readthedocs.io/en/stable/lib/passlib.crypto.digest.html | 07:17 |
| Tengu | and in keystone context, it's also good to use passlib due to the pkcs#5 support. | 07:18 |
| Tengu | jaosorior: in oslo case, I think we can stick with the standard digest lib. | 07:18 |
| jaosorior | right | 07:19 |
| jaosorior | Tengu: does it have any py2X/py3X issues? | 07:19 |
| Tengu | ah, sorry, hashlib in fact. | 07:19 |
| Tengu | https://docs.python.org/2/library/hashlib.html#module-hashlib | 07:19 |
| Tengu | you have the usage in there as well. | 07:19 |
| Tengu | jaosorior: well, if we're using md5, I donc think issues will be in hashlib :D | 07:19 |
| *** spectr has quit IRC | 07:22 | |
| Tengu | jaosorior: the good point with the hashing way: that would allow us to backport it in stable/pike without break any API :). | 07:23 |
| * Tengu loves that fact | 07:23 | |
| *** zigo has quit IRC | 07:24 | |
| jaosorior | dhellmann: what do you think? ^^ | 07:26 |
| dhellmann | jaosorior, Tengu : what's the goal here? | 07:27 |
| dhellmann | to avoid showing the auth_token in logs? | 07:27 |
| Tengu | dhellmann: yep | 07:27 |
| dhellmann | is it always showing up? or just with JSON output? | 07:27 |
| Tengu | while still showing something that can be used in order to follow a tken | 07:27 |
| *** zigo has joined #openstack-oslo | 07:28 | |
| jaosorior | dhellmann: just the JSON output as far as I could tell. | 07:29 |
| Tengu | I think the plain output displays an object pointer. | 07:29 |
| jaosorior | dhellmann: it's not showing up at the moment, cause currently it doesn't show any context at all. This patch https://review.openstack.org/#/c/517894/ is needed. | 07:29 |
| jaosorior | Tengu: it doesn't show an object pointer, it shows the actual string for the token. | 07:30 |
| Tengu | jaosorior: in the plain logs? | 07:31 |
| jaosorior | dhellmann: the patch that actually adds the context to the json output depends-on the oslo.context patch, therefore, it won't merge until we have a proper solution. | 07:31 |
| jaosorior | Tengu: yes. | 07:31 |
| jaosorior | dhellmann: there are two options right now. One is the current proposal which removes the auth_token entirely from the output. The second one, which I'm now leaning more towards, is to hash the auth_token, which would allow for b etter log filtering. | 07:32 |
| jaosorior | and to identify the case of a stolen token | 07:32 |
| Tengu | ah, "token" is the name in the log apparently. | 07:33 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.context master: Don't output auth_token for logging https://review.openstack.org/518244 | 07:35 |
| jaosorior | Tengu: what about this? ^^ | 07:35 |
| Tengu | 2s, cleaning up my tabs :D | 07:36 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.context master: Don't output auth_token for logging https://review.openstack.org/518244 | 07:36 |
| jaosorior | Tengu: oh, had a leftover. updated ^^ | 07:36 |
| Tengu | ok so you go for the sha1. should be fast enough while still providing better security than md5. | 07:37 |
| jaosorior | Tengu: yeah, I considered what you said and thought it was a better idea. | 07:37 |
| jaosorior | Tengu: what do you think? | 07:38 |
| Tengu | so by default you set the get_hash_token to False - that will be an API breakage. | 07:38 |
| jaosorior | Tengu: so, you think I should always output the hash? | 07:39 |
| Tengu | on one hand yes for the sake of API stability, on the other hand we might want to get by default a fast enough logging process. | 07:40 |
| jaosorior | haha so you're 50/50 on this | 07:40 |
| Tengu | hard to tell more. | 07:40 |
| Tengu | yep. | 07:40 |
| Tengu | both are valid. | 07:40 |
| jaosorior | dhellmann: what do you suggest? | 07:40 |
| Tengu | might need some third advice. | 07:41 |
| *** hoonetorg has quit IRC | 07:44 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.context master: Don't output auth_token for logging https://review.openstack.org/518244 | 07:44 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.context master: Ouput a null value or a hash instead of the auth_token https://review.openstack.org/518244 | 07:49 |
| jaosorior | Tengu: seems we have utf8 issues. | 07:52 |
| Tengu | where? | 07:53 |
| jaosorior | hashlib requires bytes, not utf8 | 07:54 |
| Tengu | jaosorior: can't be the sha1 output as it's a hexadecimal output, no non-ASCII char in that. | 07:54 |
| Tengu | ah | 07:55 |
| Tengu | hmmm. | 07:55 |
| Tengu | so the header is a u'string' ? | 07:55 |
| jaosorior | and we don't necessarily know what auth_token's format is | 07:55 |
| Tengu | jaosorior: can you test locally the patch? if so, care to print some `type(self.auth_token)' ? | 07:56 |
| *** hoonetorg has joined #openstack-oslo | 07:57 | |
| Tengu | jaosorior: ah, there's some linting issue in the code according to pep8. | 08:01 |
| Tengu | ./oslo_context/context.py:32:1: H306 imports not in alphabetical order (itertools, hashlib) | 08:01 |
| Tengu | h comes before i :D. running tox in order to check what's going on. | 08:02 |
| *** samueldmq has quit IRC | 08:03 | |
| jaosorior | yep, fixed that one now | 08:04 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.context master: Ouput a null value or a hash instead of the auth_token https://review.openstack.org/518244 | 08:04 |
| jaosorior | Tengu: this is what I ahve right now ^^ | 08:04 |
| Tengu | lemme fetch it again then | 08:04 |
| jaosorior | Tengu: missing detecting if auth_token is utf8, and if it is, convert it to bytes | 08:05 |
| *** samueldmq has joined #openstack-oslo | 08:05 | |
| *** pcaruana has joined #openstack-oslo | 08:06 | |
| Tengu | hmm ok. well, unale to run tox due to some issues with requirements. probably missing some dev lib for python :/. | 08:08 |
| Tengu | *unable | 08:08 |
| Tengu | jaosorior: hmm, your latest patch just puts the salt in byte. | 08:08 |
| jaosorior | Tengu: it should also have fixe the import issue | 08:10 |
| Tengu | yup, indeed | 08:10 |
| jaosorior | Tengu: but yeah, setting the salt as bytes works with both python 2 and 3. | 08:10 |
| jaosorior | only thing missing is handling the auth_token | 08:10 |
| Tengu | weird thing: it should be a simple string. | 08:11 |
| *** AlexeyAbashkin has joined #openstack-oslo | 08:12 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.context master: Ouput a null value or a hash instead of the auth_token https://review.openstack.org/518244 | 08:19 |
| jaosorior | Tengu: what about this? ^^ | 08:19 |
| Tengu | 2s | 08:21 |
| Tengu | ah, should be good like that. creating a function would also allow to use that hashed output in other places. | 08:21 |
| Tengu | Might be a non-private one maybe? | 08:22 |
| jaosorior | Tengu: lol, so apparently there was an oslo.utils function | 08:22 |
| Tengu | oh ?? | 08:22 |
| *** tesseract has joined #openstack-oslo | 08:23 | |
| Tengu | jaosorior: which one are you thinking about? | 08:23 |
| jaosorior | Tengu: check the latest comment in the patch | 08:24 |
| Tengu | ah, I just saw that one. | 08:24 |
| Tengu | (the mask_password) | 08:24 |
| Tengu | gni… ?! | 08:25 |
| jaosorior | Tengu: they even have a mask_dict_password | 08:25 |
| Tengu | I don't think this does what we want. | 08:25 |
| Tengu | apparently it replace all passwords with the same string, i.e. "***" by default. | 08:26 |
| Tengu | so nope, this isn't the one we want. | 08:26 |
| jaosorior | it doesn't | 08:26 |
| *** AlexeyAbashkin has quit IRC | 08:27 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 08:27 | |
| Tengu | it searches in string in order to replace, in the strings, the password. | 08:28 |
| Tengu | not really what we want :/ | 08:28 |
| jaosorior | Tengu: you're right. Answered in the review | 08:28 |
| Tengu | just saw that. I was about to tell more or less the same :) | 08:29 |
| jaosorior | if you have a better explanation it would be worth adding it there. | 08:30 |
| *** ralonsoh has joined #openstack-oslo | 08:33 | |
| Tengu | I can do that if you want :) | 08:33 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.context master: Ouput a null value or a hash instead of the auth_token https://review.openstack.org/518244 | 08:34 |
| jaosorior | Tengu: ok, that patch is in a better state now :D ^^ | 08:34 |
| jaosorior | Tengu: now the only thing we need is more opinions on whether we should hash by default or not. | 08:34 |
| Tengu | :) | 08:34 |
| Tengu | I add some more comment on Mehdi proposal. | 08:34 |
| *** e0ne has joined #openstack-oslo | 08:37 | |
| Tengu | jaosorior: if this one passes through the CI without issue, it's pretty call. Just one concern though: how do we set the get_hashed_token and salt? | 08:38 |
| jaosorior | Tengu: we would need to enable those via a configuration optino is oslo.log | 08:39 |
| Tengu | ok | 08:39 |
| Tengu | so some more patching are needed I guess? | 08:39 |
| jaosorior | yes' | 08:39 |
| Tengu | and more CI :D | 08:39 |
| jaosorior | haha indeed | 08:39 |
| *** lpetrut has joined #openstack-oslo | 08:39 | |
| Tengu | o___O speaking about it… my patch apparently goes through the gate a second time (didn't do anything), and its ETA is over 19h | 08:40 |
| jaosorior | Tengu: let me check it out | 08:41 |
| *** lpetrut has quit IRC | 08:44 | |
| *** lpetrut has joined #openstack-oslo | 08:44 | |
| *** salv-orlando has quit IRC | 08:45 | |
| *** salv-orlando has joined #openstack-oslo | 08:46 | |
| *** salv-orlando has quit IRC | 08:51 | |
| *** pooja-jadhav is now known as pooja_jadhav | 08:55 | |
| *** namnh has quit IRC | 08:55 | |
| *** yamamoto has quit IRC | 09:02 | |
| *** yamamoto has joined #openstack-oslo | 09:05 | |
| *** yamamoto has quit IRC | 09:09 | |
| *** lucas-afk is now known as lucasagomes | 09:17 | |
| *** salv-orlando has joined #openstack-oslo | 09:23 | |
| *** yamamoto has joined #openstack-oslo | 09:46 | |
| jaosorior | Tengu: oh, well, seems we have an answer | 09:48 |
| Tengu | hmm? | 09:48 |
| jaosorior | Tengu: check the last comments to the oslo.context patch | 09:49 |
| Tengu | ah, yes, wait, trying to get my cluster back first ^^' | 09:50 |
| Tengu | jaosorior: I'll add some comment for Mehdi. While the None part is correct in fact - you might want to use the mask_password in that context - the hash one is still valid imho. | 09:57 |
| sileht | / | 09:57 |
| *** chhavi has joined #openstack-oslo | 09:57 | |
| chhavi | https://bugs.launchpad.net/cinder/+bug/1692775 | 10:07 |
| openstack | Launchpad bug 1692775 in Cinder "Cinder-backup service reports as down during backup of large volumes" [Undecided,Fix released] - Assigned to Gorka Eguileor (gorka) | 10:07 |
| jaosorior | Tengu: I meant the laaaast | 10:07 |
| chhavi | this issue is still seen in the latest code | 10:07 |
| jaosorior | Tengu: oh wait, hadn't seen that one. | 10:07 |
| *** vipul has quit IRC | 10:09 | |
| chhavi | tommylikehu: https://bugs.launchpad.net/cinder/+bug/1729044 updated the defect with the details | 10:10 |
| openstack | Launchpad bug 1729044 in Cinder "cinder backup not releasing the memory after backup create" [Undecided,New] | 10:11 |
| *** vipul has joined #openstack-oslo | 10:26 | |
| *** yamamoto has quit IRC | 10:27 | |
| *** salv-orlando has quit IRC | 10:27 | |
| *** yamamoto has joined #openstack-oslo | 10:27 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.context master: Ouput a null value or a hash instead of the auth_token https://review.openstack.org/518244 | 10:29 |
| *** vipul has quit IRC | 10:30 | |
| *** yamamoto has quit IRC | 10:33 | |
| *** ianychoi_ has joined #openstack-oslo | 10:33 | |
| Tengu | have to go, jaosorior I'll check that once at home (part-time job: the best one ;)) | 10:34 |
| *** ianychoi has quit IRC | 10:36 | |
| jaosorior | Tengu: haha alright, appreciate the help! | 10:36 |
| *** AlexeyAbashkin has quit IRC | 10:39 | |
| *** vipul has joined #openstack-oslo | 10:40 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 10:43 | |
| *** links has quit IRC | 10:45 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.context master: Ouput a null value or a hash instead of the auth_token https://review.openstack.org/518244 | 10:48 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.context master: Ouput a null value or a hash instead of the auth_token https://review.openstack.org/518244 | 10:51 |
| *** sdague has joined #openstack-oslo | 10:53 | |
| jaosorior | sileht, dhellmann: How is the request-id generated? | 10:54 |
| jaosorior | sileht, dhellmann as far as I've understood, you can use the same token for different requests, and it'll be valid, and it will also have different request-id's | 10:55 |
| *** links has joined #openstack-oslo | 10:57 | |
| sileht | jaosorior, does you patch is for "not leaking auth_token" or "tracking user" ? I'm lost | 10:58 |
| jaosorior | sileht: it's kind of evolving into both | 10:58 |
| sileht | well, a change should implement only one thing | 10:59 |
| sileht | "not leaking auth_token" is easy fix | 10:59 |
| jaosorior | sileht: ok, I'll break up the patch into two. And it'll make discussion easier. | 10:59 |
| sileht | while "tracking user" require wide community discustion | 11:00 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.context master: Ouput a placeholder instead of the auth_token https://review.openstack.org/518244 | 11:05 |
| *** pbourke has quit IRC | 11:07 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.context master: Ouput a placeholder instead of the auth_token https://review.openstack.org/518244 | 11:08 |
| *** pbourke has joined #openstack-oslo | 11:08 | |
| *** yamamoto has joined #openstack-oslo | 11:12 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.context master: Add option to output hashed auth_token https://review.openstack.org/518296 | 11:14 |
| jaosorior | sileht: done. Thanks for the suggestion. | 11:14 |
| *** pblaho has quit IRC | 11:20 | |
| *** salv-orlando has joined #openstack-oslo | 11:27 | |
| *** links has quit IRC | 11:30 | |
| *** yamamoto has quit IRC | 11:31 | |
| *** salv-orlando has quit IRC | 11:32 | |
| *** links has joined #openstack-oslo | 11:43 | |
| *** yamamoto has joined #openstack-oslo | 11:43 | |
| *** raildo has joined #openstack-oslo | 11:55 | |
| Tengu | jaosorior: just added a comment | 11:56 |
| jaosorior | Tengu: I separated the commits to ease the discussion, added you to the other one too | 11:56 |
| Tengu | jaosorior: cool, thanks | 11:58 |
| *** yamamoto has quit IRC | 11:58 | |
| Tengu | jaosorior: I explained the use-case for the "follow the auth_id" :) | 11:58 |
| Tengu | I'll check the other commit(s). | 11:58 |
| jaosorior | Tengu: only two https://review.openstack.org/#/q/topic:dont-leak-auth-token+(status:open+OR+status:merged) | 11:59 |
| Tengu | yup, on them. | 11:59 |
| Tengu | OK, so the original one will only output the "***", this mimics the oslo.utils mask_password() function. | 12:00 |
| Tengu | and you added a new separated commit in order to be able to hash the auth_token if admin wants. seems good for me. | 12:00 |
| jaosorior | right | 12:01 |
| jaosorior | so, no need to add a dependency on oslo.utils | 12:01 |
| jaosorior | since we just needed that one thing | 12:01 |
| Tengu | yup | 12:01 |
| Tengu | jaosorior: just to learn: you have one branch and two commits in it, each one creates a new review right? | 12:02 |
| jaosorior | yes | 12:02 |
| Tengu | cool | 12:02 |
| *** nicolasbock has joined #openstack-oslo | 12:02 | |
| *** lucasagomes is now known as lucas-hungry | 12:04 | |
| *** gcb has joined #openstack-oslo | 12:08 | |
| *** pblaho has joined #openstack-oslo | 12:26 | |
| *** salv-orlando has joined #openstack-oslo | 12:29 | |
| *** salv-orlando has quit IRC | 12:31 | |
| *** ansmith has quit IRC | 12:31 | |
| *** salv-orl_ has joined #openstack-oslo | 12:31 | |
| *** yamamoto has joined #openstack-oslo | 12:34 | |
| *** catintheroof has joined #openstack-oslo | 12:34 | |
| *** links has quit IRC | 12:37 | |
| *** salv-orl_ has quit IRC | 12:40 | |
| *** catintheroof has quit IRC | 12:45 | |
| *** samueldmq has quit IRC | 12:55 | |
| *** samueldmq has joined #openstack-oslo | 12:55 | |
| *** gordc has joined #openstack-oslo | 12:56 | |
| *** catintheroof has joined #openstack-oslo | 12:57 | |
| *** lucas-hungry is now known as lucasagomes | 12:57 | |
| *** pcaruana has quit IRC | 13:22 | |
| *** ansmith has joined #openstack-oslo | 13:42 | |
| *** kgiusti has joined #openstack-oslo | 13:48 | |
| *** yamamoto has quit IRC | 13:56 | |
| *** kgiusti has left #openstack-oslo | 13:58 | |
| *** catintheroof has quit IRC | 14:03 | |
| *** catintheroof has joined #openstack-oslo | 14:10 | |
| *** yamamoto has joined #openstack-oslo | 14:10 | |
| *** gordc has quit IRC | 14:11 | |
| *** gordc has joined #openstack-oslo | 14:15 | |
| *** yamamoto has quit IRC | 14:15 | |
| *** spilla has joined #openstack-oslo | 14:29 | |
| *** pcaruana has joined #openstack-oslo | 14:47 | |
| *** janzian has joined #openstack-oslo | 14:52 | |
| *** spectr has joined #openstack-oslo | 15:01 | |
| *** yamamoto has joined #openstack-oslo | 15:13 | |
| *** gcb has quit IRC | 15:22 | |
| *** yamamoto has quit IRC | 15:26 | |
| *** ansmith has quit IRC | 15:37 | |
| *** AlexeyAbashkin has quit IRC | 15:37 | |
| *** kgiusti has joined #openstack-oslo | 15:38 | |
| *** ansmith has joined #openstack-oslo | 15:49 | |
| *** yamamoto has joined #openstack-oslo | 15:55 | |
| *** spectr has quit IRC | 16:00 | |
| *** ihrachys has joined #openstack-oslo | 16:01 | |
| *** chhavi has quit IRC | 16:03 | |
| *** yamamoto has quit IRC | 16:06 | |
| *** lpetrut_ has joined #openstack-oslo | 16:16 | |
| *** nikhil has joined #openstack-oslo | 16:17 | |
| *** lpetrut has quit IRC | 16:18 | |
| *** salv-orlando has joined #openstack-oslo | 16:20 | |
| *** lpetrut_ has quit IRC | 16:24 | |
| *** ianychoi_ has quit IRC | 16:29 | |
| *** yamamoto has joined #openstack-oslo | 16:35 | |
| *** yamamoto has quit IRC | 16:41 | |
| *** lpetrut has joined #openstack-oslo | 16:51 | |
| *** kmalloc has joined #openstack-oslo | 16:59 | |
| *** e0ne has quit IRC | 17:16 | |
| *** lucasagomes is now known as lucas-afk | 17:18 | |
| *** lpetrut has quit IRC | 17:25 | |
| *** tesseract has quit IRC | 17:30 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 17:31 | |
| *** ralonsoh has quit IRC | 17:33 | |
| *** AlexeyAbashkin has quit IRC | 17:36 | |
| *** tesseract has joined #openstack-oslo | 17:40 | |
| *** spilla has quit IRC | 17:43 | |
| *** tesseract has quit IRC | 17:49 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 18:00 | |
| *** AlexeyAbashkin has quit IRC | 18:04 | |
| jaosorior | bnemec: hey, could you check these out https://review.openstack.org/518244 ? | 18:13 |
| *** nikhil has quit IRC | 18:26 | |
| *** aselius has joined #openstack-oslo | 18:27 | |
| *** e0ne has joined #openstack-oslo | 18:33 | |
| *** spilla has joined #openstack-oslo | 18:51 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 18:59 | |
| *** d0ugal has quit IRC | 19:01 | |
| *** e0ne has quit IRC | 19:03 | |
| *** AlexeyAbashkin has quit IRC | 19:03 | |
| *** dave-mccowan has joined #openstack-oslo | 19:18 | |
| *** dave-mcc_ has joined #openstack-oslo | 19:22 | |
| *** Guest71388 has quit IRC | 19:23 | |
| *** dave-mccowan has quit IRC | 19:24 | |
| *** dansmith has joined #openstack-oslo | 19:24 | |
| *** dansmith is now known as Guest98706 | 19:24 | |
| *** Aramis has joined #openstack-oslo | 19:45 | |
| *** eck` is now known as eck`gone | 19:54 | |
| *** e0ne has joined #openstack-oslo | 19:54 | |
| *** eck`gone is now known as eck` | 19:54 | |
| *** kmalloc has quit IRC | 19:59 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 20:00 | |
| *** AlexeyAbashkin has quit IRC | 20:04 | |
| *** e0ne has quit IRC | 20:09 | |
| *** e0ne has joined #openstack-oslo | 20:09 | |
| *** catintheroof has quit IRC | 20:15 | |
| *** e0ne has quit IRC | 20:27 | |
| *** catintheroof has joined #openstack-oslo | 20:46 | |
| *** catintheroof has quit IRC | 20:51 | |
| *** ansmith_ has joined #openstack-oslo | 20:52 | |
| *** harlowja has quit IRC | 20:52 | |
| *** ansmith_ has quit IRC | 20:52 | |
| openstackgerrit | Merged openstack/oslo.context master: Ouput a placeholder instead of the auth_token https://review.openstack.org/518244 | 20:54 |
| *** catintheroof has joined #openstack-oslo | 20:58 | |
| *** catintheroof has quit IRC | 21:02 | |
| *** raildo has quit IRC | 21:10 | |
| *** catintheroof has joined #openstack-oslo | 21:11 | |
| *** catintheroof has quit IRC | 21:15 | |
| *** dave-mcc_ has quit IRC | 21:23 | |
| *** kgiusti has left #openstack-oslo | 21:30 | |
| *** ansmith has quit IRC | 21:37 | |
| openstackgerrit | Ondřej Nový proposed openstack/taskflow master: Make the build reproducible https://review.openstack.org/518397 | 21:52 |
| *** dave-mccowan has joined #openstack-oslo | 21:55 | |
| *** Guest98706 is now known as dansmith | 21:57 | |
| *** chhavi has joined #openstack-oslo | 22:00 | |
| *** chhavi has quit IRC | 22:04 | |
| *** kmalloc has joined #openstack-oslo | 22:04 | |
| *** eck` is now known as eck`gone | 22:13 | |
| *** dave-mccowan has quit IRC | 22:19 | |
| *** ansmith has joined #openstack-oslo | 22:31 | |
| *** spilla has quit IRC | 22:37 | |
| *** harlowja has joined #openstack-oslo | 22:46 | |
| *** gordc has quit IRC | 22:56 | |
| *** salv-orlando has quit IRC | 22:59 | |
| *** salv-orlando has joined #openstack-oslo | 23:00 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 23:00 | |
| *** salv-orlando has quit IRC | 23:04 | |
| *** AlexeyAbashkin has quit IRC | 23:04 | |
| *** prad has joined #openstack-oslo | 23:10 | |
| *** prad has quit IRC | 23:21 | |
| *** d0ugal has joined #openstack-oslo | 23:39 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!