*** catintheroof has joined #openstack-oslo | 00:19 | |
*** catintheroof has quit IRC | 01:37 | |
*** catintheroof has joined #openstack-oslo | 01:38 | |
*** yamamoto has joined #openstack-oslo | 01:54 | |
*** catintheroof has quit IRC | 01:57 | |
*** zhouyaguo has joined #openstack-oslo | 02:25 | |
openstackgerrit | Merged openstack/oslo.db master: Add new foreign key utility function to utils https://review.openstack.org/492241 | 02:54 |
---|---|---|
openstackgerrit | Rajath Agasthya proposed openstack/oslo.messaging master: Fix default value of RPC dispatcher access_policy https://review.openstack.org/500456 | 03:25 |
*** chhavi has joined #openstack-oslo | 04:05 | |
*** Dinesh_Bhor has joined #openstack-oslo | 04:14 | |
*** links has joined #openstack-oslo | 04:25 | |
*** yamamoto_ has joined #openstack-oslo | 06:36 | |
*** yamamoto has quit IRC | 06:36 | |
*** rcernin has joined #openstack-oslo | 06:41 | |
*** pcaruana has joined #openstack-oslo | 07:06 | |
*** yamamoto_ has quit IRC | 07:14 | |
*** yamamoto has joined #openstack-oslo | 07:16 | |
*** tesseract has joined #openstack-oslo | 07:23 | |
*** chhavi has quit IRC | 07:28 | |
*** yamamoto_ has joined #openstack-oslo | 07:33 | |
*** yamamoto has quit IRC | 07:36 | |
*** yamamoto_ has quit IRC | 07:41 | |
*** ralonsoh has joined #openstack-oslo | 07:46 | |
*** shardy has joined #openstack-oslo | 07:55 | |
*** yamamoto has joined #openstack-oslo | 08:10 | |
*** e0ne has joined #openstack-oslo | 08:25 | |
*** mikal_ has joined #openstack-oslo | 08:30 | |
*** mikal has quit IRC | 08:32 | |
*** yamamoto has quit IRC | 08:32 | |
*** finucannot is now known as stephenfin | 08:47 | |
*** lpetrut has joined #openstack-oslo | 09:20 | |
*** pbourke has quit IRC | 09:22 | |
*** pbourke has joined #openstack-oslo | 09:23 | |
*** jaosorior has joined #openstack-oslo | 09:28 | |
*** yamamoto has joined #openstack-oslo | 09:40 | |
*** chhavi has joined #openstack-oslo | 09:43 | |
*** yamamoto has quit IRC | 10:00 | |
*** nicolasbock has joined #openstack-oslo | 10:02 | |
*** nicolasbock has quit IRC | 10:12 | |
*** nicolasbock has joined #openstack-oslo | 10:24 | |
*** gcb has joined #openstack-oslo | 10:33 | |
*** zhouyaguo has quit IRC | 10:40 | |
*** zhouyaguo has joined #openstack-oslo | 10:40 | |
*** pblaho has joined #openstack-oslo | 10:51 | |
*** gcb has quit IRC | 10:53 | |
*** sdague has joined #openstack-oslo | 10:59 | |
*** ps_jadhav has joined #openstack-oslo | 11:04 | |
*** pooja_jadhav has quit IRC | 11:07 | |
*** clayton has quit IRC | 11:25 | |
*** clayton has joined #openstack-oslo | 11:30 | |
*** yamamoto has joined #openstack-oslo | 11:30 | |
*** raildo has joined #openstack-oslo | 11:37 | |
*** pblaho has quit IRC | 11:44 | |
*** ps_jadhav is now known as pooja_jadhav | 11:45 | |
dims | dhellmann : good morning. is https://review.openstack.org/#/c/491783/ ok now? | 11:53 |
*** yamamoto has quit IRC | 12:00 | |
*** eck`gone is now known as eck` | 12:02 | |
*** pblaho has joined #openstack-oslo | 12:08 | |
*** MVenesio has joined #openstack-oslo | 12:11 | |
*** sambetts|afk is now known as sambetts | 12:13 | |
*** yamamoto has joined #openstack-oslo | 12:18 | |
*** yamamoto has quit IRC | 12:33 | |
*** ansmith has joined #openstack-oslo | 12:34 | |
*** boden has joined #openstack-oslo | 12:36 | |
*** gordc has joined #openstack-oslo | 12:40 | |
openstackgerrit | melissaml proposed openstack/oslo.utils master: Cleanup test-requirements https://review.openstack.org/507082 | 12:44 |
openstackgerrit | melissaml proposed openstack/oslo.log master: Cleanup test-requirements https://review.openstack.org/507084 | 12:46 |
openstackgerrit | melissaml proposed openstack/oslo.config master: Cleanup test-requirements https://review.openstack.org/507086 | 12:48 |
openstackgerrit | melissaml proposed openstack/oslo.rootwrap master: Cleanup test-requirements https://review.openstack.org/507088 | 12:50 |
openstackgerrit | melissaml proposed openstack/oslo.vmware master: Cleanup test-requirements https://review.openstack.org/507089 | 12:50 |
*** yamamoto has joined #openstack-oslo | 12:52 | |
*** janzian has joined #openstack-oslo | 12:52 | |
*** kgiusti has joined #openstack-oslo | 12:59 | |
*** gcb has joined #openstack-oslo | 13:10 | |
*** links has quit IRC | 13:23 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.policy master: External Policy hook should support SSL https://review.openstack.org/491783 | 13:25 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.policy master: [WIP] Make http/https check rules as stevedore extensions https://review.openstack.org/507098 | 13:25 |
*** lbragstad has joined #openstack-oslo | 13:28 | |
*** dave-mccowan has joined #openstack-oslo | 13:41 | |
openstackgerrit | Dirk Mueller proposed openstack/oslo.db master: Drop MySQL-python dependency from oslo.db https://review.openstack.org/505835 | 13:45 |
*** chhavi has quit IRC | 13:46 | |
*** zxy has joined #openstack-oslo | 13:49 | |
*** zxy has quit IRC | 13:49 | |
*** zxy has joined #openstack-oslo | 13:50 | |
openstackgerrit | Thomas Bechtold proposed openstack/stevedore master: Remove duplicate optional requirement https://review.openstack.org/507108 | 13:51 |
openstackgerrit | Thomas Bechtold proposed openstack/stevedore master: Move reno to optional docs requirements https://review.openstack.org/507109 | 13:52 |
gcb | weekly meeting in 3 minutes at #openstack-meeting-3 | 13:57 |
*** beekneemech is now known as bnemec | 14:02 | |
*** superdan is now known as dansmith | 14:02 | |
*** haypo has joined #openstack-oslo | 14:09 | |
haypo | dhellmann, gcb : would you mind to look again to my JSON to_primitive() minor enhancement? https://review.openstack.org/#/c/503993/ it doesn't change the default behaviour, it only adds a small parameter to fix oslo.log JSON Formatter | 14:11 |
dhellmann | haypo : we're in the meeting in #openstack-meeting-3, want to join us and mention it there? | 14:11 |
haypo | dhellmann: i joined the channel | 14:12 |
openstackgerrit | Victor Stinner proposed openstack/oslo.log master: JSONFormatter convert unserializable with repr() https://review.openstack.org/504004 | 14:20 |
openstackgerrit | Victor Stinner proposed openstack/oslo.serialization master: jsonutils.to_primitive(): add fallback parameter https://review.openstack.org/503993 | 14:22 |
*** thomas__ has joined #openstack-oslo | 14:41 | |
thomas__ | ping dhellmann :) | 14:41 |
dhellmann | hi, thomas__ | 14:42 |
dhellmann | squashing those 2 commits together isn't complicated, but if a problem comes up I thought it would be better to be here to talk about it | 14:42 |
dhellmann | to start, you'll want to make sure you have the latest version of the master branch of oslo.policy. something like: | 14:43 |
dhellmann | git checkout master && git pull | 14:43 |
dhellmann | then you want to check out a copy of my patch with : git review -d 506785 | 14:43 |
dhellmann | that should create a branch with a name starting with "review" | 14:44 |
dhellmann | the branch will include my patch as the most recent patch, and your patch as its parent | 14:44 |
thomas__ | how do you obtain that number 506785 ? | 14:44 |
dhellmann | that is the review number, from the URL for my patch | 14:44 |
dhellmann | https://review.openstack.org/#/c/506785/ | 14:45 |
thomas__ | OK | 14:45 |
dhellmann | after you have that branch, you rebase it on master with "git rebase -i master" | 14:45 |
dhellmann | that should open your editor, and list both patches | 14:45 |
dhellmann | change the "pick" instruction to "s" for squash, save the buffer, and quit your editor | 14:45 |
*** takedakn has joined #openstack-oslo | 14:46 | |
dhellmann | git should then ask you to modify the commit message in your editor and it should fill in the buffer with both of the existing messages | 14:46 |
dhellmann | make sure you save the Change-Id line from *your* patch and *remove* the one from my patch | 14:46 |
dhellmann | then update the rest of the text of the message, save, and exit | 14:47 |
dhellmann | then resubmit the patch with "git review" like you normally would | 14:47 |
dhellmann | when you've done that, I will abandon my patch | 14:47 |
*** ihrachys has joined #openstack-oslo | 14:48 | |
thomas__ | when I write "s" and quit my editor, it says "Cannot 'squash' without a previous commit" | 14:48 |
dhellmann | leave "pick" on your patch and change it to "s" on my patch | 14:49 |
dhellmann | sorry, I wasn't clear | 14:49 |
openstackgerrit | Merged openstack-dev/cookiecutter master: Switch to use stestr as the default test runner https://review.openstack.org/505772 | 14:51 |
dhellmann | thomas__ : I need to step away for a minute, but I will be right back. | 14:53 |
*** gcb has quit IRC | 14:55 | |
dhellmann | back | 14:57 |
thomas__ | dhellmann: in my editor I have to write something like this ? | 15:01 |
thomas__ | pick 0a11ae8 make it easier to reuse the invocation logic for check objects \nsquash | 15:01 |
dhellmann | this might be easier if we share screens so I can see what you're seeing -- I may have summarized what happens too much | 15:02 |
dhellmann | let me set up a thing for that, I will give you a URL in a minute | 15:02 |
*** zxy has quit IRC | 15:03 | |
*** links has joined #openstack-oslo | 15:08 | |
openstackgerrit | Merged openstack/oslo.context master: Rename deprecated context params https://review.openstack.org/498305 | 15:11 |
*** links has quit IRC | 15:17 | |
*** rajathagasthya has joined #openstack-oslo | 15:17 | |
openstackgerrit | Merged openstack/oslo.middleware master: Remove method set_latent https://review.openstack.org/453723 | 15:21 |
*** e0ne has quit IRC | 15:23 | |
*** links has joined #openstack-oslo | 15:29 | |
*** takedakn has quit IRC | 15:32 | |
*** pcaruana has quit IRC | 15:33 | |
openstackgerrit | Thomas Duval proposed openstack/oslo.policy master: Modification to add additional information in the HTTPCheck request. https://review.openstack.org/498467 | 15:33 |
openstackgerrit | Stephen Finucane proposed openstack-dev/pbr master: builddoc: Use '[sphinx_build] builders' with Sphinx < 1.6 https://review.openstack.org/481620 | 15:33 |
openstackgerrit | Stephen Finucane proposed openstack-dev/pbr master: Deprecate support for Sphinx < 1.6 https://review.openstack.org/481621 | 15:34 |
*** pcaruana has joined #openstack-oslo | 15:34 | |
*** thomas__ has quit IRC | 15:36 | |
*** aselius has joined #openstack-oslo | 15:44 | |
*** rajathagasthya has quit IRC | 15:45 | |
*** rcernin has quit IRC | 15:48 | |
*** pooja_jadhav has quit IRC | 16:03 | |
*** rajathagasthya has joined #openstack-oslo | 16:07 | |
*** Dinesh_Bhor has quit IRC | 16:07 | |
*** links has quit IRC | 16:10 | |
openstackgerrit | Merged openstack/oslo.messaging master: Fix wrong transport warnings in functional tests https://review.openstack.org/506813 | 16:13 |
*** pcaruana has quit IRC | 16:15 | |
openstackgerrit | Merged openstack/stevedore master: Remove duplicate optional requirement https://review.openstack.org/507108 | 16:16 |
*** lpetrut has quit IRC | 16:16 | |
*** chhavi has joined #openstack-oslo | 16:29 | |
*** ralonsoh has quit IRC | 16:33 | |
openstackgerrit | Merged openstack/stevedore master: Move reno to optional docs requirements https://review.openstack.org/507109 | 16:38 |
chhavi | harlowja: have a query on taskflow, is there a way to discard the retry of the mainflow if there is a specific exception in one of the flow, rever method only handles the subflow, and still perform retries. The control does not comes to on_falure. Is there anything specific which needs to be taken care to handle this scenario. | 16:41 |
*** chhavi has quit IRC | 16:42 | |
*** pblaho has quit IRC | 16:42 | |
*** chhavi has joined #openstack-oslo | 16:43 | |
*** chhavi has quit IRC | 16:43 | |
*** lpetrut has joined #openstack-oslo | 17:00 | |
*** harlowja has joined #openstack-oslo | 17:20 | |
*** kgiusti has quit IRC | 17:27 | |
*** kgiusti has joined #openstack-oslo | 17:30 | |
*** tesseract has quit IRC | 17:53 | |
*** ihrachys has quit IRC | 17:57 | |
*** ihrachys has joined #openstack-oslo | 17:57 | |
*** sambetts is now known as sambetts|afk | 18:07 | |
openstackgerrit | Doug Hellmann proposed openstack/oslo.policy master: Modification to add additional information in the HTTPCheck request. https://review.openstack.org/498467 | 18:09 |
*** rcernin has joined #openstack-oslo | 18:11 | |
*** lpetrut has quit IRC | 18:11 | |
*** kgiusti has quit IRC | 18:14 | |
*** pblaho has joined #openstack-oslo | 18:32 | |
*** kgiusti has joined #openstack-oslo | 18:33 | |
*** eck` has quit IRC | 18:34 | |
*** raildo has quit IRC | 18:34 | |
*** eck` has joined #openstack-oslo | 18:37 | |
*** raildo has joined #openstack-oslo | 18:42 | |
openstackgerrit | Doug Hellmann proposed openstack/oslo.serialization master: add more tests for serializing unserializable objects https://review.openstack.org/507233 | 18:45 |
*** dave-mccowan has quit IRC | 18:56 | |
*** lpetrut has joined #openstack-oslo | 19:09 | |
*** e0ne has joined #openstack-oslo | 19:12 | |
*** lpetrut has quit IRC | 19:14 | |
*** lifeless has quit IRC | 19:14 | |
*** lifeless has joined #openstack-oslo | 19:15 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.policy master: External Policy hook should support SSL https://review.openstack.org/491783 | 19:22 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.policy master: [WIP] Make http/https check rules as stevedore extensions https://review.openstack.org/507098 | 19:22 |
*** e0ne has quit IRC | 19:22 | |
*** dave-mccowan has joined #openstack-oslo | 19:24 | |
dhellmann | dims : what's ^^ for? | 19:28 |
dims | dhellmann : i was trying to see if we could let folks add their own rule checks like we added the HttpsCheck | 19:29 |
dims | experiment | 19:30 |
dhellmann | dims : deployers? because apps can already do that | 19:30 |
dhellmann | but yeah, I like the idea | 19:30 |
*** dave-mccowan has quit IRC | 19:32 | |
*** dave-mccowan has joined #openstack-oslo | 19:33 | |
dims | thanks! i mean someone writes a new rule check, publishes a library and deployers can just use that new check | 19:35 |
dims | dhellmann : i have a funny error in the docs run for https://review.openstack.org/#/c/491783/ will ping you when i see the CI go red or warning shows up | 19:36 |
dhellmann | dims : ok. it works for me locally using "tox -e docs" on a checkout of your patch | 19:37 |
dims | dhellmann : ah i forgot to switch warning-is-error=1 back on before updating | 19:38 |
dims | can you please try with that? (setup.cfg) | 19:39 |
dhellmann | the setup.cfg I have shows warning-is-error=1 | 19:40 |
dhellmann | oh, wait, I may be looking at the wrong patch | 19:40 |
dhellmann | hmm, no, it's 491783 | 19:41 |
dims | sorry i i pasted the wrong one. https://review.openstack.org/#/c/507098/2/setup.cfg | 19:43 |
dhellmann | ok, trying that one | 19:43 |
dims | here's what i see with warning-as-error set to 0 - http://paste.openstack.org/show/621865/ | 19:44 |
dhellmann | dims : running sphinx-build directly gives me the traceback | 19:45 |
dhellmann | looking at _checks I see it calling _init_extensions() on import; which imports external; which imports _checks -- cycle | 19:45 |
dhellmann | since _init_extensions() is being run before the rest of the _checks module is initialized, external can't find what it needs | 19:46 |
dhellmann | try moving the extension registration stuff into the enforcer class? | 19:46 |
dhellmann | i.e., do it at runtime | 19:46 |
dhellmann | that makes it easier to deal with mocking for tests anyway | 19:47 |
dims | ack will try that | 19:47 |
dims | thanks dhellmann | 19:47 |
*** jdandrea_ has joined #openstack-oslo | 19:49 | |
*** e0ne has joined #openstack-oslo | 19:55 | |
*** prometheanfire has joined #openstack-oslo | 20:00 | |
prometheanfire | has anyone looked into updating versionedobjects for the new iso8601? https://bugs.launchpad.net/cinder/+bug/1715486 | 20:01 |
openstack | Launchpad bug 1715486 in oslo.versionedobjects "py35 tests failing due to iso8601 module change" [Undecided,In progress] - Assigned to zhangyangyang (zhangyangyang) | 20:01 |
*** raildo has quit IRC | 20:03 | |
*** rcernin has quit IRC | 20:11 | |
*** eck` has quit IRC | 20:14 | |
*** eck`gone has joined #openstack-oslo | 20:17 | |
*** eck`gone is now known as eck` | 20:17 | |
*** e0ne has quit IRC | 20:18 | |
openstackgerrit | Victor Stinner proposed openstack/oslo.serialization master: jsonutils.to_primitive(): add fallback parameter https://review.openstack.org/503993 | 20:23 |
*** kgiusti has left #openstack-oslo | 20:29 | |
*** nicolasbock has quit IRC | 20:35 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.policy master: [WIP] Make http/https check rules as stevedore extensions https://review.openstack.org/507098 | 20:39 |
*** ansmith has quit IRC | 20:50 | |
-openstackstatus- NOTICE: The infra team is bringing Zuul v3 online; expect service disruptions and please see https://docs.openstack.org/infra/manual/zuulv3.html for more information. | 20:50 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.policy master: External Policy hook should support SSL https://review.openstack.org/491783 | 21:26 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.policy master: [WIP] Make http/https check rules as stevedore extensions https://review.openstack.org/507098 | 21:26 |
*** jdandrea_ has quit IRC | 21:28 | |
*** MVenesio has quit IRC | 21:37 | |
*** MVenesio has joined #openstack-oslo | 21:37 | |
*** MVenesio has quit IRC | 21:41 | |
*** dave-mccowan has quit IRC | 21:43 | |
*** shardy has quit IRC | 21:47 | |
*** janzian has quit IRC | 21:50 | |
*** john51 has joined #openstack-oslo | 21:59 | |
*** john51_ has quit IRC | 22:01 | |
*** gordc has quit IRC | 22:17 | |
*** sai has quit IRC | 22:25 | |
*** sai has joined #openstack-oslo | 22:25 | |
*** dave-mccowan has joined #openstack-oslo | 22:44 | |
*** dave-mcc_ has joined #openstack-oslo | 23:05 | |
*** dave-mccowan has quit IRC | 23:07 | |
*** ansmith has joined #openstack-oslo | 23:13 | |
*** sdague has quit IRC | 23:39 | |
*** rajathagasthya has quit IRC | 23:46 | |
openstackgerrit | Merged openstack/oslo.versionedobjects master: Add a TimestampedObject mixin https://review.openstack.org/495913 | 23:47 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!