| *** rajathagasthya has quit IRC | 00:12 | |
| *** yamamoto_ has joined #openstack-oslo | 00:13 | |
| *** yamamoto_ has quit IRC | 00:13 | |
| openstackgerrit | Merged openstack/oslo.messaging master: Ensure RPC endpoint target attribute is correct https://review.openstack.org/491851 | 00:13 |
|---|---|---|
| *** ragasthya has quit IRC | 00:14 | |
| *** rajathagasthya has joined #openstack-oslo | 00:52 | |
| *** ragasthya has joined #openstack-oslo | 00:55 | |
| *** rajathagasthya has quit IRC | 00:56 | |
| *** yamamoto_ has joined #openstack-oslo | 01:14 | |
| *** yamamoto_ has quit IRC | 01:20 | |
| *** aselius has quit IRC | 01:37 | |
| *** spzala has quit IRC | 01:50 | |
| *** yamamoto_ has joined #openstack-oslo | 02:16 | |
| *** yamamoto_ has quit IRC | 02:22 | |
| *** ragasthya has quit IRC | 02:31 | |
| *** dave-mccowan has quit IRC | 02:32 | |
| *** yamamoto has joined #openstack-oslo | 02:49 | |
| *** gcb has joined #openstack-oslo | 02:50 | |
| *** yamamoto has quit IRC | 03:12 | |
| *** rajathagasthya has joined #openstack-oslo | 03:55 | |
| *** links has joined #openstack-oslo | 04:03 | |
| *** hoonetorg has quit IRC | 04:11 | |
| *** yamamoto has joined #openstack-oslo | 04:13 | |
| *** yamamoto has quit IRC | 04:19 | |
| *** hoonetorg has joined #openstack-oslo | 04:23 | |
| *** lpetrut has joined #openstack-oslo | 04:26 | |
| *** rajathagasthya has quit IRC | 04:47 | |
| *** lpetrut has quit IRC | 04:56 | |
| *** kornicameister has quit IRC | 05:03 | |
| *** pbourke has quit IRC | 05:10 | |
| *** pbourke has joined #openstack-oslo | 05:12 | |
| *** yamamoto has joined #openstack-oslo | 05:15 | |
| openstackgerrit | Merged openstack/osprofiler master: Make dependency on oslo.messaging runtime only https://review.openstack.org/492154 | 05:21 |
| *** yamamoto has quit IRC | 05:21 | |
| *** yamamoto has joined #openstack-oslo | 06:13 | |
| *** yamamoto has quit IRC | 06:38 | |
| *** yamamoto has joined #openstack-oslo | 06:39 | |
| *** yamamoto has quit IRC | 06:39 | |
| *** pcaruana has joined #openstack-oslo | 06:39 | |
| *** rcernin has joined #openstack-oslo | 07:10 | |
| *** tesseract has joined #openstack-oslo | 07:25 | |
| *** Kimamisa has joined #openstack-oslo | 07:30 | |
| *** yamamoto has joined #openstack-oslo | 07:40 | |
| *** yamamoto has quit IRC | 07:45 | |
| *** ralonsoh has joined #openstack-oslo | 07:50 | |
| openstackgerrit | Ilya Shakhat proposed openstack/osprofiler master: Remove dependency on oslo.log library https://review.openstack.org/498507 | 08:23 |
| *** yamamoto has joined #openstack-oslo | 08:42 | |
| *** yamamoto has quit IRC | 08:47 | |
| *** lucas-afk is now known as lucasagomes | 08:59 | |
| *** Adri2000 has joined #openstack-oslo | 09:27 | |
| Adri2000 | hello | 09:27 |
| Adri2000 | I've got a question regarding the [oslo_middleware] enable_proxy_headers_parsing option | 09:28 |
| Adri2000 | does it hurt to enable it even if the service is *not* behind a reverse proxy? | 09:28 |
| Adri2000 | if it doesn't hurt, why isn't it enabled by default? | 09:29 |
| *** sambetts|afk is now known as sambetts | 09:36 | |
| *** yamamoto has joined #openstack-oslo | 09:43 | |
| *** yamamoto has quit IRC | 09:49 | |
| *** sdague has joined #openstack-oslo | 09:54 | |
| Adri2000 | looks like the explanation: https://git.openstack.org/cgit/openstack/oslo.middleware/commit/oslo_middleware/http_proxy_to_wsgi.py?id=f62c3a74c07238d91efb17e9ac64373f08894490 | 09:55 |
| Adri2000 | jaosorior: hello, regarding ^ could you explain the potential security problems of having enable_proxy_headers_parsing enabled when not behind a reverseproxy? I'm not sure I get it | 09:56 |
| openstackgerrit | Sami Makki proposed openstack/oslo.policy master: Add JSON output option to sample generator https://review.openstack.org/491629 | 10:02 |
| *** rook is now known as rook|pto | 10:06 | |
| *** boden has joined #openstack-oslo | 10:24 | |
| *** lpetrut has joined #openstack-oslo | 10:34 | |
| *** lpetrut_ has joined #openstack-oslo | 10:34 | |
| *** pbourke has quit IRC | 10:35 | |
| *** pbourke has joined #openstack-oslo | 10:37 | |
| *** pbourke has quit IRC | 10:39 | |
| *** yamamoto has joined #openstack-oslo | 10:45 | |
| *** zxy has quit IRC | 10:47 | |
| *** zxy has joined #openstack-oslo | 10:48 | |
| *** yamamoto has quit IRC | 10:51 | |
| *** e0ne has joined #openstack-oslo | 10:52 | |
| *** e0ne has quit IRC | 10:56 | |
| *** e0ne has joined #openstack-oslo | 10:57 | |
| *** ansmith has quit IRC | 11:06 | |
| *** e0ne has quit IRC | 11:14 | |
| *** pbourke has joined #openstack-oslo | 11:20 | |
| *** raildo has joined #openstack-oslo | 11:25 | |
| *** e0ne has joined #openstack-oslo | 11:26 | |
| *** eck` is now known as eck`gone | 11:31 | |
| *** yamamoto has joined #openstack-oslo | 11:47 | |
| *** chhavi has joined #openstack-oslo | 11:48 | |
| chhavi | harlowja: I am trying to use taskflows, have couple of queries for the same | 11:49 |
| *** yamamoto has quit IRC | 11:52 | |
| *** lucasagomes is now known as lucas-hungry | 11:58 | |
| *** rmascena has joined #openstack-oslo | 12:00 | |
| *** raildo has quit IRC | 12:03 | |
| *** dave-mccowan has joined #openstack-oslo | 12:05 | |
| *** MVenesio has joined #openstack-oslo | 12:20 | |
| *** MVenesio has quit IRC | 12:20 | |
| openstackgerrit | Pooja Jadhav proposed openstack/oslo.utils master: Check for valid uuid length https://review.openstack.org/498786 | 12:25 |
| *** gcb has quit IRC | 12:29 | |
| *** gcb has joined #openstack-oslo | 12:30 | |
| *** eck`gone is now known as eck` | 12:43 | |
| *** yamamoto has joined #openstack-oslo | 12:49 | |
| *** ansmith has joined #openstack-oslo | 12:52 | |
| *** janzian has joined #openstack-oslo | 12:53 | |
| *** yamamoto has quit IRC | 12:54 | |
| *** lucas-hungry is now known as lucasagomes | 13:01 | |
| *** pblaho has quit IRC | 13:02 | |
| *** hoonetorg has quit IRC | 13:08 | |
| *** hoonetorg has joined #openstack-oslo | 13:09 | |
| *** kgiusti has joined #openstack-oslo | 13:13 | |
| *** gordc has joined #openstack-oslo | 13:15 | |
| *** eck` is now known as eck`gone | 13:16 | |
| *** ihrachys has joined #openstack-oslo | 13:18 | |
| *** links has quit IRC | 13:18 | |
| *** eck`gone is now known as eck` | 13:19 | |
| *** dave-mccowan has quit IRC | 13:19 | |
| *** lucasagomes is now known as lucas-brb | 13:26 | |
| Adri2000 | so https://bugs.launchpad.net/oslo.middleware/+bug/1590635 is related to what I said earlier | 13:28 |
| openstack | Launchpad bug 1590635 in oslo.middleware "http_proxy_to_wsgi middleware shouldn't be disabled by default " [Undecided,New] | 13:28 |
| Adri2000 | jaosorior: ^; or dims ^ as you +1'ed the initial change | 13:32 |
| jaosorior | Adri2000: it's been a while, but you can potentially pass anything in the proxy headers; could be a very cleverly crafted string, on which there's barely any verification for on the OpenStack services side. So, ideally, these headers should only be set by the proxy (such as HAProxy) | 13:36 |
| jaosorior | and if there's no need for it, then it should be disabled. | 13:36 |
| openstackgerrit | WuKong proposed openstack/oslo-specs master: external pdp hood for oslo.policy https://review.openstack.org/492543 | 13:38 |
| jaosorior | Adri2000: but yeah, if MOST deployments use a loadbalancer (which is probably true), then I guess it could actually default to true. | 13:40 |
| Adri2000 | jaosorior: I understand that with http_proxy_to_wsgi enabled, the middleware will parse those headers and take action if they are present; if they are not present, the middleware should do nothing? | 13:40 |
| Adri2000 | so I fail to see the added security risk :/ | 13:40 |
| *** dave-mccowan has joined #openstack-oslo | 13:41 | |
| jaosorior | Adri2000: right, but anybody could put any sort of crap into those headers. Which should ideally not be the case when you're behind a loadbalancer, since the loadbalancer would overwrite any setting coming from the client. | 13:41 |
| Adri2000 | ah in that sense I see | 13:41 |
| Adri2000 | so you are being careful in case the parsing function in oslo.middleware has some vulnerabilities, right? | 13:42 |
| jaosorior | of course, depends if you configured the endpoint correctly | 13:42 |
| jaosorior | that won't help if you let those headers through in the haproxy config | 13:43 |
| jaosorior | Adri2000: right | 13:43 |
| Adri2000 | that's a good point, but that should be balanced with the fact that most/all production deployments use a reverse proxy in front of the APIs | 13:44 |
| Adri2000 | I can probably comment in the bug report, it'd be nice to have other opinions as well | 13:44 |
| Adri2000 | thanks for the clarification anyway! | 13:48 |
| *** yamamoto has joined #openstack-oslo | 13:50 | |
| Adri2000 | https://bugs.launchpad.net/oslo.middleware/+bug/1590635 feel free to comment - I may send an email as well on this topic | 13:56 |
| openstack | Launchpad bug 1590635 in oslo.middleware "http_proxy_to_wsgi middleware shouldn't be disabled by default " [Undecided,New] | 13:56 |
| *** yamamoto has quit IRC | 13:56 | |
| lbragstad | hey folks - i'd like to propose adding the ability to deprecate policies to oslo.policy. is it best to start that effort with a spec? | 14:02 |
| openstackgerrit | WuKong proposed openstack/oslo-specs master: external pdp hood for oslo.policy https://review.openstack.org/492543 | 14:05 |
| *** zxy has quit IRC | 14:21 | |
| *** lucas-brb is now known as lucasagomes | 14:41 | |
| *** yamamoto has joined #openstack-oslo | 14:52 | |
| openstackgerrit | Merged openstack/oslo.rootwrap master: Fix test_daemon_no_cleanup_for_uninitialized_server https://review.openstack.org/494237 | 14:54 |
| *** yamamoto has quit IRC | 14:58 | |
| stevemar | dhellmann: poke | 15:18 |
| stevemar | dhellmann: did you want to -1 this patch: https://review.openstack.org/#/c/491629/ ? | 15:18 |
| stevemar | dhellmann: otherwise i was going to +A it, seems reasonable, but you had a concern about direction | 15:19 |
| dhellmann | stevemar : I think it's a bad idea, in principle, to add more support for something we're trying to deprecate. I don't feel strongly enough to -2 it though. | 15:19 |
| stevemar | well now you've got me in a bind :) | 15:20 |
| dhellmann | it's fine to approve it if you think it's a good change. It just means a bit more work down the road when/if we drop JSON support. Maybe we'll never bother to do that, though. | 15:21 |
| *** lucasagomes is now known as lucas-afk | 15:28 | |
| Kimamisa | just to be sure, the only reason to switch to YAML is the possibility to add comments, right ? | 15:32 |
| stevemar | Kimamisa: that was a motivating factor, yes | 15:33 |
| Kimamisa | but apart from that, is there any technical reason ( I mean code constraints ) that would prevent keeping both ? | 15:35 |
| *** e0ne has quit IRC | 15:42 | |
| *** aselius has joined #openstack-oslo | 15:48 | |
| *** lpetrut_ has quit IRC | 15:50 | |
| *** yamamoto has joined #openstack-oslo | 15:54 | |
| *** rajathagasthya has joined #openstack-oslo | 15:55 | |
| stevemar | Kimamisa: not really, just as doug mentions, the whole move to yaml becomes harder | 15:59 |
| *** yamamoto has quit IRC | 16:00 | |
| Kimamisa | stevemar: in this case, I think the switch will ta | 16:04 |
| Kimamisa | ke time | 16:04 |
| Kimamisa | and that's a good tool to have | 16:04 |
| *** tesseract has quit IRC | 16:15 | |
| *** sambetts is now known as sambetts|afk | 16:21 | |
| *** rajathagasthya has quit IRC | 16:35 | |
| *** rajathagasthya has joined #openstack-oslo | 16:36 | |
| *** rcernin has quit IRC | 16:46 | |
| harlowja | chhavi feel free to ask, depending on where in the world u are, it might be easier just to post any questions :) | 16:48 |
| harlowja | (instead of waiting for people to get online at the same time) | 16:48 |
| *** pcaruana has quit IRC | 16:48 | |
| *** dave-mccowan has quit IRC | 16:50 | |
| *** lpetrut has quit IRC | 16:54 | |
| *** links has joined #openstack-oslo | 16:55 | |
| *** Kimamisa has quit IRC | 16:55 | |
| chhavi | harlowja: I have a question on Retry, If I have a main flow and some subflows in linear order, and i want to attempt retry if any of the subflow fails. | 16:55 |
| *** yamamoto has joined #openstack-oslo | 16:56 | |
| harlowja | ok, u should just be able to put a retry node on the main flow and that should force a retry to happen | 16:56 |
| chhavi | in this case, if i add retry to each subflows, what i am seing if the final result is a failure after max attempt, since the flow is linear, the number of attempts is more. | 16:57 |
| harlowja | ya, i'd just add the retry to the top 'main flow' | 16:57 |
| *** Kimamisa has joined #openstack-oslo | 16:58 | |
| chhavi | what is the difference adding the retry to top or subflow, I was expecting since subflow fails, only that should be retried, | 16:58 |
| harlowja | chhavi ya, if a subflow keeps on failing though, then from what i remember the main flow will then be retried | 17:00 |
| harlowja | ie if the inner retry 'doesn't work out' then the parent one will start to take affect | 17:01 |
| *** Kimamisa has quit IRC | 17:01 | |
| *** yamamoto has quit IRC | 17:02 | |
| chhavi | so if we put the retry on the mainFlow, we don't need to put in subflows, | 17:02 |
| harlowja | that's your choice | 17:02 |
| harlowja | think of it like | 17:03 |
| harlowja | # main flow | 17:03 |
| harlowja | while failing: | 17:03 |
| harlowja | do_task() | 17:03 |
| harlowja | # subflow | 17:03 |
| harlowja | def do_task(): | 17:03 |
| harlowja | while task_failing: | 17:03 |
| harlowja | do_subtask()... | 17:03 |
| chhavi | ok so if we put in mainflow as well as subflows, the number of attempts will be sum of both. is this correct understanding | 17:03 |
| *** ralonsoh has quit IRC | 17:03 | |
| harlowja | ya | 17:03 |
| harlowja | makes sense to me | 17:04 |
| chhavi | ok got it. | 17:04 |
| chhavi | one more issue which I was facing is to check the return value for the subflows, is there a way to verify if the subflow is executed successfully | 17:05 |
| chhavi | I ended up using provides, but are there any other way. | 17:06 |
| harlowja | hmmm, so subflows don't currently really return values | 17:07 |
| harlowja | though u can get whether or not an task in a subflow worked or didn't | 17:08 |
| harlowja | prob need to make this better... | 17:08 |
| harlowja | https://github.com/openstack/taskflow/blob/master/taskflow/storage.py#L509-L512 can get whether it worked or didn't | 17:08 |
| chhavi | how to check if the subflow executed successfully atleast | 17:08 |
| chhavi | ok, but i think this work only in case of persistence, | 17:10 |
| harlowja | stuff is always persisted (even in memory) | 17:10 |
| harlowja | so should be fine to depend on that | 17:10 |
| harlowja | code would have to be created to do it better | 17:10 |
| harlowja | *the information is there, just not exposed... | 17:10 |
| chhavi | ok | 17:10 |
| harlowja | chhavi if u want to work on some taskflow code, that'd prob be a medium size thing to do | 17:26 |
| harlowja | feel free :) | 17:26 |
| chhavi | sure will let u know, currently exploring how can i leverage this in our codeflows. they solve lot of common problems. | 17:29 |
| harlowja | cools | 17:33 |
| harlowja | chhavi if u want talk to some of the octavia folks; they are heavily using taskflow | 17:33 |
| harlowja | might be worthwhile to chat with them | 17:34 |
| johnsom | o/ | 17:34 |
| *** links has quit IRC | 17:34 | |
| *** lpetrut has joined #openstack-oslo | 17:45 | |
| harlowja | chhavi johnsom is the last time i checked the octavia PTL so might have some idears | 17:47 |
| harlowja | chhavi though some context on which/what project u are working on might help to :) | 17:47 |
| johnsom | Yep, crazy enough to re-up | 17:47 |
| harlowja | :-P | 17:47 |
| johnsom | So, stuck with me through Queens | 17:47 |
| harlowja | and beyond | 17:49 |
| harlowja | lo | 17:49 |
| harlowja | lol | 17:49 |
| johnsom | Anyway, if you want to see the crazy stuff we are doing this is a good starting point: https://docs.openstack.org/octavia/latest/contributor/devref/flows.html | 17:50 |
| harlowja | hmmmm, need to make that more pretty johnsom :-p | 17:51 |
| *** lpetrut has quit IRC | 17:51 | |
| harlowja | https://github.com/networkx/networkx/blob/master/networkx/readwrite/json_graph/__init__.py#L1 apparently exists (which might be readable by d3.js) | 17:51 |
| johnsom | harlowja Not all of us have so much spare time to polish..... | 17:51 |
| *** lpetrut has joined #openstack-oslo | 17:51 | |
| harlowja | http://bl.ocks.org/mbostock/4062045 (an example from that i guess) | 17:51 |
| johnsom | Hahaha | 17:52 |
| harlowja | management will give u extra bonus if u use that johnsom | 17:52 |
| harlowja | 2x extra bonus | 17:52 |
| harlowja | lol | 17:52 |
| johnsom | Well, harlowja, you develop we will leverage (steal?) | 17:52 |
| harlowja | lol | 17:52 |
| harlowja | do u profit share? | 17:52 |
| harlowja | lol | 17:52 |
| johnsom | Sure, happy to give you a slice of the "None" | 17:53 |
| harlowja | ha | 17:53 |
| harlowja | so thats like 1 million right | 17:54 |
| johnsom | It's as many None as you would like.... | 17:55 |
| johnsom | Just think of the options you will have with 1,000,000,000,000,000 * 0..... | 17:55 |
| johnsom | grin | 17:55 |
| harlowja | oh man | 17:55 |
| harlowja | lol | 17:55 |
| harlowja | just need to switch * 0 to * 1 | 17:56 |
| johnsom | Yeah, still working on that part. | 17:56 |
| *** yamamoto has joined #openstack-oslo | 17:58 | |
| *** yamamoto has quit IRC | 18:04 | |
| *** rajathagasthya has quit IRC | 18:09 | |
| *** rajathagasthya has joined #openstack-oslo | 18:22 | |
| *** chhavi has quit IRC | 18:23 | |
| *** lpetrut has quit IRC | 18:37 | |
| *** lpetrut has joined #openstack-oslo | 18:59 | |
| *** yamamoto has joined #openstack-oslo | 18:59 | |
| *** lpetrut has quit IRC | 19:05 | |
| *** yamamoto has quit IRC | 19:05 | |
| *** yamamoto has joined #openstack-oslo | 19:27 | |
| *** gcb has quit IRC | 19:33 | |
| *** lpetrut has joined #openstack-oslo | 19:33 | |
| *** e0ne has joined #openstack-oslo | 19:34 | |
| *** dave-mccowan has joined #openstack-oslo | 19:35 | |
| *** e0ne has quit IRC | 19:47 | |
| *** e0ne has joined #openstack-oslo | 19:53 | |
| *** eck` is now known as eck`gone | 20:12 | |
| *** e0ne has quit IRC | 20:14 | |
| *** kgiusti has left #openstack-oslo | 20:20 | |
| *** ansmith has quit IRC | 20:33 | |
| *** rmascena has quit IRC | 20:33 | |
| *** Kimamisa1 has joined #openstack-oslo | 20:46 | |
| *** eck`gone is now known as eck` | 20:53 | |
| *** Kimamisa1 has quit IRC | 21:02 | |
| *** kimamisa has joined #openstack-oslo | 21:03 | |
| *** yamamoto has quit IRC | 21:04 | |
| *** kimamisa has left #openstack-oslo | 21:05 | |
| *** yamamoto has joined #openstack-oslo | 21:08 | |
| *** kimamisa has joined #openstack-oslo | 21:14 | |
| *** kimamisa has quit IRC | 21:23 | |
| *** ansmith has joined #openstack-oslo | 21:27 | |
| *** yamamoto has quit IRC | 21:30 | |
| *** yamamoto has joined #openstack-oslo | 21:32 | |
| *** yamamoto has quit IRC | 21:32 | |
| *** tbarron is now known as tbarron|errand | 21:46 | |
| *** janzian has quit IRC | 21:50 | |
| *** lpetrut has quit IRC | 21:55 | |
| *** sdague has quit IRC | 22:04 | |
| *** boden has quit IRC | 22:11 | |
| *** lbragstad has quit IRC | 22:20 | |
| *** gordc has quit IRC | 23:09 | |
| *** ianychoi has quit IRC | 23:17 | |
| *** ianychoi has joined #openstack-oslo | 23:17 | |
| *** yamamoto has joined #openstack-oslo | 23:28 | |
| openstackgerrit | Sean McCully proposed openstack/oslo.versionedobjects master: iso8601.is8601.Utc No Longer Exists https://review.openstack.org/498275 | 23:32 |
| *** spzala has joined #openstack-oslo | 23:33 | |
| *** spzala has quit IRC | 23:33 | |
| *** yamamoto has quit IRC | 23:46 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!