openstackgerrit | Merged openstack/oslo.serialization master: Revert "Explicitly raise ValueError in to_primitive" https://review.openstack.org/484396 | 00:08 |
---|---|---|
*** ansmith has joined #openstack-oslo | 00:26 | |
*** boris-42__ has quit IRC | 00:27 | |
*** dave-mccowan has quit IRC | 00:42 | |
*** dave-mccowan has joined #openstack-oslo | 00:46 | |
*** gcb has quit IRC | 00:53 | |
*** rajathagasthya has quit IRC | 01:03 | |
*** boden has quit IRC | 01:10 | |
*** trungnv has quit IRC | 01:12 | |
*** zhangguoqing has joined #openstack-oslo | 01:24 | |
*** harlowja has quit IRC | 01:34 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.log master: Updated from global requirements https://review.openstack.org/484567 | 01:54 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.messaging master: Updated from global requirements https://review.openstack.org/484568 | 01:54 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.policy master: Updated from global requirements https://review.openstack.org/484569 | 01:55 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.reports master: Updated from global requirements https://review.openstack.org/484570 | 01:55 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.versionedobjects master: Updated from global requirements https://review.openstack.org/484571 | 01:55 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/pycadf master: Updated from global requirements https://review.openstack.org/470137 | 01:55 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/taskflow master: Updated from global requirements https://review.openstack.org/484591 | 01:58 |
*** dave-mccowan has quit IRC | 02:02 | |
*** xgerman__ has joined #openstack-oslo | 02:06 | |
*** samueldmq_ has joined #openstack-oslo | 02:06 | |
*** ildikov_ has joined #openstack-oslo | 02:06 | |
*** patrickeast_ has joined #openstack-oslo | 02:06 | |
*** nikhil_ has joined #openstack-oslo | 02:06 | |
*** nikhil_ is now known as Guest78669 | 02:06 | |
*** _d34dh0r53_ has joined #openstack-oslo | 02:12 | |
*** toabctl_ has joined #openstack-oslo | 02:13 | |
*** dhellmann has quit IRC | 02:13 | |
*** patrickeast has quit IRC | 02:13 | |
*** ildikov has quit IRC | 02:13 | |
*** toabctl has quit IRC | 02:13 | |
*** larainema has quit IRC | 02:13 | |
*** d34dh0r53 has quit IRC | 02:13 | |
*** samueldmq has quit IRC | 02:13 | |
*** xgerman_ has quit IRC | 02:13 | |
*** nikhil has quit IRC | 02:13 | |
*** ildikov_ is now known as ildikov | 02:13 | |
*** patrickeast_ is now known as patrickeast | 02:13 | |
*** toabctl_ is now known as toabctl | 02:14 | |
*** samueldmq_ is now known as samueldmq | 02:14 | |
*** xgerman__ is now known as xgerman_ | 02:14 | |
*** Guest78669 is now known as nikhil | 02:14 | |
openstackgerrit | Merged openstack/osprofiler master: Update .gitignore https://review.openstack.org/480982 | 02:16 |
*** dhellmann has joined #openstack-oslo | 02:19 | |
*** gcb has joined #openstack-oslo | 02:19 | |
*** dave-mccowan has joined #openstack-oslo | 02:26 | |
*** trungnv has joined #openstack-oslo | 02:31 | |
*** yamamoto has joined #openstack-oslo | 02:41 | |
*** dave-mccowan has quit IRC | 02:44 | |
*** sdague has quit IRC | 03:29 | |
*** harlowja has joined #openstack-oslo | 03:40 | |
*** zhangguoqing has quit IRC | 03:49 | |
*** links has joined #openstack-oslo | 03:55 | |
*** larainema has joined #openstack-oslo | 04:03 | |
*** aselius has quit IRC | 04:17 | |
*** chhavi has joined #openstack-oslo | 04:21 | |
openstackgerrit | Merged openstack/oslo.log master: Updated from global requirements https://review.openstack.org/484567 | 04:28 |
*** rajathagasthya has joined #openstack-oslo | 04:31 | |
openstackgerrit | Merged openstack/oslo.versionedobjects master: Updated from global requirements https://review.openstack.org/484571 | 04:41 |
openstackgerrit | Merged openstack/taskflow master: Updated from global requirements https://review.openstack.org/484591 | 04:44 |
*** nicolasbock has joined #openstack-oslo | 04:44 | |
*** zhangguoqing has joined #openstack-oslo | 04:48 | |
*** harlowja has quit IRC | 04:54 | |
*** zzzeek has quit IRC | 04:55 | |
*** bnemec has quit IRC | 05:13 | |
*** nicolasbock has quit IRC | 05:19 | |
*** nicolasbock has joined #openstack-oslo | 05:21 | |
*** rcernin has joined #openstack-oslo | 05:29 | |
*** rajathagasthya has quit IRC | 05:31 | |
*** zzzeek has joined #openstack-oslo | 05:36 | |
*** zzzeek has quit IRC | 05:37 | |
*** zzzeek has joined #openstack-oslo | 05:38 | |
*** lpetrut_ has joined #openstack-oslo | 06:11 | |
openstackgerrit | Lingyong Xu proposed openstack/oslotest master: Use assertIsNone(...) instead of assertIs(None,...) https://review.openstack.org/484642 | 06:49 |
openstackgerrit | Merged openstack/oslo.messaging master: Updated from global requirements https://review.openstack.org/484568 | 06:50 |
*** lpetrut_ has quit IRC | 07:02 | |
openstackgerrit | Merged openstack/oslo.policy master: Updated from global requirements https://review.openstack.org/484569 | 07:07 |
openstackgerrit | Merged openstack/oslo.reports master: Updated from global requirements https://review.openstack.org/484570 | 07:15 |
*** lpetrut_ has joined #openstack-oslo | 07:17 | |
*** tesseract has joined #openstack-oslo | 07:18 | |
*** shardy has joined #openstack-oslo | 07:19 | |
*** shardy has quit IRC | 07:21 | |
*** lpetrut_ has quit IRC | 07:29 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/oslotest master: Update URLs in documents according to document migration https://review.openstack.org/483169 | 07:32 |
openstackgerrit | Merged openstack/oslotest master: Update URLs in documents according to document migration https://review.openstack.org/483169 | 07:40 |
*** ralonsoh has joined #openstack-oslo | 07:41 | |
*** gcb has quit IRC | 08:09 | |
*** lucas-afk is now known as lucasagomes | 08:17 | |
openstackgerrit | chenxu proposed openstack/osprofiler master: Add loading local static files option of template.html https://review.openstack.org/484671 | 08:36 |
*** yamamoto has quit IRC | 08:36 | |
*** yamamoto has joined #openstack-oslo | 09:01 | |
*** yamamoto has quit IRC | 09:02 | |
*** yamamoto has joined #openstack-oslo | 09:04 | |
*** zhangguoqing has quit IRC | 09:20 | |
*** zhangguoqing has joined #openstack-oslo | 09:22 | |
*** shardy has joined #openstack-oslo | 09:39 | |
*** sambetts|afk is now known as sambetts | 09:46 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.cache master: Imported Translations from Zanata https://review.openstack.org/483285 | 09:47 |
*** Dinesh_Bhor has quit IRC | 09:50 | |
*** zhangguoqing has quit IRC | 10:02 | |
*** gcb has joined #openstack-oslo | 10:11 | |
*** ralonsoh has quit IRC | 10:15 | |
*** yamamoto has quit IRC | 10:18 | |
*** Dinesh_Bhor has joined #openstack-oslo | 10:21 | |
*** lpetrut_ has joined #openstack-oslo | 10:23 | |
*** sdague has joined #openstack-oslo | 10:23 | |
*** yamamoto has joined #openstack-oslo | 10:28 | |
*** boden has joined #openstack-oslo | 10:31 | |
*** yamamoto has quit IRC | 10:38 | |
*** raildo has joined #openstack-oslo | 11:03 | |
*** ralonsoh has joined #openstack-oslo | 11:14 | |
*** dave-mccowan has joined #openstack-oslo | 11:17 | |
*** lucasagomes is now known as lucas-hungry | 11:21 | |
*** dave-mccowan has quit IRC | 11:23 | |
*** ralonsoh_ has joined #openstack-oslo | 11:24 | |
*** ralonsoh has quit IRC | 11:24 | |
*** ansmith has quit IRC | 11:28 | |
*** yamamoto has joined #openstack-oslo | 11:33 | |
*** lpetrut__ has joined #openstack-oslo | 11:35 | |
*** lpetrut_ has quit IRC | 11:37 | |
*** janzian has joined #openstack-oslo | 11:52 | |
*** yamamoto has quit IRC | 12:04 | |
*** clayton has quit IRC | 12:08 | |
*** clayton has joined #openstack-oslo | 12:09 | |
*** yamamoto has joined #openstack-oslo | 12:19 | |
*** lucas-hungry is now known as lucasagomes | 12:25 | |
*** MVenesio has joined #openstack-oslo | 12:29 | |
*** eck`gone is now known as eck` | 12:33 | |
*** kgiusti has joined #openstack-oslo | 12:38 | |
*** gordc has joined #openstack-oslo | 12:40 | |
*** ansmith has joined #openstack-oslo | 12:44 | |
*** ralonsoh_ is now known as ralonsoh | 12:52 | |
*** eck` is now known as eck`gone | 12:59 | |
*** bknudson has joined #openstack-oslo | 13:06 | |
*** eck`gone is now known as eck` | 13:10 | |
*** nicolasbock has quit IRC | 13:27 | |
*** nicolasbock has joined #openstack-oslo | 13:28 | |
*** nicolasbock has quit IRC | 13:32 | |
*** nicolasbock has joined #openstack-oslo | 13:35 | |
*** links has quit IRC | 13:38 | |
*** pblaho has quit IRC | 13:44 | |
*** kgiusti has quit IRC | 13:59 | |
*** pblaho has joined #openstack-oslo | 14:00 | |
*** kgiusti has joined #openstack-oslo | 14:01 | |
openstackgerrit | Michael Bayer proposed openstack/oslo.db master: Rename idle_timeout to connection_recycle_time https://review.openstack.org/334182 | 14:23 |
*** ihrachys has joined #openstack-oslo | 14:25 | |
*** bnemec has joined #openstack-oslo | 14:25 | |
*** aselius has joined #openstack-oslo | 14:33 | |
*** kgiusti has quit IRC | 14:48 | |
openstackgerrit | Michael Bayer proposed openstack/oslo.db master: Rename idle_timeout to connection_recycle_time https://review.openstack.org/334182 | 15:07 |
*** kgiusti has joined #openstack-oslo | 15:14 | |
*** yamamoto has quit IRC | 15:17 | |
*** bknudson has left #openstack-oslo | 15:17 | |
*** yamamoto has joined #openstack-oslo | 15:21 | |
*** bknudson has joined #openstack-oslo | 15:21 | |
openstackgerrit | Doug Hellmann proposed openstack/oslo.config master: handle option defaults that are not strings https://review.openstack.org/484848 | 15:26 |
*** bknudson has left #openstack-oslo | 15:28 | |
*** yamamoto has quit IRC | 15:29 | |
*** bknudson has joined #openstack-oslo | 15:31 | |
*** rcernin has quit IRC | 15:32 | |
openstackgerrit | Doug Hellmann proposed openstack/oslo.config master: handle option defaults that are not strings https://review.openstack.org/484848 | 15:36 |
dhellmann | gcb, dims, bnemec : ^^ could use reviews. it would be good to include that in a release this week. | 15:37 |
dims | ack dhellmann on it | 15:38 |
*** pblaho has quit IRC | 15:40 | |
dims | dhellmann : when will we end up in the else condition in line 498? https://review.openstack.org/#/c/484848/2/oslo_config/types.py | 15:47 |
dhellmann | looking | 15:48 |
dhellmann | dims : oh, good question | 15:48 |
dhellmann | if the option is a list, but the default is given as a single int | 15:48 |
dhellmann | I don't have a test for that | 15:48 |
bnemec | dhellmann: I left a comment on the generator change too. | 15:49 |
dhellmann | oh, and that's not a valid configuration | 15:49 |
dhellmann | bnemec : yes, thanks, typo there | 15:51 |
bnemec | A list of one item is not valid? | 15:51 |
dhellmann | bnemec : a list of 1 item is. A single int not in a list is not. | 15:51 |
dhellmann | I wonder if a single string default works | 15:52 |
bnemec | So value is always either a string or a list object, not a bare int? | 15:52 |
dhellmann | it looks like it | 15:53 |
dhellmann | stand by for a new patchset | 15:54 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.config master: handle option defaults that are not strings https://review.openstack.org/484848 | 15:55 |
dims | dhellmann : LGTM when it goes green | 15:59 |
bnemec | dhellmann: So I guess the thing there is that while the List type can take a type parameter, we only ever added the String type: https://github.com/openstack/oslo.config/blob/a8482a323b65dd5390c4ec375b3b4b50f66bb204/oslo_config/cfg.py#L1364 | 16:01 |
bnemec | So I'm not sure the else was wrong, it just wasn't necessary today. | 16:01 |
*** rcernin has joined #openstack-oslo | 16:02 | |
bnemec | Actually, does Cinder have a custom opt type defined or something? | 16:02 |
bnemec | Otherwise how would they be creating lists of non-strings? | 16:03 |
openstackgerrit | Eric Harney proposed openstack/oslo.config master: Fix python 3.6 escape char warnings in strings https://review.openstack.org/484871 | 16:03 |
*** rajathagasthya has joined #openstack-oslo | 16:17 | |
*** yamamoto has joined #openstack-oslo | 16:29 | |
*** rajathag_ has joined #openstack-oslo | 16:33 | |
*** rajathagasthya has quit IRC | 16:33 | |
*** yamamoto has quit IRC | 16:37 | |
*** lpetrut__ has quit IRC | 16:38 | |
*** sambetts is now known as sambetts|afk | 16:57 | |
*** ralonsoh has quit IRC | 17:00 | |
*** yamamoto has joined #openstack-oslo | 17:07 | |
*** yamamoto has quit IRC | 17:12 | |
openstackgerrit | Michael Bayer proposed openstack/oslo.db master: Rename idle_timeout to connection_recycle_time https://review.openstack.org/334182 | 17:15 |
*** harlowja has joined #openstack-oslo | 17:24 | |
*** lucasagomes is now known as lucas-afk | 17:25 | |
*** nicolasbock has quit IRC | 17:35 | |
*** nicolasbock has joined #openstack-oslo | 17:36 | |
*** bknudson has quit IRC | 17:38 | |
dhellmann | zzzeek : I've found your issue with oslo.config; stand by for the fix | 17:40 |
zzzeek | dhellmann: woop | 17:44 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.config master: fix an issue with looking up deprecated option names in code https://review.openstack.org/484897 | 17:45 |
dhellmann | zzzeek : ^^ | 17:45 |
dhellmann | gcb, dims, bnemec : here's another quick-fix for pike ^^ | 17:45 |
zzzeek | dhellmann: cool | 17:45 |
dhellmann | zzzeek : you'll be far far better off in the long run if you disallow the use of config options as APIs, though, and fix those nova tests. | 17:46 |
zzzeek | dhellmann: yeah how do i "disallow" that ? | 17:46 |
dhellmann | zzzeek : well, at this point it's a policy issue | 17:47 |
dhellmann | so you'd change the tests in nova, with a comment that they should never have been doing whatever they're doing | 17:47 |
dhellmann | changing the tests may mean adding some functions to oslo.db to support what they want | 17:47 |
dhellmann | or a fixture, maybe? | 17:48 |
dhellmann | I'd have to look at the actual tests to say exactly what to do | 17:48 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.config master: handle option defaults that are not strings https://review.openstack.org/484848 | 17:50 |
*** bknudson has joined #openstack-oslo | 17:53 | |
zzzeek | dhellmann: nova-manage command does it: http://logs.openstack.org/82/334182/4/check/gate-tempest-dsvm-neutron-src-oslo.db-ubuntu-xenial/c1dcab4/logs/devstacklog.txt.gz | 17:54 |
zzzeek | dhellmann: ive no clue what theyre trying to do there | 17:55 |
dhellmann | whatever it is, oslo.db should provide the implementation of get_db_conf | 17:55 |
*** tesseract has quit IRC | 17:58 | |
*** deep-book-gk_ has joined #openstack-oslo | 18:12 | |
*** deep-book-gk_ has left #openstack-oslo | 18:15 | |
*** chhavi has quit IRC | 18:17 | |
zzzeek | dhellmann: enginefacade already supported configure(**dict(conf.database)) so for now I've proposed that. but it's crunchtime so now I've annoyed nova by putting up gerrits | 18:38 |
dhellmann | yeah, given that this is the library freeze week your patch to move those config options is not likely to go out in pike :-/ | 18:38 |
zzzeek | dhellmann: yah it's not a pike thing | 19:13 |
dhellmann | zzzeek : ok, good | 19:13 |
*** lpetrut__ has joined #openstack-oslo | 19:24 | |
*** bknudson has quit IRC | 19:25 | |
*** zzzeek has quit IRC | 19:29 | |
*** zzzeek has joined #openstack-oslo | 19:30 | |
*** nicolasbock has quit IRC | 19:53 | |
*** dave-mccowan has joined #openstack-oslo | 19:58 | |
*** eck` is now known as eck`gone | 20:04 | |
*** bknudson has joined #openstack-oslo | 20:05 | |
*** Dinesh_Bhor has quit IRC | 20:17 | |
*** dave-mccowan has quit IRC | 20:17 | |
*** kgiusti has quit IRC | 20:21 | |
*** dave-mccowan has joined #openstack-oslo | 20:24 | |
*** ansmith has quit IRC | 20:24 | |
openstackgerrit | Doug Hellmann proposed openstack/oslo.config master: fix an issue with looking up deprecated option names in code https://review.openstack.org/484897 | 20:25 |
*** dave-mccowan has quit IRC | 20:27 | |
dims | dhellmann : i noticed that castellan does not use stevedore ... filed this one https://review.openstack.org/#/c/484015/ | 20:34 |
*** shardy has quit IRC | 20:34 | |
dhellmann | dims : nice | 20:36 |
openstackgerrit | Merged openstack/oslo.config master: handle option defaults that are not strings https://review.openstack.org/484848 | 20:37 |
*** lpetrut__ has quit IRC | 20:38 | |
*** eck`gone is now known as eck` | 20:41 | |
*** raildo has quit IRC | 20:48 | |
*** rcernin has quit IRC | 20:57 | |
*** sdague has quit IRC | 21:02 | |
*** MVenesio has quit IRC | 21:09 | |
openstackgerrit | Merged openstack/oslo.db master: Log an exception when reconnect-to-disconnected occurs https://review.openstack.org/484455 | 21:12 |
openstackgerrit | Merged openstack/oslo.config master: Fix python 3.6 escape char warnings in strings https://review.openstack.org/484871 | 21:15 |
*** rajathag_ has quit IRC | 21:26 | |
*** MVenesio has joined #openstack-oslo | 21:50 | |
*** MVenesio has quit IRC | 21:50 | |
*** gordc has quit IRC | 22:25 | |
*** janzian has quit IRC | 22:40 | |
*** boden has quit IRC | 22:42 | |
*** bknudson has quit IRC | 22:52 | |
*** ansmith has joined #openstack-oslo | 22:58 | |
*** gcb has quit IRC | 23:02 | |
*** dave-mccowan has joined #openstack-oslo | 23:29 | |
*** dave-mcc_ has joined #openstack-oslo | 23:37 | |
*** dave-mccowan has quit IRC | 23:38 | |
*** dave-mcc_ has quit IRC | 23:45 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!