| *** jamielennox is now known as jamielennox|away | 00:07 | |
| *** harlowja has quit IRC | 00:09 | |
| *** jdandrea has quit IRC | 00:09 | |
| *** LeoZhang has quit IRC | 00:09 | |
| *** jdandrea has joined #openstack-oslo | 00:10 | |
| *** LeoZhang has joined #openstack-oslo | 00:10 | |
| *** purplerbot has quit IRC | 00:11 | |
| *** jamielennox|away is now known as jamielennox | 00:11 | |
| *** ogelbukh has quit IRC | 00:11 | |
| *** macsz has quit IRC | 00:12 | |
| *** dmitryme has quit IRC | 00:12 | |
| *** rpodolyaka has quit IRC | 00:12 | |
| *** johnsom has quit IRC | 00:12 | |
| *** macsz has joined #openstack-oslo | 00:12 | |
| *** HenryG has quit IRC | 00:12 | |
| *** purplerbot has joined #openstack-oslo | 00:12 | |
| *** ogelbukh has joined #openstack-oslo | 00:13 | |
| *** pkoniszewski has quit IRC | 00:13 | |
| *** dmitryme has joined #openstack-oslo | 00:13 | |
| *** ildikov has quit IRC | 00:13 | |
| *** jroll has quit IRC | 00:14 | |
| *** HenryG has joined #openstack-oslo | 00:15 | |
| *** pkoniszewski has joined #openstack-oslo | 00:16 | |
| *** rpodolyaka has joined #openstack-oslo | 00:20 | |
| *** jroll has joined #openstack-oslo | 00:20 | |
| *** ildikov has joined #openstack-oslo | 00:21 | |
| *** johnsom has joined #openstack-oslo | 00:22 | |
| *** johnsom has quit IRC | 00:25 | |
| *** johnsom has joined #openstack-oslo | 00:25 | |
| *** harlowja has joined #openstack-oslo | 00:25 | |
| *** mriedem has joined #openstack-oslo | 00:35 | |
| *** mriedem1 has joined #openstack-oslo | 00:38 | |
| *** mriedem has quit IRC | 00:42 | |
| *** mriedem1 has quit IRC | 00:58 | |
| *** LeoZhang has quit IRC | 01:11 | |
| *** ansmith_ has joined #openstack-oslo | 01:19 | |
| *** ansmith has joined #openstack-oslo | 01:19 | |
| *** zz_dimtruck is now known as dimtruck | 01:22 | |
| *** Syed__ has quit IRC | 01:25 | |
| *** xgerman has joined #openstack-oslo | 01:32 | |
| *** tovin07 has joined #openstack-oslo | 02:00 | |
| *** browne has quit IRC | 02:08 | |
| *** ansmith has quit IRC | 02:11 | |
| *** ansmith_ has quit IRC | 02:11 | |
| *** dimtruck is now known as zz_dimtruck | 02:15 | |
| *** jeckersb_gone is now known as jeckersb | 02:43 | |
| *** spzala has quit IRC | 02:52 | |
| *** deray has joined #openstack-oslo | 03:01 | |
| *** zz_dimtruck is now known as dimtruck | 03:11 | |
| *** yamahata has quit IRC | 03:14 | |
| *** amotoki has quit IRC | 03:21 | |
| *** amotoki has joined #openstack-oslo | 03:29 | |
| *** nicolasbock has quit IRC | 03:31 | |
| *** salv-orl_ has quit IRC | 03:32 | |
| *** salv-orlando has joined #openstack-oslo | 03:32 | |
| *** amotoki has quit IRC | 03:33 | |
| *** spzala has joined #openstack-oslo | 03:47 | |
| openstackgerrit | Tuan Luong-Anh proposed openstack/futurist: Allow functions to raise a never again exception to remove themselves from running https://review.openstack.org/418612 | 03:47 |
|---|---|---|
| *** links has joined #openstack-oslo | 03:47 | |
| *** ihrachys has joined #openstack-oslo | 04:11 | |
| *** yamahata has joined #openstack-oslo | 04:15 | |
| *** spzala has quit IRC | 04:19 | |
| *** salv-orl_ has joined #openstack-oslo | 04:23 | |
| *** salv-orlando has quit IRC | 04:26 | |
| *** ihrachys has quit IRC | 05:06 | |
| *** gcb has quit IRC | 05:13 | |
| *** deray has quit IRC | 05:23 | |
| *** deray has joined #openstack-oslo | 05:29 | |
| *** nkrinner_afk is now known as nkrinner | 06:04 | |
| *** gcb has joined #openstack-oslo | 06:04 | |
| *** lpetrut has joined #openstack-oslo | 06:10 | |
| *** itisha has quit IRC | 06:12 | |
| *** dims has quit IRC | 06:13 | |
| *** pcaruana has joined #openstack-oslo | 06:25 | |
| *** lpetrut has quit IRC | 06:43 | |
| openstackgerrit | rajiv proposed openstack/tooz: Removed unnecessary utf-8 encoding https://review.openstack.org/418733 | 06:45 |
| *** lpetrut has joined #openstack-oslo | 07:00 | |
| *** lpetrut has quit IRC | 07:08 | |
| *** tesseract has joined #openstack-oslo | 07:08 | |
| *** lpetrut has joined #openstack-oslo | 07:17 | |
| *** dimtruck is now known as zz_dimtruck | 07:24 | |
| *** amotoki has joined #openstack-oslo | 07:28 | |
| *** lpetrut has quit IRC | 07:33 | |
| *** rasca has joined #openstack-oslo | 07:35 | |
| *** eezhova has joined #openstack-oslo | 07:39 | |
| *** hogepodge has quit IRC | 07:56 | |
| *** sheeprine has quit IRC | 08:05 | |
| *** yamahata has quit IRC | 08:05 | |
| *** sheeprine has joined #openstack-oslo | 08:09 | |
| *** amotoki has quit IRC | 08:16 | |
| *** gcb has quit IRC | 08:19 | |
| *** salv-orl_ has quit IRC | 08:21 | |
| *** lpetrut has joined #openstack-oslo | 08:24 | |
| *** ozamiatin has joined #openstack-oslo | 08:28 | |
| *** eezhova has quit IRC | 08:28 | |
| *** gcb has joined #openstack-oslo | 08:33 | |
| *** gcb has quit IRC | 08:40 | |
| *** dtardivel has joined #openstack-oslo | 08:41 | |
| *** ozamiatin has quit IRC | 08:50 | |
| *** eezhova has joined #openstack-oslo | 08:51 | |
| *** ozamiatin has joined #openstack-oslo | 08:52 | |
| openstackgerrit | rajiv proposed openstack/tooz: Removed unnecessary utf-8 encoding https://review.openstack.org/418733 | 08:53 |
| *** ozamiatin has quit IRC | 09:00 | |
| *** zzzeek has quit IRC | 09:00 | |
| *** zzzeek has joined #openstack-oslo | 09:00 | |
| *** jeckersb is now known as jeckersb_gone | 09:13 | |
| *** shardy has joined #openstack-oslo | 09:13 | |
| *** jeckersb_gone has quit IRC | 09:13 | |
| *** sambetts|afk is now known as sambetts | 09:17 | |
| *** amotoki has joined #openstack-oslo | 09:22 | |
| *** lucas-afk is now known as lucasagomes | 09:38 | |
| *** e0ne has joined #openstack-oslo | 10:02 | |
| *** sambetts is now known as sambetts|afk | 10:20 | |
| *** ozamiatin has joined #openstack-oslo | 10:24 | |
| openstackgerrit | Merged openstack/oslo.middleware: Remove references to Python 3.4 https://review.openstack.org/418008 | 10:31 |
| *** mhickey has joined #openstack-oslo | 10:43 | |
| *** aarefiev has joined #openstack-oslo | 10:47 | |
| *** aarefiev_afk has quit IRC | 10:50 | |
| *** gcb has joined #openstack-oslo | 11:00 | |
| *** cdent has joined #openstack-oslo | 11:00 | |
| *** deray has quit IRC | 11:12 | |
| *** sdague has joined #openstack-oslo | 11:15 | |
| openstackgerrit | Oleksii Zamiatin proposed openstack/oslo.messaging: [zmq] Distinguish Round-Robin/Fanout socket sending mode https://review.openstack.org/418866 | 11:26 |
| *** nicolasbock has joined #openstack-oslo | 11:35 | |
| *** boden has joined #openstack-oslo | 11:36 | |
| *** boden has quit IRC | 11:36 | |
| *** boden has joined #openstack-oslo | 11:37 | |
| *** dims has joined #openstack-oslo | 11:39 | |
| *** tommylikehu_ has joined #openstack-oslo | 11:57 | |
| openstackgerrit | Oleksii Zamiatin proposed openstack/oslo.messaging: [zmq] Support py35 testenv https://review.openstack.org/418887 | 12:04 |
| *** rtheis has joined #openstack-oslo | 12:09 | |
| *** sambetts|afk is now known as sambetts | 12:09 | |
| *** amotoki has quit IRC | 12:14 | |
| *** jeckersb_gone has joined #openstack-oslo | 12:25 | |
| *** amotoki has joined #openstack-oslo | 12:26 | |
| *** jeckersb_gone has quit IRC | 12:29 | |
| *** jeckersb_gone has joined #openstack-oslo | 12:30 | |
| *** tommylikehu_ has quit IRC | 12:33 | |
| *** shardy is now known as shardy_lunch | 12:43 | |
| *** gcb has quit IRC | 12:45 | |
| *** lucasagomes is now known as lucas-hungry | 12:50 | |
| *** pblaho has quit IRC | 12:50 | |
| *** amotoki has quit IRC | 12:50 | |
| *** tommylikehu_ has joined #openstack-oslo | 12:59 | |
| *** tommylikehu_ has quit IRC | 12:59 | |
| *** pblaho has joined #openstack-oslo | 12:59 | |
| *** tommylikehu_ has joined #openstack-oslo | 12:59 | |
| *** amotoki has joined #openstack-oslo | 13:00 | |
| *** amotoki has quit IRC | 13:02 | |
| *** LeoZhang has joined #openstack-oslo | 13:04 | |
| *** amotoki has joined #openstack-oslo | 13:05 | |
| *** yamamoto has joined #openstack-oslo | 13:06 | |
| *** tovin07_ has joined #openstack-oslo | 13:09 | |
| *** LeoZhang has quit IRC | 13:10 | |
| *** LeoZhang has joined #openstack-oslo | 13:10 | |
| openstackgerrit | Radoslav Gerganov proposed openstack/oslo.vmware: Fix setting the SOAP headers for remote calls. https://review.openstack.org/418921 | 13:12 |
| *** shardy_lunch has quit IRC | 13:12 | |
| openstackgerrit | Radoslav Gerganov proposed openstack/oslo.vmware: Fix setting the SOAP headers for remote calls. https://review.openstack.org/418921 | 13:14 |
| *** ansmith has joined #openstack-oslo | 13:14 | |
| *** tovin07 has quit IRC | 13:15 | |
| *** tovin07_ is now known as tovin07 | 13:15 | |
| *** tovin07_ has joined #openstack-oslo | 13:15 | |
| *** ansmith_ has joined #openstack-oslo | 13:17 | |
| *** shardy_lunch has joined #openstack-oslo | 13:19 | |
| *** electrocucarach has joined #openstack-oslo | 13:20 | |
| *** trown|outtypewww is now known as trown | 13:22 | |
| *** ozamiatin has quit IRC | 13:23 | |
| *** ozamiatin has joined #openstack-oslo | 13:27 | |
| *** shardy_lunch is now known as shardy | 13:28 | |
| *** amotoki has quit IRC | 13:28 | |
| *** shardy has quit IRC | 13:28 | |
| *** shardy has joined #openstack-oslo | 13:29 | |
| *** kgiusti has joined #openstack-oslo | 13:32 | |
| *** amotoki has joined #openstack-oslo | 13:39 | |
| openstackgerrit | M V P Nitesh proposed openstack/futurist: Removes unnecessary utf-8 encoding https://review.openstack.org/418933 | 13:40 |
| *** lucas-hungry has quit IRC | 13:41 | |
| *** lucasagomes has joined #openstack-oslo | 13:47 | |
| *** trown is now known as trown|brb | 13:49 | |
| *** ozamiatin has quit IRC | 13:52 | |
| *** david-lyle has quit IRC | 13:56 | |
| *** ihrachys has joined #openstack-oslo | 13:56 | |
| *** tongli has joined #openstack-oslo | 13:59 | |
| *** amotoki has quit IRC | 13:59 | |
| *** david-lyle has joined #openstack-oslo | 13:59 | |
| *** ozamiatin has joined #openstack-oslo | 14:01 | |
| *** yamamoto has quit IRC | 14:01 | |
| *** yamamoto has joined #openstack-oslo | 14:02 | |
| *** links has quit IRC | 14:02 | |
| *** mriedem has joined #openstack-oslo | 14:03 | |
| *** trown|brb is now known as trown | 14:04 | |
| *** yamamoto has quit IRC | 14:07 | |
| *** itisha has joined #openstack-oslo | 14:11 | |
| *** jeckersb_gone is now known as jeckersb | 14:11 | |
| *** electrocucarach is now known as electrocucaracha | 14:13 | |
| *** jamielennox is now known as jamielennox|away | 14:14 | |
| *** david-lyle has quit IRC | 14:16 | |
| *** zz_dimtruck is now known as dimtruck | 14:22 | |
| *** tovin07 has left #openstack-oslo | 14:27 | |
| *** yamamoto has joined #openstack-oslo | 14:30 | |
| *** yamamoto has quit IRC | 14:34 | |
| *** yamamoto has joined #openstack-oslo | 14:35 | |
| *** amotoki has joined #openstack-oslo | 14:39 | |
| *** yamamoto has quit IRC | 14:40 | |
| *** yamamoto has joined #openstack-oslo | 14:43 | |
| *** dimtruck is now known as zz_dimtruck | 14:49 | |
| *** tongli has quit IRC | 14:49 | |
| *** yamamoto has quit IRC | 14:49 | |
| *** spzala has joined #openstack-oslo | 15:06 | |
| *** spzala has quit IRC | 15:06 | |
| *** spzala has joined #openstack-oslo | 15:06 | |
| *** miqui has joined #openstack-oslo | 15:08 | |
| *** nkrinner is now known as nkrinner_afk | 15:09 | |
| *** pradk has joined #openstack-oslo | 15:15 | |
| *** zz_dimtruck is now known as dimtruck | 15:21 | |
| *** yamahata has joined #openstack-oslo | 15:22 | |
| *** gordc has joined #openstack-oslo | 15:32 | |
| *** tommylikehu_ has quit IRC | 15:33 | |
| *** shardy has quit IRC | 15:43 | |
| *** spzala has quit IRC | 15:44 | |
| *** spzala has joined #openstack-oslo | 15:44 | |
| *** lucasagomes has quit IRC | 15:44 | |
| *** spzala has quit IRC | 15:45 | |
| *** spzala has joined #openstack-oslo | 15:45 | |
| *** lucasagomes has joined #openstack-oslo | 15:46 | |
| *** yamamoto has joined #openstack-oslo | 15:50 | |
| *** tommylikehu_ has joined #openstack-oslo | 15:52 | |
| *** tommylikehu_ has quit IRC | 15:55 | |
| *** mhickey_ has joined #openstack-oslo | 16:01 | |
| *** yamamoto has quit IRC | 16:02 | |
| *** mhickey has quit IRC | 16:04 | |
| *** salv-orlando has joined #openstack-oslo | 16:09 | |
| openstackgerrit | Merged openstack/oslo.messaging: [zmq] Distinguish Round-Robin/Fanout socket sending mode https://review.openstack.org/418866 | 16:10 |
| *** Rockyg has joined #openstack-oslo | 16:13 | |
| *** Syed__ has joined #openstack-oslo | 16:15 | |
| *** salv-orl_ has joined #openstack-oslo | 16:22 | |
| *** salv-orlando has quit IRC | 16:25 | |
| *** trown is now known as trown|lunch | 16:28 | |
| *** eezhova has quit IRC | 16:30 | |
| *** jeckersb is now known as jeckersb_gone | 16:31 | |
| *** jeckersb_gone is now known as jeckersb | 16:31 | |
| *** cdent has quit IRC | 16:38 | |
| *** shardy has joined #openstack-oslo | 16:38 | |
| *** cdent has joined #openstack-oslo | 16:51 | |
| *** mhickey_ has quit IRC | 16:52 | |
| *** ozamiatin has quit IRC | 16:53 | |
| *** mhickey_ has joined #openstack-oslo | 16:56 | |
| *** e0ne has quit IRC | 17:06 | |
| *** pcaruana has quit IRC | 17:12 | |
| *** Zealoussnow_ has joined #openstack-oslo | 17:13 | |
| *** LeoZhang has quit IRC | 17:13 | |
| Syed__ | Hi guys, i need some help with oslo policy Enforce authorize | 17:15 |
| Syed__ | any help would be appreciated | 17:15 |
| *** eezhova has joined #openstack-oslo | 17:19 | |
| *** tesseract has quit IRC | 17:20 | |
| *** eezhova has quit IRC | 17:21 | |
| JayF | Syed__: it's better to just ask your question directly, ratehr than asking to ask. That way you can get help from folks who may not be brave enough to claim expertise in oslo.policy :) | 17:22 |
| Syed__ | so i am actually running into an issue with PolicyNotRegistered | 17:22 |
| Syed__ | its giving me an error saying oslo_policy.policy.PolicyNotRegistered: Policy fleet:audit has not been registered | 17:23 |
| Syed__ | i am working on a basic script to set up | 17:23 |
| *** yamahata has quit IRC | 17:25 | |
| *** lpetrut has quit IRC | 17:38 | |
| *** eezhova has joined #openstack-oslo | 17:40 | |
| *** browne has joined #openstack-oslo | 17:46 | |
| *** SlickNik has joined #openstack-oslo | 17:49 | |
| *** lucasagomes is now known as lucas-afk | 17:50 | |
| *** lenticularmother has joined #openstack-oslo | 17:53 | |
| *** aarefiev is now known as aarefiev_afk | 17:54 | |
| *** yamahata has joined #openstack-oslo | 17:54 | |
| *** vipuls has joined #openstack-oslo | 17:58 | |
| *** trown|lunch is now known as trown | 18:05 | |
| *** david-lyle has joined #openstack-oslo | 18:16 | |
| *** rasca has quit IRC | 18:17 | |
| *** sambetts is now known as sambetts|afk | 18:19 | |
| *** lpetrut has joined #openstack-oslo | 18:31 | |
| *** amotoki has quit IRC | 18:32 | |
| *** mhickey_ has quit IRC | 18:32 | |
| *** ozamiatin has joined #openstack-oslo | 18:34 | |
| *** dharinic is now known as dharinic|lunch | 18:36 | |
| *** lenticularmother has quit IRC | 18:44 | |
| *** shardy has quit IRC | 18:48 | |
| *** Rockyg has quit IRC | 18:51 | |
| *** cdent has quit IRC | 18:53 | |
| *** lpetrut has quit IRC | 18:55 | |
| *** mtanino has joined #openstack-oslo | 19:02 | |
| *** eezhova has quit IRC | 19:04 | |
| *** spzala has quit IRC | 19:07 | |
| *** spzala has joined #openstack-oslo | 19:07 | |
| *** spzala has quit IRC | 19:12 | |
| *** ozamiatin has quit IRC | 19:15 | |
| *** dharinic|lunch is now known as dharinic | 19:26 | |
| *** amotoki has joined #openstack-oslo | 19:32 | |
| *** eezhova has joined #openstack-oslo | 19:33 | |
| *** salv-orl_ has quit IRC | 19:45 | |
| *** eezhova has quit IRC | 19:51 | |
| openstackgerrit | Julian proposed openstack/oslo.versionedobjects: Fixed JSONSchema Enum and IPV4AndV6Address Changed the schema from oneOf ipv4 and ipv6 pattern to ipv6 only because of validation issues. (ipv4 format is valid ipv6) Added None to the Enum values if it's nullable to be valid JSON Schema Converted Enum val https://review.openstack.org/419114 | 19:59 |
| *** e0ne has joined #openstack-oslo | 20:14 | |
| *** spzala_ has joined #openstack-oslo | 20:15 | |
| *** spzala_ has quit IRC | 20:20 | |
| *** spzala has joined #openstack-oslo | 20:21 | |
| openstackgerrit | Merged openstack/oslo.utils: Remove references to Python 3.4 https://review.openstack.org/418005 | 20:24 |
| *** browne has quit IRC | 20:28 | |
| *** browne has joined #openstack-oslo | 20:33 | |
| openstackgerrit | John Perkins proposed openstack/oslo.config: oslo validator https://review.openstack.org/384559 | 20:34 |
| *** e0ne has quit IRC | 20:43 | |
| kevinbenton | harlowja: hola senior | 20:57 |
| harlowja | yo yo | 20:58 |
| kevinbenton | harlowja: any plans to bump minimum rec sqlalchemy to 1.1 ? | 20:58 |
| harlowja | if zzzeek thinks its useful to do so | 20:58 |
| kevinbenton | ack | 20:58 |
| kevinbenton | i want this event | 20:58 |
| kevinbenton | http://docs.sqlalchemy.org/en/latest/orm/events.html#sqlalchemy.orm.events.SessionEvents.loaded_as_persistent | 20:58 |
| kevinbenton | it pleases me | 20:59 |
| harlowja | lol | 20:59 |
| kevinbenton | harlowja: unrelated question | 21:00 |
| kevinbenton | harlowja: do we have any utils for making weakrefs to bound methods? | 21:00 |
| harlowja | hmmm, i don't | 21:01 |
| *** jamielennox|away is now known as jamielennox | 21:01 | |
| kevinbenton | harlowja: i have this janky thing (L269: https://review.openstack.org/#/c/418555/3/neutron/db/common_db_mixin.py) | 21:01 |
| kevinbenton | HenryG: around? | 21:07 |
| *** dimtruck is now known as zz_dimtruck | 21:07 | |
| kevinbenton | (sorry, wrong channel) | 21:07 |
| *** trown is now known as trown|mtg | 21:09 | |
| harlowja | kevinbenton why u need to do that btw, lol | 21:10 |
| harlowja | are u doing some crazy plugin loading | 21:11 |
| harlowja | and unloading | 21:11 |
| harlowja | lol | 21:11 |
| kevinbenton | harlowja: yeah, for unit tests | 21:11 |
| kevinbenton | harlowja: the problem is that we have callbacks that plugins register to extend dictionaries | 21:11 |
| harlowja | ? | 21:11 |
| harlowja | seems ok, ha | 21:11 |
| kevinbenton | harlowja: and each unit test builds a new instance of whatever plugin its testing | 21:12 |
| kevinbenton | harlowja: but the callbacks stick around | 21:12 |
| kevinbenton | harlowja: from the old instances | 21:12 |
| harlowja | ya, i wonder if zzzeek has any existing code | 21:13 |
| harlowja | since sqlalchemy is a pretty heavy user of weakrefs (i believe) | 21:13 |
| kevinbenton | harlowja: yeah, i sent him a message in the neutron channel asking about it but he hasn't gotten back to me yet | 21:13 |
| kevinbenton | harlowja: i poked around sqlachemy's use of weakrefs and didn't see anything obvious | 21:13 |
| harlowja | ah i do remember some of this | 21:16 |
| harlowja | https://github.com/harlowja/notifier/blob/master/requirements.txt#L11 | 21:16 |
| harlowja | https://pypi.python.org/pypi/weakrefmethod/ | 21:16 |
| harlowja | would that help u? | 21:16 |
| *** cdent has joined #openstack-oslo | 21:19 | |
| harlowja | ^ may not be needed on py3 | 21:20 |
| *** salv-orlando has joined #openstack-oslo | 21:25 | |
| *** zz_dimtruck is now known as dimtruck | 21:27 | |
| kevinbenton | harlowja: yes | 21:29 |
| kevinbenton | harlowja: that would be what i need | 21:29 |
| kevinbenton | harlowja: thx | 21:29 |
| harlowja | np | 21:29 |
| *** lpetrut has joined #openstack-oslo | 21:33 | |
| zzzeek | kevinbenton / harlowja : there's some sqlalchemy-migrate that has to be merged for tests to pass on it | 21:34 |
| zzzeek | hmm maybe it merged. | 21:34 |
| zzzeek | ah it was this https://review.openstack.org/#/c/389363/ it merged | 21:35 |
| kevinbenton | harlowja: no weakrefmethod in global reqs :( | 21:35 |
| kevinbenton | zzzeek: does the sqlalchemy API expose generated weakrefs for bound methods in its API? ;) | 21:35 |
| kevinbenton | generating* | 21:35 |
| zzzeek | kevinbenton: you mean, if i call sqlalchemy.foo.bar(), "bar" is directly a weakref object? | 21:36 |
| kevinbenton | zzzeek: nah, i was just kidding. I want a function I can pass a bound method to and get a weakref back :) | 21:37 |
| *** rtheis has quit IRC | 21:38 | |
| *** lpetrut has quit IRC | 21:38 | |
| zzzeek | kevinbenton: oh. yeah internally we use this thing with __call__ on it. if you want that you should put it in oslo.utils | 21:38 |
| kevinbenton | zzzeek: harlowja pointed me to https://github.com/twang817/weakrefmethod/blob/master/weakrefmethod/weakrefmethod.py | 21:39 |
| kevinbenton | zzzeek: just gonna try to add that to global reqs | 21:39 |
| harlowja | use py3 and problem solved, lol | 21:39 |
| zzzeek | kevinbenton: ok. this looks complicated | 21:39 |
| harlowja | not sure how much of a direct backport of https://hg.python.org/cpython/file/tip/Lib/weakref.py#l36 that is | 21:41 |
| zzzeek | kevinbenton: OK i guess this is for methods yah SQLA doesn't quite have this | 21:41 |
| kevinbenton | zzzeek: so how is sqlalchemy dealing with bound methods then? | 21:41 |
| zzzeek | kevinbenton: you mean w/ events ? | 21:41 |
| kevinbenton | zzzeek: yeah | 21:42 |
| zzzeek | kevinbenton: ok let me clarify. if you make an fn, and set that as an event handler, fn itself doesn't get GC'ed if you lose your own references to it | 21:42 |
| *** trown|mtg is now known as trown|outtypewww | 21:42 | |
| kevinbenton | zzzeek: ah, then i do have to worry about objects being kept alive if they subscribe bound methods to events | 21:42 |
| zzzeek | it's the other way around. if you lose references to the object that you've set the event listener on, *that* will get GC'ed and so will your fn | 21:43 |
| zzzeek | kevinbenton: why | 21:43 |
| kevinbenton | zzzeek: unit tests | 21:43 |
| zzzeek | kevinbenton: is there some error you're dealing with ? | 21:43 |
| kevinbenton | zzzeek: wait. i'm not following | 21:43 |
| zzzeek | a bound method should have a strong reference to its "self' already | 21:44 |
| kevinbenton | zzzeek: right, so if you have a strong reference to a bound method in sqla, the event system is keeping that object alive | 21:44 |
| kevinbenton | zzzeek: even if we blow away all references | 21:44 |
| kevinbenton | zzzeek: and forget to unsubscribe | 21:45 |
| zzzeek | kevinbenton: well yes it's normal that you might have an event fn that does something important but you don't need to hold a reference to it | 21:45 |
| zzzeek | e.g. if the host object goes away your fn does too | 21:45 |
| kevinbenton | zzzeek: how do you store the list of event subscribers? | 21:46 |
| kevinbenton | zzzeek: i don't see how the object could ever go away unless you implemented some kind of weakmethod thing like that library above | 21:46 |
| zzzeek | kevinbenton: id have to look. it's intense because there are class-level lists and instance-level lists and there's some gymniastics to make it performant and some other stuff | 21:46 |
| kevinbenton | zzzeek: so if i construct an instance of the revision handler in neutron, it will subscribe to an after_flush event | 21:47 |
| kevinbenton | zzzeek: https://github.com/openstack/neutron/blob/master/neutron/services/revisions/revision_plugin.py#L27-L37 | 21:48 |
| zzzeek | kevinbenton: you have SQLAlchemy object Q, Q has some event collecton that points to your bound method, which has self, so Q->your method->your "self" why can't that be garbage collected? | 21:48 |
| zzzeek | kevinbenton: unless you're going for no reference cycles at all | 21:49 |
| kevinbenton | zzzeek: the event is attached to from sqlalchemy.orm.session.Session | 21:49 |
| kevinbenton | zzzeek: for 'after_flush' | 21:49 |
| kevinbenton | zzzeek: so that will always have the event collection forever, right? | 21:49 |
| zzzeek | kevinbenton: to the Session class? | 21:50 |
| kevinbenton | zzzeek: https://github.com/openstack/neutron/blob/master/neutron/services/revisions/revision_plugin.py#L37 | 21:50 |
| kevinbenton | zzzeek: yeah | 21:50 |
| zzzeek | kevinbenton: if it's on the class, or the thing from sessoinmaker(), yeah that will live as long as that sessionmaker | 21:50 |
| kevinbenton | zzzeek: yeah, and our sessionmaker is defined at import time IIRC | 21:51 |
| kevinbenton | zzzeek: so for the lifetime of all of the unit tests, it's going to build up cruft | 21:51 |
| kevinbenton | zzzeek: does sqlalchemy have a way to just blow away all listeners that we can add to cleanup? | 21:51 |
| kevinbenton | zzzeek: i didn't see anything in the docs | 21:52 |
| zzzeek | kevinbenton: an indivual event listener can be removed | 21:52 |
| zzzeek | kevinbenton: so if your setup is adding a listener, you should tear it down in a cleanup | 21:52 |
| zzzeek | kevinbenton: as far as removing all listeners, that's a thing internally but it isn't exposed b.c. that would prevent SQLAlchemy from ever using events internally | 21:52 |
| kevinbenton | zzzeek: yeah, i figured that might be why | 21:53 |
| kevinbenton | zzzeek: unfortunately forcing to remember to teardown is what led to the issue :) | 21:53 |
| zzzeek | kevinbenton: yah but we use addCleanup / fixtures for everything no ? | 21:53 |
| kevinbenton | zzzeek: it's not quite that straight forward. The revision plugin is constructed based on configured service plugins for the test | 21:55 |
| kevinbenton | zzzeek: and that construction is handled by the neutron plugin manager | 21:55 |
| kevinbenton | zzzeek: i need to think about this a bit to avoid putting test logic in the real plugin | 21:55 |
| zzzeek | kevinbenton: making all that reversible would be worthwhile :) | 21:57 |
| kevinbenton | zzzeek: adding an unsubscribe method is the easy part :) | 21:57 |
| kevinbenton | zzzeek: sanely automating it so it's not easy to leak this stuff is what i want | 21:58 |
| zzzeek | kevinbenton: you can make your "event subscribe" maintain a link to the key and FN right there, and package it up into an unsubscriber | 21:58 |
| *** ansmith has quit IRC | 21:59 | |
| *** ansmith_ has quit IRC | 21:59 | |
| *** ihrachys has quit IRC | 22:01 | |
| *** spzala has quit IRC | 22:09 | |
| *** cdent has quit IRC | 22:15 | |
| *** spzala has joined #openstack-oslo | 22:16 | |
| *** spzala has quit IRC | 22:20 | |
| *** salv-orl_ has joined #openstack-oslo | 22:22 | |
| *** salv-orlando has quit IRC | 22:26 | |
| *** spzala has joined #openstack-oslo | 22:28 | |
| *** spzala has quit IRC | 22:28 | |
| *** dtardivel has quit IRC | 22:34 | |
| *** kberger has joined #openstack-oslo | 22:41 | |
| *** miqui has quit IRC | 22:41 | |
| *** boden has quit IRC | 22:49 | |
| *** tommylikehu_ has joined #openstack-oslo | 22:58 | |
| *** spzala has joined #openstack-oslo | 23:01 | |
| *** tommylikehu_ has quit IRC | 23:07 | |
| *** spzala has quit IRC | 23:09 | |
| *** spzala has joined #openstack-oslo | 23:09 | |
| *** spzala has quit IRC | 23:18 | |
| *** pradk has quit IRC | 23:38 | |
| *** dimtruck is now known as zz_dimtruck | 23:47 | |
| *** salv-orl_ has quit IRC | 23:52 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!