Wednesday, 2016-11-30

*** dimtruck is now known as zz_dimtruck00:43
*** tommylikehu_ has joined #openstack-oslo00:48
*** mtanino has quit IRC00:59
*** tovin07_ has quit IRC01:16
*** spzala has quit IRC01:27
openstackgerritint32bit proposed openstack/oslo.db: Check if an index on given columns exists.  https://review.openstack.org/40212801:31
tommylikehu_hey anybody here, could you spend some time on this patch? https://review.openstack.org/#/c/404272/01:40
*** zhangguoqing has joined #openstack-oslo01:45
*** ansmith has joined #openstack-oslo01:48
*** gcb has joined #openstack-oslo01:50
*** ansmith has quit IRC02:10
*** tovin07 has joined #openstack-oslo02:16
*** tovin07_ has joined #openstack-oslo02:18
*** stevemar__ has joined #openstack-oslo02:29
*** browne has quit IRC02:52
*** zz_dimtruck is now known as dimtruck02:53
*** zhenq has quit IRC03:08
*** code-R has joined #openstack-oslo03:20
*** code-R_ has joined #openstack-oslo03:21
*** code-R has quit IRC03:25
*** code-R_ has quit IRC03:25
*** code-R has joined #openstack-oslo03:25
*** links has joined #openstack-oslo03:28
*** tommylikehu_ has quit IRC03:51
*** nicolasbock has quit IRC03:57
*** code-R_ has joined #openstack-oslo04:04
*** code-R has quit IRC04:07
*** stevemar__ has quit IRC04:19
*** stevemar__ has joined #openstack-oslo04:19
*** stevemar__ has quit IRC04:24
*** yamamoto_ has quit IRC04:24
*** yamahata has quit IRC04:35
openstackgerritMerged openstack/stevedore: Add Apache 2.0 license to source file  https://review.openstack.org/40351704:36
*** dimtruck is now known as zz_dimtruck04:47
*** zz_dimtruck is now known as dimtruck04:47
*** dimtruck is now known as zz_dimtruck05:01
*** tommylikehu_ has joined #openstack-oslo05:07
*** yamamoto_ has joined #openstack-oslo05:08
*** code-R_ has quit IRC05:26
*** gcb has quit IRC05:54
*** chenying_ has quit IRC05:54
openstackgerritThomas Bechtold proposed openstack/oslo.config: Add defaults for config-dir  https://review.openstack.org/40066705:57
toabctldhellmann, I had to update https://review.openstack.org/#/c/400667 again (pep8 failed). Could you please readd your +2?05:58
*** gcb has joined #openstack-oslo06:07
*** code-R has joined #openstack-oslo06:08
*** yamahata has joined #openstack-oslo06:26
*** code-R_ has joined #openstack-oslo06:26
*** stevemar__ has joined #openstack-oslo06:29
*** code-R has quit IRC06:30
*** stevemar__ has quit IRC06:33
*** tsufiev has quit IRC06:35
*** tsufiev has joined #openstack-oslo06:39
*** code-R_ has quit IRC06:42
openstackgerritint32bit proposed openstack/oslo.db: Check if an index on given columns exists.  https://review.openstack.org/40212806:43
openstackgerritMehdi Abaakouk (sileht) proposed openstack/oslo.messaging: DNM: Revert "Add Constraints support"  https://review.openstack.org/40457706:47
*** oanson has joined #openstack-oslo07:01
*** nkrinner_afk is now known as nkrinner07:04
*** e0ne has joined #openstack-oslo07:16
openstackgerritMehdi Abaakouk (sileht) proposed openstack/oslo.messaging: Revert "Add Constraints support"  https://review.openstack.org/40457707:19
*** hoonetorg has quit IRC07:21
*** hoonetorg has joined #openstack-oslo07:21
*** hoonetorg has quit IRC07:24
*** hoonetorg has joined #openstack-oslo07:24
*** eezhova has joined #openstack-oslo07:27
*** rcernin has joined #openstack-oslo07:28
*** mkoderer has joined #openstack-oslo07:30
haypoharlowja: asynchronous programming is hard :)07:45
sileht(with monkeypatching)07:45
sileht:p07:46
hayposileht: hi. harlowja asked me "why is asyncio so complicated :-P" ;-)07:47
silehthaypo, because it works on non-posix platform ?07:47
hayposileht: saying that asynchronous programming is easy is just a lie :) see https://docs.python.org/dev/library/asyncio-dev.html for example of corner cases ;)07:47
*** eezhova has quit IRC07:49
*** gcb has quit IRC07:51
silehthaypo, very interesting07:52
*** gcb has joined #openstack-oslo07:53
*** tsufiev has quit IRC07:54
hayposileht: no, it's not a side effect of portability07:55
hayposileht: asyncio API is mostly OS-agnostic07:55
silehthaypo, I was kidding07:55
hayposileht: hehe07:55
*** eezhova has joined #openstack-oslo07:56
openstackgerritMehdi Abaakouk (sileht) proposed openstack/oslo.messaging: Remove small job timeout  https://review.openstack.org/40461507:58
*** tsufiev has joined #openstack-oslo07:58
openstackgerritint32bit proposed openstack/oslo.db: Strip prefix `migrate_` in parameter `migrate_engine`  https://review.openstack.org/40461808:00
*** shardy has joined #openstack-oslo08:04
*** links has quit IRC08:06
hayposileht: ah, FYI I just added socket.TCP_USER_TIMEOUT constant to Python 3.6 ;-) i missed that someone proposed a patch a few months ago08:07
hayposileht: i didn't know that Python didn't have the constant!08:07
silehthaypo, this is a recent socket change and kernel change08:08
haypo"recent"...08:08
hayposileht: Linux 2.6.3708:08
hayposileht: Fedora 25 uses Linux 4.808:08
*** amotoki has joined #openstack-oslo08:08
*** amotoki has quit IRC08:08
thervehaypo, You can still use it without python having it, no?08:09
haypoLinux 2.6.37 released 4 January, 2011.08:09
haypotherve: sure08:09
sileht2.6.37 ? I have thought is was more recent08:09
haypotherve: i prefer to avoid hardcoded constants, i'm never confident that constants are "portable". CLOCK_MONOTONIC was a pain: it was different between openbsd, freebsd, mac os x and linux :-/08:10
haypothat's why i added time.monotonic(), to avoid the "if sys.platform ..." mess ;)08:10
hayposileht: which part of oslo.messaging uses OS_TEST_TIMEOUT ?08:11
silehthaypo, all08:11
silehthaypo, that's a oslotest thing08:11
hayposileht: i don't see the constant uses directly08:11
silehthaypo, this is the per test timeout08:11
haypoah ok08:12
silehthaypo, the default is located in .testr.conf08:12
silehthaypo, this is used by oslotest timeoutfixture08:12
hayposileht: +2a for me, the fix seems well contained and safe08:13
silehthaypo, thx!08:13
haypoincreasing a timeout shouldn't make tests failing08:13
haypoanyway, if something goes wrong, it will be your fault08:13
haypo!08:13
silehtyeah I known08:13
*** dtardivel has joined #openstack-oslo08:16
*** links has joined #openstack-oslo08:18
*** eezhova has quit IRC08:19
*** jpena|off is now known as jpena08:22
*** amoralej|off is now known as amoralej08:25
*** stevemar__ has joined #openstack-oslo08:30
*** stevemar__ has quit IRC08:34
*** e0ne has quit IRC08:35
*** eezhova has joined #openstack-oslo08:43
*** zzzeek has quit IRC09:00
*** zzzeek has joined #openstack-oslo09:00
*** yamahata has quit IRC09:09
*** lpetrut has joined #openstack-oslo09:10
tommylikehu_ping harlowja09:18
*** lei-zh has joined #openstack-oslo09:22
*** lei-zh has left #openstack-oslo09:22
*** lei-zh has joined #openstack-oslo09:22
haypotommylikehu_: he lives in australia, so he is probably sleeping ;)09:23
*** lei-zh has quit IRC09:23
haypotommylikehu_: moreover, please don't use naked ping, but leave a message ;)09:23
*** lei-zh has joined #openstack-oslo09:23
*** lei-zh has quit IRC09:27
*** lei-zh has joined #openstack-oslo09:27
tommylikehu_haypo: thanks for your reminder~09:28
*** lei-zh has quit IRC09:30
*** lei-zh has joined #openstack-oslo09:30
tommylikehu_harlowja: could you take a look at this patch when you available?  https://review.openstack.org/#/c/404620/09:32
*** yassine has joined #openstack-oslo09:32
*** lucas-afk is now known as lucasagomes09:33
*** yassine is now known as Guest6200909:33
*** tommylikehu_ has quit IRC09:51
*** tommylikehu_ has joined #openstack-oslo09:51
*** tommylikehu_ has quit IRC09:51
*** tommylikehu_ has joined #openstack-oslo09:52
*** lpetrut has quit IRC09:55
*** tommylikehu_ has quit IRC09:56
*** lei-zh has quit IRC09:58
*** tovin07_ has quit IRC10:02
*** lpetrut has joined #openstack-oslo10:03
*** code-R has joined #openstack-oslo10:04
*** links has quit IRC10:05
*** code-R_ has joined #openstack-oslo10:07
*** snikitin has joined #openstack-oslo10:07
*** code-R has quit IRC10:10
*** hoonetorg has quit IRC10:15
snikitinharlowja: Hi! yesterday this patch https://review.openstack.org/#/c/404357/ was merged in oslo.policy. It improves the performance of Nova unit tests almost in 2 times and it will be very useful for nova team to get it. So I wanted to ask when new oslo.policy release is expected?10:15
*** andreaf has quit IRC10:17
*** ihrachys has joined #openstack-oslo10:17
*** andreaf has joined #openstack-oslo10:18
*** pkholkin_ has joined #openstack-oslo10:18
*** e0ne has joined #openstack-oslo10:18
*** pkholkin has quit IRC10:19
*** pkholkin_ is now known as pkholkin10:19
*** zz_dimtruck has quit IRC10:19
*** ogelbukh has quit IRC10:19
*** bnemec has quit IRC10:19
*** johndperkins has quit IRC10:19
*** DinaBelova has quit IRC10:19
*** jschwarz has quit IRC10:19
*** mfisch has quit IRC10:19
*** dhellmann has quit IRC10:19
*** lpetrut has quit IRC10:20
*** bnemec has joined #openstack-oslo10:21
*** e0ne has quit IRC10:21
*** DinaBelova has joined #openstack-oslo10:21
*** e0ne has joined #openstack-oslo10:21
*** links has joined #openstack-oslo10:22
*** ogelbukh has joined #openstack-oslo10:22
*** mfisch has joined #openstack-oslo10:23
*** mfisch has quit IRC10:23
*** mfisch has joined #openstack-oslo10:23
*** dhellmann has joined #openstack-oslo10:23
*** hoonetorg has joined #openstack-oslo10:24
*** zz_dimtruck has joined #openstack-oslo10:25
*** boris-42 has quit IRC10:25
*** code-R_ has quit IRC10:25
*** zz_dimtruck is now known as dimtruck10:25
*** code-R has joined #openstack-oslo10:26
*** jschwarz has joined #openstack-oslo10:26
*** boris-42 has joined #openstack-oslo10:28
*** johndperkins has joined #openstack-oslo10:30
openstackgerritAlexis Lee proposed openstack/oslo.config: List comprehensions  https://review.openstack.org/40075110:35
*** pcaruana has joined #openstack-oslo10:35
*** e0ne has quit IRC10:36
*** e0ne has joined #openstack-oslo10:36
*** cdent has joined #openstack-oslo10:37
*** lpetrut has joined #openstack-oslo10:55
*** lpetrut has quit IRC11:01
*** links has quit IRC11:07
*** links has joined #openstack-oslo11:08
*** sdague has joined #openstack-oslo11:27
*** ansmith has joined #openstack-oslo11:36
*** boden has joined #openstack-oslo11:37
*** rtheis has joined #openstack-oslo11:49
openstackgerritJulien Danjou proposed openstack/tooz: zookeeper: switch to standard group membership watching  https://review.openstack.org/39916211:52
openstackgerritJulien Danjou proposed openstack/tooz: Add partitioner implementation  https://review.openstack.org/39860411:52
openstackgerritJulien Danjou proposed openstack/tooz: coordination: add __repr__ for join/leave events  https://review.openstack.org/39835011:52
openstackgerritJulien Danjou proposed openstack/tooz: coordination: renforce event based testing  https://review.openstack.org/39834911:52
openstackgerritJulien Danjou proposed openstack/tooz: Use the internal group of list rather than listing the groups  https://review.openstack.org/39916111:52
openstackgerritJulien Danjou proposed openstack/tooz: Add a hashring implementation  https://review.openstack.org/39726411:52
openstackgerritJulien Danjou proposed openstack/tooz: Factorize member_id in the base coordinator class  https://review.openstack.org/39777211:52
openstackgerritJulien Danjou proposed openstack/tooz: Move the cached-based watcher implementation into its own class  https://review.openstack.org/39726311:52
openstackgerritJulien Danjou proposed openstack/tooz: Do not re-set the members cache for watchers by default  https://review.openstack.org/39835211:52
*** szaher has quit IRC11:56
*** ansmith has quit IRC11:58
*** nicolasbock has joined #openstack-oslo12:11
*** links has quit IRC12:34
*** amoralej is now known as amoralej|lunch12:50
*** lucasagomes is now known as lucas-hungry12:54
*** gcb has quit IRC12:58
*** yamamoto_ has quit IRC12:59
*** code-R_ has joined #openstack-oslo13:22
*** ansmith has joined #openstack-oslo13:22
*** code-R has quit IRC13:24
*** lei-zh has joined #openstack-oslo13:25
*** links has joined #openstack-oslo13:36
*** links has quit IRC13:36
*** edmondsw has joined #openstack-oslo13:36
*** stevemar__ has joined #openstack-oslo13:37
*** zhangguoqing has quit IRC13:39
*** mhickey has joined #openstack-oslo13:40
*** rasca has joined #openstack-oslo13:40
*** oanson has quit IRC13:43
*** jeckersb is now known as jeckersb_gone13:45
*** yamamoto has joined #openstack-oslo13:45
thervejd__, Started getting this failure yesterday night: http://logs.openstack.org/40/404340/1/check/gate-heat-dsvm-functional-convg-mysql-lbaasv2-centos-7-amqp1-nv/689d26a/logs/screen-s-proxy.txt.gz13:46
therveAny idea what's going on?13:46
therveIt's in the qpid gate13:47
jd__therve: not a clue, sileht maybe?13:47
*** jpena is now known as jpena|lunch13:48
silehttherve, no idea13:49
therveIt's weird, I can't see where the change comes from13:50
*** lucas-hungry is now known as lucasagomes13:51
silehttherve, in http://logs.openstack.org/40/404340/1/check/gate-heat-dsvm-functional-convg-mysql-lbaasv2-centos-7-amqp1-nv/689d26a/logs/etc/swift/proxy-server.conf.txt.gz13:51
silehttherve, the url is obvious wrong13:51
silehttherve, "url = amqp://:@10.12.39.254:/"13:51
silehtempty is not a valid port :)13:51
silehttherve, we can fix it in oslo.messaging13:52
silehttherve, but something else put ':' without a port13:52
thervesileht, https://review.openstack.org/#/c/399166/ maybe?13:54
silehttherve, indeed13:54
therveI haven't spotted the error just yet :)13:55
therveAh yeah the $port doesn't have a default value13:56
rascahaypo, dhellmann, rpodolyaka, dims, hi everybody guys, what else needs to be done to have this https://review.openstack.org/#/c/404289/ merged and finally get the package? Is Joshua the only one in charge of this?13:56
*** szaher has joined #openstack-oslo13:56
therveansmith, Hi, around? I have a question with https://review.openstack.org/#/c/399166/13:56
openstackgerritJulien Danjou proposed openstack/tooz: zookeeper: switch to standard group membership watching  https://review.openstack.org/39916213:58
openstackgerritJulien Danjou proposed openstack/tooz: Add partitioner implementation  https://review.openstack.org/39860413:58
openstackgerritJulien Danjou proposed openstack/tooz: coordination: add __repr__ for join/leave events  https://review.openstack.org/39835013:58
openstackgerritJulien Danjou proposed openstack/tooz: coordination: renforce event based testing  https://review.openstack.org/39834913:58
openstackgerritJulien Danjou proposed openstack/tooz: Use the internal group of list rather than listing the groups  https://review.openstack.org/39916113:58
openstackgerritJulien Danjou proposed openstack/tooz: Add a hashring implementation  https://review.openstack.org/39726413:58
openstackgerritJulien Danjou proposed openstack/tooz: Factorize member_id in the base coordinator class  https://review.openstack.org/39777213:58
openstackgerritJulien Danjou proposed openstack/tooz: Move the cached-based watcher implementation into its own class  https://review.openstack.org/39726313:58
openstackgerritJulien Danjou proposed openstack/tooz: Do not re-set the members cache for watchers by default  https://review.openstack.org/39835213:58
thervesileht, Thanks for your help :)13:58
rpodolyakarasca: +1'ed the patch, but we'll need someone from the stable team or harlowja to approve it13:59
silehttherve, I have written a fix13:59
silehttherve, does your job use amqp1.0 driver ?14:00
thervesileht, Yep14:00
silehttherve, cool !14:00
silehttherve, I fix the oslo.messaging port bug but I have nothing to test the amqp1.0 plugin14:01
thervesileht, I mean, you don't have to change oslo messaging frankly. Maybe just have a better error, but it's a broken setup14:03
silehttherve, the url is self is valid14:04
therveI guess14:04
silehttherve, TransportUrl object try to mimic urlparse14:05
*** code-R has joined #openstack-oslo14:05
silehttherve, urlparse raise ValueError for incorrect port too14:05
silehtfor this particular case, empty is not an invalid error14:05
silehterror/value14:05
*** kgiusti has joined #openstack-oslo14:06
*** tongli has joined #openstack-oslo14:07
*** code-R_ has quit IRC14:08
openstackgerritMehdi Abaakouk (sileht) proposed openstack/oslo.messaging: Fix transport url with empty port  https://review.openstack.org/40478314:09
*** shardy has quit IRC14:09
silehttherve, https://review.openstack.org/40478314:09
thervesileht, What will happen when None bubbles up later on? There is a real default?14:11
silehttherve, None means driver default14:11
*** amoralej|lunch is now known as amoralej14:11
therveCool, makes sense14:12
zzzeekhey all i need https://review.openstack.org/#/c/404443/  and https://review.openstack.org/#/c/404453/ to go in, if we release oslo.db w/o then neutron test suite will break, and we need an oslo.db release for a different mysql issue14:13
kgiustisileht: hey - any chance we can get some sileht love for https://review.openstack.org/#/c/402753/  ?14:15
kgiustisileht: seeing zeromq timeouts http://logs.openstack.org/11/403911/2/check/gate-oslo.messaging-dsvm-functional-py27-zeromq/e87cfd1/console.html#_2016-11-29_21_24_28_16338014:15
silehtkgiusti, I have found that too: https://review.openstack.org/#/c/404615/14:16
kgiustisileht: yeah - I was just looking at that one. :)14:17
silehtkgiusti, I'm planning to pass voting the rabbit one14:17
silehtkgiusti, I wonder why it have been disabled14:17
silehtkgiusti, the commit (8 months old) said for 'instable' reason14:18
kgiustisileht: good question - I wondered about that too.14:18
silehtbut I don't see any failure with logstash since 3 months14:18
sileht(3 months is the max retention of logs)14:18
kgiusti+1 to making it voting14:18
*** pradk has quit IRC14:24
*** mriedem has quit IRC14:25
*** tsufiev has quit IRC14:33
*** gcb has joined #openstack-oslo14:33
*** tsufiev has joined #openstack-oslo14:37
*** jeckersb_gone is now known as jeckersb14:38
openstackgerritMerged openstack/oslo.config: Add defaults for config-dir  https://review.openstack.org/40066714:41
openstackgerritGevorg Davoian proposed openstack/oslo.messaging: [zmq] Support message versions for rolling upgrades  https://review.openstack.org/39051714:41
openstackgerritMehdi Abaakouk (sileht) proposed openstack/oslo.messaging: kafka separate unit/functionnal tests  https://review.openstack.org/40480214:41
silehtLet's see what the gate thing, but that one should fix our py3 jobs : https://review.openstack.org/40480214:42
silehtkgiusti, ^14:42
openstackgerritMehdi Abaakouk (sileht) proposed openstack/oslo.messaging: kafka separate unit/functionnal tests  https://review.openstack.org/40480214:42
silehtoups I have missed a file14:42
*** mtanino has joined #openstack-oslo14:43
openstackgerritGevorg Davoian proposed openstack/oslo.messaging: [zmq] Support message versions for rolling upgrades  https://review.openstack.org/39051714:44
*** jpena|lunch is now known as jpena14:44
*** spzala has joined #openstack-oslo14:50
kgiustisileht: 'test_fafka.py'  fafka - I like that!14:53
silehtkgiusti, I have just split the existing one to not run functional kafka tests on rabbit job :)14:53
jeckersbfafka sounds like it should be a drink... like fanta14:54
gcb:)14:55
*** mriedem has joined #openstack-oslo14:56
silehtOn my side, I see 'Kafta'14:56
openstackgerritMehdi Abaakouk (sileht) proposed openstack/oslo.messaging: kafka separate unit/functionnal tests  https://review.openstack.org/40480214:57
silehtkgiusti, I have renamed it14:57
kgiustisileht: np - but I think the testenv you added into tox.ini is misnamed (should be -kafka, not -pika) - is that correct?14:58
openstackgerritMehdi Abaakouk (sileht) proposed openstack/oslo.messaging: kafka separate unit/functionnal tests  https://review.openstack.org/40480214:58
silehtkgiusti, thx (I have copy/paste)14:59
kgiusti:D - been there many times myself14:59
*** Rockyg has joined #openstack-oslo14:59
silehtkgiusti, I wonder if someone use this driver15:00
*** yamamoto has quit IRC15:00
silehtkgiusti, the code comes from 1 commit the 01/12/201515:00
silehtand still no functional tests in gate15:01
kgiustisileht: yeah - perhaps it should be deprecated in pike?  See if anyone steps forward to own it?15:01
silehtkgiusti, I will send a mail on the ML for this15:02
silehtkgiusti, it still use the old/deprecated python-kafka api15:02
openstackgerritOleksii Zamiatin proposed openstack/oslo.messaging: [zmq] Fix non voting gate jobs  https://review.openstack.org/40481515:04
kgiustisileht: mmm... that doesn't look good.15:04
*** shardy has joined #openstack-oslo15:05
*** yamamoto has joined #openstack-oslo15:06
amrithhi guys ... https://review.openstack.org/#/c/404783/115:07
amrithbefore you approve the change, please see my comment there.15:07
amrithsileht, kgiusti15:07
amrith^^15:08
kgiustiamrith: kk15:08
amrithkgiusti, thx15:08
ozamiatinkgiusti: hi, i've read yesterday conversation today sorry ...15:09
kgiustiozamiatin: np dude :O15:10
kgiusti:)15:10
ozamiatinkgiusti: this patch is going to fix those failing jobs ... will see :)  https://review.openstack.org/40481515:10
kgiustidansmith: ozamiatin to the rescue!15:13
*** lei-zh has quit IRC15:13
dansmithwoot15:13
*** oanson has joined #openstack-oslo15:13
*** stevemar__ has quit IRC15:18
*** stevemar__ has joined #openstack-oslo15:19
*** eezhova has quit IRC15:19
*** jeckersb is now known as jeckersb_gone15:25
*** pradk has joined #openstack-oslo15:27
openstackgerritMehdi Abaakouk (sileht) proposed openstack/oslo.messaging: kafka separate unit/functionnal tests  https://review.openstack.org/40480215:27
*** jeckersb_gone is now known as jeckersb15:28
openstackgerritMerged openstack/oslo.messaging: [zmq] Fix zmq-specific f-tests from periodic hangs  https://review.openstack.org/40275315:31
amrithkgiusti, any thoughts on https://review.openstack.org/#/c/404783/ ?15:32
amrithsileht, ^^15:33
kgiustiamrith: yeah - I was going to follow up on the review.  But discussing it here is fine too.15:33
*** gordc has joined #openstack-oslo15:33
*** pblaho has quit IRC15:34
amriththx kgiusti I ask because I'm midway through reviewing a change in trove about specifying the transport URL15:34
kgiustiamrith: you're correct - the hostname: no-port is technically invalid according to all the amqp related tech I've seen (rabbitmq qpid stuff, activemq)15:34
amrithand wanted to reflect what we discuss here.15:34
amrithkgiusti, I'll go further and say a : with no port number is invalid as a generic URI15:34
amrithirrespective of the smaller domain of amqp.15:34
*** pblaho has joined #openstack-oslo15:34
amrithit would be invalid for http, gopher, telnet, ...15:34
kgiustiamrith: so flagging it as illegal is perfectly reasonable15:35
kgiustiamrith: true that15:35
silehtamrith, I just mimic urlparse.urlparse I haven't checked the RFC15:35
kgiustiamrith: ..but... (there's always a but) should we still allow it and assume the default port of 5672?15:35
kgiustiamrith: IOW: be liberal in what we accept?15:36
amrithkgiusti, I would not15:36
amrithif you want to assume port 5672, don't put a :15:36
amrithso, amqp://hostname.domain.org/ should be analogous to amqp://hostname.domain.org:5672/15:37
amriththat is what https://tools.ietf.org/html/rfc3986.html#section-3.2.3 says15:37
kgiustiamrith: which it is - no argument there.15:37
amrithI note that they state "URI producers and15:37
amrith   normalizers should omit the port component and its ":" delimiter if15:37
amrith   port is empty or if its value would be the same as that of the15:37
amrith   scheme's default."15:37
kgiustiamrith: so, from the 'being liberal' argument POV let me ask - what is the harm in assuming ':' with no port == port 5672 implied?15:39
amrithbeing liberal with a specification leads to incompatibilities15:39
amrithespecially when there is a mechanism to specify a default already.15:40
*** syjulian has joined #openstack-oslo15:40
amrithjust like a programming language (grammar) saying they'll be liberal about things.15:40
*** gcb has quit IRC15:40
amrithlet me ask the other way; what about allowing a "," there instead of only a :15:40
amrithbe liberal about that too, after all / is the path delimiter15:41
amrithso why not accept amqp://hostname.domain.org,5671/15:41
amrithit is unambiguous (today)15:41
amritha ',' can't be used in a fqdn15:41
amrithso let's do that too :)15:41
amrithand to respond to sileht what you are doing is NOT the same as urlparse.urlparse. See: https://gist.github.com/anonymous/8504f160ff90649890b5a2a82f8028b015:43
amrithit is not throwing an error, but it is treating the : as part of the hostname15:43
kgiustiamrith: hey - you just reminded me: our transport url parser allows for 'amqp://hostport[,hostport]*/...'15:43
amrithwhat you are doing is silently dropping the :15:43
kgiustiamrith: which IIRC is completely illegal also :D15:43
amrithkgiusti, I didn't make the example up ... I know we do that.15:43
amrithand I hate it15:44
amrithbecause now all projects have to support these extensions15:44
silehtamrith, please, port is None that why you don't see it...15:46
silehtamrith, currently we raise ValueError, while urlparse ignore the ':'15:46
amrithand sileht the : remains in the URI15:46
amrithit does NOT ignore the :15:46
amrithit respects it and leaves it in the host identifier15:46
silehtamrith, it's not host its netloc ...15:47
amrithanyway, y'all do what you wish; i'll just observe that what you are doing isn't what the RFC says. yes it is sileht see the gist I posted.15:47
therveamrith, Not it's netloc, not hostname15:48
silehtamrith, so urlparse is not RFC compliant ...15:48
silehtamrith, __repr__ doesn't means anything this is a object text represention ...15:48
amrithsileht, therve that doesn't make it right. but as I said, y'all do what you wish.15:49
*** yamamoto has quit IRC15:49
thervekgiusti, At any rate, if you could fix the devstack plugin so that it specified the port, that'd be great :)15:53
kgiustitherve: oh - the amqp1 plugin?15:54
thervekgiusti, Yeah introduced by https://review.openstack.org/#/c/399166/15:54
thervekgiusti, $port is not always specified, which led to the patch we're talking about15:55
kgiustitherve: GAH!15:55
kgiustitherve: <expletive> - yes I'll fix that immediately - so sorry I missed that.15:56
thervekgiusti, No problem. My gate is non-voting for now :D15:56
kgiustiansmith: ^^^15:57
kgiustiansmith: I'm going to take that one15:57
*** rcernin has quit IRC16:02
*** code-R has quit IRC16:02
*** edmondsw has quit IRC16:02
*** yamamoto has joined #openstack-oslo16:06
kgiustisileht: I didn't realize that patch was to get around a bug in the plugin.16:08
silehtkgiusti, you show up a real bug16:09
kgiustisileht: not intentional by any means :)16:09
openstackgerritMerged openstack/oslo.messaging: Remove small job timeout  https://review.openstack.org/40461516:12
openstackgerritKen Giusti proposed openstack/devstack-plugin-amqp1: Use 5672 as the default port if none specified  https://review.openstack.org/40485416:13
*** ihrachys has quit IRC16:14
*** yamahata has joined #openstack-oslo16:26
*** miqui has joined #openstack-oslo16:26
*** code-R has joined #openstack-oslo16:27
openstackgerritGevorg Davoian proposed openstack/oslo.messaging: [zmq] Support message versions for rolling upgrades  https://review.openstack.org/39051716:30
hayporasca: thierry wrote "We could also use Joshua's +1 on it as PTL/releaseman"16:30
hayporasca: releases require a +1 from the PTL16:31
*** code-R has quit IRC16:35
openstackgerritHenry Gessau proposed openstack/oslo.tools: electrocucaracha is the new liaison for Neutron  https://review.openstack.org/40486616:41
rascahaypo, ok, so we depend here from harlowja, understood.16:52
*** dimtruck is now known as zz_dimtruck17:01
*** e0ne has quit IRC17:03
*** code-R has joined #openstack-oslo17:06
*** zz_dimtruck is now known as dimtruck17:10
*** nkrinner is now known as nkrinner_afk17:13
*** yamamoto has quit IRC17:14
*** yamamoto has joined #openstack-oslo17:15
*** yamamoto has quit IRC17:17
*** code-R has quit IRC17:17
*** yamamoto has joined #openstack-oslo17:18
*** pcaruana has quit IRC17:23
*** code-R has joined #openstack-oslo17:25
*** spzala has quit IRC17:25
*** tongli has quit IRC17:30
*** yamamoto has quit IRC17:34
*** shardy has quit IRC17:35
*** yamamoto has joined #openstack-oslo17:46
*** lucasagomes is now known as lucas-afk17:48
*** yamamoto has quit IRC17:51
*** dimtruck is now known as zz_dimtruck17:51
*** yamahata has quit IRC17:51
openstackgerritMerged openstack/tooz: coordination: make get_members() return a set  https://review.openstack.org/39835117:54
*** mriedem1 has joined #openstack-oslo17:54
*** mriedem has quit IRC17:56
*** mriedem1 is now known as mriedem17:59
*** spzala has joined #openstack-oslo17:59
*** spzala has quit IRC18:03
harlowjarasca whats up18:08
openstackgerritint32bit proposed openstack/oslo.db: Check if an index on given columns exists.  https://review.openstack.org/40212818:08
*** zz_dimtruck is now known as dimtruck18:10
*** eezhova has joined #openstack-oslo18:13
dansmithharlowja: this seems to fix the thing that is blocking my thing from becoming a real thing: https://review.openstack.org/#/c/404815/18:15
dansmithi can haz?18:15
harlowjasureee18:15
*** ihrachys has joined #openstack-oslo18:15
harlowjais redhat going more with zeromq now-a-days :-P18:16
dansmithno, I just can't land my thing because the job is broken18:16
harlowjakk18:16
*** mriedem has quit IRC18:27
*** e0ne has joined #openstack-oslo18:27
*** mriedem has joined #openstack-oslo18:30
*** ihrachys has quit IRC18:31
*** snikitin_ has joined #openstack-oslo18:33
*** yamahata has joined #openstack-oslo18:34
snikitin_harlowja: Hi! yesterday this patch https://review.openstack.org/#/c/404357/ was merged in oslo.policy. It improves the performance of Nova unit tests almost in 2 times and it will be very useful for nova team to get it. So I wanted to ask when new oslo.policy release is expected?18:34
harlowja today :)18:35
snikitin_great!18:35
*** oanson has quit IRC18:36
*** jpena is now known as jpena|off18:37
*** spzala has joined #openstack-oslo18:43
*** mhickey has quit IRC18:46
*** dharinic is now known as dharinic|lunch18:47
*** spzala has quit IRC18:47
*** amoralej is now known as amoralej|off18:47
*** spzala has joined #openstack-oslo18:47
openstackgerritMerged openstack/tooz: Factorize group quit on stop()  https://review.openstack.org/39916018:48
*** eezhova has quit IRC18:55
*** eezhova has joined #openstack-oslo19:01
zzzeekdims / harlowja : any +2's for https://review.openstack.org/#/c/404443/ https://review.openstack.org/#/c/404453/ , these have to be in before next oslo.db release19:05
kgiustiansmith: I've opened https://bugs.launchpad.net/oslo.messaging/+bug/1646208 to track the changes to the amqp1 plugin19:06
openstackLaunchpad bug 1646208 in oslo.messaging "[AMQP 1.0] amqp1 devstack plugin should set the transport url using env variables" [Undecided,New]19:06
ansmithkgiusti: taking it...19:07
kgiustiansmith: you da man.19:08
harlowjazzzeek will do19:09
dimszzzeek : ack will look in a little bit19:12
stevemar__harlowja, always giving the people what they want!19:18
harlowja:-p19:18
harlowjaslowly but surely19:18
harlowjalol19:18
*** snikitin_ has quit IRC19:25
*** eezhova has quit IRC19:26
*** SpamapS has quit IRC19:26
*** dharinic|lunch is now known as dharinic19:28
*** mkoderer has quit IRC19:33
*** SpamapS has joined #openstack-oslo19:42
openstackgerritMerged openstack/devstack-plugin-amqp1: Use 5672 as the default port if none specified  https://review.openstack.org/40485419:42
*** eezhova has joined #openstack-oslo20:13
*** lpetrut has joined #openstack-oslo20:14
*** ihrachys has joined #openstack-oslo20:15
*** Guest62009 has quit IRC20:22
*** browne has joined #openstack-oslo20:31
*** rcernin has joined #openstack-oslo20:37
dansmithkgiusti: hah, that fix failed zmq also20:39
dansmithwould sure love to land my bugfix :/20:39
kgiustidansmith: yeah.  grrrr :)20:39
*** gangil has joined #openstack-oslo20:43
*** dtardivel has quit IRC20:44
*** spzala has quit IRC20:54
*** rajathagasthya has joined #openstack-oslo20:59
*** dimtruck is now known as zz_dimtruck21:09
*** rtheis has quit IRC21:10
*** zz_dimtruck is now known as dimtruck21:14
*** ihrachys has quit IRC21:16
*** amoralej|off is now known as amoralej21:21
*** e0ne has quit IRC21:22
*** e0ne has joined #openstack-oslo21:23
*** e0ne has quit IRC21:24
*** e0ne has joined #openstack-oslo21:24
*** e0ne has quit IRC21:24
*** e0ne has joined #openstack-oslo21:25
*** e0ne has quit IRC21:25
*** e0ne has joined #openstack-oslo21:25
*** e0ne has quit IRC21:26
*** e0ne has joined #openstack-oslo21:26
*** e0ne has quit IRC21:27
*** e0ne has joined #openstack-oslo21:27
*** e0ne has quit IRC21:27
*** e0ne has joined #openstack-oslo21:28
*** e0ne has quit IRC21:28
*** e0ne has joined #openstack-oslo21:29
*** e0ne has quit IRC21:29
*** ansmith has quit IRC21:46
*** kgiusti has quit IRC21:49
openstackgerritJiaJunsu proposed openstack/oslo.middleware: Filter X-Auth-Token in catch_errors  https://review.openstack.org/40498022:00
*** lpetrut has quit IRC22:01
*** rajathagasthya has quit IRC22:09
*** dimtruck is now known as zz_dimtruck22:11
*** pblaho` has joined #openstack-oslo22:14
*** pblaho has quit IRC22:16
rascaharlowja, you still there?22:19
rascaharlowja, I just made a package request and would like to know if we can move on from there22:19
openstackgerritMerged openstack/oslo.db: Don't run LegacyBaseClass provision test for unavailable database  https://review.openstack.org/40444322:19
openstackgerritMerged openstack/oslo.db: Ensure provision_new_database is True by default  https://review.openstack.org/40445322:19
*** rasca has quit IRC22:20
*** amoralej is now known as amoralej|off22:22
*** jeckersb is now known as jeckersb_gone22:31
*** code-R_ has joined #openstack-oslo22:33
*** code-R has quit IRC22:33
*** mriedem has quit IRC22:39
*** mnaser has quit IRC22:41
*** mnaser has joined #openstack-oslo22:50
*** eezhova has quit IRC22:54
*** browne has quit IRC23:04
*** boden has quit IRC23:06
*** gordc has quit IRC23:13
openstackgerritOpenStack Proposal Bot proposed openstack/tooz: Updated from global requirements  https://review.openstack.org/34678223:16
*** spzala has joined #openstack-oslo23:21
*** szaher has quit IRC23:25
*** spzala has quit IRC23:26
*** rcernin has quit IRC23:26
*** szaher has joined #openstack-oslo23:28
*** spzala has joined #openstack-oslo23:36
*** sdague has quit IRC23:38
*** pradk has quit IRC23:43
harlowjarelease wave starting!23:52
harlowjabegin release waveeee23:52
*** mriedem has joined #openstack-oslo23:54

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!