| *** rcernin has quit IRC | 00:42 | |
| *** tovin07 has joined #openstack-oslo | 00:48 | |
| *** tovin07_ has joined #openstack-oslo | 00:49 | |
| *** tovin07 has quit IRC | 01:04 | |
| *** gus has quit IRC | 01:07 | |
| *** gus has joined #openstack-oslo | 01:11 | |
| *** gus has quit IRC | 01:16 | |
| *** gus has joined #openstack-oslo | 01:17 | |
| *** tovin07 has joined #openstack-oslo | 01:17 | |
| *** jamielennox is now known as jamielennox|away | 01:26 | |
| *** hieulq has joined #openstack-oslo | 01:44 | |
| openstackgerrit | gecong proposed openstack/osprofiler: Replace six.iteritems() with .items() https://review.openstack.org/403468 | 01:52 |
|---|---|---|
| *** chenying_ has joined #openstack-oslo | 01:56 | |
| *** tovin07_ has quit IRC | 02:05 | |
| *** tovin07_ has joined #openstack-oslo | 02:08 | |
| *** jamielennox|away is now known as jamielennox | 02:15 | |
| *** zhangguoqing has joined #openstack-oslo | 02:16 | |
| *** gcb has joined #openstack-oslo | 02:23 | |
| openstackgerrit | gecong proposed openstack/automaton: Replace six.iteritems() with .items() https://review.openstack.org/403480 | 02:24 |
| openstackgerrit | Cao Xuan Hoang proposed openstack/tooz: Changed author and author-email https://review.openstack.org/403488 | 03:08 |
| *** yamamoto_ has joined #openstack-oslo | 04:05 | |
| *** code-R has quit IRC | 04:09 | |
| *** code-R has joined #openstack-oslo | 04:09 | |
| *** links has joined #openstack-oslo | 04:13 | |
| *** code-R has quit IRC | 04:21 | |
| *** code-R has joined #openstack-oslo | 04:21 | |
| *** jeckersb_gone is now known as jeckersb | 04:36 | |
| *** code-R has quit IRC | 04:41 | |
| openstackgerrit | Cao Xuan Hoang proposed openstack/mox3: Replace 'assertTrue(a (not)in b)' with 'assert(Not)In(a, b)' https://review.openstack.org/403498 | 04:43 |
| openstackgerrit | Cao Xuan Hoang proposed openstack/tooz: Replace 'assertTrue(a (not)in b)' with 'assert(Not)In(a, b)' https://review.openstack.org/403500 | 04:54 |
| *** dkehn has quit IRC | 04:58 | |
| *** dkehn has joined #openstack-oslo | 04:58 | |
| *** code-R has joined #openstack-oslo | 06:00 | |
| *** lpetrut has joined #openstack-oslo | 06:25 | |
| openstackgerrit | Cao Xuan Hoang proposed openstack/stevedore: Add Apache 2.0 license to source file https://review.openstack.org/403517 | 06:34 |
| openstackgerrit | Cao Xuan Hoang proposed openstack/oslo.tools: Add Apache 2.0 license to source file https://review.openstack.org/403519 | 06:39 |
| openstackgerrit | Cao Xuan Hoang proposed openstack/oslo.vmware: Files with no code must be left completely empty https://review.openstack.org/403521 | 06:44 |
| *** code-R_ has joined #openstack-oslo | 06:49 | |
| *** code-R has quit IRC | 06:52 | |
| *** nkrinner_afk is now known as nkrinner | 06:59 | |
| *** yamamoto_ has quit IRC | 07:11 | |
| *** dtardivel has joined #openstack-oslo | 07:14 | |
| *** code-R_ has quit IRC | 07:20 | |
| *** e0ne has joined #openstack-oslo | 07:26 | |
| *** lpetrut has quit IRC | 07:34 | |
| *** code-R has joined #openstack-oslo | 07:35 | |
| *** e0ne has quit IRC | 07:40 | |
| *** rcernin has joined #openstack-oslo | 07:44 | |
| *** pcaruana has joined #openstack-oslo | 07:45 | |
| *** e0ne has joined #openstack-oslo | 07:48 | |
| *** yamamoto_ has joined #openstack-oslo | 07:55 | |
| *** code-R_ has joined #openstack-oslo | 07:57 | |
| *** code-R has quit IRC | 07:59 | |
| *** shardy has joined #openstack-oslo | 08:11 | |
| *** e0ne has quit IRC | 08:14 | |
| *** eezhova has joined #openstack-oslo | 08:14 | |
| openstackgerrit | Merged openstack/oslo.vmware: Add SPBM WSDL for vSphere 6.5 https://review.openstack.org/402559 | 08:15 |
| *** ihrachys has joined #openstack-oslo | 08:22 | |
| *** code-R_ has quit IRC | 08:30 | |
| *** code-R has joined #openstack-oslo | 08:34 | |
| *** bauwser is now known as bauzas | 08:47 | |
| *** amoralej|off is now known as amoralej | 08:52 | |
| *** zzzeek has quit IRC | 09:00 | |
| *** code-R has quit IRC | 09:00 | |
| *** lpetrut has joined #openstack-oslo | 09:01 | |
| *** zzzeek has joined #openstack-oslo | 09:01 | |
| openstackgerrit | gecong proposed openstack/oslo.versionedobjects: Fix a typo https://review.openstack.org/403567 | 09:02 |
| *** eezhova has quit IRC | 09:03 | |
| *** e0ne has joined #openstack-oslo | 09:10 | |
| *** lucas-afk is now known as lucasagomes | 09:27 | |
| *** yassine has joined #openstack-oslo | 09:30 | |
| *** yassine is now known as Guest89691 | 09:31 | |
| openstackgerrit | Tovin Seven proposed openstack/osprofiler: Re-format html template https://review.openstack.org/403592 | 09:35 |
| openstackgerrit | Tovin Seven proposed openstack/osprofiler: Fix syntax in JS, json indent with 4 spaces https://review.openstack.org/403593 | 09:35 |
| *** pblaho has joined #openstack-oslo | 09:38 | |
| *** eezhova has joined #openstack-oslo | 09:39 | |
| *** ihrachys has quit IRC | 09:42 | |
| *** code-R has joined #openstack-oslo | 09:55 | |
| *** code-R_ has joined #openstack-oslo | 09:57 | |
| *** code-R has quit IRC | 10:00 | |
| *** cdent has joined #openstack-oslo | 10:00 | |
| *** stevemar has quit IRC | 10:19 | |
| *** ihrachys has joined #openstack-oslo | 10:43 | |
| *** jpena|off is now known as jpena | 10:44 | |
| openstackgerrit | Tovin Seven proposed openstack/osprofiler: Fix syntax in JS, json indent with 4 spaces https://review.openstack.org/403593 | 10:50 |
| *** tovin07_ has quit IRC | 10:50 | |
| openstackgerrit | Tovin Seven proposed openstack/osprofiler: Re-format html template https://review.openstack.org/403592 | 10:51 |
| openstackgerrit | Tovin Seven proposed openstack/osprofiler: Fix syntax in JS, json indent with 4 spaces https://review.openstack.org/403593 | 10:52 |
| *** kragniz has quit IRC | 10:54 | |
| *** kragniz has joined #openstack-oslo | 10:54 | |
| *** ozamiatin_ has joined #openstack-oslo | 11:05 | |
| openstackgerrit | Roman Podoliaka proposed openstack/oslo.db: SoftDeleteMixin: coerce deleted param to be an integer https://review.openstack.org/403631 | 11:24 |
| *** nicolasbock has joined #openstack-oslo | 11:45 | |
| *** rtheis has joined #openstack-oslo | 11:56 | |
| *** code-R_ has quit IRC | 11:59 | |
| *** code-R has joined #openstack-oslo | 12:04 | |
| *** pblaho has quit IRC | 12:04 | |
| *** pblaho has joined #openstack-oslo | 12:05 | |
| *** kzaitsev_ws has quit IRC | 12:10 | |
| *** ozamiatin_ has quit IRC | 12:17 | |
| *** bauzas has quit IRC | 12:34 | |
| openstackgerrit | Merged openstack/oslo.tools: Add Apache 2.0 license to source file https://review.openstack.org/403519 | 12:35 |
| *** bauzas has joined #openstack-oslo | 12:39 | |
| *** pblaho has quit IRC | 12:39 | |
| *** lucasagomes is now known as lucas-hungry | 12:44 | |
| *** amoralej is now known as amoralej|off | 12:46 | |
| *** amoralej|off is now known as amoralej|lunch | 12:46 | |
| *** yamamoto_ has quit IRC | 12:47 | |
| *** gcb has quit IRC | 12:56 | |
| *** pradk has joined #openstack-oslo | 13:00 | |
| *** boden has joined #openstack-oslo | 13:01 | |
| *** pblaho has joined #openstack-oslo | 13:04 | |
| *** kgiusti has joined #openstack-oslo | 13:17 | |
| *** code-R_ has joined #openstack-oslo | 13:20 | |
| *** code-R has quit IRC | 13:23 | |
| *** dims has quit IRC | 13:33 | |
| *** yamamoto has joined #openstack-oslo | 13:33 | |
| openstackgerrit | Omer Anson proposed openstack/oslo.utils: Move wait_until_true to oslo.utils https://review.openstack.org/401126 | 13:36 |
| *** oanson has joined #openstack-oslo | 13:36 | |
| openstackgerrit | Merged openstack/tooz: Changed author and author-email https://review.openstack.org/403488 | 13:40 |
| *** jpena is now known as jpena|lunch | 13:40 | |
| *** tovin07_ has joined #openstack-oslo | 13:42 | |
| openstackgerrit | Julien Danjou proposed openstack/oslo.middleware: Suggest to use egg based filter_factory rather than fragile full path https://review.openstack.org/403705 | 13:44 |
| openstackgerrit | Omer Anson proposed openstack/oslo.utils: Move wait_until_true to oslo.utils https://review.openstack.org/401126 | 13:44 |
| *** dims has joined #openstack-oslo | 13:44 | |
| *** stevemar__ has joined #openstack-oslo | 13:47 | |
| *** amoralej|lunch is now known as amoralej | 13:50 | |
| *** lucas-hungry is now known as lucasagomes | 13:55 | |
| *** mhickey has joined #openstack-oslo | 13:59 | |
| *** jdandrea has joined #openstack-oslo | 14:03 | |
| *** oanson has quit IRC | 14:04 | |
| *** links has quit IRC | 14:04 | |
| *** yamamoto has quit IRC | 14:12 | |
| *** lpetrut has quit IRC | 14:13 | |
| *** jdandrea has quit IRC | 14:16 | |
| *** lpetrut has joined #openstack-oslo | 14:17 | |
| *** mriedem has joined #openstack-oslo | 14:27 | |
| *** rcernin has quit IRC | 14:27 | |
| *** openstackstatus has quit IRC | 14:28 | |
| *** yamamoto has joined #openstack-oslo | 14:29 | |
| *** pblaho has quit IRC | 14:29 | |
| *** openstackstatus has joined #openstack-oslo | 14:29 | |
| *** ChanServ sets mode: +v openstackstatus | 14:29 | |
| *** yamamoto has quit IRC | 14:31 | |
| openstackgerrit | Tovin Seven proposed openstack/osprofiler: Fix syntax in JS, JSON indent with 4 spaces https://review.openstack.org/403593 | 14:34 |
| *** rcernin has joined #openstack-oslo | 14:36 | |
| openstackgerrit | Julien Danjou proposed openstack/oslo.middleware: Transform healthcheck from filter to an application https://review.openstack.org/403734 | 14:36 |
| *** jdandrea has joined #openstack-oslo | 14:43 | |
| openstackgerrit | Merged openstack/oslo.config: Add 'summarize' option https://review.openstack.org/328229 | 14:46 |
| openstackgerrit | Merged openstack/oslo.reports: Fix a typo https://review.openstack.org/400009 | 14:47 |
| openstackgerrit | Merged openstack/oslo.vmware: Add 'uncommitted' field to the 'Datastore' class https://review.openstack.org/402601 | 14:47 |
| openstackgerrit | Merged openstack/oslo.policy: Remove wrong parameter type for class NotCheck from docstring https://review.openstack.org/388656 | 14:48 |
| *** jpena|lunch is now known as jpena | 14:51 | |
| *** gcb has joined #openstack-oslo | 14:53 | |
| *** oanson has joined #openstack-oslo | 14:58 | |
| oanson | jd__, sileht, hi. Are you in? | 15:00 |
| jd__ | hi oanson | 15:00 |
| oanson | I would be happy for a chance to defend https://review.openstack.org/#/c/401126/ | 15:00 |
| oanson | I understand the issue with tenacity, and I have also tried a tenacity-based implementation. | 15:01 |
| oanson | I feel wait_until_true offers a simple API for a simple task, whereas tenacity offers a very flexible and versatile API, but more complex | 15:01 |
| oanson | Additionally, the wait_until_true API is used in openstack, e.g. in neutron, dragonflow, and karbor | 15:02 |
| oanson | jd__, ping | 15:07 |
| jd__ | oanson: that's a terrible defense :/ | 15:07 |
| oanson | Very possible | 15:08 |
| jd__ | this code is using multi-threading for *no good reason* | 15:08 |
| oanson | That's what I have. And I rewrote it. It no longer uses multi-threading | 15:08 |
| oanson | PS2 uses tenacity. PS3 uses a loop with sleep and stopwatch | 15:08 |
| jd__ | ah you didnot set any message in the review so I just reput -2 to not lose the -1 | 15:09 |
| jd__ | oh | 15:09 |
| jd__ | you really had to put a message then :) | 15:09 |
| *** yamamoto has joined #openstack-oslo | 15:10 | |
| oanson | Sorry :) I discussed this here with sileht, and figured the change in PS would be noticeable | 15:10 |
| openstackgerrit | Alexis Lee proposed openstack/oslo.config: List comprehensions https://review.openstack.org/400751 | 15:10 |
| jd__ | yeah PS2 and PS3 are less scary thanks | 15:10 |
| openstackgerrit | Alexis Lee proposed openstack/oslo.config: Add defaults for config-dir https://review.openstack.org/400667 | 15:10 |
| jd__ | but PS2 just proves that you could use tenacity directly in the end, if you move the code from Neutron whatever to it, so I really don't think it's worth adding one more layer in oslo.utils | 15:10 |
| jd__ | there's no good technical reason to have that | 15:11 |
| oanson | Mostly I want to maintain the API. | 15:11 |
| jd__ | it's an internal API, you don't have to | 15:11 |
| oanson | I also think using tenacity directly will be a bit awkward, seeing as how PS2 came out | 15:11 |
| jd__ | or wrap tenacity inside Neutron if you want… | 15:11 |
| jd__ | oanson: rewrite the code properly :( | 15:12 |
| jd__ | (i mean the neutron code using it) | 15:12 |
| oanson | jd__, I started with that. Neutron said I should try here first | 15:12 |
| jd__ | oanson: you have a patch URL? | 15:12 |
| oanson | Yes. | 15:12 |
| oanson | https://review.openstack.org/#/c/398405/ | 15:12 |
| oanson | I will update the implementation to PS3 if I continue in that direction | 15:13 |
| openstackgerrit | Merged openstack/oslo.db: SoftDeleteMixin: coerce deleted param to be an integer https://review.openstack.org/403631 | 15:13 |
| openstackgerrit | Merged openstack/oslo.vmware: Show team and repo badges on README https://review.openstack.org/402471 | 15:13 |
| jd__ | ok that's not the kind of patch I was expecting but I understand | 15:13 |
| jd__ | that makes sense | 15:14 |
| jd__ | like Armando said "if you want this into a library and available to all OpenStack projects, a much more suitable library is something like oslo.utils." | 15:14 |
| jd__ | well, it's already in tenacity, so just go use it | 15:14 |
| oanson | But for tenacity I have to rewrite the wrapper for every use case. | 15:15 |
| oanson | That's where the helper function comes in. | 15:15 |
| oanson | In some cases it's simple lambdas and existing functions to which I have to recreate the code in PS2 | 15:15 |
| jd__ | if Neutron wants a 2 lines wrapper around tenacity it can have it somewhere in it's code I guess | 15:15 |
| jd__ | we have that in Gnocchi for example: https://github.com/openstack/gnocchi/blob/master/gnocchi/utils.py#L63-L65 | 15:16 |
| jd__ | and we have that in various places where we want to retry things | 15:16 |
| oanson | This is not a retry. This is a method that waits until a function returns bool(True) | 15:17 |
| *** jlvill-travel is now known as jlvillal | 15:17 | |
| oanson | And the code is reusable. There is not reason to re-implement it 5 times in 5 different projects | 15:18 |
| jd__ | so… it retries until a function returns True right? :) | 15:18 |
| oanson | Yes. And exits after a timeout | 15:18 |
| oanson | It can be done with tenacity. PS2 proves that. I just think this API is simpler, and since it is used in multiple places, it has merit | 15:19 |
| jd__ | oanson: just do that in neutron-lib then, that PS2 | 15:20 |
| jd__ | that's cool with me | 15:20 |
| oanson | All right. I'll take it up with them. | 15:21 |
| jd__ | cool | 15:21 |
| oanson | Thanks for your time | 15:22 |
| *** bknudson has joined #openstack-oslo | 15:23 | |
| openstackgerrit | Jim Rollenhagen proposed openstack-dev/cookiecutter: Sync with global-requirements https://review.openstack.org/399543 | 15:24 |
| jroll | gcb: ^ squashed, thanks for review | 15:24 |
| openstackgerrit | Merged openstack/tooz: Replace 'assertTrue(a (not)in b)' with 'assert(Not)In(a, b)' https://review.openstack.org/403500 | 15:25 |
| gcb | jroll: nice work! | 15:25 |
| jroll | gcb: thanks, don't forget about the launchpad_project change also in that chain :) | 15:25 |
| gcb | jroll, will check that now :-) | 15:26 |
| rpodolyaka | zzzeek: good point on NULL - I totally missed that one :( | 15:35 |
| rpodolyaka | zzzeek: I replied to the comment on naming - https://review.openstack.org/#/c/403631/ - I'd rather we leave the name as is | 15:35 |
| rpodolyaka | as we want to allow for passing of non-boolean values (arbitrary positive integers) | 15:35 |
| zzzeek | rpodolyaka: oh ok you want other ints, OK | 15:36 |
| *** dims has quit IRC | 15:36 | |
| *** bnemec has joined #openstack-oslo | 15:37 | |
| rpodolyaka | I'll add a test case with None and upload a fixup | 15:37 |
| zzzeek | rpodolyaka: oooh right the thing where deleted is some kind of id number, i remember, maybe comment on that (if there wasn't one already) | 15:37 |
| rpodolyaka | zzzeek: yeah, I only mentioned it in the commit message. I'll add the comment to the mixin class itself | 15:38 |
| zzzeek | k | 15:38 |
| rpodolyaka | as I was struggling to remember why we have this weird logic with ints in the first place when snikitin asked me about it on the other day :D | 15:39 |
| *** gordc has joined #openstack-oslo | 15:39 | |
| *** dims has joined #openstack-oslo | 15:41 | |
| *** mtanino has joined #openstack-oslo | 15:42 | |
| *** mtanino has quit IRC | 15:46 | |
| *** yamamoto has quit IRC | 15:47 | |
| *** mtanino has joined #openstack-oslo | 15:50 | |
| *** code-R_ has quit IRC | 15:51 | |
| *** harlowja_at_home has joined #openstack-oslo | 15:51 | |
| *** dtardivel has quit IRC | 15:54 | |
| *** yamahata has joined #openstack-oslo | 15:56 | |
| toabctl | lxsli, hey. is your +2 still valid for https://review.openstack.org/#/c/400667 ? | 15:56 |
| *** kgiusti has quit IRC | 16:01 | |
| *** hieulq has quit IRC | 16:01 | |
| *** tovin07 has quit IRC | 16:01 | |
| *** sheeprine has quit IRC | 16:01 | |
| *** david-lyle has quit IRC | 16:01 | |
| *** HenryG has quit IRC | 16:01 | |
| *** purplerbot has quit IRC | 16:01 | |
| *** andreaf has quit IRC | 16:01 | |
| *** tbarron has quit IRC | 16:01 | |
| *** zigo has quit IRC | 16:01 | |
| *** rm_work has quit IRC | 16:01 | |
| *** dstufft has quit IRC | 16:01 | |
| *** tovin07_ is now known as tovin07 | 16:01 | |
| *** dstufft has joined #openstack-oslo | 16:01 | |
| *** zigo has joined #openstack-oslo | 16:01 | |
| *** sheeprine has joined #openstack-oslo | 16:01 | |
| lxsli | toabctl: I'll have a look when it's out of WIP | 16:02 |
| *** tbarron has joined #openstack-oslo | 16:02 | |
| *** tovin07_ has joined #openstack-oslo | 16:02 | |
| *** kgiusti has joined #openstack-oslo | 16:02 | |
| *** hieulq has joined #openstack-oslo | 16:02 | |
| toabctl | lxsli, it is not wip | 16:02 |
| *** david-lyle has joined #openstack-oslo | 16:02 | |
| toabctl | not sure why it was marked as wip | 16:02 |
| *** rm_work has joined #openstack-oslo | 16:02 | |
| *** ansmith has joined #openstack-oslo | 16:02 | |
| *** HenryG has joined #openstack-oslo | 16:02 | |
| lxsli | let's see what doug says | 16:03 |
| *** purplerbot has joined #openstack-oslo | 16:03 | |
| openstackgerrit | Merged openstack/oslo.messaging: [zmq] Fix functional gates proxy/pub-sub https://review.openstack.org/402733 | 16:04 |
| openstackgerrit | Merged openstack/oslo.messaging: [zmq] Send fanouts without pub/sub in background https://review.openstack.org/391933 | 16:05 |
| *** shardy has quit IRC | 16:10 | |
| *** andreaf has joined #openstack-oslo | 16:12 | |
| openstackgerrit | Julien Danjou proposed openstack/oslo.middleware: Transform healthcheck from filter to an application https://review.openstack.org/403734 | 16:15 |
| *** pblaho has joined #openstack-oslo | 16:16 | |
| openstackgerrit | Julien Danjou proposed openstack/tooz: zookeeper: switch to standard group membership watching https://review.openstack.org/399162 | 16:17 |
| openstackgerrit | Julien Danjou proposed openstack/tooz: coordination: make get_members() return a set https://review.openstack.org/398351 | 16:17 |
| openstackgerrit | Julien Danjou proposed openstack/tooz: Add partitioner implementation https://review.openstack.org/398604 | 16:17 |
| openstackgerrit | Julien Danjou proposed openstack/tooz: coordination: add __repr__ for join/leave events https://review.openstack.org/398350 | 16:17 |
| openstackgerrit | Julien Danjou proposed openstack/tooz: coordination: renforce event based testing https://review.openstack.org/398349 | 16:17 |
| openstackgerrit | Julien Danjou proposed openstack/tooz: Factorize group quit on stop() https://review.openstack.org/399160 | 16:17 |
| openstackgerrit | Julien Danjou proposed openstack/tooz: Use the internal group of list rather than listing the groups https://review.openstack.org/399161 | 16:17 |
| openstackgerrit | Julien Danjou proposed openstack/tooz: Add a hashring implementation https://review.openstack.org/397264 | 16:17 |
| openstackgerrit | Julien Danjou proposed openstack/tooz: Factorize member_id in the base coordinator class https://review.openstack.org/397772 | 16:17 |
| openstackgerrit | Julien Danjou proposed openstack/tooz: Move the cached-based watcher implementation into its own class https://review.openstack.org/397263 | 16:17 |
| openstackgerrit | Julien Danjou proposed openstack/tooz: Do not re-set the members cache for watchers by default https://review.openstack.org/398352 | 16:17 |
| *** nkrinner is now known as nkrinner_afk | 16:19 | |
| *** code-R has joined #openstack-oslo | 16:25 | |
| *** rcernin has quit IRC | 16:27 | |
| openstackgerrit | Roman Podoliaka proposed openstack/oslo.db: SoftDeleteMixin: allow for None values https://review.openstack.org/403788 | 16:30 |
| rpodolyaka | zzzeek: ^ | 16:30 |
| *** code-R_ has joined #openstack-oslo | 16:31 | |
| *** code-R has quit IRC | 16:34 | |
| *** harlowja_at_home has quit IRC | 16:42 | |
| rpodolyaka | oslo cores, could you please review and approve https://review.openstack.org/#/c/403788/ ? | 16:44 |
| *** tovin07 has left #openstack-oslo | 16:49 | |
| *** jschwarz is now known as jschwarz|mtg | 16:50 | |
| haypo | rpodolyaka: hi. LGTM but i'm not sure if i want to approve it :) | 17:02 |
| haypo | rpodolyaka: i don't know well oslo.db :-/ | 17:02 |
| haypo | rpodolyaka: at the same time, mike voted +2 and i trust him :) | 17:02 |
| rpodolyaka | haypo: it has a +2 from Mike, I just don't want to set a +W on the patch I uploaded :D | 17:02 |
| haypo | zzzeek: ^^ can i approve https://review.openstack.org/#/c/403788/ ? :-) | 17:02 |
| haypo | rpodolyaka: you are a core on the project, no? | 17:03 |
| rpodolyaka | I am | 17:03 |
| *** e0ne has quit IRC | 17:03 | |
| zzzeek | haypo: you're working on nova ? | 17:03 |
| haypo | zzzeek: no | 17:03 |
| haypo | rpodolyaka, zzzeek : i approved the change ;) | 17:04 |
| *** lpetrut has quit IRC | 17:04 | |
| rpodolyaka | haypo: thanks! | 17:05 |
| haypo | rpodolyaka: +2a because of your unit test and doc ;) | 17:05 |
| rpodolyaka | :) | 17:05 |
| haypo | zzzeek: is https://review.openstack.org/#/c/403788/ related to nova? | 17:05 |
| rpodolyaka | sort of | 17:05 |
| rpodolyaka | they decided to fix it in another way | 17:05 |
| rpodolyaka | https://review.openstack.org/#/c/403756 | 17:06 |
| *** ozamiatin_ has joined #openstack-oslo | 17:06 | |
| *** eezhova has quit IRC | 17:06 | |
| *** lpetrut has joined #openstack-oslo | 17:07 | |
| *** jschwarz|mtg is now known as jschwarz | 17:08 | |
| haypo | rpodolyaka: "if deleted:", is deleted=0 a legit value? | 17:17 |
| rpodolyaka | yep, it denotes a "non-deleted row" | 17:17 |
| haypo | rpodolyaka: ok | 17:17 |
| rpodolyaka | deleted = primary key -> a "deleted row" | 17:17 |
| rpodolyaka | *== | 17:17 |
| rpodolyaka | where PK is supposed to be of type integer | 17:17 |
| *** pcaruana has quit IRC | 17:19 | |
| *** code-R_ has quit IRC | 17:35 | |
| *** code-R has joined #openstack-oslo | 17:35 | |
| *** lpetrut has quit IRC | 17:39 | |
| *** mhickey has quit IRC | 17:41 | |
| openstackgerrit | Matt Fischer proposed openstack/oslo.middleware: Remove self-referential link in docs https://review.openstack.org/403825 | 17:48 |
| openstackgerrit | Matt Fischer proposed openstack/oslo.middleware: Document how to use detailed mode in healthcheck https://review.openstack.org/403831 | 17:54 |
| openstackgerrit | Matt Fischer proposed openstack/oslo.middleware: Document how to use detailed mode in healthcheck https://review.openstack.org/403831 | 17:54 |
| *** gcb has quit IRC | 17:55 | |
| *** jeckersb is now known as jeckersb_gone | 17:55 | |
| *** ihrachys has quit IRC | 18:02 | |
| *** lucasagomes is now known as lucas-afk | 18:05 | |
| *** lpetrut has joined #openstack-oslo | 18:21 | |
| *** browne has joined #openstack-oslo | 18:28 | |
| openstackgerrit | Merged openstack/oslo.db: SoftDeleteMixin: allow for None values https://review.openstack.org/403788 | 18:38 |
| *** code-R has quit IRC | 18:38 | |
| *** code-R has joined #openstack-oslo | 18:38 | |
| *** jeckersb_gone is now known as jeckersb | 18:40 | |
| *** jpena is now known as jpena|off | 18:40 | |
| *** lpetrut has quit IRC | 18:42 | |
| *** gangil has joined #openstack-oslo | 18:43 | |
| *** bnemec has quit IRC | 18:45 | |
| *** lpetrut has joined #openstack-oslo | 18:52 | |
| *** rajathagasthya has joined #openstack-oslo | 19:02 | |
| *** amoralej is now known as amoralej|off | 19:11 | |
| openstackgerrit | Andy Smith proposed openstack/oslo.messaging: Periodically purge sender link cache https://review.openstack.org/403862 | 19:14 |
| *** lpetrut has quit IRC | 19:28 | |
| *** mfisch has joined #openstack-oslo | 19:29 | |
| *** ozamiatin_ has quit IRC | 19:33 | |
| *** ozamiatin_ has joined #openstack-oslo | 19:34 | |
| *** rajathagasthya has quit IRC | 19:35 | |
| *** spzala has joined #openstack-oslo | 19:37 | |
| *** eezhova has joined #openstack-oslo | 19:46 | |
| *** bnemec has joined #openstack-oslo | 20:03 | |
| *** eezhova has quit IRC | 20:06 | |
| *** browne has quit IRC | 20:08 | |
| *** browne has joined #openstack-oslo | 20:10 | |
| openstackgerrit | Merged openstack/osprofiler: Remove print statement https://review.openstack.org/400624 | 20:12 |
| openstackgerrit | Merged openstack/osprofiler: Move hacking checks outside tests https://review.openstack.org/401102 | 20:12 |
| openstackgerrit | Merged openstack/osprofiler: Pretty print json output https://review.openstack.org/399486 | 20:17 |
| *** yamahata has quit IRC | 20:25 | |
| *** lpetrut has joined #openstack-oslo | 20:26 | |
| openstackgerrit | Brian Stajkowski proposed openstack/oslo.config: [WIP] oslo validator https://review.openstack.org/384559 | 20:29 |
| *** ozamiatin_ has quit IRC | 20:34 | |
| *** oanson has quit IRC | 20:36 | |
| *** ildikov has joined #openstack-oslo | 20:39 | |
| ildikov | dhellmann: hi | 20:41 |
| dhellmann | ildikov : hi | 20:41 |
| ildikov | dhellmann: I sent out the mail finally to get people's eyes on on boarding activities: http://lists.openstack.org/pipermail/openstack-dev/2016-November/108084.html | 20:41 |
| dhellmann | ildikov : I saw, and forwarded it to our local person here in ATL who may be interested in participating | 20:42 |
| ildikov | dhellmann: if you know anyone who would be interested in this please send them in my way :) | 20:42 |
| ildikov | dhellmann: great, thanks much! | 20:42 |
| dhellmann | ildikov : thanks for driving this, I think it's a great idea | 20:42 |
| ildikov | dhellmann: also if you have ideas on how to get the community more excited about activities like this please ping me | 20:43 |
| *** zhangguoqing has quit IRC | 20:43 | |
| dhellmann | I'll give it some thought | 20:44 |
| ildikov | dhellmann: sure, I think it's really important but unfortunately lower priority activity usually, so I hope giving more spotlight to it will help a bit | 20:44 |
| *** rtheis has quit IRC | 20:45 | |
| ildikov | dhellmann: thanks for all the support! | 20:45 |
| dhellmann | :-) | 20:45 |
| *** spzala has quit IRC | 21:01 | |
| *** yamahata has joined #openstack-oslo | 21:04 | |
| openstackgerrit | Ken Giusti proposed openstack/oslo.messaging: [AMQP 1.0] Simplify the I/O event loop code https://review.openstack.org/403911 | 21:25 |
| *** kgiusti has left #openstack-oslo | 21:38 | |
| *** ansmith has quit IRC | 22:00 | |
| *** e0ne has joined #openstack-oslo | 22:08 | |
| openstackgerrit | Dan Smith proposed openstack/oslo.messaging: Register opts if we're going to check conf.transport_url in parse() https://review.openstack.org/403924 | 22:11 |
| dansmith | dims: harlowja: https://review.openstack.org/#/c/403924/ | 22:14 |
| dansmith | prevents us from doing a thing :/ | 22:14 |
| harlowja | kk | 22:15 |
| harlowja | weird stuff, lol | 22:15 |
| *** jdandrea has quit IRC | 22:23 | |
| *** e0ne has quit IRC | 22:25 | |
| *** zigo has quit IRC | 22:29 | |
| *** zigo has joined #openstack-oslo | 22:36 | |
| *** lpetrut has quit IRC | 22:41 | |
| *** spzala has joined #openstack-oslo | 23:01 | |
| *** mriedem has quit IRC | 23:02 | |
| *** spzala has quit IRC | 23:06 | |
| *** boden has quit IRC | 23:22 | |
| *** boden has joined #openstack-oslo | 23:35 | |
| *** bnemec has quit IRC | 23:37 | |
| *** boden has quit IRC | 23:38 | |
| *** gordc has quit IRC | 23:54 | |
| *** Guest89691 has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!