*** yamamoto_ has joined #openstack-oslo | 00:27 | |
*** yamamoto_ has quit IRC | 00:35 | |
*** mordred has quit IRC | 00:48 | |
*** mordred has joined #openstack-oslo | 00:52 | |
*** tonytan4ever has joined #openstack-oslo | 00:52 | |
*** tonytan_brb has joined #openstack-oslo | 00:53 | |
*** tonytan_brb has joined #openstack-oslo | 00:53 | |
*** mriedem has quit IRC | 00:55 | |
*** tonytan4ever has quit IRC | 00:58 | |
*** zz_dimtruck is now known as dimtruck | 01:30 | |
*** dimtruck is now known as zz_dimtruck | 01:30 | |
*** tonytan_brb has quit IRC | 01:42 | |
*** tonytan4ever has joined #openstack-oslo | 01:50 | |
*** dkehn has quit IRC | 01:56 | |
*** sputnik13 has joined #openstack-oslo | 02:00 | |
*** salv-orlando has joined #openstack-oslo | 02:04 | |
*** dkehn has joined #openstack-oslo | 02:07 | |
*** salv-orlando has quit IRC | 02:08 | |
*** ansmith has joined #openstack-oslo | 02:17 | |
*** ansmith has quit IRC | 02:31 | |
*** ansmith has joined #openstack-oslo | 02:42 | |
*** mtanino has joined #openstack-oslo | 02:55 | |
openstackgerrit | Cao Xuan Hoang proposed openstack/oslo.db: Replace 'assertTrue(a not in b)' with 'assertNotIn(a, b)' https://review.openstack.org/380895 | 02:56 |
---|---|---|
*** salv-orlando has joined #openstack-oslo | 03:04 | |
*** salv-orlando has quit IRC | 03:09 | |
*** yamamoto_ has joined #openstack-oslo | 03:31 | |
*** links has joined #openstack-oslo | 03:49 | |
*** salv-orlando has joined #openstack-oslo | 04:05 | |
*** salv-orlando has quit IRC | 04:10 | |
*** yamamoto_ has quit IRC | 04:38 | |
*** tonytan4ever has quit IRC | 04:58 | |
*** salv-orlando has joined #openstack-oslo | 05:04 | |
*** code-R has joined #openstack-oslo | 05:09 | |
*** code-R has quit IRC | 05:12 | |
*** code-R has joined #openstack-oslo | 05:13 | |
*** code-R has quit IRC | 05:18 | |
*** yamamoto_ has joined #openstack-oslo | 05:28 | |
*** links has quit IRC | 05:31 | |
*** e0ne has joined #openstack-oslo | 05:31 | |
*** e0ne has quit IRC | 05:35 | |
*** links has joined #openstack-oslo | 05:44 | |
*** amotoki has joined #openstack-oslo | 05:49 | |
*** lpetrut has joined #openstack-oslo | 05:57 | |
*** salv-orlando has quit IRC | 06:00 | |
*** rcernin has joined #openstack-oslo | 06:04 | |
*** dtardivel has joined #openstack-oslo | 06:17 | |
openstackgerrit | Tuan Luong-Anh proposed openstack/taskflow: Fix typo: remove redundant 'that' https://review.openstack.org/380940 | 06:30 |
*** links has quit IRC | 06:31 | |
*** kevinbenton has quit IRC | 06:42 | |
*** links has joined #openstack-oslo | 06:44 | |
*** kevinbenton has joined #openstack-oslo | 06:46 | |
*** salv-orlando has joined #openstack-oslo | 06:50 | |
*** pcaruana has joined #openstack-oslo | 06:53 | |
*** e0ne has joined #openstack-oslo | 06:54 | |
*** tonytan4ever has joined #openstack-oslo | 06:59 | |
*** lpetrut has quit IRC | 07:01 | |
*** tesseract- has joined #openstack-oslo | 07:03 | |
*** tonytan4ever has quit IRC | 07:04 | |
*** lpetrut has joined #openstack-oslo | 07:10 | |
*** jpena|off is now known as jpena | 07:20 | |
*** sputnik13 has quit IRC | 07:23 | |
*** lpetrut has quit IRC | 07:35 | |
*** zigo has quit IRC | 07:39 | |
*** zigo has joined #openstack-oslo | 07:42 | |
*** zigo is now known as Guest24756 | 07:42 | |
*** salv-orl_ has joined #openstack-oslo | 07:44 | |
*** haypo has joined #openstack-oslo | 07:44 | |
*** salv-orlando has quit IRC | 07:48 | |
*** shardy has joined #openstack-oslo | 07:58 | |
*** gcb has joined #openstack-oslo | 07:59 | |
*** zzzeek has quit IRC | 08:00 | |
*** tonytan4ever has joined #openstack-oslo | 08:00 | |
*** zzzeek has joined #openstack-oslo | 08:00 | |
*** kevinbenton has quit IRC | 08:01 | |
*** code-R has joined #openstack-oslo | 08:02 | |
*** kevinbenton has joined #openstack-oslo | 08:03 | |
*** code-R_ has joined #openstack-oslo | 08:04 | |
*** kevinbenton has quit IRC | 08:04 | |
*** tonytan4ever has quit IRC | 08:05 | |
*** kevinbenton has joined #openstack-oslo | 08:06 | |
*** code-R has quit IRC | 08:07 | |
*** yassine has joined #openstack-oslo | 08:10 | |
*** yassine is now known as Guest17084 | 08:10 | |
*** mhickey has joined #openstack-oslo | 08:41 | |
*** Guest24756 is now known as zigo | 08:54 | |
*** lpetrut has joined #openstack-oslo | 09:06 | |
*** sambetts|afk is now known as sambetts | 09:18 | |
*** ozamiatin has joined #openstack-oslo | 09:20 | |
*** ozamiatin has quit IRC | 09:28 | |
*** hoonetorg has quit IRC | 09:39 | |
*** ozamiatin has joined #openstack-oslo | 09:41 | |
*** ansmith has quit IRC | 09:46 | |
*** ihrachys has joined #openstack-oslo | 09:48 | |
*** hoonetorg has joined #openstack-oslo | 09:52 | |
*** ansmith has joined #openstack-oslo | 09:58 | |
*** hoonetorg has quit IRC | 10:00 | |
*** ozamiatin has quit IRC | 10:02 | |
*** cdent has joined #openstack-oslo | 10:05 | |
*** hoonetorg has joined #openstack-oslo | 10:13 | |
*** yamamoto_ has quit IRC | 10:24 | |
*** ozamiatin has joined #openstack-oslo | 10:42 | |
*** ansmith has quit IRC | 10:47 | |
*** openstackgerrit has quit IRC | 10:48 | |
*** openstackgerrit has joined #openstack-oslo | 10:48 | |
*** eezhova has joined #openstack-oslo | 11:04 | |
*** salv-orl_ has quit IRC | 11:14 | |
*** salv-orlando has joined #openstack-oslo | 11:18 | |
*** psanchez has joined #openstack-oslo | 11:21 | |
*** rtheis has joined #openstack-oslo | 11:23 | |
*** yamamoto has joined #openstack-oslo | 11:26 | |
*** lucas-afk is now known as lucasagomes | 11:26 | |
*** jrollen has joined #openstack-oslo | 11:34 | |
*** tonytan4ever has joined #openstack-oslo | 12:02 | |
*** tonytan4ever has quit IRC | 12:06 | |
*** ansmith has joined #openstack-oslo | 12:08 | |
*** pradk has joined #openstack-oslo | 12:14 | |
*** kgiusti has joined #openstack-oslo | 12:16 | |
*** jrollen has quit IRC | 12:18 | |
*** yamamoto has quit IRC | 12:21 | |
*** edmondsw has joined #openstack-oslo | 12:23 | |
openstackgerrit | Benjamin VanHavermaet proposed openstack/osprofiler: Add a redis driver https://review.openstack.org/364487 | 12:28 |
*** Guest17084 is now known as yassou | 12:28 | |
*** tonytan4ever has joined #openstack-oslo | 12:39 | |
*** jrollen has joined #openstack-oslo | 12:41 | |
*** jpena is now known as jpena|lunch | 12:43 | |
*** jrollen has quit IRC | 12:45 | |
*** jrollen has joined #openstack-oslo | 12:45 | |
*** jroll has quit IRC | 12:53 | |
*** jrollen is now known as jroll | 12:55 | |
*** mtanino has quit IRC | 13:02 | |
*** lpetrut has quit IRC | 13:02 | |
*** yamamoto has joined #openstack-oslo | 13:04 | |
*** gordc has joined #openstack-oslo | 13:08 | |
*** tonytan4ever has quit IRC | 13:16 | |
*** jeckersb_gone is now known as jeckersb | 13:27 | |
*** tonytan4ever has joined #openstack-oslo | 13:32 | |
*** tonytan4ever has quit IRC | 13:33 | |
*** tonytan4ever has joined #openstack-oslo | 13:38 | |
*** jpena|lunch is now known as jpena | 13:42 | |
*** boden has joined #openstack-oslo | 13:43 | |
*** salv-orl_ has joined #openstack-oslo | 13:44 | |
*** salv-orlando has quit IRC | 13:47 | |
*** mtanino has joined #openstack-oslo | 13:52 | |
openstackgerrit | Gevorg Davoian proposed openstack/oslo.messaging: [zmq] Routing table refactoring, dynamic direct connections https://review.openstack.org/372001 | 13:58 |
openstackgerrit | Gevorg Davoian proposed openstack/oslo.messaging: [zmq] Fix send_cast in AckManager https://review.openstack.org/379562 | 13:58 |
*** mriedem has joined #openstack-oslo | 14:07 | |
*** pblaho has joined #openstack-oslo | 14:17 | |
*** beekneemech is now known as bnemec | 14:18 | |
openstackgerrit | Kirill Bespalov proposed openstack/oslo.messaging: [simulator] Automatic stopping of rpc-servers https://review.openstack.org/380380 | 14:20 |
*** ozamiatin has quit IRC | 14:40 | |
openstackgerrit | Gevorg Davoian proposed openstack/oslo.messaging: [zmq] Fix send_cast in AckManager https://review.openstack.org/379562 | 14:46 |
*** spzala has joined #openstack-oslo | 14:46 | |
openstackgerrit | Gevorg Davoian proposed openstack/oslo.messaging: [zmq] Fix send_cast in AckManager https://review.openstack.org/379562 | 14:50 |
openstackgerrit | Gevorg Davoian proposed openstack/oslo.messaging: [zmq] Fix send_cast in AckManager https://review.openstack.org/379562 | 15:01 |
*** links has quit IRC | 15:04 | |
*** yamamoto has quit IRC | 15:04 | |
openstackgerrit | Gevorg Davoian proposed openstack/oslo.messaging: [zmq] Fix send_cast in AckManager https://review.openstack.org/379562 | 15:12 |
*** pcaruana has quit IRC | 15:18 | |
openstackgerrit | Gevorg Davoian proposed openstack/oslo.messaging: [zmq] Fix send_cast in AckManager https://review.openstack.org/379562 | 15:18 |
*** rcernin has quit IRC | 15:19 | |
*** yamamoto has joined #openstack-oslo | 15:23 | |
*** davidlenwell has quit IRC | 15:37 | |
*** e0ne has quit IRC | 15:42 | |
openstackgerrit | Merged openstack/oslo.policy: Updated from global requirements https://review.openstack.org/380581 | 15:45 |
*** davidlenwell has joined #openstack-oslo | 15:50 | |
*** ozamiatin has joined #openstack-oslo | 15:51 | |
*** harlowja_at_home has joined #openstack-oslo | 15:53 | |
*** eliqiao has quit IRC | 15:53 | |
*** eliqiao has joined #openstack-oslo | 15:56 | |
*** tesseract- has quit IRC | 15:56 | |
*** mriedem1 has joined #openstack-oslo | 15:59 | |
*** mriedem has quit IRC | 16:00 | |
*** shardy has quit IRC | 16:00 | |
*** mhickey has quit IRC | 16:00 | |
*** mriedem1 is now known as mriedem | 16:01 | |
openstackgerrit | Ihar Hrachyshka proposed openstack/oslo.tools: HenryG is the new liaison for Neutron https://review.openstack.org/381207 | 16:02 |
ihrachys | harlowja_at_home: ^ | 16:02 |
harlowja_at_home | thx | 16:03 |
*** ihrachys has quit IRC | 16:19 | |
*** dharinic is now known as dharinic|pto | 16:25 | |
*** mriedem has quit IRC | 16:35 | |
*** mriedem has joined #openstack-oslo | 16:38 | |
*** lpetrut has joined #openstack-oslo | 16:40 | |
*** harlowja_still_a has joined #openstack-oslo | 16:40 | |
*** harlowja_at_home has quit IRC | 16:44 | |
*** harlowja_still_a has quit IRC | 16:46 | |
openstackgerrit | Merged openstack/oslo.utils: doc: Fix docstring of method bool_from_string https://review.openstack.org/380284 | 16:50 |
*** code-R_ has quit IRC | 16:55 | |
openstackgerrit | Merged openstack/oslo.tools: HenryG is the new liaison for Neutron https://review.openstack.org/381207 | 16:55 |
*** yamamoto has quit IRC | 16:59 | |
*** yamahata has joined #openstack-oslo | 17:03 | |
*** salv-orl_ has quit IRC | 17:12 | |
*** yassou has quit IRC | 17:16 | |
*** e0ne has joined #openstack-oslo | 17:20 | |
*** salv-orlando has joined #openstack-oslo | 17:20 | |
*** jdandrea has joined #openstack-oslo | 17:28 | |
*** gcb has quit IRC | 17:35 | |
*** yamahata has quit IRC | 17:37 | |
*** jpena is now known as jpena|away | 17:46 | |
openstackgerrit | Merged openstack/oslo.messaging: [zmq] Added a processing to handle ImportError in Redis plugin of Matchmaker https://review.openstack.org/374664 | 17:46 |
*** ozamiatin has quit IRC | 17:49 | |
*** cdent has quit IRC | 17:51 | |
*** salv-orlando has quit IRC | 17:53 | |
*** ozamiatin has joined #openstack-oslo | 17:57 | |
*** lpetrut has quit IRC | 17:59 | |
*** ozamiatin has quit IRC | 18:01 | |
*** sambetts is now known as sambetts|afk | 18:02 | |
*** yamahata has joined #openstack-oslo | 18:15 | |
*** zz_dimtruck is now known as dimtruck | 18:19 | |
*** dimtruck is now known as zz_dimtruck | 18:20 | |
*** yamahata has quit IRC | 18:29 | |
*** pcaruana has joined #openstack-oslo | 18:29 | |
*** yamamoto has joined #openstack-oslo | 18:30 | |
*** browne has joined #openstack-oslo | 18:30 | |
*** rcernin has joined #openstack-oslo | 18:31 | |
*** harlowja has quit IRC | 18:38 | |
*** harlowja has joined #openstack-oslo | 18:39 | |
johnsom | Hi oslo folks. Does anyone have example code for oslo_config test fixture that they feel is "done right"? I am realizing folks have been setting overrides in our project tests in three different ways, all but one of which I think are wrong. | 18:54 |
johnsom | I.e. this is wrong: https://github.com/openstack/octavia/blame/master/octavia/tests/unit/amphorae/drivers/keepalived/jinja/test_jinja_cfg.py#L92 | 18:57 |
*** dtardivel has quit IRC | 18:57 | |
johnsom | I think this is right: https://github.com/openstack/octavia/blob/master/octavia/tests/unit/amphorae/drivers/haproxy/test_rest_api_driver.py#L234 | 18:57 |
*** yamahata has joined #openstack-oslo | 18:59 | |
*** yamamoto has quit IRC | 19:00 | |
*** hoonetorg has quit IRC | 19:00 | |
*** lpetrut has joined #openstack-oslo | 19:08 | |
*** ozamiatin has joined #openstack-oslo | 19:23 | |
*** rtheis_ has joined #openstack-oslo | 19:25 | |
*** spzala has quit IRC | 19:26 | |
*** mhickey has joined #openstack-oslo | 19:26 | |
*** rtheis has quit IRC | 19:26 | |
*** hoonetorg has joined #openstack-oslo | 19:27 | |
*** spzala has joined #openstack-oslo | 19:27 | |
*** salv-orlando has joined #openstack-oslo | 19:30 | |
*** spzala has quit IRC | 19:32 | |
*** ozamiatin has quit IRC | 19:35 | |
*** ozamiatin has joined #openstack-oslo | 19:38 | |
*** ozamiatin has quit IRC | 19:39 | |
*** spzala has joined #openstack-oslo | 19:41 | |
*** salv-orl_ has joined #openstack-oslo | 19:44 | |
*** ansmith has quit IRC | 19:46 | |
*** david-lyle has joined #openstack-oslo | 19:47 | |
*** salv-orlando has quit IRC | 19:47 | |
*** ansmith has joined #openstack-oslo | 19:50 | |
*** tonytan4ever has quit IRC | 19:55 | |
*** ansmith has quit IRC | 19:57 | |
*** ansmith has joined #openstack-oslo | 19:57 | |
*** e0ne has quit IRC | 20:05 | |
*** jpena|away is now known as jpena | 20:05 | |
openstackgerrit | Eric Harney proposed openstack/oslo.db: Add DBDataError for "Data too long" https://review.openstack.org/381289 | 20:08 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.messaging: Updated from global requirements https://review.openstack.org/373775 | 20:16 |
*** lucasagomes is now known as lucas-afk | 20:19 | |
*** jpena is now known as jpena|off | 20:22 | |
*** lpetrut has quit IRC | 20:23 | |
*** david-lyle has quit IRC | 20:30 | |
*** zz_dimtruck is now known as dimtruck | 20:32 | |
harlowja | johnsom i think the second one is the best one | 20:35 |
*** david-lyle has joined #openstack-oslo | 20:35 | |
harlowja | though is it just me or did that not call useFixture | 20:35 |
johnsom | Yeah, the first is clearly wrong as it's setting the global. I just wanted to make sure the second one was the "right" way. | 20:35 |
harlowja | second one seems to be missing https://github.com/testing-cabal/testtools/blob/master/testtools/testcase.py#L721 ? | 20:36 |
harlowja | maybe that happens somewhere under the covers | 20:36 |
johnsom | Yeah, I *think* that happens when I wrap the config with conf = oslo_fixture.Config(cfg.CONF) | 20:37 |
johnsom | I have done some tests with the second one, it seems to be working | 20:37 |
harlowja | odd, i wonder how the fixture.cleanUp gets called | 20:37 |
harlowja | because without calling self.useFixture not quite sure how it gets registered with the testcase | 20:38 |
openstackgerrit | Ken Giusti proposed openstack/oslo.messaging: Remove debug logs from fast path https://review.openstack.org/381300 | 20:38 |
harlowja | johnsom mainly https://github.com/testing-cabal/testtools/blob/master/testtools/testcase.py#L757-L761 | 20:39 |
harlowja | don't see how calling oslo_fixture.Config(cfg.CONF) would call these :-P | 20:39 |
harlowja | unless it passes the testcase in | 20:39 |
harlowja | *which it doesn't | 20:39 |
johnsom | Yeah, I see it. This is why I was asking the oracle for advice.... grin | 20:39 |
harlowja | oracle! | 20:39 |
harlowja | don't ask oracle | 20:40 |
harlowja | lol | 20:40 |
johnsom | oslo.oracle | 20:40 |
harlowja | 500$ service fee | 20:40 |
johnsom | Ugh, sorry, that is worse.... | 20:40 |
harlowja | for asking oracle | 20:40 |
harlowja | lol | 20:40 |
*** kgiusti has quit IRC | 20:40 | |
johnsom | Sigh, matrix reference gone wrong.... | 20:40 |
harlowja | i'd say use config = useFixture(oslo_fixture.Config(cfg.CONF)) | 20:40 |
harlowja | lol | 20:40 |
harlowja | like @ https://github.com/openstack/oslo.config/blob/master/oslo_config/fixture.py#L198 | 20:41 |
harlowja | that should ensure cleanup | 20:41 |
harlowja | but yes, better doc or something is needed | 20:41 |
johnsom | Yeah, just a little code snippet example would be awesome. I actually found like three different ways people were trying to do this in our code. Evidently all of them were wrong | 20:42 |
harlowja | :-/ | 20:42 |
harlowja | suck | 20:42 |
*** dimtruck is now known as zz_dimtruck | 20:42 | |
johnsom | Which leads to my favorite, test order dependent failures.... | 20:42 |
harlowja | ya | 20:43 |
*** david-lyle has quit IRC | 20:44 | |
*** pcaruana has quit IRC | 20:45 | |
johnsom | harlowja Thanks for wisdom. | 20:47 |
harlowja | np | 20:47 |
harlowja | the oracle is here to help | 20:47 |
harlowja | lol | 20:47 |
*** cdent has joined #openstack-oslo | 20:56 | |
*** ansmith has quit IRC | 20:58 | |
*** Rockyg has joined #openstack-oslo | 20:59 | |
*** zz_dimtruck is now known as dimtruck | 21:03 | |
*** edmondsw has quit IRC | 21:14 | |
*** dimtruck is now known as zz_dimtruck | 21:15 | |
*** lpetrut has joined #openstack-oslo | 21:18 | |
*** openstackgerrit has quit IRC | 21:19 | |
*** openstackgerrit has joined #openstack-oslo | 21:19 | |
*** david-lyle has joined #openstack-oslo | 21:19 | |
*** rtheis_ has quit IRC | 21:21 | |
*** ozamiatin has joined #openstack-oslo | 21:22 | |
*** mhickey has quit IRC | 21:26 | |
*** hoonetorg has quit IRC | 21:26 | |
openstackgerrit | Gevorg Davoian proposed openstack/oslo.messaging: [zmq] Fix send_cast in AckManager https://review.openstack.org/379562 | 21:27 |
*** hoonetorg has joined #openstack-oslo | 21:31 | |
*** spzala has quit IRC | 21:41 | |
*** browne has quit IRC | 21:55 | |
*** spzala has joined #openstack-oslo | 21:55 | |
*** YorikSar has quit IRC | 21:56 | |
*** YorikSar has joined #openstack-oslo | 21:57 | |
*** browne has joined #openstack-oslo | 21:57 | |
*** lpetrut has quit IRC | 22:05 | |
*** boden has quit IRC | 22:05 | |
*** YorikSar has quit IRC | 22:05 | |
*** YorikSar has joined #openstack-oslo | 22:06 | |
*** YorikSar is now known as YorikSar_ | 22:08 | |
*** YorikSar_ is now known as YorikSar | 22:09 | |
*** david-lyle has quit IRC | 22:09 | |
*** mriedem has quit IRC | 22:13 | |
*** zz_dimtruck is now known as dimtruck | 22:17 | |
*** rcernin has quit IRC | 22:25 | |
*** gcb has joined #openstack-oslo | 22:27 | |
*** salv-orlando has joined #openstack-oslo | 22:28 | |
*** salv-orl_ has quit IRC | 22:28 | |
*** david-lyle has joined #openstack-oslo | 22:36 | |
*** dimtruck is now known as zz_dimtruck | 22:44 | |
*** cdent has quit IRC | 22:44 | |
*** salv-orlando has quit IRC | 22:55 | |
*** spzala has quit IRC | 22:55 | |
*** gordc has quit IRC | 22:56 | |
*** spzala has joined #openstack-oslo | 22:56 | |
*** zz_dimtruck is now known as dimtruck | 22:57 | |
*** spzala has quit IRC | 23:01 | |
*** gordc has joined #openstack-oslo | 23:01 | |
*** mtanino has quit IRC | 23:22 | |
*** jamielennox is now known as jamielennox|away | 23:35 | |
*** gordc has quit IRC | 23:37 | |
*** dimtruck is now known as zz_dimtruck | 23:39 | |
*** david-lyle has quit IRC | 23:44 | |
*** browne has quit IRC | 23:44 | |
*** yamahata has quit IRC | 23:44 | |
*** jamielennox|away is now known as jamielennox | 23:48 | |
*** spzala has joined #openstack-oslo | 23:57 | |
*** yamahata has joined #openstack-oslo | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!