| *** vilobhmm11 has joined #openstack-oslo | 00:05 | |
| *** yamamoto_ has joined #openstack-oslo | 00:05 | |
| *** EinstCrazy has joined #openstack-oslo | 00:10 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Initial POC/experimental builder code (for the general good) https://review.openstack.org/282584 | 00:11 |
|---|---|---|
| *** yamamoto_ has quit IRC | 00:14 | |
| *** EinstCrazy has quit IRC | 00:14 | |
| *** vilobhmm11 has quit IRC | 00:19 | |
| *** vilobhmm11 has joined #openstack-oslo | 00:20 | |
| *** cdent has joined #openstack-oslo | 00:20 | |
| *** vilobhmm11 has quit IRC | 00:21 | |
| *** vilobhmm11 has joined #openstack-oslo | 00:21 | |
| *** vilobhmm11 has quit IRC | 00:21 | |
| *** vilobhmm11 has joined #openstack-oslo | 00:22 | |
| *** jeckersb is now known as jeckersb_gone | 00:31 | |
| *** cdent has quit IRC | 00:42 | |
| *** dtardivel has quit IRC | 01:08 | |
| *** yamamoto_ has joined #openstack-oslo | 01:14 | |
| *** yamamoto_ has quit IRC | 01:19 | |
| *** yamamoto_ has joined #openstack-oslo | 01:20 | |
| *** jeckersb_gone is now known as jeckersb | 01:32 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.db: Updated from global requirements https://review.openstack.org/283900 | 01:38 |
| *** sputnik13 has quit IRC | 01:45 | |
| *** dims has quit IRC | 01:59 | |
| *** vilobhmm11 has quit IRC | 01:59 | |
| *** yamamoto_ has quit IRC | 02:00 | |
| *** yamahata has quit IRC | 02:00 | |
| *** vilobhmm11 has joined #openstack-oslo | 02:03 | |
| *** vilobhmm11 has quit IRC | 02:03 | |
| *** vilobhmm11 has joined #openstack-oslo | 02:03 | |
| *** sputnik13 has joined #openstack-oslo | 02:06 | |
| *** sputnik13 has quit IRC | 02:07 | |
| *** pcaruana has quit IRC | 02:07 | |
| *** vilobhmm11 has quit IRC | 02:12 | |
| *** browne has quit IRC | 02:16 | |
| *** pcaruana has joined #openstack-oslo | 02:19 | |
| openstackgerrit | Merged openstack/oslo.context: Revert "Add common oslo.log format parameters" https://review.openstack.org/283745 | 02:24 |
| *** zz_dimtruck is now known as dimtruck | 02:47 | |
| *** yamamoto_ has joined #openstack-oslo | 02:47 | |
| *** vilobhmm11 has joined #openstack-oslo | 02:59 | |
| *** pcaruana has quit IRC | 03:01 | |
| *** amrith is now known as _amrith_ | 03:05 | |
| *** browne has joined #openstack-oslo | 03:09 | |
| *** dims has joined #openstack-oslo | 03:13 | |
| *** pcaruana has joined #openstack-oslo | 03:16 | |
| *** salv-orlando has joined #openstack-oslo | 03:26 | |
| *** salv-orlando has quit IRC | 03:28 | |
| *** salv-orl_ has quit IRC | 03:29 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.messaging: Added duration to notify server/client https://review.openstack.org/281254 | 03:33 |
| openstackgerrit | Merged openstack/oslo.db: Updated from global requirements https://review.openstack.org/283900 | 03:36 |
| openstackgerrit | Merged openstack/oslo.messaging: Reduce number of rabbitmq consumer tag used https://review.openstack.org/280170 | 03:36 |
| openstackgerrit | Merged openstack/oslo.messaging: Documents the mirror queue policy of RabbitMQ 3.0 https://review.openstack.org/282152 | 03:36 |
| openstackgerrit | Merged openstack/oslo.messaging: Typos of 'recieve' instead of 'receive' https://review.openstack.org/283403 | 03:36 |
| openstackgerrit | Merged openstack/tooz: Compute requires_beating https://review.openstack.org/279651 | 03:37 |
| dims | dhellmann : something wrong with oslosphinx : http://logs.openstack.org/60/282760/1/check/gate-oslo.middleware-docs/acfeaff/console.html | 03:39 |
| *** links has joined #openstack-oslo | 03:46 | |
| dims | gus : ping | 03:53 |
| *** boris-42 has quit IRC | 03:54 | |
| gus | ? | 03:54 |
| dims | gus : saw your note, can you please file review for oslo.privsep release? | 03:55 |
| gus | security review? | 03:55 |
| dims | " It still relies on a merged-but-not-yet-released change in oslo.privsep" | 03:56 |
| gus | oh right.. | 03:56 |
| gus | https://review.openstack.org/#/c/283917/ | 03:56 |
| dims | gus : then another review for g-r and u-c bump | 03:56 |
| gus | yep, will do. | 03:56 |
| dims | you will need a os-brick release too right? with that fixed up oslo.privsep version # | 03:57 |
| gus | yes. | 03:57 |
| gus | but that needs to actually be reviewed first, so might take a few days (at least). | 03:58 |
| dims | ok let's take care of the oslo.privsep + g-r/u-c bump | 03:58 |
| *** pcaruana has quit IRC | 04:01 | |
| *** vilobhmm11 has quit IRC | 04:04 | |
| gus | dims: Sachi mentioned in passing that you were working on a jenkins job that just used everything from git - is this true / already-merged? | 04:04 |
| gus | (otherwise I'll put together such a thing - I'm tired of Depends-On being ignored without waiting for a project-config approval round-trip) | 04:06 |
| gus | dims: oslo.privsep g-r/u-c bump: https://review.openstack.org/283925 | 04:09 |
| *** pcaruana has joined #openstack-oslo | 04:15 | |
| *** dimtruck is now known as zz_dimtruck | 04:35 | |
| harlowja_at_home | gus, let me know when u want to work on that language stuff :) | 04:35 |
| harlowja_at_home | ;) | 04:35 |
| dims | gus : those are running already - details here - https://etherpad.openstack.org/p/dims-periodic-jobs | 04:41 |
| gus | dims: aha, thanks. | 04:43 |
| *** harlowja_at_home has quit IRC | 04:53 | |
| *** jamielennox is now known as jamielennox|away | 04:54 | |
| dims | gus : done with the release and the bumps | 04:56 |
| gus | thanks | 04:57 |
| *** deray has joined #openstack-oslo | 05:04 | |
| *** amotoki has joined #openstack-oslo | 05:05 | |
| *** jamespage has quit IRC | 05:05 | |
| *** jamespage has joined #openstack-oslo | 05:06 | |
| openstackgerrit | javeme proposed openstack/oslo.messaging: Use more efficient mask_dict_password to mask password https://review.openstack.org/283942 | 05:20 |
| *** zqfan has joined #openstack-oslo | 05:20 | |
| openstackgerrit | Merged openstack/oslo.service: wsgi: decrease the default number of greenthreads in pool https://review.openstack.org/269188 | 05:30 |
| *** jeckersb is now known as jeckersb_gone | 05:32 | |
| *** salv-orlando has joined #openstack-oslo | 05:36 | |
| *** gcb has quit IRC | 05:37 | |
| *** pcaruana has quit IRC | 05:38 | |
| *** dims has quit IRC | 05:48 | |
| *** salv-orlando has quit IRC | 05:49 | |
| *** pcaruana has joined #openstack-oslo | 05:53 | |
| *** gcb has joined #openstack-oslo | 05:58 | |
| *** vilobhmm11 has joined #openstack-oslo | 06:02 | |
| *** nkrinner has joined #openstack-oslo | 06:16 | |
| *** harlowja_at_home has joined #openstack-oslo | 06:17 | |
| *** openstack has joined #openstack-oslo | 13:20 | |
| *** openstackstatus has joined #openstack-oslo | 13:21 | |
| *** ChanServ sets mode: +v openstackstatus | 13:21 | |
| *** subscope has quit IRC | 13:24 | |
| *** edmondsw has joined #openstack-oslo | 13:27 | |
| *** jeckersb_gone is now known as jeckersb | 13:34 | |
| *** dims has joined #openstack-oslo | 13:40 | |
| *** amotoki has joined #openstack-oslo | 13:44 | |
| *** EinstCrazy has joined #openstack-oslo | 13:47 | |
| dims | dhellmann : we have a problem with oslo.middleware docs build, can you please take a look when you get a chance? https://bugs.launchpad.net/oslo.middleware/+bug/1549106 | 13:53 |
| openstack | Launchpad bug 1549106 in oslo.middleware "gate-oslo.middleware-docs fails to build" [Undecided,New] | 13:53 |
| *** gordc has joined #openstack-oslo | 13:55 | |
| szaher | dhellmann I can see the logs twice, one time in the log-file and other one in output stream | 13:59 |
| *** salv-orlando has joined #openstack-oslo | 14:01 | |
| szaher | dhellmann check the output http://paste.openstack.org/show/488021/ seems to be fine ... I need to stop stream handler ! | 14:03 |
| *** slashme has joined #openstack-oslo | 14:03 | |
| *** mdrabe has joined #openstack-oslo | 14:03 | |
| *** dimtruck is now known as zz_dimtruck | 14:05 | |
| *** salv-orlando has quit IRC | 14:08 | |
| *** mriedem has joined #openstack-oslo | 14:14 | |
| *** kgiusti has joined #openstack-oslo | 14:15 | |
| *** rlrossit_ has joined #openstack-oslo | 14:17 | |
| *** itisha has quit IRC | 14:19 | |
| openstackgerrit | Oleksii Zamiatin proposed openstack/oslo.messaging: Check devstack gate zmq https://review.openstack.org/229779 | 14:24 |
| *** regXboi has joined #openstack-oslo | 14:24 | |
| *** dukhlov has joined #openstack-oslo | 14:25 | |
| dhellmann | dims : ack | 14:33 |
| zzzeek | rpodolyaka: looks great | 14:33 |
| *** EinstCrazy has quit IRC | 14:35 | |
| dhellmann | szaher : ok, let me take a closer look. can I run freezer from a virtualenv or do I need to run devstack? | 14:36 |
| dhellmann | szaher : and do I need that configuration file you have in your example in the paste? | 14:37 |
| dhellmann | szaher : running freezer-agent without a config file isn't doing anything | 14:40 |
| openstackgerrit | Merged openstack/oslo.db: Increase the default max_overflow value https://review.openstack.org/269186 | 14:44 |
| dhellmann | szaher : this code needs a lot of work. You're violating privacy policies messing with the internals of the config object. | 14:50 |
| dims | bknudson : some recent oslo policy change seems to be causing problems in ironic - http://logs.openstack.org/51/284151/1/check/gate-ironic-python27/b30cad5/testr_results.html.gz | 14:51 |
| bknudson | there's recent changes in oslo.policy? | 14:52 |
| dims | bknudson : at least it's failing in oslo policy :) | 14:52 |
| *** rlrossit_ has quit IRC | 14:53 | |
| *** rlrossit has joined #openstack-oslo | 14:53 | |
| bknudson | the most recent merge to oslo.policy that actually changed something was Jan 7 | 14:54 |
| dims | bknudson : hmm :( | 14:54 |
| bknudson | maybe it's an interaction with oslo.context | 14:54 |
| bknudson | ? | 14:54 |
| dims | that would have been too easy :) | 14:54 |
| dims | yes possible | 14:54 |
| dims | roles? | 14:55 |
| dims | bingo | 14:55 |
| bknudson | http://git.openstack.org/cgit/openstack/oslo.context/log/ -- the roles change isn't released | 14:56 |
| dims | bknudson : right, that's why we are failing running against master | 14:56 |
| dims | of all oslo.* | 14:56 |
| bknudson | success | 14:56 |
| dims | bknudson : do you have some time to poke at this? (pretty please) | 14:57 |
| bknudson | dims: I can look at this today | 14:57 |
| bknudson | I'll be hanging out at the neutron meetup | 14:57 |
| dims | thanks bknudson. ack. i'll try to get back to it in a couple of hours too | 14:57 |
| openstackgerrit | Julian proposed openstack/oslo.db: Add tests for float interval values in wrap_db_retry() https://review.openstack.org/284175 | 14:58 |
| *** sigmavirus24_awa is now known as sigmavirus24 | 14:58 | |
| *** jecarey has joined #openstack-oslo | 14:59 | |
| *** mtanino has joined #openstack-oslo | 14:59 | |
| *** ozamiatin has quit IRC | 14:59 | |
| *** deray has quit IRC | 15:01 | |
| *** pblaho has quit IRC | 15:05 | |
| lxsli_web | Anyone who understands oslo.service here? Specifically ProcessLauncher | 15:06 |
| lxsli_web | it looks to me as though in #wait, when service#reset is called, it does so in the launcher process not the worker process | 15:06 |
| lxsli_web | eezhova: ^^ | 15:07 |
| *** salv-orlando has joined #openstack-oslo | 15:08 | |
| eezhova | lxsli_web, here is how reset is triggered in ProcessLauncher: https://github.com/openstack/oslo.service/blob/master/oslo_service/service.py#L558-L561 | 15:09 |
| eezhova | lxsli_web, reset is called for all children | 15:09 |
| eezhova | lxsli_web, then all children are killed by SIGTERM so they are guaranteed to restart with new config | 15:11 |
| *** lxsli_web has quit IRC | 15:11 | |
| openstackgerrit | Merged openstack/oslo.versionedobjects: Updated from global requirements https://review.openstack.org/283999 | 15:18 |
| openstackgerrit | Merged openstack/oslo.service: Updated from global requirements https://review.openstack.org/283998 | 15:20 |
| *** lxsli_web has joined #openstack-oslo | 15:21 | |
| lxsli_web | oslo.service: I suspect ProcessLauncher is only calling service#reset in its own process, not the workers | 15:22 |
| lxsli_web | anyone know why this is OK please? Seems fairly broken to me | 15:22 |
| lxsli_web | The direct solution would be to make workers call service.reset when they catch SIGHUP instead of exiting. This could have side-effects. | 15:22 |
| lxsli_web | An alternative would be to set up a threading.Event per worker and use this to signal reset. Each worker would need a thread to poll the event. | 15:22 |
| lxsli_web | eezhova dhellmann ^^ | 15:22 |
| openstackgerrit | Merged openstack/oslo.messaging: Improves logging https://review.openstack.org/283674 | 15:26 |
| openstackgerrit | Merged openstack/oslo.messaging: Use more efficient mask_dict_password to mask password https://review.openstack.org/283942 | 15:26 |
| *** zz_dimtruck is now known as dimtruck | 15:28 | |
| eezhova | lxsli_web, In the past when a parent process received SIGHUP it reloaded its own config and then sent SIGHUP to all children and they handled the signal by calling launcher.restart (https://github.com/openstack/oslo.service/blob/master/oslo_service/service.py#L471) | 15:29 |
| *** dims has quit IRC | 15:29 | |
| *** salv-orlando has quit IRC | 15:29 | |
| *** dims has joined #openstack-oslo | 15:30 | |
| eezhova | lxsli_web, But later the behavior was changed so that a parent sends SIGTERM instead of SIGHUP https://github.com/openstack/oslo.service/commit/286a6ea80dd4419137d8c35c7db6a0f687027418 | 15:30 |
| lxsli_web | eezhova: just been reading git blame, thank you :) | 15:31 |
| lxsli_web | eezhova: do you agree that since service.reset() doesn't cross the process boundary to the workers, it's pointless? | 15:31 |
| lxsli_web | or, what have I missed? | 15:31 |
| eezhova | lxsli_web, it isn't entirely useless. it was introduced because Neutron does some stuff in the parent process | 15:32 |
| openstackgerrit | John Eckersberg proposed openstack/oslo.messaging: amqp: log time elapsed between receiving a message and replying https://review.openstack.org/284195 | 15:33 |
| eezhova | lxsli_web, and it also has to be reset | 15:33 |
| lxsli_web | :| | 15:33 |
| bknudson | dims: look how ironic does init for its context: http://git.openstack.org/cgit/openstack/ironic/tree/ironic/common/context.py#n21 | 15:34 |
| *** dims has quit IRC | 15:34 | |
| bknudson | the call to super() is at the end rather than the beginning | 15:35 |
| eezhova | lxsli_web, I agree that it is ugly, but that's how it is :( | 15:35 |
| openstackgerrit | John Eckersberg proposed openstack/oslo.messaging: amqp: log time elapsed between receiving a message and replying https://review.openstack.org/284195 | 15:35 |
| bknudson | dims: so that oslo.context's change to initialize roles overrides ironic's | 15:36 |
| lxsli_web | eezhova: thanks for the explanation, I'll try to figure out what to do | 15:36 |
| *** yamahata has joined #openstack-oslo | 15:39 | |
| bknudson | dims: change to ironic: https://review.openstack.org/#/c/284199/ | 15:39 |
| *** nkrinner has quit IRC | 15:44 | |
| *** mdrabe has quit IRC | 15:53 | |
| *** dims has joined #openstack-oslo | 16:03 | |
| *** browne has joined #openstack-oslo | 16:08 | |
| *** salv-orlando has joined #openstack-oslo | 16:08 | |
| *** mdrabe has joined #openstack-oslo | 16:08 | |
| *** yamahata has quit IRC | 16:10 | |
| *** Kennan has quit IRC | 16:13 | |
| *** lxsli_web has quit IRC | 16:13 | |
| *** Kennan has joined #openstack-oslo | 16:14 | |
| rbradfor | bknudson, I pretty sure I've seen a similar context subclassing pattern in other projects | 16:24 |
| bknudson | rbradfor: why do they even subclass if they're not going to use it? | 16:24 |
| rbradfor | bknudson, that would require more investigation, I'm sure there is a reason. | 16:25 |
| rbradfor | bknudson, an alternative solution is to pass roles to super() now that's is a kwarg of the baseclass | 16:25 |
| bknudson | rbradfor: I proposed that in https://review.openstack.org/#/c/284227/ | 16:26 |
| rbradfor | bknudson, oh, I'd only seen the earlier review | 16:27 |
| *** harlowja_at_home has joined #openstack-oslo | 16:31 | |
| *** ihrachys has quit IRC | 16:33 | |
| harlowja_at_home | dims, yt | 16:41 |
| harlowja_at_home | question from ironic folks, they were thinking it might be nice to have ironic-dvsm gate or something on futurist library, now that futurist code merged there (ya)!!! | 16:42 |
| harlowja_at_home | https://review.openstack.org/#/c/264720/ (merged, woot!) | 16:43 |
| stevemar | question for you wonderful oslo folks | 16:46 |
| *** vilobhmm11 has joined #openstack-oslo | 16:46 | |
| stevemar | we're getting the following message in keystone test logs: oslo_middleware/ssl.py:28: Deprecation[30;43mWarn[0ming: The 'oslo_middleware.ssl' module usage is deprecated, please use oslo_middleware.http_proxy_to_wsgi | 16:46 |
| stevemar | but we're not importing oslo_middleware.ssl :) | 16:47 |
| *** lxsli_web has joined #openstack-oslo | 16:47 | |
| stevemar | could it be coming from the init? http://git.openstack.org/cgit/openstack/oslo.middleware/tree/oslo_middleware/__init__.py | 16:47 |
| stevemar | from oslo_middleware.ssl import SSLMiddleware | 16:47 |
| *** yuriy_n17 has quit IRC | 16:47 | |
| stevemar | which then invokes : removals.removed_module ... | 16:47 |
| harlowja_at_home | hmmm | 16:48 |
| harlowja_at_home | likely | 16:48 |
| harlowja_at_home | stevemar, looks like due to that __init__ that is likely getting triggerex | 16:49 |
| harlowja_at_home | *triggered | 16:49 |
| stevemar | harlowja_at_home: yep =\ | 16:49 |
| * harlowja_at_home doesn't like __init__ that do that kind of stuff | 16:49 | |
| stevemar | harlowja_at_home: http://codesearch.openstack.org/?q=oslo_middleware.ssl&i=nope&files=&repos= | 16:50 |
| *** pblaho has joined #openstack-oslo | 16:50 | |
| harlowja_at_home | right | 16:50 |
| harlowja_at_home | http://git.openstack.org/cgit/openstack/oslo.middleware/tree/oslo_middleware/ssl.py#n27 | 16:50 |
| stevemar | harlowja_at_home: might we be able to remove it from the init? the only folks using it, are doing it directly? | 16:50 |
| harlowja_at_home | seems fair to me | 16:51 |
| harlowja_at_home | hopefully that will work out for folks | 16:51 |
| * stevemar shrugs | 16:51 | |
| stevemar | harlowja_at_home: i'll toss something up and see what happens | 16:51 |
| harlowja_at_home | cool | 16:51 |
| *** lbragstad has quit IRC | 16:58 | |
| *** dims has quit IRC | 17:00 | |
| *** amotoki has quit IRC | 17:00 | |
| *** ozamiatin has joined #openstack-oslo | 17:01 | |
| *** dims has joined #openstack-oslo | 17:03 | |
| rbradfor | bknudson, FYI https://review.openstack.org/#/c/284227 will fail, context.roles is merged, but not released until 2.2.0 | 17:04 |
| bknudson | I'll recheck after oslo.context is released | 17:04 |
| rbradfor | np | 17:05 |
| * dims back online | 17:05 | |
| rbradfor | all hail dims! | 17:05 |
| bknudson | that's what znc is for | 17:05 |
| dims | LOL | 17:05 |
| dims | what exciting stuff did i miss? :) | 17:05 |
| *** yamahata has joined #openstack-oslo | 17:06 | |
| *** ozamiatin has quit IRC | 17:06 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.middleware: work around doc build error https://review.openstack.org/284264 | 17:12 |
| dhellmann | dims : ^^ | 17:12 |
| *** achanda has joined #openstack-oslo | 17:15 | |
| *** achanda has quit IRC | 17:15 | |
| *** achanda has joined #openstack-oslo | 17:15 | |
| dims | dhellmann : thanks | 17:16 |
| dhellmann | dims : stand by for the oslo.config patch | 17:17 |
| dims | rbradfor, bknudson : one of you please +2A it? https://review.openstack.org/#/c/284264/ | 17:17 |
| dims | ack dhellmann | 17:17 |
| bknudson | dims: looking... | 17:17 |
| rbradfor | dims, done. I was already running this locally, can see the ValueError: list.remove(x): x not in list presently. | 17:18 |
| dims | rbradfor : bknudson : thanks | 17:19 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.config: remove redundant call to set explicit target https://review.openstack.org/284270 | 17:20 |
| rbradfor | dhellmann, while it works, it perplexes me what keeps sample.config current | 17:20 |
| dhellmann | rbradfor : the extension causes the file to be generated | 17:21 |
| rbradfor | dhellmann, sphinxconfiggen, ok, I didn't see an output_file so i take it that is a default file | 17:22 |
| dhellmann | rbradfor : yeah | 17:22 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.middleware: Revert "work around doc build error" https://review.openstack.org/284272 | 17:23 |
| *** edmondsw has quit IRC | 17:23 | |
| *** ihrachys has joined #openstack-oslo | 17:26 | |
| *** ihrachys has quit IRC | 17:29 | |
| rbradfor | dhellmann, one day you will need to teach me how you got from error to https://review.openstack.org/#/c/284270/ | 17:30 |
| dhellmann | rbradfor : I used pdb and some intuition. It took a few rounds of "what are these nodes?" to figure out what was going on. | 17:32 |
| rbradfor | dhellmann, I'm sure your reST and sphinx work in past helped navigate. | 17:34 |
| *** slashme has left #openstack-oslo | 17:40 | |
| dhellmann | rbradfor : yeah, that's where the intuition came in | 17:42 |
| openstackgerrit | Merged openstack/oslo.messaging: Added duration to notify server/client https://review.openstack.org/281254 | 17:45 |
| *** edmondsw has joined #openstack-oslo | 17:47 | |
| *** yamamoto has quit IRC | 17:49 | |
| dims | updates from testing this morning : https://review.openstack.org/#/q/owner:dims-v+message:%22%255BWIP%255D+Trying+latest+oslo.*+from+master%22 | 17:49 |
| dims | cinder breaks until https://review.openstack.org/#/c/284167/ gets merged | 17:50 |
| dims | ironic breaks until https://review.openstack.org/#/c/284300/ gets merged | 17:50 |
| dims | s/breaks until/will break unless/ | 17:50 |
| *** lucasagomes is now known as lucas-hungry | 17:51 | |
| *** sputnik13 has joined #openstack-oslo | 17:52 | |
| openstackgerrit | Vilobh Meshram proposed openstack/tooz: Add Consul Driver https://review.openstack.org/245362 | 17:54 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 18:01 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.messaging: Allow Notifier to have multiple topics https://review.openstack.org/284330 | 18:15 |
| harlowja_at_home | dims, hey, do u think that new periodic job will cover what the ironic folks are looking for, basically a dvsm-gate on futurist (now that https://review.openstack.org/#/c/264720 merged, woot!) | 18:39 |
| harlowja_at_home | dmitry there was wondering about ironic-dvsm job for futurist, may not though be useful if periodic job does enough of the same | 18:40 |
| dims | harlowja_at_home : right now it uses only oslo*, yes others can be added - http://git.openstack.org/cgit/openstack-infra/project-config/tree/jenkins/scripts/run-tox-with-oslo-master.sh#n26 | 18:47 |
| dims | ah dsvm! | 18:47 |
| dims | one sec | 18:47 |
| dims | harlowja_at_home : this one needs to be updated - http://git.openstack.org/cgit/openstack-infra/project-config/tree/jenkins/jobs/devstack-gate.yaml#n1374 | 18:49 |
| *** yamamoto has joined #openstack-oslo | 18:50 | |
| *** yamamoto has quit IRC | 18:56 | |
| *** cdent has quit IRC | 18:59 | |
| harlowja_at_home | dims, thx | 19:02 |
| harlowja_at_home | will see if that's what the ironic folks are thinking/lookin for | 19:04 |
| *** arunkant has joined #openstack-oslo | 19:10 | |
| *** browne has quit IRC | 19:11 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 19:11 | |
| dims | sileht : dhellmann : this look ok? https://review.openstack.org/#/c/284330/ i can add tests if its worth it. it was noticed by arunkant in https://review.openstack.org/#/c/279828/ over in keystone channel | 19:16 |
| dims | harlowja_at_home : does the removal for kwarg look ok in that? ^^ | 19:16 |
| dhellmann | dims : some tests to verify the precedent order logic would be good, but the change looks fine to me | 19:18 |
| harlowja_at_home | agreed, looks ok | 19:18 |
| dhellmann | I can't comment on the removals(), I haven't used that before. | 19:18 |
| dims | cool thanks dhellmann and harlowja_at_home : let me add tests | 19:18 |
| harlowja_at_home | dims, http://docs.openstack.org/developer/debtcollector/api.html#debtcollector.renames.renamed_kwarg can also work, if that suites it better | 19:18 |
| harlowja_at_home | since u are renaming topic -> topics | 19:19 |
| dims | harlowja_at_home : y will switch | 19:20 |
| harlowja_at_home | cools | 19:20 |
| harlowja_at_home | man debtcollector so cool, lol | 19:25 |
| harlowja_at_home | who made that | 19:25 |
| harlowja_at_home | h | 19:25 |
| harlowja_at_home | ha | 19:25 |
| harlowja_at_home | ha | 19:25 |
| openstackgerrit | Joshua Harlow proposed openstack/futurist: Add what the watcher watches to the watcher as a property https://review.openstack.org/284367 | 19:26 |
| dims | LOL | 19:36 |
| *** browne has joined #openstack-oslo | 19:37 | |
| * harlowja_at_home to much coffeee ;) | 19:37 | |
| dims | dhellmann : harlowja_at_home : updated https://review.openstack.org/284330 with tests | 19:37 |
| dhellmann | dims : looking | 19:38 |
| *** yamahata has quit IRC | 19:41 | |
| harlowja_at_home | dims, do u want to use the replace option? | 19:41 |
| harlowja_at_home | that option, when enabled, allow u to just use topics in the new function signature | 19:41 |
| harlowja_at_home | and if topic gets passed in then, it will move topic -> topics | 19:41 |
| harlowja_at_home | woah i just found https://www.rdoproject.org/blog/2015/08/dims-talks-about-the-oslo-project/ | 19:42 |
| harlowja_at_home | lol | 19:42 |
| harlowja_at_home | dims, u so famous | 19:42 |
| harlowja_at_home | ha | 19:42 |
| harlowja_at_home | what replace does @ https://github.com/openstack/debtcollector/blob/master/debtcollector/renames.py#L36 | 19:43 |
| harlowja_at_home | seems like u want to use that | 19:43 |
| openstackgerrit | Merged openstack/oslo.context: Standardize an oslo.policy credentials dictionary https://review.openstack.org/271929 | 19:47 |
| openstackgerrit | Merged openstack/oslo.log: use log.warning instead of log.warn https://review.openstack.org/284242 | 19:53 |
| rbradfor | dims, I believe there are no reviews outstanding on oslo.context, everything is merged and project doesn't have dependencies. this has some work to unblock oslo.log work. No idea what pertains to requesting release? | 19:58 |
| openstackgerrit | Merged openstack/oslo.messaging: Improves poller's stop logic https://review.openstack.org/283622 | 20:05 |
| openstackgerrit | Merged openstack/oslo.middleware: work around doc build error https://review.openstack.org/284264 | 20:05 |
| *** zqfan has quit IRC | 20:12 | |
| *** yassine__ has quit IRC | 20:12 | |
| openstackgerrit | Joshua Harlow proposed openstack/futurist: Fix jitter strategies https://review.openstack.org/284390 | 20:13 |
| *** gordc has quit IRC | 20:18 | |
| *** cdent has joined #openstack-oslo | 20:28 | |
| *** cprm has joined #openstack-oslo | 20:30 | |
| *** dtardivel has quit IRC | 20:38 | |
| *** gordc has joined #openstack-oslo | 20:47 | |
| *** ihrachys has joined #openstack-oslo | 20:47 | |
| *** boris-42 has joined #openstack-oslo | 20:53 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.messaging: Allow Notifier to have multiple topics https://review.openstack.org/284330 | 20:57 |
| dims | rbradfor : harlowja_at_home : let's get this in please ^^ | 20:58 |
| rbradfor | dims, looking at it presently. | 20:58 |
| dims | rbradfor : i added the version and removal_version | 20:58 |
| rbradfor | dims, thanks | 20:59 |
| *** rlrossit has quit IRC | 20:59 | |
| rbradfor | my other comment was in response to replace=True, seems like you do not want to do that. | 20:59 |
| dims | rbradfor : right | 21:00 |
| dims | dhellmann rbradfor : do we need this for Mitaka? https://review.openstack.org/#/c/284270/ | 21:00 |
| dhellmann | dims : we should get patchbot set up in here :-) | 21:01 |
| dhellmann | dims : yeah, we should include that | 21:01 |
| dims | rbradfor : dhellmann : https://review.openstack.org/#/c/284270/ has my +2 now | 21:01 |
| dims | +1 dhellmann | 21:01 |
| *** achanda has quit IRC | 21:01 | |
| dims | for patchbot | 21:01 |
| rbradfor | dims, I'm just getting to appreciate debtcollector so my comments were related to its use (and I'm on a bit of a when you deprecate/remove stuff). I really have no knowledge of oslo.messaging (as yet) to say hey, this fixes the problem. | 21:02 |
| rbradfor | dhellmann, what is patchbot? | 21:02 |
| rbradfor | dhellmann, doing my last validation on https://review.openstack.org/#/c/284270/ | 21:02 |
| openstackgerrit | Ken Giusti proposed openstack/oslo.messaging: Fix a minor syntax error in a log statement https://review.openstack.org/284408 | 21:03 |
| rbradfor | dhellmann, removing clearly fixes the middleware docs things, investigating what that really does I just wanted to know | 21:03 |
| dhellmann | rbradfor : if you mention a patch, it looks up the title for you. notmyname operates it, IIRC | 21:03 |
| dhellmann | rbradfor : ack on the review | 21:04 |
| dims | notmyname: can you please add patchbot here? :) | 21:05 |
| dims | dhellmann : i added versions, so wiped out your +2, can you please re-look? https://review.openstack.org/#/c/284330/ | 21:06 |
| *** patchbot has joined #openstack-oslo | 21:06 | |
| dims | welcome patchbot | 21:06 |
| dhellmann | https://review.openstack.org/#/c/284330/ | 21:07 |
| patchbot | dhellmann: patch 284330 - oslo.messaging - Allow Notifier to have multiple topics | 21:07 |
| dhellmann | rbradfor : ^^ | 21:07 |
| dims | not very chatty are you patchbot ? :) | 21:07 |
| rbradfor | dhellmann, still unclear how that differs from openstackgerrit proposals? | 21:08 |
| *** Kennan has quit IRC | 21:08 | |
| dhellmann | rbradfor : openstackgerrit posts here when you submit a patch. patchbot watches for you to mention patches and gives you the subject line from them. | 21:08 |
| *** Kennan has joined #openstack-oslo | 21:08 | |
| rbradfor | dhellmann, ok, I see, would it be nice and smarter if you just went like review:284330 and it could get a url, and message. | 21:09 |
| dhellmann | rbradfor : maybe notmyname will take a patch | 21:09 |
| *** pcaruana has quit IRC | 21:10 | |
| dhellmann | rbradfor : although tbh I usually just paste the full link from the browser because it's faster than typing the # myself | 21:11 |
| rbradfor | dhellmann, yep in some cases, I guess I cut/pasted just the id to git review -d <n> a lot, so perhaps I was confusing things | 21:12 |
| dhellmann | rbradfor : sure, both cases make sense | 21:13 |
| *** ihrachys has quit IRC | 21:17 | |
| *** rlrossit_ has joined #openstack-oslo | 21:19 | |
| openstackgerrit | Sean M. Collins proposed openstack/oslo.concurrency: [WIP] Use tempfile to determine a temporary directory for lock_path https://review.openstack.org/284415 | 21:26 |
| *** salv-orl_ has joined #openstack-oslo | 21:27 | |
| *** salv-orlando has quit IRC | 21:29 | |
| kevinbenton | dims: ping | 21:32 |
| dims | kevinbenton : pong | 21:32 |
| kevinbenton | dims: is there a way to have an oslo config option default to the value of another oslo config option? | 21:33 |
| dims | kevinbenton : see $sqlite_db example on http://docs.openstack.org/developer/oslo.config/cfg.html | 21:34 |
| *** ekarlso- has quit IRC | 21:34 | |
| *** ekarlso- has joined #openstack-oslo | 21:34 | |
| kevinbenton | dims: can it reference another section? | 21:34 |
| dims | kevinbenton : i think both have to be in DEFAULT section (limitation) | 21:35 |
| openstackgerrit | Eric Brown proposed openstack/oslo.vmware: Move bandit into pep8 https://review.openstack.org/284423 | 21:35 |
| kevinbenton | dims: arg. trying to figure out the best way to deprecate an ML2 specific option and move it to a 'default' option | 21:35 |
| dims | dhellmann : ^^ thoughts? | 21:35 |
| openstackgerrit | Sean M. Collins proposed openstack/oslo.concurrency: [WIP] Use tempfile to determine a temporary directory for lock_path https://review.openstack.org/284415 | 21:36 |
| *** mtanino__ has joined #openstack-oslo | 21:41 | |
| rbradfor | kevinbenton, dims if you believe the docs, it says "You can use . to delimit option from other groups, e.g. ${mygroup.myoption}." | 21:42 |
| kevinbenton | rbradfor: i'll give it a shot. thx | 21:42 |
| dims | rbradfor : ah we must have fixed it :) | 21:42 |
| *** achanda has joined #openstack-oslo | 21:43 | |
| dims | looks like jd__ 's work :) https://github.com/openstack/oslo.config/commit/a5afcc22aaebb6ad5b671a2d5b345010ce19ac74 | 21:44 |
| *** achanda has quit IRC | 21:45 | |
| *** ndipanov has quit IRC | 21:45 | |
| rbradfor | kevinbenton, let us know if it works, I didn't know you could do this until this conversation | 21:46 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.middleware: Updated from global requirements https://review.openstack.org/282760 | 21:49 |
| dims | dhellmann : harlowja_at_home : let's get this in please https://review.openstack.org/#/c/284330/ | 21:51 |
| patchbot | dims: patch 284330 - oslo.messaging - Allow Notifier to have multiple topics | 21:51 |
| openstackgerrit | Merged openstack/oslo.config: remove redundant call to set explicit target https://review.openstack.org/284270 | 21:52 |
| *** kgiusti has left #openstack-oslo | 21:54 | |
| *** notmyname has joined #openstack-oslo | 21:59 | |
| notmyname | did patchbot make it in here | 21:59 |
| notmyname | (swift meeting is over) | 21:59 |
| notmyname | hello patchbot | 21:59 |
| notmyname | usage: patch 1234 | 22:00 |
| patchbot | notmyname: https://review.openstack.org/#/c/1234/ - tempest - Removing link doctoring in test_images (MERGED) | 22:00 |
| notmyname | and https://review.openstack.org/#/c/1234/ | 22:00 |
| patchbot | notmyname: patch 1234 - tempest - Removing link doctoring in test_images (MERGED) | 22:00 |
| notmyname | pm me if you have questions/issues with patchbot, or find me in #openstack-swift | 22:01 |
| notmyname | dims: dhellmann: ^ | 22:01 |
| *** regXboi has quit IRC | 22:01 | |
| dims | thanks notmyname | 22:01 |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.middleware: remove oslo_middleware.ssl from __init__.py https://review.openstack.org/284256 | 22:02 |
| *** notmyname has left #openstack-oslo | 22:03 | |
| *** dims has quit IRC | 22:14 | |
| openstackgerrit | Dmitriy Ukhlov proposed openstack/oslo.messaging: test https://review.openstack.org/284441 | 22:34 |
| *** gordc has quit IRC | 22:38 | |
| *** jecarey has quit IRC | 22:50 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 22:54 | |
| *** mriedem has quit IRC | 23:00 | |
| *** mdrabe has quit IRC | 23:03 | |
| *** cprm has quit IRC | 23:04 | |
| *** cprm has joined #openstack-oslo | 23:06 | |
| *** dims has joined #openstack-oslo | 23:08 | |
| *** yamamoto_ has joined #openstack-oslo | 23:08 | |
| *** rlrossit_ has quit IRC | 23:10 | |
| *** achanda has joined #openstack-oslo | 23:10 | |
| dims | zzzeek : DinaBelova found something interesting - https://bugs.launchpad.net/oslo.db/+bug/1549516 | 23:13 |
| openstack | Launchpad bug 1549516 in oslo.db "Too many reconnections to the SQLalchemy engine" [Undecided,New] | 23:13 |
| zzzeek | dims: the "SELECT 1" is not per connection | 23:14 |
| zzzeek | it's per connection use | 23:14 |
| DinaBelova | zzzeek so here https://github.com/openstack/oslo.db/blob/master/oslo_db/sqlalchemy/engines.py#L146 is done against engine_connect op | 23:14 |
| DinaBelova | is that connection usage? | 23:14 |
| DinaBelova | not the connection itself? | 23:14 |
| zzzeek | DinaBelova: that is checking out a connection from the pool | 23:15 |
| zzzeek | DinaBelova: also the "SELECT 1" is usually not a very latent thing, it's there for openstack's pessimistic disconnect detection | 23:15 |
| zzzeek | DinaBelova: do you have python profling that show actual *time* spent in the "SELECT 1" ? | 23:15 |
| DinaBelova | what I used was not the python profiling on the code level, but the osprofiler notifications processing https://dinabelova.github.io/nova-boot-keystone-cache-turn-on.html | 23:16 |
| DinaBelova | so it sends operation start/end notifications | 23:16 |
| zzzeek | DinaBelova: part of this might be that keystone does way too many individual connection uses | 23:17 |
| DinaBelova | so for keystone that is defined here https://review.openstack.org/#/c/103368/34/keystone/common/sql/core.py | 23:17 |
| patchbot | DinaBelova: patch 103368 - keystone - Integrate OSprofiler in Keystone | 23:17 |
| zzzeek | DinaBelova: the enginefacade refactor that nova and keystone are moving toawrds would theoretically reduce the number of "connects" as it will allow lots of smaller operations to correctly join into a single transaction | 23:17 |
| DinaBelova | zzzeek ok, so right now I see SELECT 1 per every operation in keystone, and per 1-2 db operations in Nova - is any OpenStack project already using enginefacade reactor so I can take a look on what's going on in these cases? | 23:20 |
| *** abitha has joined #openstack-oslo | 23:20 | |
| dims | DinaBelova : nova should be | 23:20 |
| dims | DinaBelova : the engine facade stuff merged a couple of weeks ago | 23:21 |
| DinaBelova | dims : ok, so for nova the situation looks better from what i see in https://dinabelova.github.io/nova-boot-oslodb-ping-listener-profiled.html - for nova SELECT 1 is happening per 3-4 operations | 23:22 |
| DinaBelova | i suppose neutron was moved to this approach as well from what I see in the trace | 23:23 |
| dims | bknudson : stevemar : ^^ | 23:23 |
| *** pradk has quit IRC | 23:24 | |
| *** vilobhmm11 has quit IRC | 23:25 | |
| dims | DinaBelova : ha! merged 4 hours ago :) https://review.openstack.org/#/c/257458/ | 23:25 |
| patchbot | dims: patch 257458 - keystone - Use the new enginefacade from oslo.db (MERGED) | 23:25 |
| *** vilobhmm11 has joined #openstack-oslo | 23:25 | |
| dims | bknudson : stevemar : never mind :) | 23:25 |
| DinaBelova | dims hahaha :D well, my env does not have it for sure :D | 23:25 |
| DinaBelova | ok, I'll check what the picture will be with this change applied | 23:26 |
| DinaBelova | :facepalm: I need to rebase keystone change again :D | 23:28 |
| *** dimtruck is now known as zz_dimtruck | 23:28 | |
| dims | DinaBelova : it's all good :) we fixed it 4 hours before we found it | 23:30 |
| DinaBelova | :D | 23:30 |
| zzzeek | DinaBelova: i dont think neutron moved yet, but their existing approach is already much more like enginefacade's | 23:31 |
| DinaBelova | zzzeek ack | 23:31 |
| zzzeek | DinaBelova: if nova can continue to modernize longer series of methods into one long transaction these select 1's wuld be reduced | 23:31 |
| zzzeek | DinaBelova: all DBAPI operations are in a transaction anyway so the driver emits BEGIN / COMMIT / ROLLBACK everytime as well | 23:31 |
| DinaBelova | ok, I'll recheck if my env has Nova change applied (I believe yes, I remember myself changing nova commit some time ago because of this), and will try keystone change agains the env | 23:32 |
| DinaBelova | zzzeek dims - will keep you updated | 23:32 |
| dims | zzzeek : thanks! | 23:35 |
| *** yamamoto_ has quit IRC | 23:38 | |
| *** cdent has quit IRC | 23:47 | |
| *** cprm has quit IRC | 23:52 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!