openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.log: Remove bandit.yaml in favor of defaults https://review.openstack.org/276508 | 00:05 |
---|---|---|
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.messaging: Remove bandit.yaml in favor of defaults https://review.openstack.org/276507 | 00:11 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.service: Remove bandit.yaml in favor of defaults https://review.openstack.org/276509 | 00:13 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.messaging: Remove bandit.yaml in favor of defaults https://review.openstack.org/276507 | 00:14 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.utils: Remove bandit.yaml in favor of defaults https://review.openstack.org/276510 | 00:16 |
openstackgerrit | Merged openstack/oslo.utils: Updated from global requirements https://review.openstack.org/276402 | 00:33 |
openstackgerrit | Merged openstack/oslo.service: Updated from global requirements https://review.openstack.org/276401 | 00:35 |
*** mss-4 has quit IRC | 00:37 | |
*** dims_ has joined #openstack-oslo | 00:39 | |
openstackgerrit | Merged openstack/oslo.log: Updated from global requirements https://review.openstack.org/276399 | 00:40 |
*** dims has quit IRC | 00:40 | |
*** sputnik13 has quit IRC | 00:41 | |
openstackgerrit | Merged openstack/oslo.messaging: Updated from global requirements https://review.openstack.org/276400 | 00:42 |
*** salv-orl_ has quit IRC | 00:54 | |
*** Jokke__ has joined #openstack-oslo | 01:06 | |
*** Jokke__ has quit IRC | 01:06 | |
*** mtanino has quit IRC | 01:34 | |
openstackgerrit | Merged openstack/oslo.config: Updated from global requirements https://review.openstack.org/276398 | 02:04 |
*** edmondsw has quit IRC | 02:10 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Work on fix for timeout of tasks (WIP) https://review.openstack.org/276536 | 02:16 |
openstackgerrit | Merged openstack/oslosphinx: Add version and download badges to README https://review.openstack.org/275965 | 02:17 |
*** davidlenwell has quit IRC | 02:18 | |
*** davidlenwell has joined #openstack-oslo | 02:19 | |
*** vilobhmm11 has quit IRC | 02:21 | |
*** yamamoto_ has joined #openstack-oslo | 02:21 | |
*** zz_dimtruck is now known as dimtruck | 02:22 | |
*** davidlenwell has quit IRC | 02:23 | |
*** davidlenwell has joined #openstack-oslo | 02:27 | |
*** achanda has joined #openstack-oslo | 02:42 | |
dims_ | gus : ping about oslo.privsep..is there a TODO list? | 02:44 |
*** browne has quit IRC | 03:00 | |
openstackgerrit | Merged openstack/oslo.versionedobjects: Make sure functions in child object registries work https://review.openstack.org/270117 | 03:07 |
openstackgerrit | Merged openstack/oslo.privsep: Add version and download badges to README https://review.openstack.org/275964 | 03:09 |
*** dimtruck is now known as zz_dimtruck | 03:13 | |
openstackgerrit | Merged openstack/oslo.messaging: [zmq] RPC timeout for CAST https://review.openstack.org/274013 | 03:14 |
*** eliqiao has quit IRC | 03:15 | |
*** zz_dimtruck is now known as dimtruck | 03:21 | |
*** dims_ has quit IRC | 03:33 | |
*** browne has joined #openstack-oslo | 03:37 | |
*** dimtruck is now known as zz_dimtruck | 03:37 | |
*** browne has quit IRC | 03:38 | |
*** yamahata has quit IRC | 03:44 | |
openstackgerrit | Merged openstack/oslo.service: Fix test execution on CentOS 7 https://review.openstack.org/265338 | 03:47 |
*** achanda has quit IRC | 03:59 | |
*** vilobhmm11 has joined #openstack-oslo | 04:32 | |
*** vilobhmm11 has quit IRC | 04:33 | |
*** links has joined #openstack-oslo | 04:43 | |
*** jeckersb is now known as jeckersb_gone | 04:53 | |
*** achanda has joined #openstack-oslo | 04:58 | |
*** vilobhmm11 has joined #openstack-oslo | 05:01 | |
*** dkehn has quit IRC | 05:05 | |
*** dkehn has joined #openstack-oslo | 05:05 | |
*** salv-orlando has joined #openstack-oslo | 05:08 | |
*** amotoki has joined #openstack-oslo | 05:11 | |
*** salv-orlando has quit IRC | 05:18 | |
openstackgerrit | Merged openstack/oslo.db: exception: fix InvalidSortKey message https://review.openstack.org/274867 | 05:44 |
openstackgerrit | Merged openstack/oslo.db: exceptions: enhance InvalidSortKey to carry the invalid key https://review.openstack.org/274868 | 05:44 |
*** yamamoto_ has quit IRC | 06:09 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.utils: Imported Translations from Zanata https://review.openstack.org/275023 | 06:14 |
*** achanda has quit IRC | 06:19 | |
*** nkrinner has joined #openstack-oslo | 06:19 | |
*** achanda has joined #openstack-oslo | 06:20 | |
openstackgerrit | Merged openstack/futurist: Allow PeriodicWorker to skip executor shutdown in case of a preexisting executor https://review.openstack.org/275326 | 06:38 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Fix for WBE sporadic timeout of tasks https://review.openstack.org/276536 | 06:39 |
*** yamamoto_ has joined #openstack-oslo | 06:44 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Fix for WBE sporadic timeout of tasks https://review.openstack.org/276536 | 06:48 |
*** links has quit IRC | 07:04 | |
*** stevemar has joined #openstack-oslo | 07:06 | |
*** links has joined #openstack-oslo | 07:14 | |
openstackgerrit | Dmitriy Ukhlov proposed openstack/oslo.messaging: Switches pika driver to eager connection to RabbitMQ https://review.openstack.org/274255 | 07:21 |
*** e0ne has joined #openstack-oslo | 07:30 | |
openstackgerrit | Merged openstack/oslo.vmware: Remove bandit.yaml in favor of defaults https://review.openstack.org/276472 | 07:45 |
*** eliqiao has joined #openstack-oslo | 07:53 | |
*** zakora has joined #openstack-oslo | 08:21 | |
*** dtardivel has joined #openstack-oslo | 08:30 | |
*** ihrachys has joined #openstack-oslo | 08:43 | |
*** salv-orlando has joined #openstack-oslo | 08:45 | |
*** salv-orlando has quit IRC | 08:49 | |
*** ihrachys has quit IRC | 08:53 | |
*** salv-orlando has joined #openstack-oslo | 09:00 | |
*** EinstCrazy has quit IRC | 09:01 | |
*** EinstCrazy has joined #openstack-oslo | 09:02 | |
haypo | morning | 09:04 |
*** EinstCrazy has quit IRC | 09:07 | |
*** vilobhmm11 has quit IRC | 09:08 | |
*** openstackgerrit has quit IRC | 09:17 | |
*** openstackgerrit has joined #openstack-oslo | 09:17 | |
*** yassine has joined #openstack-oslo | 09:17 | |
*** lucas-dinner is now known as lucasagomes | 09:22 | |
*** achanda has quit IRC | 09:31 | |
*** ihrachys has joined #openstack-oslo | 09:33 | |
*** ihrachys has quit IRC | 09:35 | |
*** stevemar has quit IRC | 09:35 | |
*** stevemar has joined #openstack-oslo | 09:36 | |
*** mkoderer has joined #openstack-oslo | 09:36 | |
*** mkoderer has left #openstack-oslo | 09:36 | |
*** mkoderer has joined #openstack-oslo | 09:37 | |
*** stevemar has quit IRC | 09:40 | |
*** ihrachys has joined #openstack-oslo | 09:44 | |
*** ihrachys has quit IRC | 09:51 | |
*** mhickey has joined #openstack-oslo | 09:51 | |
*** boris-42 has joined #openstack-oslo | 09:52 | |
*** ihrachys has joined #openstack-oslo | 09:53 | |
*** ihrachys has quit IRC | 10:02 | |
*** ihrachys has joined #openstack-oslo | 10:05 | |
*** ihrachys has quit IRC | 10:08 | |
*** ihrachys has joined #openstack-oslo | 10:08 | |
*** yamamoto_ has quit IRC | 10:15 | |
*** yamamoto_ has joined #openstack-oslo | 10:17 | |
*** EinstCrazy has joined #openstack-oslo | 10:22 | |
*** ihrachys has quit IRC | 10:24 | |
*** bnemec has joined #openstack-oslo | 10:25 | |
*** ihrachys has joined #openstack-oslo | 10:25 | |
*** ihrachys has quit IRC | 10:30 | |
*** ihrachys has joined #openstack-oslo | 10:31 | |
haypo | jd__: it looks like your forgot to fix DBInvalidUnicodeParameter https://review.openstack.org/#/c/274867/1/oslo_db/exception.py | 10:33 |
*** EinstCrazy has quit IRC | 10:35 | |
*** ihrachys has quit IRC | 10:36 | |
*** EinstCrazy has joined #openstack-oslo | 10:36 | |
*** stevemar has joined #openstack-oslo | 10:37 | |
*** salv-orl_ has joined #openstack-oslo | 10:39 | |
*** stevemar has quit IRC | 10:40 | |
*** EinstCrazy has quit IRC | 10:40 | |
*** salv-orlando has quit IRC | 10:42 | |
*** e0ne has quit IRC | 10:57 | |
*** jeckersb_gone has quit IRC | 11:11 | |
*** jokke_ has quit IRC | 11:12 | |
*** toabctl_ has quit IRC | 11:12 | |
*** jokke_ has joined #openstack-oslo | 11:13 | |
*** jeckersb_gone has joined #openstack-oslo | 11:16 | |
*** toabctl has joined #openstack-oslo | 11:17 | |
*** yamamoto_ has quit IRC | 11:18 | |
*** bnemec has quit IRC | 11:31 | |
*** mss-4 has joined #openstack-oslo | 11:34 | |
*** mss-4 has quit IRC | 11:38 | |
*** dims has joined #openstack-oslo | 11:46 | |
*** e0ne has joined #openstack-oslo | 11:55 | |
*** salv-orl_ has quit IRC | 12:01 | |
*** mkoderer__ has joined #openstack-oslo | 12:04 | |
mkoderer__ | dims: I am thinking about a CLI tool for stevedore. IMHO it would be useful to list all installed plugins | 12:05 |
mkoderer__ | dims: what do you think? | 12:05 |
dims | mkoderer__ : sure, would be very handy | 12:05 |
mkoderer__ | dims: do you think it can live in stevedore directly? So this would add a cliff dependency | 12:06 |
dims | mkoderer__ : we could add it as an optional dependency so it's not installed always. | 12:12 |
mkoderer__ | dims: aha ok didn't know that this is possible. I will have a look | 12:13 |
dims | mkoderer : example http://git.openstack.org/cgit/openstack/glance_store/tree/setup.cfg#n53 | 12:16 |
*** pkholkin has quit IRC | 12:18 | |
*** yamamoto has joined #openstack-oslo | 12:19 | |
*** yamamoto has quit IRC | 12:25 | |
*** EinstCrazy has joined #openstack-oslo | 12:29 | |
*** salv-orlando has joined #openstack-oslo | 12:29 | |
*** gordc has joined #openstack-oslo | 12:33 | |
*** stevemar has joined #openstack-oslo | 12:35 | |
*** lucasagomes is now known as lucas-hungry | 12:35 | |
*** EinstCrazy has quit IRC | 12:36 | |
*** stevemar has quit IRC | 12:38 | |
openstackgerrit | Oleksii Zamiatin proposed openstack/oslo.messaging: WIP: [zmq] Test linger default value https://review.openstack.org/276710 | 12:43 |
*** links has quit IRC | 12:43 | |
*** mtanino has joined #openstack-oslo | 12:50 | |
*** jaypipes has quit IRC | 13:00 | |
*** krotscheck has joined #openstack-oslo | 13:01 | |
*** jaypipes has joined #openstack-oslo | 13:04 | |
*** tcammann has joined #openstack-oslo | 13:12 | |
*** salv-orlando has quit IRC | 13:13 | |
*** yassine_ has joined #openstack-oslo | 13:18 | |
*** tcammann has quit IRC | 13:19 | |
*** tcammann has joined #openstack-oslo | 13:20 | |
*** yassine has quit IRC | 13:20 | |
jd__ | haypo: https://review.openstack.org/#/c/276253/1 | 13:21 |
*** boris-42 has quit IRC | 13:23 | |
*** tcammann has quit IRC | 13:25 | |
*** kgiusti has joined #openstack-oslo | 13:27 | |
*** jeckersb_gone is now known as jeckersb | 13:31 | |
*** pradk has joined #openstack-oslo | 13:32 | |
*** edmondsw has joined #openstack-oslo | 13:34 | |
*** takedakn has joined #openstack-oslo | 13:34 | |
*** cdent has joined #openstack-oslo | 13:40 | |
*** ihrachys has joined #openstack-oslo | 13:50 | |
*** ihrachys has quit IRC | 13:54 | |
haypo | jd__: haha, unit test on exception message. i like that | 13:55 |
*** takedakn has quit IRC | 14:00 | |
*** lucas-hungry is now known as lucasagomes | 14:00 | |
*** rlrossit has joined #openstack-oslo | 14:11 | |
*** takedakn has joined #openstack-oslo | 14:12 | |
*** salv-orlando has joined #openstack-oslo | 14:13 | |
*** mkoderer__ has quit IRC | 14:16 | |
*** mkoderer__ has joined #openstack-oslo | 14:17 | |
*** yamamoto has joined #openstack-oslo | 14:24 | |
*** nkrinner has quit IRC | 14:24 | |
*** salv-orlando has quit IRC | 14:30 | |
*** takedakn has quit IRC | 14:31 | |
*** amotoki has quit IRC | 14:37 | |
*** regXboi has joined #openstack-oslo | 14:47 | |
openstackgerrit | Oleksii Zamiatin proposed openstack/oslo.messaging: WIP: [zmq] Test linger default value https://review.openstack.org/276710 | 14:49 |
*** mriedem has joined #openstack-oslo | 14:57 | |
*** yamamoto has quit IRC | 15:01 | |
*** pradk has quit IRC | 15:03 | |
*** pradk has joined #openstack-oslo | 15:03 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 15:10 | |
*** zz_dimtruck is now known as dimtruck | 15:12 | |
*** amotoki has joined #openstack-oslo | 15:14 | |
*** mhickey has quit IRC | 15:14 | |
*** mhickey has joined #openstack-oslo | 15:15 | |
*** nikhil_k is now known as nikhil | 15:17 | |
*** yamamoto has joined #openstack-oslo | 15:29 | |
*** yamamoto has quit IRC | 15:31 | |
*** yamamoto has joined #openstack-oslo | 15:32 | |
*** yamamoto has quit IRC | 15:37 | |
*** bnemec has joined #openstack-oslo | 15:39 | |
*** amotoki has quit IRC | 15:40 | |
*** yamamoto has joined #openstack-oslo | 15:42 | |
*** yamamoto has quit IRC | 15:44 | |
*** david-lyle has joined #openstack-oslo | 15:47 | |
openstackgerrit | Ivan Kolodyazhny proposed openstack/oslo.reports: Use file modification events instead of signal handler https://review.openstack.org/260976 | 15:48 |
*** amotoki has joined #openstack-oslo | 15:54 | |
*** mgarza has joined #openstack-oslo | 15:55 | |
*** nkrinner has joined #openstack-oslo | 15:57 | |
*** bnemec has quit IRC | 15:59 | |
*** bnemec has joined #openstack-oslo | 16:00 | |
*** cburgess_ has joined #openstack-oslo | 16:05 | |
*** mhickey has quit IRC | 16:11 | |
*** bnemec has quit IRC | 16:13 | |
*** cburgess has quit IRC | 16:14 | |
*** ozamiatin has quit IRC | 16:14 | |
*** ozamiatin has joined #openstack-oslo | 16:17 | |
*** david-lyle has quit IRC | 16:23 | |
*** dimtruck is now known as zz_dimtruck | 16:23 | |
*** yassine_ has quit IRC | 16:25 | |
openstackgerrit | Merged openstack/oslo.db: exception: fix DBInvalidUnicodeParameter error message https://review.openstack.org/276253 | 16:26 |
*** mss-4 has joined #openstack-oslo | 16:27 | |
*** zakora has quit IRC | 16:28 | |
*** david-lyle has joined #openstack-oslo | 16:29 | |
*** zz_dimtruck is now known as dimtruck | 16:33 | |
*** harlowja_at_home has joined #openstack-oslo | 16:34 | |
*** dimtruck is now known as zz_dimtruck | 16:35 | |
*** e0ne has quit IRC | 16:37 | |
*** shardy has joined #openstack-oslo | 16:43 | |
*** yamamoto has joined #openstack-oslo | 16:45 | |
sdague | dims: oslo.cache is .... quite verbose | 16:45 |
sdague | http://logs.openstack.org/54/276554/1/check/gate-tempest-dsvm-full/3de1525/logs/apache/keystone.txt.gz#_2016-02-05_04_50_21_885880 | 16:45 |
dims | sdague : ack we merged a oslo.log change to make it less chatty | 16:45 |
sdague | it looks like we're getting 20 - 30 debug lines out of oslo.cache for every keystone request | 16:45 |
sdague | dims: ok, but should those be there at all? | 16:45 |
dims | looking | 16:46 |
sdague | it seems like just turning up the log level isn't the right fix | 16:46 |
sdague | locally I'm seeing this kind of spike apache load | 16:46 |
harlowja_at_home | other option is to switch some of those to TRACE and leave the log level as is... | 16:46 |
sdague | sure, though, I guess is it really useful now that the lib is released? | 16:47 |
sdague | can we not just check for an aberant behavior and only log on that | 16:47 |
dims | bknudson_ : ^^ | 16:47 |
harlowja_at_home | i thought the other change was to make dogpiple also less chatty | 16:48 |
harlowja_at_home | so even if we make oslo.cache dogpile will be chatty still :-/ | 16:48 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Fix for WBE sporadic timeout of tasks https://review.openstack.org/276536 | 16:49 |
dims | harlowja_at_home : some of these are from here http://git.openstack.org/cgit/openstack/oslo.cache/tree/oslo_cache/_memcache_pool.py#n112 | 16:49 |
harlowja_at_home | right | 16:50 |
dims | harlowja_at_home : guess we can switch those to trace instead of debug | 16:50 |
harlowja_at_home | i get why they exist, helpfully when debugging | 16:50 |
harlowja_at_home | but maybe trace more appropriate? | 16:50 |
bknudson_ | caching was enabled in devstack recently. | 16:50 |
*** yamamoto has quit IRC | 16:51 | |
bknudson_ | I agree these don't look useful | 16:51 |
*** e0ne has joined #openstack-oslo | 16:52 | |
bknudson_ | oslo.log change: https://review.openstack.org/#/c/274510/ | 16:54 |
bknudson_ | set oslo.cache and dogpile to INFO | 16:54 |
*** sputnik13 has joined #openstack-oslo | 17:00 | |
*** sputnik13 has quit IRC | 17:02 | |
*** stevemar has joined #openstack-oslo | 17:03 | |
openstackgerrit | Joshua Harlow proposed openstack/oslo.cache: Move some of these noisy logs to trace level https://review.openstack.org/276835 | 17:09 |
harlowja_at_home | bknudson_, dims sdague ^ | 17:09 |
*** david-lyle has quit IRC | 17:14 | |
*** achanda has joined #openstack-oslo | 17:15 | |
*** harlowja_at_home has quit IRC | 17:17 | |
*** stevemar has quit IRC | 17:17 | |
*** stevemar has joined #openstack-oslo | 17:18 | |
*** david-lyle has joined #openstack-oslo | 17:21 | |
*** stevemar has quit IRC | 17:22 | |
*** david-lyle has quit IRC | 17:25 | |
*** lucasagomes is now known as lucas-dinner | 17:27 | |
*** mriedem is now known as mriedem_afk | 17:31 | |
dims | dhellmann : whoa! just got the packet, the oslo jacket is kick-ass! was expecting the t-shirt :) | 17:33 |
dims | dhellmann : thanks! | 17:33 |
dhellmann | I thought you'd enjoy that, it seemed nice and warm. :-) | 17:34 |
dims | dhellmann : just in time, we got about 6-8 inches today :) | 17:36 |
dhellmann | :-) | 17:37 |
*** sigmavirus24 is now known as sigmavirus24_awa | 17:39 | |
*** amotoki has quit IRC | 17:45 | |
*** zz_dimtruck is now known as dimtruck | 17:49 | |
*** e0ne has quit IRC | 17:51 | |
*** salv-orlando has joined #openstack-oslo | 17:55 | |
sdague | harlowja: is there a reason these are actually useful messages outside of developing the library? | 17:57 |
sdague | that's the part I'm not sure I understand, like why they don't just get deleted | 17:58 |
dims | sdague : talking to memcached has been a big thorn in some of the production environments, so i'd support having traces on these | 18:01 |
sdague | dims: and it wedges in a way that no error condition is triggered | 18:02 |
sdague | ? | 18:02 |
sdague | I just want to challenge the notion that the right approach for finding production issues is log every step of the possitive path, vs. asserting when things don't look right, and logging the errors. | 18:04 |
sdague | especially as this amount of output basically cripples the apache servers. I tripped over this because apache was running flat out on 3 cores just processing output | 18:06 |
*** achanda has quit IRC | 18:06 | |
sdague | for logs | 18:06 |
sdague | so turning on these traces is going to change the performance profile quite a lot | 18:06 |
*** dtardivel has quit IRC | 18:08 | |
*** nikhil_k has joined #openstack-oslo | 18:11 | |
*** nikhil has quit IRC | 18:14 | |
*** dansmith is now known as superdan | 18:16 | |
*** achanda has joined #openstack-oslo | 18:18 | |
harlowja | i imagine if there is a bug somewhere in the library and there is misunderstanding as to what's going on then well knowing when a connection is in the pool or not might be quite useful to know | 18:19 |
harlowja | but i do get that challenge, and the balance isn't always easy to find | 18:20 |
sdague | right, but if we go with that theory we're basically going to put line by line tracing into all our libraries, which seems excessive. | 18:22 |
harlowja | imho sdague i do start to wonder if we need to rethink our logging guidelines (especially around DEBUG/TRACE) because it seems somewhat like we (openstack devs and users) are fighting an uphill battle in doing what u say | 18:22 |
sdague | harlowja: in what way? | 18:22 |
harlowja | changing the world to our ideas on DEBUG/TRACE likely will never happen, so perhaps we should reevaluate how the bigger world uses DEBUG/TRACE | 18:22 |
sdague | I mean, there are many uphill battles, so mostly I wanted to be specific about it | 18:22 |
harlowja | DEBUG/TRACE being used by most 3rd party libraries and all in different ways than i think we view it to be used | 18:23 |
harlowja | just a thought i was thinking on the way to work :-P | 18:23 |
sdague | harlowja: yes, 3rd party libraries are all over the map here | 18:23 |
harlowja | right | 18:23 |
sdague | but it's not like they all have a different idea than us | 18:23 |
sdague | they all have different ideas from each other as well | 18:24 |
harlowja | ya, which makes me think its a larger python community issue/battle | 18:24 |
*** sputnik13 has joined #openstack-oslo | 18:25 | |
sdague | ok, that is a battle, all on it's own. And is a problem because oslo.log isn't a log engine, it's a setup tool for python logging | 18:25 |
*** stevemar has joined #openstack-oslo | 18:25 | |
harlowja | right | 18:25 |
sdague | but that's kind of different from the stuff we have under our control | 18:25 |
sdague | for the stuff under our control, we should be confident that it does the right thing in the main path and not step log everything | 18:25 |
sdague | if we are not confident in that, we should add more tests | 18:26 |
sdague | and we should clearly log any exceptional behavior | 18:26 |
harlowja | ya, i guess the weird part becomes when interacting with other systems, where a log message (at debug or trace) that shows main path will actually be useful in figuring out why the interaction is messed up | 18:27 |
harlowja | but maybe we should recommend more pdb for that | 18:27 |
harlowja | (except ya, eventlet makes that hard) | 18:27 |
sdague | that feels to me like the library contract wasn't defined | 18:27 |
sdague | if everything works down here, but goes nutters at a higher level | 18:27 |
sdague | I get that if there is a specific bug people are trying to sort out, adding stuff like this is fine in the short run | 18:28 |
sdague | but it really shouldn't be part of normal main path code | 18:28 |
harlowja | how would u turn it on then if its not in the code? | 18:29 |
harlowja | __debug__ ? | 18:29 |
harlowja | ie, deleting it would mean person fixing bug would have to patch it back in | 18:29 |
harlowja | * https://docs.python.org/2/library/constants.html#__debug__ (this could do it i guess) | 18:29 |
*** dims is now known as dimsum__ | 18:30 | |
harlowja | although idk if most people know about that, lol | 18:30 |
harlowja | its also what causes the assert statement to be a noop | 18:30 |
sdague | I'm not saying it's there to turn on. I'm saying that code only gets instrumented like this when chasing an active bug. | 18:30 |
harlowja | right, so maybe __debug__ then | 18:31 |
harlowja | which is as close as i know to something like #ifdef debug, lol | 18:31 |
sdague | I think we're talking past each other | 18:32 |
harlowja | maybe | 18:32 |
harlowja | lol | 18:32 |
sdague | I'm not saying put this behind __debug__ | 18:32 |
sdague | I'm saying delete all this logging | 18:32 |
harlowja | right, which then someone who wants it has to put it all back in | 18:33 |
sdague | at some future date, if there is a registered bug people are working on, put in appropriate trace logging if required to solve that | 18:33 |
harlowja | and re-release lib? | 18:33 |
harlowja | or just temporarily? | 18:33 |
sdague | and once the bug is addressed, pull it out and go forward | 18:33 |
sdague | temporarily | 18:33 |
*** lxsli_web has quit IRC | 18:34 | |
sdague | in a release if you really need to | 18:34 |
sdague | but don't make that the norm | 18:34 |
harlowja | ya, i guess that depends on if people can actually change code that easy to mess with bugs | 18:34 |
harlowja | sometimes u can't change code, but can change a log level, and changing the log level can help u figure out the bug | 18:35 |
harlowja | *in an older version that is | 18:35 |
harlowja | i know i can't go on a production hypervisor, and alter code, but can request logging levels to change temporarily if i suspect some memcache bug is happening | 18:36 |
harlowja | (hypothetical situation) | 18:36 |
sdague | and kill your keystone in the process? | 18:36 |
harlowja | hopefully one of X keystones goes down, where X is not all of them | 18:37 |
sdague | because that seems highly on the hypothetical based on the loads I was seeing here. It makes the assumption that flipping on this giant amount of verbose logging means you get the same code executing | 18:37 |
sdague | which you don't | 18:37 |
sdague | every log message means a new eventlet greenlet context switch point, because it's IO | 18:38 |
harlowja | yup | 18:38 |
sdague | so what you are saying is "I might have a bug. I'll turn on this option. Now I won't be running any of the same flows, but I'll debug those." | 18:38 |
sdague | which doesn't seem like a good approach | 18:39 |
harlowja | depends on the situation i think, it might be good enough | 18:39 |
sdague | everything might be good enough. | 18:39 |
harlowja | lol | 18:39 |
sdague | ok, I'm kind of exhausted by this. But massively frustrated that the new model here seems to be step logging every function. | 18:40 |
harlowja | take a deep breath | 18:40 |
harlowja | everything will be ok | 18:40 |
sdague | honestly, it won't, we released a library that is supposed to increase performance that instead made it worse | 18:41 |
sdague | and the fix is tweak oslo.log, but hope that no one does custom python logging rules, because if so, they won't get that, and they'll take the perf hit | 18:41 |
dimsum__ | sdague : here's an example https://bugs.launchpad.net/mos/+bug/1516737 with keystone log paste - http://paste.openstack.org/show/479017/ | 18:41 |
openstack | Launchpad bug 1516737 in Mirantis OpenStack "Keystone returns 500 deque index out of range" [High,Invalid] - Assigned to MOS Keystone (mos-keystone) | 18:41 |
dimsum__ | sdague : what's the perf hit when folks are supposed to be at DEBUG level and we are doing this at TRACE level? | 18:42 |
sdague | dimsum__: that should be covered by logging the exceptional cases | 18:42 |
dimsum__ | clearly we have no clue where the problem is coming from | 18:43 |
dimsum__ | if we did we would have :) | 18:43 |
*** browne has joined #openstack-oslo | 18:44 | |
sdague | dimsum__: because I think that if we default to step trace logging, then people will just assume that's good enough and not think about having the code figure out it's in an aberant state, someone can just read 100 GB of logs, build and analysis engine, and handle it there | 18:45 |
sdague | like I said, if we don't test the code, build test cases for it | 18:45 |
sdague | sorry, if we don't trust the code | 18:45 |
sdague | catching this at a full stack level is going to take forever and be error prone | 18:45 |
sdague | see: gate debugging | 18:45 |
dimsum__ | sdague : yep, problem is this is occuring under really heavy load :( | 18:45 |
sdague | dimsum__: right, which is *way* easier to trigger at the library than in a full stack | 18:46 |
sdague | start up oslo.cache against a memcache | 18:46 |
dimsum__ | sdague : i wish :( been struggling with this for a long while | 18:47 |
sdague | fork 100 workers, beat the crap out of it | 18:47 |
*** sputnik13 has quit IRC | 18:47 | |
dimsum__ | sdague : we haven't done this with oslo.cache yet | 18:47 |
dimsum__ | this was the older code in keystone | 18:47 |
dimsum__ | sdague : going to try some stress tests with keystone and nova both hitting memcached soon-ish | 18:48 |
sdague | cool, that should be a much better approach | 18:49 |
*** e0ne has joined #openstack-oslo | 18:50 | |
*** shardy has quit IRC | 18:59 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Don't bother scanning for workers if no new messages arrived https://review.openstack.org/276872 | 19:00 |
*** sputnik13 has joined #openstack-oslo | 19:03 | |
dimsum__ | harlowja : here's tricky one since you like osprofiler :) https://bugs.launchpad.net/osprofiler/+bug/1440027 | 19:04 |
openstack | Launchpad bug 1440027 in osprofiler "osprofiler is Incompatibe with staticmethod within a class" [Undecided,New] | 19:04 |
harlowja | eck | 19:04 |
harlowja | don't use @profiler.trace_cls imho | 19:04 |
harlowja | lol | 19:04 |
dimsum__ | apparently jobs are failing https://bugs.launchpad.net/cinder/+bug/1541996 | 19:05 |
openstack | Launchpad bug 1440027 in osprofiler "duplicate for #1541996 osprofiler is Incompatibe with staticmethod within a class" [Undecided,New] | 19:05 |
harlowja | DinaBelova was working on some of that stuff | 19:05 |
harlowja | i wonder if her fix fixed up that | 19:05 |
dimsum__ | DinaBelova : ping | 19:05 |
harlowja | https://review.openstack.org/#/c/269860/ dimsum__ | 19:06 |
harlowja | maybe just needs a release? | 19:06 |
dimsum__ | we gotta talk to boris about +2A's | 19:06 |
DinaBelova | harlowja dimsum__ yep, this included to the release | 19:07 |
DinaBelova | 1.0.0. | 19:07 |
DinaBelova | of osprofiler | 19:07 |
harlowja | boris not around, lol | 19:07 |
harlowja | boris in hiding? | 19:07 |
DinaBelova | @harlowja @dimsum__ https://review.openstack.org/#/c/269860/ | 19:07 |
harlowja | right | 19:07 |
dimsum__ | DinaBelova : is that in the release? | 19:08 |
harlowja | DinaBelova https://bugs.launchpad.net/osprofiler/+bug/1440027/comments/2 :-/ | 19:08 |
openstack | Launchpad bug 1440027 in osprofiler "osprofiler is Incompatibe with staticmethod within a class" [Undecided,New] | 19:08 |
harlowja | maybe still an issue? | 19:08 |
DinaBelova | yes, it's included to 1.0.0 | 19:08 |
harlowja | 'I've submitted a requirements patch to prevent 1.0.0' | 19:08 |
dimsum__ | DinaBelova : please make sure reviews get 2 +2's | 19:08 |
harlowja | prevent there | 19:08 |
harlowja | https://review.openstack.org/#/c/276761/ DinaBelova | 19:08 |
harlowja | :-/ | 19:08 |
DinaBelova | very strange | 19:09 |
DinaBelova | Nova gates were failing without this commit | 19:09 |
DinaBelova | and now - nope | 19:09 |
harlowja | weird | 19:09 |
harlowja | makes me wonder if they are using some other version | 19:11 |
DinaBelova | or probably it's other issue | 19:12 |
DinaBelova | that looks similar | 19:12 |
harlowja | maybe | 19:13 |
*** sigmavirus24_awa is now known as sigmavirus24 | 19:14 | |
*** nkrinner has quit IRC | 19:14 | |
dimsum__ | DinaBelova : osprofiler===1.0.0 http://openstack-logs.purestorage.com/19/275919/1/check/PureFCDriver-tempest-dsvm-volume-multipath/21e6a5e/logs/pip-freeze.txt.gz | 19:14 |
DinaBelova | dimsum__ I see | 19:15 |
dimsum__ | line number matches too | 19:15 |
DinaBelova | that's really strange, nova gates are feeling ok with this osprofiler version | 19:17 |
dimsum__ | i know | 19:17 |
*** stevemar has quit IRC | 19:20 | |
*** vilobhmm11 has joined #openstack-oslo | 19:20 | |
*** stevemar has joined #openstack-oslo | 19:20 | |
*** salv-orlando has quit IRC | 19:24 | |
*** stevemar has quit IRC | 19:24 | |
*** pradk has quit IRC | 19:27 | |
*** bauzas is now known as bauwser | 19:27 | |
harlowja | DinaBelova dimsum__ ok i see it | 19:28 |
harlowja | u guys figure it out yet :-P | 19:28 |
dimsum__ | he is calling a static method with self? | 19:28 |
dimsum__ | he/she i mean | 19:28 |
harlowja | nope | 19:28 |
harlowja | lol | 19:28 |
dimsum__ | :) | 19:29 |
dimsum__ | that was a wild guess | 19:29 |
dimsum__ | what's the verdict? :) | 19:29 |
harlowja | lol | 19:29 |
harlowja | https://gist.github.com/harlowja/b3f9c920c3a6951128b5 | 19:29 |
harlowja | https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L241 | 19:29 |
harlowja | ^ that isn't a class | 19:29 |
DinaBelova | if so error about args number will be called | 19:29 |
harlowja | but its applying the trace_cls decorator to a driver object.... | 19:29 |
*** rlrossit has quit IRC | 19:29 | |
harlowja | gist causes same thing to happen | 19:29 |
harlowja | idk whats up with #L241 there | 19:30 |
harlowja | lol | 19:30 |
harlowja | bb | 19:30 |
DinaBelova | harlowja for this purpose there is this line https://github.com/openstack/osprofiler/blob/master/osprofiler/profiler.py#L151 | 19:33 |
harlowja | hmmm | 19:33 |
*** rlrossit_ has joined #openstack-oslo | 19:34 | |
harlowja | why people using trace_cls on things not classes, lol | 19:34 |
harlowja | weird | 19:34 |
dimsum__ | harlowja : like this? http://paste.openstack.org/show/486132/ | 19:34 |
DinaBelova | even if they are, it should not be an issue | 19:34 |
harlowja | https://gist.github.com/harlowja/b3f9c920c3a6951128b5 should work then right? | 19:34 |
harlowja | :-/ | 19:34 |
harlowja | for me it does https://gist.github.com/harlowja/f43f8a14a0d0c501b7b3 | 19:35 |
harlowja | and boom | 19:35 |
*** stevemar has joined #openstack-oslo | 19:35 | |
harlowja | dimsum__ probably like yours also, if people have references to the wrong static method after @trace_cls (for a lot of reasons) then it will get werid | 19:35 |
harlowja | staticmethods are weird, because people can be referenceing them from all over | 19:37 |
DinaBelova | also I cannot understand my experimental job with tempest did not catch it when we ran it against that patch | 19:37 |
dimsum__ | DinaBelova : because that does not exercise the PureFC driver | 19:37 |
harlowja | like in the module that the class is in, after defintion it could be making local variable reference to staticmethod, and then later @trace_cls changes it, but the module has reference to old one :-/ | 19:37 |
dimsum__ | it's a 3rd party job | 19:37 |
DinaBelova | dimsum__ ah, ok | 19:38 |
harlowja | (that's also why i don't like tracecls, its not really connected into the python class creation process, and therefore gets weird) | 19:38 |
harlowja | dimsum__ in your example http://paste.openstack.org/show/486132/ | 19:38 |
harlowja | A.e() which e() is that calling :) | 19:39 |
dimsum__ | harlowja : i would vote to fail with better error message pointing them to fix their own broken code | 19:39 |
harlowja | because in your paste, there is really 2 e()s | 19:39 |
*** krotscheck is now known as krotscheck_dcm | 19:39 | |
*** vilobhmm111 has joined #openstack-oslo | 19:39 | |
harlowja | one in the class defintion | 19:39 |
harlowja | and one new function created by trace_cls | 19:39 |
harlowja | *wrapper function | 19:39 |
harlowja | i don't like messing with python class stuff | 19:40 |
harlowja | lol | 19:40 |
harlowja | *except via normal metaclass processes, lol | 19:40 |
harlowja | (and even that thing is hairy), lol | 19:40 |
*** vilobhmm11 has quit IRC | 19:40 | |
dimsum__ | ok back to the problem at hand :) | 19:41 |
harlowja | lol | 19:41 |
dimsum__ | how do we get them going DinaBelova :) | 19:41 |
dimsum__ | see what i did there harlowja :) | 19:41 |
harlowja | redirection ftw | 19:41 |
harlowja | lol | 19:41 |
dimsum__ | yay :) | 19:41 |
harlowja | u could be a web browser :-P | 19:42 |
harlowja | haha | 19:42 |
harlowja | if u ever needed a side-job | 19:42 |
DinaBelova | dimsum__ I'm looking now, but the issue is I will need to go away from a laptop in 20 minutes | 19:42 |
dimsum__ | harlowja : easy thing would be to not decorate the static methods no? | 19:43 |
dimsum__ | DinaBelova ack | 19:43 |
harlowja | thats one way | 19:43 |
harlowja | its still is weird | 19:43 |
harlowja | but might be acceptable | 19:44 |
harlowja | might be good to have more staticmethod and classmethod tests | 19:44 |
harlowja | bunch of weirdo cases u can have | 19:44 |
dimsum__ | y, so we get DinaBelova and boris-42 past the revert and they can do that :) | 19:44 |
harlowja | k | 19:45 |
DinaBelova | dimsum__ probably the best way right now will be not to trace staticmethods... if we'll revert this stuff at all, nova change won't be able to land | 19:46 |
dimsum__ | right DinaBelova | 19:47 |
harlowja | dimsum__ DinaBelova https://gist.github.com/harlowja/0dc708a09e535632e6f8 | 19:47 |
harlowja | bunch of weird cases there :-P | 19:47 |
harlowja | to see when something is traced/not , https://gist.github.com/harlowja/09ea124f33e9d6b39585 (tiny little print patch) | 19:48 |
harlowja | actually, nm, a few less cases in there than i thought | 19:49 |
harlowja | https://gist.github.com/harlowja/6dc4eb90bf150eaeca29 (some cases) | 19:50 |
dimsum__ | harlowja : this would do the trick? http://paste.openstack.org/show/486136/ | 19:51 |
harlowja | should do it, unsure what else that changes, but sure :) | 19:51 |
harlowja | maybe wrapped_method is None, just incase some method for some reason has __bool__ or something on it (who knows) | 19:52 |
*** sigmavirus24 is now known as sigmavirus24_awa | 19:52 | |
harlowja | i think classmethods will be ok, but probably some stuff that might be off | 19:53 |
DinaBelova | dimsum__ I even used http://paste.openstack.org/show/Cw0X6lNw5dbVcGhjC0s1/ | 19:55 |
DinaBelova | without any wrapping at all | 19:56 |
dimsum__ | DinaBelova we haven't see a problem with classmethod, so we should not skip that | 19:56 |
DinaBelova | yeah, indeed | 19:56 |
dimsum__ | let's call continue with just the staticmethod | 19:56 |
DinaBelova | ok | 19:56 |
DinaBelova | one moment sir | 19:57 |
harlowja | class methods i think will be ok, although if modules reference class method before trace_cls() gets applied, they will bypass tracing | 19:57 |
dimsum__ | DinaBelova : one test has to be fixed "def test_static(self, mock_start, mock_stop)" | 19:57 |
DinaBelova | yes, I know that | 19:57 |
dimsum__ | DinaBelova : harlowja means we have to doc the edge cases :) | 19:57 |
harlowja | def | 19:57 |
harlowja | translator applied | 19:57 |
harlowja | ha | 19:57 |
dimsum__ | :) | 19:58 |
harlowja | sputnik13 also does that prettty well to :) | 19:58 |
harlowja | lol | 19:58 |
dimsum__ | DinaBelova : so two of us are here, we can get that change in and you can test nova et. al | 19:58 |
dimsum__ | DinaBelova : then find boris-41 and open up a openstack/releases review please? | 19:59 |
DinaBelova | dimsum__ I need to go very soon :( so do not know when I'll be able to do it... | 19:59 |
dimsum__ | sorry 42 | 19:59 |
dimsum__ | ah ok | 19:59 |
DinaBelova | I'll upload staticmethod ignorance change in next few minutes | 20:00 |
harlowja | fire the missles | 20:00 |
dimsum__ | DinaBelova : blast boris-42's phone to show up here too please? :) | 20:00 |
harlowja | i can do that to, i think i got his number | 20:01 |
harlowja | lol | 20:01 |
* harlowja if needed | 20:02 | |
dimsum__ | worst case we miss the boat on Nova | 20:02 |
openstackgerrit | Dina Belova proposed openstack/osprofiler: Disable staticmethods tracing https://review.openstack.org/276897 | 20:05 |
DinaBelova | dimsum__ ^^ | 20:05 |
dimsum__ | ack DinaBelova : will wait for CI | 20:05 |
DinaBelova | ыure | 20:05 |
DinaBelova | sure* | 20:05 |
harlowja | russian mode toggle | 20:05 |
harlowja | :) | 20:05 |
DinaBelova | dimsum__ harlowja - I quickly checked nova with this osprofiler modification against my dev env. Boot request seems to feel ok | 20:08 |
harlowja | cool | 20:08 |
harlowja | good feelings are happy feelings | 20:08 |
harlowja | (or some other quote), lol | 20:09 |
DinaBelova | harlowja dimsum__ http://dinabelova.github.io/nova-no-static-traces.html here it is | 20:10 |
harlowja | cool | 20:10 |
harlowja | probably not missing to much by not tracing staticmethods | 20:10 |
DinaBelova | it's with the modified profiler and does not seem to have any differences (or at least visually) | 20:10 |
DinaBelova | indeed | 20:11 |
harlowja | cool | 20:11 |
*** dimtruck is now known as zz_dimtruck | 20:14 | |
*** zz_dimtruck is now known as dimtruck | 20:15 | |
*** pballand has quit IRC | 20:20 | |
*** salv-orlando has joined #openstack-oslo | 20:24 | |
*** stevemar has quit IRC | 20:26 | |
*** pballand has joined #openstack-oslo | 20:26 | |
*** stevemar has joined #openstack-oslo | 20:26 | |
sputnik13 | huh? | 20:34 |
dimsum__ | sputnik13 : there you are! :) | 20:36 |
sputnik13 | here I am | 20:36 |
sputnik13 | uhhh... what did I do? :) | 20:36 |
dimsum__ | :) all's well sputnik13 | 20:36 |
sputnik13 | whew | 20:37 |
sputnik13 | thought I was in trouble | 20:37 |
dimsum__ | well we are waiting for boris-42 to show up :) he's in trouble | 20:37 |
sputnik13 | uh oh | 20:37 |
*** david-lyle has joined #openstack-oslo | 20:39 | |
harlowja | lol | 20:41 |
*** achanda has quit IRC | 20:45 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Remove need for separate notify thread https://review.openstack.org/276915 | 20:54 |
*** david-lyle has quit IRC | 20:55 | |
*** david-lyle_ has joined #openstack-oslo | 20:55 | |
*** achanda has joined #openstack-oslo | 20:59 | |
*** david-lyle_ is now known as david-lyle | 21:00 | |
*** achanda has quit IRC | 21:06 | |
*** jeckersb is now known as jeckersb_gone | 21:08 | |
*** gordc has quit IRC | 21:09 | |
*** achanda has joined #openstack-oslo | 21:12 | |
*** e0ne has quit IRC | 21:20 | |
*** boris-42 has joined #openstack-oslo | 21:23 | |
boris-42 | dims I approved that patch | 21:24 |
dimsum__ | boris-42 : can you please file a openstack/releases review? | 21:25 |
*** stevemar has quit IRC | 21:27 | |
boris-42 | dimsum__: yep one second | 21:28 |
*** stevemar has joined #openstack-oslo | 21:28 | |
*** kgiusti has left #openstack-oslo | 21:29 | |
*** achanda has quit IRC | 21:31 | |
*** stevemar_ has joined #openstack-oslo | 21:32 | |
*** stevemar has quit IRC | 21:33 | |
*** achanda has joined #openstack-oslo | 21:41 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Remove need for separate notify thread https://review.openstack.org/276915 | 21:52 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.config: refactor sphinxext to make reformatting easier https://review.openstack.org/276927 | 21:55 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.config: support multiple namespaces in sphinxext https://review.openstack.org/276928 | 21:56 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.config: have show-options load the generator config file https://review.openstack.org/276929 | 21:56 |
dhellmann | rbradfor : ^^ | 21:56 |
rbradfor | dhellmann, will take a look | 21:56 |
dhellmann | rbradfor : I'm working on a patch to glance as an example, too | 21:57 |
rbradfor | dhellmann, fighting the PXE tftp daemons at present | 21:57 |
dhellmann | rbradfor : god speed | 21:57 |
rbradfor | dhellmann, at whits end, I get get my PXE menu, but I'm then stuck, | 21:58 |
dhellmann | rbradfor : https://review.openstack.org/276931 | 22:03 |
*** dims has joined #openstack-oslo | 22:04 | |
*** dimsum__ has quit IRC | 22:04 | |
rbradfor | dhellmann, so here is a downside to that idea. | 22:05 |
rbradfor | you now are effectively duplicating common options (aka the logging options) per page. It's an unwinable situation either way, and I see the issues with the operating manuals where the same options are duplicated so many times. in isolation, i.e. I want to look at one config file (now one page) I would see everything I need to know, we get exactly what we want | 22:06 |
dhellmann | normally one wouldn't want to duplicate the information because you would be afraid of missing an update if it changes. this is all automatically generated, though. | 22:07 |
rbradfor | dhellmann, that is true, it is generated, not humans | 22:08 |
*** cdent is now known as dentures | 22:10 | |
*** jeckersb_gone is now known as jeckersb | 22:22 | |
*** stevemar_ has quit IRC | 22:24 | |
*** stevemar has joined #openstack-oslo | 22:25 | |
dims | boris-42 : don't see it yet | 22:34 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Some WBE protocol/executor cleanups https://review.openstack.org/276941 | 22:34 |
*** dentures has quit IRC | 22:39 | |
*** salv-orl_ has joined #openstack-oslo | 22:40 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Don't bother scanning for workers if no new messages arrived https://review.openstack.org/276872 | 22:41 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Some WBE protocol/executor cleanups https://review.openstack.org/276941 | 22:41 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Remove need for separate notify thread https://review.openstack.org/276915 | 22:41 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Fix for WBE sporadic timeout of tasks https://review.openstack.org/276536 | 22:41 |
*** salv-orlando has quit IRC | 22:43 | |
*** dims_ has joined #openstack-oslo | 23:06 | |
*** rlrossit_ has quit IRC | 23:06 | |
openstackgerrit | Doug Hellmann proposed openstack/oslo.config: always show coverage output from tests https://review.openstack.org/276946 | 23:08 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.config: refactor sphinxext and add unit tests https://review.openstack.org/276947 | 23:08 |
*** dims has quit IRC | 23:10 | |
*** edmondsw has quit IRC | 23:13 | |
*** dimtruck is now known as zz_dimtruck | 23:14 | |
openstackgerrit | Joshua Harlow proposed openstack/osprofiler: Disable staticmethods tracing https://review.openstack.org/276897 | 23:18 |
*** vilobhmm111 has quit IRC | 23:19 | |
openstackgerrit | Boris Pavlovic proposed openstack/osprofiler: Disable staticmethods tracing https://review.openstack.org/276897 | 23:22 |
*** bauwser is now known as bauzas | 23:23 | |
harlowja | boris-42 overwriting my change are u | 23:23 |
harlowja | lol | 23:23 |
boris-42 | harlowja: ? | 23:23 |
boris-42 | harlowja: ahaha lol | 23:23 |
harlowja | :) | 23:23 |
boris-42 | ok | 23:24 |
harlowja | ok ok | 23:25 |
harlowja | lol | 23:25 |
*** regXboi has quit IRC | 23:25 | |
openstackgerrit | Doug Hellmann proposed openstack/oslo.log: always run coverage report https://review.openstack.org/276953 | 23:28 |
*** mgarza has quit IRC | 23:37 | |
dims_ | boris-42 : it's still not right. the FIXME that dina added should be removed as you are skipping the test now | 23:59 |
boris-42 | dims_: =( | 23:59 |
boris-42 | dims_: ok | 23:59 |
openstackgerrit | Boris Pavlovic proposed openstack/osprofiler: Disable staticmethods tracing https://review.openstack.org/276897 | 23:59 |
boris-42 | dims_: ^ fixed | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!