| *** salv-orl_ has joined #openstack-oslo | 00:06 | |
| *** salv-orlando has quit IRC | 00:09 | |
| *** pratikmallya has quit IRC | 00:17 | |
| *** pratikmallya has joined #openstack-oslo | 00:59 | |
| *** salv-orl_ has quit IRC | 01:11 | |
| *** zz_dimtruck is now known as dimtruck | 01:12 | |
| *** salv-orlando has joined #openstack-oslo | 01:12 | |
| *** ozamiatin__ has joined #openstack-oslo | 01:18 | |
| *** dimtruck is now known as zz_dimtruck | 01:22 | |
| *** jecarey has joined #openstack-oslo | 01:53 | |
| *** jecarey has quit IRC | 01:58 | |
| *** zz_dimtruck is now known as dimtruck | 02:01 | |
| *** dimtruck is now known as zz_dimtruck | 02:11 | |
| *** pratikmallya has quit IRC | 02:15 | |
| *** gcb has joined #openstack-oslo | 02:37 | |
| *** yamahata has quit IRC | 03:16 | |
| *** jeckersb_gone is now known as jeckersb | 03:29 | |
| *** beekneemech has quit IRC | 03:37 | |
| *** bnemec has joined #openstack-oslo | 03:39 | |
| openstackgerrit | Merged openstack/taskflow: Quote/standardize atom name output https://review.openstack.org/258645 | 03:52 |
|---|---|---|
| *** jecarey has joined #openstack-oslo | 03:53 | |
| *** links has joined #openstack-oslo | 03:54 | |
| *** jecarey has quit IRC | 03:59 | |
| *** zz_dimtruck is now known as dimtruck | 04:02 | |
| *** dimtruck is now known as zz_dimtruck | 04:11 | |
| *** vilobhmm11 has joined #openstack-oslo | 04:26 | |
| *** jeckersb is now known as jeckersb_gone | 04:36 | |
| *** jecarey has joined #openstack-oslo | 04:39 | |
| *** jecarey has quit IRC | 04:58 | |
| *** jamespage has quit IRC | 05:00 | |
| *** jamespage has joined #openstack-oslo | 05:00 | |
| *** salv-orl_ has joined #openstack-oslo | 05:07 | |
| *** salv-orlando has quit IRC | 05:07 | |
| openstackgerrit | zhangguoqing proposed openstack/oslo.messaging: Change LOG.warn to LOG.warning https://review.openstack.org/263120 | 05:46 |
| *** pratikmallya has joined #openstack-oslo | 05:47 | |
| *** harlowja_at_home has joined #openstack-oslo | 05:51 | |
| openstackgerrit | zhangguoqing proposed openstack/oslo.middleware: Change LOG.warn to LOG.warning https://review.openstack.org/263121 | 05:52 |
| *** ozamiatin__ has quit IRC | 05:56 | |
| *** ozamiatin_ has joined #openstack-oslo | 05:58 | |
| *** jecarey has joined #openstack-oslo | 05:58 | |
| *** jecarey has quit IRC | 06:02 | |
| *** zz_dimtruck is now known as dimtruck | 06:03 | |
| *** salv-orlando has joined #openstack-oslo | 06:06 | |
| *** harlowja_at_home has quit IRC | 06:08 | |
| *** salv-orl_ has quit IRC | 06:09 | |
| *** dimtruck is now known as zz_dimtruck | 06:12 | |
| *** vilobhmm11 has quit IRC | 06:19 | |
| *** vilobhmm11 has joined #openstack-oslo | 06:25 | |
| *** pratikmallya has quit IRC | 06:49 | |
| *** vilobhmm11 has quit IRC | 07:18 | |
| *** salv-orlando has quit IRC | 07:34 | |
| *** salv-orlando has joined #openstack-oslo | 07:35 | |
| *** jecarey has joined #openstack-oslo | 07:35 | |
| *** amotoki has joined #openstack-oslo | 07:38 | |
| *** jecarey has quit IRC | 07:40 | |
| *** salv-orlando has quit IRC | 07:42 | |
| *** salv-orlando has joined #openstack-oslo | 07:42 | |
| *** kevinbenton has quit IRC | 07:49 | |
| *** nkrinner has joined #openstack-oslo | 07:51 | |
| *** kevinbenton has joined #openstack-oslo | 07:54 | |
| *** zz_dimtruck is now known as dimtruck | 08:00 | |
| *** markus_z has joined #openstack-oslo | 08:02 | |
| *** kevinbenton has quit IRC | 08:08 | |
| *** dimtruck is now known as zz_dimtruck | 08:10 | |
| openstackgerrit | Zhihai Song proposed openstack/oslo.privsep: Use logging intead of oslo_log https://review.openstack.org/261940 | 08:11 |
| *** zakora has joined #openstack-oslo | 08:20 | |
| *** xek_ is now known as xek | 08:29 | |
| *** ihrachys has joined #openstack-oslo | 08:31 | |
| *** haypo has joined #openstack-oslo | 08:33 | |
| *** salv-orlando has quit IRC | 08:34 | |
| *** salv-orlando has joined #openstack-oslo | 08:35 | |
| *** jecarey has joined #openstack-oslo | 08:36 | |
| *** jecarey has quit IRC | 08:42 | |
| *** shardy has joined #openstack-oslo | 08:44 | |
| *** pblaho has joined #openstack-oslo | 08:48 | |
| *** links has quit IRC | 09:00 | |
| *** ihrachys_ has joined #openstack-oslo | 09:02 | |
| *** deray has joined #openstack-oslo | 09:03 | |
| *** links has joined #openstack-oslo | 09:04 | |
| *** ihrachys has quit IRC | 09:04 | |
| *** yassine__ has joined #openstack-oslo | 09:05 | |
| *** ihrachys_ has quit IRC | 09:17 | |
| *** ihrachys has joined #openstack-oslo | 09:17 | |
| *** ihrachys has quit IRC | 09:19 | |
| *** ihrachys has joined #openstack-oslo | 09:20 | |
| *** ihrachys has quit IRC | 09:30 | |
| *** ihrachys has joined #openstack-oslo | 09:30 | |
| *** ihrachys has quit IRC | 09:30 | |
| *** lxsli_festive is now known as lxsli | 09:39 | |
| lxsli | rbradfor: ping back | 09:43 |
| mhorban | lxsli: Hi! | 09:45 |
| mhorban | I want discuss https://review.openstack.org/#/c/223668/ about reloading logging config in nova | 09:46 |
| mhorban | lxsli: ^ | 09:46 |
| *** pblaho has quit IRC | 09:48 | |
| *** pblaho has joined #openstack-oslo | 09:49 | |
| *** goodygum has joined #openstack-oslo | 09:50 | |
| *** vipuls has quit IRC | 09:55 | |
| *** SlickN1k has quit IRC | 09:55 | |
| *** SlickN1k has joined #openstack-oslo | 09:55 | |
| *** ndipanov has joined #openstack-oslo | 09:56 | |
| *** vipuls has joined #openstack-oslo | 09:58 | |
| *** cdent has joined #openstack-oslo | 09:58 | |
| *** zz_dimtruck is now known as dimtruck | 10:01 | |
| *** openstackgerrit has quit IRC | 10:02 | |
| *** openstackgerrit has joined #openstack-oslo | 10:02 | |
| *** dimtruck is now known as zz_dimtruck | 10:11 | |
| *** pblaho has quit IRC | 10:24 | |
| lxsli | hey | 10:32 |
| lxsli | I need to look at oslo.service to figure out how the Nova integration will work | 10:33 |
| lxsli | I have a patch up for oslo.log here: https://review.openstack.org/#/c/254821/ | 10:44 |
| *** mhickey has joined #openstack-oslo | 10:45 | |
| lxsli | mhorban: ^^ | 10:46 |
| mhorban | lxsli: hm.. I believe oslo.service should call notify_oslo_config_reload() from your patch | 10:51 |
| mhickey | ttx: Hey. Do you have some bandwdith for a quick question? | 10:52 |
| lxsli | mhorban: yes I think so | 10:53 |
| mhorban | lxsli. And one more question | 10:54 |
| mhorban | Do we need call conf.reload_config_files() before notify_oslo_config_reload()? | 10:54 |
| mhorban | lxsli: What is consequence? | 10:55 |
| lxsli | mhorban: yes, we don't want callbacks in oslo.config so the thread of control has to start in the outermost layer IE the application (Nova etc) | 10:55 |
| lxsli | conf.reload_config_files is what changes the CONF object | 10:55 |
| lxsli | notify_oslo_config_reload tells oslo.log to look at the config again and Make It So | 10:55 |
| lxsli | I need to figure out how Nova and oslo.service can interact so Nova can also reinspect the config and Make It So | 10:56 |
| mhorban | so notify_oslo_config_reload should be called after conf.reload_config_file | 10:56 |
| ttx | mhickey: sure | 10:56 |
| mhickey | ttx: great. I unfortunately set status for https://bugs.launchpad.net/neutron/+bug/1199963 to fix released instead of committed. I am unable to change it now. What should I do withy it? | 10:58 |
| openstack | Launchpad bug 1199963 in neutron "Neutron does not use Oslo for config generator" [Wishlist,Fix released] - Assigned to Martin Hickey (martin-hickey) | 10:58 |
| mhorban | lxsli. Nova uses ProcessLauncher and ServiceLauncher from oslo.services. These launchers like a containers with support of some features like signal handling. When SIGHUP is caught Launcher calls conf.reload_config_files | 10:58 |
| ttx | mhickey: let me see if I can fix it. | 10:58 |
| mhickey | ttx: ok | 10:59 |
| ttx | mhickey: looks like I can | 10:59 |
| mhorban | lxsli: and than Laucher call service.reset(). So I believe service.reset() is right place to put notify_oslo_config_reload() | 10:59 |
| ttx | mhickey: although I'm wondering why you think it's the wrong status | 10:59 |
| ttx | since we don't use Fix Committed that much anymore | 10:59 |
| mhickey | ttx: sjould it not be committed until you set it to released> | 11:00 |
| mhickey | ? | 11:00 |
| mhickey | *should* | 11:00 |
| ttx | mhickey: we changed that recently, let me look for the reference | 11:00 |
| ttx | http://lists.openstack.org/pipermail/openstack-dev/2015-November/080288.html | 11:01 |
| ttx | basically we add a comment rather than rely on bug status | 11:01 |
| *** yassine__ has quit IRC | 11:01 | |
| ttx | so it looks like FixReleased was right after all | 11:02 |
| mhickey | ttx: ok, I understand. | 11:02 |
| lxsli | mhorban: ahh that's excellent, yes I agree | 11:02 |
| ttx | reverting fix | 11:02 |
| mhickey | ttx: so, it seems like it was. :) | 11:02 |
| ttx | mhickey: sorry for the confusion :) | 11:02 |
| mhickey | ttx: ok, thanks for this. sorry for the hassle. | 11:02 |
| mhickey | ttx: my fault. always happens after holidays! :) | 11:03 |
| *** e0ne has joined #openstack-oslo | 11:06 | |
| *** deray has quit IRC | 11:13 | |
| *** zz_dimtruck is now known as dimtruck | 11:22 | |
| *** shardy has quit IRC | 11:29 | |
| *** shardy has joined #openstack-oslo | 11:30 | |
| openstackgerrit | Oleksii Zamiatin proposed openstack/oslo.messaging: (WIP) [zmq] Heartbeat implementation https://review.openstack.org/257346 | 11:38 |
| *** dims has joined #openstack-oslo | 11:40 | |
| *** dims has quit IRC | 11:40 | |
| *** dims has joined #openstack-oslo | 11:41 | |
| *** pblaho has joined #openstack-oslo | 11:41 | |
| *** pblaho has quit IRC | 11:42 | |
| *** pblaho has joined #openstack-oslo | 11:42 | |
| dims | fellow oslo-ites: happy new year! | 11:44 |
| *** cdent has quit IRC | 11:48 | |
| ozamiatin_ | dims: thanks, happy new year! | 11:50 |
| openstackgerrit | Oleksii Zamiatin proposed openstack/oslo.messaging: (WIP) [zmq] Heartbeat implementation https://review.openstack.org/257346 | 12:05 |
| *** salv-orl_ has joined #openstack-oslo | 12:06 | |
| *** salv-orl_ has quit IRC | 12:07 | |
| *** salv-orl_ has joined #openstack-oslo | 12:07 | |
| *** salv-orlando has quit IRC | 12:09 | |
| *** tedross has joined #openstack-oslo | 12:11 | |
| *** dimtruck is now known as zz_dimtruck | 12:17 | |
| *** zz_dimtruck is now known as dimtruck | 12:21 | |
| *** gordc has joined #openstack-oslo | 12:24 | |
| *** cdent has joined #openstack-oslo | 12:30 | |
| *** yassine__ has joined #openstack-oslo | 12:34 | |
| *** links has quit IRC | 12:34 | |
| gcb | Happy new year everyone ! | 12:39 |
| *** pblaho has quit IRC | 12:50 | |
| *** pblaho has joined #openstack-oslo | 12:52 | |
| *** gcb has quit IRC | 13:02 | |
| *** salv-orl_ has quit IRC | 13:13 | |
| *** salv-orlando has joined #openstack-oslo | 13:14 | |
| *** edmondsw has joined #openstack-oslo | 13:20 | |
| *** jecarey has joined #openstack-oslo | 13:20 | |
| lxsli | dims: and to you o/ | 13:21 |
| *** jecarey has quit IRC | 13:22 | |
| *** ihrachys has joined #openstack-oslo | 13:23 | |
| openstackgerrit | amrith proposed openstack/oslo.utils: Add a mechanism to mask passwords in dictionaries https://review.openstack.org/257561 | 13:24 |
| lxsli | dims: can I pick your brain for ideas? https://review.openstack.org/#/c/251471 introduces a mutate_config_opts which is like reload_config_opts but respects a new 'mutable' opt flag | 13:25 |
| lxsli | dims: oslo.service calls reload_config_opts today but I'd like a way to make it use mutate_config_opts instead on a service-by-service basis. Any ideas on how to go about that? | 13:26 |
| dims | lxsli : star'red it. give me a bit to catch up and i'll take a look | 13:27 |
| lxsli | dims: great, thanks - bear in mind this is looking forward from that specific change | 13:27 |
| dims | ack | 13:27 |
| *** pradk has joined #openstack-oslo | 13:29 | |
| openstackgerrit | Alexis Lee proposed openstack/oslo.config: Add 'mutable' param to Opt https://review.openstack.org/251471 | 13:30 |
| openstackgerrit | Alexis Lee proposed openstack/oslo.config: Allow parser and namespace modification https://review.openstack.org/253125 | 13:30 |
| *** amrith is now known as _amrith_ | 13:31 | |
| *** ihrachys_ has joined #openstack-oslo | 13:34 | |
| *** ihrachys has quit IRC | 13:36 | |
| *** tedross has left #openstack-oslo | 13:39 | |
| *** jecarey has joined #openstack-oslo | 13:43 | |
| *** rlrossit has joined #openstack-oslo | 13:43 | |
| *** jecarey has quit IRC | 13:44 | |
| *** jecarey has joined #openstack-oslo | 13:44 | |
| *** jecarey has quit IRC | 13:45 | |
| openstackgerrit | zhangguoqing proposed openstack/oslo.vmware: Change LOG.warn to LOG.warning https://review.openstack.org/263263 | 13:48 |
| *** links has joined #openstack-oslo | 13:56 | |
| openstackgerrit | Merged openstack/oslo-incubator: fix the clone script for the updated gerrit https://review.openstack.org/261081 | 13:57 |
| mhickey | dansmith: Hi. Do you have some bandwidth to chat about versioned objects? i have an issue on a patch. | 14:04 |
| openstackgerrit | Merged openstack-dev/oslo-cookiecutter: remove python 2.6 trove classifier https://review.openstack.org/260979 | 14:04 |
| *** pblaho has quit IRC | 14:04 | |
| *** pblaho has joined #openstack-oslo | 14:05 | |
| *** jeckersb_gone is now known as jeckersb | 14:06 | |
| *** links has quit IRC | 14:07 | |
| *** Kennan has quit IRC | 14:14 | |
| *** Kennan has joined #openstack-oslo | 14:15 | |
| *** zakora has quit IRC | 14:18 | |
| *** dimtruck is now known as zz_dimtruck | 14:18 | |
| *** zakora has joined #openstack-oslo | 14:19 | |
| rlrossit | mhickey: I might be able to help. What's the issue? | 14:19 |
| mhickey | rlrossit: Hey. How are things? Happy new yesr. | 14:20 |
| mhickey | *year* | 14:21 |
| rlrossit | mhickey: happy new year! this is like, the 4th best day of the year so far :P | 14:23 |
| mhickey | rlrossit: patch https://review.openstack.org/#/c/258026/. Have an issue with FakeResource objecj. Info in the comments. | 14:23 |
| mhickey | *object* | 14:23 |
| mhickey | rlrossit: yep and return to work! :) | 14:28 |
| rlrossit | mhickey: I'm getting vague memories of helping you out with this a while ago with the register_if(False) thing. Let me fix a merge conflict in one of my patches quick and then I'll take a good look at that patch | 14:28 |
| rbradfor | lxsli, hi | 14:30 |
| lxsli | hey | 14:30 |
| mhickey | rlrossit: sure, you helped me out but that was for a different issue. this is to do with not allowing this test object to be false. take your time.. | 14:31 |
| rbradfor | lxsli, I had a question for you regarding the state of some reviews. Trying to recall after the break what they were? | 14:32 |
| lxsli | rbradfor: probably starting from https://review.openstack.org/#/c/253125/? | 14:33 |
| rbradfor | lxsli, it was mutable related. I am more interested at present in understanding the varying attempts to reload logging configuration via SIGHUP, which would likely also include this work | 14:35 |
| lxsli | rbradfor: yes that's a goal | 14:35 |
| lxsli | I also have https://review.openstack.org/254821 | 14:36 |
| lxsli | and mhorban put up https://review.openstack.org/223668 today | 14:36 |
| rbradfor | yes, was just looking at 254821 | 14:36 |
| lxsli | we need a patch to oslo.service to make it call mutate_config_files but I'm not sure how best to go about that yet | 14:36 |
| *** mriedem has joined #openstack-oslo | 14:38 | |
| * rbradfor looking for the oslo_log.log.notify_oslo_config_reload mentioned in nova patch. | 14:39 | |
| lxsli | that's part of 254821 | 14:39 |
| rbradfor | right, found it | 14:40 |
| *** jlvacation is now known as jlvillal | 14:40 | |
| *** jeckersb is now known as jeckersb_gone | 14:41 | |
| rbradfor | lxsli, this work seems to only be a blunt approach of changing the logging level, really, changing the logging levels of specific packages gives an operator a more find grained approach. | 14:43 |
| ihrachys_ | lifeless: dims: are you aware of gate breakage for stable branches due to pbr not pulling testrepository? | 14:44 |
| dims | ihrachys_ : no i have not looked at it yet | 14:46 |
| ihrachys_ | dims: http://lists.openstack.org/pipermail/openstack-dev/2016-January/083212.html and below | 14:47 |
| openstackgerrit | Merged openstack/oslo.privsep: Remove unused file openstack-common.conf https://review.openstack.org/261928 | 14:47 |
| ihrachys_ | something stopped pulling testr for us in devstack jobs. looked at project-config, devstack-gate, devstack, but failed to determine what it could be. | 14:48 |
| lxsli | rbradfor: this is the mutable config work. Changing the debug param is one output. Nova could choose, when it receives SIGHUP, to always reload log config but that's beyond what I'm looking at right now | 14:48 |
| lxsli | rbradfor: we think there are other usecases for mutable config, EG changing endpoints, tuning parameters | 14:49 |
| mhorban | lxsli: Hi, Are you still here? | 14:49 |
| lxsli | mhorban: yo | 14:50 |
| openstackgerrit | Merged openstack/oslo.versionedobjects: Remove meaningless default value in __get__() https://review.openstack.org/260394 | 14:50 |
| mhorban | lxsli: Could you please explain about mutate_config_files | 14:50 |
| *** jecarey has joined #openstack-oslo | 14:51 | |
| rbradfor | lxsli, thanks for the info, I will be following along more closely now. | 14:51 |
| mhorban | lxsli: This function will be implemented in future? | 14:51 |
| lxsli | mhorban: it's part of 251471 | 14:52 |
| lxsli | rbradfor: glad you're interested :) | 14:52 |
| openstackgerrit | Merged openstack/oslo.i18n: doc: contextual/plural translation requires oslo.i18n >=2.1.0 https://review.openstack.org/260872 | 14:52 |
| lxsli | mhorban: reload_config_files reloads everything, I can't suddenly make it only reload mutable opts | 14:52 |
| lxsli | mhorban: so I've added a similar method, mutate_config_files, which does that. This also made it easier to return the things that have changed | 14:53 |
| openstackgerrit | Alexandre Viau proposed openstack-dev/pbr: dont include submodules in _find_git_files https://review.openstack.org/263297 | 14:53 |
| openstackgerrit | Merged openstack/oslo.reports: Trival: Remove 'MANIFEST.in' https://review.openstack.org/253772 | 14:54 |
| openstackgerrit | Merged openstack/oslo.versionedobjects: Updated from global requirements https://review.openstack.org/262917 | 14:54 |
| lxsli | *I'm adding | 14:54 |
| openstackgerrit | Merged openstack/tooz: etcd: driver with lock support https://review.openstack.org/246879 | 14:54 |
| openstackgerrit | Merged openstack/oslo.log: Trival: Remove 'MANIFEST.in' https://review.openstack.org/253774 | 14:55 |
| *** mtanino has joined #openstack-oslo | 14:55 | |
| *** ihrachys_ is now known as ihrachys | 14:55 | |
| rbradfor | lxsli, mhorban I see the pieces now, and your comment makes senses, where does oslo_service trigger mutate_config_file | 14:56 |
| lxsli | rbradfor: it doesn't yet - it does call reload_config_files, grep will find it easily | 14:56 |
| openstackgerrit | Alexandre Viau proposed openstack-dev/pbr: dont include submodules in _find_git_files https://review.openstack.org/263297 | 14:57 |
| rbradfor | lxsli, yep, perhaps more words needed, determining where in service to correctly call mutate_config_file is the next piece to do. | 14:58 |
| lxsli | rbradfor: the tricky part is that I can't just switch oslo.service over either | 14:58 |
| lxsli | rbradfor: I'll need the service to tell oslo.service which behaviour to use somehow | 14:59 |
| lxsli | maybe just a constructor argument | 14:59 |
| *** jeckersb_gone is now known as jeckersb | 15:00 | |
| rbradfor | lxsli, as I'm not up on all the workings of service, it seems a different signal is another way to trigger a mutated change. | 15:01 |
| *** sigmavirus24_awa is now known as sigmavirus24 | 15:01 | |
| openstackgerrit | Merged openstack/oslo.vmware: Python 3 deprecated the logger.warn method in favor of warning https://review.openstack.org/262125 | 15:01 |
| mhorban | lxsli: I see. I believe that we can change reload_config_files in oslo.service to mutate_config_files. If someone lose some functionality - we will make this options mutable. | 15:01 |
| lxsli | rbradfor: I don't foresee any service wanting both behaviours | 15:02 |
| *** kgiusti has joined #openstack-oslo | 15:02 | |
| *** cdent has quit IRC | 15:02 | |
| lxsli | mhorban: you mean try it and see who complains? I'd rather try to anticipate problems | 15:03 |
| openstackgerrit | Merged openstack/oslo.middleware: Change LOG.warn to LOG.warning https://review.openstack.org/263121 | 15:07 |
| openstackgerrit | Merged openstack/oslo.middleware: Python 3 deprecated the logger.warn method in favor of warning https://review.openstack.org/261916 | 15:07 |
| openstackgerrit | Merged openstack/oslo.context: Trival: Remove 'MANIFEST.in' https://review.openstack.org/253776 | 15:08 |
| mhorban | lxsli: I know that nova and neutron will not complain about loosing of reloading of some option... | 15:10 |
| lxsli | mhorban: yeah it's possible no one is using it but there are so many openstack projects now | 15:10 |
| openstackgerrit | Merged openstack/oslo.cache: Trival: Remove 'MANIFEST.in' https://review.openstack.org/253779 | 15:10 |
| openstackgerrit | Alexandre Viau proposed openstack-dev/pbr: include submodules in _find_git_files https://review.openstack.org/263297 | 15:11 |
| mhorban | lxsli: But it is hard to be familar with all openstack and non-openstack staff | 15:11 |
| *** zz_dimtruck is now known as dimtruck | 15:12 | |
| *** regXboi has joined #openstack-oslo | 15:12 | |
| *** shakamunyi has quit IRC | 15:15 | |
| *** barra204 has quit IRC | 15:15 | |
| openstackgerrit | Alexandre Viau proposed openstack-dev/pbr: include submodules in _find_git_files https://review.openstack.org/263297 | 15:16 |
| openstackgerrit | Merged openstack/oslo.service: Updated from global requirements https://review.openstack.org/262916 | 15:17 |
| lxsli | mhorban: yeah so we need to be safe and not change behaviour in a lib | 15:17 |
| openstackgerrit | Merged openstack/tooz: Add a default port and default host https://review.openstack.org/262624 | 15:17 |
| openstackgerrit | Merged openstack/oslo.cache: Updated from global requirements https://review.openstack.org/262913 | 15:19 |
| *** pradk_ has joined #openstack-oslo | 15:19 | |
| *** pradk_ has quit IRC | 15:19 | |
| *** pradk has quit IRC | 15:19 | |
| *** pradk has joined #openstack-oslo | 15:22 | |
| *** gcb has joined #openstack-oslo | 15:27 | |
| *** shakamunyi has joined #openstack-oslo | 15:29 | |
| *** cdent has joined #openstack-oslo | 15:31 | |
| *** I has joined #openstack-oslo | 15:32 | |
| *** I is now known as Guest63053 | 15:32 | |
| *** _amrith_ is now known as amrith | 15:38 | |
| rlrossit | mhickey: I posted comments on https://review.openstack.org/#/c/258026 and it lets you know how to solve the problem in a not-so-fun way, so we may need to get dansmith to help us out with this. | 15:44 |
| mhickey | rlrossit: ok, thanks. let me take a look.. | 15:45 |
| mhorban | lxsli: so what is the plan? We can add optional argument in Launcher constructor and call reload_config_files or mutate_config_files depends on argument... | 15:45 |
| *** mtreinish has quit IRC | 15:46 | |
| lxsli | mhorban: yeah I'm preparing that change right now | 15:47 |
| *** mtreinish has joined #openstack-oslo | 15:48 | |
| openstackgerrit | Alexis Lee proposed openstack/oslo.service: WIP - Allow use of mutate_config_files https://review.openstack.org/263312 | 15:48 |
| lxsli | mhorban: ^^ needs tests and it almost certainly has bugs | 15:49 |
| mhickey | rlrossit: good response, thanks. that sheds some light on my confusion. I think I have some of the tmp registry pattern implemented locally but it is not working as expected. do you have time to field some questions? | 15:51 |
| rlrossit | mhickey: well, I have a meeting in 9 minutes :/ | 15:51 |
| mhickey | rlrossit: ok, have you time before then? | 15:52 |
| rlrossit | yep, I can answer whatever you have for the next few minutes | 15:52 |
| mhickey | rlrossit: when should I register the fake object and should I still have register_if(False) assigned to it/ | 15:54 |
| mhickey | ? | 15:54 |
| dims | 5 mins to oslo meeting | 15:54 |
| dims | hopefully a quick one | 15:55 |
| rlrossit | mhickey: if you are using a test object, it should be register_if(False), if you don't it'll add the test object to the registry, and then you can get into situations where you're suddenly versioning unimportant test objects | 15:55 |
| rlrossit | mhickey: exceptions to that rule are where objects require registry lookups. If you have those, then you either need to use 1) an object that is already registered (a real neutron object), or 2) use the temp registry pattern | 15:56 |
| mhickey | rlrossit: ok, have added code to backup and restore the registry | 15:56 |
| mhickey | whats now needed for the test object? | 15:57 |
| rlrossit | mhickey: not quite sure what you mean by that question. do you mean should you put a register or register_if on the object? | 15:58 |
| mhickey | rlrossit: yes | 15:59 |
| rlrossit | mhickey: you shouldn't need any decorator on it anymore, because you'll be manually calling the register() function on the temporary object registry from within setUp() | 16:00 |
| rlrossit | I'm also trying and failing to find an example of this... | 16:01 |
| mhorban | lxsli: Possibly we should log warning when someone uses sighup_behaviour='reload'. Because it is something like deprecated behavior | 16:01 |
| mhickey | rlrossit: let me try it out. thanks for the help. | 16:01 |
| *** harlowja_at_home has joined #openstack-oslo | 16:04 | |
| *** devananda has quit IRC | 16:07 | |
| amrith | haypo, are you there? | 16:12 |
| lxsli | mhorban: need to establish whether we're actually deprecating reload_config_files or just providing another way to do it | 16:12 |
| *** Guest63053 has quit IRC | 16:13 | |
| *** devananda has joined #openstack-oslo | 16:15 | |
| *** gcb has quit IRC | 16:18 | |
| rbradfor | lxsli, for sake of exploring the options from an outsider just looking at this, how does reload_config_files, which only changes options defined as mutable, differ from mutate_config_files. This leads to projects identifying what can be mutable. This would not break functionality, only force projects to think about what is expected functionality. | 16:18 |
| lxsli | rbradfor: reload_config_files reloads everything | 16:19 |
| rbradfor | lxsli, now, but what if loaded configuration when not defined and reloaded only mutable configuration. | 16:20 |
| rbradfor | Its difficult with backward compatible and an alternative way to do the same thing. | 16:21 |
| lxsli | rbradfor: you mean, what if we changed reload_config_files so it does respect the mutable flag? In that case we shouldn't have mutate_config_files | 16:22 |
| lxsli | but that's how I tried to go originally and it didn't work out so well | 16:22 |
| rbradfor | well because it failed tests or people complained about the functionality changing with no alternative? | 16:23 |
| lxsli | it feels better to provide an alternative and services which want the new behaviour can switch over in their own time | 16:23 |
| openstackgerrit | amrith proposed openstack/oslo.utils: Add a mechanism to mask passwords in dictionaries https://review.openstack.org/257561 | 16:23 |
| rbradfor | lxsli, I would not disagree with you there. | 16:23 |
| rbradfor | lxsli, but I would suspect projects would be less inclined to also change their service launcher. I guess if the functionality to change logging level, and package logging level was only this way, when they decided it was needed they would. | 16:25 |
| rbradfor | lxsli, the disadvantage here is inconsistency across projects when defining cofig, which having come from a significant operations background is very annoying. | 16:26 |
| lxsli | The config shouldn't be any different | 16:26 |
| lxsli | Nova (EG) will tell oslo.service to use mutate_ instead of reload_ and mark+document which options are mutable | 16:27 |
| *** harlowja_at_home has quit IRC | 16:29 | |
| *** cdent has quit IRC | 16:29 | |
| *** cdent has joined #openstack-oslo | 16:32 | |
| mhorban | rbradfor, lxsli: My suggestion is that no project that uses Process/ServiceLauncher uses reloading config by SIGHUP. I tested nova services and figured out that some services fails on SIGHUP :). It means that noone uses it :) I would change reload_config_files to mutate_config_files and I believe that noone will complain | 16:37 |
| lxsli | mhorban: huh, interesting | 16:39 |
| rbradfor | mhorban, I found in my initial testing that oslo.service terminates on a hangup, I beleive the oslo.service code does not actually reload. | 16:39 |
| mhorban | rbradfor: It terminates service if it is started as non daemon | 16:40 |
| rbradfor | mhorban, thanks for the clarification. | 16:40 |
| * rbradfor reading is_signup_and_daemon at the time you said this | 16:40 | |
| mhorban | rbradfor: If service is started in background - SIGHUP worked well in my testing | 16:40 |
| lxsli | mhorban: so when you say "some services fails on SIGHUP" - which? | 16:46 |
| lxsli | and do some work OK? | 16:47 |
| *** zakora has quit IRC | 16:48 | |
| *** e0ne has quit IRC | 16:48 | |
| *** barra204 has joined #openstack-oslo | 16:51 | |
| *** shakamunyi has quit IRC | 16:51 | |
| lxsli | that was a question not an instruction :) | 16:56 |
| *** yassine__ has quit IRC | 16:58 | |
| *** ihrachys has quit IRC | 16:59 | |
| *** sputnik13_ has joined #openstack-oslo | 16:59 | |
| *** sputnik13_ has quit IRC | 16:59 | |
| *** nihilifer has quit IRC | 17:00 | |
| *** nihilifer has joined #openstack-oslo | 17:04 | |
| haypo | amrith: ask your question | 17:05 |
| dims | haypo : you may like this... https://review.openstack.org/#/c/261045/ and https://review.openstack.org/#/c/262083/ - only a few flaky tests are blacklisted now | 17:09 |
| *** markus_z has quit IRC | 17:09 | |
| *** nihilifer has quit IRC | 17:17 | |
| *** nihilifer has joined #openstack-oslo | 17:18 | |
| haypo | dims: i see that you are still a fan of big patches :) | 17:23 |
| lxsli | dhellmann: I responded to your q on https://review.openstack.org/#/c/251471, I'm going home now but if you could take a look I'll see your response tomorrow | 17:24 |
| haypo | dims: don't hesitate to add me as a reviewer to such changes | 17:24 |
| haypo | dims: i will take a look this week, but i have to leave ;) bye | 17:24 |
| dims | haypo : thanks. i had to fully use CI during the holidays :) | 17:24 |
| dims | bye haypo | 17:24 |
| *** haypo has left #openstack-oslo | 17:25 | |
| *** ozamiatin__ has joined #openstack-oslo | 17:29 | |
| *** ozamiatin_ has quit IRC | 17:32 | |
| lifeless | o/ | 17:34 |
| *** ozamiatin__ has quit IRC | 17:37 | |
| *** ozamiatin_ has joined #openstack-oslo | 17:37 | |
| dims | hey lifeless | 17:46 |
| openstackgerrit | Julien Danjou proposed openstack/tooz: utils: replace exception_message by exception_to_unicode https://review.openstack.org/263365 | 17:48 |
| *** kevinbenton has joined #openstack-oslo | 17:49 | |
| mhickey | rlrossit: hey | 17:49 |
| rlrossit | mhickey: hey | 17:50 |
| mhickey | rlrossit: i posted to the patch but unfortunately only errors still | 17:51 |
| mhickey | rlrossit: I am going to be heading off shortly. If you think of anything else maybe post a comment if you get a chance? | 17:52 |
| rlrossit | mhickey: will do | 17:52 |
| openstackgerrit | Julien Danjou proposed openstack/tooz: Only install mock on old Python versions https://review.openstack.org/263370 | 17:53 |
| openstackgerrit | Julien Danjou proposed openstack/oslotest: Only install mock on old Python versions https://review.openstack.org/263372 | 17:55 |
| *** vilobhmm11 has joined #openstack-oslo | 17:55 | |
| mhickey | rlrossit: thanks. much appreciated! :) | 17:56 |
| mhickey | bye | 17:58 |
| *** kevinbenton has quit IRC | 18:03 | |
| *** mhickey has quit IRC | 18:04 | |
| *** harlowja has quit IRC | 18:04 | |
| *** harlowja has joined #openstack-oslo | 18:04 | |
| *** salv-orl_ has joined #openstack-oslo | 18:06 | |
| *** salv-orl_ has quit IRC | 18:06 | |
| *** salv-orl_ has joined #openstack-oslo | 18:07 | |
| *** salv-orlando has quit IRC | 18:08 | |
| *** kevinbenton has joined #openstack-oslo | 18:09 | |
| openstackgerrit | Timothy Symanczyk proposed openstack/oslo.policy: Don't crash on RoleCheck when roles not present https://review.openstack.org/262329 | 18:09 |
| *** vilobhmm11 has quit IRC | 18:14 | |
| lifeless | dims: hey | 18:20 |
| lifeless | dims: what was ihar talking about ? | 18:20 |
| lifeless | sorry ihrachys_ ? | 18:21 |
| *** sputnik13_ has joined #openstack-oslo | 18:22 | |
| *** e0ne has joined #openstack-oslo | 18:23 | |
| openstackgerrit | Joshua Harlow proposed openstack/tooz: Add base64 key encoder (and validations) https://review.openstack.org/262643 | 18:29 |
| *** openstackgerrit has quit IRC | 18:32 | |
| *** openstackgerrit has joined #openstack-oslo | 18:32 | |
| openstackgerrit | Graham Hayes proposed openstack/oslo.versionedobjects: Add UUID Validation https://review.openstack.org/250493 | 18:38 |
| openstackgerrit | Graham Hayes proposed openstack/oslo.versionedobjects: Add Deprecation notice for validating UUIDs https://review.openstack.org/263380 | 18:38 |
| *** yamahata has joined #openstack-oslo | 18:42 | |
| *** isq has quit IRC | 18:50 | |
| *** isq has joined #openstack-oslo | 18:50 | |
| *** boris-42 has quit IRC | 18:53 | |
| *** bnemec has quit IRC | 18:58 | |
| *** vilobhmm11 has joined #openstack-oslo | 18:58 | |
| *** sc68cal has quit IRC | 19:11 | |
| *** sc68cal has joined #openstack-oslo | 19:14 | |
| *** regXboi has quit IRC | 19:17 | |
| *** bnemec has joined #openstack-oslo | 19:20 | |
| *** openstackstatus has quit IRC | 19:20 | |
| *** openstackstatus has joined #openstack-oslo | 19:22 | |
| *** ChanServ sets mode: +v openstackstatus | 19:22 | |
| *** regXboi has joined #openstack-oslo | 19:22 | |
| *** browne has joined #openstack-oslo | 19:25 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/oslo.reports: Use file modification events instead of signal handler https://review.openstack.org/260976 | 19:29 |
| openstackgerrit | Timothy Symanczyk proposed openstack/oslo.policy: Don't crash on RoleCheck when roles not present https://review.openstack.org/262329 | 19:33 |
| *** Kiall has quit IRC | 19:36 | |
| *** Kiall has joined #openstack-oslo | 19:36 | |
| *** dims_ has joined #openstack-oslo | 19:46 | |
| *** dims has quit IRC | 19:47 | |
| *** jecarey has quit IRC | 19:53 | |
| *** jecarey has joined #openstack-oslo | 19:54 | |
| *** jecarey has quit IRC | 19:54 | |
| openstackgerrit | Joshua Harlow proposed openstack/tooz: Adjust some of the zookeeper exception message https://review.openstack.org/263407 | 20:09 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.privsep: Updated from global requirements https://review.openstack.org/262915 | 20:14 |
| *** sputnik13_ has quit IRC | 20:30 | |
| *** sputnik13_ has joined #openstack-oslo | 20:32 | |
| *** sputnik13_ has quit IRC | 20:35 | |
| *** sputnik13_ has joined #openstack-oslo | 20:37 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Differentiate failures (internal vs external) https://review.openstack.org/263417 | 20:39 |
| *** ihrachys has joined #openstack-oslo | 20:41 | |
| amrith | haypo, yt? | 20:42 |
| *** sputnik13_ has quit IRC | 20:42 | |
| amrith | at your convenience please review https://review.openstack.org/#/c/257561/ | 20:42 |
| *** sputnik13_ has joined #openstack-oslo | 20:49 | |
| *** ihrachys_ has joined #openstack-oslo | 20:51 | |
| *** ihrachys has quit IRC | 20:52 | |
| *** ihrachys_ is now known as ihrachys | 20:56 | |
| *** cdent has quit IRC | 21:01 | |
| *** cdent has joined #openstack-oslo | 21:01 | |
| *** e0ne has quit IRC | 21:01 | |
| *** ihrachys_ has joined #openstack-oslo | 21:05 | |
| *** amrith is now known as _amrith_ | 21:06 | |
| *** sputnik13_ has quit IRC | 21:07 | |
| *** ihrachys has quit IRC | 21:08 | |
| *** jecarey has joined #openstack-oslo | 21:09 | |
| openstackgerrit | Merged openstack/oslo.log: Add ISO8601/RFC3339 timestamp to ContextFormatter https://review.openstack.org/256584 | 21:12 |
| *** ihrachys_ is now known as ihrachys | 21:14 | |
| *** kgiusti has quit IRC | 21:25 | |
| *** lucasagomes has joined #openstack-oslo | 21:34 | |
| *** lucasagomes is now known as lucas-dinner | 21:34 | |
| *** pratikmallya has joined #openstack-oslo | 21:42 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.log: enable isotime for exceptions https://review.openstack.org/263453 | 21:43 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.log: only compute the isotime value when it is needed https://review.openstack.org/263454 | 21:43 |
| *** jeckersb is now known as jeckersb_gone | 21:44 | |
| *** ihrachys has quit IRC | 21:44 | |
| *** ndipanov has quit IRC | 21:45 | |
| *** regXboi has quit IRC | 22:01 | |
| *** alexpilotti_ has joined #openstack-oslo | 22:08 | |
| *** sputnik13_ has joined #openstack-oslo | 22:10 | |
| *** sputnik13_ has quit IRC | 22:15 | |
| *** salv-orl_ has quit IRC | 22:15 | |
| *** mriedem is now known as mriedem_jedi | 22:20 | |
| *** mriedem_jedi is now known as mriedem | 22:21 | |
| *** alexpilotti_ has quit IRC | 22:26 | |
| *** sputnik13_ has joined #openstack-oslo | 22:31 | |
| *** shardy has quit IRC | 22:33 | |
| *** e0ne has joined #openstack-oslo | 22:34 | |
| openstackgerrit | Ronald Bradford proposed openstack/oslo.log: Added public method to getting default log levels https://review.openstack.org/263468 | 22:35 |
| *** sputnik13_ has quit IRC | 22:39 | |
| *** rlrossit has quit IRC | 22:41 | |
| *** mriedem is now known as mriedem_away | 22:57 | |
| *** sputnik13_ has joined #openstack-oslo | 22:57 | |
| *** e0ne has quit IRC | 23:11 | |
| *** dimtruck is now known as zz_dimtruck | 23:16 | |
| *** edmondsw has quit IRC | 23:17 | |
| *** jeckersb_gone is now known as jeckersb | 23:25 | |
| *** jecarey has quit IRC | 23:31 | |
| *** jecarey has joined #openstack-oslo | 23:32 | |
| *** jecarey has quit IRC | 23:33 | |
| *** boris-42 has joined #openstack-oslo | 23:33 | |
| *** pratikmallya has quit IRC | 23:33 | |
| *** jecarey has joined #openstack-oslo | 23:34 | |
| *** jecarey has quit IRC | 23:34 | |
| *** jecarey has joined #openstack-oslo | 23:35 | |
| *** pradk has quit IRC | 23:35 | |
| openstackgerrit | Vilobh Meshram proposed openstack/tooz: Add Consul Driver https://review.openstack.org/245362 | 23:36 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 23:46 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Start shift to symbol nomenclature https://review.openstack.org/103296 | 23:49 |
| *** jecarey has quit IRC | 23:49 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!