Tuesday, 2015-10-20

*** jaypipes has quit IRC00:04
*** achanda has quit IRC00:05
openstackgerritJoshua Harlow proposed openstack/taskflow: Trap and expose exception any 'args'  https://review.openstack.org/23727900:11
*** amotoki has joined #openstack-oslo00:14
*** salv-orlando has quit IRC00:17
*** amotoki has quit IRC00:18
openstackgerritJoshua Harlow proposed openstack/taskflow: Move 'fill_iter' to 'iter_utils.fill'  https://review.openstack.org/23734900:27
openstackgerritJoshua Harlow proposed openstack/taskflow: Move 'fill_iter' to 'iter_utils.fill'  https://review.openstack.org/23734900:33
openstackgerritJoshua Harlow proposed openstack/taskflow: Move 'fill_iter' to 'iter_utils.fill'  https://review.openstack.org/23734900:34
*** dims_ has joined #openstack-oslo00:38
*** vilobhmm11 has quit IRC00:40
*** browne has quit IRC00:55
openstackgerritMerged openstack/oslo.rootwrap: Python 3: encode or decode i/o data of Popen.communicate()  https://review.openstack.org/23040801:04
*** _amrith_ is now known as amrith01:04
openstackgerritMerged openstack/oslo-incubator: Updated from global requirements  https://review.openstack.org/23730301:27
*** sputnik13 has quit IRC01:38
*** sputnik1_ has joined #openstack-oslo01:39
*** dims_ has quit IRC01:41
*** yamahata has quit IRC01:51
openstackgerritMerged openstack/oslo.serialization: Updated from global requirements  https://review.openstack.org/23731202:07
openstackgerritMerged openstack/oslo.policy: Updated from global requirements  https://review.openstack.org/23731002:10
openstackgerritMerged openstack/oslo.cache: Updated from global requirements  https://review.openstack.org/23730402:12
*** amotoki has joined #openstack-oslo02:14
*** devlaps has quit IRC02:15
*** browne has joined #openstack-oslo02:18
*** amotoki has quit IRC02:19
*** achanda has joined #openstack-oslo02:24
openstackgerritMerged openstack/oslo.concurrency: Updated from global requirements  https://review.openstack.org/23730502:25
openstackgerritMerged openstack/oslo.db: Updated from global requirements  https://review.openstack.org/23730602:25
openstackgerritMerged openstack/oslo.versionedobjects: Updated from global requirements  https://review.openstack.org/23731402:26
openstackgerritMerged openstack/taskflow: Updated from global requirements  https://review.openstack.org/23733102:26
openstackgerritMerged openstack/tooz: Updated from global requirements  https://review.openstack.org/23733202:27
openstackgerritMerged openstack/oslo.middleware: Updated from global requirements  https://review.openstack.org/23730902:27
openstackgerritMerged openstack/oslo.vmware: Updated from global requirements  https://review.openstack.org/23731502:27
openstackgerritMerged openstack/oslo.log: Updated from global requirements  https://review.openstack.org/23730702:28
*** devlaps has joined #openstack-oslo02:29
*** salv-orlando has joined #openstack-oslo02:34
openstackgerritMerged openstack/oslo.reports: Updated from global requirements  https://review.openstack.org/23731102:38
*** devlaps has quit IRC02:40
*** dims_ has joined #openstack-oslo02:41
*** dims_ has quit IRC02:47
openstackgerritMerged openstack/oslo.messaging: Updated from global requirements  https://review.openstack.org/23730802:47
*** achanda has quit IRC02:54
*** salv-orlando has quit IRC02:55
*** zz_dimtruck is now known as dimtruck02:57
*** yfujioka has quit IRC03:18
*** salv-orlando has joined #openstack-oslo03:22
*** amotoki has joined #openstack-oslo03:23
*** sputnik1_ has quit IRC03:23
openstackgerritMerged openstack/oslo.service: Updated from global requirements  https://review.openstack.org/23731303:24
*** salv-orlando has quit IRC03:29
*** links has joined #openstack-oslo03:39
*** subscope has joined #openstack-oslo03:42
*** dims_ has joined #openstack-oslo03:43
*** vilobhmm11 has joined #openstack-oslo03:47
*** dims_ has quit IRC03:48
*** fnordahl has quit IRC03:50
*** amrith has quit IRC03:50
*** links has quit IRC03:52
*** amrith has joined #openstack-oslo03:56
*** fnordahl has joined #openstack-oslo03:57
*** amotoki has quit IRC03:58
*** dimtruck is now known as zz_dimtruck04:01
*** itisha has quit IRC04:01
*** jecarey has quit IRC04:03
*** jecarey has joined #openstack-oslo04:03
*** jecarey has quit IRC04:08
*** amotoki has joined #openstack-oslo04:11
*** links has joined #openstack-oslo04:15
*** amotoki has quit IRC04:15
*** amotoki has joined #openstack-oslo04:19
*** amotoki_ has joined #openstack-oslo04:25
*** vilobhmm11 has quit IRC04:26
*** amotoki has quit IRC04:28
*** stevemar_ has quit IRC04:34
*** vilobhmm11 has joined #openstack-oslo04:39
*** amotoki_ has quit IRC04:40
*** salv-orlando has joined #openstack-oslo04:44
*** dims_ has joined #openstack-oslo04:45
*** amotoki has joined #openstack-oslo04:46
*** dims_ has quit IRC04:50
*** salv-orlando has quit IRC04:56
*** e0ne has joined #openstack-oslo05:01
*** stevemar_ has joined #openstack-oslo05:02
*** jecarey has joined #openstack-oslo05:04
*** achanda has joined #openstack-oslo05:04
*** rpodolyaka has joined #openstack-oslo05:05
*** jecarey has quit IRC05:08
*** boris-42 has joined #openstack-oslo05:09
*** e0ne has quit IRC05:23
*** salv-orlando has joined #openstack-oslo05:23
*** e0ne has joined #openstack-oslo05:26
*** stevemar_ has quit IRC05:28
*** stevemar_ has joined #openstack-oslo05:29
*** amotoki_ has joined #openstack-oslo05:30
*** salv-orl_ has joined #openstack-oslo05:31
*** salv-orlando has quit IRC05:34
*** jamielennox is now known as jamielennox|away05:39
*** rpodolyaka has quit IRC05:40
*** rpodolyaka has joined #openstack-oslo05:41
*** edmondsw has quit IRC05:41
*** dims_ has joined #openstack-oslo05:47
*** stevemar_ has quit IRC05:51
*** dims_ has quit IRC05:52
*** amotoki_ has quit IRC05:54
*** amotoki_ has joined #openstack-oslo05:59
*** amotoki_ has quit IRC06:00
*** e0ne has quit IRC06:05
*** exploreshaifali has joined #openstack-oslo06:06
*** achanda has quit IRC06:12
*** shardy_a1k has joined #openstack-oslo06:13
*** shardy_afk has quit IRC06:14
*** stevemar_ has joined #openstack-oslo06:14
*** shardy_a1k has quit IRC06:18
*** shardy_afk has joined #openstack-oslo06:19
*** e0ne has joined #openstack-oslo06:30
*** nkrinner has joined #openstack-oslo06:30
*** amotoki_ has joined #openstack-oslo06:40
*** rpodolyaka has quit IRC06:40
*** stevemar_ has quit IRC06:44
*** kragniz has quit IRC06:46
*** dims_ has joined #openstack-oslo06:48
*** rpodolyaka has joined #openstack-oslo06:51
*** dims_ has quit IRC06:53
*** amotoki_ has quit IRC07:01
*** e0ne has quit IRC07:05
*** jecarey has joined #openstack-oslo07:05
*** e0ne has joined #openstack-oslo07:09
*** jecarey has quit IRC07:09
*** e0ne has quit IRC07:11
*** e0ne has joined #openstack-oslo07:16
*** markus_z has joined #openstack-oslo07:16
*** e0ne has quit IRC07:19
*** shardy_afk is now known as shardy07:27
*** vilobhmm11 has quit IRC07:39
*** rpodolyaka has quit IRC07:42
*** itisha has joined #openstack-oslo07:45
*** openstackgerrit has quit IRC07:46
*** openstackgerrit has joined #openstack-oslo07:46
*** dims_ has joined #openstack-oslo07:49
*** browne has quit IRC07:49
*** yfujioka has joined #openstack-oslo07:52
*** dims_ has quit IRC07:55
*** salv-orl_ has quit IRC07:56
*** salv-orlando has joined #openstack-oslo08:01
*** salv-orlando has quit IRC08:05
*** salv-orlando has joined #openstack-oslo08:05
*** yassine has joined #openstack-oslo08:17
*** rpodolyaka has joined #openstack-oslo08:17
*** boris-42 has quit IRC08:18
openstackgerritVictor Stinner proposed openstack/oslo.config: Fix versionchanged  https://review.openstack.org/23745508:22
haypooh oh, we start to have issues with versionchanged/versionadded documented for "future" releases :-p ^^08:23
*** rpodolyaka has quit IRC08:24
haypoi hesitate to approve my own change since it changes a single digit in a docstring for an obvious bug ^^ :-p08:27
mdboothhaypo: I can review if you like :)08:28
haypomdbooth: thanks :)08:29
mdboothhaypo: Looks like this is the second correction to that change :/08:30
mdboothAlthough the first was by the author08:30
haypomdbooth: second? what was the first correction?08:31
*** rpodolyaka has joined #openstack-oslo08:31
*** yfujioka has quit IRC08:31
mdboothhttps://review.openstack.org/#/c/222078/08:31
mdboothhaypo: And... look at the comments in that review :)08:32
haypomdbooth: i'm not sure that i understand. https://review.openstack.org/#/c/222078/ changed the behaviour of oslo.config and adds versionchanged to document the change08:32
mdboothhaypo: Comment of Oct 1608:32
mdboothBy Victor Stinner08:33
mdbooth;)08:33
haypomdbooth: yes, i asked to add versionchanged, but it was before the 2.6 release. i don't understand the problem08:33
mdboothhaypo: Ah... ok08:33
mdboothSo, I'm new around here. Where does '2.6' come from?08:34
mdbooth$ git describe f7c54d9ae23339f390ecc5c4410dbd705e1fbf0108:34
mdbooth1.4.0-3-gf7c54d908:34
haypomdbooth: in oct 16, 2.6 was the future oslo.config release. today, it's the latest release, so 2.7 becomes the new future release08:35
mdboothhaypo: But where does 2.6 come from?08:35
mdboothOr 2.7?08:35
mdboothWhere is the version defined?08:36
mdboothI don't see any reference to it in the source08:36
mdboothAnd the git tag suggest 1.408:36
haypomdbooth: there are git tags08:36
haypomdbooth: are you looking to oslo.config?08:36
mdboothYeah08:37
* mdbooth could be misinterpreting 'git describe'08:37
haypoi never used git describe08:37
haypoi like : git tag --contains=sha108:37
mdboothhaypo: Ah, nm. I was looking at the wrong change id, I think08:39
mdboothsec08:39
*** kragniz_ has joined #openstack-oslo08:41
*** kragniz_ is now known as kragniz08:41
*** alexpilotti has joined #openstack-oslo08:42
mdboothhaypo: Yeah, it's merge weirdness. It was written before 2.6, but merged after it.08:42
mdboothSo describe puts it at 2.5+08:43
mdboothBut it's not in 2.608:43
*** dims_ has joined #openstack-oslo08:51
*** amotoki has quit IRC08:51
*** dims_ has quit IRC08:57
*** ozamiatin has joined #openstack-oslo08:58
*** shardy_ has joined #openstack-oslo08:59
*** stevemar_ has joined #openstack-oslo09:00
*** shardy has quit IRC09:00
*** stevemar_ has quit IRC09:03
*** shardy_ has quit IRC09:04
*** frickler has quit IRC09:05
*** shardy has joined #openstack-oslo09:05
*** jecarey has joined #openstack-oslo09:06
*** e0ne has joined #openstack-oslo09:07
*** amotoki has joined #openstack-oslo09:10
*** jecarey has quit IRC09:10
*** yamahata has joined #openstack-oslo09:13
*** dkehn has quit IRC09:14
*** dkehn has joined #openstack-oslo09:15
*** zqfan is now known as robot09:16
*** frickler has joined #openstack-oslo09:18
*** ihrachys has joined #openstack-oslo09:20
*** jamielennox|away is now known as jamielennox09:26
openstackgerritRui Chen proposed openstack/oslo-incubator: Fix Resource.__eq__ mismatch semantics of object equal  https://review.openstack.org/22879709:29
openstackgerritMatthew Booth proposed openstack/oslo.messaging: Fix a race calling blocking MessageHandlingServer.start()  https://review.openstack.org/23703809:31
openstackgerritMatthew Booth proposed openstack/oslo.messaging: Robustify locking in MessageHandlingServer  https://review.openstack.org/23534709:31
*** amotoki has quit IRC09:37
*** amotoki has joined #openstack-oslo09:43
*** markus_z is now known as markus_z_lunch09:49
*** dims_ has joined #openstack-oslo09:49
*** robot is now known as zqfan09:52
*** ihrachys has quit IRC09:52
*** jecarey has joined #openstack-oslo09:53
*** amotoki has quit IRC09:53
*** jecarey has quit IRC09:57
*** amotoki has joined #openstack-oslo10:02
openstackgerritTom Cammann proposed openstack/oslo.config: Allow naming of custom types  https://review.openstack.org/22139410:07
*** subscope has quit IRC10:10
*** rpodolyaka_ has joined #openstack-oslo10:11
*** subscope has joined #openstack-oslo10:12
*** subscope has quit IRC10:13
mdboothsileht: Hey, are you interested in reviewing those patches, btw?10:13
mdboothI split them up so it should be clearer what changes I made and why10:14
*** rpodolyaka has quit IRC10:14
*** rpodolyaka_ is now known as rpodolyaka10:14
mdboothsileht: I saw your general 'do we need anything this complicated' comment the other day, btw.10:15
mdboothI've given it a fair bit of thought because it's obviously a concern.10:15
mdboothHowever, I couldn't think of anything simpler which was also correct, so I'm going to stand by it :)10:16
*** rpodolyaka1 has joined #openstack-oslo10:16
mdboothHowever, I'm happy to drop it for something simpler which I didn't think of, as long as it's also correct.10:17
*** exploreshaifali has quit IRC10:18
mdboothsileht: Ah, you already reviewed! Thanks, will read.10:19
*** amotoki_ has joined #openstack-oslo10:21
*** amotoki has quit IRC10:23
mdboothsileht dims_: So, there seems to be a feeling that assert is always bad. Do we not like assert?10:31
dims_mdbooth: we don't use it much in oslo for sure10:31
mdboothI've always considered it a programmers aid, rather than a user-visible feature10:32
mdboothIt adds implicit documentation to its context10:32
mdboothAnd helps catch bugs when poking things10:33
mdboothHowever, if we've decided not to use it, I'll just change it10:33
*** markus_z_lunch is now known as markus_z10:36
openstackgerritDmitriy Ukhlov proposed openstack/oslo.messaging: Implements rabbit-pika driver  https://review.openstack.org/22998510:39
mdboothdims_: Perhaps we could implement oslo_utils.assert10:41
mdboothWhich is never disabled10:41
mdboothThen it's meaning would be obvious10:41
dukhlovHello10:43
dims_dukhlov: i am watching 237339 on zuul10:43
dims_dukhlov: that one adds the initial .gitreview for the new feature/pika branch10:43
dims_dukhlov: let's use that branch for the pika work10:43
dims_dukhlov: i'll figure out how to periodically sync that branch from master10:44
dims_dukhlov: sounds good?10:45
dukhlov@dism_: ok, but what is the reason? I think I will not change any current code, only add new10:45
dukhlov@dism_:why do we need separate branch?10:45
dims_dukhlov: thats what was agreed on in the weekly oslo meeting, we did the same thing for zmq. one core reviewer is enough to merge your change to branch.10:48
dims_dukhlov: there's more freedom to experiment in the branch and not worry about breaking others especially since we release oslo libraries frequently10:49
dukhlovdims_: ok let it be so10:49
dukhlovdims_: could I enable somehow gate tempest job or/and functional tests for this branch?10:51
*** ihrachys has joined #openstack-oslo10:52
*** jamielennox is now known as jamielennox|away11:00
dims_dukhlov: yes of course, i'll help with that11:03
silehtmdbooth, I /2411:04
silehtmdbooth, oups sorry for noise11:04
mdboothsileht: I was trying to divine some obscure reference there :)11:05
mdboothsileht dims_: So interestingly, I changed those asserts into RuntimeErrors and...11:10
mdboothtests started failing because of a bug :)11:11
silehtmdbooth, :)11:11
mdboothSo, why weren't they being executed?11:11
*** amotoki_ has quit IRC11:15
mdboothDoes anybody know of a way to run a single testscenarios-generated test with 'python -m testtools.run ...' ?11:16
mdboothFor example, how would I run:11:16
mdboothoslo_messaging.tests.rpc.test_server.TestMultipleServers.test_multiple_servers(same_exchange,diff_topic,same_server,not_fanout,call,two_endpoints)11:16
* mdbooth probably wasted over a day last week trying to work that out, and didn't succeed11:18
*** e0ne has quit IRC11:21
openstackgerritKseniya Tychkova proposed openstack/oslo.policy: Apache Fortress support prototype  https://review.openstack.org/23752111:27
*** salv-orl_ has joined #openstack-oslo11:31
*** rpodolyaka1 has quit IRC11:33
flaper87dims_: hey11:34
dims_flaper87: pong11:34
*** rpodolyaka1 has joined #openstack-oslo11:34
flaper87dims_: when you said that o.m gate is using the released version, where you referring to this patch? https://review.openstack.org/#/c/236900/111:34
*** salv-orlando has quit IRC11:34
dims_mdbooth: no idea11:34
*** rpodolyaka1 has quit IRC11:34
*** rpodolyaka1 has joined #openstack-oslo11:35
dims_flaper87: nope. hang on11:35
*** rpodolyaka1 has quit IRC11:35
flaper87dims_: mmh, ok. Because that's ignoring the change :D11:35
dims_flaper87: https://review.openstack.org/#/c/236168/11:35
*** rpodolyaka1 has joined #openstack-oslo11:35
*** rpodolyaka1 has quit IRC11:35
flaper87dims_: thanks11:36
dims_flaper87: y me and ozamiatin took a look at zmq run's pip-freeze and spotted that problem11:37
*** yamahata has quit IRC11:38
*** ozamiatin has quit IRC11:39
*** gordc has joined #openstack-oslo11:40
*** salv-orl_ has quit IRC11:44
*** salv-orlando has joined #openstack-oslo11:45
*** stevemar_ has joined #openstack-oslo11:45
*** stevemar_ has quit IRC11:48
*** jecarey has joined #openstack-oslo11:54
*** jecarey has quit IRC11:58
haypoi approved my own change fixing a docstring :-p https://review.openstack.org/#/c/237455/12:03
openstackgerritVictor Stinner proposed openstack/oslo.config: Use versionadded and versionchanged in doc  https://review.openstack.org/23523212:06
dukhlov@dims_: I have sent new patch to feature/pika branch. should I abandon patch to master branch?12:09
dukhlov@dims_:https://review.openstack.org/#/c/237532/12:10
jokke_haypo: that's very wrong of you :P12:10
haypojokke_: i know that it's a bad practice, but see the change. it's really short12:11
haypowe must write a tool to automate the detection of versionadded/versionchanged before a release, and at least emit a warning if the version looks wrong12:11
*** jaypipes has joined #openstack-oslo12:24
*** pradk has joined #openstack-oslo12:24
dims_dukhlov: yes, please abandon master12:25
dukhlovok12:25
*** dguitarbite has quit IRC12:26
*** amrith is now known as _amrith_12:27
*** rpodolyaka1 has joined #openstack-oslo12:28
*** amotoki has joined #openstack-oslo12:29
*** edmondsw has joined #openstack-oslo12:32
*** e0ne has joined #openstack-oslo12:33
silehtdims_, seems oslo.msg 2.7.0 breaks aodh project12:34
silehthttp://logs.openstack.org/12/237512/1/check/gate-aodh-python27/ee87460/testr_results.html.gz12:34
*** binarin has joined #openstack-oslo12:36
*** binarin has quit IRC12:36
*** amotoki has quit IRC12:43
*** dguitarbite has joined #openstack-oslo12:43
*** samueldmq has joined #openstack-oslo12:45
*** jecarey has joined #openstack-oslo12:48
*** jecarey has quit IRC12:48
flaper87sileht: https://review.openstack.org/#/c/231039/ (and the one it depends on)12:51
silehtflaper87, done12:53
silehtdims_, seems to be a issue in aodh that show up only with the new version, sorry for noise12:54
flaper87sileht: ++12:54
*** alejandrito has joined #openstack-oslo12:54
*** rlrossit has joined #openstack-oslo13:00
*** regXboi has joined #openstack-oslo13:03
*** ozamiatin has joined #openstack-oslo13:03
flaper87sileht: again, pls! I screwed up13:04
openstackgerritMerged openstack/oslo.config: Fix versionchanged  https://review.openstack.org/23745513:09
mdboothThe most frustrating aspect of working on oslo.messaging for me over the past few days has been the inability run run a debugger against tests generated by testscenarios13:24
mdboothThat has been absolute poison to my productivity13:25
mdboothIf anybody is aware of a solution to this problem I would be very grateful13:25
haypomdbooth: i don't understand testscenarios. it looks like black magic. i prefer mixin and classic test case classes13:27
mdboothhaypo: I don't care, as long as it generates something with a class name13:28
mdboothI want to be able to run 'python -m testtools.run ...'13:28
mdboothand drop into a debugger at my selected breakpoint13:29
*** dims_ has quit IRC13:30
*** dims_ has joined #openstack-oslo13:30
mdboothI think I'm about at the point where I would have saved time if last week I'd just worked out how to write my own testrunner13:30
mdboothThis particular problem is mostly about uncovering unexpected interactions. Doing that without a debugger has been an exercise in frustration.13:32
haypomdbooth: you should try to avoid testscenario :)13:33
mdboothhaypo: Well I will -1 any future patch I see which uses it :)13:33
mdboothBut unfortunately it's already in there, and the tests which use it are otherwise very good13:33
mdboothcase in point: they keep finding interesting interactions :)13:33
mdboothThey're just unable to tell me what they are13:34
*** pradk has quit IRC13:34
*** pradk has joined #openstack-oslo13:34
*** amotoki has joined #openstack-oslo13:36
dims_mdbooth: best resource === lifeless13:38
*** zqfan is now known as zqfan_afk13:38
*** _amrith_ is now known as amrith13:41
*** amotoki has quit IRC13:41
openstackgerritDina Belova proposed openstack/oslo.messaging: Modify simulator.py tool  https://review.openstack.org/23595813:42
*** rpodolyaka1 has quit IRC13:42
*** jecarey has joined #openstack-oslo13:45
*** jecarey has quit IRC13:45
kashyapdims_: Please don't address humans as "resources" :-)13:45
kashyapTechnically, we might be. . .13:45
dims_kashyap: yep. point taken13:45
*** jecarey has joined #openstack-oslo13:45
dims_apologies13:46
mdboothkashyap: What's your preferred address?13:46
dims_best human === lifeless :)13:46
mdboothlol13:46
kashyap:-)13:46
kashyapmdbooth: Well, "best person" is okay, no?13:46
* kashyap stops being an IRC police13:47
*** rpodolyaka1 has joined #openstack-oslo13:48
mdboothlifeless: I've heard you're an excellent human13:49
mdboothGot a sec?13:49
mdboothSee above question about debugging a testscenarios-generated test13:50
*** jecarey has quit IRC13:51
amrithdhellmann, ping13:53
amrithat yesterday's oslo meeting, dims suggested I contact you about this question.13:53
amrithis there a simple way to configure oslo.log to send all messages to a remote syslog or a remote machine?13:53
*** cprmrf has joined #openstack-oslo13:57
*** diana_clarke has joined #openstack-oslo14:03
*** diana_clarke has left #openstack-oslo14:03
*** alexpilotti has quit IRC14:04
dims_amrith: looks like there is a SysLogHandler - https://docs.python.org/2/library/logging.handlers.html14:06
dims_amrith: it has an address param14:06
dims_which defaults to localhost14:07
amrithdims, looking at just that now ...14:07
amrithwas looking also at a different option that would be specific for trove, to ship the data back to the trove controller host.14:09
*** fultonj has joined #openstack-oslo14:15
*** stevemar_ has joined #openstack-oslo14:16
*** stevemar_ has quit IRC14:20
*** sigmavirus24_awa is now known as sigmavirus2414:20
*** browne has joined #openstack-oslo14:25
mdboothfoo.dispatch calls foo._dispatch, which calls dispatcher._do_dispatch(foo), which calls foodispatcher._maybe_dispatch(do)14:29
mdbooth...got it14:29
*** rpodolyaka1 has quit IRC14:35
*** rpodolyaka1 has joined #openstack-oslo14:35
*** rpodolyaka1 has quit IRC14:36
mdboothThe executor thread tries to join itself!14:36
*** binarin has joined #openstack-oslo14:40
*** ozamiatin has quit IRC14:45
*** rpodolyaka1 has joined #openstack-oslo14:47
*** rpodolyaka1 has quit IRC14:50
mdboothYup, the blocking executor is blocking waiting on its own completion14:55
mdboothThis happened to work because previously join() was a noop14:56
* mdbooth is trying to work out if this is a test bug14:56
*** boris-42 has joined #openstack-oslo14:56
*** e0ne has quit IRC15:00
*** e0ne has joined #openstack-oslo15:02
*** links has quit IRC15:02
*** zqfan_afk is now known as zqfan15:05
*** rpodolyaka1 has joined #openstack-oslo15:10
*** jlvillal has quit IRC15:11
*** ozamiatin has joined #openstack-oslo15:12
*** jecarey has joined #openstack-oslo15:15
*** ozamiatin has quit IRC15:15
*** jecarey has quit IRC15:16
*** jlvillal has joined #openstack-oslo15:17
*** jecarey has joined #openstack-oslo15:17
*** salv-orlando has quit IRC15:18
*** thangp has joined #openstack-oslo15:18
*** zzzeek has quit IRC15:21
*** jecarey has quit IRC15:22
*** zzzeek has joined #openstack-oslo15:30
*** zzzeek has quit IRC15:30
*** zzzeek has joined #openstack-oslo15:31
*** dims__ has joined #openstack-oslo15:33
*** jecarey has joined #openstack-oslo15:34
dhellmannamrith: I think the way that's generally done is to talk to syslog locally and have the local syslog configured to ship the logs elsewhere. That way you don't take a network hit for processing outgoing log messages in your app.15:35
*** dims_ has quit IRC15:36
amrithdhellmann, thanks. currently the messages don't go to syslog (locally) so I'm looking at fixing it in oslo_logg using the syslog handler that dims suggested.15:36
*** amotoki has joined #openstack-oslo15:38
*** shardy_ has joined #openstack-oslo15:41
*** shardy has quit IRC15:42
*** stevemar_ has joined #openstack-oslo15:43
*** shardy_ has quit IRC15:46
*** pballand has joined #openstack-oslo15:46
*** shardy has joined #openstack-oslo15:47
*** amotoki has quit IRC15:51
*** ozamiatin has joined #openstack-oslo15:59
*** pradk has quit IRC15:59
*** vilobhmm11 has joined #openstack-oslo16:02
*** amotoki has joined #openstack-oslo16:05
*** vilobhmm11 has left #openstack-oslo16:08
*** zz_dimtruck is now known as dimtruck16:10
*** david-lyle has quit IRC16:18
*** nkrinner has quit IRC16:18
*** david-lyle has joined #openstack-oslo16:18
*** dstanek has quit IRC16:19
*** salv-orlando has joined #openstack-oslo16:20
*** jecarey has quit IRC16:21
*** dstanek has joined #openstack-oslo16:22
*** exploreshaifali has joined #openstack-oslo16:25
*** salv-orlando has quit IRC16:25
*** dimtruck is now known as zz_dimtruck16:33
*** e0ne has quit IRC16:33
mdboothharlowja dims__ sileht: Around?16:35
dims__pong (on a call)16:35
mdboothI've discovered yet another race :(16:35
mdboothAlthough I don't know what the seriousness is of this one16:35
mdboothSo, the contract of server.wait() is:16:36
mdbooth        After calling stop(), there may still be some existing messages16:36
mdbooth        which have not been completely processed. The wait() method blocks16:36
mdbooth        until all message processing has completed.16:36
mdbooth        Once it's finished, the underlying driver resources associated to this16:36
mdbooth        server are released (like closing useless network connections).16:36
mdboothHowever, it doesn't actually wait until all existing messages have been completely processed16:37
mdboothIt only waits until any message which is currently being processed has completed16:37
*** achanda has joined #openstack-oslo16:41
*** rpodolyaka1 has quit IRC16:41
*** markus_z has quit IRC16:41
*** rpodolyaka1 has joined #openstack-oslo16:42
*** pradk has joined #openstack-oslo16:43
mdboothHmm, I think it's just a test bug, actually16:47
mdboothAnd maybe some bad wording on that docstring16:47
*** stevemar_ has quit IRC16:52
*** zz_dimtruck is now known as dimtruck16:57
*** stevemar_ has joined #openstack-oslo16:59
*** achanda has quit IRC17:00
*** browne has quit IRC17:01
*** sputnik13 has joined #openstack-oslo17:03
harlowjamdbooth sup17:07
mdboothharlowja: I think I finally have it sorted :)17:07
harlowjaexecutors internally can't return from shutdown until they have finished all there in-progress stuffs17:07
mdboothRight, in-progress17:08
harlowjahttps://docs.python.org/dev/library/concurrent.futures.html#concurrent.futures.Executor.shutdown17:08
mdboothMy reading was 'all outstanding', though17:08
harlowjahmmm17:08
mdboothHowever, this isn't the case17:08
mdboothAnyway the issue is actually test_multiple_servers17:08
mdboothIn fact, the whole of test_servers17:09
harlowjaya, i would suspect that if outstanding == not know to the executor, then it can shutdown without it17:09
harlowjathings not known to executor are hard to track17:09
mdboothIt uses a pattern of adding an additional endpoint with a stop method17:09
mdboothAnd that stop method does server.stop(), server.wait()17:09
mdboothThe problem with that is that it's executed in the context of the blocking executor17:10
mdboothSo the executor is now waiting for itself to exit17:10
mdboothWhich obviously never happens17:10
harlowjawe should get rid of that executor imho17:10
harlowjalol17:10
mdboothThis setup is insane, but it makes sense in the context of these tests17:11
mdboothBecause the stop message is essentially a canary17:11
harlowjaright17:11
mdboothi.e. execute until you get the stop message17:11
mdboothThen stop executing17:11
harlowjayup17:11
harlowjatypically canary/tombstone/equivalent17:11
mdboothThe above understanding has taken me a very long time to obtain :)17:11
harlowja:-P17:11
mdboothHowever, now I have it, it's fixed17:11
mdboothI have re-implemented the stop message as a threading.Event17:12
harlowjacool17:12
harlowjamakes sense17:12
*** ozamiatin has quit IRC17:12
mdboothThe reason I hit this, btw, is because I made FakeBlockingThread.join() not a no-oip17:12
mdboothAnd, incidentally, my asserts weren't asserting17:13
harlowjahttps://github.com/openstack/taskflow/blob/master/taskflow/types/latch.py#L22 might be useful for u to, not sure, if u have N outstanding messages17:13
*** ozamiatin has joined #openstack-oslo17:13
harlowja^ a version of that is in the py3.3+ threading library, but ya, can't really use that yet, ha17:13
*** achanda has joined #openstack-oslo17:13
mdboothharlowja: Nah, I think the marker concept is good here17:14
harlowjak17:14
*** kelfen has joined #openstack-oslo17:14
mdboothAlthough it is kinda dependent on delivery ordering17:14
mdboothTests pass, though, so I guess it's good17:15
harlowjalol17:15
mdboothWell they didn't before I realised why the stop message was used :)17:15
mdboothMy first pass was to just remove it and call stop immediately17:15
mdboothBut of course all the tests failed because it stopped before processing all the test messages17:15
mdboothNon-deterministically17:15
harlowjathose are the fun ones :-P17:15
mdboothToday has been a fun day17:16
harlowjathe non-deterministic things that make u go crazy, lo17:16
kelfenHi guys! i'm trying to install Keystone release Juno but i've a little problem with oslo.i18n, when I try to start keystone this error occurred: "ImportError: cannot import name i18n"17:16
kelfenThe strange thing is that it happen in 1 of 3 nodes17:17
kelfenI'm tryng to import it also via python client, but the result is the same17:18
*** boris-42 has quit IRC17:18
*** jecarey has joined #openstack-oslo17:21
*** salv-orlando has joined #openstack-oslo17:24
*** salv-orlando has quit IRC17:24
*** salv-orlando has joined #openstack-oslo17:25
openstackgerritMatthew Booth proposed openstack/oslo.messaging: Fix a race calling blocking MessageHandlingServer.start()  https://review.openstack.org/23703817:25
openstackgerritMatthew Booth proposed openstack/oslo.messaging: Robustify locking in MessageHandlingServer  https://review.openstack.org/23534717:25
mdboothEnjoy17:25
mdboothharlowja: Incidentally, the regression is only fixed by the last patch in the series17:25
harlowjacol17:25
harlowja*cool17:25
mdboothNamely that not all threads would wait on wait()17:26
*** jecarey has quit IRC17:26
mdboothThis was supposed to be a small, quick fix.17:26
mdboothInteresting, though17:26
mdboothlaters17:26
*** dims__ has quit IRC17:27
*** dims_ has joined #openstack-oslo17:28
*** harlowja has quit IRC17:30
*** jecarey has joined #openstack-oslo17:34
*** harlowja has joined #openstack-oslo17:36
*** yamahata has joined #openstack-oslo17:38
*** kragniz has quit IRC17:39
*** achanda has quit IRC17:39
*** kragniz has joined #openstack-oslo17:39
*** rpodolyaka1 has quit IRC17:40
*** Alec_ has joined #openstack-oslo17:43
*** amotoki has quit IRC17:46
*** achanda has joined #openstack-oslo17:47
*** bnemec has quit IRC17:48
dhellmannharlowja, dims_: if you have some time https://review.openstack.org/#/c/236091 could use reviews17:51
dims_dhellmann: ack17:51
harlowjaah nice17:51
*** rlrossit has quit IRC17:52
*** jecarey has quit IRC17:53
*** sputnik13 has quit IRC17:53
*** kelfen has quit IRC17:54
amrithdhellmann, dims ... I opted for https://review.openstack.org/#/c/237710/17:54
*** pradk has quit IRC17:54
*** ozamiatin has quit IRC17:55
dims_amrith: whoa, increasing pressure on rabbit? that's going to hurt17:55
*** browne has joined #openstack-oslo17:55
openstackgerritMerged openstack/oslosphinx: add config option to point to the cgit browser  https://review.openstack.org/23609117:56
*** ozamiatin has joined #openstack-oslo17:56
*** sputnik13 has joined #openstack-oslo17:56
amrithdims_, I don't feel any pain. oh, I'm not a rabbit.17:57
amrithok17:57
amrith;)17:57
dims_lol17:57
dhellmannamrith: if the logger calls oslo.messaging, which calls the logger, what happens?17:58
dhellmannis that what the nested_call bit is for?17:58
amrithyes17:59
amriththat's the nested call piece17:59
amrithoslo.messaging does call LOG17:59
amrithand I don't want to go into an infinite loop17:59
dhellmannso you won't get any logging from oslo.messaging or anything it calls while another message is being logged, which I guess is better than getting no logs at all17:59
amrithor rather, without that, I did so I added that belt-and-suspender thing17:59
amriththis is mostly for debugging18:00
*** jecarey has joined #openstack-oslo18:00
amrithI'm kind-of more interested in seeing what the trove guest agent is doing18:00
amrithand in the gate, that is what I'm looking mostly at18:00
amrithI'm hoping that it isn't something where I'm going to need either MySQL's log18:00
amrithor the linux log file18:00
amriththis clearly won't get me that18:00
amrithI wanted to avoid getting into syslog18:01
amriththough that's easy enough18:01
amrithI'd just go setup syslog (not oslo.log ...) to forward18:01
dhellmannyeah18:01
lifelessmdbooth: hi, I do18:01
lifelessmdbooth: but I've no idea about the context... can you restate?18:02
*** jamielennox|away is now known as jamielennox18:02
*** ihrachys has quit IRC18:04
*** ndipanov has quit IRC18:06
*** ozamiatin has quit IRC18:08
openstackgerritDan Smith proposed openstack/oslo.versionedobjects: Make class action calls use version manifest  https://review.openstack.org/22486118:08
openstackgerritDan Smith proposed openstack/oslo.versionedobjects: Make tests properly use object_class_action_versions()  https://review.openstack.org/22486218:08
openstackgerritDan Smith proposed openstack/oslo.versionedobjects: Add warnings for deprecated IndirectionAPI methods  https://review.openstack.org/22486318:08
*** rlrossit has joined #openstack-oslo18:10
*** achanda has quit IRC18:11
*** jecarey_ has joined #openstack-oslo18:20
*** jecarey has quit IRC18:21
*** ozamiatin has joined #openstack-oslo18:27
*** jecarey_ has quit IRC18:30
*** sputnik13 has quit IRC18:30
*** sputnik13 has joined #openstack-oslo18:31
*** zqfan is now known as zqfan_afk18:32
*** achanda has joined #openstack-oslo18:33
*** rpodolyaka1 has joined #openstack-oslo18:35
*** achanda has quit IRC18:39
*** jecarey has joined #openstack-oslo18:42
*** jecarey has quit IRC18:44
*** exploreshaifali has quit IRC18:44
*** achanda has joined #openstack-oslo18:48
*** jecarey has joined #openstack-oslo18:52
*** pradk has joined #openstack-oslo18:52
*** harlowja has quit IRC18:53
*** jecarey has quit IRC18:55
*** shardy has quit IRC19:04
*** shardy has joined #openstack-oslo19:06
openstackgerritDavanum Srinivas (dims) proposed openstack/oslo-incubator: Adjust script to skip tests if directory not present  https://review.openstack.org/23774719:06
*** thumpba has joined #openstack-oslo19:09
*** harlowja has joined #openstack-oslo19:11
*** abetterlie_ has joined #openstack-oslo19:19
*** jecarey has joined #openstack-oslo19:21
*** salv-orlando has quit IRC19:23
*** achanda has quit IRC19:23
*** fultonj has left #openstack-oslo19:39
*** pradk has quit IRC19:46
*** Alec_ has quit IRC19:49
*** yassine has quit IRC19:50
openstackgerritJoshua Harlow proposed openstack/taskflow: Move 'fill_iter' to 'iter_utils.fill'  https://review.openstack.org/23734919:50
*** kfarr has joined #openstack-oslo19:55
*** thumpba has quit IRC19:56
*** shardy has quit IRC19:56
*** shardy has joined #openstack-oslo19:58
*** ndipanov has joined #openstack-oslo19:59
*** boris-42 has joined #openstack-oslo20:02
*** thangp has quit IRC20:02
*** rpodolyaka1 has quit IRC20:03
*** bnemec has joined #openstack-oslo20:03
*** jecarey has quit IRC20:05
*** salv-orlando has joined #openstack-oslo20:05
*** jecarey has joined #openstack-oslo20:05
*** jecarey has quit IRC20:10
*** adam_g has quit IRC20:10
*** amrith is now known as _amrith_20:12
*** adam_g has joined #openstack-oslo20:14
*** adam_g has quit IRC20:14
*** adam_g has joined #openstack-oslo20:14
openstackgerritDavanum Srinivas (dims) proposed openstack/oslo.context: Ensure to_dict() supports non-ascii characters  https://review.openstack.org/23776720:15
*** kgiusti has left #openstack-oslo20:18
*** achanda has joined #openstack-oslo20:24
*** jecarey has joined #openstack-oslo20:25
*** achanda has quit IRC20:25
*** jsavak has joined #openstack-oslo20:42
openstackgerritDavanum Srinivas (dims) proposed openstack/oslo.messaging: Decouple transport for RPC and Notification  https://review.openstack.org/23325820:44
*** achanda has joined #openstack-oslo20:47
*** rpodolyaka1 has joined #openstack-oslo20:50
*** Alec_ has joined #openstack-oslo20:50
*** rpodolyaka1 has quit IRC20:53
*** achanda has quit IRC20:53
*** sputnik13 has quit IRC20:54
*** Alec_ has quit IRC20:54
*** regXboi has quit IRC21:03
*** zqfan_afk has quit IRC21:06
*** Alec_ has joined #openstack-oslo21:07
*** achanda has joined #openstack-oslo21:07
*** jsavak has quit IRC21:12
*** ozamiatin has quit IRC21:13
*** achanda has quit IRC21:15
*** abetterlie_ has quit IRC21:15
*** jamielennox is now known as jamielennox|away21:20
*** ndipanov has quit IRC21:24
*** rlrossit has left #openstack-oslo21:24
*** jamielennox|away is now known as jamielennox21:28
*** salv-orlando has quit IRC21:33
*** kfarr has quit IRC21:33
*** salv-orlando has joined #openstack-oslo21:34
*** achanda has joined #openstack-oslo21:35
*** alejandrito has quit IRC21:47
*** achanda has quit IRC21:47
openstackgerritMerged openstack/taskflow: Fix order of assertEqual for unit.worker_based  https://review.openstack.org/23620021:55
*** achanda has joined #openstack-oslo21:57
*** stevemar_ has quit IRC21:58
*** stevemar_ has joined #openstack-oslo21:58
*** edmondsw has quit IRC21:59
*** cprmrf has quit IRC21:59
openstackgerritRonald Bradford proposed openstack/oslo.context: Remove reference to undefined attributes  https://review.openstack.org/23778922:01
openstackgerritMerged openstack/taskflow: Fix order of assertEqual for unit.persistence  https://review.openstack.org/23619922:01
openstackgerritMerged openstack/taskflow: Fix order of assertEqual for unit.action_engine  https://review.openstack.org/23619422:01
openstackgerritMerged openstack/taskflow: Fix order of assertEqual for unit.jobs  https://review.openstack.org/23619622:02
*** achanda has quit IRC22:02
openstackgerritMerged openstack/taskflow: Fix order of assertEqual for unit.patterns  https://review.openstack.org/23619722:02
openstackgerritMerged openstack/taskflow: Fix order of assertEqual for unit.test_*  https://review.openstack.org/23665922:02
openstackgerritMerged openstack/taskflow: Register conductor information on jobboard  https://review.openstack.org/23444822:02
*** stevemar_ has quit IRC22:02
*** ozamiatin has joined #openstack-oslo22:08
*** browne has quit IRC22:08
*** browne has joined #openstack-oslo22:09
*** ozamiatin has quit IRC22:09
*** achanda has joined #openstack-oslo22:12
openstackgerritDrew Varner proposed openstack/oslo.utils: comment in write_to_tempfile  https://review.openstack.org/23779222:14
*** browne has quit IRC22:14
*** jecarey has quit IRC22:15
*** jecarey has joined #openstack-oslo22:30
*** lhcheng has joined #openstack-oslo22:31
lhchengdims_: ping22:31
*** jamielennox is now known as jamielennox|away22:31
openstackgerritDrew Varner proposed openstack/oslo.utils: comment in write_to_tempfile  https://review.openstack.org/23779222:32
*** jecarey has quit IRC22:34
*** jongchoi has joined #openstack-oslo22:36
*** jongchoi has quit IRC22:36
*** gordc has quit IRC22:37
*** dimtruck is now known as zz_dimtruck22:40
*** sigmavirus24 is now known as sigmavirus24_awa22:49
*** Alec_ has quit IRC22:56
*** avarner has joined #openstack-oslo22:58
*** sputnik13 has joined #openstack-oslo23:01
*** sputnik13 has quit IRC23:06
*** salv-orlando has quit IRC23:06
*** browne has joined #openstack-oslo23:10
*** yamahata__ has quit IRC23:11
*** yamahata__ has joined #openstack-oslo23:11
*** isq has joined #openstack-oslo23:12
*** yfujioka has joined #openstack-oslo23:20
*** jamielennox|away is now known as jamielennox23:32
*** jaypipes has quit IRC23:36
dims_lhcheng: pong23:38
harlowjadims_ https://bugs.launchpad.net/cinder/+bug/1432387 fyi23:39
openstackLaunchpad bug 1432387 in Cinder "abandoned lock files" [High,In progress] - Assigned to Alex Xu (xuhj)23:39
harlowjai've proposed a few ideas there23:39
harlowjasee comments 7-1023:40
harlowja6-10 i mean23:40
harlowja*6-9, lol23:40
harlowjathat range :-P23:40
harlowjafinal answer23:40
dims_harlowja: will check it out in a little bit. thanks23:41
harlowjanp23:41
jlvillalAnyone know if in oslo_messaging can setup a dummy type messaging queue?  Trying to do functional testing in Ironic.23:44
jlvillalAnd ironic-api and ironic-conductor communicate via rabbitmq, using oslo_messaging. I would prefer not to require rabbitmq if possible to do the functional testing.23:45
*** dims_ has quit IRC23:45
*** dims has joined #openstack-oslo23:46
jlvillalI wasn't sure if the transport driver 'fake' would work23:47
lhchengdims: I am wondering if you're looking at nova to use global cache for the service tokens.23:49
lhchengdims: do you know if there is a bug/bp for that?23:50
dimslhcheng: does not ring a bell23:50
lhchengdims: okay, maybe somebody else is looking at it. :)23:51
dimslhcheng: what problem does that solve?23:52
lhchengjamielennox: do you recall who's working on "use global cache for the service tokens" ?23:52
lhchengdims: I think right now for inter-service communication, nova fetches a new token everytime23:52
jamielennoxFor auth_token middleware , just me23:53
dimslhcheng: i know we fixed that behavior for nova<->neutron handshake23:53
lhchengdims: we saw that behavior for the nova-to-ironic communication23:53
jamielennoxIronic is pretty terrible at this23:53
lhchengdims: yeah, I saw some caching in nova-neutron handshake in: https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L211-L25323:54
dimslhcheng: right23:54
jamielennoxThat will be massively improved with the locking done in keystone auth23:55
lhchengjamielennox: oh okay, thought you were working with dims on this.. :)23:55
jamielennoxThere are lots of places with similar issues. dims has been doing the nova-> neutron bit23:56
lhcheng:(23:57
lhchenglet me know if you need help fixing that in other areas23:58
lhchengwe can chat on the path forward in the summit23:58
lhchengjamielennox: ^23:58
openstackgerritJoshua Harlow proposed openstack/taskflow: Add a executor backed conductor and have existing impl. use it  https://review.openstack.org/17464323:59
harlowjalhcheng why isn't the token just like this23:59
harlowjatoken = {23:59
harlowja    'value': value,23:59
harlowja    'expiry': expiry,23:59
harlowja    'signature': signature,23:59
harlowja    'version': 1,23:59
harlowja}23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!