*** achanda_ has quit IRC | 00:11 | |
openstackgerrit | Merged openstack/taskflow: Enable testr OS_DEBUG to be TRACE(blather) by default https://review.openstack.org/208791 | 00:17 |
---|---|---|
openstackgerrit | Joshua Harlow proposed openstack/oslo.service: Avoid using the global lockutils semaphore collection https://review.openstack.org/209285 | 00:34 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.messaging: Added additional logging https://review.openstack.org/194295 | 00:35 |
openstackgerrit | Joshua Harlow proposed openstack/oslo.service: Avoid using the global lockutils semaphore collection https://review.openstack.org/209285 | 00:35 |
*** tsekiyam_ has joined #openstack-oslo | 00:38 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.messaging: Added additional logging https://review.openstack.org/194295 | 00:40 |
*** mtanino has quit IRC | 00:41 | |
*** tsekiyama has quit IRC | 00:41 | |
*** tsekiyam_ has quit IRC | 00:42 | |
*** prad has quit IRC | 00:43 | |
*** stevemar has joined #openstack-oslo | 00:55 | |
openstackgerrit | Joshua Harlow proposed openstack/oslo.service: Use contextlib.closing instead of try ... finally: sock.close https://review.openstack.org/209301 | 00:57 |
*** stevemar has quit IRC | 00:58 | |
*** salv-orlando has joined #openstack-oslo | 00:59 | |
*** jdandrea has quit IRC | 01:02 | |
*** alexpilotti has quit IRC | 01:03 | |
*** salv-orlando has quit IRC | 01:04 | |
*** abitha has quit IRC | 01:05 | |
*** amotoki has joined #openstack-oslo | 01:07 | |
*** david-lyle has joined #openstack-oslo | 01:19 | |
*** zzzeek has joined #openstack-oslo | 01:27 | |
openstackgerrit | Merged openstack/oslo.messaging: Fix BaseDriver.listen_for_notifications() signature https://review.openstack.org/209043 | 01:27 |
*** zzzeek has quit IRC | 01:50 | |
*** sdake_ has quit IRC | 02:04 | |
*** dims has quit IRC | 02:04 | |
*** zz_dimtruck is now known as dimtruck | 02:04 | |
*** sdake has joined #openstack-oslo | 02:04 | |
*** salv-orlando has joined #openstack-oslo | 02:05 | |
*** achanda has joined #openstack-oslo | 02:07 | |
*** salv-orlando has quit IRC | 02:12 | |
*** achanda has quit IRC | 02:14 | |
openstackgerrit | Merged openstack/oslo.versionedobjects: Add usage information https://review.openstack.org/207330 | 02:27 |
openstackgerrit | Merged openstack/oslo.versionedobjects: Add validation on target_version arg when calling obj_to_primitive https://review.openstack.org/207998 | 02:28 |
*** achanda has joined #openstack-oslo | 02:28 | |
*** achanda_ has joined #openstack-oslo | 02:54 | |
*** achanda has quit IRC | 02:55 | |
*** achanda has joined #openstack-oslo | 03:03 | |
*** achanda_ has quit IRC | 03:03 | |
*** rjaiswal has quit IRC | 03:10 | |
*** dimtruck is now known as zz_dimtruck | 03:15 | |
*** Nakato has quit IRC | 03:38 | |
*** achanda has quit IRC | 03:38 | |
*** Nakato has joined #openstack-oslo | 03:40 | |
*** LimorStotland has joined #openstack-oslo | 03:41 | |
*** svilgelm has joined #openstack-oslo | 03:42 | |
*** stevemar has joined #openstack-oslo | 03:55 | |
*** ozamiatin has joined #openstack-oslo | 03:56 | |
*** stevemar has quit IRC | 03:58 | |
*** svilgelm has quit IRC | 04:03 | |
*** jamespage has quit IRC | 04:05 | |
*** jamespage has joined #openstack-oslo | 04:06 | |
*** rpodolyaka1 has joined #openstack-oslo | 04:08 | |
*** salv-orlando has joined #openstack-oslo | 04:10 | |
*** harlowja_at_home has joined #openstack-oslo | 04:11 | |
*** ozamiatin has quit IRC | 04:12 | |
*** amotoki has quit IRC | 04:18 | |
*** salv-orlando has quit IRC | 04:22 | |
*** LimorStotland has quit IRC | 04:28 | |
*** stevemar has joined #openstack-oslo | 04:29 | |
*** achanda has joined #openstack-oslo | 04:41 | |
*** pcaruana has quit IRC | 04:59 | |
*** harlowja_at_home has quit IRC | 05:08 | |
*** salv-orlando has joined #openstack-oslo | 05:21 | |
*** salv-orlando has quit IRC | 05:23 | |
openstackgerrit | Merged openstack/tooz: Expose 'run_elect_coordinator' and call it from 'run_watchers' https://review.openstack.org/193693 | 06:13 |
*** rpodolyaka1 has quit IRC | 06:15 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.messaging: Imported Translations from Transifex https://review.openstack.org/209363 | 06:17 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Refactor argument and provider fetching https://review.openstack.org/187376 | 06:21 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Move bulk of storage '__init__' logic to new '_prepare' method https://review.openstack.org/202794 | 06:26 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Allow customized scope lookup reordering https://review.openstack.org/206769 | 06:27 |
*** browne has quit IRC | 06:34 | |
*** rjaiswal has joined #openstack-oslo | 06:36 | |
*** pcaruana has joined #openstack-oslo | 06:36 | |
*** stevemar has quit IRC | 06:40 | |
*** salv-orlando has joined #openstack-oslo | 06:41 | |
*** stevemar has joined #openstack-oslo | 06:41 | |
*** achanda has quit IRC | 06:42 | |
*** ihrachyshka has joined #openstack-oslo | 06:42 | |
*** abhishekk has joined #openstack-oslo | 06:42 | |
*** stevemar has quit IRC | 06:43 | |
*** sputnik13 has joined #openstack-oslo | 06:52 | |
*** svilgelm has joined #openstack-oslo | 07:00 | |
*** rpodolyaka1 has joined #openstack-oslo | 07:01 | |
*** svilgelm_ has joined #openstack-oslo | 07:01 | |
*** sputnik13 has quit IRC | 07:03 | |
*** abhishekk has quit IRC | 07:04 | |
*** svilgelm has quit IRC | 07:05 | |
*** ndipanov has joined #openstack-oslo | 07:22 | |
*** LimorStotland has joined #openstack-oslo | 07:27 | |
*** browne has joined #openstack-oslo | 07:30 | |
*** rpodolyaka1 has quit IRC | 07:31 | |
*** yamahata has quit IRC | 07:31 | |
*** salv-orlando has quit IRC | 07:38 | |
*** browne has quit IRC | 07:40 | |
*** e0ne has joined #openstack-oslo | 07:47 | |
*** amotoki has joined #openstack-oslo | 07:48 | |
*** e0ne has quit IRC | 07:52 | |
*** e0ne has joined #openstack-oslo | 07:56 | |
*** yassine has joined #openstack-oslo | 08:02 | |
*** e0ne has quit IRC | 08:04 | |
*** barra204 has quit IRC | 08:25 | |
*** boris-42 has quit IRC | 08:30 | |
*** mdbooth has quit IRC | 08:30 | |
*** mdbooth has joined #openstack-oslo | 08:30 | |
*** ihrachyshka has quit IRC | 08:35 | |
*** salv-orlando has joined #openstack-oslo | 08:39 | |
*** stevemar has joined #openstack-oslo | 08:41 | |
*** stevemar has quit IRC | 08:45 | |
*** LimorStotland has quit IRC | 09:04 | |
*** rjaiswal has quit IRC | 09:30 | |
*** e0ne has joined #openstack-oslo | 09:31 | |
*** salv-orlando has quit IRC | 09:36 | |
*** e0ne has quit IRC | 09:38 | |
*** stevemar has joined #openstack-oslo | 09:42 | |
*** cdent has joined #openstack-oslo | 09:45 | |
*** stevemar has quit IRC | 09:46 | |
openstackgerrit | Elena Ezhova proposed openstack/oslo.service: Check that sighup is supported before accessing signal.SIGHUP https://review.openstack.org/209431 | 09:53 |
*** dims has joined #openstack-oslo | 10:00 | |
*** dims has quit IRC | 10:00 | |
*** dims has joined #openstack-oslo | 10:00 | |
xek | dansmith, I got a comment on a versioned objects spec, which got me thinking - how would you add a method on a versioned object and keep the client compatible with an older server? | 10:14 |
xek | dansmith, I posted my thoughts here: https://review.openstack.org/#/c/196670/ | 10:14 |
*** rpodolyaka1 has joined #openstack-oslo | 10:15 | |
*** e0ne has joined #openstack-oslo | 10:30 | |
*** salv-orlando has joined #openstack-oslo | 10:34 | |
dims | @rpodolyaka: is this good now? https://review.openstack.org/#/c/201265/ (bbobrov’s oslo.db patch) | 10:37 |
*** exploreshaifali has joined #openstack-oslo | 10:42 | |
sileht | oslo.db folks I have a question about pagination, In gnocchi, we try to add pagination in the API, I run into an issue | 10:43 |
sileht | When I sort the result on a nullable column, I don't get the same result on postgresql and mysql | 10:44 |
sileht | I known this is a diffrence between backend, but does oslo.db should hide this difference ? | 10:44 |
sileht | (I can write a patch is needed) | 10:45 |
*** e0ne has quit IRC | 10:46 | |
*** h00327910__ has quit IRC | 10:58 | |
rpodolyaka1 | dims: will take a look right after a call | 10:58 |
rpodolyaka1 | sileht: how would you expect it to do that? sorting is done by the RDBMS itself - I'm not sure how we can tell it how exactly types should be compared | 11:00 |
rpodolyaka1 | sileht: pagination is usually done based on PK, or something like created_at/updated_at | 11:00 |
rpodolyaka1 | (and a marker) | 11:01 |
*** ihrachyshka has joined #openstack-oslo | 11:01 | |
sileht | rpodolyaka1, postgresql have 'NULLS FIRST' / 'NULLS LAST' to control the behavior | 11:03 |
sileht | rpodolyaka1, mysql have order by ISNULL(col), col | 11:03 |
sileht | rpodolyaka1, or 'order by col is NULL, col' works for both | 11:03 |
*** exploreshaifali has quit IRC | 11:04 | |
sileht | rpodolyaka1, in gnocchi we have field like 'ended_at' that NULL if the resource have not been ended yet | 11:05 |
*** e0ne has joined #openstack-oslo | 11:07 | |
*** claudiub has joined #openstack-oslo | 11:08 | |
rpodolyaka1 | sileht: ok. I think we could probably extend https://github.com/openstack/oslo.db/blob/master/oslo_db/sqlalchemy/utils.py#L65 to hide this difference | 11:15 |
rpodolyaka1 | sileht: although I don't want it to become 'too smart' and decide for you | 11:15 |
rpodolyaka1 | sileht: so I'm ok with making this optional, if one explicitly passed desired behavior for NULLs | 11:16 |
rpodolyaka1 | sileht: and implement it for MySQL, PostgreSQL and fall back to 'order by col is NULL, col' | 11:16 |
*** ihrachyshka has quit IRC | 11:19 | |
*** jaypipes has joined #openstack-oslo | 11:24 | |
openstackgerrit | Merged openstack/oslo.messaging: Imported Translations from Transifex https://review.openstack.org/209363 | 11:25 |
sileht | rpodolyaka1, cool I have started something | 11:25 |
*** alexpilotti has joined #openstack-oslo | 11:26 | |
*** dims_ has joined #openstack-oslo | 11:26 | |
rpodolyaka1 | sileht: great! feel free to file a Wishlist bug and add me to reviewers then ;) | 11:27 |
*** gordc has joined #openstack-oslo | 11:28 | |
*** dims has quit IRC | 11:28 | |
*** e0ne has quit IRC | 11:34 | |
*** dims_ has quit IRC | 11:44 | |
*** dims has joined #openstack-oslo | 11:51 | |
*** yassine has quit IRC | 11:51 | |
*** takedakn has joined #openstack-oslo | 11:53 | |
*** ihrachyshka has joined #openstack-oslo | 12:05 | |
*** e0ne has joined #openstack-oslo | 12:06 | |
*** yassine has joined #openstack-oslo | 12:07 | |
openstackgerrit | Boris Bobrov proposed openstack/oslo.db: Upgrade and downgrade based on revision existence https://review.openstack.org/201265 | 12:18 |
*** alejandrito has joined #openstack-oslo | 12:19 | |
cdent | dhellmann: if you're about and you have the power is there a way you can delete this: https://pypi.python.org/pypi/ceilometer | 12:34 |
*** salv-orlando has quit IRC | 12:37 | |
*** salv-orlando has joined #openstack-oslo | 12:45 | |
*** prad has joined #openstack-oslo | 12:52 | |
*** bapalm has joined #openstack-oslo | 12:52 | |
*** bapalm_ has joined #openstack-oslo | 12:53 | |
*** dims_ has joined #openstack-oslo | 12:57 | |
*** bapalm has quit IRC | 12:57 | |
*** dims has quit IRC | 12:59 | |
*** thumpba has joined #openstack-oslo | 13:01 | |
*** thumpba has quit IRC | 13:04 | |
*** browne has joined #openstack-oslo | 13:06 | |
*** mriedem_away is now known as mriedem | 13:08 | |
*** alejandrito has quit IRC | 13:10 | |
*** takedakn1 has joined #openstack-oslo | 13:12 | |
*** takedakn has quit IRC | 13:12 | |
*** kgiusti has joined #openstack-oslo | 13:16 | |
*** alexpilotti has quit IRC | 13:21 | |
*** zzzeek has joined #openstack-oslo | 13:21 | |
*** sdake has quit IRC | 13:21 | |
*** exploreshaifali has joined #openstack-oslo | 13:22 | |
*** alexpilotti has joined #openstack-oslo | 13:23 | |
*** bknudson has joined #openstack-oslo | 13:28 | |
*** saggi has left #openstack-oslo | 13:28 | |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.db: WIP: pagination: enhance sorting of null values https://review.openstack.org/209518 | 13:33 |
openstackgerrit | Thang Pham proposed openstack/oslo.versionedobjects: Fix ComparableVersionedObject in python 3.4 https://review.openstack.org/206679 | 13:34 |
*** jd__` has joined #openstack-oslo | 13:34 | |
*** jd__- has joined #openstack-oslo | 13:35 | |
*** jecarey has joined #openstack-oslo | 13:36 | |
*** dims has joined #openstack-oslo | 13:36 | |
dansmith | xek: are you talking about changing calls to normal rpc methods, or changing the call on an object? | 13:37 |
xek | dansmith, changing a call on an object | 13:38 |
*** dims_ has quit IRC | 13:38 | |
xek | dansmith, I assume the first think will just result in an exception from the oslo.messaging library | 13:38 |
dansmith | xek: so that is why we always have conductor be newest. The object version goes with the rpc call, which means if conductor is older, we can reject the call because of the version | 13:38 |
xek | *thing | 13:38 |
dansmith | no, the exception comes from the objects code | 13:39 |
*** jdandrea has joined #openstack-oslo | 13:39 | |
dansmith | because object rpc calls are not normal oslo.messaging calls | 13:39 |
xek | oslo.messaging also has it's exceptions ( UnsupportedRpcEnvelopeVersion ), when versioning RPC calls | 13:41 |
dansmith | right, but a call on an object is not an oslo.messaging call | 13:41 |
xek | dansmith, ok, in heat there is no conductor though | 13:42 |
dansmith | it uses an oslo.messaging call (object_action or object_class_action), but those calls are static and don't change | 13:42 |
*** dims_ has joined #openstack-oslo | 13:42 | |
dansmith | sure, but that means you have to implement object_action to do something specific | 13:42 |
dansmith | maybe that means you just turn it into a regular oslo.messaging call, | 13:42 |
dansmith | but if you do that, then you can do whatever you want to handle the version difference | 13:42 |
xek | the oslo.messaging can't handle this case eather - it just raises an exception | 13:43 |
dansmith | right, if the version is a mismatch | 13:43 |
xek | in my comment I proposed writing method which know about what versions are expected | 13:43 |
*** dims has quit IRC | 13:44 | |
xek | and since they will be placed in the object code, at least the scope of the version management is limited to the versioned object code | 13:44 |
*** jd__` has quit IRC | 13:45 | |
*** jd__- has quit IRC | 13:45 | |
*** jd__ has quit IRC | 13:45 | |
xek | for now I don't have any better ideas | 13:45 |
dansmith | okay, I'm not sure I understand because your spec doesn't seem to be related to object methods | 13:45 |
dansmith | but let me get some coffee and read | 13:45 |
*** jd__ has joined #openstack-oslo | 13:45 | |
xek | no, but Zane thinks this is a bigger problem then managing the versions of objects sent through RPC, so we were discussing that | 13:46 |
*** jd__ has quit IRC | 13:46 | |
*** sc68cal_ has joined #openstack-oslo | 13:46 | |
*** LimorStotland has joined #openstack-oslo | 13:46 | |
*** jd__ has joined #openstack-oslo | 13:46 | |
*** exploreshaifali has quit IRC | 13:46 | |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.db: WIP: pagination: enhance sorting of null values https://review.openstack.org/209518 | 13:49 |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.db: pagination: enhance sorting of null values https://review.openstack.org/209518 | 13:50 |
*** sc68cal has quit IRC | 13:52 | |
*** salv-orlando has quit IRC | 13:53 | |
xek | dansmith, I was curious if there were any concerns of this sort in Nova, but as you say, when the conductor is in the newest version, and it doesn't call objects on the compute nodes, there are no issues related to this in nova... | 13:54 |
dansmith | xek: well, the closest thing would be one newer compute sending an object to an older compute over a regular rpc method | 13:55 |
*** dims has joined #openstack-oslo | 13:55 | |
dansmith | xek: when that is done, the older compute bounces it to conductor for backporting | 13:55 |
*** sigmavirus24_awa is now known as sigmavirus24 | 13:56 | |
*** dims_ has quit IRC | 13:57 | |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.db: pagination: enhance sorting of null values https://review.openstack.org/209518 | 14:01 |
*** zz_dimtruck is now known as dimtruck | 14:02 | |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.db: pagination: enhance sorting of null values https://review.openstack.org/209518 | 14:04 |
*** zigo has quit IRC | 14:05 | |
dansmith | xek: I commented | 14:05 |
*** zigo has joined #openstack-oslo | 14:06 | |
*** thumpba has joined #openstack-oslo | 14:07 | |
xek | dansmith, thanks! | 14:09 |
openstackgerrit | Thang Pham proposed openstack/oslo.versionedobjects: Make direct call to object's obj_from_primitive https://review.openstack.org/206637 | 14:09 |
*** takedakn1 has quit IRC | 14:14 | |
*** takedakn has joined #openstack-oslo | 14:22 | |
*** takedakn has quit IRC | 14:22 | |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.db: pagination: enhance sorting of null values https://review.openstack.org/209518 | 14:24 |
*** dims_ has joined #openstack-oslo | 14:27 | |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.db: pagination: enhance sorting of null values https://review.openstack.org/209518 | 14:29 |
*** dims has quit IRC | 14:29 | |
sileht | rpodolyaka1, that's ready: https://review.openstack.org/209518 | 14:30 |
rpodolyaka1 | sileht: cool! will take a look a bit later | 14:30 |
sileht | rpodolyaka1, thanks | 14:30 |
rpodolyaka1 | np | 14:30 |
*** dims has joined #openstack-oslo | 14:31 | |
*** dims_ has quit IRC | 14:33 | |
*** dims_ has joined #openstack-oslo | 14:34 | |
*** dims has quit IRC | 14:37 | |
*** dims has joined #openstack-oslo | 14:38 | |
*** bapalm_ has quit IRC | 14:38 | |
*** dims_ has quit IRC | 14:40 | |
*** svilgelm_ has quit IRC | 14:44 | |
*** svilgelm has joined #openstack-oslo | 14:44 | |
*** stevemar has joined #openstack-oslo | 14:46 | |
*** bapalm_ has joined #openstack-oslo | 14:46 | |
*** ozamiatin has joined #openstack-oslo | 14:50 | |
*** svilgelm has quit IRC | 14:52 | |
*** svilgelm_ has joined #openstack-oslo | 14:52 | |
*** mtanino has joined #openstack-oslo | 15:00 | |
*** ndipanov has quit IRC | 15:06 | |
*** yamahata has joined #openstack-oslo | 15:11 | |
*** rjaiswal has joined #openstack-oslo | 15:18 | |
*** ozamiatin has quit IRC | 15:30 | |
*** tsekiyama has joined #openstack-oslo | 15:32 | |
openstackgerrit | ice yao proposed openstack/oslo-specs: Update setuptools setup_requires https://review.openstack.org/209562 | 15:33 |
*** bapalm_ has quit IRC | 15:34 | |
*** shakamunyi has joined #openstack-oslo | 15:35 | |
*** ozamiatin has joined #openstack-oslo | 15:37 | |
*** sdake has joined #openstack-oslo | 15:50 | |
*** ozamiatin has quit IRC | 15:53 | |
openstackgerrit | Merged openstack/oslo.db: Upgrade and downgrade based on revision existence https://review.openstack.org/201265 | 15:56 |
*** bapalm_ has joined #openstack-oslo | 15:57 | |
*** dims_ has joined #openstack-oslo | 16:00 | |
*** dims__ has joined #openstack-oslo | 16:02 | |
*** dims has quit IRC | 16:02 | |
*** dims_ has quit IRC | 16:04 | |
*** alexpilotti has quit IRC | 16:06 | |
*** salv-orlando has joined #openstack-oslo | 16:06 | |
*** stevemar has quit IRC | 16:10 | |
*** stevemar has joined #openstack-oslo | 16:11 | |
*** dims has joined #openstack-oslo | 16:12 | |
*** dims__ has quit IRC | 16:13 | |
*** exploreshaifali has joined #openstack-oslo | 16:16 | |
*** browne has quit IRC | 16:23 | |
*** pcaruana has quit IRC | 16:26 | |
*** openstackgerrit_ has joined #openstack-oslo | 16:30 | |
openstackgerrit | Thang Pham proposed openstack/oslo.versionedobjects: Fix ComparableVersionedObject in python 3.4 https://review.openstack.org/206679 | 16:32 |
*** viktors is now known as viktors|afk | 16:44 | |
*** sputnik13 has joined #openstack-oslo | 16:48 | |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.db: pagination: enhance sorting of null values https://review.openstack.org/209518 | 16:56 |
*** yassine has quit IRC | 16:56 | |
*** sdake has quit IRC | 16:58 | |
*** bapalm_ has quit IRC | 17:00 | |
*** sputnik13 has quit IRC | 17:01 | |
*** sputnik13 has joined #openstack-oslo | 17:02 | |
*** openstackgerrit_ has quit IRC | 17:05 | |
*** abitha has joined #openstack-oslo | 17:05 | |
*** dims has quit IRC | 17:11 | |
*** dims has joined #openstack-oslo | 17:12 | |
*** e0ne has quit IRC | 17:13 | |
*** jamespage_ has joined #openstack-oslo | 17:14 | |
*** browne has joined #openstack-oslo | 17:14 | |
*** jaypipes has quit IRC | 17:15 | |
*** openstackgerrit_ has joined #openstack-oslo | 17:24 | |
*** achanda has joined #openstack-oslo | 17:25 | |
*** ihrachyshka has quit IRC | 17:28 | |
*** jaypipes has joined #openstack-oslo | 17:29 | |
*** openstackgerrit_ has quit IRC | 17:34 | |
*** svilgelm_ has quit IRC | 17:39 | |
*** e0ne has joined #openstack-oslo | 17:53 | |
*** jamespage_ has quit IRC | 17:53 | |
*** bapalm_ has joined #openstack-oslo | 18:00 | |
*** svilgelm has joined #openstack-oslo | 18:01 | |
*** bapalm_ has quit IRC | 18:06 | |
*** svilgelm has quit IRC | 18:06 | |
*** exploreshaifali has quit IRC | 18:20 | |
*** exploreshaifali has joined #openstack-oslo | 18:21 | |
*** sdake has joined #openstack-oslo | 18:32 | |
mriedem | dims: it appears we need a stable/kilo oslo.vmware release for https://github.com/openstack/oslo.vmware/commit/bd8a876482bb9d3f4df41fa4b4fe3c6cfdd4f846 | 18:41 |
mriedem | dims: want me to push the openstack/releases change? | 18:41 |
dims | mriedem: ++ | 18:41 |
krotscheck | I've got a question about the config generator, anyone around who knows how that works? | 18:42 |
* dims waves | 18:42 | |
krotscheck | Hi dims! | 18:42 |
* harlowja waves | 18:43 | |
dims | krotscheck: what's the question about oslo-config-generator? | 18:43 |
harlowja | what are waving at? | 18:43 |
krotscheck | Well, it's a question about configuratino options that are API specific. | 18:43 |
dims | waving at krotscheck :) | 18:43 |
harlowja | oh, ok | 18:43 |
harlowja | :) | 18:43 |
mriedem | dims: nevermind, i guess that's in 0.11.2, weird | 18:43 |
krotscheck | For example, ironic makes use of the X-Openstack-Ironic-API-Version header, which needs to be included in the CORS header configuration. | 18:44 |
dims | mriedem: ack | 18:44 |
krotscheck | So, if the sample configuration generated for ironic doesn't include that, things will break. | 18:44 |
krotscheck | So I'm curious, how could I tell the config generator that "Yes, we have this config thing, and here are the API specific defaults?" | 18:45 |
krotscheck | (As opposed to the defaults provided in oslo_middleware) | 18:46 |
krotscheck | If the answer is "They can't be generated in the autogenerated file", that's ok, we just need to document that. | 18:46 |
*** openstackgerrit has quit IRC | 18:46 | |
*** openstackgerrit has joined #openstack-oslo | 18:46 | |
dims | krotscheck: i don't believe we have a way to do that | 18:49 |
dims | so yes, +1 to document for now | 18:49 |
krotscheck | Alrightey! | 18:49 |
harlowja | sounds like the oslo_middleware config needs to be made 'aware' of the CORS config? and then dynamically change itself/include more config? | 18:49 |
krotscheck | Is this a thing that someone should make it do? | 18:49 |
krotscheck | harlowja: Well, I'm thinking that config generator add on hooks would be useful. | 18:49 |
harlowja | krotscheck ya, a hook mechanism would i think be needed, some type of hook | 18:50 |
krotscheck | I'm a fan of fishing hooks. | 18:50 |
krotscheck | Or boarding hooks. | 18:50 |
harlowja | although another idea is | 18:50 |
harlowja | when generating config u'd ask for oslo_middleware[cors] config | 18:50 |
harlowja | instead of the 'basic' oslo_middleware config | 18:51 |
harlowja | or 'oslo_middleware[cors+ironic]' config? | 18:51 |
harlowja | basically this is additional stuff that is somewhat dynamic? | 18:51 |
* harlowja not really sure (just brainstorming) | 18:51 | |
krotscheck | Well, it's part of the question of dynamically configured things like this. | 18:52 |
krotscheck | I mean, there's a possible use case where someone might want to NOT include those headers. | 18:52 |
krotscheck | But, really, the'll always be there. | 18:52 |
harlowja | ya, i just start to wonder if there is a simpler way here, because tying these together starts to make a nice spaghetti dependency-graph | 18:53 |
krotscheck | Well, the more I think about it, the more I feel that teaching the middleware to add a default set of headers used by the API makes sense. | 18:54 |
krotscheck | That way you don't even have to include it in the configuration. | 18:54 |
krotscheck | It'll be baked into the app. | 18:54 |
harlowja | ya, the consumer of the oslo_middleware could provide to some sort of constructor __init__(your_default_headers) | 18:54 |
harlowja | and there u go, default headers, ha | 18:55 |
krotscheck | Mind you, I still think microversions are... a cheap excuse. | 18:55 |
krotscheck | Because really they're just pushing the burden of backwards compatibility to the consumer. | 18:55 |
harlowja | or __init__(your_default_headers_callback) | 18:55 |
harlowja | ^ all dynamic and stuff | 18:55 |
harlowja | then *your_default_headers_callback* can see if cors is loaded or something | 18:55 |
harlowja | and return special things | 18:55 |
harlowja | then ironic can use whatever config setting it wants, and that callback just needs to extract it and return it as needed | 18:56 |
harlowja | so maybe that will work to, idk | 18:57 |
krotscheck | harlowja: Yeah, maybe. | 18:59 |
krotscheck | I'm just annoyed that my crystal ball wasn't working when I first built this thing, and now I have legacy API to maintain. | 18:59 |
harlowja | krotscheck let me activate my time machine | 19:00 |
harlowja | i'm from the 24th century, so let me fix that for u | 19:00 |
harlowja | hmmm, time machine not working :( | 19:00 |
harlowja | damn, i'm screwed, lol | 19:00 |
krotscheck | Looks like Squa Tront managed to create another instability. | 19:01 |
harlowja | ya, i'll work on the time machine later, ha, i'll fix the glitch in that legacy API for u, ha | 19:03 |
harlowja | although i have to avoid stepping on butterflies | 19:03 |
harlowja | ha | 19:03 |
krotscheck | Oh, one more question for dims: Looks like the sample config generator isn't picking up the config options from middleware at all. | 19:03 |
*** pblaho has quit IRC | 19:05 | |
dims | krotscheck: is the middlware entrypoints mentioned in the configuration file for the oslo-config-generator? (see example in doc - http://docs.openstack.org/developer/oslo.config/generator.html) | 19:09 |
*** ozamiatin has joined #openstack-oslo | 19:10 | |
*** pblaho has joined #openstack-oslo | 19:10 | |
*** cdent has quit IRC | 19:13 | |
*** achanda has quit IRC | 19:16 | |
krotscheck | dims: I don't actually know, let me see. | 19:22 |
*** ozamiatin has quit IRC | 19:23 | |
*** elarson has quit IRC | 19:24 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 19:24 | |
krotscheck | Looks like it works. | 19:24 |
*** sigmavirus24_awa is now known as sigmavirus24 | 19:24 | |
krotscheck | I'll forward that comment. | 19:24 |
*** ozamiatin has joined #openstack-oslo | 19:28 | |
*** svilgelm has joined #openstack-oslo | 19:31 | |
openstackgerrit | Joshua Harlow proposed openstack/oslo.policy: Ensure checking/setting the 'reducers' attribute is atomic https://review.openstack.org/209644 | 19:31 |
*** e0ne has quit IRC | 19:38 | |
*** ozamiatin has quit IRC | 19:44 | |
*** ozamiatin has joined #openstack-oslo | 19:47 | |
svilgelm | harjowja: Hi, dims has sent me to you. I can submit a patch today to the taskflow for using oslo.log instead of system logging and also i'll replace BLATHER with TRACE | 19:52 |
harlowja | svilgelm hmmm, using oslo.log pulls in all the rest of oslo | 19:53 |
harlowja | i'd rather just stick to the generic default python logging, and say, change blather -> trace to match oslo.log | 19:53 |
* harlowja still has ideals and grand visions of keeping taskflow not so tightly coupled to openstack | 19:54 | |
harlowja | since there is nothing conceptually tying it so tightly together (oslo.log already affects things like sqlalchemy) | 19:54 |
harlowja | and sqlalchemy isn't part of openstack ... | 19:54 |
harlowja | svilgelm the other option is to just switch taskflow back to using DEBUG only | 19:55 |
harlowja | since afaik sputnik13 created a patch to slience the amount of 'noise' taskflow creates when used (imho valueable noise useful for seeing whats happening) | 19:55 |
svilgelm | harlowja: Ok :) | 19:55 |
harlowja | sputnik13 what choice do u think :-P | 19:56 |
svilgelm | harlowja: i see and will skip the taskflow in my list of changes | 19:56 |
harlowja | https://github.com/openstack/oslo.log/blob/master/oslo_log/_options.py#L90 (other 3rd-party, non-openstack libraries that have there logging configuration tweaked) | 19:56 |
svilgelm | harlowja: thanks :) | 19:58 |
*** thumpba has quit IRC | 19:58 | |
harlowja | svilgelm sure, let me discuss more with taskflow folks, maybe can just remove BLATHER/TRACE now anyways | 19:59 |
svilgelm | harlowja: sure | 19:59 |
harlowja | thx :) | 19:59 |
openstackgerrit | Joshua Harlow proposed openstack/oslo.policy: Have the enforcer have its own file cache https://review.openstack.org/209656 | 20:04 |
*** ozamiatin has quit IRC | 20:04 | |
openstackgerrit | Joshua Harlow proposed openstack/oslo.policy: Have the enforcer have its own file cache https://review.openstack.org/209656 | 20:05 |
*** boris-42 has joined #openstack-oslo | 20:12 | |
*** sc68cal_ is now known as sc68cal | 20:13 | |
*** bapalm has joined #openstack-oslo | 20:16 | |
*** dimtruck is now known as zz_dimtruck | 20:17 | |
harlowja | jd__ morganfainberg https://review.openstack.org/#/c/209661/ some initial scribbling | 20:21 |
*** ozamiatin has joined #openstack-oslo | 20:23 | |
harlowja | flaper87 ^ | 20:25 |
harlowja | sputnik13 SpamapS ^ | 20:25 |
harlowja | and anyone else, ha | 20:25 |
harlowja | all u people | 20:25 |
SpamapS | harlowja: who you calling YOU eh? | 20:25 |
harlowja | lol | 20:26 |
harlowja | all the peoples of the world | 20:26 |
harlowja | join hands now | 20:26 |
dims | kumbaya! | 20:33 |
*** sigmavirus24 is now known as sigmavirus24_awa | 20:36 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 20:36 | |
*** stevemar has quit IRC | 20:46 | |
*** svilgelm has quit IRC | 20:50 | |
*** gordc has quit IRC | 20:59 | |
*** zz_dimtruck is now known as dimtruck | 20:59 | |
-openstackstatus- NOTICE: Zuul has been restarted to resolve a reconfiguration failure: previously running jobs have been reenqueued but change events between 19:50-20:54 UTC have been lost and will need to be rechecked or their approvals reapplied to trigger testing. | 21:05 | |
*** bapalm has quit IRC | 21:06 | |
harlowja | dims :) | 21:10 |
-openstackstatus- NOTICE: Correction: change events between 20:50-20:54 UTC (during the restart only) have been lost and will need to be rechecked or their approvals reapplied to trigger testing. | 21:10 | |
dims | harlowja: thought you may be able to untangle that one :) | 21:10 |
harlowja | def | 21:11 |
harlowja | ha | 21:11 |
dims | not sure if what i am doing is right | 21:11 |
* harlowja is currently getting the fire ready so we can roast marshmallows together | 21:11 | |
harlowja | :-P | 21:11 |
dims | harlowja: so i am back again end of the month to visit mountain view. early heads up :) | 21:12 |
harlowja | cool | 21:12 |
harlowja | boris-42 now has a car so we can go places, ha | 21:12 |
harlowja | and he'll drive us, right boris-42 :-P | 21:12 |
dims | :) | 21:12 |
harlowja | thx boris-42 ! | 21:12 |
harlowja | lol | 21:13 |
boris-42 | harlowja: yep yep | 21:13 |
harlowja | woot :-P | 21:13 |
*** exploreshaifali has quit IRC | 21:15 | |
harlowja | boris-42 we can go somewhere else this time, ha | 21:17 |
*** exploreshaifali has joined #openstack-oslo | 21:20 | |
*** ozamiatin has quit IRC | 21:23 | |
boris-42 | harlowja: yeeep | 21:27 |
harlowja | sweet | 21:28 |
*** exploreshaifali has quit IRC | 21:36 | |
*** kgiusti has left #openstack-oslo | 21:38 | |
*** fnordahl has quit IRC | 21:39 | |
*** fnordahl has joined #openstack-oslo | 21:39 | |
*** mriedem is now known as mriedem_away | 21:47 | |
*** prad has quit IRC | 21:48 | |
openstackgerrit | Merged openstack/oslo.versionedobjects: Add obj_tree_get_versions() utility method https://review.openstack.org/203746 | 22:08 |
*** sigmavirus24 is now known as sigmavirus24_awa | 22:27 | |
*** achanda has joined #openstack-oslo | 22:28 | |
openstackgerrit | Merged openstack/oslo.versionedobjects: Implement multi-version object backport method https://review.openstack.org/203773 | 22:30 |
openstackgerrit | Merged openstack/oslo.versionedobjects: Support using the version manifest for obj_make_compatible() https://review.openstack.org/206657 | 22:30 |
*** bknudson has quit IRC | 22:33 | |
*** prad has joined #openstack-oslo | 22:38 | |
*** dimtruck is now known as zz_dimtruck | 22:42 | |
*** fnordahl has quit IRC | 22:52 | |
*** fnordahl has joined #openstack-oslo | 23:01 | |
*** achanda has quit IRC | 23:04 | |
openstackgerrit | Michael Krotscheck proposed openstack/oslo.middleware: Added latent properties to CORS middleware. https://review.openstack.org/209697 | 23:06 |
*** jecarey has quit IRC | 23:34 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Enable conversion of the tree nodes into a digraph https://review.openstack.org/209214 | 23:40 |
*** zzzeek has quit IRC | 23:48 | |
*** sdake has quit IRC | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!