| *** ozamiatin has quit IRC | 00:01 | |
| *** achanda has quit IRC | 00:15 | |
| *** sputnik13 has quit IRC | 00:19 | |
| *** xek_ has joined #openstack-oslo | 00:19 | |
| *** xek has quit IRC | 00:20 | |
| *** isq_ has joined #openstack-oslo | 00:20 | |
| *** isq has quit IRC | 00:20 | |
| *** david-lyle has quit IRC | 00:24 | |
| *** ujjain has quit IRC | 00:24 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Allow customized provider reordering https://review.openstack.org/206769 | 00:25 |
|---|---|---|
| harlowja | tdurakov ^ should provide most of what u want to tweak the ordering (and leave the default as is) | 00:26 |
| *** ujjain has joined #openstack-oslo | 00:26 | |
| *** ujjain has quit IRC | 00:26 | |
| *** ujjain has joined #openstack-oslo | 00:26 | |
| harlowja | pretty simple :-P | 00:26 |
| harlowja | tdurakov it needs a few more tweaks, but thats the majority of it | 00:28 |
| harlowja | and tests i guess | 00:28 |
| *** tsekiyam_ has joined #openstack-oslo | 00:32 | |
| *** mtanino has quit IRC | 00:34 | |
| *** tsekiyama has quit IRC | 00:35 | |
| *** tsekiyam_ has quit IRC | 00:36 | |
| openstackgerrit | Joshua Harlow proposed openstack/debtcollector: Expose a top level 'deprecate' function https://review.openstack.org/206262 | 00:37 |
| openstackgerrit | Joshua Harlow proposed openstack/debtcollector: Expose a top level 'deprecate' function https://review.openstack.org/206262 | 00:38 |
| openstackgerrit | Joshua Harlow proposed openstack/debtcollector: Expose a top level 'deprecate' function https://review.openstack.org/206262 | 00:42 |
| *** xek_ has quit IRC | 00:46 | |
| *** xek_ has joined #openstack-oslo | 00:47 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 00:48 | |
| *** bknudson has joined #openstack-oslo | 00:54 | |
| *** haypo has left #openstack-oslo | 00:57 | |
| *** ashleighfarnham has quit IRC | 01:04 | |
| openstackgerrit | Merged openstack/taskflow: Bump futurist and remove waiting code in taskflow https://review.openstack.org/201728 | 01:07 |
| *** browne has quit IRC | 01:08 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Allow customized provider reordering https://review.openstack.org/206769 | 01:15 |
| *** dimtruck is now known as zz_dimtruck | 01:16 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Allow customized provider reordering https://review.openstack.org/206769 | 01:18 |
| *** salv-orlando has joined #openstack-oslo | 01:20 | |
| *** salv-orlando has quit IRC | 01:25 | |
| *** mriedem has quit IRC | 01:26 | |
| *** david-lyle has joined #openstack-oslo | 02:19 | |
| *** david-lyle has quit IRC | 02:23 | |
| *** achanda has joined #openstack-oslo | 02:37 | |
| *** boris-42 has quit IRC | 02:40 | |
| *** browne has joined #openstack-oslo | 02:40 | |
| *** yamahata has joined #openstack-oslo | 03:21 | |
| openstackgerrit | Merged openstack/oslo.cache: Remove NoOp cache from oslo.cache https://review.openstack.org/206113 | 03:22 |
| *** david-lyle has joined #openstack-oslo | 03:34 | |
| openstackgerrit | Zhu Zhu proposed openstack/oslo.vmware: Allow http connection pool size to be configured https://review.openstack.org/206804 | 03:39 |
| openstackgerrit | Merged openstack/taskflow: .gitignore update https://review.openstack.org/206697 | 03:45 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/automaton: Updated from global requirements https://review.openstack.org/206806 | 03:45 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/debtcollector: Updated from global requirements https://review.openstack.org/206808 | 03:45 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/futurist: Updated from global requirements https://review.openstack.org/206811 | 03:45 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo-incubator: Updated from global requirements https://review.openstack.org/206830 | 03:49 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.cache: Updated from global requirements https://review.openstack.org/206831 | 03:49 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.concurrency: Updated from global requirements https://review.openstack.org/206832 | 03:49 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.config: Updated from global requirements https://review.openstack.org/206833 | 03:49 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.context: Updated from global requirements https://review.openstack.org/206834 | 03:49 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.db: Updated from global requirements https://review.openstack.org/206835 | 03:49 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.i18n: Updated from global requirements https://review.openstack.org/206836 | 03:49 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.log: Updated from global requirements https://review.openstack.org/206837 | 03:49 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.messaging: Updated from global requirements https://review.openstack.org/206838 | 03:50 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.middleware: Updated from global requirements https://review.openstack.org/206839 | 03:50 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.policy: Updated from global requirements https://review.openstack.org/206840 | 03:50 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.reports: Updated from global requirements https://review.openstack.org/206841 | 03:50 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.rootwrap: Updated from global requirements https://review.openstack.org/206842 | 03:50 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.serialization: Updated from global requirements https://review.openstack.org/206843 | 03:50 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.service: Updated from global requirements https://review.openstack.org/206844 | 03:50 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.utils: Updated from global requirements https://review.openstack.org/206845 | 03:50 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.versionedobjects: Updated from global requirements https://review.openstack.org/206846 | 03:50 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/stevedore: Updated from global requirements https://review.openstack.org/206855 | 03:51 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/taskflow: Updated from global requirements https://review.openstack.org/206856 | 03:51 |
| *** achanda has quit IRC | 03:55 | |
| *** amotoki has joined #openstack-oslo | 03:56 | |
| lifeless | go bot go | 04:03 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 04:14 | |
| *** harlowja_at_home has joined #openstack-oslo | 04:17 | |
| openstackgerrit | Merged openstack/oslo-incubator: Updated from global requirements https://review.openstack.org/206830 | 04:38 |
| *** stevemar has joined #openstack-oslo | 04:56 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Allow customized provider reordering https://review.openstack.org/206769 | 04:56 |
| openstackgerrit | Merged openstack/oslo.policy: Updated from global requirements https://review.openstack.org/206840 | 04:59 |
| *** harlowja_still_a has joined #openstack-oslo | 05:02 | |
| *** harlowja_at_home has quit IRC | 05:05 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Remove extra runner layer and just use use machine in engine https://review.openstack.org/202838 | 05:07 |
| openstackgerrit | Merged openstack/oslo.reports: Updated from global requirements https://review.openstack.org/206841 | 05:10 |
| openstackgerrit | Merged openstack/oslo.middleware: Updated from global requirements https://review.openstack.org/206839 | 05:10 |
| openstackgerrit | Merged openstack/oslo.log: Updated from global requirements https://review.openstack.org/206837 | 05:11 |
| openstackgerrit | Merged openstack/oslo.i18n: Updated from global requirements https://review.openstack.org/206836 | 05:11 |
| *** rpodolyaka1 has joined #openstack-oslo | 05:12 | |
| openstackgerrit | Merged openstack/oslo.versionedobjects: Updated from global requirements https://review.openstack.org/206846 | 05:13 |
| openstackgerrit | Merged openstack/oslo.serialization: Updated from global requirements https://review.openstack.org/206843 | 05:13 |
| openstackgerrit | Merged openstack/oslo.utils: Updated from global requirements https://review.openstack.org/206845 | 05:13 |
| openstackgerrit | Merged openstack/oslo.rootwrap: Updated from global requirements https://review.openstack.org/206842 | 05:14 |
| openstackgerrit | Merged openstack/taskflow: Updated from global requirements https://review.openstack.org/206856 | 05:15 |
| *** sputnik13 has joined #openstack-oslo | 05:15 | |
| openstackgerrit | Merged openstack/oslo.db: Updated from global requirements https://review.openstack.org/206835 | 05:15 |
| *** harlowja_still_a has quit IRC | 05:16 | |
| *** harlowja_at_home has joined #openstack-oslo | 05:16 | |
| openstackgerrit | Zhu Zhu proposed openstack/oslo.vmware: Allow http connection pool size to be configured https://review.openstack.org/206804 | 05:17 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Allow customized scope lookup reordering (WIP) https://review.openstack.org/206769 | 05:19 |
| *** stevemar has quit IRC | 05:19 | |
| openstackgerrit | Merged openstack/futurist: Updated from global requirements https://review.openstack.org/206811 | 05:19 |
| *** stevemar has joined #openstack-oslo | 05:20 | |
| openstackgerrit | Merged openstack/oslo.service: Updated from global requirements https://review.openstack.org/206844 | 05:20 |
| *** LimorStotland has joined #openstack-oslo | 05:22 | |
| openstackgerrit | Merged openstack/oslo.config: Updated from global requirements https://review.openstack.org/206833 | 05:24 |
| openstackgerrit | Merged openstack/debtcollector: Updated from global requirements https://review.openstack.org/206808 | 05:24 |
| *** stevemar has quit IRC | 05:24 | |
| openstackgerrit | Merged openstack/stevedore: Updated from global requirements https://review.openstack.org/206855 | 05:26 |
| *** achanda has joined #openstack-oslo | 05:26 | |
| toabctl | oslo.concurrency has "posix-ipc" in its' requirements.txt . shouldn't that be "posix_ipc" ? (with underscore) | 05:27 |
| *** harlowja_still_a has joined #openstack-oslo | 05:29 | |
| toabctl | seem this change did the wrong thing: https://review.openstack.org/#/c/201182/ | 05:31 |
| *** harlowja_at_home has quit IRC | 05:32 | |
| *** harlowja_still_a has quit IRC | 05:38 | |
| *** sputnik13 has quit IRC | 05:40 | |
| openstackgerrit | Merged openstack/automaton: Updated from global requirements https://review.openstack.org/206806 | 05:52 |
| openstackgerrit | Merged openstack/oslo.cache: Updated from global requirements https://review.openstack.org/206831 | 05:52 |
| openstackgerrit | Merged openstack/oslo.concurrency: Updated from global requirements https://review.openstack.org/206832 | 05:52 |
| openstackgerrit | Merged openstack/oslo.context: Updated from global requirements https://review.openstack.org/206834 | 05:52 |
| *** rpodolyaka1 has quit IRC | 06:02 | |
| *** nkrinner has joined #openstack-oslo | 06:18 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.middleware: Imported Translations from Transifex https://review.openstack.org/206879 | 06:20 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.i18n: Imported Translations from Transifex https://review.openstack.org/206882 | 06:23 |
| *** jamespage_ has joined #openstack-oslo | 06:30 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.log: Imported Translations from Transifex https://review.openstack.org/206890 | 06:31 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.versionedobjects: Imported Translations from Transifex https://review.openstack.org/206894 | 06:34 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.vmware: Imported Translations from Transifex https://review.openstack.org/206896 | 06:34 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.concurrency: Imported Translations from Transifex https://review.openstack.org/206898 | 06:35 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.messaging: Imported Translations from Transifex https://review.openstack.org/206902 | 06:39 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.db: Imported Translations from Transifex https://review.openstack.org/206904 | 06:40 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.utils: Imported Translations from Transifex https://review.openstack.org/206906 | 06:41 |
| *** browne has quit IRC | 06:49 | |
| *** jamespage_ has quit IRC | 06:51 | |
| *** jamespage_ has joined #openstack-oslo | 06:51 | |
| *** achanda has quit IRC | 06:54 | |
| openstackgerrit | Zhu Zhu proposed openstack/oslo.vmware: Allow http connection pool size to be configured https://review.openstack.org/206804 | 06:54 |
| *** jamespage_ has quit IRC | 06:56 | |
| *** jamespage_ has joined #openstack-oslo | 06:57 | |
| *** achanda has joined #openstack-oslo | 06:57 | |
| *** rpodolyaka1 has joined #openstack-oslo | 06:59 | |
| *** rpodolyaka1 has quit IRC | 07:00 | |
| *** rpodolyaka1 has joined #openstack-oslo | 07:02 | |
| *** yamahata has quit IRC | 07:05 | |
| *** otherwiseguy has quit IRC | 07:05 | |
| *** otherwiseguy has joined #openstack-oslo | 07:10 | |
| *** salv-orlando has joined #openstack-oslo | 07:12 | |
| openstackgerrit | Zhu Zhu proposed openstack/oslo.vmware: Allow http connection pool size to be configured https://review.openstack.org/206804 | 07:15 |
| *** jamespage_ has quit IRC | 07:18 | |
| *** jamespage_ has joined #openstack-oslo | 07:18 | |
| *** jamespage_ has quit IRC | 07:24 | |
| *** ozamiatin has joined #openstack-oslo | 07:24 | |
| *** jamespage_ has joined #openstack-oslo | 07:24 | |
| *** achanda has quit IRC | 07:27 | |
| *** ihrachyshka has joined #openstack-oslo | 07:38 | |
| *** ozamiatin has quit IRC | 07:47 | |
| *** jamespage_ has quit IRC | 07:50 | |
| *** jamespage_ has joined #openstack-oslo | 07:51 | |
| *** rpodolyaka1 has quit IRC | 08:01 | |
| *** jamespage_ has quit IRC | 08:04 | |
| *** jamespage_ has joined #openstack-oslo | 08:11 | |
| *** jamespage_ has quit IRC | 08:13 | |
| *** ndipanov has quit IRC | 08:14 | |
| *** ndipanov has joined #openstack-oslo | 08:14 | |
| *** dguitarbite has joined #openstack-oslo | 08:18 | |
| *** jamespage_ has joined #openstack-oslo | 08:18 | |
| *** jamespage_ has quit IRC | 08:28 | |
| openstackgerrit | Marian Horban proposed openstack/oslo.service: Added class SignalHandler https://review.openstack.org/204972 | 08:29 |
| *** jamespage_ has joined #openstack-oslo | 08:31 | |
| *** e0ne has joined #openstack-oslo | 08:40 | |
| *** rpodolyaka1 has joined #openstack-oslo | 08:41 | |
| *** exploreshaifali has joined #openstack-oslo | 08:42 | |
| *** jamespage_ has quit IRC | 08:43 | |
| *** e0ne has quit IRC | 08:43 | |
| *** yassine has joined #openstack-oslo | 08:43 | |
| *** ozamiatin has joined #openstack-oslo | 08:48 | |
| *** viktors has quit IRC | 08:50 | |
| *** haypo has joined #openstack-oslo | 08:54 | |
| *** ozamiatin has quit IRC | 09:01 | |
| *** ozamiatin has joined #openstack-oslo | 09:02 | |
| *** amotoki has quit IRC | 09:05 | |
| *** ihrachyshka has quit IRC | 09:15 | |
| *** alexpilotti has joined #openstack-oslo | 09:25 | |
| -openstackstatus- NOTICE: Currently our CI system is broken, jobs are not getting processed at all. | 09:29 | |
| *** ChanServ changes topic to "Currently our CI system is broken, jobs are not getting processed at all." | 09:29 | |
| *** rpodolyaka1 has quit IRC | 09:39 | |
| *** mdbooth has quit IRC | 09:46 | |
| *** mdbooth has joined #openstack-oslo | 09:47 | |
| *** rpodolyaka1 has joined #openstack-oslo | 09:47 | |
| *** ihrachyshka has joined #openstack-oslo | 09:53 | |
| *** ozamiatin has quit IRC | 09:55 | |
| *** e0ne has joined #openstack-oslo | 09:57 | |
| *** yassine has quit IRC | 09:59 | |
| *** ihrachyshka has quit IRC | 10:00 | |
| *** Kennan has quit IRC | 10:00 | |
| *** sc68cal has quit IRC | 10:00 | |
| *** ihrachyshka has joined #openstack-oslo | 10:01 | |
| *** Kennan has joined #openstack-oslo | 10:01 | |
| *** sc68cal has joined #openstack-oslo | 10:02 | |
| *** e0ne_ has joined #openstack-oslo | 10:02 | |
| *** e0ne has quit IRC | 10:05 | |
| *** LimorStotland has quit IRC | 10:05 | |
| *** LimorStotland has joined #openstack-oslo | 10:06 | |
| *** e0ne_ is now known as e0ne | 10:06 | |
| *** rpodolyaka1 has quit IRC | 10:13 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.messaging: Added additional logging https://review.openstack.org/194295 | 10:30 |
| dims | flaper87: done! ^^ | 10:31 |
| dims | flaper87: jd__: one of you bless this too? https://review.openstack.org/#/c/205779/ | 10:32 |
| *** rossella_s has quit IRC | 10:37 | |
| *** rossella_s has joined #openstack-oslo | 10:38 | |
| *** exploreshaifali_ has joined #openstack-oslo | 10:39 | |
| *** exploreshaifali has quit IRC | 10:43 | |
| *** cdent has joined #openstack-oslo | 10:55 | |
| *** ozamiatin has joined #openstack-oslo | 11:02 | |
| *** yassine has joined #openstack-oslo | 11:04 | |
| *** yassine has quit IRC | 11:04 | |
| *** yassine has joined #openstack-oslo | 11:04 | |
| *** dukhlov has joined #openstack-oslo | 11:24 | |
| *** e0ne has quit IRC | 11:25 | |
| *** rpodolyaka1 has joined #openstack-oslo | 11:27 | |
| openstackgerrit | fumihiko kakuma proposed openstack/oslo.db: Python 3: Use use_unicode=1 under Python 3 https://review.openstack.org/206997 | 11:30 |
| *** e0ne has joined #openstack-oslo | 11:35 | |
| *** svilgelm has joined #openstack-oslo | 11:43 | |
| *** svilgelm has quit IRC | 11:45 | |
| *** svilgelm has joined #openstack-oslo | 11:48 | |
| dims | dansmith: o.vo reviews are piling up | 11:48 |
| haypo | dims: ah yes, i found a bug yesterday :) i have to write a patch ;) | 11:52 |
| haypo | it's a bug in wrap_exception(), i have a patch, but i'm working on an unit test. oh, nova has the same function, but without the bug /o\ | 11:57 |
| *** e0ne has quit IRC | 11:59 | |
| *** exploreshaifali_ has quit IRC | 12:07 | |
| sdague | dims: is the six requirement in oslo.utils wrong? | 12:08 |
| sdague | File "/usr/local/lib/python2.7/dist-packages/oslo_utils/netutils.py", line 224, in <module> | 12:08 |
| sdague | class _ModifiedSplitResult(parse.SplitResult): | 12:08 |
| sdague | AttributeError: 'Module_six_moves_urllib_parse' object has no attribute 'SplitResult' | 12:08 |
| haypo | sdague: it looks like SplitResult was introduced in Python 3 | 12:09 |
| sdague | sure, but it's via six | 12:10 |
| sdague | my devstack just exploded because of this | 12:10 |
| *** svilgelm has quit IRC | 12:10 | |
| haypo | sdague: six doesn't implement new types, it just routes to the right module | 12:10 |
| sdague | ok, so that's just completely wrong then? | 12:11 |
| sdague | http://paste.openstack.org/show/406205/ | 12:11 |
| haypo | sdague: ah wait, it's available in the urlparse module on Python 2.7 | 12:11 |
| sdague | right, hence my first question | 12:12 |
| sdague | because if six is specified as too old to fine it | 12:12 |
| sdague | find it | 12:12 |
| haypo | sdague: it's available in my six version, as six.moves.urllib.parse.SplitResult | 12:12 |
| haypo | i have six 1.9 | 12:12 |
| dims | http://paste.openstack.org/show/406206/ | 12:12 |
| dims | sdague: i can see it too | 12:12 |
| haypo | sdague: six sucks in the changelog, it doesn't document when new symbols are added | 12:12 |
| dims | sdague: which version of six do you have? | 12:13 |
| sdague | 1.5.2 | 12:13 |
| haypo | oslo.utils requires six >= 1.9 | 12:13 |
| sdague | apparently | 12:13 |
| haypo | sdague: you don't respect oslo.utils requirements :) | 12:13 |
| sdague | dims: which oslo.utils requires that? | 12:13 |
| haypo | sdague: you have to search what installed six 1.5.2 | 12:15 |
| dims | https://github.com/kelp404/six/compare/1.5.2...1.6.0 | 12:15 |
| *** rpodolyaka1 has quit IRC | 12:15 | |
| dims | looks like it was added in 1.6.0 | 12:15 |
| haypo | dims: well, anyway oslo.utils requires six >= 1.9 | 12:15 |
| haypo | (at least, in the master branch) | 12:15 |
| sdague | haypo: right, which is a commit that landed 12 hrs ago | 12:16 |
| haypo | dims: oh, i didn't know that six has a changlog. good to know | 12:16 |
| dims | sdague: 1.7.0 of six was minimum way back from what i can tell - https://github.com/openstack/oslo.utils/commit/db5a0c6284f419e0a025476653e19b8fcc9bcd6c | 12:18 |
| sdague | hmmm... it seems like another regressions on requirements handling, no idea why it didn't get installed, oslo.utils is at a version that should have required it | 12:18 |
| dims | ack sdague | 12:18 |
| dims | we are definitely diligent about proposal bot updates | 12:19 |
| *** gordc has joined #openstack-oslo | 12:21 | |
| *** salv-orl_ has joined #openstack-oslo | 12:22 | |
| *** xek_ is now known as xek | 12:23 | |
| *** salv-orlando has quit IRC | 12:25 | |
| *** e0ne has joined #openstack-oslo | 12:25 | |
| *** salv-orlando has joined #openstack-oslo | 12:26 | |
| *** rpodolyaka1 has joined #openstack-oslo | 12:26 | |
| *** salv-orl_ has quit IRC | 12:26 | |
| *** salv-orl_ has joined #openstack-oslo | 12:27 | |
| *** salv-orlando has quit IRC | 12:30 | |
| *** salv-orlando has joined #openstack-oslo | 12:35 | |
| *** ganso_ has joined #openstack-oslo | 12:35 | |
| *** kgiusti has joined #openstack-oslo | 12:37 | |
| *** kgiusti has quit IRC | 12:37 | |
| *** salv-orl_ has quit IRC | 12:38 | |
| openstackgerrit | Marian Horban proposed openstack/oslo.service: Adding wsgi functionality https://review.openstack.org/204003 | 12:40 |
| *** salv-orl_ has joined #openstack-oslo | 12:44 | |
| *** salv-orlando has quit IRC | 12:47 | |
| *** salv-orl_ has quit IRC | 12:47 | |
| *** salv-orlando has joined #openstack-oslo | 12:48 | |
| *** kgiusti has joined #openstack-oslo | 12:50 | |
| *** ChanServ changes topic to "#openstack-oslo" | 12:50 | |
| -openstackstatus- NOTICE: zuul's disks were at capacity. Space has been freed up and jobs are being re-queued. | 12:51 | |
| *** ozamiatin has quit IRC | 12:51 | |
| haypo | sileht: hey. FYI ubuntu prepared a package python3.4 version 3.4.3 which fixes the crash in the Python garbage collector. Clark Boylan & me validated the new package, i hope that i will go quickly to Trusty main repository: https://bugs.launchpad.net/ubuntu/+source/python3.4/+bug/1367907 | 12:52 |
| openstack | Launchpad bug 1367907 in python3.4 (Ubuntu Trusty) "Segfault in gc with cyclic trash" [Undecided,Fix committed] | 12:52 |
| sileht | haypo, woot good news | 12:52 |
| haypo | sileht: it's the bug which causes Oslo Messaging to crash on the py34 gates | 12:52 |
| haypo | sileht: it was first discussed to backport only the GC fix, but it's better to upgrade to 3.4.3 instead | 12:52 |
| haypo | 3.4.3 contains many other bugfixes | 12:52 |
| *** LimorStotland has quit IRC | 12:53 | |
| dims | haypo: very cool | 12:54 |
| haypo | dims: it took some months, but we are close to have this old bug fixes in Ubuntu LTS! | 12:55 |
| haypo | fixed* | 12:55 |
| *** jaosorior has joined #openstack-oslo | 12:57 | |
| *** dims has quit IRC | 12:57 | |
| *** salv-orl_ has joined #openstack-oslo | 12:57 | |
| *** dims has joined #openstack-oslo | 12:57 | |
| *** mriedem has joined #openstack-oslo | 12:57 | |
| haypo | sdague: i'm running devstack on a ubuntu VM created 30 minutes ago. right now, i still have six 1.5.2, but ./stack.sh is still installing things | 12:59 |
| sdague | I'm getting issues with the nova cli | 12:59 |
| *** jamespage_ has joined #openstack-oslo | 13:00 | |
| *** pblaho has quit IRC | 13:00 | |
| *** gordc is now known as gordc_idle | 13:00 | |
| *** salv-orlando has quit IRC | 13:00 | |
| *** salv-or__ has joined #openstack-oslo | 13:00 | |
| *** bknudson has quit IRC | 13:01 | |
| *** pblaho has joined #openstack-oslo | 13:01 | |
| *** ozamiatin has joined #openstack-oslo | 13:03 | |
| *** salv-orl_ has quit IRC | 13:04 | |
| *** jamespage__ has joined #openstack-oslo | 13:04 | |
| *** jamespage_ has quit IRC | 13:05 | |
| dims | haypo: that does not sound good | 13:07 |
| dims | sdague: similar six issues? | 13:08 |
| sdague | yeh | 13:08 |
| *** sigmavirus24_awa is now known as sigmavirus24 | 13:08 | |
| *** salv-or__ has quit IRC | 13:09 | |
| *** pblaho has quit IRC | 13:10 | |
| *** salv-orlando has joined #openstack-oslo | 13:11 | |
| *** pblaho has joined #openstack-oslo | 13:11 | |
| *** pblaho has quit IRC | 13:12 | |
| haypo | dims, sdague : stack.sh is still running, but six is now six 1.9.0 (as expected) | 13:14 |
| *** salv-orl_ has joined #openstack-oslo | 13:14 | |
| *** pblaho has joined #openstack-oslo | 13:15 | |
| *** bknudson has joined #openstack-oslo | 13:16 | |
| *** pblaho has quit IRC | 13:17 | |
| *** salv-orlando has quit IRC | 13:17 | |
| *** pblaho has joined #openstack-oslo | 13:18 | |
| *** salv-orlando has joined #openstack-oslo | 13:18 | |
| sdague | ok, with six 1.9.0 I now get | 13:18 |
| sdague | File "/opt/stack/keystone/keystone/assignment/core.py", line 46, in deprecated_to_role_api | 13:18 |
| sdague | @six.wraps(f) | 13:18 |
| sdague | AttributeError: 'module' object has no attribute 'wraps' | 13:18 |
| *** pblaho has quit IRC | 13:19 | |
| *** pblaho has joined #openstack-oslo | 13:19 | |
| *** pblaho has quit IRC | 13:20 | |
| *** pblaho has joined #openstack-oslo | 13:20 | |
| haypo | sdague: liar! | 13:21 |
| *** salv-orl_ has quit IRC | 13:21 | |
| haypo | sdague: check where the six module does come from: import six; print(six.__path__) | 13:21 |
| haypo | sorry: import six; print(six.__file__) | 13:22 |
| *** pblaho has quit IRC | 13:22 | |
| haypo | sdague: six 1.9 has six.wraps() | 13:22 |
| sdague | oh, gdi | 13:22 |
| *** pblaho has joined #openstack-oslo | 13:22 | |
| sdague | pyc files | 13:22 |
| openstackgerrit | Victor Stinner proposed openstack/oslo.versionedobjects: Fix error handling in the exception module on py3 https://review.openstack.org/207038 | 13:24 |
| sdague | sigh | 13:24 |
| sdague | apt-get remove doesn't delete pyc files | 13:24 |
| sdague | so that's fun | 13:24 |
| haypo | sdague: maybe you upgrading the six module manually with pip? | 13:24 |
| haypo | upgraded* | 13:24 |
| sdague | yes, I did | 13:25 |
| haypo | dims: ^^ i'm proud of this patch, it adds new tests! :) | 13:25 |
| haypo | dims: so you told me that you have pending py3 patches for nova? | 13:25 |
| sdague | but, you know, it's useful that all the python tools to tell you version numbers of things, skip the pyc files | 13:26 |
| dims | sdague: ouch! | 13:26 |
| dims | haypo: https://review.openstack.org/#/c/204723/ is the next in line | 13:26 |
| -openstackstatus- NOTICE: zuul jobs after about 07:00 UTC may need a 'recheck' to enter the queue. Look if your change is in http://status.openstack.org/zuul/ and recheck if not. | 13:27 | |
| haypo | dims: you don't like writing short patches? :) | 13:27 |
| dims | haypo: haha | 13:27 |
| dims | haypo: once this lands, it would make it harder to check in py34 incompatible syntax and imports at least which will make it easier to turn on more test cases | 13:29 |
| haypo | dims: i _can_ review such patch, but are you sure that you get support from two cores to get such large pach merged? | 13:30 |
| haypo | dims: did you see that the nova python3 blueprint is somewhat deferred to the next cycle? | 13:30 |
| dims | haypo: i try to do the best and hope for the best :) | 13:31 |
| dims | haypo: i know. we will hopefully have some support to do this in trickles to avoid a big bang python34 work in the future | 13:32 |
| *** jamespage__ has quit IRC | 13:32 | |
| *** jecarey has joined #openstack-oslo | 13:32 | |
| haypo | dims: with your patch, can we run tests with testr instead of testtools.run for py34? | 13:32 |
| *** jamespage__ has joined #openstack-oslo | 13:32 | |
| haypo | i chose to run tests using testtools.run to support incremental changes in nova | 13:32 |
| haypo | (to not have to write a giant "hello, this is python3" patch -- this you did ;-)) | 13:33 |
| haypo | (to not have to write a giant "hello, this is python3" patch -- like you did ;-)) | 13:33 |
| dims | haypo: big bang would be, "this patch runs all tests" | 13:34 |
| *** stevemar has joined #openstack-oslo | 13:34 | |
| haypo | dims: load yes (run, no) | 13:34 |
| dansmith | dims: a couple of them are on hold at the moment, but yes | 13:35 |
| dims | haypo: right, this is like a hacking rule to avoid non-python3 syntax :) | 13:35 |
| haypo | dims: sure, i get the idea | 13:35 |
| dims | haypo: i am perfectly ok if you want to pass over reviewing that patch :) | 13:35 |
| haypo | dims: no no, as i wrote, i _can_ review this patch. i'm just depressed to see that my nova patches are not reviewed | 13:36 |
| *** jamespage__ has quit IRC | 13:36 | |
| *** jamespage__ has joined #openstack-oslo | 13:36 | |
| openstackgerrit | Merged openstack/oslo.messaging: Updated from global requirements https://review.openstack.org/206838 | 13:37 |
| dims | haypo: i hear you. need to be patient :) | 13:37 |
| haypo | dims: oh, in the meanwhile i switched to other projects which are faster to review my patches | 13:38 |
| dims | dansmith: ack | 13:38 |
| dims | haypo: understandable, but please do keep at it with Nova :) | 13:39 |
| *** rpodolyaka1 has quit IRC | 13:39 | |
| *** rpodolyaka1 has joined #openstack-oslo | 13:42 | |
| *** jamespage__ has quit IRC | 13:42 | |
| *** pblaho has quit IRC | 13:45 | |
| *** pblaho has joined #openstack-oslo | 13:45 | |
| *** pblaho has quit IRC | 13:47 | |
| *** pblaho has joined #openstack-oslo | 13:47 | |
| haypo | dims: ok, you get my first review. https://review.openstack.org/#/c/204723/ | 13:48 |
| haypo | dims: +1 for me ;) | 13:48 |
| dims | thank you sir! | 13:48 |
| haypo | dims: oh, you got a +2a from danbp on your py3 patch for nova scheduler, cool | 13:48 |
| haypo | dims: py3 is not dead | 13:48 |
| dims | haypo: the xenserver stuff, the CI for xen has a really old python/six so will fail unless we do it this way | 13:49 |
| *** pblaho has quit IRC | 13:49 | |
| dims | haypo: y. that was good! | 13:49 |
| *** pblaho has joined #openstack-oslo | 13:49 | |
| *** pblaho has quit IRC | 13:51 | |
| *** salv-orlando has quit IRC | 13:52 | |
| *** katyafervent is now known as katyafervent_awa | 13:55 | |
| *** yamahata has joined #openstack-oslo | 13:57 | |
| *** katyafervent_awa is now known as katyafervent | 13:58 | |
| *** rpodolyaka1 has quit IRC | 14:00 | |
| *** rpodolyaka1 has joined #openstack-oslo | 14:02 | |
| *** jd__ has quit IRC | 14:04 | |
| *** EmilienM has quit IRC | 14:05 | |
| *** haypo has quit IRC | 14:06 | |
| *** haypo has joined #openstack-oslo | 14:06 | |
| *** haypo has quit IRC | 14:06 | |
| *** haypo has joined #openstack-oslo | 14:06 | |
| *** EmilienM has joined #openstack-oslo | 14:09 | |
| *** jd__ has joined #openstack-oslo | 14:10 | |
| *** browne has joined #openstack-oslo | 14:12 | |
| *** zz_dimtruck is now known as dimtruck | 14:24 | |
| *** mtanino has joined #openstack-oslo | 14:25 | |
| dansmith | ativelkov: agreed that the fix to nova's enum sounds like the right way | 14:32 |
| dansmith | ativelkov: do you want to propose that or should I? | 14:32 |
| dansmith | ativelkov: in fact, the right thing might just be to make nova use enum from o.vo, which I think we can do now (but couldn't until recently) | 14:33 |
| dansmith | ativelkov: so I can work on that change if you want | 14:33 |
| ativelkov | dansmith: thanks, that will help a lot | 14:33 |
| ativelkov | dansmith: btw, I think that nova does indeed use enums from o.vo | 14:36 |
| *** rossella_s has quit IRC | 14:37 | |
| ativelkov | dansmith: see here: https://github.com/openstack/nova/blob/master/nova/objects/fields.py#L48 | 14:37 |
| *** rossella_s has joined #openstack-oslo | 14:38 | |
| dansmith | ativelkov: oh, heh, yeah that was my patch I wrote a while ago and it just recently merged :D | 14:38 |
| dansmith | ativelkov: so.. hmm, I guess I don't understand the problem then | 14:38 |
| dansmith | oh | 14:39 |
| dansmith | I see | 14:40 |
| dansmith | ativelkov: so I think I can make a change to nova's unit test that will coerce everything to unicode for the purposes of the hash verification | 14:41 |
| dansmith | ativelkov: and then your change will have no effect | 14:41 |
| *** yamahata has quit IRC | 14:41 | |
| *** LimorStotland has joined #openstack-oslo | 14:49 | |
| ativelkov | dansmith: yup, that will help | 14:55 |
| dansmith | ativelkov: and this will not affect existing code, right? | 14:57 |
| dansmith | ativelkov: if the enum has a valid_values with unicode values, using the existing non-unicode strings will still work? | 14:57 |
| ativelkov | dansmith: as far as I know, it should work fine | 14:57 |
| *** tsekiyama has joined #openstack-oslo | 14:59 | |
| dansmith | okay, maybe you can include a test to make sure? | 14:59 |
| dansmith | the py27 case is where I'm concerned of course | 14:59 |
| *** e0ne has quit IRC | 15:02 | |
| *** e0ne has joined #openstack-oslo | 15:04 | |
| *** nkrinner has quit IRC | 15:05 | |
| *** ozamiatin has quit IRC | 15:05 | |
| dansmith | ativelkov: https://review.openstack.org/207087 | 15:08 |
| *** svilgelm has joined #openstack-oslo | 15:14 | |
| *** gordc_idle has quit IRC | 15:16 | |
| ativelkov | dansmith: all the existing o.vo unittests on enums pass non-unicode strings to the fields which (in my patch) store their valid_values as unicode. And the tests pass. | 15:16 |
| dansmith | ativelkov: awesome, sounds like we're good then | 15:16 |
| ativelkov | dansmith: this happens because the FieldType first coerces the passed value (i.e. makes it unicode) and then runs the validations | 15:17 |
| ativelkov | I'll update my patch to include the Depends-On on yours | 15:17 |
| dansmith | ah, right | 15:18 |
| openstackgerrit | Alexander Tivelkov proposed openstack/oslo.versionedobjects: Adds value validation to the fields https://review.openstack.org/196041 | 15:22 |
| *** tsekiyama has quit IRC | 15:23 | |
| *** tsekiyama has joined #openstack-oslo | 15:25 | |
| *** sputnik13 has joined #openstack-oslo | 15:28 | |
| ativelkov | dansmith: I've fetched your nova patch and run its TestObjectVersions.test_versions unit test against my o.vo patch. It still fails on checksums, complaining that InstanceExternalEvent's hash has changed. This is expected, as it has enum fields, but you din't update its hash in you patch | 15:33 |
| *** alexpilotti has quit IRC | 15:34 | |
| dansmith | huh, I wonder why it didn't fail for me | 15:37 |
| *** gordc has joined #openstack-oslo | 15:39 | |
| ativelkov | strange | 15:39 |
| dansmith | I'm running --until-failure now | 15:40 |
| *** harlowja_at_home has joined #openstack-oslo | 15:44 | |
| *** rpodolyaka1 has quit IRC | 15:47 | |
| *** rpodolyaka1 has joined #openstack-oslo | 15:56 | |
| *** svilgelm has quit IRC | 16:02 | |
| dansmith | ativelkov: ah, instance external event doesn't define its own enum, it uses the base class in place | 16:08 |
| *** sdake has joined #openstack-oslo | 16:09 | |
| *** ihrachyshka has quit IRC | 16:09 | |
| dansmith | ativelkov: yeah, that was it.. fix coming | 16:11 |
| *** jaypipes has joined #openstack-oslo | 16:12 | |
| dansmith | ativelkov: pushed.. good catch :) | 16:12 |
| *** zhiyan has quit IRC | 16:13 | |
| *** ganso_ has quit IRC | 16:13 | |
| *** jraim has quit IRC | 16:13 | |
| ativelkov | dansmith: thanks, it just passed the version test :) Will run a complete tox -e py27 now | 16:14 |
| dansmith | cool | 16:14 |
| *** harlowja_at_home has quit IRC | 16:15 | |
| *** david-lyle has quit IRC | 16:18 | |
| *** ashleighfarnham has joined #openstack-oslo | 16:19 | |
| *** ozamiatin has joined #openstack-oslo | 16:25 | |
| *** jraim has joined #openstack-oslo | 16:26 | |
| *** browne has quit IRC | 16:27 | |
| *** yassine has quit IRC | 16:29 | |
| *** ihrachyshka has joined #openstack-oslo | 16:32 | |
| *** exploreshaifali has joined #openstack-oslo | 16:33 | |
| *** sdake has quit IRC | 16:37 | |
| *** svilgelm has joined #openstack-oslo | 16:39 | |
| *** haypo has left #openstack-oslo | 16:40 | |
| *** david-lyle has joined #openstack-oslo | 16:42 | |
| *** zhiyan has joined #openstack-oslo | 16:46 | |
| *** alexpilotti has joined #openstack-oslo | 16:47 | |
| *** ganso_ has joined #openstack-oslo | 16:48 | |
| *** svilgelm has quit IRC | 16:48 | |
| openstackgerrit | Tom Cocozzello proposed openstack/automaton: Activate pep8 check that _ is imported https://review.openstack.org/207124 | 16:49 |
| *** sdake has joined #openstack-oslo | 16:53 | |
| *** rjaiswal has joined #openstack-oslo | 16:55 | |
| ativelkov | dansmith: all the py27 test have passed | 16:58 |
| dansmith | ativelkov: rock on | 16:58 |
| ativelkov | Do you know why https://review.openstack.org/#/c/196041/ has got a -1 from jenkins? It says "change depends on a change that failed to merge", but your patch does not seem to be in a merge conflict or something | 17:00 |
| dansmith | because I pushed in the middle of your run | 17:00 |
| dansmith | recheck it | 17:00 |
| ativelkov | got it | 17:01 |
| openstackgerrit | Merged openstack/oslo.messaging: Imported Translations from Transifex https://review.openstack.org/206902 | 17:02 |
| *** e0ne has quit IRC | 17:03 | |
| ihrachyshka | dansmith, one thing I wondered. how does nova solve the problem of synthetic fields in objects not be in sync with main fields due to multiple transactions used to load those additional fields? | 17:04 |
| dansmith | ihrachyshka: meaning a half-filled object? | 17:07 |
| dansmith | ihrachyshka: in general, objects that come from row-based entities do column-based updates | 17:08 |
| ihrachyshka | dansmith, yeah, those fields that are filled in thru obj_set_attr or smth. | 17:08 |
| dansmith | objects that come from blobs don't ever come out of the db partially so we don't have to worry about blowing away the existing blob with a partial one | 17:08 |
| ihrachyshka | dansmith, so in neutron, we have a qos_policy object and it has rules field that is a list of qos_rule objects. We currently load it in autonested txn when we QosPolicy.get_by_id to make sure rules belong to policy and are consistent with at least some state of the object. | 17:09 |
| ihrachyshka | dansmith, http://git.openstack.org/cgit/openstack/neutron/tree/neutron/objects/qos/policy.py?h=feature/qos#n84 | 17:10 |
| *** svilgelm has joined #openstack-oslo | 17:10 | |
| *** salv-orlando has joined #openstack-oslo | 17:14 | |
| *** alexpilotti has quit IRC | 17:14 | |
| *** browne has joined #openstack-oslo | 17:19 | |
| *** salv-orlando has quit IRC | 17:20 | |
| rjaiswal | all: How does oslo.messaging handle timeouts | 17:22 |
| *** salv-orlando has joined #openstack-oslo | 17:22 | |
| *** alexpilotti has joined #openstack-oslo | 17:23 | |
| *** ihrachyshka has quit IRC | 17:25 | |
| *** achanda has joined #openstack-oslo | 17:27 | |
| *** rpodolyaka1 has quit IRC | 17:32 | |
| *** rpodolyaka1 has joined #openstack-oslo | 17:32 | |
| *** rpodolyaka1 has quit IRC | 17:33 | |
| *** ozamiatin has quit IRC | 17:37 | |
| *** ihrachyshka has joined #openstack-oslo | 17:39 | |
| *** jaypipes has quit IRC | 17:40 | |
| *** e0ne has joined #openstack-oslo | 17:56 | |
| *** browne has quit IRC | 18:02 | |
| *** browne has joined #openstack-oslo | 18:04 | |
| openstackgerrit | Merged openstack/oslo.concurrency: Imported Translations from Transifex https://review.openstack.org/206898 | 18:04 |
| *** prad has quit IRC | 18:04 | |
| openstackgerrit | Merged openstack/oslo.db: Imported Translations from Transifex https://review.openstack.org/206904 | 18:05 |
| *** e0ne has quit IRC | 18:06 | |
| *** adam_g has joined #openstack-oslo | 18:07 | |
| *** adam_g has quit IRC | 18:07 | |
| *** adam_g has joined #openstack-oslo | 18:07 | |
| *** e0ne has joined #openstack-oslo | 18:09 | |
| *** prad has joined #openstack-oslo | 18:19 | |
| *** dims_ has joined #openstack-oslo | 18:24 | |
| *** prad has quit IRC | 18:24 | |
| *** svilgelm has quit IRC | 18:27 | |
| *** prad has joined #openstack-oslo | 18:27 | |
| *** dims has quit IRC | 18:28 | |
| *** openstackgerrit has quit IRC | 18:31 | |
| *** openstackgerrit has joined #openstack-oslo | 18:32 | |
| *** svilgelm has joined #openstack-oslo | 18:34 | |
| *** jaypipes has joined #openstack-oslo | 18:34 | |
| *** salv-orlando has quit IRC | 18:40 | |
| *** sdake has quit IRC | 18:43 | |
| *** rpodolyaka1 has joined #openstack-oslo | 18:45 | |
| *** sdake has joined #openstack-oslo | 18:46 | |
| *** ashleighfarnham has left #openstack-oslo | 18:47 | |
| *** svilgelm has quit IRC | 18:52 | |
| *** svilgelm has joined #openstack-oslo | 18:57 | |
| *** svilgelm has quit IRC | 18:59 | |
| *** svilgelm has joined #openstack-oslo | 19:00 | |
| openstackgerrit | Thang Pham proposed openstack/oslo.versionedobjects: Fix ComparableVersionedObject in python 3.4 https://review.openstack.org/206679 | 19:01 |
| *** salv-orlando has joined #openstack-oslo | 19:01 | |
| *** sputnik13 has quit IRC | 19:03 | |
| openstackgerrit | Merged openstack/oslo.vmware: Imported Translations from Transifex https://review.openstack.org/206896 | 19:17 |
| openstackgerrit | Merged openstack/oslo.log: Imported Translations from Transifex https://review.openstack.org/206890 | 19:18 |
| openstackgerrit | Merged openstack/oslo.middleware: Imported Translations from Transifex https://review.openstack.org/206879 | 19:18 |
| openstackgerrit | Merged openstack/oslo.versionedobjects: Imported Translations from Transifex https://review.openstack.org/206894 | 19:22 |
| *** dims_ has quit IRC | 19:27 | |
| *** dims has joined #openstack-oslo | 19:27 | |
| openstackgerrit | Merged openstack/oslo.i18n: Imported Translations from Transifex https://review.openstack.org/206882 | 19:28 |
| *** salv-orlando has quit IRC | 19:35 | |
| *** achanda has quit IRC | 19:46 | |
| *** HenryG has quit IRC | 19:49 | |
| *** sputnik13 has joined #openstack-oslo | 19:50 | |
| *** e0ne has quit IRC | 19:51 | |
| *** salv-orlando has joined #openstack-oslo | 19:51 | |
| *** HenryG has joined #openstack-oslo | 19:52 | |
| *** e0ne has joined #openstack-oslo | 19:55 | |
| openstackgerrit | Thang Pham proposed openstack/oslo.versionedobjects: Make direct call to object's obj_from_primitive https://review.openstack.org/206637 | 19:57 |
| *** e0ne has quit IRC | 20:03 | |
| *** rjaiswal has quit IRC | 20:04 | |
| *** svilgelm has quit IRC | 20:06 | |
| *** e0ne has joined #openstack-oslo | 20:11 | |
| harlowja | tdurakov sputnik13 using https://review.openstack.org/#/c/206769/ the ordering alteration seems to work as expected, example @ http://paste.openstack.org/show/406311/ | 20:16 |
| *** openstackgerrit has quit IRC | 20:16 | |
| *** openstackgerrit has joined #openstack-oslo | 20:16 | |
| harlowja | output of that @ http://paste.openstack.org/show/406312/ | 20:17 |
| harlowja | showing the altered ordering working | 20:17 |
| *** achanda has joined #openstack-oslo | 20:25 | |
| *** achanda has quit IRC | 20:34 | |
| *** achanda has joined #openstack-oslo | 20:35 | |
| *** rpodolyaka1 has quit IRC | 20:36 | |
| *** salv-orlando has quit IRC | 20:36 | |
| *** stevemar has quit IRC | 20:37 | |
| *** ozamiatin has joined #openstack-oslo | 20:37 | |
| *** rpodolyaka1 has joined #openstack-oslo | 20:38 | |
| *** achanda has quit IRC | 20:41 | |
| *** kgiusti has left #openstack-oslo | 20:43 | |
| *** rpodolyaka1 has quit IRC | 20:45 | |
| *** salv-orlando has joined #openstack-oslo | 20:46 | |
| *** cdent has quit IRC | 20:50 | |
| openstackgerrit | Timofey Durakov proposed openstack/taskflow: [WIP]change for decider logic https://review.openstack.org/207212 | 20:50 |
| *** tdurakov_ has joined #openstack-oslo | 20:51 | |
| tdurakov_ | harlowja, hi! | 20:51 |
| tdurakov_ | https://review.openstack.org/#/c/207212/ - idea, we discussed yesterday | 20:52 |
| *** dimtruck is now known as zz_dimtruck | 20:58 | |
| *** rpodolyaka1 has joined #openstack-oslo | 20:59 | |
| harlowja | tdurakov_ cool | 21:08 |
| harlowja | tdurakov_ interesting, so that allows descions based on the node in question | 21:09 |
| tdurakov_ | harlowja: yep, and task names are unique | 21:10 |
| harlowja | interesting | 21:10 |
| * harlowja thinking | 21:10 | |
| tdurakov_ | harlowja, this is just PoC, so I could implement this in patch if it's ok) | 21:11 |
| *** ajo_ has joined #openstack-oslo | 21:11 | |
| harlowja | tdurakov_ what about just passing the local_decider(history=results, atom=node) ? | 21:11 |
| harlowja | then the decider function can determine stuff | 21:11 |
| harlowja | and then the code changes less | 21:12 |
| tdurakov_ | sounds good | 21:12 |
| *** ajo_ has quit IRC | 21:12 | |
| harlowja | that makes it so that 'if node.name != result:' can change to be other things if users want | 21:12 |
| *** ajo_ has joined #openstack-oslo | 21:12 | |
| harlowja | cause who knows what people could create, ha | 21:12 |
| *** ajo_ has quit IRC | 21:13 | |
| tdurakov_ | ++ more flexible | 21:13 |
| *** ozamiatin has quit IRC | 21:13 | |
| harlowja | the other question i guess becomes how to handle backwards compat, ie, people that have no made 1 argument functions and now this provides 2 | 21:13 |
| tdurakov_ | atom=None in signnature? | 21:14 |
| harlowja | ya, which means a forced change in peoples code | 21:14 |
| harlowja | anyway to make that less crappy on users would be nice | 21:15 |
| harlowja | >>> f = lambda history: None | 21:15 |
| harlowja | >>> f(history="", atom="b") | 21:15 |
| harlowja | Traceback (most recent call last): | 21:15 |
| harlowja | File "<stdin>", line 1, in <module> | 21:15 |
| harlowja | TypeError: <lambda>() got an unexpected keyword argument 'atom' | 21:15 |
| harlowja | thats what would happen currently | 21:15 |
| harlowja | *or something like that | 21:15 |
| tdurakov_ | are there any example of current local_decider usages? | 21:15 |
| harlowja | octavia folks in #openstack-lbaas might have some, they really wanted that review to merge, so i expect they are using it | 21:16 |
| harlowja | i can think of various ways to address this | 21:16 |
| *** ekarlso has quit IRC | 21:16 | |
| harlowja | f = lambda history: None | 21:17 |
| harlowja | try: | 21:17 |
| harlowja | f(history=history, atom=atom) | 21:17 |
| harlowja | except TypeError: | 21:17 |
| harlowja | f(history=history) | 21:17 |
| harlowja | thats one way, not so great imho | 21:17 |
| harlowja | class Decider(object): | 21:18 |
| harlowja | def __call__(self, history): | 21:18 |
| harlowja | pass | 21:18 |
| harlowja | class AtomDecider(Decider): | 21:18 |
| harlowja | def __call__(self, history, atom=None): | 21:18 |
| harlowja | pass | 21:18 |
| harlowja | another option | 21:18 |
| * tdurakov_ grepping through octavia code | 21:18 | |
| harlowja | *then can use isinstance to determine what to call | 21:18 |
| harlowja | can use inspect also, but thats 'eh' imho | 21:18 |
| *** rpodolyaka1 has quit IRC | 21:19 | |
| *** rpodolyaka1 has joined #openstack-oslo | 21:20 | |
| tdurakov_ | second seems better | 21:20 |
| harlowja | class Decider(object): | 21:20 |
| harlowja | accepts = ['history', 'atom'] | 21:20 |
| harlowja | def __call__(self, history=None, atom=None): | 21:20 |
| harlowja | pass | 21:20 |
| harlowja | or that | 21:20 |
| harlowja | ^ which is sorta like a mix of using inspect and not, lol | 21:21 |
| *** rpodolyaka1 has quit IRC | 21:21 | |
| tdurakov_ | if you don't mind, i would like to implement that in patch:) | 21:21 |
| harlowja | which one? | 21:21 |
| harlowja | :) | 21:21 |
| harlowja | 1st, second, 3rd? | 21:21 |
| harlowja | :-P | 21:21 |
| tdurakov_ | :) | 21:21 |
| tdurakov_ | second or third | 21:21 |
| harlowja | hehe ok, i'm not sure which is better there either :) | 21:22 |
| harlowja | i've seen 1st be done in places, not sure if its a good pattern though | 21:22 |
| harlowja | i like second more, but it forces people to use classes | 21:22 |
| tdurakov_ | also got a snippet for you: http://paste.openstack.org/show/406316/ | 21:23 |
| harlowja | cool | 21:23 |
| harlowja | this brings me to another idea | 21:23 |
| tdurakov_ | r_d task would be never started | 21:23 |
| harlowja | ya, hmmm | 21:24 |
| *** e0ne has quit IRC | 21:24 | |
| harlowja | that shouldn't be super hard to fix i think | 21:24 |
| harlowja | but def seems like a undesired bug that i see why it happens | 21:24 |
| harlowja | wanna open a bug for that, should be somewhat easy to fix i think | 21:25 |
| tdurakov_ | while its oriented graph, r_d is successor of r_b which should be executed and r_c whic become ignored | 21:25 |
| harlowja | agreed | 21:25 |
| tdurakov_ | yeh, working on patch for that | 21:25 |
| harlowja | cools thx tdurakov_ | 21:26 |
| *** ozamiatin has joined #openstack-oslo | 21:27 | |
| tdurakov_ | so, there are two ways to fix that | 21:27 |
| harlowja | someday when networkx releases its graph support for ordereddict that will also i think make this a little more natural | 21:27 |
| harlowja | *graph support using orderddicts internally (vs unorderd dicts) | 21:27 |
| *** zz_dimtruck is now known as dimtruck | 21:27 | |
| tdurakov_ | we could always run r_d as successor of r_b, or we could add extra param for link method | 21:28 |
| tdurakov_ | smth like: def link(self, u, v, decider=None, ignore_successor=True): | 21:28 |
| tdurakov_ | i'd preffer first one | 21:28 |
| tdurakov_ | harlowja, what do you think about?^ | 21:29 |
| harlowja | hmmm | 21:29 |
| *** ozamiatin has quit IRC | 21:30 | |
| harlowja | oorrr tdurakov_ what about returning an enumeration from a decider ? | 21:31 |
| harlowja | or somehow providing an enurmation that affects how the ignoring works | 21:32 |
| harlowja | class Selection(enum.Enum): | 21:32 |
| harlowja | any | 21:32 |
| harlowja | all | 21:32 |
| harlowja | single | 21:32 |
| harlowja | or something like that, this is basically something that would affect the loop | 21:32 |
| harlowja | for local_decider in six.itervalues(self._edge_deciders): | 21:33 |
| harlowja | if not local_decider(history=results): | 21:33 |
| harlowja | return False | 21:33 |
| harlowja | which is basically a 'or' statement | 21:33 |
| harlowja | *in a way* | 21:33 |
| *** achanda has joined #openstack-oslo | 21:34 | |
| harlowja | any would ignore if any return 'true'; all would be ignore if 'all' return true | 21:35 |
| harlowja | maybe that enum should come in via def set_decision(self, u) method on a graph flow | 21:36 |
| harlowja | since its really not link specific (but the decision that a target 'u' node/atom will perform when undergoing the decision stuff) | 21:36 |
| tdurakov_ | ooook) | 21:38 |
| *** achanda has quit IRC | 21:39 | |
| *** gordc has quit IRC | 21:39 | |
| tdurakov_ | harlowja, I'll push patches for that tomorrow) | 21:40 |
| harlowja | tdurakov_ sweet | 21:40 |
| harlowja | probably don't need the 'single' in that enum actually, but the 'any/all' seem to make sense | 21:40 |
| *** tdurakov_ has quit IRC | 21:42 | |
| harlowja | and should default to 'any' i guess (to work in the existing manner) | 21:43 |
| *** exploreshaifali has quit IRC | 21:43 | |
| *** ekarlso has joined #openstack-oslo | 21:44 | |
| openstackgerrit | Merged openstack/debtcollector: Add example for removing a @classmethod https://review.openstack.org/206237 | 21:50 |
| openstackgerrit | Merged openstack/debtcollector: Improve + test keyword argument @classmethod removal https://review.openstack.org/206246 | 21:51 |
| *** ihrachyshka has quit IRC | 21:56 | |
| *** prad has quit IRC | 21:59 | |
| *** Kennan2 has joined #openstack-oslo | 22:02 | |
| *** Kennan has quit IRC | 22:03 | |
| *** mriedem has quit IRC | 22:04 | |
| *** achanda has joined #openstack-oslo | 22:11 | |
| *** bknudson has quit IRC | 22:25 | |
| *** sigmavirus24 has quit IRC | 22:31 | |
| openstackgerrit | Merged openstack/debtcollector: Add @removals.removed_kwarg on an __init__ method https://review.openstack.org/206259 | 22:31 |
| openstackgerrit | Merged openstack/debtcollector: Expose a top level 'deprecate' function https://review.openstack.org/206262 | 22:31 |
| *** sigmavirus24 has joined #openstack-oslo | 22:33 | |
| *** ozamiatin has joined #openstack-oslo | 22:33 | |
| *** rossella_s has quit IRC | 22:37 | |
| *** rossella_s has joined #openstack-oslo | 22:38 | |
| *** abitha has joined #openstack-oslo | 22:38 | |
| *** sdake has quit IRC | 22:40 | |
| *** sdake has joined #openstack-oslo | 22:40 | |
| *** sdake has quit IRC | 22:42 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 22:43 | |
| *** jaypipes has quit IRC | 22:43 | |
| openstackgerrit | fumihiko kakuma proposed openstack/oslo.db: Python 3: Use use_unicode=1 under Python 3 https://review.openstack.org/206997 | 22:45 |
| *** ericksonsantos has quit IRC | 22:50 | |
| *** ozamiatin has quit IRC | 22:59 | |
| *** jecarey has quit IRC | 23:04 | |
| *** alexpilotti has quit IRC | 23:05 | |
| *** dimtruck is now known as zz_dimtruck | 23:18 | |
| *** jaosorior has quit IRC | 23:21 | |
| *** jamielennox is now known as jamielennox|away | 23:39 | |
| *** zz_dimtruck is now known as dimtruck | 23:40 | |
| openstackgerrit | Zhu Zhu proposed openstack/oslo.vmware: Allow http connection pool size to be configured https://review.openstack.org/206804 | 23:51 |
| *** Kennan2 is now known as Kennan | 23:53 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!