*** alexpilotti has quit IRC | 00:10 | |
*** dims__ has joined #openstack-oslo | 00:11 | |
*** dims_ has quit IRC | 00:12 | |
*** vilobhmm has joined #openstack-oslo | 00:12 | |
harlowja | lifeless have u seen http://paste.openstack.org/show/264329/ ? | 00:15 |
---|---|---|
harlowja | $ pip freeze | grep testtools | 00:15 |
harlowja | testtools==1.8.0 | 00:15 |
*** sputnik13 has quit IRC | 00:16 | |
lifeless | harlowja: too-old pbr | 00:16 |
harlowja | ah | 00:16 |
harlowja | k | 00:16 |
lifeless | harlowja: how did you install testtools ? | 00:16 |
harlowja | pip, but in a old venv i guess | 00:16 |
*** dims__ has quit IRC | 00:17 | |
lifeless | I'll check the install_requires is appropriately versioned, it may not be | 00:17 |
harlowja | k | 00:17 |
*** dims_ has joined #openstack-oslo | 00:17 | |
harlowja | updated @ https://review.openstack.org/#/c/188633/ | 00:18 |
harlowja | thx | 00:19 |
*** jaosorior has quit IRC | 00:22 | |
*** vilobhmm has quit IRC | 00:27 | |
*** tsekiyam_ has joined #openstack-oslo | 00:42 | |
*** tsekiyam_ has quit IRC | 00:42 | |
*** mtanino has quit IRC | 00:43 | |
*** tsekiyama has quit IRC | 00:45 | |
*** amotoki has joined #openstack-oslo | 00:53 | |
*** salv-orlando has joined #openstack-oslo | 00:54 | |
*** salv-orlando has quit IRC | 01:10 | |
*** stpierre has quit IRC | 01:30 | |
*** stpierre has joined #openstack-oslo | 01:31 | |
*** tobe has joined #openstack-oslo | 01:38 | |
*** Kiall_ has joined #openstack-oslo | 01:43 | |
*** Kiall has quit IRC | 01:43 | |
*** vilobhmm has joined #openstack-oslo | 01:46 | |
tchaypo | lifeless: I’ve re-added the checks on requires.txt to https://review.openstack.org/187846 (well, the change it depends on) to make sure that requires.txt is being generated properly, and that passes; but even with setuptools>=16, in every test, either we get ‘invalid environment marker’ or we end up with the requirements missing | 01:56 |
tchaypo | lifeless: the biggest doubt I’ve got is whether I’m calling pip properly | 01:56 |
lifeless | tchaypo: ok, so I should pull it down again and poke? Where are you seeing invalid environment market btw | 02:01 |
*** vilobhmm has quit IRC | 02:01 | |
lifeless | tchaypo: still python 2.6 only? | 02:01 |
tchaypo | on the most recent run, 26, 27, and 34 | 02:02 |
tchaypo | on patchset 5, test_requirement_parsing(editable,tree,pbr_not_installed) (and maybe others) didn’t get invalid environment marker, but did fail to install the requirements | 02:04 |
*** yamahata has quit IRC | 02:04 | |
lifeless | weird | 02:06 |
*** salv-orlando has joined #openstack-oslo | 02:09 | |
*** gordc has quit IRC | 02:13 | |
*** salv-orlando has quit IRC | 02:17 | |
*** stevemar has quit IRC | 02:40 | |
*** achanda has joined #openstack-oslo | 02:46 | |
*** boris-42 has quit IRC | 02:58 | |
*** stpierre has quit IRC | 03:00 | |
*** achanda has quit IRC | 03:00 | |
*** dims_ has quit IRC | 03:07 | |
tchaypo | Lifeless: makati is having a look at pbr now. She's running into issues with the tests that invoke GPG in test_packaging.TestVersions - it seems to be because she has a newer GPG - so she's planning to poke at those | 03:18 |
lifeless | k | 03:21 |
lifeless | who is makati ? | 03:21 |
*** amotoki has quit IRC | 03:22 | |
lifeless | tchaypo: ?^ | 03:50 |
*** salv-orlando has joined #openstack-oslo | 03:51 | |
tchaypo | Bah | 03:55 |
tchaypo | *nakato | 03:55 |
*** exploreshaifali has joined #openstack-oslo | 03:56 | |
*** salv-orlando has quit IRC | 04:01 | |
*** dims_ has joined #openstack-oslo | 04:05 | |
*** dims_ has quit IRC | 04:10 | |
*** rpodolyaka1 has joined #openstack-oslo | 04:15 | |
*** rushiagr_away is now known as rushiagr | 04:22 | |
*** rushiagr is now known as rushiagr_away | 04:27 | |
*** amotoki has joined #openstack-oslo | 04:31 | |
*** jamielennox is now known as jamielennox|away | 04:32 | |
*** rpodolyaka1 has quit IRC | 04:38 | |
*** rushiagr_away is now known as rushiagr | 04:40 | |
*** rpodolyaka1 has joined #openstack-oslo | 04:58 | |
Nakato | re-pbr-tests: So it breaks due to %no-ask-password being a no-op in 2.1, so just need to use new options with 2.1 | 05:16 |
lifeless | cool | 05:18 |
tchaypo | shouldn’t a no-op do nothing? | 05:18 |
lifeless | It would be nice if gpg could pick one way of doing this and stick to it | 05:18 |
tchaypo | or is it one of those not-much-ops that very noisly does nothing? | 05:18 |
lifeless | tchaypo: its no-opping - so it asks for a password; is how I interpret Nakato's statement | 05:19 |
tchaypo | … oh. | 05:19 |
Nakato | lifeless: precisely, which fails when it's not interactive | 05:19 |
tchaypo | le sigh | 05:21 |
*** achanda has joined #openstack-oslo | 05:25 | |
*** exploreshaifali_ has joined #openstack-oslo | 05:28 | |
*** exploreshaifali has quit IRC | 05:29 | |
*** sputnik13 has joined #openstack-oslo | 05:37 | |
*** tobe has quit IRC | 05:41 | |
*** tobe has joined #openstack-oslo | 05:42 | |
*** achanda has quit IRC | 05:43 | |
*** tobe has quit IRC | 05:44 | |
*** mdbooth has quit IRC | 05:48 | |
*** mdbooth has joined #openstack-oslo | 05:53 | |
*** jaosorior has joined #openstack-oslo | 05:54 | |
*** rpodolyaka1 has quit IRC | 06:02 | |
*** achanda has joined #openstack-oslo | 06:09 | |
openstackgerrit | Sachi King proposed openstack-dev/pbr: Fix test case to be runnable with gnupg 2.1 https://review.openstack.org/188675 | 06:10 |
*** vilobhmm has joined #openstack-oslo | 06:12 | |
*** amotoki has quit IRC | 06:16 | |
*** tobe has joined #openstack-oslo | 06:19 | |
jd__ | harlowja: yeah thanks I wanted to investigate on that migration, you beat me to it | 06:23 |
*** amotoki has joined #openstack-oslo | 06:25 | |
*** sputnik13 has quit IRC | 06:29 | |
*** amotoki has quit IRC | 06:36 | |
*** amotoki has joined #openstack-oslo | 06:37 | |
openstackgerrit | Sachi King proposed openstack-dev/pbr: Fix test case to be runnable with gnupg 2.1 https://review.openstack.org/188675 | 06:41 |
*** amotoki has quit IRC | 06:41 | |
*** exploreshaifali_ has quit IRC | 06:45 | |
*** vilobhmm has quit IRC | 06:46 | |
*** rpodolyaka1 has joined #openstack-oslo | 06:52 | |
*** dims_ has joined #openstack-oslo | 06:54 | |
openstackgerrit | Merged openstack/oslotest: Fix argument handling in oslo_run_cross_tests https://review.openstack.org/188527 | 06:54 |
*** e0ne has joined #openstack-oslo | 06:54 | |
lifeless | Nakato: patch is looking ok, but did you see my second erview comment? | 06:55 |
*** takedakn has joined #openstack-oslo | 06:56 | |
*** dims_ has quit IRC | 06:59 | |
*** takedakn has quit IRC | 07:00 | |
*** takedakn has joined #openstack-oslo | 07:01 | |
*** e0ne has quit IRC | 07:04 | |
*** takedakn has quit IRC | 07:04 | |
lifeless | Nakato: ah nvm, I read the diff badly! | 07:11 |
ekarlso | sileht: heya, you about mr ? | 07:12 |
*** takedakn has joined #openstack-oslo | 07:16 | |
*** prashant-upadhya has joined #openstack-oslo | 07:17 | |
Nakato | lifeless: Yea saw that, bit confusing when a script has commented out things in it... Saved me a great deal of research though as I started by looking up what those options were. | 07:17 |
prashant-upadhya | hi nakato | 07:17 |
prashant-upadhya | i have a query regarding rpc.call/cast | 07:17 |
*** takedakn has quit IRC | 07:17 | |
prashant-upadhya | can u help me | 07:17 |
*** takedakn has joined #openstack-oslo | 07:18 | |
Nakato | Sorry prashant-upadhya, I currently don't know anything about that. | 07:18 |
*** takedakn has quit IRC | 07:18 | |
*** takedakn has joined #openstack-oslo | 07:19 | |
prashant-upadhya | i want to know how message reaches its destination . how topic subsribers get to know a message has reached. is there some documents i can go through | 07:19 |
prashant-upadhya | somebody else who knows it.. can help | 07:19 |
prashant-upadhya | :) | 07:19 |
*** takedakn has quit IRC | 07:22 | |
*** achanda has quit IRC | 07:28 | |
lifeless | prashant-upadhya: probably need to read the rabbitmq docs | 07:32 |
prashant-upadhya | okay ; is there any way to see the logs of queues . what message it got from whom . who picked it ? | 07:33 |
lifeless | see the rabbitmq docs for all that sort of thing IMO | 07:34 |
*** exploreshaifali has joined #openstack-oslo | 07:36 | |
*** rpodolyaka1 has quit IRC | 07:44 | |
*** achanda has joined #openstack-oslo | 07:52 | |
*** achanda_ has joined #openstack-oslo | 08:01 | |
*** achanda has quit IRC | 08:04 | |
*** ajo_ has joined #openstack-oslo | 08:05 | |
*** ihrachyshka has joined #openstack-oslo | 08:10 | |
openstackgerrit | Elena Ezhova proposed openstack/oslo.service: Add entrypoints for option discovery https://review.openstack.org/187607 | 08:19 |
*** yassine_ has joined #openstack-oslo | 08:21 | |
eezhova | dhellmann, hello! I updated the review ^^^. Do the entrypoints look okay and what additional documentation should I add? | 08:22 |
*** rpodolyaka1 has joined #openstack-oslo | 08:27 | |
openstackgerrit | Victor Sergeyev proposed openstack/oslo.messaging: Reduce `magic` conf attribute usage https://review.openstack.org/187923 | 08:30 |
*** sdake has quit IRC | 08:34 | |
*** ndipanov has joined #openstack-oslo | 08:37 | |
*** rpodolyaka1 has quit IRC | 08:45 | |
*** achanda_ has quit IRC | 08:46 | |
*** rpodolyaka1 has joined #openstack-oslo | 08:46 | |
ekarlso | sileht: heya, I got a Q regarding oslo.messaging, is it possible to have it send more raw data vs the data being wrapped in some oslo dicT ? | 08:47 |
*** ozamiatin has joined #openstack-oslo | 08:54 | |
*** cdent has joined #openstack-oslo | 09:00 | |
*** Kiall_ has quit IRC | 09:05 | |
*** Kiall has joined #openstack-oslo | 09:06 | |
*** e0ne has joined #openstack-oslo | 09:09 | |
*** prashant-upadhya has quit IRC | 09:13 | |
*** exploreshaifali has quit IRC | 09:23 | |
*** Kiall has quit IRC | 09:24 | |
*** Kiall_ has joined #openstack-oslo | 09:24 | |
openstackgerrit | Elena Ezhova proposed openstack/oslo.service: Introduce abstract base class for services https://review.openstack.org/188714 | 09:25 |
*** ajo_ has quit IRC | 09:33 | |
*** prashant-upadhya has joined #openstack-oslo | 09:34 | |
*** dims_ has joined #openstack-oslo | 09:43 | |
*** rpodolyaka1 has quit IRC | 09:43 | |
*** alexpilotti has joined #openstack-oslo | 09:45 | |
*** dims__ has joined #openstack-oslo | 09:47 | |
*** rpodolyaka1 has joined #openstack-oslo | 09:48 | |
*** dims_ has quit IRC | 09:48 | |
*** Kiall_ has quit IRC | 09:53 | |
*** Kiall has joined #openstack-oslo | 09:56 | |
*** rpodolyaka1 has quit IRC | 10:04 | |
*** e0ne is now known as e0ne_ | 10:07 | |
*** rpodolyaka1 has joined #openstack-oslo | 10:07 | |
*** e0ne_ is now known as e0ne | 10:12 | |
*** rpodolyaka1 has quit IRC | 10:13 | |
sileht | ekarlso, no this is not possible, I wonder why you need that, this dict containt the information to decode the payload ie: the version tell that the message is a json dict with a payload a context... | 10:14 |
ekarlso | sileht: if you're wanting to send info to logstash for example.. | 10:14 |
sileht | ekarlso, the application consumer need to decode the message and transform it to something suitable for logstash | 10:16 |
sileht | ekarlso, otherrise if one day we change the content of the message, you logstash will be borken | 10:16 |
ekarlso | sileht: uhm, logstash is a PITA to do that kinda stuff ie extract stuff in payload etc into something useful | 10:17 |
ekarlso | but I guess i'm off writing my own notification listener then | 10:17 |
sileht | ekarlso, to have something solid you have to wrote something (or use oslo.messaging) that understand the message format | 10:18 |
ekarlso | sileht: i guess a notifi listener is the best thing then :'( | 10:19 |
sileht | ekarlso, or don't use logstash :p | 10:20 |
openstackgerrit | Merged openstack/oslo.db: Allow to fail instead of skip in DbFixture https://review.openstack.org/187717 | 10:20 |
*** achanda has joined #openstack-oslo | 10:20 | |
sileht | ekarlso, fluentd is not cool for that too | 10:20 |
ekarlso | sileht: really logstash is more or the less like a notification listener no ? | 10:20 |
*** boris-42 has joined #openstack-oslo | 10:20 | |
sileht | ekarlso, yes this a notification listener, but it doesn't decode the message format | 10:21 |
ekarlso | ah well ok | 10:21 |
ekarlso | sileht: is there a way to just publish notifications to 1 topic vs topic.info etc ? | 10:22 |
sileht | ekarlso, you have to use grok or something like that to read the pauload | 10:22 |
dims__ | sileht: easy ones? https://review.openstack.org/#/c/187963/ and https://review.openstack.org/#/c/185853/ | 10:33 |
sileht | dims__, done | 10:34 |
dims__ | sileht: this one may be a long one for the weekend :) https://review.openstack.org/#/c/187338/ | 10:35 |
dims__ | jd__: flaper87: any opinion on this one? https://review.openstack.org/#/c/143423/ | 10:35 |
ihrachyshka | dims__, hey. I have a concern around debtcollector. it seems it uses DeprecationWarnings that are disabled by default in py27+, so if we want to see those warnings, we need to enable them globally for all libraries, including those that we don't control. | 10:37 |
ihrachyshka | dims__, while versionutils module allows us to report just those that we explicitly request | 10:37 |
ihrachyshka | comments? | 10:37 |
*** SergeyLukjanov has quit IRC | 10:39 | |
dims__ | ihrachyshka: are you using versionutils right now? | 10:42 |
ihrachyshka | dims__, we consider it for one of deprecations in neutron. yes, we also use it in several places. | 10:43 |
dims__ | ihrachyshka: then i'd be ok for you to continue with that but the one from oslo.log | 10:43 |
ihrachyshka | we wanted to extend versionutils to support keyword deprecation, but were asked to use debtcollector. | 10:43 |
ihrachyshka | so we looked into it and don't get how to enable warnings without bloating logs with irrelevant stuff | 10:44 |
dims__ | let's involve dhellmann and harlowja in this discussion as it is important. | 10:44 |
dims__ | ihrachyshka: point me to the review please? | 10:44 |
ihrachyshka | dims__, neutron review that raised the need of keyword deprecation: https://review.openstack.org/175238 | 10:45 |
ihrachyshka | dims__, and versionutils extension for that: https://review.openstack.org/187530 (abandoned due to debtcollector) | 10:45 |
dims__ | ihrachyshka: can you please unabandon that one? and paste this chat there | 10:47 |
dims__ | looks like we did not wait for dhellmann's response on that one | 10:48 |
ihrachyshka | dims__, done | 10:49 |
ihrachyshka | all in all, seems like adopting debtcollector as the way to go for openstack can be blocked by this. unless we extend the lib to log with something more visible. | 10:50 |
*** SergeyLukjanov has joined #openstack-oslo | 10:51 | |
dims__ | ihrachyshka: ack | 11:02 |
dims__ | lifeless: around? | 11:02 |
*** prashant-upadhya has quit IRC | 11:03 | |
*** e0ne is now known as e0ne_ | 11:05 | |
*** e0ne_ is now known as e0ne | 11:07 | |
dims__ | lifeless: i am slowly adding to py34 tests in nova (using testtools.run), the white list is becoming quite big - https://review.openstack.org/#/c/188653/3/tox.ini,cm - any suggestions to better manage it outside of tox.ini? | 11:08 |
*** prashant-upadhya has joined #openstack-oslo | 11:09 | |
openstackgerrit | Merged openstack/oslo.messaging: Enable `fanout_target` scenarios in test_impl_rabbit https://review.openstack.org/187963 | 11:20 |
openstackgerrit | Merged openstack/oslo.messaging: rabbit: test for new reply behavior https://review.openstack.org/185853 | 11:20 |
ihrachyshka | dims__, why not working on covering a single tree of tests so that you can merge multiple entries into one? | 11:23 |
*** ozamiatin has quit IRC | 11:26 | |
openstackgerrit | Elena Ezhova proposed openstack/oslo.service: Make logging option values configurable https://review.openstack.org/188747 | 11:31 |
*** rpodolyaka1 has joined #openstack-oslo | 11:31 | |
*** achanda has quit IRC | 11:35 | |
*** prashant-upadhya has quit IRC | 11:42 | |
*** tobe has quit IRC | 11:42 | |
*** jecarey has joined #openstack-oslo | 11:52 | |
*** rpodolyaka1 has quit IRC | 12:04 | |
*** rpodolyaka1 has joined #openstack-oslo | 12:06 | |
*** e0ne is now known as e0ne_ | 12:21 | |
*** e0ne_ is now known as e0ne | 12:22 | |
*** kgiusti has joined #openstack-oslo | 12:34 | |
*** ndipanov is now known as ndipanoff | 12:36 | |
*** shardy_ has joined #openstack-oslo | 12:39 | |
*** shardy has quit IRC | 12:39 | |
*** gordc has joined #openstack-oslo | 12:41 | |
*** bknudson has joined #openstack-oslo | 12:44 | |
*** shardy_ has quit IRC | 12:44 | |
*** shardy has joined #openstack-oslo | 12:44 | |
*** exploreshaifali has joined #openstack-oslo | 12:57 | |
*** dims__ has quit IRC | 13:09 | |
*** dims_ has joined #openstack-oslo | 13:10 | |
*** boris-42 has quit IRC | 13:18 | |
*** ozamiatin has joined #openstack-oslo | 13:19 | |
*** rpodolyaka1 has quit IRC | 13:20 | |
*** rpodolyaka1 has joined #openstack-oslo | 13:24 | |
*** stpierre has joined #openstack-oslo | 13:25 | |
*** mriedem has joined #openstack-oslo | 13:27 | |
*** rushiagr is now known as rushiagr_away | 13:28 | |
*** kgiusti has quit IRC | 13:29 | |
*** kgiusti has joined #openstack-oslo | 13:30 | |
*** shardy_ has joined #openstack-oslo | 13:36 | |
*** shardy has quit IRC | 13:36 | |
*** e0ne is now known as e0ne_ | 13:39 | |
*** e0ne_ is now known as e0ne | 13:39 | |
*** jecarey has quit IRC | 13:40 | |
*** shardy_ has quit IRC | 13:41 | |
*** boris-42 has joined #openstack-oslo | 13:41 | |
*** shardy has joined #openstack-oslo | 13:42 | |
*** exploreshaifali has quit IRC | 13:43 | |
*** jaypipes is now known as leakypipes | 13:43 | |
*** jecarey has joined #openstack-oslo | 13:52 | |
*** exploreshaifali has joined #openstack-oslo | 14:00 | |
*** zzzeek has joined #openstack-oslo | 14:01 | |
*** yamahata has joined #openstack-oslo | 14:03 | |
*** exploreshaifali has quit IRC | 14:06 | |
*** achanda has joined #openstack-oslo | 14:10 | |
*** shardy_ has joined #openstack-oslo | 14:11 | |
*** shardy has quit IRC | 14:12 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 14:12 | |
*** amrith is now known as _amrith_ | 14:12 | |
*** e0ne is now known as e0ne_ | 14:16 | |
*** shardy_ has quit IRC | 14:16 | |
*** shardy has joined #openstack-oslo | 14:17 | |
*** rushiagr_away is now known as rushiagr | 14:18 | |
*** rpodolyaka1 has quit IRC | 14:25 | |
*** e0ne_ has quit IRC | 14:26 | |
*** mtanino has joined #openstack-oslo | 14:29 | |
*** salv-orlando has joined #openstack-oslo | 14:31 | |
*** dansmith is now known as superdan | 14:32 | |
*** rpodolyaka1 has joined #openstack-oslo | 14:38 | |
*** yamahata has quit IRC | 14:43 | |
*** stevemar has joined #openstack-oslo | 14:44 | |
*** zzzeek has quit IRC | 14:45 | |
*** e0ne has joined #openstack-oslo | 14:45 | |
*** zzzeek has joined #openstack-oslo | 14:46 | |
*** zzzeek has quit IRC | 14:46 | |
*** achanda has quit IRC | 14:56 | |
*** _amrith_ is now known as amrith | 15:01 | |
*** sputnik13 has joined #openstack-oslo | 15:22 | |
*** e0ne is now known as e0ne_ | 15:29 | |
*** e0ne_ is now known as e0ne | 15:30 | |
*** shardy_ has joined #openstack-oslo | 15:30 | |
*** e0ne is now known as e0ne_ | 15:30 | |
*** e0ne_ is now known as e0ne | 15:30 | |
*** shardy has quit IRC | 15:31 | |
*** arnaud____ has joined #openstack-oslo | 15:32 | |
*** achanda has joined #openstack-oslo | 15:34 | |
*** shardy_ has quit IRC | 15:35 | |
*** tsekiyama has joined #openstack-oslo | 15:36 | |
*** shardy has joined #openstack-oslo | 15:36 | |
ihrachyshka | dhellmann, hey | 15:39 |
ihrachyshka | I have debtcollector concern | 15:40 |
dhellmann | ihrachyshka: hi | 15:42 |
openstackgerrit | Merged openstack/oslotest: Updated from global requirements https://review.openstack.org/188569 | 15:43 |
ihrachyshka | dhellmann, concern is: debtcollector does not log by default, and if I enable deprecation warnings, I get all of them, not just from openstack components | 15:43 |
ihrachyshka | dhellmann, should we run with deprecation warnings enabled, always and globally? | 15:43 |
dhellmann | ihrachyshka: we don't want the messages logged anywhere other than unit test jobs, and those can turn on the warnings themselves | 15:43 |
dhellmann | ihrachyshka: deployers cannot fix a problem with a deprecated internal API, so they don't need to see the warning | 15:44 |
ihrachyshka | well, then how would other consumers of neutron code catch that they use it in wrong way? | 15:44 |
ihrachyshka | so versionutils is for user actionable items while debtcollector for code issues? | 15:45 |
dhellmann | ihrachyshka: the unit test jobs should have warnings turned on, so that the deprecation warnings are emitted | 15:45 |
dhellmann | and yes, that's why we have them in separate libraries, the messages are intended for different audiences | 15:46 |
*** david-lyle has quit IRC | 15:46 | |
dhellmann | debtcollector is also not tied to openstack release names for the same reason | 15:46 |
ihrachyshka | dhellmann, got it. do you think anyone reads unit tests output, especially since we run it thru tox that swallows everything? | 15:46 |
*** david-lyle has joined #openstack-oslo | 15:46 | |
dhellmann | ihrachyshka: when I run tox locally I see deprecation warnings as the jobs start up. don't you? | 15:47 |
*** pblaho has quit IRC | 15:47 | |
dhellmann | those might only be on import, though | 15:47 |
dhellmann | dims_, harlowja: have any thoughts on ^^? | 15:48 |
*** amrith is now known as _amrith_ | 15:49 | |
*** crc32 has joined #openstack-oslo | 15:52 | |
*** ozamiatin has quit IRC | 15:54 | |
*** ozamiatin has joined #openstack-oslo | 15:56 | |
dims_ | dhellmann: i like the distinction you were making | 15:59 |
*** achanda_ has joined #openstack-oslo | 15:59 | |
dims_ | unit tests vs deployed instance | 15:59 |
dhellmann | dims_: do you share ihrachyshka's concerns about those warnings not being visible from unit tests? | 15:59 |
dims_ | dhellmann: i do see a whole bunch when i run tox targets locally with nova | 16:00 |
dhellmann | ok, cool, I was worried maybe I had something special set up to enable that | 16:00 |
*** achanda has quit IRC | 16:00 | |
*** ozamiatin has quit IRC | 16:00 | |
openstackgerrit | Doug Hellmann proposed openstack/oslo-incubator: Remove versionutils https://review.openstack.org/182428 | 16:05 |
ihrachyshka | dhellmann, in which repo do you see them? | 16:07 |
ihrachyshka | dhellmann, in neutron, I only get list of test names + ... ok | 16:07 |
*** shardy_ has joined #openstack-oslo | 16:07 | |
*** ashleighfarnham has joined #openstack-oslo | 16:08 | |
*** shardy has quit IRC | 16:08 | |
dhellmann | ihrachyshka: dims_ reported seeing them for nova, and I've seen them in a couple of different places. Maybe there is something about those jobs that enables showing them? Maybe compare the neutron setup and nova setup? | 16:10 |
*** shardy_ has quit IRC | 16:13 | |
*** shardy has joined #openstack-oslo | 16:13 | |
*** exploreshaifali has joined #openstack-oslo | 16:14 | |
*** crc32 has quit IRC | 16:18 | |
dims_ | ihrachyshka: dhellmann: example when i run tox py34 in nova http://paste.openstack.org/show/266386/ | 16:20 |
ihrachyshka | dims_, is it at the start of tox run? | 16:21 |
dims_ | ihrachyshka: no, just a random snip from my screen | 16:21 |
*** e0ne is now known as e0ne_ | 16:23 | |
ihrachyshka | dims_, oh indeed I see them now. in nova at least. | 16:24 |
ihrachyshka | though in a different format | 16:24 |
*** e0ne_ has quit IRC | 16:24 | |
ihrachyshka | dims_, so is there a way to execute unit tests in a way that they fail on deprecation warnings? | 16:25 |
ihrachyshka | if it does not fail, it's not getting attention at all | 16:26 |
*** achanda_ has quit IRC | 16:26 | |
dims_ | ihrachyshka: here's what the keystone folks use - https://review.openstack.org/#/c/187640/1/keystone/tests/unit/core.py,cm | 16:27 |
dims_ | bknudson can fill in details on what they do :) | 16:28 |
dstanek | dims_: that would be a great thing to add everywhere to catch deprecation warnings | 16:30 |
dims_ | dstanek: unfortunately it stops people in their tracks and makes them copy code :) | 16:30 |
ihrachyshka | oh, filter on namespace is nice | 16:31 |
ihrachyshka | we don't want to be broken by external libs | 16:31 |
ihrachyshka | though that would mean that we immediately break consumers once we mark anything as deprecated. | 16:33 |
dims_ | right | 16:33 |
ihrachyshka | the only workaround for them would be to reset it back to 'normal' | 16:33 |
ihrachyshka | or fix breakage | 16:33 |
ihrachyshka | maybe we should just promote disabling it by default if they don't want to chase neutron | 16:34 |
ihrachyshka | and provide a way to enable it for a specific test run | 16:34 |
ihrachyshka | via envvar | 16:34 |
*** rpodolyaka1 has quit IRC | 16:34 | |
ihrachyshka | or go vice versa: enable it for neutron jobs only, and allow consumers of the code to opt in | 16:34 |
*** rpodolyaka1 has joined #openstack-oslo | 16:35 | |
*** arnaud____ has quit IRC | 16:35 | |
ihrachyshka | ok, I think we have now clear way to go for neutron | 16:35 |
ihrachyshka | thanks dims_ and dhellmann for clarifications | 16:35 |
*** rpodolyaka1 has quit IRC | 16:36 | |
dstanek | dims_: ihrachyshka: is this for more than just unit tests? | 16:39 |
*** sdake has joined #openstack-oslo | 16:40 | |
*** e0ne has joined #openstack-oslo | 16:40 | |
ihrachyshka | dstanek, I want to expose it for most tox controlled jobs, for neutron it's functional, unit, fullstack, probably api | 16:42 |
*** e0ne has quit IRC | 16:43 | |
*** achanda has joined #openstack-oslo | 16:43 | |
*** sdake_ has joined #openstack-oslo | 16:44 | |
*** yassine_ has quit IRC | 16:45 | |
*** ashleighfarnham has quit IRC | 16:46 | |
*** sdake has quit IRC | 16:48 | |
*** rpodolyaka1 has joined #openstack-oslo | 16:49 | |
ihrachyshka | dims_, hm, neutron\\. filter still raises oslo invoked deprecations as if they are failures | 16:50 |
*** rpodolyaka1 has quit IRC | 16:54 | |
*** achanda has quit IRC | 16:55 | |
bknudson | I would have been happy to change keystone to use the workaround (isoformat), but it wouldn't be backwards compatible. | 17:00 |
bknudson | I've got a similar change in keystonemiddleware - https://review.openstack.org/#/c/187775/ | 17:01 |
bknudson | maybe there could be a fixture that we could use instead. | 17:01 |
bknudson | nova has http://git.openstack.org/cgit/openstack/nova/tree/nova/tests/fixtures.py#n247 | 17:02 |
ihrachyshka | bknudson, so while keystone has that keystone\\. filter for DeprecationWarnings, isn't it now broken by any change in e.g. oslo libs that would raise a new deprecation? | 17:02 |
bknudson | ihrachyshka: the tests fail if keystone is calling a deprecated function. | 17:03 |
bknudson | at which point we need to fix it. | 17:03 |
bknudson | which makes sense... keystone shouldn't be calling function that's not supported | 17:03 |
ihrachyshka | bknudson, so you are frequently broken by a new release and are ok with that? | 17:03 |
ihrachyshka | it's still supported while it's deprecated | 17:03 |
bknudson | it's only happened once so far | 17:03 |
dstanek | ihrachyshka: it's good to be broken like that so that we are not fighting to catch up | 17:04 |
bknudson | if a library wants to warn users about deprecation they can use PendingDeprecation instead. | 17:04 |
ihrachyshka | I'm not sure neutron team will be ok with that kind of breakages :) | 17:04 |
bknudson | I would have liked to see a PendingDeprecation because then we could have fixed it in our own time. | 17:04 |
bknudson | or, more likely, it would have been ignored until we were totally broken. | 17:04 |
ihrachyshka | bknudson, though if you are not broken, it's easy to just miss the warning | 17:04 |
ihrachyshka | right | 17:05 |
bknudson | my opinion is that it's better to know right away so that we're not picking up debt. | 17:06 |
bknudson | and, it's easy to unbreak, just disable the guard. | 17:06 |
bknudson | or, the deprecation message should say what the remediation is, so do that | 17:07 |
*** vilobhmm has joined #openstack-oslo | 17:10 | |
harlowja | dims_ dhellmann perhaps oslotest should enable https://github.com/testing-cabal/fixtures/blob/master/fixtures/_fixtures/warnings.py by default, and dump them out or something (or blowup? of any are triggered) | 17:11 |
harlowja | or something else (print the messages in big bold blinky red html) | 17:12 |
harlowja | so then it shows up as blinky red html (with a sad face next to it) | 17:12 |
bknudson | it's hard to get output from unit tests. | 17:13 |
bknudson | or it seems to be anyways | 17:13 |
bknudson | some projects don't show any output and others have all sorts of it | 17:13 |
bknudson | the change of keystoneclient to oslotest starts printing all sorts of stuff where it didn't before --https://review.openstack.org/#/c/187770/5 | 17:14 |
bknudson | I haven't had a chance to look into why | 17:14 |
bknudson | also running tox -e py34 has lots of output where py27 doesn't | 17:15 |
*** ashleighfarnham has joined #openstack-oslo | 17:15 | |
*** achanda has joined #openstack-oslo | 17:16 | |
harlowja | hmmmm | 17:17 |
harlowja | odd | 17:17 |
ihrachyshka | for py34 vs py27, it's clear why. | 17:18 |
harlowja | https://docs.python.org/3/library/warnings.html#default-warning-filters (maybe thats the reason?) | 17:19 |
harlowja | 'Changed in version 3.2: DeprecationWarning is now ignored by default in addition to PendingDeprecationWarning.' | 17:19 |
harlowja | but perhaps all thats needed is to use '-W ' correctly in tests | 17:20 |
bknudson | the change in output is unrelated to warnings | 17:20 |
bknudson | it's debug output or something | 17:20 |
harlowja | ya, those look like log warnings (not warnings.warnings ones) | 17:21 |
harlowja | it doesn't look like the duplicate message handling is working (?) | 17:21 |
bknudson | 2015-06-05 01:36:50.653 | WARNING [keystonemiddleware.auth_token] Authorization failed for token -- these are just log.warnings | 17:22 |
harlowja | right | 17:22 |
bknudson | for some reason these aren't printed during tox -e py27 when using testtools.TestCase | 17:22 |
harlowja | odd | 17:23 |
bknudson | so something in oslotest must be letting those through | 17:23 |
bknudson | there might be some oslotest config I didn't do. | 17:23 |
harlowja | man my browser acting up, damn FF, lol | 17:23 |
harlowja | https://github.com/openstack/oslotest/blob/master/oslotest/base.py#L116 ? | 17:24 |
harlowja | maybe something going on there? | 17:24 |
bknudson | I didn't try setting OS_LOG_CAPTURE | 17:25 |
harlowja | ya, maybe try | 17:25 |
bknudson | seems not safe to change how the tests work based on env vars. | 17:25 |
* harlowja won't disagree with that | 17:26 | |
harlowja | afaik https://github.com/openstack/keystone/blob/master/.testr.conf (and others set most of these) | 17:26 |
bknudson | that's probably what I missed in keystoneclient | 17:27 |
bknudson | oops, keystonemiddleware | 17:27 |
harlowja | possibly | 17:27 |
harlowja | bb | 17:27 |
*** harlowja has quit IRC | 17:27 | |
*** harlowja has joined #openstack-oslo | 17:32 | |
*** achanda has quit IRC | 17:34 | |
*** rushiagr is now known as rushiagr_away | 17:40 | |
*** achanda has joined #openstack-oslo | 17:40 | |
*** _amrith_ is now known as amrith | 17:42 | |
*** e0ne has joined #openstack-oslo | 17:48 | |
*** sdake has joined #openstack-oslo | 17:50 | |
*** zz_jgrimm is now known as jgrimm | 17:53 | |
*** sdake_ has quit IRC | 17:54 | |
*** sdake_ has joined #openstack-oslo | 17:56 | |
*** achanda_ has joined #openstack-oslo | 17:59 | |
*** sdake has quit IRC | 17:59 | |
*** achanda has quit IRC | 18:01 | |
harlowja | bknudson hopefully adding that stuff makes it all work | 18:06 |
harlowja | *if u are trying | 18:06 |
bknudson | it's on my list | 18:06 |
harlowja | maybe we should add oslotest docs for all that | 18:06 |
harlowja | or something | 18:06 |
harlowja | so the 'magic' is more known | 18:06 |
harlowja | http://docs.openstack.org/developer/oslotest/ doesn't seem to mention it | 18:06 |
*** achanda has joined #openstack-oslo | 18:10 | |
*** achanda_ has quit IRC | 18:10 | |
*** sdake_ is now known as sdake | 18:10 | |
* harlowja will seee if i can remember to add something | 18:11 | |
harlowja | lifeless if u get around can u re +2 https://review.openstack.org/#/c/183194/ | 18:12 |
harlowja | had to rebase after another merge | 18:12 |
harlowja | if u don't mind | 18:12 |
*** achanda_ has joined #openstack-oslo | 18:18 | |
*** achanda has quit IRC | 18:20 | |
bknudson | I wanted to check my understanding of how rabbit ssl config works... | 18:20 |
bknudson | http://git.openstack.org/cgit/openstack/oslo.messaging/tree/oslo_messaging/_drivers/impl_rabbit.py#n552 | 18:20 |
bknudson | according to that, looks like it's --insecure if you don't set ca_certs | 18:20 |
bknudson | (where ca_certs is actually kombu_ssl_ca_certs | 18:21 |
bknudson | and --insecure means it doesn't verify server cert. | 18:21 |
harlowja | unsure, sileht or flaper87 may know | 18:23 |
bknudson | so, rather than using the system CA certs, it just accepts any cert the server presents | 18:23 |
*** cdent has quit IRC | 18:30 | |
*** cdent has joined #openstack-oslo | 18:32 | |
*** cdent has quit IRC | 18:32 | |
*** mriedem is now known as mriedem_madmax | 18:35 | |
*** mriedem_madmax has quit IRC | 18:35 | |
*** achanda has joined #openstack-oslo | 18:38 | |
*** sabari has quit IRC | 18:41 | |
*** achanda_ has quit IRC | 18:41 | |
*** ashleighfarnham has quit IRC | 18:42 | |
*** ashleighfarnham has joined #openstack-oslo | 18:43 | |
*** harlowja has quit IRC | 18:46 | |
*** achanda_ has joined #openstack-oslo | 18:48 | |
*** achanda has quit IRC | 18:49 | |
*** harlowja has joined #openstack-oslo | 18:53 | |
*** jraim has quit IRC | 18:54 | |
*** zhiyan has quit IRC | 18:54 | |
*** sabari has joined #openstack-oslo | 18:55 | |
*** exploreshaifali has quit IRC | 18:58 | |
*** achanda has joined #openstack-oslo | 19:00 | |
*** achanda_ has quit IRC | 19:01 | |
*** ihrachyshka has quit IRC | 19:02 | |
openstackgerrit | Jeremy Stanley proposed openstack/oslo.db: Switch from MySQL-python to PyMySQL https://review.openstack.org/184392 | 19:04 |
*** achanda has quit IRC | 19:04 | |
fungi | when zzzeek's around again, i know that's ^ going to need some guidance on what we want to do about the opportunistic tests for mysql-python and mysql-connector | 19:05 |
fungi | i started trying to rip them out, but it's one of those loose yarns that seems to unravel much of the sweater | 19:05 |
dims_ | fungi: ack will ping him | 19:06 |
dims_ | thanks! | 19:06 |
fungi | sure thing. i'm happy to keep poking at it given sufficient suggestions on tweaking/removing tests, though also equally happy to hand over the reigns | 19:07 |
fungi | er, reins | 19:07 |
*** sdake has quit IRC | 19:08 | |
*** jaosorior has quit IRC | 19:12 | |
dims_ | fungi: i need to sync up on this topic as well | 19:22 |
dims_ | harlowja: do you know if there's a replacement for cmp(dict1, dict2) in python3? found a bunch of those in nova | 19:22 |
harlowja | something in https://github.com/testing-cabal/testtools/blob/master/testtools/matchers/_dict.py perhaps? | 19:23 |
harlowja | https://github.com/testing-cabal/testtools/blob/master/testtools/matchers/_dict.py#L168 ? | 19:24 |
*** amrith is now known as _amrith_ | 19:25 | |
harlowja | dims_^ | 19:27 |
*** leakypipes has quit IRC | 19:34 | |
dhellmann | dims_: how are they used? can you just say == or != ? | 19:35 |
dhellmann | dims_: I've noticed some of the other projects maintain an etherpad "whiteboard" with priority lists and team status info. I wonder if it would be useful for us to do something similar, with reviews associated with priorities for this cycle. | 19:36 |
*** e0ne has quit IRC | 19:39 | |
*** zzzeek has joined #openstack-oslo | 19:41 | |
*** amotoki has joined #openstack-oslo | 19:55 | |
*** dims__ has joined #openstack-oslo | 19:57 | |
harlowja | dhellmann i like that idear | 19:58 |
*** dims_ has quit IRC | 20:00 | |
*** boris-42 has quit IRC | 20:02 | |
*** dougwig has quit IRC | 20:02 | |
*** dims__ has quit IRC | 20:11 | |
*** e0ne has joined #openstack-oslo | 20:16 | |
*** kgiusti has quit IRC | 20:38 | |
*** jraim has joined #openstack-oslo | 20:38 | |
*** e0ne has quit IRC | 20:45 | |
*** e0ne has joined #openstack-oslo | 20:48 | |
*** jecarey has quit IRC | 20:49 | |
*** dougwig has joined #openstack-oslo | 20:50 | |
*** zhiyan has joined #openstack-oslo | 20:54 | |
*** amotoki has quit IRC | 20:57 | |
*** boris-42 has joined #openstack-oslo | 21:00 | |
*** e0ne has quit IRC | 21:06 | |
*** rpodolyaka1 has joined #openstack-oslo | 21:06 | |
*** rpodolyaka1 has quit IRC | 21:09 | |
*** rpodolyaka1 has joined #openstack-oslo | 21:11 | |
*** rpodolyaka1 has quit IRC | 21:13 | |
*** rpodolyaka1 has joined #openstack-oslo | 21:14 | |
*** rpodolyaka1 has quit IRC | 21:17 | |
*** zzzeek has quit IRC | 21:37 | |
*** openstack has joined #openstack-oslo | 21:42 | |
-cameron.freenode.net- [freenode-info] if you're at a conference and other people are having trouble connecting, please mention it to staff: http://freenode.net/faq.shtml#gettinghelp | 21:42 | |
*** amotoki has joined #openstack-oslo | 21:44 | |
*** stpierre has quit IRC | 21:50 | |
*** Kennan2 has joined #openstack-oslo | 22:02 | |
*** Kennan has quit IRC | 22:03 | |
*** amotoki has quit IRC | 22:11 | |
*** stevemar has quit IRC | 22:12 | |
*** gordc has quit IRC | 22:29 | |
openstackgerrit | Joshua Harlow proposed openstack/tooz: Ensure locks can not be created outside of the root file driver directory https://review.openstack.org/188467 | 22:36 |
*** openstackgerrit has quit IRC | 22:37 | |
*** openstackgerrit has joined #openstack-oslo | 22:37 | |
*** ashleighfarnham has quit IRC | 22:41 | |
openstackgerrit | Joshua Harlow proposed openstack/futurist: Vastly improve the docs https://review.openstack.org/188960 | 22:41 |
openstackgerrit | Joshua Harlow proposed openstack/futurist: Vastly improve the docs https://review.openstack.org/188960 | 22:43 |
openstackgerrit | Joshua Harlow proposed openstack/automaton: Add a initial .gitreview file https://review.openstack.org/188961 | 22:45 |
openstackgerrit | Joshua Harlow proposed openstack/futurist: Caps for futurist in hacking https://review.openstack.org/188962 | 22:50 |
openstackgerrit | Joshua Harlow proposed openstack/automaton: Revamp repo to match openstack repos https://review.openstack.org/188961 | 22:55 |
openstackgerrit | Joshua Harlow proposed openstack/futurist: Capital letters for futurist in HACKING.rst https://review.openstack.org/188962 | 22:56 |
openstackgerrit | Joshua Harlow proposed openstack/automaton: Revamp repo to match openstack repos https://review.openstack.org/188961 | 23:02 |
openstackgerrit | Joshua Harlow proposed openstack/automaton: Revamp repo to match openstack repos https://review.openstack.org/188961 | 23:06 |
openstackgerrit | Joshua Harlow proposed openstack/automaton: Vastly improve the docs https://review.openstack.org/188968 | 23:14 |
harlowja | ok those should be good to go (unless they fail CI, which i don't think they will) | 23:17 |
*** sdake has joined #openstack-oslo | 23:26 | |
*** amotoki has joined #openstack-oslo | 23:53 | |
*** sdake_ has joined #openstack-oslo | 23:57 | |
openstackgerrit | Joshua Harlow proposed openstack/automaton: Revamp repo to match openstack repos https://review.openstack.org/188961 | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!