*** prad has quit IRC | 00:00 | |
*** gordc has quit IRC | 00:03 | |
*** sputnik13 has quit IRC | 00:05 | |
*** achanda_ has joined #openstack-oslo | 00:06 | |
*** achanda has quit IRC | 00:10 | |
*** achanda_ has quit IRC | 00:11 | |
lifeless | harlowja: see my email to -dev about the neutron gate issue | 00:12 |
---|---|---|
harlowja | k | 00:12 |
lifeless | harlowja: it has a link to a patch | 00:12 |
lifeless | for neutron | 00:12 |
lifeless | tchaypo: ok so breath in, breath out | 00:13 |
tchaypo | fortunately the unrelated gas leak was fixed last week, so that no longer makes me want to vomit :p | 00:13 |
tchaypo | I’m working throuh comments at the moment | 00:13 |
harlowja | lifeless also http://paste.openstack.org/show/221292/ (for why not publishing things to pip); i wonder that in march and asked infra folks | 00:14 |
*** salv-orlando has joined #openstack-oslo | 00:15 | |
harlowja | nothing to super amazing came out of that, but some history :-P | 00:16 |
harlowja | ok, let me see if i can figure out extra requires there | 00:18 |
harlowja | don't care about win32 though, ha | 00:19 |
lifeless | oh man, wordpress you so drunk | 00:22 |
lifeless | harlowja: https://rbtcollins.wordpress.com/2015/05/13/improving-dependency-handling-upstream-for-openstack/ has links that will help | 00:22 |
harlowja | cool, think i figured it out , just gotta check | 00:22 |
harlowja | once i found https://www.python.org/dev/peps/pep-0426/#environment-markers | 00:22 |
harlowja | :-P | 00:22 |
* harlowja wasn't sure what that mini language supported | 00:23 | |
tchaypo | too much. | 00:23 |
tchaypo | ;) | 00:23 |
harlowja | :) | 00:23 |
tchaypo | but on the other hand | 00:23 |
tchaypo | at least it’s not turing-complete | 00:23 |
lifeless | it doesn't support it all | 00:24 |
lifeless | like, whats defined and whats supported differ | 00:24 |
harlowja | awesome | 00:24 |
harlowja | thats the best kind of support | 00:24 |
harlowja | and docs | 00:24 |
harlowja | lol | 00:24 |
*** tsekiyam_ has joined #openstack-oslo | 00:25 | |
*** amuller has quit IRC | 00:25 | |
*** salv-orlando has quit IRC | 00:26 | |
*** mtanino has quit IRC | 00:27 | |
*** david-lyle has quit IRC | 00:28 | |
*** tsekiyama has quit IRC | 00:28 | |
*** tsekiyam_ has quit IRC | 00:29 | |
lifeless | aieee theme explosion | 00:30 |
lifeless | I think I've got an ok one now | 00:30 |
lifeless | right, context switch time - tchaypo how you going? | 00:30 |
lifeless | dhellmann: sdague: https://rbtcollins.wordpress.com/2015/05/13/improving-dependency-handling-upstream-for-openstack/ <- probably useful context for the discussion the other day | 00:31 |
harlowja | someday i'll be a cool blogger | 00:33 |
harlowja | lol | 00:33 |
*** bogdando has joined #openstack-oslo | 00:35 | |
tchaypo | lifeless: updating code based on your comments | 00:35 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Remove custom py26/py27 and tweak requirements https://review.openstack.org/182423 | 00:44 |
harlowja | tchaypo lifeless does the setup.py stuff in ^ look ok? | 00:44 |
harlowja | oops, duped 2.6, lol | 00:45 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Remove custom py26/py27 and tweak requirements https://review.openstack.org/182423 | 00:45 |
tchaypo | I think so | 00:46 |
harlowja | k | 00:46 |
harlowja | tox knows how to install those ? | 00:46 |
harlowja | i guess when it runs setup.py develop that will get sucked down? | 00:47 |
tchaypo | now that’s a whole nother question. | 00:47 |
harlowja | ah | 00:47 |
harlowja | hmmm, nice to have them get packaged right, even better if they get used by tox to, lol | 00:47 |
harlowja | ^ ensures they are tested :-P | 00:47 |
tchaypo | I haven’t tested that. but my understanding is that the intent with env_markers is that they’re meant to be automatically acted on | 00:47 |
harlowja | k | 00:48 |
*** browne has quit IRC | 00:53 | |
*** stevemar has joined #openstack-oslo | 00:54 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Remove custom py26/py27 tox venvs no longer used https://review.openstack.org/182512 | 00:56 |
harlowja | hmmm, ya, doesn't seem to be getting installed on my 2.7 env with those markers | 00:57 |
harlowja | *mysql-python that is | 00:57 |
harlowja | think i'll wait as lifeless suggested :-P | 00:58 |
lifeless | harlowja: when we do do it you'll want to add file://$(pwd)/[test] to your deps= in tox.ini | 00:59 |
harlowja | kk | 00:59 |
lifeless | harlowja: and have them guarded by test as i mentioned in my review | 00:59 |
harlowja | maybe thats why it wasn't working lcoally | 00:59 |
harlowja | *locally | 00:59 |
*** erickson has joined #openstack-oslo | 00:59 | |
tchaypo | lifeless: responded with comments on test_util.py, still working through the rest | 01:00 |
*** ericksonfgds has quit IRC | 01:00 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Remove custom py26/py27 tox requirements https://review.openstack.org/182423 | 01:05 |
lifeless | tchaypo: replied back to you | 01:05 |
lifeless | :) | 01:05 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Remove customized pyX.Y tox requirements https://review.openstack.org/182423 | 01:07 |
*** bknudson has joined #openstack-oslo | 01:07 | |
tchaypo | lifeless: nit on your blog post - " Only use supplied requirements” should be “Only user supplied requirements" | 01:11 |
lifeless | fixed | 01:21 |
tchaypo | there was a “pips” later on that should have been “pip’s” as well | 01:33 |
tchaypo | *reads about list ordering in python* | 01:36 |
tchaypo | I can’t find anything that says list ordering is guaranteed to be preserved. I know that it is, but I thought that was an implementation detail rather than something to rely on | 01:39 |
lifeless | tchaypo: preserved under what operation ? | 01:42 |
tchaypo | obviously not sorting :p | 01:42 |
lifeless | tchaypo: the semantics of a list is that its an ordered sequence. | 01:42 |
tchaypo | add/append | 01:42 |
lifeless | tchaypo: it is very much not a detail. It is le raison d'etre | 01:43 |
tchaypo | is that documented somewhere? | 01:44 |
lifeless | does it matter? | 01:44 |
lifeless | I mean, we can burn cycles digging up the chapter and verse if needed. | 01:44 |
tchaypo | https://docs.python.org/2/reference/datamodel.html - “These represent finite ordered sets" | 01:45 |
lifeless | there you go | 01:45 |
tchaypo | woo | 01:45 |
*** ozamiatin has quit IRC | 01:45 | |
lifeless | though technical I would have thought finite ordered multi-set | 01:46 |
*** zzzeek has quit IRC | 01:47 | |
*** erickson has quit IRC | 01:47 | |
tchaypo | I’m constantly surprised that things like http://stackoverflow.com/questions/3495124/not-reading-vimrc/9700719#9700719 keep getting upvotes | 01:48 |
tchaypo | … and I’m constantly surprised that I’m apparently in the top 8% of repo on stackoverflow | 01:48 |
*** vilobhmm1 has quit IRC | 01:49 | |
*** vilobhmm1 has joined #openstack-oslo | 01:49 | |
openstackgerrit | James Polley proposed openstack-dev/pbr: WIP: Teach pbr to read extras from setup.cfg https://review.openstack.org/181795 | 01:53 |
*** vilobhmm1 has quit IRC | 01:54 | |
lifeless | tchaypo: this is my equivalent - http://stackoverflow.com/questions/3277367/how-does-pythons-super-work-with-multiple-inheritance/16310777#16310777 | 01:58 |
lifeless | someday it will surpase the wrong answer above it | 02:00 |
lifeless | tchaypo: looks like none of my review comments made it through your local git ops, you may need to check the older review to be sure. | 02:05 |
lifeless | ok -> doctors, bbialw | 02:06 |
tchaypo | bah. enjoy the doctor! | 02:06 |
*** erickson has joined #openstack-oslo | 02:11 | |
*** ihrachyshka has quit IRC | 02:13 | |
*** shardy_z has quit IRC | 02:16 | |
*** browne has joined #openstack-oslo | 02:17 | |
openstackgerrit | Ethan Lynn proposed openstack/oslo.utils: Add mac validate function in netutils https://review.openstack.org/182167 | 02:21 |
tchaypo | lifeless: in case you see this - i think you mean the comments about using test scnearios? I did see those, and I do plan to go that way | 02:24 |
*** zzzeek has joined #openstack-oslo | 02:26 | |
*** zzzeek has quit IRC | 02:26 | |
*** sputnik13 has joined #openstack-oslo | 02:27 | |
*** yamahata has quit IRC | 02:39 | |
*** achanda has joined #openstack-oslo | 02:47 | |
*** sdake has quit IRC | 02:51 | |
*** ashleighfarnham has quit IRC | 02:54 | |
*** alexpilotti has quit IRC | 03:00 | |
*** yamahata has joined #openstack-oslo | 03:03 | |
*** erickson has quit IRC | 03:10 | |
*** salv-orlando has joined #openstack-oslo | 03:17 | |
*** dims_ has quit IRC | 03:18 | |
*** links has joined #openstack-oslo | 03:30 | |
*** vilobhmm1 has joined #openstack-oslo | 03:33 | |
openstackgerrit | Eric Brown proposed openstack/oslo.vmware: Add ToolsUnavailable exception https://review.openstack.org/182527 | 03:37 |
*** salv-orlando has quit IRC | 03:42 | |
*** david-lyle has joined #openstack-oslo | 03:48 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 04:06 | |
*** salv-orlando has joined #openstack-oslo | 04:10 | |
*** dims has joined #openstack-oslo | 04:18 | |
*** salv-orlando has quit IRC | 04:25 | |
*** dims has quit IRC | 04:25 | |
*** vilobhmm1 has quit IRC | 04:25 | |
*** vilobhmm1 has joined #openstack-oslo | 04:26 | |
*** salv-orlando has joined #openstack-oslo | 04:32 | |
*** salv-orlando has quit IRC | 04:33 | |
openstackgerrit | James Polley proposed openstack-dev/pbr: WIP: Teach pbr to read extras from setup.cfg https://review.openstack.org/181795 | 04:41 |
*** nkrinner has joined #openstack-oslo | 04:58 | |
lifeless | tchaypo: I meant that, and the per fiel comments | 05:11 |
lifeless | tchaypo: which seemed entirely ignored judging from the diff | 05:11 |
*** vilobhmm11 has joined #openstack-oslo | 05:11 | |
tchaypo | sorry, I probably should have been clearer about the fact that I was uploading a partially-done set of changes | 05:11 |
tchaypo | I’m moving off this now so I can work on other things, will pick it up again in the morning | 05:12 |
*** achanda_ has joined #openstack-oslo | 05:12 | |
lifeless | k | 05:13 |
*** SlickN1k has joined #openstack-oslo | 05:14 | |
*** stevemar2 has joined #openstack-oslo | 05:14 | |
*** vilobhmm1 has quit IRC | 05:15 | |
lifeless | tchaypo: I'd love to have this bedded down before Canvouver | 05:15 |
*** achanda has quit IRC | 05:26 | |
*** stevemar has quit IRC | 05:26 | |
*** ir2ivps10 has quit IRC | 05:26 | |
*** SlickNik has quit IRC | 05:27 | |
*** SlickN1k is now known as SlickNik | 05:27 | |
*** ir2ivps10 has joined #openstack-oslo | 05:39 | |
*** ashleighfarnham has joined #openstack-oslo | 05:43 | |
*** dulek has joined #openstack-oslo | 05:48 | |
*** ashleighfarnham has quit IRC | 05:59 | |
*** ashleighfarnham has joined #openstack-oslo | 05:59 | |
*** dims has joined #openstack-oslo | 06:01 | |
*** ashleighfarnham has quit IRC | 06:04 | |
*** dims has quit IRC | 06:06 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.versionedobjects: Imported Translations from Transifex https://review.openstack.org/182545 | 06:06 |
*** stevemar2 is now known as stevemar | 06:10 | |
*** shardy has joined #openstack-oslo | 06:32 | |
*** inc0 has joined #openstack-oslo | 06:42 | |
*** stevemar has quit IRC | 06:43 | |
*** smallbig has left #openstack-oslo | 06:50 | |
*** dulek has quit IRC | 06:51 | |
*** dulek has joined #openstack-oslo | 06:51 | |
*** achanda_ has quit IRC | 06:55 | |
*** dulek has quit IRC | 07:09 | |
*** x3k is now known as xek | 07:19 | |
*** vilobhmm11 has quit IRC | 07:27 | |
*** xek has quit IRC | 07:40 | |
*** xek has joined #openstack-oslo | 07:41 | |
*** dulek has joined #openstack-oslo | 07:50 | |
*** browne has quit IRC | 07:54 | |
*** dulek has quit IRC | 07:55 | |
*** haypo has joined #openstack-oslo | 08:19 | |
*** e0ne has joined #openstack-oslo | 08:25 | |
*** e0ne has quit IRC | 08:28 | |
*** jaosorior has joined #openstack-oslo | 08:28 | |
*** e0ne has joined #openstack-oslo | 08:30 | |
*** e0ne has quit IRC | 08:31 | |
*** dguitarbite has joined #openstack-oslo | 08:43 | |
*** ozamiatin has joined #openstack-oslo | 08:46 | |
*** ericksonfgds has joined #openstack-oslo | 08:52 | |
*** inc0 has quit IRC | 09:06 | |
*** inc0 has joined #openstack-oslo | 09:08 | |
*** dulek has joined #openstack-oslo | 09:09 | |
openstackgerrit | Merged openstack/stevedore: re-raise exception with full traceback https://review.openstack.org/176793 | 09:09 |
*** ihrachyshka has joined #openstack-oslo | 09:10 | |
*** inc0 has quit IRC | 09:13 | |
*** ericksonfgds has quit IRC | 09:20 | |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.messaging: Remove outdated release notes https://review.openstack.org/182585 | 09:21 |
*** e0ne has joined #openstack-oslo | 09:22 | |
openstackgerrit | Merged openstack/stevedore: Remove run_cross_tests.sh https://review.openstack.org/179482 | 09:22 |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.config: Remove outdated release notes https://review.openstack.org/182588 | 09:23 |
openstackgerrit | Julien Danjou proposed openstack/oslo.serialization: jsonutils: simplify simple value handling https://review.openstack.org/166866 | 09:28 |
openstackgerrit | Julien Danjou proposed openstack/oslo.serialization: jsonutils: encode dict keys https://review.openstack.org/166902 | 09:28 |
openstackgerrit | Julien Danjou proposed openstack/oslo.serialization: jsonutils: replace strtime() usage with isotime() https://review.openstack.org/166861 | 09:28 |
*** dulek has quit IRC | 09:28 | |
*** dulek has joined #openstack-oslo | 09:29 | |
*** dims has joined #openstack-oslo | 09:35 | |
*** e0ne is now known as e0ne_ | 09:36 | |
*** e0ne_ is now known as e0ne | 09:38 | |
*** inc0 has joined #openstack-oslo | 09:40 | |
*** dims has quit IRC | 09:40 | |
openstackgerrit | Julien Danjou proposed openstack/oslo.utils: timeutils: make marshall timezone aware https://review.openstack.org/182597 | 09:43 |
openstackgerrit | Julien Danjou proposed openstack/oslo.utils: timeutils: utcnow() returns a value with a timezone https://review.openstack.org/182598 | 09:43 |
openstackgerrit | Julien Danjou proposed openstack/oslo.utils: Deprecate strtime https://review.openstack.org/148500 | 09:45 |
*** inc0 has quit IRC | 09:47 | |
*** ozamiatin has quit IRC | 09:48 | |
*** inc0 has joined #openstack-oslo | 09:49 | |
haypo | jd__, hi. here is a typo in your oslo.serialization patch https://review.openstack.org/#/c/166861/ | 09:49 |
*** inc0_ has joined #openstack-oslo | 09:50 | |
jd__ | haypo: yeah I need to update it | 09:50 |
openstackgerrit | Julien Danjou proposed openstack/oslo.utils: timeutils: deprecate isotime() https://review.openstack.org/182602 | 09:51 |
*** inc0 has quit IRC | 09:53 | |
openstackgerrit | Julien Danjou proposed openstack/oslo.serialization: jsonutils: simplify simple value handling https://review.openstack.org/166866 | 09:54 |
openstackgerrit | Julien Danjou proposed openstack/oslo.serialization: jsonutils: encode dict keys https://review.openstack.org/166902 | 09:54 |
openstackgerrit | Julien Danjou proposed openstack/oslo.serialization: jsonutils: replace strtime() usage with isotime() https://review.openstack.org/166861 | 09:54 |
openstackgerrit | Julien Danjou proposed openstack/oslo.utils: Deprecate strtime https://review.openstack.org/148500 | 09:54 |
jd__ | haypo: curious on your opinion on https://review.openstack.org/#/c/182602/ | 09:54 |
haypo | jd__, did you check if timeutils is able to parse the +HH:HH format of timezones, at least for UTC? | 09:55 |
jd__ | haypo: we rely on iso8601 module to do that, so yeah it works fine | 09:56 |
haypo | >>> timeutils.parse_isotime('2015-05-13T11:56:41.879782') | 09:57 |
haypo | datetime.datetime(2015, 5, 13, 11, 56, 41, 879782, tzinfo=<iso8601.iso8601.Utc object at 0x7fb945a6d1d0>) | 09:57 |
haypo | oh, the function expects UTC timezone | 09:57 |
haypo | >>> timeutils.parse_isotime('2015-05-13T11:56:41.879782+00:00') | 09:57 |
haypo | datetime.datetime(2015, 5, 13, 11, 56, 41, 879782, tzinfo=<FixedOffset '+00:00' datetime.timedelta(0)>) | 09:57 |
haypo | but yes, it supports +HH:HH format (it works also with any other fixed offset like +01:02) | 09:58 |
haypo | jd__, oh wait, you want to deprecate isotime(), sorry i read strtime() :-p | 09:59 |
haypo | jd__, isotime() has two features: format a datetime but also get the current datetime in the UTC timezone | 10:00 |
*** dims has joined #openstack-oslo | 10:01 | |
haypo | >>> datetime.datetime.now(tz=iso8601.iso8601.UTC).isoformat() | 10:01 |
haypo | '2015-05-13T10:01:43.742092+00:00' | 10:01 |
haypo | jd__, ^^ it would be nice to have a function for this | 10:02 |
jd__ | haypo: that's timeutils.utcnow().isoformat() | 10:02 |
jd__ | haypo: with my patches obviously | 10:02 |
haypo | >>> timeutils.utcnow().isoformat() | 10:03 |
haypo | '2015-05-13T10:03:00.603834' | 10:03 |
openstackgerrit | Merged openstack/oslo.log: Add versionutils to API documentation https://review.openstack.org/167768 | 10:03 |
openstackgerrit | Merged openstack/oslo.log: Add versionutils options to list_opts https://review.openstack.org/167769 | 10:03 |
haypo | jd__, wait, i have to read your whole patch serie :) | 10:03 |
jd__ | np | 10:03 |
haypo | jd__, i don't understand the purpose of utcnow.override_time | 10:05 |
openstackgerrit | Merged openstack/oslo.log: Make remove_in=0 (no removal) use a better syntax https://review.openstack.org/168186 | 10:05 |
haypo | jd__, is it for unit tests? why not using mock.patch? | 10:05 |
openstackgerrit | Merged openstack/oslo.log: Remove is_compatible from versionutils https://review.openstack.org/170471 | 10:05 |
tchaypo | haypo: oh hai! | 10:05 |
haypo | tchaypo, hi myself, hum no, wait ;-) | 10:06 |
jd__ | haypo: that's another subject, I think that's because mock does not work in certain cases | 10:06 |
tchaypo | haypo: I look forward to us working together on something | 10:07 |
tchaypo | haypo: mostly because I’ll enjoy others being confused :) | 10:07 |
*** jamielennox is now known as jamielennox|away | 10:08 | |
haypo | jd__, sorry, new typo found in the title of your commit message /o\ https://review.openstack.org/#/c/166861/ | 10:10 |
haypo | jd__, except of that, the patch looks good to me | 10:10 |
jd__ | thanks | 10:10 |
haypo | tchaypo, ah? i'm going to eat | 10:10 |
openstackgerrit | Julien Danjou proposed openstack/oslo.serialization: jsonutils: simplify simple value handling https://review.openstack.org/166866 | 10:11 |
openstackgerrit | Julien Danjou proposed openstack/oslo.serialization: jsonutils: encode dict keys https://review.openstack.org/166902 | 10:11 |
openstackgerrit | Julien Danjou proposed openstack/oslo.serialization: jsonutils: replace strtime() usage with isoformat() https://review.openstack.org/166861 | 10:11 |
openstackgerrit | Julien Danjou proposed openstack/oslo.utils: timeutils: utcnow() returns a value with a timezone https://review.openstack.org/182598 | 10:12 |
jd__ | ETOOMANYPATCHES | 10:12 |
*** ozamiatin has joined #openstack-oslo | 10:14 | |
sileht | hum, I guess is very hard to get merged a patch in oslo.cache: https://review.openstack.org/#/admin/projects/openstack/oslo.cache,access | 10:18 |
*** ozamiatin has quit IRC | 10:19 | |
*** dulek has quit IRC | 10:19 | |
*** e0ne is now known as e0ne_ | 10:25 | |
*** wendar has quit IRC | 10:25 | |
*** gus has quit IRC | 10:25 | |
*** wendar_ has joined #openstack-oslo | 10:25 | |
*** e0ne_ is now known as e0ne | 10:26 | |
*** dulek has joined #openstack-oslo | 10:28 | |
*** jd__ has quit IRC | 10:28 | |
*** jd__ has joined #openstack-oslo | 10:32 | |
*** EmilienM has quit IRC | 10:33 | |
*** ekarlso has quit IRC | 10:33 | |
*** gus has joined #openstack-oslo | 10:33 | |
*** Steap has quit IRC | 10:34 | |
*** Steap has joined #openstack-oslo | 10:35 | |
*** EmilienM has joined #openstack-oslo | 10:35 | |
*** e0ne is now known as e0ne_ | 10:39 | |
*** e0ne_ is now known as e0ne | 10:40 | |
*** ekarlso has joined #openstack-oslo | 10:41 | |
*** ekarlso has quit IRC | 10:45 | |
*** ekarlso has joined #openstack-oslo | 10:45 | |
*** dulek has quit IRC | 10:50 | |
*** dulek has joined #openstack-oslo | 10:50 | |
*** dulek_ has joined #openstack-oslo | 10:53 | |
*** dulek_ has quit IRC | 10:53 | |
*** dulek_ has joined #openstack-oslo | 10:54 | |
*** dulek has quit IRC | 10:54 | |
*** cdent has joined #openstack-oslo | 11:13 | |
*** e0ne is now known as e0ne_ | 11:26 | |
*** salv-orlando has joined #openstack-oslo | 11:28 | |
*** salv-orlando has quit IRC | 11:37 | |
*** salv-orlando has joined #openstack-oslo | 11:43 | |
viktors | sileht: hi! | 11:48 |
*** yamahata has quit IRC | 11:48 | |
haypo | tchaypo, on which project do you want to collaborate? | 11:49 |
tchaypo | oh, nothing in particular, but it’d be funny if we did some day :) | 11:50 |
*** ozamiatin has joined #openstack-oslo | 11:52 | |
*** sdake has joined #openstack-oslo | 12:00 | |
haypo | jd__, ok, i reviewed the patch serie for oslo.serialize, +2 for all of them | 12:01 |
*** e0ne_ is now known as e0ne | 12:08 | |
openstackgerrit | Julien Danjou proposed openstack/oslo.utils: timeutils: deprecate isotime() https://review.openstack.org/182602 | 12:12 |
openstackgerrit | Julien Danjou proposed openstack/oslo.utils: Deprecate strtime https://review.openstack.org/148500 | 12:13 |
*** gordc has joined #openstack-oslo | 12:25 | |
*** sputnik13 has quit IRC | 12:29 | |
dims | sileht: filed a patch for oslo.cache - https://review.openstack.org/182645 | 12:29 |
*** amrith is now known as _amrith_ | 12:30 | |
*** dulek_ has quit IRC | 12:31 | |
*** alexpilotti has joined #openstack-oslo | 12:32 | |
haypo | jd__, ok, i also reviewed your patches for oslo.utils. there is a low risk of breaking applications if timeutils begins to create aware datetime objects. it's more a matter of warnings users and help them to fix their applications | 12:36 |
jd__ | haypo: one of the patch fails likely because it breaks Keystone | 12:37 |
jd__ | clearly this is far from being won | 12:37 |
haypo | jd__, the safe approach is to add new optional parameters or new functions | 12:37 |
haypo | jd__, but i know that you prefer to break the world to force users to enhance their code :-D | 12:38 |
haypo | i have no strong opinion on the better approach | 12:38 |
*** prad has joined #openstack-oslo | 12:39 | |
*** salv-orlando has quit IRC | 12:39 | |
*** bknudson has quit IRC | 12:40 | |
openstackgerrit | Julien Danjou proposed openstack/oslo.utils: timeutils: make marshall timezone aware https://review.openstack.org/182597 | 12:49 |
openstackgerrit | Julien Danjou proposed openstack/oslo.utils: timeutils: utcnow() returns a value with a timezone https://review.openstack.org/182598 | 12:49 |
*** kgiusti has joined #openstack-oslo | 12:51 | |
openstackgerrit | Julien Danjou proposed openstack/oslo.utils: timeutils: deprecate isotime() https://review.openstack.org/182602 | 12:53 |
openstackgerrit | Julien Danjou proposed openstack/oslo.utils: Deprecate strtime https://review.openstack.org/148500 | 12:56 |
*** nkrinner has quit IRC | 13:06 | |
*** mriedem has left #openstack-oslo | 13:10 | |
*** mriedem has joined #openstack-oslo | 13:11 | |
*** stpierre has joined #openstack-oslo | 13:20 | |
openstackgerrit | Victor Sergeyev proposed openstack/oslo.messaging: Use connection.ChannelPool in RabbitMQ driver https://review.openstack.org/182272 | 13:21 |
viktors | sileht: around? | 13:21 |
*** exploreshaifali has joined #openstack-oslo | 13:34 | |
*** sputnik13 has joined #openstack-oslo | 13:34 | |
sileht | viktors, hi | 13:36 |
*** sigmavirus24_awa is now known as sigmavirus24 | 13:37 | |
*** sdake_ has joined #openstack-oslo | 13:39 | |
viktors | sileht: firs of all, thanks for your help with remove-double-reply spec. Will you suggest the comments or I'll do it? | 13:40 |
viktors | sileht: and I found, that RabbitMQ driver spend a lot of time for creating a new channel, so I made a patch, which uses ChannelPool. | 13:41 |
viktors | sileht: Please look at it, when you'll have a time - https://review.openstack.org/182272 | 13:41 |
*** sdake has quit IRC | 13:42 | |
sileht | viktors, cool, I'm unsure about using a ChannelPool, but avoiding the recreation of a channel with this one work is a good enhancement. | 13:45 |
sileht | viktors, I don't think I can review the patch soon, I will be in holiday in a couple of hour and then I go to the summit | 13:46 |
*** links has quit IRC | 13:48 | |
viktors | sileht: ok, enjoy your holiday :) | 13:50 |
*** _amrith_ is now known as amrith | 13:50 | |
*** sdake has joined #openstack-oslo | 14:01 | |
*** Kennan has quit IRC | 14:03 | |
*** Kennan has joined #openstack-oslo | 14:03 | |
*** sdake_ has quit IRC | 14:04 | |
*** amotoki_ has joined #openstack-oslo | 14:06 | |
*** mtanino has joined #openstack-oslo | 14:07 | |
*** bknudson has joined #openstack-oslo | 14:15 | |
*** jaypipes has joined #openstack-oslo | 14:15 | |
*** jecarey has joined #openstack-oslo | 14:24 | |
*** dulek has joined #openstack-oslo | 14:26 | |
*** stevemar has joined #openstack-oslo | 14:32 | |
openstackgerrit | Victor Stinner proposed openstack/oslo.versionedobjects: Drop outdated notes and docstrings https://review.openstack.org/182698 | 14:33 |
openstackgerrit | Victor Stinner proposed openstack/oslo.versionedobjects: Enhance dict compat of VersionedObjectDictCompat https://review.openstack.org/182699 | 14:33 |
haypo | is there someone here who can review my oslo.versionedobjects patches? | 14:38 |
haypo | i don't know if this project is currently used outside nova | 14:38 |
ihrachyshka | haypo, there are plans for neutron to consume it in L | 14:38 |
haypo | ihrachyshka, ah, good to know | 14:39 |
ihrachyshka | also heat? | 14:39 |
*** tsekiyama has joined #openstack-oslo | 14:39 | |
haypo | well, my second patch is required to port nova to python 3 | 14:43 |
*** e0ne is now known as e0ne_ | 14:50 | |
*** e0ne_ is now known as e0ne | 14:52 | |
openstackgerrit | Victor Stinner proposed openstack/oslo.versionedobjects: Enhance docuemntation https://review.openstack.org/182707 | 14:53 |
dims | sigmavirus24: around? | 14:54 |
sigmavirus24 | dims: I am | 14:54 |
sigmavirus24 | I was thinking about the problem last night, there must be a client that nova's using that is using streamed requests | 14:54 |
dims | sigmavirus24: one _get_conn followed by 2 _put_conn's - http://paste.openstack.org/show/221879/ | 14:54 |
sigmavirus24 | It doesn't necessarily have to be using iter_chunked, the thing we need to be looking for is stream=True | 14:55 |
dims | sigmavirus24: from http://logs.openstack.org/95/182495/4/check/check-tempest-dsvm-multinode-full/86c885b/logs/screen-n-cpu.txt.gz | 14:55 |
sigmavirus24 | dims: interesting | 14:55 |
dims | sigmavirus24: here's how i logged those lines https://review.openstack.org/#/c/182495/4/nova/utils.py,cm | 14:55 |
sigmavirus24 | dims: I'll try to figure out why that's happening, doesn't make sense based on the added log-info | 14:59 |
dims | sigmavirus24: glanceclient/common/http.py", line 209 and glanceclient/common/http.py", line 243 both end up triggering a _put_conn essentially | 14:59 |
dims | and the 2nd one fails as the Queue size is 10 already | 15:00 |
dims | thanks sigmavirus24 | 15:01 |
sigmavirus24 | So https://github.com/shazow/urllib3/blob/d5f6cefbd90268fbf5e4c976bad933246870e572/urllib3/connectionpool.py#L270 is where that log message comes from and self.pool is a Queue.LifoQueue | 15:02 |
sigmavirus24 | https://github.com/shazow/urllib3/blob/d5f6cefbd90268fbf5e4c976bad933246870e572/urllib3/connectionpool.py#L176 (is where self.pool is initialized) | 15:02 |
*** e0ne is now known as e0ne_ | 15:02 | |
sigmavirus24 | Hm, this is interesting | 15:03 |
sigmavirus24 | That should all be correct. The question becomes, why do we call _put_conn twice with the same HTTPConnection | 15:03 |
openstackgerrit | Julien Danjou proposed openstack/oslo.utils: timeutils: make marshall timezone aware https://review.openstack.org/182597 | 15:05 |
openstackgerrit | Julien Danjou proposed openstack/oslo.utils: timeutils: utcnow() returns a value with a timezone https://review.openstack.org/182598 | 15:05 |
openstackgerrit | Julien Danjou proposed openstack/oslo.utils: Deprecate strtime https://review.openstack.org/148500 | 15:07 |
viktors | haypo: around? | 15:12 |
haypo | viktors, yes | 15:12 |
viktors | haypo: just a curiosity - are you sure, that DB tests were not skipped on patch https://review.openstack.org/#/c/182709 ? | 15:12 |
haypo | viktors, no, i'm not sure | 15:13 |
openstackgerrit | Julien Danjou proposed openstack/oslo.utils: timeutils: deprecate isotime() https://review.openstack.org/182602 | 15:13 |
viktors | haypo: ok, will wait for Jenkins :) | 15:13 |
haypo | viktors, i didn't run tests locally, i don't think that i have the right setup to run tests, and i'm very confident in my change :-D | 15:14 |
viktors | :-D | 15:14 |
haypo | viktors, it doesn't look possible to make a choice between mysql-python, mysqlclient and pymysql; this patch is a quick change to unblock my work on python 3 | 15:15 |
haypo | viktors, i guess that tempest will continue to use mysql-python, my change is specific to nova unit & functional tests | 15:15 |
*** dims has quit IRC | 15:15 | |
viktors | haypo: in Ironic I've made a such thing - https://github.com/openstack/ironic/blob/master/tox.ini#L26-L34 | 15:16 |
viktors | haypo: I think, it's can be a good addition to your patch | 15:16 |
*** dims has joined #openstack-oslo | 15:16 | |
haypo | viktors, i hesitate to split test-requirements.txt. i see that you chose to split | 15:17 |
*** ozamiatin has quit IRC | 15:18 | |
haypo | viktors, i don't know OS_TEST_DBAPI_ADMIN_CONNECTION. how is it used? see my nova patch, i saw hardcoded "mysql://..." URLs in the code | 15:18 |
viktors | haypo: it used for functional DB tests only to replace default DB connection strings | 15:19 |
*** salv-orlando has joined #openstack-oslo | 15:22 | |
openstackgerrit | Victor Sergeyev proposed openstack/oslo.messaging: Use connection.ChannelPool in RabbitMQ driver https://review.openstack.org/182272 | 15:27 |
*** sdake has quit IRC | 15:30 | |
*** sdake has joined #openstack-oslo | 15:31 | |
jd__ | haypo: you have a penchant to comment things that do not need comments in reviews which is very disturbing | 15:32 |
haypo | jd__, right :) | 15:32 |
haypo | jd__, sorry for distrubing you :-p | 15:32 |
*** yamahata has joined #openstack-oslo | 15:33 | |
jd__ | haypo: no problem, thanks for your help anyway | 15:34 |
mriedem | dhellmann: gordc: dims: looks like we need a 0.6.1 release of pycadf on stable/juno | 15:34 |
mriedem | oslo.messaging is uncapped on pycadf 0.6.0 which is breaking keystonemiddleware on stable/juno which is breaking glance | 15:34 |
jd__ | I really wonder sometimes how we ended up with so much crap in Oslo but well | 15:34 |
mriedem | pycadf stable/juno has a cap https://github.com/openstack/pycadf/commit/002953f683b0eb441a926c179c550ab3895f8683 | 15:34 |
mriedem | just need to release that bad boy | 15:34 |
*** browne has joined #openstack-oslo | 15:34 | |
gordc | mriedem: hmm. i thought i had release 0.6.1 last week | 15:35 |
mriedem | hrm, looks like that's actually already in a 0.6.1 pycadf | 15:35 |
mriedem | yeah there is | 15:35 |
*** yamahata has quit IRC | 15:36 | |
gordc | mriedem: ... i have a feeling i released it when the gate was broken... i guess it didn't publish to pypi | 15:36 |
*** yamahata has joined #openstack-oslo | 15:36 | |
*** mriedem has left #openstack-oslo | 15:36 | |
*** zqfan_afk has quit IRC | 15:37 | |
*** mriedem has joined #openstack-oslo | 15:37 | |
gordc | mriedem: i will try to manually copy over tarballs over to pypi | 15:37 |
*** exploreshaifali has quit IRC | 15:37 | |
dims | gordc: you may want to ask infra folks too on how they would recommend to copy things over | 15:38 |
gordc | dims: i was just going to say... i don't know how safe it is for me to manually do that or if i should push an identical 0.6.2. | 15:38 |
gordc | i'll check with infra | 15:38 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/stevedore: Fix Python versions supported https://review.openstack.org/181524 | 15:39 |
*** salv-orlando has quit IRC | 15:41 | |
*** e0ne_ is now known as e0ne | 15:43 | |
*** kgiusti has quit IRC | 15:47 | |
*** shakamunyi has quit IRC | 15:51 | |
*** barra204 has quit IRC | 15:51 | |
*** ashleighfarnham has joined #openstack-oslo | 15:58 | |
*** viktors is now known as viktors|afk | 15:59 | |
*** vilobhmm1 has joined #openstack-oslo | 16:00 | |
*** amrith is now known as _amrith_ | 16:02 | |
openstackgerrit | Victor Stinner proposed openstack/oslo.versionedobjects: Enhance documentation https://review.openstack.org/182707 | 16:02 |
*** ashleighfarnham has quit IRC | 16:06 | |
*** dulek has quit IRC | 16:08 | |
*** ashleighfarnham has joined #openstack-oslo | 16:20 | |
*** ashleighfarnham has quit IRC | 16:21 | |
*** ashleighfarnham has joined #openstack-oslo | 16:22 | |
*** vilobhmm1 has quit IRC | 16:25 | |
*** haypo has quit IRC | 16:32 | |
*** kgiusti has joined #openstack-oslo | 16:34 | |
*** ihrachyshka has quit IRC | 16:34 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/stevedore: Updated from global requirements https://review.openstack.org/179877 | 16:39 |
*** arnaud____ has joined #openstack-oslo | 16:43 | |
*** inc0_ has quit IRC | 16:43 | |
*** prad has quit IRC | 16:44 | |
*** prad has joined #openstack-oslo | 16:44 | |
*** amotoki_ has quit IRC | 16:46 | |
*** arnaud____ has quit IRC | 16:49 | |
*** browne has quit IRC | 16:51 | |
*** vilobhmm1 has joined #openstack-oslo | 16:59 | |
*** sdake has quit IRC | 17:00 | |
*** zzzeek has joined #openstack-oslo | 17:06 | |
*** achanda has joined #openstack-oslo | 17:14 | |
*** _amrith_ is now known as amrith | 17:16 | |
*** vilobhmm1 has quit IRC | 17:18 | |
*** vilobhmm1 has joined #openstack-oslo | 17:19 | |
*** harlowja has quit IRC | 17:20 | |
*** harlowja has joined #openstack-oslo | 17:20 | |
harlowja | samueldmq fyi, https://review.openstack.org/#/c/182445 if u want to comment on that to; i'm not exactly sure how that works yet (seems pretty preliminary/drafting) | 17:22 |
samueldmq | harlowja, k will take a look later thanks | 17:23 |
harlowja | cool | 17:24 |
harlowja | jd__ maybe that marshall time stuff should be shared between oslo.serialization and oslo.utils | 17:29 |
harlowja | i think the code is the same now :-P | 17:29 |
*** cdent has quit IRC | 17:30 | |
*** salv-orlando has joined #openstack-oslo | 17:30 | |
*** rrepaka123 has joined #openstack-oslo | 17:32 | |
*** browne has joined #openstack-oslo | 17:33 | |
*** yamahata has quit IRC | 17:40 | |
*** alexpilotti has quit IRC | 17:41 | |
*** salv-orlando has quit IRC | 17:44 | |
rrepaka123 | llifeless:Hi Ping me if you need any additional info from me, yesterday i got pulled into other things, so didnt login to IRC. | 17:45 |
*** e0ne is now known as e0ne_ | 18:00 | |
*** e0ne_ is now known as e0ne | 18:04 | |
*** yamahata has joined #openstack-oslo | 18:05 | |
*** e0ne has quit IRC | 18:06 | |
*** ajo has quit IRC | 18:10 | |
openstackgerrit | Merged openstack/oslo.vmware: Add ToolsUnavailable exception https://review.openstack.org/182527 | 18:21 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Remove customized pyX.Y tox requirements https://review.openstack.org/182423 | 18:23 |
gordc | mriedem: we need a stable/icehouse for pycadf i think | 18:40 |
mriedem | oh no | 18:40 |
gordc | the juno grenade test is broken because of new pycadf | 18:40 |
mriedem | oh fun | 18:40 |
gordc | it looks like new pycadf needs pytz<=2014.10 but pycadf 0.5.1 (which icehouse uses) has pytz>=2010h | 18:40 |
mriedem | https://github.com/openstack/requirements/blob/stable/icehouse/global-requirements.txt#L95 | 18:41 |
mriedem | pytz>=2010h,<=2015.2 | 18:41 |
mriedem | specifically right? | 18:41 |
lifeless | rrepaka123: hi sorry, wehad a gate wedge ysterdday and I had to pop into a (routine followup) with a doctor in the city, chewed up my day after the early rush of meetings | 18:41 |
lifeless | rrepaka123: I will look at the pastebins shortly | 18:41 |
gordc | mriedem: yeah... but i pycadf doesn't have an icehouse requirements sync.. so it just has whatever it was at the time (no upper cap) | 18:42 |
gordc | mriedem: that's weird that icehouse has a later cap than juno | 18:42 |
mriedem | gordc: yeah, was thinking the same | 18:42 |
mriedem | gordc: maybe that's the problem | 18:43 |
gordc | mriedem: i guess i can cut a 0.5.2 release (without creating a stable/branch | 18:43 |
rrepaka123 | lifeless: No problem just check before i vanish for next few days | 18:44 |
gordc | mriedem: maybe i'll just create a 0.5.2 release with appropriate requirements. | 18:44 |
gordc | mriedem: but yeah, i think that weird cap diff is going to be an issue. | 18:44 |
*** e0ne has joined #openstack-oslo | 18:45 | |
*** jaosorior has quit IRC | 18:52 | |
dims | stevemar: wanna do this in liberty? https://review.openstack.org/#/c/170685/ | 18:58 |
stevemar | dims, if you guys think it's worth it, yes | 19:00 |
dims | stevemar: y please switch that from kilo to liberty and we can vote on it | 19:00 |
openstackgerrit | Merged openstack/oslo-specs: Add an adopt futurist spec https://review.openstack.org/179890 | 19:02 |
harlowja | merged | 19:02 |
harlowja | begin the fun | 19:02 |
* harlowja starting rocket-engine | 19:02 | |
*** exploreshaifali has joined #openstack-oslo | 19:05 | |
*** sdake has joined #openstack-oslo | 19:06 | |
openstackgerrit | Merged openstack/taskflow: Remove custom py26/py27 tox venvs no longer used https://review.openstack.org/182512 | 19:06 |
openstackgerrit | Merged openstack/oslotest: Do not sync run_cross_tests.sh https://review.openstack.org/180281 | 19:08 |
mriedem | i said this in -qa this morning half jokingly, but could some of our requirements nightmares be solved with a single large oslo library? | 19:11 |
mriedem | so we do less cat herding? | 19:11 |
*** Rockyg_ has joined #openstack-oslo | 19:12 | |
dhellmann | mriedem: that would significantly limit the usefulness of some of the libraries | 19:13 |
harlowja | mriedem dhellmann said that was considered once :-P | 19:13 |
harlowja | make oslo-incubator.zip | 19:14 |
dhellmann | mriedem: we're going to be sitting down next week to think through some of these requirements changes, so I expect some fixes in the week or two after the summit | 19:14 |
harlowja | but it really does do what dhellmann says, makes it basically a u take it all or u take nothing, even if u only use 1 little function from it | 19:14 |
dhellmann | some of those will likely involve breaking semver in the stable branches to cap requirements there, but we don't want to just do that without thinking it through | 19:14 |
mriedem | dhellmann: i was trying to find the session link to add to my schedule but wasn't sure which one it was | 19:15 |
*** exploreshaifali has quit IRC | 19:16 | |
*** amrith is now known as _amrith_ | 19:17 | |
gordc | dhellmann: just a headsup, i think i neeed you to create a stable/icehouse branch for pycadf.... pytz issue above ^^ | 19:18 |
dhellmann | mriedem: I think ttx plans to discuss it in the release working session friday | 19:23 |
harlowja | anyone know how to connect https://launchpad.net/futurist into the oslo project listing @ https://launchpad.net/oslo | 19:26 |
harlowja | i see no add my project to link | 19:26 |
harlowja | maybe someone knows the magic incantation | 19:27 |
dhellmann | dims, harlowja : https://twitter.com/doughellmann/status/598568921306923008 | 19:27 |
dhellmann | harlowja: let me find the page where you set that, hang on | 19:27 |
harlowja | sweet hotnesss dhellmann | 19:27 |
harlowja | thx launchpad is weird, lol | 19:28 |
dhellmann | harlowja: https://launchpad.net/futurist/+edit and in the "part of" field put "oslo" (no quotes) | 19:28 |
harlowja | k | 19:28 |
harlowja | hmm well thats weird | 19:28 |
harlowja | 'Not allowed here' | 19:28 |
harlowja | so dhellmann maybe u can do that :P | 19:28 |
harlowja | 'Sorry, you don't have permission to access this page or the information in this page is not shared with you. ' | 19:28 |
harlowja | lol | 19:28 |
dhellmann | harlowja: hmm | 19:28 |
dims | dhellmann: looks good! | 19:28 |
harlowja | 'Not allowed here | 19:28 |
harlowja | Sorry, you don't have permission to access this page or the information in this page is not shared with you. | 19:28 |
harlowja | You are logged in as Joshua Harlow. | 19:28 |
harlowja | ' | 19:28 |
harlowja | :-/ | 19:28 |
harlowja | sadface | 19:28 |
dhellmann | harlowja: ah, you may not be in the drivers group | 19:28 |
harlowja | lol | 19:28 |
harlowja | ah | 19:29 |
harlowja | maybe | 19:29 |
harlowja | should i be? (maybe sileht to? | 19:29 |
dhellmann | probably? | 19:29 |
harlowja | lol | 19:29 |
dhellmann | sileht is | 19:29 |
dhellmann | let me see about adding you | 19:29 |
dhellmann | done | 19:29 |
harlowja | sweet | 19:29 |
harlowja | i'm now offically cool | 19:29 |
harlowja | so who's gonna be the first to get the oslo moose tattoo? | 19:30 |
dhellmann | harlowja: it would be good if you updated the "driver" field on futurist to refer to the oslo drivers team now | 19:30 |
harlowja | jd__ ? | 19:30 |
harlowja | k | 19:30 |
harlowja | done | 19:30 |
dhellmann | no tats for me, but you go for it :-) | 19:30 |
harlowja | lol | 19:31 |
harlowja | next time, http://www.temporarytattoo.in/water-based-tattoos.html | 19:32 |
harlowja | lol | 19:32 |
*** e0ne has quit IRC | 19:32 | |
dims | so i count futurist, automaton, oslo.cache, oslo.io and oslo.service so far... | 19:32 |
dims | anything else? | 19:32 |
harlowja | have we adopted sqlalchemy yet | 19:32 |
harlowja | :-P | 19:32 |
* harlowja runs away | 19:33 | |
dims | haha | 19:33 |
dhellmann | dims: reports, maybe? | 19:33 |
* dims labels harlowja as "primary instigator of libraries" | 19:33 | |
dims | ah. right dhellmann | 19:33 |
harlowja | :-/ | 19:33 |
*** e0ne has joined #openstack-oslo | 19:33 | |
harlowja | primary awesome-person u mean | 19:33 |
dims | :) | 19:34 |
*** frickler has quit IRC | 19:36 | |
*** nkrinner has joined #openstack-oslo | 19:36 | |
harlowja | ok, https://review.openstack.org/182803 dims | 19:39 |
harlowja | copy/pasted the work items from a previous run of this @ https://blueprints.launchpad.net/oslo.utils/+spec/adopt-futurist (adjusting that as this goes) | 19:39 |
dims | funny, i can't even +1 that review | 19:40 |
harlowja | :-/ | 19:41 |
harlowja | that repo is weird | 19:41 |
harlowja | lol | 19:41 |
harlowja | governance by the-one-true-dicator only, lol | 19:41 |
harlowja | no comments allowed, lol | 19:41 |
harlowja | feedback and u go to prison | 19:41 |
harlowja | lol | 19:41 |
dims | comments are ok i guess. just don't vote | 19:41 |
harlowja | no pass go | 19:41 |
harlowja | dims agreed with u, its odd that u can't do much of anything there | 19:42 |
harlowja | democracy fail, lol | 19:43 |
lifeless | WALL OF TEXT | 19:43 |
*** e0ne has quit IRC | 19:43 | |
mriedem | gordc: is this the stable/icehouse pycadf thing you were talking about? | 19:44 |
mriedem | http://logs.openstack.org/55/182755/1/check/check-grenade-dsvm/1f665f1/logs/grenade.sh.txt.gz#_2015-05-13_18_34_16_156 | 19:44 |
*** stevemar has quit IRC | 19:44 | |
openstackgerrit | Merged openstack/oslo.utils: Move versionutils into place and remove deprecation tools https://review.openstack.org/170469 | 19:49 |
openstackgerrit | Merged openstack/oslo.vmware: Add support for dynamicProperty https://review.openstack.org/182398 | 19:49 |
*** arnaud____ has joined #openstack-oslo | 19:50 | |
openstackgerrit | Merged openstack/oslo.messaging: rabbit: redeclare consumers when ack/requeue fail https://review.openstack.org/180059 | 19:50 |
mriedem | gordc: i'm kind of thinking pytz shouldn't be capped in g-r | 19:51 |
mriedem | it doesn't require anything else so it's not a transitive dependency risk | 19:51 |
gordc | mriedem: yep. that's the issue. | 19:52 |
mtreinish | mriedem: well unless they break things | 19:52 |
mriedem | blarg | 19:52 |
mriedem | mtreinish: pytz is a pretty tiny thing | 19:52 |
mtreinish | if pytz breaks an api that's consumed it could cause issues | 19:52 |
mtreinish | mriedem: yeah I know, I'm just saying | 19:52 |
mriedem | there are other things that are uncapped in g-r | 19:53 |
mtreinish | and at least in recent months backwards incompatible changes have not been a common failure on stable | 19:53 |
mtreinish | the most recent is probably boto | 19:53 |
dhellmann | gordc: which hash should I use to create the branch? | 19:54 |
openstackgerrit | Merged openstack/oslo.messaging: rabbit: smarter declaration of the notif. queue https://review.openstack.org/179270 | 19:54 |
*** arnaud____ has quit IRC | 19:55 | |
dhellmann | mtreinish, mriedem : is pytz the thing that gives us the timezone database? | 19:55 |
mtreinish | dhellmann: yep | 19:55 |
dhellmann | mtreinish: ok, capping that would be bad -- that db changes way more often than you'd think | 19:55 |
dhellmann | it turns out when you have political constructs like dst, politicians feel free to change them | 19:56 |
gordc | dhellmann: if we don't uncap pytz, we'll need a stable/icehouse branch on https://github.com/openstack/pycadf/commit/d68002f9fb714e1897662fc4e89f261a9b8aacaa | 19:56 |
mriedem | here https://review.openstack.org/#/c/182755/ | 19:57 |
gordc | 0.5.1 is the last pycadf release before juno requirements | 19:57 |
mriedem | i updated that | 19:57 |
mtreinish | dhellmann: sure | 19:57 |
dhellmann | gordc: we can do both, it shouldn't be capped, imo | 19:57 |
mriedem | https://review.openstack.org/#/c/182755/ uncaps pytz on stable/juno in g-r | 19:57 |
mriedem | i will push a separate change to g-r stable/icehouse to uncap there | 19:57 |
dhellmann | mriedem: +2a | 19:58 |
*** Rockyg_ has quit IRC | 19:59 | |
*** e0ne has joined #openstack-oslo | 19:59 | |
gordc | there's a pep8 comment in regards to pytz in master: https://github.com/openstack/requirements/blob/master/global-requirements.txt#L142-L143 | 20:00 |
gordc | do we need to enforce a minimum? | 20:00 |
mriedem | umm | 20:00 |
mriedem | only if we care about pep 440 | 20:00 |
harlowja | ok, main one up @ https://review.openstack.org/#/c/182808/ | 20:01 |
harlowja | will wait for rest of work items until that goes in | 20:01 |
*** Rockyg has joined #openstack-oslo | 20:01 | |
gordc | mriedem: i don't know why it's there to be honest? didn't know other libs can cause pep failures. | 20:01 |
openstackgerrit | Merged openstack/oslo.log: fix pep8 errors https://review.openstack.org/173572 | 20:01 |
openstackgerrit | Merged openstack/oslo.log: Provide an API to let tempest control the log file https://review.openstack.org/173573 | 20:01 |
dhellmann | gordc: so, create stable/icehouse for pycadf from 0.5.1? | 20:01 |
harlowja | sileht https://review.openstack.org/#/c/182808/ for u to | 20:02 |
gordc | dhellmann: yes please. | 20:02 |
mriedem | gordc: pytz is 2015.2 on icehouse changes that i see so pep440 must not be a problem | 20:03 |
dhellmann | gordc: https://review.openstack.org/#/c/182816/ | 20:05 |
dhellmann | gordc: branch created | 20:05 |
gordc | mriedem: cool cool. need to pull in that update to pycadf for 0.6.3 release anyways so we can verify there. | 20:05 |
openstackgerrit | Merged openstack/oslo.utils: Remove run_cross_tests.sh https://review.openstack.org/179480 | 20:05 |
openstackgerrit | Merged openstack/oslo.utils: Denote monotonic import ordering + usage https://review.openstack.org/175218 | 20:05 |
openstackgerrit | Merged openstack/oslo.i18n: Remove run_cross_tests.sh https://review.openstack.org/179474 | 20:05 |
gordc | dhellmann: cool +2a... thanks! | 20:06 |
openstackgerrit | Merged openstack/oslo.utils: Add exception_to_unicode() function https://review.openstack.org/163507 | 20:07 |
openstackgerrit | Merged openstack/oslo.rootwrap: Remove run_cross_tests.sh https://review.openstack.org/179477 | 20:08 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.messaging: Remove stale copy of context.py https://review.openstack.org/182822 | 20:11 |
*** haypo has joined #openstack-oslo | 20:21 | |
openstackgerrit | Victor Stinner proposed openstack/oslo.versionedobjects: Enhance dict compat of VersionedObjectDictCompat https://review.openstack.org/182699 | 20:23 |
*** jecarey has quit IRC | 20:24 | |
*** jecarey has joined #openstack-oslo | 20:40 | |
*** _amrith_ is now known as amrith | 20:40 | |
gordc | mriedem: i think you need to change https://review.openstack.org/#/c/182755/2/global-requirements.txt to say pycadf>=0.6.0,!=0.6.2,<0.7.0 | 20:44 |
*** ajo has joined #openstack-oslo | 20:47 | |
*** achanda has quit IRC | 20:48 | |
mriedem | b/c pycadf has capped pytz | 20:50 |
gordc | yeah...or at least 0.6.2 does | 20:50 |
mriedem | right | 20:50 |
mriedem | god, who's idea was it to release that anyway | 20:51 |
*** nkrinner has quit IRC | 20:51 | |
gordc | ... /me walks away. | 20:52 |
mriedem | i'll remove the note in the requirements file too | 20:53 |
haypo | jaypipes, thanks for your support for if in the class body ;) https://review.openstack.org/#/c/182699/ | 20:53 |
mriedem | since it doesn't really apply if we blacklist pycadf 0.6.2 | 20:53 |
gordc | mriedem: cool cool | 20:54 |
jaypipes | haypo: hey now... I didn't say I loved it, just that I didn't hate it :) I still need to do a review on that... | 20:54 |
haypo | jaypipes, ah ok, but thanks ;) | 20:58 |
jaypipes | haypo: done | 20:59 |
haypo | jaypipes, cool :) i didn't know oslo.versionedobjects, so i checked the doc, but the doc is... empty! i wrote a patch to add a little bit more doc; ) https://review.openstack.org/#/c/182707/ | 21:00 |
haypo | jaypipes, for nova, i will need the patch for dict api. would it be possible to schedule a release and later depend on it in nova? | 21:01 |
haypo | i heard that heat and neutron may use this library, cool | 21:02 |
dansmith | haypo: why do you need a release immediately? | 21:04 |
*** isq_ has joined #openstack-oslo | 21:04 | |
*** sreshetn1ak has joined #openstack-oslo | 21:05 | |
haypo | dansmith, i'm not sure that a release is needed. i'm asking to be able to replace dict(obj.iteritems()) with dict(obj) in nova | 21:05 |
dansmith | oh | 21:05 |
*** viktors has joined #openstack-oslo | 21:06 | |
dansmith | I guess I did just land the bit to make us use this dict layer didn't I? | 21:06 |
* dansmith completely forgot | 21:06 | |
dansmith | haypo: I'd like to delay a bit if possible because I need to make another round of conversions in nova and I'd like to hold off in case there is anything else I need to bring over | 21:06 |
*** mriedem has quit IRC | 21:06 | |
dansmith | haypo: can you get around it by just adding __iter__ to the nova class maybe? | 21:07 |
haypo | dansmith, my patch "Replace dict.iteritems() with six.iteritems(dict)" is not required right now. it's just a huge cleanup to start on a fresh base to start porting nova | 21:08 |
haypo | dansmith, i mean, smaller patches replacing dict.iteritems() can be written if it's really needed | 21:08 |
*** shardy has quit IRC | 21:08 | |
haypo | dansmith, "can you get around it by just adding __iter__ to the nova class maybe?" yeah, that's a compromise. i have to investigate this option | 21:09 |
dansmith | okay | 21:09 |
dansmith | there is that indirection bit still in nova at this point | 21:09 |
dansmith | so you should be able to hide it in there I think | 21:09 |
*** rakhmerov has quit IRC | 21:09 | |
*** sreshetnyak has quit IRC | 21:09 | |
*** amaurymedeiros has quit IRC | 21:09 | |
*** ekarlso has quit IRC | 21:09 | |
*** bogdando has quit IRC | 21:09 | |
*** viktors|afk has quit IRC | 21:09 | |
*** larsks has quit IRC | 21:09 | |
*** Kennan has quit IRC | 21:09 | |
*** samueldmq has quit IRC | 21:09 | |
*** isq has quit IRC | 21:09 | |
*** isq_ has quit IRC | 21:09 | |
*** isq_ has joined #openstack-oslo | 21:09 | |
*** bogdando has joined #openstack-oslo | 21:09 | |
*** amaurymedeiros has joined #openstack-oslo | 21:10 | |
*** samueldmq has joined #openstack-oslo | 21:10 | |
*** amaurymedeiros has quit IRC | 21:10 | |
*** amaurymedeiros has joined #openstack-oslo | 21:10 | |
*** ekarlso has joined #openstack-oslo | 21:10 | |
*** Kennan has joined #openstack-oslo | 21:10 | |
*** rakhmerov has joined #openstack-oslo | 21:10 | |
*** larsks has joined #openstack-oslo | 21:11 | |
*** achanda has joined #openstack-oslo | 21:11 | |
*** vilobhmm11 has joined #openstack-oslo | 21:20 | |
*** vilobhmm12 has joined #openstack-oslo | 21:21 | |
*** vilobhmm11 has quit IRC | 21:21 | |
*** kgiusti has quit IRC | 21:22 | |
*** vilobhmm11 has joined #openstack-oslo | 21:22 | |
*** vilobhmm1 has quit IRC | 21:23 | |
*** vilobhmm1 has joined #openstack-oslo | 21:24 | |
*** mriedem has joined #openstack-oslo | 21:25 | |
*** vilobhmm12 has quit IRC | 21:26 | |
*** vilobhmm11 has quit IRC | 21:27 | |
mriedem | gordc: https://review.openstack.org/#/c/182858/ | 21:32 |
gordc | mriedem: done | 21:33 |
lifeless | tchaypo: ok so lets get this patch landed today | 21:41 |
harlowja | haypo i really loved http://docs-draft.openstack.org/07/182707/2/check/gate-oslo.versionedobjects-docs/f3573e9//doc/build/html/usage.html | 21:41 |
harlowja | lol | 21:41 |
*** stpierre has quit IRC | 21:41 | |
tchaypo | well, ready to land at least | 21:41 |
tchaypo | landing requires more +2s than I can deliver | 21:41 |
haypo | harlowja, best doc ever | 21:41 |
tchaypo | maybe you can help with that bit :) | 21:42 |
harlowja | :) | 21:42 |
harlowja | someday i wonder about how we can use http://marshmallow.readthedocs.org/en/latest/ in oslo.versionedobjects (maybe there is overlap there we can take advantage of) idk | 21:42 |
harlowja | that has a nice marshmallow logo | 21:43 |
harlowja | lol | 21:43 |
lifeless | tchaypo: once its ready I can shop it around | 21:44 |
lifeless | tchaypo: did you push again last night? | 21:44 |
bknudson | it generates json so we could use something like marshmallow all over the place | 21:45 |
harlowja | cool | 21:47 |
harlowja | something to ponder on | 21:47 |
*** ho has joined #openstack-oslo | 21:47 | |
harlowja | the marshmallow folks i didn't think wanted versioning in it | 21:47 |
harlowja | so maybe thats what oslo.versionedobjects adds | 21:47 |
harlowja | i asked some time ago to the marshmallow folks | 21:47 |
bknudson | this would clean up the keystone code quite a bit | 21:48 |
harlowja | https://github.com/marshmallow-code/marshmallow/issues/171 | 21:48 |
harlowja | ^ no thx to versions (at least a couple months ago) | 21:48 |
bknudson | but it seems like other projects are using pecan or something laready | 21:48 |
harlowja | maybe they could be 'convinced' though | 21:48 |
* harlowja didn't push hard (at all) | 21:48 | |
bknudson | "Object versioning is outside of marshmallow's scope" -- ouch! | 21:49 |
harlowja | ya, i didn't push harder, haha | 21:49 |
harlowja | someone else could try | 21:49 |
harlowja | maybe that guy was in a bad mood :-P | 21:49 |
bknudson | kind of kills it for any project that plans to be around for a while | 21:49 |
tchaypo | lifeless: no; I did more work but haven’t pushed it yet | 21:49 |
ho | hello, is it possible to check my email "[openstack-dev] [oslo.policy] service_roles checks in oslo.policy" ? | 21:50 |
tchaypo | let me push it up; aside from docs, I think it completes the extras | 21:50 |
harlowja | bknudson i'm thinking maybe just need to dive deeper, or find that guy on IRC if we really wanted to go farther here... | 21:50 |
harlowja | i'm guessing it could be figured out (or maybe thats what oslo.versionedobjects add, the versioning part) | 21:50 |
bknudson | how similar is nova objects to marshmallow? | 21:50 |
harlowja | anyways, just idears | 21:50 |
bknudson | it's got a schema and serializing? | 21:50 |
haypo | harlowja, it has a logo but also a doc :) | 21:50 |
harlowja | from a high level, it looks similar | 21:51 |
harlowja | but i'm not an expert on either | 21:51 |
harlowja | haypo it has a marshmallow man logo | 21:51 |
harlowja | lol | 21:51 |
tchaypo | git review is running. lately it’s been taking ~4 minutes to push up | 21:51 |
bknudson | maybe that part could be split out of nova.objects | 21:51 |
harlowja | marshmallow face | 21:51 |
haypo | harlowja, there is maybe a unicode character for marshmallow | 21:52 |
openstackgerrit | Merged openstack/oslo.versionedobjects: Drop outdated notes and docstrings https://review.openstack.org/182698 | 21:52 |
harlowja | my guess is there has to be, lol | 21:52 |
harlowja | all sorta of weird crap in unicode | 21:52 |
harlowja | lol | 21:52 |
harlowja | including literally a poo symbol | 21:52 |
harlowja | http://www.fileformat.info/info/unicode/char/1f4a9/index.htm | 21:52 |
harlowja | lol | 21:52 |
openstackgerrit | James Polley proposed openstack-dev/pbr: WIP: Teach pbr to read extras from setup.cfg https://review.openstack.org/181795 | 21:53 |
harlowja | bknudson it'd be an intersting investigation, use marshmallow (with docs) and if they don't want versioning support, we'll we add that ontop of it (or convince them to add it) | 21:54 |
harlowja | but i'm more of just theorizing :-P | 21:54 |
openstackgerrit | Merged openstack/oslo.versionedobjects: Enhance dict compat of VersionedObjectDictCompat https://review.openstack.org/182699 | 21:55 |
bknudson | 💩 | 21:55 |
haypo | cool, my first contribution to olso.versionedobjects was merged: drop doc, haha | 21:55 |
bknudson | did that work? | 21:55 |
harlowja | yp | 21:55 |
harlowja | yup | 21:55 |
harlowja | i see poo | 21:55 |
harlowja | lol | 21:55 |
harlowja | poo happy face | 21:56 |
harlowja | lol | 21:56 |
bknudson | all I see is 01F4A9 :( | 21:56 |
harlowja | oh | 21:56 |
tchaypo | lifeless: I think I’m missing a step here. your comment mentions requirements.txt but I can’t find where util.py touches requirements.txt at all | 21:56 |
harlowja | are u using a client in a terminal without unicode font support (or with crappy unicode font support) | 21:56 |
bknudson | pidgin. | 21:57 |
bknudson | I wonder what makes poo happy. | 21:57 |
tchaypo | it looks like that parsing happens in packaging | 21:58 |
*** ajo has quit IRC | 21:58 | |
*** mriedem is now known as mriedem_away | 21:58 | |
harlowja | bknudson hmmm, odd, u'd think it'd work (on mac os x shows a poo sign) | 21:59 |
bknudson | start leaving comments like -1 💩 | 21:59 |
harlowja | lol | 21:59 |
harlowja | or other fun ones @ http://www.fileformat.info/info/unicode/block/miscellaneous_symbols_and_pictographs/utf8test.htm | 21:59 |
lifeless | tchaypo: parse_requirements is the direct parser; it may need touching | 22:00 |
lifeless | tchaypo: that reflects into requires_dist in the config in MetadataConfig | 22:00 |
bknudson | I need a new computer to see those symbols | 22:00 |
lifeless | (see hooks/metadata) | 22:00 |
harlowja | bknudson or an updated font package maybe? | 22:00 |
lifeless | tchaypo: which you then see as install_requires in the function you're accessing (see line 113 of util.py | 22:01 |
harlowja | jaypipes dansmith do u know if anyone has looked at the overlap between oslo versioned objects and marshmallow.readthedocs.org/ (and perhaps someway the oslo versioned objects could use the work being done in marshmallow, a cooperative partnership if u will) | 22:02 |
* tchaypo notices that the first line of cfg_to_args is a comment saying that the method source code starts here | 22:04 | |
* tchaypo imagines there used to be unimportant code before the comment | 22:04 | |
bknudson | pecan has its own model / serializer - https://pecan.readthedocs.org/en/latest/jsonify.html | 22:05 |
lifeless | tchaypo: so my comment stands, you should be able to work just within that metod | 22:06 |
bknudson | tie the sqlalchemy model to the json model and keystone would be about 5 lines of code | 22:06 |
lifeless | tchaypo: but - shove pdb in there, run setup.py egg_info locally, and you can see | 22:06 |
lifeless | tchaypo: easy :) | 22:06 |
*** gordc has quit IRC | 22:06 | |
harlowja | hmmm, bknudson but thats another weird tying, something like marshmallow (which all it does is that stuff) seems more appropriate than using one in a web framework | 22:06 |
harlowja | i mean i understand why pecan has one, just doesn't seem ideal | 22:06 |
bknudson | looks like there's alternatives to marshmallow but they're all tied to web frameworks like pecan.jsonify -- http://marshmallow.readthedocs.org/en/latest/why.html#why | 22:10 |
harlowja | ah, good link there | 22:11 |
harlowja | guess thats why it was created :-P | 22:11 |
harlowja | (or one of the reasons it was) | 22:11 |
harlowja | less 💩 | 22:12 |
bknudson | gross! | 22:13 |
*** achanda has quit IRC | 22:13 | |
*** salv-orlando has joined #openstack-oslo | 22:15 | |
*** salv-orlando has quit IRC | 22:15 | |
*** jecarey has quit IRC | 22:16 | |
*** vilobhmm1 has quit IRC | 22:16 | |
*** zzzeek has quit IRC | 22:17 | |
*** vilobhmm1 has joined #openstack-oslo | 22:17 | |
*** jamielennox|away is now known as jamielennox | 22:19 | |
*** bknudson has quit IRC | 22:20 | |
tchaypo | lifeless: yep, i see the hooks now | 22:22 |
*** e0ne has quit IRC | 22:28 | |
*** Rockyg has quit IRC | 22:33 | |
*** ekarlso has quit IRC | 22:34 | |
*** ekarlso has joined #openstack-oslo | 22:34 | |
*** ozamiatin has joined #openstack-oslo | 22:37 | |
lifeless | tchaypo: excellent | 22:37 |
*** ashleighfarnham has quit IRC | 22:39 | |
*** ashleighfarnham has joined #openstack-oslo | 22:39 | |
*** dims_ has joined #openstack-oslo | 22:40 | |
*** achanda has joined #openstack-oslo | 22:40 | |
-openstackstatus- NOTICE: Gerrit and Zuul are going offline for reboots to fix a security vulnerability. | 22:40 | |
*** ChanServ changes topic to "Gerrit and Zuul are going offline for reboots to fix a security vulnerability." | 22:40 | |
*** dims has quit IRC | 22:41 | |
tchaypo | idle thought | 22:42 |
tchaypo | do we care about env markers in test_requires? | 22:42 |
tchaypo | s/test_requires/tests_require/ | 22:42 |
*** dims has joined #openstack-oslo | 22:43 | |
*** ashleighfarnham has quit IRC | 22:44 | |
lifeless | tchaypo: yes but its complicated | 22:46 |
lifeless | tchaypo: see my thread on pypa-dev, but for this patch I recommend ignoring it | 22:46 |
lifeless | since I think the answer is going to be something like 'stop using test-requires' | 22:47 |
*** dims_ has quit IRC | 22:47 | |
*** openstackgerrit has quit IRC | 22:47 | |
tchaypo | okay. your comments on the review are almost starting to make sense to me | 22:49 |
*** openstackgerrit has joined #openstack-oslo | 22:49 | |
tchaypo | my first instinct is to move the data in requires-dist into extras[‘'] | 22:55 |
tchaypo | which will then get it parsed by the code I’ve already written, and then we can pop it out again at the end | 22:55 |
tchaypo | my second instinct is to be slightly horrified that I want to do all that shuffling-around with the data just to avoid slightly tweaking code just because I know it currently works | 22:56 |
*** ericksonfgds has joined #openstack-oslo | 22:58 | |
*** ChanServ changes topic to "#openstack-oslo" | 22:58 | |
-openstackstatus- NOTICE: Gerrit and Zuul are back online. | 22:58 | |
tchaypo | okay, I can see two ways to do this | 23:02 |
tchaypo | one is to pull the stuff I’ve already written into a parse-these-requirements function that gets called once on requires-dist around line 327 and again on extras around line 377 | 23:03 |
tchaypo | the other is to simply stuff requires-dist into extras[‘’] before line 377 and then pull extra_requires[‘’] out again after line 392 | 23:04 |
tchaypo | *thinks out loud* | 23:04 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Beef up docs on the logbook/flow detail/atom details models https://review.openstack.org/181581 | 23:05 |
tchaypo | either way we need to handle the fact that the seperator is : in extras but ; in requires-dist | 23:05 |
lifeless | tchaypo: so no | 23:06 |
lifeless | tchaypo: I suggested you pull it into a single data structure because the other way won't work | 23:06 |
*** Rockyg has joined #openstack-oslo | 23:07 | |
lifeless | tchaypo: you need to merge any extras the user has written directly into anything coming out of install_requires | 23:07 |
lifeless | tchaypo: so your first instinct - which is what i proposed last night - will just work, the other one will require corner case handling | 23:07 |
tchaypo | well - it will if I s/;/:/g and then put it into extras[‘'] | 23:08 |
lifeless | I'm confused | 23:08 |
*** achanda has quit IRC | 23:09 | |
lifeless | reading up I think you described your options twice, once in one order and once in the reverse order | 23:09 |
lifeless | first time: 'my first instinct is to move the data in requires-dist into extras[‘']' | 23:09 |
lifeless | second time: 'one is to pull the stuff I’ve already written into a parse-these-requirements function' | 23:09 |
lifeless | so, I was referring to the first time. MOving the data into extras ;) | 23:09 |
tchaypo | *reads up* | 23:09 |
lifeless | but - there are two stages | 23:09 |
tchaypo | yes I did get the order wrong *sigh* | 23:10 |
lifeless | rather than s/;/:/ which will break on url requirements etc | 23:10 |
lifeless | parse it locally in each case | 23:10 |
lifeless | and union into a first-stage data structure | 23:10 |
tchaypo | ho hum. url requirements. | 23:10 |
lifeless | then process that into the final data structure | 23:10 |
tchaypo | the code I’ve already written splits on the first :, so i think that’s going to break for url requirementsd | 23:11 |
lifeless | right | 23:11 |
lifeless | but you've conflated two things | 23:11 |
lifeless | parsing | 23:11 |
lifeless | and marshalling | 23:11 |
lifeless | parse into (req, marker) | 23:11 |
lifeless | add the same parse step up above for install requires | 23:11 |
lifeless | then a single marshalling loop | 23:11 |
openstackgerrit | Victor Stinner proposed openstack/oslo.db: Add a keys() method to SQLAlchemy ModelBase https://review.openstack.org/182877 | 23:14 |
tchaypo | yep. | 23:16 |
tchaypo | I have to go make a coffee, but when I’m back I’ll make a note that I need to add a test case that has a url requirement and fix anything that breaks | 23:17 |
lifeless | uhm | 23:17 |
harlowja | lifeless u should do like a talk at the summit about all this versioning stuff | 23:17 |
harlowja | i'd go to that | 23:17 |
lifeless | so thats a rathole | 23:17 |
harlowja | *so u'd have at least 1 person | 23:17 |
lifeless | tchaypo: because - I don't want to cry - so please don't. Lets just be a little careful on the code so far and not peer into the abyss. | 23:17 |
lifeless | harlowja: hah. I might do one next summit. When the tooling is available. | 23:18 |
lifeless | UNLEARNING 3 years of suffering | 23:18 |
harlowja | lol | 23:18 |
harlowja | ^ perfect title | 23:18 |
harlowja | ha | 23:18 |
harlowja | UNLEARNING 3 years of suffering: bring your lashings/rods/whipes | 23:20 |
harlowja | there, a little better | 23:20 |
harlowja | although maybe thats a difference conference :-/ | 23:20 |
*** vipuls is now known as vipul | 23:20 | |
lifeless | well | 23:21 |
lifeless | I'm sure there is a set intersection in attendees | 23:21 |
harlowja | highly likely | 23:21 |
*** ozamiatin has quit IRC | 23:24 | |
*** achanda has joined #openstack-oslo | 23:26 | |
*** ho has quit IRC | 23:28 | |
harlowja | hmmm, is https://www.python.org/ down for othrs? | 23:28 |
harlowja | someone killed it | 23:28 |
lifeless | http://downforeveryoneorjustme.com/www.python.com | 23:29 |
lifeless | oh org | 23:29 |
lifeless | s is down | 23:29 |
lifeless | h is up | 23:29 |
harlowja | ah | 23:29 |
harlowja | thx | 23:29 |
harlowja | forgot about that downforme site thingy | 23:29 |
tchaypo | lifeless: i should at least least change it to split on ‘ :’ rather than just ‘:' | 23:32 |
lifeless | tchaypo: why? | 23:33 |
lifeless | tchaypo: this is another reason to have your sample data be a text literal, its easier to show expected inputs | 23:33 |
tchaypo | -f git+git://github.com/mozilla/elasticutils.git | 23:34 |
lifeless | tchaypo: not a valid install_requires | 23:34 |
lifeless | tchaypo: can't be present in an extras field | 23:34 |
lifeless | tchaypo: urls are special, please don't try to understand. I don't want to page it all in ;) | 23:35 |
tchaypo | okay. I’ll just ignore them for now | 23:35 |
lifeless | tchaypo: but the heart of the fault goes back to requirements != install-requires even though they do | 23:35 |
lifeless | pip -r AFILE can specify things install_requires can't | 23:35 |
lifeless | and what you're writing is in a saner spot | 23:35 |
lifeless | or its meant to be | 23:36 |
tchaypo | -e git://github.com/mozilla/elasticutils.git#egg=elasticutils ? | 23:36 |
lifeless | valid in a requirements file, not a valid install_requires | 23:37 |
tchaypo | or extras | 23:37 |
lifeless | valid as a dependency link, which is deprecated, or a named doodah per pep426, but thats not implemented yet | 23:37 |
tchaypo | *checks* | 23:38 |
tchaypo | not that I ever doubted you | 23:38 |
tchaypo | but pdb confirms that as of line 244, requires_dist just has ‘pip\nelasticutils' | 23:39 |
tchaypo | okay good. moving right along... | 23:40 |
lifeless | so there's probably preprocessing stripping out the matchers | 23:40 |
lifeless | you'll find that out when we write an acceptance test | 23:41 |
*** ho has joined #openstack-oslo | 23:44 | |
*** rrepaka123 has quit IRC | 23:48 | |
tchaypo | doesn’t pip already handle env markers in requirements.txt? | 23:51 |
*** bknudson has joined #openstack-oslo | 23:51 | |
haypo | tchaypo, it does since pip 6 | 23:51 |
*** tsekiyam_ has joined #openstack-oslo | 23:53 | |
*** exploreshaifali has joined #openstack-oslo | 23:54 | |
*** ericksonfgds has quit IRC | 23:55 | |
lifeless | tchaypo: it does, but thats requirements.txt, not install_requires | 23:55 |
lifeless | tchaypo: see, I keep saying you don't want to stare down the abyss :) | 23:55 |
lifeless | tchaypo: there is a data model for distributions | 23:56 |
lifeless | tchaypo: markers are part of that. pbr doesn't export markers to that data model. | 23:56 |
lifeless | tchaypo: we do our own parsing of requirements files | 23:56 |
lifeless | tchaypo: (and only support a subset of pips capabilities) | 23:56 |
lifeless | tchaypo: we use requirements files as both requirements files and as install_requires | 23:56 |
lifeless | tchaypo: -> nothing you've learnt about or know about requirements files is relevant to the work we're doing now | 23:57 |
*** tsekiyama has quit IRC | 23:57 | |
lifeless | tchaypo: because we're working in the distribution data model | 23:57 |
jaypipes | harlowja: the giant gaping hole that marshmallow is missing is schema evolution :) i.e. versioning. | 23:57 |
*** mtanino has quit IRC | 23:57 | |
tchaypo | oh right. | 23:57 |
tchaypo | pip handles them when it’s installing packages | 23:57 |
harlowja | jaypipes agreed, https://github.com/marshmallow-code/marshmallow/issues/171 was my attempt/initial probe to see if the author was willing to take that (or interested in it) | 23:58 |
lifeless | our goal here is to get away from using requirements.txt entirely | 23:58 |
*** tsekiyam_ has quit IRC | 23:58 | |
lifeless | so we can separate out the distribution metadata and the deployment metadata | 23:58 |
harlowja | jaypipes but maybe thats the value add we go to the author with and discuss more with (or if that doesn't work, thats the value add of the versionedobjects library?) | 23:58 |
lifeless | from-git is a deployment decisions | 23:58 |
lifeless | needs-neutron is a distribution metadata statement | 23:58 |
jaypipes | harlowja: not entirely sure it's worth it, but feel free to pursue. | 23:58 |
harlowja | jaypipes i didn't especially try hard to 'convince him' | 23:58 |
jaypipes | and letus know what you find :) | 23:58 |
harlowja | damn, i was gonna volunteer u | 23:59 |
harlowja | lol | 23:59 |
tchaypo | so to do that, pbr has to be able to handle both requirements coming from requirements.txt but also install_requires in setup.cfg? | 23:59 |
*** ashleighfarnham has joined #openstack-oslo | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!