Monday, 2015-03-23

openstackgerritMerged openstack/taskflow: Rename memory backend filesystem -> fake filesystem  https://review.openstack.org/16566200:13
*** achanda has quit IRC00:22
*** liusheng has quit IRC00:26
*** liusheng has joined #openstack-oslo00:26
*** achanda has joined #openstack-oslo00:53
*** amrith is now known as _amrith_00:58
*** sputnik13 has quit IRC01:00
*** liusheng has quit IRC01:00
*** dims has joined #openstack-oslo01:01
*** dims has quit IRC01:01
*** _amrith_ is now known as amrith01:15
*** dims__ has joined #openstack-oslo01:15
*** stevemar has quit IRC01:34
*** sputnik13 has joined #openstack-oslo01:40
*** sputnik13 has quit IRC01:51
*** sputnik13 has joined #openstack-oslo01:57
*** achanda has quit IRC01:57
*** mtanino has joined #openstack-oslo02:08
*** ccrouch has joined #openstack-oslo02:25
*** takedakn has joined #openstack-oslo02:44
*** amrith is now known as _amrith_02:52
*** achanda has joined #openstack-oslo02:58
*** dims__ has quit IRC03:01
*** ccrouch is now known as ccrouch-afk03:02
*** achanda has quit IRC03:03
*** dims__ has joined #openstack-oslo04:06
*** achanda has joined #openstack-oslo04:08
*** stevemar has joined #openstack-oslo04:15
*** achanda has quit IRC04:34
*** dims__ has quit IRC04:36
*** yamahata has joined #openstack-oslo04:54
*** kiseok7_ has joined #openstack-oslo05:06
*** pcaruana has quit IRC05:07
*** achanda has joined #openstack-oslo05:08
*** rushiagr_away is now known as rushiagr05:19
*** achanda has quit IRC05:24
*** achanda has joined #openstack-oslo05:26
openstackgerritJoshua Harlow proposed openstack/taskflow: Allow using shallow copy instead of deep copy  https://review.openstack.org/16569305:33
openstackgerritJoshua Harlow proposed openstack/taskflow: By default use a in memory backend (when none is provided)  https://review.openstack.org/16565405:33
openstackgerritJoshua Harlow proposed openstack/taskflow: Just unify having a single requirements.txt file  https://review.openstack.org/16452305:35
*** yamahata has quit IRC05:41
openstackgerritOpenStack Proposal Bot proposed openstack/oslo.utils: Imported Translations from Transifex  https://review.openstack.org/16670006:11
*** mtanino has quit IRC06:22
*** dims__ has joined #openstack-oslo06:22
*** ajo_ has joined #openstack-oslo06:28
*** jamielennox is now known as jamielennox|away06:28
*** stevemar has quit IRC06:48
*** inc0 has joined #openstack-oslo06:52
*** dims__ has quit IRC06:54
*** pcaruana has joined #openstack-oslo06:58
*** rushiagr is now known as rushiagr_away07:03
*** saikrishna has joined #openstack-oslo07:07
*** ajo_ is now known as ajo07:10
*** achanda has quit IRC07:29
*** yamahata has joined #openstack-oslo07:36
*** ajo has quit IRC07:42
*** gtt116 has joined #openstack-oslo07:51
gtt116good morning?07:52
gtt116https://blueprints.launchpad.net/oslo.messaging/+spec/consistent-exception-notifications  does somebody still work on this blueprint?07:52
*** yamahata has quit IRC07:53
*** YorikSar has quit IRC07:58
*** saikrishna_ has joined #openstack-oslo07:58
*** saikrishna has quit IRC08:01
*** saikrishna__ has joined #openstack-oslo08:14
*** saikrishna_ has quit IRC08:16
*** ndipanov has joined #openstack-oslo08:21
*** ihrachyshka has joined #openstack-oslo08:25
*** YorikSar has joined #openstack-oslo08:34
*** gtt116 has quit IRC08:37
*** gtt116 has joined #openstack-oslo08:37
*** dims__ has joined #openstack-oslo08:39
*** andreykurilin_ has joined #openstack-oslo08:40
*** ihrachyshka has quit IRC08:48
*** inc0 has quit IRC08:51
*** ajo has joined #openstack-oslo08:52
*** e0ne has joined #openstack-oslo09:02
*** inc0 has joined #openstack-oslo09:04
*** e0ne has quit IRC09:08
*** inc0 has quit IRC09:11
*** inc0 has joined #openstack-oslo09:11
*** BrianShang has quit IRC09:12
*** dims__ has quit IRC09:12
*** BrianShang has joined #openstack-oslo09:13
openstackgerritMerged openstack/tooz: Use a sentinel connection pool to manage failover  https://review.openstack.org/16629109:17
openstackgerritMerged openstack/tooz: Updated from global requirements  https://review.openstack.org/16647909:17
*** andreykurilin_ has quit IRC09:26
haypohi. did someone saw a test_save_and_reraise_exception_dropped() failure with python 3.4 in Oslo Incubator?09:26
haypooh, it's in oslo.utils sorry, not incubator09:29
*** inc0 has quit IRC09:32
*** inc0 has joined #openstack-oslo09:34
*** kbyrne has joined #openstack-oslo09:35
*** viktors has joined #openstack-oslo09:36
*** liusheng has joined #openstack-oslo09:41
*** dims__ has joined #openstack-oslo09:51
*** gtt116_ has joined #openstack-oslo09:53
*** e0ne has joined #openstack-oslo09:54
*** gtt116 has quit IRC09:56
*** e0ne is now known as e0ne_10:00
*** inc0 has quit IRC10:01
*** inc0 has joined #openstack-oslo10:02
*** e0ne_ has quit IRC10:05
*** subscope has joined #openstack-oslo10:06
*** inc0 has quit IRC10:10
*** enikanorov_ has quit IRC10:11
*** enikanorov_ has joined #openstack-oslo10:12
*** e0ne has joined #openstack-oslo10:14
*** cdent has joined #openstack-oslo10:18
openstackgerritMerged openstack/oslo.db: Updated from global requirements  https://review.openstack.org/16645210:20
*** ihrachyshka has joined #openstack-oslo10:23
*** takedakn has quit IRC10:25
*** vigneshvar has joined #openstack-oslo10:41
*** dulek has joined #openstack-oslo10:46
*** ihrachyshka has quit IRC10:47
*** dulek has quit IRC10:47
*** dulek has joined #openstack-oslo10:47
*** saikrishna_ has joined #openstack-oslo10:52
*** dulek_ has joined #openstack-oslo10:53
*** jaosorior has joined #openstack-oslo10:53
*** saikrishna__ has quit IRC10:54
*** dulek has quit IRC10:55
dims__sigmavirus24_awa: so going through some really old stuff, does this still happen? https://bugs.launchpad.net/nova/+bug/110140410:58
openstackLaunchpad bug 1101404 in oslo.log "nova syslog logging to /dev/log race condition in python 2.6 and 2.7" [Medium,Confirmed]10:58
*** saikrishna__ has joined #openstack-oslo10:59
*** saikrishna_ has quit IRC11:02
*** saikrishna__ has quit IRC11:09
*** e0ne is now known as e0ne_11:10
*** _amrith_ is now known as amrith11:13
*** e0ne_ is now known as e0ne11:17
*** saikrishna has joined #openstack-oslo11:26
*** zul has joined #openstack-oslo11:32
*** saikrishna has quit IRC11:33
silehtdims__, yes it still happens11:35
silehtdims__, I have added a link to new eventlet bug about that11:36
*** shardy has joined #openstack-oslo11:42
*** BrianShang has quit IRC11:42
mdboothAny interest in this: https://review.openstack.org/#/c/146228/11:42
mdboothI'd like to use it in Nova11:42
*** BrianShang has joined #openstack-oslo11:43
dims__sileht: i see the patch for logging/handlers.py in my python 2.7 installation - http://bugs.python.org/issue15179 - does it happen even with that patch?11:44
dims__viktors: rpodolyaka: please see ping from mdbooth when you get a chance - https://review.openstack.org/#/c/146228/11:46
silehtdims__, yes11:54
*** pblaho has joined #openstack-oslo11:57
*** kgiusti has joined #openstack-oslo12:01
*** e0ne is now known as e0ne_12:05
*** stpierre has joined #openstack-oslo12:07
*** sreshetnyak has quit IRC12:18
haypoi don't understand how i'm supposed to use the subunit module :-(12:20
haypopython -m subunit.run discover --list > test-list; python -m subunit.run discover --load-list test-list => UnicodeDecodeError ??12:20
haypo--load-list expects a text file?12:21
*** sreshetnyak has joined #openstack-oslo12:22
haypoi'm investigating the bug https://bugs.launchpad.net/oslo.utils/+bug/143380012:22
openstackLaunchpad bug 1433800 in oslo.utils "Intermittent "expected string or buffer" exception in py3 jobs" [Medium,Confirmed]12:22
*** gordc has joined #openstack-oslo12:27
*** e0ne_ has quit IRC12:29
*** yassine has joined #openstack-oslo12:31
*** ihrachyshka has joined #openstack-oslo12:31
*** dims__ has quit IRC12:34
*** dims__ has joined #openstack-oslo12:34
*** amrith is now known as _amrith_12:35
*** jecarey has quit IRC12:52
*** dims__ is now known as dims12:52
dhellmann_amrith_, bnemec, dims, haypo : I randomly got this more detailed traceback for the utils issue: http://paste.openstack.org/show/195344/12:55
haypodhellmann: yes. see https://bugs.launchpad.net/oslo.utils/+bug/143380012:56
openstackLaunchpad bug 1433800 in oslo.utils "Intermittent "expected string or buffer" exception in py3 jobs" [Medium,Confirmed]12:56
haypodhellmann: i wrote a shell script to reproduce it in 100% cases12:56
haypoi'm still trying to understand how to reproduce it with less commands12:56
dhellmannhaypo: at least you have it reproducable!12:57
haypodhellmann: do you know how to load a list of tests using subunit?12:57
haypo13:20 < haypo> python -m subunit.run discover --list > test-list; python -m subunit.run discover --load-list test-list => UnicodeDecodeError ??12:57
dhellmannhaypo: no :-(12:57
haypoi don't understand all these subunit tools12:58
dimshaypo: folks on -qa may know13:00
dhellmannhaypo: it always takes me a while to find the docs because they aren't linked from the readme page: http://testrepository.readthedocs.org/en/latest/13:00
*** amotoki has quit IRC13:01
haypodhellmann: i wrote my own list of docs :-) http://haypo-notes.readthedocs.org/openstack.html#tests13:04
haypodhellmann: with simple reminders like "how to run a test"... it's not so simple in practice :)13:04
dhellmannhaypo: heh13:04
*** amotoki has joined #openstack-oslo13:06
*** vigneshvar has quit IRC13:09
*** leakypipes has quit IRC13:13
dhellmannhaypo: your script doesn't cause the failure to happen for me :-/13:14
haypodhellmann: too bad13:16
eezhovadims, ping13:19
dimseezhova: pong13:19
eezhovadims, could you please check out my reply to your comment to https://bugs.launchpad.net/oslo-incubator/+bug/1433142 ?13:20
openstackLaunchpad bug 1433142 in oslo-incubator "ProcessLauncher should support reloading config file for parent process on receiving SIGHUP" [Undecided,Fix committed] - Assigned to Elena Ezhova (eezhova)13:20
dimseezhova: ah. i tested nova-compute and verified that it does reload config files. i missed testing nova-api13:22
dimseezhova: so nova-api is still busted?13:22
eezhovadims, does nova-compute use ProcessLauncher?13:22
dimseezhova: nova/service.py seems to indicate so13:23
haypodhellmann: cool, i reduced the list of tests from 12,000+ tests to 2 tests :) i'm still able to reprodue the issue13:25
dhellmannhaypo: that's good progress13:26
dhellmannhaypo: which 2 tests?13:27
*** mriedem1 has joined #openstack-oslo13:27
*** mriedem has quit IRC13:27
*** alexpilotti has joined #openstack-oslo13:31
eezhovadims, it seems to that nova-compute uses ServiceLauncher13:31
haypodhellmann: (py34)haypo@smithers$ python -m testtools.run oslo_utils.tests.test_netutils.TestIsIPv6Enabled.test_disabled tests.test_excutils.SaveAndReraiseTest.test_save_and_reraise_exception_dropped13:31
haypodhellmann: ok, the problem is in oslo_utils.tests.test_netutils.TestIsIPv6Enabled.test_disabled, it never stops a mock13:31
eezhovadims, https://github.com/openstack/nova/blob/97d63d8745cd9b3b391ce96b94b4da263b3a053d/nova/service.py#L44013:31
eezhovadims, serve accepts workers as a parameter13:32
eezhovadims, with default value - None13:32
eezhovaand here https://github.com/openstack/nova/blob/97d63d8745cd9b3b391ce96b94b4da263b3a053d/nova/cmd/compute.py#L73 no workers parameter is passed13:33
dhellmannhaypo: ah! it looks like the test author assumed that the base class set up the mock fixture to stop mocks13:33
eezhovadims, so, ServiceLauncher would be used: https://github.com/openstack/oslo-incubator/blob/master/openstack/common/service.py#L48813:34
*** zzzeek has joined #openstack-oslo13:36
eezhovadims, it is not nova's bug, it is ProcessLauncher that is missing the required functionality13:37
*** superdan is now known as dansmith13:39
*** dulek_ has quit IRC13:43
*** exploreshaifali has joined #openstack-oslo13:45
*** jecarey has joined #openstack-oslo13:48
*** salv-orlando has joined #openstack-oslo13:50
openstackgerritVictor Stinner proposed openstack/oslo.utils: Fix test_netutils: stop patches  https://review.openstack.org/16683513:50
*** exploreshaifali has quit IRC13:51
*** e0ne has joined #openstack-oslo13:52
dimseezhova: easy to fix?13:56
eezhovadims, yes, we just have to reload config and call reset() in wait method after receiving SIGHUP13:57
eezhovadims, https://review.openstack.org/#/c/165104/13:57
eezhovadims, that's almost the same that is done for ServiceLauncher13:59
*** hogepodge has joined #openstack-oslo14:02
*** prad has joined #openstack-oslo14:04
dimseezhova: tested and works?14:04
dimssorry a bit distracted with another thing at the moment14:05
eezhovadims, tested with neutron-server. will double check with nova-api14:05
dimsthanks!14:05
*** _amrith_ is now known as amrith14:06
*** stevemar has joined #openstack-oslo14:10
*** zz_jgrimm- is now known as jgrimm14:12
eezhovadims, I ran the same test for nova-api with my patch and it works - please see logs http://paste.openstack.org/show/195378/14:12
dimseezhova: awesome work! thanks14:13
eezhovadims, thanks for you time! do you mind if remove nova from affected projects and reset the bug's status to "In progress"?14:14
dimseezhova: i need it for sync-ing oslo-incubator to nova14:15
eezhovadims, ah, OK14:16
*** sigmavirus24_awa is now known as sigmavirus2414:16
*** ccrouch-afk is now known as ccrouch14:17
*** mtanino has joined #openstack-oslo14:21
jd__dhellmann: dims: knock knock14:22
dimsjd__: pong14:22
jd__I've a problem and I'd like to hear from you14:22
sigmavirus24dims: re bug 1101404 we were seeing it on 2.7 but I dont' recall the steps to reproduce14:22
openstackbug 1101404 in oslo.log "nova syslog logging to /dev/log race condition in python 2.6 and 2.7" [Medium,Confirmed] https://launchpad.net/bugs/110140414:22
dhellmannjd__: is the parser in pip, or setuptools?14:22
dhellmannjd__: oh, you go first :-)14:22
sigmavirus24I know that isn't particularly helpful, but we're running 2.7 and were still seeing the bug14:22
jd__dhellmann: pip, setuptools does not support those tags that's why we remove them14:22
dhellmannjd__: I thought the whole point of this was there was a standard and some of the upstream tools now support it14:23
jd__so basically I was using jsonutils happily until 5 minutes ago where I was very disapointed to discover that it relies on strtime() to encode datetime https://git.openstack.org/cgit/openstack/oslo.serialization/tree/oslo_serialization/jsonutils.py#n11014:23
jd__dhellmann: I don't know everything, but from what I got that's the state of it, don't ask me more :)14:24
dimssigmavirus24: ack, please add whatever you can to the bug (even just saying which version of python 2.7 you are seeing)14:24
dhellmannjd__: ok, I'll ask lifeless14:24
jd__as you know I'm on a quest to remove strtime() from OpenStack and timeutils14:24
jd__so I wrote a patch to change strtime() to isotime() in oslo.serialization and I tested on Nova14:24
dimsjd__: k14:24
dhellmannjd__: on the date format thing, we need to provide a migration path that supports rolling upgrades for anything that might be sending datetime values over rpc14:25
jd__and it didn't explose, it just broke 2 tests14:25
dhellmannit's not enough that it works, it has to work with both formats at the same time14:25
jd__dhellmann: yeah I did that for context in Nova already14:25
dhellmannok14:25
jd__you just leave strtime() on the ouput and start reading with parse_isotime() which understands both14:25
dhellmannthat sounds good14:25
jd__and on L we can drop strtime() in favor of isotime()14:25
jd__it's pretty easy actually14:26
sigmavirus24dims: will do14:26
dhellmannor just change the return value of strtime14:26
jd__dhellmann: that's an option too :)14:26
jd__so back on my jsonutils thing I'm not sure what to do14:26
dhellmannthat might make it easier, since we don't need to go update all of the projects before removing the function14:26
jd__clearly it changes the API, but it also fixes it14:26
jd__it's not too invasive from what I tested, but still it "breaks" things14:27
dhellmannyeah, we need to publicize the change14:27
dhellmannjd__: just a sec14:28
dimsjd__: so accept old and new and generate new?14:28
jd__dims: well in jsonutils there's no "accept" so we're safe – it's just test that check for some string value, and the new value has a Z (the timezone) at the end of it so the test fails14:29
dhellmanndansmith: what impact would changing the datetime format have on versionedobjects? ^^14:29
jd__it it was tested with parse_isotime() it would not fail14:29
jd__so I can pre-patch Nova and other projects before we make the change to oslo.serialization if that's good14:29
* dansmith reads14:29
dansmithdhellmann: jd__: we don't rely on jsonutils to serialize our datetimes, so it doesn't affect us, yes/14:30
jd__awesome14:30
jd__I see you use isotime(), good call14:30
* jd__ high-five dansmith 14:30
dimsyay14:30
dansmithwoohoo! :)14:31
dansmithright, just for the record: https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/fields.py#L298-30414:32
dansmiththat's where we serialize and deserialize datetimes14:32
dhellmanndansmith: excellent, that was one of my big concerns14:32
dansmither, well, I highlighted down instead of up, but you get the idea :)14:32
dhellmannjd__: so the other thing is the rpc calls, especially notifications, so how will this affect ceilometer?14:32
jd__dhellmann: let me check that14:33
dansmithjd__: if it has a Z at the end, does it end up with a tz-aware datetime?14:33
dansmithbecause if so, that will cause lots of problems all over14:34
jd__dhellmann: looks like we don't realy on parse_strtime() in Ceilometer (and nothing about that in oslo.messaging neither)14:34
dhellmannjd__: I know you hate this, but one way to publicize a format change like this will be a small spec. Pulling together the notes from this conversation and your other research into the impact would be good, and then we can also prepare an email thread14:34
jd__dansmith: yes, that's the point14:34
dhellmannI wonder if it's worth providing a backwards compatibility flag14:34
*** achanda has joined #openstack-oslo14:34
dansmithjd__: that's going to cause issues everywhere, right?14:34
jd__dansmith: that's my question – from what I tested with Nova unit tested, it only breaks 2 tests14:34
dansmithjd__: people that create a datetime and go to compare it with something received over the wire, and end up with a failure comparing the tz-aware and tz-unaware tests14:35
dansmithjd__: (a) that surprises me and (b) I'm sure there are more14:35
dansmithjd__: because of objects, we've converted a lot of code to tz-aware now, so that's probably why it's low, but it used to be hundreds14:35
dansmithjd__: I would expect other projects to choke on that pretty hard14:35
jd__dansmith: that depends on how you parse the time actually, parse_isotime() always add a timezone14:36
jd__so we're safe with that14:36
dansmithbut this is changing jsonutils' output right?14:36
jd__and if it relies on parse_strtime(), it will explose (and I'm trying to remove parse_strtime() usage)14:36
jd__dansmith: yes it is14:36
dansmithright, so that's the problem I think14:37
dansmithcan't we change jsonutils to just strip out the timezone on datetimes after parsing or something?14:37
jd__yes, so we are trying to see who is using parse_strtime() to read JSON, but I don't see many places doing that – and I'm trying to fixing them – and we can actually replace parse_strtime() by parse_isotime() likely?14:37
jd__dansmith: jsonutils doesn't parse14:37
dansmithbefore objects, nearly every rpc call in nova sent three datetimes that were serialized by jsonutils14:38
dansmithby "doesn't parse" you mean the loads() returns the stringified version of the datetime instead of the actual datetime, right14:40
dansmithso the problem with this plan, had you done it in nova two years ago, is that you'd have some services running new code sending things with Z on the end to code that is using the old parse_strtime(), which would choke right?14:41
*** achanda has quit IRC14:41
dansmithso, people still doing such things might not care about rolling upgrades, I dunno14:41
jd__yes that's the main possible issue I see14:41
dansmithyep14:42
dansmithI expect there are actually more breaks in nova around the scheduler and resource tracker stuff that don't pop up in unit tests, but the devstack tests should hopefully shake those out14:43
jd__well I'm gonna send the patch I guess and we'll discuss that there I guess14:43
dansmithokay14:43
jd__dansmith: the thing is I don't think we can now that before releasing the lib :( which is too late obviously14:43
jd__dhellmann correct me if I'm wrong14:43
dhellmannjd__: patching the lib should trigger a devstack-gate test job that installs the lib from source14:44
jd__dhellmann: ok, cool!14:45
*** bnemec has quit IRC14:46
dhellmannjd__: if that *doesn't* happen we should make sure the test job config for the lib is right :-)14:46
jd__dhellmann: dully noted, I'm waiting for the results anyway14:47
dimsjd__: you can even run oslo libraries against juno if you want. example https://review.openstack.org/#/c/165981/14:47
dhellmanndims: we should make sure we have the right jobs set up against all of the libs stable branches -- do you know if that happens automatically or if we need to do something special?14:48
openstackgerritJulien Danjou proposed openstack/oslo.serialization: jsonutils: replace strtime() usage with isotime()  https://review.openstack.org/16686114:48
dimsdhellmann: need to take an inventory. don't know for sure14:49
dimsdhellmann: will add to my todo list14:49
*** bnemec has joined #openstack-oslo14:49
dhellmanndims: ok, thanks14:50
openstackgerritJulien Danjou proposed openstack-dev/pbr: Handle PEP426 markers  https://review.openstack.org/16501514:51
openstackgerritJulien Danjou proposed openstack/oslo.serialization: jsonutils: simplify simple value handling  https://review.openstack.org/16686614:55
*** pblaho has quit IRC15:05
sdaguedoes anyone here have pull with the eventlet team? This was proposed a year ago - https://github.com/eventlet/eventlet/pull/75 - and got a "will merge soon", and never did15:09
sdagueand would simplify the oslo logging / service story with eventlet15:10
*** tsekiyama_ has joined #openstack-oslo15:13
dhellmannsdague: I don't know anyone on that team. haypo or harlowja may, since they've been looking at alternatives15:17
openstackgerritMerged openstack/oslo.db: Implement generic update-on-match feature  https://review.openstack.org/14622815:19
hayposdague: good luck :-p15:21
hayposdague: https://github.com/temoto looks to be actively reviewing pull requests15:22
*** sputnik13 has quit IRC15:22
hayposdague: my latest pull request, https://github.com/eventlet/eventlet/pull/18715:22
sdagueok, well he was the one that said he'd merge it last Jan15:23
sdagueI guess I'll just be patient15:23
dimssdague: build failed? https://travis-ci.org/eventlet/eventlet/builds/5502610215:23
sdaguedims: yeh, python3 races in one of the configs15:23
sdagueit's unrelated, and hitting all the patches last time I looked15:23
dimsi see15:23
dimshe's published an email address... http://temoto.ru/15:24
*** sdague has quit IRC15:26
*** bogdando has quit IRC15:26
haypodims: with his phone number, you can call him! "review my pull request, immediatly!"15:26
*** harlowja_at_home has joined #openstack-oslo15:30
dimshaypo: hahaha15:32
*** exploreshaifali has joined #openstack-oslo15:36
dhellmannhaypo: were you going to update https://review.openstack.org/#/c/166835/ to use the fixture? I can do it, if you have other work you need to do15:38
*** yamahata has joined #openstack-oslo15:39
*** sdague has joined #openstack-oslo15:40
haypodhellmann: i never used fixtures, i don't understand them :-p15:41
*** tsekiyama_ is now known as tsekiyama15:41
haypodhellmann: i just wanted to fix oslo.utils, feel free to rewrite my simple patch15:41
*** jaypipes has joined #openstack-oslo15:42
*** tsekiyama is now known as tsekiyama_15:42
haypo(i checked quickly if other tests use something call "fixture" with mock, but i gave up)15:42
dhellmannhaypo: ok, I'll update it15:44
dhellmannjd__: looking at haypo's patch, it's actually going to be pretty ugly to rewrite it to use fixtures. I'm inclined to approve the fix, and rewrite it as a separate patch. Thoughts?15:52
dhellmannjd__: mostly because it wants to mock six.moves.builtins.open.return_value.__enter__.return_value.read to replace a file-reading call15:53
dhellmannand I can refactor that into a function in netutils that we can mock instead15:53
*** YorikSar has quit IRC15:56
dimsdhellmann: am cool with a separate patch15:56
dhellmanndims: that's on https://review.openstack.org/#/c/166835/15:56
*** bogdando has joined #openstack-oslo15:57
dimsdhellmann: ack, saw jd__'s -115:57
haypodhellmann: hum, it sounds complex to use fixtures15:57
openstackgerritJulien Danjou proposed openstack/oslo.serialization: jsonutils: encode dict keys  https://review.openstack.org/16690215:57
e0nehi! i can't find agenda for today's meeting at https://wiki.openstack.org/wiki/Meetings/Oslo. can anybody help me please?15:57
haypodhellmann: fixtures are not supposed to make code shorter/simpler? :-p15:57
jd__dhellmann: ok, feel free to bypass my -1 :)15:58
dhellmannhaypo: they are, but in this case the tests are doing some weird things and the fixtures aren't structured to make that easy15:58
dhellmannjd__: ok, I didn't want to do that without chatting about it15:58
dimsdhellmann: Elena has the SIGHUP one ready - https://review.openstack.org/#/c/165104/15:59
haypodhellmann: i like mock API, it's simple15:59
haypodhellmann: if you don't want to repeat addCleanup(patch.stop), add a call to addCleanup(patch.stopall) in the parent test class16:00
dhellmannhaypo: the trick there is getting the ordering right, but yeah16:01
*** tsekiyama_ has quit IRC16:05
*** tsekiyama has joined #openstack-oslo16:07
jd__this does not look good http://logs.openstack.org/61/166861/1/check/gate-oslo.serialization-docs/d17dd51/console.html not sure it's related to my change16:18
*** yamahata has quit IRC16:19
harlowja_at_homejd__,  stop breaking all the things, haha16:19
*** yamahata has joined #openstack-oslo16:19
jd__:(16:20
jd__I'm too agile for OpenStack16:20
harlowja_at_homedef16:21
harlowja_at_homelol16:21
*** sreshetn1 has joined #openstack-oslo16:31
*** harlowja_at_home has quit IRC16:34
*** YorikSar has joined #openstack-oslo16:34
*** yamahata has quit IRC16:41
*** yamahata has joined #openstack-oslo16:41
*** ajo has quit IRC16:42
openstackgerritMerged openstack/oslo.messaging: Remove 'UNIQUE_ID is %s' logging  https://review.openstack.org/16637216:42
dimsjd__: haha16:50
*** ihrachyshka has quit IRC16:51
openstackgerritDoug Hellmann proposed openstack/oslo.utils: Clean up TestIsIPv6Enabled  https://review.openstack.org/16692416:52
dhellmannhaypo: ^^16:52
dhellmannjd__, dims : ^^16:52
*** yamahata has quit IRC16:54
*** yamahata has joined #openstack-oslo16:54
openstackgerritDoug Hellmann proposed openstack/oslo-specs: Change oslo.log to keep other libraries quiet in the logs  https://review.openstack.org/16485116:57
*** e0ne is now known as e0ne_16:57
*** e0ne_ is now known as e0ne16:58
haypojd__, dims : hey, you approved the change before i had time to send my review :-p17:03
dimshaypo: i +217:03
dims'ed first so it's jd__'s fault :)17:03
haypodims: don't worry, it's always jd__'s fault17:03
jd__I know, I know17:04
haypo:)17:04
haypoat least you know17:04
jd__"but it works now!" "yeah that's jd again"17:04
*** yamahata has quit IRC17:04
openstackgerritMerged openstack/taskflow: Add newline to avoid sphinx warning  https://review.openstack.org/16400617:05
*** exploreshaifali_ has joined #openstack-oslo17:06
*** exploreshaifali has quit IRC17:07
*** vigneshvar has joined #openstack-oslo17:11
openstackgerritJulien Danjou proposed openstack/oslo.serialization: jsonutils: encode dict keys  https://review.openstack.org/16690217:15
* dims bows to jd__17:16
*** amotoki has quit IRC17:19
dhellmannhaypo, jd__ : when I use StringIO I get "StringIO instance has no attribute __exit__17:19
*** sputnik13 has joined #openstack-oslo17:21
*** harlowja has joined #openstack-oslo17:27
*** achanda has joined #openstack-oslo17:29
*** yassine has quit IRC17:30
krotscheckRandom historical question: Oslo libs used to be installed via copy/commit to source. How did that come about?17:35
dhellmannkrotscheck: http://specs.openstack.org/openstack/oslo-specs/specs/policy/incubator.html17:36
*** e0ne has quit IRC17:36
*** amotoki has joined #openstack-oslo17:36
krotscheckdhellmann: Interesting. So it's basically an approval buffer.17:36
dhellmannkrotscheck: right, and a way to make breaking changes to the API before declaring it stable17:37
krotscheckCool. I was hoping it was a different reason, because I want to strengthen my argument to do something similar for js.17:37
*** sreshetn1 has quit IRC17:38
*** khivin has quit IRC17:40
openstackgerritJoshua Harlow proposed openstack/taskflow: Add in memory filesystem clearing  https://review.openstack.org/16694617:46
sigmavirus24krotscheck: use Go as your go to example for why vendoring is good17:46
sigmavirus24=P17:46
krotscheckvendoring?17:46
sigmavirus24copying a dependency into place and committing it17:46
krotschecksigmavirus24: Right. That's what I was going to propose.17:47
sigmavirus24krotscheck: Go is formalizing how that works17:47
harlowjai'm not sure everyone will agree that vendoring is good still :-P17:47
sigmavirus24harlowja: sssssh17:47
krotscheckThere are disagreements.17:47
sigmavirus24breaking migration libraries in patch versions is good so why isn't vendoring?17:47
harlowjaif google jumps off a cliff, would u17:47
harlowjalol17:47
sigmavirus24harlowja: google wouldn't jump off a cliff though, "Do No Evil"17:48
* sigmavirus24 is being sarcastic in case anyone missed it17:48
harlowja;)17:48
harlowjaself-jumping off a cliff is evil?17:48
sigmavirus24harlowja: according to some. there are disagreements17:48
harlowja:)17:48
krotschecksigmavirus24: I'm confused. Do you like vendoring or not?17:49
sigmavirus24krotscheck: I tolerate it17:49
sigmavirus24I neither like nor dislike it17:49
krotscheck(in ref to 'im being sarcastic')17:49
*** yamahata has joined #openstack-oslo17:49
krotscheckGotcha17:49
krotscheckI would prefer for bower to use a signed code repository.17:49
sigmavirus24I recognize the fact that it is useful and that debian does it in spite of their clear guidelines not to17:49
krotscheckSo that we can mirror it without someon doing a git history rewrite and messing everything up.17:50
harlowjaimho if its done at the right level, then sure its ok (but i think that level is the container/vm level, not the library level)17:50
krotscheckBut that's sadly not the case.17:50
harlowjavendoring stuff for your own laziness, not a good reason imho, vendoring stuff at deployment time, sure ok17:50
sigmavirus24harlowja: that's a much clearer explanation. I was confused what you meant17:51
krotscheckI don't think it's a lazyness issue. it's a question of "Is your code trustworthy enough to package on CentOS/Debian"17:51
krotscheckAnd, well, if you do a build-time resolution against a git repository, like bower does, then no: your code isn't trustworthy.17:51
sigmavirus24krotscheck: for what it's worth, I maintain requests. It has a vendoring policy set by the original author who refuses to change it, so we've made it easy for people to remove vendored dependencies17:52
harlowjasounds like said person needs to take some confidence drugs17:52
sigmavirus24(Without munging imports that is)17:52
harlowjanot the ones they sell u on TV, lol17:52
krotschecksigmavirus24: I'm definitely a fan of a two-pronged approach :)17:53
krotscheckUltimately, I'd love to cater to all relevant audiences: Packagers & the JS community.17:53
sigmavirus24krotscheck: won't happen17:53
krotscheckI think it's possible.17:53
openstackgerritDoug Hellmann proposed openstack/oslo.utils: Clean up TestIsIPv6Enabled  https://review.openstack.org/16692417:53
sigmavirus24krotscheck: use JS{L,H}int and see how far you get ;P17:54
dhellmannjd__, haypo, dims : I found a work-around17:54
harlowjakrotscheck https://github.com/kennethreitz/requests/pull/1812 ;)17:54
* dhellmann didn't plan to spend his day fiddling with old unit tests17:54
krotschecksigmavirus24: You mean eslint?17:54
krotscheck:D17:54
sigmavirus24krotscheck: the community prefers JSHint and that's the standard you should be using17:55
sigmavirus24=P17:55
sigmavirus24harlowja: yep17:55
harlowja^ fun read ;-P17:55
krotscheckYour logical fallacy is straw man. We're not talking about tooling choices.17:55
krotscheckWe're talking about making a single javascript project's codebase trustworthy enough for packagers, but still deployable to either npm or bower.17:56
sigmavirus24krotscheck: there are common grounds you won't find is all I'm saying17:56
harlowjado packagers have trust issues?17:56
harlowjamaybe they should see someone about that17:56
harlowja^ thats my recommended fix, lol17:56
*** achanda has quit IRC17:57
*** stevemar has quit IRC18:02
*** stevemar has joined #openstack-oslo18:03
*** ChuckC has quit IRC18:08
*** achanda has joined #openstack-oslo18:15
*** flashgordon is now known as jogo18:16
openstackgerritJoshua Harlow proposed openstack/oslo.messaging: Use the oslo_utils stop watch in decaying timer  https://review.openstack.org/16695118:17
*** harlowja has quit IRC18:18
*** achanda has quit IRC18:19
*** achanda has joined #openstack-oslo18:20
*** harlowja has joined #openstack-oslo18:21
openstackgerritMerged openstack/taskflow: Allow using shallow copy instead of deep copy  https://review.openstack.org/16569318:23
openstackgerritMerged openstack/taskflow: By default use a in memory backend (when none is provided)  https://review.openstack.org/16565418:27
*** achanda has quit IRC18:27
*** achanda has joined #openstack-oslo18:28
openstackgerritJoshua Harlow proposed openstack/taskflow: Just unify having a single requirements.txt file  https://review.openstack.org/16452318:34
*** vigneshvar has quit IRC18:54
*** tsekiyama is now known as tsekiyama_18:55
lifelessdhellmann: ask me wha?18:56
dhellmannlifeless: jd__ has a patch up to pbr to change the way environment markers are handled, basically stripping them out before sending the values to setuptools. I thought setuptools understood them, though, so didn't know why we would do that. According to mordred most of that part of the code is really not used and could probably be deleted since pip does understand the environment markers.19:01
*** tsekiyama_ is now known as tsekiyama19:02
*** mfedosin has quit IRC19:04
*** frickler has quit IRC19:04
*** SpamapS has quit IRC19:04
*** SpamapS has joined #openstack-oslo19:04
*** SpamapS has joined #openstack-oslo19:04
*** pasquier-s has quit IRC19:04
*** otherwiseguy has quit IRC19:04
*** frickler has joined #openstack-oslo19:04
*** mfedosin has joined #openstack-oslo19:04
*** pasquier-s has joined #openstack-oslo19:04
*** otherwiseguy has joined #openstack-oslo19:04
lifelessdhellmann: ack. jd__ - can you consult with dstufft on the rightness of that patch?19:09
jd__dhellmann: as I said on openstack-dev, as far as I can tell my patch works, if it's not clear, using pip install -e . it does what's expected19:11
jd__just a reminder if it wasn't clear :)19:11
dhellmannjd__: yeah, I think lifeless just came online and was catching up on the discussion19:12
*** sreshetn1 has joined #openstack-oslo19:18
*** rushiagr_away is now known as rushiagr19:23
*** prad has quit IRC19:32
*** rushiagr is now known as rushiagr_away19:34
*** alexpilotti has quit IRC19:39
*** ajo has joined #openstack-oslo19:43
openstackgerritJoshua Harlow proposed openstack/taskflow: Make the storage layer more resilent to failures  https://review.openstack.org/16699019:57
*** jgrimm is now known as zz_jgrimm20:05
openstackgerritJoshua Harlow proposed openstack/taskflow: Make the storage layer more resilent to failures  https://review.openstack.org/16699020:05
*** andreykurilin_ has joined #openstack-oslo20:15
*** kgiusti has left #openstack-oslo20:19
*** andreykurilin_ has quit IRC20:19
*** andreykurilin__ has joined #openstack-oslo20:19
*** e0ne has joined #openstack-oslo20:21
*** crc32 has joined #openstack-oslo20:22
*** crc32 has quit IRC20:23
*** amrith is now known as _amrith_20:27
*** ndipanov has quit IRC20:29
*** crc32 has joined #openstack-oslo20:36
*** andreykurilin__ has quit IRC20:37
*** andreykurilin_ has joined #openstack-oslo20:37
*** exploreshaifali_ has quit IRC20:41
*** stpierre has quit IRC20:46
*** jaypipes has quit IRC20:47
*** stpierre has joined #openstack-oslo20:48
*** stpierre has quit IRC20:48
*** stpierre has joined #openstack-oslo20:48
*** vipuls is now known as vipul20:49
*** jaypipes has joined #openstack-oslo20:52
*** fesp has joined #openstack-oslo20:56
*** jamielennox|away is now known as jamielennox21:02
*** cdent has quit IRC21:09
*** prad has joined #openstack-oslo21:20
*** sreshetn1 has quit IRC21:23
*** yamahata has quit IRC21:35
*** stpierre has quit IRC21:35
*** yamahata has joined #openstack-oslo21:36
*** exploreshaifali_ has joined #openstack-oslo21:36
*** yamahata has quit IRC21:37
*** yamahata has joined #openstack-oslo21:38
*** exploreshaifali_ has quit IRC21:39
dhellmannharlowja: I'm thinking about where to put the versionutils module when we graduate it. Can you imagine any scenario in which it would be useful to have a wrapper around debtcollector that knows about openstack versions? like, would we want to emit messages such as "this module is going away in M"?21:43
harlowjadhellmann either a wrapper or there could be a new decorator param 'to_log' or something that gets used also?21:44
harlowjaor wrapper + said param21:45
harlowjahttps://docs.python.org/2/library/logging.html#logging.captureWarnings exists, but its pretty primitivie (the impl is sorta not so great imho)21:45
dhellmannharlowja: yeah, I wasn't thinking of adding this to debtcollector, just trying to decide if a standalone lib made sense21:45
dhellmannit's too small to be worth that at this point, but if we were going to add to it I could see doing that21:45
lifelessjd__: yeah, so I'm confused if it works if you're stripping the environment markers ;)21:45
harlowjacould just be something small enough to include; seems well isolated21:45
dhellmannharlowja: it brings in a dependency on oslo.config, and ties debtcollector to openstack version names21:46
harlowjahmmm21:46
dhellmannI assumed we wouldn't want that for debtcollector as it is now21:46
harlowjahmmm, so whats the dependency on oslo.config for?21:47
harlowjaguess 'fatal_deprecations'21:47
dhellmannright21:47
dhellmannharlowja: I'll think about this more tomorrow, I need to go help prep the house for guests21:47
dhellmannharlowja: I'm thinking at this point that we just move it to oslo.log or oslo.config21:48
harlowjaif there is a 'logger' handle that gets passed in to debtcollector stuff, i'm wondering if that could just handle that configuration21:48
dhellmannone less tiny library21:48
harlowjaand then debtcollector just doesn't know about what that logger is doing21:48
dhellmannharlowja: the config option has to live somewhere, though21:48
dhellmannand if that lives somewhere, then the associated code might as well live there, too21:48
dhellmannand leave debtcollector independent of openstack21:48
* dhellmann has to run21:49
harlowjakk21:49
harlowjauntil next time!21:49
harlowjawill think about it21:49
harlowjawhy i think the logging.captureWarnings stuff not so good ( https://hg.python.org/releasing/3.4/file/8671f89107c8/Lib/logging/__init__.py#l1913 )21:50
harlowjasorta meh meh, monkey patchey21:50
harlowjabut maybe should be a oslo.version anyway, with all things releated to openstack versions/comparison functions...21:51
*** _amrith_ is now known as amrith21:55
openstackgerritMerged openstack/oslo.utils: Fix test_netutils: stop patches  https://review.openstack.org/16683521:57
*** sigmavirus24 is now known as sigmavirus24_awa22:07
*** andreykurilin_ has quit IRC22:15
openstackgerritJoshua Harlow proposed openstack/taskflow: Make the storage layer more resilent to failures  https://review.openstack.org/16699022:20
*** gordc has quit IRC22:23
openstackgerritEric Brown proposed openstack/oslo.config: Allow case insensitive compare of choice values  https://review.openstack.org/16702522:28
*** prad has quit IRC22:31
*** salv-orl_ has joined #openstack-oslo22:34
*** salv-orlando has quit IRC22:34
*** salv-orl_ has quit IRC22:38
openstackgerritJoshua Harlow proposed openstack/taskflow: Add ability to use tooz to find and advertise workers  https://review.openstack.org/15149522:40
*** jecarey has quit IRC22:41
*** salv-orlando has joined #openstack-oslo22:42
*** crc32 has quit IRC22:53
openstackgerritJoshua Harlow proposed openstack/taskflow: Allow providing a node stringify function to tree pformat  https://review.openstack.org/16704023:23
*** tsekiyam_ has joined #openstack-oslo23:32
*** tsekiyama has quit IRC23:35
*** mtanino has quit IRC23:35
*** tsekiyam_ has quit IRC23:36
*** zzzeek has quit IRC23:39
*** jaosorior has quit IRC23:42
*** dims_ has joined #openstack-oslo23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!