| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Use compilation helper objects https://review.openstack.org/161035 | 00:07 |
|---|---|---|
| *** zzzeek has quit IRC | 00:17 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Use tooz to find/advertise workers (WIP, need to drop 2.6) https://review.openstack.org/151495 | 00:22 |
| *** daniel3_ has quit IRC | 00:24 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 00:26 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Make the worker banner template part of the worker class https://review.openstack.org/161040 | 00:29 |
| *** jamespage has quit IRC | 00:45 | |
| *** jamespage has joined #openstack-oslo | 00:45 | |
| *** jamespage has quit IRC | 00:45 | |
| *** jamespage has joined #openstack-oslo | 00:45 | |
| *** tsekiyam_ has joined #openstack-oslo | 00:46 | |
| *** mtanino has quit IRC | 00:50 | |
| *** tsekiyama has quit IRC | 00:50 | |
| *** tsekiyam_ has quit IRC | 00:51 | |
| *** pasquier-s has quit IRC | 00:52 | |
| *** pasquier-s has joined #openstack-oslo | 00:53 | |
| openstackgerrit | Merged openstack/debtcollector: Format the method/class removals messages like the others https://review.openstack.org/155124 | 00:55 |
| *** stpierre has quit IRC | 00:56 | |
| openstackgerrit | Merged openstack/debtcollector: Add examples of using the new removals decorator https://review.openstack.org/155121 | 00:57 |
| *** jaosorior has quit IRC | 01:02 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 01:06 | |
| openstackgerrit | Merged openstack/debtcollector: Updated from global requirements https://review.openstack.org/160734 | 01:06 |
| *** crc32 has quit IRC | 01:11 | |
| openstackgerrit | Merged openstack/taskflow: Allow node finding to not do a deep search https://review.openstack.org/160965 | 01:14 |
| openstackgerrit | Min Pae proposed openstack/taskflow: Added a map and a reduce task https://review.openstack.org/157677 | 01:14 |
| *** dims_ has joined #openstack-oslo | 01:17 | |
| *** sputnik13 has quit IRC | 01:17 | |
| *** dims has quit IRC | 01:19 | |
| *** salv-orlando has quit IRC | 01:20 | |
| openstackgerrit | Joshua Harlow proposed openstack/debtcollector: Add a removed module deprecation helper https://review.openstack.org/154298 | 01:20 |
| openstackgerrit | Joshua Harlow proposed openstack/debtcollector: Add a removed module deprecation helper https://review.openstack.org/154298 | 01:21 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add a fully functional orderedset https://review.openstack.org/160219 | 01:21 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Allow using ordered(set/dict) to retain ordering https://review.openstack.org/160558 | 01:22 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Added a map and a reduce task https://review.openstack.org/157677 | 01:22 |
| openstackgerrit | Sabari proposed openstack/oslo.vmware: Copy missing tests to new oslo_vmware location https://review.openstack.org/161062 | 01:34 |
| *** pasquier-s has quit IRC | 01:34 | |
| *** achanda has quit IRC | 01:35 | |
| openstackgerrit | Sabari proposed openstack/oslo.vmware: Copy missing tests to new oslo_vmware location https://review.openstack.org/161062 | 01:37 |
| *** achanda has joined #openstack-oslo | 01:41 | |
| *** pasquier-s has joined #openstack-oslo | 01:42 | |
| openstackgerrit | Sabari proposed openstack/oslo.vmware: Move missing tests to new oslo_vmware location https://review.openstack.org/161062 | 01:42 |
| openstackgerrit | Sabari proposed openstack/oslo.vmware: Move missing tests to new oslo_vmware location https://review.openstack.org/161062 | 01:44 |
| *** pmathews has quit IRC | 01:46 | |
| *** pmathews has joined #openstack-oslo | 01:46 | |
| *** noelbk has quit IRC | 02:04 | |
| *** ChuckC has quit IRC | 02:04 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Use tooz to find/advertise workers (WIP, need to drop 2.6) https://review.openstack.org/151495 | 02:05 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Use tooz to find/advertise workers (WIP, need to drop 2.6) https://review.openstack.org/151495 | 02:12 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Use tooz to find/advertise workers (WIP, need to drop 2.6) https://review.openstack.org/151495 | 02:18 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Use tooz to find/advertise workers (WIP, need to drop 2.6) https://review.openstack.org/151495 | 02:20 |
| *** salv-orlando has joined #openstack-oslo | 02:20 | |
| *** achanda has quit IRC | 02:25 | |
| *** noelbk has joined #openstack-oslo | 02:30 | |
| *** stevemar has joined #openstack-oslo | 02:30 | |
| *** achanda has joined #openstack-oslo | 02:33 | |
| *** stevemar has quit IRC | 02:35 | |
| *** stevemar has joined #openstack-oslo | 02:36 | |
| *** ChuckC has joined #openstack-oslo | 02:49 | |
| *** ChuckC has quit IRC | 02:54 | |
| *** ChuckC has joined #openstack-oslo | 02:54 | |
| openstackgerrit | Merged openstack/cliff: Correct completion in interactive mode https://review.openstack.org/157944 | 02:59 |
| *** achanda has quit IRC | 03:05 | |
| *** ChuckC has quit IRC | 03:06 | |
| *** ChuckC has joined #openstack-oslo | 03:06 | |
| *** achanda has joined #openstack-oslo | 03:10 | |
| *** amrith is now known as _amrith_ | 03:11 | |
| *** noelbk has quit IRC | 03:12 | |
| *** dims_ has quit IRC | 03:17 | |
| *** harlowja_ is now known as harlowja_away | 03:21 | |
| *** jecarey has quit IRC | 03:21 | |
| *** salv-orlando has quit IRC | 03:21 | |
| *** _amrith_ is now known as amrith | 03:28 | |
| *** yamahata has quit IRC | 03:29 | |
| *** achanda has quit IRC | 03:30 | |
| *** koesik has joined #openstack-oslo | 03:51 | |
| *** achanda has joined #openstack-oslo | 03:55 | |
| *** breton_ has joined #openstack-oslo | 04:30 | |
| *** breton has quit IRC | 04:30 | |
| *** openstackgerrit has quit IRC | 04:46 | |
| *** openstackgerrit has joined #openstack-oslo | 04:52 | |
| *** jmeridth has quit IRC | 05:00 | |
| *** achanda has quit IRC | 05:28 | |
| *** jmeridth has joined #openstack-oslo | 05:30 | |
| *** openstack has joined #openstack-oslo | 05:36 | |
| *** salv-orlando has joined #openstack-oslo | 05:38 | |
| *** amotoki has joined #openstack-oslo | 05:43 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Use tooz to find/advertise workers (WIP, need to drop 2.6) https://review.openstack.org/151495 | 05:47 |
| *** sputnik13 has joined #openstack-oslo | 05:56 | |
| *** lbragstad has quit IRC | 06:08 | |
| *** lbragstad has joined #openstack-oslo | 06:10 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.utils: Imported Translations from Transifex https://review.openstack.org/160649 | 06:13 |
| *** achanda has joined #openstack-oslo | 06:16 | |
| *** lbragstad has quit IRC | 06:19 | |
| *** lbragstad has joined #openstack-oslo | 06:22 | |
| *** BrianShang_ has quit IRC | 06:24 | |
| *** sputnik13 has quit IRC | 06:29 | |
| *** salv-orlando has quit IRC | 06:29 | |
| *** YorikSar has joined #openstack-oslo | 06:49 | |
| *** jogo has quit IRC | 06:53 | |
| openstackgerrit | Merged openstack/taskflow: Add a frozen checking decorator https://review.openstack.org/160536 | 06:55 |
| openstackgerrit | Merged openstack/taskflow: Use compilation helper objects https://review.openstack.org/161035 | 06:55 |
| *** inc0 has joined #openstack-oslo | 06:58 | |
| openstackgerrit | Merged openstack/taskflow: Make the worker banner template part of the worker class https://review.openstack.org/161040 | 07:04 |
| *** lbragstad has quit IRC | 07:08 | |
| *** dulek has joined #openstack-oslo | 07:21 | |
| *** david-lyle_afk has joined #openstack-oslo | 07:33 | |
| *** vigneshvar has joined #openstack-oslo | 07:34 | |
| *** openstackgerrit has quit IRC | 07:49 | |
| *** openstackgerrit has joined #openstack-oslo | 07:49 | |
| *** amotoki has quit IRC | 07:57 | |
| *** amotoki has joined #openstack-oslo | 07:57 | |
| *** ajo has quit IRC | 08:02 | |
| *** shardy has joined #openstack-oslo | 08:12 | |
| *** achanda has quit IRC | 08:12 | |
| *** salv-orlando has joined #openstack-oslo | 08:15 | |
| *** e0ne has joined #openstack-oslo | 08:20 | |
| *** yamahata has joined #openstack-oslo | 08:26 | |
| *** vigneshvar has quit IRC | 08:30 | |
| -openstackstatus- NOTICE: Zuul check queue stuck due to reboot maintenance window at one of our cloud providers - no need to recheck changes at the moment, they won't move forward. | 08:31 | |
| *** ChanServ changes topic to "Zuul check queue stuck due to reboot maintenance window at one of our cloud providers - no need to recheck changes at the moment, they won't move forward." | 08:31 | |
| *** ajo has joined #openstack-oslo | 08:38 | |
| *** e0ne has quit IRC | 08:42 | |
| *** vigneshvar has joined #openstack-oslo | 08:45 | |
| *** salv-orlando has quit IRC | 08:45 | |
| *** salv-orlando has joined #openstack-oslo | 08:45 | |
| *** achanda has joined #openstack-oslo | 08:52 | |
| YorikSar | ttx: ping | 08:55 |
| ttx | YorikSar: pong | 08:56 |
| YorikSar | ttx: Have you seen CR https://review.openstack.org/#/c/160130/ ? | 08:58 |
| ttx | I saw it was posted, no time to review yet, on my todo list for today | 08:58 |
| YorikSar | ttx: Terry found a problem with rootwrap daemon: it's both too strict and too allowing with environment variables. | 08:59 |
| ttx | checking now | 08:59 |
| YorikSar | ttx: It's not the CR itself that I'd like to bring to your attention but this problem: sudo filters environment variables on whitelist basis, but daemon mode bypasses this check entirely. | 09:00 |
| *** exploreshaifali has joined #openstack-oslo | 09:00 | |
| ttx | YorikSar: could we copy the env from the initial sudo invocation? | 09:00 |
| *** jaosorior has joined #openstack-oslo | 09:01 | |
| YorikSar | ttx: We could, but users want to add some env vars to their processes (change LC_ALL, for example), so we have to support adding some vars, but then we need to filter them ourselves on daemon side to not allow bad env vars. | 09:02 |
| ttx | Hm. Looks like that's what the patch does, in a convoluted way | 09:02 |
| ttx | YorikSar: couldn't we require that the whitelist them in sudoers ? | 09:03 |
| ttx | they* | 09:03 |
| YorikSar | ttx: Yes, it fixes one part of the problem (too strict): it allows PATH to be propagated to command so that e.g. 'ip netns exec' find proper executables. | 09:03 |
| YorikSar | ttx: We can, but since daemon is reused for several (or all) command invocations, one may want to run commands that require different environments for different commands. | 09:04 |
| ttx | YorikSar: not sure I follow that use case | 09:05 |
| ttx | YorikSar: could you give a practical example that would lead to the need for us to filter ? | 09:05 |
| ttx | (per-command env addition generally goes through EnvFilter) | 09:06 |
| YorikSar | ttx: Take Neutron for instance (where Terry tripped over this). It runs dnsmasq with LC_ALL=C, but other commands go with no env modifications. | 09:06 |
| ttx | sure, and it uses an env filter to do so ? | 09:07 |
| * ttx looks at code | 09:07 | |
| *** openstack has joined #openstack-oslo | 15:28 | |
| dhellmann | YorikSar: ok, that makes me feel a bit more confident | 15:28 |
| dhellmann | YorikSar: when was 1.3 released, was that last cycle? | 15:29 |
| mdbooth | https://review.openstack.org/#/c/146228/9 | 15:33 |
| mdbooth | Assuming zzzeek is happy with my minor changes, what's the likely timescale for that landing? | 15:33 |
| YorikSar | dhellmann: Yes, daemon mode landed in Juno | 15:34 |
| openstackgerrit | Merged openstack/oslo-incubator: Update release tool for governance change https://review.openstack.org/156238 | 15:41 |
| openstackgerrit | Merged openstack/oslo-incubator: script to list the latest release of each library https://review.openstack.org/152332 | 15:42 |
| openstackgerrit | Merged openstack/oslo-incubator: Remove obsolete comments from tool scripts https://review.openstack.org/152637 | 15:42 |
| *** amrith is now known as _amrith_ | 15:44 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo-incubator: Move the release_notes.py script to release-tools https://review.openstack.org/161274 | 15:45 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo-incubator: Update projects ignored for unreleased changes https://review.openstack.org/161275 | 15:45 |
| *** YorikSar has quit IRC | 15:47 | |
| *** pmathews has joined #openstack-oslo | 15:49 | |
| *** dulek has joined #openstack-oslo | 15:49 | |
| *** daniel3_ has joined #openstack-oslo | 15:49 | |
| *** ChuckC_ has joined #openstack-oslo | 15:54 | |
| *** lbragstad has joined #openstack-oslo | 15:56 | |
| *** ihrachyshka has quit IRC | 15:58 | |
| *** tsekiyama has joined #openstack-oslo | 16:05 | |
| *** jungleboyj has joined #openstack-oslo | 16:12 | |
| *** ihrachyshka has joined #openstack-oslo | 16:13 | |
| *** ihrachyshka has quit IRC | 16:15 | |
| *** ihrachyshka has joined #openstack-oslo | 16:15 | |
| openstackgerrit | Merged openstack/oslo.db: Use PyMySQL as DB driver in py3 environment https://review.openstack.org/133962 | 16:31 |
| *** dulek has quit IRC | 16:32 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add ability to use tooz to find and advertise workers https://review.openstack.org/151495 | 16:35 |
| *** jaypipes has joined #openstack-oslo | 16:40 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add ability to use tooz to find and advertise workers https://review.openstack.org/151495 | 16:44 |
| *** _amrith_ is now known as amrith | 16:44 | |
| *** dtantsur is now known as dtantsur|afk | 16:51 | |
| *** YorikSar has joined #openstack-oslo | 16:53 | |
| stevemar | dhellmann, say, if the only patch left in oslo policy is WIP, did we want to cut another release, 0.3.0? and formally announce? or still want it to bake a bit longer? | 16:55 |
| *** ihrachyshka has quit IRC | 16:59 | |
| dhellmann | stevemar: that's the thing with the removed option, isn't it? | 17:02 |
| stevemar | dhellmann, yeppers | 17:02 |
| dhellmann | dims, jd__: can you look at https://review.openstack.org/#/c/160475/ for us? it's a blocker on oslo.policy's first public release | 17:02 |
| dhellmann | stevemar: let's get a version of oslo.config in place that will let us mark that option as deprecated instead of just deleting it | 17:03 |
| dhellmann | jd__: thanks | 17:04 |
| *** amotoki has quit IRC | 17:04 | |
| dhellmann | stevemar: we should be able to release oslo.config today, then update sdague's patch to mark the option deprecated, then release oslo.policy | 17:05 |
| stevemar | dhellmann, hehe, it's so funny how quickly things can move when you ask the right people :) | 17:05 |
| dhellmann | stevemar: I think we caught jd__ at a good time :-) | 17:05 |
| jd__ | :) | 17:05 |
| stevemar | dhellmann, the logistics sounds right, want me to update g-r with the new config version? | 17:06 |
| dhellmann | stevemar: yes, when we cut it if you make that patch I can +2 it | 17:06 |
| stevemar | \o/ | 17:07 |
| *** amrith is now known as _amrith_ | 17:12 | |
| *** e0ne is now known as e0ne_ | 17:12 | |
| *** e0ne_ is now known as e0ne | 17:12 | |
| -openstackstatus- NOTICE: Issue solved, gate slowly digesting accumulated changes | 17:16 | |
| *** e0ne is now known as e0ne_ | 17:23 | |
| *** pmathews has quit IRC | 17:31 | |
| *** cdent has quit IRC | 17:33 | |
| *** e0ne has joined #openstack-oslo | 17:41 | |
| *** e0ne has quit IRC | 17:41 | |
| *** pmathews has joined #openstack-oslo | 17:47 | |
| *** zzzeek has joined #openstack-oslo | 17:51 | |
| *** stpierre has joined #openstack-oslo | 17:51 | |
| *** achanda has joined #openstack-oslo | 17:54 | |
| openstackgerrit | Merged openstack/oslo.config: Add ability to deprecate opts for removal https://review.openstack.org/160475 | 18:05 |
| *** sputnik13 has joined #openstack-oslo | 18:06 | |
| *** pmathews has quit IRC | 18:15 | |
| dims | dhellmann: looks like that went through. | 18:18 |
| *** harlowja_away is now known as harlowja_ | 18:19 | |
| *** e0ne has joined #openstack-oslo | 18:22 | |
| dhellmann | dims: yep, just finished lunch so I'll go ahead and do the release now | 18:25 |
| *** yassine has quit IRC | 18:28 | |
| *** YorikSar has quit IRC | 18:31 | |
| kragniz | dhellmann: I love the new amount of emotion in the oslo release notices :P | 18:32 |
| dims | kragniz: we can add more :) http://git.openstack.org/cgit/openstack/oslo-incubator/tree/tools/release_notes.py#n29 | 18:35 |
| kragniz | dims: yeah, I saw the commit when they were added | 18:35 |
| kragniz | I like them :) | 18:35 |
| dims | kragniz: have you seen the docker folks generating names for containers? :) https://github.com/docker/docker/blob/master/pkg/namesgenerator/names-generator.go | 18:39 |
| kragniz | dims: no, I hadn't seen that! | 18:39 |
| dhellmann | stevemar: oslo.config 1.9.0 is released and sdague's patch in policy is un-WIP-ed so you two can coordinate reworking it | 18:40 |
| stevemar | dhellmann, roger doger | 18:40 |
| bnemec | I was just going to comment on how much I <3 the new release notes, but I see I was beaten to the punch. :-) | 18:41 |
| stevemar | bnemec, who isn't pumped for new releases! | 18:44 |
| bnemec | stevemar: Exactly! :-) | 18:45 |
| *** ChuckC_ has quit IRC | 18:46 | |
| dims | :) | 18:48 |
| *** jogo has joined #openstack-oslo | 18:51 | |
| sdague | stevemar: I'm not sure I'll have time to get to the patch until the morning, so feel free to respin it today yourself if you need it earlier | 18:52 |
| harlowja_ | if someone gets some free time, can https://review.openstack.org/#/c/154298/ be looked over, would be nice to get another debtcollector release out with that (less code taskflow has that is similar/same) | 18:54 |
| harlowja_ | thx much | 18:55 |
| harlowja_ | lol, pumped for oslo.config | 18:55 |
| harlowja_ | lol | 18:55 |
| harlowja_ | oh ya | 18:55 |
| harlowja_ | https://review.openstack.org/#/c/154311/ would be another cool one to get in (maybe dims u have time for that?) | 18:58 |
| dims | harlowja_: looking | 19:01 |
| harlowja_ | cool | 19:01 |
| stevemar | sdague, yeah, i just might | 19:02 |
| *** alexpilotti_ has joined #openstack-oslo | 19:02 | |
| openstackgerrit | Darragh Bailey proposed openstack-dev/pbr: Allow overwriting sphinx builder from command line https://review.openstack.org/117478 | 19:03 |
| *** alexpilotti has quit IRC | 19:03 | |
| *** alexpilotti_ is now known as alexpilotti | 19:03 | |
| *** e0ne is now known as e0ne_ | 19:05 | |
| *** e0ne_ has quit IRC | 19:05 | |
| *** sputnik13 has quit IRC | 19:06 | |
| *** _amrith_ is now known as amrith | 19:07 | |
| *** stevemar has quit IRC | 19:07 | |
| *** stevemar has joined #openstack-oslo | 19:08 | |
| *** sputnik13 has joined #openstack-oslo | 19:09 | |
| dims | harlowja_: elapses() uses "if self._state not in (self._STOPPED, self._STARTED):" | 19:15 |
| *** e0ne has joined #openstack-oslo | 19:16 | |
| dims | harlowja_: expired() uses "if self._state is None:" | 19:16 |
| *** ChanServ changes topic to "#openstack-oslo" | 19:16 | |
| dims | harlowja_: want to standardize on one or other? | 19:16 |
| *** e0ne is now known as e0ne_ | 19:16 | |
| harlowja_ | ya, think that makes sense | 19:16 |
| harlowja_ | good catch | 19:16 |
| dims | harlowja_: split()'s if condition is just for _STARTED, but RuntimeError message talks about started/stopped | 19:17 |
| harlowja_ | right, because u can't create a split time of a stopwatch if its not running (if it has not been started or if it has been stopped) | 19:19 |
| *** e0ne_ is now known as e0ne | 19:20 | |
| harlowja_ | the states are (started, stopped, None -> not ever started/stopped) | 19:20 |
| dims | ok | 19:20 |
| dims | is there a way or a need to check if this StopWatch has started? | 19:20 |
| harlowja_ | sure, i can expose a function has_started() | 19:21 |
| dims | since someone who wants to call resume() may want to check before calling it | 19:21 |
| harlowja_ | sure | 19:21 |
| jogo | I think nova/openstack/common/versionutils.py is breaking genconfig for nova | 19:24 |
| *** sputnik13 has quit IRC | 19:24 | |
| *** sputnik13 has joined #openstack-oslo | 19:25 | |
| jogo | http://paste.openstack.org/show/188020/ | 19:25 |
| dims | jogo: https://review.openstack.org/#/c/159646/ | 19:25 |
| dims | harlowja_: need a test for __enter__ / __exit__? | 19:25 |
| harlowja_ | def test_context_manager(self, mock_now): ? | 19:25 |
| dims | jogo: i have a running bug - https://bugs.launchpad.net/nova/+bug/1424576 | 19:25 |
| openstack | Launchpad bug 1424576 in OpenStack Compute (nova) "RuntimeError: Unable to find group for option fatal_deprecations, maybe it's defined twice in the same group?" [Low,In progress] - Assigned to Davanum Srinivas (DIMS) (dims-v) | 19:25 |
| dims | harlowja_: oops sorry, could add a split() in that test? | 19:27 |
| harlowja_ | sure | 19:27 |
| dims | thanks harlowja_ | 19:28 |
| harlowja_ | sureee | 19:28 |
| *** sputnik13 has quit IRC | 19:29 | |
| jogo | dims: thanks | 19:29 |
| dims | jogo: please consider https://review.openstack.org/#/c/159685/ as a stop-gap and we can get started on trying to using oslo-config-generator | 19:30 |
| dims | jogo: that review is against nova | 19:30 |
| *** sputnik13 has joined #openstack-oslo | 19:33 | |
| *** daniel3_ has quit IRC | 19:35 | |
| *** sputnik13 has quit IRC | 19:35 | |
| *** daniel3_ has joined #openstack-oslo | 19:36 | |
| *** sputnik13 has joined #openstack-oslo | 19:37 | |
| *** sputnik13 has quit IRC | 19:43 | |
| *** sputnik13 has joined #openstack-oslo | 19:44 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add node removal/disassociate functions https://review.openstack.org/161376 | 19:50 |
| *** zz_jgrimm is now known as jgrimm | 19:51 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add node removal/disassociate functions https://review.openstack.org/161376 | 19:54 |
| *** sputnik13 has quit IRC | 19:55 | |
| *** e0ne is now known as e0ne_ | 19:55 | |
| *** sputnik13 has joined #openstack-oslo | 19:56 | |
| *** harlowja_ has quit IRC | 19:57 | |
| *** devlaps has joined #openstack-oslo | 19:58 | |
| *** harlowja has joined #openstack-oslo | 20:01 | |
| *** e0ne_ has quit IRC | 20:01 | |
| *** jaypipes has quit IRC | 20:01 | |
| *** jaypipes has joined #openstack-oslo | 20:02 | |
| *** e0ne has joined #openstack-oslo | 20:05 | |
| *** achanda has quit IRC | 20:07 | |
| *** yamahata has quit IRC | 20:11 | |
| *** andreykurilin_ has joined #openstack-oslo | 20:13 | |
| dims | harlowja: what do you have in your quiver how to construct a list comprehension, with unique items | 20:16 |
| harlowja | hmmm, not much for uniques | 20:17 |
| harlowja | https://docs.python.org/2/library/itertools.html has an example | 20:17 |
| harlowja | http://paste.ubuntu.com/10530687/ | 20:18 |
| harlowja | that might work for u | 20:18 |
| dims | thanks, will try | 20:18 |
| harlowja | seems like https://pypi.python.org/pypi/more-itertools has all those recipes | 20:19 |
| harlowja | maybe we should add that to requirements | 20:19 |
| harlowja | so people don't cut/copy that code | 20:19 |
| harlowja | https://github.com/erikrose/more-itertools/blob/master/more_itertools/recipes.py#L224 | 20:19 |
| harlowja | seems like a useful pypi package | 20:20 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.db: Updated from global requirements https://review.openstack.org/161394 | 20:22 |
| dhellmann | if anyone is interested, the logging working group is meeting in #openstack-meeting-4 and oslo.log has come up several times | 20:26 |
| *** dims has quit IRC | 20:29 | |
| *** dims has joined #openstack-oslo | 20:29 | |
| *** andreykurilin_ has quit IRC | 20:30 | |
| openstackgerrit | Joshua Harlow proposed openstack/oslo.utils: Add a stopwatch + split for duration(s) https://review.openstack.org/154311 | 20:31 |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.policy: deprecate policy_dirs option https://review.openstack.org/161405 | 20:31 |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.policy: deprecate policy_dirs option https://review.openstack.org/160407 | 20:32 |
| dims | dhellmann: ack, joined meeting-4 | 20:33 |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.policy: deprecate policy_dirs option https://review.openstack.org/160407 | 20:33 |
| stevemar | dhellmann, sdague ^ not sure what else is expected on that one, maybe a test to check if the warning is written to the log? cc sigmavirus24 | 20:35 |
| sigmavirus24 | stevemar: at that point you're testing oslo.log's behaviour which seems over-the-top | 20:38 |
| stevemar | sigmavirus24, yeah ... | 20:39 |
| sigmavirus24 | like, we trust oslo.log to do that the right way so I don't think we need a test there | 20:39 |
| stevemar | sigmavirus24, i made the change, looked at `git diff`, and was wondering if i should both to add anything else | 20:39 |
| sigmavirus24 | (or at least, I trust oslo.log) | 20:39 |
| sigmavirus24 | yeah I'm not sure what else we could add :/ | 20:40 |
| sigmavirus24 | Maybe notes around the usage in Enforcer? | 20:40 |
| sigmavirus24 | i.e., # NOTE(stevemar): When policy.d is fully removed, remove this | 20:40 |
| stevemar | meh, i'll let the big guns weigh in on it | 20:40 |
| sigmavirus24 | but I doubt it | 20:40 |
| stevemar | tru tru | 20:40 |
| stevemar | we could just check the git commit history to see when the change was made, not sure when we are going to remove it | 20:41 |
| stevemar | i assume it'll be in 2 release cycles | 20:41 |
| *** achanda has joined #openstack-oslo | 20:41 | |
| *** exploreshaifali has quit IRC | 20:44 | |
| openstackgerrit | Joshua Harlow proposed openstack/oslo.utils: Add a stopwatch + split for duration(s) https://review.openstack.org/154311 | 20:47 |
| bnemec | Heh, deprecated_for_removal is a hit. You might even say people are pumped about it. ;-) | 20:47 |
| dims | lol! | 20:47 |
| openstackgerrit | Ben Nemec proposed openstack/oslo.policy: deprecate policy_dirs option https://review.openstack.org/160407 | 20:56 |
| *** jungleboyj has quit IRC | 20:59 | |
| stevemar | thanks bnemec | 21:00 |
| stevemar | just gotta wait for g-r to be updated | 21:00 |
| bnemec | Oh, that's right. I should WIP that until the requirements are correct. It will break on older versions of oslo.config. | 21:01 |
| sdague | stevemar / dhellmann what do we believe a sufficient deprecation cycle is for this? | 21:03 |
| sdague | because it actually seems like we should keep my original patch, put stevemar's patch under it. Merge his. Procedurally block mine until it's allowed to delete | 21:04 |
| dhellmann | sdague: yeah, that's a good approach | 21:07 |
| * dhellmann checks the deprecation rules on config options | 21:07 | |
| stevemar | dhellmann, sdague, i was assuming that it's a full cycles? it's super long but i think necessary | 21:07 |
| sdague | we could also leave a # delete in L or something in there | 21:08 |
| sdague | stevemar: well, this was very recently added | 21:08 |
| dhellmann | if we count it as added in juno and deprecated by some projects in kilo, we should probably wait until all projects have adopted the library before actually removing it so that makes it M? | 21:09 |
| dhellmann | or N? | 21:09 |
| dhellmann | it would help to know how many projects actually have the option from the incubated version, too | 21:09 |
| sdague | it seems weird to let projects get it added in. We should do the deprecate in the incubator as well I suppose | 21:10 |
| dhellmann | sdague, stevemar : http://paste.openstack.org/show/188113/ | 21:10 |
| sdague | man, neutron is way back? | 21:11 |
| dhellmann | at this point changing the incubator means changing stable/juno because we've deleted the module from the incubator | 21:11 |
| *** amrith is now known as _amrith_ | 21:11 | |
| dhellmann | well, since it's such a new option let's mark it for deprecation in the lib in kilo and remove it in M | 21:11 |
| sdague | yeh, that seems good | 21:11 |
| dhellmann | everyone should adopt the lib by the end of Liberty, which gives notice, and then in M it'll go away | 21:12 |
| sdague | so given that duration, lets just add a comment about when to delete it | 21:12 |
| sdague | because I won't have patience to have an open patch for 8 months | 21:12 |
| dhellmann | a WIP in patch would be good, since we have something to work with already, and we can just block it until M opens | 21:12 |
| dhellmann | hrm | 21:12 |
| stevemar | i'll add a quick comment in the code | 21:13 |
| dhellmann | stevemar: if you're just adding a comment, we should have a bug, too | 21:13 |
| stevemar | dhellmann, yep, with more comments in there too. agree with sdague - i don't like open patches for that long | 21:14 |
| dhellmann | ok | 21:14 |
| dhellmann | sounds like we have our plan, then? | 21:14 |
| *** e0ne has quit IRC | 21:14 | |
| bnemec | ++M | 21:14 |
| sdague | dhellmann: yep, sounds like a plan | 21:15 |
| harlowja | i'm pumped about all of this | 21:15 |
| harlowja | lol | 21:15 |
| dhellmann | sdague, stevemar : thanks | 21:15 |
| dhellmann | harlowja: :-P | 21:16 |
| sigmavirus24 | So, is there a good way to load driver-specific options without loading the driver itself with oslo.config/stevedore? (glance_store currently loads each driver even though their dependencies are optional and not in requirements.txt: https://github.com/openstack/glance_store/blob/c5eb4fc54dd4adb8c52a089c3591dc9d0ef1cc50/glance_store/backend.py#L61) | 21:16 |
| *** alexpilotti has quit IRC | 21:17 | |
| dhellmann | sigmavirus24: the config generator rule is that if you have an option defined in your file, that file needs to be importable even if the dependencies of the driver that use the option are not | 21:17 |
| sigmavirus24 | dhellmann: okay | 21:17 |
| dhellmann | sigmavirus24: you can address that either by making the imports optional in the driver, or by putting the options in a separate file | 21:17 |
| dhellmann | both approaches have their pros and cons, so it's really up to you | 21:17 |
| mriedem | sigmavirus24: yeah, probably should be the former | 21:17 |
| mriedem | that's what the gridfs driver does with pymongo | 21:18 |
| sigmavirus24 | thank you dhellmann, those were the only ideas I could think of but wasn't sure if I was missing something | 21:18 |
| dhellmann | sigmavirus24: great minds something something | 21:18 |
| sigmavirus24 | mriedem: I'll look at the s3 driver then to see if I can send a fix for this | 21:18 |
| sigmavirus24 | Thanks dhellmann | 21:18 |
| dhellmann | sigmavirus24: any time! | 21:18 |
| *** achanda has quit IRC | 21:19 | |
| * bnemec wants an "Olso: We're here to PUMP YOU UP!" shirt | 21:20 | |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.policy: deprecate policy_dirs option https://review.openstack.org/160407 | 21:20 |
| stevemar | sdague, dhellmann quickly made the bug https://bugs.launchpad.net/oslo.policy/+bug/1428332 and updated the patch https://review.openstack.org/#/c/160407/ | 21:21 |
| openstack | Launchpad bug 1428332 in oslo.policy "remove the policy_dirs option" [Undecided,New] | 21:21 |
| sdague | stevemar: +1, thanks | 21:21 |
| dhellmann | stevemar: thanks! | 21:22 |
| stevemar | oh sdague if you could look @ https://review.openstack.org/#/c/161353/ that would speed up the policy patch :) | 21:24 |
| stevemar | bah the gate is taking long anyway, we have time i suppose | 21:24 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.config: Expand and clean up documentation for the config generator https://review.openstack.org/161425 | 21:29 |
| dhellmann | sigmavirus24: ^^ | 21:29 |
| dhellmann | stevemar: you can also mark your policy patch as Depends-On the g-r change | 21:30 |
| sigmavirus24 | dhellmann++ | 21:30 |
| dhellmann | sigmavirus24: we're always looking for holes in the docs, so let me know if you have more questions :-) | 21:31 |
| sigmavirus24 | dhellmann: will do! | 21:31 |
| *** exploreshaifali has joined #openstack-oslo | 21:32 | |
| *** ChuckC has joined #openstack-oslo | 21:32 | |
| stevemar | dhellmann, what is this depends on magic? | 21:34 |
| openstackgerrit | Dan Krause proposed openstack/taskflow: Persistence backend refactor https://review.openstack.org/160889 | 21:34 |
| dhellmann | stevemar: let me find the reference... | 21:34 |
| dhellmann | stevemar: http://lists.openstack.org/pipermail/openstack-dev/2015-February/056515.html | 21:35 |
| stevemar | ohhh cross repo dep. | 21:35 |
| stevemar | nice | 21:35 |
| stevemar | sure, i'll give it a shot | 21:36 |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.policy: deprecate policy_dirs option https://review.openstack.org/160407 | 21:37 |
| dhellmann | stevemar: +2a so let's see what it does :-) | 21:39 |
| stevemar | yeah, excited to see what happens | 21:40 |
| *** zzzeek has quit IRC | 21:44 | |
| *** zzzeek has joined #openstack-oslo | 21:46 | |
| *** dhellmann has quit IRC | 21:52 | |
| *** dhellmann has joined #openstack-oslo | 21:55 | |
| *** dhellmann has quit IRC | 21:56 | |
| *** dhellmann has joined #openstack-oslo | 21:57 | |
| *** kgiusti has left #openstack-oslo | 21:58 | |
| *** harlowja has quit IRC | 21:58 | |
| *** stevemar2 has joined #openstack-oslo | 21:59 | |
| *** stevemar has quit IRC | 22:00 | |
| *** crc32 has joined #openstack-oslo | 22:01 | |
| *** ChuckC has quit IRC | 22:11 | |
| *** achanda has joined #openstack-oslo | 22:20 | |
| *** e0ne has joined #openstack-oslo | 22:22 | |
| *** _amrith_ is now known as amrith | 22:22 | |
| *** jgrimm is now known as zz_jgrimm | 22:23 | |
| *** achanda has quit IRC | 22:26 | |
| *** harlowja has joined #openstack-oslo | 22:28 | |
| *** e0ne has quit IRC | 22:30 | |
| *** mriedem is now known as mriedem-away | 22:30 | |
| *** exploreshaifali has quit IRC | 22:31 | |
| *** jogo has quit IRC | 22:41 | |
| *** jogo has joined #openstack-oslo | 22:42 | |
| *** bknudson has quit IRC | 22:50 | |
| *** jecarey_ has quit IRC | 22:54 | |
| *** crc32 has quit IRC | 22:55 | |
| *** stpierre has quit IRC | 23:02 | |
| openstackgerrit | Merged openstack/oslotest: Force rebuild egg-info before running cross tests https://review.openstack.org/158382 | 23:04 |
| *** alexpilotti has joined #openstack-oslo | 23:06 | |
| *** jaypipes has quit IRC | 23:09 | |
| *** gordc has quit IRC | 23:09 | |
| *** jungleboyj has joined #openstack-oslo | 23:18 | |
| *** alexpilotti has quit IRC | 23:26 | |
| *** crc32 has joined #openstack-oslo | 23:33 | |
| *** stevemar2 is now known as stevemar | 23:38 | |
| *** pmathews has joined #openstack-oslo | 23:39 | |
| *** achanda has joined #openstack-oslo | 23:40 | |
| *** jungleboyj has quit IRC | 23:46 | |
| openstackgerrit | Merged openstack/oslo.log: Make use_syslog=True log to syslog via /dev/log https://review.openstack.org/159606 | 23:47 |
| *** bknudson has joined #openstack-oslo | 23:52 | |
| *** yamahata has joined #openstack-oslo | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!