Monday, 2015-02-23

« Sunday, 2015-02-22 Index Tuesday, 2015-02-24 »
*** amotoki has joined #openstack-oslo00:53
*** harlowja_at_home has joined #openstack-oslo01:06
*** boris-42 has joined #openstack-oslo01:13
*** achanda has quit IRC01:21
*** salv-orlando has quit IRC01:22
*** kbyrne has quit IRC01:23
openstackgerritJoshua Harlow proposed openstack/oslo.utils: Allow providing a logger to save_and_reraise_exception  https://review.openstack.org/15815801:23
*** kbyrne has joined #openstack-oslo01:25
*** dimsum__ has joined #openstack-oslo01:38
*** dims_ has joined #openstack-oslo01:39
*** dimsum__ has quit IRC01:43
*** amotoki has quit IRC01:44
openstackgerritMerged openstack-dev/hacking: Updated from global requirements  https://review.openstack.org/15775801:44
openstackgerritJoshua Harlow proposed openstack/taskflow: Use oslo.utils encodeutils for encode/decode functions  https://review.openstack.org/15814301:48
openstackgerritJoshua Harlow proposed openstack/taskflow: Use oslo.utils encodeutils for encode/decode functions  https://review.openstack.org/15814301:54
openstackgerritMerged openstack/oslotest: Updated from global requirements  https://review.openstack.org/15778901:54
openstackgerritMerged openstack/oslo-incubator: Updated from global requirements  https://review.openstack.org/15777701:54
*** stevemar has joined #openstack-oslo02:21
*** achanda has joined #openstack-oslo02:22
*** achanda has quit IRC02:27
*** achanda has joined #openstack-oslo02:27
*** yamahata has quit IRC02:32
*** yamahata has joined #openstack-oslo02:32
openstackgerritMerged openstack/oslo.middleware: Update the list of packages in setup.cfg  https://review.openstack.org/15795402:34
openstackgerritMerged openstack/oslo.rootwrap: Updated from global requirements  https://review.openstack.org/15778502:35
*** achanda has quit IRC02:38
openstackgerritMerged openstack/oslo.utils: Updated from global requirements  https://review.openstack.org/15778702:40
openstackgerritMerged openstack/oslo.concurrency: Updated from global requirements  https://review.openstack.org/15777802:42
openstackgerritMerged openstack/oslo.config: Updated from global requirements  https://review.openstack.org/15777902:46
openstackgerritMerged openstack/oslo.config: Log a warning when deprecated opts are used  https://review.openstack.org/14802002:46
*** yamahata has quit IRC02:46
openstackgerritMerged openstack/tooz: Updated from global requirements  https://review.openstack.org/15780402:46
openstackgerritMerged openstack/oslo.serialization: Updated from global requirements  https://review.openstack.org/15778602:48
openstackgerritMerged openstack/oslo.db: Updated from global requirements  https://review.openstack.org/15778002:48
openstackgerritMerged openstack/oslo.i18n: Updated from global requirements  https://review.openstack.org/15778102:50
*** himangi has quit IRC02:58
openstackgerritMerged openstack/oslo.vmware: Updated from global requirements  https://review.openstack.org/15778802:58
*** amrith is now known as _amrith_03:01
openstackgerritJoshua Harlow proposed openstack/taskflow: Use oslo.utils encodeutils for encode/decode functions  https://review.openstack.org/15814303:01
*** mriedem has left #openstack-oslo03:06
*** mriedem has quit IRC03:06
*** amotoki has joined #openstack-oslo03:19
*** diga has joined #openstack-oslo03:32
*** diga has quit IRC03:37
openstackgerritMerged openstack/oslo.log: Updated from global requirements  https://review.openstack.org/15778203:38
*** harlowja_at_home has quit IRC03:53
*** _amrith_ is now known as amrith04:04
*** himangi has joined #openstack-oslo04:52
*** rushiagr_away is now known as rushiagr04:56
openstackgerritJoshua Harlow proposed openstack/taskflow: Refactor parts of the periodic worker  https://review.openstack.org/15809605:05
*** vigneshvar has joined #openstack-oslo05:13
openstackgerritJoshua Harlow proposed openstack/taskflow: Refactor parts of the periodic worker  https://review.openstack.org/15809605:30
*** achanda has joined #openstack-oslo05:35
*** pcaruana has quit IRC05:45
*** rushiagr is now known as rushiagr_away06:20
*** achanda has quit IRC06:25
*** ajo has joined #openstack-oslo06:44
*** achanda has joined #openstack-oslo06:56
*** himangi has quit IRC06:58
*** stevemar has quit IRC07:19
*** inc0 has joined #openstack-oslo07:25
*** rushiagr_away is now known as rushiagr07:34
*** ajo has quit IRC07:38
*** achanda has quit IRC07:42
*** noelbk has joined #openstack-oslo07:44
*** noelbk has quit IRC07:47
*** achanda has joined #openstack-oslo07:48
*** e0ne has joined #openstack-oslo07:49
*** e0ne is now known as e0ne_07:49
*** SridharGaddam has joined #openstack-oslo07:52
*** e0ne_ is now known as e0ne07:53
*** jaosorior has joined #openstack-oslo07:54
*** ttx2 has joined #openstack-oslo08:15
*** ttx2 is now known as ttx08:15
*** ttx has quit IRC08:17
*** ttx has joined #openstack-oslo08:17
*** ttx has quit IRC08:17
*** ttx has joined #openstack-oslo08:18
*** ttx has quit IRC08:19
*** ttx has joined #openstack-oslo08:19
*** achanda has quit IRC08:21
*** achanda has joined #openstack-oslo08:22
*** achanda has quit IRC08:32
*** dtantsur|afk is now known as dtantsur08:35
*** SridharGaddam has quit IRC08:39
*** i159 has joined #openstack-oslo08:44
*** achanda has joined #openstack-oslo08:45
*** rushiagr is now known as rushiagr_away08:54
*** e0ne has quit IRC08:57
*** viktors|afk is now known as viktors08:58
*** dulek has joined #openstack-oslo08:59
*** subscope has joined #openstack-oslo09:15
*** achanda has quit IRC09:16
*** ajo has joined #openstack-oslo09:27
*** salv-orlando has joined #openstack-oslo09:33
*** andreykurilin_ has joined #openstack-oslo09:34
*** bogdando has joined #openstack-oslo09:45
*** pblaho has joined #openstack-oslo09:47
*** rushiagr_away is now known as rushiagr09:58
*** e0ne has joined #openstack-oslo09:59
*** salv-orlando has quit IRC10:04
*** ihrachyshka has joined #openstack-oslo10:07
*** ozamiatin has joined #openstack-oslo10:13
*** salv-orlando has joined #openstack-oslo10:14
*** e0ne is now known as e0ne_10:21
*** andreykurilin_ has quit IRC10:23
*** e0ne_ is now known as e0ne10:28
*** vigneshvar has quit IRC10:42
*** kbyrne has quit IRC10:49
*** kbyrne has joined #openstack-oslo10:49
*** inc0 has quit IRC10:53
*** dulek_ has joined #openstack-oslo10:57
*** dulek has quit IRC11:00
*** jaypipes has joined #openstack-oslo11:05
*** ujjain has quit IRC11:06
*** ujjain has joined #openstack-oslo11:06
*** himangi has joined #openstack-oslo11:16
openstackgerritOleksii Zamiatin proposed openstack/oslo.messaging: ZmqReactor doesn't create proper tcp consumer  https://review.openstack.org/15781011:18
*** salv-orlando has quit IRC11:19
*** salv-orlando has joined #openstack-oslo11:25
*** salv-orlando has quit IRC11:29
*** salv-orl_ has joined #openstack-oslo11:29
*** exploreshaifali has joined #openstack-oslo12:25
*** salv-orl_ has quit IRC12:38
*** salv-orlando has joined #openstack-oslo12:39
*** cdent has joined #openstack-oslo12:41
*** salv-orlando has quit IRC12:42
*** salv-orlando has joined #openstack-oslo12:43
*** dulek_ has quit IRC12:43
*** dims_ has quit IRC12:44
*** dimsum__ has joined #openstack-oslo12:51
*** zigo has quit IRC12:52
*** zigo has joined #openstack-oslo12:56
*** salv-orlando has quit IRC13:04
*** dulek_ has joined #openstack-oslo13:07
*** ajo has quit IRC13:07
*** ajo has joined #openstack-oslo13:08
*** kgiusti has joined #openstack-oslo13:09
*** dulek_ is now known as dulek13:18
*** dimsum__ has quit IRC13:22
*** dimsum__ has joined #openstack-oslo13:22
*** salv-orlando has joined #openstack-oslo13:23
*** salv-orlando has quit IRC13:28
*** gordc has joined #openstack-oslo13:30
*** salv-orlando has joined #openstack-oslo13:33
*** dimsum__ is now known as dims13:39
*** amrith is now known as _amrith_13:40
*** salv-orlando has quit IRC13:41
*** bknudson has quit IRC13:41
openstackgerritGrzegorz Grasza (xek) proposed openstack/oslo.versionedobjects: Update README.rst  https://review.openstack.org/15829513:41
*** salv-orlando has joined #openstack-oslo13:46
*** haypo has quit IRC13:50
*** jecarey has quit IRC13:51
*** salv-orlando has quit IRC13:53
*** dulek_ has joined #openstack-oslo13:59
*** dulek has quit IRC14:01
*** ajo_ has joined #openstack-oslo14:04
*** bknudson has joined #openstack-oslo14:05
*** dtantsur is now known as dtantsur|brb14:06
*** ajo has quit IRC14:07
*** tsekiyama has joined #openstack-oslo14:13
*** dulek_ has quit IRC14:14
*** exploreshaifali has quit IRC14:21
*** mtanino has quit IRC14:22
*** e0ne is now known as e0ne_14:30
*** e0ne_ is now known as e0ne14:31
*** stevemar has joined #openstack-oslo14:33
*** jecarey has joined #openstack-oslo14:33
*** amotoki has quit IRC14:37
*** dulek has joined #openstack-oslo14:38
*** mriedem has joined #openstack-oslo14:40
*** rushiagr is now known as rushiagr_away14:42
*** tsekiyama has quit IRC14:43
*** e0ne is now known as e0ne_14:44
*** tedross_ has joined #openstack-oslo14:47
*** tedross_ has left #openstack-oslo14:47
*** beekneemech is now known as bnemec14:48
*** superdan is now known as dansmith14:53
*** e0ne_ has quit IRC14:54
*** e0ne has joined #openstack-oslo14:56
*** dtantsur|brb is now known as dtantsur14:57
*** _amrith_ is now known as amrith15:02
*** dulek has quit IRC15:03
*** prad has joined #openstack-oslo15:06
*** daniel3_ has joined #openstack-oslo15:06
*** sigmavirus24_awa is now known as sigmavirus2415:16
*** rushiagr_away is now known as rushiagr15:18
dhellmannviktors, rpodolyaka: are we ready to release oslo.db today15:22
dimsdhellmann: i think they said they needed https://review.openstack.org/#/c/156996/ to land in nova15:27
dimslet me ask on nova15:27
dhellmanndims: thanks15:28
*** achanda has joined #openstack-oslo15:34
*** zigo_ has joined #openstack-oslo15:37
*** alexpilotti has joined #openstack-oslo15:37
*** exploreshaifali has joined #openstack-oslo15:38
*** amrith is now known as _amrith_15:39
*** hemnafk is now known as hemna15:44
*** achanda has quit IRC15:44
*** tsekiyama has joined #openstack-oslo15:45
rpodolyakathanks dims!15:46
rpodolyakadhellmann: yep, viktors tests shown that nova fails with the latest oslo.db code15:46
dimsrpodolyaka: mriedem and sdague asked mdbooth to rework that patch15:47
rpodolyakadhellmann: nova base test case does some weird things like deletion of test case instance attributes, which can possibly break perfectly ok code15:47
rpodolyakadims: ah, looks like a nit15:48
dimsrpodolyaka: :)15:48
sdaguerpodolyaka: then we should address those issues, because deleting test case attributes seems like it should be safe on cleanup15:48
sdagueand is needed for memory control15:49
*** ChuckC has joined #openstack-oslo15:49
rpodolyakasdague: right, but only if it's done as the very last thing on cleanup15:51
sdaguecleanups should be run in a reverse stack15:51
sdagueso everything the test has done will be over by that point15:51
sdagueand cleaned up15:52
sdaguerpodolyaka: do you have a specific instance of breakage?15:52
rpodolyakasdague: let me reproduce it with oslo.db master15:52
*** ChuckC_ has quit IRC15:52
rpodolyakasdague: afair, oslo.db base test case cleanup fails trying to fetch an attribute which apparentely been deleted by nova base test case15:53
rpodolyakasdague: so any test cases inheriting both base nova test case and oslo.db test case should mind the order of base classes15:53
sdagueor make the oslo.db cleanup check attrs15:54
sdagueand not do it blindly15:54
rpodolyakasdague: and migration test cases just happen to do that in the wrong order15:54
*** _amrith_ is now known as amrith15:54
rpodolyakawell, we don't delete them, so we expect them to stay there :)15:54
mriedemboris-42: wanna hit this if you're around? https://review.openstack.org/#/c/151331/15:54
dhellmannrpodolyaka: do you have a traceback?15:55
sdaguesure, but making cleanup paths robust and defensive is kind of best practice15:55
rpodolyakadhellmann: reproducing right now15:55
dhellmannsdague: so is not deleting things you don't own :-)15:55
dhellmannrpodolyaka: ok15:55
rpodolyakadefensive coding, heh?15:55
*** rushiagr is now known as rushiagr_away15:55
sdaguedhellmann: you've looked at the cleanup in question, right?15:56
dhellmannsdague: no, where is it?15:56
sdaguehttps://github.com/openstack/nova/blob/master/nova/test.py#L256-L26215:56
dhellmannsdague: that's pretty aggressive15:57
sdagueyeh, well we have 14000 test cases15:57
sdagueand people set attrs a lot15:57
dhellmannI would expect that to break all sorts of things15:57
sdagueit doesn't15:57
dhellmannwhat's keeping the test instances around?15:57
sdagueit's in the cleanup path15:57
dhellmannI guess they're all in the suite15:57
sdagueyep, they are all part of the suite, so a few thousand per worker15:58
dhellmannwell, yeah, but like rpodolyaka said, order is important. I wonder if we want to just put that in oslotest somewhere very early so it's done last15:58
dhellmannteam meeting in ~2 min15:58
sdagueit seems like it would be pretty easy to have oslo.db just be robust here. Given the amount of complexity otherwise making each interface robust seems means that likehood of bad interactions goes way down.16:01
dhellmannsdague: I'm not arguing that it shouldn't be robust, just that it's not a good idea to assume that it's safe to delete things not owned by the code doing the deleting16:02
dhellmannwe can't make all of the libraries infinitely safe from "bad" code elsewhere, even in tests16:02
rpodolyakasdague: dhellmann: tests are still running, but it's something like http://paste.openstack.org/show/180628/16:04
sdaguerpodolyaka: can you point me at the code that's triggering this in oslo.db16:05
*** amotoki has joined #openstack-oslo16:05
*** inc0 has joined #openstack-oslo16:06
dhellmannsdague: fwiw, we've been delaying oslo.db release 2 weeks now for things other projects did that were more correct than this. I'm not excited about waiting for this fix in nova. :-/16:07
*** elarson has joined #openstack-oslo16:07
rpodolyakasdague: that's a good one... it's testresources magic https://github.com/openstack/oslo.db/blob/master/oslo_db/sqlalchemy/provision.py#L88-L106 https://github.com/openstack/oslo.db/blob/master/oslo_db/sqlalchemy/test_base.py#L56-L7616:09
openstackgerritCedric Brandily proposed openstack/cliff: Allow to call initialize_app when running --help  https://review.openstack.org/15834316:10
sdagueoh, it's testresources magic... :(16:11
sdaguewhich is triggered because of the multiple inheritance in these tests16:11
sdaguerpodolyaka: so because of the multiple inheritance, what's the actual execution order of all these different setUps?16:14
*** harlowja_at_home has joined #openstack-oslo16:15
rpodolyakasdague: must be http://paste.openstack.org/show/180637/16:16
sdaguealso, this has the impact of doubly running all the real db tests in nova right? Because now instead of there being an explicit call path per engine, it's all in the magic of testresources?16:16
rpodolyakait does not generate test case classes per backend automatically, if you mean that16:17
sdaguerpodolyaka: isn't that the whole point of testresources?16:18
rpodolyakathat's only one side16:18
sdagueok, what is the side that is being used here?16:18
sdagueI guess the matrix fill was the only part I understood about testresources16:19
rpodolyakahere it allows to create 'schema' test cases, so that you can preserve the db schema between test cases. and each test is effectively running in its own transaction, which is rolled back after the test16:19
rpodolyakabut you still need to explicitly ask for that16:19
rpodolyakawe'll add docs when the bp is complete16:20
sdaguebut it only applies within a class ?16:20
rpodolyakayes16:20
sdagueok, I guess that surprises me, because we'd done global level caching in the nova tests previously16:21
rpodolyakaglobal level caching works for sqlite only16:21
*** devlaps has joined #openstack-oslo16:21
*** mtanino has joined #openstack-oslo16:21
*** rushiagr_away is now known as rushiagr16:21
rpodolyakaafaiu, mbooth is now working on reusing this new oslo.db functionality in nova16:22
sdaguerpodolyaka: the existing one does, but there is no way to do a global connection for mysql/pg?16:22
rpodolyakahttps://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:db/mysql_tests,n,z16:22
sdagueright, yeh, I've been reviewing those16:22
sdagueanyway, I think the specific fix here is to change the inheritance order in the nova tests so that the nova base class runs first, which is the way it should be16:23
rpodolyakasdague: what you need is to ensure each test is run in its own transaction which is rolled back. given that, you'll be able even to use 1 db instance shared between multiple test running processes, if the transaction isolation level is high enough (read committed)16:24
rpodolyakatestresources magic in oslo.db will allow to do that relatively easy16:24
*** andreykurilin_ has joined #openstack-oslo16:25
rpodolyakafrom projects side only monkey patching of get_engine/get_session is needed + set attributes on test cases (like SCHEMA = 'nova', which means 'preserve the same schema nova' between these tests)16:25
sdagueok, well if you could explore the fix I said above, that would be good16:26
rpodolyakayeah, but, do we really need that? I kind of like mbooth's patch, which just removes the nova base test case from the list of base classes16:27
rpodolyakaas the only reason we needed there was TEST_SCALING_FACTOR16:27
sdaguealso, please make sure this is highly documented before it goes out, because in the past the use of testresources mostly caused so much test complexity that it go ripped out16:27
rpodolyakaagreed16:27
sdaguerpodolyaka: so I really *don't* like it, because there are a number of fixes we need to apply to all nova tests at times, and having stuff in tree which doesn't inherit from the base class makes that hard16:28
sdagueI do realize the base test class does too much, but I'm working on unwinding that and turning it into tested fixtures16:29
rpodolyakasdague: fwiw, migration tests didn't inherit it for some time before I added that it :(16:29
sdagueand we've had real blocking bugs because someone took a few test cases and decided to not have them inherit from base16:29
sdagueyeh, that might have gotten changed when we had to address one of those bugs16:29
sdagueeverything in nova/tests should inherit from nova's base test16:29
rpodolyakaok, I'll give it a try after the meeting16:30
*** e0ne has quit IRC16:32
*** e0ne has joined #openstack-oslo16:33
*** devlaps has quit IRC16:42
*** i159 has quit IRC16:42
*** elarson has quit IRC16:42
*** ajo_ has quit IRC16:46
*** inc0 has quit IRC16:46
*** devlaps has joined #openstack-oslo16:48
*** amotoki has quit IRC16:48
dimssileht: https://bugs.launchpad.net/grenade/+bug/142472816:49
openstackLaunchpad bug 1424728 in oslo.messaging "Remove old rpc alias(es) from nova.conf and code" [Undecided,New]16:49
*** harlowja_at_home has quit IRC16:49
dimsozamiatin: ^^16:50
ozamiatindims, hi16:51
dimsozamiatin: we were just talking about this issue at the oslo meeting (see almost at the end) http://eavesdrop.openstack.org/meetings/oslo/2015/oslo.2015-02-23-16.00.log.html16:52
*** elarson has joined #openstack-oslo16:53
*** ChuckC_ has joined #openstack-oslo16:57
*** ChuckC_ has quit IRC16:58
*** ChuckC has quit IRC17:00
*** ChuckC_ has joined #openstack-oslo17:00
silehtdims, this is because on devstack-juno, nova.openstack.common.rpc.impl_kombu is used instead of "rabbit"17:00
*** vigneshvar has joined #openstack-oslo17:01
silehtdims, the configuration of nova have to be updated before the upgrade process use one of the nova-* command/service17:01
*** viktors is now known as viktors|afk17:02
openstackgerritDan Smith proposed openstack/oslo.versionedobjects: Allow subclasses to define the serialization namespaces  https://review.openstack.org/15835917:03
dimssileht: yes, on the other hand, we have to tell end users that this is going away17:09
dims"nova.openstack.common.rpc.impl_kombu"17:09
silehtdims, sure17:09
dimsgrenade problem is easy to solve17:09
dimswe need a deprecation warning in Kilo, so we can safely assume everyone will notice and remove in Liberty17:10
dimsi can see similar values being used in other projects too17:12
silehtdims, I think we should deprecated the whole aliases feature in oslo.msg17:12
silehtdims, it leave only for deprecated name hardcoded in application17:13
rpodolyakasdague: https://review.openstack.org/#/c/158364/17:13
silehtdims, once this feature have been removed, oslo.messaging will be the only thing that will deal with the rpc_backend option17:13
dimssileht: +1, that way we can just loop through everything in there and throw deprecation warnings for those17:13
rpodolyakasdague: so ^ this should help. though the solution is rather ugly17:13
rpodolyakasdague: the problem is we need to explicitly inherit from oslotest base test case now17:13
rpodolyakasdague: to ensure we override the timeout fixture in nova base test case setUp(), so that TIMEOUT_SCALING_FACTOR is handled properly17:14
openstackgerritMerged openstack/oslo.messaging: Add FAQ entry for notifier configuration  https://review.openstack.org/15661917:14
* dims back in a bit17:14
*** noelbk has joined #openstack-oslo17:14
rpodolyakasdague: gotta go now, will be back in a few hours17:14
*** rpodolyaka is now known as rpodolyaka_afk17:15
*** ihrachyshka has quit IRC17:19
silehtdims, dhellmann, if we can land https://review.openstack.org/#/c/138723/5, before the release17:20
silehtdhellmann, otherwise oslo.messaging is ready to be released, even without that one ^ if you want to release a version now17:21
silehtdhellmann, I will run nova tests with the master to be sure17:22
dhellmannsileht: sounds good. I'm in a meeting, and then lunch, but then I'll look at that patch and start the other releases.17:29
dhellmannsileht, dims, bnemec : can you approve https://review.openstack.org/#/c/157883/17:30
*** himangi has quit IRC17:31
bnemecdhellmann: +217:32
dhellmannbnemec: thanks17:32
silehtdhellmann, this tools looks, no more manual testing17:36
*** ChuckC_ has quit IRC17:36
dhellmannsileht: yeah, that used to be in the incubator but putting into oslotest lets us distribute it more easily17:36
dhellmannsileht: it relies on having the source checked out in a particular way, though17:37
*** e0ne has quit IRC17:38
peterstacHi, any infra people here that can look at https://review.openstack.org/#/c/157955/ ?17:41
peterstacpython-troveclient is dead in the water until we get that merged ...17:42
*** ChuckC has joined #openstack-oslo17:45
*** exploreshaifali has quit IRC17:45
*** salv-orlando has joined #openstack-oslo17:46
dhellmannpeterstac: did you ask in #openstack-infra?17:47
*** yamahata has joined #openstack-oslo17:56
openstackgerritDoug Hellmann proposed openstack/oslotest: Force rebuild egg-info before running cross tests  https://review.openstack.org/15838218:02
*** david-lyle_afk is now known as david-lyle18:09
*** ChuckC has quit IRC18:11
*** dtantsur is now known as dtantsur|afk18:16
*** achanda has joined #openstack-oslo18:16
*** achanda has quit IRC18:18
*** achanda has joined #openstack-oslo18:18
*** rushiagr is now known as rushiagr_away18:27
*** harlowja has joined #openstack-oslo18:33
sdaguerpodolyaka_afk: hmm... can you explain that bit? what's coming from oslotest base?18:34
sdagueI'm confused by what we need from oslotest18:37
openstackgerritMerged openstack/oslotest: Restore missing module for pre-release test script  https://review.openstack.org/15788318:45
*** jaosorior has quit IRC18:51
kragnizdhellmann: is oslo.config parsing StrOpt types set to 'None' from a config file as the string 'None' rather than NoneType desired behaviour?18:53
*** hemna has quit IRC19:03
dhellmannkragniz: Do you mean your config file has the word None in it?19:08
kragnizdhellmann: yup19:08
kragnizhttps://review.openstack.org/#/c/158377/19:08
dhellmannkragniz: yes, whatever is in the file is turned into a string, so None -> "None"19:08
kragnizyeah, it makes sense19:08
kragnizdhellmann: so the only way to get a StrOpt to be NoneType is to default it to None and not set it in a config file, right?19:09
dhellmannkragniz: that may work, I'm not sure if the class requires a valid string as a default. Why do you want the value to be None?19:10
kragnizdhellmann: it's supposed to be ignored if it is None19:11
dhellmannkragniz: how about an empty string?19:11
kragnizthat would also work, I think19:12
kragnizlet me check what swiftclient does with it19:12
*** cdent has quit IRC19:14
peterstacdhellmann: nope, I'll do that now, thx19:18
kragnizdhellmann: also, thanks for the help!19:19
dhellmannkragniz: sure thing, I hope that does what you need19:19
dhellmannoslotest 1.5.0 has been released19:19
*** sputnik13 has joined #openstack-oslo19:19
sdaguedhellmann: so you are probably going to hate me for suggesting this, but in this case of the test changes to use testresources, I wonder if we'd been ahead to not change the existing class, instead add a new test class, then migrate projects over to the new test class once it's out in the wild.19:20
dhellmannsdague: yeah, that may have been a smoother transition19:20
sdagueespecially for things that expect to be consumed by various unit test stacks, it might be nice to consider them bug fix only once released, then make new better ones if there is new better functionality to be done19:21
dhellmannoslo.vmware 0.10.0 released19:21
*** alexpilotti has quit IRC19:24
dhellmannsdague: I  don't know if we need a blanket policy for that, but I do see your point.19:24
dhellmannoslo.log 0.3.0 released19:29
dhellmannoslo.config 1.7.0 released19:33
dhellmannoslo.concurrency 1.6.0 released19:33
*** andreykurilin_ has quit IRC19:38
*** salv-orlando has quit IRC19:40
dimsdhellmann: nice crop, now we wait to see what we reap :)19:41
* dhellmann braces himself19:41
dims:)19:41
*** amrith is now known as _amrith_19:49
*** e0ne has joined #openstack-oslo19:51
*** openstackgerrit has quit IRC19:51
*** openstackgerrit has joined #openstack-oslo19:52
*** achanda has quit IRC19:57
*** achanda has joined #openstack-oslo19:59
morganfainbergdhellmann: so. If I wanted to add a new protocol to oslo.messaging that also mirrors an impl (aka Gearman) should I just add the impl or add a protocol and a thin wrapper around in the impl.20:04
morganfainbergdhellmann: I'm inclined to just do it as an impl because protocol in this case is implementation.20:04
morganfainbergVs say ampq which is rabbit, qpid, etc20:05
morganfainbergdhellmann: this is more exploration at the moment but will move beyond if it works (and I'll add a spec)20:05
*** stevemar has quit IRC20:07
openstackgerritOpenStack Proposal Bot proposed openstack/oslo.messaging: Updated from global requirements  https://review.openstack.org/15778320:09
dhellmannmorganfainberg: the protocol thing is new for the amqp 1.0 driver, I think. I'm not sure how that fits into what you're asking about.20:09
morganfainbergdhellmann: I think it doesn't matter. Since Gearman really is pretty simple.20:10
morganfainbergBut I wanted to be sure I wasn't missing  some subtle thing.20:10
morganfainbergWhy I asked.20:10
dhellmannyeah, I'm looking at the code organization now and it's not clear to me why that was split up other than it looks like the amqp 1.0 driver needed a bunch of helper code that might have made a single impl_ file big20:11
dhellmannmorganfainberg: I suppose we could have moved oslo_messaging/_drivers/amqpdriver.py into a similar protocols dir, and the matchmaker stuff for zmq could be moved, too20:12
dhellmannmorganfainberg: so if you can do it in an impl_ file then I'd just do that20:13
morganfainbergYeah I think I can just do it in impl file.20:13
*** kgiusti has quit IRC20:17
*** andreykurilin_ has joined #openstack-oslo20:19
*** kgiusti has joined #openstack-oslo20:22
*** vigneshvar has quit IRC20:23
*** stevemar has joined #openstack-oslo20:30
*** harlowja has quit IRC20:34
*** harlowja_ has joined #openstack-oslo20:34
*** mriedem has quit IRC20:35
*** exploreshaifali has joined #openstack-oslo20:38
*** salv-orlando has joined #openstack-oslo20:41
*** achanda has quit IRC20:45
*** bknudson has quit IRC21:05
*** jmeridth has joined #openstack-oslo21:10
openstackgerritKen Giusti proposed openstack/oslo.messaging: Properly distinguish between server index zero and no server  https://review.openstack.org/15844421:10
*** kgiusti has quit IRC21:12
*** salv-orlando has quit IRC21:12
*** achanda has joined #openstack-oslo21:13
*** salv-orlando has joined #openstack-oslo21:17
*** ChuckC has joined #openstack-oslo21:25
*** _amrith_ is now known as amrith21:26
*** rushiagr_away is now known as rushiagr21:27
dhellmannttx, sdague, jogo, mtreinish: you all think about requirements management, so we're interested in your input on https://review.openstack.org/#/c/157135/21:29
*** daniel3_ has quit IRC21:29
*** daniel3_ has joined #openstack-oslo21:31
*** daniel3_ has quit IRC21:32
*** daniel3_ has joined #openstack-oslo21:33
*** daniel3_ has quit IRC21:33
openstackgerritGreg Hill proposed openstack/taskflow: add jobboard trash method  https://review.openstack.org/15845921:42
*** achanda has quit IRC21:46
*** achanda has joined #openstack-oslo21:47
*** exploreshaifali has quit IRC21:51
*** rushiagr is now known as rushiagr_away22:29
*** harlowja_ has quit IRC22:29
*** harlowja has joined #openstack-oslo22:30
*** mtanino has quit IRC22:40
*** achanda has quit IRC22:43
*** achanda has joined #openstack-oslo22:45
*** e0ne has quit IRC23:00
*** harlowja has quit IRC23:04
*** stevemar has quit IRC23:07
*** stevemar has joined #openstack-oslo23:07
*** achanda has quit IRC23:12
*** devlaps has quit IRC23:14
*** devlaps has joined #openstack-oslo23:14
*** harlowja has joined #openstack-oslo23:16
*** amaurymedeiros has quit IRC23:20
*** amaurymedeiros has joined #openstack-oslo23:20
*** achanda has joined #openstack-oslo23:25
*** prad has quit IRC23:36
*** alexpilotti has joined #openstack-oslo23:36
*** gordc has quit IRC23:37
*** andreykurilin_ has quit IRC23:43
*** salv-orlando has quit IRC23:45
*** MasterPiece has joined #openstack-oslo23:53
« Sunday, 2015-02-22 Index Tuesday, 2015-02-24 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!