| zzzeek | harlowja_: yeah it was fork() in service.py | 00:09 |
|---|---|---|
| harlowja_ | ya, and the weird stuff around it i think (stuff thats happening on object creation before the fork, stuff happening after...) | 00:09 |
| harlowja_ | * https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L187 (that db opening thingy) and i guess others that idk about, ha | 00:10 |
| harlowja_ | pretty sure we should close all fds in the child (take the common pattern that is done in the subprocess.py module) | 00:11 |
| harlowja_ | thats my 2 cents :-P | 00:11 |
| zzzeek | that will be worse though b.c. then all the DB connections will raise an error and be reopened after the ping fails | 00:14 |
| zzzeek | so same effect, but slower and shittier | 00:14 |
| *** stevemar has quit IRC | 00:16 | |
| *** stevemar has joined #openstack-oslo | 00:22 | |
| zzzeek | though itll warn like crazy so wahtever | 00:22 |
| harlowja_ | ok then i recommend a LOG statement, that uses the DEBUG logger to log a warning to developers about a usage of warnings.warn to let them know about a postcard they will get that says don't do this | 00:23 |
| harlowja_ | lol | 00:23 |
| *** _amrith_ is now known as amrith | 00:23 | |
| *** stevemar has quit IRC | 00:32 | |
| harlowja_ | the postcard should include zzzeek face on it | 00:32 |
| harlowja_ | ^ sounds about right to me, lol | 00:32 |
| *** hemna is now known as hemnafk | 00:38 | |
| *** david-lyle is now known as david-lyle_afk | 00:41 | |
| *** gordc has quit IRC | 00:42 | |
| *** ajo has quit IRC | 00:55 | |
| *** bknudson has quit IRC | 00:58 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 01:02 | |
| *** vishy has quit IRC | 01:07 | |
| *** vishy has joined #openstack-oslo | 01:09 | |
| openstackgerrit | Jamie Lennox proposed openstack/oslo.config: Add expose_opt to CfgFilter https://review.openstack.org/115565 | 01:13 |
| openstackgerrit | Jamie Lennox proposed openstack/oslo.config: Allow setting overrides in CfgFilter https://review.openstack.org/143423 | 01:13 |
| *** tsekiyam_ has joined #openstack-oslo | 01:16 | |
| *** krotscheck has quit IRC | 01:18 | |
| *** tsekiyama has quit IRC | 01:20 | |
| *** tsekiyam_ has quit IRC | 01:21 | |
| *** mtanino has quit IRC | 01:25 | |
| *** stevemar has joined #openstack-oslo | 01:37 | |
| *** crc32 has joined #openstack-oslo | 01:41 | |
| *** kgiusti has left #openstack-oslo | 01:43 | |
| openstackgerrit | Dan Krause proposed openstack/taskflow: add get_flow_details and get_atom_details to all backends https://review.openstack.org/157225 | 01:45 |
| *** himangi has quit IRC | 01:55 | |
| *** devlaps has quit IRC | 01:55 | |
| *** crc32 has quit IRC | 02:03 | |
| *** krotscheck has joined #openstack-oslo | 02:03 | |
| *** jaosorior has quit IRC | 02:11 | |
| *** krotscheck has quit IRC | 02:12 | |
| *** krotscheck has joined #openstack-oslo | 02:13 | |
| *** zzzeek has quit IRC | 02:13 | |
| *** achanda has quit IRC | 02:33 | |
| *** salv-orlando has quit IRC | 02:40 | |
| *** achanda has joined #openstack-oslo | 02:42 | |
| *** achanda has quit IRC | 02:46 | |
| *** dims_ has quit IRC | 02:52 | |
| *** mriedem has joined #openstack-oslo | 02:53 | |
| *** jecarey has joined #openstack-oslo | 02:54 | |
| *** achanda has joined #openstack-oslo | 03:02 | |
| *** harlowja_ is now known as harlowja_away | 03:15 | |
| *** jecarey has quit IRC | 03:28 | |
| *** jecarey has joined #openstack-oslo | 03:28 | |
| *** salv-orlando has joined #openstack-oslo | 03:41 | |
| *** achanda has quit IRC | 03:45 | |
| *** achanda has joined #openstack-oslo | 03:52 | |
| *** dims__ has joined #openstack-oslo | 03:52 | |
| *** yamahata has quit IRC | 03:54 | |
| *** dims__ has quit IRC | 03:57 | |
| *** amotoki has joined #openstack-oslo | 04:04 | |
| *** noelbk has quit IRC | 04:12 | |
| *** achanda has quit IRC | 04:16 | |
| *** salv-orlando has quit IRC | 04:31 | |
| *** jecarey has quit IRC | 04:35 | |
| mriedem | this seems, bad? https://bugs.launchpad.net/oslo.messaging/+bug/1423438 | 04:36 |
| openstack | Launchpad bug 1423438 in oslo.messaging "rabbit: AttributeError: 'Connection' object has no attribute 'driver_conf'" [Undecided,New] | 04:36 |
| *** miqui has joined #openstack-oslo | 04:42 | |
| *** himangi has joined #openstack-oslo | 04:47 | |
| *** miqui has quit IRC | 04:52 | |
| *** miqui has joined #openstack-oslo | 04:53 | |
| *** vigneshvar has joined #openstack-oslo | 05:02 | |
| *** mriedem has quit IRC | 05:05 | |
| *** mriedem has joined #openstack-oslo | 05:10 | |
| *** mriedem has left #openstack-oslo | 05:11 | |
| *** achanda has joined #openstack-oslo | 05:16 | |
| *** achanda has quit IRC | 05:18 | |
| *** achanda has joined #openstack-oslo | 05:18 | |
| *** yamahata has joined #openstack-oslo | 05:19 | |
| *** vigneshvar has quit IRC | 05:36 | |
| *** vigneshvar has joined #openstack-oslo | 05:37 | |
| *** amotoki_ has joined #openstack-oslo | 05:44 | |
| *** achanda has quit IRC | 05:45 | |
| *** noelbk has joined #openstack-oslo | 05:46 | |
| *** amotoki has quit IRC | 05:47 | |
| *** noelbk has quit IRC | 05:48 | |
| *** exploreshaifali has joined #openstack-oslo | 05:53 | |
| *** zigo has quit IRC | 05:54 | |
| *** zigo has joined #openstack-oslo | 05:55 | |
| *** achanda has joined #openstack-oslo | 05:56 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.vmware: Imported Translations from Transifex https://review.openstack.org/156897 | 06:09 |
| *** salv-orlando has joined #openstack-oslo | 06:15 | |
| *** miqui has quit IRC | 06:26 | |
| *** himangi has quit IRC | 06:45 | |
| *** yamahata has quit IRC | 06:51 | |
| *** yamahata has joined #openstack-oslo | 06:51 | |
| *** harlowja_at_home has joined #openstack-oslo | 06:52 | |
| *** i159 has joined #openstack-oslo | 07:11 | |
| *** harlowja_at_home has quit IRC | 07:13 | |
| *** salv-orlando has quit IRC | 07:26 | |
| *** dims__ has joined #openstack-oslo | 07:30 | |
| *** dims__ has quit IRC | 07:35 | |
| *** exploreshaifali has quit IRC | 07:44 | |
| *** i159_ has joined #openstack-oslo | 07:53 | |
| *** i159 has quit IRC | 07:53 | |
| *** harlowja_away has quit IRC | 08:03 | |
| openstackgerrit | Merged openstack/taskflow: Allow loading conductors via entrypoints https://review.openstack.org/124617 | 08:08 |
| openstackgerrit | Merged openstack/taskflow: Tweaks to atom documentation https://review.openstack.org/156844 | 08:08 |
| *** exploreshaifali has joined #openstack-oslo | 08:08 | |
| *** stevemar has quit IRC | 08:22 | |
| *** salv-orlando has joined #openstack-oslo | 08:25 | |
| *** achanda has quit IRC | 08:29 | |
| *** andreykurilin_ has joined #openstack-oslo | 08:29 | |
| *** achanda has joined #openstack-oslo | 08:29 | |
| *** achanda has quit IRC | 08:30 | |
| *** inc0 has joined #openstack-oslo | 08:41 | |
| *** dtantsur|afk is now known as dtantsur | 08:41 | |
| *** dulek has joined #openstack-oslo | 08:50 | |
| *** rushiagr_away is now known as rushiagr | 08:52 | |
| *** salv-orlando has quit IRC | 08:52 | |
| *** salv-orlando has joined #openstack-oslo | 08:52 | |
| *** stannie has joined #openstack-oslo | 08:58 | |
| *** andreykurilin_ has quit IRC | 08:58 | |
| *** ajo has joined #openstack-oslo | 08:59 | |
| *** vigneshvar has quit IRC | 09:12 | |
| *** vigneshvar has joined #openstack-oslo | 09:14 | |
| *** ozamiatin has joined #openstack-oslo | 09:20 | |
| *** salv-orlando has quit IRC | 09:29 | |
| *** salv-orlando has joined #openstack-oslo | 09:33 | |
| *** yamahata has quit IRC | 09:39 | |
| *** viktors|afk is now known as viktors | 09:47 | |
| *** exploreshaifali has quit IRC | 10:05 | |
| *** amotoki_ has quit IRC | 10:14 | |
| *** amotoki has joined #openstack-oslo | 10:18 | |
| *** dtantsur is now known as dtantsur|bbl | 10:21 | |
| *** ihrachyshka has joined #openstack-oslo | 10:21 | |
| *** e0ne has joined #openstack-oslo | 10:21 | |
| *** hogepodge has quit IRC | 10:22 | |
| *** hogepodge has joined #openstack-oslo | 10:24 | |
| *** xek has quit IRC | 10:35 | |
| *** e0ne is now known as e0ne_ | 10:39 | |
| *** e0ne_ is now known as e0ne | 10:39 | |
| *** dims__ has joined #openstack-oslo | 10:50 | |
| *** e0ne is now known as e0ne_ | 10:53 | |
| *** e0ne_ is now known as e0ne | 10:54 | |
| *** dims__ has quit IRC | 10:54 | |
| *** exploreshaifali has joined #openstack-oslo | 10:58 | |
| *** ozamiatin has quit IRC | 11:09 | |
| *** salv-orlando has quit IRC | 11:11 | |
| *** salv-orlando has joined #openstack-oslo | 11:12 | |
| *** dulek has quit IRC | 11:29 | |
| *** dulek has joined #openstack-oslo | 11:30 | |
| *** salv-orlando has quit IRC | 11:31 | |
| *** salv-orlando has joined #openstack-oslo | 11:31 | |
| *** e0ne is now known as e0ne_ | 11:34 | |
| openstackgerrit | Marian Horban proposed openstack/oslo-incubator: Optimization of waiting subprocesses in ProcessLauncher https://review.openstack.org/156345 | 11:39 |
| *** vigneshvar has quit IRC | 11:49 | |
| *** alexpilotti has joined #openstack-oslo | 11:51 | |
| *** rushiagr is now known as rushiagr_away | 11:54 | |
| *** exploreshaifali has quit IRC | 11:55 | |
| *** dtantsur|bbl is now known as dtantsur | 11:56 | |
| *** inc0_ has joined #openstack-oslo | 11:58 | |
| *** inc0 has quit IRC | 11:59 | |
| *** inc0_ has quit IRC | 11:59 | |
| *** e0ne_ is now known as e0ne | 12:10 | |
| *** ihrachyshka has quit IRC | 12:16 | |
| *** 7JTACEC3O has joined #openstack-oslo | 12:22 | |
| *** salv-orlando has quit IRC | 12:31 | |
| *** salv-orlando has joined #openstack-oslo | 12:31 | |
| *** tomoiaga has joined #openstack-oslo | 12:36 | |
| tomoiaga | I am trying to use oslo messaging to listen for rpc messages. Everything is fine up to the part where I need multiple listeners that should be able to receive the same messages. I ended up using a different pool name for each listener, however I would like to know how to delete the queue created by the listener once that listener is stopped for example ? Is there a method or something in oslo that can help me remove a queue ? Thank you! | 12:39 |
| *** salv-orlando has quit IRC | 12:40 | |
| *** cdent has joined #openstack-oslo | 12:40 | |
| *** salv-orlando has joined #openstack-oslo | 12:41 | |
| *** amotoki has quit IRC | 12:43 | |
| *** dims__ has joined #openstack-oslo | 12:44 | |
| *** xek has joined #openstack-oslo | 12:44 | |
| *** salv-orlando has quit IRC | 12:49 | |
| *** exploreshaifali has joined #openstack-oslo | 12:58 | |
| *** alexpilotti has quit IRC | 13:05 | |
| *** vigneshvar has joined #openstack-oslo | 13:08 | |
| xek | dansmith, I think this can be closed as invalid, since you already defined the indirection api https://bugs.launchpad.net/oslo.versionedobjects/+bug/1417280 | 13:23 |
| openstack | Launchpad bug 1417280 in oslo.versionedobjects "need to rewrite the service-related tests" [Undecided,In progress] - Assigned to Grzegorz Grasza (xek) | 13:23 |
| 7JTACEC3O | tomoiaga, hi, as I know there is no direct method to remove a queue, it's up to rabbit to manage queues and to decide when to clean up | 13:24 |
| tomoiaga | 7JTACEC3O: Ok, I'll have to deal with this some other way I guess. My problem is that those queues will fill up with messages if the workers are not running for a while. I guess I can also set the option to auto delete the queues in oslo, but that will apply to all queues. | 13:25 |
| *** kgiusti has joined #openstack-oslo | 13:29 | |
| openstackgerrit | Roman Prykhodchenko proposed openstack/cliff: Allow using custom help and complete commands https://review.openstack.org/157368 | 13:30 |
| *** gordc has joined #openstack-oslo | 13:37 | |
| *** hogepodge has quit IRC | 13:47 | |
| *** hogepodge has joined #openstack-oslo | 13:49 | |
| *** salv-orlando has joined #openstack-oslo | 13:50 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 13:52 | |
| *** ihrachyshka has joined #openstack-oslo | 13:52 | |
| *** exploreshaifali has quit IRC | 13:55 | |
| *** vigneshvar has quit IRC | 14:04 | |
| openstackgerrit | Grzegorz Grasza (xek) proposed openstack/oslo.versionedobjects: Remove already commented out and unused fixtures https://review.openstack.org/157380 | 14:05 |
| *** pblaho has quit IRC | 14:07 | |
| openstackgerrit | Grzegorz Grasza (xek) proposed openstack/oslo.versionedobjects: Remove already commented out and unused fixtures https://review.openstack.org/157380 | 14:07 |
| *** diga_ has joined #openstack-oslo | 14:17 | |
| *** mriedem has joined #openstack-oslo | 14:27 | |
| *** hogepodge has quit IRC | 14:36 | |
| *** hogepodge has joined #openstack-oslo | 14:39 | |
| *** salv-orlando has quit IRC | 14:39 | |
| *** salv-orlando has joined #openstack-oslo | 14:40 | |
| *** tedross has joined #openstack-oslo | 14:49 | |
| dansmith | xek: yeah, or just close it as complete :) | 14:56 |
| *** yamahata has joined #openstack-oslo | 14:57 | |
| *** daniel3_ has joined #openstack-oslo | 15:02 | |
| openstackgerrit | Roman Prykhodchenko proposed openstack/cliff: Allow using custom help and complete commands https://review.openstack.org/157368 | 15:03 |
| dansmith | xek: commented on your cleanup patch | 15:03 |
| *** exploreshaifali has joined #openstack-oslo | 15:05 | |
| dansmith | dims__: https://review.openstack.org/#/c/157127/1 | 15:07 |
| dansmith | dims__: know what that's about? | 15:08 |
| dims__ | dansmith: project-requirements-change.py is not upto snuff | 15:09 |
| dims__ | fixtures>=1.0 does not match openstack/requirements value fixtures>=0.3.14 | 15:09 |
| dansmith | dims__: ah, so I need to just make mine match? | 15:10 |
| dims__ | dansmith: y | 15:10 |
| dansmith | dims__: thanks :) | 15:10 |
| openstackgerrit | Dan Krause proposed openstack/taskflow: add get_flow_details and get_atom_details to all backends https://review.openstack.org/157225 | 15:13 |
| *** cdent has quit IRC | 15:15 | |
| *** cdent has joined #openstack-oslo | 15:16 | |
| *** jecarey has joined #openstack-oslo | 15:16 | |
| *** dims__ has quit IRC | 15:17 | |
| *** dims__ has joined #openstack-oslo | 15:18 | |
| openstackgerrit | Dan Smith proposed openstack/oslo.versionedobjects: Rename checks to fixture and update requirements https://review.openstack.org/157127 | 15:18 |
| *** i159_ has quit IRC | 15:19 | |
| *** exploreshaifali has quit IRC | 15:28 | |
| *** mtanino has joined #openstack-oslo | 15:29 | |
| openstackgerrit | Grzegorz Grasza (xek) proposed openstack/oslo.versionedobjects: Remove already commented out and unused fixtures https://review.openstack.org/157380 | 15:33 |
| *** achanda has joined #openstack-oslo | 15:33 | |
| *** tomoiaga has left #openstack-oslo | 15:40 | |
| *** achanda has quit IRC | 15:41 | |
| *** MasterPiece has joined #openstack-oslo | 15:41 | |
| openstackgerrit | Assaf Muller proposed openstack/oslo.rootwrap: WIP: Add logging in KillFilter to aid debugging https://review.openstack.org/157420 | 15:43 |
| *** jaypipes has quit IRC | 15:51 | |
| *** hemnafk is now known as hemna | 15:53 | |
| *** bogdando has quit IRC | 15:55 | |
| *** jaypipes has joined #openstack-oslo | 16:01 | |
| *** david-lyle_afk is now known as david-lyle | 16:04 | |
| *** himangi has joined #openstack-oslo | 16:05 | |
| *** denis_makogon has quit IRC | 16:05 | |
| openstackgerrit | Kobi Samoray proposed openstack/oslo.vmware: VMWare NSXv: Spoofguard API, retry mechanism https://review.openstack.org/157429 | 16:06 |
| *** dulek has quit IRC | 16:11 | |
| *** zzzeek has joined #openstack-oslo | 16:13 | |
| *** stevemar has joined #openstack-oslo | 16:14 | |
| mriedem | dhellmann: replied https://bugs.launchpad.net/oslo.messaging/+bug/1423438/comments/4 | 16:34 |
| openstack | Launchpad bug 1423438 in oslo.messaging "rabbit: AttributeError: 'Connection' object has no attribute 'driver_conf'" [Undecided,Incomplete] | 16:34 |
| mriedem | dhellmann: think i just figured it out myself | 16:35 |
| mriedem | depr | 16:35 |
| *** openstackgerrit has quit IRC | 16:36 | |
| mriedem | dhellmann: the patch https://github.com/openstack/oslo.messaging/commit/68cd8cfecc12a40b61a7b8557aad7b5a4e1f1c6d requires driver_conf which was added in https://github.com/openstack/oslo.messaging/commit/824313ac9c8d1d7095cfa2cc348da24c1052c591 | 16:36 |
| mriedem | which isn't patched in the rpm | 16:36 |
| mriedem | that's the problem | 16:36 |
| *** openstackgerrit has joined #openstack-oslo | 16:36 | |
| mriedem | fwiw i didn't generate this patch myself, this is why i run unit tests on a cherry pick before generating a patch | 16:37 |
| *** tsekiyama has joined #openstack-oslo | 16:39 | |
| *** yamahata has quit IRC | 16:39 | |
| dims__ | dansmith: here's a trivial change - https://review.openstack.org/#/c/157114/ | 16:43 |
| *** noelbk has joined #openstack-oslo | 16:44 | |
| openstackgerrit | Merged openstack/oslotest: Set a higher default for maxDiff https://review.openstack.org/153578 | 16:44 |
| sdague | the oslo_config fixture... does that support doing this in parts? The _unregister seems to tear down the world | 16:46 |
| *** salv-orlando has quit IRC | 16:52 | |
| *** daniel3_ has quit IRC | 16:57 | |
| *** ihrachyshka has quit IRC | 17:03 | |
| *** dtantsur is now known as dtantsur|afk | 17:08 | |
| *** yamahata has joined #openstack-oslo | 17:10 | |
| *** exploreshaifali has joined #openstack-oslo | 17:12 | |
| *** ihrachyshka has joined #openstack-oslo | 17:15 | |
| *** pradk has joined #openstack-oslo | 17:19 | |
| *** jecarey has quit IRC | 17:20 | |
| openstackgerrit | Yuriy Nesenenko proposed openstack/oslo.config: Fix: cfg.py checks glod.glob(config_dir_glob) if it is empty https://review.openstack.org/157454 | 17:21 |
| *** cdent has quit IRC | 17:21 | |
| *** cdent has joined #openstack-oslo | 17:24 | |
| openstackgerrit | Yuriy Nesenenko proposed openstack/oslo.config: Fix: cfg.py checks glod.glob(config_dir_glob) if it is empty https://review.openstack.org/157454 | 17:25 |
| *** bknudson has joined #openstack-oslo | 17:26 | |
| *** cdent has quit IRC | 17:26 | |
| *** dansmith has quit IRC | 17:30 | |
| *** dansmith has joined #openstack-oslo | 17:30 | |
| *** himangi has quit IRC | 17:33 | |
| dhellmann | mriedem: ok, good, I was worried somehow we had landed code that wasn't working properly in master | 17:35 |
| *** krotscheck has quit IRC | 17:36 | |
| dhellmann | sdague: we may not have encountered that use case before -- what are you trying to do? | 17:37 |
| sdague | nova has a lot of test layers | 17:37 |
| sdague | there is a base set of conf overrides needed regardless of what's going on | 17:37 |
| sdague | and there are effectively patches needed on top of that for specific kinds of tests | 17:38 |
| *** ihrachyshka has quit IRC | 17:38 | |
| sdague | and I was trying to figure out what the safe way of patching and unwinding is | 17:38 |
| *** daniel3_ has joined #openstack-oslo | 17:38 | |
| dhellmann | sdague: sure, that makes sense. Maybe you want to subclass that fixture and put the common stuff in its setup? | 17:38 |
| *** krotscheck has joined #openstack-oslo | 17:39 | |
| sdague | maybe, I actually came up with a local patcher model that I think will work for us. I ran into this because a fixture I was building needs specific configuration for it to work | 17:39 |
| dhellmann | I'm having trouble picturing that. Would it make sense to put any of that in the base class? | 17:40 |
| sdague | I have a fixture that provides a nova api endpoint with a client interface to it for full stack testing | 17:44 |
| sdague | but you can't do that in tests in parallel unless you change all the bind hosts to 127.0.0.1 and the bind ports to 0 (to dynamically allocate ports) | 17:44 |
| dhellmann | sdague: I know the webtest framework lets you talk to the WSGI app directly without actually using sockets. Maybe that's a better route? | 17:50 |
| *** diga_ has quit IRC | 17:51 | |
| openstackgerrit | Marian Horban proposed openstack/oslo-incubator: Optimization of waiting subprocesses in ProcessLauncher https://review.openstack.org/156345 | 17:52 |
| *** salv-orlando has joined #openstack-oslo | 17:52 | |
| openstackgerrit | Yuriy Nesenenko proposed openstack/oslo.config: Fix cfg.py checks list_config_files if it is empty https://review.openstack.org/157454 | 17:57 |
| openstackgerrit | Yuriy Nesenenko proposed openstack/oslo.config: Fix cfg.py checks list_config_files if it is empty https://review.openstack.org/157454 | 17:58 |
| openstackgerrit | Merged openstack/oslo.versionedobjects: Remove already commented out and unused fixtures https://review.openstack.org/157380 | 17:58 |
| *** sreshetnyak has joined #openstack-oslo | 17:59 | |
| sdague | dhellmann: except that would then require rewriting all the tests and the existing clients for the 900+ existing tests before making any forward progress. | 18:05 |
| sdague | so, I really don't think that's a better path | 18:06 |
| sdague | anyway I've been at it for a while, so going away for a chunk this afternoon. | 18:07 |
| *** e0ne has quit IRC | 18:08 | |
| *** harlowja has joined #openstack-oslo | 18:10 | |
| bnemec | Okay, the oslo.db email is sent. I'm pretty sure it's going to be a tldr for basically everyone though. :-/ | 18:10 |
| harlowja | bnemec did u include the part where we use debug logging to log a warning about a snail mail that will include a secret code to decode a log message that we will include in a future release ? | 18:13 |
| harlowja | lol | 18:13 |
| bnemec | harlowja: Damn, I knew I forgot something. ;-) | 18:14 |
| harlowja | :) | 18:14 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/oslo.config: Add exception handling for entry points https://review.openstack.org/153863 | 18:27 |
| *** jecarey has joined #openstack-oslo | 18:27 | |
| openstackgerrit | Assaf Muller proposed openstack/oslo.rootwrap: WIP: Add logging in KillFilter to aid debugging https://review.openstack.org/157420 | 18:29 |
| harlowja | should we add an ability for service.py to take a list of callbacks that will be triggered after forking | 18:29 |
| harlowja | so that cinder could provide one to close there db session(s) | 18:29 |
| * harlowja doesn't think it has that right now (but probably should) | 18:30 | |
| harlowja | *the last callback in that chain could be the 'forced' one that closes all descriptors | 18:30 |
| *** achanda has joined #openstack-oslo | 18:31 | |
| *** pradk is now known as prad | 18:31 | |
| stevemar | dhellmann, sigmavirus24 looks like jenkins is finally happy with keystone and oslo.policy -> https://review.openstack.org/#/c/148624/ i'm a bit unsure about how i loaded the options though | 18:34 |
| sigmavirus24 | stevemar: is opts a module? | 18:36 |
| * sigmavirus24 forgets | 18:36 | |
| stevemar | sigmavirus24, yep https://github.com/openstack/oslo.policy/blob/master/oslo_policy/opts.py | 18:36 |
| sigmavirus24 | right | 18:36 |
| stevemar | sigmavirus24, but it should be loaded when I create an Enforcer | 18:37 |
| sigmavirus24 | right right, I was just confused by it | 18:37 |
| stevemar | but Enforcer requires a policy_file which is set in CONF | 18:37 |
| *** daniel3_ has quit IRC | 18:39 | |
| * sigmavirus24 has thoughts | 18:39 | |
| sigmavirus24 | stevemar: can you remove the -e git:// stuff since 0.1.0 was released? | 18:39 |
| sigmavirus24 | (wasn't it released?) | 18:40 |
| sigmavirus24 | stevemar: left a comment | 18:40 |
| stevemar | sigmavirus24, probably, the requirements job will still fail | 18:40 |
| *** daniel3_ has joined #openstack-oslo | 18:42 | |
| sigmavirus24 | So I know for a fact that keystone isn't the only service setting rules like that in tests. I wonder if we want the Rules class to have a .from_dict or something classmethod that does the parsing for us | 18:42 |
| sigmavirus24 | make sense? | 18:42 |
| * sigmavirus24 is also happy to add it + the tests | 18:42 | |
| stevemar | sigmavirus24, seems like thats the case | 18:47 |
| sigmavirus24 | better than import _parser and such | 18:47 |
| stevemar | yeah | 18:47 |
| stevemar | good call | 18:47 |
| * sigmavirus24 will do it after lunch | 18:47 | |
| stevemar | everything is better after lunch | 18:47 |
| sigmavirus24 | unless you get to it before then =P | 18:47 |
| stevemar | nah, looking at keystone stuff, we have a metric ton of stuff to do | 18:48 |
| stevemar | i'm just happy i got jenkins passing, big first step | 18:48 |
| sigmavirus24 | stevemar: same here with glance + I want to show how easy it'll be to move glance to oslo.policy =P | 18:48 |
| *** exploreshaifali has quit IRC | 18:55 | |
| *** khivin has quit IRC | 18:57 | |
| *** salv-orlando has quit IRC | 18:57 | |
| *** dims_ has joined #openstack-oslo | 18:59 | |
| *** 7JTACEC3O has quit IRC | 18:59 | |
| *** sreshetnyak has quit IRC | 19:01 | |
| *** dims__ has quit IRC | 19:02 | |
| *** e0ne has joined #openstack-oslo | 19:06 | |
| *** achanda has quit IRC | 19:11 | |
| openstackgerrit | Assaf Muller proposed openstack/oslo.rootwrap: WIP: Add logging in KillFilter to aid debugging https://review.openstack.org/157420 | 19:13 |
| *** dims_ has quit IRC | 19:26 | |
| *** vigneshvar has joined #openstack-oslo | 19:28 | |
| *** himangi has joined #openstack-oslo | 19:31 | |
| *** salv-orlando has joined #openstack-oslo | 19:32 | |
| *** achanda has joined #openstack-oslo | 19:34 | |
| dhellmann | stevemar: looking at https://review.openstack.org/#/c/148624/9/keystone/policy/backends/rules.py,cm -- if the Enforcer takes a policy file that is determined by the config option, we should provide an API to ask for that value or make Enforcer figure it out -- we do not want apps to access config options for libraries directly | 19:35 |
| *** vigneshvar has quit IRC | 19:38 | |
| dhellmann | stevemar: I'll leave some comments on the review | 19:40 |
| *** exploreshaifali has joined #openstack-oslo | 19:54 | |
| *** dims__ has joined #openstack-oslo | 20:01 | |
| stevemar | dhellmann, thanks! | 20:02 |
| *** crc32 has joined #openstack-oslo | 20:02 | |
| *** dims__ has quit IRC | 20:05 | |
| *** crc32 has quit IRC | 20:06 | |
| *** zzzeek has quit IRC | 20:23 | |
| *** achanda has quit IRC | 20:28 | |
| *** ihrachyshka has joined #openstack-oslo | 20:32 | |
| *** achanda has joined #openstack-oslo | 20:32 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: WIP for having the ability to have tooz find workers+topics https://review.openstack.org/151495 | 20:38 |
| *** e0ne has quit IRC | 20:47 | |
| *** yamahata has quit IRC | 20:51 | |
| openstackgerrit | Doug Hellmann proposed openstack/cliff: Fix git repo urls in tox.ini https://review.openstack.org/157522 | 20:56 |
| openstackgerrit | Dan Smith proposed openstack/oslo.versionedobjects: Sync obj_reset_changes(recursive=) change from Nova https://review.openstack.org/157523 | 21:00 |
| openstackgerrit | Dan Smith proposed openstack/oslo.versionedobjects: Sync default-setting change from Nova https://review.openstack.org/157524 | 21:00 |
| *** crc32 has joined #openstack-oslo | 21:00 | |
| * dhellmann wonders how long the cliff build was completely broken :-/ | 21:01 | |
| *** achanda has quit IRC | 21:06 | |
| openstackgerrit | Doug Hellmann proposed openstack/cliff: Fix git repo urls in tox.ini https://review.openstack.org/157522 | 21:17 |
| *** achanda has joined #openstack-oslo | 21:24 | |
| *** dims__ has joined #openstack-oslo | 21:29 | |
| *** morganfainberg is now known as needscoffee | 21:32 | |
| *** ajo has quit IRC | 21:36 | |
| *** ajo has joined #openstack-oslo | 21:37 | |
| *** achanda has quit IRC | 21:40 | |
| *** ihrachyshka has quit IRC | 21:44 | |
| *** andreykurilin_ has joined #openstack-oslo | 21:45 | |
| *** achanda has joined #openstack-oslo | 21:46 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo-specs: add references to spec approval policy https://review.openstack.org/157538 | 21:48 |
| *** jaypipes has quit IRC | 21:53 | |
| *** MasterPiece has quit IRC | 21:56 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.config: Add FAQ section to documentation https://review.openstack.org/157546 | 21:59 |
| openstackgerrit | Merged openstack/oslo-specs: add references to spec approval policy https://review.openstack.org/157538 | 22:03 |
| openstackgerrit | Ian Cordasco proposed openstack/oslo.policy: Add Rules.from_dict classmethod https://review.openstack.org/157548 | 22:05 |
| *** viktors has quit IRC | 22:08 | |
| *** viktors has joined #openstack-oslo | 22:12 | |
| dhellmann | harlowja: do you have permission to change the maintainer of debtcollector on launchpad? I'd like to update the project configuration, but can't because I'm not an OpenStack Administrator | 22:12 |
| *** openstackstatus has joined #openstack-oslo | 22:15 | |
| *** ChanServ sets mode: +v openstackstatus | 22:15 | |
| dhellmann | harlowja: I updated the work items in https://blueprints.launchpad.net/oslo-incubator/+spec/adopt-debtcollector | 22:15 |
| *** dims__ has quit IRC | 22:15 | |
| *** stannie has left #openstack-oslo | 22:21 | |
| harlowja | dhellmann i think i cans | 22:28 |
| harlowja | hmmm dhellmann don't think i can, haha | 22:28 |
| harlowja | jeblair i think is the admin of https://launchpad.net/~openstack-admins so my guess is he can? | 22:29 |
| *** tedross has left #openstack-oslo | 22:31 | |
| *** mriedem has quit IRC | 22:33 | |
| harlowja | dhellmann its all done | 22:37 |
| dhellmann | harlowja: thanks! | 22:44 |
| * harlowja also updated https://blueprints.launchpad.net/oslo-incubator/+spec/adopt-debtcollector with what i think is accurate | 22:44 | |
| harlowja | are all the devstack changes needed for this? | 22:44 |
| *** exploreshaifali has quit IRC | 22:47 | |
| *** dulek has joined #openstack-oslo | 22:48 | |
| dhellmann | harlowja: oops, I just edited the blueprint page and may have overwritten your changes (I hate launchpad) | 22:50 |
| harlowja | thats ok, i'll overwrite yours, ha | 22:51 |
| harlowja | lol | 22:51 |
| dhellmann | harlowja: yes, you'll need to do all of the gate and devstack stuff | 22:51 |
| * harlowja probably just overwrite your changes, lol | 22:51 | |
| harlowja | refresh and it should be back to what i had :-P | 22:52 |
| *** kgiusti has left #openstack-oslo | 22:52 | |
| dhellmann | harlowja: I'm merging the lists here: https://etherpad.openstack.org/p/9GKKwPT40H | 22:53 |
| harlowja | lol | 22:53 |
| harlowja | kk | 22:53 |
| harlowja | ghetto-launchpad | 22:53 |
| harlowja | let me get the devstack changes up shouldn't be so hard | 22:54 |
| *** dulek has quit IRC | 22:54 | |
| *** jgrimm is now known as zz_jgrimm | 22:55 | |
| dhellmann | harlowja: requesting lock for the blueprint page to update the work items :-) | 22:57 |
| harlowja | ack | 22:57 |
| dhellmann | harlowja: commited | 22:58 |
| harlowja | what is your favorite color | 22:58 |
| harlowja | oh no, u didn't answer your favorite color | 22:58 |
| harlowja | lol | 22:58 |
| dhellmann | heh. | 22:58 |
| dhellmann | I removed some of the n/a items and marked some others done | 22:58 |
| harlowja | kk | 22:58 |
| dhellmann | so I think it's correct now | 22:58 |
| harlowja | https://review.openstack.org/#/c/157566/ should fix that projects.txt so i guess can be marked | 22:59 |
| harlowja | or i can mark when merges, either or | 22:59 |
| openstackgerrit | Ian Cordasco proposed openstack/oslo.policy: Fix the order of args to assertEqual in tests https://review.openstack.org/157572 | 22:59 |
| dhellmann | harlowja: when it merges | 22:59 |
| harlowja | k | 22:59 |
| dhellmann | harlowja: what I've done elsewhere is add the link to the review on the line with the todo item, so anyone can check if it's done and mark it complete when the merge happens | 22:59 |
| harlowja | ah | 23:00 |
| harlowja | ok | 23:00 |
| harlowja | but that means acquiring the launchpad lock | 23:00 |
| harlowja | and thats a dangerous process | 23:00 |
| dhellmann | harlowja: this writer is signing off for the night, so you should be clear | 23:00 |
| harlowja | :) | 23:01 |
| stevemar | sigmavirus24, so much wrong with assertEquals | 23:01 |
| sigmavirus24 | stevemar: I considered three separate changes, one for each file | 23:02 |
| stevemar | sigmavirus24, meh | 23:02 |
| sigmavirus24 | but I wasn't sure if that would be annoying or helpful | 23:02 |
| sigmavirus24 | Also I couldnt' find the LP bug that all the other projects were using to track this | 23:02 |
| sigmavirus24 | so | 23:02 |
| * sigmavirus24 shrugs | 23:02 | |
| stevemar | sigmavirus24, i'm wondering why the ones that assert a boolean value aren't just assertTrue/Fals | 23:02 |
| stevemar | assertTrue/False* | 23:03 |
| sigmavirus24 | stevemar: good point, should I make those a dependent patch or just throw those in this one? | 23:03 |
| stevemar | i'd say depends on this one | 23:03 |
| *** noelbk has quit IRC | 23:03 | |
| * sigmavirus24 doesn't mind juggling 3 patchsets | 23:03 | |
| stevemar | i mean, if it makes sense, i can't see a reason not to use that | 23:03 |
| stevemar | sigmavirus24, lets try to push this one through | 23:04 |
| sigmavirus24 | agreed. this was more of a robotic fix them all | 23:04 |
| stevemar | luckily, the booleans are mostly located in 1 file | 23:04 |
| stevemar | test_checks | 23:05 |
| *** crc32 has quit IRC | 23:07 | |
| stevemar | sigmavirus24, https://bugs.launchpad.net/oslo.policy/+bug/1277104 | 23:08 |
| openstack | Launchpad bug 1277104 in python-ceilometerclient "wrong order of assertEquals args " [Low,In progress] - Assigned to Jia Dong (jiadong-jia) | 23:08 |
| sigmavirus24 | Thanks stevemar | 23:08 |
| openstackgerrit | Ian Cordasco proposed openstack/oslo.policy: Fix the order of args to assertEqual in tests https://review.openstack.org/157572 | 23:09 |
| stevemar | np at all | 23:11 |
| *** prad has quit IRC | 23:16 | |
| openstackgerrit | Ian Cordasco proposed openstack/oslo.policy: Use assertTrue or assertFalse where appropriate https://review.openstack.org/157583 | 23:17 |
| sigmavirus24 | stevemar: because I'm still waiting for local test of os-ansible-deployment to finish ^ | 23:18 |
| *** crc32 has joined #openstack-oslo | 23:19 | |
| *** noelbk has joined #openstack-oslo | 23:30 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: WIP for having the ability to have tooz find/advertise workers https://review.openstack.org/151495 | 23:30 |
| *** ajo has quit IRC | 23:30 | |
| *** salv-orlando has quit IRC | 23:39 | |
| *** daniel3_ has quit IRC | 23:40 | |
| *** andreykurilin_ has quit IRC | 23:40 | |
| *** salv-orlando has joined #openstack-oslo | 23:40 | |
| openstackgerrit | Merged openstack/cliff: Fix git repo urls in tox.ini https://review.openstack.org/157522 | 23:44 |
| *** mriedem has joined #openstack-oslo | 23:53 | |
| *** bknudson has quit IRC | 23:53 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!