Tuesday, 2015-02-17

dims_dansmith: still around? 156397 needed http://paste.openstack.org/show/175551/ to pass py3400:04
dansmithyep working on it now thanks00:08
*** dims_ has quit IRC00:27
*** mtanino has quit IRC00:28
*** dims__ has joined #openstack-oslo00:30
openstackgerritSteve Martinelli proposed openstack/oslo.policy: Use single quotes consistently  https://review.openstack.org/15640400:37
dansmithdims__: that was a lie.. I was on the phone "now". *now* I'm working on it :P00:48
*** bknudson has joined #openstack-oslo00:48
dims__:)00:48
dims__left a couple of comments in others too dansmith00:49
*** jaosorior has quit IRC00:51
openstackgerritMerged openstack/oslo.versionedobjects: Remove internal items from public namespace  https://review.openstack.org/15639300:53
*** vigneshvar has quit IRC00:55
*** jecarey has quit IRC01:00
openstackgerritDan Smith proposed openstack/oslo.versionedobjects: Generalize object dependency change detection  https://review.openstack.org/15639901:10
openstackgerritDan Smith proposed openstack/oslo.versionedobjects: Generalize object hash-based change detection  https://review.openstack.org/15639801:10
openstackgerritDan Smith proposed openstack/oslo.versionedobjects: Generalize remote testing infrastructure  https://review.openstack.org/15639701:10
openstackgerritDan Smith proposed openstack/oslo.versionedobjects: Add conditional object registration  https://review.openstack.org/15639601:10
openstackgerritDan Smith proposed openstack/oslo.versionedobjects: Remove Nova objects module registration code  https://review.openstack.org/15639501:10
openstackgerritDan Smith proposed openstack/oslo.versionedobjects: Generalize the indirection_api interface  https://review.openstack.org/15639401:10
openstackgerritDan Smith proposed openstack/oslo.versionedobjects: Fix py34 for iteritems() use in base.py  https://review.openstack.org/15642901:10
*** sigmavirus24 is now known as sigmavirus24_awa01:17
*** zzzeek has quit IRC01:21
dims__dansmith: Nova will have a new class that extends base.VersionedObjectRegistry right?01:22
*** zzzeek has joined #openstack-oslo01:23
dansmithdims__: probably initially, but not necessarily forever01:23
dims__asking because...do we want to leave the ObjectVersionChecker hard coded to look in base.VersionedObjectRegistry?01:24
dansmithdims__: hmm, I was thinking it wouldn't matter because of the singleton-ness, as long as we instantiate the subclass first, but now I'm wondering if that's right01:25
dansmithdims__: so maybe we should pass a registry class to those test functions, and I might look at the rest of the bits as well to make sure a subclass registry looks like we want01:26
dims__cool01:26
dansmithdims__: since I added the registration hook, I'm not sure we really will need to subclass it, but we should allow for it probably01:27
*** noelbk has quit IRC01:27
dims__ack01:27
dims__dansmith: also was thinking about if exposing relevant_data that was used to calculate the fingerprint may be useful when the hash does fail, it's easy to spot what changed...01:31
*** zzzeek has quit IRC01:39
openstackgerritIan Cordasco proposed openstack/oslo.policy: Fix minor spelling issues in oslo.policy  https://review.openstack.org/15640501:41
*** harlowja_at_home has joined #openstack-oslo02:07
*** salv-orlando has quit IRC02:13
*** tsekiyam_ has joined #openstack-oslo02:26
openstackgerritJoshua Harlow proposed openstack/taskflow: Move 'provides' and 'name' to instance attributes  https://review.openstack.org/15506002:26
*** tsekiyama has quit IRC02:30
openstackgerritJoshua Harlow proposed openstack/taskflow: Allow loading conductors via entrypoints  https://review.openstack.org/12461702:30
*** tsekiyam_ has quit IRC02:30
openstackgerritJoshua Harlow proposed openstack/taskflow: Chain exceptions correctly on py3.x  https://review.openstack.org/15516802:32
openstackgerritJoshua Harlow proposed openstack/taskflow: Use the ability to chain exceptions correctly  https://review.openstack.org/15518702:32
*** harlowja_at_home has quit IRC02:33
*** bknudson has quit IRC02:37
*** dims__ has quit IRC02:40
*** harlowja_at_home has joined #openstack-oslo02:40
*** salv-orlando has joined #openstack-oslo03:14
openstackgerritJoshua Harlow proposed openstack/debtcollector: By default mutate the docstring(s) for deprecations  https://review.openstack.org/15598803:17
*** dims__ has joined #openstack-oslo03:40
*** himangi has quit IRC03:43
*** amotoki_ has joined #openstack-oslo03:43
*** amotoki_ has quit IRC03:45
*** dims__ has quit IRC03:45
*** harlowja_at_home has quit IRC03:46
*** achanda has joined #openstack-oslo03:56
openstackgerritJoshua Harlow proposed openstack/taskflow: Move 'provides' and 'name' to instance attributes  https://review.openstack.org/15506004:00
*** yamahata has joined #openstack-oslo05:14
*** devlaps has quit IRC05:16
*** rushiagr_away is now known as rushiagr05:23
*** achanda has quit IRC05:43
*** achanda has joined #openstack-oslo05:46
*** pcaruana has quit IRC05:47
openstackgerritJoshua Harlow proposed openstack/taskflow: Add todo note for kombu pull request  https://review.openstack.org/15647205:57
*** viktors has quit IRC06:12
*** vigneshvar has joined #openstack-oslo06:34
*** yamahata has quit IRC07:00
*** salv-orlando has quit IRC07:07
*** ozamiatin has quit IRC07:09
*** dims__ has joined #openstack-oslo07:18
*** dims__ has quit IRC07:23
*** inc0 has joined #openstack-oslo07:28
*** stevemar has quit IRC07:38
*** achanda has quit IRC07:47
*** achanda has joined #openstack-oslo07:54
*** andreykurilin_ has joined #openstack-oslo08:05
*** achanda has quit IRC08:20
*** dtantsur|afk is now known as dtantsur08:23
*** achanda has joined #openstack-oslo08:24
*** achanda has quit IRC08:30
*** achanda has joined #openstack-oslo08:37
*** salv-orlando has joined #openstack-oslo08:38
*** achanda has quit IRC08:47
*** viktors has joined #openstack-oslo08:52
*** salv-orlando has quit IRC09:15
*** ihrachyshka has joined #openstack-oslo09:26
*** snikitin has quit IRC09:35
*** e0ne has joined #openstack-oslo09:48
*** salv-orlando has joined #openstack-oslo10:03
*** e0ne is now known as e0ne_10:21
*** ajo has joined #openstack-oslo10:25
*** e0ne_ has quit IRC10:26
*** e0ne has joined #openstack-oslo10:38
*** e0ne has quit IRC11:01
*** e0ne has joined #openstack-oslo11:02
*** salv-orlando has quit IRC11:02
openstackgerritMerged openstack/oslo.versionedobjects: Fix py34 for iteritems() use in base.py  https://review.openstack.org/15642911:06
*** dulek has joined #openstack-oslo11:08
*** bogdando has quit IRC11:20
*** bogdando has joined #openstack-oslo11:23
*** e0ne has quit IRC11:24
*** e0ne has joined #openstack-oslo11:25
*** cdent has joined #openstack-oslo11:32
*** dims__ has joined #openstack-oslo11:32
*** khivin has quit IRC11:33
*** bogdando has quit IRC11:35
*** bogdando has joined #openstack-oslo11:36
*** e0ne is now known as e0ne_11:44
dims__sileht: denis_makogon: have you seen this before? https://bugs.launchpad.net/nova/+bug/118864311:51
openstackLaunchpad bug 1188643 in OpenStack Compute (nova) "notification queues are created in rabbit but never consumed" [Medium,Confirmed] - Assigned to Jian Wen (wenjianhn)11:51
*** e0ne_ has quit IRC11:54
denis_makogondims__, i've seen that before, and also noticed that reminder from jerdfelt, so, it does seem like one of the possible solutions was described  - having a config option that says create or don't do that.11:55
*** e0ne has joined #openstack-oslo11:55
*** andreykurilin_ has quit IRC11:57
*** andreykurilin__ has joined #openstack-oslo11:57
dims__denis_makogon: that won't help the case where say both nova and ceilometer was supposed to be running together and ceilometer went away (so no one is reading from the queues) right?11:57
denis_makogondims__, in that case, we should be completely sure that consumer will consume, right?12:00
dims__denis_makogon: or find some setting in rabbitmq so it does fail badly12:01
denis_makogondims__, will try to investigate this issue, thanks12:02
*** salv-orlando has joined #openstack-oslo12:02
dims__thanks denis_makogon12:03
denis_makogondims__, np =)12:07
*** e0ne is now known as e0ne_12:19
*** e0ne_ is now known as e0ne12:23
*** rushiagr is now known as rushiagr_away12:41
*** salv-orlando has quit IRC12:50
*** salv-orlando has joined #openstack-oslo12:50
openstackgerritMerged openstack/oslo.versionedobjects: Rename utils -> _utils  https://review.openstack.org/15440912:53
openstackgerritMerged openstack/oslo.vmware: PBM utility method to retrieve profiles of a VM  https://review.openstack.org/15574512:56
openstackgerritMerged openstack/oslo.middleware: Adds missing files  https://review.openstack.org/15406312:59
openstackgerritMerged openstack/oslo.concurrency: Drop use of namespaced oslo.i18n  https://review.openstack.org/15183013:02
openstackgerritMerged openstack/oslo.vmware: Handle SPBM SecurityError  https://review.openstack.org/15616413:09
*** _amrith_ is now known as amrith13:15
*** dulek has quit IRC13:16
*** vigneshvar has quit IRC13:22
dims__pasquier-s: so, if we can add a toggle for switching off notifications in nova. that would work right? (for cases where there is no one listening)13:26
pasquier-sdims: nope13:27
pasquier-swhat other have proposed in the bug report is to have a configuration option for disabling the automatic creation of the queues13:27
dims__pasquier-s: in oslo.messaging?13:28
pasquier-swell, i've no sufficient knowledge of oslo.messaging to understand whether it's nova or oslo.messaging that creates the queue...13:29
dims__pasquier-s: ack, just want to make sure i understand what has been done/researched so far13:30
pasquier-sdims__, np :)13:31
*** gordc has joined #openstack-oslo13:34
*** kgiusti has joined #openstack-oslo13:34
*** himangi has joined #openstack-oslo13:39
bretonhello13:46
bretonwhat's the status of versionutils.py in oslo-incubator? Doesn't it do the same as debtcollector?13:47
*** amotoki has quit IRC13:49
*** HenryG has quit IRC13:49
*** HenryG has joined #openstack-oslo13:52
*** amotoki has joined #openstack-oslo13:54
bretonright, reading https://review.openstack.org/#/c/141220/7/specs/kilo/adopt-debtcollector.rst now. That would be great to have the descriprion somewhere in the docs13:55
*** e0ne is now known as e0ne_13:56
*** himangi has quit IRC13:58
ihrachyshkadhellmann, https://review.openstack.org/#/c/137913/ please remove -213:59
*** e0ne_ is now known as e0ne14:00
*** trown|outttypeww is now known as trown14:02
*** bknudson has joined #openstack-oslo14:20
haypoihrachyshka: but, your patch modifies the wrong path, no?14:30
haypoihrachyshka: oslo/messaging/ has been moved to oslo_messaging/14:30
ihrachyshkahaypo, it's a backport14:30
ihrachyshkahaypo, which makes Doug's comment not applicable :)14:30
haypoihrachyshka: ah yes :)14:30
*** pradk has quit IRC14:32
hayposileht: hi. can you accept https://review.openstack.org/#/c/137913/ even if dhellmann voted -1 on the workflow (but also voted +2)14:34
hayposileht: (i can't)14:34
*** rushiagr_away is now known as rushiagr14:37
*** pradk has joined #openstack-oslo14:39
*** zz_jgrimm is now known as jgrimm14:40
*** mriedem has joined #openstack-oslo14:45
dhellmannihrachyshka, haypo: gerrit needs to show "stable/juno" in big flashing red letters :-/14:50
dhellmannihrachyshka, haypo : +2a14:50
ihrachyshkadhellmann, lol14:51
haypodhellmann: why not a random color? ;)14:52
dhellmannhaypo: as long as it's flashing I don't care what color it is :-)14:53
*** daniel3_ has joined #openstack-oslo14:53
*** sigmavirus24_awa is now known as sigmavirus2414:54
dims__pasquier-s: denis_makogon: so far it seems that we can either NOT create a queue https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/_drivers/impl_rabbit.py#L452 or we can stop nova from sending notifications in https://github.com/openstack/nova/blob/master/nova/notifications.py for cases where there is no one who will be listening14:56
denis_makogondims__, i'd vote for stop nova sending notifications =)14:56
dims__sileht: ^^^ we are talking about  https://bugs.launchpad.net/nova/+bug/118864314:57
openstackLaunchpad bug 1188643 in OpenStack Compute (nova) "notification queues are created in rabbit but never consumed" [Medium,Confirmed] - Assigned to Jian Wen (wenjianhn)14:57
*** mtanino has joined #openstack-oslo14:57
dims__denis_makogon: guessing we may need both for different scenarios, the one in MOS is definitely quicker to do the nova/notifications14:58
dims__pasquier-s: wdyt?14:58
*** jaosorior has joined #openstack-oslo15:00
denis_makogonpasquier-s, sileht, dims__, yes, that i was thinking about. But in general if someone wants to create queues oslo.messaging should not forbid doing it, it does seem like up to components to handle consumption,15:00
pasquier-sI'd vote for having a way to disable the queue creation15:00
*** mriedem has quit IRC15:02
dhellmanndenis_makogon, pasquier-s, dims__: in this case, why is nova configured to send notifications if nothing is there to listen for them? why not use a no-op notifier?15:02
*** dims__ has quit IRC15:03
*** cdent_ has joined #openstack-oslo15:03
denis_makogondhellmann, actually it might work15:03
*** cdent has quit IRC15:04
*** cdent_ is now known as cdent15:04
*** dims__ has joined #openstack-oslo15:04
*** dims__ has quit IRC15:04
*** mriedem has joined #openstack-oslo15:04
*** dims__ has joined #openstack-oslo15:05
pasquier-sdhellmann, one use case is a service external to OpenStack (eg not Ceilo) that wants to receive notifications using a dedicated queue.15:05
pasquier-sdhellmann, and it doesn't really care losing notifications15:06
openstackgerritMichal Jastrzebski (inc0) proposed openstack/oslo.versionedobjects: Fixes for heat implementation  https://review.openstack.org/15483515:06
dhellmannpasquier-s: so the notifications are wanted, but someone doesn't like the default queue name?15:06
dims__pasquier-s: denis_makogon: y, for the case where there will be no ceilometer, then NoOpDriver is better choice15:06
denis_makogondims__, sure thing15:06
*** e0ne is now known as e0ne_15:07
pasquier-sdhellmann, the service doesn't want to consume from the default queue15:07
*** jecarey has joined #openstack-oslo15:07
*** amotoki has joined #openstack-oslo15:07
silehtpasquier-s, denis_makogon dhellmann the queue name is configurable and I confirm if you don't want a queue you have to use the NoopDriver15:08
*** e0ne_ is now known as e0ne15:08
dhellmannsileht: it's configurable via the "notification_topics" option?15:09
silehtdhellmann, yes15:09
dhellmannsileht: this has come up a few times, maybe we need to add a FAQ to the docs15:10
silehtdhellmann, sure15:10
* sileht is just passing, he's off this week15:11
*** salv-orlando has quit IRC15:11
dims__sileht: have a good vacation/week off :)15:11
dhellmannsileht: I'll file a bug so we don't forget to write it up. Have a good week!15:11
dims__pasquier-s: denis_makogon: between these options, we have all we need right?15:12
*** salv-orlando has joined #openstack-oslo15:13
denis_makogondims__, it seems like yes15:14
dims__cool thanks15:14
*** takedakn has joined #openstack-oslo15:15
openstackgerritDoug Hellmann proposed openstack/oslo.messaging: Add FAQ entry for notifier configuration  https://review.openstack.org/15661915:23
dhellmannsileht, dims__ : it was easier to write the faq than the bug report ^^15:24
*** jaypipes has quit IRC15:24
dims__:)15:26
*** stevemar has joined #openstack-oslo15:28
*** achanda has joined #openstack-oslo15:32
*** achanda has quit IRC15:41
dansmithdims__: got py34 locally, but when I try to run I get "db type could not be determined"15:44
*** takedakn has quit IRC15:47
viktorsdansmith: rm -r .testrepository/ && tox -e py3415:47
dansmithviktors: py27 and py34 testr aren't compatible?15:47
dims__dansmith: need to run py34 first and then py27 then it works15:47
viktorsdansmith: there are some differences in file formats, I don't remember exactly15:48
viktorsbut as dims__ told, py27 works good after py3x tests15:48
dansmithhmm, okay15:48
sdaguetestr uses dbm files for storage15:49
sdaguethe format created by py3 works with py2, but not the other way around15:50
sdagueit's... special15:50
*** khivin has joined #openstack-oslo15:50
*** zzzeek has joined #openstack-oslo15:51
viktorszzzeek, rpodolyaka: Hi folks! How do you think, do we need in oslo.db something similar to https://review.openstack.org/#/c/154521/ ?15:52
dansmithsdague: bizarre15:54
dims__dansmith: yep15:54
dansmithokay, that seems to work15:54
zzzeekviktors: possible.  I’m confused if that’s actually been merged to nova yet, and if there are any guidelines on how to use them.  there’s some notion of migrations that still have to be written in between , I dont understand how that works either.   the system conflates two different things: autogenerate and the notion of the separate up/down streams.   alembic supports separate up/down streams directly now.15:55
viktorszzzeek: there are some details about it in spec. I'm looking for it now15:58
viktorszzzeek: https://github.com/openstack/nova-specs/blob/master/specs/kilo/approved/online-schema-changes.rst15:58
zzzeekviktors: i read the spec several times15:58
viktorszzzeek: :)15:58
zzzeekviktors: basically I had to clamor in there to not have it written on migrate which would have made dropping migrate that much harder15:59
zzzeekviktors: so at least I got that15:59
zzzeekviktors: very frustrating.  my changes to database practices languish while people are skeptical and fail to appreciate their importance, but then other DB changes that I think are questionable fly right through and I can barely affect them16:00
*** sdague has quit IRC16:00
*** sdague has joined #openstack-oslo16:02
dhellmannsdague, dansmith : the testr issue is caused by python 3 dropping a dbm library that happened to be the default for anydbm under python 216:04
*** achanda has joined #openstack-oslo16:05
*** achanda has quit IRC16:06
dhellmannviktors: how are things looking with that test that was breaking in ironic? are we ready to release oslo.db, or should we wait?16:07
sdaguedhellmann: interesting, so it's fixable if testr specified format?16:08
*** mriedem has quit IRC16:08
*** mriedem1 has joined #openstack-oslo16:08
dhellmannsdague: I haven't looked at the testr code, but it's possible -- of course then you'd have to worry about which dbm library was actually installed on a box, which is why anydbm was picked to begin with16:09
*** tsekiyama has joined #openstack-oslo16:09
dhellmannand if they're using shelve, I don't think you can specify the format16:09
*** e0ne has quit IRC16:09
dhellmannsdague: the other fix would be for testr to keep version-specific databases, but there may be a use case for not doing that, too16:10
dhellmannof just use sqlite :-)16:10
dhellmanns/of/or/16:10
sdagueyeh, seriously :)16:10
*** amotoki has quit IRC16:13
openstackgerritDan Smith proposed openstack/oslo.versionedobjects: Generalize object dependency change detection  https://review.openstack.org/15639916:26
openstackgerritDan Smith proposed openstack/oslo.versionedobjects: Generalize object hash-based change detection  https://review.openstack.org/15639816:26
openstackgerritDan Smith proposed openstack/oslo.versionedobjects: Generalize remote testing infrastructure  https://review.openstack.org/15639716:26
openstackgerritDan Smith proposed openstack/oslo.versionedobjects: Add conditional object registration  https://review.openstack.org/15639616:26
openstackgerritDan Smith proposed openstack/oslo.versionedobjects: Remove Nova objects module registration code  https://review.openstack.org/15639516:26
openstackgerritDan Smith proposed openstack/oslo.versionedobjects: Generalize the indirection_api interface  https://review.openstack.org/15639416:26
mtreinishdhellmann: the testr sqlite thing is going to happen eventually16:32
viktorsdhellmann: we are not ready to release today - I've sent a workaround to Ironic but it isn't merged yet16:32
viktorswill ping cores tomorrow16:32
mtreinishthat's something Robert and I discussed doing with subunit2sql16:32
*** andreykurilin__ has quit IRC16:34
*** andreykurilin_ has joined #openstack-oslo16:34
dhellmannmtreinish: cool; I haven't looked at the schema so I don't know how hard that would be16:35
dhellmannviktors: ok, sounds good16:36
mtreinishdhellmann: it's actually just using dbm as a keypair value store for test_run times16:36
mtreinishit's just test_id: run_time16:36
mtreinishthe subunit2sql thing is more long term since it would be storing basically everything in the db16:37
dhellmannmtreinish: ah, ok, that should be a fairly straightforward schema change, then16:38
*** dtantsur is now known as dtantsur|afk16:44
*** ihrachyshka has quit IRC16:49
*** andreykurilin_ has quit IRC16:49
*** andreykurilin_ has joined #openstack-oslo16:49
*** bknudson has quit IRC16:50
*** viktors is now known as viktors|afk16:51
openstackgerritDan Smith proposed openstack/oslo.versionedobjects: Generalize object dependency change detection  https://review.openstack.org/15639916:53
openstackgerritDan Smith proposed openstack/oslo.versionedobjects: Generalize object hash-based change detection  https://review.openstack.org/15639816:53
openstackgerritDan Smith proposed openstack/oslo.versionedobjects: Generalize remote testing infrastructure  https://review.openstack.org/15639716:53
openstackgerritDan Smith proposed openstack/oslo.versionedobjects: Add conditional object registration  https://review.openstack.org/15639616:53
openstackgerritDan Smith proposed openstack/oslo.versionedobjects: Remove Nova objects module registration code  https://review.openstack.org/15639516:53
openstackgerritDan Smith proposed openstack/oslo.versionedobjects: Generalize the indirection_api interface  https://review.openstack.org/15639416:53
openstackgerritDan Smith proposed openstack/oslo.versionedobjects: Disable some unstable tests until they are generalized  https://review.openstack.org/15666016:53
openstackgerritDan Smith proposed openstack/oslo.versionedobjects: Add a test to ensure subclassibility of the object registry  https://review.openstack.org/15666216:59
mtreinishdhellmann: qq, is there a good pattern somewhere for using the requestid middleware and then getting it log the request id on every incoming request?16:59
mtreinishdhellmann: I'm just thinking for the next step after https://review.openstack.org/15590116:59
*** inc0 has quit IRC17:03
dhellmannmtreinish: gordc is our middleware expert, so he might know17:04
mtreinishdhellmann: ok, thanks17:04
dhellmannmtreinish: do you want the request id added to the logging context, or just logged from the middleware?17:04
mtreinishdhellmann: probably the context. I'm looking for something similar to nova where the request-id is in both the incoming request log and all the internal operations associated with that request17:06
mtreinishwhich I assume is all handled when it's in the logging context17:06
dhellmannmtreinish: ok, I think the middleware is just the first part of that. You also need to create a RequestContext somewhere in the flow. I don't have a good example of that handy, though.17:07
dhellmannthe RequestContext is stored in a thread-local when it is created, and the logging code looks for it to add data to the log records17:08
mtreinishdhellmann: ok, that makes sense. I'll do some digging and try to come up with something17:10
mtreinishthanks17:10
dhellmannmtreinish: we need to work on the docs for the new libs, to add examples like this17:11
mtreinishdhellmann: if I come up with something I can help with a doc patch afterwards17:11
dhellmannmtreinish: that would be really helpful. In this case, I'm not sure if it should go in the oslo.context docs or the oslo.log docs, but one of those.17:12
*** jaypipes has joined #openstack-oslo17:26
*** rushiagr is now known as rushiagr_away17:29
*** miqui_ has quit IRC17:34
*** miqui has quit IRC17:37
*** rushiagr_away is now known as rushiagr17:37
*** e0ne has joined #openstack-oslo17:38
zzzeekmr bnemec17:42
zzzeekquestion about oslo.concurrency17:43
bnemeczzzeek: Shoot17:44
zzzeekso, cinder seems like it uses this when its starting up.   not sure if you noticed on the ML im pulling my hair out with a seeming sqlalhcemy connection pool issue17:45
zzzeekbut what im looking at is, this thing actually is spawning a child fork, then letting eventlet run in *that* too17:45
zzzeekwhihc means, if the parent proces called create_engine(), now there’s a connection pool, now it spawns a fork, now that pool is copied over to the subprocess, same file descriptor for the MySQL connection, kaboom17:46
zzzeekbecause, when you use multiprocessing with SQLAlchemy, you *must must must* make a totally new engine in the child17:46
zzzeekthis all sound plausible ?17:46
zzzeekthe error condition i have here only happens with this subprocess kicks off17:47
zzzeekand it does it in this bizarro way where it shows me the same object ids with entirely different state17:47
zzzeekguess I need to add process id to my logging output :)17:47
bnemeczzzeek: Hmm, I'm not familiar with how thread pools propagate through subprocesses, but it does sound plausible.17:49
bnemecI know we've had issues with things forking and sharing objects in the past, although I think that was more file descriptors.17:49
zzzeekbnemec: taht is what we are talking about :)17:52
zzzeekbnemec: a mysql connection is a file descriptor17:52
zzzeekWOW you openstack folks, scared the crap out of me.  well let me confirm this first17:53
bnemeczzzeek: Oh, is this another late monkey patching problem?17:53
zzzeekbnemec: not at all17:53
zzzeekbnemec: the eventlet factor here threw me on the totally wrong path all day yesterday and today.   it has nothing to do with it17:53
bnemeczzzeek: Ah, okay.  That probably would have been easier to fix. :-/17:54
zzzeekbnemec: you can’t call create_engine(), then spawn a subprocess, and use that engine in parent/subproces at the same time, because file descriptors are pooled in it17:54
bnemeczzzeek: Okay, so the change we had around this was related to lockutils: https://github.com/openstack/oslo.concurrency/commit/2dae1fd780198719f35d79e3b01db26cfc2ebf2817:57
bnemecBasically Python 3 doesn't propagate the file descriptors by default.17:57
bnemecI don't know that it helps here though.17:57
zzzeekwell im working in py217:57
bnemeczzzeek: Yeah, but if they're doing something where they rely on a file descriptor remaining open after a spawn it's going to break in py3 anyway.  They probably haven't noticed because nobody's running live on py3 yet.17:59
zzzeekbnemec: im working on an actual reported py2k bug17:59
zzzeekoh i see it owuld break more quickly18:00
zzzeekright18:00
zzzeekwell18:00
bnemecYeah, that's what I'm getting at.18:00
zzzeekim going to add a “it will definitely break” thing to oslo.db18:00
*** bknudson has joined #openstack-oslo18:01
bnemeczzzeek: Is there any way we could get O_CLOEXEC set on the mysql file descriptors?18:01
* dhellmann wonders how many other places that will break18:01
bnemecSounds like that's the behavior you want anyway.18:01
zzzeekdhellmann: this *has* to break quickly and loudly.  its unlikely it is silently happening wiht database connections anywhere else18:01
dhellmannzzzeek: yeah, just beware that it will be seen as oslo.db breaking something that was working before18:02
zzzeekdhellmann: this is a battle I can wage pretty easily .  i dont think this is very prevalent.  in cinder, cinder is already broken, this jsut makes the failure happen deterministically18:03
dhellmannthat's certainly better, then18:04
zzzeekdhellmann: the bug is, “when people share pools across processes, it breaks in weird non-determinsitic ways and wastes zzzeek’s time b.c. nobody knows what they are seeing” :)18:04
bnemecCall it a py3k compatibility fix.  Nobody understands that well enough to argue anyway. ;-)18:04
dhellmannzzzeek: :-)18:05
zzzeekthis is the bug fyi https://bugs.launchpad.net/cinder/+bug/141701818:05
openstackLaunchpad bug 1417018 in Cinder "Cinder encounters dbapi error: NoSuchColumnError: "Could not locate column in row for column '%(140070887032400 anon)s.volumes_id'"" [Undecided,New]18:05
*** yamahata has joined #openstack-oslo18:06
*** harlowja_away is now known as harlowja_18:10
harlowja_zzzeek u figure it out yet? :-P18:13
zzzeekharlowja_: yup18:13
*** ihrachyshka has joined #openstack-oslo18:13
harlowja_sweet18:13
*** bknudson has quit IRC18:14
zzzeekharlowja_: threading spec yes please18:14
*** andreykurilin_ has quit IRC18:14
harlowja_damn it, someone noticed i wrote that, haha18:14
harlowja_;)18:14
*** andreykurilin_ has joined #openstack-oslo18:14
zzzeekdhellmann: I acutally could modify my “raise an error and complain” approach to just re-connect in the subprocess :)18:15
zzzeekdhellmann: but then people will call it “an oslo.db bug” :(18:15
*** mriedem1 is now known as mriedem18:15
zzzeekbleh.   stupid better solutions that dont make people feel bad18:16
*** bknudson has joined #openstack-oslo18:16
*** himangi has joined #openstack-oslo18:17
*** achanda has joined #openstack-oslo18:18
harlowja_zzzeek so somewhere in cinder they are creating a sqlalchemy engine before the service.py stuff forks?18:21
zzzeekharlowja_: yes18:21
zzzeekharlowja_: this isnt an uncommon problem18:21
harlowja_ya, i could see people doing that quite often18:22
*** vigneshvar has joined #openstack-oslo18:23
*** sigmavirus24 is now known as sigmavirus24_awa18:25
*** noelbk has joined #openstack-oslo18:27
*** vigneshvar has quit IRC18:31
*** sigmavirus24_awa is now known as sigmavirus2418:31
openstackgerritMerged openstack/oslo.concurrency: processutils: execute(): fix option incompatibility  https://review.openstack.org/14703318:38
*** devlaps has joined #openstack-oslo18:40
*** vigneshvar has joined #openstack-oslo18:43
*** devlaps has quit IRC18:49
*** jecarey has quit IRC18:52
*** mriedem has quit IRC18:58
*** mriedem has joined #openstack-oslo19:01
*** rushiagr is now known as rushiagr_away19:02
*** vigneshvar has quit IRC19:04
harlowja_zzzeek https://review.openstack.org/156711 ok, mostly a shell though, ha19:04
*** ihrachyshka has quit IRC19:04
zzzeekheh19:04
*** jecarey has joined #openstack-oslo19:09
*** ajo has quit IRC19:13
*** openstackgerrit has quit IRC19:20
*** openstackgerrit has joined #openstack-oslo19:20
*** vigneshvar has joined #openstack-oslo19:20
harlowja_i'll fill in more throughout the next few hours, ha19:21
*** ajo has joined #openstack-oslo19:22
dims__folks, anyone have project ideas or willing to mentor students for the summer? https://wiki.openstack.org/wiki/GSoC201519:25
harlowja_oh, i always have ideas19:26
harlowja_and i like free labor, haha19:26
dims__harlowja_: awesome, please add 'em :)19:26
harlowja_i mean, free students19:26
harlowja_errr, nm, lol19:27
dhellmanndims__: what sorts of projects are you looking for? probably not "add narrative documentation to all libraries"19:27
dims__y, google pays them, they work here19:27
dims__dhellmann: something concrete, achievable19:27
dhellmannI'll have to spend some time thinking about it -- spec planning is like christmas, it comes earlier every season19:28
dims__haha19:28
dhellmanndims__: we will have some code left to graduate, but I'm not sure if that's something I'd trust to a completely new person without a lot of guidance19:30
dhellmannthe stuff that's left is the service code19:30
dims__dhellmann: ack19:30
dhellmannI guess we have some client code, too, that might be doable19:31
dims__dhellmann: we could get them to help with filing reviews to use oslo-* in different projects too19:31
dhellmannthat's a good idea19:31
dhellmannputting the context class in, for example, would take some fiddling and be more than just a few sed lines19:31
dims__y19:32
openstackgerritMichael Bayer proposed openstack/oslo.db: Add process guards + invalidate to the connection pool  https://review.openstack.org/15672519:36
bknudsonis there some docs on how to publish releases to pypi?19:36
dhellmannbknudson: we have some tools, but I don't know that they are documented very well, yet19:37
dhellmannbknudson: looking...19:37
dhellmannbknudson: what are you trying to publish?19:37
bknudsondhellmann: ossg has a tool called "bandit"19:37
bknudsonit's in gerrit.19:38
*** mriedem has quit IRC19:39
dhellmannbknudson: the first thing to do is make sure you have all of the jobs you need set up. I think those are described in http://docs.openstack.org/infra/manual/creators.html19:39
dhellmannbknudson: the mechanics of releasing are to create a git *signed* tag in the repo and push it to gerrit19:40
dhellmannyou need permission to do that, and the group setup is described in the guide ^^19:40
*** mriedem has joined #openstack-oslo19:41
bknudsondid you have a script19:42
dhellmannbknudson: then, if you want to do something like what we do in oslo, you can use the release script in openstack-infra/release-tools. See https://review.openstack.org/#/c/151285/ for the latest version of that19:42
dhellmannthe README in that repo gives a short example of how to use it19:42
*** cdent has quit IRC19:43
dhellmannbknudson: let me know if you get stuck on any of that and I'll try to help you out19:44
bknudsonsweet, thanks19:44
openstackgerritDoug Chivers proposed openstack/oslo.config: Fixes deprecation warning for oslo.config in cfg.py  https://review.openstack.org/15673019:46
*** mriedem has quit IRC19:50
*** mriedem has joined #openstack-oslo19:52
*** jecarey_ has joined #openstack-oslo19:54
*** jecarey has quit IRC19:57
*** noelbk has quit IRC20:05
*** noelbk has joined #openstack-oslo20:07
*** vigneshvar has quit IRC20:10
openstackgerritManish Godara proposed openstack/taskflow: Update Flow::__str__  https://review.openstack.org/15592620:18
*** vigneshvar has joined #openstack-oslo20:29
harlowja_ok jogo zzzeek haypo https://review.openstack.org/#/c/156711/ (some kind of first draft up)20:35
harlowja_or pre-first draft, ha20:35
harlowja_aka some crap i wrote, its up, lol20:35
*** achanda has quit IRC20:36
*** andreykurilin_ has quit IRC20:40
*** andreykurilin_ has joined #openstack-oslo20:40
*** dulek has joined #openstack-oslo20:45
*** jgrimm is now known as zz_jgrimm20:51
openstackgerritDoug Chivers proposed openstack/oslo.config: Fixes deprecation warning for oslo.config in cfg.py  https://review.openstack.org/15673020:53
openstackgerritMichael Bayer proposed openstack/oslo.db: Add process guards + invalidate to the connection pool  https://review.openstack.org/15672520:56
*** zz_jgrimm is now known as jgrimm20:58
himangihey! I wish to start contributing to oslo.. I would appreciate any help!20:59
*** achanda has joined #openstack-oslo21:11
*** achanda has quit IRC21:11
*** achanda has joined #openstack-oslo21:12
*** e0ne has quit IRC21:39
krotscheckI’ve got a question about the Oslo Timestamp mixin :)21:47
krotscheckoslo.db timestamp mixin I mean21:47
krotscheckOne of the things we’ve run into is that the datetimes that come back from that don’t contain a timezone.21:48
krotscheckNow, the default value assumes UTC, however with different databases having different timezone support and different assumptions about how things get stored, is there a good way that the Timestamp mixin can explicitly declare the TZ on the record?21:49
krotscheckWe’ve done something sortof like this in storyboard just now, creating a UTCDateTime data type and our own mixin to replace the one from oslo.db -> One of the things we’ve run into is that21:50
krotscheckArgh21:50
krotscheckI meant https://review.openstack.org/#/c/155083/4/storyboard/db/models.py21:50
krotscheckHowever the question was raised whether this should be in oslo rather that SB proper.21:51
krotscheckAnd I don’t know enough about why timezones were excluded in the first place.21:51
*** zzzeek has quit IRC21:51
krotscheckSo the question: Should the TimestampMixin include a datetime decorator that adds the timezone if it doesn’t exist yet?21:52
openstackgerritSteve Martinelli proposed openstack/oslo-incubator: Remove policy from oslo-incubator  https://review.openstack.org/15281221:53
openstackgerritSteve Martinelli proposed openstack/oslo-incubator: Prevent update.py from updating policy  https://review.openstack.org/15281321:53
*** dulek has quit IRC22:00
*** bknudson has quit IRC22:00
*** achanda has quit IRC22:10
*** salv-orlando has quit IRC22:10
*** crc32 has joined #openstack-oslo22:12
*** salv-orlando has joined #openstack-oslo22:13
stevemardhellmann, wondering what your thoughts are on policy? think it's baked enough?22:17
stevemarnot trying to rush you, i just think it's been close for a while :)22:18
*** crc32 has quit IRC22:18
openstackgerritManish Godara proposed openstack/taskflow: Update Flow::__str__  https://review.openstack.org/15592622:19
dhellmannhimangi: hi! we would be happy to have you contributing. One easy way to start is to review patches already submitted to the oslo projects.22:22
himangidhellmann, that sounds good22:23
dhellmannkrotscheck: there was a similar conversation in here a few days ago between dansmith and inc0 and dates with timezones in versioneobjects22:23
dhellmannhimangi: do you already have gerrit credentials?22:23
himangino22:23
dhellmannstevemar: I'm doing some more cleanup work on the policy tests. I'm not sure it's required before we release, though.22:24
himangiI am a student from India and wish to work with openstack for GSOC this summers..22:24
dhellmannhimangi: look through https://wiki.openstack.org/wiki/How_To_Contribute and follow the instructions for setting yourself as a developer. Let me know if you run into trouble and I'll try to help.22:24
stevemardhellmann, cleanup is good, it can wait another week if you don't like releasing late in the week22:24
himangidhellmann: sure :)22:25
dhellmannstevemar: well, as a first release we can relax that rule since nothing will be using it so nothing will break :-)22:25
stevemarthe only benefit of a first release22:26
krotscheckdhellmann: I don’t have that scrollback unfortunately.22:27
dhellmannkrotscheck: yeah, I don't either :-/22:27
krotscheckdhellmann: Summarize the decision?22:28
*** achanda has joined #openstack-oslo22:29
dhellmannkrotscheck: I really only saw the conversation and thought you might want to talk to them22:30
krotscheckdhellmann: Oh! Ok :)22:30
krotscheckWell, dansmith and inc0 can ping me then :)22:31
*** crc32 has joined #openstack-oslo22:31
*** zzzeek has joined #openstack-oslo22:37
*** SpamapS has joined #openstack-oslo22:38
openstackgerritDoug Hellmann proposed openstack/oslo.policy: Create the temporary files needed for tests  https://review.openstack.org/15681122:44
openstackgerritDoug Hellmann proposed openstack/oslo.policy: Change default set of tox environments  https://review.openstack.org/15681222:44
openstackgerritDoug Hellmann proposed openstack/oslo.policy: Fix i18n imports  https://review.openstack.org/15681322:44
dhellmannstevemar: ^^ none of those are really blockers22:45
*** andreykurilin_ has quit IRC22:45
stevemardhellmann, will review now anyway22:45
stevemarthe i18n one is super easy22:46
openstackgerritJoshua Harlow proposed openstack/taskflow: Mark all current deprecations to get removed before 1.0  https://review.openstack.org/15681622:46
stevemardhellmann, i love the patch to update the tests, delete all those crummy files22:47
*** bknudson has joined #openstack-oslo22:48
dhellmannstevemar: right, continuing the work you started with that symlink22:49
openstackgerritDoug Hellmann proposed openstack/oslo.config: Do not import our namespace package  https://review.openstack.org/15682022:51
dansmithkrotscheck: I prefer that datetimes have the timezones in them, inc0 does not22:58
dansmithkrotscheck: so the plan was for him to add a flag to the datetime field specifying whether it was aware or not22:58
dansmithkrotscheck: I haven't looked to see if that is up for review yet or not22:58
dhellmanndansmith: would that be in versionedobjects or in oslo.db?22:58
krotscheckdansmith: Gotcha. I’ll keep my eyes out, and switch our code out when I get a chance.22:58
dansmithdhellmann: versionedobjects22:58
dhellmanndansmith: ok22:59
openstackgerritMerged openstack/oslo.policy: Use single quotes consistently  https://review.openstack.org/15640423:04
openstackgerritMerged openstack/oslo.policy: Fix minor spelling issues in oslo.policy  https://review.openstack.org/15640523:04
openstackgerritMerged openstack/oslo-specs: Add policy template  https://review.openstack.org/14983523:04
openstackgerritMerged openstack/oslo-specs: Add incubator policy  https://review.openstack.org/14982623:07
openstackgerritMerged openstack/oslo-specs: Add library naming policy  https://review.openstack.org/14983623:07
*** daniel3_ has quit IRC23:08
*** vigneshvar has quit IRC23:09
*** mriedem has quit IRC23:09
openstackgerritMerged openstack-dev/oslo-cookiecutter: Use correct package name for incubator sync  https://review.openstack.org/15222023:09
openstackgerritMerged openstack/oslo-specs: More missing files for versionedobjects  https://review.openstack.org/15222223:10
openstackgerritDoug Hellmann proposed openstack/oslo-incubator: Remove obsolete comments from tool scripts  https://review.openstack.org/15263723:10
openstackgerritDoug Hellmann proposed openstack/oslo-incubator: script to list the latest release of each library  https://review.openstack.org/15233223:10
openstackgerritMerged openstack/oslo-incubator: Move test runner scripts to oslotest repository  https://review.openstack.org/15175423:11
openstackgerritJoshua Harlow proposed openstack/oslo.utils: Add a stopwatch + split for duration(s)  https://review.openstack.org/15431123:12
openstackgerritDoug Hellmann proposed openstack/oslo-specs: Add adoption timeline to incubator policy  https://review.openstack.org/15368223:15
openstackgerritDoug Hellmann proposed openstack/oslo-specs: Add private symbol use policy  https://review.openstack.org/15011823:15
openstackgerritDoug Hellmann proposed openstack/oslo-specs: Add spec approval policy  https://review.openstack.org/15011923:15
openstackgerritDoug Hellmann proposed openstack/oslo-specs: Add versioning policy  https://review.openstack.org/14984223:15
openstackgerritDoug Hellmann proposed openstack/oslo-specs: Add revision history sections  https://review.openstack.org/15261823:15
openstackgerritDoug Hellmann proposed openstack/oslo-specs: add policy describing liaison program  https://review.openstack.org/14983823:15
openstackgerritDoug Hellmann proposed openstack/oslo-incubator: Remove obsolete comments from tool scripts  https://review.openstack.org/15263723:21
openstackgerritDoug Hellmann proposed openstack/oslo-incubator: Update release tool for governance change  https://review.openstack.org/15623823:21
openstackgerritDoug Hellmann proposed openstack/oslo-incubator: script to list the latest release of each library  https://review.openstack.org/15233223:21
*** gordc has quit IRC23:26
openstackgerritDoug Hellmann proposed openstack/oslo.policy: Fix i18n imports  https://review.openstack.org/15681323:27
openstackgerritDoug Hellmann proposed openstack/oslo.policy: Change default set of tox environments  https://review.openstack.org/15681223:28
openstackgerritDoug Hellmann proposed openstack/oslo.policy: Create the temporary files needed for tests  https://review.openstack.org/15681123:28
openstackgerritDoug Hellmann proposed openstack/oslo.policy: Update comments about tox configuration  https://review.openstack.org/15683623:28
openstackgerritEric Brown proposed openstack/oslo.vmware: Add bandit to tox for security static analysis  https://review.openstack.org/15683823:29
*** pradk has quit IRC23:29
*** kgiusti has quit IRC23:30
dhellmannstevemar: I think we're probably ready to go ahead with a policy release tomorrow morning.23:30
openstackgerritJoshua Harlow proposed openstack/taskflow: Tweaks to atom documentation  https://review.openstack.org/15684423:41
openstackgerritMerged openstack/oslo-specs: add policy describing liaison program  https://review.openstack.org/14983823:48
openstackgerritMerged openstack/oslo-specs: Add versioning policy  https://review.openstack.org/14984223:48
openstackgerritMerged openstack/oslo-specs: Add private symbol use policy  https://review.openstack.org/15011823:49
openstackgerritMerged openstack/oslo-specs: Add spec approval policy  https://review.openstack.org/15011923:49
openstackgerritJoshua Harlow proposed openstack/taskflow: Tweaks to atom documentation  https://review.openstack.org/15684423:52
stevemardhellmann, oh, why the change of mind?23:52
kragnizwhat happened to jsonutils?23:55
kragnizI can't see it in oslo.utils23:55
kragnizdid it just get removed?23:55
harlowja_probably got moved to oslo_utils?23:56
harlowja_or oslo.serialization23:56
harlowja_^ ya that23:56
harlowja_https://github.com/openstack/oslo.serialization/tree/master/oslo_serialization23:56
kragnizaha!23:56
kragnizthanks harlowja_!23:56
harlowja_np23:56
harlowja_although i would consider using the msgpack there if u are starting a new project23:57
harlowja_the msgpack stuff isn't as lossy with types...23:57
kragnizporting barbican over to use the graduated modules23:57
harlowja_k23:57
kragnizI guess it would be better to just keep things as similar as possible :P23:58
harlowja_up to u23:58
kragnizI'll keep it the same23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!