Wednesday, 2015-02-11

*** dims__ has joined #openstack-oslo00:07
*** crc32 has quit IRC00:23
harlowjajogo getting closer i think for https://github.com/harlowja/pippin (simple run @ http://paste.ubuntu.com/10165874/ ) it has the deep dependency graph, and is using some of taskflow's tree code to find paths through that tree (and hopefully just now need to find a valid path among those paths)00:31
*** dims__ has quit IRC00:31
jogoharlowja: neat, how long does that take to run? and can you run it against global-reqs?00:49
harlowjajogo running right now, lol00:49
jogoharlowja: sweet00:49
harlowjait is doing a deep download/open... repeat, so my guess not so quick, but it caches all the things it can00:49
harlowjabut i'll time it00:49
jogoharlowja: can you make it use standard pip.conf settings like specifying the URL00:50
harlowjaprobably00:50
jogoso I can use devpi-server locally etc.00:50
harlowjaya, shouldn't be a problem i think00:50
*** dims__ has joined #openstack-oslo00:53
*** dims_ has joined #openstack-oslo00:54
*** dims__ has quit IRC00:58
*** achanda_ has joined #openstack-oslo01:16
*** tsekiyam_ has joined #openstack-oslo01:17
*** achanda has quit IRC01:19
*** mtanino has quit IRC01:20
*** tsekiyama has quit IRC01:20
*** achanda_ has quit IRC01:21
*** tsekiyam_ has quit IRC01:21
*** noelbk has quit IRC01:21
*** hemna is now known as hemnafk01:22
*** daniel3_ has quit IRC01:24
*** david-lyle has quit IRC01:26
*** sigmavirus24 is now known as sigmavirus24_awa01:47
*** sigmavirus24_awa is now known as sigmavirus2401:51
*** david-lyle has joined #openstack-oslo02:08
*** shardy has quit IRC02:14
*** tedross has joined #openstack-oslo02:29
openstackgerritIan Wienand proposed openstack/oslo.policy: Turn off missing-directory log output for default case  https://review.openstack.org/15474202:40
*** yamahata has quit IRC02:45
*** sigmavirus24 is now known as sigmavirus24_awa02:46
*** david-lyle has quit IRC02:46
*** harlowja is now known as harlowja_away02:46
*** david-lyle has joined #openstack-oslo02:50
*** pradk has quit IRC03:10
*** david-lyle has quit IRC03:31
*** rushiagr_away is now known as rushiagr03:39
*** achanda has joined #openstack-oslo03:40
*** _amrith_ is now known as amrith03:47
*** tedross has quit IRC03:50
*** dims_ has quit IRC04:01
*** rushiagr is now known as rushiagr_away04:04
*** ViswaV has quit IRC04:07
*** david-lyle has joined #openstack-oslo04:09
*** ViswaV has joined #openstack-oslo04:09
openstackgerritSteve Martinelli proposed openstack/oslo.policy: Use standard logging in oslo.policy  https://review.openstack.org/15463504:11
*** achanda has quit IRC04:13
openstackgerritSteve Martinelli proposed openstack/oslo.policy: document the migration process and update the docs a bit  https://review.openstack.org/15475204:50
*** rushiagr_away is now known as rushiagr04:52
*** amrith is now known as _amrith_04:56
*** zzzeek has quit IRC04:59
*** dims__ has joined #openstack-oslo05:02
*** dims__ has quit IRC05:07
*** achanda has joined #openstack-oslo05:23
openstackgerritMin Pae proposed openstack/taskflow: Map optional arguments as well as required arguments  https://review.openstack.org/15197205:27
*** achanda has quit IRC05:39
*** achanda has joined #openstack-oslo05:40
*** achanda has quit IRC05:56
*** MasterPiece has joined #openstack-oslo06:05
*** MasterPiece| has joined #openstack-oslo06:16
*** MasterPiece has quit IRC06:17
*** noelbk has joined #openstack-oslo06:21
*** inc0 has joined #openstack-oslo06:23
openstackgerritMin Pae proposed openstack/taskflow: Map optional arguments as well as required arguments  https://review.openstack.org/15197206:32
openstackgerritMin Pae proposed openstack/oslo.utils: Add a "optional" argument to reflection.get_callable_args  https://review.openstack.org/15235706:35
openstackgerritMerged openstack/debtcollector: Add universal wheel tag to setup.cfg  https://review.openstack.org/15341406:42
*** achanda has joined #openstack-oslo06:43
*** sirushti has left #openstack-oslo06:52
openstackgerritJoshua Harlow proposed openstack/taskflow: Let the multi-lock convert the provided value to a tuple  https://review.openstack.org/15477006:57
*** vigneshvar has joined #openstack-oslo07:01
openstackgerritJoshua Harlow proposed openstack/oslo.utils: Add a stopwatch + split for duration(s)  https://review.openstack.org/15431107:01
openstackgerritVilobh Meshram proposed openstack/taskflow: Docstrings should document parameters return values  https://review.openstack.org/15237507:03
*** achanda has quit IRC07:16
openstackgerritMin Pae proposed openstack/oslo.utils: Add a "optional" argument to reflection.get_callable_args  https://review.openstack.org/15235707:19
*** achanda has joined #openstack-oslo07:29
*** shardy has joined #openstack-oslo07:58
*** dtantsur|afk is now known as dtantsur07:59
*** e0ne has joined #openstack-oslo08:10
*** alexpilotti has quit IRC08:24
*** dulek has joined #openstack-oslo08:27
*** achanda has quit IRC08:36
*** achanda has joined #openstack-oslo08:36
*** noelbk has quit IRC08:37
*** achanda has quit IRC08:37
*** andreykurilin_ has joined #openstack-oslo08:37
*** ajo has joined #openstack-oslo08:39
openstackgerritMerged openstack/taskflow: Map optional arguments as well as required arguments  https://review.openstack.org/15197208:39
*** e0ne has quit IRC08:50
*** andreykurilin_ has quit IRC08:53
*** andreykurilin_ has joined #openstack-oslo08:53
*** andreykurilin_ has quit IRC08:54
*** andreykurilin_ has joined #openstack-oslo08:55
*** ihrachyshka has joined #openstack-oslo08:58
*** vigneshvar has quit IRC09:07
*** vigneshvar has joined #openstack-oslo09:12
*** ihrachyshka has quit IRC09:15
openstackgerritMichal Jastrzebski (inc0) proposed openstack/oslo.versionedobjects: Remove references to Nova  https://review.openstack.org/15440109:29
*** achanda has joined #openstack-oslo09:38
*** achanda has quit IRC09:43
*** e0ne has joined #openstack-oslo09:45
*** stevemar has quit IRC09:47
*** viktors has left #openstack-oslo09:52
*** pblaho has joined #openstack-oslo09:56
*** dtantsur is now known as dtantsur|bbl09:56
openstackgerritGrzegorz Grasza proposed openstack/oslo.versionedobjects: Compatibility with Python 3  https://review.openstack.org/15440710:07
openstackgerritMerged openstack/oslo.db: Updated from global requirements  https://review.openstack.org/15050210:08
*** alexpilotti has joined #openstack-oslo10:22
inc0guys, what should I use? from oslo import messaging or import oslo_messaging?10:24
*** MasterPiece| has quit IRC10:34
openstackgerritGrzegorz Grasza proposed openstack/oslo.versionedobjects: Compatibility with Python 3  https://review.openstack.org/15440710:34
openstackgerritGrzegorz Grasza proposed openstack/oslo.versionedobjects: Compatibility with Python 3  https://review.openstack.org/15440710:36
ozamiatininc0, hi, if you would like to use the public api: get_rpc_server, get_notification_listener etc... you should 'from oslo import messaging'. oslo_messaging is for internal entities like drivers etc, you shouldn't import it from the outside10:37
haypoinc0: import oslo_messaging10:37
*** dims__ has joined #openstack-oslo10:37
haypoinc0: "oslo" namespace will slowly disappear10:37
haypoinc0: make sure that you have at least oslo.messaging>=1.2.0 in your requirements10:37
inc0haypo, thanks for clarification10:38
ozamiatinhaypo, thanks too, seems I didn't get it right...10:38
inc0thanka for clarification guys10:39
inc0thanks10:39
haypoozamiatin: are you Grzegorz Grasza ?10:39
haypoof the versionedobjects review?10:40
ozamiatinhaypo, no I'm Oleksii Zamiatin :)10:40
haypooh ok :) sorry10:40
ozamiatinhaypo, np )10:40
haypoozamiatin: i know, it's hard to follow recent changes in oslo10:40
inc0haypo, xek is Grzegorz10:43
inc0haypo, but I'm very much involved as well:)10:44
*** ihrachyshka has joined #openstack-oslo10:44
haypoxek: hey. for python3, you may take a look at https://wiki.openstack.org/wiki/Python3 thanks for helping to port openstack to python 3 ;)10:44
*** i159 has joined #openstack-oslo10:45
openstackgerritMichal Jastrzebski (inc0) proposed openstack/oslo.versionedobjects: New field type - Json  https://review.openstack.org/15482010:45
inc0speaking of which...10:46
*** e0ne is now known as e0ne_10:46
*** e0ne_ is now known as e0ne10:47
haypoinc0: i don't understand what is this coerce() method :-/10:48
haypoinc0: but i don't know oslo.versionedobjects at all :-p10:48
inc0haypo, its part of idea that versionedobject should be serializable10:49
inc0so you can transport it via RPC10:49
inc0and then we have typed field, like these: https://review.openstack.org/#/c/146841/11/heat/objects/stack.py10:50
inc0coerce is method which turns serialized thing to unserialized10:51
inc0haypo, and I don't blame you about not knowing it, gerrit appeared in Monday;)10:52
openstackgerritGrzegorz Grasza proposed openstack/oslo.versionedobjects: Rename utils -> _utils  https://review.openstack.org/15440910:52
xekhaypo, thanks, I will look into it10:55
*** alexpilotti has quit IRC11:00
*** dtantsur|bbl is now known as dtantsur11:01
openstackgerritMichal Jastrzebski (inc0) proposed openstack/oslo.versionedobjects: Remove references to Nova  https://review.openstack.org/15440111:03
*** e0ne_ has joined #openstack-oslo11:09
*** i159 has quit IRC11:10
*** e0ne has quit IRC11:10
*** i159 has joined #openstack-oslo11:10
*** f13o has quit IRC11:19
openstackgerritMichal Jastrzebski (inc0) proposed openstack/oslo.versionedobjects: New field type - Json  https://review.openstack.org/15482011:29
inc0is Victor Stinner here?:)11:39
*** achanda has joined #openstack-oslo11:40
*** f13o has joined #openstack-oslo11:43
*** achanda has quit IRC11:45
*** cdent has joined #openstack-oslo11:48
*** boris-42 has quit IRC11:52
*** ankit_ag has joined #openstack-oslo11:52
openstackgerritMichal Jastrzebski (inc0) proposed openstack/oslo.versionedobjects: Fixes for heat implementation  https://review.openstack.org/15483511:53
openstackgerritMichal Jastrzebski (inc0) proposed openstack/oslo.versionedobjects: Fixes for heat implementation  https://review.openstack.org/15483511:53
*** _amrith_ is now known as amrith12:04
openstackgerritAlexander Makarov proposed openstack/oslo-specs: oslo logging needs a way to be reconfigured  https://review.openstack.org/15483812:14
*** boris-42 has joined #openstack-oslo12:28
*** pblaho_ has joined #openstack-oslo12:29
*** pblaho has quit IRC12:29
haypoinc0: i'm victor stinner12:30
inc0ahh, good to know;)12:33
inc0I've replied to your comments in review, thanks12:33
haypoinc0: ok, i will see that later12:33
inc0basically versionedobjects is pulled straight out of nova12:33
inc0hence all this nova-reference removals12:34
inc0we've pulled out whole thing including all its flaws, like hardcoded stuff:)12:34
haypoyes, i understood that (that it comes from nova)12:34
haypoinc0: it is possible to implement new fields in applications using versionedobjects ?12:35
inc0yes12:35
inc0all you need to do is to inherit from base classes12:35
inc0so nova, neutron and so on will be able to implement their own field types, I think thats reasonable12:36
inc0I'd hate to see patchset for review made by Cinder guys with something like "ISCSITargetField" ;) I wouldn't even know how to review it;)12:37
*** pblaho_ is now known as pblaho12:37
dims__go flaper87 go!12:50
*** pblaho_ has joined #openstack-oslo12:51
*** pblaho has quit IRC12:51
*** rushiagr is now known as rushiagr_away12:59
*** akhivin has quit IRC13:00
*** mkoderer_cloud has joined #openstack-oslo13:03
*** khivin has joined #openstack-oslo13:06
*** vipul has quit IRC13:08
openstackgerritMehdi Abaakouk proposed openstack/oslo.messaging: Skip functional tests that fail due to a qpidd bug  https://review.openstack.org/15463813:10
openstackgerritMehdi Abaakouk proposed openstack/oslo.messaging: amqp1: fix functional tests deps  https://review.openstack.org/15375413:10
*** vipul has joined #openstack-oslo13:11
*** pblaho_ is now known as pblaho13:14
*** tedross has joined #openstack-oslo13:15
openstackgerritMichal Jastrzebski (inc0) proposed openstack/oslo.versionedobjects: Fixes for heat implementation  https://review.openstack.org/15483513:18
*** inc0 has quit IRC13:18
*** dims__ has quit IRC13:19
*** tedross has left #openstack-oslo13:19
*** dims__ has joined #openstack-oslo13:20
openstackgerritMehdi Abaakouk proposed openstack/oslo.messaging: amqp1: fix functional tests deps  https://review.openstack.org/15375413:25
*** e0ne_ has quit IRC13:40
*** amrith is now known as _amrith_13:41
*** kgiusti has joined #openstack-oslo13:44
*** e0ne has joined #openstack-oslo13:45
openstackgerritMehdi Abaakouk proposed openstack/oslo.messaging: amqp1: fix functional tests deps  https://review.openstack.org/15375413:46
*** vigneshvar has quit IRC13:48
*** bknudson has joined #openstack-oslo13:49
*** jaosorior has joined #openstack-oslo13:50
openstackgerritGrzegorz Grasza proposed openstack/oslo.versionedobjects: Compatibility with Python 3  https://review.openstack.org/15440713:56
openstackgerritGrzegorz Grasza proposed openstack/oslo.versionedobjects: Compatibility with Python 3  https://review.openstack.org/15440713:56
openstackgerritGrzegorz Grasza proposed openstack/oslo.versionedobjects: Rename utils -> _utils  https://review.openstack.org/15440913:58
*** inc0 has joined #openstack-oslo13:59
*** mriedem has joined #openstack-oslo14:29
*** zzzeek has joined #openstack-oslo14:34
*** gordc has joined #openstack-oslo14:36
*** mtanino has joined #openstack-oslo14:49
*** sigmavirus24_awa is now known as sigmavirus2414:55
openstackgerritMerged openstack/oslo.messaging: Skip functional tests that fail due to a qpidd bug  https://review.openstack.org/15463814:57
*** jecarey has joined #openstack-oslo15:11
*** e0ne is now known as e0ne_15:12
inc0dansmith, hi, I'm thinking about this ip address fields in oslo15:15
dansmithinc0: hi15:15
inc0I'm not convinced I did good removing it, but it still seems a bit too domain-specific15:15
inc0most of projects will not use this kind of fields15:16
dansmithwhich projects don't deal with ip addresses?15:17
inc0cinder, heat15:17
inc0not on object level15:17
dansmithyou mean they don't currently persist any plain IP addresses, I assume, but they do deal with network addresses in many forms and could at some point decide to persist an IP, right?15:18
inc0sure, but if we want to add normal ipv4 address, we may as well add subnet, then ipv6 and so on and so on15:19
inc0we'll end up having ton of fields around network15:19
inc0it might be good idea to just separate it to another file...like network-related fields15:19
dansmiththe reason to have them there, IMHO, is to offer an easier alternative than the other projects just using a string for those things because "it's harder to build a proper field"15:19
dansmithinc0: if you think separating them is important, then sure :)15:20
*** prad has joined #openstack-oslo15:20
inc0yeah, but as I understand idea of a field, its closer to raw data structure than complex one15:20
dansmithit's really just to codify a specific type of data15:20
dansmithand there are more complicated ones than IPAddress15:20
inc0yeah, another topic I wanted to move;)15:21
dansmiththe address one does a lot of validation and canonicalization, especially in the case of ipv615:21
inc0whats point of "list of dicts field" and so on?15:21
inc0that doesn't seem right...15:21
dansmithone of the reasons we added the address one is because mysql stores it as a string and does no checking, postgres does checking, and our API was depending on the database to validate (!)15:21
dansmiththe list-of-dicts (et al) are mostly because we haven't been able to force people to properly model all their data all in one go15:22
dansmithso I'm happy to have those stay in nova if you want15:22
inc0wouldn't be better to do something like string_field(validator=ipaddress_calidator)15:22
dansmithwe have things like lists of cpu maps and such that fit into those15:22
*** e0ne_ has quit IRC15:22
inc0I was thinking of jsonfield...15:23
inc0I had to implement it for heat (we store templates as deeply nested json..impossible to cast to "list of whatever")15:23
dansmithit just seems cleaner to me to define the field in terms of what it is, and not in terms of the primitive type plus a validator15:23
inc0de gustibus non est disputandum15:25
inc0 :)15:25
dansmithtranslation please :)15:25
inc0There’s no arguing about tastes and colors.15:25
dansmithhah15:25
inc0its from latin15:26
inc0I just want to agree on one standard now, before anyone actually implement it;)15:26
inc0because then we might not have that chance15:26
inc0;)15:26
*** andreykurilin_ has quit IRC15:26
inc0and what do you think about jsonfield replacing list-of-whatever-field?15:27
openstackgerritMerged openstack/oslo.messaging: Add missing unit test for a recent commit  https://review.openstack.org/15312215:28
dansmithinc0: we specifically don't want a jsonfield in nova15:29
inc0ow? and why is that?15:30
dansmithinc0: it is the definition of what we were trying to replace with this whole infrastructure15:30
dansmithinc0: it's unversioned, and that's the problem15:30
*** e0ne has joined #openstack-oslo15:30
dansmithinc0: before this, we were passing unversioned dicts (jsonified) all over RPC. The point of this is to define a schema attached to a version, and thus it should be a set of well-defined data types15:30
dansmithso I'm definitely -2 on putting that in here, but heat can do what they want of course :)15:31
inc0well, we can't really dodge that bullet I think, I'll try to think of way around that15:32
inc0dansmith, nova doesn't use sqlalchemy's jsonfield?15:35
dansmithno15:35
dansmithwe store json in the database, but we're moving to using the serialized (and thus versioned) form of these objects everywhere we do15:35
inc0but what about objects without strictly defined schema?15:36
dansmithso that when we pull json out of the database, we know what version it was stored in, and we can apply the same semantics to reading it as we do to receiving an older object over rpc15:36
inc0like heat template - it can be nested indefinetly and so on?15:36
dansmithinc0: we don't have anything like that, AFAIK15:36
dansmithinc0: the closes thing we have is metadata, and it's strictly key=value, 255 chars each15:37
*** e0ne is now known as e0ne_15:37
*** e0ne_ is now known as e0ne15:37
inc0well, then I'd ask you to remove -2 on this idea, because there are cases like that15:38
openstackgerritMehdi Abaakouk proposed openstack/tooz: file: Fix multiple call of get_lock  https://review.openstack.org/15491315:38
inc0heat is an example15:39
*** amotoki has joined #openstack-oslo15:40
*** yamahata has joined #openstack-oslo15:40
dansmithinc0: right, so heat can define their own such field, right?15:40
dansmithinc0: my point is, it goes contrary to the whole goal of this, so it seems extremely problematic to build in such functionality to the base library object15:41
inc0well, sure we can do that in heat, but I bet there are other cases like that15:42
dansmithwell, I'd argue we should start without it, and see how many cases pop up15:43
dansmithheat seems to be the only one I can think of,15:43
dansmithwhere you do have arbitrary complexity in a structure.. can't see what in cinder would be similar15:43
inc0taskflow?15:44
dansmithI don't know enough about it to say15:45
dansmithso let me ask you this:15:45
*** _gryf has joined #openstack-oslo15:46
dansmithif you  have half your deployment running old code and half running new code, how do you handle passing this unversioned structure from one to the other and handling potential changes in what those components expect?15:46
dansmithI don't know if taskflow has such a potential.. heat either for that matter, although I expect it does15:46
dims__inc0: does not look like harlowja_away needs it in taskflow (http://docs.openstack.org/developer/taskflow/persistence.html)15:46
dansmithpersistence is the other side, where you've stuffed something in the db, to be read by a later version of the code at some undetermined point in the future15:47
inc0well, what I'm saying is, people will use stringfield to do it15:48
inc0so exactly what you wanted to avoid by putting ipv4 field out there15:48
dansmithbut ipv4 is a well-defined thing15:49
dansmith"random complexity json" is not15:49
dansmithunless you have some weird five-byte IPv4 addresses that we don't :P15:49
inc0I know, but still do we really want close this road because people might use it wrong?15:49
*** hemnafk is now known as hemna15:50
inc0I know, we can make our own jsonfield, we can even use stringfield...its just seem wrong15:50
dansmithwe're not closing the road if we don't add it now, we are opening the road forever if we do, right?15:50
inc0what about jsonschema or something like that?15:51
dansmith...more words15:51
*** _amrith_ is now known as amrith15:52
*** denis_makogon has joined #openstack-oslo15:52
dansmithinc0: sorry, I meant: can you describe more of what you mean by "jsonschema or something like that" ?15:55
inc0well, its something that allow us to put some arbitrary schema for json15:55
inc0its more flexible than what we have now, and might just be common ground15:56
inc0because we can use it for some version compatibility logic15:56
dansmithif you define a field in terms of jsonschema,15:56
dansmithand then you have version 1.0 which pertains to some specific schema of that json field,15:57
inc0well, then you can schema per field, which is reasonable15:57
dansmithand then you want to change the schema and bump to 1.1,15:57
dansmithwhat happens if you receive an object of version 1.0? and what happens if you need to send a 1.1 object to something that only knows 1.0?15:57
inc0then you'll have to add make_obj_compatible logic to turn one into another15:57
inc0this is the case of anything really15:58
inc0unless its just "string or none"15:58
*** harlowja_at_home has joined #openstack-oslo15:58
*** yamahata has quit IRC15:58
dansmithit is, but my argument here is: we've been getting it wrong for a long time, despite best intentions15:59
*** yamahata has joined #openstack-oslo15:59
dansmithit's much easier to define "version 1.3 gained a string field that is just a name of a widget. In order to send to 1.2, remove that field"15:59
inc0dansmith, I'm not saying that we should replace whole thing with jsonschema, I'm just saying that if you consider ListOfSetsOfIntegersField you still can end up with function that has to add None to this at some point16:00
inc0or floatr16:01
inc0and you have exactly the same problem16:01
dansmithI understand what you're saying, I just don't agree :)16:01
*** arek has joined #openstack-oslo16:02
inc0what you really did by adding class like that, is specyfing schema of something16:02
*** arek has quit IRC16:02
*** rushiagr_away is now known as rushiagr16:03
inc0but still it doesn't have any migrations and anything16:03
*** arek_ch has joined #openstack-oslo16:03
*** prad has quit IRC16:03
inc0and you can still have exactly the same problem you've described earlier16:03
dansmithyou really don't. It's not a list of sets of strings, it's a list of sets of integers16:03
dansmithit can't change, it's a known format16:04
dansmithit can't include a key, inside of which could be arbitrary complexity of other stuff16:04
inc0yeah, but what if between versions it will have to change?16:04
inc0you'll end up with problem where you'll have to translate v1.1 to v1.016:05
inc0and mutually incompatible formats16:05
dansmithperhaps this is unspoken and needs to be written, but we don't change formats of fields for this specific reason16:05
dansmithyou can't turn Foo.cpus from a string to a list-of-sets-of-integers and then to a dict16:06
dansmithbecause that breaks everything16:06
inc0but what if we could at some point add 0.5 of cpu to vm? it might not break anything as this value is just passed by to libvirt, but it will break on versioning16:07
inc0thing is, predicting is hard, especially the future...16:08
dansmiththat spans two domains, the modeling and the "business logic" I think16:08
inc0and its harder to make translation rules between several field than to one better defined and more flexible16:08
inc0it does, but still it might require hacks, or migrations16:09
dansmithI dunno what to say16:09
inc0well, I'll do patchset, we'll have prototype to discuss16:10
inc0how about that?16:10
*** andreykurilin_ has joined #openstack-oslo16:10
dansmithI guess16:10
inc0ok, by this positive accent I conclude this day:) cya later dansmith16:12
inc0and rest16:12
dansmithinc0: see ya :)16:13
*** andreykurilin_ has quit IRC16:19
*** andreykurilin_ has joined #openstack-oslo16:20
*** MasterPiece has joined #openstack-oslo16:23
openstackgerritMehdi Abaakouk proposed openstack/oslo.messaging: amqp1: fix functional tests deps  https://review.openstack.org/15375416:25
*** stevemar has joined #openstack-oslo16:26
*** tsekiyama has joined #openstack-oslo16:27
*** harlowja_at_home has quit IRC16:27
*** ihrachyshka has quit IRC16:35
*** saikrishna has joined #openstack-oslo16:35
*** denis_makogon has quit IRC16:36
*** MasterPiece has quit IRC16:40
*** MasterPiece has joined #openstack-oslo16:40
*** ankit_ag has quit IRC16:49
*** MasterPiece has quit IRC16:55
*** daniel3_ has joined #openstack-oslo16:56
*** MasterPiece has joined #openstack-oslo17:03
*** MasterPiece has quit IRC17:07
*** MasterPiece has joined #openstack-oslo17:08
*** e0ne is now known as e0ne_17:09
*** dulek has quit IRC17:09
*** e0ne_ is now known as e0ne17:11
*** noelbk has joined #openstack-oslo17:21
*** andreykurilin_ has quit IRC17:21
openstackgerritSteve Martinelli proposed openstack/oslo.policy: document the migration process and update the docs a bit  https://review.openstack.org/15475217:23
*** alexpilotti has joined #openstack-oslo17:25
*** dtantsur is now known as dtantsur|afk17:28
*** i159 has quit IRC17:33
*** arek_ch has quit IRC17:33
openstackgerritDan Smith proposed openstack/oslo.versionedobjects: Rename tests/fixtures to test/obj_fixtures to avoid import collisions  https://review.openstack.org/15497117:39
openstackgerritDan Smith proposed openstack/oslo.versionedobjects: Replace metaclass-based registry with a decorator-based one  https://review.openstack.org/15497217:39
*** MasterPiece has quit IRC17:45
dhellmannbnemec: what's your take on the subprocess monkeypatching change? https://review.openstack.org/#/c/153216/317:45
openstackgerritSteve Martinelli proposed openstack/oslo.utils: Add fileutils to oslo_utils  https://review.openstack.org/15497517:45
bnemecdhellmann: I still think it's enabling bad behavior in consuming applications.17:47
*** harlowja_away is now known as harlowja17:47
bnemecAnd I think neutron is working on a patch to monkey patch earlier so it isn't necessary.17:47
dhellmannbnemec: ok, I'll let you -2 it then17:48
harlowjadims__ what u say about taskflow, lol17:48
dhellmannbnemec: I agree that the apps should be setting up the monkeypatching themselves, although I wonder if we can make it easier to get right? is that just a documentation issue, or can we code something?17:48
harlowja* dims__ inc0 (me just trying to figure out what was mentioned, ha)17:50
bnemecdhellmann: I dunno, I did consider an oslo.eventlet library or something, but I think it's mostly a documentation issue.17:50
bnemecdhellmann: Basically the eventlet best practices spec is my attempt to resolve this once and for all.17:50
bnemecWe'll see how that goes. :-)17:50
dhellmannbnemec: does an app developer need to know which modules oslo libs need patched? or are we expecting them to patch everything?17:50
bnemecdhellmann: So that's an interesting question.  harlowja has found that if, for example, you don't patch the thread module you can get random hangs no matter what we do.17:52
*** yamahata has quit IRC17:52
bnemecMy preference would be patch everything or nothing.  Accept eventlet into your heart, as harlowja put it. ;-)17:52
harlowja*when u pull in libraries from pypi u don't know the patterns they are doing inside that library (and really won't ever know)17:52
bnemecBut I know that's not what we're doing today, so I think discussion is going to be needed.17:52
harlowjaand if they are doing certain patterns they can potentially hang :-/17:52
* dhellmann is so tired of talking about eventlet17:53
harlowjabnemec amen, lol17:53
bnemecYeah, the whole monkey patching thing is one of those ideas that was too clever by half.17:53
dhellmannok, I think you're both right that this isn't a patch we want, and maybe the spec bnemec is writing will help17:53
*** MasterPiece has joined #openstack-oslo17:53
*** MasterPiece| has joined #openstack-oslo17:54
harlowjaaccept it into your heart!17:55
harlowjalol17:55
*** achanda has joined #openstack-oslo17:55
*** MasterPiece has quit IRC17:58
*** vigneshvar has joined #openstack-oslo18:02
dims__harlowja: that the persistence was not complicated18:03
harlowjadims__ depends on who u ask, everything is complicated to someone :-P18:03
harlowjabut ya, i tried to not make it that complicated, ha18:04
harlowjaif u have the ability to integrate running things with persistence (then i think its less complicated) but if u try to layer it in later (then i think it gets more complicated)18:04
harlowjataskflow does the first path (not the second)18:04
harlowja^ if that made any sense :-P18:05
dims__harlowja: y trying to understand. the other thing they were talking about was nested versionedobjects and if taskflow needed it (heat templates are nested)18:12
dansmithdims__: not really nested versionedobjects, but versioned objects with fields that contain unversionable arbitrary complexity blobs of stuff :)18:13
dansmithI don't expect taskflow needs to do that, but I don't know18:13
harlowjai could see it being useful for stuff that taskflow persists (aka when people return things from tasks, they get persisted, so if people returned versionedobjects then peoples upgrade path when they resume/upgrade stuff could be nicer)18:13
dansmithnested objects is a thing we already do18:14
dims__right18:15
harlowjai'll use it if i can (pretty please make versionedobjects pretty generic, ha)18:16
harlowja*and pretty18:17
harlowjalol18:17
*** saikrishna has quit IRC18:26
openstackgerritMerged openstack/debtcollector: Add doctested examples into the documentation  https://review.openstack.org/15375218:28
*** yamahata has joined #openstack-oslo18:28
*** rushiagr is now known as rushiagr_away18:29
*** david-lyle is now known as david-lyle_afk18:31
harlowjaok, mtreinish lets get out a release for debtcollector18:37
mtreinishharlowja: cool18:38
*** jaosorior has quit IRC18:41
harlowjamtreinish https://pypi.python.org/pypi/debtcollector/0.2.0 ok dokie18:44
harlowjaguess requirements repo will need adjustment if u want to use it18:44
gordcis there suppose to be an oslo.cache lib somewhere or is google lying to me?18:44
harlowjaonly yahoo doesn't lie to u18:45
harlowjalol18:45
gordc:) /me goes to yahoo18:45
harlowjahaha18:46
gordchmm.. didn't realise bing still powered yahoo.18:47
*** e0ne has quit IRC18:47
harlowjafor a little while longer i thinkk18:47
gordcah i see. time for me to go to bing and look at pretty moving pictures.18:48
*** mkoderer_cloud has quit IRC18:48
harlowjajogo fyi, that debtcollector release is new this cycle (so shouldn't block your work/cause problems)18:51
mtreinishharlowja: well you can use it now (well once the mirror syncs) you only need to bump in g-r if a project starts having a hard req on 0.2.018:55
harlowjamtreinish isn't that what u wanted to do (use it but needed 0.20) :-P18:55
harlowjaso seems like a hard req no?18:55
mtreinishharlowja: heh, yeah. I was just saying18:56
harlowjaah, k18:56
harlowjaya, agreed18:56
mtreinishI'll let jogo handle that because it's his patch...18:56
*** crc32 has joined #openstack-oslo18:59
harlowjak18:59
* harlowja nearly forgot who's patch it was, ha18:59
*** MasterPiece| has quit IRC19:00
*** ViswaV has quit IRC19:01
*** ViswaV has joined #openstack-oslo19:02
* jogo is happy to let mtreinish handle it if he wants19:03
jogoharlowja: just -1 my patch with a link to what I should do19:03
*** noelbk has quit IRC19:04
harlowjak19:04
*** MasterPiece| has joined #openstack-oslo19:04
*** amotoki has quit IRC19:04
*** alexpilotti has quit IRC19:10
*** amotoki has joined #openstack-oslo19:12
*** noelbk has joined #openstack-oslo19:17
dhellmanngordc: you might be thinking of http://specs.openstack.org/openstack/oslo-specs/specs/kilo/oslo-cache-using-dogpile.html, which we haven't started on yet19:19
*** inc0 has quit IRC19:21
*** ViswaV has quit IRC19:21
*** ViswaV has joined #openstack-oslo19:26
*** achanda has quit IRC19:27
*** boris-42 has quit IRC19:32
*** noelbk has quit IRC19:32
*** achanda has joined #openstack-oslo19:42
*** noelbk has joined #openstack-oslo19:48
*** david-lyle_afk is now known as david-lyle19:51
*** BrianShang has quit IRC19:57
*** cdent has quit IRC19:57
*** prad has joined #openstack-oslo20:05
*** crc32 has quit IRC20:06
*** amrith is now known as _amrith_20:07
*** crc32 has joined #openstack-oslo20:10
dansmithdims__: https://review.openstack.org/#/c/154971/120:11
dansmithdims__: that fixes a problem with import ambiguity20:11
*** _gryf has quit IRC20:11
dansmithdims__: also interested in feedback on the patch on top of that, which is one of the work items20:12
*** e0ne has joined #openstack-oslo20:12
dims__dansmith: we seem to be following a pattern in naming the fixture - http://paste.openstack.org/show/171567/ am ok with leaving the name what you have, but just checking20:16
gordcdhellmann: i see... so i guess if i did want some sort of cache i should use the one sitting in oslo-incubator... or an external lib20:16
dims__dansmith: looking at the other one20:18
dansmithdims__: I normally don't name things test_foo unless it's testing foo, but that's fine, don't much care20:19
dims__good point20:20
*** ihrachyshka has joined #openstack-oslo20:26
*** ViswaV has quit IRC20:28
*** fnordahl has quit IRC20:32
*** fnordahl has joined #openstack-oslo20:32
*** sigmavirus24 is now known as sigmavirus24_awa20:33
*** crc32 has quit IRC20:34
*** amotoki has quit IRC20:34
*** achanda has quit IRC20:36
*** sigmavirus24_awa is now known as sigmavirus2420:36
dims__dansmith: if one of the other projects define their own class extending base.NovaObject, is there something in the test harness they can use (other than fixtures)20:37
openstackgerritMerged openstack/oslo.policy: Use standard logging in oslo.policy  https://review.openstack.org/15463520:37
dansmithdims__: meaning, to reuse some of the test infrastructure that is here?20:37
openstackgerritJoshua Harlow proposed openstack/oslo.serialization: Avoid using strtime for serializing datetimes  https://review.openstack.org/15454720:38
dims__dansmith: y (like we use _VirtDriverTestCase for various drivers)20:38
dansmithdims__: yeah, I was thinking about that when doing the registry patch.. the versions test is really not even relevant for the library, but is something that other projects will want to have to check their objects like we do in nova20:39
dansmithdims__: so I'm not sure what the prior art is there, I'll have to think on it a bit20:39
dims__thanks dansmith20:39
dhellmanngordc: use dogpile20:41
dhellmanngordc: the oslo lib was just going to be a bunch of configuration options for it, so we can extract whatever you come up with to start that lib20:41
dhellmannmorganfainberg: ^^20:42
morganfainbergdhellmann: ++20:42
morganfainberggordc: what dhellmann said. And it was going to be used to be able to replicate what is in keystone caching.20:43
morganfainbergElsewhere (but also better) and replace the keystone caching with something a bit more standard across the projects.20:43
gordccool cool. sounds like a plan.20:44
gordcwill work with dogpile for now.20:45
openstackgerritMerged openstack/oslo-incubator: Update policy.py status in MAINTAINERS  https://review.openstack.org/15456520:45
morganfainberggordc: zzzeek is the maintainer of dogpile. So we have expertise in house :)20:47
openstackgerritDan Smith proposed openstack/oslo.versionedobjects: Remove the ambiguous context argument on remotable methods  https://review.openstack.org/15504820:48
*** ajo has quit IRC20:54
*** ajo has joined #openstack-oslo20:55
openstackgerritDan Smith proposed openstack/oslo.versionedobjects: Remove the ambiguous context argument on remotable methods  https://review.openstack.org/15504820:57
*** ajo has quit IRC21:01
dims__dansmith: if the object does not have an emedded context then we'll see OrphanedObjectError?21:02
dansmithdims__: yep21:02
stevemardhellmann, i'm calling it - we should be ready to tag a release of oslo.policy, i double checked all the items here: https://etherpad.openstack.org/p/graduate-policy21:03
dhellmannstevemar: ok, I'm wrapped up in this version capping thing at the moment, but I'll review everything and if it looks good I will cut 0.1.0 tomorrow21:05
stevemardhellmann, \o/21:06
dhellmannstevemar: also, if you haven't already, please update the work items on the blueprint21:06
stevemarwill do sir21:06
dhellmannty!21:06
openstackgerritMehdi Abaakouk proposed openstack/oslo.messaging: rabbit: Fix behavior of rabbit_use_ssl  https://review.openstack.org/15444621:07
dims__good work stevemar!21:07
stevemardims__, ty - was also wondering about fileutils in incubator21:08
stevemari posted a patch to move it to oslo.utils, i'm wondering if i need to create a whole blueprint for that too?21:08
dims__stevemar: will check. give me a few21:10
*** ViswaV has joined #openstack-oslo21:12
*** kgiusti has quit IRC21:12
*** ajo has joined #openstack-oslo21:15
dims__dansmith: what does serialize_entity use context for?21:16
dansmithdims__: I think it's there for symmetry with deserialize()21:17
dims__dansmith: cool, it's not really needed or used from what i can tell21:23
openstackgerritJoshua Harlow proposed openstack/taskflow: Move 'provides' and 'name' to instance attributes  https://review.openstack.org/15506021:23
dansmithdims__: we put it there because it was part of oslo.messaging api, and since the serializer is defined in each project, we didn't want to limit them to only the context on deserialize21:23
dansmithdims__: see that that class inherits from messaging.NoOpSerializer ?21:24
dims__ah. got it. thanks i did miss that21:24
*** achanda has joined #openstack-oslo21:36
*** achanda has quit IRC21:39
*** achanda has joined #openstack-oslo21:39
*** kgiusti has joined #openstack-oslo21:40
dims__stevemar: left a note and added dhellmann to the review21:42
stevemardims__, cool!21:42
dims__stevemar: i had exactly the same thought before paris, so am with you21:43
*** tsekiyama has quit IRC21:45
*** tsekiyama has joined #openstack-oslo21:45
stevemardims__, looks like concurrency depends on utils now anyway =\21:47
dims__stevemar: cool, so we should be all set :)21:48
*** daniel3_ has quit IRC21:48
dims__may be i was mis-remembering some other dependency chain. will +2 it and let's wait for dhellmann21:48
*** daniel3_ has joined #openstack-oslo21:50
*** cdent has joined #openstack-oslo21:50
*** daniel3_ is now known as Guest3477621:50
stevemarsounds good to me21:51
dims__stevemar: dug up the etherpad - https://etherpad.openstack.org/p/kilo-oslo-library-proposals21:51
dims__"We may want to split some of the things like fileutils, imageutils, etc. out to separate libraries just to avoid dependency bloat "21:52
dims__quote from dhellmann21:52
stevemartheres also, re: oslo.context: This library is needed to release oslo.log, and oslo.log is blocking oslo.concurrency because currently oslo.concurrency includes a version of the log settings in the vendored copy of log needed by fileutils21:52
stevemaroh i guess... i mean fileutils just depends on std libs, no 3rd party stuff21:54
dims__right21:54
stevemarif it's packaged solo that would be nice21:54
stevemarbut its not like oslo.utils has tons of bloat21:55
stevemarhttps://github.com/openstack/oslo.utils/blob/master/requirements.txt21:55
dims__either way we have to revisit stuff to see where we are since that etherpad is old21:55
dims__stevemar: right21:55
stevemari'm legitimately indifferent, on one hand it's nice to make something like oslo.io, but OTOH the reqs for utils are small21:56
stevemarwhat are the odds that a project isn't going to use oslo.utils21:56
* stevemar shrugs21:56
dims__stevemar: next oslo meeting, we can take it to vote21:57
stevemarfair enough, when are those?21:57
dims__monday noon-ish i think21:58
*** Guest34776 has quit IRC21:58
dims__1600 UTC21:58
dims__https://wiki.openstack.org/wiki/Meetings/Oslo21:59
*** daniel3__ has joined #openstack-oslo22:01
*** noelbk has quit IRC22:02
dhellmannstevemar, dims__ : the client libs use oslo.utils, so we don't want to drag too much in as secondary requirements22:02
stevemardhellmann, but fileutils doesn't add to any secondary requirements, AFAICT it's just std lib22:04
dhellmannstevemar: ok, that's fine -- I just wanted to make sure that was kept in mind22:04
*** ihrachyshka has quit IRC22:04
dhellmannI also want to avoid throwing everything into oslo.utils, just as a random bag of whatever we can't think of where else to put it22:05
dhellmannsome of this stuff is really stable, so making a new library is a one time cost22:05
stevemarthats fair22:06
dhellmannthe benefit is we get the whole history of the file, which we don't if we copy the file between existing repositories -- though I'm told there may be a way to merge those histories, too22:06
dhellmannI probably didn't do a good enough job of writing down why I came up with each of those libraries, so as dims__ said we should go through it again22:07
dhellmannI would lean towards saving history, myself, but I can be persuaded it's not worth the trouble :-)22:07
dhellmannstevemar: for some reason I thought fileutils had code that only glance was using, but it doesn't look like it, so this may be a good candidate to get into oslo.utils22:08
stevemardhellmann, afaik, keystone and oslo.policy would use it too22:09
dhellmannstevemar: yeah, I just mis-remembered what it was22:12
*** kgiusti has left #openstack-oslo22:13
*** noelbk has joined #openstack-oslo22:13
dims__dhellmann: we are growing old dhellmann :)22:15
dhellmanndims__: my "friend" said to me recently, "there are people younger than us who are old"22:16
dims__dhellmann: classic22:23
openstackgerritJoshua Harlow proposed openstack/taskflow: Move 'provides' and 'name' to instance attributes  https://review.openstack.org/15506022:25
*** cdent has quit IRC22:47
*** cdent has joined #openstack-oslo22:48
*** mriedem has quit IRC22:52
openstackgerritManish Godara proposed openstack/taskflow: Clarify documentation related to inputs  https://review.openstack.org/15509322:54
*** ajo has quit IRC22:58
*** achanda has quit IRC23:00
*** achanda has joined #openstack-oslo23:05
*** e0ne has quit IRC23:20
*** cdent has quit IRC23:30
*** achanda has quit IRC23:32
*** achanda has joined #openstack-oslo23:33
*** MasterPiece| is now known as MasterPiece23:40
*** prad has quit IRC23:41
openstackgerritMerged openstack/oslo.policy: document the migration process and update the docs a bit  https://review.openstack.org/15475223:47
*** dims__ has quit IRC23:49
*** dims__ has joined #openstack-oslo23:50
*** achanda has quit IRC23:52
openstackgerritJoshua Harlow proposed openstack/oslo.serialization: Avoid using strtime for serializing datetimes  https://review.openstack.org/15454723:52
*** achanda has joined #openstack-oslo23:53
openstackgerritJoshua Harlow proposed openstack/taskflow: Improve upon/adjust/move around new optional example  https://review.openstack.org/15511123:53
*** achanda has quit IRC23:53
*** dims__ has quit IRC23:54
*** achanda has joined #openstack-oslo23:56

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!