| *** andreykurilin_ has joined #openstack-oslo | 00:12 | |
| gus | So I note some of the new oslo_foo packages still import other parts of themselves using oslo.foo - is that considered a bug? | 00:18 |
|---|---|---|
| gus | and also now that I look at the packages, I see files are duplicated between oslo.foo and oslo_foo (at least for oslo.utils, which I happened to look at first). Was __init__.py trickery considered and discarded as an option to avoid duplication here? (what was the issue with that approach?) | 00:21 |
| gus | (I'm eager to see the demise of the oslo namespace package - but haven't kept up with the details/roadmap. If I should send in a bunch of trivial patches to address the above, let me know) | 00:25 |
| openstackgerrit | Matthew Treinish proposed openstack/debtcollector: Add a removal decorator https://review.openstack.org/153429 | 00:28 |
| mtreinish | harlowja: ^^^ | 00:28 |
| harlowja | woot | 00:28 |
| harlowja | mtreinish do u want to infer the function_name there? | 00:28 |
| harlowja | like https://github.com/openstack/debtcollector/blob/master/debtcollector/moves.py#L35 | 00:29 |
| harlowja | up to u | 00:29 |
| harlowja | then no name needs to be provided | 00:29 |
| mtreinish | harlowja: oh, I didn't even think about that (maybe a sign I should call it a night soon) | 00:29 |
| mtreinish | sure one sec I'll respin it to add that | 00:29 |
| harlowja | cools | 00:29 |
| *** dims__ has quit IRC | 00:31 | |
| openstackgerrit | Matthew Treinish proposed openstack/debtcollector: Add a removal decorator https://review.openstack.org/153429 | 00:34 |
| *** achanda has quit IRC | 00:39 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Default to using a thread-safe storage unit https://review.openstack.org/153434 | 00:41 |
| openstackgerrit | Matthew Treinish proposed openstack/debtcollector: Add a removal decorator https://review.openstack.org/153429 | 00:41 |
| *** prad has joined #openstack-oslo | 00:42 | |
| *** marun has quit IRC | 00:51 | |
| *** salv-orl_ has joined #openstack-oslo | 00:58 | |
| *** salv-orlando has quit IRC | 01:01 | |
| *** salv-orl_ has quit IRC | 01:02 | |
| *** daniel3_ has quit IRC | 01:05 | |
| *** dims__ has joined #openstack-oslo | 01:05 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Default to using a thread-safe storage unit https://review.openstack.org/153434 | 01:07 |
| *** tsekiyam_ has joined #openstack-oslo | 01:08 | |
| openstackgerrit | Vilobh Meshram proposed openstack/taskflow: Docstrings should document parameters return values https://review.openstack.org/152375 | 01:08 |
| *** sputnik13 has quit IRC | 01:09 | |
| *** mtanino has quit IRC | 01:10 | |
| *** andreykurilin_ has quit IRC | 01:11 | |
| *** tsekiyama has quit IRC | 01:11 | |
| *** tsekiyam_ has quit IRC | 01:12 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Default to using a thread-safe storage unit https://review.openstack.org/153434 | 01:13 |
| *** salv-orl_ has joined #openstack-oslo | 01:14 | |
| *** noelbk has quit IRC | 01:15 | |
| *** ViswaV has joined #openstack-oslo | 01:26 | |
| *** ViswaV has quit IRC | 01:31 | |
| *** ViswaV has joined #openstack-oslo | 01:32 | |
| *** openstack has joined #openstack-oslo | 01:33 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add warning to sqlalchemy backend size limit docs https://review.openstack.org/153443 | 01:48 |
| *** salv-orl_ has quit IRC | 01:53 | |
| *** ViswaV has quit IRC | 02:01 | |
| openstackgerrit | Vilobh Meshram proposed openstack/taskflow: Docstrings should document parameters return values https://review.openstack.org/152375 | 02:07 |
| *** takedakn has quit IRC | 02:08 | |
| *** ChuckC_ has joined #openstack-oslo | 02:09 | |
| *** ChuckC has quit IRC | 02:13 | |
| openstackgerrit | Merged openstack/oslo.policy: Add entry points for option discovery https://review.openstack.org/153090 | 02:26 |
| *** yamahata has quit IRC | 02:46 | |
| *** harlowja is now known as harlowja_away | 02:48 | |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.policy: Privatize parsing classes https://review.openstack.org/153149 | 02:50 |
| *** salv-orlando has joined #openstack-oslo | 02:53 | |
| *** ChuckC has joined #openstack-oslo | 02:59 | |
| *** ChuckC_ has quit IRC | 02:59 | |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.policy: Make use of private modules https://review.openstack.org/153310 | 03:14 |
| stevemar | sigmavirus24_awa, i hope that rebase was correct... | 03:15 |
| *** dims__ has quit IRC | 03:15 | |
| *** achanda has joined #openstack-oslo | 03:17 | |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.policy: Do not use global enforcer for tests https://review.openstack.org/153321 | 03:17 |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.policy: Stop shouting test attribute names https://review.openstack.org/153322 | 03:18 |
| *** achanda has quit IRC | 03:23 | |
| *** salv-orlando has quit IRC | 03:25 | |
| *** salv-orlando has joined #openstack-oslo | 03:27 | |
| *** salv-orlando has quit IRC | 03:34 | |
| *** achanda has joined #openstack-oslo | 04:23 | |
| *** prad has quit IRC | 04:24 | |
| *** salv-orlando has joined #openstack-oslo | 04:31 | |
| *** salv-orlando has quit IRC | 04:48 | |
| *** miqui_ has joined #openstack-oslo | 04:49 | |
| *** salv-orlando has joined #openstack-oslo | 04:50 | |
| *** yamahata has joined #openstack-oslo | 04:54 | |
| *** zzzeek has quit IRC | 04:58 | |
| *** achanda has quit IRC | 05:25 | |
| *** achanda has joined #openstack-oslo | 05:27 | |
| *** salv-orlando has quit IRC | 05:29 | |
| *** BrianShang_ has joined #openstack-oslo | 05:30 | |
| *** harlowja_at_home has joined #openstack-oslo | 05:32 | |
| *** BrianShang has quit IRC | 05:33 | |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.policy: Make use of private modules https://review.openstack.org/153310 | 05:38 |
| *** harlowja_away has quit IRC | 05:38 | |
| *** noelbk has joined #openstack-oslo | 05:41 | |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.policy: Do not use global enforcer for tests https://review.openstack.org/153321 | 05:41 |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.policy: Stop shouting test attribute names https://review.openstack.org/153322 | 05:43 |
| stevemar | sigmavirus24_awa, dhellmann finally done re-basing all those patches, *phew* | 05:43 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Default to using a thread-safe storage unit https://review.openstack.org/153434 | 06:06 |
| openstackgerrit | Merged openstack/taskflow: Just directly access the callback attributes https://review.openstack.org/152408 | 06:20 |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.policy: Stop shouting test attribute names https://review.openstack.org/153322 | 06:27 |
| *** rushiagr_away is now known as rushiagr | 06:29 | |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.policy: Remove oslo.concurrency from requirements https://review.openstack.org/153480 | 06:31 |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.policy: Sync test-requirements with global requirements https://review.openstack.org/153481 | 06:34 |
| *** openstackgerrit has quit IRC | 06:35 | |
| *** openstackgerrit has joined #openstack-oslo | 06:35 | |
| *** tsufiev_ is now known as tsufiev | 06:37 | |
| *** salv-orlando has joined #openstack-oslo | 06:37 | |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.policy: Upgrade hacking to >=0.10.0 https://review.openstack.org/153482 | 06:43 |
| openstackgerrit | Merged openstack/taskflow: Remove duplicate code https://review.openstack.org/152826 | 06:47 |
| *** salv-orlando has quit IRC | 06:48 | |
| *** harlowja_at_home has quit IRC | 06:49 | |
| *** achanda has quit IRC | 06:52 | |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.policy: Remove oslo.concurrency from requirements https://review.openstack.org/153480 | 06:54 |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.policy: Sync test-requirements with global requirements https://review.openstack.org/153481 | 06:54 |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.policy: Upgrade hacking to >=0.10.0 https://review.openstack.org/153482 | 06:54 |
| *** achanda has joined #openstack-oslo | 07:01 | |
| *** noelbk has quit IRC | 07:03 | |
| *** vigneshvar has joined #openstack-oslo | 07:07 | |
| *** noelbk has joined #openstack-oslo | 07:08 | |
| *** miqui_ has quit IRC | 07:12 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add a symbol type (WIP) https://review.openstack.org/144789 | 07:13 |
| *** pblaho has joined #openstack-oslo | 07:17 | |
| *** Ritz has joined #openstack-oslo | 07:18 | |
| *** pblaho has quit IRC | 07:22 | |
| Ritz | i am new to oslo messaging , i sucessfully wrote the publisher and consumer part using "from oslo import messaging" but i am a bit confused looking at examples of the website which says "import oslo_messaging" | 07:22 |
| Ritz | so what is the difference | 07:23 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Default to using a thread-safe storage unit https://review.openstack.org/153434 | 07:25 |
| *** achanda has quit IRC | 07:27 | |
| *** _amrith_ is now known as amrith | 07:35 | |
| *** yamahata has quit IRC | 07:36 | |
| Ritz | can anyone please help me understand oslo.messaging .. | 07:38 |
| Ritz | oslo.messaging v/s oslo_messaging | 07:39 |
| *** jaosorior has joined #openstack-oslo | 08:06 | |
| *** amrith is now known as _amrith_ | 08:15 | |
| *** dulek has joined #openstack-oslo | 08:22 | |
| *** stevemar has quit IRC | 08:39 | |
| *** BrianShang has joined #openstack-oslo | 08:47 | |
| *** BrianShang_ has quit IRC | 08:50 | |
| *** ajo has joined #openstack-oslo | 08:50 | |
| *** alexpilotti has joined #openstack-oslo | 08:51 | |
| *** salv-orlando has joined #openstack-oslo | 08:56 | |
| sileht | Ritz, oslo.messaging will be deprecated in favor of oslo_messaging | 09:05 |
| sileht | Ritz, we have just changed the package name convension because of some issues with the namespace package style | 09:06 |
| sileht | Ritz, so if you write new code, you should use 'import oslo_messaging' | 09:07 |
| *** jgrimm is now known as zz_jgrimm | 09:14 | |
| *** andreykurilin_ has joined #openstack-oslo | 09:23 | |
| *** salv-orlando has quit IRC | 09:26 | |
| *** salv-orlando has joined #openstack-oslo | 09:28 | |
| *** alexpilotti has quit IRC | 09:32 | |
| *** ihrachyshka has joined #openstack-oslo | 09:35 | |
| *** mriedem has joined #openstack-oslo | 09:35 | |
| *** mriedem_zz has quit IRC | 09:36 | |
| *** e0ne has joined #openstack-oslo | 09:41 | |
| Ritz | thank you very much silhent ! | 09:45 |
| *** e0ne has quit IRC | 09:49 | |
| *** e0ne has joined #openstack-oslo | 09:50 | |
| *** SlickNik has quit IRC | 09:52 | |
| *** vigneshvar has quit IRC | 09:52 | |
| *** viktors has quit IRC | 09:53 | |
| *** kbyrne has quit IRC | 09:53 | |
| *** SlickNik has joined #openstack-oslo | 09:58 | |
| *** salv-orlando has quit IRC | 10:00 | |
| *** ruhe has left #openstack-oslo | 10:01 | |
| *** vigneshvar has joined #openstack-oslo | 10:05 | |
| *** viktors has joined #openstack-oslo | 10:06 | |
| *** kbyrne has joined #openstack-oslo | 10:06 | |
| *** subscope has quit IRC | 10:14 | |
| *** e0ne is now known as e0ne_ | 10:23 | |
| *** e0ne_ is now known as e0ne | 10:25 | |
| *** ihrachyshka has quit IRC | 10:25 | |
| *** subscope has joined #openstack-oslo | 10:26 | |
| *** dulek_ has joined #openstack-oslo | 10:29 | |
| *** andreykurilin_ has quit IRC | 10:31 | |
| *** ihrachyshka has joined #openstack-oslo | 10:31 | |
| *** dulek has quit IRC | 10:32 | |
| *** takedakn has joined #openstack-oslo | 10:40 | |
| *** subscope has quit IRC | 10:52 | |
| *** dims__ has joined #openstack-oslo | 10:54 | |
| *** pblaho has joined #openstack-oslo | 10:55 | |
| *** i159 has joined #openstack-oslo | 10:55 | |
| *** amotoki has joined #openstack-oslo | 10:56 | |
| *** ihrachyshka has quit IRC | 11:00 | |
| *** cdent has joined #openstack-oslo | 11:04 | |
| *** Ritz has quit IRC | 11:07 | |
| *** isviridov_away is now known as isviridov | 11:20 | |
| *** isviridov is now known as isviridov_launch | 11:21 | |
| *** ihrachyshka has joined #openstack-oslo | 11:25 | |
| *** denis_makogon has joined #openstack-oslo | 11:32 | |
| openstackgerrit | Victor Stinner proposed openstack/oslo.concurrency: Don't decode stdout/stderr on Python 2 https://review.openstack.org/146984 | 11:32 |
| *** cdent has quit IRC | 11:33 | |
| *** cdent has joined #openstack-oslo | 11:35 | |
| *** ihrachyshka has quit IRC | 11:40 | |
| *** cdent_ has joined #openstack-oslo | 11:42 | |
| *** zigo has quit IRC | 11:42 | |
| *** pblaho has quit IRC | 11:42 | |
| *** pblaho_ has joined #openstack-oslo | 11:42 | |
| *** cdent has quit IRC | 11:42 | |
| *** cdent_ is now known as cdent | 11:42 | |
| openstackgerrit | Victor Stinner proposed openstack/oslo.concurrency: Port processutils to Python 3 https://review.openstack.org/146984 | 11:49 |
| *** e0ne is now known as e0ne_ | 11:54 | |
| *** cdent has quit IRC | 11:58 | |
| *** dulek_ has quit IRC | 11:58 | |
| *** dulek has joined #openstack-oslo | 11:59 | |
| *** e0ne_ is now known as e0ne | 11:59 | |
| *** ihrachyshka has joined #openstack-oslo | 12:00 | |
| *** sirushti has quit IRC | 12:00 | |
| *** sirushti has joined #openstack-oslo | 12:00 | |
| *** cdent has joined #openstack-oslo | 12:00 | |
| *** dulek has quit IRC | 12:02 | |
| *** sheeprine_ has joined #openstack-oslo | 12:04 | |
| *** dulek has joined #openstack-oslo | 12:04 | |
| *** sheeprine has quit IRC | 12:05 | |
| *** russellb has quit IRC | 12:06 | |
| *** jroll has quit IRC | 12:06 | |
| *** russellb has joined #openstack-oslo | 12:09 | |
| *** sileht_ has joined #openstack-oslo | 12:11 | |
| *** breton__ has joined #openstack-oslo | 12:13 | |
| *** ihrachyshka has quit IRC | 12:15 | |
| *** pblaho_ has quit IRC | 12:15 | |
| *** ihrachyshka has joined #openstack-oslo | 12:15 | |
| *** sheeprine_ is now known as sheeprine | 12:16 | |
| *** sheeprine has joined #openstack-oslo | 12:16 | |
| *** noelbk has quit IRC | 12:17 | |
| *** jgrimmn has joined #openstack-oslo | 12:19 | |
| *** vigneshvar has quit IRC | 12:19 | |
| *** therve has quit IRC | 12:19 | |
| *** dougwig has quit IRC | 12:19 | |
| *** breton has quit IRC | 12:19 | |
| *** sileht has quit IRC | 12:19 | |
| *** wendar has quit IRC | 12:19 | |
| *** rossella_s has quit IRC | 12:19 | |
| *** zz_jgrimm has quit IRC | 12:19 | |
| *** dtantsur|afk has quit IRC | 12:19 | |
| *** sileht_ is now known as sileht | 12:19 | |
| *** pblaho__ has joined #openstack-oslo | 12:19 | |
| *** jroll has joined #openstack-oslo | 12:21 | |
| *** vigneshvar has joined #openstack-oslo | 12:21 | |
| *** therve has joined #openstack-oslo | 12:21 | |
| *** dougwig has joined #openstack-oslo | 12:21 | |
| *** wendar has joined #openstack-oslo | 12:21 | |
| *** rossella_s has joined #openstack-oslo | 12:21 | |
| *** dtantsur|afk has joined #openstack-oslo | 12:21 | |
| *** ihrachyshka has quit IRC | 12:24 | |
| *** pblaho__ has quit IRC | 12:28 | |
| *** sileht has quit IRC | 12:28 | |
| *** sileht has joined #openstack-oslo | 12:29 | |
| *** ihrachyshka has joined #openstack-oslo | 12:30 | |
| *** jaypipes has joined #openstack-oslo | 12:31 | |
| *** breton__ is now known as breton | 12:44 | |
| *** dulek has quit IRC | 12:53 | |
| *** dulek has joined #openstack-oslo | 12:54 | |
| openstackgerrit | Christian Berendt proposed openstack-dev/hacking: Add hacking check H106: Use the correct capitalization of OpenStack https://review.openstack.org/153547 | 12:58 |
| *** kgiusti has joined #openstack-oslo | 13:08 | |
| *** rushiagr is now known as rushiagr_away | 13:10 | |
| *** dims__ has quit IRC | 13:17 | |
| *** alexpilotti has joined #openstack-oslo | 13:20 | |
| *** dulek has quit IRC | 13:21 | |
| *** dulek has joined #openstack-oslo | 13:22 | |
| *** dims_ has joined #openstack-oslo | 13:25 | |
| *** bknudson has quit IRC | 13:28 | |
| *** dulek_ has joined #openstack-oslo | 13:29 | |
| *** dulek has quit IRC | 13:32 | |
| *** gordc has joined #openstack-oslo | 13:40 | |
| *** vigneshvar has quit IRC | 13:47 | |
| *** rushiagr_away is now known as rushiagr | 13:50 | |
| *** ihrachyshka has quit IRC | 13:51 | |
| openstackgerrit | Ken Giusti proposed openstack/oslo.messaging: Remove unnecessary log messages from amqp1 unit tests https://review.openstack.org/153564 | 13:53 |
| *** ihrachyshka has joined #openstack-oslo | 13:55 | |
| *** ajo has quit IRC | 13:57 | |
| *** ajo has joined #openstack-oslo | 13:57 | |
| *** jroll has quit IRC | 14:03 | |
| *** jroll has joined #openstack-oslo | 14:03 | |
| *** andreykurilin has quit IRC | 14:04 | |
| *** jaosorior has quit IRC | 14:06 | |
| *** andreykurilin has joined #openstack-oslo | 14:06 | |
| *** jaypipes is now known as leakypipes | 14:07 | |
| dhellmann | gus: we have some patches in flight to stop using the namespace packages throughout the oslo libraries, but if you could be more specific about what you've found that would help. The duplicated modules were necessary to deal with a hacking rule implementation at one point. My goal is to remove the packages entirely next cycle, so I wasn't that interested in spending time making trickery work. | 14:15 |
| *** isviridov_launch is now known as isviridov | 14:16 | |
| *** ihrachyshka has quit IRC | 14:20 | |
| openstackgerrit | Alex Meade proposed openstack/oslotest: Set a higher default for maxDiff https://review.openstack.org/153578 | 14:33 |
| *** bknudson has joined #openstack-oslo | 14:39 | |
| *** _amrith_ is now known as amrith | 14:47 | |
| *** ChuckC has quit IRC | 14:52 | |
| *** amrith is now known as _amrith_ | 15:01 | |
| *** ajo has quit IRC | 15:02 | |
| *** ajo has joined #openstack-oslo | 15:02 | |
| *** jecarey has joined #openstack-oslo | 15:06 | |
| *** yamahata has joined #openstack-oslo | 15:12 | |
| *** rushiagr is now known as rushiagr_away | 15:15 | |
| *** stevemar has joined #openstack-oslo | 15:17 | |
| *** jgrimmn is now known as zz_jgrimmn | 15:21 | |
| *** yamahata has quit IRC | 15:23 | |
| *** mtanino has joined #openstack-oslo | 15:25 | |
| *** jaosorior has joined #openstack-oslo | 15:31 | |
| *** salv-orlando has joined #openstack-oslo | 15:43 | |
| bnemec | Holy cow, how deep does this oslo.policy patch chain go? :-) | 15:49 |
| dhellmann | bnemec: :-) | 15:50 |
| * bnemec finally reached the bottom | 15:51 | |
| denis_makogon | bnemec, hi there, got question. do you have like 5 mins to talk? | 15:53 |
| bnemec | denis_makogon: Sure | 15:54 |
| denis_makogon | bnemec, as you i've updated your patchset and did some changes to project-config ( tool that checks requirements), and according to Monty's suggestion i've send an email about our approach | 15:55 |
| bnemec | denis_makogon: Yeah, I kind of figured they'd want to make sure everyone is still onboard with this. | 15:56 |
| otherwiseguy | bnemec: re-replied to your concern on the processutils monkey_patch issue. I think I'm right, but you never know...this stuff gets a bit complex. ;) | 15:56 |
| bnemec | I did glance at the changes, but I haven't had a chance to really dive in yet. | 15:56 |
| denis_makogon | bnemec, so, as dhellmann told not so long ago, the idea of splitting requirements into per-driver requirements should eventually end as ability to install oslo.messaging with deps for specific driver i.e., oslo.messaging[rabbit] | 15:56 |
| bnemec | denis_makogon: Yep, absolutely. | 15:58 |
| *** yamahata has joined #openstack-oslo | 15:58 | |
| *** kgiusti1 has joined #openstack-oslo | 15:59 | |
| *** _amrith_ is now known as amrith | 15:59 | |
| denis_makogon | i was trying to user 'extras_require' as dhellmann suggested, but it does seem to work only if i'd modify setup.py explicitly (adding [extras_require] section into setup.cfg doesn't work) | 16:00 |
| *** kgiusti has quit IRC | 16:00 | |
| denis_makogon | bnemec, also, it doesn't work if you would use same redirection (as you've did) in extras_require, this option expects to receive only a list of dependencies, but not redirections, unfortunately =( | 16:01 |
| bnemec | I didn't even remember that I did that. :-) | 16:03 |
| denis_makogon | bnemec, but you've did and that was awesome, because i didn't know that we can do that =) | 16:03 |
| *** isviridov is now known as isviridov_away | 16:07 | |
| *** david-lyle_afk is now known as david-lyle | 16:07 | |
| denis_makogon | dhellmann, thanks for suggestion to look at pbr. Appreciate it. | 16:08 |
| *** salv-orlando has quit IRC | 16:13 | |
| *** salv-orlando has joined #openstack-oslo | 16:13 | |
| dhellmann | denis_makogon: please work with bnemec on a spec before writing any more code | 16:16 |
| denis_makogon | dhellmann, will do | 16:16 |
| dhellmann | there are several parties we want to align on whatever decision we make, and it's not obvious that we need to do anything more complicated than adding all of our requirements to requirements.txt | 16:17 |
| *** tsekiyama has joined #openstack-oslo | 16:18 | |
| *** dulek_ has quit IRC | 16:19 | |
| *** openstackgerrit has quit IRC | 16:21 | |
| *** openstackgerrit has joined #openstack-oslo | 16:22 | |
| otherwiseguy | bnemec: also just added a gist with an example showing what happens on the processutils monkey_patch review: https://review.openstack.org/#/c/153216/ | 16:32 |
| *** dtantsur|afk is now known as dtantsur | 16:36 | |
| *** dims_ is now known as dimsum__ | 16:39 | |
| *** zzzeek has joined #openstack-oslo | 16:42 | |
| *** prad has joined #openstack-oslo | 16:47 | |
| *** enykeev has quit IRC | 16:50 | |
| *** daniel3_ has joined #openstack-oslo | 16:51 | |
| *** enykeev has joined #openstack-oslo | 16:52 | |
| bnemec | otherwiseguy: Okay, so for some reason I was thinking eventlet monkey patched the entire module out. Turns out it's just attributes, so this does work as expected. | 16:52 |
| bnemec | But I still have a couple of issues with it: | 16:53 |
| bnemec | 1) It took me this long to figure out what's going on, and I'm vaguely familiar with the concept of eventlet monkey patching. Most devs aren't going to have a clue what's going on. | 16:53 |
| *** dhellmann_ has quit IRC | 16:53 | |
| bnemec | 2) There's still a race if someone calls execute before monkey patching happens. | 16:53 |
| *** dhellmann_ has joined #openstack-oslo | 16:54 | |
| otherwiseguy | bnemec: Right, but these issues exist anyway. It just makes things slightly better. | 16:54 |
| otherwiseguy | The problem is that monkey patching is just evil. :) | 16:54 |
| otherwiseguy | Big 'ol code comment explaining? | 16:54 |
| bnemec | otherwiseguy: Right, which is why we shouldn't mess around with it. Do it first, or not at all. | 16:55 |
| bnemec | Anything in between leaves you open to really difficult to debug issues. | 16:55 |
| bnemec | Honestly I'm kind of happy this breaks because IMHO it exposed a problem in Neutron. | 16:56 |
| otherwiseguy | The problem is not always being in control of what is monkey_patching. This at least delays the issue to the last possible momemnt: execution. | 16:56 |
| *** dhellmann_ has quit IRC | 16:56 | |
| otherwiseguy | The biggest issue being things like tests. | 16:56 |
| bnemec | otherwiseguy: How is anyone not in control of when the monkey patching happens? Do it in __init__.py and be done with it. | 16:56 |
| *** takedakn has quit IRC | 16:57 | |
| otherwiseguy | Like I'm not in charge of what tempest is doing with my code, etc. | 16:57 |
| *** dhellmann_ has joined #openstack-oslo | 16:57 | |
| bnemec | otherwiseguy: Sure, put it in __init__.py. No matter how tempest imports your code it will get monkey patched before any of your stuff runs. | 16:57 |
| otherwiseguy | You can go around trying to fix it everywhere, but it is nice to be able to catch as many cases as you can in the library, IMO. | 16:57 |
| *** BAKfr has quit IRC | 16:58 | |
| *** ChuckC has joined #openstack-oslo | 16:58 | |
| otherwiseguy | The problem is, we can't put it in neutron/__init__.py for some reason that Ihar mentions in another patch. We can put it in neutron/tests/__init__.py, though. That fixes our unit tests, but not whatever tempest is doing. | 16:59 |
| *** dhellmann_ has quit IRC | 16:59 | |
| *** vigneshvar has joined #openstack-oslo | 16:59 | |
| *** haypo has left #openstack-oslo | 16:59 | |
| otherwiseguy | (god I hate eventlet) | 16:59 |
| *** dhellmann_ has joined #openstack-oslo | 16:59 | |
| bnemec | otherwiseguy: Where is this other patch? | 16:59 |
| bnemec | otherwiseguy: So much +1 :-) | 17:00 |
| otherwiseguy | bnemec: https://review.openstack.org/#/c/153225/ | 17:00 |
| otherwiseguy | apparently it breaks flake8 | 17:00 |
| *** BAKfr has joined #openstack-oslo | 17:01 | |
| bnemec | otherwiseguy: Oh, right. Nova actually does it in nova/cmd/__init__.py to avoid that. | 17:02 |
| bnemec | Actually that looks like the right fix to me. | 17:02 |
| bnemec | And I don't think tempest should be an issue. It's not supposed to be importing code directly. | 17:02 |
| bnemec | It just runs against the REST API. | 17:02 |
| bnemec | And the CLI, although I think they were talking about removing that. | 17:03 |
| bnemec | We should put together an eventlet best practices wiki page and get all of the projects doing things the same way. | 17:04 |
| otherwiseguy | bnemec: ok. I had tried just depending my neutron.utils.execute -> processutils patch on the neutron/tests/__init__.py and noticed I'd gotten tempest timeouts on all of the tests. I can try doing making another patch that patches cmd/__init__.py and add that as a dependency as well and see if that fixes things. | 17:04 |
| *** kgiusti1 has quit IRC | 17:04 | |
| bnemec | Mostly so I don't have to remember this whole discussion in six months when someone else has issues. :-) | 17:04 |
| bnemec | otherwiseguy: Yeah, the tests change won't help there. I think cmd is the right place for runtime stuff. | 17:05 |
| *** tedross has joined #openstack-oslo | 17:05 | |
| * otherwiseguy hopes it works so he can go back to pretending that eventlet doesn't exist | 17:06 | |
| *** crc32 has joined #openstack-oslo | 17:06 | |
| otherwiseguy | (until it bites him, again, like it always will, because it is evil) | 17:06 |
| bnemec | Yeah, we have a bunch of people in Oslo pushing to move off of it. | 17:06 |
| bnemec | But it's a hard sell because it's insinuated itself into so many projects at this point. | 17:07 |
| *** kgiusti has joined #openstack-oslo | 17:08 | |
| bnemec | dhellmann: and dhellmann_: What do you think about a cross-project spec for eventlet best practices? | 17:09 |
| bnemec | (right after I finish the feature freeze spec...) | 17:09 |
| *** vigneshvar has quit IRC | 17:14 | |
| *** salv-orlando has quit IRC | 17:16 | |
| openstackgerrit | Merged openstack/oslo.policy: Privatize parsing classes https://review.openstack.org/153149 | 17:19 |
| otherwiseguy | bnemec: neutron/cmd isn't really used for most neutron executables. It's spread all over the place neutron/{plugins,agents,cmd,severices,...} etc. | 17:23 |
| * otherwiseguy sighs | 17:23 | |
| *** zz_jgrimmn is now known as jgrimm | 17:23 | |
| *** e0ne has quit IRC | 17:24 | |
| bnemec | otherwiseguy: Hmm, that's unfortunate. In oslo.concurrency we do tests with and without eventlet - I wonder if you could do the same thing with Neutron. Just tell it not to monkey patch on flake8 runs. | 17:24 |
| bnemec | If that's the only problem you might be able to just put it in top-level __init__ again. | 17:25 |
| *** BrianShang_ has joined #openstack-oslo | 17:26 | |
| otherwiseguy | I'd still argue that making processutils slightly more resilient isn't a horrible idea. There's already a pretty big comment around the existing test it already has to do... But, I'm also lazy. And my brain is worn out. | 17:27 |
| *** sigmavirus24_awa is now known as sigmavirus24 | 17:28 | |
| *** BrianShang has quit IRC | 17:28 | |
| sigmavirus24 | stevemar: I'm sure you rebased them perfectly | 17:29 |
| bnemec | Oh dear, we lost our eventlet testing in the namespace package move. :-( | 17:29 |
| * otherwiseguy investigates un-inventing eventlet | 17:31 | |
| openstackgerrit | Ben Nemec proposed openstack/oslo.concurrency: Add eventlet test check to new tests __init__.py https://review.openstack.org/153635 | 17:34 |
| bnemec | otherwiseguy: So what I'm thinking is something like https://github.com/openstack/oslo.concurrency/blob/master/tests/__init__.py#L17 and https://github.com/openstack/oslo.concurrency/blob/master/tox.ini#L20 | 17:35 |
| bnemec | Except you would want to disable eventlet in the flake8 runs. | 17:35 |
| bnemec | The reason I'm pushing back so hard on this is that if we work around the problem in processutils it will almost certainly come up again somewhere else, likely in a more difficult to debug situation. | 17:36 |
| bnemec | If we just make the eventlet monkey patching not racy then this class of problems goes away forever. | 17:36 |
| bnemec | Other will no doubt take their place, but it's progress. :-) | 17:36 |
| *** vigneshvar has joined #openstack-oslo | 17:37 | |
| otherwiseguy | bnemec: Trying to figure out what I need to do to make flake8 fail like Ihar mentioned. Just patching neutron/__init__.py didn't seem to break anything when I ran the flake8 test via ./runtests -p. | 17:41 |
| *** ViswaV has joined #openstack-oslo | 17:43 | |
| *** bnemec is now known as beekneemech | 17:44 | |
| beekneemech | Friday! | 17:44 |
| *** noelbk has joined #openstack-oslo | 17:46 | |
| *** ChuckC has quit IRC | 17:46 | |
| *** ViswaV has quit IRC | 17:48 | |
| *** ViswaV has joined #openstack-oslo | 17:48 | |
| *** salv-orlando has joined #openstack-oslo | 17:49 | |
| *** achanda has joined #openstack-oslo | 17:51 | |
| *** denis_makogon has quit IRC | 17:57 | |
| *** ChuckC has joined #openstack-oslo | 18:02 | |
| *** ViswaV has quit IRC | 18:02 | |
| *** dtantsur is now known as dtantsur|afk | 18:08 | |
| *** i159 has quit IRC | 18:09 | |
| openstackgerrit | Ben Nemec proposed openstack/oslo-specs: Add feature freeze policy https://review.openstack.org/153642 | 18:11 |
| *** ViswaV has joined #openstack-oslo | 18:15 | |
| *** harlowja has joined #openstack-oslo | 18:15 | |
| *** ViswaV has quit IRC | 18:19 | |
| *** ViswaV has joined #openstack-oslo | 18:20 | |
| harlowja | mtreinish shall i fix up https://review.openstack.org/#/c/153429/ (if u don't have time i'm cool with that) | 18:22 |
| *** e0ne has joined #openstack-oslo | 18:26 | |
| *** ViswaV has quit IRC | 18:31 | |
| *** ViswaV has joined #openstack-oslo | 18:37 | |
| sigmavirus24 | stevemar: btw, thanks for also taking care of the i18n updates in those changes in oslo_policy | 18:38 |
| openstackgerrit | Vilobh Meshram proposed openstack/taskflow: Docstrings should document parameters return values https://review.openstack.org/152375 | 18:39 |
| stevemar | sigmavirus24, i must have rebased correctly, folks +2'ed it | 18:39 |
| stevemar | so many docstrings to move around | 18:40 |
| *** jogo is now known as flashgordon | 18:40 | |
| sigmavirus24 | no one +2'd https://review.openstack.org/#/c/153310/7 yet =P (with good reason) | 18:40 |
| sigmavirus24 | I only realized this morning on my flights that I should have made it two changes. The one for checks (I think) would have been okay on its own. The _parser one though depended on _checks being its own module (otherwise circular import patterns) | 18:41 |
| sigmavirus24 | But I started from the wrong side of the problem yesterday so ... I didn't see it then | 18:41 |
| *** tedross has left #openstack-oslo | 18:44 | |
| mtreinish | harlowja: nah I can get to it today, I've just got a couple of other things todo before I can get to it | 18:44 |
| harlowja | kk | 18:45 |
| stevemar | sigmavirus24, meh, i think it's all good, just needs more time to bake :) | 18:49 |
| stevemar | if doug +2s it, i might just push it through | 18:49 |
| sigmavirus24 | stevemar: personally I'm glad that morganfainberg is taking a close look at it | 18:50 |
| sigmavirus24 | I have zero qualms about waiting for another person to push it through, just to be safe | 18:51 |
| stevemar | sigmavirus24, yep, i was going to take a second look again, make sure i don't miss anything | 18:51 |
| stevemar | i uploaded a few more patches at the end of the chain :) | 18:51 |
| sigmavirus24 | I saw more after Doug's | 18:52 |
| sigmavirus24 | I haven't looked at them yet | 18:52 |
| sigmavirus24 | I have >200 emails from gerrit since 2PM (CST) yesterday | 18:52 |
| morganfainberg | I'm good with it as is. Fwiw | 18:54 |
| morganfainberg | I just had errands to run before I could dig into the tests. | 18:55 |
| *** dhellmann has quit IRC | 18:58 | |
| *** dhellmann_ is now known as dhellmann | 18:58 | |
| *** dhellmann_ has joined #openstack-oslo | 18:59 | |
| stevemar | sigmavirus24, select all -> delete | 18:59 |
| sigmavirus24 | morganfainberg: really, take your time | 18:59 |
| * sigmavirus24 is at a conference this weekend so I'll have low bandwidth | 18:59 | |
| sigmavirus24 | but I think there's some openstack goodness happening one of the nights so I can pick up on reviews then | 19:00 |
| *** dhellmann_ has quit IRC | 19:01 | |
| *** dhellmann_ has joined #openstack-oslo | 19:01 | |
| openstackgerrit | Merged openstack/oslotest: Update docs for new script name https://review.openstack.org/151740 | 19:04 |
| stevemar | sigmavirus24, which conference? | 19:06 |
| sigmavirus24 | PyTennessee | 19:06 |
| *** dhellmann has quit IRC | 19:09 | |
| *** dhellmann_ is now known as dhellmann | 19:09 | |
| *** alexpilotti has quit IRC | 19:12 | |
| *** jaosorior has quit IRC | 19:16 | |
| *** cdent has quit IRC | 19:25 | |
| *** e0ne has quit IRC | 19:28 | |
| *** vigneshvar has quit IRC | 19:33 | |
| *** vigneshvar has joined #openstack-oslo | 19:34 | |
| *** andreykurilin_ has joined #openstack-oslo | 19:38 | |
| *** amrith is now known as _amrith_ | 19:38 | |
| *** achanda has quit IRC | 19:44 | |
| openstackgerrit | Merged openstack/oslo.messaging: Fix the import of the driver by the unit test https://review.openstack.org/153392 | 19:46 |
| openstackgerrit | Merged openstack/oslo.messaging: Include missing parameter in call to listen_for_notifications https://review.openstack.org/153403 | 19:49 |
| openstackgerrit | Merged openstack/oslo.messaging: Remove unnecessary log messages from amqp1 unit tests https://review.openstack.org/153564 | 19:49 |
| *** achanda has joined #openstack-oslo | 19:53 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 19:55 | |
| *** ihrachyshka has joined #openstack-oslo | 20:15 | |
| *** achanda has quit IRC | 20:20 | |
| openstackgerrit | Vilobh Meshram proposed openstack/taskflow: Docstrings should document parameters return values https://review.openstack.org/152375 | 20:20 |
| *** Patang has left #openstack-oslo | 20:23 | |
| *** daniel3_ has quit IRC | 20:24 | |
| *** daniel3_ has joined #openstack-oslo | 20:29 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo-specs: Add adoption timeline to incubator policy https://review.openstack.org/153682 | 20:36 |
| *** ViswaV has quit IRC | 20:36 | |
| *** stevemar has quit IRC | 20:37 | |
| *** stevemar has joined #openstack-oslo | 20:38 | |
| *** vigneshvar has quit IRC | 20:38 | |
| *** prad has quit IRC | 20:38 | |
| *** jgrimm is now known as zz_jgrimm | 20:42 | |
| openstackgerrit | Matthew Treinish proposed openstack/debtcollector: Add a removal decorator https://review.openstack.org/153429 | 21:13 |
| *** kgiusti has quit IRC | 21:17 | |
| *** ViswaV_ has joined #openstack-oslo | 21:18 | |
| *** achanda has joined #openstack-oslo | 21:20 | |
| *** achanda has quit IRC | 21:25 | |
| *** daniel3_ has quit IRC | 21:34 | |
| *** daniel3_ has joined #openstack-oslo | 21:36 | |
| *** ChuckC has quit IRC | 21:38 | |
| *** crc32 has quit IRC | 21:40 | |
| *** vigneshvar has joined #openstack-oslo | 21:41 | |
| *** amotoki has quit IRC | 21:41 | |
| *** leakypipes has quit IRC | 21:41 | |
| flashgordon | so trollius | 21:42 |
| flashgordon | viktors: ^ | 21:42 |
| flashgordon | has it been run anywhere | 21:42 |
| flashgordon | re production | 21:42 |
| *** sigmavirus24_awa is now known as sigmavirus24 | 21:43 | |
| *** yamahata has quit IRC | 21:45 | |
| *** alexpilotti has joined #openstack-oslo | 21:48 | |
| *** ihrachyshka has quit IRC | 21:49 | |
| *** ViswaV_ has quit IRC | 21:56 | |
| *** jecarey has quit IRC | 21:59 | |
| *** achanda has joined #openstack-oslo | 22:00 | |
| harlowja | flashgordon are u poking the author of trollius with that ? | 22:00 |
| harlowja | i think viktors is the wrong victor in that case :) | 22:00 |
| harlowja | but haypo (not sure where he is) is the right one | 22:00 |
| harlowja | sileht and jd__ might know | 22:01 |
| flashgordon | harlowja: woops wrong victor indded | 22:01 |
| harlowja | haypo sometimes in here (the right victor); guess is weekend in france | 22:01 |
| * harlowja think i made that same mistake once :-P | 22:02 | |
| flashgordon | harlowja: maybe you know about trollius? my biggest concern is how tested it is | 22:06 |
| *** salv-orl_ has joined #openstack-oslo | 22:07 | |
| harlowja | flashgordon i have that same concern and i'm not sure either :-/ | 22:07 |
| harlowja | i know haypo is very active in py3.5 for asyncio | 22:07 |
| harlowja | and it does concern me the number of bugs i see for 3.5 for asyncio | 22:07 |
| harlowja | *imho* | 22:07 |
| harlowja | it seems like its still 'baking' | 22:07 |
| harlowja | and trillious is derived from asyncio | 22:07 |
| harlowja | sooo it implies the same baking | 22:07 |
| harlowja | but this is just my thoughts | 22:08 |
| flashgordon | harlowja: yeah that is my line of thinking as well | 22:08 |
| *** salv-orlando has quit IRC | 22:08 | |
| harlowja | now maybe thats not a fair evaulation | 22:08 |
| harlowja | but just my gut | 22:09 |
| flashgordon | the spec does nothing to address those issues though | 22:09 |
| harlowja | which spec u looking at? | 22:10 |
| harlowja | i just see stuff like http://bugs.python.org/issue22087 and wonder if its not ready for general use yet... | 22:10 |
| harlowja | 'asyncio: support multiprocessing' :-/ | 22:10 |
| flashgordon | https://review.openstack.org/#/c/153298/ | 22:10 |
| *** zigo has joined #openstack-oslo | 22:11 | |
| *** salv-orl_ has quit IRC | 22:11 | |
| harlowja | interesting | 22:12 |
| harlowja | man | 22:12 |
| harlowja | i have mixed feelings about that | 22:12 |
| *** bknudson has quit IRC | 22:13 | |
| *** ChuckC has joined #openstack-oslo | 22:13 | |
| harlowja | i'm sorta in the boat that zzzeek i think is in, around his thoughts @ http://lists.openstack.org/pipermail/openstack-dev/2015-January/055493.html | 22:13 |
| *** hemna has joined #openstack-oslo | 22:13 | |
| harlowja | and my general concerns flashgordon around what does it really buy the whole project as a group :-/ | 22:14 |
| harlowja | is it the best $$ spent (cause peoples time is in the end $$) | 22:15 |
| flashgordon | harlowja: yeah | 22:15 |
| harlowja | is it better spent elsewhere... | 22:15 |
| flashgordon | harlowja: the big thing I want is python3 support honestly | 22:15 |
| harlowja | sure, but haypo has also been hacking around the eventlet + py3.x also | 22:15 |
| harlowja | and thought that was getting more in 'shape' | 22:15 |
| harlowja | *for better or worse | 22:15 |
| flashgordon | harlowja: that honestly sounds like a less risky way to go at least for now | 22:16 |
| harlowja | *aka keeping the status quo (allowing $$ to be spent say on other things) | 22:16 |
| harlowja | but idk, just my thoughts :-P | 22:16 |
| *** achanda has quit IRC | 22:17 | |
| *** achanda has joined #openstack-oslo | 22:17 | |
| *** gordc has quit IRC | 22:18 | |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.policy: Remove globals that were introduced for compatibility https://review.openstack.org/153714 | 22:18 |
| flashgordon | harlowja: you should comment on that spec | 22:19 |
| harlowja | kk | 22:19 |
| harlowja | lol | 22:19 |
| harlowja | flashgordon the other thing i don't like is 'raise Return(res)' | 22:20 |
| harlowja | eck | 22:20 |
| harlowja | that trillous forces | 22:20 |
| harlowja | because of py2.x limitations | 22:20 |
| *** ViswaV has joined #openstack-oslo | 22:21 | |
| ekarlso | harlowja: what open projects are using tf now ? | 22:21 |
| ekarlso | cinder, glance and cue ? | 22:21 |
| harlowja | seems so | 22:22 |
| harlowja | and some mirantis pumphouse stuff | 22:22 |
| harlowja | https://github.com/MirantisLabs/pumphouse | 22:22 |
| harlowja | yup, still seems like pumphouse using it | 22:22 |
| harlowja | *as far as 'open' projects | 22:23 |
| harlowja | *that i know about | 22:23 |
| *** stevemar has quit IRC | 22:26 | |
| harlowja | some internal automatic fix tool gonna use it soon | 22:27 |
| harlowja | *hopefully | 22:27 |
| *** stevemar has joined #openstack-oslo | 22:27 | |
| harlowja | and bigdata folks @ rackspace still | 22:27 |
| harlowja | thats the realm of my knowledge | 22:27 |
| harlowja | lol | 22:27 |
| harlowja | flashgordon http://tinyurl.com/nxqjp4l is the open asyncio bugs (i sorta watch the python bug queue to get a feel for whats happening) | 22:28 |
| flashgordon | eep | 22:32 |
| *** vigneshvar has quit IRC | 22:36 | |
| harlowja | flashgordon and http://tinyurl.com/k7z5rpg are the closed ones (fixed or not, i'm not sure, but if closed+fixed that means likely not fixed until 3.5.x?) | 22:39 |
| harlowja | so thats not bad its a bigger list, just makes more of my gut feeling around 'is this ready' happen | 22:39 |
| harlowja | now maybe i should tell my gut to shut-up | 22:40 |
| harlowja | lol | 22:40 |
| *** mriedem has quit IRC | 22:46 | |
| *** vigneshvar has joined #openstack-oslo | 22:47 | |
| *** ViswaV has quit IRC | 23:07 | |
| *** ViswaV has joined #openstack-oslo | 23:09 | |
| *** ViswaV has quit IRC | 23:14 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 23:16 | |
| *** ViswaV has joined #openstack-oslo | 23:17 | |
| *** bknudson has joined #openstack-oslo | 23:25 | |
| *** salv-orlando has joined #openstack-oslo | 23:29 | |
| *** salv-orlando has quit IRC | 23:34 | |
| *** ViswaV has quit IRC | 23:35 | |
| *** salv-orlando has joined #openstack-oslo | 23:43 | |
| *** salv-orlando has quit IRC | 23:45 | |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.policy: Remove globals that were introduced for compatibility https://review.openstack.org/153714 | 23:46 |
| *** stevemar has quit IRC | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!