| openstackgerrit | Merged openstack/oslo.db: Restore the check_foreign_keys() method. https://review.openstack.org/146663 | 00:05 |
|---|---|---|
| bknudson | oslo.utils has both tests and oslo_utils/tests -- which one should I use? | 00:06 |
| *** raildo has quit IRC | 00:09 | |
| dhellmann | bknudson: new tests only need to go in oslo_utils/tests | 00:10 |
| dhellmann | the /tests dir is for testing the old import paths, | 00:10 |
| bknudson | dhellmann: ok, thanks. | 00:10 |
| dhellmann | zzzeek: I'll release oslo.db tomorrow morning unless you, rpodolyaka1, or viktors|afk beat me to it | 00:12 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo-incubator: Updated from global requirements https://review.openstack.org/145891 | 00:14 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.log: Updated from global requirements https://review.openstack.org/146703 | 00:14 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.messaging: Updated from global requirements https://review.openstack.org/141509 | 00:14 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.vmware: Updated from global requirements https://review.openstack.org/146162 | 00:14 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/taskflow: Updated from global requirements https://review.openstack.org/146712 | 00:16 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/tooz: Updated from global requirements https://review.openstack.org/144786 | 00:16 |
| *** mtanino_ has joined #openstack-oslo | 00:23 | |
| *** david-lyle has joined #openstack-oslo | 00:24 | |
| *** mtanino has quit IRC | 00:24 | |
| *** dims__ has joined #openstack-oslo | 00:39 | |
| *** jecarey has quit IRC | 00:41 | |
| *** david-lyle has quit IRC | 00:46 | |
| *** david-lyle has joined #openstack-oslo | 00:51 | |
| *** crc32 has joined #openstack-oslo | 00:52 | |
| *** armax has joined #openstack-oslo | 00:54 | |
| openstackgerrit | Brant Knudson proposed openstack/oslo.utils: Add TimeFixture https://review.openstack.org/146719 | 00:57 |
| bknudson | do you require a spec? ^ | 00:58 |
| bknudson | bug / blueprint | 00:58 |
| *** david-lyle has quit IRC | 01:04 | |
| *** sabari is now known as zz_sabari | 01:23 | |
| *** ihrachyshka has quit IRC | 01:23 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.utils: custom context manger for py27/py3x compatability https://review.openstack.org/146639 | 01:23 |
| *** yamahata has quit IRC | 01:24 | |
| crc32 | is there an official document out that shows how to use oslo.messaging. I'm trying to use RPCClien to send messages to a server. The RPCClient is successfully casting messages to rabiitMQ but the server does not appear to be picking up the messages. The API document doesn't show a working example of both the producer side and the consumer side. | 01:27 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 01:27 | |
| *** ihrachyshka has joined #openstack-oslo | 01:31 | |
| *** zzzeek has quit IRC | 01:35 | |
| *** achanda has joined #openstack-oslo | 01:35 | |
| crc32 | is there a working example of how to use oslo-messaging? | 01:36 |
| *** david-lyle has joined #openstack-oslo | 01:37 | |
| harlowja | crc32 i guess with https://review.openstack.org/#/c/140318/ there will be :) | 01:41 |
| *** tsekiyam_ has joined #openstack-oslo | 01:44 | |
| crc32 | Is there any examples of oslo.messaging that exist now? | 01:46 |
| *** mtanino_ has quit IRC | 01:46 | |
| harlowja | unsure; some folks here might be able to provide some | 01:47 |
| *** armax has left #openstack-oslo | 01:47 | |
| *** achanda has quit IRC | 01:47 | |
| *** tsekiyama has quit IRC | 01:47 | |
| *** tsekiyam_ has quit IRC | 01:48 | |
| crc32 | where does oslo.messaging write its logs I just want to see if the server(consumer) side is even connecting to rabbitMQ | 01:50 |
| *** achanda has joined #openstack-oslo | 01:50 | |
| *** achanda has quit IRC | 01:51 | |
| *** david-lyle has quit IRC | 01:52 | |
| harlowja | seeing that its a library i don't think it writes its log to anywhere | 01:52 |
| harlowja | u decide that by setting up python logging afaik | 01:52 |
| *** kgiusti has quit IRC | 01:56 | |
| crc32 | ok I got the logging to work. Well logging to stdout anyways. But I don't see anything happening on the server side when I send a message. | 01:57 |
| crc32 | its like the server isn't really listening to the Queue | 01:58 |
| openstackgerrit | Merged openstack-dev/pbr: Be more aggressive about building wheels https://review.openstack.org/146650 | 02:02 |
| *** burgobianco has quit IRC | 02:05 | |
| *** burgobianco has joined #openstack-oslo | 02:06 | |
| *** dims__ has quit IRC | 02:09 | |
| crc32 | so it looks like the blocking executor works but eventlet is just plain broken. | 02:09 |
| *** dims__ has joined #openstack-oslo | 02:09 | |
| *** oomichi has joined #openstack-oslo | 02:13 | |
| openstackgerrit | Dan Prince proposed openstack/oslo.i18n: Set setup.cfg packages = oslo.i18n https://review.openstack.org/146733 | 02:13 |
| *** dims__ has quit IRC | 02:14 | |
| harlowja | did u make sure that eventlet is setup and monkey patched | 02:16 |
| harlowja | if u didn't, then that executor might be all wonky | 02:16 |
| crc32 | yes I just saw that. | 02:18 |
| crc32 | I'm not really sure what eventlet or monkey_patch is. But it sounds like class dynamic mangling. | 02:18 |
| *** ihrachyshka has quit IRC | 02:19 | |
| openstackgerrit | Dan Prince proposed openstack/oslo.utils: Make setup.cfg packages include oslo.utils https://review.openstack.org/146735 | 02:20 |
| openstackgerrit | Dan Prince proposed openstack/oslo.i18n: Make setup.cfg packages include oslo.i18n https://review.openstack.org/146733 | 02:20 |
| *** salv-orlando has quit IRC | 02:25 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Use a single sender https://review.openstack.org/146738 | 02:26 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Create and use a multiprocessing sync manager subclass https://review.openstack.org/146739 | 02:26 |
| openstackgerrit | Merged openstack/taskflow: Updated from global requirements https://review.openstack.org/146712 | 02:28 |
| harlowja | crc32 yup it is | 02:30 |
| harlowja | *it is dynamic manging | 02:30 |
| harlowja | *mangling | 02:30 |
| harlowja | but thats pretty much all of eventlet, lol | 02:30 |
| *** jeffreycoho has joined #openstack-oslo | 02:36 | |
| *** zz_sabari is now known as sabari | 02:38 | |
| *** crc32 has quit IRC | 02:42 | |
| *** stevemar has joined #openstack-oslo | 02:43 | |
| *** noelbk has quit IRC | 02:45 | |
| *** dims__ has joined #openstack-oslo | 02:45 | |
| *** dims__ has quit IRC | 02:47 | |
| *** dims__ has joined #openstack-oslo | 02:48 | |
| *** yamahata has joined #openstack-oslo | 02:49 | |
| *** david-lyle has joined #openstack-oslo | 02:55 | |
| *** dims__ has quit IRC | 03:04 | |
| *** amrith is now known as _amrith_ | 03:23 | |
| *** _amrith_ is now known as amrith | 03:24 | |
| *** salv-orlando has joined #openstack-oslo | 03:26 | |
| *** harlowja is now known as harlowja_away | 03:31 | |
| *** mriedem has left #openstack-oslo | 03:35 | |
| *** mriedem has quit IRC | 03:35 | |
| *** harlowja_away is now known as harlowja | 03:39 | |
| *** amrith is now known as _amrith_ | 03:41 | |
| *** salv-orlando has quit IRC | 03:42 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add executor statistics https://review.openstack.org/146382 | 03:51 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add split time capturing to the stop watch https://review.openstack.org/146752 | 03:59 |
| *** rushiagr_away is now known as rushiagr | 04:20 | |
| openstackgerrit | Merged openstack/taskflow: The taskflow logger module does not provide a logging adapter https://review.openstack.org/146242 | 04:20 |
| *** david-lyle has quit IRC | 04:20 | |
| *** amotoki has quit IRC | 04:25 | |
| *** amotoki has joined #openstack-oslo | 04:25 | |
| *** jecarey has joined #openstack-oslo | 04:27 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add split time capturing to the stop watch https://review.openstack.org/146752 | 04:27 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add split time capturing to the stop watch https://review.openstack.org/146752 | 04:31 |
| *** achanda has joined #openstack-oslo | 04:32 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Use platform neutral line separator(s) https://review.openstack.org/146347 | 04:34 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add split time capturing to the stop watch https://review.openstack.org/146752 | 04:40 |
| *** sabari is now known as zz_sabari | 04:47 | |
| *** amotoki has quit IRC | 04:58 | |
| *** amotoki_ has joined #openstack-oslo | 05:02 | |
| *** stevemar has quit IRC | 05:04 | |
| *** stevemar has joined #openstack-oslo | 05:05 | |
| *** amotoki_ has quit IRC | 05:08 | |
| *** marun has quit IRC | 05:15 | |
| openstackgerrit | Peng Wu proposed openstack/oslo.i18n: Support contextual and plural form of gettext functions https://review.openstack.org/134850 | 05:17 |
| *** achanda has quit IRC | 05:20 | |
| openstackgerrit | Peng Wu proposed openstack/oslo.i18n: Support contextual and plural form of gettext functions https://review.openstack.org/134850 | 05:21 |
| *** noelbk has joined #openstack-oslo | 05:23 | |
| *** amotoki has joined #openstack-oslo | 05:24 | |
| *** achanda has joined #openstack-oslo | 05:35 | |
| *** zz_sabari is now known as sabari | 05:35 | |
| *** achanda has quit IRC | 05:37 | |
| *** harlowja is now known as harlowja_away | 05:42 | |
| *** oomichi has quit IRC | 05:51 | |
| *** salv-orlando has joined #openstack-oslo | 05:58 | |
| *** salv-orlando has quit IRC | 06:00 | |
| *** dims__ has joined #openstack-oslo | 06:04 | |
| *** arnaud___ has joined #openstack-oslo | 06:07 | |
| *** dims__ has quit IRC | 06:09 | |
| *** rpodolyaka2 has joined #openstack-oslo | 06:09 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.messaging: Imported Translations from Transifex https://review.openstack.org/143256 | 06:12 |
| *** rpodolyaka2 has quit IRC | 06:13 | |
| *** amotoki has quit IRC | 06:17 | |
| *** amotoki has joined #openstack-oslo | 06:18 | |
| *** rpodolyaka2 has joined #openstack-oslo | 06:39 | |
| *** salv-orlando has joined #openstack-oslo | 06:40 | |
| *** salv-orlando has quit IRC | 06:43 | |
| *** rpodolyaka2 has quit IRC | 06:50 | |
| openstackgerrit | Kobi Samoray proposed openstack/oslo.vmware: VMWare NSXv: Common components https://review.openstack.org/146780 | 07:09 |
| openstackgerrit | Merged openstack/taskflow: Use a single sender https://review.openstack.org/146738 | 07:13 |
| *** sabari is now known as zz_sabari | 07:27 | |
| *** zz_sabari is now known as sabari | 07:27 | |
| *** sabari is now known as zz_sabari | 07:32 | |
| *** amotoki has quit IRC | 07:40 | |
| *** amotoki has joined #openstack-oslo | 07:40 | |
| *** e0ne has joined #openstack-oslo | 07:55 | |
| *** e0ne is now known as e0ne_ | 08:02 | |
| *** jschwarz has joined #openstack-oslo | 08:06 | |
| *** e0ne_ has quit IRC | 08:08 | |
| openstackgerrit | Kobi Samoray proposed openstack/oslo.vmware: VMWare NSXv: Common components https://review.openstack.org/146780 | 08:12 |
| *** salv-orlando has joined #openstack-oslo | 08:16 | |
| *** k4n0 has joined #openstack-oslo | 08:18 | |
| openstackgerrit | John Schwarz proposed openstack/oslo.db: Save fixture in DbTestCase https://review.openstack.org/146794 | 08:18 |
| jschwarz | \o/ | 08:18 |
| *** e0ne has joined #openstack-oslo | 08:20 | |
| openstackgerrit | Merged openstack/taskflow: Use platform neutral line separator(s) https://review.openstack.org/146347 | 08:21 |
| openstackgerrit | Merged openstack/taskflow: Add split time capturing to the stop watch https://review.openstack.org/146752 | 08:22 |
| openstackgerrit | Merged openstack/taskflow: Fix for job consumption example using wrong object https://review.openstack.org/145574 | 08:22 |
| openstackgerrit | Merged openstack/taskflow: Include docstrings for parallel engine types/strings supported https://review.openstack.org/146287 | 08:22 |
| *** salv-orlando has quit IRC | 08:24 | |
| *** e0ne is now known as e0ne_ | 08:25 | |
| *** e0ne_ is now known as e0ne | 08:27 | |
| *** e0ne has quit IRC | 08:27 | |
| *** ajo has joined #openstack-oslo | 08:31 | |
| *** inc0 has joined #openstack-oslo | 08:32 | |
| *** stevemar has quit IRC | 08:33 | |
| *** arnaud___ has quit IRC | 08:35 | |
| *** pblaho has joined #openstack-oslo | 08:36 | |
| *** otherwiseguy has quit IRC | 08:36 | |
| *** otherwiseguy has joined #openstack-oslo | 08:38 | |
| openstackgerrit | Victor Stinner proposed openstack/oslo.messaging: Add a new aioeventlet executor https://review.openstack.org/136653 | 08:51 |
| openstackgerrit | Merged openstack/taskflow: Create and use a multiprocessing sync manager subclass https://review.openstack.org/146739 | 08:51 |
| *** dtantsur|afk is now known as dtantsur | 09:03 | |
| *** yamahata has quit IRC | 09:16 | |
| *** i159 has joined #openstack-oslo | 09:20 | |
| *** yassine has joined #openstack-oslo | 09:25 | |
| *** arnaud___ has joined #openstack-oslo | 09:36 | |
| *** dulek has joined #openstack-oslo | 09:39 | |
| *** arnaud___ has quit IRC | 09:41 | |
| *** dulek_ has joined #openstack-oslo | 09:41 | |
| *** dulek has quit IRC | 09:45 | |
| *** e0ne has joined #openstack-oslo | 09:56 | |
| sileht | Hi, if someone can Approve this namespace change (oslo.msg): https://review.openstack.org/#/c/144794/ | 09:56 |
| *** andreykurilin has joined #openstack-oslo | 09:58 | |
| haypo | sileht: i will review this change | 09:59 |
| *** jschwarz has quit IRC | 10:01 | |
| haypo | sileht: in exchange, you may approve this one ;-) https://review.openstack.org/#/c/146574/ | 10:03 |
| haypo | oh oh, i will have to rebase this change, but also my 2 other oslo messaging changes since i approved the namespace change | 10:04 |
| haypo | now i hate me too :) | 10:05 |
| sileht | haypo, oslo.messaging merge was frozen until the namespace change have been merged, so all pendings changes need to be rebased | 10:06 |
| haypo | sileht: ok. i will wait until the change is merged before rebasing my changes | 10:07 |
| openstackgerrit | garyk proposed openstack/oslo.vmware: Remove python 2.6 testing https://review.openstack.org/146810 | 10:22 |
| openstackgerrit | Kobi Samoray proposed openstack/oslo.vmware: VMWare NSXv: Common components https://review.openstack.org/146780 | 10:26 |
| openstackgerrit | Merged openstack/oslo.messaging: Move files out of the namespace package https://review.openstack.org/144794 | 10:33 |
| haypo | sileht: "Change has been successfully merged into the git repository." ! | 10:34 |
| *** ihrachyshka has joined #openstack-oslo | 10:34 | |
| sileht | Cool | 10:34 |
| *** salv-orlando has joined #openstack-oslo | 10:34 | |
| openstackgerrit | Victor Stinner proposed openstack/oslo.messaging: fix qpid test issue with eventlet monkey patching https://review.openstack.org/146574 | 10:35 |
| haypo | sileht: ^^ updated patch | 10:35 |
| *** salv-orlando has quit IRC | 10:40 | |
| openstackgerrit | zhangjl proposed openstack/oslo.messaging: Make sure zmq can work with redis https://review.openstack.org/142651 | 10:40 |
| *** salv-orlando has joined #openstack-oslo | 10:42 | |
| *** subscope has quit IRC | 10:43 | |
| *** amotoki has quit IRC | 10:45 | |
| sileht | dhellmann, I have opened https://bugs.launchpad.net/heat/+bug/1410196 this blocks the release of oslo.messaging | 10:46 |
| sileht | therve, ^^ | 10:47 |
| therve | Oopsie | 10:47 |
| haypo | sileht: what do you suggest to fix this issue? | 10:48 |
| *** andreykurilin has quit IRC | 10:48 | |
| *** andreykurilin has joined #openstack-oslo | 10:48 | |
| sileht | therve, I wonder why the exception is serialized and then unserialized | 10:50 |
| therve | sileht, Don't that wrap the error with RemoteError? | 10:50 |
| therve | The idea I believe is to fake the error going over the wire | 10:51 |
| sileht | therve, oh I see you have special behavior when you receive a RemoteError ? | 10:51 |
| therve | Yeah I think so | 10:51 |
| therve | It's the whole crap with the _Remote suffix | 10:54 |
| *** subscope has joined #openstack-oslo | 10:56 | |
| therve | sileht, https://github.com/openstack/heat/blob/master/heat/api/middleware/fault.py#L115 that's basically what we're doing in various places | 10:56 |
| *** lakshmiS has joined #openstack-oslo | 10:56 | |
| therve | And why we do those stuff in the tests | 10:57 |
| therve | Any reason why serialize_remote_exception isn't public? | 10:57 |
| sileht | Why the decorator oslo.messaging.expected_exceptions is not used | 10:57 |
| sileht | therve, because it's driver depends, perhaps a driver doesn't need to do that in that ways | 10:58 |
| therve | Hum | 10:58 |
| openstackgerrit | Victor Stinner proposed openstack/oslo.messaging: Add a new aioeventlet executor https://review.openstack.org/136653 | 10:58 |
| sileht | therve, catching exception with just the name is really insecure | 10:59 |
| lakshmiS | I need to consume notifications from glance queue and was thinking of using oslo.messaging for listening to notifications. Is it used in any other project which i can look at for sample? | 10:59 |
| openstackgerrit | Victor Stinner proposed openstack/oslo.messaging: Port zmq driver to Python 3 https://review.openstack.org/145241 | 10:59 |
| sileht | lakshmiS, by ceilometer | 10:59 |
| therve | sileht, You mean name vs fqn? | 11:00 |
| lakshmiS | thanks @sileht. will take a look at ceilometer code! | 11:00 |
| therve | If you serialize it it's not like you have more than that | 11:00 |
| sileht | therve, sure but this is the deal of oslo.messaging to serialize/unserialize that | 11:01 |
| sileht | therve, for example here: https://github.com/openstack/heat/blob/master/heat/engine/resources/software_config/software_deployment.py#L197 | 11:02 |
| openstackgerrit | Julien Danjou proposed openstack/tooz: Add a file based driver https://review.openstack.org/146507 | 11:02 |
| sileht | @oslo.messaging.expected_exceptions(exceptions.NotFound) should works | 11:02 |
| sileht | then you just have to except exceptions.NotFound: pass | 11:02 |
| sileht | this will ignore this exception and raise other with 'RemoteError' | 11:03 |
| therve | Yeah | 11:04 |
| therve | It's a major refactoring though, we have 3 different places doing that, and I don't want to break the current behavior | 11:05 |
| therve | The 2 others being more tricky | 11:05 |
| sileht | therve, the middleware one looks tricky, it's just generic code | 11:07 |
| *** e0ne is now known as e0ne_ | 11:07 | |
| sileht | therve, what is the goal of this middleware ? | 11:08 |
| sileht | just to convert error in json ? | 11:08 |
| *** e0ne_ is now known as e0ne | 11:14 | |
| openstackgerrit | Merged openstack/tooz: Allow to pass arguments to retry() https://review.openstack.org/146506 | 11:21 |
| *** arnaud___ has joined #openstack-oslo | 11:25 | |
| *** arnaud___ has quit IRC | 11:29 | |
| openstackgerrit | Merged openstack/oslo.concurrency: Bump to hacking 0.10 https://review.openstack.org/146626 | 11:31 |
| openstackgerrit | Merged openstack/oslo.serialization: Bump to hacking 0.10 https://review.openstack.org/146627 | 11:36 |
| *** kbyrne has quit IRC | 11:38 | |
| *** kbyrne has joined #openstack-oslo | 11:41 | |
| *** dims__ has joined #openstack-oslo | 11:47 | |
| *** noelbk has quit IRC | 11:56 | |
| *** e0ne is now known as e0ne_ | 11:56 | |
| *** e0ne_ is now known as e0ne | 11:56 | |
| *** _amrith_ is now known as amrith | 12:08 | |
| *** e0ne is now known as e0ne_ | 12:13 | |
| *** ajo has quit IRC | 12:14 | |
| *** ajo has joined #openstack-oslo | 12:15 | |
| *** alexpilotti has joined #openstack-oslo | 12:15 | |
| therve | sileht, To turn random exceptions to HTTP errors | 12:16 |
| therve | sileht, I don't think we can use expected_exceptions here, because it's specifically for unexpected ones | 12:23 |
| *** e0ne_ has quit IRC | 12:23 | |
| *** andreykurilin has quit IRC | 12:27 | |
| *** e0ne has joined #openstack-oslo | 12:44 | |
| *** amotoki has joined #openstack-oslo | 12:49 | |
| *** pblaho has quit IRC | 12:56 | |
| *** jaosorior has joined #openstack-oslo | 13:00 | |
| dhellmann | therve, sileht : ugh | 13:03 |
| dhellmann | therve, sileht: I'm still seeing errors about _CallContext, too -- I thought those tests were updated? | 13:06 |
| therve | Apparently not | 13:07 |
| dhellmann | http://paste.openstack.org/show/156990/ | 13:08 |
| therve | Yeah I see the tests | 13:08 |
| dhellmann | sileht: I'm inclined to add the serialize/deserialize functions to the exposed symbols under oslo.messaging using their current name, but still encourage the heat team to rewrite the exception handling as you suggest. That lets us release now without knowingly breaking them, but doesn't move the symbols into a public namespace. | 13:11 |
| *** rushiagr is now known as rushiagr_away | 13:11 | |
| dhellmann | therve: for some reason I'm *not* seeing errors from the rpc_common imports failing. I wonder why. | 13:12 |
| therve | dhellmann, Are you using latest oslo.messaging master? | 13:13 |
| dhellmann | therve: I thought so, but I'm double checking | 13:13 |
| *** arnaud___ has joined #openstack-oslo | 13:14 | |
| *** kgiusti has joined #openstack-oslo | 13:16 | |
| dhellmann | therve: how are you running the tests? | 13:16 |
| *** arnaud___ has quit IRC | 13:19 | |
| *** gordc has joined #openstack-oslo | 13:26 | |
| dhellmann | therve: the heat .testr.conf sets the test_command to a multi-line shell command that passes even though the first command to discover tests should be failing because of the bad imports | 13:33 |
| *** SergeyLukjanov has quit IRC | 13:36 | |
| *** ihrachyshka has quit IRC | 13:38 | |
| *** pradk has joined #openstack-oslo | 13:39 | |
| *** k4n0 has quit IRC | 13:41 | |
| *** SergeyLukjanov has joined #openstack-oslo | 13:44 | |
| *** jaypipes has quit IRC | 13:45 | |
| *** achanda has joined #openstack-oslo | 13:46 | |
| therve | dhellmann, Hum yeah actually that works | 13:48 |
| dhellmann | therve: the discovery command passes as it is in heat master, but if I take out the loop for contrib it fails as I would expect | 13:49 |
| dhellmann | therve: adding some __init__.py files to the contrib structure causes testr to scan it without the loop, fwiw | 13:49 |
| therve | Hum | 13:50 |
| therve | dhellmann, I didn't manage to get sileht errors. I don't know how to get it | 13:51 |
| therve | But anyway the issue is present | 13:51 |
| *** ihrachyshka has joined #openstack-oslo | 13:51 | |
| dhellmann | therve: I wasn't able to produce a failure without modifying heat's .testr.conf, were you? | 13:51 |
| therve | I didn't manage to reproduce it at all :) | 13:52 |
| dhellmann | therve: ok, I commented out line 5 of the .testr.conf in heat and then from the oslo.messaging directory ran "./tools/run_cross_tests.sh ../heat py27" | 13:53 |
| dhellmann | (that assumes you have heat and oslo.messaging checked out in the same parent directory) | 13:53 |
| dhellmann | then I get import errors during test discovery | 13:53 |
| dhellmann | I don't know how sileht found this | 13:53 |
| sileht | dhellmann, with grep :) | 13:53 |
| dhellmann | sileht: ha! | 13:53 |
| sileht | for the _CallContext, tests should mock the rpc client like this: https://github.com/openstack/ceilometer/blob/master/ceilometer/tests/publisher/test_messaging_publisher.py#L147 | 13:54 |
| *** yamahata has joined #openstack-oslo | 13:55 | |
| *** yamahata has quit IRC | 13:55 | |
| *** yamahata has joined #openstack-oslo | 13:56 | |
| dhellmann | therve: https://bugs.launchpad.net/heat/+bug/1410268 | 13:58 |
| *** jecarey has quit IRC | 14:00 | |
| *** rpodolyaka2 has joined #openstack-oslo | 14:02 | |
| *** rushiagr_away is now known as rushiagr | 14:04 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.messaging: Add oslo.messaging._drivers.common for heat tests https://review.openstack.org/146872 | 14:05 |
| dhellmann | sileht, therve : ^^ | 14:05 |
| haypo | dhellmann: why not putting this in oslo_messaging.common? "_drivers" still looks private no ? | 14:06 |
| dims__ | dhellmann: worth a TODO in https://review.openstack.org/#/c/146872/1/oslo/messaging/_drivers/common.py? to remove the private bits once heat is fixed? | 14:07 |
| haypo | dhellmann: (i see "oslo/messaging/" is your change, did you updated your master branch? the namespace change has been merged) | 14:07 |
| dhellmann | haypo: this is a temporary fix until we can have the conversation about whether those functions should be public | 14:07 |
| dhellmann | haypo: yes, that's the problem -- the private functions aren't exposed in the shims I added when moving the code out of the namespace package | 14:07 |
| haypo | dhellmann: oh. i see, i just read the patch itself | 14:07 |
| dhellmann | dims__: yeah, good idea | 14:07 |
| haypo | dhellmann: +2, but i hope that "temporary" will be short :) | 14:08 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.messaging: Add oslo.messaging._drivers.common for heat tests https://review.openstack.org/146872 | 14:08 |
| dhellmann | haypo: oh, new version of the patch ^^ | 14:08 |
| sileht | dhellmann, it's weird I have installed oslo.messaging master into a virtualenv and I have .tox/venv/lib/python2.7/site-packages/oslo/messaging/_drivers directory | 14:09 |
| sileht | in additionnal of .tox/venv/lib/python2.7/site-packages/oslo_messaging/_drivers/ | 14:09 |
| dhellmann | sileht: did you run "git clean -d -f" before installing to remove lingering .pyc files? | 14:09 |
| * sileht retries | 14:09 | |
| * dhellmann needs breakfast | 14:10 | |
| *** k4n0 has joined #openstack-oslo | 14:10 | |
| *** k4n0 has quit IRC | 14:10 | |
| haypo | sileht: i recreated my tox environments, "import oslo.messaging._drivers" fails, "import oslo_messaging._drivers" works | 14:15 |
| sileht | haypo, dhellmann http://paste.openstack.org/show/157036/ | 14:16 |
| haypo | sileht: pip tells me that i have oslo.messaging==1.5.1.post49 | 14:17 |
| haypo | i don't know how the number is generated | 14:17 |
| *** ajo has quit IRC | 14:17 | |
| sileht | haypo, number of commit since release 1.5.1 | 14:17 |
| *** ajo has joined #openstack-oslo | 14:18 | |
| sileht | (I guess) | 14:18 |
| haypo | sileht: ah, i maybe ran setup.py in a development branch | 14:18 |
| *** jokke_ has left #openstack-oslo | 14:18 | |
| haypo | (or tox, i don't remember) | 14:18 |
| sileht | $ git log 1.5.1..HEAD | grep -c ^commit | 14:18 |
| sileht | 48 | 14:18 |
| haypo | ok, good to know | 14:19 |
| *** lakshmiS has quit IRC | 14:20 | |
| *** dulek_ has quit IRC | 14:20 | |
| haypo | dhellmann, jd__ : do you have time to review my aioeventlet executor change for oslo messaging? https://review.openstack.org/#/c/136653/ | 14:21 |
| haypo | tell me if you need more context to understand the change | 14:21 |
| dhellmann | sileht: how about "git log oslo/messaging/_drivers" | 14:21 |
| *** lakshmiS has joined #openstack-oslo | 14:22 | |
| dhellmann | also "ls -ld oslo/messaging/_drivers" | 14:22 |
| dhellmann | haypo: I'll put it on my list for today | 14:22 |
| * dhellmann heads to the bakery for a while | 14:22 | |
| *** openstackgerrit has quit IRC | 14:22 | |
| sileht | dhellmann, that will not help you: http://paste.openstack.org/show/157038/ | 14:23 |
| *** openstackgerrit has joined #openstack-oslo | 14:23 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 14:23 | |
| dhellmann | sileht: try removing oslo.messaging.egg-info and installing again | 14:23 |
| sileht | dhellmann, the directory still exists | 14:25 |
| *** viktors|afk is now known as viktors | 14:27 | |
| *** jaypipes has joined #openstack-oslo | 14:32 | |
| *** pradk has quit IRC | 14:33 | |
| haypo | sileht: i removed all .pyc, __pycache__, .egg-info, etc. files, and the .tox directory. i recreated the env with "tox -e py27" => no oslo.messaging._drivers module | 14:34 |
| haypo | sileht: maybe you applied dhellmann's patch? :) | 14:34 |
| sileht | haypo, will 'pip install -e' it works as expected, but not with 'pip install' | 14:35 |
| *** raildo has joined #openstack-oslo | 14:35 | |
| haypo | sileht: what is your full command? | 14:36 |
| sileht | haypo, I do http://paste.openstack.org/show/157036/ | 14:36 |
| dhellmann | sileht: what's the sha of the repo you have checked out? | 14:38 |
| sileht | dhellmann, e55a83e832d888e1a5fb087863590b08e7bd6090 | 14:40 |
| haypo | sileht: ls: cannot access foobar/lib/python2.7/site-packages/oslo.messaging/_drivers/: No such file or directory | 14:41 |
| haypo | sileht: you lie | 14:41 |
| sileht | ahah :) | 14:41 |
| haypo | sileht: i just reproduced http://paste.openstack.org/show/157036/ | 14:41 |
| sileht | something should be wrong on my computer :( | 14:41 |
| haypo | sileht: something is different between our two computers, but what? ... | 14:41 |
| *** salv-orlando has quit IRC | 14:41 | |
| *** salv-orlando has joined #openstack-oslo | 14:42 | |
| sileht | I have retried with a tarball built with setup.py sdist and it works fine, so it should be fine for the release | 14:42 |
| haypo | sileht: i don't think so, http://paste.openstack.org/show/157051/ | 14:43 |
| sileht | haypo, oslo_messaging is correct, oslo/messaging is not | 14:44 |
| haypo | sileht: heat wants oslo/messaging/_drivers, there is no such directory in the tarball | 14:44 |
| sileht | haypo, oh you have not copy/paste the right command, it's 'ls foobar/lib/python2.7/site-packages/oslo/messaging/_drivers/' | 14:44 |
| haypo | haypo@devstack-victor$ ls foobar/lib/python2.7/site-packages/oslo/messaging/_drivers/ | 14:45 |
| haypo | ls: cannot access foobar/lib/python2.7/site-packages/oslo/messaging/_drivers/: No such file or directory | 14:45 |
| dhellmann | sileht: I'm not able to reproduce that | 14:45 |
| *** salv-orlando has quit IRC | 14:46 | |
| *** salv-orlando has joined #openstack-oslo | 14:46 | |
| dhellmann | sileht: have you seen this failure before? https://jenkins04.openstack.org/job/gate-oslo.messaging-python33/201/console | 14:47 |
| sileht | dhellmann, yes | 14:47 |
| *** mriedem has joined #openstack-oslo | 14:48 | |
| sileht | dhellmann, I have no clue for now | 14:48 |
| sileht | dhellmann, I think this is a test issue | 14:49 |
| dhellmann | sileht: yeah, I wonder if that test is timing out or something | 14:49 |
| sdague | oslo.messaging question, nova's using the fake driver in unit/functional tests, and it looks like any poll call is not returning anything ever, and just looping until a timeout (which adds a number of delays) | 14:49 |
| dhellmann | sileht: ^^ | 14:51 |
| *** dulek has joined #openstack-oslo | 14:51 | |
| *** pcaruana|off| is now known as pcaruana | 14:51 | |
| sileht | sdague, with master or 1.5.1 ? | 14:52 |
| sdague | 1.5.1 | 14:52 |
| *** zzzeek has joined #openstack-oslo | 14:52 | |
| sdague | I was trying to get to the bottom of why all the tests were taking 5s, it turns out 3s of that is rpcserver.wait() in shutting down services in the cleanup phase because of this fake driver timout | 14:53 |
| sileht | sdague, it should return something when a call/cast/fanout is done | 14:53 |
| sileht | sdague, I have changed that in master, now it returns immediatly | 14:55 |
| sileht | sdague, with eventlet executor | 14:55 |
| sdague | we call .stop() then .wait() | 14:55 |
| *** inc0_ has joined #openstack-oslo | 14:56 | |
| sdague | .wait() seems to run to the full timeout on the fake driver even if nothing is there, right? | 14:56 |
| *** achanda has quit IRC | 14:56 | |
| sdague | or more importantly, when there is nothing to wait for, it doesn't know to end early | 14:56 |
| sileht | sdague, in 1.5.1 the timeout is 1 seconds, in master they are no more timeout | 14:57 |
| sileht | when you call stop, then wait(), once the last callback is done, wait returns | 14:57 |
| sdague | sileht: ok | 14:57 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 14:57 | |
| sdague | how soon is that going to be released? | 14:57 |
| sdague | because > 50% of the execution time of our functional tests right now, is this wait | 14:58 |
| *** inc0 has quit IRC | 14:58 | |
| openstackgerrit | gordon chung proposed openstack/oslo.messaging: Implements notification-dispatcher-filter https://review.openstack.org/77886 | 14:59 |
| *** rpodolyaka2 has quit IRC | 15:00 | |
| dhellmann | sdague: I was going to release messaging with the namespace package changes later today or tomorrow, but we're trying to work around an issue in heat's tests first | 15:00 |
| sileht | sdague, https://github.com/openstack/oslo.messaging/commit/15aa5cbda810ef3f757e9e54280fd8216dc9ef7d | 15:00 |
| *** inc0_ has quit IRC | 15:01 | |
| sileht | dhellmann, forget my pip issue, if it works with the tarball and for you and haypo, I have an issue in my env | 15:01 |
| dhellmann | sileht: yeah, I was assuming that already :-) | 15:01 |
| sdague | sileht: ok cool | 15:02 |
| openstackgerrit | Julien Danjou proposed openstack/oslo.log: Replace RFCSysLogHandler by a syslog() based one https://review.openstack.org/136842 | 15:02 |
| *** arnaud___ has joined #openstack-oslo | 15:03 | |
| *** boris-42 has quit IRC | 15:03 | |
| haypo | sileht: my point is that dhellmann's patch is needed | 15:03 |
| haypo | https://review.openstack.org/#/c/146872/ | 15:04 |
| sileht | haypo, sure | 15:04 |
| haypo | sileht: oh ok, i wasn't sure that i understood you correctly ;) | 15:05 |
| dhellmann | oslo.concurrency 0.4.0 released | 15:07 |
| *** arnaud___ has quit IRC | 15:07 | |
| openstackgerrit | Julien Danjou proposed openstack/tooz: Upgrade to hacking 0.10 https://review.openstack.org/146893 | 15:12 |
| openstackgerrit | Merged openstack/oslo.db: Ensure DBConnectionError is raised on failed revalidate https://review.openstack.org/139738 | 15:13 |
| *** sigmavirus24_awa is now known as sigmavirus24 | 15:15 | |
| *** pblaho has joined #openstack-oslo | 15:16 | |
| dhellmann | viktors: thanks for releasing oslo.db this morning | 15:17 |
| viktors | dhellmann: no problem, thank you for the release yesterday | 15:18 |
| *** e0ne is now known as e0ne_ | 15:18 | |
| viktors | dhellmann: I have a question as for project unittests on Openstack projects - - is there a list of projects where we should ensure, that unittests runs ok before the new oslo.* release? | 15:21 |
| dhellmann | viktors: no, there's no list. I've been using a few of the bigger projects where breaking them is likely to break the gate, but it's just a subset | 15:23 |
| dims__ | viktors: squeaky wheel test? who complains the most :) | 15:24 |
| viktors | dhellmann: me either, but maybe we should define these projects? | 15:24 |
| dhellmann | dims__: pretty much | 15:25 |
| viktors | dims__: maybe, I'm not sure | 15:25 |
| dhellmann | viktors: after this namespace package work is done, I do not expect to be running tests manually before releases | 15:25 |
| viktors | dhellmann: ? | 15:26 |
| dhellmann | viktors: I have only been running the tests because I expect things to break because I am moving the modules around. Smaller patches with API changes are easier to catch as part of the review process | 15:26 |
| *** yamahata has quit IRC | 15:26 | |
| *** pradk has joined #openstack-oslo | 15:28 | |
| *** e0ne_ has quit IRC | 15:29 | |
| *** salv-orlando has quit IRC | 15:30 | |
| viktors | dhellmann: yes, but smaller patches can break unittests/gates as well, so I'm trying to run unittests with oslo.db master before release | 15:30 |
| dhellmann | viktors: we should have API tests in our own test suite, and then not break them | 15:30 |
| *** raildo has quit IRC | 15:31 | |
| viktors | dhellmann: yes, but sometimes we are changing the API | 15:31 |
| *** e0ne has joined #openstack-oslo | 15:32 | |
| dhellmann | viktors: you have to change it without breaking existing users, because you don't have any way to test deployed systems | 15:32 |
| *** pradk has quit IRC | 15:33 | |
| *** raildo has joined #openstack-oslo | 15:33 | |
| *** stevemar has joined #openstack-oslo | 15:34 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 15:34 | |
| viktors | dhellmann: agreed, but it's would be nice to test some changes, to ensure, that all is ok. See https://review.openstack.org/#/c/138215/ for example :) | 15:35 |
| dhellmann | viktors: I'm not saying you're not *allowed* to run tests, just that we need to be careful enough in reviews that it's not *required* for every release | 15:36 |
| *** sigmavirus24_awa is now known as sigmavirus24 | 15:36 | |
| *** dulek has quit IRC | 15:37 | |
| viktors | dhellmann: ok, got it. But just for information - if I'll want to run these tests, what project should I check? | 15:37 |
| dhellmann | viktors: I have been testing nova, cinder, glance, and heat for the namespace package changes | 15:38 |
| viktors | dhellmann: ok, thanks | 15:38 |
| dhellmann | neutron does weird things with the database, so that might be a good one to include | 15:38 |
| viktors | it was surprise for me, that neutron have some db-tests in `functional` tox env | 15:39 |
| viktors | dhellmann: one more thing - what is the best practice to deprecate API in oslo.* libraries? | 15:39 |
| dhellmann | viktors: they need to log that they are deprecated, either using versionutils.deprecated() or harlowja_away's new debtcollector library | 15:42 |
| *** e0ne is now known as e0ne_ | 15:43 | |
| *** pradk has joined #openstack-oslo | 15:43 | |
| viktors | dhellmann: during the what time? | 15:43 |
| dhellmann | for a cycle, at least | 15:44 |
| *** salv-orlando has joined #openstack-oslo | 15:46 | |
| viktors | dhellmann: ok, thanks | 15:52 |
| *** dulek has joined #openstack-oslo | 15:53 | |
| *** e0ne_ has quit IRC | 15:53 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo-incubator: Remove oslo.log code and clean up versionutils API https://review.openstack.org/123868 | 15:53 |
| *** raildo has quit IRC | 15:55 | |
| *** pradk is now known as prad-afk | 16:01 | |
| *** jecarey has joined #openstack-oslo | 16:02 | |
| *** arnaud___ has joined #openstack-oslo | 16:03 | |
| *** inc0 has joined #openstack-oslo | 16:06 | |
| *** ajo has quit IRC | 16:07 | |
| *** raildo has joined #openstack-oslo | 16:07 | |
| *** amotoki has quit IRC | 16:08 | |
| *** inc0_ has joined #openstack-oslo | 16:08 | |
| *** arnaud___ has quit IRC | 16:08 | |
| *** prad-afk has quit IRC | 16:10 | |
| *** dulek has quit IRC | 16:11 | |
| *** inc0 has quit IRC | 16:11 | |
| *** inc0_ has quit IRC | 16:13 | |
| *** rushiagr is now known as rushiagr_away | 16:13 | |
| *** tsekiyama has joined #openstack-oslo | 16:15 | |
| *** lakshmiS has quit IRC | 16:18 | |
| *** zz_sabari is now known as sabari | 16:21 | |
| *** e0ne has joined #openstack-oslo | 16:27 | |
| *** salv-orlando has quit IRC | 16:33 | |
| *** salv-orlando has joined #openstack-oslo | 16:34 | |
| *** e0ne is now known as e0ne_ | 16:40 | |
| *** raildo has quit IRC | 16:42 | |
| *** sabari is now known as zz_sabari | 16:44 | |
| *** zz_jgrimm is now known as jgrimm | 16:48 | |
| openstackgerrit | Merged openstack/oslo.utils: Make setup.cfg packages include oslo.utils https://review.openstack.org/146735 | 16:48 |
| openstackgerrit | Merged openstack/oslo.messaging: fix qpid test issue with eventlet monkey patching https://review.openstack.org/146574 | 16:49 |
| *** salv-orlando has quit IRC | 16:49 | |
| *** e0ne_ has quit IRC | 16:51 | |
| kragniz | dhellmann/other oslo folk: can oslo be added as a project under openstack in launchpad? | 16:54 |
| dims__ | kragniz: there's one - launchpad.net/oslo/ | 16:55 |
| dims__ | kragniz: ah you mean under openstack? | 16:55 |
| *** ihrachyshka has quit IRC | 16:55 | |
| dims__ | kragniz: don't know if it launchpad supports that | 16:55 |
| bnemec | I don't think it can. I seem to recall that a project can't be part of two separate groups in lp. | 16:55 |
| dims__ | 2 levels nested | 16:55 |
| dims__ | right | 16:56 |
| kragniz | hmm, okay | 16:57 |
| kragniz | it's just blueprint links are broken in gerrit at the moment | 16:57 |
| kragniz | like in this one: https://review.openstack.org/#/c/146476/ | 16:57 |
| * kragniz may be doing something wrong, though | 16:57 | |
| *** arnaud___ has joined #openstack-oslo | 16:59 | |
| *** lakshmiS has joined #openstack-oslo | 17:04 | |
| bnemec | kragniz: No, they're just broken. That's been on my todo list for about six months. :-/ | 17:04 |
| kragniz | bnemec: :/ | 17:04 |
| kragniz | if there's something I can do help fix them, just shout | 17:04 |
| bnemec | kragniz: I think step 1 was to get a bug opened with infra. It might be a trivial fix for someone familiar with the code. | 17:05 |
| *** i159 has quit IRC | 17:06 | |
| openstackgerrit | Merged openstack/oslo.i18n: Make setup.cfg packages include oslo.i18n https://review.openstack.org/146733 | 17:07 |
| * kragniz does that | 17:07 | |
| kragniz | excuse to use storyboard! | 17:08 |
| kragniz | wait, they're probably going to wontfix it since we're moving to storyboard :/ | 17:09 |
| *** boris-42 has joined #openstack-oslo | 17:12 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.concurrency: Allow callers to disable encoding for execute() https://review.openstack.org/146932 | 17:18 |
| dhellmann | bnemec: ^^ | 17:19 |
| bnemec | dhellmann: We still broke backward compatibility then though. :-( | 17:22 |
| bnemec | Unless we default encoding to None too. | 17:22 |
| dhellmann | bnemec: yeah | 17:22 |
| bnemec | Also, that should probably wrap the entire block. Right now it just does basically a = b, b = a when it's None. | 17:23 |
| dhellmann | dims, jd__: ^^ | 17:23 |
| dhellmann | https://review.openstack.org/#/c/141206/ | 17:23 |
| bnemec | dhellmann: Could we EAFP it and just swallow the exception? | 17:23 |
| dhellmann | EAFP? | 17:24 |
| bnemec | Easier to as forgiveness than permission | 17:24 |
| bnemec | *ask | 17:24 |
| dhellmann | swallowing the exception won't return the data, though | 17:24 |
| dhellmann | what we probably ought to do is make None the default encoding, but that is going to make the python 3 work harder | 17:25 |
| bnemec | dhellmann: I was thinking something like this: http://paste.openstack.org/show/157182/ | 17:26 |
| bnemec | result is still set to the original data that way, so it should work as it did before the decode change. | 17:27 |
| dhellmann | that has a chance of returning a byte string up to the caller, though, which could break other things in weird subtle ways | 17:27 |
| *** noelbk has joined #openstack-oslo | 17:27 | |
| *** zz_sabari is now known as sabari | 17:28 | |
| bnemec | I don't think we can avoid that. | 17:28 |
| bnemec | Checking for encoding = None leaves the data untouched too. | 17:28 |
| bnemec | I really don't understand this stuff at all though. I've never been able to wrap my head around the python encoding/decoding logic. | 17:30 |
| dhellmann | bnemec: right, but if the caller has passed encoding=None then they are expecting binary output | 17:31 |
| dhellmann | if we just sometimes return a byte string, it can be a surprise when they get it | 17:33 |
| bnemec | dhellmann: So, I'm not sure I understand how this is supposed to work. We don't control what comes back from Popen.communicate() | 17:33 |
| bnemec | So it seems to me that this is just wrong. | 17:33 |
| bnemec | Apparently the mocks changing in https://review.openstack.org/#/c/141206/1/oslo_concurrency/tests/unit/test_processutils.py was changing the behavior from what actually happens. | 17:35 |
| bnemec | Maybe the py3 behavior just differs? | 17:35 |
| dhellmann | maybe | 17:36 |
| *** noelbk has quit IRC | 17:36 | |
| *** jaypipes has quit IRC | 17:36 | |
| dhellmann | well, nova was breaking in python 2 | 17:36 |
| dhellmann | you know, the more I think about it, the more I'm inclined to just revert that patch and let haypo and jd__ figure it out | 17:36 |
| bnemec | Yeah, because python 2 returns a str, and this code was written for what python 3 does. | 17:36 |
| bnemec | *for whatever python 3 does | 17:36 |
| bnemec | Which is apparently different. | 17:36 |
| bnemec | +1 to revert | 17:36 |
| bnemec | It's clearly broken, and we don't have an immediate fix. | 17:37 |
| bnemec | And I don't understand it. :-) | 17:37 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.concurrency: Revert "Port processutils to Python 3" https://review.openstack.org/146940 | 17:38 |
| dhellmann | let's see if that's clean | 17:38 |
| *** rushiagr_away is now known as rushiagr | 17:40 | |
| *** e0ne has joined #openstack-oslo | 17:41 | |
| *** e0ne has quit IRC | 17:42 | |
| *** jaypipes has joined #openstack-oslo | 17:45 | |
| bnemec | dhellmann: Yeah, Popen.communicate returns different types on py2 and py3: http://paste.openstack.org/show/157204/ | 17:45 |
| bnemec | So we'll need a new version of the patch that handles both. | 17:46 |
| dhellmann | bnemec: a py2 str and py3 byte are mostly the same thing (there's no exact same version of that) | 17:46 |
| dhellmann | well, my added test fails on 2.6: https://jenkins05.openstack.org/job/gate-oslo.concurrency-python26/82/console | 17:47 |
| dhellmann | it works locally on 2.6, though | 17:47 |
| dims__ | ouch | 17:48 |
| *** salv-orlando has joined #openstack-oslo | 17:50 | |
| dhellmann | yeah, I think we're going to just have to go with reverting the change and fixing it when there's less time pressure | 17:51 |
| bnemec | +1 | 17:51 |
| bnemec | I have no idea idea what's going on. :-/ | 17:51 |
| dhellmann | yeah, I think having a flag is fine but we need the default to do something safer than what this version does | 17:52 |
| dhellmann | looks like my fix for heat in oslo.messaging failed under python 3 | 17:53 |
| *** denis_makogon has quit IRC | 17:54 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.concurrency: Revert "Port processutils to Python 3" https://review.openstack.org/146940 | 17:54 |
| dhellmann | updated to include the bug # in the commit message ^^ | 17:55 |
| *** salv-orlando has quit IRC | 17:55 | |
| jd__ | you could just cap oslo.utils to the old version? | 18:11 |
| *** ihrachyshka has joined #openstack-oslo | 18:14 | |
| *** mtanino has joined #openstack-oslo | 18:18 | |
| *** rushiagr is now known as rushiagr_away | 18:28 | |
| *** ajo has joined #openstack-oslo | 18:31 | |
| *** salv-orlando has joined #openstack-oslo | 18:34 | |
| *** salv-orlando has quit IRC | 18:38 | |
| dhellmann | jd__ we will, but we're going to release 0.4.1 without this change while you and haypo figure out a way to do this without changing the APi of the function (maybe just a different default encoding, for example) | 18:38 |
| *** harlowja_away is now known as harlowja | 18:39 | |
| *** sabari is now known as zz_sabari | 18:41 | |
| *** salv-orlando has joined #openstack-oslo | 18:42 | |
| *** salv-orlando has quit IRC | 18:42 | |
| *** salv-orlando has joined #openstack-oslo | 18:45 | |
| *** salv-orlando has quit IRC | 18:48 | |
| harlowja | viktors debtcollector stuff should be avail hopefully later this week (or maybe next); just going through infra changes... | 18:48 |
| harlowja | https://review.openstack.org/#/c/146224/ and https://review.openstack.org/#/c/146225/ | 18:48 |
| *** noelbk has joined #openstack-oslo | 18:50 | |
| *** e0ne has joined #openstack-oslo | 18:53 | |
| *** e0ne has quit IRC | 18:59 | |
| *** rpodolyaka2 has joined #openstack-oslo | 19:00 | |
| *** zz_sabari is now known as sabari | 19:00 | |
| *** alexpilotti has quit IRC | 19:01 | |
| *** sabari is now known as zz_sabari | 19:02 | |
| *** ihrachyshka has quit IRC | 19:02 | |
| *** zz_sabari is now known as sabari | 19:03 | |
| *** jecarey has quit IRC | 19:04 | |
| *** jecarey has joined #openstack-oslo | 19:05 | |
| *** rpodolyaka2 has quit IRC | 19:06 | |
| *** rpodolyaka2 has joined #openstack-oslo | 19:06 | |
| *** pblaho has quit IRC | 19:08 | |
| *** dtantsur is now known as dtantsur|afk | 19:13 | |
| *** yamahata has joined #openstack-oslo | 19:19 | |
| *** ajo has quit IRC | 19:23 | |
| openstackgerrit | Steve McLellan proposed openstack-dev/pbr: Use diff --exit-code instead of --quiet https://review.openstack.org/146958 | 19:23 |
| *** lakshmiS has quit IRC | 19:24 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Use oslo.utils reflection for class name https://review.openstack.org/146959 | 19:24 |
| *** achanda has joined #openstack-oslo | 19:25 | |
| *** crc32 has joined #openstack-oslo | 19:27 | |
| *** sabari is now known as zz_sabari | 19:38 | |
| *** salv-orlando has joined #openstack-oslo | 19:38 | |
| *** zzzeek has quit IRC | 19:43 | |
| *** zz_sabari is now known as sabari | 19:43 | |
| *** zzzeek has joined #openstack-oslo | 19:45 | |
| *** zzzeek has quit IRC | 19:45 | |
| *** ajo has joined #openstack-oslo | 19:46 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Use monotonic time when/if available https://review.openstack.org/144212 | 19:47 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Use monotonic time when/if available https://review.openstack.org/144212 | 19:48 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Move implementation(s) to there own sections https://review.openstack.org/143249 | 19:51 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Move the jobboard/job bases to a jobboard/base module https://review.openstack.org/143246 | 19:51 |
| *** achanda has quit IRC | 19:52 | |
| *** rpodolyaka2 has quit IRC | 19:55 | |
| *** achanda has joined #openstack-oslo | 19:55 | |
| *** sabari is now known as zz_sabari | 19:57 | |
| *** nikhil_k has joined #openstack-oslo | 19:58 | |
| sigmavirus24 | was there a bug recently in sqlalchemy-migrate (in case anyone knows)? | 19:58 |
| *** isviridov_away is now known as isviridov | 19:59 | |
| *** jecarey has quit IRC | 20:02 | |
| *** yassine has quit IRC | 20:02 | |
| *** jecarey has joined #openstack-oslo | 20:03 | |
| dims__ | sigmavirus24: this one? https://bugs.launchpad.net/nova/+bug/1368391 | 20:07 |
| sigmavirus24 | dims__: no. We're seeing http://paste.openstack.org/show/157276/ with 0.9.4 | 20:08 |
| dims__ | y, looks new | 20:09 |
| sigmavirus24 | Yeah. | 20:10 |
| dims__ | checking logstash | 20:11 |
| *** zzzeek has joined #openstack-oslo | 20:12 | |
| dims__ | mriedem: ^^^ | 20:13 |
| dims__ | mriedem: looking at the 0.9.4 announcement, is there something in 0.9.4 which may cause sigmavirus24's paste? | 20:14 |
| *** ajo has quit IRC | 20:14 | |
| sigmavirus24 | dims__: 0.9.1 doesn't have this problem | 20:15 |
| haypo | dhellmann: hi | 20:15 |
| dims__ | sigmavirus24: we went from 0.9.2 to 0.9.4 | 20:15 |
| sigmavirus24 | so I suspect it's something in 0.9.3 (0.9.4 has 1 commit different dims__ ) | 20:15 |
| *** david-lyle has joined #openstack-oslo | 20:16 | |
| sigmavirus24 | yeah, 0.9.3 was removed from PyPI entirely. and looking at the comparison between tags, 0.9.3 and 0.9.4 just have a commit to fix the setup.cfg | 20:16 |
| sigmavirus24 | so I have to look at 0.9.2..0.9.3 I think | 20:16 |
| *** rpodolyaka2 has joined #openstack-oslo | 20:16 | |
| *** achanda has quit IRC | 20:16 | |
| nikhil_k | filed this bug https://bugs.launchpad.net/sqlalchemy-migrate/+bug/1410494 | 20:18 |
| *** ajo has joined #openstack-oslo | 20:21 | |
| dims__ | sigmavirus24: this one? https://github.com/stackforge/sqlalchemy-migrate/commit/938757e7aa581646a6a501426a5dae84ebe5631f | 20:21 |
| sigmavirus24 | looks plausible dims__ | 20:22 |
| sigmavirus24 | Thanks! | 20:22 |
| dims__ | sigmavirus24: the rest seem to be ibm db2 related | 20:22 |
| dims__ | cool | 20:23 |
| sigmavirus24 | yeah | 20:26 |
| *** achanda has joined #openstack-oslo | 20:30 | |
| *** salv-orlando has quit IRC | 20:36 | |
| dhellmann | haypo: hi, I'm in a meeting so may be slow to reply | 20:40 |
| haypo | dhellmann: i'm writing a change which revert the previous behaviour on Python 2 but keep Python 3 compatibility | 20:40 |
| haypo | dhellmann: right now, i'm trying to understand why the issue was not noticed by unit tests | 20:41 |
| haypo | oh, i remember that there was an issue with mask_password() | 20:43 |
| *** boris-42 has quit IRC | 20:43 | |
| haypo | mask_password() tries to decode the message from the default python encoding (ex: ascii on python 2), but... it ignores decoding error | 20:44 |
| haypo | this hack (ignore UnicodeDecodeError) works on python 2, not on python 3 | 20:44 |
| haypo | i tried to have a reliable behaviour on all cases (python 2 & 3, ascii and non-ascii output) | 20:45 |
| mriedem | dims__: sigmavirus24: just got back | 20:47 |
| mriedem | so https://github.com/stackforge/sqlalchemy-migrate/commit/938757e7aa581646a6a501426a5dae84ebe5631f was meant to fix the bug in 0.9.2 | 20:47 |
| dhellmann | haypo: I don't think we can have that function behave differently under 2 and 3 | 20:48 |
| haypo | dhellmann: i propose a change to modify mask_password(), but it was rejected | 20:49 |
| haypo | i have to find it to remember why :) | 20:49 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add executor statistics https://review.openstack.org/146382 | 20:49 |
| haypo | https://review.openstack.org/#/c/137600/ | 20:50 |
| *** zz_sabari is now known as sabari | 20:50 | |
| sigmavirus24 | mriedem: Yeah. That was evident from the commit message. As I commented on 1410494, this may have been present even before that, but wasn't known since 0.9.2 was blacklisted in g-r and this fix surfaced a new issue | 20:53 |
| *** salv-orlando has joined #openstack-oslo | 20:57 | |
| mriedem | http://goo.gl/epzB9c | 20:57 |
| mriedem | yeah, damn it | 20:57 |
| *** isviridov is now known as isviridov_away | 20:58 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add executor statistics https://review.openstack.org/146382 | 21:02 |
| *** achanda has quit IRC | 21:03 | |
| *** ajo has quit IRC | 21:05 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 21:06 | |
| *** david-ly_ has joined #openstack-oslo | 21:07 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 21:08 | |
| *** achanda has joined #openstack-oslo | 21:08 | |
| *** david-lyle has quit IRC | 21:09 | |
| sigmavirus24 | mriedem: how difficult would it be to set up jobs for sqlam that run against nova/glance/etc. ? | 21:09 |
| mriedem | sigmavirus24: probably the same level of difficulty as it would be for all of the oslo libs to do that | 21:10 |
| mriedem | i'm not sure how much people have looked at that before | 21:10 |
| sigmavirus24 | I mean doesn't even have to run their full suite | 21:10 |
| sigmavirus24 | Just something representative | 21:10 |
| * sigmavirus24 is curious now | 21:10 | |
| mriedem | i'd just be looking for unit tests | 21:11 |
| mriedem | gate-nova-sqla-migrate-python27, something like that | 21:11 |
| *** rpodolyaka2 has quit IRC | 21:11 | |
| *** achanda has quit IRC | 21:12 | |
| *** david-ly_ has quit IRC | 21:12 | |
| *** rpodolyaka2 has joined #openstack-oslo | 21:12 | |
| sigmavirus24 | yeah | 21:13 |
| *** rpodolyaka2 has quit IRC | 21:14 | |
| *** e0ne has joined #openstack-oslo | 21:14 | |
| *** ajo has joined #openstack-oslo | 21:19 | |
| openstackgerrit | Sean Dague proposed openstack-dev/pbr: remove integration test, it now lives in requirements https://review.openstack.org/146982 | 21:24 |
| *** dims__ has quit IRC | 21:25 | |
| *** dims__ has joined #openstack-oslo | 21:26 | |
| jogo | dhellmann: have you seen http://logs.openstack.org/26/145626/2/check/gate-nova-python27/b350bbc/console.html#_2015-01-13_17_13_36_291 | 21:27 |
| *** dims__ has quit IRC | 21:28 | |
| haypo | jogo: hi. it looks like the regression https://bugs.launchpad.net/oslo.concurrency/+bug/1410348 | 21:28 |
| *** dims__ has joined #openstack-oslo | 21:28 | |
| mriedem | jogo: yes | 21:28 |
| mriedem | covered | 21:28 |
| openstackgerrit | Victor Stinner proposed openstack/oslo.concurrency: Don't decode stdout/stderr on Python 2 https://review.openstack.org/146984 | 21:29 |
| *** burgobianco has quit IRC | 21:32 | |
| *** harlowja has quit IRC | 21:32 | |
| *** haypo has quit IRC | 21:32 | |
| *** sirushti has quit IRC | 21:32 | |
| *** rodrigods has quit IRC | 21:32 | |
| *** lifeless has quit IRC | 21:32 | |
| *** ajo has quit IRC | 21:32 | |
| *** e0ne has quit IRC | 21:32 | |
| *** SergeyLukjanov has quit IRC | 21:32 | |
| *** gordc has quit IRC | 21:32 | |
| *** jeffreycoho has quit IRC | 21:32 | |
| *** eezhova has quit IRC | 21:32 | |
| *** dims__ has quit IRC | 21:32 | |
| *** salv-orlando has quit IRC | 21:32 | |
| *** yamahata has quit IRC | 21:32 | |
| *** kgiusti has quit IRC | 21:32 | |
| *** kragniz has quit IRC | 21:32 | |
| *** SlickNik has quit IRC | 21:32 | |
| *** mtreinish has quit IRC | 21:32 | |
| *** bogdando has quit IRC | 21:32 | |
| *** amrith has quit IRC | 21:32 | |
| *** eikke has quit IRC | 21:32 | |
| *** subscope has quit IRC | 21:33 | |
| *** bknudson has quit IRC | 21:33 | |
| *** sheeprine has quit IRC | 21:33 | |
| *** crc32 has quit IRC | 21:33 | |
| *** mriedem has quit IRC | 21:33 | |
| *** palendae has quit IRC | 21:33 | |
| *** sdague has quit IRC | 21:33 | |
| *** hogepodge has quit IRC | 21:33 | |
| *** eikke has joined #openstack-oslo | 21:34 | |
| *** amrith has joined #openstack-oslo | 21:34 | |
| *** lifeless has joined #openstack-oslo | 21:34 | |
| *** rodrigods has joined #openstack-oslo | 21:34 | |
| *** bogdando has joined #openstack-oslo | 21:34 | |
| *** sirushti has joined #openstack-oslo | 21:34 | |
| *** mtreinish has joined #openstack-oslo | 21:34 | |
| *** SlickNik has joined #openstack-oslo | 21:34 | |
| *** kragniz has joined #openstack-oslo | 21:34 | |
| *** eezhova has joined #openstack-oslo | 21:34 | |
| *** haypo has joined #openstack-oslo | 21:34 | |
| *** harlowja has joined #openstack-oslo | 21:34 | |
| *** burgobianco has joined #openstack-oslo | 21:34 | |
| *** jeffreycoho has joined #openstack-oslo | 21:34 | |
| *** kgiusti has joined #openstack-oslo | 21:34 | |
| *** gordc has joined #openstack-oslo | 21:34 | |
| *** SergeyLukjanov has joined #openstack-oslo | 21:34 | |
| *** yamahata has joined #openstack-oslo | 21:34 | |
| *** salv-orlando has joined #openstack-oslo | 21:34 | |
| *** e0ne has joined #openstack-oslo | 21:34 | |
| *** ajo has joined #openstack-oslo | 21:34 | |
| *** dims__ has joined #openstack-oslo | 21:34 | |
| *** crc32 has joined #openstack-oslo | 21:34 | |
| *** mriedem has joined #openstack-oslo | 21:34 | |
| *** subscope has joined #openstack-oslo | 21:34 | |
| *** bknudson has joined #openstack-oslo | 21:34 | |
| *** palendae has joined #openstack-oslo | 21:34 | |
| *** sdague has joined #openstack-oslo | 21:34 | |
| *** sheeprine has joined #openstack-oslo | 21:34 | |
| *** hogepodge has joined #openstack-oslo | 21:34 | |
| *** burgobianco has quit IRC | 21:35 | |
| *** HenryG has quit IRC | 21:35 | |
| *** tsekiyama has quit IRC | 21:36 | |
| *** rpodolyaka1 has quit IRC | 21:36 | |
| *** shardy has quit IRC | 21:36 | |
| *** dstanek has quit IRC | 21:36 | |
| *** burgobianco has joined #openstack-oslo | 21:36 | |
| *** tsekiyama has joined #openstack-oslo | 21:37 | |
| *** rpodolyaka1 has joined #openstack-oslo | 21:37 | |
| *** shardy has joined #openstack-oslo | 21:37 | |
| *** dstanek has joined #openstack-oslo | 21:37 | |
| *** HenryG has joined #openstack-oslo | 21:37 | |
| *** jaosorior has quit IRC | 21:38 | |
| *** sabari has quit IRC | 21:38 | |
| *** sreshetnyak has quit IRC | 21:38 | |
| *** bnemec has quit IRC | 21:38 | |
| *** tsufiev has quit IRC | 21:38 | |
| *** frickler has quit IRC | 21:38 | |
| *** krotscheck has quit IRC | 21:38 | |
| *** redrobot has quit IRC | 21:38 | |
| *** therve has quit IRC | 21:38 | |
| *** ekarlso- has quit IRC | 21:38 | |
| *** cburgess has quit IRC | 21:38 | |
| *** jogo has quit IRC | 21:38 | |
| *** flaper87 has quit IRC | 21:39 | |
| *** flaper87 has joined #openstack-oslo | 21:39 | |
| *** sabari has joined #openstack-oslo | 21:40 | |
| *** sreshetnyak has joined #openstack-oslo | 21:40 | |
| *** bnemec has joined #openstack-oslo | 21:40 | |
| *** tsufiev has joined #openstack-oslo | 21:40 | |
| *** frickler has joined #openstack-oslo | 21:40 | |
| *** krotscheck has joined #openstack-oslo | 21:40 | |
| *** therve has joined #openstack-oslo | 21:40 | |
| *** ekarlso- has joined #openstack-oslo | 21:40 | |
| *** cburgess has joined #openstack-oslo | 21:40 | |
| *** jogo has joined #openstack-oslo | 21:40 | |
| *** redrobot has joined #openstack-oslo | 21:40 | |
| *** achanda has joined #openstack-oslo | 21:41 | |
| *** redrobot is now known as Guest80861 | 21:41 | |
| *** david-lyle has joined #openstack-oslo | 21:41 | |
| *** isviridov_away has quit IRC | 21:42 | |
| *** Guest80861 is now known as redrobot | 21:42 | |
| *** isviridov_away has joined #openstack-oslo | 21:42 | |
| *** mfedosin has quit IRC | 21:43 | |
| *** jgrimm has quit IRC | 21:43 | |
| *** tristanC has quit IRC | 21:43 | |
| *** mfedosin has joined #openstack-oslo | 21:43 | |
| *** jgrimm has joined #openstack-oslo | 21:43 | |
| *** tristanC has joined #openstack-oslo | 21:43 | |
| *** achanda has quit IRC | 21:44 | |
| *** noelbk has quit IRC | 21:44 | |
| *** openstackgerrit has quit IRC | 21:44 | |
| *** nikhil_k has quit IRC | 21:44 | |
| *** amaurymedeiros has quit IRC | 21:44 | |
| *** zzzeek has quit IRC | 21:44 | |
| *** kbyrne has quit IRC | 21:44 | |
| *** xek has quit IRC | 21:44 | |
| *** greghaynes has quit IRC | 21:44 | |
| *** fnordahl has quit IRC | 21:44 | |
| *** toabctl has quit IRC | 21:44 | |
| *** jd__ has quit IRC | 21:44 | |
| *** mfedosin has quit IRC | 21:44 | |
| *** jgrimm has quit IRC | 21:44 | |
| *** tristanC has quit IRC | 21:44 | |
| *** isviridov_away has quit IRC | 21:44 | |
| *** sabari has quit IRC | 21:44 | |
| *** sreshetnyak has quit IRC | 21:44 | |
| *** bnemec has quit IRC | 21:45 | |
| *** tsufiev has quit IRC | 21:45 | |
| *** frickler has quit IRC | 21:45 | |
| *** krotscheck has quit IRC | 21:45 | |
| *** therve has quit IRC | 21:45 | |
| *** ekarlso- has quit IRC | 21:45 | |
| *** cburgess has quit IRC | 21:45 | |
| *** jogo has quit IRC | 21:45 | |
| *** tsekiyama has quit IRC | 21:45 | |
| *** rpodolyaka1 has quit IRC | 21:45 | |
| *** shardy has quit IRC | 21:45 | |
| *** dstanek has quit IRC | 21:45 | |
| *** david-lyle has quit IRC | 21:45 | |
| *** harlowja has quit IRC | 21:45 | |
| *** haypo has quit IRC | 21:45 | |
| *** sirushti has quit IRC | 21:45 | |
| *** rodrigods has quit IRC | 21:45 | |
| *** lifeless has quit IRC | 21:45 | |
| *** ajo has quit IRC | 21:45 | |
| *** e0ne has quit IRC | 21:45 | |
| *** SergeyLukjanov has quit IRC | 21:45 | |
| *** gordc has quit IRC | 21:45 | |
| *** jeffreycoho has quit IRC | 21:45 | |
| *** eezhova has quit IRC | 21:45 | |
| *** HenryG has quit IRC | 21:45 | |
| *** dims__ has quit IRC | 21:45 | |
| *** salv-orlando has quit IRC | 21:45 | |
| *** yamahata has quit IRC | 21:45 | |
| *** kgiusti has quit IRC | 21:45 | |
| *** kragniz has quit IRC | 21:45 | |
| *** SlickNik has quit IRC | 21:45 | |
| *** mtreinish has quit IRC | 21:45 | |
| *** bogdando has quit IRC | 21:45 | |
| *** amrith has quit IRC | 21:45 | |
| *** eikke has quit IRC | 21:45 | |
| *** subscope has quit IRC | 21:45 | |
| *** bknudson has quit IRC | 21:45 | |
| *** sheeprine has quit IRC | 21:45 | |
| *** crc32 has quit IRC | 21:45 | |
| *** mriedem has quit IRC | 21:45 | |
| *** palendae has quit IRC | 21:45 | |
| *** sdague has quit IRC | 21:45 | |
| *** hogepodge has quit IRC | 21:45 | |
| *** jaypipes has quit IRC | 21:45 | |
| *** stevemar has quit IRC | 21:46 | |
| *** otherwiseguy has quit IRC | 21:46 | |
| *** jraim has quit IRC | 21:46 | |
| *** lbragstad has quit IRC | 21:46 | |
| *** russellb has quit IRC | 21:46 | |
| *** dhellmann has quit IRC | 21:46 | |
| *** pcaruana has quit IRC | 21:46 | |
| *** dtantsur|afk has quit IRC | 21:46 | |
| *** rharwood has quit IRC | 21:46 | |
| *** gus has quit IRC | 21:46 | |
| *** gothicmindfood has quit IRC | 21:46 | |
| *** anteaya has quit IRC | 21:46 | |
| *** jamespage has quit IRC | 21:46 | |
| *** ozamiatin has quit IRC | 21:46 | |
| *** dougwig has quit IRC | 21:46 | |
| *** JoshNang has quit IRC | 21:46 | |
| *** ttx has quit IRC | 21:46 | |
| *** sigmavirus24 has quit IRC | 21:46 | |
| *** clif_h has quit IRC | 21:46 | |
| *** ujjain has quit IRC | 21:46 | |
| *** d0ugal has quit IRC | 21:46 | |
| *** rushiagr_away has quit IRC | 21:46 | |
| *** BAKfr has quit IRC | 21:46 | |
| *** hockeynut has quit IRC | 21:46 | |
| *** morganfainberg has quit IRC | 21:46 | |
| *** redrobot has quit IRC | 21:46 | |
| *** jecarey has quit IRC | 21:46 | |
| *** wendar has quit IRC | 21:46 | |
| *** andreykurilin1 has quit IRC | 21:46 | |
| *** flaper87 has quit IRC | 21:46 | |
| *** openstack has joined #openstack-oslo | 21:47 | |
| *** burgobianco has joined #openstack-oslo | 21:51 | |
| *** jaosorior has joined #openstack-oslo | 21:51 | |
| *** david-lyle has joined #openstack-oslo | 21:51 | |
| *** tristanC has joined #openstack-oslo | 21:51 | |
| *** jgrimm has joined #openstack-oslo | 21:51 | |
| *** mfedosin has joined #openstack-oslo | 21:51 | |
| *** isviridov_away has joined #openstack-oslo | 21:51 | |
| *** redrobot has joined #openstack-oslo | 21:51 | |
| *** jogo has joined #openstack-oslo | 21:51 | |
| *** cburgess has joined #openstack-oslo | 21:51 | |
| *** ekarlso- has joined #openstack-oslo | 21:51 | |
| *** therve has joined #openstack-oslo | 21:51 | |
| *** krotscheck has joined #openstack-oslo | 21:51 | |
| *** frickler has joined #openstack-oslo | 21:51 | |
| *** tsufiev has joined #openstack-oslo | 21:51 | |
| *** bnemec has joined #openstack-oslo | 21:51 | |
| *** sreshetnyak has joined #openstack-oslo | 21:51 | |
| *** sabari has joined #openstack-oslo | 21:51 | |
| *** HenryG has joined #openstack-oslo | 21:51 | |
| *** dstanek has joined #openstack-oslo | 21:51 | |
| *** shardy has joined #openstack-oslo | 21:51 | |
| *** rpodolyaka1 has joined #openstack-oslo | 21:51 | |
| *** tsekiyama has joined #openstack-oslo | 21:51 | |
| *** hogepodge has joined #openstack-oslo | 21:51 | |
| *** sheeprine has joined #openstack-oslo | 21:51 | |
| *** sdague has joined #openstack-oslo | 21:51 | |
| *** palendae has joined #openstack-oslo | 21:51 | |
| *** bknudson has joined #openstack-oslo | 21:51 | |
| *** subscope has joined #openstack-oslo | 21:51 | |
| *** mriedem has joined #openstack-oslo | 21:51 | |
| *** crc32 has joined #openstack-oslo | 21:51 | |
| *** dims__ has joined #openstack-oslo | 21:51 | |
| *** ajo has joined #openstack-oslo | 21:51 | |
| *** e0ne has joined #openstack-oslo | 21:51 | |
| *** salv-orlando has joined #openstack-oslo | 21:51 | |
| *** yamahata has joined #openstack-oslo | 21:51 | |
| *** SergeyLukjanov has joined #openstack-oslo | 21:51 | |
| *** gordc has joined #openstack-oslo | 21:51 | |
| *** kgiusti has joined #openstack-oslo | 21:51 | |
| *** jeffreycoho has joined #openstack-oslo | 21:51 | |
| *** harlowja has joined #openstack-oslo | 21:51 | |
| *** haypo has joined #openstack-oslo | 21:51 | |
| *** eezhova has joined #openstack-oslo | 21:51 | |
| *** kragniz has joined #openstack-oslo | 21:51 | |
| *** SlickNik has joined #openstack-oslo | 21:51 | |
| *** mtreinish has joined #openstack-oslo | 21:51 | |
| *** sirushti has joined #openstack-oslo | 21:51 | |
| *** bogdando has joined #openstack-oslo | 21:51 | |
| *** rodrigods has joined #openstack-oslo | 21:51 | |
| *** lifeless has joined #openstack-oslo | 21:51 | |
| *** amrith has joined #openstack-oslo | 21:51 | |
| *** eikke has joined #openstack-oslo | 21:51 | |
| *** zzzeek has joined #openstack-oslo | 21:51 | |
| *** jecarey has joined #openstack-oslo | 21:51 | |
| *** jaypipes has joined #openstack-oslo | 21:51 | |
| *** stevemar has joined #openstack-oslo | 21:51 | |
| *** kbyrne has joined #openstack-oslo | 21:51 | |
| *** otherwiseguy has joined #openstack-oslo | 21:51 | |
| *** jraim has joined #openstack-oslo | 21:51 | |
| *** russellb has joined #openstack-oslo | 21:51 | |
| *** lbragstad has joined #openstack-oslo | 21:51 | |
| *** wendar has joined #openstack-oslo | 21:51 | |
| *** dhellmann has joined #openstack-oslo | 21:51 | |
| *** pcaruana has joined #openstack-oslo | 21:51 | |
| *** xek has joined #openstack-oslo | 21:51 | |
| *** dtantsur|afk has joined #openstack-oslo | 21:51 | |
| *** rharwood has joined #openstack-oslo | 21:51 | |
| *** andreykurilin1 has joined #openstack-oslo | 21:51 | |
| *** gus has joined #openstack-oslo | 21:51 | |
| *** jamespage has joined #openstack-oslo | 21:51 | |
| *** greghaynes has joined #openstack-oslo | 21:51 | |
| *** fnordahl has joined #openstack-oslo | 21:51 | |
| *** flaper87 has joined #openstack-oslo | 21:51 | |
| *** gothicmindfood has joined #openstack-oslo | 21:51 | |
| *** anteaya has joined #openstack-oslo | 21:51 | |
| *** dougwig has joined #openstack-oslo | 21:51 | |
| *** JoshNang has joined #openstack-oslo | 21:51 | |
| *** toabctl has joined #openstack-oslo | 21:51 | |
| *** ttx has joined #openstack-oslo | 21:51 | |
| *** ozamiatin has joined #openstack-oslo | 21:51 | |
| *** sigmavirus24 has joined #openstack-oslo | 21:51 | |
| *** clif_h has joined #openstack-oslo | 21:51 | |
| *** ujjain has joined #openstack-oslo | 21:51 | |
| *** rushiagr_away has joined #openstack-oslo | 21:51 | |
| *** d0ugal has joined #openstack-oslo | 21:51 | |
| *** jd__ has joined #openstack-oslo | 21:51 | |
| *** BAKfr has joined #openstack-oslo | 21:51 | |
| *** hockeynut has joined #openstack-oslo | 21:51 | |
| *** morganfainberg has joined #openstack-oslo | 21:51 | |
| *** david-lyle has quit IRC | 21:51 | |
| *** david-lyle has joined #openstack-oslo | 21:51 | |
| *** jaosorior has quit IRC | 21:51 | |
| *** jaosorior has joined #openstack-oslo | 21:51 | |
| zzzeek | sdague: this looks like the issue where there were BEGIN statements inside of .sql scripts and we were filtering them out. but maybe not | 21:51 |
| mriedem | https://review.openstack.org/#/c/110611/ | 21:51 |
| *** arnaud___ has quit IRC | 21:51 | |
| mriedem | zzzeek: this is ihar's glance change https://review.openstack.org/#/c/121033/ | 21:51 |
| zzzeek | mriedem: wasnt there another one that looked to exclude “BEGIN” ? | 21:51 |
| mriedem | zzzeek: yeah, that's https://review.openstack.org/#/c/121517/ | 21:51 |
| mriedem | zzzeek: i verified ^ was ok with nova unit tests | 21:51 |
| *** zhiyan has quit IRC | 21:52 | |
| *** zhiyan has joined #openstack-oslo | 21:52 | |
| mriedem | but it still fails on glance unit tests | 21:52 |
| mriedem | hence pin-ageddon https://review.openstack.org/#/c/146975/ | 21:52 |
| zzzeek | mriedem: so are we at the point where we dont understand the current failures ? | 21:52 |
| mriedem | i'm trying to recreate the glance UT failures locally | 21:52 |
| mriedem | this is the error though: http://logs.openstack.org/53/146953/1/check/gate-glance-python27/b87b2b8/console.html#_2015-01-13_19_49_37_989 | 21:52 |
| *** jaypipes has quit IRC | 21:53 | |
| *** stevemar has quit IRC | 21:53 | |
| *** otherwiseguy has quit IRC | 21:53 | |
| *** jraim has quit IRC | 21:53 | |
| *** lbragstad has quit IRC | 21:53 | |
| *** russellb has quit IRC | 21:53 | |
| *** dhellmann has quit IRC | 21:53 | |
| *** pcaruana has quit IRC | 21:53 | |
| *** dtantsur|afk has quit IRC | 21:53 | |
| *** rharwood has quit IRC | 21:53 | |
| *** gus has quit IRC | 21:53 | |
| *** gothicmindfood has quit IRC | 21:53 | |
| *** anteaya has quit IRC | 21:53 | |
| *** jamespage has quit IRC | 21:53 | |
| *** ozamiatin has quit IRC | 21:53 | |
| *** jaypipes has joined #openstack-oslo | 21:53 | |
| *** stevemar has joined #openstack-oslo | 21:53 | |
| *** otherwiseguy has joined #openstack-oslo | 21:53 | |
| *** jraim has joined #openstack-oslo | 21:53 | |
| *** russellb has joined #openstack-oslo | 21:53 | |
| *** lbragstad has joined #openstack-oslo | 21:53 | |
| *** dhellmann has joined #openstack-oslo | 21:53 | |
| *** pcaruana has joined #openstack-oslo | 21:53 | |
| *** dtantsur|afk has joined #openstack-oslo | 21:53 | |
| *** rharwood has joined #openstack-oslo | 21:53 | |
| *** gus has joined #openstack-oslo | 21:53 | |
| *** jamespage has joined #openstack-oslo | 21:53 | |
| *** gothicmindfood has joined #openstack-oslo | 21:53 | |
| *** anteaya has joined #openstack-oslo | 21:53 | |
| *** ozamiatin has joined #openstack-oslo | 21:53 | |
| mriedem | so the glance change https://review.openstack.org/#/c/121033/ will probably fix that, but if you have glance in juno w/o that change but migrate 0.9.4, kaboom | 21:54 |
| mriedem | we don't cap migrate's version in stable/juno | 21:54 |
| *** dougwig has quit IRC | 21:54 | |
| *** JoshNang has quit IRC | 21:54 | |
| *** ttx has quit IRC | 21:54 | |
| *** sigmavirus24 has quit IRC | 21:54 | |
| *** clif_h has quit IRC | 21:54 | |
| *** ujjain has quit IRC | 21:54 | |
| *** d0ugal has quit IRC | 21:54 | |
| *** rushiagr_away has quit IRC | 21:54 | |
| *** BAKfr has quit IRC | 21:54 | |
| *** hockeynut has quit IRC | 21:54 | |
| *** morganfainberg has quit IRC | 21:54 | |
| sdague | https://review.openstack.org/#/c/121033/ doesn't seem to be fixing at the moment | 21:54 |
| *** dougwig has joined #openstack-oslo | 21:54 | |
| *** JoshNang has joined #openstack-oslo | 21:54 | |
| *** ttx has joined #openstack-oslo | 21:54 | |
| *** sigmavirus24 has joined #openstack-oslo | 21:54 | |
| *** clif_h has joined #openstack-oslo | 21:54 | |
| *** ujjain has joined #openstack-oslo | 21:54 | |
| *** rushiagr_away has joined #openstack-oslo | 21:54 | |
| *** d0ugal has joined #openstack-oslo | 21:54 | |
| *** BAKfr has joined #openstack-oslo | 21:54 | |
| *** hockeynut has joined #openstack-oslo | 21:54 | |
| *** morganfainberg has joined #openstack-oslo | 21:54 | |
| *** achanda_ has joined #openstack-oslo | 21:54 | |
| *** achanda has joined #openstack-oslo | 21:54 | |
| *** nikhil_k has joined #openstack-oslo | 21:54 | |
| *** noelbk has joined #openstack-oslo | 21:54 | |
| *** openstackgerrit has joined #openstack-oslo | 21:54 | |
| *** amaurymedeiros has joined #openstack-oslo | 21:54 | |
| *** redrobot has quit IRC | 21:54 | |
| *** jecarey has quit IRC | 21:54 | |
| *** wendar has quit IRC | 21:54 | |
| *** andreykurilin1 has quit IRC | 21:55 | |
| *** flaper87 has quit IRC | 21:55 | |
| mriedem | sdague: ? | 21:55 |
| zzzeek | mriedem / sdague : I have a feeling that there’s a comment in a .sql file here and the parsing is blowing it up | 21:55 |
| mriedem | zzzeek: there is a comment in the file | 21:55 |
| zzzeek | e.g. /*\n * | 21:55 |
| zzzeek | FYI, SQL comments dont use /* */ | 21:55 |
| sdague | zzzeek: let me look | 21:55 |
| zzzeek | they use -- | 21:55 |
| mriedem | https://review.openstack.org/#/c/121033/4/glance/db/sqlalchemy/migrate_repo/versions/006_sqlite_upgrade.sql | 21:55 |
| zzzeek | OK so that is absolutely not compliant SQL | 21:55 |
| *** achanda has quit IRC | 21:55 | |
| zzzeek | i mean, maybe some DBs do it OK | 21:55 |
| mriedem | zzzeek: so see the HACK note removed here: https://review.openstack.org/#/c/110611/11/migrate/versioning/script/sql.py | 21:56 |
| mriedem | zzzeek: maybe we should just add that condition check back in? | 21:56 |
| mriedem | looks like it's just for sqlite which is what all of the UTs are running with | 21:56 |
| mriedem | let me work on a patch quick | 21:56 |
| sdague | mriedem: I'm mostly there | 21:57 |
| sdague | there are some other fixes needed as well | 21:57 |
| *** redrobot has joined #openstack-oslo | 21:57 | |
| sdague | give me 5 minutes | 21:57 |
| mriedem | sdague: k | 21:57 |
| *** redrobot is now known as Guest8210 | 21:57 | |
| zzzeek | mriedem: what about, the fix in https://review.openstack.org/#/c/121517/8/migrate/versioning/script/sql.py is wrong, because it ignores “BEGIN” but perhaps not “BEGIN TRANSACTION” ? | 21:57 |
| zzzeek | mriedem: because in the error message in the trace, “BEGIN TRANSACTION” is there | 21:57 |
| mriedem | zzzeek: i believe those are ignored, see the warnings in the gate runs http://goo.gl/UGXOBa | 21:58 |
| mriedem | http://logs.openstack.org/53/146953/1/check/gate-glance-python27/b87b2b8/console.html#_2015-01-13_19_49_37_991 | 21:58 |
| mriedem | so it ignores and then kaboom | 21:58 |
| zzzeek | mriedem: OK well if i wanted to fix this, I’d need to spend time confirming exactly whats happening, which isn’t on deck for me right now, so if you just want to emergecny revert things for now, that is fine | 21:58 |
| mriedem | i'll wait for sdague | 21:59 |
| mriedem | i'm also supposed to be in a meeting here | 21:59 |
| *** jecarey has joined #openstack-oslo | 21:59 | |
| *** wendar has joined #openstack-oslo | 21:59 | |
| *** andreykurilin1 has joined #openstack-oslo | 21:59 | |
| *** flaper87 has joined #openstack-oslo | 21:59 | |
| sigmavirus24 | sdague: I can work on a glance fix for the comment issues if you'd like | 22:01 |
| sdague | sigmavirus24: I have that fix, but I'm still getting a break | 22:01 |
| *** david-lyle has quit IRC | 22:02 | |
| *** zzzeek has quit IRC | 22:02 | |
| *** kbyrne has quit IRC | 22:02 | |
| *** xek has quit IRC | 22:02 | |
| *** greghaynes has quit IRC | 22:02 | |
| *** fnordahl has quit IRC | 22:02 | |
| *** toabctl has quit IRC | 22:02 | |
| *** jd__ has quit IRC | 22:02 | |
| *** jecarey has quit IRC | 22:02 | |
| *** wendar has quit IRC | 22:02 | |
| *** andreykurilin1 has quit IRC | 22:02 | |
| *** flaper87 has quit IRC | 22:02 | |
| *** dougwig has quit IRC | 22:02 | |
| *** JoshNang has quit IRC | 22:02 | |
| *** ttx has quit IRC | 22:02 | |
| *** sigmavirus24 has quit IRC | 22:02 | |
| *** clif_h has quit IRC | 22:02 | |
| *** ujjain has quit IRC | 22:03 | |
| *** d0ugal has quit IRC | 22:03 | |
| *** rushiagr_away has quit IRC | 22:03 | |
| *** BAKfr has quit IRC | 22:03 | |
| *** hockeynut has quit IRC | 22:03 | |
| *** morganfainberg has quit IRC | 22:03 | |
| *** jaypipes has quit IRC | 22:03 | |
| *** stevemar has quit IRC | 22:03 | |
| *** otherwiseguy has quit IRC | 22:03 | |
| *** lbragstad has quit IRC | 22:03 | |
| *** jraim has quit IRC | 22:03 | |
| *** russellb has quit IRC | 22:03 | |
| *** dhellmann has quit IRC | 22:03 | |
| *** pcaruana has quit IRC | 22:03 | |
| *** dtantsur|afk has quit IRC | 22:03 | |
| *** rharwood has quit IRC | 22:03 | |
| *** gus has quit IRC | 22:03 | |
| *** gothicmindfood has quit IRC | 22:03 | |
| *** anteaya has quit IRC | 22:03 | |
| *** jamespage has quit IRC | 22:03 | |
| *** ozamiatin has quit IRC | 22:03 | |
| *** noelbk has quit IRC | 22:03 | |
| *** openstackgerrit has quit IRC | 22:03 | |
| *** nikhil_k has quit IRC | 22:03 | |
| *** amaurymedeiros has quit IRC | 22:03 | |
| *** Guest8210 has quit IRC | 22:03 | |
| *** mfedosin has quit IRC | 22:03 | |
| *** jgrimm has quit IRC | 22:03 | |
| *** tristanC has quit IRC | 22:03 | |
| *** isviridov_away has quit IRC | 22:03 | |
| *** achanda_ has quit IRC | 22:04 | |
| *** sabari has quit IRC | 22:04 | |
| *** sreshetnyak has quit IRC | 22:04 | |
| *** bnemec has quit IRC | 22:04 | |
| *** tsufiev has quit IRC | 22:04 | |
| *** frickler has quit IRC | 22:04 | |
| *** krotscheck has quit IRC | 22:04 | |
| *** therve has quit IRC | 22:04 | |
| *** ekarlso- has quit IRC | 22:04 | |
| *** cburgess has quit IRC | 22:04 | |
| *** jogo has quit IRC | 22:04 | |
| *** tsekiyama has quit IRC | 22:04 | |
| *** rpodolyaka1 has quit IRC | 22:04 | |
| *** shardy has quit IRC | 22:04 | |
| *** dstanek has quit IRC | 22:04 | |
| *** harlowja has quit IRC | 22:04 | |
| *** haypo has quit IRC | 22:04 | |
| *** sirushti has quit IRC | 22:04 | |
| *** rodrigods has quit IRC | 22:04 | |
| *** lifeless has quit IRC | 22:04 | |
| *** ajo has quit IRC | 22:04 | |
| *** e0ne has quit IRC | 22:04 | |
| *** SergeyLukjanov has quit IRC | 22:04 | |
| *** gordc has quit IRC | 22:04 | |
| *** jeffreycoho has quit IRC | 22:04 | |
| *** eezhova has quit IRC | 22:04 | |
| *** HenryG has quit IRC | 22:05 | |
| *** dims__ has quit IRC | 22:05 | |
| *** salv-orlando has quit IRC | 22:05 | |
| *** yamahata has quit IRC | 22:05 | |
| *** kgiusti has quit IRC | 22:05 | |
| *** kragniz has quit IRC | 22:05 | |
| *** SlickNik has quit IRC | 22:05 | |
| *** mtreinish has quit IRC | 22:05 | |
| *** bogdando has quit IRC | 22:05 | |
| *** amrith has quit IRC | 22:05 | |
| *** eikke has quit IRC | 22:05 | |
| *** burgobianco has quit IRC | 22:05 | |
| *** jaosorior has quit IRC | 22:05 | |
| *** subscope has quit IRC | 22:05 | |
| *** bknudson has quit IRC | 22:05 | |
| *** sheeprine has quit IRC | 22:05 | |
| *** crc32 has quit IRC | 22:05 | |
| *** mriedem has quit IRC | 22:05 | |
| *** palendae has quit IRC | 22:05 | |
| *** sdague has quit IRC | 22:05 | |
| *** hogepodge has quit IRC | 22:05 | |
| *** flaper87 has joined #openstack-oslo | 22:06 | |
| *** andreykurilin1 has joined #openstack-oslo | 22:06 | |
| *** wendar has joined #openstack-oslo | 22:06 | |
| *** jecarey has joined #openstack-oslo | 22:06 | |
| *** Guest8210 has joined #openstack-oslo | 22:06 | |
| *** amaurymedeiros has joined #openstack-oslo | 22:06 | |
| *** openstackgerrit has joined #openstack-oslo | 22:06 | |
| *** noelbk has joined #openstack-oslo | 22:06 | |
| *** nikhil_k has joined #openstack-oslo | 22:06 | |
| *** achanda_ has joined #openstack-oslo | 22:06 | |
| *** morganfainberg has joined #openstack-oslo | 22:06 | |
| *** hockeynut has joined #openstack-oslo | 22:06 | |
| *** BAKfr has joined #openstack-oslo | 22:06 | |
| *** d0ugal has joined #openstack-oslo | 22:06 | |
| *** rushiagr_away has joined #openstack-oslo | 22:06 | |
| *** ujjain has joined #openstack-oslo | 22:06 | |
| *** clif_h has joined #openstack-oslo | 22:06 | |
| *** sigmavirus24 has joined #openstack-oslo | 22:06 | |
| *** ttx has joined #openstack-oslo | 22:06 | |
| *** JoshNang has joined #openstack-oslo | 22:06 | |
| *** dougwig has joined #openstack-oslo | 22:06 | |
| *** ozamiatin has joined #openstack-oslo | 22:06 | |
| *** anteaya has joined #openstack-oslo | 22:06 | |
| *** gothicmindfood has joined #openstack-oslo | 22:06 | |
| *** jamespage has joined #openstack-oslo | 22:06 | |
| *** gus has joined #openstack-oslo | 22:06 | |
| *** rharwood has joined #openstack-oslo | 22:06 | |
| *** dtantsur|afk has joined #openstack-oslo | 22:06 | |
| *** pcaruana has joined #openstack-oslo | 22:06 | |
| *** dhellmann has joined #openstack-oslo | 22:06 | |
| *** lbragstad has joined #openstack-oslo | 22:06 | |
| *** russellb has joined #openstack-oslo | 22:06 | |
| *** jraim has joined #openstack-oslo | 22:06 | |
| *** otherwiseguy has joined #openstack-oslo | 22:06 | |
| *** stevemar has joined #openstack-oslo | 22:06 | |
| *** jaypipes has joined #openstack-oslo | 22:06 | |
| *** burgobianco has joined #openstack-oslo | 22:06 | |
| *** jaosorior has joined #openstack-oslo | 22:06 | |
| *** david-lyle has joined #openstack-oslo | 22:06 | |
| *** tristanC has joined #openstack-oslo | 22:06 | |
| *** jgrimm has joined #openstack-oslo | 22:06 | |
| *** mfedosin has joined #openstack-oslo | 22:06 | |
| *** isviridov_away has joined #openstack-oslo | 22:06 | |
| *** jogo has joined #openstack-oslo | 22:06 | |
| *** cburgess has joined #openstack-oslo | 22:06 | |
| *** ekarlso- has joined #openstack-oslo | 22:06 | |
| *** therve has joined #openstack-oslo | 22:06 | |
| *** krotscheck has joined #openstack-oslo | 22:06 | |
| *** frickler has joined #openstack-oslo | 22:06 | |
| *** tsufiev has joined #openstack-oslo | 22:06 | |
| *** bnemec has joined #openstack-oslo | 22:06 | |
| *** sreshetnyak has joined #openstack-oslo | 22:06 | |
| *** sabari has joined #openstack-oslo | 22:06 | |
| *** HenryG has joined #openstack-oslo | 22:06 | |
| *** dstanek has joined #openstack-oslo | 22:06 | |
| *** shardy has joined #openstack-oslo | 22:06 | |
| *** rpodolyaka1 has joined #openstack-oslo | 22:06 | |
| *** tsekiyama has joined #openstack-oslo | 22:06 | |
| *** hogepodge has joined #openstack-oslo | 22:06 | |
| *** sheeprine has joined #openstack-oslo | 22:06 | |
| *** sdague has joined #openstack-oslo | 22:06 | |
| *** palendae has joined #openstack-oslo | 22:06 | |
| *** bknudson has joined #openstack-oslo | 22:06 | |
| *** subscope has joined #openstack-oslo | 22:06 | |
| *** mriedem has joined #openstack-oslo | 22:06 | |
| *** crc32 has joined #openstack-oslo | 22:06 | |
| *** dims__ has joined #openstack-oslo | 22:06 | |
| *** ajo has joined #openstack-oslo | 22:06 | |
| *** e0ne has joined #openstack-oslo | 22:06 | |
| *** salv-orlando has joined #openstack-oslo | 22:06 | |
| *** yamahata has joined #openstack-oslo | 22:06 | |
| *** SergeyLukjanov has joined #openstack-oslo | 22:06 | |
| *** kgiusti has joined #openstack-oslo | 22:06 | |
| *** jeffreycoho has joined #openstack-oslo | 22:06 | |
| *** harlowja has joined #openstack-oslo | 22:06 | |
| *** haypo has joined #openstack-oslo | 22:06 | |
| *** eezhova has joined #openstack-oslo | 22:06 | |
| *** kragniz has joined #openstack-oslo | 22:06 | |
| *** SlickNik has joined #openstack-oslo | 22:06 | |
| *** mtreinish has joined #openstack-oslo | 22:06 | |
| *** sirushti has joined #openstack-oslo | 22:06 | |
| *** bogdando has joined #openstack-oslo | 22:06 | |
| *** rodrigods has joined #openstack-oslo | 22:06 | |
| *** lifeless has joined #openstack-oslo | 22:06 | |
| *** amrith has joined #openstack-oslo | 22:06 | |
| *** eikke has joined #openstack-oslo | 22:06 | |
| *** zzzeek has joined #openstack-oslo | 22:06 | |
| *** kbyrne has joined #openstack-oslo | 22:06 | |
| *** xek has joined #openstack-oslo | 22:06 | |
| *** greghaynes has joined #openstack-oslo | 22:06 | |
| *** fnordahl has joined #openstack-oslo | 22:06 | |
| *** toabctl has joined #openstack-oslo | 22:06 | |
| *** jd__ has joined #openstack-oslo | 22:06 | |
| sdague | Ran 2500 (+2499) tests in 151.911s (+141.561s) | 22:07 |
| sdague | FAILED (id=7, failures=61 (+60), skips=12) | 22:07 |
| sdague | error: testr failed (1) | 22:07 |
| sdague | I get a lot of MissingCredentialError: Missing required credential: username | 22:08 |
| mriedem | sdague: the patch worked for me locally, did you rebuild tox? | 22:09 |
| sdague | I did | 22:09 |
| mriedem | tox -r -v -e py27 -- glance.tests.functional.db.test_registry.TestRegistryDriver.test_image_destroy_with_delete_all | 22:10 |
| sdague | running now | 22:10 |
| sdague | ok, that passe | 22:10 |
| mriedem | sdague: want to move to -glance? | 22:11 |
| sdague | I actually need to drop | 22:11 |
| mriedem | ok, only point was if we merge the migrations change in glance, the library is still busted | 22:11 |
| sigmavirus24 | mriedem: let's move to glance | 22:11 |
| sdague | but if you think that patch is going to work, that's a better fix than the requirements thing | 22:11 |
| mriedem | sdague: migrate 0.9.4 on juno glance will fail | 22:11 |
| sdague | we can pin in juno | 22:12 |
| mriedem | true | 22:12 |
| sdague | but lets not do that on master | 22:12 |
| sdague | lets actually fix it | 22:12 |
| mriedem | ok, well this change is passing for me locally with migrate 0.9.4 | 22:12 |
| sdague | ok, win | 22:12 |
| *** mriedem has left #openstack-oslo | 22:12 | |
| *** mriedem has joined #openstack-oslo | 22:12 | |
| *** sabari is now known as zz_sabari | 22:14 | |
| dims__ | mriedem: not going to support filtering /* */ comments? | 22:15 |
| *** kgiusti has left #openstack-oslo | 22:15 | |
| mriedem | dims__: sdague has the fix here https://review.openstack.org/#/c/121033/ | 22:15 |
| mriedem | as zzzeek pointed out, /* */ aren't valid | 22:15 |
| mriedem | http://dev.mysql.com/doc/refman/5.0/en/comments.html | 22:16 |
| zzzeek | mriedem: generally. not sure if this “executescript” thing is filtering them out | 22:16 |
| mriedem | i guess /* */ was ok for mysql? | 22:16 |
| dims__ | right, so we may at least want to holler with a better message? | 22:16 |
| mriedem | oh in sqlite | 22:17 |
| mriedem | https://docs.python.org/2/library/sqlite3.html#sqlite3.Cursor.executescript | 22:17 |
| mriedem | not much there about parsing comments | 22:17 |
| mriedem | https://www.sqlite.org/lang_comment.html | 22:18 |
| mriedem | hmm, maybe a bug in sqlite? | 22:18 |
| *** dougwig has quit IRC | 22:19 | |
| sdague | mriedem: also, there are new files that since landed with the commit; parts | 22:23 |
| *** stevemar has quit IRC | 22:23 | |
| sdague | also, apparently the girls are all sleeping now, so back to the grind | 22:26 |
| *** david-lyle has quit IRC | 22:27 | |
| mriedem | huzzah | 22:27 |
| *** noelbk has quit IRC | 22:27 | |
| *** david-lyle has joined #openstack-oslo | 22:30 | |
| dims__ | sdague: mriedem: 0.9.1 works with the non-sql /**/ so question i have is, should we continue to support that? | 22:31 |
| sdague | honestly, I think that's a red herring | 22:31 |
| sdague | there were 2 more migrations that landed with the bad commit messages | 22:31 |
| mriedem | dims__: yeah that wouldn't make sense for me, since i don't see anything related to comment processing here https://review.openstack.org/#/c/121517/ | 22:32 |
| mriedem | dims__: it seems if one wants to support sqlite sql scripts with migrate they have to use the executescript function in sqlite | 22:33 |
| mriedem | which was removed in migrate 0.9.2 when things started blowing up in nova | 22:33 |
| dims__ | mriedem: sdague: ack. thanks. trying to learn. had not spent time on the db stuff before | 22:34 |
| sdague | yeh, I don't know | 22:35 |
| sdague | mriedem: my patch works for all the glance tests for you? | 22:35 |
| mriedem | sdague: now that i installed curl, yes :) | 22:35 |
| * mriedem takes note to update something somewhere in glance about that | 22:35 | |
| sdague | um, yeh, it explodes cryptically if you don't have curl? | 22:36 |
| sdague | I definitely have curl installed | 22:36 |
| dims__ | LOL | 22:36 |
| dims__ | can't live w/o curl/wget :) | 22:37 |
| sdague | also... --concurrency=0 ? | 22:39 |
| mriedem | this vm doesn't have devstack | 22:40 |
| mriedem | just bare trusty with git clone and tox | 22:40 |
| mriedem | i only have nova's native deps for tests | 22:40 |
| *** jecarey has quit IRC | 22:41 | |
| mriedem | sigmavirus24: nikhil_k: dims__: sdague: i've gotta go pick up my daughter from daycare and head home, i'll push the stable branch pins later tonight, | 22:47 |
| sigmavirus24 | thanks mriedem | 22:47 |
| dims__ | thanks mriedem | 22:47 |
| mriedem | hopefully we won't break the gate tomorrow | 22:47 |
| mriedem | :) | 22:47 |
| *** mriedem has quit IRC | 22:48 | |
| *** achanda_ has quit IRC | 22:51 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo-incubator: Update run_cross_test.sh to pass extra args to tox https://review.openstack.org/147009 | 22:56 |
| *** achanda has joined #openstack-oslo | 22:59 | |
| *** raildo has joined #openstack-oslo | 23:01 | |
| *** zz_sabari is now known as sabari | 23:03 | |
| *** e0ne is now known as e0ne_ | 23:05 | |
| *** sabari is now known as zz_sabari | 23:05 | |
| openstackgerrit | Joshua Harlow proposed openstack/oslo-specs: config: Add a spec for a oslo.config proxy config opts https://review.openstack.org/130047 | 23:06 |
| *** ihrachyshka has joined #openstack-oslo | 23:07 | |
| *** ajo has quit IRC | 23:07 | |
| *** e0ne_ is now known as e0ne | 23:08 | |
| *** e0ne has quit IRC | 23:09 | |
| *** zz_sabari is now known as sabari | 23:12 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 23:14 | |
| *** dims_ has joined #openstack-oslo | 23:15 | |
| *** dims__ has quit IRC | 23:19 | |
| *** jrw1 has joined #openstack-oslo | 23:20 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo-incubator: Update run_cross_test.sh to pass extra args to tox https://review.openstack.org/147009 | 23:22 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo-incubator: Ignore errors uninstalling lib in run_cross_test.sh https://review.openstack.org/147016 | 23:22 |
| *** david-lyle has quit IRC | 23:27 | |
| *** crc32 has quit IRC | 23:30 | |
| *** dims_ has quit IRC | 23:33 | |
| *** jaosorior has quit IRC | 23:33 | |
| *** dims__ has joined #openstack-oslo | 23:33 | |
| *** dims__ has quit IRC | 23:38 | |
| *** dougwig has joined #openstack-oslo | 23:39 | |
| *** oomichi_ has joined #openstack-oslo | 23:40 | |
| *** jraim has quit IRC | 23:40 | |
| *** zhiyan has quit IRC | 23:40 | |
| *** sabari is now known as zz_sabari | 23:41 | |
| *** zz_sabari is now known as sabari | 23:42 | |
| *** mriedem has joined #openstack-oslo | 23:43 | |
| *** jrw1 has left #openstack-oslo | 23:44 | |
| *** dims__ has joined #openstack-oslo | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!