Friday, 2014-12-12

harlowjaok, lets see where that goes00:01
openstackgerritJoshua Harlow proposed openstack/oslo-specs: Add debtcollector adoption  https://review.openstack.org/14122000:07
openstackgerritJoshua Harlow proposed openstack/oslo-specs: Add debtcollector adoption  https://review.openstack.org/14122000:10
openstackgerritJoshua Harlow proposed openstack/oslo-specs: Add debtcollector adoption  https://review.openstack.org/14122000:11
*** dims__ has quit IRC00:15
*** dims__ has joined #openstack-oslo00:15
*** dims__ has quit IRC00:18
*** dims__ has joined #openstack-oslo00:18
*** exploreshaifali has quit IRC00:21
*** david-lyle is now known as david-lyle_afk00:23
*** dims__ has quit IRC00:45
*** dims__ has joined #openstack-oslo00:46
*** andreykurilin__ has quit IRC00:47
*** dims__ has quit IRC00:50
openstackgerritJoshua Harlow proposed openstack/oslo-specs: Add debtcollector adoption  https://review.openstack.org/14122001:07
*** tsekiyam_ has joined #openstack-oslo01:15
*** tsekiyama has quit IRC01:18
*** tsekiyam_ has quit IRC01:19
*** mtanino has quit IRC01:26
*** dims__ has joined #openstack-oslo01:27
*** _amrith_ is now known as amrith01:38
*** boris-42 has quit IRC02:03
*** zzzeek has quit IRC02:08
*** oomichi has joined #openstack-oslo02:46
*** dims__ has quit IRC02:49
*** dims__ has joined #openstack-oslo02:50
*** dims__ has quit IRC02:54
*** sabari is now known as zz_sabari03:10
*** jeckersb is now known as jeckersb_gone03:29
*** harlowja is now known as harlowja_away03:36
*** zz_sabari is now known as sabari03:39
*** sabari is now known as zz_sabari03:47
*** zz_sabari is now known as sabari03:49
*** oomichi has quit IRC04:12
*** sabari is now known as zz_sabari04:16
*** zz_sabari is now known as sabari04:17
*** stevemar has joined #openstack-oslo04:30
*** lbragstad has quit IRC04:32
*** lbragstad has joined #openstack-oslo04:33
*** zzzeek has joined #openstack-oslo04:33
*** zzzeek has quit IRC04:33
*** ujjain has quit IRC04:34
*** ujjain has joined #openstack-oslo04:35
*** sabari is now known as zz_sabari04:44
*** zz_sabari is now known as sabari05:00
*** sabari is now known as zz_sabari05:32
*** zz_sabari is now known as sabari05:37
*** rpodolyaka2 has joined #openstack-oslo05:38
*** stevemar has quit IRC05:43
*** sgotliv has joined #openstack-oslo06:08
*** harlowja_at_home has joined #openstack-oslo06:12
*** sgotliv has quit IRC06:13
*** vigneshvar has joined #openstack-oslo06:39
*** harlowja_at_home has quit IRC06:46
openstackgerritMerged openstack/taskflow: Avoid holding the lock while scanning for existing jobs  https://review.openstack.org/14116906:53
*** sgotliv has joined #openstack-oslo06:57
*** sgotliv has quit IRC07:04
*** oomichi has joined #openstack-oslo07:11
*** oomichi has quit IRC07:21
*** SridharGaddam has joined #openstack-oslo07:22
openstackgerritMehdi Abaakouk proposed openstack/oslo.messaging: safe_log Sanitize Passwords in List of Dicts  https://review.openstack.org/12375907:31
*** lifeless has quit IRC07:36
*** lifeless has joined #openstack-oslo07:43
*** noelbk has joined #openstack-oslo08:00
*** jamespage_ has joined #openstack-oslo08:02
*** jamespage_ has quit IRC08:04
*** dtantsur|afk is now known as dtantsur08:05
*** sabari is now known as zz_sabari08:06
*** xek has joined #openstack-oslo08:08
*** jaypipes_ has joined #openstack-oslo08:10
*** zz_sabari is now known as sabari08:11
*** jaypipes has quit IRC08:14
*** rpodolyaka2 has quit IRC08:16
*** e0ne has joined #openstack-oslo08:28
*** ajo has joined #openstack-oslo08:32
*** stannie has joined #openstack-oslo08:42
*** ajo has quit IRC08:45
*** ajo has joined #openstack-oslo08:47
*** dtantsur is now known as dtantsur|bbl08:59
*** stannie has quit IRC09:00
*** sabari is now known as zz_sabari09:05
*** raildo_ has joined #openstack-oslo09:14
*** e0ne has quit IRC09:28
*** raildo_ has quit IRC09:32
*** ihrachyshka has joined #openstack-oslo09:32
*** ihrachyshka_ has joined #openstack-oslo09:34
*** pblaho has joined #openstack-oslo09:36
*** ihrachyshka has quit IRC09:37
openstackgerritJulien Danjou proposed openstack/tooz: Add create/join/leave group support in IPC driver  https://review.openstack.org/14131409:56
*** alexpilotti has joined #openstack-oslo10:08
*** sgotliv has joined #openstack-oslo10:08
*** _gryf has quit IRC10:15
*** _gryf has joined #openstack-oslo10:15
*** e0ne has joined #openstack-oslo10:25
*** andreykurilin_ has joined #openstack-oslo10:36
*** sgotliv has quit IRC10:40
*** ihrachyshka_ has quit IRC10:43
openstackgerritRoman Podoliaka proposed openstack/oslo.db: Ensure DBConnectionError is raised on failed revalidate  https://review.openstack.org/13973810:50
openstackgerritRoman Podoliaka proposed openstack/oslo.db: Repair string-based disconnect filters for MySQL, DB2  https://review.openstack.org/13973310:50
openstackgerritRoman Podoliaka proposed openstack/oslo.db: Ensure PostgreSQL connection errors are wrapped  https://review.openstack.org/14132310:50
*** dims__ has joined #openstack-oslo10:56
*** dims__ has quit IRC11:00
*** ihrachyshka_ has joined #openstack-oslo11:35
*** ihrachyshka__ has joined #openstack-oslo11:38
*** ihrachyshka_ has quit IRC11:41
*** dims__ has joined #openstack-oslo11:45
*** dims__ has quit IRC11:49
*** dims__ has joined #openstack-oslo11:49
*** dims__ has quit IRC11:54
*** boris-42 has joined #openstack-oslo11:55
*** dims__ has joined #openstack-oslo11:56
*** dtantsur|bbl is now known as dtantsur12:10
openstackgerritMerged openstack/oslotest: Activate pep8 check that _ is imported  https://review.openstack.org/14120512:18
*** sgotliv has joined #openstack-oslo12:18
*** ihrachyshka__ is now known as ihrachyshka12:23
openstackgerritMiguel Angel Ajo proposed openstack/oslo-incubator: Introduce fileutils ensure_dir creation mode parameter  https://review.openstack.org/14134812:28
dims__jd__: when you get a chance, please bless this oslo.vmware bump12:29
dims__jd__: https://review.openstack.org/#/c/141099/12:29
ajodhellmann  ^12:30
ajohttp://review.openstack.org/14134812:30
ajoI hope it's ok, not sure if I need to fill a bug or blueprint for such a tiny thing, but if I need, I will12:30
*** e0ne_ has joined #openstack-oslo12:40
openstackgerritMerged openstack/oslo.rootwrap: Activate pep8 check that _ is imported  https://review.openstack.org/14120212:41
*** tedross has joined #openstack-oslo12:41
*** e0ne has quit IRC12:42
openstackgerritMerged openstack/oslo.messaging: rabbit: add some tests when rpc_backend is set  https://review.openstack.org/13897412:43
openstackgerritMerged openstack/oslo.serialization: Activate pep8 check that _ is imported  https://review.openstack.org/14120312:44
openstackgerritMerged openstack/oslo.db: Upgrade exc_filters for 'engine' argument and connect behavior  https://review.openstack.org/13972512:46
*** vigneshvar has quit IRC12:47
*** dims__ has quit IRC12:48
openstackgerritMerged openstack/oslo.db: Repair string-based disconnect filters for MySQL, DB2  https://review.openstack.org/13973312:48
*** dims__ has joined #openstack-oslo12:48
ajoihrachyshka, there is no constant for 0x77712:49
ajoI can construct it btw...12:49
ajobut python itself uses 0o77712:50
ajo(octal, sorry)12:50
*** dims__ has quit IRC12:52
*** dims__ has joined #openstack-oslo13:01
openstackgerritMerged openstack/oslo.concurrency: Port processutils to Python 3  https://review.openstack.org/14120613:16
openstackgerritMerged openstack/oslo.concurrency: Drop requirements-py3.txt  https://review.openstack.org/14098013:17
openstackgerritJulien Danjou proposed openstack/tooz: Add create/join/leave group support in IPC driver  https://review.openstack.org/14131413:22
*** dims__ has quit IRC13:26
*** jecarey has joined #openstack-oslo13:26
*** vigneshvar has joined #openstack-oslo13:27
*** dims__ has joined #openstack-oslo13:27
*** dims__ has quit IRC13:31
ihrachyshkaajo: well, yes, you can construct it13:42
*** jecarey has quit IRC13:46
*** amrith is now known as _amrith_13:50
*** jeckersb_gone is now known as jeckersb14:00
*** dims__ has joined #openstack-oslo14:02
*** k4n0 has quit IRC14:17
dims__dhellmann: do we have a process for moving attic?14:26
dims__dhellmann: (oslo.version)14:26
*** noelbk has quit IRC14:31
*** jecarey has joined #openstack-oslo14:39
*** jeckersb is now known as jeckersb_gone14:45
openstackgerritMerged openstack/oslo.log: Add pbr to installation requirements  https://review.openstack.org/13078514:48
openstackgerritMerged openstack/oslo.messaging: Updated from global requirements  https://review.openstack.org/14095014:48
*** _amrith_ is now known as amrith14:49
*** xek has quit IRC14:51
*** jeckersb_gone is now known as jeckersb14:53
*** vigneshvar has quit IRC14:53
*** andymaier has joined #openstack-oslo15:01
andymaierHi. We did not find a tag in the oslo.log git repo that is specific to the Juno release.15:03
andymaieroslo.log is one of five repos that are installed by devstack.15:03
andymaierQuestion: Should such a tag be added to the oslo.log repo?15:03
andymaiercorrection: oslo.log is one of five repos that are installed by devstack that does not have such a tag.15:04
dhellmannandymaier: we haven't made an official release of oslo.log yet, so nothing is using it15:04
andymaierdevstack offers a variable to set the branch for oslo.log. Does that mean that devstack went ahead of things there?15:05
dhellmannandymaier: our plan was to release it last cycle, but we hit a snag, so it was unfinished15:05
dhellmannandymaier: if you change devstack w.r.t. oslo.log, please limit the changes to the stable/juno branch and keep master as it is because we're working on it again this cycle15:06
andymaierok. thanks for the info, doug.15:07
*** mtanino has joined #openstack-oslo15:18
*** eezhova has quit IRC15:21
*** andymaier has left #openstack-oslo15:25
*** eezhova has joined #openstack-oslo15:26
openstackgerritMerged openstack/oslo.log: Updated from global requirements  https://review.openstack.org/14094915:29
*** kgiusti has joined #openstack-oslo15:33
openstackgerritMerged openstack/oslo.concurrency: Activate pep8 check that _ is imported  https://review.openstack.org/14119315:39
*** mriedem has joined #openstack-oslo15:39
dhellmanndims__: there were some notes on the attic stuff in one of the etherpads from the summit, just a sec15:39
dhellmanndims__: bottom of https://etherpad.openstack.org/p/kilo-oslo-library-proposals15:40
*** e0ne_ is now known as e0ne15:41
dims__dhellmann: those make sense, we probably need to request infra for a rename before those15:43
*** jaypipes_ is now known as jaypipes15:44
dhellmanndims__: yeah, I think they want the patch up for review first but you'd have to ask fungi15:44
dims__dhellmann: ack thanks!15:46
*** andymaier has joined #openstack-oslo15:53
*** andymaier has quit IRC15:55
*** andymaier has joined #openstack-oslo15:56
*** gordc has joined #openstack-oslo15:57
*** SridharGaddam has quit IRC16:08
*** prad has joined #openstack-oslo16:08
*** andymaier has quit IRC16:14
*** tsekiyama has joined #openstack-oslo16:16
*** noelbk has joined #openstack-oslo16:18
*** e0ne_ has joined #openstack-oslo16:21
*** e0ne has quit IRC16:24
*** boris-42 has quit IRC16:32
*** dims__ has quit IRC16:33
*** dims__ has joined #openstack-oslo16:34
*** dims__ has quit IRC16:38
openstackgerritDoug Hellmann proposed openstack/oslo.rootwrap: Move files out of the namespace package  https://review.openstack.org/14114716:43
*** kbyrne has quit IRC16:44
*** dims__ has joined #openstack-oslo16:44
*** kbyrne has joined #openstack-oslo16:46
*** david-lyle_afk is now known as david-lyle16:49
*** jaosorior has joined #openstack-oslo16:53
*** kbyrne has quit IRC16:53
*** kbyrne has joined #openstack-oslo16:57
*** haypo has left #openstack-oslo16:57
*** andreykurilin_ has quit IRC16:58
*** andreykurilin_ has joined #openstack-oslo16:58
*** miqui_ has quit IRC17:04
*** miqui_ has joined #openstack-oslo17:04
*** mriedem has quit IRC17:11
*** dtantsur is now known as dtantsur|afk17:15
openstackgerritDoug Hellmann proposed openstack/oslo.rootwrap: Move files out of the namespace package  https://review.openstack.org/14114717:21
*** jogo is now known as flashgordon17:24
*** jaypipes is now known as leakypipes17:25
openstackgerritDoug Hellmann proposed openstack/oslo.rootwrap: Move files out of the namespace package  https://review.openstack.org/14114717:31
*** openstackgerrit has quit IRC17:34
*** openstackgerrit has joined #openstack-oslo17:34
openstackgerritIhar Hrachyshka proposed openstack/oslo.concurrency: Don't use ConfigFilter for lockutils  https://review.openstack.org/14143617:35
*** andreykurilin_ has quit IRC17:38
*** andreykurilin_ has joined #openstack-oslo17:39
*** zzzeek has joined #openstack-oslo17:41
*** e0ne_ has quit IRC17:48
*** openstackgerrit has quit IRC17:49
*** openstackgerrit has joined #openstack-oslo17:49
*** ihrachyshka has quit IRC17:49
*** andreykurilin_ has quit IRC17:54
*** dims__ is now known as dimsum__17:57
*** pblaho has quit IRC18:16
*** harlowja_away is now known as harlowja18:17
*** noelbk has quit IRC18:21
*** leakypipes is now known as leaky-tennis18:23
*** russellb is now known as rustlebee18:29
*** zz_sabari is now known as sabari18:29
*** amrith is now known as _amrith_18:41
openstackgerritJoshua Harlow proposed openstack/oslo-specs: Add debtcollector adoption  https://review.openstack.org/14122018:53
*** sgotliv has quit IRC18:57
*** boris-42 has joined #openstack-oslo19:03
*** achanda has joined #openstack-oslo19:04
achandaI've been trying to 'pip install oslo.log' and it says there is no distribution for oslo.log19:05
dhellmannachanda: that is correct, we have not released oslo.log yet19:05
achandadhellman: thanks!19:05
*** ruhe has joined #openstack-oslo19:05
achandaI guess I rushed into it :)19:05
* dhellmann wonders why so many people have been asking that question lately :-)19:05
achandamaybe because it shows up in pip search! :)19:06
achandain pypi19:06
dhellmannyes, we registered the project to reserve the name19:07
achandaok, cool19:07
*** vigneshvar has joined #openstack-oslo19:10
openstackgerritDoug Hellmann proposed openstack/oslo.concurrency: Report import warnings where the import occurs  https://review.openstack.org/14112519:11
dhellmannviktors|afk, zzzeek, rpodolyaka1: I'm going to have a lot of trouble rebasing https://review.openstack.org/138787 if we keep landing changes in oslo.db. Can we prioritize reviewing that one when I have a new patch ready?19:13
zzzeekdhellmann: aboslutely say the word19:20
dhellmannzzzeek: I hate to block everyone else, but I have to recreate that patch by hand every time someone changes a file so I don't lose their change :-/19:20
zzzeekdhellmann: im sure , so, when is that finally going to go in ?19:20
dhellmanngit doesn't seem to be smart enough to figure this out19:20
dhellmannwell, I'm going to start working on fixing the current patch now, so then it's up to the reviewers as to when it lands19:21
zzzeekdhellmann: oh wow there was a pymysql gerrit, heh19:23
zzzeekdhellmann: IMO we shoudl try to get mysql-connector to work for us19:23
dhellmannyeah, we have a spec for that, too, and I think we approved the spec19:23
dhellmannI'll let you and ihar work that out19:24
harlowjazzzeek sooo who wants to fork mysql-connector ;)19:24
harlowjai don't have larry's phone nmber19:24
harlowjamaybe if i got that19:24
harlowjai could run over to the oracle buildings and yell like a crazy person in them19:24
harlowjathat might help ?19:24
dhellmannzzzeek: oh, here's the spec review: https://review.openstack.org/#/c/125044/19:24
zzzeekdhellmann: wasnt sure I’d be the only one uncomforatble with “many bug fixes and improvements”19:24
dhellmannyeah, that's not great -- I mean, maybe it's OK, but I don't want to assume it is and I don't have time to do a real review myself19:25
harlowjabetter than no  bug fixes, lol19:25
dhellmannheh19:25
harlowjai know where the oracle tin can buildings are, maybe if i scope out the buildings and do a raid, i can get that published to pypi19:26
harlowja* http://www.bloomberg.com/image/iBvkPglvU38M.jpg19:27
harlowjacould be like a stealth mission19:27
harlowja* http://cdn.cultofmac.com/wp-content/uploads/2010/03/mission-impossible-SPLASH.jpg (would be me instead of tom cruise)19:29
harlowjaand i'd be uploading the package to pypi instead of doing whatever he's doing there19:30
harlowjalol19:30
*** sabari is now known as zz_sabari19:35
*** zz_sabari is now known as sabari19:38
*** _amrith_ is now known as amrith19:43
dimsum__harlowja: haha19:49
harlowja:)19:50
openstackgerritJoshua Harlow proposed openstack/oslo-specs: Add debtcollector adoption  https://review.openstack.org/14122019:56
openstackgerritDoug Hellmann proposed openstack/oslo.db: Move files out of the namespace package  https://review.openstack.org/13878719:58
*** e0ne has joined #openstack-oslo20:02
*** alexpilotti has quit IRC20:10
*** dtantsur|afk has quit IRC20:11
*** alexpilotti has joined #openstack-oslo20:12
*** noelbk has joined #openstack-oslo20:15
*** e0ne has quit IRC20:15
*** sabari is now known as zz_sabari20:16
*** alexpilotti has quit IRC20:22
*** jaosorior has quit IRC20:23
*** alexpilotti has joined #openstack-oslo20:23
*** vigneshvar has quit IRC20:23
*** dtantsur has joined #openstack-oslo20:24
*** alexpilotti has quit IRC20:27
*** dteselkin has left #openstack-oslo20:33
*** vigneshvar has joined #openstack-oslo20:37
*** alexpilotti has joined #openstack-oslo20:37
*** achanda has quit IRC20:37
openstackgerritJoshua Harlow proposed openstack/taskflow: Add a moved_inheritable_class deprecation helper  https://review.openstack.org/14013220:51
openstackgerritJoshua Harlow proposed openstack/taskflow: Remove usage of listener base postfix  https://review.openstack.org/14149020:51
openstackgerritJoshua Harlow proposed openstack/taskflow: Remove usage of listener base postfix  https://review.openstack.org/14149020:53
*** zz_sabari is now known as sabari20:54
*** ajo has quit IRC20:56
*** alexpilotti has quit IRC20:57
*** alexpilotti has joined #openstack-oslo20:58
*** alexpilotti has quit IRC20:59
*** alexpilotti has joined #openstack-oslo21:01
*** alexpilotti has quit IRC21:01
*** alexpilotti has joined #openstack-oslo21:02
*** alexpilotti has quit IRC21:02
*** alexpilotti has joined #openstack-oslo21:03
*** prad has quit IRC21:04
*** alexpilotti has quit IRC21:05
*** ajo has joined #openstack-oslo21:06
*** jecarey has quit IRC21:07
*** alexpilotti has joined #openstack-oslo21:07
*** alexpilotti has quit IRC21:09
*** ajo has quit IRC21:12
*** alexpilotti has joined #openstack-oslo21:14
*** ajo has joined #openstack-oslo21:15
*** alexpilotti has quit IRC21:15
*** leaky-tennis is now known as leakypipes21:17
openstackgerritDoug Hellmann proposed openstack/oslo.config: Move files out of the namespace package  https://review.openstack.org/13973521:23
openstackgerritDoug Hellmann proposed openstack/oslo.i18n: Move out of the oslo namespace package  https://review.openstack.org/12732321:27
*** boris-42 has quit IRC21:33
*** e0ne has joined #openstack-oslo21:33
dhellmannsileht, jd__ : same question for you as for the oslo.db guys, can we prioritize my patch to remove the namespace package so I don't have to keep rebasing it by hand? I need to submit a fixed up patch21:37
flashgordonzzzeek: ping21:40
zzzeekflashgordon: hi21:40
flashgordonzzzeek: https://review.openstack.org/#/c/135296/2/specs/kilo/approved/lock-free-quota-management.rst,cm thought you may find that spec interesting21:41
flashgordonnote I have only just started reading it, but thought you may have a thought or two21:41
zzzeekflashgordon: have seen this already being implemented in lots of places21:42
zzzeekflashgordon: its the basic optimistic approach and is what we shoudl be doing21:42
flashgordonzzzeek: glad to hear it, a +1 from you would be nice21:44
flashgordonit would help me feel comfortable +2ing it21:44
zzzeeki approve everything jay pipes does :)21:45
leakypipeslol21:45
flashgordonleakypipes: oh no more tennis?21:45
*** tedross has quit IRC21:45
leakypipesflashgordon: no, we got beaten badly by two people 30 years older than us. It was mucho embarrassing.21:46
leakypipesbut hey, whatever makes the wife happy, right? :)21:46
flashgordonleakypipes: haha yup21:47
*** jeckersb is now known as jeckersb_gone21:47
flashgordonleakypipes: naive question21:47
flashgordonthe write-intent lock, is that on the whole table? And will the compare and swap method hit the backoff less often then the deadlock is raised now?21:49
leakypipesflashgordon: write-intent locks are on single rows and what are called "gap locks" in InnoDB21:50
leakypipesflashgordon: they are definitely not on the whole table, no.21:51
flashgordonleakypipes: so the part I am a little confused on, is how will this make for  better concurrency. I get the fewer db deadlock based retries21:53
flashgordonleakypipes: I am asking to learn, not because I doubt it does that21:54
*** kgiusti has quit IRC21:54
*** boris-42 has joined #openstack-oslo21:55
flashgordonoh and there is a section with TODO in it so21:57
sdagueflashgordon: so the issue is select for update gets a write lock21:57
sdaguebecause that's what you were intending to do21:57
leakypipesflashgordon: no worries. so right now, there is a set of write-intent locks held for all quota usage records for a project during the reserve() and commit() methods of the QuotaDbDriver. These methods take a lock on all the rows in the table that match the project_id, loop through each record, adjust the usage amount, and then calls an UPDATE statement via the ORM in SQLalchemy. Again, all those loops are run while th21:57
leakypipese locks on the rows are held. This means that users in the same tenant cannot concurrently take actions that impact quotas.21:57
sdaguevs. just a select which could run in parallel21:58
leakypipesflashgordon: because user B will block waiting for user A's thread to release its locks on the usage records.21:58
leakypipesflashgordon: with the compare and swap technique, both threads can interleave their requests concurrently, and the window of time that a lock is held is reduced to its smallest possible period.21:59
flashgordonleakypipes: ahhh makes sense21:59
flashgordonleakypipes: so in theory randomizing the order of the resources being updated would help?22:00
leakypipesflashgordon: now, the compare and swap technique also has the benefit of "fixing" the SELECT FOR UPDATE problem that Galera has (Galera throws a certification timeout error when it detects two threads on two writer nodes have updated the same rows, and a SELECT FOR UPDATE in Galera only locks rows on the node that received the SELECT query.22:00
flashgordonat least in a pathological case22:00
sdagueleakypipes: any major concerns on races on update? or is that going to be healed in some offline manner?22:00
leakypipessdague: not really, no. say thread A and thread B are simultaneously launching an instance.22:01
flashgordonsdague leakypipes: now that we are consuming resources one at a time, I assume roll back will take care of things.22:01
flashgordonsay two instances being spawned at once, and there is enough memory quota for both but not enough CPU quota22:02
leakypipessdague: thread A gets to the quota reserve() part and reads the usage records. thread B does the same. thread A then attempts to update the usage record for a particular resource and project ID. it does so by issuing a SQL statement like so:22:02
flashgordonboth consume memory quota, one gets CPU, and the other undoes the memory quota usage?22:02
flashgordonand fails22:02
leakypipesUPDATE usages SET amount = <NEW_AMOUNT> WHERE project_id = <PROJECT> and resource_id = <REOURCE> and amount = <OLD_AMOUNT>22:03
sdagueleakypipes: right22:03
sdaguebut if we have two attempts there, the 2nd one won't increment the allocation22:03
leakypipessdague: if thread B happens to have been able to update that row before thread A, thread A will simply re-read the usage row and try again (after checking to see if the quota has been exceeded)22:03
leakypipessdague: the only time a lock is held is for the very brief time that the UPDATE statement is being executed on the MySQL server.22:04
sdagueoh, you'll check the row count on update, and if it's 0 retry?22:04
sdagueyep... that's even there in the spec22:04
sdagueI jumped past it22:05
sdaguevery good22:05
sdagueflashgordon: you should +2 that22:05
flashgordonleakypipes: what about the case where we hit quota limit, as I attempted to describe above22:05
flashgordonsdague: I want to, waiting for leakypipes to remove the TODO from the spec22:05
leakypipessdague: yes, exactly correct.22:05
flashgordonhttp://docs-draft.openstack.org/96/135296/2/check/gate-nova-specs-docs/f4b24fe/doc/build/html/specs/kilo/approved/lock-free-quota-management.html#work-items22:06
leakypipesflashgordon: then we raise Overlimit as per usual.22:06
leakypipesflashgordon: oh, crap... what TODO is left on that spec?22:06
flashgordonleakypipes: and for the request that failed, we undo the quota usage?22:06
flashgordoneven though it is partia22:06
flashgordonpartial22:06
sdagueflashgordon: it's like any Overlimit fail, you have to back track it all22:07
sdaguewhich we do terribly today22:07
sdaguewhich is a whole other can of worms22:07
leakypipesflashgordon: correct.22:07
sdaguebut this at least solves one problem22:07
flashgordonsdague: right, just making sure this doesn't make that worse.22:07
sdagueno22:07
flashgordonleakypipes: once you make that TODO go away, +2 from me22:08
flashgordonwow the quota logic is funny22:11
flashgordonit looks like we check for overquota in python not in sql22:11
flashgordonanyway this is a massive step in the right direction so huzzah22:13
openstackgerritOpenStack Proposal Bot proposed openstack/oslo.messaging: Updated from global requirements  https://review.openstack.org/14150922:20
*** e0ne is now known as e0ne_22:25
*** e0ne_ has quit IRC22:31
*** stevemar has joined #openstack-oslo22:36
*** gordc has quit IRC22:43
*** dimsum__ has quit IRC22:51
*** dimsum__ has joined #openstack-oslo22:52
*** dimsum__ has quit IRC22:57
*** vigneshvar has quit IRC23:00
*** tsekiyam_ has joined #openstack-oslo23:04
*** andreykurilin_ has joined #openstack-oslo23:07
*** tsekiyama has quit IRC23:08
*** tsekiyam_ has quit IRC23:09
*** ftcjeff has joined #openstack-oslo23:12
*** ftcjeff has quit IRC23:13
*** ajo_ has joined #openstack-oslo23:15
*** ajo has quit IRC23:15
openstackgerritMiguel Angel Ajo proposed openstack/oslo-incubator: Introduce fileutils ensure_dir creation mode parameter  https://review.openstack.org/14134823:22
ajo_repeating myself in a second...23:23
openstackgerritMiguel Angel Ajo proposed openstack/oslo-incubator: Introduce fileutils ensure_dir creation mode parameter  https://review.openstack.org/14134823:23
*** andreykurilin_ has quit IRC23:24
*** andreykurilin_ has joined #openstack-oslo23:25
*** ajo_ has quit IRC23:44
*** sabari is now known as zz_sabari23:46

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!