Wednesday, 2014-12-10

*** david-lyle is now known as david-lyle_afk00:11
*** andreykurilin_ has quit IRC00:12
*** andreykurilin_ has joined #openstack-oslo00:13
*** dims has quit IRC00:17
*** ViswaV has quit IRC00:18
*** dims has joined #openstack-oslo00:19
*** ViswaV has joined #openstack-oslo00:20
*** ViswaV has quit IRC00:25
*** ViswaV has joined #openstack-oslo00:25
*** dims has quit IRC00:30
*** noelbk has joined #openstack-oslo00:35
*** noelbk has quit IRC00:39
openstackgerritJoshua Harlow proposed openstack/tooz: Update links + python version supported  https://review.openstack.org/14054100:39
*** dims has joined #openstack-oslo00:43
*** dims has quit IRC01:11
*** zzzeek has quit IRC01:16
*** sabari is now known as zz_sabari01:25
*** tsekiyam_ has joined #openstack-oslo01:42
*** ViswaV has quit IRC01:44
*** andreykurilin_ has quit IRC01:44
*** tsekiyama has quit IRC01:46
*** tsekiyam_ has quit IRC01:46
*** oomichi_ has joined #openstack-oslo01:57
*** sigmavirus24_awa is now known as sigmavirus2402:09
*** harlowja has joined #openstack-oslo02:10
*** raildo_ has quit IRC02:24
*** prontotest has joined #openstack-oslo02:25
*** prontotest has left #openstack-oslo02:25
*** oomichi_ has quit IRC02:44
*** zz_sabari is now known as sabari02:54
*** harlowja is now known as harlowja_away03:12
*** _amrith_ is now known as amrith03:20
*** amotoki has joined #openstack-oslo03:28
*** sigmavirus24 is now known as sigmavirus24_awa03:31
*** oomichi_ has joined #openstack-oslo03:35
*** mtanino has quit IRC03:39
*** amotoki has quit IRC04:17
*** amotoki has joined #openstack-oslo04:34
*** harlowja_at_home has joined #openstack-oslo05:06
*** rpodolyaka2 has joined #openstack-oslo05:18
openstackgerritJoshua Harlow proposed openstack/tooz: Add driver autogenerated docs  https://review.openstack.org/14026305:19
openstackgerritJoshua Harlow proposed openstack/tooz: Add driver autogenerated docs  https://review.openstack.org/14026305:25
*** harlowja_away is now known as harlowja05:28
*** harlowja is now known as harlowja_away05:29
openstackgerritMerged openstack/taskflow: Remove rtype from task clone() doc  https://review.openstack.org/14026405:48
openstackgerritJoshua Harlow proposed openstack/oslo.utils: Add a deprecation helper/utility  https://review.openstack.org/14011906:03
openstackgerritJoshua Harlow proposed openstack/oslo.utils: Add a deprecation helper/utility  https://review.openstack.org/14011906:05
openstackgerritJoshua Harlow proposed openstack/oslo.utils: Add a deprecation helper/utility  https://review.openstack.org/14011906:07
openstackgerritOpenStack Proposal Bot proposed openstack/oslo.utils: Imported Translations from Transifex  https://review.openstack.org/13656606:12
*** harlowja_at_home has quit IRC06:37
*** oomichi_ has quit IRC06:46
openstackgerritMerged openstack/taskflow: Just assign a empty collection instead of copy/clear  https://review.openstack.org/14053007:05
*** e0ne has joined #openstack-oslo07:08
*** k4n0 has joined #openstack-oslo07:25
*** ViswaV has joined #openstack-oslo07:28
*** ViswaV_ has joined #openstack-oslo07:32
*** ViswaV has quit IRC07:32
*** dtantsur|afk is now known as dtantsur07:55
flaper87sileht: ping08:00
silehtflaper87, pong08:00
flaper87sileht: hey, good morning :)08:01
flaper87sileht: got few mins to talk about https://bugs.launchpad.net/oslo.messaging/+bug/128887808:01
flaper87?08:01
silehtyep08:01
flaper87cool08:01
flaper87so, I think it'd be worth to catch the clear failure and log a warning/error instead of blowing everything up onto user's faces08:02
flaper87I know you said you don't like the idea08:02
flaper87but I don't think the fact that it's a public API is a good reason not to do it08:02
flaper87actually, since it's a public API, we *have* to be more careful on how we communicate these things to users08:03
flaper87if we delete a localcontext that doesn't exist, we should we make it fail ?08:04
flaper87s/we/why/08:04
silehtflaper87, the issue is that only get_local_context should be public, clean/set should be private08:05
flaper87sileht: that I agree with, lets fix it :D, lets make them private and raise a warning08:06
flaper87then we'll remove them from the public API08:06
flaper87but until then, I think we shouldn't blow this up on user's face08:06
silehtflaper87, if the user cannot clear the localcontext it cannot get AttributeError (excepting if it have not monkeypatched correclty)08:07
flaper87sileht: exactly, that last bit is the one I'm worried about. I think, in this particular case, there's something we can do to make user's life easier08:09
flaper87Probably by moving forward with your original patch08:09
*** rpodolyaka2 has quit IRC08:10
silehtflaper87, my original patch will only hide the real issue, monkeypatching done after module have been loaded08:10
silehtflaper87, as eventlet says : 'It is important to call monkey_patch() as early in the lifetime of the application as possible'08:11
flaper87sileht: yup, I know that. My point is that we need to communicate this to the user before we get to the point of clearing the local context08:11
flaper87Otherwise, every user of oslo.messaging+eventlet will come to us with the same issue/questions08:11
flaper87and they'll all claim it's our fault08:11
flaper87The reason I moved that bug to confirmed again is because it's not the first time I get these complains08:12
flaper87Probably try/except is not the best solution there, as you mentioned. However, there must be something we can do to improve the user experience there08:12
silehtflaper87, I'm bit sad to write code just because people doesn't use eventlet correclty...08:14
openstackgerritJoshua Harlow proposed openstack/oslo.serialization: Deprecate substituting jsonutils as a anyjson reference impl  https://review.openstack.org/11784408:15
openstackgerritMerged openstack/oslo.utils: Imported Translations from Transifex  https://review.openstack.org/13656608:16
flaper87sileht: people doesn't use eventlet correctly becaue they don't know how to do it. If there's something we can do to help with that, I believe we should. I'm not saying we have to add hacks to avoid these errors but at least, there should be a warning somewhere telling the user that eventlet monkey_patch was not called when it was supposed to08:16
flaper87s/doesn't/don't/08:16
openstackgerritJoshua Harlow proposed openstack/oslo.serialization: Deprecate substituting jsonutils as a anyjson reference impl  https://review.openstack.org/11784408:16
silehtflaper87, a warning in the eventlet executor and some docs looks a good solution for me08:16
flaper87sileht: there you go, now we're talking :)08:17
flaper87ok, lets go with that08:17
flaper87I'll comment on the bug again with a gist of our discussion08:17
flaper87thanks for your time08:17
silehtflaper87, cool that08:17
silehtflaper87, cool thanks08:17
*** ViswaV_ has quit IRC08:23
*** stevemar has quit IRC08:25
*** oomichi has joined #openstack-oslo08:26
*** e0ne has quit IRC08:36
*** oomichi has quit IRC08:40
openstackgerritMehdi Abaakouk proposed openstack/oslo.messaging: Warns user if thread monkeypatch is not done  https://review.openstack.org/14061008:49
silehtflaper87, ^^08:50
flaper87sileht: awesome, thanks. You beat me on that08:50
openstackgerritMehdi Abaakouk proposed openstack/oslo.messaging: Fixes localcontext API  https://review.openstack.org/14061609:08
silehtflaper87, and the API deprecation ^^09:10
* sileht wanted to do that since a long time09:10
*** i159 has joined #openstack-oslo09:20
* flaper87 reviews that09:22
*** sabari is now known as zz_sabari09:26
openstackgerritVictor Sergeyev proposed openstack/oslo.db: Use PyMySQL as DB driver in py3 environment  https://review.openstack.org/13396209:33
*** ozamiatin has quit IRC09:38
*** e0ne has joined #openstack-oslo09:41
*** ihrachyshka has joined #openstack-oslo09:51
*** subscope has joined #openstack-oslo09:56
jokke_morning10:02
openstackgerritVictor Sergeyev proposed openstack/oslo.db: Use PyMySQL as DB driver in py3 environment  https://review.openstack.org/13396210:16
*** viktors|afk is now known as viktors10:20
openstackgerritMehdi Abaakouk proposed openstack/oslo.messaging: Fixes localcontext API  https://review.openstack.org/14061610:24
openstackgerritMehdi Abaakouk proposed openstack/oslo.messaging: Warns user if thread monkeypatch is not done  https://review.openstack.org/14061010:24
*** ihrachyshka_ has joined #openstack-oslo10:28
*** ihrachyshka has quit IRC10:30
*** amotoki has quit IRC10:51
*** andreykurilin_ has joined #openstack-oslo11:34
*** alexpilotti has joined #openstack-oslo11:35
*** inc0 has joined #openstack-oslo11:39
inc0dhellmann, ping11:41
*** vigneshvar has joined #openstack-oslo11:46
openstackgerritIlya Pekelny proposed openstack/oslo.db: Use alternative url string for Py3  https://review.openstack.org/13901511:57
*** e0ne has quit IRC12:00
*** david-lyle_afk is now known as david-lyle12:09
*** david-lyle is now known as david-lyle_afk12:17
*** david-lyle_afk is now known as david-lyle12:17
*** david-lyle is now known as david-lyle_afk12:23
*** david-lyle_afk is now known as david-lyle12:23
*** sgotliv has joined #openstack-oslo12:25
*** jaosorior has joined #openstack-oslo12:27
*** amotoki has joined #openstack-oslo12:29
*** david-lyle is now known as david-lyle_afk12:31
*** david-lyle_afk is now known as david-lyle12:31
*** e0ne has joined #openstack-oslo12:52
openstackgerritDoug Hellmann proposed openstack/oslo.config: Raise TemplateSubstitutionError from _substitute  https://review.openstack.org/14014312:54
dhellmanninc0: pong12:56
inc0hello dhellmann, I have question about oslo.versionedobjects12:56
dhellmannok12:57
inc0is there anything going on in this matter? I'm trying to prepare heat to introduce this12:57
dhellmanninc0: we haven't started working on it, yet. The spec is approved but we have a lot of other work happening right now.12:58
inc0do you have any vision of API to use? which parts will be in oslo and which will have to be implemented in every project?12:58
dhellmanninc0: I really don't know that code well yet. Have you talked to Dan?12:59
openstackgerritMerged openstack/oslo.messaging: rabbit: more precise iterconsume timeout  https://review.openstack.org/13998012:59
inc0what is his irc nick?12:59
dhellmanninc0: the API is described a bit in the spec: http://specs.openstack.org/openstack/oslo-specs/specs/kilo/adopt-oslo-versionedobjects.html12:59
dhellmanninc0: dansmith13:00
*** david-lyle is now known as david-lyle_afk13:00
inc0ok, I'll try to catch him, thanks13:00
*** kgiusti has joined #openstack-oslo13:03
*** tedross has joined #openstack-oslo13:04
openstackgerritMerged openstack/oslo.messaging: qpid: honor iterconsume timeout  https://review.openstack.org/13998113:04
openstackgerritMerged openstack/oslo.messaging: The executor doesn't need to set the timeout  https://review.openstack.org/13998213:05
openstackgerritDoug Hellmann proposed openstack/oslo.config: Set the version string  https://review.openstack.org/14067113:11
*** andreykurilin_ has quit IRC13:27
*** jeckersb is now known as jeckersb_gone13:27
*** vigneshvar has quit IRC13:28
*** amotoki_ has joined #openstack-oslo13:28
*** amrith is now known as _amrith_13:30
jd__flaper87: hint hint https://review.openstack.org/#/c/127923/13:40
* flaper87 clicks13:40
openstackgerritDoug Hellmann proposed openstack/oslo.concurrency: Clean up API documentation  https://review.openstack.org/14068013:40
viktorsjd__: hi! Can you please +2A a simple patch https://review.openstack.org/#/c/140291 ?13:45
openstackgerritMerged openstack/oslo-specs: Restore app-agnostic-logging-parameters spec  https://review.openstack.org/13255113:47
*** amotoki has quit IRC13:51
*** amotoki_ is now known as amotoki13:51
*** stevemar has joined #openstack-oslo13:54
openstackgerritDoug Hellmann proposed openstack/oslo.config: Stop sorting options on output  https://review.openstack.org/13648213:56
*** subscope has quit IRC14:08
*** subscope has joined #openstack-oslo14:21
*** jecarey has joined #openstack-oslo14:23
*** bknudson has joined #openstack-oslo14:23
*** mriedem has joined #openstack-oslo14:23
*** mjturek has joined #openstack-oslo14:23
*** jaypipes has joined #openstack-oslo14:29
*** mjturek has quit IRC14:31
dhellmannviktors: I have a question about oslo.db and glance, if you have a minute?14:33
dhellmannviktors: I am working on moving the oslo/db package to oslo_db. I have a traceback in a devstack log where glance is importing oslo.db in a way I don't understand: http://logs.openstack.org/87/138787/8/check/gate-tempest-dsvm-neutron-src-oslo.db/88772a7/logs/devstacklog.txt.gz14:33
dhellmannviktors: it does "from oslo import db" and then later "db.options.set_defaults()" but there is nothing in the oslo/db/__init__.py that would create an "options" and oslo/db/options.py is not being imported as far as I can tell14:34
dhellmannflaper87: maybe you have an idea about this, too? ^^14:35
* flaper87 clicks14:35
* flaper87 reads14:36
dhellmannflaper87: I don't understand how that glance code can be working with the released version of oslo.db.14:36
flaper87oh, mhhh...14:39
*** dims has joined #openstack-oslo14:39
viktorslooks really weird14:39
flaper87Python works mysterious ways14:39
flaper87Should I have put that in quotes?14:40
flaper87:P14:40
viktorsI'm not sure, that this file was executed )14:40
flaper87viktors: that was my guess as well but you need glance-mange to sync the db14:41
dhellmannflaper87: oh, how weird, if I run some other glance imports first it works: http://paste.openstack.org/show/148708/14:42
viktorsdhellmann: see http://paste.openstack.org/show/148709/14:42
dhellmannviktors: ah14:42
*** tsekiyama has joined #openstack-oslo14:42
viktorsdhellmann: have you got something?14:43
dhellmannno, I thought you had found some magic happening somewhere14:43
dhellmannit appears that we're relying on an import side-effect here, and that seems bad14:44
*** inc0 has quit IRC14:44
* flaper87 digging into this14:44
flaper87dhellmann: import side effect sounds like a nice way to say: "A very fucked-up attribute injection"14:45
flaper87:P14:45
* flaper87 stops ranting and digs more14:45
dhellmannthis looks like a python "feature": http://paste.openstack.org/show/148710/14:45
dhellmannflaper87: I think I'll submit a patch to glance to change the way that import works in the migration module, to not rely on this side-effect14:46
viktorsyes, it looks like, that we have "from oslo.db import options" before db.options usage14:46
dhellmannviktors: yes, something like that14:46
flaper87probably something related to the namespace thingy14:46
flaper87dhellmann: ok, if you want, I'll take care of that14:47
flaper87s/I'll/I can/14:47
dhellmannyeah, patch coming shortly14:47
flaper87ok14:47
* flaper87 waits, ready for review14:47
*** sgotliv has quit IRC14:53
*** pblaho has joined #openstack-oslo14:54
*** _amrith_ is now known as amrith14:55
dhellmannflaper87: https://review.openstack.org/14070914:57
dhellmannviktors: ^^14:57
flaper87dhellmann: +214:58
flaper87I'll wait for jenkins and ninja-approve if necessary14:58
dhellmannflaper87: ty; I'm blocked on that oslo.db namespace package change by this. I could have worked around it, but I think fixing this in glance is the more correct solution.14:59
openstackgerritMehdi Abaakouk proposed openstack/oslo.messaging: Warns user if thread monkeypatch is not done  https://review.openstack.org/14061015:03
*** dims has quit IRC15:05
*** dims has joined #openstack-oslo15:05
*** jeckersb_gone is now known as jeckersb15:08
*** sgotliv has joined #openstack-oslo15:10
*** dims has quit IRC15:10
*** mtanino has joined #openstack-oslo15:13
silehtdhellmann, does oslo.context have been released ?15:24
silehtdhellmann, according pypi yes, can I migrate to that version ?15:24
dhellmannsileht: yes, there is a 0.1.0 release of oslo.context15:25
dhellmannwe need to figure out what we need to add to it to make it work for oslo.messaging15:25
dhellmannto replace or supplement the API in oslo.messaging15:25
silehtdhellmann, I don't know who use the oslo.messaging localcontext but because get_local_context signature is broken and looks weird, I bet nobody15:27
dhellmannsileht: let's not make that assumption without checking :-)15:27
silehtdhellmann, the difference I see:15:27
sileht* the context was a dict it will because an object15:27
openstackgerritDoug Hellmann proposed openstack/oslo.vmware: Add pbr to installation requirements  https://review.openstack.org/13079015:28
sileht* the list of field is describe by oslo.context but before we just put the whole ctxt receive in rpccall/notification15:28
*** zz_jgrimm is now known as jgrimm15:29
sileht* and the thread cache of oslo.context is never cleaned15:29
silehtdhellmann, ^15:29
dhellmannsileht: the thread cache is cleaned when a new context is created15:29
dhellmannalthough I wonder if we should have some sort of explicit cleanup there15:29
silehtdhellmann, oslo.messaging create a greenthread each time a rpc message is dispatched15:30
dhellmannsileht: as far as I can tell, only oslo.messaging has references to get_local_context and set_local_context15:30
silehtdhellmann, yes15:30
dhellmannsileht: what sets the context for those threads?15:30
silehtdhellmann, the oslo/messaging/{rpc,notify}/dispatcher.py15:31
silehtdhellmann, this the context set when the client have use rpclient.call(CTXT, ....)15:32
dhellmannok, and is that a dictionary or is that an object?15:32
silehtdhellmann, a dictionnary15:32
dhellmannthe CTXT variable, I mean15:32
dhellmann:-(15:32
* sileht checks15:32
dhellmannok, this may be a longer-term change15:32
dhellmannpart of the idea for oslo.context was to have those instances directly usable by oslo.messaging, too15:33
silehtdhellmann, we can do that we a backward compatibility path15:33
dhellmannyeah15:34
silehtdhellmann, https://github.com/openstack/oslo.messaging/blob/master/oslo/messaging/_drivers/amqpdriver.py#L35815:34
dhellmannbut your point about having a lot more threads than I realized, and oslo.context never cleaning up, makes me think maybe we should do something about that15:34
dhellmannsileht: hahaha15:34
silehtdhellmann, yes this is the only blocking point15:34
dhellmannsileht: we have a bit of a conflict with the way the context is used elsewhere.15:35
* dhellmann goes to look at the nova code again15:35
*** gordc has joined #openstack-oslo15:35
dhellmannah, the store in nova uses weak references15:35
dhellmannand oslo.context only uses a threading.local15:36
dhellmannugh, did that weak local reference thing end up in concurrency?15:36
dhellmannoh, maybe we didn't put it anywhere15:37
openstackgerritRossella Sblendido proposed openstack/oslo.db: Retry query if db deadlock error is received  https://review.openstack.org/10954915:37
silehtdhellmann, it works is monkeypatching occurs before the threading.local is created15:37
silehtis/if15:37
dhellmannsileht: yes, I think we're assuming that15:38
dhellmannhowever, we have a memory leak, don't we? because things are added to the local store, but never removed -- does the thread code clean that up when a thread exits?15:38
silehtdhellmann, in oslo.messaging, no because we clean this store but for nova I think yes15:39
dhellmannright, I was asking in the general case how memory leaks are avoided with threading.local or the monkeypatched version15:40
silehtahah15:41
silehtfor rpc stuff only oslo.messaging known when the work starts and ends15:42
silehtfor wsgi stuff only only the wsgi controller known that15:42
dhellmanntrue15:42
silehtfor pecan we can add post_request hook15:42
silehtoslo.messaging already do the cleanup, but we have to update nova to use the context prepare by oslo.messaging15:43
silehtand nova have to switch to oslo.context first to not break averything15:43
dhellmannthat makes sense15:44
dhellmanncan oslo.messaging use the API in oslo.context to fetch the current context object? or does it need to have one passed explicitly?15:44
silehtoslo.messaging doesn't need the context15:45
dhellmann?15:45
dhellmannit has a context, but it's not the same now, and I thought it would be good for it to be the same15:46
dhellmanndo you mean it doesn't need the API in oslo.context for fetching the current context?15:46
dhellmannah, I see, the context in _dispatch() is coming from the message15:48
dhellmannthat makes sense15:48
silehtoslo.messaging doesn't really care about the context, the client send a dict, we serialize it, pass it throught the messaging broker, unserialize to a dict (or a helper method like nova does), and pass it the rpc endpoint AND make it availlable via localcontenxt.get_local_context15:48
*** inc0 has joined #openstack-oslo15:49
dhellmannsileht: on the receiving side, what turns that context dictionary into a context object that can be used by the application?15:50
dhellmannor is it just passed to the application code as a dictionary?15:50
dhellmannI see in _do_dispatch() something deserializes it and then the results are passed to the endpoint's method15:51
silehtdhellmann, the one in localcontext is a dict and the one passed to the application endpoint is a dict by default, but the application can set a hook15:51
silehtnova does this hook: https://github.com/openstack/nova/blob/master/nova/rpc.py#L11715:51
dhellmannok, cool15:52
dhellmannso oslo.messaging doesn't actually need to know about oslo.context, then15:52
silehtnop15:52
dhellmanncool. I don't think I would have done anything differently if I had known that earlier, but it's still good to know now.15:53
silehtI wonder if we could just drop oslo.messaging localcontext (after deprecation ;) )15:53
dhellmannsileht: well, we still need it for inside oslo.messaging don't we?15:54
dhellmannor do we always have an explicit reference to the context?15:54
silehtdhellmann, oslo.messaging set this local store in case of someone else want to get the context, but olso.messaging itself doesn't need that15:56
dhellmannsileht: ok, yes, we should get rid of that. oslo.context has that feature now15:57
silehtdhellmann, so I can deprecated everything and tell developper to use oslo.context so ?15:57
dhellmannsileht: yes15:58
silehtcool15:58
dhellmannsileht: harlowja_away is working on adding some nice developer-oriented deprecation tools to oslo.utils: https://review.openstack.org/14011915:58
dhellmannsileht: thanks for working through this with me; I have to step away for a bit, but I feel a lot better about my understanding of how the context works in oslo.messaging now.16:00
silehtdhellmann, welcome16:02
*** inc0 has quit IRC16:04
silehtdhellmann, harlowja_away I wonder if we can complete the docstring with deprecated stuff for the sphinx documentation16:08
*** dtantsur is now known as dtantsur|brb16:10
openstackgerritMehdi Abaakouk proposed openstack/oslo.messaging: Deprecates this localcontext API  https://review.openstack.org/14061616:13
*** amrith is now known as _amrith_16:13
dhellmannsileht: I'm not sure what you mean?16:16
*** rpodolyaka2 has joined #openstack-oslo16:17
*** e0ne_ has joined #openstack-oslo16:18
silehtdhellmann, automatically adding text that says a method is deprecated in favor in something else in the dev documentation16:19
*** e0ne has quit IRC16:19
*** rpodolyaka2 has quit IRC16:19
dhellmannsileht: oh, nice, I like that idea16:19
silehtI don't know how works sphinx but perhaps it's doable16:20
dhellmannsileht: I'll have to think about it. If the decorator adds information to the function, we should be able to get to it from sphinx.16:20
*** rpodolyaka2 has joined #openstack-oslo16:22
flaper87dhellmann: the patch failed on py2716:26
flaper87I think some mock needs to be updated16:26
dhellmannflaper87: looking16:27
dhellmannflaper87: can I run only some of the glance tests? I tried "tox -e py27 -- test_cache_middleware", but it seems to be running them all16:29
*** e0ne_ is now known as e0ne16:30
*** dims has joined #openstack-oslo16:32
*** sgotliv has quit IRC16:32
flaper87dhellmann: I normally use nosetest for that :/16:32
dhellmannflaper87: ok, I'll try that16:32
dhellmannI know we have oslo setup for that, so maybe I can make that patch for glance, too16:32
dhellmannafter lunch :-)16:32
*** _amrith_ is now known as amrith16:33
flaper87there's run_tests as well but I don't like that script much16:33
flaper87:D16:33
*** jaosorior has quit IRC16:33
openstackgerritMerged openstack/oslo-incubator: Delete graduated concurrency files  https://review.openstack.org/12279616:34
*** subscope has quit IRC16:35
*** zzzeek has joined #openstack-oslo16:35
*** dims has quit IRC16:36
*** dims has joined #openstack-oslo16:36
zzzeekviktors: new version of the fix at https://review.openstack.org/#/c/139738/16:40
*** vigneshvar has joined #openstack-oslo16:41
viktorszzzeek: hey! Just tested this on devstack16:42
zzzeekim sure it did somethign different, whether or not it worked16:43
*** ihrachyshka_ has quit IRC16:44
*** sgotliv has joined #openstack-oslo16:44
*** tsekiyama has quit IRC16:44
viktorszzzeek: yes, I already tested with conn.execute("select 1")  and it's works fine with your fix16:45
zzzeekviktors: i moved the event handling right into the moment it connects inside the pool, there’s no way it can be missed :)16:45
zzzeekviktors: it can just potentially break other crap if i missed anything.  but it’s doing what 1.0 does16:46
*** zhiyan has quit IRC16:46
*** jraim has quit IRC16:48
viktorszzzeek: hm.... There is seems to be something wrong - please look at http://paste.openstack.org/show/148787/16:48
zzzeekviktors: ah i know waht that is and i think that affects SQLA 1.0 also :)  will fix16:50
*** subscope has joined #openstack-oslo16:51
viktorszzzeek: thanks a lot for your work on this :)16:51
zzzeekya16:51
*** zz_sabari is now known as sabari16:53
*** sigmavirus24_awa is now known as sigmavirus2416:53
zzzeekviktors: this is great stuff16:53
openstackgerritMerged openstack/oslo.db: Fix TestConnectionUtils to py3x compatibility  https://review.openstack.org/14029116:54
openstackgerritMerged openstack/oslo.messaging: Warns user if thread monkeypatch is not done  https://review.openstack.org/14061016:54
openstackgerritMerged openstack/oslo.vmware: Add pbr to installation requirements  https://review.openstack.org/13079016:54
viktorszzzeek: we supposed to retry db-api queries on disconnect, so DBConnectionError should indicate `db-gone-away` situation16:57
viktorsalso sometimes I see patches like this - https://review.openstack.org/#/c/12211416:57
*** amrith is now known as _amrith_16:58
*** viktors is now known as viktors|afk17:00
*** amotoki has quit IRC17:02
openstackgerritOpenStack Proposal Bot proposed openstack/oslo.vmware: Updated from global requirements  https://review.openstack.org/13994517:03
*** i159 has quit IRC17:05
*** david-lyle_afk is now known as david-lyle17:06
*** e0ne has quit IRC17:12
*** k4n0 has quit IRC17:12
openstackgerritMichael Bayer proposed openstack/oslo.db: Ensure DBConnectionError is raised on failed revalidate  https://review.openstack.org/13973817:20
zzzeekviktors|afk: if you’re still there, try it again17:20
zzzeekviktors|afk: fixed that17:20
*** zzzeek has quit IRC17:25
*** zzzeek has joined #openstack-oslo17:25
*** jaypipes has quit IRC17:26
*** dtantsur|brb is now known as dtantsur17:27
*** sabari is now known as zz_sabari17:30
*** tedross has quit IRC17:35
openstackgerritOpenStack Proposal Bot proposed openstack/oslo.concurrency: Updated from global requirements  https://review.openstack.org/14078017:36
*** ihrachyshka has joined #openstack-oslo17:38
*** sigmavirus24 is now known as sigmavirus24_awa17:40
*** jraim has joined #openstack-oslo17:41
*** ihrachyshka has quit IRC17:42
*** amotoki has joined #openstack-oslo17:49
*** amotoki_ has joined #openstack-oslo17:50
*** stevemar has quit IRC17:50
*** andreykurilin_ has joined #openstack-oslo17:53
*** amotoki_ has quit IRC17:54
*** amotoki has quit IRC17:54
*** tsekiyama has joined #openstack-oslo17:55
*** tsekiyama has quit IRC18:00
*** _amrith_ is now known as amrith18:03
*** ViswaV has joined #openstack-oslo18:07
*** zhiyan has joined #openstack-oslo18:09
*** zz_sabari is now known as sabari18:18
*** ViswaV has quit IRC18:19
*** ViswaV has joined #openstack-oslo18:19
*** e0ne has joined #openstack-oslo18:25
*** sabari is now known as zz_sabari18:25
*** ViswaV has quit IRC18:26
*** ViswaV has joined #openstack-oslo18:26
*** harlowja_away is now known as harlowja18:31
harlowjasileht dhellmann  hmmm, sphinx documentation plugin somehow, likely possible, i think dhellmann  is more of the expert on that stuff than me :)18:33
*** pradk has joined #openstack-oslo18:36
harlowja*more of an expert on sphinx that is18:39
harlowjasileht check out https://review.openstack.org/#/c/140119/ ; that can be the start of useful patterns for folks18:40
harlowjathe tests included in that have some examples of how to use it..18:41
harlowjahopefully useful for some folks18:45
*** pblaho has quit IRC18:45
harlowjazzzeek u might be a useful reviewer of that also ;018:45
harlowja;)18:45
*** rpodolyaka2 has quit IRC18:50
*** viktors1 has joined #openstack-oslo18:52
*** rpodolyaka2 has joined #openstack-oslo18:52
viktors1harlowja: hi!18:53
harlowjaviktors1 yo yo18:53
viktors1harlowja: do you plan to maintain patch https://review.openstack.org/#/c/120198/ ? It should make py3 tests green =)18:54
harlowjasure i can update18:54
viktors1thanks!18:55
harlowjanp18:55
*** viktors1 has quit IRC18:57
jogodims: https://bugs.launchpad.net/neutron/+bug/139978818:57
dimsjogo: back to back stuff today, subscribed to it19:01
jogodims: thanks, it looks like it *may* be an oslo-incubator related issue but not sure19:02
dimsjogo: ack19:03
harlowjadhellmann do u have any time to look over https://review.openstack.org/#/c/135146/ again (this time with super-docs)19:04
*** gordc has quit IRC19:06
*** jaypipes has joined #openstack-oslo19:07
*** zz_sabari is now known as sabari19:07
dhellmannharlowja: I'll put it on my list for today or tomorrow19:07
harlowjathx19:07
*** sabari is now known as zz_sabari19:09
*** andreykurilin_ has quit IRC19:09
*** tsekiyama has joined #openstack-oslo19:11
*** zz_sabari is now known as sabari19:12
*** gordc has joined #openstack-oslo19:13
jogojd__: making sure you know you are hacking core (now that oslo-core is removed) https://review.openstack.org/#/admin/groups/153,members19:16
harlowjadhellmann dims jd__ and any others http://lists.openstack.org/pipermail/openstack-dev/2014-December/052688.html19:17
harlowjaif that date not good, let me know, or respond and can adjust...19:17
openstackgerritJoshua Harlow proposed openstack/oslo.db: Fix more invalid encoding and scoping issues  https://review.openstack.org/12019819:20
harlowjaviktors|afk updated, but i'm still getting stuff like http://paste.ubuntu.com/9466228/ in 3.419:21
harlowjathats using19:22
harlowjaSQLAlchemy==0.9.819:22
harlowjasqlalchemy-migrate==0.9.119:22
palendaedhellmann: Seeing as you're getting into the cmd2 maintenance and I only see neutronclient using cliff, is it worth the effort still to investigate removing the cmd2 dependency from cliff?19:23
dhellmannpalendae: python-openstackclient also uses cliff -- that's actually why I wrote cliff to begin with19:25
palendaeAh, ok, missed that one19:25
palendaeI was looking at each service19:25
dhellmannpalendae: the neutron team created their client with the idea that the plugins would be compatible with the unified client, but I think we reimplemented the commands to make them consistent with the design of the other commands there19:25
dhellmannpalendae: https://github.com/dhellmann/aeromancer19:26
dhellmann(skunkworks project)19:26
harlowjanot so skunkworks anymore, muhahaha19:26
harlowjalol19:26
palendaeAll the readme links 404, fyi :)19:26
dhellmannheh, the readme is empty -- if you install that and run it against a copy of all of the openstack code, you can ask it questions about openstack projects19:26
palendaeCool19:26
palendaeThat's....a lot of code19:27
dhellmannyeah, those will work when I make it a real stackforge project19:27
dhellmannyeah, I'm using it as an excuse to relearn a alembic and sqlalchemy19:27
palendaeFair enough19:27
palendaeI should do something like that too, lots of time buried in Ansible lately19:27
dhellmannalthough I've been tempted to throw that out and use elasticsearch instead19:27
jd__jogo: yes I added mysefl19:31
jd__jogo: I didn't bother to ask sorry :)19:31
jogojd__: ahhh that is fine, but a heads up would have been appreciated19:31
jogojd__: glad to have more people on the team19:32
jd__my bad :)19:32
dimsharlowja: lgtm (17th)19:35
*** sabari is now known as zz_sabari19:39
*** dtantsur is now known as dtantsur|afk19:40
harlowjadims cools19:41
*** zz_sabari is now known as sabari19:44
*** ViswaV has quit IRC19:54
dhellmannflaper87: I can't make that test fail locally, so I'm going to recheck the patch.19:54
*** sabari is now known as zz_sabari19:57
*** zz_sabari is now known as sabari19:57
*** sgotliv has quit IRC20:00
*** dims has quit IRC20:02
*** kgiusti has quit IRC20:04
*** kgiusti has joined #openstack-oslo20:06
dhellmannflaper87: failed again :-/20:08
harlowjadhellmann sileht https://github.com/twisted/twisted/blob/trunk/twisted/python/deprecate.py is also similar to the code in that review (or at least has somewhat similar capabilities); useful to see other projects deprecation patterns...20:10
harlowjai believe https://github.com/twisted/twisted/blob/trunk/twisted/python/deprecate.py#L119 is simlar to the docstring modification...20:10
harlowjathat and https://github.com/twisted/twisted/blob/trunk/twisted/python/deprecate.py#L21320:10
dhellmannharlowja: did you happen to look on pypi for a library that does this sort of thing?20:11
harlowjai think i did, from what i remember20:11
harlowjadon't think i found much of anything20:11
dhellmannit's hard to search for "deprecate"; lots of hits for actual deprecated modules20:11
harlowjaya, i think i remember looking for deprecation utils or something, pretty sure i tried to find something, lol20:11
harlowjasome other guy in my team i think also looked20:12
dhellmannyeah, just seeing 2 modules doing this work made me think maybe it's worth having it stand on its own20:12
harlowjaagreed20:12
harlowjaits confusing also to me why python doesn't provide such patterns somewhere20:12
dhellmannthere's nothing really "oslo-y" about that implementation, right?20:12
harlowjanopers20:12
harlowjau can make up a snappy name for it :-P20:13
harlowjai'm not so good at names, lol20:13
harlowjahttps://pypi.python.org/pypi/zope.deprecation is close, but u know zope20:13
dhellmannhow about baggage, as in "we're carrying this code as baggage"20:13
harlowjai guess oslo.utils isn't much better, ha20:13
dhellmannharlowja: yeah, we chose that on purpose to scare away outside users :-)20:14
harlowja;)20:14
harlowjai bet the zope people did the same, lol20:14
dhellmannI think at the time the namespacing was considered a feature20:14
harlowjahmmm, https://pypi.python.org/pypi/baggage doesn't exist +120:14
flaper87dhellmann: I'll take a look20:14
dhellmannflaper87: it's not obvious that the test in question is mocking anything20:15
dhellmannwell, not anything related to the code I'm actually changing -- a couple of import statements20:15
dhellmannharlowja, ironically "deprecate" is available on pypi so you could just use that :-)20:16
harlowjalo20:16
harlowjalol20:16
*** sabari is now known as zz_sabari20:16
dhellmannharlowja: we could make this a new oslo lib, but release it outside of utils if you want20:16
harlowjahmmm, baggage or deprecate, hmmm20:16
harlowjadhellmann sure, i'm ok with that20:17
dhellmannharlowja: or how about "debtcollector"20:17
harlowjalol20:17
harlowjato many options :-P20:17
dhellmannrepoman is taken20:17
harlowjahttps://pypi.python.org/pypi/deprecation is also free, weird20:17
harlowjanobody deprecates stuff i guess20:18
harlowjalol20:18
dhellmannooh, bagman isn't taken20:18
dhellmannmeh, debtcollector seems better20:18
harlowjahmmm, i'm fine with whatever u guys want20:18
harlowja:-P20:18
dhellmannhow about a ML thread? I think we have a bunch of cores offline for travel or at sprints or things, so I'm not sure we're going to get consensus here in the chat room today20:19
harlowjaagreed, and that durn xmas20:19
harlowjawill send20:19
dhellmanncoming up fast20:19
harlowjaalright, sendin ML out20:20
dhellmannharlowja: cool, thanks20:21
harlowjasent @ http://lists.openstack.org/pipermail/openstack-dev/2014-December/052692.html20:27
jamespagedhellmann, sileht: hey20:29
jamespagewould you guys have time to re-review https://review.openstack.org/#/c/128233/ - getting alot of left-a-bit right-a-bit now20:29
*** rpodolyaka2 has quit IRC20:32
dhellmannjamespage: looking20:35
openstackgerritRodrigo Duarte proposed openstack/oslo-specs: Graduate Policy  https://review.openstack.org/14016120:36
jamespagedhellmann, ta20:36
dhellmannjamespage: regarding the log.error vs log.exception call in impl_zmq.py line 628 -- is mm.unregister() calling out to some other library, or is that more of our code?20:38
dhellmannit doesn't seem like a traceback is going to be useful there20:38
jogopossible oslo.messaging bug https://bugs.launchpad.net/oslo.messaging/+bug/139318220:40
harlowjadhellmann another possibility of a new oslo library is that automaton stuff20:41
dhellmannharlowja: yep20:41
dhellmannharlowja: one at a time, though :-)20:41
harlowjabasically to avoid https://review.openstack.org/#/c/139215/ from diverging to much ...20:41
dhellmannjamespage: +2 with comments20:42
dhellmannjogo: looking20:42
openstackgerritJoshua Harlow proposed openstack/oslo.messaging: Add a thread + futures executor based executor  https://review.openstack.org/7091420:42
jogodhellmann: thanks20:43
dhellmannjogo: I'm not sure why you think that's a messaging bug? It looks like the driver is having trouble connecting to rabbit there20:43
dhellmannwe might need sileht to take a look, though, I'm far from an expert at the messaging stuff20:44
dhellmannjogo: "error: [Errno 104] Connection reset by peer"20:44
*** ViswaV has joined #openstack-oslo20:44
jogodhellmann: it may not be20:44
jogobut thought it would be good to rule it out as a possibility20:45
jogohmm I should be able to reproduce this easily actually20:45
*** rpodolyaka2 has joined #openstack-oslo20:47
dhellmannharlowja: if your oslo.utils requirements bump doesn't get another +2a after the tests pass let me know and I'll re-approve -- it was just rebased, right?20:48
dhellmannjogo: ok, thanks20:48
harlowjadhellmann ya, someone modified oslo.vmware or something20:48
dhellmannharlowja: weird that gerrit/zuul/whatever couldn't resolve that conflict20:49
harlowjai'm gonna say its linus fault20:49
harlowjalol20:49
dhellmannheh20:50
*** dims has joined #openstack-oslo21:03
*** amrith is now known as _amrith_21:06
*** dims has quit IRC21:08
openstackgerritJoshua Harlow proposed openstack/taskflow: Add a helper callback class triggered on task events  https://review.openstack.org/14083821:13
*** zz_sabari is now known as sabari21:13
*** dims has joined #openstack-oslo21:17
openstackgerritRodrigo Duarte proposed openstack/oslo-specs: Graduate Policy  https://review.openstack.org/14016121:18
*** kgiusti has quit IRC21:23
*** denis_makogon_ has joined #openstack-oslo21:26
*** tedross has joined #openstack-oslo21:27
*** denis_makogon has quit IRC21:31
*** denis_makogon_ is now known as denis_makogon21:31
*** dmakogon_ has joined #openstack-oslo21:32
*** jecarey has quit IRC21:38
*** rpodolyaka2 has quit IRC21:53
*** sabari is now known as zz_sabari21:54
*** zz_sabari is now known as sabari21:55
openstackgerritMerged openstack/oslo.vmware: Updated from global requirements  https://review.openstack.org/13994521:57
*** ViswaV has quit IRC22:01
*** sabari is now known as zz_sabari22:07
*** tedross has quit IRC22:08
*** zz_sabari is now known as sabari22:10
harlowjadhellmann i'll write up that spec, maybe later this week for the deprecation thing, will see if anyone really objects to that on ML first22:10
harlowjaor should i wait longer ?22:11
*** _amrith_ is now known as amrith22:17
*** jeckersb is now known as jeckersb_gone22:21
*** andreykurilin_ has joined #openstack-oslo22:25
openstackgerritgordon chung proposed openstack/oslo.messaging: Implements notification-dispatcher-filter  https://review.openstack.org/7788622:28
openstackgerritgordon chung proposed openstack/oslo.messaging: Implements notification-dispatcher-filter  https://review.openstack.org/7788622:32
*** mriedem has left #openstack-oslo22:44
*** ViswaV has joined #openstack-oslo22:47
*** vigneshvar has quit IRC22:59
dhellmannharlowja: whenever you're ready23:07
harlowjak23:07
dhellmannharlowja: benemec is out this week, but I don't imagine he'll object. if he does, he can comment on the spec23:07
harlowjakk23:07
dhellmannlook at the graduation template, that's probably closest to what you want23:08
harlowjasures23:08
harlowjathx23:08
openstackgerritJoshua Harlow proposed openstack/taskflow: Tidy up the WBE cache (now WBE types) module  https://review.openstack.org/10324523:22
*** gordc has quit IRC23:23
*** raildo_ has joined #openstack-oslo23:24
*** pradk has quit IRC23:29
*** jeckersb_gone is now known as jeckersb23:31
*** ViswaV has quit IRC23:32
*** sabari is now known as zz_sabari23:51
*** zz_sabari is now known as sabari23:51

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!