| *** boden has quit IRC | 00:00 | |
| *** mriedem has left #openstack-oslo | 00:02 | |
| *** mriedem has quit IRC | 00:02 | |
| *** jecarey_ has joined #openstack-oslo | 00:27 | |
| *** jecarey has quit IRC | 00:29 | |
| *** harlowja_at_home has quit IRC | 00:54 | |
| *** boden has joined #openstack-oslo | 00:56 | |
| *** dims has joined #openstack-oslo | 00:59 | |
| *** boden has quit IRC | 01:01 | |
| *** yamahata has joined #openstack-oslo | 01:13 | |
| *** harlowja_at_home has joined #openstack-oslo | 01:26 | |
| *** dims has quit IRC | 01:26 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 01:27 | |
| *** dims has joined #openstack-oslo | 01:30 | |
| *** dims_ has joined #openstack-oslo | 01:31 | |
| harlowja_at_home | if u guys get a few minutes free could u look over https://review.openstack.org/#/c/120168/ and https://review.openstack.org/#/c/122951/ (requirements related changes) | 01:32 |
|---|---|---|
| harlowja_at_home | thx much! | 01:32 |
| *** dims has quit IRC | 01:35 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 01:40 | |
| *** dims_ has quit IRC | 01:40 | |
| *** dims has joined #openstack-oslo | 01:41 | |
| *** dims has quit IRC | 01:45 | |
| *** boden has joined #openstack-oslo | 01:57 | |
| *** boden has quit IRC | 02:02 | |
| *** amrith is now known as _amrith_ | 02:16 | |
| *** _amrith_ is now known as amrith | 02:18 | |
| *** takedakn has joined #openstack-oslo | 02:19 | |
| *** harlowja_at_home has quit IRC | 02:21 | |
| *** amrith is now known as _amrith_ | 02:36 | |
| *** boden has joined #openstack-oslo | 02:58 | |
| *** takedakn has quit IRC | 03:00 | |
| *** takedakn has joined #openstack-oslo | 03:00 | |
| *** takedakn has quit IRC | 03:02 | |
| *** _amrith_ is now known as amrith | 03:02 | |
| *** takedakn has joined #openstack-oslo | 03:02 | |
| *** boden has quit IRC | 03:03 | |
| *** takedakn has quit IRC | 03:07 | |
| *** shakamunyi has joined #openstack-oslo | 03:24 | |
| *** jaypipes has joined #openstack-oslo | 03:25 | |
| *** noelbk has quit IRC | 03:31 | |
| *** boden has joined #openstack-oslo | 03:59 | |
| *** shakamunyi has quit IRC | 04:00 | |
| *** boden has quit IRC | 04:03 | |
| *** sheeprine has quit IRC | 04:17 | |
| *** sheeprine has joined #openstack-oslo | 04:19 | |
| *** dims has joined #openstack-oslo | 04:41 | |
| *** dims has quit IRC | 04:46 | |
| *** boden has joined #openstack-oslo | 05:00 | |
| *** boden has quit IRC | 05:04 | |
| *** harlowja_at_home has joined #openstack-oslo | 05:05 | |
| *** noelbk has joined #openstack-oslo | 05:07 | |
| *** rpodolyaka1 has joined #openstack-oslo | 05:30 | |
| *** noelbk has quit IRC | 05:43 | |
| *** takedakn has joined #openstack-oslo | 05:48 | |
| *** boden has joined #openstack-oslo | 06:00 | |
| *** takedakn has quit IRC | 06:01 | |
| *** harlowja_at_home has quit IRC | 06:04 | |
| *** flaper87 has quit IRC | 06:05 | |
| *** flaper87 has joined #openstack-oslo | 06:05 | |
| *** boden has quit IRC | 06:05 | |
| *** rpodolyaka1 has quit IRC | 06:06 | |
| *** k4n0 has joined #openstack-oslo | 06:20 | |
| *** e0ne has joined #openstack-oslo | 06:28 | |
| *** e0ne has quit IRC | 06:30 | |
| *** e0ne has joined #openstack-oslo | 06:34 | |
| *** e0ne has quit IRC | 06:36 | |
| *** e0ne has joined #openstack-oslo | 06:40 | |
| *** e0ne has quit IRC | 06:43 | |
| *** vigneshvar has joined #openstack-oslo | 06:45 | |
| *** e0ne has joined #openstack-oslo | 06:47 | |
| *** e0ne has quit IRC | 06:49 | |
| *** andreykurilin_ has joined #openstack-oslo | 06:59 | |
| *** boden has joined #openstack-oslo | 07:01 | |
| *** boden has quit IRC | 07:06 | |
| *** ihrachyshka has joined #openstack-oslo | 07:19 | |
| *** e0ne has joined #openstack-oslo | 07:29 | |
| *** ihrachyshka_ has joined #openstack-oslo | 07:30 | |
| *** ihrachyshka has quit IRC | 07:33 | |
| *** e0ne has quit IRC | 07:38 | |
| *** e0ne has joined #openstack-oslo | 07:40 | |
| *** andreykurilin_ has quit IRC | 07:44 | |
| *** e0ne has quit IRC | 08:13 | |
| *** e0ne has joined #openstack-oslo | 08:16 | |
| *** boden has joined #openstack-oslo | 08:27 | |
| *** k4n0 has quit IRC | 08:33 | |
| *** pblaho has joined #openstack-oslo | 08:35 | |
| *** i159 has joined #openstack-oslo | 08:39 | |
| *** liusheng has joined #openstack-oslo | 08:48 | |
| *** k4n0 has joined #openstack-oslo | 08:51 | |
| *** sreshetnyak has joined #openstack-oslo | 09:23 | |
| *** ihrachyshka_ has quit IRC | 09:23 | |
| *** ozamiatin has quit IRC | 09:23 | |
| *** e0ne has quit IRC | 09:24 | |
| *** e0ne has joined #openstack-oslo | 09:26 | |
| *** k4n0 has quit IRC | 09:44 | |
| *** pblaho has quit IRC | 09:48 | |
| *** pblaho has joined #openstack-oslo | 09:49 | |
| *** pcm_ has joined #openstack-oslo | 10:13 | |
| *** pcm_ has quit IRC | 10:15 | |
| *** pcm_ has joined #openstack-oslo | 10:15 | |
| *** ihrachyshka has joined #openstack-oslo | 10:20 | |
| *** k4n0 has joined #openstack-oslo | 10:29 | |
| *** yamahata has quit IRC | 10:37 | |
| *** e0ne has quit IRC | 10:43 | |
| *** amrith is now known as _amrith_ | 10:54 | |
| *** dims has joined #openstack-oslo | 10:59 | |
| *** shakamunyi has joined #openstack-oslo | 11:17 | |
| *** shakamunyi has quit IRC | 11:20 | |
| *** zz_jgrimm is now known as jgrimm | 11:33 | |
| *** e0ne has joined #openstack-oslo | 11:42 | |
| *** tedross has joined #openstack-oslo | 11:48 | |
| *** e0ne has quit IRC | 11:50 | |
| *** e0ne has joined #openstack-oslo | 11:58 | |
| *** kgiusti has joined #openstack-oslo | 12:01 | |
| *** openstackgerrit has joined #openstack-oslo | 12:14 | |
| *** boden has quit IRC | 12:30 | |
| *** boden has joined #openstack-oslo | 12:30 | |
| *** jeckersb_gone is now known as jeckersb | 12:32 | |
| *** dims has quit IRC | 12:38 | |
| *** dims has joined #openstack-oslo | 12:38 | |
| *** liusheng has quit IRC | 12:39 | |
| *** gordc has joined #openstack-oslo | 12:39 | |
| openstackgerrit | Andrey Pavlov proposed a change to openstack/oslo.messaging: Declare queue in publisher also. https://review.openstack.org/123115 | 12:51 |
| *** vigneshvar has quit IRC | 12:54 | |
| *** tedross has quit IRC | 12:56 | |
| openstackgerrit | Andrey Pavlov proposed a change to openstack/oslo.messaging: Declare queue in publisher also. https://review.openstack.org/123115 | 12:57 |
| *** miqui has joined #openstack-oslo | 13:00 | |
| openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo-incubator: Delete graduated db files https://review.openstack.org/122808 | 13:02 |
| *** tedross has joined #openstack-oslo | 13:11 | |
| *** bknudson has quit IRC | 13:21 | |
| *** mriedem has joined #openstack-oslo | 13:24 | |
| *** jeckersb is now known as jeckersb_gone | 13:29 | |
| *** yassine has joined #openstack-oslo | 13:31 | |
| openstackgerrit | Jeremy Stanley proposed a change to openstack/oslotest: Work toward Python 3.4 support and testing https://review.openstack.org/118796 | 13:31 |
| *** yassine has quit IRC | 13:36 | |
| *** jeckersb_gone is now known as jeckersb | 13:40 | |
| openstackgerrit | A change was merged to openstack/oslo.concurrency: Imported Translations from Transifex https://review.openstack.org/123051 | 13:42 |
| *** zzzeek has joined #openstack-oslo | 13:42 | |
| *** pblaho has quit IRC | 13:42 | |
| *** yassine has joined #openstack-oslo | 13:50 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 13:53 | |
| *** jaosorior has joined #openstack-oslo | 13:54 | |
| *** bknudson has joined #openstack-oslo | 13:56 | |
| dims | dhellmann: splitting out openstack.common.report looks to me like a low hanging fruit | 14:03 |
| openstackgerrit | Andreas Jaeger proposed a change to openstack/oslo.db: Update help string to use database https://review.openstack.org/120204 | 14:07 |
| *** mtanino has joined #openstack-oslo | 14:17 | |
| *** k4n0 has quit IRC | 14:19 | |
| *** yamahata has joined #openstack-oslo | 14:23 | |
| *** jecarey_ has quit IRC | 14:24 | |
| *** cfriesen_ has quit IRC | 14:26 | |
| *** cfriesen_ has joined #openstack-oslo | 14:26 | |
| *** Kiall has quit IRC | 14:39 | |
| *** Kiall has joined #openstack-oslo | 14:43 | |
| *** rpodolyaka1 has joined #openstack-oslo | 14:44 | |
| dhellmann | dims: I think I agree, although I'm not sure how stable it is. Maybe iteration would be easier outside of the incubator, though. | 14:46 |
| *** tsekiyama has joined #openstack-oslo | 14:53 | |
| *** jecarey has joined #openstack-oslo | 14:54 | |
| dims | dhellmann: only nova is using it at this point from what i can tell | 15:01 |
| dims | dhellmann: shared a spreadsheet with some notes as a first pass | 15:02 |
| dhellmann | dims: looking now | 15:03 |
| dims | Anyone else wants to look, plz let me know your gmail address. (trying to help doug with next set of oslo libs) | 15:04 |
| dhellmann | dims: don't forget https://wiki.openstack.org/wiki/Oslo/GraduationStatus and https://wiki.openstack.org/wiki/Oslo/Dependencies | 15:05 |
| dhellmann | some of the analysis we did during icehouse is probably still relevant, though worth revisiting | 15:05 |
| dims | dhellmann: ack will revisit those | 15:06 |
| openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.config: do not use colons in section titles https://review.openstack.org/123154 | 15:13 |
| dhellmann | dims: maybe you can make a new column for what we thought we'd do originally, to make it easier to compare? | 15:17 |
| *** tedross has quit IRC | 15:20 | |
| *** kragniz has quit IRC | 15:24 | |
| *** ihrachyshka has quit IRC | 15:24 | |
| *** rpodolyaka1 has quit IRC | 15:31 | |
| dims | dhellmann: ack | 15:33 |
| *** kragniz has joined #openstack-oslo | 15:35 | |
| *** rpodolyaka1 has joined #openstack-oslo | 15:38 | |
| *** tedross has joined #openstack-oslo | 15:38 | |
| *** rpodolyaka1 has quit IRC | 15:43 | |
| dhellmann | dims: and thank you for starting to look at this; it'll be another few days before I think I could have started it | 15:45 |
| openstackgerrit | Andrey Pavlov proposed a change to openstack/oslo.messaging: Declare queue in publisher also https://review.openstack.org/123115 | 15:57 |
| *** AAzza is now known as AAzza_afk | 15:58 | |
| *** rpodolyaka1 has joined #openstack-oslo | 15:59 | |
| *** rpodolyaka1 has quit IRC | 16:00 | |
| dims | dhellmann: yw! i have a new column now. will try to figure out cross dependencies later today | 16:01 |
| *** rpodolyaka1 has joined #openstack-oslo | 16:02 | |
| *** i159 has quit IRC | 16:09 | |
| *** AAzza_afk is now known as AAzza | 16:15 | |
| *** e0ne has quit IRC | 16:17 | |
| *** noelbk has joined #openstack-oslo | 16:19 | |
| dhellmann | dims: this may be useful: https://github.com/dhellmann/oslo-dependencies | 16:19 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Fix multilock concurrency when shared by > 1 threads https://review.openstack.org/122887 | 16:22 |
| *** yassine has quit IRC | 16:28 | |
| *** yassine has joined #openstack-oslo | 16:32 | |
| *** takedakn has joined #openstack-oslo | 16:52 | |
| *** takedakn1 has joined #openstack-oslo | 16:54 | |
| *** takedakn has quit IRC | 16:56 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 17:04 | |
| *** yamahata has quit IRC | 17:08 | |
| *** e0ne has joined #openstack-oslo | 17:11 | |
| *** _amrith_ is now known as amrith | 17:14 | |
| *** rpodolyaka1 has quit IRC | 17:15 | |
| *** harlowja_away is now known as harlowja | 17:21 | |
| *** rpodolyaka1 has joined #openstack-oslo | 17:24 | |
| *** andreykurilin has quit IRC | 17:27 | |
| *** rpodolyaka1 has quit IRC | 17:29 | |
| *** rpodolyaka1 has joined #openstack-oslo | 17:30 | |
| *** praneshp has joined #openstack-oslo | 17:32 | |
| *** rpodolyaka1 has quit IRC | 17:43 | |
| *** rpodolyaka1 has joined #openstack-oslo | 17:45 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 18:00 | |
| *** harlowja has quit IRC | 18:05 | |
| *** harlowja_ has joined #openstack-oslo | 18:05 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Fix multilock concurrency when shared by > 1 threads https://review.openstack.org/122887 | 18:08 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Fix multilock concurrency when shared by > 1 threads https://review.openstack.org/122887 | 18:15 |
| harlowja_ | dhellmann do u mind checking out https://review.openstack.org/#/c/122951/ ; apparently the updates bot isn't adjusting requirements-py2 files yet | 18:22 |
| harlowja_ | will be fixed once https://review.openstack.org/#/c/122953/ is merged | 18:22 |
| mriedem | oslo.i18n usage question! | 18:31 |
| mriedem | if i have an exception with this: msg_fmt = _("No valid host was found. %(reason)s") | 18:31 |
| mriedem | can I construct that as: raise exception.NoValidHost(reason=_('my reason'))? | 18:31 |
| mriedem | jecarey: ^? | 18:31 |
| *** e0ne has quit IRC | 18:35 | |
| *** e0ne has joined #openstack-oslo | 18:35 | |
| jecarey | mriedem, That should work. NovaException will apply the keyword 'reason' to the message in the constructor. If lazy is enabled it will delay translation of it as well. | 18:36 |
| mriedem | so we'd essentially have this: _("No valid host was found. %(reason)s") % {'reason': _('my reason')} | 18:36 |
| mriedem | and that's OK? | 18:36 |
| jecarey | Yes. It should be. | 18:38 |
| jecarey | Are you hitting a problem? | 18:38 |
| mriedem | jecarey: no, writing a patch and this stuff always trips me up | 18:38 |
| mriedem | i checked http://docs.openstack.org/developer/oslo.i18n/guidelines.html first | 18:39 |
| mriedem | might be a good example to add | 18:39 |
| jecarey | mriedem, that's a good suggestion. I'll follow up on that. | 18:40 |
| *** rpodolyaka1 has quit IRC | 18:46 | |
| *** rpodolyaka1 has joined #openstack-oslo | 18:53 | |
| *** openstack has joined #openstack-oslo | 18:55 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/oslo.db: Use six.wraps instead of functools.wraps https://review.openstack.org/121968 | 18:59 |
| *** takedakn has joined #openstack-oslo | 19:03 | |
| *** takedakn1 has quit IRC | 19:03 | |
| openstackgerrit | Michael Bayer proposed a change to openstack/oslo-specs: Add long-lived-transactionalized-db-fixtures https://review.openstack.org/117335 | 19:06 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/oslo.db: Start adding a environment for py34/py33 https://review.openstack.org/119968 | 19:08 |
| *** takedakn has quit IRC | 19:09 | |
| openstackgerrit | Michael Bayer proposed a change to openstack/oslo-specs: Add long-lived-transactionalized-db-fixtures https://review.openstack.org/117335 | 19:10 |
| *** takedakn has joined #openstack-oslo | 19:10 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/oslo.db: Create a nested helper function that will work on py3.x https://review.openstack.org/120195 | 19:10 |
| openstackgerrit | Arnaud Legendre proposed a change to openstack/oslo.vmware: getText can be called only when doc is not None https://review.openstack.org/123224 | 19:13 |
| dims | dhellmann: so graph does not look that bad, still peeling the onion - http://bit.ly/1wGIRKO | 19:25 |
| *** hartsocks has left #openstack-oslo | 19:29 | |
| mtreinish | I had a quick question about using oslo.db. I have this review: https://review.openstack.org/#/c/118419/ which adds session params to a global db api | 19:33 |
| mtreinish | but I got a -1 review saying that using a session on a global method will cause issues on dropped connections | 19:33 |
| mtreinish | so I was curious what the recommended usage pattern was here instead, because I was just basing this off some examples I saw in other projects | 19:33 |
| *** AAzza is now known as AAzza_afk | 19:35 | |
| *** tflower has joined #openstack-oslo | 19:38 | |
| *** vigneshvar has joined #openstack-oslo | 19:41 | |
| *** AAzza_afk is now known as AAzza | 19:54 | |
| *** shakamunyi has joined #openstack-oslo | 19:57 | |
| *** tsekiyama has quit IRC | 19:57 | |
| *** tsekiyam_ has joined #openstack-oslo | 19:57 | |
| *** praneshp has quit IRC | 20:01 | |
| dhellmann | harlowja_: +2a | 20:03 |
| *** praneshp has joined #openstack-oslo | 20:03 | |
| harlowja_ | dhellmann thx | 20:04 |
| harlowja_ | be nice to get https://review.openstack.org/#/c/122953/ in also, so that doesn't happen again | 20:04 |
| dhellmann | mriedem: I'm not sure I understand your example. | 20:04 |
| dhellmann | oh, the reason is translatable, too? | 20:04 |
| mriedem | dhellmann: yes, https://review.openstack.org/#/c/123236/ | 20:05 |
| *** kgiusti has quit IRC | 20:05 | |
| mriedem | dhellmann: i wanted to make sure that didn't explode somehow, like with lazy translation | 20:05 |
| dhellmann | dims: that graph still includes things we'll be deleting, so that should help clean it up even further | 20:05 |
| mriedem | b/c, voodoo | 20:05 |
| dhellmann | mriedem: ok, as long as the reason itself is static it should be ok | 20:06 |
| mriedem | dhellmann: alright | 20:06 |
| jecarey | dhellmann, why would it have to be static? | 20:06 |
| mriedem | well the message is static, the vars in one version of it aren't | 20:06 |
| mriedem | but i use named parameters for those | 20:06 |
| dhellmann | harlowja_: gratuitous use of for loop ignored and +2a :-) | 20:07 |
| harlowja_ | lol | 20:07 |
| harlowja_ | :-P | 20:07 |
| dhellmann | jecarey: because if the reason text is coming from a variable, we can't extract it to put it into the message catalog to have it translated | 20:07 |
| *** amrith is now known as _amrith_ | 20:07 | |
| mriedem | dhellmann: do you see any problem with my change above? | 20:08 |
| dhellmann | mriedem: looking | 20:08 |
| dhellmann | mriedem: that should be fine -- you have literal strings inside the _() so the extraction code can find them | 20:08 |
| mriedem | ok, cool | 20:09 |
| jecarey | dhellmann, got it. Thanks. | 20:09 |
| *** e0ne has quit IRC | 20:09 | |
| *** boden has quit IRC | 20:11 | |
| *** marun has joined #openstack-oslo | 20:15 | |
| marun | Hi! Is there anyone here to talk to me about migration testing in the gate using oslo.db? | 20:16 |
| dims | dhellmann: yep | 20:16 |
| dhellmann | marun: you probably want zzzeek, viktors, or rpodolyaka | 20:18 |
| marun | dhellmann: ok, danke | 20:18 |
| *** bjornar_ has joined #openstack-oslo | 20:20 | |
| *** jaosorior has quit IRC | 20:22 | |
| marun | zzzeek, viktors, rpodolyaka: Regarding a Neutron patch that proposes to test migrations: https://review.openstack.org/#/c/76520/ | 20:26 |
| marun | I understand that the openstack_citest credentials are used to target mysql or pg, and that this is configured on unittest nodes. | 20:29 |
| *** mriedem has left #openstack-oslo | 20:29 | |
| *** mriedem has quit IRC | 20:29 | |
| marun | I have some concerns around putting this kind of testing in our unittest suite, since it requires skips on missing dependencies that we are actively trying to avoid via our functional job. | 20:30 |
| marun | I'd be interested in discussing how other projects are doing this kind of testing and whether the way we want to do things in Neutron is a good thing or not. | 20:32 |
| *** miqui has quit IRC | 20:34 | |
| *** tedross has quit IRC | 20:47 | |
| *** vigneshvar has quit IRC | 20:56 | |
| *** praneshp has quit IRC | 20:59 | |
| *** pcm_ has quit IRC | 21:00 | |
| *** praneshp has joined #openstack-oslo | 21:08 | |
| *** boden has joined #openstack-oslo | 21:12 | |
| *** andreykurilin has joined #openstack-oslo | 21:12 | |
| *** flaper87 is now known as flaper87|afk | 21:13 | |
| *** _amrith_ is now known as amrith | 21:16 | |
| *** boden has quit IRC | 21:16 | |
| *** jeckersb is now known as jeckersb_gone | 21:18 | |
| *** bjornar_ has quit IRC | 21:19 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/oslo.db: Start adding a environment for py34/py33 https://review.openstack.org/119968 | 21:19 |
| *** AAzza has left #openstack-oslo | 21:25 | |
| *** tflower has quit IRC | 21:28 | |
| zzzeek | viktors: yeah that patch is old stuff :) | 21:37 |
| zzzeek | viktors: we’re trying to fix it downstream | 21:37 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Fix multilock concurrency when shared by > 1 threads https://review.openstack.org/122887 | 21:37 |
| *** harlowja_ has quit IRC | 21:49 | |
| *** harlowja has joined #openstack-oslo | 21:49 | |
| openstackgerrit | A change was merged to openstack-dev/hacking: Update H501 to check for self.__dict__ https://review.openstack.org/119460 | 21:52 |
| openstackgerrit | A change was merged to openstack/oslo-incubator: Fix typo to show correct log message https://review.openstack.org/122377 | 21:55 |
| *** dims_ has joined #openstack-oslo | 21:56 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/pylockfile: Prototype a addition that moves the lock_utils code over https://review.openstack.org/123257 | 21:58 |
| *** dims_ has quit IRC | 21:58 | |
| *** dims_ has joined #openstack-oslo | 21:58 | |
| *** rpodolyaka1 has quit IRC | 21:59 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/pylockfile: Prototype a addition that moves the lock_utils code over https://review.openstack.org/123257 | 21:59 |
| *** dims has quit IRC | 21:59 | |
| *** rpodolyaka1 has joined #openstack-oslo | 22:03 | |
| harlowja | let me know what u guys think of ^ jd__ dhellmann dims_ | 22:05 |
| harlowja | i couldn't think of a better name vs 'autolockfile', ha | 22:05 |
| *** boden has joined #openstack-oslo | 22:13 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 22:13 | |
| *** andreykurilin has quit IRC | 22:17 | |
| *** boden has quit IRC | 22:17 | |
| dims_ | harlowja: isn't lockfile.LockBase the base class? i can't seem to find _SharedBase in http://git.openstack.org/cgit/openstack/pylockfile/tree/lockfile/__init__.py | 22:24 |
| harlowja | look at the dependent on that review ;) | 22:26 |
| harlowja | https://review.openstack.org/#/c/122253/1 | 22:26 |
| dims_ | Duh! | 22:26 |
| harlowja | LockBase api doesn't quite make sense for us afaik | 22:26 |
| harlowja | can adjust as we see fit though | 22:27 |
| harlowja | 'def i_am_locking(self):' seems odd | 22:27 |
| harlowja | which is on the prior base | 22:27 |
| dims_ | harlowja: so this class won't implement the 5 user-visible methods as mentioned in the docs... | 22:27 |
| harlowja | or we work on implementing them, or mention they aren't implemented? | 22:28 |
| dims_ | harlowja: at least throw not implemented exceptions? | 22:29 |
| * dims_ looking if you have done this already ;) | 22:29 | |
| harlowja | haven't yet, ha | 22:29 |
| harlowja | i'm not sure though if we really should implement those apis | 22:29 |
| harlowja | 'def i_am_locking(self):' is the odd one there | 22:30 |
| harlowja | out of def break_lock(self): | 22:30 |
| harlowja | and def is_locked(self): | 22:30 |
| harlowja | although is_locked is odd also | 22:30 |
| harlowja | how do we tell if the file is locked without locking it ourselves ? | 22:30 |
| harlowja | *the file handle that is | 22:30 |
| dims_ | harlowja: if people are expecting to use those they should see errors i think since the docs talk about the family of impls | 22:30 |
| dims_ | regarding the name..."Auto" we are locking bytes or ranges of bytes, looking at names already there...we could do "ByteRangeLockFile" or something like that | 22:32 |
| harlowja | sounds better than auto, ha | 22:32 |
| dims_ | :) | 22:33 |
| * dims_ staring at msvcrt and fnctl... | 22:34 | |
| harlowja | so how about that windows :-P | 22:34 |
| *** jgrimm is now known as zz_jgrimm | 22:35 | |
| dims_ | still drags us down even if we never use it :) | 22:35 |
| dims_ | brb | 22:35 |
| *** gordc has quit IRC | 22:35 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/pylockfile: Prototype a addition that moves the lock_utils code over https://review.openstack.org/123257 | 22:37 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/pylockfile: Prototype a addition that moves the lock_utils code over https://review.openstack.org/123257 | 22:38 |
| *** jaypipes has quit IRC | 22:41 | |
| *** jecarey has quit IRC | 22:41 | |
| *** marun has quit IRC | 22:46 | |
| *** marun has joined #openstack-oslo | 22:48 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/oslo.db: Start adding a environment for py34/py33 https://review.openstack.org/119968 | 22:50 |
| *** bknudson has quit IRC | 23:02 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/pylockfile: Prototype a addition that moves the lock_utils code over https://review.openstack.org/123257 | 23:04 |
| *** boden has joined #openstack-oslo | 23:13 | |
| *** boden has quit IRC | 23:18 | |
| *** yamahata has joined #openstack-oslo | 23:34 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add a futures type that can unify our future functionality https://review.openstack.org/116489 | 23:45 |
| harlowja | what do people think of https://review.openstack.org/#/c/70914/ for getting off eventlet? | 23:53 |
| harlowja | with the executor impl there, could just remove the impl_eventlet | 23:54 |
| harlowja | since when eventlet monkey patches the threading module they should act the same | 23:54 |
| harlowja | that moves oslo.messaging pretty close to py3 compat | 23:54 |
| harlowja | *close/closer :-P | 23:54 |
| harlowja | although i guess impl_zmq.py has some eventlet usage directly in it | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!