| *** tsekiyama has quit IRC | 00:07 | |
| *** mtanino has quit IRC | 00:11 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack-dev/hacking: Updated from global requirements https://review.openstack.org/120628 | 00:24 |
|---|---|---|
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Switch to using oslo.utils and oslo.serialization https://review.openstack.org/120630 | 00:24 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/cliff: Updated from global requirements https://review.openstack.org/120631 | 00:24 |
| *** harlowja_ has quit IRC | 00:25 | |
| *** harlowja has joined #openstack-oslo | 00:28 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo-incubator: Updated from global requirements https://review.openstack.org/119815 | 00:30 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.config: Updated from global requirements https://review.openstack.org/119991 | 00:30 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.i18n: Updated from global requirements https://review.openstack.org/119992 | 00:30 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.rootwrap: Updated from global requirements https://review.openstack.org/120646 | 00:30 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.serialization: Updated from global requirements https://review.openstack.org/119145 | 00:30 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.utils: Updated from global requirements https://review.openstack.org/119993 | 00:30 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.version: Updated from global requirements https://review.openstack.org/120647 | 00:30 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslosphinx: Updated from global requirements https://review.openstack.org/120648 | 00:30 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/pycadf: Updated from global requirements https://review.openstack.org/120649 | 00:30 |
| openstackgerrit | Clark Boylan proposed a change to openstack/oslo.rootwrap: Handle py34 logging module https://review.openstack.org/120228 | 00:41 |
| *** noelbk has quit IRC | 00:48 | |
| *** yamahata has joined #openstack-oslo | 00:51 | |
| *** zarric has quit IRC | 00:56 | |
| *** takedakn has quit IRC | 00:58 | |
| *** takedakn has joined #openstack-oslo | 00:58 | |
| *** dims_ has joined #openstack-oslo | 01:32 | |
| *** oomichi has joined #openstack-oslo | 01:37 | |
| *** jaypipes has quit IRC | 01:58 | |
| *** alexpilotti has quit IRC | 02:01 | |
| *** markmcclain has quit IRC | 02:05 | |
| *** amotoki_ has joined #openstack-oslo | 02:10 | |
| *** amotoki_ is now known as amotoki | 02:11 | |
| *** markmcclain has joined #openstack-oslo | 02:26 | |
| *** takedakn has quit IRC | 02:26 | |
| *** sileht has quit IRC | 02:46 | |
| *** praneshp has quit IRC | 02:48 | |
| *** dims_ has quit IRC | 02:49 | |
| *** dims_ has joined #openstack-oslo | 02:49 | |
| *** dims_ has quit IRC | 02:54 | |
| *** arnaud has quit IRC | 03:01 | |
| *** noelbk has joined #openstack-oslo | 03:18 | |
| *** krotscheck has quit IRC | 03:44 | |
| *** krotscheck has joined #openstack-oslo | 03:47 | |
| *** takedakn has joined #openstack-oslo | 03:53 | |
| *** praneshp has joined #openstack-oslo | 03:54 | |
| *** praneshp_ has joined #openstack-oslo | 03:57 | |
| *** praneshp has quit IRC | 03:58 | |
| *** praneshp_ is now known as praneshp | 03:58 | |
| *** harlowja is now known as harlowja_away | 04:05 | |
| *** noelbk has quit IRC | 04:07 | |
| *** noelbk has joined #openstack-oslo | 04:24 | |
| openstackgerrit | A change was merged to openstack/cliff: Add docs environment to tox.ini https://review.openstack.org/119912 | 04:29 |
| *** markmcclain has quit IRC | 04:34 | |
| *** harlowja_at_home has joined #openstack-oslo | 04:39 | |
| *** HenryG is now known as HenryG_zzzz | 04:40 | |
| *** yamahata has quit IRC | 04:46 | |
| *** yamahata has joined #openstack-oslo | 04:47 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/oslo.db: Start adding a environment for py34/py33 https://review.openstack.org/119968 | 04:48 |
| *** noelbk has quit IRC | 04:54 | |
| *** jaypipes has joined #openstack-oslo | 04:54 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/oslo.db: Create a nested helper function that will work on py3.x https://review.openstack.org/120195 | 04:56 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/oslo.db: Fix more invalid encoding and scoping issues https://review.openstack.org/120198 | 04:56 |
| openstackgerrit | Steve Martinelli proposed a change to openstack/oslotest: Add an extra parameter for test directory in debugger script https://review.openstack.org/120316 | 04:57 |
| *** inteq has joined #openstack-oslo | 05:05 | |
| openstackgerrit | A change was merged to openstack/oslo.db: Use single quotes for db schema sanity check https://review.openstack.org/118935 | 05:26 |
| *** jaosorior has joined #openstack-oslo | 05:46 | |
| *** praneshp has quit IRC | 05:54 | |
| *** flaper87|afk is now known as flaper87 | 05:58 | |
| *** oomichi_ has joined #openstack-oslo | 06:03 | |
| *** oomichi has quit IRC | 06:05 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.db: Imported Translations from Transifex https://review.openstack.org/118539 | 06:05 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.concurrency: Imported Translations from Transifex https://review.openstack.org/120698 | 06:10 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.messaging: Imported Translations from Transifex https://review.openstack.org/120700 | 06:12 |
| *** takedakn has quit IRC | 06:13 | |
| *** inteq has quit IRC | 06:26 | |
| *** k4n0 has joined #openstack-oslo | 06:34 | |
| r1chardj0n3s | anyone here? | 06:44 |
| lifeless | nope | 06:48 |
| r1chardj0n3s | thanks ;) | 06:49 |
| *** harlowja_at_home has quit IRC | 06:56 | |
| *** sileht has joined #openstack-oslo | 07:03 | |
| *** ildikov has joined #openstack-oslo | 07:09 | |
| *** dtantsur|afk is now known as dtantsur | 07:12 | |
| openstackgerrit | Zang MingJie proposed a change to openstack/oslo-incubator: Mask secrets when output conf https://review.openstack.org/120068 | 07:17 |
| lifeless | r1chardj0n3s: anything in particular you wanted to discuss ? :) | 07:17 |
| r1chardj0n3s | the thing I just posted to openstack-dev :) | 07:17 |
| r1chardj0n3s | but I'm signing off for the night, so conversation will have to wait until tomorrow :) | 07:18 |
| *** r1chardj0n3s is now known as r1chardj0n3s_afk | 07:18 | |
| *** sileht has quit IRC | 07:29 | |
| *** sileht has joined #openstack-oslo | 07:29 | |
| *** oomichi_ has quit IRC | 07:45 | |
| *** AAzza_afk is now known as AAzza | 07:51 | |
| *** andreykurilin has joined #openstack-oslo | 07:56 | |
| *** stannie has joined #openstack-oslo | 08:05 | |
| *** yassine has joined #openstack-oslo | 08:12 | |
| *** ihrachyshka has joined #openstack-oslo | 08:13 | |
| andreykurilin | jd__, ihrachyshka: hi! | 08:20 |
| ihrachyshka | andreykurilin: hey! | 08:21 |
| andreykurilin | ihrachyshka, how are you? | 08:22 |
| ihrachyshka | andreykurilin: fine, thanks. can I help you somehow? | 08:22 |
| andreykurilin | ihrachyshka, yes, you can:) | 08:23 |
| ihrachyshka | tell me! | 08:23 |
| andreykurilin | ihrachyshka, i working on porting novaclient to use oslo.serialization and have one problem - https://bugs.launchpad.net/oslo.serialization/+bug/1366748 | 08:23 |
| andreykurilin | ihrachyshka, oslo.serialization is missed from global-requirements in stable branches | 08:24 |
| ihrachyshka | I see. I hate that we pull all the master deps of clients to stable branches, but since it's the way it is now... looking | 08:24 |
| ihrachyshka | andreykurilin: I think you need to cherry-pick Iff29ce2e88cddc2332229cfbbc518251dd2c76f3 instead | 08:27 |
| ihrachyshka | retaining the same Change-Id | 08:27 |
| andreykurilin | ihrachyshka, ok, i will fix it now | 08:28 |
| ihrachyshka | ok, thanks | 08:28 |
| *** pblaho has joined #openstack-oslo | 08:29 | |
| andreykurilin | ihrachyshka, i need to submit new patch or changing commit message will be enought? | 08:30 |
| ihrachyshka | andreykurilin: you will need new reviews | 08:31 |
| andreykurilin | iharchyska, I know it:) | 08:32 |
| openstackgerrit | Julien Danjou proposed a change to openstack/oslosphinx: Remove empty file https://review.openstack.org/120717 | 08:38 |
| ihrachyshka | andreykurilin: just send me the links when done :) | 08:38 |
| andreykurilin | iharchyska, thanks! | 08:39 |
| andreykurilin | iharchyska, stable/icehouse: https://review.openstack.org/#/c/120718/ | 08:39 |
| andreykurilin | iharchyska, stable/havana: https://review.openstack.org/#/c/120719/ | 08:42 |
| *** sunrenjie6 has joined #openstack-oslo | 08:46 | |
| *** oomichi has joined #openstack-oslo | 08:52 | |
| *** viktors|afk is now known as viktors | 08:53 | |
| *** andreykurilin has quit IRC | 08:55 | |
| *** dtantsur is now known as dtantsur|afk | 09:07 | |
| *** andreykurilin has joined #openstack-oslo | 09:08 | |
| *** oomichi has quit IRC | 09:10 | |
| openstackgerrit | zhangjl proposed a change to openstack/oslo.messaging: Message was send to wrong node with use zmq as rpc_backend https://review.openstack.org/84938 | 09:22 |
| *** ajo has quit IRC | 09:25 | |
| *** ajo has joined #openstack-oslo | 09:26 | |
| ihrachyshka | andreykurilin: great. please check my comments. | 09:32 |
| andreykurilin | ihrachyshka: done | 09:34 |
| *** sunrenjie6 has quit IRC | 09:35 | |
| ihrachyshka | andreykurilin: yeah, but still, no -x used, no Conflicts: section (though conflicts obviously occurred...) | 09:40 |
| andreykurilin | ihrachyshka: one moment | 09:41 |
| ihrachyshka | andreykurilin: I feel like being pain in the ass, maybe I should just approve and be done with it. but - silly me - I still dream about time when people stick to those simple backport rules. | 09:42 |
| andreykurilin | ihrachyshka, i agree with you and will fix fully your comment:) | 09:43 |
| ihrachyshka | ok, thanks | 09:43 |
| *** dims_ has joined #openstack-oslo | 09:51 | |
| andreykurilin | ihrachyshka, fixed | 09:51 |
| ihrachyshka | andreykurilin: good job now! :) | 09:55 |
| andreykurilin | ihrachyshka, thanks! | 09:58 |
| *** dims_ has quit IRC | 10:00 | |
| *** dims_ has joined #openstack-oslo | 10:01 | |
| andreykurilin | ihrachyshka, one more question:) | 10:06 |
| *** dims_ has quit IRC | 10:06 | |
| andreykurilin | ihrachyshka, do I need add a link to bug in commit message or adding information about "why this backport is needed" will be enought? | 10:07 |
| *** d0ugal has quit IRC | 10:08 | |
| *** d0ugal has joined #openstack-oslo | 10:08 | |
| ihrachyshka | andreykurilin: that would help, yes. it's better to be explicit. | 10:08 |
| ihrachyshka | otherwise you're doomed to explain it to each new reviewer :D | 10:08 |
| andreykurilin | ihrachyshka, thanks for an advice. please, review my patches again:) | 10:14 |
| *** yamahata has quit IRC | 10:31 | |
| *** pcm_ has joined #openstack-oslo | 10:35 | |
| *** pblaho is now known as pblaho|afk | 10:36 | |
| *** pcm_ has quit IRC | 10:37 | |
| *** pcm_ has joined #openstack-oslo | 10:37 | |
| *** markmc has joined #openstack-oslo | 10:43 | |
| andreykurilin | markmc, hi! | 11:05 |
| openstackgerrit | James Page proposed a change to openstack/oslo.messaging: Construct ZmqListener with correct arguments https://review.openstack.org/120745 | 11:14 |
| *** dims_ has joined #openstack-oslo | 11:17 | |
| openstackgerrit | Ann Kamyshnikova proposed a change to openstack/oslo.db: ModelsMigrationsSync:add correct server_default check for Enum https://review.openstack.org/120746 | 11:21 |
| *** pblaho|afk is now known as pblaho | 11:24 | |
| *** dtantsur|afk is now known as dtantsur | 11:26 | |
| *** dims_ has quit IRC | 11:30 | |
| *** dims_ has joined #openstack-oslo | 11:31 | |
| *** tedross has joined #openstack-oslo | 11:33 | |
| *** dims__ has joined #openstack-oslo | 11:34 | |
| *** dims_ has quit IRC | 11:35 | |
| *** pblaho is now known as pblaho|afk | 11:51 | |
| *** kgiusti has joined #openstack-oslo | 12:08 | |
| *** markmcclain has joined #openstack-oslo | 12:09 | |
| *** zz_jgrimm is now known as jgrimm | 12:20 | |
| openstackgerrit | Radoslav Gerganov proposed a change to openstack/oslo.vmware: Add 'details' property to VMwareDriverException https://review.openstack.org/120768 | 12:21 |
| openstackgerrit | Radoslav Gerganov proposed a change to openstack/oslo.vmware: Add DuplicateName exception https://review.openstack.org/120769 | 12:21 |
| *** amrith is now known as _amrith_ | 12:28 | |
| *** pblaho|afk is now known as pblaho | 12:32 | |
| *** gordc has joined #openstack-oslo | 12:42 | |
| *** dims__ has quit IRC | 12:49 | |
| *** dims_ has joined #openstack-oslo | 12:50 | |
| *** dims_ is now known as dims | 12:51 | |
| *** HenryG_zzzz is now known as HenryG | 12:55 | |
| openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.vmware: VMware: Enable vCenter SSL certificate validation https://review.openstack.org/120183 | 12:55 |
| openstackgerrit | A change was merged to openstack/oslo.utils: warn against sorting requirements https://review.openstack.org/118728 | 13:02 |
| openstackgerrit | A change was merged to openstack/oslo.utils: Work toward Python 3.4 support and testing https://review.openstack.org/118794 | 13:02 |
| openstackgerrit | A change was merged to openstack/oslo.utils: Add the ability to extract the query params from a urlsplit https://review.openstack.org/118881 | 13:02 |
| openstackgerrit | A change was merged to openstack/oslo.concurrency: Updated from global requirements https://review.openstack.org/120329 | 13:02 |
| *** jgrimm is now known as zz_jgrimm | 13:03 | |
| openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.vmware: VMware: Enable vCenter SSL certificate validation https://review.openstack.org/120183 | 13:14 |
| *** mriedem has joined #openstack-oslo | 13:24 | |
| dims | bnemec: do we really need the WeakValueDictionary? | 13:26 |
| *** ihrachyshka has quit IRC | 13:32 | |
| *** jecarey has joined #openstack-oslo | 13:32 | |
| *** pblaho has quit IRC | 13:35 | |
| *** yassine has quit IRC | 13:40 | |
| *** bknudson has joined #openstack-oslo | 13:46 | |
| *** _amrith_ is now known as amrith | 13:49 | |
| *** yassine has joined #openstack-oslo | 13:55 | |
| *** markmcclain has quit IRC | 13:58 | |
| *** arnaud has joined #openstack-oslo | 14:00 | |
| *** tongli has joined #openstack-oslo | 14:08 | |
| *** andreykurilin has quit IRC | 14:08 | |
| *** andreykurilin_ has joined #openstack-oslo | 14:08 | |
| *** zz_jgrimm is now known as jgrimm | 14:15 | |
| *** ihrachyshka has joined #openstack-oslo | 14:20 | |
| *** amotoki has quit IRC | 14:21 | |
| *** yamahata has joined #openstack-oslo | 14:23 | |
| bnemec | dims: I don't know that we need it, but if we don't use it we have to clean up all of the semaphores ourselves after we're done with them. | 14:23 |
| bnemec | Although...I wonder if there's some danger there. We lock the _semaphores structure when we create sems, but there's no way to control their destruction. | 14:25 |
| gordc | dhellmann: sorry for being mia last few days... was travelling. | 14:30 |
| gordc | dhellmann: do you think it's safe to cut a release for oslo.middleware after the requirements patch merges... (whenever that is.) | 14:31 |
| *** tsekiyama has joined #openstack-oslo | 14:39 | |
| *** arnaud has quit IRC | 14:40 | |
| *** mtanino has joined #openstack-oslo | 14:46 | |
| *** markmcclain has joined #openstack-oslo | 14:47 | |
| *** markmcclain1 has joined #openstack-oslo | 14:49 | |
| *** markmcclain1 has quit IRC | 14:49 | |
| *** markmcclain1 has joined #openstack-oslo | 14:50 | |
| *** markmcclain has quit IRC | 14:52 | |
| *** k4n0 has quit IRC | 15:01 | |
| openstackgerrit | A change was merged to openstack/oslo.rootwrap: warn against sorting requirements https://review.openstack.org/118726 | 15:03 |
| andreykurilin_ | markmcclain1, hi! | 15:08 |
| *** andreykurilin_ is now known as andreykurilin | 15:08 | |
| openstackgerrit | A change was merged to openstack/oslo.rootwrap: Fix the bug tracker URL in CONTRIBUTING.rst https://review.openstack.org/119871 | 15:09 |
| openstackgerrit | A change was merged to openstack/oslo.config: warn against sorting requirements https://review.openstack.org/118717 | 15:09 |
| markmcclain1 | andreykurilin: are you looking for me or markmc? | 15:10 |
| andreykurilin | markmcclain1, i'm looking for core of openstack/requirements, which can help me with oslo.serialization:) | 15:11 |
| *** AAzza is now known as AAzza_afk | 15:11 | |
| markmcclain1 | andreykurilin: ah .. then I can help.. what's up? | 15:12 |
| andreykurilin | markmcclain1, nice! i'm working on porting novaclient to use oslo.serialization, but i found one problem - https://bugs.launchpad.net/oslo.serialization/+bug/1366748 | 15:14 |
| *** yamahata has quit IRC | 15:15 | |
| andreykurilin | markmcclain1, I have 2 patches in openstack/requirements and I have already +2 for it, but I need more reviewers. | 15:16 |
| markmcclain1 | andreykurilin: +2/A… now we just have to wait for the gate to catch up | 15:16 |
| andreykurilin | markmcclain1, great! thank you. | 15:17 |
| markmcclain1 | andreykurilin: you're welcome | 15:17 |
| *** zzzeek has joined #openstack-oslo | 15:20 | |
| *** markmcclain1 has quit IRC | 15:20 | |
| *** markmcclain has joined #openstack-oslo | 15:20 | |
| openstackgerrit | A change was merged to openstack/oslo.rootwrap: Add a short doc to README on how to use daemon mode https://review.openstack.org/120100 | 15:23 |
| *** jgrimm is now known as zz_jgrimm | 15:37 | |
| *** harlowja_at_home has joined #openstack-oslo | 15:39 | |
| ihrachyshka | dhellmann: hey! | 15:47 |
| *** zz_jgrimm is now known as jgrimm | 15:48 | |
| ihrachyshka | dhellmann: now that sqlalchemy-migrate pieces are approved and about to be merged in next hours, I wonder whom to reach to release pypi package with the fixes. stackforge governance seems to be quite anarchic. do you know anyone with pypi package push permissions? | 15:49 |
| *** andreykurilin has quit IRC | 15:51 | |
| *** dtantsur is now known as dtantsur|afk | 15:55 | |
| *** harlowja_at_home has quit IRC | 16:03 | |
| *** markmc has quit IRC | 16:07 | |
| openstackgerrit | Steve Martinelli proposed a change to openstack/oslotest: Add an extra parameter for test directory in debugger script https://review.openstack.org/120316 | 16:11 |
| *** praneshp has joined #openstack-oslo | 16:16 | |
| *** markmcclain has quit IRC | 16:19 | |
| *** amrith is now known as _amrith_ | 16:22 | |
| openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.vmware: VMware: Enable vCenter SSL certificate validation https://review.openstack.org/120183 | 16:25 |
| openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.vmware: Add a memory based shared cache https://review.openstack.org/116297 | 16:29 |
| jogo | any oslo db folks around? | 16:31 |
| jogo | https://bugs.launchpad.net/oslo.db/+bug/1367799 | 16:31 |
| *** bjornar_ has joined #openstack-oslo | 16:33 | |
| *** yassine has quit IRC | 16:33 | |
| *** ihrachyshka has quit IRC | 16:41 | |
| jogo | https://review.openstack.org/120835 | 16:41 |
| jogo | dhellmann: ^ | 16:41 |
| *** jgrimm is now known as zz_jgrimm | 16:42 | |
| *** ihrachyshka has joined #openstack-oslo | 16:42 | |
| jogo | bnemec: ^ | 16:43 |
| *** ildikov has quit IRC | 16:45 | |
| bnemec | jogo: I take it the check queue isn't a problem for e-r? | 16:46 |
| bnemec | I kind of wonder why we're wasting a vm running a test we know won't pass though. | 16:46 |
| *** noelbk has joined #openstack-oslo | 16:47 | |
| jogo | bnemec: if you want to turn off the job all together thats even better | 16:48 |
| jogo | bnemec: and yes we ignore the check queue in e-r in most cases | 16:48 |
| bnemec | jogo: I would be fine with that. | 16:48 |
| jogo | bnemec: as the data is too dirty | 16:48 |
| jogo | bnemec: cool, I'll respin the patch | 16:48 |
| bnemec | viktors: Is there a reason we're runnign the py3 jobs in oslo.db when we know they won't work? | 16:48 |
| jogo | bnemec: AFAIK yes I413cf53234536286a6718e7662b7698f5ef4f64b | 16:49 |
| jogo | bnemec: We suppose to add python 3.3 support to oslo.db so we should enable | 16:49 |
| jogo | (as non-voting, at first) gate testing on python 3.3 | 16:49 |
| jogo | bnemec: btw how is the lockutils bug going? | 16:51 |
| bnemec | jogo: Yeah, but if we know it's not working right now, it seems like we should disable it. | 16:51 |
| bnemec | It makes more sense to me to get it working, turn on the job non-voting to make sure it behaves in the gate, then make it voting. | 16:51 |
| bnemec | jogo: I posted an update to the bug last night, but I haven't had any luck reproducing that behavior in lockutils itself. | 16:52 |
| jogo | bnemec: thoughts on tracing through logs to see if the latest oslo sync made it worse or not? | 16:54 |
| jogo | as a spot check showed it may have donethat | 16:54 |
| jogo | but that was a spot check so it doesn't really mean much | 16:54 |
| *** zz_jgrimm is now known as jgrimm | 16:55 | |
| bnemec | jogo: I would be really surprised if the file locking change affected internal semaphore locking. | 16:55 |
| bnemec | Not that it's impossible. | 16:55 |
| bnemec | lockutils constantly comes up with new ways to surprise me. :-/ | 16:56 |
| jogo | bnemec: hehe I can do some counting in a bit | 16:57 |
| jogo | unless you want to | 16:57 |
| bnemec | jogo: Not especially :-) | 16:57 |
| openstackgerrit | Anderson Mesquita proposed a change to openstack/oslo.i18n: Remove unused/mutable default args https://review.openstack.org/116413 | 16:58 |
| jogo | bnemec: I'll take a whack at it in a bit | 16:59 |
| *** markmcclain has joined #openstack-oslo | 17:02 | |
| *** harlowja_away is now known as harlowja | 17:09 | |
| *** takedakn has joined #openstack-oslo | 17:12 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/cliff: Updated from global requirements https://review.openstack.org/120631 | 17:13 |
| *** ajo is now known as ajo|afk | 17:13 | |
| harlowja | bnemec whats your thought on trying http://paste.ubuntu.com/8314680/ (or at least using it and adding logging in the locations where refereences are gotten/released) | 17:14 |
| harlowja | do u guys also mind checking out https://review.openstack.org/#/c/119985/ (the taskflow requirements update ) | 17:14 |
| dstanek | is there any date in mind for projects to use the new logging hints? | 17:15 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.config: Updated from global requirements https://review.openstack.org/119991 | 17:19 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.db: Updated from global requirements https://review.openstack.org/118564 | 17:19 |
| bnemec | harlowja: That looks useful. I do wonder if we want to start off by just logging when we create a new semaphore first. | 17:20 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.utils: Updated from global requirements https://review.openstack.org/119993 | 17:20 |
| bnemec | That would tell us if a semaphore got destroyed somehow before the next lock attempt. | 17:20 |
| bnemec | And if we find that's happening then we can add your logging to find out where. | 17:20 |
| harlowja | bnemec ya, some information that would show the possible colloision | 17:20 |
| bnemec | The only reason I'm concerned with your change is that it swaps data structures. | 17:20 |
| bnemec | Of course, if getting rid of WeakRefDictionary fixes the problem then that's a data point too. :-) | 17:21 |
| harlowja | bnemec agreed, one variable that could fix it, would be interesting if it did | 17:21 |
| harlowja | be nice to be able to try a couple different possible solutions at once | 17:22 |
| bnemec | Yeah, although then if one of them fixes the problem we won't know which one. :-) | 17:26 |
| bnemec | But at this point in the cycle the shotgun approach probably makes sense. We can sort out the pieces once the problem is gone. | 17:26 |
| harlowja | thats what i was thinkin | 17:27 |
| harlowja | another option, http://paste.ubuntu.com/8320580/ (try different container types here) | 17:27 |
| harlowja | one with a dict, one with a list ... | 17:27 |
| bnemec | jogo: Do you have any feel for how often this is happening? Like could we put up several different options and let CI chew on them? Or is it something that needs to merge to Nova and be run for every change? | 17:28 |
| *** tkelsey_ has joined #openstack-oslo | 17:29 | |
| *** tkelsey_ is now known as tkelsey | 17:31 | |
| *** takedakn1 has joined #openstack-oslo | 17:31 | |
| *** takedakn has quit IRC | 17:32 | |
| harlowja | ya, if it occurrs like every run, that'd be super actually | 17:36 |
| harlowja | *sadly super* | 17:36 |
| harlowja | haha | 17:36 |
| dhellmann | dstanek: "new logging hints"? do you mean the translation stuff? | 17:37 |
| dstanek | dhellmann: yeah, the marker functions | 17:38 |
| dhellmann | dstanek: it would be good if those were fully deployed by the end of kilo | 17:38 |
| openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.vmware: VMware: Enable vCenter SSL certificate validation https://review.openstack.org/120183 | 17:38 |
| *** _amrith_ is now known as amrith | 17:39 | |
| dstanek | dhellmann: perfect, thanks. someone submitted a spec for Keystone and i wanted to make sure the info in it was correct | 17:39 |
| dhellmann | dstanek: link? | 17:39 |
| dhellmann | dims: where does the oslo.vmware stand? I missed a bunch this morning because of my commute | 17:40 |
| dstanek | dhellmann: https://review.openstack.org/#/c/105954/3/specs/juno/support-log-translation-hints.rst | 17:40 |
| dstanek | dhellmann: i actually implemented a hacking rule and the changes before i saw this spec | 17:40 |
| jogo | bnemec: this happens on every job I have checked (2) | 17:40 |
| dims | dhellmann: 3 merges in the loooooooong gate queue | 17:41 |
| dims | dhellmann: once they are out, we can cut a release | 17:41 |
| dhellmann | gordc: we should time the oslo.middleware release carefully because of the weekend, unless you can be around to help resolve issues it might cause. Monday morning? Sunday night? | 17:41 |
| dhellmann | dims: ok, same warning ^^ | 17:41 |
| dims | dhellmann: ack. will make time | 17:41 |
| dhellmann | dstanek: reading | 17:41 |
| gordc | dhellmann: sounds like a plan to me. i'll cut a release of oslo.middleware sunday/monday. | 17:41 |
| dhellmann | dims: ok, I'll leave it up to you | 17:42 |
| dhellmann | gordc: do you have any reviews in the queue that need to be approved before rc1? | 17:42 |
| bnemec | jogo: Cool, so we can probably push some debugging changes for Nova that don't need to be able to merge. | 17:42 |
| bnemec | harlowja: ^ | 17:42 |
| harlowja | cool | 17:42 |
| dims | dhellmann: thanks will do | 17:42 |
| jogo | bnemec: ++ | 17:42 |
| harlowja | bnemec so a couple options @ http://paste.ubuntu.com/8320653/ | 17:42 |
| gordc | dhellmann: there is a new middleware that i think we can leave off... https://review.openstack.org/#/c/120257/ | 17:42 |
| dstanek | dhellmann: i updated it quite a bit, but kept the spirit of the proposal - i'm going to update the juno timeframe with kilo | 17:42 |
| harlowja | both avoid weakref dictionary | 17:43 |
| gordc | dhellmann: dims and i have decided to leave the doc change from first release. | 17:43 |
| dhellmann | gordc: yeah, no new features at this point | 17:43 |
| harlowja | and add in logging of create/ref bye bye | 17:43 |
| dhellmann | gordc: and right we can clean up docs a bit between rc1 and final | 17:43 |
| gordc | dhellmann: cool cool. i'll let the requirements merge go through and then cut release for monday | 17:44 |
| dhellmann | gordc: I think the bugs are targeted for "next" in launchpad already, but if you have one that isn't go ahead and update it | 17:44 |
| * bnemec wonders why he has a nova branch named "fruit" | 17:44 | |
| dhellmann | gordc: cool | 17:44 |
| dhellmann | bnemec: haha | 17:44 |
| openstackgerrit | David Stanek proposed a change to openstack/oslo.i18n: Fixes a small syntax error in the doc examples https://review.openstack.org/120856 | 17:46 |
| *** openstackgerrit has quit IRC | 17:46 | |
| *** openstackgerrit has joined #openstack-oslo | 17:47 | |
| bnemec | harlowja: I'd say try whatever you've got time for. I'm about to push a stupid simple debugging patch, but like you said we might as well try all the things. | 17:48 |
| harlowja | bnemec will put up a nova/openstack/common lockutils adjustment, to see what happens | 17:48 |
| openstackgerrit | Ken Giusti proposed a change to openstack/oslo.messaging: Add documentation explaining how to use the AMQP 1.0 driver. https://review.openstack.org/120860 | 17:49 |
| dims | harlowja: please add me to the review as well. will help when i get a chance | 17:49 |
| harlowja | dims sure | 17:49 |
| bnemec | jogo: harlowja: dims: https://review.openstack.org/#/c/120859/ | 17:49 |
| bnemec | Just FYI | 17:50 |
| bnemec | Ah, fruit was the low-hanging fruit syncs from end of last cycle. | 17:51 |
| dims | bnemec: lgtm, we may have to run it many times.. | 17:51 |
| dims | lol | 17:51 |
| jogo | dims: so we hit the double lock in most runs if not all | 17:51 |
| dims | jogo: that's good i guess in terms of this exercise :) | 17:52 |
| dhellmann | bnemec: why do we use threading.Semaphore() instead of threading.Lock() for inner locks? | 17:55 |
| dhellmann | bnemec: I don't think that has anything to do with the problem, I'm just curious | 17:56 |
| bnemec | dhellmann: Not sure. I think that predates my involvement in lockutils. | 17:56 |
| dhellmann | ok | 17:56 |
| bnemec | Although it's possible you couldn't do weakrefs to Lock's until py2.7. | 17:56 |
| * bnemec thinks he just read that | 17:56 | |
| bnemec | Yeah: https://docs.python.org/2/library/weakref.html | 17:57 |
| bnemec | Changed in version 2.7: Added support for thread.lock, threading.Lock, and code objects. | 17:57 |
| bnemec | dhellmann: ^ is probably why | 17:57 |
| dhellmann | ah, ok, that makes sense | 17:57 |
| *** tkelsey has quit IRC | 17:58 | |
| harlowja | are we seeing this on 2.6 only? | 17:58 |
| * dhellmann now wonders why we need a weakref dict to hold those locks | 17:58 | |
| dhellmann | shouldn't we prefer to make sure we keep the same lock objects around? | 17:59 |
| harlowja | dhellmann i think its due to not knowing the lifespan of those locks | 17:59 |
| harlowja | so weakref the lifespan is automatic | 17:59 |
| dhellmann | well, yeah, but if we're not explictly unlocking something that's a bug, isn't it? | 17:59 |
| harlowja | likely | 18:00 |
| harlowja | https://review.openstack.org/120865 | 18:00 |
| harlowja | we can switch out the container there for a non-weakref one | 18:00 |
| harlowja | and see what happens | 18:00 |
| jogo | bnemec: grep compute_resources screen-n-cpu.txt.gz | grep -Pzo "Got semaphore.*\n.*Got" | wc -l | 18:02 |
| jogo | will show double the number of hits | 18:02 |
| jogo | for the bugs | 18:02 |
| dhellmann | harlowja: that's going to have the same problem of possibly removing the reference to a lock that wasn't unlocked just because we can't find anything that refers to it, right? | 18:03 |
| dhellmann | s/removing the reference to/removing/ | 18:03 |
| bnemec | jogo: Thanks. | 18:03 |
| harlowja | dhellmann sure, if someone isn't unlocking a lock thats a bigger issue | 18:04 |
| dhellmann | harlowja: right, but that's also assuming that the thing locking the lock is saving a reference properly | 18:04 |
| bnemec | We could certainly clean up explicitly in our lock decorator. If anyone's using internal_lock directly though we might have a problem. | 18:06 |
| *** sreshetnyak has quit IRC | 18:12 | |
| jogo | bnemec: in recent gate-tempest-dsvm-full jobs for nova patches that landed | 18:12 |
| openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.vmware: VMware: Enable vCenter SSL certificate validation https://review.openstack.org/120183 | 18:12 |
| jogo | the hit count is anywhere from 27-37 | 18:12 |
| *** sreshetnyak has joined #openstack-oslo | 18:12 | |
| *** sreshetnyak has quit IRC | 18:13 | |
| *** sreshetnyak has joined #openstack-oslo | 18:13 | |
| *** sreshetnyak has quit IRC | 18:13 | |
| *** sreshetnyak has joined #openstack-oslo | 18:14 | |
| bnemec | jogo: That should make debugging easier at least. | 18:14 |
| harlowja | alright, https://review.openstack.org/120868 | 18:15 |
| harlowja | lets see what happens :-P | 18:15 |
| dhellmann | bnemec: I was thinking more that we need to make sure we're actually holding references to the objects that are wrapped with weakrefs, so we don't accidentally allow something to be reaped before we're really done with it | 18:16 |
| jogo | bnemec: similar results before the sync | 18:18 |
| openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.vmware: VMware: Enable vCenter SSL certificate validation https://review.openstack.org/120183 | 18:18 |
| bnemec | dhellmann: Yeah, but then we're back to having to manually clean up our strong refs so we don't hold the objects in memory. | 18:19 |
| bnemec | Although I suppose we could only do that in the decorator, and if anyone's using the locks directly they're responsible for the object lifetime. | 18:19 |
| bnemec | Which is reasonable. | 18:19 |
| dhellmann | bnemec: I guess these things don't get reused a bunch? | 18:19 |
| bnemec | jogo: That's what I would have expected. | 18:19 |
| harlowja | bnemec https://review.openstack.org/#/c/120868/ what do u think about that, might be interesting to see what happens | 18:19 |
| bnemec | dhellmann: Some do, some don't. | 18:19 |
| dhellmann | maybe we should update harlowja's thing to only remove it from the cache if the lock isn't locked? | 18:20 |
| bnemec | dhellmann: Some projects create a new lock for every instance/volume/image, and you probably don't want those hanging around forever. | 18:20 |
| dhellmann | true | 18:20 |
| bnemec | (where "forever" is defined as "until the service restarts" :-) | 18:21 |
| openstackgerrit | Michael Bayer proposed a change to openstack/oslo.db: Reorganize DbTestCase to use provisioning completely https://review.openstack.org/110170 | 18:21 |
| openstackgerrit | Michael Bayer proposed a change to openstack/oslo.db: Organize provisioning to use testresources https://review.openstack.org/120870 | 18:21 |
| dims | harlowja: i had something very similar to yours, except i gave up when i saw the "yield int_lock" as i was not sure | 18:29 |
| harlowja | dims might as well try it, see how it goes :) | 18:29 |
| dims | harlowja: lol :) | 18:30 |
| harlowja | one of https://review.openstack.org/#/c/120868 or https://review.openstack.org/#/c/120865/ might help | 18:30 |
| *** takedakn1 has quit IRC | 18:30 | |
| harlowja | if it does, then we can figure out why i guess | 18:30 |
| amrith | dims, ping! | 18:31 |
| dims | amrith: pong | 18:31 |
| amrith | dims, hi. won't interrupt your chat for longer than 1s. will you be coming to the meetup this PM? | 18:31 |
| dims | amrith: will know around 3:30-4:00 | 18:33 |
| amrith | dims, thx | 18:36 |
| *** tsekiyama has quit IRC | 18:40 | |
| *** tsekiyama has joined #openstack-oslo | 18:41 | |
| *** ihrachyshka has quit IRC | 18:42 | |
| *** sreshetnyak has quit IRC | 18:51 | |
| bnemec | So this looks bad: http://paste.openstack.org/show/110284/ | 18:54 |
| bnemec | It creates the semaphore, proceeds to lock the same one three times in a row, releases a couple, _another_ thread gets in there and grabs the same semaphore, and finally they all release. | 18:55 |
| bnemec | And as you can see it's using only one semaphore for all of them. | 18:56 |
| bnemec | jogo: harlowja dims dhellmann: ^ | 18:56 |
| bnemec | This is in a local tempest run. | 18:56 |
| dhellmann | bnemec: can you log the object id of the semaphore? | 18:57 |
| dhellmann | I guess the "using existing" line shows we're reusing the object, doesn't it | 18:58 |
| *** jecarey has quit IRC | 18:58 | |
| bnemec | dhellmann: Unless the weakref dict is doing something weird on us. | 18:59 |
| harlowja | evil weakref | 18:59 |
| * harlowja waiting to see if https://review.openstack.org/#/c/120868/ (no weakrefs) helps | 18:59 | |
| jogo | bnemec: just to be clear re-using the same semaphore is good right? | 19:00 |
| bnemec | jogo: That's what we would expect to be happening, yes. | 19:01 |
| jogo | but having two things aquire the semaphore at the same time is the issue here | 19:01 |
| harlowja | i also wonder about https://github.com/openstack/nova/blob/master/nova/openstack/common/lockutils.py#L234 | 19:02 |
| harlowja | that logging line is not during a lock ownership, but after, so it can happen in weird orders | 19:02 |
| *** jecarey has joined #openstack-oslo | 19:03 | |
| harlowja | probably nothing though | 19:03 |
| jogo | harlowja: that would be worth trying a test patch on nova to confirm though | 19:03 |
| harlowja | patch 4 coming up :-P | 19:03 |
| bnemec | harlowja: Hmm, that's a good point. I'm going to try moving it inside the lock. | 19:03 |
| harlowja | kk | 19:03 |
| dhellmann | jogo: the fact that 2 things seem to acquire the same semaphore makes me thing what we have is not a semaphore | 19:04 |
| harlowja | same with the 'LOG.debug('Got semaphore "%(lock)s"', {'lock': name})' line | 19:04 |
| dhellmann | bnemec: logging the type and id of the object returned would help show if that's right | 19:04 |
| harlowja | it doesn't say its acutally acquired, just gotten | 19:04 |
| openstackgerrit | Steve Martinelli proposed a change to openstack/pycadf: Use oslo_debug_helper and remove our own version https://review.openstack.org/120884 | 19:04 |
| dhellmann | I wonder, for example, if eventlet's semaphore is broken in some way | 19:04 |
| harlowja | so probably useful to have logs for gotten, acquired, released, letgo... | 19:04 |
| dhellmann | or if we're getting a threading.Semaphore() for real | 19:04 |
| jogo | dhellmann: well we could have a counting semaphore insetad of a binary one | 19:04 |
| dhellmann | jogo: they're all counting, with a default of 1 | 19:04 |
| dhellmann | jogo: unless, say, the default for eventlet's semaphore isn't 1? | 19:05 |
| jogo | dhellmann: right, but if we aren't stopping at 1 | 19:05 |
| dhellmann | maybe we should set that explicitly when we make the semaphore | 19:05 |
| *** russellb has quit IRC | 19:05 | |
| jogo | dhellmann: If not specified, value defaults to 1. | 19:06 |
| jogo | http://eventlet.net/doc/modules/semaphore.html | 19:06 |
| dhellmann | jogo: that's consistent with threading | 19:06 |
| *** russellb has joined #openstack-oslo | 19:07 | |
| *** lbragstad has quit IRC | 19:07 | |
| harlowja | afaik we aren't really using it as a counting sempahore, so we could easily replace it with a normal lock | 19:07 |
| dhellmann | bnemec: logging vars(semaphore) would also show us the counter value (the attr name is private for a threading.Semaphore) | 19:07 |
| dhellmann | harlowja: there was an issue creating weakrefs to those before python 2.7 | 19:08 |
| harlowja | kk | 19:08 |
| harlowja | solution no more weakrefs ;) | 19:08 |
| dhellmann | yeah, memory leak | 19:08 |
| bnemec | dhellmann: Okay, running with id logging and the rearranged statements so we only log when we've actually got the lock. Will try vars next. | 19:08 |
| dhellmann | bnemec: sounds good | 19:08 |
| harlowja | dhellmann well https://review.openstack.org/#/c/120868/ is without weakrefs, lets call that sorta-weak-refs, ha | 19:09 |
| *** freyes has quit IRC | 19:09 | |
| dhellmann | harlowja: yeah, doing your own reference counting :-) | 19:09 |
| harlowja | josh-refs | 19:09 |
| harlowja | lol | 19:09 |
| *** freyes has joined #openstack-oslo | 19:10 | |
| *** lbragstad has joined #openstack-oslo | 19:10 | |
| dhellmann | he | 19:10 |
| *** hartsocks has quit IRC | 19:13 | |
| *** Guest75250 has quit IRC | 19:14 | |
| *** russellb has quit IRC | 19:15 | |
| *** freyes has quit IRC | 19:19 | |
| *** lbragstad has quit IRC | 19:19 | |
| *** jroll has quit IRC | 19:19 | |
| * bnemec fails at python logging | 19:20 | |
| *** lbragstad has joined #openstack-oslo | 19:23 | |
| *** bjornar_ has quit IRC | 19:25 | |
| bnemec | Bleh. I think this may just be a bad logging issue. | 19:27 |
| *** lbragstad has quit IRC | 19:28 | |
| bnemec | With the logging wrapped into the lock it looks like it did the right thing: http://paste.openstack.org/show/110298/ | 19:28 |
| *** markmcclain has quit IRC | 19:28 | |
| bnemec | create, acquire, use, use, release, acquire, use, release, acquire, release, acquire, release | 19:28 |
| *** alexpilotti has joined #openstack-oslo | 19:29 | |
| dhellmann | zzzeek: can you join us in #openstack-nova | 19:29 |
| zzzeek | hey | 19:29 |
| dhellmann | zzzeek: that thing you and ihar were working on for the new mysql driver :-( https://bugs.launchpad.net/nova/+bug/1368391 | 19:29 |
| dhellmann | unless it's oslo.db maybe? | 19:30 |
| zzzeek | that issue could be the pysqlite issue , though….i thought tests were passing in nova ? | 19:30 |
| zzzeek | unless this is the multi-execute thing | 19:30 |
| harlowja | bnemec well that would take the fun out of it, ha | 19:30 |
| harlowja | bnemec did u move the 'Released semaphore' to say a 'Releasing semaphore' (while still under the lock) | 19:31 |
| bnemec | harlowja: Yeah, Released semaphore is actually inside the lock as the last statement. | 19:31 |
| harlowja | cool | 19:32 |
| bnemec | harlowja: The code I'm testing looks like: http://paste.openstack.org/show/110300/ | 19:32 |
| harlowja | righto, cool | 19:32 |
| harlowja | well maybe a false alarm them | 19:33 |
| harlowja | *then | 19:33 |
| *** lbragstad has joined #openstack-oslo | 19:34 | |
| *** lbragstad has quit IRC | 19:37 | |
| *** jecarey has quit IRC | 19:38 | |
| *** jecarey has joined #openstack-oslo | 19:38 | |
| *** yamahata__ has joined #openstack-oslo | 19:39 | |
| *** mtanino has quit IRC | 19:40 | |
| *** yamahata_ has quit IRC | 19:40 | |
| *** mriedem1 has joined #openstack-oslo | 19:40 | |
| *** mriedem has quit IRC | 19:40 | |
| *** dims has quit IRC | 19:44 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo-incubator: Updated from global requirements https://review.openstack.org/119815 | 19:44 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.db: Updated from global requirements https://review.openstack.org/118564 | 19:44 |
| harlowja | bnemec well that would make it really simple if that was the issue :) | 19:47 |
| *** hartsocks has joined #openstack-oslo | 19:51 | |
| *** mgagne has joined #openstack-oslo | 19:51 | |
| *** jroll has joined #openstack-oslo | 19:51 | |
| *** hartsocks is now known as Guest14516 | 19:51 | |
| openstackgerrit | Ben Nemec proposed a change to openstack/oslo.concurrency: Clarify logging in lockutils https://review.openstack.org/120894 | 19:52 |
| bnemec | harlowja: Yeah, hopefully. :-) | 19:53 |
| bnemec | We definitely need to fix the logging though. It was clearly useless. | 19:54 |
| bnemec | Hence change^ | 19:54 |
| harlowja | ya | 19:54 |
| harlowja | +1 from me | 19:54 |
| harlowja | otherwise just causes confusion (like possibly this bug) | 19:54 |
| *** sigmavirus24 has joined #openstack-oslo | 19:54 | |
| openstackgerrit | Doug Hellmann proposed a change to openstack/oslo-specs: Remove specs not completed in juno https://review.openstack.org/120095 | 19:56 |
| harlowja | bnemec something thats confused me also | 19:57 |
| harlowja | oslo.concurrency has another lockutils @ https://github.com/openstack/oslo.concurrency/blob/master/oslo/concurrency/openstack/common/lockutils.py | 19:57 |
| harlowja | is that just in need of a oslo incubator sync/cleanup? | 19:57 |
| harlowja | *like files didn't get removed when the oslo incubator sync happened | 19:57 |
| bnemec | harlowja: Ah, yeah, that needs to be removed. | 19:58 |
| bnemec | I think the fixture module may depend on it though. | 19:58 |
| harlowja | hmmm | 19:58 |
| harlowja | holy crap, a third one | 19:58 |
| harlowja | https://github.com/openstack/oslo.concurrency/blob/master/oslo/concurrency/openstack/common/fixture/lockutils.py | 19:58 |
| *** amrith is now known as notamcrn | 19:58 | |
| harlowja | turtles all the way down | 19:58 |
| harlowja | lol | 19:58 |
| bnemec | Yeah, that's a different one though. :-) | 19:59 |
| harlowja | ya | 19:59 |
| harlowja | :) | 19:59 |
| *** notamcrn is now known as amrith | 19:59 | |
| bnemec | But actually, that fixture should be part of the library now, so we shouldn't need it at all. | 19:59 |
| harlowja | cool | 19:59 |
| bnemec | So definitely more cleanup needed. | 19:59 |
| harlowja | kk, i was about to enter inception there for a sec | 20:00 |
| harlowja | ha | 20:01 |
| openstackgerrit | Ben Nemec proposed a change to openstack/oslo.concurrency: Clarify logging in lockutils https://review.openstack.org/120894 | 20:01 |
| *** lbragstad has joined #openstack-oslo | 20:02 | |
| *** dims_ has joined #openstack-oslo | 20:03 | |
| *** mtanino has joined #openstack-oslo | 20:05 | |
| *** takedakn has joined #openstack-oslo | 20:05 | |
| openstackgerrit | Ben Nemec proposed a change to openstack/oslo-incubator: Clarify logging in lockutils https://review.openstack.org/120897 | 20:08 |
| *** markmcclain has joined #openstack-oslo | 20:10 | |
| dhellmann | bnemec: do you think we should try to make those logging changes for rc1, or let it go until kilo? | 20:13 |
| harlowja | i'm worried that if we don't we might get more false positive bugs :-/ | 20:14 |
| bnemec | Well, it's been this way for a long time. | 20:14 |
| bnemec | I guess the only thing is it might be helpful debugging the deadlock nova has been seeing. | 20:14 |
| bnemec | https://bugs.launchpad.net/nova/+bug/1349452 | 20:14 |
| bnemec | dhellmann: ^ | 20:15 |
| *** kgiusti has quit IRC | 20:16 | |
| bnemec | Although I guess we're hoping the file locks change fixes that, so maybe it's not a big deal anymore. | 20:17 |
| *** dims__ has joined #openstack-oslo | 20:17 | |
| bnemec | brb. Still haven't eaten lunch and getting kind of hungry. :-) | 20:17 |
| dhellmann | bnemec: I got distracted with the sqlalchemy-migrate thing. Are you saying there's a fix for the locking issue nova is seeing? Or that the log messages are misleading us and we don't have the problem we thought we had? | 20:17 |
| *** dims_ has quit IRC | 20:20 | |
| *** dims__ has quit IRC | 20:22 | |
| *** tkelsey has joined #openstack-oslo | 20:23 | |
| bnemec | dhellmann: Okay, there are two locking bugs open: https://bugs.launchpad.net/oslo.concurrency/+bug/1367941 and https://bugs.launchpad.net/nova/+bug/1349452 | 20:24 |
| *** flaper87 is now known as flaper87|afk | 20:24 | |
| bnemec | The first, AFAICT, is just bogus logging on our part. | 20:24 |
| bnemec | The second is "fixed" by the file locking change. | 20:24 |
| dhellmann | bnemec: I thought that concurrency bug was reported because of a real issue, though. Was it just because jogo saw something weird in the logs? | 20:25 |
| dhellmann | bnemec: and what is "the file locking change"? Is that the latest version of lockutils, or something pending? | 20:25 |
| bnemec | dhellmann: I think he reported the bug based on the bad logging that suggested it was possible to double lock a semaphore, which doesn't appear to be the case. | 20:25 |
| dhellmann | bnemec: ok, good, so your logging change is a "fix" for that bug | 20:26 |
| bnemec | dhellmann: The file locking change is just the switch back to file locks by default. | 20:26 |
| dhellmann | bnemec: right, and that's already committed? | 20:26 |
| bnemec | I think the hope was that that would fix the deadlock but, but I don't know that there was any specific evidence to support that. | 20:26 |
| bnemec | dhellmann: Right | 20:26 |
| bnemec | *bug | 20:26 |
| dhellmann | bnemec: ok, thanks | 20:26 |
| bnemec | np | 20:27 |
| dhellmann | bnemec: did you see harlowja's comment on the logging change? | 20:27 |
| bnemec | Not yet | 20:27 |
| dhellmann | nit on the log format, I don't know if it's worth holding things up over it | 20:28 |
| bnemec | Oh, the %lock stuff is a holdover from when debug messages were translated. | 20:28 |
| bnemec | I only left it in the second set of messages because it was there to begin with. | 20:28 |
| dhellmann | ok, I think he's pointing out that it's inconsistent now | 20:28 |
| dhellmann | that's fine, we can clean it up in oslo.concurrency later | 20:29 |
| harlowja | ya, thats all, just minor nit | 20:29 |
| *** tkelsey has quit IRC | 20:29 | |
| *** tedross has quit IRC | 20:36 | |
| *** andreykurilin has joined #openstack-oslo | 20:37 | |
| dhellmann | bnemec: +2 on both | 20:38 |
| bnemec | dhellmann: Thanks | 20:38 |
| dhellmann | bnemec: I also went ahead and scheduled the bug for rc1 | 20:40 |
| *** zzzeek has quit IRC | 20:40 | |
| bnemec | Sounds good | 20:40 |
| jogo | bnemec: heh this was all a case of misleading logs? | 20:56 |
| *** r1chardj0n3s_afk is now known as r1chardj0n3s | 20:56 | |
| bnemec | jogo: I think so. I couldn't find any double-acquires once I moved the logging into the lock itself. | 20:57 |
| bnemec | And http://paste.openstack.org/show/110298/ shows it doing the right thing with multiple threads trying to grab a lock. | 20:57 |
| jogo | bnemec: hopefully your right | 20:58 |
| jogo | glad it was just a case of misleading logs | 20:58 |
| harlowja | jogo lets wait and see ;) | 20:58 |
| *** markmcclain has quit IRC | 20:59 | |
| jogo | harlowja: yup, its easy to spot check if this fixes it | 20:59 |
| harlowja | agreed, anything out of order would mean it didn't work | 20:59 |
| *** tongli has quit IRC | 21:12 | |
| *** r1chardj0n3s is now known as r1chardj0n3s_afk | 21:26 | |
| *** amrith is now known as _amrith_ | 21:27 | |
| *** jaosorior has quit IRC | 21:42 | |
| openstackgerrit | Terry Howe proposed a change to openstack/cliff: Get testenv docs working https://review.openstack.org/120918 | 21:44 |
| openstackgerrit | lifeless proposed a change to openstack/oslo-incubator: Fixup Fixtures Use in db test classes. https://review.openstack.org/120919 | 21:45 |
| *** jecarey has quit IRC | 21:48 | |
| *** mriedem1 has left #openstack-oslo | 21:59 | |
| *** mriedem1 has quit IRC | 21:59 | |
| openstackgerrit | Sean Dague proposed a change to openstack/oslo.db: Fixup Fixtures Use in db test classes. https://review.openstack.org/120923 | 22:08 |
| harlowja | jogo qq, whats the ability to have an elastic recheck query that checks for the correct ordering? | 22:09 |
| * harlowja not a big user of that, so not sure | 22:09 | |
| *** dims_ has joined #openstack-oslo | 22:10 | |
| jogo | harlowja: we treat each line in a log file as its own thing | 22:13 |
| jogo | harlowja: so we cannot do queries accross log lines | 22:13 |
| harlowja | durn | 22:13 |
| *** andreykurilin has quit IRC | 22:14 | |
| *** dims_ has quit IRC | 22:14 | |
| *** pcm_ has quit IRC | 22:16 | |
| harlowja | if only could write a custom mapper/reducer | 22:17 |
| *** stannie has quit IRC | 22:30 | |
| *** gordc has quit IRC | 22:32 | |
| *** jgrimm is now known as zz_jgrimm | 22:32 | |
| *** praneshp has quit IRC | 22:36 | |
| *** openstackgerrit has quit IRC | 22:38 | |
| *** openstackgerrit_ has joined #openstack-oslo | 22:38 | |
| *** bknudson has quit IRC | 22:39 | |
| *** openstackgerrit_ is now known as openstackgerrit | 22:40 | |
| openstackgerrit | Ian Cordasco proposed a change to openstack/oslo-incubator: Do not incur the cost of a second method call https://review.openstack.org/120932 | 22:40 |
| *** dims_ has joined #openstack-oslo | 22:44 | |
| *** praneshp has joined #openstack-oslo | 22:45 | |
| *** ajo|afk has quit IRC | 22:53 | |
| openstackgerrit | A change was merged to openstack/oslo-incubator: Clarify logging in lockutils https://review.openstack.org/120897 | 22:58 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add a state machine copy() method https://review.openstack.org/120936 | 23:23 |
| *** r1chardj0n3s_afk is now known as r1chardj0n3s | 23:27 | |
| *** dims_ has quit IRC | 23:34 | |
| *** oomichi has joined #openstack-oslo | 23:37 | |
| *** _amrith_ is now known as amrith | 23:40 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 23:41 | |
| r1chardj0n3s | does anyone know why running "tox -e py27" in oslo.middleware results in testr giving me the results of every test *twice*? | 23:48 |
| openstackgerrit | A change was merged to openstack/oslo.rootwrap: Initial cut of documentation for oslo.rootwrap https://review.openstack.org/118752 | 23:51 |
| openstackgerrit | A change was merged to openstack/oslo.db: Fix DBReferenceError on MySQL and SQLite https://review.openstack.org/116324 | 23:51 |
| *** dims_ has joined #openstack-oslo | 23:52 | |
| openstackgerrit | A change was merged to openstack/oslo.vmware: Enable oslo.i18n for oslo.vmware https://review.openstack.org/120271 | 23:55 |
| *** dims__ has joined #openstack-oslo | 23:55 | |
| *** dims_ has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!