Wednesday, 2014-08-13

*** tsekiyama has quit IRC00:01
*** dims_ has quit IRC00:01
*** dims_ has joined #openstack-oslo00:01
*** tsekiyam_ has quit IRC00:03
*** dims_ has quit IRC00:06
openstackgerritlifeless proposed a change to openstack-dev/pbr: Teach pbr about post versioned dev versions.  https://review.openstack.org/8044900:16
openstackgerritlifeless proposed a change to openstack-dev/pbr: Raise an error if preversion versions are too low  https://review.openstack.org/10826900:16
openstackgerritlifeless proposed a change to openstack-dev/pbr: Look for and process sem-ver pseudo headers in git  https://review.openstack.org/10827000:17
openstackgerritlifeless proposed a change to openstack-dev/pbr: Introduce a SemanticVersion object  https://review.openstack.org/9410800:17
*** zzzeek has quit IRC00:22
*** arnaud has quit IRC00:23
*** dims_ has joined #openstack-oslo00:29
*** dims_ is now known as dims00:37
*** markmcclain has quit IRC00:50
*** Ish__ has joined #openstack-oslo00:52
*** arnaud has joined #openstack-oslo01:08
*** yamahata has joined #openstack-oslo01:10
openstackgerritA change was merged to openstack/oslo.vmware: Port the Datastore and DatastorePath objects  https://review.openstack.org/10527401:37
*** Ish__ has quit IRC01:51
*** Krast has joined #openstack-oslo02:00
*** dims has quit IRC02:04
*** dims has joined #openstack-oslo02:05
*** dims is now known as Guest4869502:05
*** Guest48695 has quit IRC02:09
*** Krast has quit IRC02:23
*** arnaud has quit IRC02:34
*** SridharG has joined #openstack-oslo02:34
*** mriedem has left #openstack-oslo02:36
*** mriedem has quit IRC02:36
*** arnaud has joined #openstack-oslo02:38
*** Krast has joined #openstack-oslo02:42
*** pcm_ has quit IRC02:49
openstackgerritYAMAMOTO Takashi proposed a change to openstack/oslo-incubator: Specify namedtuple_as_object=False when using simplejson  https://review.openstack.org/11376003:27
openstackgerritZhi Kun Liu proposed a change to openstack/oslo.messaging: Add parameter to customize Qpid receiver capacity  https://review.openstack.org/11253603:43
*** praneshp has quit IRC03:55
openstackgerritA change was merged to openstack/oslo.messaging: Enable PEP8 check E241  https://review.openstack.org/10907703:59
*** arnaud has quit IRC04:02
*** jroll|dupe has joined #openstack-oslo04:03
*** arnaud has joined #openstack-oslo04:05
*** jroll has quit IRC04:05
*** jroll|dupe is now known as jroll04:05
*** arnaud has quit IRC04:08
*** arnaud has joined #openstack-oslo04:18
*** praneshp_ has joined #openstack-oslo04:32
*** ildikov has quit IRC04:36
*** jgrimm has quit IRC05:01
*** SridharG has quit IRC05:25
*** k4n0 has joined #openstack-oslo05:30
openstackgerritOpenStack Proposal Bot proposed a change to openstack/oslo.vmware: Imported Translations from Transifex  https://review.openstack.org/11378506:08
*** HenryG_ has joined #openstack-oslo06:09
*** ildikov has joined #openstack-oslo06:11
*** HenryG has quit IRC06:12
*** SridharG has joined #openstack-oslo06:13
*** Alexei_987 has quit IRC06:14
*** stevemar has quit IRC06:42
*** stevemar has joined #openstack-oslo06:42
*** flaper87|afk is now known as flaper8706:44
*** AAzza_afk is now known as AAzza06:47
*** stevemar has quit IRC06:47
*** arnaud has quit IRC06:48
*** arnaud has joined #openstack-oslo06:57
*** jaosorior has joined #openstack-oslo07:18
*** ihrachyshka has joined #openstack-oslo07:20
*** ihrachyshka has quit IRC07:23
*** Alexei_987 has joined #openstack-oslo07:27
*** noelbk has quit IRC07:51
openstackgerritMa Wen Cheng proposed a change to openstack/oslo.messaging: Disable Topic name used as Queue name for QPID consumers  https://review.openstack.org/11380808:11
*** arnaud has quit IRC08:12
*** wenchma has joined #openstack-oslo08:18
*** ihrachyshka has joined #openstack-oslo08:26
*** pblaho has joined #openstack-oslo09:08
*** pblaho has quit IRC09:11
*** pblaho has joined #openstack-oslo09:11
*** ihrachyshka has quit IRC09:11
d0ugalHaving some issue with my oslo.db migration. The options are not showing up in the generated config sample. What is the correct way to include them now?09:58
*** sheeprine has quit IRC10:00
*** bnemec has quit IRC10:00
*** pblaho is now known as pblaho|afk10:01
*** ihrachyshka has joined #openstack-oslo10:07
*** sheeprine has joined #openstack-oslo10:07
*** bnemec has joined #openstack-oslo10:07
*** ihrachyshka has quit IRC10:07
*** ihrachyshka has joined #openstack-oslo10:07
*** pcm_ has joined #openstack-oslo10:13
*** pcm__ has joined #openstack-oslo10:15
*** pcm_ has quit IRC10:18
*** ihrachyshka has quit IRC10:23
*** sheeprine has quit IRC10:23
*** bnemec has quit IRC10:23
*** ihrachyshka has joined #openstack-oslo10:30
*** sheeprine has joined #openstack-oslo10:30
*** bnemec has joined #openstack-oslo10:30
*** ihrachyshka has quit IRC10:30
*** ihrachyshka has joined #openstack-oslo10:30
*** markmc has joined #openstack-oslo10:36
*** yamahata has quit IRC10:42
openstackgerritRossella Sblendido proposed a change to openstack/oslo.db: Retry query if db deadlock error is received  https://review.openstack.org/10954910:44
amrithYorikSar, russellb , pblaho|afk , dhellmann ... would you please re-review https://review.openstack.org/#/c/110933/10:48
*** dims has joined #openstack-oslo11:03
*** dims is now known as Guest2502111:03
*** pblaho|afk is now known as pblaho11:03
*** Guest25021 has quit IRC11:04
*** dims_ has joined #openstack-oslo11:05
*** dims_ has quit IRC11:22
*** dims_ has joined #openstack-oslo11:23
*** AAzza is now known as AAzza_afk11:24
*** dims__ has joined #openstack-oslo11:26
*** dims_ has quit IRC11:27
openstackgerritA change was merged to openstack/oslo.rootwrap: Refactor common parts from cmd to wrapper  https://review.openstack.org/10708311:30
*** pblaho is now known as pblaho|afk11:31
*** pblaho|afk is now known as pblaho11:39
dhellmannd0ugal: if you're using the config generator from the incubator, you probably need to add the -l option with oslo.db as an argument http://git.openstack.org/cgit/openstack/oslo-incubator/tree/tools/config/generate_sample.sh#n3511:46
d0ugaldhellmann: aha! awesome, that is just what I've been looking for.11:48
dhellmannd0ugal: if you wanted to be hip, you could update to use the config generator in oslo.config, which uses that mode only and no longer parses code looking for option definitions11:53
d0ugaldhellmann: I did look at that, I'm not sure I'm quite hip enough :)11:54
d0ugaldhellmann: (maybe once I solve my other issues)11:54
*** dims__ has quit IRC12:04
*** dims_ has joined #openstack-oslo12:05
*** dims_ has quit IRC12:09
openstackgerritYuriy Taraday proposed a change to openstack/oslo.rootwrap: Add an option to run rootwrap as a daemon  https://review.openstack.org/8179812:21
*** boris-42 has quit IRC12:21
*** dims_ has joined #openstack-oslo12:22
*** bknudson1 has quit IRC12:32
*** boris-42 has joined #openstack-oslo12:32
openstackgerritA change was merged to openstack-dev/cookiecutter: Use spaces instead of tabs for indentation  https://review.openstack.org/10386912:35
*** dims_ has quit IRC12:39
*** dims_ has joined #openstack-oslo12:40
*** dims_ has quit IRC12:44
openstackgerritRossella Sblendido proposed a change to openstack/oslo.db: Retry query if db deadlock error is received  https://review.openstack.org/10954912:45
dhellmannd0ugal: one step at a time :-)12:46
openstackgerritIhar Hrachyshka proposed a change to openstack/oslo-incubator: Add mock cleanup function to each test case  https://review.openstack.org/9546512:47
*** harlowja_at_home has joined #openstack-oslo12:48
ihrachyshkadhellmann: quite a lot of cores gave their +2's for mysqlconnector spec. can we proceed with pushing it?12:51
*** bknudson has joined #openstack-oslo12:52
dhellmannihrachyshka: yep, I think the last time I looked they hadn't yet12:55
dhellmannihrachyshka: regarding rpodolyaka_afk's point on the use of "switch", how about if we rename the blueprint after we approve the spec? maybe enable-mysql-connector or enable-alternate-db-drivers?12:57
dhellmannihrachyshka: I can do all of that, once you and I agree on a new name, so just let me know12:57
ihrachyshkadhellmann: I'm for it both hands if it does trigger another month of collecting approvals :)12:57
dhellmannihrachyshka: yeah, I'll just push the name change through on my own as PTL, so don't worry about that12:58
dhellmannihrachyshka: enable-alternate-db-drivers?12:58
dhellmannwell, maybe we should go with enable-mysql-connector for now to keep the scope in mind12:58
* dhellmann needs to finish his tea before naming things12:59
ihrachyshkadhellmann: ok, thanks :) well, enable-alternate-db-drivers is too wide I think. though I'll do the work so that it's reusable for other drivers, I'll test it with mysqlconnector before it's done. After that, we may try to check whether other drivers are easy to achieve.12:59
ihrachyshka+100 for enable-mysql-connector12:59
dhellmannok, enable-mysql-connector it is then :-)12:59
openstackgerritA change was merged to openstack/oslo-incubator: Use index-filter instead of tree-filter in graduate.sh  https://review.openstack.org/10968513:02
openstackgerritA change was merged to openstack/oslo-specs: Switch from MySQLdb to MySQL Connector  https://review.openstack.org/10835513:02
openstackgerritDoug Hellmann proposed a change to openstack/oslo-specs: Rename switch-to-mysql-connector spec  https://review.openstack.org/11387213:05
openstackgerritA change was merged to openstack/oslo-specs: Rename switch-to-mysql-connector spec  https://review.openstack.org/11387213:08
dhellmannihrachyshka: spec and blueprint approved and targeted13:09
dhellmannihrachyshka: please keep the status up to date as you start work :-)13:09
*** gordc has joined #openstack-oslo13:10
*** dims_ has joined #openstack-oslo13:10
openstackgerritA change was merged to openstack-dev/pbr: Introduce a SemanticVersion object  https://review.openstack.org/9410813:16
ihrachyshkadhellmann: what do you mean - keep the status up to date?13:16
ihrachyshkadhellmann: like 'report publicly the progress'?13:16
dhellmannihrachyshka: no, like set the status field of the blueprint in launchpad if it's not being updated automatically13:17
dhellmannihrachyshka: the "Implementation" field13:17
ihrachyshkaah, ok13:19
openstackgerritA change was merged to openstack/oslo-incubator: Enhance versionutils.deprecated to work with classes  https://review.openstack.org/10491613:20
*** jecarey has joined #openstack-oslo13:21
openstackgerritA change was merged to openstack-dev/oslo-cookiecutter: Use oslotest by default  https://review.openstack.org/10687613:24
openstackgerritA change was merged to openstack-dev/oslo-cookiecutter: Run py33 tests before py2x  https://review.openstack.org/10687513:24
*** stevemar has joined #openstack-oslo13:24
*** mriedem has joined #openstack-oslo13:29
openstackgerritA change was merged to openstack/oslo-incubator: Correct coercion of logged message to unicode  https://review.openstack.org/11077213:32
*** zzzeek has joined #openstack-oslo13:34
openstackgerritA change was merged to openstack/oslo-incubator: Add unicode coercion of logged messages to ContextFormatter  https://review.openstack.org/11213513:34
openstackgerritA change was merged to openstack/oslo-incubator: log: make tests portable  https://review.openstack.org/11029713:34
openstackgerritA change was merged to openstack/oslo-incubator: Except socket.error if syslog isn't running  https://review.openstack.org/11075313:36
openstackgerritA change was merged to openstack/oslo-incubator: Set keystonemiddleware and routes.middleware to log on WARN level  https://review.openstack.org/10937913:37
*** tongli has joined #openstack-oslo13:38
*** jecarey has quit IRC13:49
*** jecarey has joined #openstack-oslo13:50
openstackgerritA change was merged to openstack-dev/pbr: add docs env to tox  https://review.openstack.org/11352913:51
openstackgerritgordon chung proposed a change to openstack/oslo-specs: graduate-oslo-middleware  https://review.openstack.org/11035313:52
*** harlowja_at_home has quit IRC13:54
*** zzzeek has quit IRC13:58
openstackgerritA change was merged to openstack-dev/pbr: cleanup tox.ini  https://review.openstack.org/11355314:11
openstackgerritA change was merged to openstack/oslo.messaging: Enable PEP8 check E265  https://review.openstack.org/10907914:11
openstackgerritA change was merged to openstack/oslo.messaging: Enable PEP8 check E714  https://review.openstack.org/10908014:11
*** Krast has quit IRC14:13
*** Krast has joined #openstack-oslo14:14
*** AAzza_afk is now known as AAzza14:16
*** openstackgerrit has quit IRC14:16
*** mriedem has quit IRC14:17
*** openstackgerrit has joined #openstack-oslo14:17
*** jecarey has quit IRC14:18
*** mriedem has joined #openstack-oslo14:26
*** Krast has quit IRC14:28
*** Krast has joined #openstack-oslo14:28
openstackgerritA change was merged to openstack/oslo.rootwrap: Move test requirement coverage into tox.ini  https://review.openstack.org/10834514:29
*** Krast has quit IRC14:31
*** Krast has joined #openstack-oslo14:31
*** markmcclain has joined #openstack-oslo14:48
*** tsekiyama has joined #openstack-oslo14:49
*** markmcclain1 has joined #openstack-oslo14:51
*** flaper87 is now known as flaper87|afk14:54
*** markmcclain has quit IRC14:55
*** linkid has joined #openstack-oslo14:57
*** pblaho is now known as pblaho|afk14:58
linkidhi14:58
linkidI have a question about oslo.messaging14:58
YorikSaramrith: will do14:59
linkidis it possible to use the rpc communication without a bloquing server ?14:59
*** jgrimm has joined #openstack-oslo15:00
linkid'cause I used an rpc server with a callback, but I had to use server.wait() to reveive the client message, which is a blocked method15:02
*** ildikov has quit IRC15:06
ihrachyshkalinkid: which executor do you use?15:09
linkideventlet15:09
*** jecarey has joined #openstack-oslo15:09
*** pblaho|afk is now known as pblaho15:10
*** yamahata has joined #openstack-oslo15:19
*** noelbk has joined #openstack-oslo15:32
*** jaosorior has quit IRC15:32
openstackgerritChristian Berendt proposed a change to openstack/oslo.rootwrap: Replace string format arguments with function parameters  https://review.openstack.org/9437815:38
*** SridharG has quit IRC15:42
openstackgerritDolph Mathews proposed a change to openstack/oslo-incubator: add list_opts to all modules with configuration options  https://review.openstack.org/11394015:44
*** pcm__ has quit IRC15:57
*** ihrachyshka has quit IRC15:58
krotscheckI have a question on oslo.config - does it matter in what order CONF(project) and CONF.register_opts(FOO, ‘foocategory’) are called?15:59
*** k4n0 has quit IRC16:01
*** AAzza is now known as AAzza_afk16:03
*** noelbk has quit IRC16:09
*** praneshp has joined #openstack-oslo16:09
*** praneshp_ has quit IRC16:09
markmckrotscheck, nope16:12
krotscheckmarkmc: Thanks16:12
markmckrotscheck, you have to call register_cli_opts() before CONF(), but not register_opts()16:12
krotscheckAwesome, thanks16:12
markmcnp16:12
YorikSarttx: Hi, have a minute?16:14
YorikSarttx: I'm trying to figure out a way to test proper cleanup on process termination for my oslo.rootwrap patch and can't think of any.16:15
YorikSarThe problem was that _shutdown never run in atexit handler because I didn't specify exitpriority to Finalizer class (from multiprocessing).16:16
YorikSarTo test that I should run a separate process, let it spawn another (rootwrap) process, and then die. And then I should somehow see if my grandchild is alive or dead.16:17
YorikSarI don't think there's a way to do it w/o some psutils or smth.16:17
YorikSarttx: Oh, you're not online.16:18
YorikSarajo: ^ may be you can think of smth?16:19
ajohi YorikSar , 1 sec, reading16:19
*** arnaud has joined #openstack-oslo16:21
ajoYorikSar, what do you mean by "proper cleanup" ? :)16:21
ajoah, the atexit stuff16:22
ajolet me look at your last changes16:22
YorikSarajo: ttx noticed that benchmark run leaves a rootwrap process behind. It should be shut down on client process exit (finalizers are run in atexit handler).16:22
YorikSarajo: And that didn't happend because I missed one option to multiprocessing version of finalizers.16:23
ajoaha16:23
ajoso for actually checking that, you need to spawn a process, that spawns a rootwrap16:23
ajothat spawns a process16:23
ajoyikes16:23
*** praneshp has quit IRC16:23
ajoand then check that when first process exits, the rootwrap is gone16:24
YorikSarYep16:24
YorikSarFrom what I understand, that's rather hard...16:24
ajodon't you have an small implementation example to start and stop?16:25
ajoyou may need to list processes, yes16:25
ajorootwrap testing is unit, or is it functional?16:25
ajoit sounds like a functional test16:25
YorikSarThere are 2 tests that verify that rootwrap process exits, but they rely on wait() system call that waits on children only.16:26
*** yamahata has quit IRC16:26
YorikSarDaemon-related code is covered with functional tests as unit tests won't make a lot of sense with it.16:26
YorikSar(btw, I've added some functional testing for usual rootwrap as well recently)16:27
*** Ish__ has joined #openstack-oslo16:29
openstackgerritYuriy Taraday proposed a change to openstack/oslo.rootwrap: Add an option to run rootwrap as a daemon  https://review.openstack.org/8179816:43
*** AAzza_afk is now known as AAzza16:47
*** praneshp has joined #openstack-oslo16:53
openstackgerritYuriy Taraday proposed a change to openstack/oslo.rootwrap: Add daemon mode to benchmark  https://review.openstack.org/10708516:53
*** pcm_ has joined #openstack-oslo16:56
*** alexpilotti has joined #openstack-oslo16:57
*** AAzza is now known as AAzza_afk17:05
*** YorikSar has quit IRC17:07
*** YorikSar has joined #openstack-oslo17:09
*** zzzeek has joined #openstack-oslo17:11
*** yamahata has joined #openstack-oslo17:11
*** nealph has joined #openstack-oslo17:15
*** praneshp has quit IRC17:15
*** Alexei_987 has quit IRC17:17
*** yamahata has quit IRC17:18
openstackgerritYAMAMOTO Takashi proposed a change to openstack/oslo.serialization: Specify namedtuple_as_object=False when using simplejson  https://review.openstack.org/11397317:19
*** praneshp has joined #openstack-oslo17:22
*** ajo has quit IRC17:23
nealphquestion on oslo messaging: I'm digging for any capability to throttle message frequency (i.e. to avoid input flooding to downstream subscribers...in this case Ceilometer). Is there any such capability someone can point me to?17:23
*** markmc has quit IRC17:27
dhellmannnealph: I don't know if we have that in the messaging library. You might be able to do it through the broker, though?17:30
openstackgerritDmitry Tantsur proposed a change to openstack/oslo-incubator: Add field_labels parameter to cliutils.print_list  https://review.openstack.org/11397817:40
nealphdhellman: yep, thinking on that approach too. I see that qpid and rabbitmq both implement resource-based flow control but was curious to know if anyone had worked through the logic to do that in the "producers", i.e. oslo messaging for most services.17:43
nealphI'll keep nosing around.17:44
*** celttechie has joined #openstack-oslo17:44
dhellmannnealph: with notifications I think we wouldn't want the producer blocked, so you'd want to do the throttling after the message ends up safely in a queue somewhere17:46
*** linkid has left #openstack-oslo17:48
openstackgerritYAMAMOTO Takashi proposed a change to openstack/oslo.serialization: Specify namedtuple_as_object=False when using simplejson  https://review.openstack.org/11397317:51
*** Ish__ has quit IRC17:55
*** arnaud has quit IRC17:59
*** pblaho has quit IRC18:09
*** AAzza_afk is now known as AAzza18:16
mriedemgordc: i don't believe 'reverify' is a thing18:17
mriedemgordc: like 'reverify no bug' isn't a thing18:18
*** dims_ has quit IRC18:19
*** dims_ has joined #openstack-oslo18:19
openstackgerritIhar Hrachyshka proposed a change to openstack/oslo.db: Set utf8 encoding for mysql and postgresql  https://review.openstack.org/11123618:20
*** dims_ has quit IRC18:21
*** Alexei_987 has joined #openstack-oslo18:21
*** dims has joined #openstack-oslo18:21
gordcmriedem: hmm... i've seen people retriggering jobs like that. i was just too lazy to search out the real bug and assume there was a bug in ci which allowed you to recheck without bug #18:23
mriedemgordc: you can now recheck w/o a bug number18:24
mriedemgordc: but i don't think that extends to reverify18:24
*** krotscheck has quit IRC18:24
gordcmriedem: yeah that's what i thought. i feel like there's a bug that got in that makes it work for reverify too... or it seems to restart tests when i've done it.18:25
*** krotscheck has joined #openstack-oslo18:25
gordcmriedem: or do you mean it's not really reverifying when i type reverify...ie. it's just reposting same results?18:25
*** arnaud has joined #openstack-oslo18:26
mriedemgordc: oh i guess it is running tests again18:27
mriedemhm,18:27
mriedemgordc: well it'd be nice to see what's causing the failures rather than reverifying something through the gate18:27
mriedemmaybe the code is racing18:27
mriedemgordc: http://logs.openstack.org/99/99599/3/check/check-grenade-dsvm/45be8d5/logs/grenade.sh.txt.gz#_2014-08-13_14_11_44_10518:28
gordcmriedem: yeah... i figured i'd try one more time before i find time to actually dig into it18:28
mriedemhttp://logs.openstack.org/99/99599/3/check/check-grenade-dsvm/45be8d5/logs/new/screen-ceilometer-api.txt.gz18:29
mriedemyeah, i'd -2 that18:29
*** AAzza is now known as AAzza_afk18:29
gordcmriedem: interesting... didn't see that18:30
gordcmriedem: i rebased it...i don't feel like -2ing myself. :)18:30
gordcmriedem: looks like i got to think on this rebase. :( thanks for pointing it out.18:31
mriedemgordc: np18:31
*** dims_ has joined #openstack-oslo18:32
*** praneshp_ has joined #openstack-oslo18:33
*** pcm__ has joined #openstack-oslo18:34
zzzeekder, review.openstack borked ?18:36
zzzeekwow how strange.18:36
*** jokke__ has joined #openstack-oslo18:36
gordczzzeek: back for me... with some ui tweaks apparently.18:36
zzzeekrestart i guess18:37
*** arnaud has quit IRC18:41
*** praneshp has quit IRC18:41
*** dims has quit IRC18:41
*** pcm_ has quit IRC18:41
*** openstackgerrit has quit IRC18:41
*** jokke_ has quit IRC18:41
*** praneshp_ is now known as praneshp18:41
*** AAzza_afk is now known as AAzza18:44
amrithYorikSar, thx for comments, will push a patch set later today.18:44
*** openstackgerrit has joined #openstack-oslo18:49
*** AAzza is now known as AAzza_afk18:51
*** krotscheck has quit IRC18:54
*** krotscheck has joined #openstack-oslo18:55
openstackgerritMichael Bayer proposed a change to openstack/oslo.db: Repair pysqlite transaction support  https://review.openstack.org/11315218:56
openstackgerritMichael Bayer proposed a change to openstack/oslo.db: Repair pysqlite transaction support  https://review.openstack.org/11315218:57
*** ildikov has joined #openstack-oslo19:03
*** ildikov has quit IRC19:08
*** ildikov has joined #openstack-oslo19:21
*** celttechie has quit IRC19:31
openstackgerritChristian Berendt proposed a change to openstack/oslo.db: Add doc8 to tox environment docs  https://review.openstack.org/11400319:46
*** celttechie has joined #openstack-oslo19:51
openstackgerritChristian Berendt proposed a change to openstack/oslo.config: Add doc8 to tox environment docs  https://review.openstack.org/11400619:52
*** zzzeek_ has joined #openstack-oslo20:06
*** zzzeek has quit IRC20:06
*** zzzeek_ is now known as zzzeek20:06
*** Ish__ has joined #openstack-oslo20:26
openstackgerritDolph Mathews proposed a change to openstack/oslo-incubator: add list_opts to all modules with configuration options  https://review.openstack.org/11394020:27
openstackgerritgordon chung proposed a change to openstack/oslo-specs: graduate-oslo-middleware  https://review.openstack.org/11035320:31
openstackgerritgordon chung proposed a change to openstack/oslo.middleware: drop middleware suffix in class names  https://review.openstack.org/11401620:34
*** Ish__ has quit IRC20:37
*** celttechie has quit IRC20:38
*** stevemar has quit IRC20:47
*** Ish__ has joined #openstack-oslo20:54
*** Ish__ has left #openstack-oslo20:55
openstackgerritgordon chung proposed a change to openstack/oslo.middleware: drop middleware suffix in class names  https://review.openstack.org/11401621:04
*** celttechie has joined #openstack-oslo21:07
*** Alexei_987 has quit IRC21:12
*** wenchma has quit IRC21:12
*** YorikSar has quit IRC21:13
*** wenchma has joined #openstack-oslo21:13
*** YorikSar has joined #openstack-oslo21:14
*** Alexei_987 has joined #openstack-oslo21:15
*** arnaud__ has joined #openstack-oslo21:20
openstackgerritBrant Knudson proposed a change to openstack/oslo.messaging: Set sample_default for rpc_zmq_host  https://review.openstack.org/11403121:29
*** jecarey has quit IRC21:40
*** HenryG_ is now known as HenryG21:57
*** mriedem has left #openstack-oslo21:58
*** jgrimm has quit IRC22:44
*** bknudson has quit IRC22:45
openstackgerritA change was merged to openstack/oslo.serialization: Specify namedtuple_as_object=False when using simplejson  https://review.openstack.org/11397322:48
morganfainbergdhellmann, zzzeek, if i need to change a column type (and transform/reinsert the data), is it safest (low volume table) to just re-create the table and port the data over? or is there some preferred "migration" magic that seems to work with everything nice and cleanly22:51
morganfainbergdhellmann, zzzeek, unfortunately this is migrate not alembic22:51
zzzeekwell make a new column on the same table22:51
zzzeekthen do an UPDATE22:51
zzzeekthen drop the old column22:51
morganfainbergi thought sqlite didn't like renaming columns22:51
* morganfainberg can't ever remeber what sqlite sucks at and doesn't suck at22:52
zzzeekmorganfainberg: ah SQLite.  then migrate has this whole drop and recerate thing it should do automaticallyt22:52
*** markmcclain1 has quit IRC22:52
zzzeekmigrate currently has better support for that :)22:52
morganfainbergyeah it needs to work on mysql, postgres, sqlite, and db222:52
morganfainbergi think those are all the dbs that officially work with keystone22:53
zzzeekin theory it should do the right thing22:53
morganfainbergok so just add the column, port the data over, drop old column and rename?22:53
zzzeekif you have an explicit transformation though, then you’d need to have the two columns22:53
openstackgerritYAMAMOTO Takashi proposed a change to openstack/oslo-incubator: Specify namedtuple_as_object=False when using simplejson  https://review.openstack.org/11376022:53
zzzeekmorganfainberg: it “depends”22:53
morganfainbergyeah need to go from DATETIME to VARCHAR (with isotime str)22:53
zzzeekmorganfainberg: on sqlite, table has to be rebuilt entirely, yes.  migrate does this (somehow)22:53
zzzeekmorganfainberg: other databases, dont know that migrate does that.  you create a new col, emit UPDATE, drop the old22:54
morganfainbergbecause mysql is crappy about DATETIME(6)22:54
zzzeekmorganfainberg: um also …what?   whats wrong with DATETIME ?22:54
morganfainbergdatetime in older than 5.6.4 of mysql doesn't have microsecond resolution22:54
zzzeekhow about TIMESTAMP ?22:55
morganfainbergkeystone relies on microsecond resolution for a couple things and it's stored in the DB22:55
morganfainbergsame issue i think.22:55
zzzeekso you’d want to store an ISO string and not, say, epoch in millis ?22:55
zzzeekmorganfainberg: also, SQLite doesnt have a DATETIME type.  SQLAlchemy is already storing an ISO string in it22:55
morganfainberglooks like 5.6.4 adds subsecond resolution to TIME DATETIME and TIMESTAMP22:56
morganfainbergso, blah. need to go varchar.22:56
morganfainbergzzzeek, right but i actually need to declare this as varchar now and do the transform explicitly . i would rather not have wildly differing schemas on different RDBMSs (e.g.varchar and magic to convert for mysql only)22:57
morganfainbergthough... i *guess* i could do that22:57
zzzeekmorganfainberg: OK I htink you should have the same type on all backends22:58
zzzeekmorganfainberg: but on SQLite, there is no DATETIME, it is already an ISO string22:58
morganfainbergzzzeek, right, but SQLAlchemy is doing the magic for me, right?22:59
zzzeekmorganfainberg: but, if you stored as epoch in millis, then that could be everywhere.   depends22:59
zzzeekmorganfainberg: with the SQLite DATETIME, yes.22:59
morganfainbergyeah.22:59
zzzeekmorganfainberg: with any system, you can make your own type that does the conversion22:59
morganfainbergthat was what i was going to do22:59
zzzeekmorganfainberg: so you could have it be mysql-only22:59
morganfainbergbut just use it globally.22:59
morganfainbergrather than be "mysql" specific22:59
morganfainbergisotime_str_backed_datetime which would do timeutils.isotime() on store and timeutils.parse_isotime() on load23:00
morganfainbergfor example23:00
zzzeekyou can have a type that does somehing different on mysql, if you wanted23:01
morganfainbergzzzeek, would it be betteroverall to just be mysql specific in that case?23:01
morganfainbergzzzeek, i'd rather go with best practices vs. "eh something that works"23:02
morganfainberg:)23:02
zzzeekmorganfainberg: with this issue i’m mostly thinking of, why is keystone comparing on time in millis and not a monotonically incrmenting counter of some kind :)23:02
zzzeekmorganfainberg: timestamps for distinguishing events is a bad idea :)23:02
morganfainbergzzzeek, token expiration, tokens expire at isotime.subsectond23:02
*** krotscheck has quit IRC23:03
morganfainbergrevocation events can invalidate tokens based on their expiration time23:03
morganfainberg1 second resolution causes transient bugs23:03
zzzeekmorganfainberg: that’s the funny part23:03
*** krotscheck has joined #openstack-oslo23:03
morganfainbergit's because many many more tokens match at 1s resolution23:03
zzzeekmorganfainberg: when a too-great second resolution causes bugs that means something is comparing that timestamp to some other timestamp23:03
morganfainbergit is generally deemed that subsecond resolution (6 digits) is a narrow enough scope to prevent minimal transient bugs23:04
zzzeekmorganfainberg: smells off to me, but i dont know the details23:05
morganfainbergso we issue 3 tokens that expire at 2014-08-04 00:00:00 with differing subsecond transactions. we issue a revocation event for one of them. but mysql trims it down to the full second23:05
morganfainbergall three tokens are now invalid23:05
zzzeekmorganfainberg: i just find datetimes as strings really distasteful23:05
morganfainbergif mysql didn't trim the subseconds off only one token would be invalidated23:05
zzzeekok wait23:06
zzzeek“issue a revocation event for one of them"23:06
morganfainbergwe are trying to compare datetime to datetime, but the RDBMS doesn't keep subsecond resolution23:06
zzzeekand “one of them” means, “the one with timestamp X” ?  that is, you are using timestamp as primary key23:06
morganfainbergwith expiration time of X23:06
zzzeeksee, thats the design failure23:06
morganfainbergwe can't use token ids23:06
morganfainbergthe token ids (the PK) are security and could be abused between event and when token is revoked at an endpoint23:07
zzzeekmorganfainberg: would it be correct to have the subsecond resolution and then make this column a unique constraint ?23:07
zzzeekmorganfainberg: if token ids are secure then there’s a one-way encrypted version that’s exposed....23:07
morganfainbergwe technically can't make it unique... but that is the design.23:07
morganfainbergzzzeek, the hash and the full id can be used interchanably23:08
morganfainbergit's a real headache23:08
*** markmcclain has joined #openstack-oslo23:08
morganfainbergi've been advocating using a non-auth granting id that can be used23:08
morganfainbergbut i was shot down on that front23:08
morganfainbergwe also use expiration_time to identify a chain of tokens,  X token is rescoped which means Y token is issued. both contain the same expiration time23:08
* morganfainberg would *rather* not use expiration_time in this case23:09
zzzeekmorganfainberg: why cant this just be a uuid4() value ?   is that what your proposal was ?23:09
morganfainbergzzzeek, yep. but it introduces a backwards incompatible change23:10
zzzeekseems like this is all already a done deal.  but the design is wrong :)23:10
morganfainbergzzzeek, among "it adds more data to the token" and "why do we need to do that"23:10
zzzeek“its a unique key but we techincally cant make it unique” :)   run run run !23:10
zzzeektahts like php programming 101 :)23:10
morganfainbergzzzeek, yeah the reason we can't make it unique is there is a *small* chance with multiple keystone running that expiration times can collide23:11
morganfainbergi made this argument before and lost23:11
zzzeekbut if you used GUIDs, then it wouldnt23:11
zzzeektoo bad23:11
morganfainbergsince microsecond resolution is only valid on a single clock domain within a system, due to skew23:11
openstackgerritClark Boylan proposed a change to openstack/oslo-incubator: Set python hash seed to 0 in tox.ini  https://review.openstack.org/11405223:11
morganfainbergyeah. it makes me kinda sad.23:11
morganfainbergi might try just flying the uuid thing again and wait for a -223:12
zzzeekwell ill +1 it if you do23:12
morganfainbergbecause i really think expiration time is kinda broken.23:12
zzzeektil then i guess use the string23:12
morganfainbergzzzeek, and don't get me started about hashing and insecure hashing concerns23:13
morganfainbergzzzeek, e.g. you can *never use md5 ever* even if it isn't used for secure data because things could collide and auditors don't care if you aren't doing anything special with it, you're using it. same hold true for anything less than sha25623:14
zzzeekyeah i generally stick to sha23:14
zzzeekbut really, jsut uuid23:14
zzzeekgood enough23:14
morganfainbergi tried that, and got told sha1 wasn't sufficient anymore unless it's sha25623:14
morganfainbergor greater23:14
morganfainberg*great*23:15
zzzeekyou can use uuid5() , it is based on a seed23:15
zzzeekits deterministic23:15
zzzeekpasses all the fancy tests23:15
morganfainbergnope, you can't, it's sha1 based23:15
zzzeekoh it is?   silly :)23:15
morganfainbergep23:15
morganfainbergyep23:15
zzzeeki mean, not for security23:15
zzzeekbut for collisions?23:15
zzzeekthey think a uuid is going to collide ?23:15
morganfainberguuid5 they think will and auditors throw a fit23:15
morganfainberguuid4 is safe, it's random23:16
* morganfainberg facepalms in the corner23:16
zzzeekok but you understand, that instead, you are using a value that *definitely* collides *all the time*23:16
morganfainbergi tried to pitch using uuid5 for user_ids in keystone, got told "nope we need the data to be hashed to sha256"23:16
zzzeeka timestamp!23:16
morganfainbergin this case yes.23:16
zzzeekwhoever is hitting you with the sha256 show them this23:17
zzzeekand then tell them they are idiots23:17
zzzeekthat they are nazis about sha256 but are totlaly fine with timestamps as not-quite-unique keys23:17
zzzeeksorry, it is just so stupid23:17
morganfainbergthis whole problem stems from some technical debt that is a lot worse than i thought it was going to be in icehouse (not my code, but... still i let it pass into keystone)23:17
morganfainbergzzzeek, i've been working to go around the issues that make auditors unhappy (especially in keystone) most of this cycle i think.23:18
zzzeekits one thing for people to be overly paranoid, but for them to be completely inconsistent about it is insane23:18
morganfainbergthey are consistent, sha1 is nogo23:18
morganfainbergever at all in the application23:18
morganfainberg:P23:18
zzzeekits not consistent b.c. the rationale is one that they are willing to crap all over in other equivalent cases23:18
zzzeekid push to get these auditors to be aware that timestmaps collide23:19
morganfainbergit's hashing. if i *hashed* the timestamps and stored that in the db and only used it for the revocation it would be shot down23:19
zzzeekput a big comment, “dear auditors, these collide *all the time*!!”23:19
morganfainbergi think i'm just going to inject uuid4 into the token23:19
morganfainbergand revoke on that.23:19
morganfainbergif that doesn't exist fall back to the timestamp brokenness *backwards compat*23:19
morganfainbergand in ... 15kajillion releases maybe the brokenness can be removed23:20
* morganfainberg is feeling a little bitter :P23:20
morganfainbergzzzeek, thanks for your help dude, i appreciate it.23:20
zzzeekgood luck23:20
morganfainbergzzzeek, you gave me the information i needed if i need to muck with the db schema23:20
openstackgerritOpenStack Proposal Bot proposed a change to openstack/oslo-incubator: Updated from global requirements  https://review.openstack.org/11406323:23
openstackgerritOpenStack Proposal Bot proposed a change to openstack/oslo.middleware: Updated from global requirements  https://review.openstack.org/11406423:23
openstackgerritOpenStack Proposal Bot proposed a change to openstack/oslo.serialization: Updated from global requirements  https://review.openstack.org/11406523:24
openstackgerritClark Boylan proposed a change to openstack/oslo.messaging: Make tests pass with random python hashseed.  https://review.openstack.org/11407923:26
*** clarkb has joined #openstack-oslo23:36
*** gordc has quit IRC23:36
clarkbhello oslo23:36
clarkbas part of my prep to upgrade tox I tested tox 1.7.2 against oslo* and https://review.openstack.org/#/c/114079/1 and https://review.openstack.org/#/c/114052/ come out of that23:37
clarkbif my change in 114079 does actually expose a real bug we should probably propose the equivalent of 114052 aganst messaging and fix that bug separately23:37
clarkb-incubator's failures were a bit more complicated and the py33 tests were already setting hashseed=0 so I didn't bother to try and fix them (that said we really should be able to run with a random hashseed because python3 defaults to that and telling people they need to set a different hashseed to run opesntack is :( )23:41
krotscheckI know this is only tangentially related to oslo, however does anyone know why I wouldn’t be able to connect to rabbitmq unless the user in question was an admin?23:49
*** markmcclain1 has joined #openstack-oslo23:56
*** markmcclain has quit IRC23:56

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!