Friday, 2014-07-25

*** Ish__ has joined #openstack-oslo00:03
*** tsekiya__ has quit IRC00:04
*** tsekiya__ has joined #openstack-oslo00:06
*** zzzeek has quit IRC00:18
*** dims_ has joined #openstack-oslo00:27
*** arnaud has quit IRC00:29
*** arnaud__ has quit IRC00:29
openstackgerritamrith proposed a change to openstack/oslo-incubator: Mask passwords in exceptions and error messages  https://review.openstack.org/10941701:01
celttechieIf someone had a minute to review:  https://review.openstack.org/#/c/108198/   ...it won't take long.01:18
*** liusheng has joined #openstack-oslo01:20
openstackgerritA change was merged to openstack/taskflow: Enable hacking checks H305 and H307 in tox.ini template  https://review.openstack.org/10920401:26
openstackgerritJoshua Harlow proposed a change to openstack/taskflow: Revamp the symbol lookup mechanism  https://review.openstack.org/10857201:28
openstackgerritJoshua Harlow proposed a change to openstack/taskflow: Revamp the symbol lookup mechanism  https://review.openstack.org/10857201:32
openstackgerritamrith proposed a change to openstack/oslo-incubator: Log stdout, stderr and command on execute() error  https://review.openstack.org/10946901:39
*** Ish__ has quit IRC01:39
*** yamahata has quit IRC01:40
*** liusheng has quit IRC01:50
*** liusheng has joined #openstack-oslo01:51
*** liusheng has quit IRC02:03
*** liusheng has joined #openstack-oslo02:04
*** praneshp has quit IRC02:13
*** arosen has quit IRC02:17
*** Ish__ has joined #openstack-oslo02:23
*** SridharG has quit IRC02:23
*** zzzeek has joined #openstack-oslo02:32
*** Ish__ has quit IRC02:33
*** harlowja is now known as harlowja_away02:37
*** Ish__ has joined #openstack-oslo02:38
*** dims_ has quit IRC02:48
*** zzzeek has quit IRC02:50
*** HenryG is now known as HenryG_afk03:08
*** tsekiya__ has quit IRC03:09
*** yamahata has joined #openstack-oslo03:18
*** arnaud has joined #openstack-oslo03:29
*** arnaud has quit IRC03:43
*** celttechie has quit IRC03:49
*** arnaud has joined #openstack-oslo04:05
*** harlowja_at_home has joined #openstack-oslo04:16
*** harlowja_at_home has quit IRC04:17
*** noelbk has quit IRC04:17
*** harlowja_at_home has joined #openstack-oslo04:18
*** arnaud has quit IRC04:33
*** arnaud has joined #openstack-oslo04:35
*** harlowja_at_home has quit IRC04:41
*** SridharG has joined #openstack-oslo04:53
*** mrda is now known as mrda-traveling04:55
*** jecarey has joined #openstack-oslo04:59
openstackgerritJoshua Harlow proposed a change to openstack/taskflow: Revamp the symbol lookup mechanism  https://review.openstack.org/10857205:13
*** aaronorosen has joined #openstack-oslo05:45
*** k4n0 has joined #openstack-oslo05:56
*** praneshp has joined #openstack-oslo06:00
openstackgerritOpenStack Proposal Bot proposed a change to openstack/oslo.i18n: Imported Translations from Transifex  https://review.openstack.org/10693806:03
*** harlowja_at_home has joined #openstack-oslo06:06
*** Ish__ has joined #openstack-oslo06:10
*** Ish__ has left #openstack-oslo06:12
*** arnaud has quit IRC06:12
*** praneshp_ has joined #openstack-oslo06:16
*** praneshp has quit IRC06:19
*** praneshp_ is now known as praneshp06:19
openstackgerritJoshua Harlow proposed a change to openstack/taskflow: Revamp the symbol lookup mechanism  https://review.openstack.org/10857206:29
*** noelbk has joined #openstack-oslo06:34
*** mkoderer_cloud has joined #openstack-oslo06:41
*** abhijeetm has joined #openstack-oslo06:45
*** abhishek has joined #openstack-oslo06:45
*** abhijeetm has left #openstack-oslo06:45
*** harlowja_at_home has quit IRC06:59
*** praneshp has quit IRC07:09
*** praneshp has joined #openstack-oslo07:10
*** praneshp has quit IRC07:21
*** i159 has joined #openstack-oslo07:26
*** flaper87 has quit IRC07:30
*** flaper87 has joined #openstack-oslo07:30
abhishekhi dhellmann, you around?07:32
*** yamahata__ has quit IRC07:48
*** flaper87 is now known as flaper87|afk07:52
*** ihrachyshka has joined #openstack-oslo07:54
*** ihrachyshka has quit IRC07:55
*** ihrachyshka has joined #openstack-oslo08:02
*** nacim has joined #openstack-oslo08:05
*** ihrachyshka has quit IRC08:12
*** pblaho has joined #openstack-oslo08:14
*** ihrachyshka has joined #openstack-oslo08:27
*** ildikov has joined #openstack-oslo08:37
*** noelbk has quit IRC08:37
*** noelbk has joined #openstack-oslo08:37
*** ildikov_ has quit IRC08:40
*** oomichi has quit IRC08:49
openstackgerritAlex Frolov proposed a change to openstack/oslo-incubator: Transfer class LazyPluggable from nova to oslo-incubator  https://review.openstack.org/10737309:25
openstackgerritChris Dent proposed a change to openstack/oslo.messaging: Fix error in example of an RPC server  https://review.openstack.org/10841009:27
openstackgerritBertrand Lallau proposed a change to openstack/oslo.messaging: Add call/cast rpc logs for debug purpose  https://review.openstack.org/10952609:31
*** ihrachyshka has quit IRC09:41
*** ihrachyshka has joined #openstack-oslo09:41
*** amotoki has quit IRC09:42
openstackgerritBertrand Lallau proposed a change to openstack/oslo.messaging: Add call/cast rpc logs for debug purpose  https://review.openstack.org/10952609:43
*** dims has joined #openstack-oslo10:24
openstackgerritA change was merged to openstack/oslo.db: Add disconnect modification support to exception handling  https://review.openstack.org/10643210:24
openstackgerritA change was merged to openstack/oslo.db: Updated from global requirements  https://review.openstack.org/10517310:26
openstackgerritA change was merged to openstack/oslo.db: Integrate the ping listener into the filter system.  https://review.openstack.org/10649110:29
*** yamahata has quit IRC10:31
*** pcm_ has joined #openstack-oslo10:32
*** pcm__ has joined #openstack-oslo10:33
*** pcm_ has quit IRC10:37
openstackgerritA change was merged to openstack/oslo.db: Port _is_db_connection_error check to exception filters  https://review.openstack.org/10649210:39
openstackgerritA change was merged to openstack/oslo.db: Use SQLAlchemy cursor execute events for tracing  https://review.openstack.org/10640610:49
*** Alexei_9871 has joined #openstack-oslo11:03
*** mkoderer_cloud has quit IRC11:06
*** mkoderer_cloud has joined #openstack-oslo11:06
openstackgerritOleksii Chuprykov proposed a change to openstack/oslo.db: Add create_database_permission_exist function  https://review.openstack.org/10925911:12
openstackgerritAlexei Kornienko proposed a change to openstack/oslo.messaging: Should not send replies for cast messages  https://review.openstack.org/10914311:15
openstackgerritRossella Sblendido proposed a change to openstack/oslo.db: Retry query if db deadlock error is received  https://review.openstack.org/10954911:19
*** alexpilotti has joined #openstack-oslo11:27
*** ihrachyshka has quit IRC11:28
*** ihrachyshka has joined #openstack-oslo11:28
*** k4n0 has quit IRC11:38
openstackgerritBertrand Lallau proposed a change to openstack/oslo.messaging: Add call/cast rpc logs for debug purpose  https://review.openstack.org/10952612:03
*** ihrachyshka has quit IRC12:07
*** ihrachyshka has joined #openstack-oslo12:07
openstackgerritYuriy Taraday proposed a change to openstack/oslo-incubator: Remove oslo.log from lockutils  https://review.openstack.org/10956112:09
openstackgerritchandan kumar proposed a change to openstack/oslo.config: Added link to bug tracker and documentation in oslo.config readme  https://review.openstack.org/10791712:21
*** dims has quit IRC12:23
*** dims has joined #openstack-oslo12:25
dhellmannabhishek: I'm here now, if you're still online.12:37
abhishekdhellmann:hi, i want to talk with you about, https://review.openstack.org/#/c/106690/12:38
abhishekdhellmann:oslo-spec for adding new comparison check in oslo-incubator's policy module12:38
dhellmannabhishek: ok12:39
abhisheksorry, please reffer this spec https://review.openstack.org/#/c/106285/12:39
dhellmannabhishek: found it; I'm reading your responses now12:40
*** gordc has joined #openstack-oslo12:40
abhishekdhellmann:ok12:41
*** HenryG_afk is now known as HenryG12:42
dhellmannabhishek: is all of this about matching literal expressions that would otherwise look like variables (like '%(test_key)s')?12:42
abhishekdhellmann:yes12:43
dhellmannok, that only became clear after reading the implementation you have12:43
dhellmannwhat's the use case for that?12:43
abhishekdhellmann:like in glance I want to create some license image and want to ensure that other users should not download and use that12:44
dhellmannabhishek: how would you express that with this new rule?12:45
abhishekdhellmann: i will create a licensed image by adding custom property to the image say x_license_code = license_key12:45
dhellmannabhishek: ok, and then what would the proposed policy rule look like? I'm afraid I'm being dense, but I don't see why you can't already do that.12:46
abhishekexample: x_license_key = abc_1234" and add it to image and then add a rule in policy.json, say 'restricted': 'abc_1234==%(x_license_key)s' makes more sense12:47
abhishekand for download image "download_image": "role:admin or rule:restricted"12:48
dhellmannso you want to place the literal value representing the key you're checking first in the rule, and the variable second?12:49
*** bknudson has quit IRC12:49
abhishekdhellmann:yes12:49
dhellmannabhishek: it seems like you could express that now as x_license_key:abc_1234 right?12:50
abhishekdhellmann:yes12:50
dhellmannor, hang on, actually it would be abc_1234:%(x_license_key)s12:50
* dhellmann isn't a policy syntax expert, obviously12:50
abhishekyes, this is right12:50
*** russellb is now known as rustlebee12:50
dhellmannok, and so you want to remove the %(x_license_key)s part of the check?12:51
dhellmannthat is, you want to turn %(x_license_key)s to just x_license_key12:51
dhellmannthat doesn't seem like it buys us much, though, when considered against the need to update existing documentation for the syntax change12:52
abhisheknoelbk, I want this as " %(x_license_key)s" only12:52
dhellmannabhishek: but that's not the example you gave above, you said 'restricted': 'abc_1234==%(x_license_key)s'12:54
abhishekyes, that's true12:54
dhellmannabhishek: are you saying you want the rule to be written: 'restricted': '%(x_license_key)s'12:54
dhellmannthat's not what you code change does, I think12:55
abhishekdhellmann:just a minute, i will explain you properly12:55
dhellmannok12:57
abhishekdehllmann: in the rule 'restricted': 'abc_1234==%(x_license_key)s', 'abc_1234' is called as 'kind' and %(x_license_key)s is called as 'match'12:57
abhishekdhellmann: if you reffer https://github.com/openstack/oslo-incubator/blob/master/openstack/common/policy.py#L89212:58
abhishekdhellmann: you can find that 'abc_1234' need to be passed as credential to this check in order to do the comparison of kind and match12:59
abhishekdhellmann: currently, you can pass only context info (i.e. user, tenant, role etc) in the credential while enforcing the policy check13:00
abhishekdhellmann: so if I want to enforce policy using any image property then, its not possible to pass this property in the credential13:02
dhellmannthe image properties are passed in the "target" variable, right?13:02
abhishekyes13:02
abhishekdhellmann:https://review.openstack.org/#/c/98737/10/glance/openstack/common/policy.py13:03
dhellmannI think that makes the syntax you want: 'abc_1234':%(x_license_key)s13:03
dhellmannwhich, I agree, isn't obvious13:03
*** bnemec has joined #openstack-oslo13:04
abhishekdhellmann:so what's your opinion on this13:05
abhishekif you see the docstring, https://github.com/openstack/oslo-incubator/blob/master/openstack/common/policy.py#L876 this syntax is already used13:06
dhellmannabhishek: well, I am not sure changing the syntax in such a slight way for a case that we already support makes a lot of sense13:06
*** bknudson has joined #openstack-oslo13:07
dhellmannabhishek: I do agree the current form is a bit backwards, but the inconsistency of having it work both ways just adds to the documentation burden13:07
abhishekdhellmann:yes13:08
abhishekdhellmann: then can I add this check in GenericCheck class only, which will solve the purpose?13:09
dhellmannabhishek: no, I don't think this is a change we want to make right now. I would like, at some point, to create a policy language that is easier to read and write, but I think that is a much bigger project than what you are proposing here.13:10
*** zzzeek has joined #openstack-oslo13:11
viktors|afkzzzeek: hi!13:11
*** viktors|afk is now known as viktors13:11
abhishekdhellmann:I will upload the new spec with appropriate example, which will help to understand more clearly13:12
abhishekdhellmann:thank you for your time13:14
dhellmannabhishek: ok13:15
*** lbragstad has joined #openstack-oslo13:18
*** mriedem has joined #openstack-oslo13:20
*** ihrachyshka has quit IRC13:29
*** ihrachyshka has joined #openstack-oslo13:29
*** jecarey has quit IRC13:30
i159zzzeek: Hi! I have several questions to you. Have you a minute, please?13:30
zzzeeki159: sure, just be patient for my responses as im getting multiple messsages out :)13:31
i159zzzeek: At first short one :) Where is the best place to put a test for PGInspector.load_enums?13:33
zzzeekhm13:33
zzzeekprobably test/dialect/postgresql/test_dialect13:33
*** bnemec is now known as beekneemech13:34
i159zzzeek: ok... I want to create something like schema.DropEnum, but the ddl module code looks to me very unusual. Should I do it or postgresql.ENUM(name=enum).drop(conn) is enaugh?13:38
zzzeekthere already is a postgresql.DropEnum13:39
openstackgerritA change was merged to openstack/oslo.db: Raise DBReferenceError on foreign key violation  https://review.openstack.org/9433313:44
i159zzzeek: It's amazing how I missed it! Anyway, good news. I hope I'll be done with a pull request today. And I have one more big question...13:44
*** abhijeetm has joined #openstack-oslo13:44
openstackgerritDoug Hellmann proposed a change to openstack/cliff: Set the main logger name to match the application  https://review.openstack.org/10957813:46
i159zzzeek: I want to discuss your comment https://review.openstack.org/#/c/99965/. I have tried to implement oslo.config instead of Alembic config. I met a lot of problems. Alembic uses config inside of environment and script modules. Oslo.config has different interface. It seems to me like an amount of overhead work to implement it. I guess I could missed a simple way. Actually I think it is an overhead, but I still need your opinion. Thanks!13:51
openstackgerritDoug Hellmann proposed a change to openstack/cliff: Clean up default tox environment list  https://review.openstack.org/10958213:51
zzzeeki159: OK i want you to not use “alembic.ini”  - the file13:52
zzzeeki159: but you *do* have to use alembic.config.Config13:52
zzzeeki159: you need to copy the things you need from oslo.config into alembic.Config13:52
zzzeeki159: programmatically13:52
i159zzzeek: Ok, sounds good to me. Thanks for your answers!13:54
zzzeeki159: good luck i have not made it easy for you :)13:54
openstackgerritMark McLoughlin proposed a change to openstack/oslo.messaging: Add release notes for stable/icehouse 1.3.1 release  https://review.openstack.org/10791514:05
*** markmcclain has joined #openstack-oslo14:09
*** yamahata has joined #openstack-oslo14:12
openstackgerritMark McLoughlin proposed a change to openstack/oslo.messaging: Add release notes for 1.4.0.0a4  https://review.openstack.org/10959914:13
*** nacim has quit IRC14:22
viktorszzzeek: hi!14:30
zzzeekhey viktors14:31
viktorsrecently we with rpodolyaka found a strange issue with SQLA connections14:31
viktorszzzeek: can you please help us investigate it?14:32
zzzeekviktors: sure14:32
viktorszzzeek: let's got to PM14:32
*** ihrachyshka has quit IRC14:38
openstackgerritA change was merged to openstack/oslo.db: Bump hacking to version 0.9.2  https://review.openstack.org/10740214:42
*** abhijeetm has left #openstack-oslo14:43
*** abhishek has quit IRC14:44
openstackgerritRadoslav Gerganov proposed a change to openstack/oslo.vmware: Log additional details of suds faults  https://review.openstack.org/10453414:50
YorikSardhellmann: Hi... Can you help me with graduate.sh script?14:50
openstackgerritKen Giusti proposed a change to openstack/oslo.messaging: An initial implementation of a 1.0 based messaging driver  https://review.openstack.org/7581514:50
*** markmcclain has quit IRC14:51
dhellmannYorikSar: I can try :-)14:52
YorikSardhellmann: I'm suprisingly getting a merge conflict14:52
*** lbragstad has quit IRC14:52
dhellmannYorikSar: that is surprising. can you set up a pastebin with the commands you're running and a link to the repository, so I can try it?14:53
*** jecarey has joined #openstack-oslo14:53
YorikSardhellmann: (btw, I've added -d option to filter-branch so that it takes about 3 minutes instead of 25)14:54
YorikSardhellmann: I've cloned original oslo-incubator and run ../oslo-incubator/tools/graduate.sh concurrency openstack/common/{lockutils.py,processutils.py} tests/unit/test_lockutils.py tests/unit/test_processutils.py14:55
*** lbragstad has joined #openstack-oslo14:55
dhellmannthat all looks right14:55
dhellmannwhat does the -d option do?14:56
YorikSardhellmann: And somewhere along the way I'm getting on "lockutils: do not grab the lock in creators" commit... I thought that can't happen.14:56
YorikSardhellmann: It sets temporary directory where filter-branch works. I've moved it to tmpfs14:56
dhellmannok14:57
dhellmannLet me try it here...14:57
*** celttechie has joined #openstack-oslo15:01
*** ihrachyshka has joined #openstack-oslo15:06
YorikSardhellmann: Huh... It seems that not only tmpfs played its role :)15:07
YorikSardhellmann: I've tried to use --index-filter instead of --tree-filter.15:08
dhellmannYorikSar: ah, ok15:08
dhellmannYorikSar: I have an unaltered version of the script here and it's still running15:08
YorikSardhellmann: I thought it made no difference time-wise.15:08
dhellmannI'm interested in that -d option if it really does make this faster, but I wanted to try it without any change15:08
YorikSardhellmann: Yes, I've reverted index-filter change, only -d left. But I think the first time I ran it as is and had the same issue.15:09
dhellmannI'm not an expert, but I think the tree-filter option needs to be used in order to actually change the contents of the commits in the way we want.15:09
dhellmannok, I'll let this copy finish running and let you know if I get an error15:09
YorikSardhellmann: index-filter does the same but without checking out anything. So you can use update-index to remove whatever you like.15:10
* YorikSar is a secret fan of Git plumbing commands15:10
dhellmannI wonder if that is faster, too? of course, if it doesn't work... :-)15:10
dhellmannYorikSar: if you get a combination of options that works, please submit a patch to the incubator repo :-)15:11
YorikSardhellmann: That's my intention :)15:11
dhellmann+115:11
YorikSardhellmann: I don't think we can provide a way to automatically create tmpfs dir, but... We can add an option, I guess.15:11
dhellmannYorikSar: would creating a directory with mktemp do it?15:12
YorikSardhellmann: Only if your /tmp is tmpfs15:12
dhellmannYorikSar: well, yes, true15:12
YorikSardhellmann: But if your /tmp is tmpfs (not like on my system) and you follow instructions on wiki thoroughly (not like me, I didn't cd to /tmp), you'll get that speedup anyway15:13
*** tongli has joined #openstack-oslo15:14
dhellmannYorikSar: I see a merge conflict as well, now15:14
YorikSardhellmann: Yay, index-filter approach works then :)15:14
YorikSardhellmann: I don't see anything different about that commit...15:17
YorikSardhellmann: Hm... Doesn't that rebase create a straight commit history without merges? If so it might've applied commits in wrong order or smth.15:18
dhellmannYorikSar: I was able to fix up that commit by hand and let the rebase continue, but then I hit another in the same function15:20
dhellmannI wonder if this is caused by the fact that we had to revert changes to that function somewhere15:21
YorikSardhellmann: It shouldn't... I'm thinking about converting all calls to filter-branch to one call so that we won't need rebase.15:22
dhellmannYorikSar: see if this repo looks right to you: https://github.com/dhellmann/oslo.concurrency15:22
dhellmannif you can improve the script, that would make me happy15:23
dhellmannI worked from some commands markmc gave me to create this version, but I confess I don't understand all of the calls15:23
dhellmannYorikSar: obviously the stuff in graduate.sh after the rebase still needs to be done15:24
YorikSardhellmann: Yes, it looks fine, but... Hm... Was it an original intention to remove all merge commits?15:24
*** arnaud has joined #openstack-oslo15:25
dhellmannYorikSar: yes, because I thought otherwise we can't really prune the history15:25
YorikSardhellmann: So you've just resolved couple of conflicts, right?15:25
dhellmannthat's right15:25
*** ihrachyshka has quit IRC15:27
YorikSardhellmann: Ok...15:27
dhellmannthe result looks right compared to the current state of master, but I don't know if the history is accurate any more15:28
*** ihrachyshka has joined #openstack-oslo15:28
YorikSardhellmann: I'll verify that. I'm still waiting for my graduate.sh run to finish...15:31
YorikSardhellmann: Although I guess I don't need to.15:32
*** arnaud__ has joined #openstack-oslo15:32
dhellmannyeah, feel free to clone that repo and keep working on it from there. I guess you'll have to run the remaining commands by hand. :-/15:33
*** erecio has joined #openstack-oslo15:34
YorikSardhellmann: I guess I'm too eager to improve graduate.sh, so I'll have your repo as a golden version to compare to :)15:35
dhellmannYorikSar: ok, that sounds good15:36
*** ihrachyshka has quit IRC15:36
*** ihrachyshka has joined #openstack-oslo15:37
*** jogo is now known as flashgordon15:38
YorikSardhellmann: Well, that speedup was definitelly from index-filter. I've killed original version running (with tmpfs) on 28th minute. And index-filter version already failed with conflict after 2:44 :)15:38
*** erecio has quit IRC15:38
dhellmannYorikSar: I'll be interested to see if your results are the same :-)15:39
*** mriedem has quit IRC15:40
*** mriedem has joined #openstack-oslo15:42
YorikSardhellmann: So... I've copied your resolituons of those conflicts and 'git diff dhellman/master' doesn't show anything :)15:43
dhellmannYorikSar: using index-filter?15:44
YorikSardhellmann: yes15:44
dhellmannYorikSar: how about the log messages and other metadata?15:44
dhellmanncommit ids would change, probably15:44
*** jaypipes has joined #openstack-oslo15:44
YorikSardhellmann: I'mlooking into removing commit ids from git log output... And then I'll tell :)15:45
*** jaypipes is now known as leakypipes15:45
YorikSardhellmann: % diff -s <(git log | grep -v '^commit') <(git log dhellman/master | grep -v '^commit')15:47
YorikSardhellmann: │Files /proc/self/fd/11 and /proc/self/fd/12 are identical15:47
YorikSardhellmann: Removing it with git log args seemed to be too hard15:47
openstackgerritDoug Hellmann proposed a change to openstack/cliff: Clean up default tox environment list  https://review.openstack.org/10958215:49
openstackgerritDoug Hellmann proposed a change to openstack/cliff: Do not allow wheels for stable tests  https://review.openstack.org/10963915:49
YorikSardhellmann: I gotta go now, but I'll push a change request soon :)15:49
dhellmannYorikSar: ok, sounds good, thanks for working on that!15:49
dhellmannteam meeting in ~10 minutes15:50
*** dims has quit IRC15:56
openstackgerritA change was merged to openstack/oslo.messaging: Add release notes for stable/icehouse 1.3.1 release  https://review.openstack.org/10791516:04
*** dims has joined #openstack-oslo16:07
openstackgerritA change was merged to openstack/oslo.messaging: Add release notes for 1.4.0.0a4  https://review.openstack.org/10959916:10
*** ihrachyshka has quit IRC16:11
*** noelbk has quit IRC16:31
openstackgerritMatthew Booth proposed a change to openstack/oslo.db: Handle constraint not found on postgresql  https://review.openstack.org/10964916:44
openstackgerritA change was merged to openstack/oslo.i18n: Imported Translations from Transifex  https://review.openstack.org/10693816:47
*** lbragstad has quit IRC16:51
*** noelbk has joined #openstack-oslo16:52
*** Alexei_9871 has left #openstack-oslo17:00
*** viktors is now known as viktors|afk17:02
*** i159 has quit IRC17:02
*** praneshp has joined #openstack-oslo17:03
YorikSarNow that the meeting's over... About oslo.local and others.17:03
YorikSarI've seen oslo.local usage in oslo.log. It can be made options really easy.17:04
YorikSarLike try: form oslo.concurrency import local except ImportError: etc17:04
YorikSarI wonder if we should create a separate library just for that 10 lines of code.17:05
YorikSarOr is it used in some services that wouldn't want to drag all oslo.concurrency in?17:08
dhellmannYorikSar: we might not. See https://wiki.openstack.org/wiki/Oslo/Dependencies though17:08
YorikSardhellmann: I might be missing some problem in this graph...17:10
dhellmannYorikSar: where were you suggesting putting local? concurrency?17:10
YorikSardhellmann: Yes17:10
dhellmannthat would introduce a cycle between oslo.log and oslo.concurrency right now17:11
YorikSardhellmann: It'll be broken by just oneline commit.17:11
*** noelbk has quit IRC17:12
dhellmannare there any projects that would use oslo.log but not the dependencies of oslo.concurrency?17:12
*** noelbk has joined #openstack-oslo17:12
YorikSardhellmann: https://review.openstack.org/109561 - as I understand it needs to land in incubator as per https://wiki.openstack.org/wiki/Oslo/CreatingANewLibrary#Updating_the_Incubator17:12
dhellmannYorikSar: ok, I'm in another meeting, so I'll have to look at this more closely in a little while17:13
dhellmannyou might be right17:13
YorikSardhellmann: I don't actually know... I'll look into it later.17:13
YorikSardhellmann: Ok, I have to walk my dog anyway. :)17:13
*** harlowja_away is now known as harlowja17:17
amrithdhellmann, I've marked the patch as WIP but it may be worthwhile to get reviews going so that at the time when it can get into o.concurrency, it can drop right in.17:19
*** mkoderer_cloud has quit IRC17:22
*** lbragstad has joined #openstack-oslo17:28
*** yamahata has quit IRC17:30
openstackgerritMichael Bayer proposed a change to openstack/oslo.db: Implement a dialect-level function dispatch system  https://review.openstack.org/10943617:34
Alexei_987harlowja: Hi are you available?17:49
Alexei_987dhellmann: Hi is there any chance that you know why we send 2 reply messages for each rpc call? https://github.com/openstack/oslo.messaging/blob/master/oslo/messaging/_drivers/amqpdriver.py#L6917:50
Alexei_987dhellmann: IMHO 2nd one could be removed if driver would be updated accordinly17:50
openstackgerritJoshua Harlow proposed a change to openstack/taskflow: Use checked commit when committing kazoo transactions  https://review.openstack.org/10825618:01
YorikSardhellmann: Ok, in openstack/* I see only horizon, os-collect-config and oslo.vmware having oslo.local but not having either lockutils or processutils18:02
YorikSardhellmann: And I think that's because of oslo.log18:02
harlowjaAlexei_987 i don't know :-/18:04
harlowjaseems odd to send a ending message18:04
Alexei_987harlowja: from the logic it seems useless.. most likely some kind of legacy stuff related to multicall18:04
harlowjaya, i wonder why just 1 ending message, why not 2 or 3 or 418:05
harlowjalol18:05
*** bknudson has quit IRC18:05
Alexei_987harlowja: oslo.messaging is one big mistery..18:05
YorikSardhellmann: Yep, that's true.18:05
harlowjai think u should send 100 ending messages; just incase the first 99 don't make it :-P18:05
*** markmcclain has joined #openstack-oslo18:06
harlowjaAlexei_987 i always thought the usage of 'rpc_amqp._MsgIdCache()' was odd also18:07
harlowjabut thats a different thing18:07
Alexei_987harlowja: yeah thats another strange stuff since it definetely doesn't work in ReplyWaiter18:08
Alexei_987harlowja: we never register anything there18:08
harlowjaits also only 16 items long18:08
harlowjamagic 1618:08
*** markmcclain1 has joined #openstack-oslo18:09
harlowjaso u only get 16 known dupes, more than that and u can have dupes18:09
Alexei_987harlowja: I hope to discuss major refactoring of all this stuff at the summit18:09
Alexei_987harlowja: and meanwhile try to work on some kind of functional tests18:09
harlowjaAlexei_987 what are your thoughts around just using more of kombu to do all the work?18:09
harlowjawhen https://github.com/celery/kombu/pull/335 goes in, qpid will work in kombu18:09
Alexei_987harlowja: my thoughts are that we should throw away all the stuff that we don't need18:10
harlowjahow much is then needed?18:10
*** markmcclain has quit IRC18:10
Alexei_987harlowja: IMHO we should target to implement our basic api classes18:10
Alexei_987harlowja: we have 2 pairs of classes - RPCClient + RPCServer18:10
Alexei_987+ same for notify18:10
harlowjaso just a couple tiny things that plug-in to kombu to do the rest18:11
harlowja?18:11
Alexei_987if we could make it work with minimum code that would be great18:11
Alexei_987yeah18:11
Alexei_987harlowja: I'm working on zmq driver when I have some free time https://github.com/Alexei-Kornienko/oslo.messaging/blob/zeromq/oslo/messaging/_drivers/impl_zmq.py18:12
Alexei_987and try to keep it small and simple18:12
harlowjaAlexei_987 kombu has a zeromq one? not good enough?18:12
harlowjahttps://github.com/celery/kombu/issues/85 ?18:12
* harlowja not sure how good/bad the kombu one is18:13
harlowja* https://github.com/celery/kombu/blob/master/kombu/transport/zmq.py18:13
Alexei_987harlowja: will take a look on that. I didn't know it's there18:13
YorikSardhellmann: In stackforge/* there are ec2-api using local from outside oslo and magentodb that uses pastedeploy that uses local, others either have processutils or lockutils or have just log or legacy rpc.18:15
harlowjacool, kombu seems to get more activity than oslo.messaging; so it'd be nice to keep oslo.messaging as a set of things ontop of kombu that are more openstack specific (if we can do this, which it seems like with that qpid+kombu addition we could)18:15
harlowjaAlexei_987 thats just my thoughts; others may believe different18:15
Alexei_987harlowja: from a quick look it doesn't seem as a good option to zmq since it requires M*M connections18:15
harlowjaAlexei_987 kombu accepts patches though ;)18:16
Alexei_987harlowja: and it won't work with dynamic discovery + HA18:16
Alexei_987we'll see about that. Right now I have to fix impl_rabbit somehow18:16
Alexei_987since it doesn't work as we want it to work18:16
harlowjaAlexei_987 understood, thats my concern with alot of oslo honestly; that we are avoiding contributing back to dependent projects (kombu for example)18:17
harlowja*if its a real concern or a josh-created one is another question entirely :-P18:19
openstackgerritJoshua Harlow proposed a change to openstack/taskflow: Revamp the symbol lookup mechanism  https://review.openstack.org/10967218:26
*** ihrachyshka has joined #openstack-oslo18:28
*** ihrachyshka has quit IRC18:36
*** tongli has quit IRC18:36
openstackgerritJoshua Harlow proposed a change to openstack/taskflow: Relax the linear flow symbol constraints  https://review.openstack.org/10789718:36
zzzeekdhellmann rpodolyaka viktors|afk : https://etherpad.openstack.org/p/sqla_exceptions_caught18:38
*** pblaho has quit IRC18:39
dhellmannamrith: yes, WIP with continuing your work was the idea18:39
openstackgerritJoshua Harlow proposed a change to openstack/taskflow: Relax the unordered flow symbol constraints  https://review.openstack.org/10816118:40
dhellmannYorikSar: I think the dependency work I did predates the idea that oslo.log would be a library for apps to configure logging, so it's possible we can include local in the concurrency library, too. Why don't you update the graduation spec with that (submit a change against the existing spec) and we'll use that as a place to record the conversation and decision.18:42
dhellmannAlexei_987: I don't know about why we have 2 responses. Maybe it has something to do with the way the rpc sender is expecting a response?18:42
YorikSardhellmann: I'm going to try to research if we can include threadgroup here as well...18:43
YorikSardhellmann: I think it'd be good to see all races happen in one library :)18:44
dhellmannAlexei_987: keep in mind, oslo.messaging grew out of the rpc implementation actually used in nova, so it may have some legacy constructs18:44
Alexei_987dhellmann: Ok.. just plan to post a patch that makes reply waiter lot simpler18:44
dhellmannYorikSar: I *think* the only things that use threadgroup are the other modules in the oslo.server list, so if we put it there then it will just be an implementation detail of that library18:45
dhellmannAlexei_987: ok18:45
openstackgerritJoshua Harlow proposed a change to openstack/taskflow: Relax the graph flow symbol constraints  https://review.openstack.org/10817518:45
zzzeekdhellmann rpodolyaka viktors|afk : im going to get a coffee.    there isn’t much to look at but this is based on my assumptions being sound.   back in a bit18:45
YorikSardhellmann: Ok, I'll verify that.18:46
dhellmannzzzeek: I'm just catching up on scrollback, but I'll take a look at what you've put together in that etherpad18:47
zzzeekdhellmann: no hurry18:47
*** morganfainberg is now known as morganfainberg_Z18:53
zzzeekok caught a glitch and fixed it, now im really going for coffee18:57
*** bknudson has joined #openstack-oslo19:02
*** ihrachyshka has joined #openstack-oslo19:02
openstackgerritYuriy Taraday proposed a change to openstack/oslo-incubator: Use index-filter instead of tree-filter in graduate.sh  https://review.openstack.org/10968519:02
YorikSardhellmann: Almost forgot ^19:02
*** SridharG has quit IRC19:03
*** bknudson has quit IRC19:06
*** Ish__ has joined #openstack-oslo19:12
openstackgerritA change was merged to openstack/oslo.utils: Make the i18n integration module private  https://review.openstack.org/10909419:18
openstackgerritA change was merged to openstack/oslo.utils: Add API docs and clean up other docs  https://review.openstack.org/10910119:20
*** bknudson has joined #openstack-oslo19:20
dhellmannYorikSar: added to my review list19:23
*** Ish__ has quit IRC19:27
*** ihrachyshka has quit IRC19:29
openstackgerritlifeless proposed a change to openstack-dev/pbr: Teach pbr about post versioned dev versions.  https://review.openstack.org/8044919:30
openstackgerritlifeless proposed a change to openstack-dev/pbr: Raise an error if preversion versions are too low  https://review.openstack.org/10826919:30
*** pblaho has joined #openstack-oslo19:30
openstackgerritlifeless proposed a change to openstack-dev/pbr: Look for and process sem-ver pseudo headers in git  https://review.openstack.org/10827019:30
openstackgerritlifeless proposed a change to openstack-dev/pbr: Refactor oneline changelog walking.  https://review.openstack.org/10827119:30
openstackgerritlifeless proposed a change to openstack-dev/pbr: Introduce a SemanticVersion object  https://review.openstack.org/9410819:30
*** pblaho has quit IRC19:35
*** Ish__ has joined #openstack-oslo19:39
*** dims has quit IRC20:20
*** dims has joined #openstack-oslo20:21
*** Ish__ has quit IRC20:27
*** Ish__ has joined #openstack-oslo20:29
*** beekneemech has quit IRC20:50
*** dims has quit IRC21:03
*** celttechie has quit IRC21:18
*** celttechie has joined #openstack-oslo21:18
*** celttechie is now known as celttechie|afk21:18
openstackgerritJoshua Harlow proposed a change to openstack/taskflow: Use a common message dispatcher  https://review.openstack.org/10109421:23
openstackgerritJoshua Harlow proposed a change to openstack/taskflow: Use a common message dispatcher  https://review.openstack.org/10109421:28
openstackgerritJoshua Harlow proposed a change to openstack/taskflow: Allow handlers to provide validation callables  https://review.openstack.org/10167921:33
openstackgerritJoshua Harlow proposed a change to openstack/taskflow: WBE notification message validation  https://review.openstack.org/10365721:41
openstackgerritJoshua Harlow proposed a change to openstack/taskflow: Use a common message dispatcher  https://review.openstack.org/10109421:43
openstackgerritJoshua Harlow proposed a change to openstack/taskflow: Allow handlers to provide validation callables  https://review.openstack.org/10167921:43
*** jecarey has quit IRC21:47
openstackgerritJoshua Harlow proposed a change to openstack/taskflow: WBE notification message validation  https://review.openstack.org/10365721:48
openstackgerritJoshua Harlow proposed a change to openstack/taskflow: WBE response message validation  https://review.openstack.org/10369021:48
*** mriedem has quit IRC21:48
openstackgerritJoshua Harlow proposed a change to openstack/taskflow: WBE request message validation  https://review.openstack.org/10369521:48
openstackgerritJoshua Harlow proposed a change to openstack/taskflow: Add basic WBE validation sanity tests  https://review.openstack.org/10401621:49
openstackgerritJoshua Harlow proposed a change to openstack/taskflow: Improve WBE testing coverage  https://review.openstack.org/10171721:49
openstackgerritJoshua Harlow proposed a change to openstack/taskflow: Add proxy heartbeat support  https://review.openstack.org/10439721:52
*** morganfainberg_Z is now known as morganfainberg21:55
openstackgerritJoshua Harlow proposed a change to openstack/taskflow: Add proxy heartbeat support  https://review.openstack.org/10439721:56
*** gordc has quit IRC22:14
*** lbragsta_ has joined #openstack-oslo22:17
*** lbragstad has quit IRC22:20
*** lbragsta_ has quit IRC22:21
*** ildikov has quit IRC22:31
*** yamahata has joined #openstack-oslo22:45
*** Ish__ has quit IRC22:52
openstackgerritA change was merged to openstack/cliff: Do not allow wheels for stable tests  https://review.openstack.org/10963922:54
*** Ish__ has joined #openstack-oslo22:54
*** morganfainberg is now known as morganfainberg_Z22:55
openstackgerritA change was merged to openstack/oslo-incubator: Remove oslo.log from lockutils  https://review.openstack.org/10956122:57
*** harlowja is now known as harlowja_away22:58
YorikSardhellmann: Around?23:02
dhellmannYorikSar: for just a few more minutes, yes23:03
openstackgerritA change was merged to openstack/oslo-specs: Support policy configuration directories  https://review.openstack.org/10415723:03
YorikSardhellmann: I finally got my dream history with all merge commits. But I'm running into an error with cookiecutter...23:04
YorikSarTypeError: unsupported operand type(s) for -: 'Undefined' and 'Undefined'23:04
dhellmannhrm23:04
dhellmannYorikSar: try installing a slightly older version of the cookiecutter for now23:04
YorikSardhellmann: Did you encounter such error? It seems it doesn't get some template argument it needs.23:05
dhellmannI know they have been doing some work on it23:05
YorikSardhellmann: Ok, will try...23:05
dhellmannlet me see which version I'm using23:05
dhellmannYorikSar: cookiecutter==0.7.023:05
dhellmannYorikSar: if the older version works, file a bug with the traceback you're seeing against oslo and we can look at our templates23:06
*** harlowja_away is now known as harlowja23:06
YorikSardhellmann: Bug to oslo or to cookiecutter?23:06
dhellmannoslo23:06
YorikSardhellmann: Ok23:06
YorikSardhellmann: And just to brag a bit: https://github.com/YorikSar/oslo.concurrency/commits/master23:08
YorikSardhellmann: All commits saved their Author, Comitter and dates :)23:08
*** morganfainberg_Z is now known as morganfainberg23:08
openstackgerritA change was merged to openstack/oslo-incubator: lockutils: split tests and run in Python 3  https://review.openstack.org/10769823:09
dhellmannYorikSar: nice!23:10
YorikSardhellmann: I'll prepare and post another CR for graduate.sh now23:10
YorikSardhellmann: I hope it's not too hackish23:11
dhellmannYorikSar: ok, sounds good23:11
dhellmannYorikSar: it's past time for my weekend to start; I'll look at your changes early next week. Have a good weekend!23:12
YorikSardhellmann: You too :)23:12
openstackgerritJoshua Harlow proposed a change to openstack/taskflow: Add proxy heartbeat support  https://review.openstack.org/10439723:13
*** flaper87l has joined #openstack-oslo23:20
*** flaper87l is now known as flaper8723:20
*** tcammann has joined #openstack-oslo23:22
*** rpodolyaka1 has joined #openstack-oslo23:23
*** gpocente1 has joined #openstack-oslo23:24
*** jokke__ has joined #openstack-oslo23:24
*** GheRiver1 has joined #openstack-oslo23:24
*** flaper87|afk has quit IRC23:29
*** rpodolyaka has quit IRC23:29
*** gpocentek has quit IRC23:29
*** ekarlso has quit IRC23:29
*** tcammann_ has quit IRC23:29
*** jokke_ has quit IRC23:29
*** GheRivero has quit IRC23:29
*** boris-42 has quit IRC23:29
*** Ish__ has quit IRC23:29
*** boris-42 has joined #openstack-oslo23:31
*** Ish__ has joined #openstack-oslo23:31
*** ekarlso has joined #openstack-oslo23:32
*** Ish__ has quit IRC23:32
*** mtreinish has quit IRC23:33
*** mtreinish has joined #openstack-oslo23:46
*** morganfainberg is now known as morganfainberg_Z23:51

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!