| *** arnaud has joined #openstack-oslo | 00:00 | |
| *** arnaud__ has joined #openstack-oslo | 00:01 | |
| *** tsekiyama has quit IRC | 00:15 | |
| gus | dhellmann: re your mysqlconnector license question: afaict mysqlconnector is gpl2. | 00:21 |
|---|---|---|
| gus | You mentioned "exceptions". Is there something more I'm missing to their license? | 00:22 |
| gus | Oh right. Confusing. | 00:26 |
| gus | The download page says unconditionally that it is available under gpl2. | 00:26 |
| gus | The COPYING file says "there are special exceptions to GPL ... in file EXCEPTIONS-CLIENT" .. and there's no EXCEPTIONS-CLIENT file. | 00:27 |
| *** tsekiyama has joined #openstack-oslo | 00:41 | |
| *** SridharG has joined #openstack-oslo | 00:41 | |
| *** dims_ has quit IRC | 00:44 | |
| *** jaypipes has quit IRC | 00:50 | |
| *** tsekiyama has quit IRC | 00:51 | |
| *** tsekiyama has joined #openstack-oslo | 00:52 | |
| *** tsekiyama has quit IRC | 00:56 | |
| *** tsekiyama has joined #openstack-oslo | 00:57 | |
| *** bknudson has joined #openstack-oslo | 01:01 | |
| *** mriedem has joined #openstack-oslo | 01:02 | |
| *** dims_ has joined #openstack-oslo | 01:09 | |
| *** tsekiyama has quit IRC | 01:10 | |
| *** oomichi has quit IRC | 01:20 | |
| *** mriedem has quit IRC | 01:23 | |
| *** mriedem has joined #openstack-oslo | 01:24 | |
| *** yamahata has joined #openstack-oslo | 01:43 | |
| *** morganfainberg has quit IRC | 01:47 | |
| *** morganfainberg has joined #openstack-oslo | 01:47 | |
| *** morganfainberg is now known as captainmorgan | 01:49 | |
| *** morganfainberg_Z has joined #openstack-oslo | 01:49 | |
| *** morganfainberg_Z is now known as morganfainberg | 01:50 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Revamp the symbol lookup mechanism https://review.openstack.org/108572 | 01:50 |
| *** morganfainberg is now known as captainmorgan | 01:50 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Revamp the symbol lookup mechanism https://review.openstack.org/108572 | 01:53 |
| *** tsekiyama has joined #openstack-oslo | 01:55 | |
| *** captainmorgan is now known as morganfainberg | 01:58 | |
| *** tsekiyama has quit IRC | 02:04 | |
| *** Ish__ has quit IRC | 02:09 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Revamp the symbol lookup mechanism https://review.openstack.org/108572 | 02:10 |
| *** tsekiyama has joined #openstack-oslo | 02:19 | |
| *** tsekiyama has quit IRC | 02:29 | |
| *** celttechie has quit IRC | 02:34 | |
| *** amotoki has joined #openstack-oslo | 02:38 | |
| *** mriedem has left #openstack-oslo | 02:39 | |
| *** liusheng has joined #openstack-oslo | 02:55 | |
| openstackgerrit | Arnaud Legendre proposed a change to openstack/oslo.vmware: Port the Datastore object and a few ds utilities https://review.openstack.org/105274 | 02:57 |
| openstackgerrit | Arnaud Legendre proposed a change to openstack/oslo.vmware: Port the Datastore object and a few ds utilities https://review.openstack.org/105274 | 03:01 |
| openstackgerrit | liusheng proposed a change to openstack/oslo.config: Fix the return of ConfigOpts's __call__ method https://review.openstack.org/103506 | 03:05 |
| *** arnaud__ has quit IRC | 03:13 | |
| *** arnaud has quit IRC | 03:13 | |
| *** zzzeek has joined #openstack-oslo | 03:14 | |
| *** arnaud has joined #openstack-oslo | 03:14 | |
| *** arnaud__ has joined #openstack-oslo | 03:14 | |
| *** arnaud has quit IRC | 03:14 | |
| *** mriedem has joined #openstack-oslo | 03:15 | |
| *** harlowja is now known as harlowja_away | 03:15 | |
| openstackgerrit | YAMAMOTO Takashi proposed a change to openstack/taskflow: README.rst: Avoid using non-ascii character https://review.openstack.org/108881 | 03:16 |
| *** arnaud__ has quit IRC | 03:18 | |
| *** dims_ has quit IRC | 03:19 | |
| *** Ish__ has joined #openstack-oslo | 03:23 | |
| *** celttechie has joined #openstack-oslo | 03:25 | |
| *** mriedem has left #openstack-oslo | 03:25 | |
| *** mriedem has quit IRC | 03:25 | |
| *** dims_ has joined #openstack-oslo | 03:46 | |
| *** praneshp has quit IRC | 03:47 | |
| *** zzzeek has quit IRC | 03:49 | |
| *** dims_ has quit IRC | 03:51 | |
| *** arnaud has joined #openstack-oslo | 04:07 | |
| *** praneshp has joined #openstack-oslo | 04:17 | |
| *** HenryG is now known as HenryG_afk | 04:19 | |
| *** oomichi has joined #openstack-oslo | 04:19 | |
| *** praneshp_ has joined #openstack-oslo | 04:34 | |
| *** praneshp has quit IRC | 04:37 | |
| *** praneshp_ is now known as praneshp | 04:37 | |
| *** celttechie has quit IRC | 04:40 | |
| *** ildikov has quit IRC | 04:59 | |
| openstackgerrit | Brad Topol proposed a change to openstack/pycadf: Fix typo comments is pycadf https://review.openstack.org/108889 | 05:02 |
| openstackgerrit | Brad Topol proposed a change to openstack/pycadf: Fix typo comments https://review.openstack.org/108889 | 05:04 |
| *** harlowja_at_home has joined #openstack-oslo | 05:30 | |
| *** k4n0 has joined #openstack-oslo | 05:33 | |
| *** harlowja_still_a has joined #openstack-oslo | 05:33 | |
| *** harlowja_at_home has quit IRC | 05:36 | |
| *** arnaud has quit IRC | 05:46 | |
| *** dims has joined #openstack-oslo | 05:50 | |
| *** SridharG has quit IRC | 05:53 | |
| *** dims has quit IRC | 05:55 | |
| *** harlowja_still_a has quit IRC | 05:57 | |
| *** harlowja_at_home has joined #openstack-oslo | 05:57 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.i18n: Imported Translations from Transifex https://review.openstack.org/106938 | 06:05 |
| *** harlowja_at_home has quit IRC | 06:12 | |
| *** Ish__ has left #openstack-oslo | 06:13 | |
| *** ildikov has joined #openstack-oslo | 06:15 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Revamp the symbol lookup mechanism https://review.openstack.org/108572 | 06:46 |
| *** viktors|afk is now known as viktors | 06:54 | |
| *** SridharG has joined #openstack-oslo | 06:55 | |
| *** dims has joined #openstack-oslo | 07:53 | |
| *** dims has quit IRC | 07:58 | |
| *** i159 has joined #openstack-oslo | 07:59 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Translate the engine runner into a well defined state-machine https://review.openstack.org/106535 | 08:03 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add existing types to generated documentation https://review.openstack.org/106930 | 08:05 |
| *** nacim has joined #openstack-oslo | 08:05 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Ensure state machine can be frozen https://review.openstack.org/107479 | 08:09 |
| *** mrda is now known as mrda-away | 08:14 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Start shift to symbol nomenclature https://review.openstack.org/103296 | 08:15 |
| *** ihrachyshka has joined #openstack-oslo | 08:26 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Better handle the tree freeze method https://review.openstack.org/107481 | 08:26 |
| *** ihrachyshka has quit IRC | 08:30 | |
| *** ihrachyshka has joined #openstack-oslo | 08:31 | |
| *** praneshp has quit IRC | 08:41 | |
| *** alexpilotti_ has joined #openstack-oslo | 08:48 | |
| *** alexpilotti has quit IRC | 08:48 | |
| *** alexpilotti_ is now known as alexpilotti | 08:48 | |
| *** dims has joined #openstack-oslo | 08:53 | |
| *** dims has quit IRC | 08:58 | |
| *** jecarey has quit IRC | 09:04 | |
| *** jecarey_ has joined #openstack-oslo | 09:05 | |
| *** pblaho has joined #openstack-oslo | 09:15 | |
| *** oomichi has quit IRC | 09:29 | |
| *** cdent has joined #openstack-oslo | 09:33 | |
| Alexei_987 | how can one submit a bug in API description docs? | 09:36 |
| sileht | Alexei_987, do you means api.openstack.org ? | 09:41 |
| Alexei_987 | https://wiki.openstack.org/wiki/Oslo/Messaging#Transport_Driver_API | 09:41 |
| Alexei_987 | sileht: Hi | 09:41 |
| Alexei_987 | sileht: problem I see is that it's not specified explicitly when actuall connection is opened | 09:41 |
| Alexei_987 | sileht: I've made a change in rabbit driver to provide heartbeat support and it breaks cinder | 09:42 |
| Alexei_987 | sileht: cause when cinder it trying to do db_sync it creates Transport instance and driver instance | 09:42 |
| Alexei_987 | for rpc | 09:43 |
| Alexei_987 | and it fails cause rabbit is not available | 09:43 |
| Alexei_987 | sileht: so I wonder what should be fixed cinder or oslo.messaging | 09:43 |
| Alexei_987 | sileht: cause it's not clear when it's safe to assume that you can open a connection to rabbit | 09:44 |
| Alexei_987 | sileht: what do you think? ^ | 09:44 |
| sileht | Alexei_987, I guess once you create a transport you may have a connection establish (may, because can depends of the driver impl), so for me If cinder create a transport do a db_sync, this is a cinder issue | 09:45 |
| Alexei_987 | sileht: cool thanks :) I'm afraid that it can be not only in cinder so have to double check all services | 09:45 |
| sileht | Alexei_987, I guess cinder.rpc.init shouldn't be called when the db_sync cli command is used | 09:47 |
| Alexei_987 | sileht: it's called cause all commands are loaded and not only db_sync | 09:47 |
| *** cdent_ has joined #openstack-oslo | 09:47 | |
| Alexei_987 | sileht: https://github.com/openstack/cinder/blob/master/bin/cinder-manage#L254 | 09:47 |
| Alexei_987 | sileht: anyway thanks for your help | 09:48 |
| sileht | Alexei_987, welcome | 09:49 |
| *** amotoki has quit IRC | 09:49 | |
| *** cdent has quit IRC | 09:50 | |
| *** cdent_ is now known as cdent | 09:50 | |
| *** Alexei_987 has quit IRC | 10:12 | |
| openstackgerrit | Chris Dent proposed a change to openstack/oslo.messaging: Fix error in example of an RPC server https://review.openstack.org/108410 | 10:15 |
| *** pcm_ has joined #openstack-oslo | 10:28 | |
| *** flaper87 has quit IRC | 10:29 | |
| *** pcm_ has quit IRC | 10:29 | |
| *** pblaho has quit IRC | 10:29 | |
| *** ihrachyshka has quit IRC | 10:30 | |
| *** pcm_ has joined #openstack-oslo | 10:30 | |
| *** pblaho has joined #openstack-oslo | 10:30 | |
| *** flaper87|afk has joined #openstack-oslo | 10:37 | |
| *** flaper87|afk is now known as flaper87 | 10:37 | |
| *** ihrachyshka has joined #openstack-oslo | 10:37 | |
| *** yamahata has quit IRC | 10:39 | |
| *** ihrachyshka has quit IRC | 10:39 | |
| *** dims has joined #openstack-oslo | 10:45 | |
| openstackgerrit | Alex Frolov proposed a change to openstack/oslo-incubator: Transfer class LazyPluggable from nova to oslo-incubator https://review.openstack.org/107373 | 10:52 |
| openstackgerrit | Yuriy Taraday proposed a change to openstack/oslo-incubator: Switch to using SysV semaphores to allow safe process termination https://review.openstack.org/108954 | 10:58 |
| YorikSar | harlowja, dims: Please take a look at ^ | 10:58 |
| dstanek | i think this needs to be abandoned, but i don't have the power - https://review.openstack.org/#/c/96637/ | 11:24 |
| *** ihrachyshka has joined #openstack-oslo | 11:30 | |
| *** alexpilotti has quit IRC | 11:37 | |
| openstackgerrit | Oleksii Chuprykov proposed a change to openstack/oslo.db: Remove sqla_07 from tox.ini https://review.openstack.org/107604 | 11:47 |
| *** yamahata has joined #openstack-oslo | 11:51 | |
| dims | YorikSar, weird failures from all jobs? | 11:56 |
| YorikSar | dims: sysv_ipc is not in global-requirements... | 12:02 |
| YorikSar | dims: But otherwise this seems to work. | 12:03 |
| *** dims has quit IRC | 12:05 | |
| *** k4n0 has quit IRC | 12:05 | |
| *** viktors is now known as viktors|afk | 12:15 | |
| *** yamahata has quit IRC | 12:26 | |
| *** dims has joined #openstack-oslo | 12:27 | |
| *** yamahata has joined #openstack-oslo | 12:28 | |
| *** liusheng has quit IRC | 12:28 | |
| *** lbragstad has joined #openstack-oslo | 12:35 | |
| *** ildikov has quit IRC | 12:44 | |
| *** alexpilotti has joined #openstack-oslo | 12:49 | |
| *** bnemec has joined #openstack-oslo | 12:54 | |
| *** yamahata has quit IRC | 13:01 | |
| *** yamahata has joined #openstack-oslo | 13:01 | |
| *** dims has quit IRC | 13:07 | |
| *** jecarey_ has quit IRC | 13:11 | |
| *** Alexei_9871 has joined #openstack-oslo | 13:13 | |
| *** bknudson has quit IRC | 13:17 | |
| *** zzzeek has joined #openstack-oslo | 13:20 | |
| dhellmann | gus: someone mentioned a FOSS exception, but I don't know the terms. There are questions about whether we can/should use GPL libraries, so I want to make sure we address the issue directly in the spec. | 13:22 |
| *** HenryG_afk is now known as HenryG | 13:24 | |
| dhellmann | dstanek: would we want to backport that for projects not yet using oslo.db? | 13:24 |
| dstanek | dhellmann: ? | 13:25 |
| dhellmann | dstanek: sorry, catching up on scrollback: https://review.openstack.org/#/c/96637/ | 13:25 |
| amrith | dhellmann, any chance we could chat about https://review.openstack.org/#/c/108216/ and https://review.openstack.org/#/c/108215/ | 13:26 |
| dstanek | dhellmann: ah | 13:26 |
| dstanek | dhellmann: i would think not because nothing really runs on Python 3 yet. but even if we wanted to backport it would be another review proposed against a branch | 13:27 |
| *** jecarey has joined #openstack-oslo | 13:30 | |
| dhellmann | dstanek: the master branch of the incubator is the "stable/juno" branch for projects that haven't moved to oslo.db, so backports go oslo.db -> incubator/master -> incubator/stable/icehouse -> etc. | 13:31 |
| dstanek | dhellmann: ah, that's a good point. is it likely that a project will be supported in Python 3 before switching to oslo.db? | 13:32 |
| dhellmann | amrith: sure | 13:32 |
| dhellmann | dstanek: no, but is that change really only needed for python 3? | 13:32 |
| amrith | dhellmann, in your review on https://review.openstack.org/#/c/108216/ the rationale for the -1 (if i understand correctly) is that the exception logging information could expose sensitive stuff | 13:33 |
| amrith | I intended to fix that in https://review.openstack.org/#/c/108215 | 13:33 |
| amrith | maybe I erred in making this two patch sets | 13:34 |
| dhellmann | amrith: ok, that part is fine, but the exception should still not be logging itself | 13:34 |
| amrith | I WILL NOT submit https://review.openstack.org/#/c/108216/ without https://review.openstack.org/#/c/108215/ | 13:34 |
| amrith | so if that's a starting point, let's address the issue of whether an exception handler should be logging at all | 13:34 |
| dhellmann | it appears that exception is already being logged elsewhere | 13:34 |
| amrith | right now, it does. | 13:34 |
| amrith | you write, "it appears that exception is already being logged elsewhere". do you mean in the caller to execute() or somewhere in execute() | 13:35 |
| dstanek | dhellmann: according to the bug it's for Python3. the commit message seems to indicate maybe there is more | 13:35 |
| dstanek | dhellmann: but .message is the same as .args[0] if only one object is passed into the exception's init - which i think is the case | 13:36 |
| dhellmann | dstanek: ok, let's see if we can find the author and have them address the status before we abandon it for them (less rude that way) | 13:36 |
| dhellmann | amrith: ok, the log call I was looking at didn't include the debug info for the command, so if you move the new LOG.debug() call to around line 213 that would make me happy | 13:37 |
| dhellmann | amrith: instantiating an exception object should not have the side-effect of adding to the logs | 13:37 |
| * amrith looks | 13:37 | |
| *** dims has joined #openstack-oslo | 13:37 | |
| dstanek | dhellmann: that's fine. i only asked in there because i asked in the review over 3 weeks ago and haven't gotten a response | 13:38 |
| dstanek | s/there/here/ | 13:38 |
| dhellmann | dstanek: sure, we get drive-bys a lot, so the author may have been distracted by internal work or something | 13:38 |
| amrith | dhellmann, if you could take a look at https://review.openstack.org/#/c/108215/ I think you'll see the other part of what I'm proposing. Yes, the line at 213 is being changed. I have proposed that it log the sanitized_cmd but I am OK removing that and just saying retrying without the command itself. Would that pass muster? | 13:40 |
| *** bknudson has joined #openstack-oslo | 13:42 | |
| dhellmann | amrith: I had 2 problems. One was that the log output wasn't sanitized. You're addressing that in 108215. The other was that the exception was logging itself. That needs to be addressed in 108216, or you could go ahead and address them both together (since we don't want the logging without the sanitizing). | 13:44 |
| openstackgerrit | Vlad Okhrimenko proposed a change to openstack/oslo.db: Create class TestInnoDB https://review.openstack.org/108994 | 13:44 |
| dhellmann | amrith: but you should not log inside the constructor for the exception object | 13:44 |
| dhellmann | amrith: make sense? | 13:45 |
| dhellmann | dstanek: I sent an email to the author to see where things stand | 13:45 |
| * amrith looks | 13:45 | |
| dstanek | dhellmann: great thanks! | 13:45 |
| *** mriedem has joined #openstack-oslo | 13:46 | |
| jecarey | dhellmann: For LOG.debug("blah %s", exc) was the direction to use LOG.debug(u"blah %s", exc) or to six.text_type(exc)? | 13:48 |
| dhellmann | jecarey: u'blah: %s' if you have more of a message, six.text_type(exc) if there is no extra message wrapper | 13:50 |
| jecarey | dhellmann: I'm being dense. What do you mean by "extra message wrapper"? | 13:52 |
| amrith | dhellmann, I will make the change you propose and not log in the constructor for the exception object; instead move the logging to around where execute() creates the ProcessExecutionError object. I will also clean up the logging around 213. Thanks. | 13:54 |
| dhellmann | jecarey: actually, let me retract that anyway. if all you want to log is the exception text, pass the exception object directly as LOG.debug(exc) but if you want to say something more than what the exception is going to say (like why there is an exception being logged) you would use LOG.debug(u'blah %s', exc) | 13:56 |
| *** markmcclain has joined #openstack-oslo | 13:56 | |
| openstackgerrit | Ihar Hrachyshka proposed a change to openstack/oslo-specs: Switch from MySQLdb to MySQL Connector https://review.openstack.org/108355 | 13:56 |
| dhellmann | amrith: please also look at how the logging is already being done there -- maybe you can just add the details you want to the existing log call so we don't have retries logged on every failure | 13:56 |
| jecarey | dhellmann: so the nasty question ... should *all* LOG.debug used u'text %s' or only those that get unicode replacement text? | 13:56 |
| amrith | dhellmann, wilco | 13:57 |
| dhellmann | jecarey: you need to assume unicode everywhere, so it's better to fix them all up | 13:57 |
| jecarey | dhellmann: OK. I was hoping you wouldn't say that ... 177 files to change :( | 13:58 |
| jecarey | dhellmann: though easier than having to look at each one | 13:58 |
| openstackgerrit | Ihar Hrachyshka proposed a change to openstack/oslo-specs: Switch from MySQLdb to MySQL Connector https://review.openstack.org/108355 | 13:58 |
| dhellmann | jecarey: you *could* try to figure out for each call whether there's likely to be any unicode data, but... | 13:59 |
| jecarey | dhellmann: True ... that's also very difficult to explain to anyone updating code. | 14:01 |
| dhellmann | jecarey: right | 14:01 |
| jecarey | dhellmann: Thanks ... I'll go change them. Does this need a hacking check? | 14:01 |
| dhellmann | jecarey: it's tricky to do that, because sometimes the messages are created in variables rather than string literals, but I wouldn't be opposed to having one | 14:03 |
| jecarey | dhellmann: Good point ... let me fix them and then I'll look at doing that. | 14:04 |
| *** tsekiyama has joined #openstack-oslo | 14:04 | |
| *** tsekiyam_ has joined #openstack-oslo | 14:05 | |
| *** ildikov has joined #openstack-oslo | 14:05 | |
| jecarey | dhellmann: thanks for the help | 14:05 |
| *** zzzeek has quit IRC | 14:07 | |
| *** zzzeek has joined #openstack-oslo | 14:08 | |
| *** tsekiyama has quit IRC | 14:09 | |
| dhellmann | jecarey: any time! | 14:15 |
| openstackgerrit | Brad Topol proposed a change to openstack/pycadf: Fixed a grammatical error in contributing doc https://review.openstack.org/109001 | 14:15 |
| openstackgerrit | Brad Topol proposed a change to openstack/pycadf: Fix a grammatical error in contributing doc https://review.openstack.org/109001 | 14:16 |
| *** tsekiyam_ has quit IRC | 14:17 | |
| dims | Hi jogo, will you have cycles to help with oslo.vmware+nova integration? (there are 2 reviews up) | 14:17 |
| dims | dhellmann, oslo.serialization infra review is up - https://review.openstack.org/#/c/108861/ | 14:19 |
| *** tsekiyama has joined #openstack-oslo | 14:19 | |
| *** cdent_ has joined #openstack-oslo | 14:41 | |
| *** cdent has quit IRC | 14:42 | |
| *** cdent_ is now known as cdent | 14:42 | |
| *** viktors has joined #openstack-oslo | 14:44 | |
| viktors | dhellmann: hi | 14:47 |
| *** lbragstad has quit IRC | 14:49 | |
| *** lbragstad has joined #openstack-oslo | 14:50 | |
| *** SridharG has quit IRC | 14:51 | |
| *** krotscheck has quit IRC | 14:52 | |
| *** krotscheck has joined #openstack-oslo | 14:55 | |
| *** lbragstad has quit IRC | 14:55 | |
| *** lbragstad has joined #openstack-oslo | 14:57 | |
| *** jaypipes has joined #openstack-oslo | 14:59 | |
| *** erecio has joined #openstack-oslo | 15:00 | |
| dhellmann | dims: ack | 15:01 |
| dhellmann | viktors: hi | 15:01 |
| viktors | dhellmann: today we with rpodolyaka found, that devstack tempest jobs use oslo.* libraries from github master, not from pypi | 15:02 |
| viktors | dhellmann: but unittests on gates uses pypi versions | 15:03 |
| viktors | dhellmann: is it correct? | 15:03 |
| *** nacim has quit IRC | 15:05 | |
| openstackgerrit | A change was merged to openstack/oslo.db: Make MySQL regexes generic across MySQL drivers https://review.openstack.org/106928 | 15:06 |
| openstackgerrit | A change was merged to openstack/oslo.db: Add host argument to get_connect_string() https://review.openstack.org/106721 | 15:06 |
| *** lbragstad has quit IRC | 15:11 | |
| *** erecio has quit IRC | 15:14 | |
| *** ihrachyshka has quit IRC | 15:15 | |
| dhellmann | viktors: devstack should be pulling from git.openstack.org | 15:18 |
| viktors | dhellmann: maybe from git.openstack.org, but from master | 15:21 |
| *** lbragstad has joined #openstack-oslo | 15:21 | |
| viktors | dhellmann: I'm a bit confused, because we run uniitest and gates with the different versions of oslo.* libraries | 15:22 |
| dhellmann | viktors: I'm not sure which of those things you think is wrong? the integration tests use master, but the unit tests use packages, and that's correct. I have a review up to add unit test jobs that work with master https://review.openstack.org/85487 as part of the bp https://blueprints.launchpad.net/oslo/+spec/enhance-cross-test-gate-job | 15:22 |
| viktors | dhellmann: ok, got it | 15:24 |
| viktors | dhellmann: one more question | 15:26 |
| viktors | dhellmann: recently we closed the bug https://bugs.launchpad.net/oslo/+bug/1214341 | 15:26 |
| dhellmann | viktors: ok | 15:26 |
| viktors | dhellmann: so now all sqla.session methods are wrapped | 15:26 |
| viktors | dhellmann: but we found, that some projects waiting for un-wrapped sqla exception | 15:27 |
| dhellmann | viktors: these are the sorts of issues that we need to look for before we make API changes like that | 15:28 |
| viktors | dhellmann: so should we fix these projects, before we cut a new release | 15:28 |
| viktors | & | 15:28 |
| viktors | ? | 15:28 |
| dhellmann | viktors: yes | 15:28 |
| *** pcm__ has joined #openstack-oslo | 15:29 | |
| dhellmann | viktors: you should probably update the other projects to accept either type of exception, so it doesn't matter which version of oslo.db someone might have | 15:29 |
| viktors | dhellmann: something like this - https://review.openstack.org/#/c/108943/ ? | 15:30 |
| *** pcm___ has joined #openstack-oslo | 15:30 | |
| viktors | dhellmann: we were pretty sure, that this change will not affect oslo.db API :( | 15:31 |
| *** pcm_ has quit IRC | 15:31 | |
| *** pcm__ has quit IRC | 15:34 | |
| dhellmann | viktors: well, it changed the types of exception the library raised, right? | 15:36 |
| dhellmann | viktors: yes, that change looks good | 15:36 |
| viktors | dhellmann: yes, it wraps sqla exceptions and re-raise (wraps) them as oslo.db exceptions. We supposed, that there is no usage of the raw sqla exceptions in projects | 15:38 |
| *** lbragstad has quit IRC | 15:38 | |
| viktors | dhellmann: this affects ironic and keystone | 15:38 |
| *** lbragstad has joined #openstack-oslo | 15:39 | |
| dhellmann | viktors: right, we have to be careful about assumptions like that :-) | 15:39 |
| viktors | :) | 15:39 |
| *** lbragstad has quit IRC | 15:40 | |
| viktors | dhellmann: in case of ironic - the only way to catch it with tests is - to run ironic's unittests on each oslo.db commit | 15:40 |
| viktors | dhellmann: I have a doubt, that this is a suitable way | 15:41 |
| dhellmann | viktors: yep, that's what my change linked above will do | 15:41 |
| dhellmann | no, it's exactly what we need to do | 15:41 |
| *** i159 has quit IRC | 15:42 | |
| viktors | dhellmann: oh, it's will be great. My doubt was - this will require a lot of resources for testing. | 15:42 |
| dhellmann | viktors: yeah, it will, but I think we found a compromise way to reduce the load a bit | 15:43 |
| viktors | dhellmann: cool | 15:43 |
| dhellmann | viktors: it will mean a lot of jobs run for changes to oslo.db, as new projects are set up as users of the library | 15:43 |
| * viktors went to read the spec :) | 15:44 | |
| *** lbragstad has joined #openstack-oslo | 16:00 | |
| *** celttechie has joined #openstack-oslo | 16:17 | |
| *** arnaud has joined #openstack-oslo | 16:29 | |
| *** SridharG has joined #openstack-oslo | 16:32 | |
| *** lbragstad has quit IRC | 16:43 | |
| *** bnemec has quit IRC | 16:58 | |
| *** bnemec has joined #openstack-oslo | 17:02 | |
| *** yamahata has quit IRC | 17:08 | |
| *** Alexei_9871 has quit IRC | 17:11 | |
| *** pblaho has quit IRC | 17:12 | |
| *** praneshp has joined #openstack-oslo | 17:16 | |
| *** mriedem has quit IRC | 17:20 | |
| *** harlowja_away is now known as harlowja | 17:20 | |
| *** bnemec has quit IRC | 17:23 | |
| *** SridharG has quit IRC | 17:30 | |
| *** mriedem has joined #openstack-oslo | 17:34 | |
| *** tongli has joined #openstack-oslo | 17:34 | |
| *** markmc has joined #openstack-oslo | 17:44 | |
| *** pcm___ has quit IRC | 17:56 | |
| *** bnemec has joined #openstack-oslo | 18:03 | |
| *** pcm___ has joined #openstack-oslo | 18:05 | |
| *** arnaud has quit IRC | 18:06 | |
| *** arnaud has joined #openstack-oslo | 18:07 | |
| *** Alexei_987 has joined #openstack-oslo | 18:09 | |
| *** pblaho has joined #openstack-oslo | 18:09 | |
| *** tsekiyama has quit IRC | 18:09 | |
| *** tsekiyama has joined #openstack-oslo | 18:10 | |
| openstackgerrit | Steve Martinelli proposed a change to openstack/pycadf: Do not depend on endpoint id existing in the service catalog https://review.openstack.org/109060 | 18:12 |
| *** lbragstad has joined #openstack-oslo | 18:13 | |
| *** pblaho has quit IRC | 18:13 | |
| *** tsekiyam_ has joined #openstack-oslo | 18:14 | |
| *** tsekiyama has quit IRC | 18:15 | |
| *** arnaud has quit IRC | 18:17 | |
| *** bnemec has quit IRC | 18:17 | |
| viktors | zzzeek: hi! | 18:18 |
| *** tsekiyam_ has quit IRC | 18:20 | |
| *** tsekiyama has joined #openstack-oslo | 18:23 | |
| zzzeek | hey | 18:23 |
| openstackgerrit | Chris Dent proposed a change to openstack/oslo.messaging: Fix error in example of an RPC server https://review.openstack.org/108410 | 18:26 |
| openstackgerrit | Christian Berendt proposed a change to openstack/pycadf: Enable PEP8 checks E128, E251 and E265 https://review.openstack.org/109067 | 18:27 |
| *** markmc has quit IRC | 18:39 | |
| *** celttechie has quit IRC | 18:41 | |
| dims | dhellmann, have you touched the stackalytics data before? i can see they have just oslo-incubator and oslo.config and even those seem to be dated - https://github.com/stackforge/stackalytics/blob/master/etc/default_data.json#L7792 | 18:44 |
| dhellmann | dims: no, I haven't messed with that (I'm not even sure I realized it was on stackforge) | 18:45 |
| dims | y i went looking for it :) | 18:45 |
| *** viktors has quit IRC | 18:47 | |
| *** celttechie has joined #openstack-oslo | 18:49 | |
| openstackgerrit | Christian Berendt proposed a change to openstack/oslo.messaging: Enable check for E226 https://review.openstack.org/108278 | 18:51 |
| *** celttechie has quit IRC | 18:52 | |
| openstackgerrit | Valeriy Ponomaryov proposed a change to openstack/oslo-incubator: Fix cache deletion within policy enforcer https://review.openstack.org/109076 | 18:54 |
| noelbk | Alexei_987: sorry for the bonehead question: I'd like to make a unit test that confirms that msg.reply() eventually calls exchange_declare(passive=True). Do you know how to do that with something like mock? | 18:57 |
| Alexei_987 | noelbk: yes you have to replace object that is called with mock and call it the same way: mock.exchange_declare(passive=True) mox.ReplayAll() | 18:59 |
| Alexei_987 | noelbk: something like that. You can find example of mock usage in existing tests. something like tests/test_transport.py | 19:00 |
| openstackgerrit | Christian Berendt proposed a change to openstack/oslo.messaging: Enable PEP8 check E241 https://review.openstack.org/109077 | 19:00 |
| *** arnaud has joined #openstack-oslo | 19:02 | |
| *** arnaud__ has joined #openstack-oslo | 19:02 | |
| *** jecarey has quit IRC | 19:02 | |
| openstackgerrit | Christian Berendt proposed a change to openstack/oslo.messaging: Enable PEP8 check E265 https://review.openstack.org/109079 | 19:05 |
| openstackgerrit | Christian Berendt proposed a change to openstack/oslo.messaging: Enable PEP8 check E714 https://review.openstack.org/109080 | 19:07 |
| *** cdent has quit IRC | 19:19 | |
| *** arnaud__ has quit IRC | 19:19 | |
| *** arnaud has quit IRC | 19:19 | |
| *** alexpilotti has quit IRC | 19:19 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Translate the engine runner into a well defined state-machine https://review.openstack.org/106535 | 19:21 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Ensure state machine can be frozen https://review.openstack.org/107479 | 19:25 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add existing types to generated documentation https://review.openstack.org/106930 | 19:33 |
| *** bnemec has joined #openstack-oslo | 19:35 | |
| openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.utils: Make the i18n integration module private https://review.openstack.org/109094 | 19:47 |
| *** markmc has joined #openstack-oslo | 19:51 | |
| *** arnaud has joined #openstack-oslo | 19:59 | |
| openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.utils: Add API docs and clean up other docs https://review.openstack.org/109101 | 20:06 |
| *** jecarey has joined #openstack-oslo | 20:09 | |
| openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.utils: Make return type from urlsplit private https://review.openstack.org/109108 | 20:22 |
| dhellmann | dims: a few oslo.utils cleanups before we do a release: https://review.openstack.org/#/q/project:openstack/oslo.utils+is:open,n,z | 20:23 |
| openstackgerrit | Arnaud Legendre proposed a change to openstack/oslo.vmware: Port the Datastore and DatastorePath objects https://review.openstack.org/105274 | 20:30 |
| *** bnemec has quit IRC | 20:33 | |
| russellb | dhellmann: ping ... just looking for an ACK to confirm that oslo and oslo.messaging are ready to have juno-2 closed out. looks like they are | 20:37 |
| dhellmann | russellb: yes, I think we're set | 20:38 |
| russellb | dhellmann: thanks! | 20:38 |
| dhellmann | russellb: remind me, do we tag at this point or is this just a launchpad status update? | 20:38 |
| russellb | dhellmann: AIUI, we tag oslo-incubator only. and close out the juno-2 milestone for both oslo and oslo.messaging in launchpad. | 20:39 |
| russellb | no tarballs for either | 20:39 |
| dhellmann | russellb: ok, that sounds right | 20:39 |
| russellb | k :) | 20:39 |
| dhellmann | we have tags on the libraries when we make releases, but only tag the incubator for milestones and then branch at the end of the cycle | 20:39 |
| dhellmann | just wanted to make sure we weren't leaving out all of the other libs if we needed to tag now | 20:40 |
| -openstackstatus- NOTICE: nodepool is unable to build test nodes so check and gate tests are delayed | 20:41 | |
| *** ChanServ changes topic to "nodepool is unable to build test nodes so check and gate tests are delayed" | 20:41 | |
| *** celttechie_grr has joined #openstack-oslo | 20:47 | |
| dims | dhellmann, thanks, will keep an eye on them | 20:53 |
| *** mrda-away is now known as mrda | 20:57 | |
| *** arnaud has quit IRC | 21:16 | |
| *** arnaud has joined #openstack-oslo | 21:19 | |
| *** arnaud__ has joined #openstack-oslo | 21:19 | |
| *** markmcclain1 has joined #openstack-oslo | 21:27 | |
| *** markmcclain has quit IRC | 21:28 | |
| *** tongli has quit IRC | 21:35 | |
| *** celttechie_grr has quit IRC | 21:35 | |
| *** markmcclain1 has quit IRC | 21:38 | |
| *** arnaud__ has quit IRC | 21:39 | |
| *** arnaud has quit IRC | 21:39 | |
| *** mriedem has quit IRC | 21:57 | |
| *** pcm___ has quit IRC | 21:58 | |
| *** lbragsta_ has joined #openstack-oslo | 22:05 | |
| -openstackstatus- NOTICE: zuul is working through a backlog of jobs due to an earlier problem with nodepool | 22:07 | |
| *** ChanServ changes topic to "zuul is working through a backlog of jobs due to an earlier problem with nodepool" | 22:07 | |
| *** lbragstad has quit IRC | 22:08 | |
| *** lbragsta_ has quit IRC | 22:09 | |
| *** shakamunyi has joined #openstack-oslo | 22:10 | |
| *** shakamunyi has quit IRC | 22:15 | |
| *** arnaud has joined #openstack-oslo | 22:18 | |
| *** arnaud__ has joined #openstack-oslo | 22:18 | |
| *** markmc has quit IRC | 22:25 | |
| *** dims has quit IRC | 22:29 | |
| *** dims has joined #openstack-oslo | 22:33 | |
| *** shakamunyi has joined #openstack-oslo | 22:33 | |
| *** dims has quit IRC | 22:43 | |
| *** jecarey has quit IRC | 22:45 | |
| openstackgerrit | Alexei Kornienko proposed a change to openstack/oslo.messaging: Should not send replies for cast messages https://review.openstack.org/109143 | 22:58 |
| *** Ish__ has joined #openstack-oslo | 23:00 | |
| harlowja | Alexei_987 nice, haha | 23:00 |
| harlowja | 10x more | 23:00 |
| Alexei_987 | harlowja: still lot's of room to optimize | 23:01 |
| harlowja | def | 23:01 |
| *** Ish__ has quit IRC | 23:01 | |
| *** Ish__ has joined #openstack-oslo | 23:02 | |
| *** bknudson has quit IRC | 23:02 | |
| Alexei_987 | harlowja: is there any chance that we'll release 1.3.1 version? | 23:04 |
| Alexei_987 | harlowja: https://bugs.launchpad.net/oslo.messaging/+bug/1346253 this one is bothering me | 23:04 |
| harlowja | i'm not sure i can answer that one :-P | 23:05 |
| harlowja | others here might be able to | 23:05 |
| Alexei_987 | harlowja: well opening a new connection for every message sent also seems stupid | 23:05 |
| harlowja | no disagreement from me | 23:05 |
| Alexei_987 | harlowja: I get amazing performance of 50 calls/second on 1.3.0 | 23:05 |
| harlowja | thats webscale, lol | 23:06 |
| Alexei_987 | I would expect to get more from rabbitmq | 23:06 |
| harlowja | agreed :) | 23:06 |
| harlowja | for something used in high speed trading and other things 50 calls/second won't cut it :-P | 23:06 |
| *** arnaud__ has quit IRC | 23:14 | |
| *** arnaud has quit IRC | 23:14 | |
| *** arnaud has joined #openstack-oslo | 23:22 | |
| *** arnaud__ has joined #openstack-oslo | 23:22 | |
| *** praneshp has quit IRC | 23:32 | |
| openstackgerrit | Arnaud Legendre proposed a change to openstack/oslo.vmware: Port the Datastore and DatastorePath objects https://review.openstack.org/105274 | 23:36 |
| *** dims has joined #openstack-oslo | 23:38 | |
| *** dims has quit IRC | 23:43 | |
| *** Ish__ has quit IRC | 23:46 | |
| *** shakamunyi has quit IRC | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!