*** oomichi_sleeping is now known as oomichi | 00:09 | |
*** dims__ has quit IRC | 00:11 | |
*** dims has joined #openstack-oslo | 00:11 | |
*** tsekiyam_ has joined #openstack-oslo | 00:13 | |
*** tsekiyama has quit IRC | 00:17 | |
*** tsekiyam_ has quit IRC | 00:17 | |
*** dims has quit IRC | 00:21 | |
*** zhiyan_ is now known as zhiyan | 00:27 | |
*** dims has joined #openstack-oslo | 00:27 | |
*** praneshp has quit IRC | 00:28 | |
*** yamahata has joined #openstack-oslo | 00:33 | |
*** ildikov_ has joined #openstack-oslo | 00:48 | |
*** ildikov has quit IRC | 00:51 | |
*** zzzeek has quit IRC | 01:08 | |
*** zzzeek has joined #openstack-oslo | 01:08 | |
*** czzl has quit IRC | 01:21 | |
*** czzl has joined #openstack-oslo | 01:22 | |
openstackgerrit | Alex Gaynor proposed a change to openstack-dev/hacking: Mark hacking as being a universal wheel https://review.openstack.org/99528 | 01:36 |
---|---|---|
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Upgrade hacking version and fix some of the issues https://review.openstack.org/99531 | 01:46 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Upgrade hacking version and fix some of the issues https://review.openstack.org/99531 | 01:52 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo-incubator: Bump hacking to 0.9.x series https://review.openstack.org/99534 | 01:54 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.config: Bump hacking to 0.9.x series https://review.openstack.org/99535 | 01:54 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.db: Bump hacking to 0.9.x series https://review.openstack.org/99537 | 01:55 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.messaging: Bump hacking to 0.9.x series https://review.openstack.org/99538 | 01:55 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.rootwrap: Bump hacking to 0.9.x series https://review.openstack.org/99539 | 01:56 |
*** zzzeek has quit IRC | 01:56 | |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.vmware: Bump hacking to 0.9.x series https://review.openstack.org/99540 | 01:57 |
*** zzzeek has joined #openstack-oslo | 01:57 | |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslosphinx: Bump hacking to 0.9.x series https://review.openstack.org/99541 | 01:57 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/pycadf: Bump hacking to 0.9.x series https://review.openstack.org/99542 | 01:57 |
*** zzzeek has quit IRC | 02:01 | |
*** czzl has quit IRC | 02:01 | |
*** czzl has joined #openstack-oslo | 02:02 | |
*** czzl has quit IRC | 02:08 | |
*** czzl has joined #openstack-oslo | 02:13 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/oslo-specs: Add basic support for conditional execution https://review.openstack.org/98946 | 02:24 |
*** arnaud__ has quit IRC | 02:29 | |
*** markmcclain has quit IRC | 02:31 | |
*** dims has quit IRC | 02:40 | |
openstackgerrit | ChangBo Guo(gcb) proposed a change to openstack/oslo-incubator: Add module integrity check in update.py https://review.openstack.org/76901 | 02:51 |
*** dims_ has joined #openstack-oslo | 03:07 | |
*** dims_ has quit IRC | 03:12 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Remove misc.as_bool as oslo provides an equivalent https://review.openstack.org/98013 | 03:13 |
*** praneshp has joined #openstack-oslo | 03:18 | |
openstackgerrit | wingwj proposed a change to openstack/oslo.db: Add _wrap_db_error support for postgresql https://review.openstack.org/92001 | 03:21 |
*** zzzeek has joined #openstack-oslo | 03:29 | |
*** zhiyan is now known as zhiyan_ | 03:30 | |
*** arnaud__ has joined #openstack-oslo | 03:36 | |
*** praneshp_ has joined #openstack-oslo | 03:39 | |
*** zhiyan_ is now known as zhiyan | 03:41 | |
*** praneshp has quit IRC | 03:41 | |
*** praneshp_ is now known as praneshp | 03:41 | |
*** xiej has quit IRC | 03:51 | |
*** jeffreycoho has joined #openstack-oslo | 03:52 | |
*** jeffreycoho has quit IRC | 03:53 | |
*** jeffreycoho has joined #openstack-oslo | 03:56 | |
*** arnaud__ has quit IRC | 04:12 | |
*** harlowja is now known as harlowja_away | 04:16 | |
*** arnaud__ has joined #openstack-oslo | 04:21 | |
*** zzzeek has quit IRC | 04:33 | |
*** czzl has quit IRC | 04:37 | |
*** markmcclain has joined #openstack-oslo | 04:50 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo-incubator: Updated from global requirements https://review.openstack.org/99084 | 04:59 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.db: Updated from global requirements https://review.openstack.org/99086 | 04:59 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/taskflow: Updated from global requirements https://review.openstack.org/93254 | 05:00 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Denote that other projects can use this library https://review.openstack.org/98624 | 05:05 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Upgrade hacking version and fix some of the issues https://review.openstack.org/99531 | 05:45 |
*** oomichi has quit IRC | 05:58 | |
*** markmcclain has quit IRC | 06:15 | |
*** praneshp has quit IRC | 06:16 | |
*** markmcclain has joined #openstack-oslo | 06:18 | |
*** ildikov_ has quit IRC | 06:20 | |
*** arnaud__ has quit IRC | 06:22 | |
*** ildikov has joined #openstack-oslo | 06:41 | |
*** jaosorior has joined #openstack-oslo | 06:49 | |
*** oomichi has joined #openstack-oslo | 07:04 | |
*** ildikov has quit IRC | 07:07 | |
*** markmcclain has quit IRC | 07:11 | |
*** I159 has joined #openstack-oslo | 07:13 | |
*** flaper87|afk is now known as flaper87 | 07:22 | |
*** ildikov has joined #openstack-oslo | 07:24 | |
*** tkelsey has joined #openstack-oslo | 07:26 | |
*** mrda is now known as mrda-away | 07:40 | |
*** ihrachyshka has joined #openstack-oslo | 07:55 | |
*** ihrachyshka has quit IRC | 08:02 | |
openstackgerrit | Roman Podoliaka proposed a change to openstack/oslo-incubator: WIP: fix openstack_citest concurrent access https://review.openstack.org/99592 | 08:02 |
*** ihrachyshka has joined #openstack-oslo | 08:02 | |
*** oomichi has quit IRC | 08:05 | |
*** sreshetnyak has quit IRC | 08:16 | |
*** markmc has joined #openstack-oslo | 08:19 | |
ihrachyshka | dhellmann: any plans to release new oslotest? I would like to see automatic mock cleanup there so that we can start removing explicit cleanups in projects that use the library. | 08:31 |
*** dims_ has joined #openstack-oslo | 08:49 | |
*** dims_ has quit IRC | 08:54 | |
*** zhiyan is now known as zhiyan_ | 09:23 | |
openstackgerrit | Roman Podoliaka proposed a change to openstack/oslo-incubator: Prevent races in opportunistic db test cases https://review.openstack.org/99592 | 09:45 |
openstackgerrit | Roman Podoliaka proposed a change to openstack/oslo.db: Prevent races in opportunistic db test cases https://review.openstack.org/99608 | 09:45 |
*** kibad has joined #openstack-oslo | 09:50 | |
kibad | can I server as empty string if I want to send a message to local system? | 09:50 |
*** oomichi has joined #openstack-oslo | 09:54 | |
*** ihrachyshka has quit IRC | 10:11 | |
*** sreshetnyak has joined #openstack-oslo | 10:13 | |
*** yamahata has quit IRC | 10:21 | |
*** dims_ has joined #openstack-oslo | 10:23 | |
*** kmartin has quit IRC | 10:38 | |
*** ihrachyshka has joined #openstack-oslo | 11:20 | |
*** tkelsey has quit IRC | 11:24 | |
*** kibad has quit IRC | 11:40 | |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo-incubator: Bump hacking to 0.9.x series https://review.openstack.org/99534 | 11:42 |
therve | sileht, Hi! Do you have any example of using the fake notifier from oslo.messaging? | 11:43 |
sileht | therve, we have this tests http://git.openstack.org/cgit/openstack/ceilometer/tree/ceilometer/tests/test_notification.py#n196 | 11:45 |
sileht | therve, but it have an issue, sometimes it fail on gate py26, I'm triing to rewrite it (eventlet issue) | 11:45 |
therve | sileht, I'm trying to use what's in _impl_test | 11:46 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.config: Bump hacking to 0.9.x series https://review.openstack.org/99535 | 11:46 |
sileht | therve, oh that one | 11:46 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.db: Bump hacking to 0.9.x series https://review.openstack.org/99537 | 11:48 |
sileht | therve, this is only for internal testing of oslo.messaging, you can't access to the NOTIFICATION lists outside of oslo.messaging | 11:48 |
therve | sileht, Okay, too bad :). There's a nice test_notifier in oslo rpc | 11:48 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.messaging: Bump hacking to 0.9.x series https://review.openstack.org/99538 | 11:49 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.vmware: Bump hacking to 0.9.x series https://review.openstack.org/99540 | 11:50 |
ihrachyshka | sileht: do you mean we can't check NOTIFICATIONS in unit tests in projects using oslo.messaging?.. these are news to me | 11:51 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/pycadf: Bump hacking to 0.9.x series https://review.openstack.org/99542 | 11:52 |
sileht | ihrachyshka, _impl_test.py is prefixed by _, NOTIFICATIONS is global in _impl_test module, so this is private API, it shouldn't be used outside of oslo.messaging | 11:53 |
*** lbragstad has quit IRC | 11:59 | |
ihrachyshka | sileht: sorry, mixed two things. I've checked one more time, and it seems we don't use NOTIFICATIONS from there, instead we implement our own fake_notifier where we collect events into array of that name | 12:00 |
ttx | dhellmann: ping me when around re: oslo-incubator juno-1 tag | 12:06 |
*** yamahata has joined #openstack-oslo | 12:10 | |
openstackgerrit | Petr Blaho proposed a change to openstack/oslo.config: Changes imports order to pass H305, enables check https://review.openstack.org/99639 | 12:17 |
*** dims_ has quit IRC | 12:22 | |
*** dims_ has joined #openstack-oslo | 12:23 | |
*** dims_ is now known as dims | 12:25 | |
*** amotoki has quit IRC | 12:31 | |
*** openstackgerrit has quit IRC | 12:46 | |
*** openstackgerrit has joined #openstack-oslo | 12:48 | |
*** oomichi has quit IRC | 12:49 | |
*** dims_ has joined #openstack-oslo | 12:55 | |
*** jecarey has quit IRC | 12:56 | |
*** dims has quit IRC | 12:56 | |
*** lbragstad has joined #openstack-oslo | 12:57 | |
*** yamahata has quit IRC | 13:03 | |
*** yamahata has joined #openstack-oslo | 13:03 | |
*** ihrachyshka has quit IRC | 13:05 | |
*** ihrachyshka has joined #openstack-oslo | 13:07 | |
*** mriedem has joined #openstack-oslo | 13:12 | |
*** tkelsey has joined #openstack-oslo | 13:35 | |
*** sileht has quit IRC | 13:43 | |
*** bknudson has joined #openstack-oslo | 13:50 | |
*** ihrachyshka has quit IRC | 13:51 | |
openstackgerrit | Ildiko Vancsa proposed a change to openstack/oslo.db: Fix Sphinx directive name https://review.openstack.org/99667 | 13:53 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.messaging: Bump hacking to 0.9.x series https://review.openstack.org/99538 | 13:53 |
*** beekneemech is now known as bnemec | 13:54 | |
*** ihrachyshka has joined #openstack-oslo | 13:55 | |
*** zzzeek has joined #openstack-oslo | 13:59 | |
*** sileht has joined #openstack-oslo | 14:02 | |
zzzeek | hey dhellmann or whomever - does https://review.openstack.org/#/c/97442/ imply that Postgresql would no longer be part of CI for openstack in general, or what is the implication there? the idea that MySQL strict mode is as good as testing that code runs against PG is crazy. I dont know what the term “in the gate” means. | 14:09 |
rpodolyaka | zzzeek: "in the gate" means integration tests jobs must pass before a commit can be merged (+Verify from Jenkins in gerrit) | 14:12 |
zzzeek | ok | 14:12 |
zzzeek | but there are other stages of CI that are more comprehensive right | 14:12 |
openstackgerrit | Petr Blaho proposed a change to openstack/oslo.db: Changes import orders to pass H305 check https://review.openstack.org/99670 | 14:12 |
openstackgerrit | Petr Blaho proposed a change to openstack/oslo.db: Fixes whitespaces between imports to pass H307 https://review.openstack.org/99671 | 14:12 |
openstackgerrit | Petr Blaho proposed a change to openstack/oslo.db: Updates one line docstring with dot to pass H402 https://review.openstack.org/99672 | 14:12 |
openstackgerrit | Petr Blaho proposed a change to openstack/oslo.db: Adds empty line to multilines docs to pass H405 https://review.openstack.org/99673 | 14:12 |
openstackgerrit | Petr Blaho proposed a change to openstack/oslo.db: Uses keyword params for i18n string to pass H703 https://review.openstack.org/99674 | 14:12 |
openstackgerrit | Petr Blaho proposed a change to openstack/oslo.db: Fixes indentations to pass E128 check. https://review.openstack.org/99675 | 14:12 |
openstackgerrit | Petr Blaho proposed a change to openstack/oslo.db: Fixes comments to pass E265 check. https://review.openstack.org/99676 | 14:12 |
rpodolyaka | not sure what you mean by "more comprehensive" :) gate jobs usually run unittests + a few devstack jobs (all-in-one openstack deployment, e.g. with mysql or postgresql, with/without neutron, etc) | 14:13 |
rpodolyaka | i.e. a few configurations of devstack jobs | 14:14 |
rpodolyaka | which I believe is pretty good coverage actually | 14:14 |
rpodolyaka | the drawback is that we need to many nodes to the all these configurations | 14:14 |
rpodolyaka | *too | 14:15 |
rpodolyaka | but +1 from me on keeping postgresql jobs, as strict is not enough, IMO | 14:16 |
rpodolyaka | *mysql strict mode | 14:16 |
*** tsekiyama has joined #openstack-oslo | 14:31 | |
zzzeek | my q is, at what point do the tests get run against all supported backends before being shipped ? if you want to test less against PG, that is one thing, but if you *never* test against PG and asssume MySQL is enough, that wont work | 14:32 |
rpodolyaka | ++ | 14:32 |
zzzeek | OK well is that what’s proposed here, since I dont know what other stages of CI exist besides just “gate jobs” that are per-commit | 14:33 |
rpodolyaka | so CI has a few job pipelines, which you can monitor here http://status.openstack.org/zuul/ | 14:34 |
rpodolyaka | but devstack jobs (test against one-node all-in-one openstack deployements) are run only in 'check' (run for each new uploaded patch set to gerrit) and 'gate' (run for each commit before it's merged) pipelines, afaik | 14:36 |
rpodolyaka | but yeah, I agree, that we can't claim PG is a supported backend if we don't test openstack against it, as 'something that is untested is broken' | 14:37 |
zzzeek | the CI environment is annoying b.c. it is very hard to see the actual runs, it’s like a separate link to a tar.gz file somewhere | 14:39 |
ttx | dhellmann: ping | 14:40 |
ttx | dhellmann: re: juno-1 completion | 14:40 |
*** yamahata has quit IRC | 14:41 | |
*** jecarey has joined #openstack-oslo | 14:46 | |
*** flaper87 is now known as flaper87|afk | 15:00 | |
ttx | dhellmann: i propose we tag 281882fb1cc29ccfe067f803f547169b62890f3b (current HEAD° as oslo-incubator "juno-1") | 15:05 |
dhellmann | ttx: looking | 15:05 |
ttx | well, 2014.2.b1 to be more precise | 15:06 |
dhellmann | ttx: that looks good, I don't think there's any real reason to wait for anything else to merge | 15:09 |
ttx | agreed | 15:09 |
ttx | on it | 15:09 |
dhellmann | ttx: I feel like we've talked about tagging libraries, too, but I don't remember what we decided. | 15:10 |
ttx | dhellmann: we can't really tag them 2014.2.b1, that would release that to pypi | 15:11 |
ttx | so we don't | 15:11 |
dhellmann | good point | 15:11 |
dhellmann | I'll add that to my notes about versioning that I sent to the ML | 15:11 |
*** ihrachyshka_ has joined #openstack-oslo | 15:12 | |
*** ihrachyshka_ has quit IRC | 15:12 | |
*** ihrachyshka has quit IRC | 15:15 | |
*** markmcclain has joined #openstack-oslo | 15:22 | |
openstackgerrit | Tom Cammann proposed a change to openstack/oslo-incubator: Make periodic tasks run on regular spacing interval https://review.openstack.org/99695 | 15:37 |
zzzeek | rpodolyaka: what’s tempest exactly? | 15:43 |
*** bogdando has quit IRC | 15:55 | |
*** bogdando has joined #openstack-oslo | 15:56 | |
*** markmcclain has quit IRC | 15:57 | |
*** markmcclain has joined #openstack-oslo | 15:57 | |
*** ihrachyshka has joined #openstack-oslo | 15:57 | |
*** markmcclain has quit IRC | 15:57 | |
*** markmcclain has joined #openstack-oslo | 15:58 | |
rpodolyaka | zzzeek: a collection of functional tests that are run against a deployed openstack cluster | 15:59 |
zzzeek | ok | 15:59 |
*** hyakuhei_ has joined #openstack-oslo | 15:59 | |
*** hyakuhei_ has quit IRC | 16:00 | |
*** hyakuhei_ has joined #openstack-oslo | 16:00 | |
*** mestery has quit IRC | 16:03 | |
zzzeek | dhellmann / rpodolyaka - what’s the history of “testr” + “subunit”? was that stuff written for openstack explicitly, and/or did OS used to use something like Nose and then switched ? im curious why I’ve never seen this test runner before (but yes I see it does the parallel testing thing) | 16:03 |
*** mestery has joined #openstack-oslo | 16:04 | |
*** hyakuhei_ has quit IRC | 16:05 | |
rpodolyaka | zzzeek: AFAIK, no, those weren't written for openstack explicitly. OS used to use Nose and switched to testr+subunit about a year ago, I think | 16:08 |
zzzeek | i see | 16:08 |
rpodolyaka | I think nose can run tests in parallel too, but there was some issue with eventlet | 16:09 |
rpodolyaka | testr works fairly good on the other hand. The main issue with it is that you can't longer use pdb easily (due to the way testr run tests) | 16:10 |
rpodolyaka | so you still need testtools/nose/any other test runner to debug your code | 16:11 |
*** markmcclain has quit IRC | 16:23 | |
openstackgerrit | Tom Cammann proposed a change to openstack/oslo-incubator: Small clean up in generator https://review.openstack.org/99707 | 16:24 |
bknudson | in keystone we put together a "debug" env for tox that does testtools for pdb | 16:24 |
*** czzl has joined #openstack-oslo | 16:31 | |
*** I159 has quit IRC | 16:31 | |
*** openstackgerrit has quit IRC | 16:38 | |
*** markmcclain has joined #openstack-oslo | 16:44 | |
*** harlowja_away is now known as harlowja | 16:54 | |
*** erecio has quit IRC | 16:58 | |
*** erecio has joined #openstack-oslo | 16:59 | |
*** hyakuhei_ has joined #openstack-oslo | 17:00 | |
*** bogdando has quit IRC | 17:00 | |
*** hyakuhei is now known as hyakuhei__ | 17:01 | |
*** hyakuhei_ is now known as hyakuhei | 17:01 | |
*** hyakuhei has joined #openstack-oslo | 17:01 | |
zzzeek | so I’m looking into nova and running tests and such. I know that nova has served as the basis for other projects, and that it isn’t using much oslo. is there a “port nova to oslo.db” plan laid out? | 17:05 |
*** erecio has quit IRC | 17:06 | |
*** erecio has joined #openstack-oslo | 17:09 | |
*** markmc has quit IRC | 17:14 | |
ihrachyshka | zzzeek: have you googled?.. it's the 2nd hit for me | 17:16 |
zzzeek | not seeing it | 17:17 |
*** czzl has quit IRC | 17:18 | |
ihrachyshka | zzzeek: http://osdir.com/ml/openstack-dev/2014-05/msg00239.html | 17:18 |
zzzeek | what did you google for to get that? | 17:19 |
zzzeek | thanks anyway | 17:23 |
*** markmcclain has quit IRC | 17:25 | |
*** ihrachyshka has quit IRC | 17:29 | |
*** arnaud__ has joined #openstack-oslo | 17:30 | |
*** praneshp has joined #openstack-oslo | 17:31 | |
*** ihrachyshka has joined #openstack-oslo | 17:32 | |
*** markmcclain has joined #openstack-oslo | 17:33 | |
*** markmcclain has quit IRC | 17:33 | |
zzzeek | rpodolyaka: per your note #4 in http://lists.openstack.org/pipermail/openstack-dev/2014-May/034944.html is this how you commonly test that what’s happening in oslo.db will work in nova? search and replace | 17:35 |
*** markmcclain has joined #openstack-oslo | 17:35 | |
*** ihrachyshka has quit IRC | 17:35 | |
*** lbragstad has quit IRC | 17:39 | |
*** ujjain has quit IRC | 17:48 | |
*** lbragstad has joined #openstack-oslo | 17:49 | |
*** markmcclain has quit IRC | 18:01 | |
*** markmcclain has joined #openstack-oslo | 18:01 | |
*** markmcclain has quit IRC | 18:02 | |
*** markmcclain has joined #openstack-oslo | 18:05 | |
*** hyakuhei has quit IRC | 18:05 | |
*** praneshp_ has joined #openstack-oslo | 18:05 | |
*** praneshp has quit IRC | 18:06 | |
*** praneshp_ is now known as praneshp | 18:06 | |
*** tkelsey has quit IRC | 18:11 | |
*** ildikov has quit IRC | 18:12 | |
*** openstackgerrit has joined #openstack-oslo | 18:13 | |
*** markmcclain has quit IRC | 18:31 | |
*** markmcclain has joined #openstack-oslo | 18:31 | |
*** hyakuhei has joined #openstack-oslo | 18:31 | |
*** jaosorior has quit IRC | 18:32 | |
*** hyakuhei has quit IRC | 18:32 | |
*** hyakuhei has joined #openstack-oslo | 18:32 | |
*** hyakuhei has joined #openstack-oslo | 18:32 | |
*** erecio has quit IRC | 18:34 | |
*** erecio has joined #openstack-oslo | 18:34 | |
*** markmcclain has quit IRC | 18:39 | |
*** rpodolyaka1 has joined #openstack-oslo | 18:39 | |
*** hyakuhei has quit IRC | 18:39 | |
*** dstanek has joined #openstack-oslo | 18:40 | |
dstanek | in oslo.config does the validation only happen when accessing the config object vs. when parsing the file? | 18:40 |
dhellmann | dstanek: I think probably yes, because the file syntax is parsed independently of knowing what options are needed (the actual option definitions can be registered after the file is parsed) | 18:42 |
dstanek | dhellmann: hmmm...so there is no way to enforce a max value on an int at parse time? | 18:43 |
dstanek | it seems to happen at runtime; and it seems that something is catching the value error so i'm not getting an error at runtime, but prints confirm the value error is raised | 18:44 |
dhellmann | dstanek: the parser doesn't know that the option type is an int when the file is parsed | 18:45 |
dhellmann | at least, it might not | 18:45 |
dhellmann | options can be added lazily, and with the new config filter they might be added by a library without the app even knowing they are used | 18:45 |
dstanek | dhellmann: hmmm. so we can't do validation? | 18:47 |
dstanek | i was hoping that there was a CONF.finalize() we could call before our server loop that would validate whatever has been registered | 18:48 |
*** hyakuhei has joined #openstack-oslo | 18:49 | |
*** hyakuhei has joined #openstack-oslo | 18:49 | |
*** hyakuhei has quit IRC | 18:49 | |
dhellmann | dstanek: we can do validation of individual options in the code that knows those options exists, but we cannot have the parser do validation because there is no universal schema for the config file | 18:49 |
dstanek | dhellmann: is creating the list of opts just for printing on the command line? | 18:51 |
dhellmann | dstanek: command line options and config file options are handled a little differently | 18:51 |
dhellmann | anything that is a command line option has to be registered before sys.argv is parsed | 18:51 |
dhellmann | dstanek: you might be interested in https://review.openstack.org/93149 | 18:53 |
*** erecio has quit IRC | 18:53 | |
dstanek | dhellmann: yes, that does look interesting. i was hoping that http://dpaste.com/2GPMSNB would enforce a max for me | 18:55 |
dhellmann | dstanek: it will, but only when max_password_length is accessed (also, max password length?!) | 18:56 |
dstanek | dhellmann: that isn't even happening for me :-( | 18:57 |
dstanek | yeah, since we use passlib we need to protect operators from setting a value higher than what passlib supports | 18:57 |
dhellmann | ok, what you have looks like it should work as we're both expecting so I'm not sure what's wrong -- maybe a bug or maybe a misunderstanding | 18:58 |
*** markmcclain has joined #openstack-oslo | 18:59 | |
*** erecio has joined #openstack-oslo | 19:03 | |
dstanek | dhellmann: i think bug since validation isn't happening on access either, but misunderstanding about the scope of what it's doing for config files | 19:04 |
dstanek | i'll create a bug and patch for this - http://git.openstack.org/cgit/openstack/oslo.config/tree/oslo/config/types.py#n137 should raise instead of return | 19:04 |
dhellmann | dstanek: yeah, I meant there might be some other thing you have to do to enable the validation, but otherwise I concur | 19:04 |
*** rpodolyaka1 has quit IRC | 19:19 | |
*** markmcclain has quit IRC | 19:25 | |
*** ildikov has joined #openstack-oslo | 19:25 | |
dstanek | dhellmann: do you think that there is a point in all of the apps right before the run loop starts where we could safely validate configuration | 19:32 |
dstanek | once the app starts doing real work I wouldn't expect new config file options to be defined | 19:32 |
*** rpodolyaka1 has joined #openstack-oslo | 19:37 | |
dhellmann | dstanek: no, because options are not all defined at import time, and even for the ones that are some drivers that define options might not have been loaded yet | 19:38 |
dhellmann | dstanek: new options can and are registered anywhere at runtime | 19:38 |
dstanek | dhellmann: sorry for the many questions :-) i'm trying to wrap my head around this as it's different from what i am used to | 19:41 |
*** rpodolyaka1 has quit IRC | 19:42 | |
*** barefoot has left #openstack-oslo | 19:43 | |
*** markmcclain has joined #openstack-oslo | 19:45 | |
*** ihrachyshka has joined #openstack-oslo | 19:49 | |
*** markmcclain has quit IRC | 19:51 | |
*** praneshp has quit IRC | 19:52 | |
openstackgerrit | David Stanek proposed a change to openstack/oslo.config: Fixes an issue validating max integer values https://review.openstack.org/99753 | 20:13 |
*** jecarey has quit IRC | 20:15 | |
*** czzl has joined #openstack-oslo | 20:15 | |
*** boris-42 has quit IRC | 20:18 | |
*** morganfainberg has quit IRC | 20:18 | |
*** boris-42 has joined #openstack-oslo | 20:18 | |
*** morganfainberg has joined #openstack-oslo | 20:18 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Upgrade hacking version and fix some of the issues https://review.openstack.org/99531 | 20:20 |
bknudson | in keystone we try not to register options at import time | 20:20 |
*** jecarey has joined #openstack-oslo | 20:33 | |
*** openstackgerrit has quit IRC | 20:35 | |
*** praneshp has joined #openstack-oslo | 20:35 | |
*** openstackgerrit has joined #openstack-oslo | 20:36 | |
*** markmcclain has joined #openstack-oslo | 20:36 | |
*** bknudson has left #openstack-oslo | 20:41 | |
*** dims_ has quit IRC | 20:47 | |
openstackgerrit | lifeless proposed a change to openstack-dev/pbr: Allow examining parsing exceptions. https://review.openstack.org/80856 | 20:47 |
openstackgerrit | lifeless proposed a change to openstack-dev/pbr: Teach pbr VersionInfo about debian versions. https://review.openstack.org/81074 | 20:47 |
openstackgerrit | lifeless proposed a change to openstack-dev/pbr: Teach pbr about post versioned dev versions. https://review.openstack.org/80449 | 20:48 |
openstackgerrit | lifeless proposed a change to openstack-dev/pbr: Use the current pbr for testpackage tests. https://review.openstack.org/94107 | 20:48 |
openstackgerrit | lifeless proposed a change to openstack-dev/pbr: Add a converter to version_tuples. https://review.openstack.org/80457 | 20:48 |
openstackgerrit | lifeless proposed a change to openstack-dev/pbr: Break out a common version object from VersionInfo https://review.openstack.org/94108 | 20:48 |
*** erecio has quit IRC | 20:53 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/oslo-specs: Add basic support for conditional execution https://review.openstack.org/98946 | 21:05 |
*** bpokorny1 has joined #openstack-oslo | 21:06 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.messaging: Updated from global requirements https://review.openstack.org/99087 | 21:07 |
*** bpokorny1 is now known as bpokorny | 21:07 | |
bpokorny | If anyone can spare some time, I'd appreciate a review on this one: https://review.openstack.org/#/c/97305/ | 21:10 |
*** markmcclain has quit IRC | 21:12 | |
*** markmcclain1 has joined #openstack-oslo | 21:12 | |
*** HenryG has quit IRC | 21:45 | |
*** mriedem has left #openstack-oslo | 21:48 | |
*** lbragstad has quit IRC | 21:50 | |
*** markmcclain1 has quit IRC | 21:56 | |
*** markmcclain has joined #openstack-oslo | 21:56 | |
*** dims_ has joined #openstack-oslo | 21:57 | |
*** praneshp_ has joined #openstack-oslo | 21:57 | |
*** praneshp has quit IRC | 21:59 | |
*** praneshp_ is now known as praneshp | 21:59 | |
*** bpokorny has quit IRC | 22:00 | |
*** mrda-away is now known as mrda | 22:01 | |
*** czzl has quit IRC | 22:09 | |
openstackgerrit | George Peristerakis proposed a change to openstack/oslo-incubator: wrapping the mock module with six https://review.openstack.org/87375 | 22:19 |
*** dstanek is now known as dstanek_zzz | 22:23 | |
*** dstanek_zzz is now known as dstanek | 22:24 | |
*** markmcclain has quit IRC | 22:27 | |
*** HenryG has joined #openstack-oslo | 22:42 | |
*** dstanek is now known as dstanek_zzz | 22:59 | |
*** dims_ has quit IRC | 23:01 | |
*** dstanek_zzz is now known as dstanek | 23:09 | |
*** markmcclain has joined #openstack-oslo | 23:18 | |
*** ihrachyshka has quit IRC | 23:23 | |
*** praneshp_ has joined #openstack-oslo | 23:34 | |
*** praneshp has quit IRC | 23:37 | |
*** praneshp_ is now known as praneshp | 23:37 | |
*** dstanek is now known as dstanek_zzz | 23:43 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!