| *** shakamunyi has joined #openstack-oslo | 00:40 | |
| *** shakamunyi has quit IRC | 00:50 | |
| *** shakamunyi has joined #openstack-oslo | 01:16 | |
| *** shakamunyi has quit IRC | 01:26 | |
| *** yamahata has joined #openstack-oslo | 01:35 | |
| *** shakamunyi has joined #openstack-oslo | 01:53 | |
| *** shakamunyi has quit IRC | 01:57 | |
| *** shakamunyi has joined #openstack-oslo | 01:58 | |
| *** shakamunyi has quit IRC | 02:05 | |
| *** yamahata has quit IRC | 02:30 | |
| *** yamahata has joined #openstack-oslo | 02:30 | |
| *** shakamunyi has joined #openstack-oslo | 02:30 | |
| *** shakamunyi has quit IRC | 02:40 | |
| *** shakamunyi has joined #openstack-oslo | 03:06 | |
| *** shakamunyi has quit IRC | 03:17 | |
| *** zhiyan has joined #openstack-oslo | 03:18 | |
| openstackgerrit | Zhu Zhu proposed a change to openstack/oslo.messaging: Encode/decode the auth_token when pack/unpack message https://review.openstack.org/94881 | 03:35 |
|---|---|---|
| *** shakamunyi has joined #openstack-oslo | 03:43 | |
| *** shakamunyi has quit IRC | 03:53 | |
| *** zhiyan is now known as zhiyan_ | 04:07 | |
| *** shakamunyi has joined #openstack-oslo | 04:19 | |
| *** zhiyan_ is now known as zhiyan | 04:26 | |
| *** shakamunyi has quit IRC | 04:29 | |
| *** shakamunyi has joined #openstack-oslo | 04:55 | |
| *** shakamunyi has quit IRC | 05:05 | |
| *** amotoki has joined #openstack-oslo | 05:18 | |
| openstackgerrit | Zhu Zhu proposed a change to openstack/oslo.messaging: Encode/decode the auth_token when pack/unpack message https://review.openstack.org/94881 | 05:30 |
| *** shakamunyi has joined #openstack-oslo | 05:32 | |
| *** shakamunyi_ has joined #openstack-oslo | 05:37 | |
| *** shakamunyi has quit IRC | 05:39 | |
| *** shakamunyi_ has quit IRC | 05:39 | |
| *** alexizz has joined #openstack-oslo | 05:40 | |
| *** AAzza has joined #openstack-oslo | 06:09 | |
| openstackgerrit | Marc Koderer proposed a change to openstack/oslotest: Add known issue about time.time mocking https://review.openstack.org/95411 | 06:12 |
| *** praneshp has joined #openstack-oslo | 06:27 | |
| *** flaper87|afk is now known as flaper87 | 06:30 | |
| *** asalkeld has joined #openstack-oslo | 06:33 | |
| *** praneshp has quit IRC | 06:38 | |
| *** praneshp has joined #openstack-oslo | 06:39 | |
| *** flaper87 is now known as flaper87|afk | 06:44 | |
| *** zhiyan is now known as zhiyan_ | 06:54 | |
| *** praneshp has quit IRC | 06:56 | |
| openstackgerrit | Zhu Zhu proposed a change to openstack/oslo.messaging: Encode/decode the auth_token when pack/unpack message https://review.openstack.org/94881 | 07:06 |
| *** ihrachyshka has joined #openstack-oslo | 07:09 | |
| *** zhiyan_ is now known as zhiyan | 07:10 | |
| *** ihrachyshka has quit IRC | 07:13 | |
| *** ihrachyshka has joined #openstack-oslo | 07:13 | |
| openstackgerrit | Nataliia Uvarova proposed a change to openstack/oslo-incubator: Fix common.log.ContextFormatter for Python 3 https://review.openstack.org/95439 | 07:15 |
| *** markmcclain has joined #openstack-oslo | 07:23 | |
| *** I159_ has joined #openstack-oslo | 07:24 | |
| *** markmcclain has quit IRC | 07:24 | |
| *** markmcclain has joined #openstack-oslo | 07:31 | |
| *** zhiyan is now known as zhiyan_ | 07:32 | |
| *** praneshp has joined #openstack-oslo | 07:32 | |
| *** zhiyan_ is now known as zhiyan | 07:33 | |
| *** praneshp has quit IRC | 07:34 | |
| *** flaper87|afk is now known as flaper87 | 07:41 | |
| openstackgerrit | garyk proposed a change to openstack/oslo.db: Remove redundant default=None for config options https://review.openstack.org/95443 | 07:41 |
| openstackgerrit | Radoslav Gerganov proposed a change to openstack/oslo.vmware: Add networkFolder in the traversal spec. https://review.openstack.org/95444 | 07:43 |
| openstackgerrit | garyk proposed a change to openstack/oslo-incubator: Remove redundant default=None for config options https://review.openstack.org/95361 | 07:44 |
| *** praneshp has joined #openstack-oslo | 07:46 | |
| *** ruhe has quit IRC | 07:49 | |
| *** nacim has joined #openstack-oslo | 07:54 | |
| *** mkoderer has joined #openstack-oslo | 07:54 | |
| *** ruhe has joined #openstack-oslo | 07:56 | |
| openstackgerrit | Christian Berendt proposed a change to openstack/taskflow: replaced str()/unicode() with six.text_type() https://review.openstack.org/95447 | 07:59 |
| openstackgerrit | Ilya Pekelny proposed a change to openstack/oslo.db: Opportunistic migration tests https://review.openstack.org/93424 | 07:59 |
| *** markmcclain1 has joined #openstack-oslo | 08:01 | |
| *** markmcclain has quit IRC | 08:03 | |
| *** markmcclain1 has quit IRC | 08:04 | |
| openstackgerrit | Ihar Hrachyshka proposed a change to openstack/oslo.messaging: Cleaned up references to executor specific RPCServer types https://review.openstack.org/95450 | 08:06 |
| *** asalkeld has left #openstack-oslo | 08:07 | |
| *** praneshp has quit IRC | 08:11 | |
| *** markmcclain has joined #openstack-oslo | 08:12 | |
| openstackgerrit | Ihar Hrachyshka proposed a change to openstack/oslo-incubator: Enforce unicode json output for jsonutils.load[s]() https://review.openstack.org/91344 | 08:31 |
| *** praneshp has joined #openstack-oslo | 08:38 | |
| openstackgerrit | Julien Danjou proposed a change to openstack/oslo-incubator: fileutils: port to Python 3 https://review.openstack.org/74728 | 08:41 |
| *** viktors|afk is now known as viktors | 08:45 | |
| *** dteselkin has joined #openstack-oslo | 08:46 | |
| openstackgerrit | Radoslav Gerganov proposed a change to openstack/oslo.vmware: Add networkFolder in the traversal spec https://review.openstack.org/95444 | 08:50 |
| *** praneshp has quit IRC | 08:55 | |
| openstackgerrit | Ihar Hrachyshka proposed a change to openstack/oslo-incubator: Add mock cleanup function to each test case https://review.openstack.org/95465 | 09:01 |
| *** alexizz has quit IRC | 09:05 | |
| *** ihrachyshka has quit IRC | 09:13 | |
| *** markmcclain has quit IRC | 09:13 | |
| *** zhiyan is now known as zhiyan_ | 09:35 | |
| openstackgerrit | Yuriy Taraday proposed a change to openstack/oslo-specs: Add rootwrap-daemon-mode blueprint https://review.openstack.org/94613 | 09:37 |
| *** ihrachyshka has joined #openstack-oslo | 10:00 | |
| *** shakamunyi has joined #openstack-oslo | 10:01 | |
| *** shakamunyi has quit IRC | 10:15 | |
| *** shakamunyi has joined #openstack-oslo | 10:33 | |
| *** nacim has quit IRC | 11:11 | |
| openstackgerrit | garyk proposed a change to openstack/oslo-incubator: Remove redundant default=None for config options https://review.openstack.org/95361 | 11:12 |
| openstackgerrit | garyk proposed a change to openstack/oslo.db: Remove redundant default=None for config options https://review.openstack.org/95443 | 11:12 |
| *** boris-42 has quit IRC | 11:13 | |
| ihrachyshka | rpodolyaka: hey! around? | 11:15 |
| *** nacim has joined #openstack-oslo | 11:17 | |
| *** boris-42 has joined #openstack-oslo | 11:24 | |
| rpodolyaka | ihrachyshka: hey! | 11:24 |
| ihrachyshka | rpodolyaka: I wanted to ask you to check unicode related patch at: https://review.openstack.org/91344 | 11:25 |
| rpodolyaka | ihrachyshka: ok, looking | 11:25 |
| ihrachyshka | rpodolyaka: the last time you've checked it you've provided some valuable comments, so wanted to reach to you now that there are significant changes applied | 11:25 |
| *** ihrachyshka_ has joined #openstack-oslo | 11:31 | |
| rpodolyaka | ihrachyshka: done. sorry, can only +1 it :) | 11:32 |
| *** ihrachyshka has quit IRC | 11:34 | |
| ihrachyshka_ | rpodolyaka: it's still valuable, I wanted to check you have no additional suggestions :) | 11:37 |
| rpodolyaka | ihrachyshka_: just one minor nit on using of tearDown(). I'd say it's optional to fix, but oslo cores may disagree | 11:40 |
| *** yamahata has quit IRC | 11:44 | |
| ihrachyshka_ | rpodolyaka: tnx. See also https://review.openstack.org/#/c/95465/ that I've based on top of the patch, probably it handles your concern | 12:02 |
| openstackgerrit | Victor Sergeyev proposed a change to openstack/oslo.db: Remove common context from oslo.db https://review.openstack.org/93397 | 12:03 |
| openstackgerrit | Victor Sergeyev proposed a change to openstack/oslo.db: Remove common context usage from db model_query() https://review.openstack.org/93396 | 12:03 |
| viktors | beekneemech: Ben, is it you? :) | 12:05 |
| *** markmcclain has joined #openstack-oslo | 12:07 | |
| *** I159_ has quit IRC | 12:09 | |
| *** I159_ has joined #openstack-oslo | 12:19 | |
| *** mriedem has joined #openstack-oslo | 12:28 | |
| *** markmcclain has quit IRC | 12:38 | |
| openstackgerrit | Marc Koderer proposed a change to openstack/oslotest: Add unit test for olsotest base class https://review.openstack.org/95516 | 12:38 |
| openstackgerrit | Ihar Hrachyshka proposed a change to openstack/oslo.messaging: Cleaned up references to executor specific RPCServer types https://review.openstack.org/95450 | 12:40 |
| *** yamahata has joined #openstack-oslo | 12:56 | |
| *** shakamunyi has quit IRC | 13:07 | |
| openstackgerrit | Ilya Pekelny proposed a change to openstack/oslo.db: Opportunistic migration tests https://review.openstack.org/93424 | 13:18 |
| openstackgerrit | Ilya Pekelny proposed a change to openstack/oslo.db: Fix the test using in-file SQLite database https://review.openstack.org/93423 | 13:18 |
| *** shakamunyi has joined #openstack-oslo | 13:34 | |
| *** shakamunyi has quit IRC | 13:47 | |
| openstackgerrit | Yuriy Taraday proposed a change to openstack/oslo.rootwrap: Add an option to run rootwrap as a daemon https://review.openstack.org/81798 | 13:47 |
| ihrachyshka_ | can anyone from cores check https://review.openstack.org/#/c/91344/ ? I'd like to proceed with its sync to affected projects, some of them already received the first part of the patch, so we need to make sure they are not left with incomplete implementation | 13:49 |
| *** rpodolyaka has quit IRC | 13:59 | |
| *** rpodolyaka has joined #openstack-oslo | 13:59 | |
| viktors | beekneemech: ping | 13:59 |
| *** ihrachyshka_ is now known as ihrachyshka | 14:02 | |
| *** shakamunyi has joined #openstack-oslo | 14:04 | |
| *** rpodolyaka has quit IRC | 14:07 | |
| *** rpodolyaka has joined #openstack-oslo | 14:09 | |
| *** markmcclain has joined #openstack-oslo | 14:18 | |
| *** erecio has joined #openstack-oslo | 14:18 | |
| *** dims has joined #openstack-oslo | 14:32 | |
| *** dims has quit IRC | 14:53 | |
| *** viktors is now known as viktors|afk | 15:16 | |
| *** shakamunyi has quit IRC | 15:16 | |
| *** markmcclain has quit IRC | 15:26 | |
| *** flaper87 is now known as flaper87|afk | 15:31 | |
| *** ihrachyshka has quit IRC | 15:33 | |
| *** I159_ has quit IRC | 15:43 | |
| *** yamahata has quit IRC | 16:02 | |
| *** yamahata has joined #openstack-oslo | 16:02 | |
| *** HenryG has joined #openstack-oslo | 16:08 | |
| openstackgerrit | Christian Berendt proposed a change to openstack/oslo-incubator: WIP: replace dict.iteritems() with six.iteritems(dict) https://review.openstack.org/95559 | 16:11 |
| openstackgerrit | Christian Berendt proposed a change to openstack/oslo.db: WIP: replace dict.iteritems() with six.iteritems(dict) https://review.openstack.org/95561 | 16:12 |
| *** praneshp has joined #openstack-oslo | 16:18 | |
| *** amotoki has quit IRC | 16:23 | |
| *** HenryG has quit IRC | 16:28 | |
| *** ihrachyshka has joined #openstack-oslo | 16:29 | |
| *** ihrachyshka has quit IRC | 16:33 | |
| *** ihrachyshka has joined #openstack-oslo | 16:34 | |
| *** nacim has quit IRC | 16:49 | |
| *** ihrachyshka has quit IRC | 16:49 | |
| openstackgerrit | Monty Taylor proposed a change to openstack-dev/pbr: Append ChangeLog into the long_description https://review.openstack.org/95569 | 17:53 |
| openstackgerrit | Monty Taylor proposed a change to openstack-dev/pbr: Append ChangeLog into the long_description https://review.openstack.org/95569 | 18:03 |
| openstackgerrit | Monty Taylor proposed a change to openstack-dev/pbr: Append ChangeLog into the long_description https://review.openstack.org/95569 | 18:30 |
| *** praneshp_ has joined #openstack-oslo | 18:33 | |
| *** mriedem has quit IRC | 18:34 | |
| *** praneshp has quit IRC | 18:35 | |
| *** praneshp_ is now known as praneshp | 18:35 | |
| *** ihrachyshka has joined #openstack-oslo | 18:39 | |
| openstackgerrit | Monty Taylor proposed a change to openstack-dev/pbr: Append ChangeLog into the long_description https://review.openstack.org/95569 | 18:42 |
| openstackgerrit | Monty Taylor proposed a change to openstack-dev/pbr: Un-nest some sections of code https://review.openstack.org/95570 | 18:42 |
| ihrachyshka | dhellmann: around? a question re: oslotest | 19:29 |
| dhellmann | hi, ihrachyshka | 19:29 |
| *** flaper87|afk is now known as flaper87 | 19:30 | |
| ihrachyshka | dhellmann: there are PatchObject and Patch classes in the library. Can they be used without BaseTestCase from the same module? | 19:30 |
| ihrachyshka | dhellmann: they set their own mock cleanup functions, but if we assume they are used with module's BaseTestCase, we may set mock.patch.stopall() as a single cleanup function to clean all mocks | 19:31 |
| ihrachyshka | if they are considered as separate entities though, we'll need to leave those per-patch cleanups intact | 19:31 |
| dhellmann | ihrachyshka: I think it is safe to say those fixtures will be used with a testtools class that supports fixtures | 19:32 |
| dhellmann | not every test is going to use those fixtures, which is probably why they are registering cleanups the way they are | 19:33 |
| dhellmann | some tests just use mock.patch() as a decorator, and not as a fixture | 19:33 |
| dhellmann | I'm not sure if that answers your question? | 19:33 |
| ihrachyshka | 'will be used with a testtools class' meaning ANY such class, not this oslotest module's one only | 19:34 |
| ihrachyshka | right? | 19:34 |
| ihrachyshka | the question is to clarify whether it's safe to remove addCleanup(_p.stop) from those objects setUp() | 19:34 |
| dhellmann | ihrachyshka: I don't think there are any cases of openstack code using testtools directly, but I can't be certain | 19:34 |
| dhellmann | why does that matter? | 19:34 |
| dhellmann | no, I would not remove that | 19:35 |
| ihrachyshka | ok, good, that's what I've searched for | 19:35 |
| ihrachyshka | thanks | 19:35 |
| dhellmann | the class is self-contained, right? it sets up the mock, and configures things so that when the test is done the mock is cleaned up | 19:35 |
| ihrachyshka | yes | 19:35 |
| dhellmann | that seems clean and easy to understand | 19:36 |
| ihrachyshka | dhellmann: ok, another question. so I'm going to add that mock.patch.stopall() cleanup function. I'm not sure whether it's possible to add a test case for this change. any ideas? | 19:36 |
| dhellmann | I think you could put a test in a tearDown() method of a test class, after it calls the base class to do the cleanup | 19:37 |
| dhellmann | in setup() save the reference to the thing being mocked; in test() do nothing (you need the method for the test to run); in tearDown() call the base class then verify that the mock is undone | 19:38 |
| ihrachyshka | yeah, indeed! :) | 19:38 |
| dhellmann | that will require a nice big comment explaining why the test is being done in tearDown as a special case :-) | 19:38 |
| dhellmann | oh, you know, you don't need to do it in teardown | 19:39 |
| dhellmann | could you write one test to invoke another? | 19:39 |
| dhellmann | it would be a little more work, but it would be clear what was going on | 19:39 |
| dhellmann | if you define the second test class inside the test method of the first, it won't be run on its own | 19:39 |
| ihrachyshka | probably, thru https://docs.python.org/2/library/unittest.html#unittest.TestSuite | 19:40 |
| dhellmann | sure, that would do it | 19:40 |
| dhellmann | either approach is ok with me, frankly | 19:41 |
| openstackgerrit | Dirk Mueller proposed a change to openstack/oslo-incubator: Fix docstring indentation in systemd https://review.openstack.org/95578 | 19:47 |
| ihrachyshka | dhellmann: hm, when I do 'git review -s', it says 'Project not found: openstack/oslo.test' | 20:09 |
| ihrachyshka | oh, I guess I've fetched the wrong repo :) | 20:09 |
| dhellmann | ihrachyshka: the .gitreview file is broken after the repo was renamed | 20:10 |
| ihrachyshka | hm, no, I've fetched the correct oslotest repo | 20:10 |
| dhellmann | ihrachyshka: https://review.openstack.org/95343 | 20:10 |
| dhellmann | I need to figure out what's wrong with that doc build before I commit that patch, and technically today is supposed to be a holiday here :-) | 20:10 |
| ihrachyshka | dhellmann: tnx | 20:11 |
| openstackgerrit | Ihar Hrachyshka proposed a change to openstack/oslotest: Cleanup mock patches on BaseTestCase tearDown() https://review.openstack.org/95581 | 20:13 |
| ihrachyshka | dhellmann: ^^ BaseTestCase change for mock patches cleanup | 20:13 |
| dhellmann | ihrachyshka: ok, on my review list for tomorrow | 20:14 |
| ihrachyshka | dhellmann: yes, enjoy the holiday ;) | 20:14 |
| openstackgerrit | Christian Berendt proposed a change to openstack/oslo.db: replace dict.iteritems() with six.iteritems(dict) https://review.openstack.org/95561 | 20:18 |
| openstackgerrit | Ihar Hrachyshka proposed a change to openstack/oslotest: Cleanup mock patches on BaseTestCase tearDown() https://review.openstack.org/95581 | 20:21 |
| *** praneshp has quit IRC | 20:42 | |
| *** erecio has quit IRC | 20:46 | |
| *** HenryG has joined #openstack-oslo | 20:50 | |
| *** markmcclain has joined #openstack-oslo | 20:57 | |
| *** yamahata has quit IRC | 20:58 | |
| *** yamahata has joined #openstack-oslo | 20:58 | |
| *** HenryG has quit IRC | 21:04 | |
| *** HenryG has joined #openstack-oslo | 21:06 | |
| *** HenryG has quit IRC | 21:08 | |
| *** HenryG has joined #openstack-oslo | 21:14 | |
| *** AAzza has quit IRC | 21:27 | |
| *** markmcclain has quit IRC | 21:34 | |
| *** markmcclain has joined #openstack-oslo | 21:34 | |
| *** flaper87 is now known as flaper87|afk | 22:05 | |
| -openstackstatus- NOTICE: stopping gerrit briefly to rebuild its search index in an attempt to fix post-rename oddities (will update with notices every 10 minutes until completed) | 22:30 | |
| *** ChanServ changes topic to "stopping gerrit briefly to rebuild its search index in an attempt to fix post-rename oddities (will update with notices every 10 minutes until completed)" | 22:30 | |
| *** ChanServ changes topic to "#openstack-oslo" | 22:36 | |
| openstackgerrit | lifeless proposed a change to openstack-dev/pbr: Allow examining parsing exceptions. https://review.openstack.org/80856 | 22:40 |
| openstackgerrit | lifeless proposed a change to openstack-dev/pbr: Permit pre-release versions with git metadata https://review.openstack.org/80857 | 22:40 |
| openstackgerrit | lifeless proposed a change to openstack-dev/pbr: Teach pbr VersionInfo about debian versions. https://review.openstack.org/81074 | 22:40 |
| openstackgerrit | lifeless proposed a change to openstack-dev/pbr: Teach pbr about post versioned dev versions. https://review.openstack.org/80449 | 22:40 |
| openstackgerrit | lifeless proposed a change to openstack-dev/pbr: Use the current pbr for testpackage tests. https://review.openstack.org/94107 | 22:40 |
| openstackgerrit | lifeless proposed a change to openstack-dev/pbr: Add a converter to version_tuples. https://review.openstack.org/80457 | 22:40 |
| openstackgerrit | lifeless proposed a change to openstack-dev/pbr: Make setUp fail if sdist fails. https://review.openstack.org/94106 | 22:40 |
| openstackgerrit | lifeless proposed a change to openstack-dev/pbr: Break out a common version object from VersionInfo https://review.openstack.org/94108 | 22:40 |
| *** yamahata has quit IRC | 22:45 | |
| *** ihrachyshka has quit IRC | 22:48 | |
| *** markmcclain has quit IRC | 23:08 | |
| *** Guest92477 is now known as redrobot | 23:28 | |
| *** redrobot is now known as Guest41856 | 23:29 | |
| *** Guest41856 is now known as redrobot | 23:30 | |
| *** mrda has joined #openstack-oslo | 23:30 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack-dev/hacking: Updated from global requirements https://review.openstack.org/95608 | 23:48 |
| *** dims has joined #openstack-oslo | 23:52 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!