Tuesday, 2014-05-06

*** dims has joined #openstack-oslo00:24
*** shakamunyi has joined #openstack-oslo01:05
*** zhiyan_ is now known as zhiyan01:15
*** shakayumi has joined #openstack-oslo01:15
*** shakamunyi has quit IRC01:18
*** wingwj has left #openstack-oslo01:26
*** dims has quit IRC01:26
*** arnaud has quit IRC01:55
*** dims has joined #openstack-oslo02:28
*** zhiyan is now known as zhiyan_02:37
*** morganfainberg is now known as morganfainberg_Z02:46
*** praneshp_ has joined #openstack-oslo02:49
*** praneshp has quit IRC02:50
*** praneshp_ is now known as praneshp02:50
*** shakayumi has quit IRC02:58
*** praneshp has quit IRC03:13
*** dims has quit IRC03:17
*** harlowja is now known as harlowja_away03:39
*** harlowja_away is now known as harlowja03:45
openstackgerritJoshua Harlow proposed a change to openstack/taskflow: Add a connection validation check for a .tombstone file  https://review.openstack.org/9228904:17
*** yamahata has quit IRC04:34
*** yamahata has joined #openstack-oslo04:35
*** yamahata has quit IRC04:58
*** yamahata has joined #openstack-oslo04:59
openstackgerritMarc Abramowitz proposed a change to openstack-dev/pbr: pbr/testr_command.py: Add logging  https://review.openstack.org/8920305:15
*** praneshp has joined #openstack-oslo05:20
*** harlowja is now known as harlowja_away05:22
*** praneshp_ has joined #openstack-oslo05:26
*** praneshp has quit IRC05:27
*** praneshp_ is now known as praneshp05:27
*** ttx has quit IRC05:53
*** ttx has joined #openstack-oslo05:57
*** praneshp has quit IRC06:28
*** sileht has quit IRC06:30
*** gcb has joined #openstack-oslo06:33
*** sileht has joined #openstack-oslo06:34
openstackgerritChangBo Guo(gcb) proposed a change to openstack/oslo-incubator: Add check import style hacking in gate  https://review.openstack.org/8783206:44
openstackgerritChangBo Guo(gcb) proposed a change to openstack/oslo-incubator: hacking:assertIsNone should be used when using None with assertEqual  https://review.openstack.org/9230907:00
*** ttx has quit IRC07:03
*** ttx has joined #openstack-oslo07:03
*** flaper87|afk is now known as flaper8707:06
*** bogdando has joined #openstack-oslo07:07
openstackgerritChangBo Guo(gcb) proposed a change to openstack/oslo-incubator: hacking:assertIsNone should be used when using None with assertEqual  https://review.openstack.org/9230907:11
*** ihrachyshka has joined #openstack-oslo07:34
*** nacim has joined #openstack-oslo07:45
ihrachyshkadhellmann: hi, I want to discuss your comment for https://review.openstack.org/#/c/91344/08:18
*** ekarlso has quit IRC08:29
*** ekarlso has joined #openstack-oslo08:29
*** ihrachyshka has quit IRC09:29
*** amotoki has quit IRC09:50
*** morganfainberg_Z has quit IRC09:50
*** markmc has joined #openstack-oslo09:54
*** amotoki has joined #openstack-oslo09:58
*** morganfainberg_Z has joined #openstack-oslo09:59
*** ihrachyshka has joined #openstack-oslo10:29
*** ihrachyshka has quit IRC10:35
*** ihrachyshka has joined #openstack-oslo10:35
*** dims_ has joined #openstack-oslo11:12
*** ihrachyshka has quit IRC11:15
*** ihrachyshka has joined #openstack-oslo11:19
*** dshulyak has quit IRC11:26
*** dshulyak has joined #openstack-oslo11:28
openstackgerritIvan Melnikov proposed a change to openstack/taskflow: Put provides and requires code to basic Flow  https://review.openstack.org/9234611:31
*** ihrachyshka has quit IRC11:31
*** ihrachyshka has joined #openstack-oslo11:32
*** nacim has quit IRC11:39
*** nacim has joined #openstack-oslo11:55
jd__dhellmann: any plan on a new stevedore?12:04
*** dims_ has quit IRC12:27
dhellmannihrachyshka: I replied to your comments12:28
dhellmannjd__: the doc build is broken right now, so I need to get that fixed before releasing12:30
jd__k12:30
*** dims has joined #openstack-oslo12:33
gcbdhellmann: Do we need local hacking for oslo-incubator ? I submit a patch https://review.openstack.org/#/c/87832/ to address your comments12:34
dhellmanngcb: I think in the mailing list thread we agreed the import check was a good idea; I'll put your patch on my review list.12:34
dhellmanngcb: I'm less sure about https://review.openstack.org/#/c/92309/12:35
ihrachyshkadhellmann: tnx a lot, replied12:37
gcbdhellmann: I saw Ben added comments about that while reviewing code,so added there, I'm also not sure :)12:37
gcbdhellmann: I added comments about your bp https://blueprints.launchpad.net/oslo/+spec/pep8-on-update12:38
*** dims has quit IRC12:38
dhellmanngcb: I like your suggestion for implementing the test in that blueprint. Maybe use len(current_longest_name)+2 so we have a little room in case a longer name comes along?12:40
gcbdhellmann: ok ,another query about the update.py, I used patch https://review.openstack.org/#/c/76901/  and found a lot of oslo-incubator files should be removed from consuming projects.12:41
dhellmannremoved?12:42
gcbdhellmann: the files copied from oslo-incubator but not used any more in consuming projects.  but they are left there, became dead files12:43
gcbsee my recently commit for other projects:https://review.openstack.org/#/q/owner:%22ChangBo+Guo%28gcb%29%22+status:open,n,z12:43
gcbdhellmann: so I think the patch for update.py https://review.openstack.org/#/c/76901/ has some value :)12:45
*** dims has joined #openstack-oslo12:45
dhellmanngcb: are you sure those files are not used at all? they aren't dependencies of other oslo modules?12:45
gcbdhellmann: I'm sure , I checked every file , the removing patches passed Jenkins tests , and that prove they are not used by others.12:47
dimsgood morning. sorry i don't have scroll back, which files?12:47
dhellmanngcb: you may have more faith in the test coverage than I do :-)12:48
dhellmanndims: https://review.openstack.org/#/q/owner:%22ChangBo+Guo%28gcb%29%22+status:open,n,z12:48
dhellmanndims: gcb is auditing which files projects are using vs. which they are syncing from the incubator12:48
dhellmannthat would be quite useful to know, especially if it helps make future syncs easier12:48
dimsah very cool12:49
dimsagree12:49
dhellmannI'm just worried that we not jump the gun on removing things12:49
dimstrue12:49
gcbbtw, keystone core reviewers have been discussing  "should use WARNNING or INFO " in https://review.openstack.org/#/c/91825/. I'd like to get more comments :)12:52
gcbagree, we should be careful when removing something.12:53
dhellmanngcb: it is not a mistake for keystone to not list something in openstack-common.conf if they are not using it directly. that's why we added dependency tracking in the first place, to make it easier to get the sync to work right.12:57
gcbagree12:59
dhellmanngcb: so we don't need to update their conf files to include modules they aren't using, but that are needed for other modules they are using13:00
dimsdhellmann, gcb, last i checked there were some files in nova which were basically un-syncable. should they be moved out from openstack/common/ tree?13:02
gcbdhellmann: yes,  I  followed  the rule as you mentioned  in my patches for consuming projects.13:03
dhellmanndims: because nova modified their copies?13:04
*** nacim has quit IRC13:05
dhellmanngcb: in https://review.openstack.org/#/c/91825/ I see a few new modules being added with comments "a dependency of oslo" -- are those used directly by keystone code?13:05
*** nacim has joined #openstack-oslo13:06
gcbThey are not used by keystone directly,  they are used by other oslo-incubators . We have decide not add them in that review13:08
gcbwill offline now , will be back an hour later.13:10
dhellmanngcb: ok13:10
*** gcb has quit IRC13:10
*** mriedem has joined #openstack-oslo13:14
*** jecarey_ has quit IRC13:17
*** erecio has quit IRC13:21
*** erecio has joined #openstack-oslo13:22
*** bknudson has quit IRC13:23
*** nacim has quit IRC13:33
dimsdhellmann, i think it was because oslo changes did not get sync'ed for a while and it became harder to sync13:39
dhellmanndims: ok, that's less troublesome, as long as they are just old versions of what we have in the incubatoro13:39
dhellmannincubatoro?13:40
dhellmanndims: I think I'd rather we try to get them up to date, or just wait for those modules to graduate and move to the libraries -- I'm not sure which is going to be easier for nova to digest13:40
*** gcb has joined #openstack-oslo13:41
openstackgerritMehdi Abaakouk proposed a change to openstack/oslo.messaging: Add transport reconnection retries  https://review.openstack.org/7536513:43
openstackgerritMehdi Abaakouk proposed a change to openstack/oslo.messaging: Transport reconnection retries for notification  https://review.openstack.org/9237313:43
dimsdhellmann, see example - nova/nova/openstack/common/policy.py oslo-incubator/openstack/common/policy.py13:44
*** bknudson has joined #openstack-oslo13:46
dhellmanndims: that diff is a mess, I'll have to study it more closely later. Do you think that's a case where we should just wait for graduation?13:47
dimsdhellmann, yep13:48
dhellmanndims: yeah, if it's going to be painful, let's only do it once :-)13:49
*** nacim has joined #openstack-oslo13:51
dims+1 :)13:52
gcb+113:57
dimsdhellmann, you use a mac?14:02
dhellmanndims: yes14:02
dhellmanndims: although I do all  my openstack dev work on a linux server14:03
dimsdhellmann, do you use brew or macports or fink or something else?14:03
dhellmannhomebrew14:03
dhellmannthere's even a fancy new gui for it, let me find that link14:03
dimscool. thanks!14:03
dhellmanndims: https://www.cakebrew.com/14:03
ihrachyshkadhellmann: yeah, macosx is not a well tested env even to run unit tests14:03
dhellmannihrachyshka: yeah, I don't even bother, too many tools depend on linux behaviors14:04
ihrachyshkadhellmann: yeah, and even 'tox' fails there :)14:04
dimsihrachyshka, there was a patch for fox's _config.py from clarkb that worked for me14:05
dimss/fox/tox/14:05
ihrachyshkadims: same as dhellmann, I don't really care14:05
dhellmannihrachyshka: I use tox for other projects on OS X all the time14:05
ihrachyshkadims: first I have a fedora in a parallels desktop, then I have plenty of servers and workstations in our lab and under my table :)14:06
dhellmannmost of the rest of the work I do runs natively14:06
ihrachyshkadhellmann: maybe some issues with particular tox configurations14:06
ihrachyshkadhellmann: it worked for some openstack projects for me, but not for neutron14:06
dhellmannihrachyshka: could be14:06
dimsihrachyshka, true14:06
ihrachyshkadhellmann: back to that json utf8 'hardcoded encoding' issue. aren't we expanding requirements from what user could expect from json implementation by enforcing utf-8 file source?14:08
dhellmannihrachyshka: I'm not sure I understand the question.14:11
ihrachyshkadhellmann: this is re: https://review.openstack.org/#/c/91344/7/openstack/common/jsonutils.py14:11
ihrachyshkadhellmann: basically, my concern with requiring unicode source is that original, stdlib json module does not enforce it14:12
dhellmannihrachyshka: right. I'm not saying we should require utf-8. I'm saying your change makes that requirement.14:12
ihrachyshkadhellmann: no, it only requires that input is utf-8 compatible, right? which is the same thing stdlib requires.14:13
dhellmannihrachyshka: and what if fp is already returning unicode?14:13
dhellmannthat's also supported by the stdlib, right?14:13
ihrachyshkadhellmann: stdlib json.load() allows file objects that emit bytes14:14
dhellmannah, ok, I thought it handled unicode14:14
ihrachyshkadhellmann: you can apply get reader recursively, it works14:16
dhellmannrecursively?14:16
ihrachyshkadhellmann: like codecs.getreader('utf-8')(codecs.getreader('utf-8')(fp))(fp)14:17
ihrachyshkahem, sorry, broken brackets :)14:18
ihrachyshkacodecs.getreader('utf-8')(codecs.getreader('utf-8')(fp))14:18
ihrachyshkalike that14:18
ihrachyshkafrom json.load() stdlib description: 'If the contents of fp are encoded with an ASCII based encoding other than UTF-8 (e.g. latin-1), then an appropriate encoding name must be specified.'14:18
ihrachyshkaso if encoding is not passed, it must be utf-814:18
ihrachyshkasince we don't have this argument, we may assume everyone passes utf-8 for us14:19
dhellmannI'm not sure that wrapping 2 readers around each other like that really does work properly14:19
dhellmannit might only work for utf-814:19
dhellmannand even then, only the ascii subset14:19
ihrachyshkadhellmann: let me do some tests14:19
*** markmcclain has joined #openstack-oslo14:19
*** jecarey has joined #openstack-oslo14:20
dhellmannihrachyshka: I don't think that just because we don't support specifying an encoding we can assume everyone is passing us a utf-8 stream -- it might just be broken now14:20
ihrachyshkadhellmann: indeed, only ascii subset is handled properly then14:20
ihrachyshkadhellmann: then it's broken on their side (they should have specify the encoding, and then they would see the issue and ask for new argument) :)14:21
ekarlsois o.version o.db rdy for consumption btw?14:21
dhellmannihrachyshka: right, so maybe the fix is to add that argument? :-)14:24
dhellmannekarlso: oslo.version isn't being used by anything, afaict14:24
dhellmannekarlso: and oslo.db is not yet ready for use -- we will announce it on the -dev mailing list when it is14:25
ekarlsodhellmann:14:25
ekarlsook14:25
dhellmannekarlso: you might want to keep an eye on https://wiki.openstack.org/wiki/Oslo/GraduationStatus too14:26
dhellmannand as libs are graduated, we will add them to https://wiki.openstack.org/wiki/Oslo14:26
openstackgerritMehdi Abaakouk proposed a change to openstack/oslo.messaging: Add transport reconnection retries  https://review.openstack.org/7536514:28
openstackgerritMehdi Abaakouk proposed a change to openstack/oslo.messaging: Transport reconnection retries for notification  https://review.openstack.org/9237314:28
*** gcb has quit IRC14:30
*** jecarey_ has joined #openstack-oslo14:31
*** jecarey has quit IRC14:32
ihrachyshkadhellmann: can we at least make this new argument with default value = 'utf-8'?14:38
ihrachyshkadhellmann: if people pass smth incompatible, this will rightfully fail14:39
openstackgerritYuriy Taraday proposed a change to openstack/oslo.rootwrap: Add an option to run rootwrap as a daemon  https://review.openstack.org/8179814:39
dhellmannihrachyshka: what is the default for the stdlib call? utf-8 or None?14:39
ihrachyshkadhellmann: encoding=None14:43
dhellmannihrachyshka: that seems like a good default for us, too, then, no?14:44
ihrachyshkadhellmann: as per JSONDecoder.__init__() inside json.decoder:14:45
ihrachyshka        """``encoding`` determines the encoding used to interpret any ``str``14:45
ihrachyshka        objects decoded by this instance (utf-8 by default).  It has no14:45
ihrachyshka        effect when decoding ``unicode`` objects.14:45
ihrachyshkadhellmann: like 'if encoding is None: fp = codecs.getreader('utf-8')(fp); ...14:46
ihrachyshka?14:46
dhellmannihrachyshka: ok, I'm just confused, so I'm sorry. Maybe if you wrote up a blueprint explaining the arguments for different defaults that would help?14:46
dhellmannihrachyshka: nevermind, there's a bug here isn't there?14:48
dhellmannihrachyshka: I'm just going to need more time to think about it than I have at the moment. :-/14:48
ihrachyshkadhellmann: the bug was revealed by latest sync to glance, though there is no formal LP instance for this14:49
dhellmannihrachyshka: are those details in https://bugs.launchpad.net/oslo/+bug/1314129 somewhere?14:49
ihrachyshkadhellmann: basically, glance uses .load() and it expects that result will contain unicode strings, otherwise it just throw exception :)14:49
ihrachyshkadhellmann: I'll add more details in comments now14:49
dhellmannihrachyshka: ok, thanks14:50
dhellmannihrachyshka: I'll try to take a look tomorrow14:50
ihrachyshkadhellmann: several issues were revealed by actual sync, so this utf8 related fixes are coming from that need.14:50
ihrachyshkagood, moving on for now14:50
*** shakayumi has joined #openstack-oslo14:51
*** jecarey has joined #openstack-oslo14:55
*** jecarey_ has quit IRC14:59
*** zhiyan_ is now known as zhiyan15:01
openstackgerritIhar Hrachyshka proposed a change to openstack/oslo-incubator: Enforce unicode json output for jsonutils.load[s]()  https://review.openstack.org/9134415:25
ihrachyshkadhellmann: I've updated the bug with a comment + uploaded a fresh patch for review to add encoding argument as discussed, plus added a test case to check that the new argument works. so once you get time for this, you can check all that. cheers.15:26
dhellmannihrachyshka: great, thanks for providing those details15:27
*** shakayumi has quit IRC15:31
*** shakamunyi has joined #openstack-oslo15:32
*** ihrachyshka has quit IRC15:36
dimsdhellmann, adding a new parameter to the constructor will break existing stuff right? what's the best way to do this? https://review.openstack.org/#/c/91573/3/oslo/vmware/api.py,unified15:41
*** dims has quit IRC15:46
*** zhiyan is now known as zhiyan_15:47
openstackgerritJakub Libosvar proposed a change to openstack/oslo.config: Introduce Opts for IP addresses  https://review.openstack.org/9239615:47
openstackgerritJakub Libosvar proposed a change to openstack/oslo.config: Introduce Opts for IP addresses  https://review.openstack.org/9239615:52
*** dims has joined #openstack-oslo15:57
*** praneshp has joined #openstack-oslo15:59
openstackgerritMehdi Abaakouk proposed a change to openstack/oslo.messaging: Transport reconnection retries for notification  https://review.openstack.org/9237316:31
openstackgerritMehdi Abaakouk proposed a change to openstack/oslo.messaging: Fix the notify method of the routing notifier  https://review.openstack.org/9240316:31
dhellmanndims: ugly as it is, the best way is to add the new port argument later in the argument list where you can specify a default value -- at the end is the most compatible place, since that allows for all existing args to be used positionally16:32
dhellmanndims: could that class take a URL as arg?16:33
openstackgerritIvan Melnikov proposed a change to openstack/taskflow: (WIP) StateFlow pattern  https://review.openstack.org/9240416:34
openstackgerritJakub Libosvar proposed a change to openstack/oslo.config: Introduce Opts for IP addresses  https://review.openstack.org/9239616:36
openstackgerritMehdi Abaakouk proposed a change to openstack/oslo.messaging: Fix the notify method of the routing notifier  https://review.openstack.org/9240316:37
openstackgerritMehdi Abaakouk proposed a change to openstack/oslo.messaging: Transport reconnection retries for notification  https://review.openstack.org/9237316:37
openstackgerritMehdi Abaakouk proposed a change to openstack/oslo.messaging: Fix the notify method of the routing notifier  https://review.openstack.org/9240316:39
openstackgerritMehdi Abaakouk proposed a change to openstack/oslo.messaging: Transport reconnection retries for notification  https://review.openstack.org/9237316:39
*** markmcclain has quit IRC16:41
*** zhiyan_ is now known as zhiyan16:42
*** shakamunyi has quit IRC16:42
openstackgerritMehdi Abaakouk proposed a change to openstack/oslo.messaging: Fix the notify method of the routing notifier  https://review.openstack.org/9240316:47
openstackgerritMehdi Abaakouk proposed a change to openstack/oslo.messaging: Add transport reconnection retries  https://review.openstack.org/7536516:47
openstackgerritMehdi Abaakouk proposed a change to openstack/oslo.messaging: Transport reconnection retries for notification  https://review.openstack.org/9237316:47
openstackgerritMehdi Abaakouk proposed a change to openstack/oslo.messaging: Fix the notify method of the routing notifier  https://review.openstack.org/9240316:51
openstackgerritMehdi Abaakouk proposed a change to openstack/oslo.messaging: Add transport reconnection retries  https://review.openstack.org/7536516:51
openstackgerritMehdi Abaakouk proposed a change to openstack/oslo.messaging: Transport reconnection retries for notification  https://review.openstack.org/9237316:51
*** zhiyan is now known as zhiyan_16:53
*** nacim has quit IRC16:56
*** harlowja_away is now known as harlowja17:07
*** arnaud__ has joined #openstack-oslo17:18
*** dims has quit IRC17:37
*** morganfainberg_Z is now known as morganfainberg17:45
openstackgerritJakub Libosvar proposed a change to openstack/oslo.config: Introduce Opts for IP addresses  https://review.openstack.org/9239618:05
*** devoid has joined #openstack-oslo18:42
devoidhi guys, I was wondering what you thought of this feature request (obviously I just submitted it so it's fine for you to tell me to go away and be patient) https://bugs.launchpad.net/oslo/+bug/131671118:44
*** markmcclain has joined #openstack-oslo18:54
*** praneshp has quit IRC19:06
*** praneshp has joined #openstack-oslo19:06
*** praneshp has quit IRC19:10
openstackgerritJoshua Harlow proposed a change to openstack/taskflow: Add a new wait() method that waits for jobs to arrive  https://review.openstack.org/9149619:12
*** electrichead_ has joined #openstack-oslo19:16
openstackgerritJoshua Harlow proposed a change to openstack/taskflow: Add a new wait() method that waits for jobs to arrive  https://review.openstack.org/9149619:16
openstackgerritJoe Gordon proposed a change to openstack-dev/hacking: Update pointer to HACKING.rst in the readme  https://review.openstack.org/9244419:26
openstackgerritJoe Gordon proposed a change to openstack-dev/hacking: Add link to readme at bottom of docs.openstack.org/developer/hacking/  https://review.openstack.org/9244519:26
dhellmanndevoid: you might be interested in https://blueprints.launchpad.net/oslo/+spec/service-validation19:33
devoiddhellmann, that looks pretty ambitious to me.19:41
*** dims has joined #openstack-oslo19:52
*** markmcclain1 has joined #openstack-oslo19:57
*** markmcclain2 has joined #openstack-oslo19:59
*** markmcclain has quit IRC19:59
*** markmcclain2 has quit IRC19:59
*** harlowja has quit IRC20:01
*** markmcclain has joined #openstack-oslo20:01
*** markmcclain1 has quit IRC20:02
*** praneshp has joined #openstack-oslo20:03
*** harlowja has joined #openstack-oslo20:04
*** dims_ has joined #openstack-oslo20:39
*** dims has quit IRC20:41
*** jecarey has quit IRC20:45
*** bknudson has quit IRC20:48
*** bknudson has joined #openstack-oslo20:49
*** jecarey has joined #openstack-oslo20:55
morganfainberggcb, dhellmann, i would prefer an INFO vs a WARN (there isn't anything to fix) if we didn't list something in the openstack-common.conf but it's sync'd in due to dependency.20:59
morganfainbergdon't mind communication, just don't see it as an error (i know, bit of a delayed response)20:59
*** harlowja has quit IRC21:05
*** harlowja has joined #openstack-oslo21:12
*** mriedem has quit IRC21:40
*** dims_ has quit IRC21:41
*** redrobot has quit IRC21:55
*** dims has joined #openstack-oslo21:55
*** electrichead_ has quit IRC21:58
*** dims has quit IRC22:15
*** bknudson has quit IRC22:25
*** markmc has quit IRC22:33
*** dims_ has joined #openstack-oslo22:34
*** redrobot has joined #openstack-oslo22:36
*** redrobot is now known as Guest4952522:36
*** Guest49525 is now known as electrichead22:37
*** dims_ has quit IRC22:39
*** dims_ has joined #openstack-oslo22:39
*** dims_ has quit IRC22:56
*** dims_ has joined #openstack-oslo22:57
*** electrichead is now known as redrobot_22:57
*** dims_ has quit IRC22:59
*** dims_ has joined #openstack-oslo23:00
*** dims_ has quit IRC23:08
*** dims has joined #openstack-oslo23:08
*** redrobot_ is now known as redrobot23:20
*** tjones has left #openstack-oslo23:23
*** markmcclain has quit IRC23:27
*** bknudson has joined #openstack-oslo23:40
*** bknudson has left #openstack-oslo23:42
*** yamahata has quit IRC23:45

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!