| *** pvaneck has quit IRC | 00:13 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack-dev/hacking: Add a tool that can fix the import order https://review.openstack.org/68988 | 00:23 |
|---|---|---|
| *** markmcclain has quit IRC | 00:59 | |
| *** _cjones_ has quit IRC | 01:11 | |
| *** rpodolyaka has quit IRC | 01:12 | |
| *** mriedem has quit IRC | 01:12 | |
| *** bknudson has quit IRC | 01:12 | |
| *** harlowja has quit IRC | 01:12 | |
| *** dteselkin has quit IRC | 01:12 | |
| *** harlowja has joined #openstack-oslo | 01:17 | |
| *** rpodolyaka has joined #openstack-oslo | 01:20 | |
| *** mriedem has joined #openstack-oslo | 01:49 | |
| *** bknudson has joined #openstack-oslo | 01:49 | |
| *** dteselkin has joined #openstack-oslo | 01:49 | |
| openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo-incubator: urlsplit issues with IPv6 addresses in python26 https://review.openstack.org/83268 | 01:59 |
| *** harlowja is now known as harlowja_away | 02:19 | |
| *** arnaud has quit IRC | 02:28 | |
| *** harlowja_away is now known as harlowja | 02:37 | |
| *** zhiyan_ is now known as zhiyan | 02:48 | |
| *** mriedem has left #openstack-oslo | 03:17 | |
| *** mriedem has quit IRC | 03:17 | |
| *** harlowja is now known as harlowja_away | 03:47 | |
| *** yamahata has joined #openstack-oslo | 03:51 | |
| *** yamahata has quit IRC | 04:05 | |
| *** russellb has quit IRC | 06:32 | |
| *** yamahata has joined #openstack-oslo | 06:39 | |
| openstackgerrit | Rémi Alvergnat proposed a change to openstack-dev/pbr: Use unicode_literals import instead of u'unicode' notation. https://review.openstack.org/83309 | 07:23 |
| *** russellb has joined #openstack-oslo | 07:47 | |
| *** flaper87|afk is now known as flaper87 | 07:53 | |
| openstackgerrit | Ivan Melnikov proposed a change to openstack/taskflow: tests: Discover absence of zookeeper faster https://review.openstack.org/83311 | 08:01 |
| *** bauzas has joined #openstack-oslo | 08:16 | |
| openstackgerrit | Zhongyue Luo proposed a change to openstack/oslo-incubator: Clean up test_imageutils https://review.openstack.org/78093 | 08:46 |
| openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo-incubator: urlsplit issues with IPv6 addresses in python26 https://review.openstack.org/83268 | 10:28 |
| *** flaper87 is now known as flaper87|afk | 10:48 | |
| *** yamahata has quit IRC | 11:07 | |
| openstackgerrit | Anastasia Karpinska proposed a change to openstack/taskflow: Move 'inputs and outputs' to developers docs https://review.openstack.org/83010 | 11:11 |
| *** morganfainberg is now known as morganfainberg_Z | 11:19 | |
| openstackgerrit | Ivan Melnikov proposed a change to openstack/taskflow: Fix race condition in result processing in worker-based executor https://review.openstack.org/83346 | 11:26 |
| openstackgerrit | Ivan Melnikov proposed a change to openstack/taskflow: Fix race condition in result processing in worker-based executor https://review.openstack.org/83346 | 11:29 |
| ihrachys | dhellmann_: can we consider this for stable incubator? https://review.openstack.org/#/c/83085/ , https://review.openstack.org/#/c/83086/ | 12:17 |
| *** rpodolyaka has quit IRC | 12:36 | |
| *** mriedem has joined #openstack-oslo | 12:45 | |
| openstackgerrit | Anastasia Karpinska proposed a change to openstack/taskflow: Move 'inputs and outputs' to developers docs https://review.openstack.org/83010 | 12:48 |
| *** dims_ has quit IRC | 12:52 | |
| *** bknudson has quit IRC | 12:58 | |
| *** dims_ has joined #openstack-oslo | 13:05 | |
| *** markmcclain has joined #openstack-oslo | 13:08 | |
| *** flaper87|afk is now known as flaper87 | 13:11 | |
| *** bknudson has joined #openstack-oslo | 13:18 | |
| openstackgerrit | Anastasia Karpinska proposed a change to openstack/taskflow: Move 'inputs and outputs' to developers docs https://review.openstack.org/83010 | 13:24 |
| *** yamahata has joined #openstack-oslo | 13:36 | |
| *** zaneb has quit IRC | 13:42 | |
| *** zaneb has joined #openstack-oslo | 13:42 | |
| *** dteselkin has quit IRC | 13:49 | |
| *** dteselkin has joined #openstack-oslo | 13:50 | |
| *** dims_ is now known as dims | 14:28 | |
| *** dims is now known as Guest68499 | 14:28 | |
| *** Guest68499 has quit IRC | 14:29 | |
| *** dims_ has joined #openstack-oslo | 14:29 | |
| openstackgerrit | Doug Hellmann proposed a change to openstack/oslo-incubator: Support copying scripts outside of modules https://review.openstack.org/83411 | 14:57 |
| openstackgerrit | Doug Hellmann proposed a change to openstack/oslo-incubator: Script for running unit tests in other projects https://review.openstack.org/83412 | 14:57 |
| openstackgerrit | Ilya Pekelny proposed a change to openstack/oslo-incubator: Add a base test case for DB schema comparison https://review.openstack.org/74081 | 15:01 |
| openstackgerrit | Doug Hellmann proposed a change to openstack/oslo-incubator: Support copying scripts outside of modules https://review.openstack.org/83411 | 15:01 |
| openstackgerrit | Doug Hellmann proposed a change to openstack/oslo-incubator: Script for running unit tests in other projects https://review.openstack.org/83412 | 15:01 |
| openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.test: Import run_cross_tests.sh from oslo-incubator https://review.openstack.org/83415 | 15:03 |
| openstackgerrit | Doug Hellmann proposed a change to openstack/cliff: Import run_cross_tests.sh from oslo-incubator https://review.openstack.org/83421 | 15:10 |
| *** dhellmann_ is now known as dhellmann | 15:21 | |
| openstackgerrit | Ilya Pekelny proposed a change to openstack/oslo-incubator: Add a base test case for DB schema comparison https://review.openstack.org/74081 | 15:28 |
| openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo-incubator: urlsplit issues with IPv6 addresses in python26 https://review.openstack.org/83268 | 15:29 |
| dims_ | bnemec, ping | 15:36 |
| dims_ | bnemec, i saw that usage in swift - https://github.com/openstack/swift/blob/master/swift/common/utils.py#L1885 | 15:37 |
| bnemec | dims_: That was actually dhellmann's question ;-) | 15:37 |
| bnemec | Oh, so this is actually copied from Swift. | 15:38 |
| dims_ | swift was urlparse, the one i have is urlsplit | 15:39 |
| dims_ | but the pattern is the same | 15:39 |
| dims_ | and i reused methods we already had in network_utils.py | 15:39 |
| bnemec | Oh, yeah, I see now. not exactly the same. | 15:39 |
| dims_ | am no python expert. i am a java guy. so i have no clue :) | 15:40 |
| bnemec | Wow, that import is *ahem* difficult to parse: https://github.com/openstack/swift/blob/master/swift/common/utils.py#L49 | 15:41 |
| bnemec | Suddenly I remember why I'm onboard with all of our import hacking rules. | 15:41 |
| dims_ | lol | 15:42 |
| bnemec | dims_: I think dhellmann is right. The reason they had to do that is urlparse() doesn't take params, it takes a single string. | 15:44 |
| bnemec | http://docs.python.org/2/library/urlparse.html#urlparse.urlparse | 15:44 |
| bnemec | Passing the params directly to your new class should work fine. It's going to call the exact same constructor. | 15:45 |
| dhellmann | yeah, the ParseResult is a namedtuple, which is being expanded by the * and so you're just passing the input arguments through it on to the new class | 15:46 |
| dhellmann | so unless the constructor of ParseResult does something with the values, it doesn't seem to be needed | 15:47 |
| dims_ | dhellmann, thanks, will rework | 15:47 |
| dhellmann | I'm planning to cut a new pbr release today when https://review.openstack.org/#/c/83309/ lands so we can stop breaking installation of libs on systems with pip < 1.4 | 15:48 |
| dhellmann | bnemec: regarding ihrachys' stable/havana changes in oslo-incubator, you gave a +1 -- do you not have +2 on the stable branch? | 15:51 |
| bnemec | dhellmann: No, I don't. | 15:52 |
| openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo-incubator: urlsplit issues with IPv6 addresses in python26 https://review.openstack.org/83268 | 15:52 |
| ihrachys | yeah, that's a shame! :) | 15:52 |
| dhellmann | bnemec: ok, I'll take your +1 as a +2 | 15:53 |
| dhellmann | ah, jd__ approved them :-) | 15:53 |
| bnemec | :-) | 15:53 |
| ihrachys | dhellmann: yes, I've pinged him today, and he was kind to check them | 15:54 |
| openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo-incubator: urlsplit issues with IPv6 addresses in python26 https://review.openstack.org/83268 | 15:55 |
| dhellmann | ihrachys: do you have anything else pending review for stable? | 15:55 |
| bnemec | I should probably just give in and subscribe to the stable ML and ask for +2, but there's already so much I'm supposed to review. ;-) | 15:55 |
| ihrachys | dhellmann: oslo-incubator? no, only those two patches. | 15:55 |
| dhellmann | ihrachys: ok, good | 15:56 |
| dhellmann | dims_: looking at that ModifiedSplitResult again, I wonder, does that work if the hostname or port are accessed using the tuple index instead of the property name? does it need to? | 15:57 |
| ihrachys | btw thank you all for reviews and +2s, sometimes I'm a pain in the ass begging for comments... | 15:57 |
| dhellmann | ihrachys: nah, sorry you have to keep pestering -- I have too many irons in the fire right now :-) | 15:57 |
| ihrachys | easy to imagine :) | 15:58 |
| dhellmann | dims_: I wonder if that extra logic should just be applied in urlsplit() directly, rather than introducing the new class | 15:58 |
| dhellmann | brb | 15:59 |
| dims_ | dhellmann, when you get a chance take a peek at urlparse.py (https://sourcegraph.com/hg.python.org/cpython/tree/b0866382064f/Lib/urlparse.py#L127) | 16:02 |
| dims_ | that's the newer one that works fine with ipv6 urls | 16:03 |
| dims_ | this is the older one that breaks - http://pythoninside.com/en/source-code/2.6.8/urlparse/urlparse.py | 16:04 |
| dims_ | back in a bit | 16:05 |
| *** viktors has joined #openstack-oslo | 16:09 | |
| *** dims_ has quit IRC | 16:10 | |
| *** dshulyak has quit IRC | 16:11 | |
| *** dshulyak has joined #openstack-oslo | 16:11 | |
| *** zhiyan is now known as zhiyan_ | 16:16 | |
| *** zhiyan_ is now known as zhiyan | 16:16 | |
| jd__ | . | 16:24 |
| *** dims_ has joined #openstack-oslo | 16:25 | |
| *** tvardeman has joined #openstack-oslo | 16:26 | |
| openstackgerrit | Jenkins proposed a change to openstack-dev/pbr: Updated from global requirements https://review.openstack.org/83468 | 16:30 |
| *** bauzas has quit IRC | 16:38 | |
| *** harlowja_away is now known as harlowja | 17:08 | |
| openstackgerrit | Doug Hellmann proposed a change to openstack/stevedore: Only log error when no load handler is set https://review.openstack.org/83509 | 17:24 |
| *** morganfainberg_Z is now known as morganfainberg | 17:26 | |
| *** dims_ has quit IRC | 17:32 | |
| *** zhiyan is now known as zhiyan_ | 17:40 | |
| *** dims_ has joined #openstack-oslo | 17:47 | |
| *** arnaud has joined #openstack-oslo | 17:51 | |
| *** dims_ has quit IRC | 17:57 | |
| *** bauzas has joined #openstack-oslo | 18:04 | |
| *** dims has joined #openstack-oslo | 18:11 | |
| *** flaper87 is now known as flaper87|afk | 18:13 | |
| *** tvardeman has quit IRC | 18:55 | |
| *** bauzas has quit IRC | 19:07 | |
| bnemec | dhellmann: Looking at setting up unit testing in a couple more of the tripleo projects. Should I go ahead and use oslotest? | 19:25 |
| bnemec | Maybe I should add them to the cross-testing list? | 19:25 |
| dhellmann | bnemec: using oslo.test? | 19:25 |
| bnemec | dhellmann: That's what I'd like to do. | 19:26 |
| dhellmann | bnemec: great, yes, add the job before incorporating the library | 19:26 |
| bnemec | dhellmann: Cool, will do. | 19:26 |
| dhellmann | bnemec: although you'll need that incubator version of the cross-test script to land so you can import it before the job will work | 19:27 |
| * dhellmann needs to add this to the new lib instructions | 19:27 | |
| *** GheRivero has quit IRC | 19:28 | |
| bnemec | dhellmann: Hmm, so we're going to have to sync that to every project that uses oslo.test? | 19:29 |
| * bnemec forgets how all the cross-testing mechanics work | 19:30 | |
| dhellmann | bnemec: sorry, no, I misled you -- I was thinking about a *new* library | 19:32 |
| dhellmann | you can add a job using oslotest now without any other code changes | 19:32 |
| bnemec | dhellmann: Ah, got it. Yeah, these projects won't need cross-testing of their own. | 19:33 |
| bnemec | dhellmann: Thanks | 19:33 |
| openstackgerrit | Doug Hellmann proposed a change to openstack/stevedore: Import run_cross_tests.sh from oslo-incubator https://review.openstack.org/83550 | 19:43 |
| *** GheRivero has joined #openstack-oslo | 19:46 | |
| dims | dhellmann, bnemec - do we have a template of a commit message that i can use? am looking at syncing python-novaclient | 19:47 |
| openstackgerrit | Doug Hellmann proposed a change to openstack-dev/oslo-cookiecutter: Sync cross-test script https://review.openstack.org/83555 | 19:47 |
| dhellmann | dims: ? | 19:48 |
| dhellmann | oh, for adding oslotest to nova client? | 19:49 |
| dhellmann | I would have to look at the commit message from oslo.messaging to see if that could be reused | 19:49 |
| dims | no running update.sh against python-novaclient | 19:49 |
| dhellmann | dims: oh, no, I don't think we've established a standard for that other than just listing the commits | 20:00 |
| dhellmann | although figuring out that list is non-trivial | 20:00 |
| *** harlowja is now known as harlowja_away | 20:03 | |
| openstackgerrit | Trevor Vardeman proposed a change to openstack/oslo-incubator: Removed unneeded #noqa tag https://review.openstack.org/83570 | 20:14 |
| openstackgerrit | Gauvain Pocentek proposed a change to openstack/oslo-incubator: generator: sanitize values ending with the fqdn https://review.openstack.org/83571 | 20:15 |
| openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo-incubator: urlsplit issues with IPv6 addresses in python26 https://review.openstack.org/83268 | 20:18 |
| *** harlowja_away is now known as harlowja | 20:35 | |
| *** zaneb has quit IRC | 20:45 | |
| *** dims has quit IRC | 21:28 | |
| harlowja | dhellmann when do u think a new pbr release can be expected (that relaxes that 1.4 requirement) | 21:29 |
| openstackgerrit | Ben Nemec proposed a change to openstack/oslo-incubator: Add test case for config generator hostname check https://review.openstack.org/83594 | 21:32 |
| *** dims has joined #openstack-oslo | 21:43 | |
| dhellmann | harlowja: was just waiting for a change to merge | 22:01 |
| harlowja | k, np | 22:01 |
| * dhellmann checks the status | 22:01 | |
| harlowja | the guy working on CI said that hoepfully we can plugin anvil to the upstream CI this quarter (lets see if it really happens, haha) | 22:01 |
| harlowja | as a non-voting system | 22:01 |
| harlowja | *working on CI @ y! | 22:01 |
| harlowja | seems like it can catch things that devstack can't so thats good | 22:02 |
| dhellmann | nice | 22:02 |
| *** yamahata has quit IRC | 22:06 | |
| dhellmann | harlowja: pbr 0.8.0 released | 22:09 |
| harlowja | woot | 22:09 |
| harlowja | ok, firing off job | 22:09 |
| openstackgerrit | Doug Hellmann proposed a change to openstack/oslo-incubator: Script for running unit tests in other projects https://review.openstack.org/83412 | 22:17 |
| openstackgerrit | Doug Hellmann proposed a change to openstack/oslo-incubator: Support copying scripts outside of modules https://review.openstack.org/83411 | 22:20 |
| openstackgerrit | Doug Hellmann proposed a change to openstack/oslo-incubator: Script for running unit tests in other projects https://review.openstack.org/83412 | 22:20 |
| *** bknudson has quit IRC | 22:30 | |
| harlowja | k, dhellmann seems ok, no more cliff build failing | 22:33 |
| dhellmann | harlowja: \o/ | 22:33 |
| harlowja | ya, although its always interesting to see what anvil starts sucking in and building, lol | 22:33 |
| harlowja | http://paste.openstack.org/show/74506/ | 22:34 |
| harlowja | 'Full known python dependency list' is the initial list and then extra stuff gets sucked in by pip when downloading those deps | 22:34 |
| harlowja | somehow pip==1.5.4 gets sucked down | 22:34 |
| harlowja | anyways, found a new anvil bug (trying to build rpms with nova.conf.sample, which no longer exists) | 22:36 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Set logbook/flowdetail/atomdetail meta to empty dict https://review.openstack.org/82944 | 22:37 |
| dhellmann | harlowja: I think there's a tox env for building that config file | 22:40 |
| dhellmann | harlowja: it came up recently on the ML | 22:40 |
| harlowja | hmmm, might have to try that out | 22:41 |
| harlowja | guess its called tox -egenconfig | 22:46 |
| harlowja | although thats odd in that it requires a venv | 22:46 |
| harlowja | when everythings a package, probably don't need a venv | 22:46 |
| harlowja | will figure that one out | 22:54 |
| *** mriedem has left #openstack-oslo | 22:58 | |
| *** markmcclain has quit IRC | 23:14 | |
| *** hartsocks has quit IRC | 23:50 | |
| *** hartsocks has joined #openstack-oslo | 23:50 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!