| *** markmcclain has joined #openstack-oslo | 00:21 | |
| *** rpodolyaka1 has joined #openstack-oslo | 00:23 | |
| *** markmcclain1 has joined #openstack-oslo | 00:24 | |
| *** markmcclain has quit IRC | 00:26 | |
| *** rpodolyaka1 has quit IRC | 00:27 | |
| *** banix has quit IRC | 00:28 | |
| *** gcb has joined #openstack-oslo | 01:02 | |
| *** harlowja_at_home has quit IRC | 01:19 | |
| *** markmcclain1 has quit IRC | 01:19 | |
| *** rpodolyaka1 has joined #openstack-oslo | 01:23 | |
| *** rpodolyaka1 has quit IRC | 01:28 | |
| *** banix has joined #openstack-oslo | 01:31 | |
| openstackgerrit | ChangBo Guo(gcb) proposed a change to openstack/oslo.messaging: Refactor AMQP message broker selection https://review.openstack.org/81183 | 01:44 |
|---|---|---|
| openstackgerrit | ChangBo Guo(gcb) proposed a change to openstack/oslo.messaging: Select AMQP message broker at random https://review.openstack.org/81962 | 01:56 |
| *** mriedem has quit IRC | 02:00 | |
| *** mriedem has joined #openstack-oslo | 02:13 | |
| *** rpodolyaka1 has joined #openstack-oslo | 02:24 | |
| *** rpodolyaka1 has quit IRC | 02:28 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add a timeout object that can be interrupted https://review.openstack.org/81971 | 02:51 |
| *** mriedem has left #openstack-oslo | 03:09 | |
| *** mriedem has quit IRC | 03:10 | |
| *** rpodolyaka1 has joined #openstack-oslo | 03:25 | |
| *** rpodolyaka1 has quit IRC | 03:29 | |
| *** banix has quit IRC | 03:33 | |
| *** gcb has quit IRC | 03:37 | |
| *** gcb has joined #openstack-oslo | 03:41 | |
| *** zhiyan_ is now known as zhiyan | 03:50 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add a timeout object that can be interrupted https://review.openstack.org/81971 | 04:04 |
| *** rpodolyaka1 has joined #openstack-oslo | 04:26 | |
| *** rpodolyaka1 has quit IRC | 04:30 | |
| *** gcb_ has joined #openstack-oslo | 04:32 | |
| *** gcb has quit IRC | 04:34 | |
| *** gcb_ has quit IRC | 04:35 | |
| *** gcb_ has joined #openstack-oslo | 04:38 | |
| *** morganfainberg is now known as morganfainberg_Z | 04:39 | |
| *** morganfainberg_Z is now known as morganfainberg | 04:44 | |
| *** arnaud has joined #openstack-oslo | 04:53 | |
| *** arnaud__ has quit IRC | 04:53 | |
| openstackgerrit | Yuriy Taraday proposed a change to openstack/oslo.rootwrap: Add an option to run rootwrap as a daemon https://review.openstack.org/81798 | 05:01 |
| *** rpodolyaka1 has joined #openstack-oslo | 05:25 | |
| *** arnaud has quit IRC | 05:25 | |
| *** arnaud has joined #openstack-oslo | 05:26 | |
| *** rpodolyaka1 has quit IRC | 05:30 | |
| *** rpodolyaka1 has joined #openstack-oslo | 05:31 | |
| *** norman has joined #openstack-oslo | 06:36 | |
| *** norman has quit IRC | 06:36 | |
| *** norman has joined #openstack-oslo | 06:37 | |
| *** rpodolyaka1 has quit IRC | 06:46 | |
| openstackgerrit | Ivan Melnikov proposed a change to openstack/taskflow: Iteration over links in flow interface https://review.openstack.org/80942 | 07:11 |
| *** arnaud has quit IRC | 07:40 | |
| *** norman has quit IRC | 08:06 | |
| *** flaper87|afk is now known as flaper87 | 08:07 | |
| *** rpodolyaka1 has joined #openstack-oslo | 08:14 | |
| *** I159_ has joined #openstack-oslo | 08:17 | |
| openstackgerrit | Ivan Melnikov proposed a change to openstack/taskflow: Drop obsolete test_unordered_flow https://review.openstack.org/82024 | 08:18 |
| *** rpodolyaka1 has quit IRC | 08:18 | |
| *** gcb_ has quit IRC | 08:52 | |
| *** ihrachys is now known as ihrachys|wfh|tax | 08:55 | |
| openstackgerrit | Ivan Melnikov proposed a change to openstack/taskflow: Drop indexing operator from linear flow https://review.openstack.org/82034 | 09:12 |
| *** gcb has joined #openstack-oslo | 09:14 | |
| openstackgerrit | ChangBo Guo(gcb) proposed a change to openstack/oslo-incubator: Add module integrity check in update.py https://review.openstack.org/76901 | 09:25 |
| *** morganfainberg is now known as morganfainberg_Z | 09:48 | |
| *** rpodolyaka1 has joined #openstack-oslo | 10:15 | |
| *** rpodolyaka1 has quit IRC | 10:19 | |
| openstackgerrit | Ivan Melnikov proposed a change to openstack/taskflow: Linear flow: mark links and rework unit tests https://review.openstack.org/82050 | 10:33 |
| *** rpodolyaka1 has joined #openstack-oslo | 11:16 | |
| *** rpodolyaka1 has quit IRC | 11:20 | |
| openstackgerrit | Ivan Melnikov proposed a change to openstack/taskflow: Unit tests for unordered flow https://review.openstack.org/82072 | 11:29 |
| *** banix has joined #openstack-oslo | 12:15 | |
| *** rpodolyaka1 has joined #openstack-oslo | 12:16 | |
| *** rpodolyaka1 has quit IRC | 12:20 | |
| *** mriedem has joined #openstack-oslo | 12:23 | |
| openstackgerrit | Yuriy Taraday proposed a change to openstack/oslo.rootwrap: Add an option to run rootwrap as a daemon https://review.openstack.org/81798 | 12:38 |
| *** russellb is now known as rustlebee | 12:40 | |
| *** dims has quit IRC | 12:41 | |
| *** dims has joined #openstack-oslo | 12:48 | |
| *** ihrachys|wfh|tax is now known as ihrachys|wfh | 12:52 | |
| *** banix has quit IRC | 13:00 | |
| *** rpodolyaka1 has joined #openstack-oslo | 13:17 | |
| openstackgerrit | Ivan Melnikov proposed a change to openstack/taskflow: Rework graph flow unit tests https://review.openstack.org/82086 | 13:18 |
| *** rpodolyaka1 has quit IRC | 13:20 | |
| *** bknudson has joined #openstack-oslo | 13:25 | |
| openstackgerrit | Ivan Melnikov proposed a change to openstack/taskflow: (WIP) Flattening improvements https://review.openstack.org/82091 | 13:29 |
| *** hartsocks is now known as hartbot | 13:31 | |
| *** markmcclain has joined #openstack-oslo | 13:59 | |
| *** banix has joined #openstack-oslo | 14:01 | |
| *** markmcclain1 has joined #openstack-oslo | 14:02 | |
| *** markmcclain has quit IRC | 14:03 | |
| *** markmcclain1 has quit IRC | 14:07 | |
| *** markmcclain has joined #openstack-oslo | 14:10 | |
| ihrachys|wfh | gcb: ping re random choice of broker in amqp | 14:12 |
| *** rpodolyaka1 has joined #openstack-oslo | 14:18 | |
| *** rpodolyaka1 has quit IRC | 14:22 | |
| *** markmcclain has quit IRC | 14:25 | |
| *** dhellmann_ is now known as dhellmann | 14:33 | |
| dhellmann | bnemec: +2a on https://review.openstack.org/#/c/78628/ (I was off yesterday) | 14:40 |
| bnemec | dhellmann: Thanks! | 14:41 |
| *** bnemec is now known as beekneemech | 14:41 | |
| ihrachys|wfh | dhellmann: have you seen that test_executor failure? | 14:42 |
| dhellmann | ihrachys|wfh: I did see your message. Looking at the test report doesn't tell me much. Are we seeing that failure on other patches? | 14:43 |
| ihrachys|wfh | dhellmann: not that I aware of it | 14:44 |
| ihrachys|wfh | dhellmann: I've seen this once only in your review. | 14:44 |
| ihrachys|wfh | dhellmann: but it looks that assumptions made in this unit test are not correct (having only single greenthread to switch to on .sleep(0)) | 14:45 |
| dhellmann | ihrachys|wfh: is there some way for me to get to the patch in gerrit from the link you posted to the test results? | 14:45 |
| ihrachys|wfh | dhellmann: https://review.openstack.org/#/c/77273/ | 14:45 |
| ihrachys|wfh | it's your patch :) | 14:45 |
| ihrachys|wfh | I just base my work on this | 14:45 |
| dhellmann | ihrachys|wfh: you might be right about the bad test assumptions | 14:46 |
| ihrachys|wfh | dhellmann: ...but since it's not reproducible, it's hard to be sure | 14:49 |
| dhellmann | it looks like cinder is giving up on oslo.messaging for this cycle? https://review.openstack.org/#/c/81870/ | 14:49 |
| ihrachys|wfh | :( | 14:50 |
| *** zhiyan is now known as zhiyan_ | 14:52 | |
| ihrachys|wfh | dhellmann: it's not clear where this unexpected greenthread came from though. | 14:53 |
| dhellmann | ihrachys|wfh: could you open a bug with the details you have? I have another issue I'm tracking atm, but we should start collecting data and rechecks for this | 14:55 |
| ihrachys|wfh | dhellmann: ok | 14:57 |
| ihrachys|wfh | dhellmann: ha! there's one https://bugs.launchpad.net/oslo.messaging/+bug/1282706 | 14:59 |
| openstackgerrit | Monty Taylor proposed a change to openstack/oslo.rootwrap: Don't use system pip things in tox https://review.openstack.org/82117 | 14:59 |
| openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.rootwrap: Don't use system pip things in tox https://review.openstack.org/82117 | 15:03 |
| ihrachys|wfh | dhellmann: is there a way to wait for all greenthreads to complete? if so, we could do it prior to running the test... | 15:03 |
| dhellmann | ihrachys|wfh: I don't think we want tests blocking like that. What is the test trying to verify? That exactly one thread is created, or that one more than used to be there is created? Or that a thread is used? Can we rewrite the test to check that condition in a different way? | 15:04 |
| openstackgerrit | Monty Taylor proposed a change to openstack/oslo.rootwrap: Don't use system pip things in tox https://review.openstack.org/82117 | 15:06 |
| ihrachys|wfh | dhellmann: i think we try to check that greenthread is actually scheduled to spawn, and it completed. | 15:06 |
| dhellmann | ihrachys|wfh: that seems like something we could do with a mock, no? | 15:09 |
| ihrachys|wfh | dhellmann: seems yes; ok, I'll try the approach now. | 15:12 |
| dhellmann | ihrachys|wfh: thanks! | 15:12 |
| *** rpodolyaka1 has joined #openstack-oslo | 15:18 | |
| *** rpodolyaka1 has quit IRC | 15:20 | |
| *** hartbot has quit IRC | 15:48 | |
| *** hartsocks has joined #openstack-oslo | 15:51 | |
| *** hartsocks has quit IRC | 15:53 | |
| *** hartsocks has joined #openstack-oslo | 15:53 | |
| *** arnaud__ has joined #openstack-oslo | 15:57 | |
| *** arnaud__ has quit IRC | 16:04 | |
| *** arnaud has joined #openstack-oslo | 16:04 | |
| *** bogdando has quit IRC | 16:07 | |
| *** markmcclain has joined #openstack-oslo | 16:10 | |
| *** gcb has quit IRC | 16:11 | |
| *** markmcclain has quit IRC | 16:15 | |
| *** rpodolyaka1 has joined #openstack-oslo | 16:19 | |
| *** rpodolyaka1 has quit IRC | 16:23 | |
| *** gcb has joined #openstack-oslo | 16:24 | |
| bknudson | is there a no-op rpc_backend? | 16:32 |
| *** anteaya is now known as cyan | 16:36 | |
| openstackgerrit | Yuriy Taraday proposed a change to openstack/oslo.rootwrap: Add an option to run rootwrap as a daemon https://review.openstack.org/81798 | 16:36 |
| *** cyan is now known as Guest20064 | 16:36 | |
| *** Guest20064 is now known as anteaya-who-was- | 16:37 | |
| *** anteaya-who-was- is now known as anteaya | 16:37 | |
| dhellmann | bknudson: there's a fake driver in oslo.messaging, if that's what you mean | 16:53 |
| bknudson | dhellmann: that might be what I'm looking for. I'll give it a try | 16:56 |
| *** I159_ has quit IRC | 17:00 | |
| ihrachys|wfh | dhellmann: on second thought, it does not look like mocking eventlet is enough. The executor test requires that scheduled thread is actually run, and all eventlet mechanics is done (like calling .__exit__). So it's not just about capturing arguments of eventlet.spawn() | 17:01 |
| ttx | dhellmann: would you agree with my comment on https://review.openstack.org/#/c/72093/ ? Just making sure i'm not crazy before uploading a "fix" for it | 17:02 |
| dhellmann | ttx: looking | 17:02 |
| ttx | trying to get it all in for depfreeze | 17:05 |
| ttx | but Dirk is a bit slow on patch updates right now | 17:05 |
| dhellmann | ttx: yes, you're right, that's the wrong expression | 17:16 |
| ttx | ok pushing fix then | 17:18 |
| openstackgerrit | Thierry Carrez proposed a change to openstack/oslo.rootwrap: Avoid matching ip -s netns exec in IpFilter https://review.openstack.org/72093 | 17:18 |
| ttx | that one would have introduced a rather subtle flaw in that filter | 17:19 |
| *** rpodolyaka1 has joined #openstack-oslo | 17:19 | |
| ttx | dhellmann: feel free to +2/APRV it later in the day if tests pass -- i'm about to call it a week | 17:20 |
| dhellmann | ttx: I'll keep an eye on it; have a good weekend! | 17:20 |
| ttx | Will tag oslo.rootwrap on Monday if hell didn't freeze over the weekend | 17:20 |
| * dhellmann crosses his fingers for a heat-wave | 17:20 | |
| ttx | We had 75°F yesterday. | 17:21 |
| ttx | (France, not Florida) | 17:21 |
| dhellmann | just a few degrees warmer than here | 17:23 |
| ttx | and now I see you were not speaking literally | 17:24 |
| *** rpodolyaka1 has quit IRC | 17:24 | |
| *** dshulyak has quit IRC | 17:25 | |
| beekneemech | dhellmann: Do you have any thoughts on https://review.openstack.org/#/c/81412/1 | 17:42 |
| beekneemech | I'm not really sure what the current best practices for oslo.config are. | 17:43 |
| * beekneemech should probably change that | 17:43 | |
| *** jroll is now known as jimmyjohns | 17:45 | |
| openstackgerrit | Ihar Hrachyshka proposed a change to openstack/oslo.messaging: Fixed inconsistent EventletContextManagerSpawnTest failures https://review.openstack.org/82151 | 18:01 |
| ihrachys|wfh | dhellmann: I've applied a bit different approach fixing the executor test failure: https://review.openstack.org/#/c/82151/ | 18:07 |
| openstackgerrit | Ihar Hrachyshka proposed a change to openstack/oslo.messaging: Fixed inconsistent EventletContextManagerSpawnTest failures https://review.openstack.org/82151 | 18:09 |
| *** morganfainberg_Z is now known as morganfainberg | 18:11 | |
| *** rpodolyaka1 has joined #openstack-oslo | 18:20 | |
| *** rpodolyaka1 has quit IRC | 18:24 | |
| *** beav has joined #openstack-oslo | 18:26 | |
| dhellmann | beekneemech: looking | 18:27 |
| dhellmann | beekneemech: it seems like those options should be registered in one group (not the default) and that the memorycache module should "own" the name of that group, not keystone client -- do you know why keystoneclient is registering them itself? | 18:29 |
| beekneemech | dhellmann: No idea. Maybe we should deprecate the keystoneclient one? | 18:31 |
| dhellmann | beekneemech: I suspect that's part of why morganfainberg has been involved in the cache work in oslo | 18:31 |
| bknudson | keystone does caching of results... keystoneclient caches tokens and revocation list | 18:36 |
| bknudson | auth_token middleware does caching of tokens and results | 18:37 |
| bknudson | tokens and revocation list | 18:37 |
| dhellmann | bknudson: the question is why the middlware registers a separate config option for that caching; is it not using the oslo module? | 18:44 |
| bknudson | dhellmann: memcached_servers option? | 18:47 |
| dhellmann | bknudson: yes, see https://review.openstack.org/#/c/81412/1 and https://launchpad.net/bugs/1262148 | 18:48 |
| dhellmann | bknudson: I'm trying to understand the background, so I can understand the proposed fix and whether it's good long-term | 18:48 |
| *** boris-42 is now known as boris-the-blade- | 18:49 | |
| *** boris-the-blade- is now known as boris-the-blade | 18:50 | |
| bknudson | dhellmann: doesn't look like python-keystoneclient needs it to me, since memorycache does the same thing. | 18:50 |
| dhellmann | bknudson: is this just a matter of a module moving into oslo, and not yet being removed from its original location? | 18:50 |
| bknudson | all that auth_token does with it is pass it on to memorycache.get_client(memcache_servers)... so if it wasn't set in auth_token then it'll use the oslo config | 18:50 |
| dhellmann | we wouldn't want the middleware to depend on that config option being registered by another module, but we don't want it registered twice with different settings either | 18:51 |
| dhellmann | aha, interesting | 18:51 |
| dhellmann | bknudson: could you leave that comment on the review? | 18:51 |
| *** rpodolyaka1 has joined #openstack-oslo | 19:08 | |
| *** hartsocks has left #openstack-oslo | 19:30 | |
| morganfainberg | dhellmann, correct this is why i am trying to work on that. | 19:42 |
| *** rpodolyaka1 has quit IRC | 19:42 | |
| morganfainberg | dhellmann, almost have all your comments on my patchset for oslo.cache addressed, but there has been enough restructure i need to test it | 19:42 |
| morganfainberg | a lot before pushing up changes. | 19:42 |
| dhellmann | morganfainberg: ok, can you provide any guidance on how to fix https://bugs.launchpad.net/nova/+bug/1262148 in the short term without major changes like moving options around into different groups? | 19:43 |
| morganfainberg | dhellmann, looking now | 19:44 |
| dhellmann | morganfainberg: see https://review.openstack.org/#/c/81412/ too | 19:44 |
| morganfainberg | dhellmann, oooh. icky | 19:45 |
| dhellmann | morganfainberg: yeah, we probably shouldn't have libraries registering options in the default group | 19:45 |
| morganfainberg | dhellmann, ++ i tossed a summit session proposal up on that :P | 19:46 |
| dhellmann | nice | 19:46 |
| morganfainberg | dhellmann, i think all oslo.* options should be namespaced incubator or library | 19:46 |
| morganfainberg | dhellmann, the [DEFAULT] group probably should only be used for the application itself and even then... limited | 19:47 |
| dhellmann | right | 19:47 |
| morganfainberg | even if the summit session is rejected, i plan on cornering people in the dev lounge about fixing this in juno | 19:47 |
| dhellmann | although I don't know if we wan an "oslo.messaging" section or just "messaging" or whatever -- but each lib should pick a namespace and the incubator modules should be using them, too | 19:47 |
| morganfainberg | or working on fixing it (more appropriately) | 19:47 |
| dhellmann | we should talk about adding that to the list of graduation steps for oslo libs | 19:48 |
| morganfainberg | dhellmann, i would like to see an [oslo.<namespace>] magic in oslo.config | 19:48 |
| morganfainberg | not sure how easy that would be due to the way config_parser works | 19:48 |
| dhellmann | why do we need magic? | 19:48 |
| morganfainberg | iirc . is special in config parser | 19:48 |
| dhellmann | oh, just for the dot | 19:48 |
| morganfainberg | yeah | 19:49 |
| dhellmann | well, why do we need the "oslo." part? | 19:49 |
| morganfainberg | we don't but it means no one would conflict with the common lib namespace | 19:49 |
| dhellmann | true | 19:49 |
| dhellmann | could just use oslo_ as a prefix | 19:49 |
| morganfainberg | if someone has mongo db stuff and wants to call their section [database] they would have zero impact to oslo.db | 19:50 |
| morganfainberg | dhellmann, true. a good alternative | 19:50 |
| morganfainberg | dhellmann, and probably requires no magic :) | 19:50 |
| dhellmann | I'm not sure we need a prefix, but I would rather pick one that doesn't need magic :-) | 19:50 |
| dhellmann | hehe | 19:50 |
| morganfainberg | dhellmann, i would advocate a prefix is just to clearly delineate where the options are defined and leaving the rest of the namespace wide open | 19:51 |
| morganfainberg | [messaging] for example could be used in a lot of cases | 19:51 |
| morganfainberg | i'm 100% for making namespaced options required for graduation from incubation | 19:51 |
| morganfainberg | even w/o a prefix :) | 19:52 |
| dhellmann | ok, I could be convinced on the prefix part I think, although it means changes to existing libs | 19:52 |
| morganfainberg | dhellmann, the deprecated option stuff is pretty good last i looked. but it is shuffling a lot of code | 19:52 |
| dhellmann | yeah | 19:53 |
| morganfainberg | i think the "correct" approach is make all new libs conform, and slate fixes for current ones as we can manage it | 19:53 |
| dhellmann | makes sense | 19:53 |
| morganfainberg | and encourage new incubated code to pre-emptively namespace | 19:53 |
| morganfainberg | "don't just dump that option in default please" | 19:54 |
| morganfainberg | ok back on topic. looking at the bug / reviews and trying to see what we can do | 19:54 |
| *** rpodolyaka1 has joined #openstack-oslo | 19:58 | |
| *** rpodolyaka1 has quit IRC | 20:07 | |
| *** rpodolyaka1 has joined #openstack-oslo | 20:10 | |
| *** rpodolyaka1 has quit IRC | 20:14 | |
| morganfainberg | dhellmann, i think the only real answer here is to either make auth_token check two locations (not register the deprecated option location) or fix the group in the incubated code. | 20:17 |
| morganfainberg | dhellmann, looking over all the various options and testing some thing, i don't see a good way to unwind this. | 20:18 |
| morganfainberg | dhellmann, likely the least resitance will be to make auth_token say "is [auth_token] memcache_servers == default ? if so, check [DEFAULT] then fallback. but it's ugly | 20:19 |
| dhellmann | morganfainberg: would there ever be a need to configure that option with 2 different values? | 20:20 |
| morganfainberg | dhellmann, this also implies we should have a way to see if a value is the default from the CONF object itself. | 20:20 |
| morganfainberg | dhellmann, hm. actually yes i could see that being desired, multiple memcache farms | 20:20 |
| dhellmann | I don't know if that's possible, and if it is I'm not sure that's a good way to detect an "unset" value | 20:20 |
| morganfainberg | dhellmann, this is the exact case why we need to namespace the options :P hm... | 20:21 |
| *** openstackgerrit has quit IRC | 20:22 | |
| dhellmann | morganfainberg: what about bknudson's comment on https://review.openstack.org/#/c/81412/1/openstack/common/memorycache.py ? | 20:23 |
| *** openstackgerrit has joined #openstack-oslo | 20:23 | |
| *** harlowja_still_a has joined #openstack-oslo | 20:23 | |
| morganfainberg | if keystoneclient imported memory_cache just to ensure the option is registered would we have the same issue? | 20:23 |
| bknudson | I can imagine you'd want a different memcache for auth_token vs whatever else might use memcache | 20:23 |
| morganfainberg | bknudson, ++ | 20:24 |
| morganfainberg | bknudson, when did we deprecate the old option? | 20:24 |
| dhellmann | right, and that's part of what the new cache stuff is trying to support, right? | 20:24 |
| * morganfainberg goes and checks | 20:24 | |
| morganfainberg | dhellmann, exactly | 20:24 |
| morganfainberg | dhellmann, it's the whole reason to use a layer like dogpile w/ named cache regions | 20:24 |
| bknudson | the auth_token options are in [keystone_authtoken] | 20:24 |
| dhellmann | were we supporting that before with this older cache code? | 20:24 |
| morganfainberg | dhellmann, don't think so | 20:25 |
| bknudson | or you could specify them in your api-paste.ini | 20:25 |
| morganfainberg | bknudson, i think the conflict comes from the deprecated name part in our option | 20:25 |
| morganfainberg | bknudson, otherwise this has little impact | 20:25 |
| bknudson | that's memcache_servers | 20:25 |
| morganfainberg | bknudson, yeah | 20:26 |
| bknudson | CONF.register_opts(opts, group='keystone_authtoken') | 20:26 |
| bknudson | deprecated_name='memcache_servers' | 20:27 |
| morganfainberg | wait a second. | 20:27 |
| bknudson | the bug 1262148 seems strange... it says auth_token defines memcached_servers in default and not in keystone_authtoken | 20:30 |
| morganfainberg | bknudson, ok this is rooted from a bug in the generator code | 20:30 |
| morganfainberg | bknudson, nothing to do with either us or the incubated code | 20:30 |
| morganfainberg | we're just symptoms here | 20:30 |
| morganfainberg | https://review.openstack.org/#/c/79738/2/openstack/common/config/generator.py | 20:30 |
| morganfainberg | aparantly identical options don't appear in separate groups | 20:31 |
| morganfainberg | https://bugs.launchpad.net/oslo/+bug/1288586 | 20:31 |
| morganfainberg | but our option is actually largely different because helptext is different | 20:31 |
| bknudson | it would be interesting to see the result of fixing that bug on the other bug | 20:31 |
| morganfainberg | this seems like faulty code | 20:34 |
| morganfainberg | why does an option need a group? | 20:35 |
| morganfainberg | it's to help smush out multiple definitions in the same group...but there are cases where we don't want a group on an option | 20:36 |
| morganfainberg | the generator assumes all options must be in a group it looks like. | 20:36 |
| *** rpodolyaka1 has joined #openstack-oslo | 20:38 | |
| *** rpodolyaka1 has quit IRC | 20:44 | |
| *** banix has quit IRC | 20:50 | |
| *** rpodolyaka1 has joined #openstack-oslo | 21:40 | |
| *** rpodolyaka1 has quit IRC | 21:45 | |
| *** bknudson has quit IRC | 22:09 | |
| *** dhellmann is now known as dhellmann_ | 22:21 | |
| *** harlowja_still_a has quit IRC | 22:33 | |
| openstackgerrit | Jenkins proposed a change to openstack/oslo-incubator: Updated from global requirements https://review.openstack.org/82236 | 22:33 |
| *** rpodolyaka1 has joined #openstack-oslo | 22:41 | |
| *** rpodolyaka1 has quit IRC | 22:47 | |
| *** dims has quit IRC | 22:59 | |
| *** dims has joined #openstack-oslo | 23:14 | |
| *** mriedem has left #openstack-oslo | 23:22 | |
| *** mriedem has quit IRC | 23:22 | |
| *** rpodolyaka1 has joined #openstack-oslo | 23:44 | |
| *** rpodolyaka1 has quit IRC | 23:48 | |
| *** yamahata has quit IRC | 23:55 | |
| *** yamahata has joined #openstack-oslo | 23:55 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!