Tuesday, 2014-03-18

harlowjaa question for some folks in here, sorta releated to oslo.messaging, but i was wondering it over the weekend, why not just add most of the feature that are being placed in oslo.messaging into kombu?00:01
harlowjalike https://github.com/celery/kombu/issues/54 shows qpid was almost there00:02
harlowjasame with zeromq it seems00:02
harlowjathen oslo.messaging mainly becomes a pretty tiny library00:02
harlowjawith some rpc helpers, and matchmaking and thats about it00:03
openstackgerritJoshua Harlow proposed a change to openstack/taskflow: Add check to ensure no duplicate names/uuids  https://review.openstack.org/8113100:37
*** yamahata has joined #openstack-oslo00:40
*** banix has joined #openstack-oslo00:41
*** markmcclain has joined #openstack-oslo00:49
*** jraim has quit IRC00:53
*** jraim has joined #openstack-oslo00:55
*** yamahata has quit IRC01:03
*** yamahata has joined #openstack-oslo01:03
*** lbragstad has joined #openstack-oslo01:03
*** markmcclain has quit IRC01:16
*** banix has quit IRC01:18
*** rpodolyaka1 has joined #openstack-oslo01:25
*** morganfainberg is now known as morganfainberg_Z01:30
*** rpodolyaka1 has quit IRC01:32
*** banix has joined #openstack-oslo01:41
*** arnaud__ has quit IRC01:46
*** morganfainberg_Z is now known as morganfainberg01:49
*** morganfainberg is now known as morganfainberg_Z02:08
*** banix has quit IRC02:15
*** harlowja is now known as harlowja_away02:21
openstackgerritwingwj proposed a change to openstack/oslo-incubator: Add _retry_on_deadlock support for postgresql  https://review.openstack.org/7491702:23
*** rpodolyaka1 has joined #openstack-oslo02:28
*** zhiyan_ is now known as zhiyan02:28
*** rpodolyaka1 has quit IRC02:33
*** harlowja_away is now known as harlowja03:06
openstackgerritwingwj proposed a change to openstack/oslo-incubator: Add _retry_on_deadlock support for postgresql  https://review.openstack.org/7491703:36
openstackgerritwingwj proposed a change to openstack/oslo-incubator: Add _retry_on_deadlock support for postgresql  https://review.openstack.org/7491703:38
*** morganfainberg_Z is now known as morganfainberg03:52
*** adrian_otto has joined #openstack-oslo03:52
openstackgerritJoshua Harlow proposed a change to openstack/taskflow: Adjust the exception hierachy  https://review.openstack.org/8037204:04
*** rpodolyaka1 has joined #openstack-oslo04:30
*** rpodolyaka1 has quit IRC04:34
openstackgerritZhongyue Luo proposed a change to openstack/oslo-incubator: Adds test condition in test_periodic  https://review.openstack.org/7207105:10
*** adrian_otto has quit IRC05:28
*** rpodolyaka1 has joined #openstack-oslo05:30
*** rpodolyaka1 has quit IRC05:35
*** harlowja is now known as harlowja_away05:40
openstackgerritChangBo Guo(gcb) proposed a change to openstack/oslo.messaging: Remove vim header  https://review.openstack.org/7582005:51
*** rpodolyaka1 has joined #openstack-oslo06:01
openstackgerritChangBo Guo(gcb) proposed a change to openstack/oslo.messaging: Refactor logic of choosing qpid brokers  https://review.openstack.org/8118306:27
*** rpodolyaka1 has quit IRC06:35
*** rpodolyaka1 has joined #openstack-oslo06:45
*** rpodolyaka1 has quit IRC06:46
*** rpodolyaka1 has joined #openstack-oslo06:46
*** rpodolyaka1 has quit IRC06:46
*** rpodolyaka1 has joined #openstack-oslo06:46
*** rpodolyaka1 has quit IRC06:47
*** rpodolyaka1 has joined #openstack-oslo06:47
openstackgerritIvan Melnikov proposed a change to openstack/taskflow: Fix few minor spelling errors  https://review.openstack.org/8118807:01
*** rpodolyaka1 has quit IRC07:07
openstackgerritThomas Goirand proposed a change to openstack-dev/pbr: Fix incorrect usage of unicode string  https://review.openstack.org/8119107:14
openstackgerritMark McLoughlin proposed a change to openstack/oslo.messaging: Use driver's notify_send() method again  https://review.openstack.org/8119307:19
openstackgerritIvan Melnikov proposed a change to openstack/taskflow: Add more test for resumption with retry  https://review.openstack.org/8119507:41
openstackgerritIvan Melnikov proposed a change to openstack/taskflow: Add more tests for resumption with retry  https://review.openstack.org/8119507:44
openstackgerritMehdi Abaakouk proposed a change to openstack/oslo.messaging: Remove old drivers dead code  https://review.openstack.org/7890307:51
*** bogdando has quit IRC07:52
*** I159_ has joined #openstack-oslo08:04
*** bogdando has joined #openstack-oslo08:16
*** morganfainberg is now known as morganfainberg_Z08:34
openstackgerritJenkins proposed a change to openstack/cliff: Updated from global requirements  https://review.openstack.org/8120308:45
openstackgerritJenkins proposed a change to openstack/pycadf: Updated from global requirements  https://review.openstack.org/7969308:51
*** mattymo has quit IRC09:07
openstackgerritAnastasia Karpinska proposed a change to openstack/taskflow: Add Retry to developers documentation  https://review.openstack.org/8121309:34
openstackgerritAnastasia Karpinska proposed a change to openstack/taskflow: Move flow states to developers documentation  https://review.openstack.org/8035009:34
openstackgerritAnastasia Karpinska proposed a change to openstack/taskflow: Flow smart revert with retry controller  https://review.openstack.org/7162109:34
openstackgerritAnastasia Karpinska proposed a change to openstack/taskflow: Add atom intentions for tasks and retries  https://review.openstack.org/7101309:34
*** cflmarques has joined #openstack-oslo09:36
cflmarquesHi guys.Does Keystone use oslo to send notifications events? "tenant creation/deleted...09:38
cflmarquesI manage to retrieve nova events, but I also needed keystone events. does it send notifications or it must be enabled on the conf file?09:40
openstackgerritAnastasia Karpinska proposed a change to openstack/taskflow: Move flow states to developers documentation  https://review.openstack.org/8035009:47
openstackgerritAnastasia Karpinska proposed a change to openstack/taskflow: Add Retry to developers documentation  https://review.openstack.org/8121309:47
*** cflmarques has quit IRC09:53
*** GheRivero has quit IRC10:16
openstackgerritNuman Siddique proposed a change to openstack/oslo.messaging: Fixed the issue for pop exception  https://review.openstack.org/7583810:20
openstackgerritNuman Siddique proposed a change to openstack/oslo.messaging: Fixed the issue for pop exception  https://review.openstack.org/7583810:27
*** GheRivero has joined #openstack-oslo10:27
*** yamahata has quit IRC10:49
*** GheRivero has quit IRC10:52
*** GheRivero has joined #openstack-oslo10:53
*** GheRivero has quit IRC10:58
openstackgerritRoman Podoliaka proposed a change to openstack/oslo-incubator: Dispose db connections pool on disconnect  https://review.openstack.org/8122510:59
openstackgerritMark McLoughlin proposed a change to openstack/oslo.messaging: Add kombu driver library to requirements.txt  https://review.openstack.org/7842411:52
*** GheRivero has joined #openstack-oslo11:53
*** yamahata has joined #openstack-oslo11:56
*** obondarev1 has joined #openstack-oslo12:06
*** yamahata_ has quit IRC12:08
*** yamahata_ has joined #openstack-oslo12:08
*** obondarev has quit IRC12:09
openstackgerritStanislav Kudriashev proposed a change to openstack/taskflow: Fix executor requests publishing bug  https://review.openstack.org/8124412:09
*** dims has quit IRC12:31
*** dims has joined #openstack-oslo12:33
*** flaper87|afk is now known as flaper8712:35
*** markmcclain has joined #openstack-oslo12:55
openstackgerritIonut Artarisi proposed a change to openstack/oslo-incubator: log a warning when memcache couldn't be imported  https://review.openstack.org/8125312:56
openstackgerritIvan Melnikov proposed a change to openstack/taskflow: Fix few minor spelling errors  https://review.openstack.org/8118812:56
openstackgerritIvan Melnikov proposed a change to openstack/taskflow: Add more tests for resumption with retry  https://review.openstack.org/8119512:57
openstackgerritIvan Melnikov proposed a change to openstack/taskflow: Test storage with memory and sqlite backends  https://review.openstack.org/8055312:58
ihrachysdhellmann: could you please reconsider your -1 at https://review.openstack.org/#/c/81009/?12:59
*** flaper87 is now known as flaper87|afk13:10
*** mriedem has joined #openstack-oslo13:14
openstackgerritIvan Melnikov proposed a change to openstack/taskflow: Iteration over links in flow interface  https://review.openstack.org/8094213:15
*** obondarev1 is now known as obondarev13:18
*** directxman12 has joined #openstack-oslo13:18
*** flaper87|afk is now known as flaper8713:19
*** directxman12 has quit IRC13:20
openstackgerritIonut Artarisi proposed a change to openstack/oslo-incubator: log a warning when memcache couldn't be imported  https://review.openstack.org/8125313:23
openstackgerritIhar Hrachyshka proposed a change to openstack/oslo.messaging: Add unit test to check the order of Qpid hosts on reconnect  https://review.openstack.org/8126113:24
openstackgerritMasaru Nomura proposed a change to openstack/oslo.vmware: Add unittest method "test_download_flat_image"  https://review.openstack.org/8126313:28
*** bknudson has joined #openstack-oslo13:31
openstackgerritIvan Melnikov proposed a change to openstack/taskflow: Simplify graph analizer interface  https://review.openstack.org/8126613:56
openstackgerritIvan Melnikov proposed a change to openstack/taskflow: Simplify graph analyzer interface  https://review.openstack.org/8126613:57
*** zhiyan is now known as zhiyan_13:58
*** banix has joined #openstack-oslo13:59
openstackgerritIlya Pekelny proposed a change to openstack/oslo-incubator: Opportunistic migration tests  https://review.openstack.org/7510714:00
*** adrian_otto has joined #openstack-oslo14:08
*** lbragstad has quit IRC14:17
*** lbragstad has joined #openstack-oslo14:17
openstackgerritChangBo Guo(gcb) proposed a change to openstack/oslo.messaging: Select AMQP message broker at random  https://review.openstack.org/8118314:19
*** adrian_otto has quit IRC14:22
*** flaper87 is now known as flaper87|afk14:25
*** wingwj has quit IRC14:32
*** wingwj has joined #openstack-oslo14:32
openstackgerritDoug Hellmann proposed a change to openstack/oslo.messaging: Clean up for qpid tests  https://review.openstack.org/7727314:45
openstackgerritIhar Hrachyshka proposed a change to openstack/oslo.messaging: Add unit test to check the order of Qpid hosts on reconnect  https://review.openstack.org/8126114:54
*** tjones has joined #openstack-oslo14:57
*** adrian_otto has joined #openstack-oslo15:00
ihrachysdhellmann: ping re qpid test for oslo.messaging15:01
dhellmannihrachys: here15:15
ihrachysdhellmann: I've seen you did some cleanup in qpid test. does it mean I need to rewrite https://review.openstack.org/#/c/81261/ ? specifically, not to call register_opts?15:22
*** tjones has quit IRC15:22
ihrachysdhellmann: also, unrelated but significant - see my comment at https://review.openstack.org/#/c/81009/, probably you will change your mind on -115:27
dhellmannihrachys: I'll have to look at your changeset15:28
dhellmannihrachys: you should not need to call register_opts() if you use the fixture that is already present in the test base class15:29
ihrachysdhellmann: I get 'NoSuchOptError: no such option: qpid_hosts' on self.config()15:31
dhellmannyou need to use self.messaging_conf15:32
dhellmannI'm not sure why that's not plumbed in to config(), that may be a bug in the fixture15:32
dhellmannI'd have to look at all of the other tests to see if they use it differently15:33
ihrachysself.config() operates on self.conf, not self.messaging_conf15:34
dhellmannright15:36
*** yamahata has quit IRC15:39
ihrachysdhellmann: using messaging_conf fixture, I get 'AttributeError: 'ConfFixture' object has no attribute 'qpid_username'' I've tried to fix this by adding _import_opts(self.conf, 'oslo.messaging._drivers.impl_qpid', 'qpid_opts') to fixture, but it doesn't help15:39
*** yamahata has joined #openstack-oslo15:39
*** beagles has left #openstack-oslo15:45
openstackgerritRoman Podoliaka proposed a change to openstack/oslo-incubator: Dispose db connections pool on disconnect  https://review.openstack.org/8122515:47
dhellmannihrachys: http://paste.openstack.org/show/73764/15:51
ihrachysdhellmann: it seems that default values are not created when using fixture; once I've manually set all those qpid_* settings used in Connection.__init__(), it passed.15:51
ihrachysouch, now I see my issue, I used messaging_conf, not messaging_conf.conf15:52
ihrachystnx!15:52
dhellmannihrachys: if you want to take a look at making that fixture work with self.conf and self.config(), that would make another good patch, I think15:53
openstackgerritIhar Hrachyshka proposed a change to openstack/oslo.messaging: Add unit test to check the order of Qpid hosts on reconnect  https://review.openstack.org/8126115:54
openstackgerritJoshua Harlow proposed a change to openstack/oslo.messaging: Add a thread + futures executor based executor  https://review.openstack.org/7091415:54
*** tjones has joined #openstack-oslo15:56
*** flaper87|afk is now known as flaper8716:30
openstackgerritThierry Carrez proposed a change to openstack/oslo.rootwrap: Avoid matching ip -s netns exec in IpFilter  https://review.openstack.org/8129516:37
*** adrian_otto has left #openstack-oslo16:44
*** wingwj has quit IRC16:48
*** harlowja_away is now known as harlowja16:53
*** sergmelikyan has quit IRC16:57
*** morganfainberg_Z is now known as morganfainberg17:01
*** arnaud__ has joined #openstack-oslo17:09
*** I159_ has quit IRC17:11
*** mriedem has quit IRC17:17
*** mriedem has joined #openstack-oslo17:19
*** morganfainberg is now known as morganfainberg_Z17:38
openstackgerritMasaru Nomura proposed a change to openstack/oslo.vmware: Fix unittest function test_download_flat_image  https://review.openstack.org/8131717:44
*** flaper87 is now known as flaper87|afk17:53
*** morganfainberg_Z is now known as morganfainberg17:58
openstackgerritOctavian Ciuhandu proposed a change to openstack-dev/pbr: Fixes blocking issue on Windows  https://review.openstack.org/8132218:00
*** harlowja is now known as harlowja_away18:01
*** harlowja_away is now known as harlowja18:02
*** shakamunyi has joined #openstack-oslo18:04
*** shakamunyi has quit IRC18:18
*** shakamunyi has joined #openstack-oslo18:27
openstackgerritVish Ishaya proposed a change to openstack/oslosphinx: Update manifest to use oslosphinx  https://review.openstack.org/8133118:27
*** hartsocks has joined #openstack-oslo18:47
*** shakamunyi has quit IRC18:49
dhellmannbnemec, dims : where do you see https://review.openstack.org/#/c/80222/6 on the feature freeze scale? it's reported as a bug, but it doesn't seem that significant to me.18:53
*** rpodolyaka1 has joined #openstack-oslo18:53
bnemecdhellmann: Well, it's not a huge deal, but I do think excessive error logs is a legitimate bug.  Especially since these messages are otherwise being logged at the WARN level.18:55
dimsdhellmann, i'd support it as it is a support headache for who ever is trying to debug logs18:55
bnemecAt least based on what I see in https://bugs.launchpad.net/neutron/+bug/128818818:55
dhellmannok, that's a good point, I hadn't thought of that case18:55
dhellmann+2a18:56
* bnemec 's dashboard shrinks by one more line18:58
*** flaper87|afk is now known as flaper8718:59
dhellmannbnemec, dims: what do you think of markwash's ideas in https://review.openstack.org/#/c/75356/ ?19:21
dimsdhellmann, my vote is to leave existing behavior as is (enforce_utf8_charset defaults to false), but definitely document the warning and encourage people to set it to true19:25
dhellmanndims: I thought we were enforcing utf8 now19:27
dhellmannwell, by "now" I mean in master19:27
dhellmannnot necessarily in havana19:27
* dhellmann checks havana19:27
*** beav has quit IRC19:28
dhellmannI don't see that check in havana, it looks like it was added in I19da8d5e2d972c78d0f9fb4325445f538ed3560019:31
dhellmannin Jan of this year19:31
dimsdhellmann, i see, for some reason i thought this was the review to make the switch to enforce utf8. now markwash's idea seems reasonable to relax that mandated move that was already added since havana19:37
dhellmanndims: yeah, it seems reasonable -- i'm worried about the side-effects of continuing to allow mixed charset databases, though19:37
dhellmannmaybe the check should just enforce that all of the charsets are the same?19:38
dimssounds good to me! :)19:38
dimsif it can be done that is19:38
dhellmann"implementation is left up to the reader" :-)19:39
* bnemec is in the tripleo meeting right now19:40
bnemecWill check back in after that's over19:40
dims:)19:43
dhellmannbnemec: thanks19:43
openstackgerritIvan Melnikov proposed a change to openstack/taskflow: docs: Links to methods on arguments and results page  https://review.openstack.org/8134819:50
*** rpodolyaka1 has quit IRC20:01
openstackgerritIvan Melnikov proposed a change to openstack/taskflow: Make schedule a proper method of GraphAction  https://review.openstack.org/8135820:07
openstackgerritIvan Melnikov proposed a change to openstack/taskflow: Remove extraneous vim configuration comments  https://review.openstack.org/8135920:13
*** flaper87 is now known as flaper87|afk20:27
*** flaper87|afk is now known as flaper8720:29
openstackgerritJoe Gordon proposed a change to openstack-dev/pbr: Make tools/integration.sh take a branch  https://review.openstack.org/8072320:32
*** rpodolyaka1 has joined #openstack-oslo20:37
*** flaper87 is now known as flaper87|afk20:39
*** rpodolyaka1 has quit IRC20:41
bnemecdhellmann: dims: +1 to deprecating non-utf8 tables, but not forcing it in Icehouse20:54
*** tjones1 has joined #openstack-oslo21:08
*** tjones has quit IRC21:08
*** dims has quit IRC21:12
*** banix has quit IRC21:16
bnemecdhellmann: I left a comment on https://review.openstack.org/#/c/75356/  Please chime in if there's anything you disagree with.21:19
openstackgerritOctavian Ciuhandu proposed a change to openstack-dev/pbr: Fixes blocking issue on Windows  https://review.openstack.org/8132221:19
dhellmannbnemec, dims: this topic is likely to be coming up in the project meeting in #openstack-meeting shortly21:23
* bnemec wanders over to openstack-meeting21:24
*** dims has joined #openstack-oslo21:26
*** rpodolyaka1 has joined #openstack-oslo21:37
*** rpodolyaka1 has quit IRC21:42
*** mriedem has left #openstack-oslo21:44
*** mriedem has quit IRC21:44
dhellmannbnemec: thanks!21:45
bnemecdhellmann: So I think we may still have a chicken and egg problem here.21:45
bnemecThey need to run a migration to convert to utf8, but we're going to block their migrations until the tables are utf8 as it stands right now.21:45
* dhellmann head-desk21:46
dhellmannbnemec: can we move the utf8 check *after* the other migrations are run?21:47
bnemecdhellmann: Maybe, although that wouldn't have caught https://bugs.launchpad.net/heat/+bug/126160521:48
bnemecWhich was the motivation behind this whole utf8 checking thing.21:48
dhellmannso glance still needs a way to turn this off, but it should only be off for one of the migrations21:49
dhellmannor rather, until the migration that fixes the encoding is run, which may be several migrations21:50
bnemecYeah, I'd have to look at exactly how the db_sync logic works.  I'm not sure we have the granularity to shut it off for a single migration.21:51
dhellmannbnemec: no, it doesn't look like it21:51
bnemecWe could maybe add a conditional that would let glance pass us a db version, and say "if the starting version is below this, don't do the utf8 check".21:51
dhellmannhmm, yeah21:52
bnemecAlthough I say that without even a glance at the actual code.21:52
dhellmannor we could make them put that in glance-manage and we could just have a flag to turn the sanity check on/off21:52
bnemecNo pun intended. :-)21:52
dhellmannheh21:52
bnemecYeah, either way.  In the project might make sense since it's project-specific.21:53
dhellmannwe give them the flag, they hold the logic for when to use it21:53
dhellmannbnemec: I wonder if glance-manage has enough information to figure out how to pass the flag. Maybe it should be a "enforce utf8 after this migration" flag, and the oslo code should figure out what state the database is in.21:58
openstackgerritJoshua Harlow proposed a change to openstack/taskflow: Adjust the exception hierachy  https://review.openstack.org/8037221:58
bnemecdhellmann: Hmm, that's true.  I think they _can_ pass in a specific version to migrate to, but they don't necessarily know what they're at beforehand.22:00
bnemecAlthough don't all the -manage clients have a db_version option to retrieve the current version?22:00
dhellmannbnemec: right, we would have to expose some way for them to learn that -- I would expect sqlalchemy-migrate to have that22:00
dhellmannoh, maybe they do22:00
* dhellmann hasn't explored this corner of the openstack world yet22:00
dhellmannbnemec: I'll follow up to the ML thread with some of these ideas22:01
bnemecdhellmann: Sounds good22:01
bnemec[fedora@openstack ~]$ glance-manage db_version22:01
bnemec3422:01
bnemecdhellmann: FWIW^22:01
dhellmannok, so it has some way to get the value22:02
dhellmanncool22:02
bnemecI'm going to duck out for a bit.  Will check back in later tonight.22:03
dhellmannbnemec: ok, thanks!22:05
*** bknudson has quit IRC22:07
*** markmcclain1 has joined #openstack-oslo22:17
*** markmcclain has quit IRC22:17
*** markmcclain1 has quit IRC22:24
*** banix has joined #openstack-oslo22:31
*** tjones1 has quit IRC22:31
*** tjones has joined #openstack-oslo22:32
*** rpodolyaka1 has joined #openstack-oslo22:38
*** banix has quit IRC22:40
*** lbragstad has left #openstack-oslo22:42
*** rpodolyaka1 has quit IRC22:43
*** tjones has quit IRC22:49
*** tjones has joined #openstack-oslo22:50
*** lbragstad has joined #openstack-oslo22:51
*** lbragstad is now known as lbragstad__22:55
openstackgerritOctavian Ciuhandu proposed a change to openstack-dev/pbr: Fixes blocking issue on Windows  https://review.openstack.org/8132222:55
*** tjones has quit IRC23:50
openstackgerritOctavian Ciuhandu proposed a change to openstack-dev/pbr: Fixes blocking issue on Windows  https://review.openstack.org/8132223:53

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!