| jesusaurus | khushbu_: then workflow I usually use for that is this: (assuming the change number is 123456) "git review -d 123456 ; git rebase origin/master ; git review -f" | 00:00 |
|---|---|---|
| *** julim has quit IRC | 00:00 | |
| jesusaurus | khushbu_: but if there are any merge conflicts, you will need to resolve them before you can run the second git-review command | 00:00 |
| khushbu_ | Does this change the change id? | 00:01 |
| jesusaurus | no, it doesn't | 00:03 |
| khushbu_ | thanks a lot. jesusaurus. That helps a lot :) | 00:04 |
| jesusaurus | the first git-review command downloads the patch from gerrit, then you rebase like normal, and the second git-review command proposes the rebased change (which will have the exact same commit message, unless you changed it during the rebase) | 00:04 |
| khushbu_ | jesusaurus, I get a merge message .. Is there a way around that >/ | 00:05 |
| khushbu_ | ? | 00:05 |
| jesusaurus | what kind of message? | 00:05 |
| jesusaurus | you probably have a merge conflict | 00:06 |
| khushbu_ | Okay wait I got around that. I got uptil rebase. Do i make my changes now or do i do git review -f first and then do my changes? | 00:09 |
| *** julim has joined #openstack-opw | 00:09 | |
| jesusaurus | ah, if you also need to make changes, do that after the rebase but before 'git review -f' | 00:10 |
| jesusaurus | and make sure to use 'git commit --amend' so that you don't end up with a new commit | 00:10 |
| khushbu_ | thanks jesusaurus. That helps :) | 00:13 |
| *** julim has quit IRC | 00:14 | |
| khushbu_ | jesusaurus, do you work for ceilometer? | 00:14 |
| jesusaurus | no, I don't work on ceilometer | 00:15 |
| *** julim has joined #openstack-opw | 00:20 | |
| *** julim has quit IRC | 00:25 | |
| *** eliqiao has joined #openstack-opw | 00:28 | |
| *** Eva-intern has quit IRC | 00:34 | |
| *** eliqiao1 has joined #openstack-opw | 00:38 | |
| *** eliqiao has quit IRC | 00:39 | |
| *** khushbu_ has quit IRC | 01:15 | |
| *** eliqiao has joined #openstack-opw | 01:32 | |
| *** eliqiao1 has quit IRC | 01:34 | |
| *** aartajos has joined #openstack-opw | 01:39 | |
| aartajos | i want to apply to the outreachy program | 01:39 |
| *** eliqiao1 has joined #openstack-opw | 01:45 | |
| *** eliqiao has quit IRC | 01:48 | |
| *** julim has joined #openstack-opw | 02:01 | |
| *** openstack has joined #openstack-opw | 02:12 | |
| *** eliqiao has joined #openstack-opw | 02:12 | |
| *** lblanchard has quit IRC | 02:22 | |
| *** pt_15 has quit IRC | 02:43 | |
| *** itisha has quit IRC | 02:43 | |
| *** sonali5 has joined #openstack-opw | 02:46 | |
| *** eliqiao1 has joined #openstack-opw | 02:47 | |
| *** eliqiao has quit IRC | 02:49 | |
| *** vsham20 has joined #openstack-opw | 02:49 | |
| *** vsham20 has quit IRC | 02:50 | |
| *** eliqiao1 has quit IRC | 02:57 | |
| *** eliqiao has joined #openstack-opw | 03:02 | |
| *** eliqiao1 has joined #openstack-opw | 03:26 | |
| *** eliqiao has quit IRC | 03:28 | |
| *** eliqiao1 has quit IRC | 03:30 | |
| *** akanksha_ has quit IRC | 03:38 | |
| *** eliqiao has joined #openstack-opw | 03:40 | |
| *** eliqiao has quit IRC | 03:53 | |
| *** eliqiao has joined #openstack-opw | 03:54 | |
| *** aartajos has joined #openstack-opw | 04:08 | |
| *** eliqiao1 has joined #openstack-opw | 04:13 | |
| *** eliqiao has quit IRC | 04:16 | |
| *** aartajos has quit IRC | 04:20 | |
| *** eliqiao1 has quit IRC | 04:21 | |
| *** eliqiao has joined #openstack-opw | 04:22 | |
| *** sonali5 has quit IRC | 04:33 | |
| *** eliqiao1 has joined #openstack-opw | 04:41 | |
| *** eliqiao has quit IRC | 04:42 | |
| *** eliqiao has joined #openstack-opw | 04:57 | |
| *** eliqiao1 has quit IRC | 04:59 | |
| *** eliqiao1 has joined #openstack-opw | 05:02 | |
| *** eliqiao has quit IRC | 05:03 | |
| *** eliqiao1 has quit IRC | 05:20 | |
| *** eliqiao has joined #openstack-opw | 05:20 | |
| *** eliqiao1 has joined #openstack-opw | 05:33 | |
| *** eliqiao has quit IRC | 05:35 | |
| *** eliqiao has joined #openstack-opw | 06:05 | |
| *** eliqiao1 has quit IRC | 06:05 | |
| *** sanjana has joined #openstack-opw | 06:46 | |
| *** sanjana has quit IRC | 06:49 | |
| *** eliqiao1 has joined #openstack-opw | 06:54 | |
| *** eliqiao has quit IRC | 06:55 | |
| *** eliqiao1 has quit IRC | 07:03 | |
| *** eliqiao has joined #openstack-opw | 07:06 | |
| *** eliqiao1 has joined #openstack-opw | 07:23 | |
| *** eliqiao has quit IRC | 07:26 | |
| *** exploreshaifali has joined #openstack-opw | 07:26 | |
| *** jengeb has joined #openstack-opw | 07:33 | |
| *** eliqiao has joined #openstack-opw | 07:36 | |
| *** jengeb has quit IRC | 07:37 | |
| *** eliqiao1 has quit IRC | 07:38 | |
| *** eliqiao1 has joined #openstack-opw | 07:42 | |
| *** eliqiao has quit IRC | 07:45 | |
| *** eliqiao2 has joined #openstack-opw | 07:55 | |
| *** eliqiao1 has quit IRC | 07:57 | |
| *** jengeb has joined #openstack-opw | 08:11 | |
| *** eliqiao1 has joined #openstack-opw | 08:19 | |
| *** eliqiao2 has quit IRC | 08:22 | |
| *** ShrutiJ has joined #openstack-opw | 08:25 | |
| *** mahatic has joined #openstack-opw | 08:27 | |
| ShrutiJ | Hello! I am Shruti Jasoria from India. I'm interested in contributing to OpenStack. Can you guide me how can I start contributing? | 08:29 |
| *** mahatic has quit IRC | 08:31 | |
| *** exploreshaifali has quit IRC | 08:35 | |
| *** josephine_l has joined #openstack-opw | 08:36 | |
| *** eliqiao2 has joined #openstack-opw | 08:48 | |
| *** eliqiao1 has quit IRC | 08:49 | |
| *** sonali5 has joined #openstack-opw | 08:50 | |
| *** psd has joined #openstack-opw | 09:05 | |
| *** psd has left #openstack-opw | 09:05 | |
| *** nisha has joined #openstack-opw | 09:09 | |
| *** joyce_ has joined #openstack-opw | 09:30 | |
| *** Eva-intern has joined #openstack-opw | 09:46 | |
| *** sonali5 has quit IRC | 10:04 | |
| *** sonali5 has joined #openstack-opw | 10:05 | |
| *** sonali5 has quit IRC | 10:13 | |
| *** jengeb has quit IRC | 10:14 | |
| *** jengeb has joined #openstack-opw | 10:14 | |
| *** sonali5 has joined #openstack-opw | 10:29 | |
| *** jengeb has quit IRC | 10:35 | |
| *** josephine_l has quit IRC | 10:40 | |
| *** sonali5 has quit IRC | 10:45 | |
| *** pt_15 has joined #openstack-opw | 10:57 | |
| *** itisha has joined #openstack-opw | 10:59 | |
| *** joyce_ has quit IRC | 11:55 | |
| *** nisha has quit IRC | 11:58 | |
| *** nisha has joined #openstack-opw | 12:02 | |
| *** nisha has quit IRC | 12:03 | |
| *** nisha has joined #openstack-opw | 12:03 | |
| *** lblanchard has joined #openstack-opw | 12:05 | |
| *** ShrutiJ has quit IRC | 12:13 | |
| *** lblanchard has quit IRC | 12:24 | |
| *** pt_15 has quit IRC | 13:03 | |
| *** sonali5 has joined #openstack-opw | 13:07 | |
| *** khushbu_ has joined #openstack-opw | 13:16 | |
| *** pt_15 has joined #openstack-opw | 13:18 | |
| *** akanksha_ has joined #openstack-opw | 13:24 | |
| *** jengeb has joined #openstack-opw | 13:36 | |
| *** Eva-intern has quit IRC | 13:45 | |
| nisha | hello everyone | 14:04 |
| nisha | I am an outreachy aspirant, and samueldmq told me that it is good practise to review other's code on https://review.openstack.org/#/ | 14:06 |
| *** rossella_s has quit IRC | 14:06 | |
| *** rossella_s has joined #openstack-opw | 14:06 | |
| nisha | I was wondering how can I give others +1 after reviewing a patch ? | 14:07 |
| nisha | And can this be done to the merged patches also? | 14:07 |
| nisha | For example, I commented on this merged patch and added myself as a reviewer https://review.openstack.org/#/c/226677/ | 14:09 |
| *** jengeb has quit IRC | 14:25 | |
| samueldmq | hi nisha, you should review open patches, not merged ones | 14:25 |
| samueldmq | nisha: the only case I see you should review a merged patch is when you do think it introduced a bug and you want to revert it | 14:26 |
| samueldmq | nisha: review open patches, after leaving comments in the files (if any), you go in the patch set and click on the Review button, there you will be able to vote plus add some additional comment | 14:27 |
| nisha | ohh, alright, I will review open patches then, le'me try some | 14:33 |
| nisha | samueldmq, thanks :) | 14:33 |
| *** GB21 has joined #openstack-opw | 14:42 | |
| *** GB21_ has joined #openstack-opw | 14:43 | |
| *** GB21 has quit IRC | 14:47 | |
| *** khushbu has joined #openstack-opw | 15:02 | |
| *** khushbu has quit IRC | 15:08 | |
| *** nisha has quit IRC | 15:13 | |
| *** jengeb has joined #openstack-opw | 15:14 | |
| *** nisha has joined #openstack-opw | 15:28 | |
| *** Eva-intern has joined #openstack-opw | 15:57 | |
| *** sonali5 has quit IRC | 16:09 | |
| *** khushbu_ has quit IRC | 16:11 | |
| *** nisha_ has joined #openstack-opw | 16:24 | |
| *** nisha_ has quit IRC | 16:24 | |
| *** nisha_ has joined #openstack-opw | 16:24 | |
| *** nisha_ has quit IRC | 16:24 | |
| *** nisha_ has joined #openstack-opw | 16:25 | |
| *** nisha_ has quit IRC | 16:25 | |
| *** nisha_ has joined #openstack-opw | 16:26 | |
| *** nisha_ has quit IRC | 16:27 | |
| *** nisha has quit IRC | 16:27 | |
| *** nisha has joined #openstack-opw | 16:28 | |
| *** sonali5 has joined #openstack-opw | 16:30 | |
| *** jengeb has quit IRC | 16:34 | |
| *** namratab94 has joined #openstack-opw | 16:50 | |
| *** nisha_ has joined #openstack-opw | 17:13 | |
| *** nisha_ has quit IRC | 17:15 | |
| *** nisha has quit IRC | 17:15 | |
| *** nisha has joined #openstack-opw | 17:16 | |
| *** ishmank has joined #openstack-opw | 17:17 | |
| *** nisha has quit IRC | 17:22 | |
| *** namratab94 has quit IRC | 17:23 | |
| *** joyce_ has joined #openstack-opw | 17:25 | |
| *** akanksha_ has quit IRC | 18:28 | |
| *** GB21 has joined #openstack-opw | 18:36 | |
| *** GB21_ has quit IRC | 18:38 | |
| *** ShrutiJ has joined #openstack-opw | 18:42 | |
| *** ishmank has quit IRC | 18:43 | |
| *** vkmc sets mode: -o vkmc | 19:34 | |
| *** joyce_ has quit IRC | 19:45 | |
| *** GB21 has quit IRC | 20:01 | |
| *** pt_15 has quit IRC | 20:03 | |
| *** sonali5 has quit IRC | 20:07 | |
| *** Eva-intern has quit IRC | 20:09 | |
| *** Eva-intern has joined #openstack-opw | 20:12 | |
| *** ShrutiJ has quit IRC | 21:03 | |
| *** rakhi has joined #openstack-opw | 21:15 | |
| *** lblanchard has joined #openstack-opw | 21:15 | |
| *** rakhi has quit IRC | 21:17 | |
| *** himanshichhabra has joined #openstack-opw | 21:25 | |
| *** itisha has quit IRC | 21:43 | |
| *** lblanchard has quit IRC | 22:08 | |
| *** himanshichhabra has quit IRC | 22:10 | |
| *** aysyd has joined #openstack-opw | 22:16 | |
| *** akanksha_ has joined #openstack-opw | 22:19 | |
| *** aysyd has quit IRC | 22:32 | |
| *** Eva-intern has quit IRC | 23:01 | |
| *** itisha has joined #openstack-opw | 23:31 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!